https://github.com/wbstack/api/pull/122

went through the list of repos again. I created a PR for those who don't have phpcs as part of composer test

@thiemowmde
thank you for the detailed info. I will go through the repos again

PR for the one repo that is not running code sinffer in composer test can be found here

@Addshore I only found one repo that doesn't run phpcs as part of composer test.
maybe we need to update the doku

wmde/Time has runs phpcs as part of composer test
as can be seen here

this repository already runs phpcs as part of composer test

PR link: https://github.com/wmde/lib-version-check/pull/5

yes, it does have a border for me. (on my local machine, It works just fine on both FF and chrome)
on toolforge, I can't even focus on it with keyboard.

Will be merged once everything else in done

I can't recreate this issue on FF and chrome. (with keyboard navigation)
does the issue happen on the same browsers as well ?

@amy_rc sorry for the late reply.
it was deployed on toolforge but i found there was a problem with it.

awesome!
I'll merge it

@Charlie_WMDE yes, its worked on a different branch. this one is only about that trash can icon.

The PR has been approved. If you can, can you take a look at it and see if you approve ? (i will merge it after that)

can be tested here https://604f3f6d294def25e536b0b8--clicky-sparqly.netlify.app/

PR can be found here

PR can be found here

@Ladsgroup the DS ticket is merged now , FYI

A mixin would be simpler to implement. but we don't have a way of documenting that in the storybook.
so I'd go with a component approach

this PR has to be merged and released first, before starting this ticket

PR: https://github.com/wmde/wikit/pull/386

https://119bc6d25deb9bf2eb5d77a16ade033ac6931053--wmde-wikit.netlify.app/?path=/story/vue_popover--all

@Charlie_WMDE