Am I on the right track here? When Site.page_restrictions() is called the first time,

if not hasattr(page,"_protection"):

will return true so it calls

self.loadpageinfo(page)

Now when Site.page_restrictions() is called after Site.protect() ,

if not hasattr(page,"_protection"):

returns false since it already has the "_protection" attribute from the previous call and so, the page info is not loaded and the assert fails.
So we have to change this such that when Site.protect() is called, it either clears the page info for that page or updates it by calling loadpageinfo()

Will adding " raise NoPage(page)" in protect() be enough to fix this?

We can extend the try except block here : https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/textlib.py#L612 to except "pywikibot.exceptions.InvalidTitle". What exactly should happen for links such as [[{{2001}}]] ?

I have already set up the build. Could you please give me the details of what has to be done to fix this bug? Thanks !

Hi I would like to work on this bug. This is my first bug. Can you give more details as to how I can fix this?

Hi I'd like to work on this bug. Where does the code for this lie in?

Hi I'd like to work on this bug. How do I begin? Thanks.

Hi I'd like to work on this project. Could you please give some pointers about the project? Thanks

I had already started fixing this bug but i guess it has been fixed by someone else :/

In T50853#939625, @Parent5446 wrote:

In T50853#939540, @blackops0057 wrote:

Ok I read the makelist() function, I did not see any NULL in an IN list. I'm probably missing something?

Nope. That's actually the point!

Here's the idea: right now, i.e., the current functionality, if makeList() sees something that looks like the following:

$db->makeList( array( 'column' => array( 'value1', 'value2', null ) ) );

It doesn't treat null as special, which is a mistake. As noted in the bug report, it produces the SQL output column IN ('value1','value2', NULL). This is wrong, and will not act as expected. The MySQL manual notes that you should "never mix quoted and unquoted values" for reasons having to do with comparison rules. I am not sure whether the aforementioned SQL is incorrect because of this or because of special NULL semantics, but nonetheless it is wrong.

What we actually want is column IN ('value1', 'value2') OR column IS NULL. This is particularly interesting because of certain optimizations with IS NULL. In other words, we want makeList() to treat null as special.

Ok so basically we have to check if NULL is an element of the array 'a' and if a NULL is indeed present we must have a seperate case so that it removes the NULL from the IN output and makes it an OR output.

In T50853#939493, @Parent5446 wrote:

Fixing this bug involves changing the function DatabaseBase::makeList(), which resides in includes/db/Database.php.

Hi I'd like to work on this bug! How do i begin??

Hi I'd like to work on this bug. First time here. I have built the source code for core. How do i fix this bug?

In T71928#936748, @Mattflaschen wrote:

In T71928#936602, @blackops0057 wrote:

HI I'd like to work on this bug. I'm a beginner. How do i begin fixing it? I have the source code ready

Do you have Flow set up to run locally yet? If not, try MediaWiki-Vagrant.

Also, you should join our IRC channel, #wikimedia-collaboration on Freenode (IRC web interface), if possible.

HI I'd like to work on this bug. I'm a beginner. How do i begin fixing it? I have the source code ready

What are the steps to reproduce this?

Hi. I'm a beginner here and i was wondering if this bug was still open to take, Thanks