- User Since
- Nov 17 2021, 11:03 AM (80 w, 6 d)
- LDAP User
- MediaWiki User
- BMartinezCalvo (WMF) [ Global Accounts ]
@AnneT I'm checking the Field last patch and it seems there is an error to fix with the error state. The helper text should also reflect the error state so it should be content-error color. There was an error in the spec so I've updated it. Could we also update it in the demo? These are the styles we should use in the error. Thank you!
@AnneT I've flagged some important components in which we should also include the large size to unify with the Button large, including ToggleButton (that is also a button) and ButtonGroup or ToggleButtonGroup.
Design sign-off done. Adding some things we should fix:
Mon, Jun 5
@AnneT as defined in the Figma spec, large button should use 16px instead (in the Codex demo we are using 12px). Should we reopen this task to fix it?
As decided in our DST planning, I'm resolving this task since it seems we don't need to do anything more here. We will open a new task if something new is needed.
Fri, Jun 2
Thu, Jun 1
@CCiufo-WMF as commented during our last 1on1, I'm creating this task to complete the design explorations an I'm moving it to Up-Next so I can work on it in the next sprint.
Wed, May 31
The open questions described in this task have been solved during our last Eng/Design sync and the Label component's spec sheet has been completed so the task is Ready for development.
I've included the component's documentation in the task description explaining how we could represent the accordion in the configurable demo and other demos.
@AnneT one thing to keep in mind is that the separation between label and ToggleSwitch should be 16px @spacing-100 while in the current Codex demo is 6px. We should fix it.
Mon, May 29
Moving this task to In Design to define the spec and explore the open questions to solve.
Since the current #d33 is not working on #F8F9FA and #EAECF0, I've included some possible solutions in the task description. Sharing them also here:
Fri, May 26
I've redesigned the userTemporary icon to be the same size as the userAvatar. Also updated the icon in the Figma library and published it.
Moving to In Design to resize the icon shape to the right size.
There is one open question to solve in the task before implementing the Image component: Do we want an option to provide a specific px size in the image? (use case from VE image settings)
During the last Eng/Design sync we decided that aspect ratios will not be defined as tokens but they will be included in the Image component as component's property. So I've created the Figma spec sheet accordingly with this and adding the following:
Thu, May 25
During the last Eng/Design sync we take the decision of removing the fixedHeight prop. We will only have an autosize prop. The grabber will appear when autosize=false, and will not appear when autosize=true.
Wed, May 24
The text mixings should be created in code in some moment, but at the moment just the Figma text styles combine the text tokens to create the Figma text styles. So I've included the design tokens used on each Figma text style mixing (font-size, line-height, font-family and font-weight) within the text style description so developers can read them when inspecting.