- User-brennen is my personal workboard
- brennen-scratchpad is an Etherpad for miscellaneous notes
- I work on the Wikimedia Release Engineering Team
- Release-Engineering-Team is our team workboard
- RelEngTeam-Weekly (etherpad)
- Projects I work on:
User Details
User Details
- User Since
- Feb 3 2019, 8:29 PM (366 w, 3 d)
- Roles
- Administrator
- Availability
- Available
- IRC Nick
- brennen
- LDAP User
- Brennen Bearnes
- MediaWiki User
- BBearnes (WMF) [ Global Accounts ]
Yesterday
Yesterday
brennen closed T416963: GitLab Private Repository Request for: Movement Insights trend monitoring as Resolved.
Note that access is inherited from the movement-insights group, and includes the list of usernames here. If it needs to be more restricted, the project will need to live elsewhere.
Mon, Feb 9
Mon, Feb 9
I set the expiry for this token to "never".
brennen added a comment to T416912: Replication to GitHub seems to have stalled.
GitHub appears to have quite a few ongoing issues.
brennen moved T416912: Replication to GitHub seems to have stalled from Backlog to Radar on the User-brennen board.
brennen added projects to T416912: Replication to GitHub seems to have stalled: Release-Engineering-Team, User-brennen.
brennen moved T416614: Codesearch down/unreachable (2026-02-05) from Backlog to Radar on the User-brennen board.
brennen added a comment to T416614: Codesearch down/unreachable (2026-02-05).
Can you share your ldap username? I'll add you in horizon.
Fri, Feb 6
Fri, Feb 6
Thanks Yug - added Gillux to Trusted-Contributors, GitLab account should now be approved.
Thu, Feb 5
Thu, Feb 5
Currently stable on all wikis.
brennen renamed T416640: ZObjectUtils: TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, array given from TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, array given to ZObjectUtils: TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, array given.
brennen merged T415906: TypeError: Wikimedia\Parsoid\Utils\DOMCompat::getPreviousElementSibling(): Argument #1 ($node) must be of type DOMElement|DOMCharacterData|Wikimedia\Parsoid\DOM\Element|Wikimedia\Parsoid\DOM\CharacterData, null given into T416630: TypeError: Wikimedia\Parsoid\Core\DOMCompat::getPreviousElementSibling(): Argument #1 ($node) must be of type DOMElement|DOMCharacterData|Wikimedia\Parsoid\DOM\Element|Wikimedia\Parsoid\DOM\CharacterData, null given.
brennen merged task T415906: TypeError: Wikimedia\Parsoid\Utils\DOMCompat::getPreviousElementSibling(): Argument #1 ($node) must be of type DOMElement|DOMCharacterData|Wikimedia\Parsoid\DOM\Element|Wikimedia\Parsoid\DOM\CharacterData, null given into T416630: TypeError: Wikimedia\Parsoid\Core\DOMCompat::getPreviousElementSibling(): Argument #1 ($node) must be of type DOMElement|DOMCharacterData|Wikimedia\Parsoid\DOM\Element|Wikimedia\Parsoid\DOM\CharacterData, null given.
brennen added a comment to T416630: TypeError: Wikimedia\Parsoid\Core\DOMCompat::getPreviousElementSibling(): Argument #1 ($node) must be of type DOMElement|DOMCharacterData|Wikimedia\Parsoid\DOM\Element|Wikimedia\Parsoid\DOM\CharacterData, null given.
Seems to have started quite a bit later than the train rolled to all group2, at 10:36 UTC:
brennen added a comment to T416614: Codesearch down/unreachable (2026-02-05).
My guess is some sort of scraper. I haven't looked into it though.
brennen updated subscribers of T413805: 1.46.0-wmf.14 deployment blockers.
Wed, Feb 4
Wed, Feb 4
Tue, Feb 3
Tue, Feb 3
brennen added a comment to T415877: PCS/summary returns errors for beta requests.
Am I correct in thinking this should no longer block with https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1234927 merged?
Mon, Feb 2
Mon, Feb 2
brennen closed T416248: GitLab Private Repository Request for: Data Engineering Bot Detection Pipeline as Resolved.
Seems like it fits with existing stuff.
Invited kevinpayravi as owner.
Fri, Jan 30
Fri, Jan 30
Thu, Jan 29
Thu, Jan 29
brennen moved T415903: Create Phabricator CustomField for GitHub PRs from Backlog to Radar on the User-brennen board.
brennen added projects to T415903: Create Phabricator CustomField for GitHub PRs: Release-Engineering-Team, User-brennen.
I understand the incentives at work. On a personal level and thinking about team load, I want to discourage use of GitHub, but I understand that work is done there.
brennen moved T415342: MediaWiki\Extension\AbuseFilter\CentralDBNotAvailableException: $wgAbuseFilterCentralDB is not configured from Untriaged to Jan–Mar 2026 on the Wikimedia-production-error board.
I see two of these in logs, total. Guessing a one-off artifact of some other breakage.
brennen moved T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given from Untriaged to Jan–Mar 2026 on the Wikimedia-production-error board.
brennen moved T415906: TypeError: Wikimedia\Parsoid\Utils\DOMCompat::getPreviousElementSibling(): Argument #1 ($node) must be of type DOMElement|DOMCharacterData|Wikimedia\Parsoid\DOM\Element|Wikimedia\Parsoid\DOM\CharacterData, null given from Untriaged to Jan–Mar 2026 on the Wikimedia-production-error board.
brennen updated the task description for T415905: Wikibase\Lexeme\Domain\Model\Exceptions\ConflictException: At least two forms with the same ID were provided: [id].
brennen moved T415257: PHP Warning: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$html from Backlog to Logs/Train on the User-brennen board.
brennen added a comment to T415257: PHP Warning: Undefined property: Wikimedia\Parsoid\NodeData\DataParsoid::$html.
Noted again in 1.46.0-wmf.13 (T413804).
brennen added a comment to T415888: PHP Warning: Undefined property: Wikimedia\Parsoid\NodeData\NodeData::$mw.
Note to self: There's a patch here in case this crops up when 1.46.0-wmf.13 (T413804) rolls to all wikis.
Wed, Jan 28
Wed, Jan 28
brennen added a comment to T413804: 1.46.0-wmf.13 deployment blockers.
End-of-workday summary: T415725 resolved itself due to cache TTL, train's now looking stable on group1.
brennen removed a parent task for T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given: T413804: 1.46.0-wmf.13 deployment blockers.
brennen removed a subtask for T413804: 1.46.0-wmf.13 deployment blockers: T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given.
brennen lowered the priority of T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given from Unbreak Now! to Needs Triage.
Couple of other things:
brennen added a comment to T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given.
Unfortunately, scap sync-world --force-l10n-update had no obvious effect.
brennen added a comment to T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given.
Ok, writing out the train-deployer-asks-stupid-questions I currently have about this.
brennen added a comment to T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given.
These are now also showing up at a
lowerroughly similar volume for testwiki on .13.
brennen added a comment to T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given.
These are now also showing up at a lower volume for testwiki on .13.
brennen added a comment to T415619: Creation of dynamic property MediaWiki\Language\Dependency\FileDependency::$filename is deprecated {"exception":"[object] (ErrorException(code: 0).
Probably related
Tue, Jan 27
Tue, Jan 27
brennen added a subtask for T415619: Creation of dynamic property MediaWiki\Language\Dependency\FileDependency::$filename is deprecated {"exception":"[object] (ErrorException(code: 0): T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given.
brennen added a parent task for T415725: TypeError: MediaWiki\Extension\Translate\MessageGroupProcessing\CachedMessageGroupFactoryLoader::MediaWiki\Extension\Translate\MessageGroupProcessing\{closure}(): Argument #1 ($value) must be of type DependencyWrapper, __PHP_Incomplete_Class given: T415619: Creation of dynamic property MediaWiki\Language\Dependency\FileDependency::$filename is deprecated {"exception":"[object] (ErrorException(code: 0).
brennen added a comment to T413804: 1.46.0-wmf.13 deployment blockers.
Current status:
brennen added a comment to T415619: Creation of dynamic property MediaWiki\Language\Dependency\FileDependency::$filename is deprecated {"exception":"[object] (ErrorException(code: 0).
After some discussion in #wikimedia-operations and looking at error rates, I'm going to see what this looks like on group0.
brennen added a comment to T415619: Creation of dynamic property MediaWiki\Language\Dependency\FileDependency::$filename is deprecated {"exception":"[object] (ErrorException(code: 0).
After some discussion in #wikimedia-operations and looking at error rates, I'm going to see what this looks like on group0.
brennen added a comment to T415619: Creation of dynamic property MediaWiki\Language\Dependency\FileDependency::$filename is deprecated {"exception":"[object] (ErrorException(code: 0).
I do note similar errors on testwikis. About 700 of these (also some for $name):
brennen lowered the priority of T415580: Revise Tone instrumentation for a saved edit is missing important custom parameters from Unbreak Now! to High.
brennen added a comment to T415580: Revise Tone instrumentation for a saved edit is missing important custom parameters.
Ok, thanks! Going ahead with backport now.
brennen added a comment to T415580: Revise Tone instrumentation for a saved edit is missing important custom parameters.
So I see you already created the backport, is it possible to just move that forward?
brennen added a comment to T415580: Revise Tone instrumentation for a saved edit is missing important custom parameters.
@Michael Would a revert of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1233223 be the easier path to unblocking the train here?
Mon, Jan 26
Mon, Jan 26
brennen moved T413804: 1.46.0-wmf.13 deployment blockers from Backlog to Doing/Involved on the User-brennen board.
Thu, Jan 15
Thu, Jan 15
Tue, Jan 13
Tue, Jan 13
Jan 9 2026
Jan 9 2026
brennen added a comment to T403215: Diffusion code view: Per-file change info is slow to load despite caching (diffusion.lastmodifiedquery).
Yeah, I think the upstream is correct, although that conditional is confusing to read. I'll test. I do still think something odd is going on here.
Jan 7 2026
Jan 7 2026
brennen added a comment to T413992: Mr. Widget (GitLabPatchesCustomField) is getting rate limited by GitLab searches.
Looking closer, last of these errors thrown at 2026-01-04 04:34:59, but there's also:
brennen changed the status of T413992: Mr. Widget (GitLabPatchesCustomField) is getting rate limited by GitLab searches from Open to In Progress.
brennen moved T413992: Mr. Widget (GitLabPatchesCustomField) is getting rate limited by GitLab searches from To Triage to Misc on the Phabricator board.
Jan 5 2026
Jan 5 2026
brennen moved T413832: Deploy Phabricator/Phorge 2026-01-06 from Backlog to Doing/Involved on the User-brennen board.