Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (275 w, 1 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Fri, Jan 17

brion added a comment to T227074: Transcoding fails for large videos for QHD and UHD resolution.

I suspect it's the file size limit yes -- ffmpeg seems to be exiting with SIGXFSZ (signal 25, exit code 153) which means 'exceeded file size'. This is probably not the file system limit, but the resource limit applied to the transcode process? However transcodes going over 4 GB may have trouble being stored anyway. :(

Fri, Jan 17, 9:21 PM · TimedMediaHandler-Transcode
brion closed T150066: Opaque error creating webm transcodes at low frame rates, a subtask of T157028: Many transcodes still fail, as Resolved.
Fri, Jan 17, 9:13 PM · Wikimedia-General-or-Unknown, TimedMediaHandler-Transcode
brion closed T150066: Opaque error creating webm transcodes at low frame rates as Resolved.

Seems to have been resolved in the meantime, probably by using updated ffmpeg on servers.

Fri, Jan 17, 9:13 PM · TimedMediaHandler-Transcode
brion closed T158287: Add option to requeueTranscodes.php to restrict processing to high or low priority queue as Invalid.

Guess this didn't seem that important, closing out.

Fri, Jan 17, 9:10 PM · TimedMediaHandler-Transcode
brion closed T200747: Batch-convert old video files for new VP9/opus format as Resolved.

All this ran, and later a bunch re-ran, some time ago. Closing out.

Fri, Jan 17, 9:08 PM · TimedMediaHandler-Transcode
brion closed T133500: Choose a way to improve playback of very small thumbnails as Resolved.

We chose to reimplement with oojs ui and have implemented.

Fri, Jan 17, 8:58 PM · VideoJS player
brion closed T226314: Video.js controls inaccessible in "packed-hover" gallery mode as Resolved.

New click-to-load mode behaves more like the old mode, and seems ok here. Closing out.

Fri, Jan 17, 8:56 PM · VideoJS player, Multimedia, MediaWiki-Gallery
brion closed T226371: Beta player slow at loading many videos in Firefox as Resolved.

This seems to be largely dealt with the new load-on-click mode, I'm going to close it out.

Fri, Jan 17, 8:55 PM · VideoJS player, WMSE-Bug-Reporting-and-Translation-2019, Performance Issue

Thu, Jan 16

brion claimed T243018: Pages in TimedText namespace have wgRevisionId set to 0.

Probably a side-effect of how the subtitle pages are specially rendered...

Thu, Jan 16, 9:14 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), TimedMediaHandler-TimedText
brion claimed T242966: PHP Warning: XMLReader::open(): Memory allocation failed : escaping URI value.

This seems to be due to a corruption problem in Photoshop or some other editing tool that produces a huge amount of extra junk data in the XMP metadata. You can find reports of this problem on forums like here: https://feedback.photoshop.com/photoshop_family/topics/corrupt-ancestors-tag-in-xmp-causing-giant-file-sizes-in-photoshop

Thu, Jan 16, 5:29 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MediaWiki-File-management, Commons, Wikimedia-production-error

Wed, Jan 15

brion added a comment to T191805: Allow Mediawiki to store file size greater than 32 bits.

The fields are currently defined in tables.sql as int unsigned which is a 32-bit type with a range from 0 to 2^32 - 1 (one byte shy of 4 GiB). To record sizes of files of 4 GiB or higher, redefining them as bigint unsigned, a 64-bit type, would be required.

Wed, Jan 15, 1:45 AM · MediaWiki-File-management, Commons, Multimedia

Tue, Jan 14

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Latest rev of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/553442 includes a quick-fix for that: an inline transform property is added which adds the playsinline attribute and a mw-tmh-inline class which has the on-load transforms set up video.js for that player instead of turning it into a popup player trigger. This is then forced on for the embedded-iframe view.

Tue, Jan 14, 9:56 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

(Well, not exactly broken, but ... kind of weird. ;) It forces the popup to run inside the iframe, which adds a title bar even at small sizes.)

Tue, Jan 14, 4:30 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Acknowledged, ?embedplayer=yes mode is indeed broken with those changes. ;_; I'll fix that shortly.

Tue, Jan 14, 4:27 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Mon, Jan 13

brion added a comment to T209437: Migrate primary Wikimedia video format from VP9 to AV1.

Native CPU-run VP9 seems pretty ok through 720p on my lower-spec machines, but YMMV. :) AV1 is much more CPU-intensive and I definitely don't recommend switching to it wholesale yet, especially at high resolutions.

Mon, Jan 13, 5:35 PM · TimedMediaHandler-Transcode

Mon, Jan 6

brion closed T240488: Network issues reaching phabricator on IPv6 (Comcast/Portland OR) as Resolved.

Definitely saw it on https, on phab. The ipv6 timeout behavior makes it hard to see reliably so not sure if it was hitting other sites consistently but the packet loss on ping to load balancer was suspicious.

Mon, Jan 6, 9:23 PM · netops, Operations

Dec 20 2019

Dzahn awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Orange Medal token.
Dec 20 2019, 3:27 AM · Office-IT

Dec 19 2019

brion added a comment to T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter.

Thanks all! I'll try the email queue next time something crops up for future reference. :)

Dec 19 2019, 8:50 PM · Office-IT
Niharika awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Cookie token.
Dec 19 2019, 5:31 PM · Office-IT
Elitre awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Burninate token.
Dec 19 2019, 5:31 PM · Office-IT
ArielGlenn awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a 100 token.
Dec 19 2019, 5:30 PM · Office-IT
greg awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Y So Serious token.
Dec 19 2019, 5:29 PM · Office-IT
jrbs awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Manufacturing Defect? token.
Dec 19 2019, 5:28 PM · Office-IT
Mholloway awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a The World Burns token.
Dec 19 2019, 5:28 PM · Office-IT
brion created T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter.
Dec 19 2019, 5:27 PM · Office-IT

Dec 17 2019

brion added a comment to T240837: MP4 files are not listed as videos on special page.

Could remove it yeah Special:MediaStatistics does that top section better. Maybe stick in a link for good measure as a related info? I think Special:TimedMediaHandler should concentrate on the transcode status info (and maybe get renamed to match).

Dec 17 2019, 9:35 PM · User-TheDJ, TimedMediaHandler

Dec 11 2019

brion added a comment to T240488: Network issues reaching phabricator on IPv6 (Comcast/Portland OR).

sudo mtr -z -s 1000 -T -P 443 phabricator.wikimedia.org gives similar results:

Dec 11 2019, 9:51 PM · netops, Operations
brion created T240488: Network issues reaching phabricator on IPv6 (Comcast/Portland OR).
Dec 11 2019, 6:45 PM · netops, Operations

Dec 10 2019

brion added a comment to T240368: Transcoding job is reported as failed before it's completed.

Looking... it looks like on success transcode_error is cleared but transcode_time_error is not. However it shouldn't be getting set in the first place unless something's awry...

Dec 10 2019, 7:59 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Patch-For-Review, TimedMediaHandler-Transcode

Dec 5 2019

brion closed T239831: VP9-enabled ffmpeg doesn't get installed after reimage of mw job runner/video scaler as Resolved.
Dec 5 2019, 9:54 PM · serviceops, Operations
brion added a comment to T239831: VP9-enabled ffmpeg doesn't get installed after reimage of mw job runner/video scaler.

Ok, I'll run:

Dec 5 2019, 4:38 PM · serviceops, Operations
brion added a comment to T239831: VP9-enabled ffmpeg doesn't get installed after reimage of mw job runner/video scaler.

Ideally: fix the installs ASAP :) If can't be done: disable $wgFFmpegVP9RowMT and that should hopefully work if it reverted to a version that groks vp9 but doesn't know the -row-mt option.

Dec 5 2019, 3:25 PM · serviceops, Operations

Nov 27 2019

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

I think the audio player will be a problem. Native players are pretty big and we often have very restrictive spacing. Don’t know a good design either though..

Nov 27 2019, 11:02 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Updated https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/529819/ to use the better minified package. Much smaller JS payload now. :)

Nov 27 2019, 8:33 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion closed T216345: Unrecognized option 'max_muxing_queue_size' as Resolved.

What should be cleaned up?

Nov 27 2019, 8:04 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), TimedMediaHandler-Transcode
brion added a comment to T216345: Unrecognized option 'max_muxing_queue_size'.

Ah, OSs shipping old stuff is always fun. :D No real danger to it, and it's clear enough in the code if we refactor and clean it out later. :)

Nov 27 2019, 2:08 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), TimedMediaHandler-Transcode
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

@TheDJ let's try using it without wgMinimumVideoPlayerSize and drop it back in if we decide the always-transformation is confusing.

Nov 27 2019, 12:02 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Nov 26 2019

brion added a comment to T216345: Unrecognized option 'max_muxing_queue_size'.

I'm a bit reluctant to add explicit support for obsolete versions of ffmpeg, since it'll never get tested and other things that break it are likely to be added. Is there a reason you're running an out of date ffmpeg?

Nov 26 2019, 11:51 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), TimedMediaHandler-Transcode
brion added a comment to T232563: Drop IE6 and IE7 basic compatibility and security support.

@AlexisJazz sorry about any frustration from the on-Commons discussion in January. It took some discussion of our own on Phabricator to decide what to do, both about the incorrect HTML security trigger and about the more general removal of obsolete checks, and communication wasn't and still isn't very consistent. Sometimes you get advice on-wiki that's based on the current general state of things, but the state of things changes -- we have indeed decided that the IE 6/7 content-type-sniffing vulnerability is no longer a serious security consideration, but in January we hadn't decided that yet so you were given advice based on the current state of the world.

Nov 26 2019, 6:22 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MW-1.34-notes, User-notice, TechCom-RFC (TechCom-Approved), MediaWiki-General

Nov 15 2019

brion added a comment to T237942: Video viewer menus may become unusable on mobile.

This is a compat problem with the old player; the new player mode is getting an update and should get merged soonish, and it's fully functional on mobile.

Nov 15 2019, 2:55 PM · Mobile, Kaltura player

Nov 7 2019

brion added a comment to T237688: Raise MW JS requirement to include ES6 Promise (drop IE11, Safari 5-6, and Android 4.1-4.3).

Note that a Promise polyfill can be loaded at the cost of a few kb of compat code, but there's so many other reasons to want to deprecate IE 11 and to move to newer JS versions and most of the other things can't be polyfilled so easily.

Nov 7 2019, 9:14 PM · Patch-For-Review, Browser-Support-Android-Google-Chrome, Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, JavaScript, Browser-Support-Internet-Explorer, Performance-Team

Oct 21 2019

brion added a comment to T235436: Vagrant installation fails.

I have some more diagnostic info on T235934 for what appears to be the same problem (installing mobilefrontend). Workaround is to manually clone extensions/MobileFrontend and re-run vagrant provision.

Oct 21 2019, 5:38 PM · Readers-Web-Backlog (Tracking), MediaWiki-Vagrant, WMSE-Bug-Reporting-and-Translation-2019, MobileFrontend

Oct 18 2019

brion added a comment to T235934: MediaWiki-Vagrant's "mobilefrontend" role fails to install MobileFrontend extension.

Yeah, looks like it's dying in the same place over on that one.

Oct 18 2019, 11:45 PM · Readers-Web-Backlog (Tracking), MobileFrontend, MediaWiki-Vagrant
brion created T235934: MediaWiki-Vagrant's "mobilefrontend" role fails to install MobileFrontend extension.
Oct 18 2019, 11:39 PM · Readers-Web-Backlog (Tracking), MobileFrontend, MediaWiki-Vagrant

Oct 17 2019

MusikAnimal awarded T18691: RFC: Section header "share" link a Love token.
Oct 17 2019, 10:16 PM · User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Oct 15 2019

brion added a comment to T234582: Remove IE 6 & 7 hacks and workarounds from core & extensions.

Change 542715 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Replace IE 4-7 compatible code with standard syntax
https://gerrit.wikimedia.org/r/542715

Oct 15 2019, 9:06 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Technical-Debt, Front-end-Standards-Group, Browser-Support-Internet-Explorer, CSS, MediaWiki-General
Trizek awarded T18691: RFC: Section header "share" link a Like token.
Oct 15 2019, 10:09 AM · User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Oct 10 2019

brion added a comment to T235228: Error undeleting file: "File was missing before deletion".

Sounds like some of that sequence resulted in a conflict that didn't get handled well at the time. Following the error message back to the code symptom, the case is this in LocalFileRestoreBatch.php:

Oct 10 2019, 10:27 PM · MediaWiki-File-management, SRE-swift-storage, Wikimedia-production-error

Oct 2 2019

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Does Video.js release imply enablement on MobileFrontend? If so, we may want to require lazy-loading on click after all. Or keep it desktop-only at first.

Oct 2 2019, 4:59 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Sep 26 2019

brion added a comment to T232354: New vagrant instance not setting password for `admin` user to `vagrant`.

I've updated the documentation at https://www.mediawiki.org/wiki/MediaWiki-Vagrant to link to this bug report and mention that you can manually log in with vagrant ssh and run mwscript maintenance/changePassword.php --user=Admin --password=vagrant to set the initial password.

Sep 26 2019, 6:11 PM · User-zeljkofilipin, Patch-For-Review, MediaWiki-Vagrant

Sep 24 2019

brion closed T136671: Intermittent bandwidth issue to labs proxy (eqiad) from Comcast in Portland OR as Resolved.

Haven't encountered this in a while; Comcast etc may have improved the intermediate routes. Closing out as resolved.

Sep 24 2019, 6:45 PM · Operations, Cloud-Services, netops

Sep 19 2019

brion added a comment to T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.

Looks like the audio wasn't getting initialized at the right time (how did it work on iOS? no clue!) unless mwEmbedSupport has already been loaded.

Sep 19 2019, 8:52 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, Kaltura player
brion updated the task description for T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.
Sep 19 2019, 8:26 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, Kaltura player
brion created T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.
Sep 19 2019, 8:23 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, Kaltura player

Sep 17 2019

Perhelion awarded T106240: Colorable SVG a Yellow Medal token.
Sep 17 2019, 7:59 AM · TechCom-RFC, Wikimedia-SVG-rendering

Sep 11 2019

brion added a comment to T229433: ResourceLoaderWikiModule.php: PHP Notice: Undefined index: .

Looks like in PHP 7.2 the empty string gets interned to a special shared instance (zend_empty_string)... It's possible something's corrupting zend_empty_string, either its contents or its hash (h) field. If we can get a core dump it should be possible to inspect the symbol...

Sep 11 2019, 9:15 PM · Performance-Team, Wikimedia-production-error, MediaWiki-ResourceLoader

Aug 28 2019

brion renamed T228342: Define criteria for setting explicit PHP support target for MediaWiki from Set explicit PHP 7.2 support target for MediaWiki to Define criteria for setting setting explicit PHP support target for MediaWiki.
Aug 28 2019, 8:36 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
brion updated the task description for T228342: Define criteria for setting explicit PHP support target for MediaWiki.
Aug 28 2019, 8:34 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
brion renamed T228342: Define criteria for setting explicit PHP support target for MediaWiki from Set explicit PHP support target for MediaWiki to Set explicit PHP 7.2 support target for MediaWiki.
Aug 28 2019, 8:32 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support

Aug 21 2019

brion added a comment to T230661: TimedMediaHandler audio captions are out of sync in Firefox (and possibly other browsers).

I'm still not sure I can reliably tell the difference but I trust you. :) Titles being sometimes late by random amounts up to 250ms seems like it would make sense given the poor latency guarantees on the timeupdate event, so I'm not sure there's much we can do directly here...

Aug 21 2019, 8:01 PM · Kaltura player, TimedMediaHandler-TimedText

Aug 20 2019

brion added a comment to T230661: TimedMediaHandler audio captions are out of sync in Firefox (and possibly other browsers).

Could this be latency from the timeupdate event? It can trigger with a wait as long as 250ms between events per spec.

Aug 20 2019, 11:27 PM · Kaltura player, TimedMediaHandler-TimedText

Aug 14 2019

brion added a comment to T230505: Parseroutput cache issue with videojs.

Note the parser cache key is not available to the hook. Fun!

Aug 14 2019, 6:50 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), TimedMediaHandler
brion added a comment to T230505: Parseroutput cache issue with videojs.

I think default mode is checked because there's a separate pcache suffix for folks using the beta-mode -- this is targeted at clearing the non-beta-mode entries after a site-config switch.

Aug 14 2019, 6:31 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), TimedMediaHandler
brion added a comment to T188831: Some thumbnail images delivered with wrong application/x-www-form-urlencoded mime-type.

The only POSTs I see in there are in setContainerAccess, addMissingHashMetadata, and doDescribeInternal, which all update existing files. Could be there's a hole in the logic of one of them that's dropping Content-Type, or that some files were missing it to begin with but it was being filled in on high-level fetches, or something, so they worked until something updated the data?

Aug 14 2019, 6:13 PM · Traffic, Operations, Multimedia, Thumbor, Commons, MediaWiki-File-management, SRE-swift-storage
brion added a comment to T188831: Some thumbnail images delivered with wrong application/x-www-form-urlencoded mime-type.

Hmm, I notice this in SwiftFileBackend.php:

Aug 14 2019, 6:08 PM · Traffic, Operations, Multimedia, Thumbor, Commons, MediaWiki-File-management, SRE-swift-storage
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Great, I'll tidy up this patch in a bit (once I get the subtitle lazy-loading patched back in) and we'll worry about lazy-loading later.

Aug 14 2019, 2:51 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Since AFAIK extensions are meant to use wikipage.content for setup, I think any area where wikitext features are expected to work _should_ trigger the hook... A common class name would still require knowing when to run setup, and potentially one might want to update the indicator (what happens during edit preview?). So we either have to add a second hook that does the same thing as wikipage.content but is explicitly scoped to non-primary areas, or ...? Hmm, bears further thought.

Aug 14 2019, 2:50 PM · MediaWiki-Parser, TimedMediaHandler
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

For a video that triggers player setup but hasn't actually been played, in Chrome/Firefox where no ogv.js shim is needed, they seem to weigh in (as reported from mw.inspect, so uncompressed) at around 293 KiB for MwEmbed+jquery.ui and 288 KiB for video.js with the core.min.js variant.

Aug 14 2019, 2:22 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Or... perhaps MW should run wikipage.content against the contents of <indicator> as well?

Aug 14 2019, 1:43 PM · MediaWiki-Parser, TimedMediaHandler
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Looking at the TimedMediaHandler JS, it uses the wikipage.content hook which passes a jQuery object holding the content area in which to process elements. Anything outside the content area is not processed.

Aug 14 2019, 1:15 PM · MediaWiki-Parser, TimedMediaHandler
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Can you create a copy of the template that uses the form that fails? I'm uncertain what to modify from the description.

Aug 14 2019, 1:07 PM · MediaWiki-Parser, TimedMediaHandler

Aug 12 2019

brion added a comment to T230181: Precision of floating-point video length is inconsistent between HHVM and PHP 7.2.

Would you want to trim in the base handling of the metadata, or in the output API serialization specifically? Might be best to do it all around if we're going to apply such rounding in ways that are machine-readable.

Aug 12 2019, 7:57 PM · TimedMediaHandler
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Patch switches to the core distribution (no http-streaming component) and the more aggressively pre-minified version. Not quite complete, as this means we can't patch in the text track lazy-loading on top as easily.

Aug 12 2019, 6:32 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Aug 9 2019

brion added a comment to T230158: OggHandler: Undefined index: 1.

This seems to be during a chunked upload of an Ogg audio or video file. Any chance we can get the original file chunks?

Aug 9 2019, 7:11 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Commons, TimedMediaHandler, Wikimedia-production-error
brion added a comment to T230181: Precision of floating-point video length is inconsistent between HHVM and PHP 7.2.

I can repro the inconsistency on both domains. I think it's a HHVM vs Zend PHP difference; the shorter serialization is served from HHVM 3.18.6 while the longer one is served from PHP 7.2.16.

Aug 9 2019, 7:04 PM · TimedMediaHandler

Jul 29 2019

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

We can probably reduce the size for now by using the video.js core distribution (without the http-streaming component which we don't use yet) and using more aggressive minification (rather than using our own minifier, which doesn't shorted variable names and such).

Jul 29 2019, 9:46 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Jul 26 2019

Quiddity awarded T18691: RFC: Section header "share" link a Love token.
Jul 26 2019, 12:25 AM · User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jul 13 2019

brion closed T227850: Transcode of a video gets turned upside down as Resolved.

Confirmed this fixes the transcodes; resolving.

Jul 13 2019, 6:40 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion claimed T227850: Transcode of a video gets turned upside down.

Fixing the .ogv file by setting the 'ROTATE=180' to 'ROTATE=0':

Jul 13 2019, 6:34 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

I suspect that the 'rotate' annotation in the comments is not actually handled by Firefox, VLC, or ogv.js -- certainly I never wrote code in ogv.js to handle it -- and may be a leftover from the MP4/3gpp original file the .ogv was sourced from.

Jul 13 2019, 6:17 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

This may be a problem that's been since fixed in upstream ffmpeg...?

Jul 13 2019, 6:16 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

For me, the original plays upside-down in Chrome, right-side-up in Firefox, VLC, and ogv.js. So this ain't handled quite universally I suppose. ;) I'll take a peek.

Jul 13 2019, 5:57 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video

Jul 12 2019

Ladsgroup awarded T167246: Refactor "user" & "user_text" fields into "actor" reference table a Love token.
Jul 12 2019, 4:19 PM · CPT Initiatives (Revision Storage Schema Improvements), Schema-change, MediaWiki-General, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic

Jul 1 2019

brion added a project to T226797: Login state not propagated across domains in Safari: Browser-Support-Apple-Safari.
Jul 1 2019, 5:10 PM · Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth

Jun 29 2019

Lofhi awarded T100106: Replace Kaltura player with Video.js a Like token.
Jun 29 2019, 11:35 AM · VideoJS player, Performance-Team (Radar), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, Wikimedia-Video, Wikimedia-Hackathon-2015

Jun 28 2019

brion created T226797: Login state not propagated across domains in Safari.
Jun 28 2019, 4:42 AM · Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth

Jun 27 2019

brion added a comment to T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object.

Note a deployment typo caused this fix to not get deployed in fact. Whoops! Roan's fixing it now.

Jun 27 2019, 11:24 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion closed T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object as Resolved.

Fix deployed. Should no longer cause fatal errors, but should log the transcoder output into the transcode table so we can review it later for suspicious commonalities.

Jun 27 2019, 9:53 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

Ok Reedy started this a while ago under T226713, so no need to re-run it a second time. It's probably the cause of seeing multiple fatals over on T226748, since all failure cases would come in a relatively short time. :D

Jun 27 2019, 9:47 PM · TimedMediaHandler-Transcode, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score
brion added a comment to T226713: Run cleanupTranscodes.php for current midi files.

Ah great, that'll do the job.

Jun 27 2019, 9:45 PM · Wikimedia-Site-requests, TimedMediaHandler
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

I have this ready to run on mwmaint1002 but want to wait until the fix for the fatal error in T226748 is deployed so I don't spam the error logs.

Jun 27 2019, 9:30 PM · TimedMediaHandler-Transcode, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score
brion claimed T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object.
Jun 27 2019, 9:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

cleanupTranscodes.php should be able to do this I believe, I'll test offline later.

Jun 27 2019, 12:28 PM · TimedMediaHandler-Transcode, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score

Jun 26 2019

brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

(main difference from previous behavior is that in practice most videos got the image with popup link where now they get a video directly)

Jun 26 2019, 10:46 PM · VideoJS player, Browser-Support-Internet-Explorer
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Ehhh, it's not hard to add a fallback image link that points to the file page. But I wouldn't necessarily block on it if it's not done soon.

Jun 26 2019, 10:45 PM · VideoJS player, Browser-Support-Internet-Explorer

Jun 24 2019

brion added a comment to T217085: Enable TimedMediaHandler video player in articles on mobile (instead of hyperlink to unplayable video).

Note that with the "New video player" beta feature enabled, this can be tested in production -- just make sure you're logged in in the mobile browser and it will pick up the preference.

Jun 24 2019, 5:34 PM · VideoJS player, Readers-Web-Backlog (Tracking), Mobile
brion claimed T226371: Beta player slow at loading many videos in Firefox.

Probably should adjust the preload setting; ISTR some related issue in past. Will test further once no longer encountering unrelated server errors.

Jun 24 2019, 10:27 AM · VideoJS player, WMSE-Bug-Reporting-and-Translation-2019, Performance Issue

Jun 23 2019

brion added a comment to T226311: Full size videos displayed as small videos in gallery.

Yeah, looks like we only read 1024 header bytes and it appears later in both those files, around 4000+ bytes in.

Jun 23 2019, 6:39 PM · Patch-For-Review, MediaWiki-File-management, MediaWiki-Gallery, Multimedia, Commons
brion added a comment to T203413: a small audio ogg file does not get played in full.

Confirmed that it's resolved with the video,js player frontend ("New video player" in beta features preferences)

Jun 23 2019, 6:31 PM · Kaltura player

Jun 22 2019

brion claimed T226311: Full size videos displayed as small videos in gallery.

I was able to reproduce this locally using the files via InstantCommons, and it looks like the root problem is that some of the files are misidentifed as audio, causing the packed-gallery code to use a small icon width instead of a large width constraint here:

Jun 22 2019, 5:57 PM · Patch-For-Review, MediaWiki-File-management, MediaWiki-Gallery, Multimedia, Commons