Wed, May 26
De-claiming this to put in the backlog, will do a major update to the transcode handling after fixing frontend issues.
Re-claiming this, doing another cleanup pass on ogv.js and TMH based on the partial but incomplete improvements in Safari.
Temporary de-assign & re-assign, putting this back on the table on a limited schedule. :)
De-assigning; not actively working on this.
Closing this out; IE 11 is no longer supported, and supported Safari versions run the WebAssembly build which is more consistent now.
May 6 2021
We can provide a simplified API for reusing this later, but now we have the secret keys unlocked. ;)
Mar 15 2021
Ah, looks Safari specific? I can confirm it in Safari. Anyway we can get around this because the decodeURIComponent call is not needed in the first place. :D
Note the error does not occur in production on that page for me in Chrome.
Mar 4 2021
Mar 1 2021
Feb 22 2021
While VP9 support is slowly creeping into WebKit via WebRTC there's still no firm sign yet they'll support it in <video> or through iOS's native controls. Based on my past research, I recommend using MobileVLCKit if we want to go the route of WebM VP9+opus playback on iOS:
Jan 28 2021
Dec 1 2020
Oct 20 2020
Yeah I'm in firefox so that explains the exception diff :)
Yep, patch seems to fix it and the new version is nice and clean. :) +2!
So if I manipulate the volume slider instead of the audio position slider, I can repro an error "Uncaught TypeError: closestHandle is undefined" but that's a different error than was reported?
Are you dragging the volume slider instead of the audio position slider? That might be doing it...
I can't reproduce this on current git master following the directions in the original post. Can you provide an exact repro?
Sorry, hadn't seen this. Sure, as far as I know it's unused for years.
Sep 24 2020
Aug 3 2020
Worth double-checking yeah, these should be the same iirc. I'm giving it a low priority/severity because it seems relatively harmless but it should still get gotten to. :)
Note that the current audio placeholder was selected to have a similar shape and size to existing inline players to minimize disruption to article layouts.
I think I lost my work patch for the subtitles >:( Will have to recreate it shortly
I might actually prefer to delay until the remember-subtitles-setting fix is merged. I'm honestly not sure what the situation with Score is at this point, but if playback is broken that might be good to fix as well.
Jul 29 2020
Jul 27 2020
Jul 16 2020
merged and done.
Jul 14 2020
Hmm, looks like the whole test case is pretty broken:
- assumes jobs are stored in the job table and looks there for available jobs?
- calls Job::pop_type() which no longer exists
- and is all disabled since years ago
Jul 13 2020
The TimedMediaHandler support won't help here directly, except insofar as actually functionally supporting ingestion of AV1 WebM video uploads will require video transcode servers to have libaom installed, so will establish that we can install the codec library on our machines in a sensible way. :)
Jun 22 2020
I'm closing this one out as I'm retiring the incomplete but mostly working OGVKit in favor of recommending MobileVLCKit. It's more mature and better supported, and these days has better build tools than when I started.
Apr 14 2020
Apr 13 2020
The other buttons don't seem to highlight (anymore?) so closing this.
$wgMinimumVideoPlayerSize is a pretty difficult hammer to use for fine editorial control, and is not supported by the new videojs mode. The general intention is to add an explicit keyword for an 'inline' player mode which would always display in-place, rather than making it dependent on player size, though that's a separate bit of work and not yet done.
Apr 6 2020
Now works as written. :D
I presume I have to create an .env file in some other way, like using a text editor? Ideally there should be a ready-to-copy-and-paste chunk of text that requires no execution in a platform-specific shell. What should I use for MW_DOCKER_UID and MW_DOCKER_GID? UID and GID are Unix-specific concepts and I don't know if they have any meaning in Windows?
The instructions to create an .env file from a bash command fail in both PowerShell and CMD.exe... There is a mention of a /docker/install.sh file later in the instructions but I don't know where it's supposed to come from?
@kostajh trying a fresh checkout now. :)
Ok, that CSS doesn't take as it's for the post-transformed player. Looks like I need to redo how the placeholders are styled to make this work. :) Easy peasy, lemon squeezy...
Ok, the popup dialog is good but the thumbnail still doesn't get shrunk as on https://deployment.m.wikimedia.beta.wmflabs.org/wiki/Video_test
Going through the backlog of visible regressions to fix up; this may have been obsoleted by the switchover to the popup player dialog but let me check.
Ok, oddly it's started working for me even with live preview on. I don't know what changed that could have caused it to start working if it was previously broken...
Apr 2 2020
Looks like there's two things going on:
- the video preview doesn't resize to fit the gallery container (it's an actual <video> with a poster image under the lid, not an <img>, so styles might not be applying to it that need to be); this usually adds extra space around the image
- in Firefox, the video sometimes overflows the available space, causing insufficient space around the image as in the screenshot
Can't reproduce in Chrome, but can in Firefox. Something seems wonky with the gallery layout in Firefox specifically.
Ah, I see what's going on... the first loading indicator is running during the time that we load up OOUI etc, before we have a dialog, so it's just sitting on the page globally instead of being anchored anywhere in specific.
Mar 31 2020
@MichaelSchoenitzer looks like you have 'use live preview' on (labeled in English as "Show previews without reloading the page" in prefs editing tab). I can confirm that the player fails to work in the preview in this case -- it's probably not loading the required JS module -- but I haven't been able to repro the visual offset issue yet, at least in Chrome.
Thanks for the confirmation, I'll see if I can figure out which option is troublesome...
Mar 30 2020
Hmm, it's working ok for me in Chrome, Firefox, and Safari on your test page and a copy I made here: https://de.wikipedia.org/wiki/Benutzer:Brion_Vibber_(WMF)/Test
Mar 19 2020
Grabbing a couple high-prio TMH issues to work on the next week or two. Looks like a bug in the surrounding JS that assumes some things are marked up in one way but they aren't for Score stuff.
Mar 7 2020
Confirmed working on a fresh install, thanks all!
Mar 5 2020
T206957 is the related ticket.
Mar 4 2020
I think principle of least surprise leads us to want a job queue that is processed automatically without manual intervention, as it's meant to be a continuously-operating part of the MediaWiki service that code can rely on being in working condition.
Feb 25 2020
The alternative would be to replace the player 'inline', but then we'd have to jump through hoops to get subtitles for audio again.
Feb 17 2020
Feb 10 2020
From caniuse it looks like IE and old Edge are the holdouts (new Chromium based edge supports it, as well as reasonably current versions of other browsers)
Neat! We should probably confirm the behavior is consistent, predictable, and either falls back cleanly or can be emulated sanely (eg in IE 11 if it doesn't support it). Also double check that neither tag is used as an extension. Then I probably have no further objection. :)
Feb 9 2020
I think I wrote this yes... we'd consider this as GPLv2-or-later as part of MediaWiki. It wasn't originally labeled in detail as it was a one-off production hack that ended up being kept around, and we weren't as careful with explicit labeling on extensions back then.
Feb 7 2020
Patch for thumbor is in the works, needs to finish adding test cases which I'll try to do this weekend so it's ready to go out when ready.
Feb 4 2020
Feb 1 2020
From the IRC log, a couple of the transaction IDs that returned 500 errors with odd messages about Swift being missing or disabled: