brion (Brion Vibber)
User

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (153 w, 2 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Wed, Sep 20

JeanFred awarded T173377: Convert and upload large interview videos for Mardetanha a Love token.
Wed, Sep 20, 9:02 AM · Wikimedia-Video

Mon, Sep 18

brion added a comment to T173377: Convert and upload large interview videos for Mardetanha.

Ok import complete:

Mon, Sep 18, 7:26 PM · Wikimedia-Video
brion added a comment to T173377: Convert and upload large interview videos for Mardetanha.

Ok, currently running the imports. Did some slight renaming of the files, gave them all prefix 'Kheshte Kham - ' to avoid any name conflicts.

Mon, Sep 18, 6:52 PM · Wikimedia-Video

Wed, Sep 13

brion closed T158212: Transcode fails with Exitcode 139 - SIGSEGV as Resolved.

Seems to have resolved itself; all transcodes for that file are present.

Wed, Sep 13, 7:53 PM · TimedMediaHandler-Transcode
brion closed T158212: Transcode fails with Exitcode 139 - SIGSEGV, a subtask of T157028: Many transcodes still fail, as Resolved.
Wed, Sep 13, 7:53 PM · Wikimedia-General-or-Unknown, TimedMediaHandler-Transcode
brion closed T160827: Transcode fail with Exitcode 136 - SIGFPE as Declined.

Theora derivatives are being dropped, no need to solve with ffmpeg2theora.

Wed, Sep 13, 7:50 PM · TimedMediaHandler-Transcode
brion closed T160827: Transcode fail with Exitcode 136 - SIGFPE, a subtask of T157028: Many transcodes still fail, as Declined.
Wed, Sep 13, 7:50 PM · Wikimedia-General-or-Unknown, TimedMediaHandler-Transcode
brion added a comment to T173377: Convert and upload large interview videos for Mardetanha.

Ok, my batch conversions have completed -- files are all converted to .webm and small enough to upload. (They're long and high resolution, but they compress well because they're interviews with relatively little motion.)

Wed, Sep 13, 5:17 PM · Wikimedia-Video
brion closed T108234: Run a bot to add 240p webm/ogv, re-run 360p/480p ogv video transcodes as Resolved.

If anything got left over, the ogv mid-resolutions no longer need redoing as they've been obsoleted.

Wed, Sep 13, 5:15 PM · Patch-For-Review, Wikimedia-Video
brion closed T108234: Run a bot to add 240p webm/ogv, re-run 360p/480p ogv video transcodes, a subtask of T134954: Android app doesn't play particular video with Ogg source, as Resolved.
Wed, Sep 13, 5:15 PM · Mobile-App-Android-Sprint-95-Americium, Unplanned-Sprint-Work, TimedMediaHandler-Transcode, Wikipedia-Android-App-Backlog, Wikimedia-Video
brion closed T145925: WebM VP9 source videos are played back with higher priority than the VP8 transcodes as Resolved.

Looks like this merged and went out. Yay!

Wed, Sep 13, 5:13 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player
brion closed T115190: ogg transcodes too slow on specific file as Declined.

Abandoning; we've stopped producing Theora derivatives due to ongoing issues with nearly-unmaintained ffmpeg2theora.

Wed, Sep 13, 5:12 PM · TimedMediaHandler-Transcode, Upstream, TimedMediaHandler
brion closed T115190: ogg transcodes too slow on specific file, a subtask of T115883: Enable Theora 2-pass encoding with confidence, as Declined.
Wed, Sep 13, 5:12 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T115883: Enable Theora 2-pass encoding with confidence as Declined.

Abandoning, we dropped Theora derivative generation due to ongoing issues with mostly-unmaintained ffmpeg2theora.

Wed, Sep 13, 5:11 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T115882: Test 2-pass Theora .ogv transcoding more thoroughly off-site as Declined.

Abandoning, we've dropped Theora derivative generation due to ongoing issues with the mostly-unmaintained ffmpeg2theora.

Wed, Sep 13, 5:11 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T115882: Test 2-pass Theora .ogv transcoding more thoroughly off-site, a subtask of T115883: Enable Theora 2-pass encoding with confidence, as Declined.
Wed, Sep 13, 5:11 PM · TimedMediaHandler-Transcode, TimedMediaHandler

Tue, Sep 5

brion added a comment to T167000: Extract video encoder metadata from WebM videos.

Ok, prior code was removing all the matroska-specific metadata on the MediaWiki side because it was heavy on binary junk, presumably. Patch in https://gerrit.wikimedia.org/r/376088 puts the 'comments' subsection back, which contains the WritingApp and MuxingApp tags which list 'Google'.

Tue, Sep 5, 8:14 PM · Patch-For-Review, TimedMediaHandler, Commons, Multimedia
brion added a comment to T167000: Extract video encoder metadata from WebM videos.

Hrm, those two *should* already be being fetched. Looking as to why they don't show up...

Tue, Sep 5, 7:17 PM · Patch-For-Review, TimedMediaHandler, Commons, Multimedia
brion added a comment to T167000: Extract video encoder metadata from WebM videos.

So there's a couple of EBML elements in the WebM/Matroska stream that I think could be added to getid3's extraction easily:

Tue, Sep 5, 7:06 PM · Patch-For-Review, TimedMediaHandler, Commons, Multimedia
brion added a comment to T167000: Extract video encoder metadata from WebM videos.

Is there a sample file that's not deleted?

Tue, Sep 5, 6:07 PM · Patch-For-Review, TimedMediaHandler, Commons, Multimedia
brion added a comment to T167000: Extract video encoder metadata from WebM videos.

Note that legitimate videos come from YouTube pretty frequently...

Tue, Sep 5, 6:03 PM · Patch-For-Review, TimedMediaHandler, Commons, Multimedia
brion closed T109994: Track transcoding-related tasks as Declined.

I'm going to go ahead and decline this as TimedMediaHandler-Transcode has existed for a while.

Tue, Sep 5, 3:44 PM · Multimedia, Project-Admins

Fri, Sep 1

brion closed T172888: Ogg audio playback in Edge gets stuck at "seeking" state after playback ends as Resolved.

Confirmed this merged and went out along with other updates, and no longer produces the described error.

Fri, Sep 1, 11:36 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player

Thu, Aug 31

brion added a comment to T174476: Video thumbnails not working at wikitech.

Offhand I don't know of any reason it couldn't be turned on there.

Thu, Aug 31, 8:37 PM · TimedMediaHandler, wikitech.wikimedia.org

Wed, Aug 30

brion created T174575: Purge/delete old .ogv Ogg Theora video derivatives after September 25, 2017.
Wed, Aug 30, 3:43 PM · TimedMediaHandler-Transcode

Mon, Aug 28

brion added a comment to T174393: Video player should allow playback at multiple speeds.

This could be implemented using the playbackRate property of the HTML5 video or audio element.

Mon, Aug 28, 9:03 PM · TimedMediaHandler-Player, Wikimedia-Video

Thu, Aug 24

brion closed T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM as Resolved.

Done! Old transcodes will still exist for now; should leave them there for a while to ensure HTML caches referencing them go out of style, but new ones won't be created and newly generated pages won't use/reference them.

Thu, Aug 24, 11:19 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
brion closed T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM, a subtask of T145742: Migrate video scalers to jessie, as Resolved.
Thu, Aug 24, 11:19 PM · Patch-For-Review, Multimedia, TimedMediaHandler, HHVM, Operations
brion added a comment to T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.

All seems well with playback, planning to merge disabling of the .ogv generation at today's SF late swat.

Thu, Aug 24, 9:14 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
CKoerner_WMF awarded T158181: Aim for 1:1 feature equivalence for MediaWiki on desktop and mobile web a Love token.
Thu, Aug 24, 6:54 PM · Epic, MediaWiki-General-or-Unknown, Technical-Debt

Aug 23 2017

brion closed T172444: Enable WebM playback for ogv.js video player shim as Resolved.

Seems to be working. :)

Aug 23 2017, 7:30 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player
RandomDSdevel awarded T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM a Haypence token.
Aug 23 2017, 1:32 AM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode

Aug 22 2017

brion added a comment to T172444: Enable WebM playback for ogv.js video player shim.

The WebM enabling is live on beta -- see for example https://simple.wikipedia.beta.wmflabs.org/wiki/File:Tears_of_Steel_in_4k_-_Official_Blender_Foundation_release.webm which now plays back the 360p-fitting WebM in Safari and IE.

Aug 22 2017, 9:32 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player

Aug 17 2017

brion added a comment to T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.

I rewrote it a bit https://meta.wikimedia.org/w/index.php?title=Tech/News/2017/34&diff=17122835&oldid=17122825 -- let me know if everyone's happy with this version. :)

Aug 17 2017, 3:33 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode

Aug 15 2017

brion created T173377: Convert and upload large interview videos for Mardetanha.
Aug 15 2017, 5:01 PM · Wikimedia-Video

Aug 14 2017

brion added a comment to T173346: IIIF and Structured Data on Wikimedia Commons discussion.

@SandraF_WMF note I've been involved in the IIIF's A/V working group on extending the protocol to support audio and video, and have been at a few of the working group meetings for that. There's also a big IIIF working meeting in Toronto coming up in October; if there's serious interest I should probably pop in to that too, or else someone else from multimedia if there's interest in moving forward with stuff more directly.

Aug 14 2017, 8:46 PM · Structured-Data-Commons, Wikidata
MGChecker awarded T128351: RfC: Notifications in core a Love token.
Aug 14 2017, 1:53 PM · TechCom-Has-shepherd, RfC, Librarization, Collaboration-Team-Triage, Notifications, TechCom-RfC

Aug 13 2017

brion closed T147162: upload.wikimedia.org returns HTTP 501 instead of 416 for non-satisfiable byte ranges as Resolved.

Per above, this has been fixed presumably by updates to Swift. Closing; thanks!

Aug 13 2017, 8:52 PM · media-storage
brion closed T147162: upload.wikimedia.org returns HTTP 501 instead of 416 for non-satisfiable byte ranges, a subtask of T117972: swift upgrade plans: jessie and swift 2.x, as Resolved.
Aug 13 2017, 8:52 PM · Patch-For-Review, media-storage, Operations
brion created T173276: Specific JPEG file on upload.wikimedia.org returns Content-Type: application/x-www-form-urlencoded.
Aug 13 2017, 8:37 PM · media-storage, Multimedia, MediaWiki-File-management
brion renamed T173266: Make some terrible logos at wikimania hackathon 2017 from Shitty logos at wikimania hackathon 2017 to Make some logos at wikimania hackathon 2017.
Aug 13 2017, 5:31 PM · Wikimania-Hackathon-2017
brion closed T169258: Core tests depend on TimedMediaHandler as Resolved.

We managed to merge these; MockOggHandler now lives in TMH. :D

Aug 13 2017, 4:55 PM · MW-1.30-release-notes, Patch-For-Review, TimedMediaHandler, MediaWiki-Core-Tests, Multimedia
brion claimed T145925: WebM VP9 source videos are played back with higher priority than the VP8 transcodes.

This is still happening, and is cropping up more often. Prioritizing a fix and assigning to self.

Aug 13 2017, 1:05 AM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player

Aug 11 2017

brion added a comment to T165717: Support transcoding audio files to MP3 for playback on IE/Edge/Safari/etc.

Have made a draft proposal here: https://commons.wikimedia.org/wiki/User:Brion_Vibber_(WMF)/MP3_output_discussion

Aug 11 2017, 4:06 PM · TimedMediaHandler-Transcode
brion updated subscribers of T165717: Support transcoding audio files to MP3 for playback on IE/Edge/Safari/etc.

@CKoerner_WMF do we think there's a need for a discussion on this one? I'd like to go ahead with MP3 output for audio, particularly to resolve the issue of audio playback on iOS (where the TimedMediaHandler fancy player still doesn't work, and the ogv.js shim would load slowly even if we added it).

Aug 11 2017, 3:44 PM · TimedMediaHandler-Transcode
brion added a comment to T167815: Conduct MP3 patrol discussion.

@CKoerner_WMF I think we're good to go any time on this -- I'd love for us to move forward. :)

Aug 11 2017, 3:42 PM · Reading-Community-Engagement, Community-Liaisons (Jul-Sep 2017), Commons, Multimedia

Aug 10 2017

brion added a comment to T77147: Show Videos in Media Viewer.

Note that there may be some issues with autoplay, as browsers are increasingly disabling autoplay and JS-triggered playback for audio-bearing files unless triggered from within an event handler. As I recall there's a lot of asynchronous loading in media viewer, so this may require jumping through some hoops.

Aug 10 2017, 5:30 PM · Multimedia, Patch-Needs-Improvement, Patch-For-Review, TimedMediaHandler, MediaWiki-extensions-MultimediaViewer

Aug 9 2017

brion added a comment to T172477: Attribute anonymous contributions to the first IP address used in a session.

My main concern is that the IP no longer matching the IP will be surprising to folks doing admin work, but they'll probably get used to it. :)

Aug 9 2017, 9:10 PM · TechCom-RfC, MediaWiki-User-management
brion added a comment to T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.

Let's say we flip the switch Wednesday, August 23, 2017? That gives some time to finalize the patches after Wikimania, and avoids the eclipse day when people are likely to be busy. ;)

Aug 9 2017, 4:07 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
brion added a comment to T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.

@Johan sometime in the next few weeks (it's holding up a server migration for the video scalers so we don't want to wait too long). We can pick a date if that helps with any required messaging; I just don't want to flip the switch in the middle of Wikimania while we're all busy. ;)

Aug 9 2017, 4:03 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
brion created T172888: Ogg audio playback in Edge gets stuck at "seeking" state after playback ends.
Aug 9 2017, 2:20 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player

Aug 8 2017

brion removed a project from T172626: Minerva skin styles conflict with content using CSS class "header": Patch-For-Review.

Sorry, didn't mean to start another CSS war. ;) Per Timo's notes on the withdrawn patch, the extra selector is a little janky, but it's probably worth looking more at prefixing the class. (Or if it's super tricky now for some reason, I'd love a general style naming cleanup to be something that's possible in future.)

Aug 8 2017, 3:21 AM · MinervaNeue, Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Tracking)

Aug 7 2017

brion added a comment to T172626: Minerva skin styles conflict with content using CSS class "header".

I think it's extremely important to say that the responsibility is *not* on content developers to guess what will and won't work on our system. It's literally our job to make it work well for them.

Aug 7 2017, 3:28 PM · MinervaNeue, Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Tracking)
brion added a project to T172626: Minerva skin styles conflict with content using CSS class "header": MinervaNeue.

Re-adding MinervaNeue project; this is an obviously incorrect problem with the skin which should be fixed.

Aug 7 2017, 3:02 PM · MinervaNeue, Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Tracking)
brion added a comment to T172626: Minerva skin styles conflict with content using CSS class "header".

I agree use of such a generic class in skin code is dangerous; it should be changed to something using the 'mw-' prefix or else the styles need to be specified in a way that won't interact with content.

Aug 7 2017, 3:00 PM · MinervaNeue, Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Tracking)

Aug 5 2017

brion created T172626: Minerva skin styles conflict with content using CSS class "header".
Aug 5 2017, 11:23 PM · MinervaNeue, Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Tracking)

Aug 3 2017

brion added a parent task for T145742: Migrate video scalers to jessie: T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.
Aug 3 2017, 8:06 PM · Patch-For-Review, Multimedia, TimedMediaHandler, HHVM, Operations
brion added a subtask for T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM: T145742: Migrate video scalers to jessie.
Aug 3 2017, 8:06 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
brion added a parent task for T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM: T172444: Enable WebM playback for ogv.js video player shim.
Aug 3 2017, 8:06 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
brion added a subtask for T172444: Enable WebM playback for ogv.js video player shim: T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.
Aug 3 2017, 8:06 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player
brion created T172445: Deprecate/remove Ogg Theora video output formats in favor of WebM.
Aug 3 2017, 8:05 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-notice, TimedMediaHandler-Transcode
brion created T172444: Enable WebM playback for ogv.js video player shim.
Aug 3 2017, 8:02 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, TimedMediaHandler-Player
brion added a comment to T145742: Migrate video scalers to jessie.

Per email consultation between me & @MoritzMuehlenhoff we're thinking we should go ahead and deprecate the Ogg Theora video output (using ffmpeg2theora) in favor of the more well-tested WebM VP8 output (using ffmpeg). I'll add a task; a small adjustment to the ogv.js shim setup needs to be done to enable WebM for it.

Aug 3 2017, 7:57 PM · Patch-For-Review, Multimedia, TimedMediaHandler, HHVM, Operations

Jul 31 2017

Ahecht awarded T106516: Greyscale pngs without gAMA chunk rendered with incorrect contrast [or setting the gamma in GIMP exports to PNG] a The World Burns token.
Jul 31 2017, 8:58 PM · Multimedia, MediaWiki-File-management, Patch-For-Review, Easy, Upstream, Commons

Jul 14 2017

MGChecker awarded T91162: RFC: Shadow namespaces a Like token.
Jul 14 2017, 7:37 PM · Wikimedia-Developer-Summit (2017), TechCom-Has-shepherd, RfC, TechCom-RfC

Jul 11 2017

Niharika awarded T18691: RFC: Section headings should have a clickable anchor a Love token.
Jul 11 2017, 1:16 AM · TechCom-Has-shepherd, RfC, TechCom-RfC, Design, MediaWiki-Interface

Jul 9 2017

Pcoombe awarded T18691: RFC: Section headings should have a clickable anchor a Like token.
Jul 9 2017, 11:00 PM · TechCom-Has-shepherd, RfC, TechCom-RfC, Design, MediaWiki-Interface

Jul 7 2017

Kozuch awarded T88746: Upload photos on Wikipedia mobile app's edit screen a Love token.
Jul 7 2017, 10:35 PM · Commons, WorkType-NewFunctionality, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog

Jul 5 2017

brion added a comment to T169783: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php.

If I update to 0.10.0 (via setting ver in composer.json & running composer update) I get:

Jul 5 2017, 7:02 PM · Patch-For-Review, MediaWiki-Codesniffer
brion added a comment to T68722: [iOS app] Media files do not work.

Note if y'all are interested in moving forward on this, I can finish up the CocoaPods packaging on OGVKit. :)

Jul 5 2017, 6:57 PM · WorkType-Maintenance, Wikipedia-iOS-App-Backlog
brion added a comment to T169783: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php.

mediawiki-codesniffer is 0.8.0. composer is 1.3.2.

Jul 5 2017, 6:29 PM · Patch-For-Review, MediaWiki-Codesniffer
brion created T169783: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php.
Jul 5 2017, 6:11 PM · Patch-For-Review, MediaWiki-Codesniffer

Jun 30 2017

Bawolff awarded T169027: Provide iframe sandboxing for rich-media extensions (defense in depth) a Love token.
Jun 30 2017, 12:24 PM · Security-General, Technical-Debt, Commons, MediaWiki-File-management, Multimedia, MediaWiki-Platform-Team

Jun 28 2017

brion created T169027: Provide iframe sandboxing for rich-media extensions (defense in depth).
Jun 28 2017, 2:41 AM · Security-General, Technical-Debt, Commons, MediaWiki-File-management, Multimedia, MediaWiki-Platform-Team
brion created T169026: Tech debt: includes/media cleanup.
Jun 28 2017, 2:21 AM · MediaWiki-File-management, Commons, Technical-Debt, Multimedia, MediaWiki-Platform-Team

Jun 23 2017

brion added a comment to T167815: Conduct MP3 patrol discussion.

I’d also like to look at adding mp3 transcode output for Ogg/flac/opus/wav files, which will let us use native audio playback on IE/Edge/Safari (reserving the ogv.js JavaScript player shim for video). This should be a much less controversial change – it doesn’t change what you can upload - but I want to make sure messaging doesn’t get confused by having two mp3 issues for the community to look at.

Jun 23 2017, 10:41 PM · Reading-Community-Engagement, Community-Liaisons (Jul-Sep 2017), Commons, Multimedia

Jun 15 2017

brion added a comment to T150369: Record an event every time a new content namespace page is created.

I have the impression rev_parent_id isn't reliable but don't offhand recall how they can break under the hood... Worth taking a look to see if we can make it reliable. :)

Jun 15 2017, 6:27 PM · Community-Tech, Analytics-Kanban, MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), EventBus, Patch-For-Review, Wikimedia-Hackathon-2017, Easy, Analytics, Contributors-Analysis, Analytics-EventLogging
dbarratt awarded T33338: Export file thumbnail, video preview via Open Graph meta elements as Facebook posting helper a Like token.
Jun 15 2017, 4:35 PM · MediaWiki-extension-requests
brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Recommended fix: move the sanitization in MemcacheBagOStuff->makeKeyInternal up to BagOStuff->makeKeyInternal and just apply it evenly everywhere so no surprises.

I'm not sure we can assume a single encoding will (or should) work on every backend. I'd rather keep this generic.

Jun 15 2017, 2:46 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
brion added a comment to T143188: "Key contains invalid characters" exception when purging pages with a "ä" in the title.

Similar symptoms and root problem to T167465 (incorrectly escaped key values), though with a twist -- WikiArticleFeeds appears to be generating its own keys here, without using any key-creation function. This is probably solvable using $messageMemc->makeKey() (1.27 or later) or the older wfMemcKey() function with relevant parameters.

Jun 15 2017, 2:24 AM · WikiArticleFeeds

Jun 9 2017

brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Ok, my vagrant install is using MemcachedBagOStuff which has a makeKeyInternal() which uses rawurlencode() on input strings, but in production we're using MultiWriteBagOStuff which does not override the naive base implementation from BagOStuff.

Jun 9 2017, 12:36 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Turns out Language::isValidCode() lets a lot through that I didn't expect for compatibility with weird hacks. It should prevent actual < and > and path-traversals etc, but is letting the non-ASCIIs through directly.

Jun 9 2017, 12:15 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Per irc, note that Wikibase's splitting everything on user lang is why the userlang appears in pcache and thus the bug is visible on any page on Commons, given the URL param, but on meta or enwiki it needs to be a page that uses user-lang stuff specifically.

Jun 9 2017, 12:00 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors

Jun 8 2017

brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Note this doesn't look image-specific; I get exception thrown if I try on a regular page that exists too, such as https://commons.wikimedia.org/wiki/Main_Page?uselang=%E2%A7%BCLang%E2%A7%BD BUT - I don't see the equivalent error on enwiki. https://en.wikipedia.org/wiki/Main_Page?uselang=%E2%A7%BCLang%E2%A7%BD does not error out.

Jun 8 2017, 11:21 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors

Jun 7 2017

brion updated the task description for T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Jun 7 2017, 2:17 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team
brion added a subtask for T161671: Compacting the revision table: T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Jun 7 2017, 2:14 AM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team
brion added a parent task for T167246: Refactor "user" & "user_text" fields into "actor" reference table: T161671: Compacting the revision table.
Jun 7 2017, 2:14 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team
brion created T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Jun 7 2017, 2:14 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team

May 26 2017

brion added a comment to T164401: Error creating thumbnail for webm video.

@Richard_Nevell_WMUK the file appears to have been trimmed or generated in a strange way: its timestamps start at ~201 seconds in, which confuses the heck out of Firefox, ffmpeg, etc. As a result, when ffmpeg skips through what it thinks is half the file, there's no video frames left to decode, and no thumbnail can be generated.

May 26 2017, 6:50 PM · TimedMediaHandler, Wikimedia-Video

May 25 2017

Krinkle awarded T158181: Aim for 1:1 feature equivalence for MediaWiki on desktop and mobile web a Orange Medal token.
May 25 2017, 1:47 PM · Epic, MediaWiki-General-or-Unknown, Technical-Debt

May 22 2017

brion added a project to T166039: Extension:TimedMediaHandler - ogv-worker-video/audio.js files: Upstream.

I've submitted them upstream to clamav for false positive checking.

May 22 2017, 10:16 AM · Upstream, TimedMediaHandler, Security
brion added a comment to T153333: RFC: How should we store longer revision comments?.

I'll fix that :)

May 22 2017, 10:04 AM · User-Daniel, TechCom-RfC, Community-Tech
brion added a comment to T166039: Extension:TimedMediaHandler - ogv-worker-video/audio.js files.

Sounds like a false positive, certainly ogv.js is not an exploit. :) Should report upstream to cpanel or clamav or whatever is doing the scanning?

May 22 2017, 9:54 AM · Upstream, TimedMediaHandler, Security

May 21 2017

brion removed a parent task for T120288: Once it's not patent-encumbered, enable MP3 support for Commons uploads and TMH/etc. playback: T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback.
May 21 2017, 9:49 PM · Support-and-Safety, TimedMediaHandler, WMF-Legal, UploadWizard, Commons, User-notice, Multimedia
brion removed a subtask for T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback: T120288: Once it's not patent-encumbered, enable MP3 support for Commons uploads and TMH/etc. playback.
May 21 2017, 9:49 PM · UploadWizard, TimedMediaHandler, WMF-Legal, Commons, Multimedia
brion added a comment to T103421: Publish File_Ogg as a composer package.

Ok current status on this -- I need to pick up my modernize branch from https://github.com/brion/File_Ogg/commits/modernize and finish reworking it for PSR-4 so it's autoloader-friendly and composer-friendly.

May 21 2017, 4:43 PM · Librarization, TimedMediaHandler
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Poop, error isn't thrown until play when using preload=none. We'll need to manually check the sources against .canPlayType() via a small JS function. We'll also possibly want this for other old browsers that get degraded in future that don't have native ogg/webm but do have HTML5 video.

May 21 2017, 4:23 PM · Patch-For-Review, TimedMediaHandler-Player
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Ok we tested this at wmhack. Quick note we need special handling for IE9, which supports <video> but none of our codecs (or ogv.js) and also gets grade C non-JS mode.

May 21 2017, 4:12 PM · Patch-For-Review, TimedMediaHandler-Player

May 20 2017

brion updated subscribers of T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

@Krinkle I'm not sure we need T122965 for this; the fallback content should "just work" and the contained image would behave the same as the <video> in terms of its sizing and inline-block nature.

May 20 2017, 11:49 PM · Patch-For-Review, TimedMediaHandler-Player
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Hmm, i have a lot of open questions on this. UI wise it's pretty shitty no matter what you do, File page linking vs download media remains a problem (which goes where?), and it's a lot of extra bytes...

May 20 2017, 11:48 PM · Patch-For-Review, TimedMediaHandler-Player