Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (24)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (231 w, 2 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Thu, Feb 28

Niedzielski awarded T18691: RFC: Section headings should have a clickable anchor a Love token.
Thu, Feb 28, 3:37 PM · Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Wed, Feb 27

brion claimed T138770: TMH video.js-mode 'info' button link normalization.
Wed, Feb 27, 8:16 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), TimedMediaHandler, Patch-For-Review, TimedMediaHandler-Player

Thu, Feb 21

brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

(Just noting I'll be ready to work more on this in around next week-ish)

Thu, Feb 21, 9:49 PM · Patch-For-Review, TimedMediaHandler, Release-Engineering-Team (Kanban), User-zeljkofilipin

Feb 21 2019

brion created T216673: Unable to install php-tidy during MediaWiki-Vagrant setup.
Feb 21 2019, 3:54 AM · MediaWiki-Vagrant

Feb 5 2019

brion created T215344: Add overlay notice recommending modern browser on slow ogv.js playback.
Feb 5 2019, 8:32 PM · TimedMediaHandler-Player

Feb 1 2019

brion added a comment to T27707: Allow "html" in exif tags.

https://www.flickr.com/photos/tinto/30943950124/ and other photos from this Flickr user.

Feb 1 2019, 10:52 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

The above patch https://gerrit.wikimedia.org/r/487527 removes some of the non-scripting tags from the checks in UploadBase::detectScript, and makes the conservative/exact IE heuristics called from UploadBase::verifyMimeType optional (but still on by default). This also deprecates $wgAllowTitleInSVG since <title is no longer looked for.

Feb 1 2019, 7:56 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

Ok, looking at the actual current code now... UploadBase::detectScript does the check, and combines several things:

  • looks at first 1024 bytes (more than IE checks) if binary, or all if text
  • does some text encoding checks (seems to be SVG-specific?)
  • looks for IE's trigger tags for type detection
  • looks for some Safari (old Safari?) trigger works for plain-specific type detection
  • decodes XML-style char references (seems to be SVG-specific)
  • looks for some script-like things CSS-like URLs in body content that seem to be SVG-specific
Feb 1 2019, 6:39 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

Though this is not needed to remove this MIME sniffing check (or at the very least, make it optional), as I've shown it can't be exploited unless the webserver is misconfigured. So it doesn't apply to Wikimedia projects.

Feb 1 2019, 5:41 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

@Aklapper I believe it's very on-topic to discuss the security implications of a suggested feature change. Where would you suggest we discuss this if not here, on this task?

Feb 1 2019, 5:18 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading

Jan 29 2019

brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

Thanks! Didn't mean to rush you, I'll probably poke at this next week unless I get inspired. :)

Jan 29 2019, 9:41 PM · Patch-For-Review, TimedMediaHandler, Release-Engineering-Team (Kanban), User-zeljkofilipin

Jan 28 2019

brion added a comment to T27707: Allow "html" in exif tags.

Double-checking:

  • IE 6 and 7 were both available on Windows XP, which includes TLS 1.0 support but not TLS 1.1 or 1.2. However IE 6-8 on XP fail to work anyway due to lack of SNI.
    • This takes IE 6 off the table entirely.
  • IE 7 on Vista should still work correctly with TLS 1.0, 1.1, or 1.2 -- https://blogs.msdn.microsoft.com/kaushal/2011/10/02/support-for-ssltls-protocols-on-windows/
  • IE8 supports X-Content-Type-Options: nosniff header; if we don't already use it consistently, applying this on all file views would resolve all sniffing issues on IE 8
Jan 28 2019, 11:35 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

The chance that someone would visit using an old IE version was probably 50% when the code was originally added; IE had a very high marketshare in the early 2000s. However at this point we can't even be accessed in IE 6 as far as I know (due to servers dropping old TLS versions for HTTPS). I think it's pretty fair to change the balance of what we check for.

Jan 28 2019, 10:58 PM · Patch-For-Review, Security, Multimedia, MediaWiki-Uploading
brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

@zeljkofilipin should I take this task? I'll need to grab some documentation for starters or else grab you later when we have time. :)

Jan 28 2019, 10:13 PM · Patch-For-Review, TimedMediaHandler, Release-Engineering-Team (Kanban), User-zeljkofilipin
brion created T214864: requeueTranscodes gets confused in some cases where null entries are left in place.
Jan 28 2019, 8:55 PM · TimedMediaHandler-Transcode

Jan 23 2019

osorio-juan-microsoft awarded T18691: RFC: Section headings should have a clickable anchor a Burninate token.
Jan 23 2019, 7:12 PM · Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Jan 4 2019

brion added a comment to T178592: decommission/replace bast4001.wikimedia.org.

Note that bast4001 no longer works for login?

Jan 4 2019, 10:13 PM · decommission, Operations, ops-ulsfo

Jan 3 2019

brion added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.

A few quick notes:

  • we should sketch out a few extensions in this model -- I'll take a look at some later in the week
  • aggressively pushing action hooks to deferred or jobqueue means we need to be much better about making the job queue *work* reliably (and quickly) on small installs
  • immutable interfaces are probably sufficient for most of what we want on hook params, without necessarily needing to create full value classes for everything. We want both sides of the hook to know what's promised & what's allowed & what might change from under you
  • side effects issues are something to consider more, about guarantees vs recommendations. needs some real-world testing to see where these guidelines lie
Jan 3 2019, 6:55 AM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom

Jan 2 2019

brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

Using a define sounds good to me, but it seems modern code is not using this style. So having a class constant is also a way to do it. I did not prefer any way here.

Jan 2 2019, 9:52 PM · MW-1.33-release, MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

MediaWikiVersionFetcher would need to be altered as well, which currently looks for $wgVersion being set in DefaultSettings.php

Jan 2 2019, 9:29 PM · MW-1.33-release, MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

Sensible enough. :) I'd recommend MW_VERSION as the constant name; but should it be set in DefaultSettings.php where $wgVersion is set now, or up in defines.php or elsewhere? May also need to update documentation about cutting release versions (updated location of the changed version).

Jan 2 2019, 9:14 PM · MW-1.33-release, MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown

Dec 28 2018

brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

Confirmed it fixed the VM on the Linux PC too. Sweeeeeeeeeeet!

Dec 28 2018, 5:28 PM · Patch-For-Review, MediaWiki-Vagrant

Dec 25 2018

brion closed T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 as Resolved.

Woohoo! I'll close this out now as fixing my main case (on the Mac where it almost worked) and will confirm Friday on the Linux PC and if that doesn't resolve it there will just reimage it.

Dec 25 2018, 9:16 PM · Patch-For-Review, MediaWiki-Vagrant
brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

@brion Want to give the above patch a go? Not perfect, but improves it a bit

Dec 25 2018, 4:07 PM · Patch-For-Review, MediaWiki-Vagrant
brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

On the Mac (where the extensions installed but php-cli didn't), php was gone again when needed for composer runs via vagrant git-update:

Dec 25 2018, 8:04 AM · Patch-For-Review, MediaWiki-Vagrant
brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

@Reedy I'm out of town for a couple days for the holiday so can't retest just now, will poke again later in the week. But I think it was around commit dca68a5c3db8f338bb8b00b3e014c3b1d1308a99 (mid-November) when I last updated it successfully.

Dec 25 2018, 7:33 AM · Patch-For-Review, MediaWiki-Vagrant

Dec 22 2018

brion created T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.
Dec 22 2018, 2:25 AM · Patch-For-Review, MediaWiki-Vagrant

Nov 14 2018

brion added a comment to T209437: Migrate primary Wikimedia video format from VP9 to AV1.

Note that this is dependent on suitable playback support being widespread. While on desktops, Chrome and Firefox are shipping AV1 now or in next versions, and Microsoft is previewing it for Edge, we don't yet know the situation for Safari. I've started adding AV1 decode to ogv.js, but it's slower than decoding VP9 so far so may require running lower resolutions (unless WebAssembly threading arrives soon on Safari).

Nov 14 2018, 12:44 AM · TimedMediaHandler
brion added a comment to T209440: Add support for AV1 as an ingestion and transcoding target format.

Ingest should be a matter of having a suitable ffmpeg & libaom package backport, and a small update to make sure we're allowing AV1 codec in WebM container. Note there will also be MP4-flavored AV1 out in the world, but we don't yet know how popular that will be as flat files (versus DASH/HLS/streaming).

Nov 14 2018, 12:37 AM · TimedMediaHandler

Nov 11 2018

Liuxinyu970226 awarded T134455: Add experimental option for direct SVG output via srcset a Like token.
Nov 11 2018, 12:20 PM · Patch-For-Review, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering, Multimedia
Liuxinyu970226 awarded T187872: Support IIIF Image API for thumbnailing & tiling of images a Like token.
Nov 11 2018, 12:18 PM · Multimedia, Commons, MediaWiki-File-management
Liuxinyu970226 awarded T34284: Update Echo Notifications in real time without page reloads a Love token.
Nov 11 2018, 8:16 AM · Growth-Team, Collaboration-Team-Triage, Notifications

Nov 8 2018

brion added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Storage note: may need/want to include a reverse-domain copy of the domain for indexing purposes for bulk lookups.

Nov 8 2018, 7:35 AM · TechCom-RFC, TechCom, Security-Team, Security
brion added a comment to T208188: Proposal for partial opt-out method for Content security policy.

(my concern being the possibility of getting people to agree to click-through things they shouldn't; attacker script wouldn't be able to auth/confirm the form, in theory)

Nov 8 2018, 6:52 AM · TechCom-RFC, TechCom, Security-Team, Security
brion added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Another suggestion that ive heard is have some sort of friendlier interstitial similar to oauth that people can agree to. Or have it part of the gadget config and people opt in when they enable a gadget that needs it

Nov 8 2018, 6:44 AM · TechCom-RFC, TechCom, Security-Team, Security

Nov 7 2018

brion closed T208710: Raise version number of TMH as Resolved.

Version bumped, and README includes a little info on the changes to config.

Nov 7 2018, 11:46 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, TimedMediaHandler
brion added a comment to T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.

Yep, our bad -- we didn't document the breaking changes to config. :( Try this:

Nov 7 2018, 11:30 PM · TimedMediaHandler

Nov 5 2018

TheDJ awarded T27611: Support optimized WebP thumbnails as alternative to JPEG, PNG a Barnstar token.
Nov 5 2018, 1:54 PM · Performance-Team, Commons, Multimedia, MediaWiki-File-management

Oct 30 2018

MusikAnimal awarded T145703: Horizon loses credentials every day a Cup of Joe token.
Oct 30 2018, 3:37 AM · cloud-services-team (Kanban), Horizon

Oct 25 2018

brion updated the task description for T206077: Wikimedia Technical Conference 2018 Session - Improving frontend testing and logging.
Oct 25 2018, 11:27 PM · Wikimedia-Technical-Conference-2018
brion updated the task description for T206077: Wikimedia Technical Conference 2018 Session - Improving frontend testing and logging.
Oct 25 2018, 11:23 PM · Wikimedia-Technical-Conference-2018

Oct 9 2018

brion closed T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome as Resolved.

I didn't manage to do an early push because I was out sick most of last week, but it should be live now, and the re-rendered file works for me so hoping it's fine for @jeblad. :)

Oct 9 2018, 5:52 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler

Oct 1 2018

Liuxinyu970226 awarded T107595: [RFC] Multi-Content Revisions a Dislike token.
Oct 1 2018, 11:43 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (MCR), Multi-Content-Revisions (New Features), Epic, User-Daniel, Wikidata-Sprint-2015-11-17, Wikimedia-Developer-Summit-2016, Wikidata, Wikidata-Sprint-2015-09-15, TechCom-RFC
brion added a comment to T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome.

I'll try to sneak it into a 'swat deploy' window later this week.

Oct 1 2018, 8:28 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler
brion edited projects for T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome, added: TimedMediaHandler-Transcode; removed TimedMediaHandler-Player.
Oct 1 2018, 6:18 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler
brion renamed T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome from Large (huge) movie clip does not play in webkit browsers (bug – uncaught exception) to Video clip in 4:2:2 chroma subsampling fails to play in Chrome.
Oct 1 2018, 6:17 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler
brion added a comment to T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome.

Aha found it -- the file is 4:2:2 chroma subsampling (profile 1) which Chrome probably doesn't support.

Oct 1 2018, 6:16 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler
brion added a comment to T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome.

I did some more poking at this, and I'm not quite sure what's going on but I don't think it's because of the pause/play stuff.

Oct 1 2018, 6:15 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T197914: Regression: videos with audio not playing in Safari Techology Preview (Safari 12 on macOS) as Resolved.

This merged some time ago. Closing out.

Oct 1 2018, 5:11 PM · Browser-Support-Apple-Safari, Patch-For-Review, TimedMediaHandler-Player
brion moved T205099: Embedded TMH points to incorrect thumbnail URLs from Backlog to Kaltura/MwEmbed on the TimedMediaHandler-Player board.
Oct 1 2018, 5:11 PM · TimedMediaHandler-Player, TimedMediaHandler, Wikimedia-Video
brion moved T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome from Backlog to Kaltura/MwEmbed on the TimedMediaHandler-Player board.
Oct 1 2018, 5:09 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler
brion added a comment to T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome.

Looks like a bug with the old mwembed player assuming it can autoplay and interacting badly with current browsers...

Oct 1 2018, 5:09 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler

Sep 18 2018

brion added a comment to T187562: Use a better method for detecting STL files on the page.

@Esanders worst case, currently should be possible to override the ThreeDHandler's doTransform method to return a custom ThumbnailImage subclass, which can add a class by sniping into the toHtml() method and appending to the img-class entry in options.

Sep 18 2018, 6:32 PM · Performance, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 3D, Multimedia
brion added a comment to T187562: Use a better method for detecting STL files on the page.

Not a blocker, but it'd be nice to treat various media types consistently in that respect. Ought to be able to add a custom class on the <img> in some reasonable way already, though...

Sep 18 2018, 6:25 PM · Performance, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 3D, Multimedia

Sep 14 2018

brion moved T68398: Links in TimedText when doing a Pop up video wrong colour (CSS gets overriden) from TimedText to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:23 PM · TimedMediaHandler-TimedText, TimedMediaHandler
brion merged task T113330: Refactor long-running transcode jobs to (PHP-based) microservice into T105951: Create video/audio transcode service to replace shell-outs to avconv/ffmpeg2theora.
Sep 14 2018, 9:21 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion merged T113330: Refactor long-running transcode jobs to (PHP-based) microservice into T105951: Create video/audio transcode service to replace shell-outs to avconv/ffmpeg2theora.
Sep 14 2018, 9:21 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion added a comment to T199129: Consider a slimmer HTML representation for videos.

Once we're able to move to MPEG-DASH streaming we could have one or two progressive-download sources at a reasonable default resolution, plus the MPEG-DASH manifest listed as first source. We might be able to shove the timed text track references into the .mpd manifest too, though that would mean they don't work with JavaScript disabled.

Sep 14 2018, 9:18 PM · Performance, Technical-Debt, TimedMediaHandler, Parsing-Team
brion moved T200145: Text on multiple lines is not shown for video subtitles from Backlog to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:15 PM · Regression, TimedMediaHandler-TimedText, TimedMediaHandler
brion moved T55926: TMH: <br> tags (line breaks) are not used in interface message from Backlog to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:14 PM · TimedMediaHandler
brion moved T137630: "EmbedPlayer.NativeControls" option is broken from Backlog to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:10 PM · TimedMediaHandler-Player, TimedMediaHandler
brion moved T149096: Audio closed captioning menu displayed poorly; only half of the first entry displayed from Backlog to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:10 PM · TimedMediaHandler-Player, TimedMediaHandler
brion moved T151641: Don't use underscores in the title bar of popup window for videos from Backlog to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:10 PM · TimedMediaHandler-Player, TimedMediaHandler
brion moved T169476: Video player error on Mac/Safari due to incorrect subtitles from Backlog to Player-Old on the TimedMediaHandler board.
Sep 14 2018, 9:10 PM · TimedMediaHandler

Sep 10 2018

brion added a comment to T203994: Link to a video file page with a specified start time.

Note that this should be made possible for both regular File: page view and the iframe-embedded view.

Sep 10 2018, 7:49 PM · TimedMediaHandler

Sep 8 2018

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Feedback question -- is the method name mapping from 'somethingWorker' to 'something' too clever? Should it just let you pass any method name to $controller->queue()?

Sep 8 2018, 3:22 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion updated the task description for T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Sep 8 2018, 3:06 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

(Still have to see if the exec mode can be got working, do a little debugging, and add a hook for closing extensions.)

Sep 8 2018, 2:33 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Updated summary with the reworked API for ParallelMaintenance.

Sep 8 2018, 2:15 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion updated the task description for T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Sep 8 2018, 2:15 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Sep 7 2018

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

using regular execute() method, with a helper fork() method (bikeshed that name!) that creates the controller, a dispatch callback, and the work/result callbacks

Sep 7 2018, 10:17 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

I'm retooling the proposal based on feedback. Key things:

Sep 7 2018, 10:13 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Sep 5 2018

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Note via Timo -- currently we run maint scripts in production through hhvm, which sets processor affinity on all child processes. :P

Sep 5 2018, 8:26 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T101716: Support MJPEG & PCM audio as last-ditch fallback output for iOS.

Hadn't thought of trying h.263; testing... I've put up some samples at https://brionv.com/misc/pumpjack/

Sep 5 2018, 3:44 PM · Patch-For-Review, TimedMediaHandler, Multimedia

Aug 31 2018

brion added a comment to T203289: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment.

Seems to be a change in how plugins are loaded in 2.1.3/2.1.4. Yay semver!

Aug 31 2018, 10:46 PM · MediaWiki-Vagrant
brion created T203289: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment.
Aug 31 2018, 10:41 PM · MediaWiki-Vagrant

Aug 27 2018

brion added a comment to T115692: Flash of unstyled content (FOUC) on Login page and Preferences (and possibly other highly visible pages?).

Taking a quick peek at this per an inquiry from @saper. Specifically looking at the login page...

Aug 27 2018, 11:04 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-User-login-and-signup, MW-1.27-release-notes

Aug 21 2018

brion renamed T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts from ParallelMaintenance helper class for multi-process maintenance scripts to RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Aug 21 2018, 2:47 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Aug 20 2018

brion closed T131515: extension.json is poorly documented as Resolved.

I'm pretty happy with the current documentation now; last time I needed to use it I found what I needed. :) Closing.

Aug 20 2018, 8:59 PM · MediaWiki-Documentation, Documentation
brion added a project to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts: TechCom-RFC.

Adding to techcom-rfc board to make sure we don't forget to discuss this, if cross-cutting issues are forseen.

Aug 20 2018, 8:50 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion updated the task description for T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Aug 20 2018, 8:49 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Should we leave open for the community to delete?

Aug 20 2018, 7:12 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Existing files should be either deleted or re-encoded.

Aug 20 2018, 7:01 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Fix has been deployed; no more MP4 files should be coming in.

Aug 20 2018, 6:58 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion closed T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed" as Invalid.

AAAAAGGGGHHHH the VM has the clock wrong and thinks the cert is not yet valid. Nevermind.

Aug 20 2018, 5:48 PM · MediaWiki-Vagrant
brion added a comment to T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed".

(I think that missing file is ok cause the dir is full of other files...?)

Aug 20 2018, 5:40 PM · MediaWiki-Vagrant
brion added a comment to T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed".

The /usr/lib/ssl/cert.pem file specified in config seems to be missing?

Aug 20 2018, 5:26 PM · MediaWiki-Vagrant
brion created T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed".
Aug 20 2018, 5:10 PM · MediaWiki-Vagrant
brion created T202308: PHPUnit test case warning about Special:Notifications missing aliases in SkinMinervaTest.
Aug 20 2018, 5:05 PM · Readers-Web-Backlog, Google-Code-in-2018, Need-volunteer, MinervaNeue
brion added a comment to T95899: MediaWiki core PHPUnit tests do not pass on MediaWiki-Vagrant.

PHP 5 is obsolete; use PHP 7.

Aug 20 2018, 4:43 PM · Wikidata, MediaWiki-Core-Testing, MediaWiki-Vagrant

Aug 19 2018

brion claimed T202208: Mp4 on Commons - since when did we allow it.
Aug 19 2018, 9:55 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Yep, that's a regression in the extension.json migration. The addition of file types to $wgFileExtensions was being done twice, both in the extension.json and then again dynamically, causing the way that 'mp4' was removed from the list to fail because it only removed one instance of it.

Aug 19 2018, 9:55 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video

Aug 14 2018

brion created T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Aug 14 2018, 10:58 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Aug 13 2018

Imarlier awarded T66214: Define an official thumb API a Baby Tequila token.
Aug 13 2018, 5:46 PM · Core Platform Team Backlog (Watching / External), Reading-Infrastructure-Team-Backlog, Services (watching), Reading Epics (Thumbnails), Traffic, Operations, TechCom-RFC, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Reading-Admin, Commons, Epic, Parsoid, Multimedia, MediaWiki-File-management
brion moved T201843: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled from Backlog to Kaltura/MwEmbed on the TimedMediaHandler-Player board.
Aug 13 2018, 3:58 PM · TimedMediaHandler-Player, Technical-Debt
brion edited projects for T201843: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled, added: TimedMediaHandler-Player; removed TimedMediaHandler.
Aug 13 2018, 3:58 PM · TimedMediaHandler-Player, Technical-Debt
brion added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

As for role ids -- perhaps we should primarily use the names, not the numbers, in the <role> bit. It's analogous to a page's <title> reference (a primary identifier) not to its <ns> or <id> (which are provided informatively if you want to repro the database exactly, but can be freely discarded when doing imports and such).

Aug 13 2018, 9:05 AM · Multimedia, Core Platform Team Kanban (Done with CPT), TechCom-RFC (TechCom-Approved), Core Platform Team (MCR), Multi-Content-Revisions (New Features), SDC Engineering, Dumps-Generation, User-ArielGlenn, User-Daniel, Wikidata
brion added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

Ok, proposed transitional schema looks like it imports cleanly via importDump (which uses same code path as Special:Import). The proposed final schema, however, imports a revision with empty text (and throws a notice on Undefined index: text in /vagrant/mediawiki/includes/import/WikiImporter.php on line 886).

Aug 13 2018, 9:00 AM · Multimedia, Core Platform Team Kanban (Done with CPT), TechCom-RFC (TechCom-Approved), Core Platform Team (MCR), Multi-Content-Revisions (New Features), SDC Engineering, Dumps-Generation, User-ArielGlenn, User-Daniel, Wikidata
brion added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

My concern with the two-step transition idea is that some consumers may not update on a reliable schedule, or may not be able to do so easily. For instance, if people are using Special:Export on one wiki and Special:Import'ing those pages on another that's *not* a Wikimedia-hosted site, it's more likely to be an older version of MediaWiki.

Aug 13 2018, 8:46 AM · Multimedia, Core Platform Team Kanban (Done with CPT), TechCom-RFC (TechCom-Approved), Core Platform Team (MCR), Multi-Content-Revisions (New Features), SDC Engineering, Dumps-Generation, User-ArielGlenn, User-Daniel, Wikidata

Aug 8 2018

brion created T201561: Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line.
Aug 8 2018, 9:25 PM · VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor