Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (247 w, 5 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Sat, Jul 13

brion closed T227850: Transcode of a video gets turned upside down as Resolved.

Confirmed this fixes the transcodes; resolving.

Sat, Jul 13, 6:40 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion claimed T227850: Transcode of a video gets turned upside down.

Fixing the .ogv file by setting the 'ROTATE=180' to 'ROTATE=0':

Sat, Jul 13, 6:34 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

I suspect that the 'rotate' annotation in the comments is not actually handled by Firefox, VLC, or ogv.js -- certainly I never wrote code in ogv.js to handle it -- and may be a leftover from the MP4/3gpp original file the .ogv was sourced from.

Sat, Jul 13, 6:17 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

This may be a problem that's been since fixed in upstream ffmpeg...?

Sat, Jul 13, 6:16 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

For me, the original plays upside-down in Chrome, right-side-up in Firefox, VLC, and ogv.js. So this ain't handled quite universally I suppose. ;) I'll take a peek.

Sat, Jul 13, 5:57 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video

Fri, Jul 12

Ladsgroup awarded T167246: Refactor "user" & "user_text" fields into "actor" reference table a Love token.
Fri, Jul 12, 4:19 PM · Core Platform Team (Revision Storage Schema Improvements), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Epic, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-Database

Mon, Jul 1

brion added a project to T226797: Login state not propagated across domains in Safari: Browser-Support-Apple-Safari.
Mon, Jul 1, 5:10 PM · Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth

Sat, Jun 29

Lofhi awarded T100106: Replace Kaltura player with Video.js a Like token.
Sat, Jun 29, 11:35 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Performance-Team, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler

Fri, Jun 28

brion created T226797: Login state not propagated across domains in Safari.
Fri, Jun 28, 4:42 AM · Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth

Thu, Jun 27

brion added a comment to T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object.

Note a deployment typo caused this fix to not get deployed in fact. Whoops! Roan's fixing it now.

Thu, Jun 27, 11:24 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion closed T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object as Resolved.

Fix deployed. Should no longer cause fatal errors, but should log the transcoder output into the transcode table so we can review it later for suspicious commonalities.

Thu, Jun 27, 9:53 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

Ok Reedy started this a while ago under T226713, so no need to re-run it a second time. It's probably the cause of seeing multiple fatals over on T226748, since all failure cases would come in a relatively short time. :D

Thu, Jun 27, 9:47 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler
brion added a comment to T226713: Run cleanupTranscodes.php for current midi files.

Ah great, that'll do the job.

Thu, Jun 27, 9:45 PM · Wikimedia-Site-requests, TimedMediaHandler
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

I have this ready to run on mwmaint1002 but want to wait until the fix for the fatal error in T226748 is deployed so I don't spam the error logs.

Thu, Jun 27, 9:30 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler
brion claimed T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object.
Thu, Jun 27, 9:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

cleanupTranscodes.php should be able to do this I believe, I'll test offline later.

Thu, Jun 27, 12:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler

Wed, Jun 26

brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

(main difference from previous behavior is that in practice most videos got the image with popup link where now they get a video directly)

Wed, Jun 26, 10:46 PM · Browser-Support-Internet-Explorer, TimedMediaHandler-Player
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Ehhh, it's not hard to add a fallback image link that points to the file page. But I wouldn't necessarily block on it if it's not done soon.

Wed, Jun 26, 10:45 PM · Browser-Support-Internet-Explorer, TimedMediaHandler-Player

Mon, Jun 24

brion added a comment to T217085: Enable TimedMediaHandler video player in articles on mobile (instead of hyperlink to unplayable video).

Note that with the "New video player" beta feature enabled, this can be tested in production -- just make sure you're logged in in the mobile browser and it will pick up the preference.

Mon, Jun 24, 5:34 PM · Readers-Web-Backlog (Tracking), Mobile, TimedMediaHandler
brion claimed T226371: Beta player slow at loading many videos in Firefox.

Probably should adjust the preload setting; ISTR some related issue in past. Will test further once no longer encountering unrelated server errors.

Mon, Jun 24, 10:27 AM · WMSE-Bug-Reporting-and-Translation-2019, Performance, TimedMediaHandler-Player

Sun, Jun 23

brion added a comment to T226311: Full size videos displayed as small videos in gallery.

Yeah, looks like we only read 1024 header bytes and it appears later in both those files, around 4000+ bytes in.

Sun, Jun 23, 6:39 PM · Patch-For-Review, MediaWiki-File-management, MediaWiki-Gallery, Multimedia, Commons
brion added a comment to T203413: a small audio ogg file does not get played in full.

Confirmed that it's resolved with the video,js player frontend ("New video player" in beta features preferences)

Sun, Jun 23, 6:31 PM · TimedMediaHandler-Player

Sat, Jun 22

brion claimed T226311: Full size videos displayed as small videos in gallery.

I was able to reproduce this locally using the files via InstantCommons, and it looks like the root problem is that some of the files are misidentifed as audio, causing the packed-gallery code to use a small icon width instead of a large width constraint here:

Sat, Jun 22, 5:57 PM · Patch-For-Review, MediaWiki-File-management, MediaWiki-Gallery, Multimedia, Commons
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

Note the root problem appears to be that some of the files are incorrectly marked as audio, causing a small width to be used for making thumbnails instead of a large one:

Sat, Jun 22, 5:50 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

@Eatcha can you file a task for the unexpectedly small videos in gallery, and we'll track it down on that task. Thanks!

Sat, Jun 22, 5:25 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

They seem to be small whether the old or new players are in use. Not quite sure why yet, will look into in a bit -- those are full size videos and should not be showing tiny... The polar bear video is low resolution, and seems to show at its native size. We may need to adjust things to ensure that video players can be sized larger than their originals?

Sat, Jun 22, 5:23 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler

Thu, Jun 20

brion closed T200813: JobQueueGroup::singleton()->getQueueSizes() returns 0 for all queues in production as Resolved.

Closing as this was worked around where needed.

Thu, Jun 20, 7:49 PM · TimedMediaHandler-Transcode, MediaWiki-JobQueue

Tue, Jun 18

Jdforrester-WMF awarded T174393: Video player should allow playback at multiple speeds a Like token.
Tue, Jun 18, 3:30 PM · TimedMediaHandler-Player, Wikimedia-Video
brion claimed T174393: Video player should allow playback at multiple speeds.
Tue, Jun 18, 2:53 PM · TimedMediaHandler-Player, Wikimedia-Video
brion added a comment to T174393: Video player should allow playback at multiple speeds.

Note that playbackRate support was recently contributed to ogv.js, so can be used when I finish packaging the new release. Shouldn't be hard to enable the rate control in the new video.js player...

Tue, Jun 18, 2:48 PM · TimedMediaHandler-Player, Wikimedia-Video
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

@Eatcha T174393 covers this; we can add it fairly easily soon (the necessary support for the Safari compatibility shim was recently added upstream; I just have to package a release and then enable the rate control)

Tue, Jun 18, 2:47 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
brion closed T225452: MW-Vagrant 'commons' role doesn't allow CORS needed for TMH video playback in Safari as Resolved.
Tue, Jun 18, 1:19 AM · MediaWiki-Vagrant

Jun 12 2019

brion added a comment to T116154: Support WebVTT subtitling.

Need to add a VTT parser; currently there's only a SRT parser that produces VTT-compatible objects which we can output in either format. Shouldn't be hard to add, just didn't get to it yet for the MVP. :D

Jun 12 2019, 4:30 PM · Patch-For-Review, TimedMediaHandler-TimedText, TimedMediaHandler
brion updated the task description for T225640: Video.js mode doesn't show subtitles by default on non-English sites.
Jun 12 2019, 4:28 PM · TimedMediaHandler-TimedText, TimedMediaHandler-Player
brion created T225640: Video.js mode doesn't show subtitles by default on non-English sites.
Jun 12 2019, 4:24 PM · TimedMediaHandler-TimedText, TimedMediaHandler-Player
brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

Basic patch added which is an updating of the old upstream PR. Seems to work but might have edge cases; I'm happy to merge it for now to get us rolling if it looks ok.

Jun 12 2019, 3:44 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
matmarex awarded T27707: Allow "html" in exif tags a Pterodactyl token.
Jun 12 2019, 3:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T224258: TimedText markup for bold, italic etc not parsed and displayed as plain text.

@TheDJ yes, it's now validated (and in many cases slightly manipulated to become conforming) before being served out. As long as the formatting uses <b>...</b> and <i>...</i> rather than wiki-style '''...''' or ''...'' it will work with the upcoming videojs player -- but the old Kaltura player we're still shipping doesn't understand those.

Jun 12 2019, 3:13 PM · TimedMediaHandler-TimedText

Jun 10 2019

brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

Upstream issue is: https://github.com/videojs/video.js/issues/5252

Jun 10 2019, 6:18 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion created T225452: MW-Vagrant 'commons' role doesn't allow CORS needed for TMH video playback in Safari.
Jun 10 2019, 6:08 PM · MediaWiki-Vagrant

Jun 6 2019

brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

@Johan @Ebe123 I've +2'd the latest patchset and added some configuration patchsets for production and MediaWiki-Vagrant. :) This should be ready to roll soon if no problems in testing.

Jun 6 2019, 9:31 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler

Jun 4 2019

brion added a comment to T27707: Allow "html" in exif tags.

Looks like the patch never got reviewed. I'll poke some people and see if we can get it moving.

Jun 4 2019, 5:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading

May 29 2019

Restricted Application added a project to T224612: Mailing list admin pass reset for winedale-l (for migration off lists.wikimedia.org): Operations.
May 29 2019, 6:08 PM · Operations, Wikimedia-Mailing-lists

May 28 2019

brion added a comment to T224522: PHP Fatal Error from ApiTimedText: Argument to WikiPage::factory must Title (WikiPage given).

Ah I see! Typo, should be $title where it's $page in this:

May 28 2019, 10:07 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikimedia-production-error, TimedMediaHandler
brion added a comment to T224367: TimedText not working on non-English wikis: Serves the translated namespace instead of canonical one for Commons files.

Ah yeah that'll do it. I'll get on it...

May 28 2019, 9:32 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), TimedMediaHandler, Regression, TimedMediaHandler-TimedText
brion claimed T224522: PHP Fatal Error from ApiTimedText: Argument to WikiPage::factory must Title (WikiPage given).
May 28 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikimedia-production-error, TimedMediaHandler

May 26 2019

brion claimed T224367: TimedText not working on non-English wikis: Serves the translated namespace instead of canonical one for Commons files.

I'll investigate this Monday, probably a regression in our recent changes.

May 26 2019, 7:33 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), TimedMediaHandler, Regression, TimedMediaHandler-TimedText

May 9 2019

Kristbaum awarded T100106: Replace Kaltura player with Video.js a Love token.
May 9 2019, 6:57 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Performance-Team, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler

May 7 2019

brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

Once per instance is probably ok, as it should be rare to have the same video over and over. Uh, except on the file page with versions maybe. >_<

May 7 2019, 9:33 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion claimed T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).
May 7 2019, 9:31 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

That ain't pretty. I'll see if can improve this.

May 7 2019, 9:31 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion added a comment to T222762: TMH subtitle fetch broken (nothing returned) for ForeignFileRepo / InstantCommons.

IIRC production Commons is fetched into Beta via ForeignAPIRepo, so it's seeing only the srt-format subtitles in its list that production Commons sees. It should fix up after production Commons gets the timedtext API...

May 7 2019, 9:30 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikimedia-Hackathon-2019, TimedMediaHandler-TimedText, TimedMediaHandler

May 2 2019

brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

Extension code that's dependent on specific interfaces should probably feature-detect for those specific interfaces with function_exists, class_exists etc rather than trusting version numbers as well -- and that can only be tested by running with the actual version. And you'd only detect failures (like using a new feature on the old version path) from running with the other version anyway, so I think they'd have to go together if that's something we want tested.

May 2 2019, 4:39 PM · MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown

May 1 2019

MichaelSchoenitzer awarded T100106: Replace Kaltura player with Video.js a Love token.
May 1 2019, 12:00 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Performance-Team, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler

Apr 23 2019

brion created T221657: 500 error when deleting ssh key from toolsadmin.
Apr 23 2019, 3:58 PM · cloud-services-team (Kanban), Striker
ToBeFree awarded T35186: Provide a well-performing API to rotate an image a Like token.
Apr 23 2019, 11:23 AM · Patch-Needs-Improvement, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-API

Apr 3 2019

nray awarded T18691: RFC: Section headings should have a clickable anchor a Like token.
Apr 3 2019, 5:53 PM · Patch-For-Review, Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Feb 28 2019

Niedzielski awarded T18691: RFC: Section headings should have a clickable anchor a Love token.
Feb 28 2019, 3:37 PM · Patch-For-Review, Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Feb 27 2019

brion claimed T138770: TMH video.js-mode 'info' button link normalization.
Feb 27 2019, 8:16 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), TimedMediaHandler, TimedMediaHandler-Player

Feb 21 2019

brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

(Just noting I'll be ready to work more on this in around next week-ish)

Feb 21 2019, 9:49 PM · Patch-For-Review, TimedMediaHandler
brion created T216673: Unable to install php-tidy during MediaWiki-Vagrant setup.
Feb 21 2019, 3:54 AM · MediaWiki-Vagrant

Feb 5 2019

brion created T215344: Add overlay notice recommending modern browser on slow ogv.js playback.
Feb 5 2019, 8:32 PM · TimedMediaHandler-Player

Feb 1 2019

brion added a comment to T27707: Allow "html" in exif tags.

https://www.flickr.com/photos/tinto/30943950124/ and other photos from this Flickr user.

Feb 1 2019, 10:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

The above patch https://gerrit.wikimedia.org/r/487527 removes some of the non-scripting tags from the checks in UploadBase::detectScript, and makes the conservative/exact IE heuristics called from UploadBase::verifyMimeType optional (but still on by default). This also deprecates $wgAllowTitleInSVG since <title is no longer looked for.

Feb 1 2019, 7:56 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

Ok, looking at the actual current code now... UploadBase::detectScript does the check, and combines several things:

  • looks at first 1024 bytes (more than IE checks) if binary, or all if text
  • does some text encoding checks (seems to be SVG-specific?)
  • looks for IE's trigger tags for type detection
  • looks for some Safari (old Safari?) trigger works for plain-specific type detection
  • decodes XML-style char references (seems to be SVG-specific)
  • looks for some script-like things CSS-like URLs in body content that seem to be SVG-specific
Feb 1 2019, 6:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

Though this is not needed to remove this MIME sniffing check (or at the very least, make it optional), as I've shown it can't be exploited unless the webserver is misconfigured. So it doesn't apply to Wikimedia projects.

Feb 1 2019, 5:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

@Aklapper I believe it's very on-topic to discuss the security implications of a suggested feature change. Where would you suggest we discuss this if not here, on this task?

Feb 1 2019, 5:18 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading

Jan 29 2019

brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

Thanks! Didn't mean to rush you, I'll probably poke at this next week unless I get inspired. :)

Jan 29 2019, 9:41 PM · Patch-For-Review, TimedMediaHandler

Jan 28 2019

brion added a comment to T27707: Allow "html" in exif tags.

Double-checking:

  • IE 6 and 7 were both available on Windows XP, which includes TLS 1.0 support but not TLS 1.1 or 1.2. However IE 6-8 on XP fail to work anyway due to lack of SNI.
    • This takes IE 6 off the table entirely.
  • IE 7 on Vista should still work correctly with TLS 1.0, 1.1, or 1.2 -- https://blogs.msdn.microsoft.com/kaushal/2011/10/02/support-for-ssltls-protocols-on-windows/
  • IE8 supports X-Content-Type-Options: nosniff header; if we don't already use it consistently, applying this on all file views would resolve all sniffing issues on IE 8
Jan 28 2019, 11:35 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

The chance that someone would visit using an old IE version was probably 50% when the code was originally added; IE had a very high marketshare in the early 2000s. However at this point we can't even be accessed in IE 6 as far as I know (due to servers dropping old TLS versions for HTTPS). I think it's pretty fair to change the balance of what we check for.

Jan 28 2019, 10:58 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

@zeljkofilipin should I take this task? I'll need to grab some documentation for starters or else grab you later when we have time. :)

Jan 28 2019, 10:13 PM · Patch-For-Review, TimedMediaHandler
brion created T214864: requeueTranscodes gets confused in some cases where null entries are left in place.
Jan 28 2019, 8:55 PM · TimedMediaHandler-Transcode

Jan 23 2019

osorio-juan-microsoft awarded T18691: RFC: Section headings should have a clickable anchor a Burninate token.
Jan 23 2019, 7:12 PM · Patch-For-Review, Readers-Web-Backlog (Design), TechCom-RFC, Design, MediaWiki-Interface

Jan 4 2019

brion added a comment to T178592: decommission/replace bast4001.wikimedia.org.

Note that bast4001 no longer works for login?

Jan 4 2019, 10:13 PM · decommission, Operations, ops-ulsfo

Jan 3 2019

brion added a comment to T212482: Evolve hook system to support "filters" and "actions" only.

A few quick notes:

  • we should sketch out a few extensions in this model -- I'll take a look at some later in the week
  • aggressively pushing action hooks to deferred or jobqueue means we need to be much better about making the job queue *work* reliably (and quickly) on small installs
  • immutable interfaces are probably sufficient for most of what we want on hook params, without necessarily needing to create full value classes for everything. We want both sides of the hook to know what's promised & what's allowed & what might change from under you
  • side effects issues are something to consider more, about guarantees vs recommendations. needs some real-world testing to see where these guidelines lie
Jan 3 2019, 6:55 AM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom

Jan 2 2019

brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

Using a define sounds good to me, but it seems modern code is not using this style. So having a class constant is also a way to do it. I did not prefer any way here.

Jan 2 2019, 9:52 PM · MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

MediaWikiVersionFetcher would need to be altered as well, which currently looks for $wgVersion being set in DefaultSettings.php

Jan 2 2019, 9:29 PM · MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown
brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

Sensible enough. :) I'd recommend MW_VERSION as the constant name; but should it be set in DefaultSettings.php where $wgVersion is set now, or up in defines.php or elsewhere? May also need to update documentation about cutting release versions (updated location of the changed version).

Jan 2 2019, 9:14 PM · MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown

Dec 28 2018

brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

Confirmed it fixed the VM on the Linux PC too. Sweeeeeeeeeeet!

Dec 28 2018, 5:28 PM · Patch-For-Review, MediaWiki-Vagrant

Dec 25 2018

brion closed T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2 as Resolved.

Woohoo! I'll close this out now as fixing my main case (on the Mac where it almost worked) and will confirm Friday on the Linux PC and if that doesn't resolve it there will just reimage it.

Dec 25 2018, 9:16 PM · Patch-For-Review, MediaWiki-Vagrant
brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

@brion Want to give the above patch a go? Not perfect, but improves it a bit

Dec 25 2018, 4:07 PM · Patch-For-Review, MediaWiki-Vagrant
brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

On the Mac (where the extensions installed but php-cli didn't), php was gone again when needed for composer runs via vagrant git-update:

Dec 25 2018, 8:04 AM · Patch-For-Review, MediaWiki-Vagrant
brion added a comment to T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.

@Reedy I'm out of town for a couple days for the holiday so can't retest just now, will poke again later in the week. But I think it was around commit dca68a5c3db8f338bb8b00b3e014c3b1d1308a99 (mid-November) when I last updated it successfully.

Dec 25 2018, 7:33 AM · Patch-For-Review, MediaWiki-Vagrant

Dec 22 2018

brion created T212552: Vagrant is missing a bunch of PHP extensions after updating from HHVM to PHP 7.2.
Dec 22 2018, 2:25 AM · Patch-For-Review, MediaWiki-Vagrant

Nov 14 2018

brion added a comment to T209437: Migrate primary Wikimedia video format from VP9 to AV1.

Note that this is dependent on suitable playback support being widespread. While on desktops, Chrome and Firefox are shipping AV1 now or in next versions, and Microsoft is previewing it for Edge, we don't yet know the situation for Safari. I've started adding AV1 decode to ogv.js, but it's slower than decoding VP9 so far so may require running lower resolutions (unless WebAssembly threading arrives soon on Safari).

Nov 14 2018, 12:44 AM · TimedMediaHandler
brion added a comment to T209440: Add support for AV1 as an ingestion and transcoding target format.

Ingest should be a matter of having a suitable ffmpeg & libaom package backport, and a small update to make sure we're allowing AV1 codec in WebM container. Note there will also be MP4-flavored AV1 out in the world, but we don't yet know how popular that will be as flat files (versus DASH/HLS/streaming).

Nov 14 2018, 12:37 AM · TimedMediaHandler

Nov 11 2018

Liuxinyu970226 awarded T134455: Add experimental option for direct SVG output via srcset a Like token.
Nov 11 2018, 12:20 PM · Patch-For-Review, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering, Multimedia
Liuxinyu970226 awarded T187872: Support IIIF Image API for thumbnailing & tiling of images a Like token.
Nov 11 2018, 12:18 PM · Multimedia, Commons, MediaWiki-File-management
Liuxinyu970226 awarded T34284: Update Echo Notifications in real time without page reloads a Love token.
Nov 11 2018, 8:16 AM · User-notice, Growth-Team, Collaboration-Team-Triage, Notifications

Nov 8 2018

brion added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Storage note: may need/want to include a reverse-domain copy of the domain for indexing purposes for bulk lookups.

Nov 8 2018, 7:35 AM · TechCom-RFC, TechCom, Security-Team, Security
brion added a comment to T208188: Proposal for partial opt-out method for Content security policy.

(my concern being the possibility of getting people to agree to click-through things they shouldn't; attacker script wouldn't be able to auth/confirm the form, in theory)

Nov 8 2018, 6:52 AM · TechCom-RFC, TechCom, Security-Team, Security
brion added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Another suggestion that ive heard is have some sort of friendlier interstitial similar to oauth that people can agree to. Or have it part of the gadget config and people opt in when they enable a gadget that needs it

Nov 8 2018, 6:44 AM · TechCom-RFC, TechCom, Security-Team, Security

Nov 7 2018

brion closed T208710: Raise version number of TMH as Resolved.

Version bumped, and README includes a little info on the changes to config.

Nov 7 2018, 11:46 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, TimedMediaHandler
brion added a comment to T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.

Yep, our bad -- we didn't document the breaking changes to config. :( Try this:

Nov 7 2018, 11:30 PM · TimedMediaHandler

Nov 5 2018

TheDJ awarded T27611: Support optimized WebP thumbnails as alternative to JPEG, PNG a Barnstar token.
Nov 5 2018, 1:54 PM · Performance-Team, Commons, Multimedia, MediaWiki-File-management

Oct 30 2018

MusikAnimal awarded T145703: Horizon loses credentials every day a Cup of Joe token.
Oct 30 2018, 3:37 AM · cloud-services-team (Kanban), Horizon

Oct 25 2018

brion updated the task description for T206077: Wikimedia Technical Conference 2018 Session - Improving frontend testing and logging.
Oct 25 2018, 11:27 PM · Wikimedia-Technical-Conference-2018
brion updated the task description for T206077: Wikimedia Technical Conference 2018 Session - Improving frontend testing and logging.
Oct 25 2018, 11:23 PM · Wikimedia-Technical-Conference-2018

Oct 9 2018

brion closed T205811: Video clip in 4:2:2 chroma subsampling fails to play in Chrome as Resolved.

I didn't manage to do an early push because I was out sick most of last week, but it should be live now, and the re-rendered file works for me so hoping it's fine for @jeblad. :)

Oct 9 2018, 5:52 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, TimedMediaHandler-Transcode, TimedMediaHandler

Oct 1 2018

Liuxinyu970226 awarded T107595: [RFC] Multi-Content Revisions a Dislike token.
Oct 1 2018, 11:43 PM · Multi-Content-Revisions, Core Platform Team Workboards (Done with CPT), Core Platform Team (MCR), Epic, User-Daniel, Wikidata-Sprint-2015-11-17, Wikimedia-Developer-Summit-2016, Wikidata, Wikidata-Sprint-2015-09-15, TechCom-RFC