Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (24)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (284 w, 3 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Thu, Mar 19

brion claimed T245377: Video.js player doesn’t work with Score.

Grabbing a couple high-prio TMH issues to work on the next week or two. Looks like a bug in the surrounding JS that assumes some things are marked up in one way but they aren't for Score stuff.

Thu, Mar 19, 6:14 PM · Regression, TimedMediaHandler, MediaWiki-extensions-Score
brion closed T248109: TimedMediaHandler has php deprecation warnings about unparenthesized expressions when running with php7.4 as Resolved.

now success :) https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-docker/1572/console

Thu, Mar 19, 6:13 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), PHP 7.4 support, TimedMediaHandler
brion claimed T248109: TimedMediaHandler has php deprecation warnings about unparenthesized expressions when running with php7.4.
Thu, Mar 19, 5:07 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), PHP 7.4 support, TimedMediaHandler

Sat, Mar 7

brion added a comment to T246930: Increase Docker image's PHP upload limit from 2 MiB to 100 MiB.

Confirmed working on a fresh install, thanks all!

Sat, Mar 7, 2:20 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), User-brennen, Release-Engineering-Team, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), dev-images, MediaWiki-Docker
brion created T247153: ffmpeg in MW-Docker lacks -row-mt option for improved multithreaded VP9 encoding.
Sat, Mar 7, 2:20 AM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, dev-images, MediaWiki-Docker, Release-Engineering-Team (Local Dev)

Thu, Mar 5

brion added a comment to T246942: TimedMediaHandler's ffmpeg processes get stuck when using resource limits on Docker image.

T206957 is the related ticket.

Thu, Mar 5, 9:48 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, MediaWiki-Docker

Wed, Mar 4

brion created T246953: Docker MW installation command line doesn't work on Windows command shell or PowerShell.
Wed, Mar 4, 10:39 PM · User-kostajh, Patch-For-Review, MediaWiki-Docker
brion added a comment to T246935: Job queue runners for MediaWiki-Docker.

I think principle of least surprise leads us to want a job queue that is processed automatically without manual intervention, as it's meant to be a continuously-operating part of the MediaWiki service that code can rely on being in working condition.

Wed, Mar 4, 9:45 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, dev-images, MediaWiki-Docker
brion created T246942: TimedMediaHandler's ffmpeg processes get stuck when using resource limits on Docker image.
Wed, Mar 4, 8:49 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, MediaWiki-Docker
brion created T246935: Job queue runners for MediaWiki-Docker.
Wed, Mar 4, 7:23 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, dev-images, MediaWiki-Docker
brion created T246930: Increase Docker image's PHP upload limit from 2 MiB to 100 MiB.
Wed, Mar 4, 7:13 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), User-brennen, Release-Engineering-Team, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), dev-images, MediaWiki-Docker

Feb 25 2020

brion added a comment to T246035: Videojs player for audio opens a dialog, which is unexpected.

The alternative would be to replace the player 'inline', but then we'd have to jump through hoops to get subtitles for audio again.

Feb 25 2020, 6:37 PM · VideoJS player

Feb 17 2020

Demian awarded T18691: RFC: Section header "share" link a Yellow Medal token.
Feb 17 2020, 12:28 AM · User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Feb 10 2020

brion added a comment to T31118: Add HTML 5 semantic elements 'details' and 'summary' to Sanitizer whitelist.

From caniuse it looks like IE and old Edge are the holdouts (new Chromium based edge supports it, as well as reasonably current versions of other browsers)

Feb 10 2020, 7:14 PM · MediaWiki-Parser
brion added a comment to T31118: Add HTML 5 semantic elements 'details' and 'summary' to Sanitizer whitelist.

Neat! We should probably confirm the behavior is consistent, predictable, and either falls back cleanly or can be emulated sanely (eg in IE 11 if it doesn't support it). Also double check that neither tag is used as an extension. Then I probably have no further objection. :)

Feb 10 2020, 7:12 PM · MediaWiki-Parser

Feb 9 2020

brion added a comment to T211484: UploadBlacklist is missing licensing.

I think I wrote this yes... we'd consider this as GPLv2-or-later as part of MediaWiki. It wasn't originally labeled in detail as it was a one-off production hack that ended up being kept around, and we weren't as careful with explicit labeling on extensions back then.

Feb 9 2020, 7:35 AM · MediaWiki-extensions-UploadBlacklist, Software-Licensing

Feb 7 2020

brion added a comment to T244570: Create thumbnail for MPEG videos.

Patch is https://gerrit.wikimedia.org/r/569341

Feb 7 2020, 7:44 PM · TimedMediaHandler
brion claimed T244570: Create thumbnail for MPEG videos.

Patch for thumbor is in the works, needs to finish adding test cases which I'll try to do this weekend so it's ready to go out when ready.

Feb 7 2020, 7:43 PM · TimedMediaHandler

Feb 4 2020

brion created T244273: thumbor-plugins offline tests don't work on Debian Stretch.
Feb 4 2020, 6:48 PM · Thumbor

Feb 1 2020

brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

From the IRC log, a couple of the transaction IDs that returned 500 errors with odd messages about Swift being missing or disabled:

Feb 1 2020, 10:08 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback.

Roughly planning to soft-launch this and try replacing some of the manual .ogv conversions of old mpeg1 and 2 files from scientific papers with the originals. I'll track that on a separate task once the release train brings it live.

Feb 1 2020, 9:38 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), TimedMediaHandler-Transcode, Patch-For-Review, UploadWizard, WMF-Legal, Commons, Multimedia
brion added a project to T244067: New thumbnail generation fails for c:File:X mark.svg: Wikimedia-SVG-rendering.
Feb 1 2020, 8:42 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

@Aklapper it is an svg file being rendered to png, so I think that should stay unless we can confirm that rendering succeeded and the error was at a later stage of serving.

Feb 1 2020, 8:01 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

Ah fun, intermittent problems. :) Should be findable in logs ...

Feb 1 2020, 6:04 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

https://upload.wikimedia.org/wikipedia/commons/thumb/a/a2/X_mark.svg/526px-X_mark.svg.png is rendering ok for me at present. What error message is displayed for you?

Feb 1 2020, 5:59 PM · Wikimedia-SVG-rendering, Thumbor

Jan 31 2020

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Seem to have worked around the deprecation issue by simply not shutting down the lock manager or file group, but will test more thoroughly to see if that breaks anything later...

Jan 31 2020, 1:23 AM · TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Looks like a little bitrot has hit this patch, with the deprecation of resetServiceForTesting outside unit tests the closing of services ends up failing.

Jan 31 2020, 12:13 AM · TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, MediaWiki-Maintenance-scripts

Jan 28 2020

brion added a comment to T243562: Commons video player does not work on IE 11 or older versions of Safari.

Can you check with this page? https://brionv.com/misc/vidtest/

Jan 28 2020, 11:37 PM · TimedMediaHandler, Commons, Fundraising-Backlog

Jan 26 2020

brion added a comment to T18763: Present list of matching timezone locations based on client offset.

This is much better than my originally suggested hack. :) +2'ing it.

Jan 26 2020, 3:34 AM · MediaWiki-User-preferences
brion added a comment to T40271: Review and deploy SVGEdit extension to Wikimedia wikis.

Still think this'd be a great base for us to work on, should there be time and energy to spend on it.

Jan 26 2020, 3:03 AM · Wikimedia-extension-review-queue, Commons, Wikimedia-Extension-setup

Jan 25 2020

brion claimed T243562: Commons video player does not work on IE 11 or older versions of Safari.
Jan 25 2020, 10:01 PM · TimedMediaHandler, Commons, Fundraising-Backlog
brion added a comment to T243562: Commons video player does not work on IE 11 or older versions of Safari.

Hmm, https://commons.wikimedia.org/wiki/File:Wikipedia_-_Edit_2019.webm?embedplayer=yes is currently working for me in IE 11 (though with low performance) and should be working in Safari as well (with much better performance). Can you confirm whether the URL works independently of the iframe, or whether it only fails in the iframe?

Jan 25 2020, 10:01 PM · TimedMediaHandler, Commons, Fundraising-Backlog

Jan 17 2020

brion added a comment to T227074: Transcoding fails for large videos for QHD and UHD resolution.

I suspect it's the file size limit yes -- ffmpeg seems to be exiting with SIGXFSZ (signal 25, exit code 153) which means 'exceeded file size'. This is probably not the file system limit, but the resource limit applied to the transcode process? However transcodes going over 4 GB may have trouble being stored anyway. :(

Jan 17 2020, 9:21 PM · TimedMediaHandler-Transcode
brion closed T150066: Opaque error creating webm transcodes at low frame rates, a subtask of T157028: Many transcodes still fail, as Resolved.
Jan 17 2020, 9:13 PM · Wikimedia-General-or-Unknown, TimedMediaHandler-Transcode
brion closed T150066: Opaque error creating webm transcodes at low frame rates as Resolved.

Seems to have been resolved in the meantime, probably by using updated ffmpeg on servers.

Jan 17 2020, 9:13 PM · TimedMediaHandler-Transcode
brion closed T158287: Add option to requeueTranscodes.php to restrict processing to high or low priority queue as Invalid.

Guess this didn't seem that important, closing out.

Jan 17 2020, 9:10 PM · TimedMediaHandler-Transcode
brion closed T200747: Batch-convert old video files for new VP9/opus format as Resolved.

All this ran, and later a bunch re-ran, some time ago. Closing out.

Jan 17 2020, 9:08 PM · TimedMediaHandler-Transcode
brion closed T133500: Choose a way to improve playback of very small thumbnails as Resolved.

We chose to reimplement with oojs ui and have implemented.

Jan 17 2020, 8:58 PM · VideoJS player
brion closed T226314: Video.js controls inaccessible in "packed-hover" gallery mode as Resolved.

New click-to-load mode behaves more like the old mode, and seems ok here. Closing out.

Jan 17 2020, 8:56 PM · VideoJS player, Multimedia, MediaWiki-Gallery
brion closed T226371: Beta player slow at loading many videos in Firefox as Resolved.

This seems to be largely dealt with the new load-on-click mode, I'm going to close it out.

Jan 17 2020, 8:55 PM · VideoJS player, WMSE-Bug-Reporting-and-Translation-2019, Performance Issue

Jan 16 2020

brion claimed T243018: Pages in TimedText namespace have wgRevisionId set to 0.

Probably a side-effect of how the subtitle pages are specially rendered...

Jan 16 2020, 9:14 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), TimedMediaHandler-TimedText
brion claimed T242966: PHP Warning: XMLReader::open(): Memory allocation failed : escaping URI value.

This seems to be due to a corruption problem in Photoshop or some other editing tool that produces a huge amount of extra junk data in the XMP metadata. You can find reports of this problem on forums like here: https://feedback.photoshop.com/photoshop_family/topics/corrupt-ancestors-tag-in-xmp-causing-giant-file-sizes-in-photoshop

Jan 16 2020, 5:29 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Commons, MediaWiki-File-management, Wikimedia-production-error

Jan 15 2020

brion added a comment to T191805: Allow Mediawiki to store file size greater than 32 bits.

The fields are currently defined in tables.sql as int unsigned which is a 32-bit type with a range from 0 to 2^32 - 1 (one byte shy of 4 GiB). To record sizes of files of 4 GiB or higher, redefining them as bigint unsigned, a 64-bit type, would be required.

Jan 15 2020, 1:45 AM · MediaWiki-File-management, Commons, Multimedia

Jan 14 2020

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Latest rev of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/553442 includes a quick-fix for that: an inline transform property is added which adds the playsinline attribute and a mw-tmh-inline class which has the on-load transforms set up video.js for that player instead of turning it into a popup player trigger. This is then forced on for the embedded-iframe view.

Jan 14 2020, 9:56 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

(Well, not exactly broken, but ... kind of weird. ;) It forces the popup to run inside the iframe, which adds a title bar even at small sizes.)

Jan 14 2020, 4:30 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Acknowledged, ?embedplayer=yes mode is indeed broken with those changes. ;_; I'll fix that shortly.

Jan 14 2020, 4:27 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Jan 13 2020

brion added a comment to T209437: Migrate primary Wikimedia video format from VP9 to AV1.

Native CPU-run VP9 seems pretty ok through 720p on my lower-spec machines, but YMMV. :) AV1 is much more CPU-intensive and I definitely don't recommend switching to it wholesale yet, especially at high resolutions.

Jan 13 2020, 5:35 PM · TimedMediaHandler-Transcode

Jan 6 2020

brion closed T240488: Network issues reaching phabricator on IPv6 (Comcast/Portland OR) as Resolved.

Definitely saw it on https, on phab. The ipv6 timeout behavior makes it hard to see reliably so not sure if it was hitting other sites consistently but the packet loss on ping to load balancer was suspicious.

Jan 6 2020, 9:23 PM · netops, Operations

Dec 20 2019

Dzahn awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Orange Medal token.
Dec 20 2019, 3:27 AM · Office-IT

Dec 19 2019

brion added a comment to T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter.

Thanks all! I'll try the email queue next time something crops up for future reference. :)

Dec 19 2019, 8:50 PM · Office-IT
Niharika awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Cookie token.
Dec 19 2019, 5:31 PM · Office-IT
Elitre awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Burninate token.
Dec 19 2019, 5:31 PM · Office-IT
ArielGlenn awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a 100 token.
Dec 19 2019, 5:30 PM · Office-IT
greg awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Y So Serious token.
Dec 19 2019, 5:29 PM · Office-IT
jrbs awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a Manufacturing Defect? token.
Dec 19 2019, 5:28 PM · Office-IT
Mholloway awarded T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter a The World Burns token.
Dec 19 2019, 5:28 PM · Office-IT
brion created T241157: XKCD "Citation needed" comic in Chandra Wiseman room is off-kilter.
Dec 19 2019, 5:27 PM · Office-IT

Dec 17 2019

brion added a comment to T240837: MP4 files are not listed as videos on special page.

Could remove it yeah Special:MediaStatistics does that top section better. Maybe stick in a link for good measure as a related info? I think Special:TimedMediaHandler should concentrate on the transcode status info (and maybe get renamed to match).

Dec 17 2019, 9:35 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), User-TheDJ, TimedMediaHandler

Dec 11 2019

brion added a comment to T240488: Network issues reaching phabricator on IPv6 (Comcast/Portland OR).

sudo mtr -z -s 1000 -T -P 443 phabricator.wikimedia.org gives similar results:

Dec 11 2019, 9:51 PM · netops, Operations
brion created T240488: Network issues reaching phabricator on IPv6 (Comcast/Portland OR).
Dec 11 2019, 6:45 PM · netops, Operations

Dec 10 2019

brion added a comment to T240368: Transcoding job is reported as failed before it's completed.

Looking... it looks like on success transcode_error is cleared but transcode_time_error is not. However it shouldn't be getting set in the first place unless something's awry...

Dec 10 2019, 7:59 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Patch-For-Review, TimedMediaHandler-Transcode

Dec 5 2019

brion closed T239831: VP9-enabled ffmpeg doesn't get installed after reimage of mw job runner/video scaler as Resolved.
Dec 5 2019, 9:54 PM · serviceops, Operations
brion added a comment to T239831: VP9-enabled ffmpeg doesn't get installed after reimage of mw job runner/video scaler.

Ok, I'll run:

Dec 5 2019, 4:38 PM · serviceops, Operations
brion added a comment to T239831: VP9-enabled ffmpeg doesn't get installed after reimage of mw job runner/video scaler.

Ideally: fix the installs ASAP :) If can't be done: disable $wgFFmpegVP9RowMT and that should hopefully work if it reverted to a version that groks vp9 but doesn't know the -row-mt option.

Dec 5 2019, 3:25 PM · serviceops, Operations

Nov 27 2019

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

I think the audio player will be a problem. Native players are pretty big and we often have very restrictive spacing. Don’t know a good design either though..

Nov 27 2019, 11:02 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Updated https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/529819/ to use the better minified package. Much smaller JS payload now. :)

Nov 27 2019, 8:33 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion closed T216345: Unrecognized option 'max_muxing_queue_size' as Resolved.

What should be cleaned up?

Nov 27 2019, 8:04 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), TimedMediaHandler-Transcode
brion added a comment to T216345: Unrecognized option 'max_muxing_queue_size'.

Ah, OSs shipping old stuff is always fun. :D No real danger to it, and it's clear enough in the code if we refactor and clean it out later. :)

Nov 27 2019, 2:08 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), TimedMediaHandler-Transcode
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

@TheDJ let's try using it without wgMinimumVideoPlayerSize and drop it back in if we decide the always-transformation is confusing.

Nov 27 2019, 12:02 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Nov 26 2019

brion added a comment to T216345: Unrecognized option 'max_muxing_queue_size'.

I'm a bit reluctant to add explicit support for obsolete versions of ffmpeg, since it'll never get tested and other things that break it are likely to be added. Is there a reason you're running an out of date ffmpeg?

Nov 26 2019, 11:51 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), TimedMediaHandler-Transcode
brion added a comment to T232563: Drop IE6 and IE7 basic compatibility and security support.

@AlexisJazz sorry about any frustration from the on-Commons discussion in January. It took some discussion of our own on Phabricator to decide what to do, both about the incorrect HTML security trigger and about the more general removal of obsolete checks, and communication wasn't and still isn't very consistent. Sometimes you get advice on-wiki that's based on the current general state of things, but the state of things changes -- we have indeed decided that the IE 6/7 content-type-sniffing vulnerability is no longer a serious security consideration, but in January we hadn't decided that yet so you were given advice based on the current state of the world.

Nov 26 2019, 6:22 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MW-1.34-notes, User-notice, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-General

Nov 15 2019

brion added a comment to T237942: Video viewer menus may become unusable on mobile.

This is a compat problem with the old player; the new player mode is getting an update and should get merged soonish, and it's fully functional on mobile.

Nov 15 2019, 2:55 PM · Mobile, Kaltura player

Nov 7 2019

brion added a comment to T237688: Raise MW JS requirement to include ES6 Promise (drop IE11, Safari 5-6, and Android 4.1-4.3).

Note that a Promise polyfill can be loaded at the cost of a few kb of compat code, but there's so many other reasons to want to deprecate IE 11 and to move to newer JS versions and most of the other things can't be polyfilled so easily.

Nov 7 2019, 9:14 PM · Patch-For-Review, Browser-Support-Android-Google-Chrome, Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, JavaScript, Performance-Team, Browser-Support-Internet-Explorer

Oct 21 2019

brion added a comment to T235436: Vagrant installation fails.

I have some more diagnostic info on T235934 for what appears to be the same problem (installing mobilefrontend). Workaround is to manually clone extensions/MobileFrontend and re-run vagrant provision.

Oct 21 2019, 5:38 PM · Readers-Web-Backlog (Tracking), MediaWiki-Vagrant, WMSE-Bug-Reporting-and-Translation-2019, MobileFrontend

Oct 18 2019

brion added a comment to T235934: MediaWiki-Vagrant's "mobilefrontend" role fails to install MobileFrontend extension.

Yeah, looks like it's dying in the same place over on that one.

Oct 18 2019, 11:45 PM · Readers-Web-Backlog (Tracking), MobileFrontend, MediaWiki-Vagrant
brion created T235934: MediaWiki-Vagrant's "mobilefrontend" role fails to install MobileFrontend extension.
Oct 18 2019, 11:39 PM · Readers-Web-Backlog (Tracking), MobileFrontend, MediaWiki-Vagrant

Oct 17 2019

MusikAnimal awarded T18691: RFC: Section header "share" link a Love token.
Oct 17 2019, 10:16 PM · User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Oct 15 2019

brion added a comment to T234582: Remove IE 6 & 7 hacks and workarounds from core & extensions.

Change 542715 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Replace IE 4-7 compatible code with standard syntax
https://gerrit.wikimedia.org/r/542715

Oct 15 2019, 9:06 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Technical-Debt, Front-end-Standards-Group, Browser-Support-Internet-Explorer, CSS, MediaWiki-General
Trizek awarded T18691: RFC: Section header "share" link a Like token.
Oct 15 2019, 10:09 AM · User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Oct 10 2019

brion added a comment to T235228: Error undeleting file: "File was missing before deletion".

Sounds like some of that sequence resulted in a conflict that didn't get handled well at the time. Following the error message back to the code symptom, the case is this in LocalFileRestoreBatch.php:

Oct 10 2019, 10:27 PM · MediaWiki-File-management, SRE-swift-storage, Wikimedia-production-error

Oct 2 2019

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Does Video.js release imply enablement on MobileFrontend? If so, we may want to require lazy-loading on click after all. Or keep it desktop-only at first.

Oct 2 2019, 4:59 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)

Sep 26 2019

brion added a comment to T232354: New vagrant instance not setting password for `admin` user to `vagrant`.

I've updated the documentation at https://www.mediawiki.org/wiki/MediaWiki-Vagrant to link to this bug report and mention that you can manually log in with vagrant ssh and run mwscript maintenance/changePassword.php --user=Admin --password=vagrant to set the initial password.

Sep 26 2019, 6:11 PM · Patch-For-Review, MediaWiki-Vagrant

Sep 24 2019

brion closed T136671: Intermittent bandwidth issue to labs proxy (eqiad) from Comcast in Portland OR as Resolved.

Haven't encountered this in a while; Comcast etc may have improved the intermediate routes. Closing out as resolved.

Sep 24 2019, 6:45 PM · Operations, Cloud-Services, netops

Sep 19 2019

brion added a comment to T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.

Looks like the audio wasn't getting initialized at the right time (how did it work on iOS? no clue!) unless mwEmbedSupport has already been loaded.

Sep 19 2019, 8:52 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, Kaltura player
brion updated the task description for T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.
Sep 19 2019, 8:26 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, Kaltura player
brion created T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.
Sep 19 2019, 8:23 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, Kaltura player

Sep 17 2019

Perhelion awarded T106240: Colorable SVG a Yellow Medal token.
Sep 17 2019, 7:59 AM · TechCom-RFC, Wikimedia-SVG-rendering

Sep 11 2019

brion added a comment to T229433: ResourceLoaderWikiModule.php: PHP Notice: Undefined index: .

Looks like in PHP 7.2 the empty string gets interned to a special shared instance (zend_empty_string)... It's possible something's corrupting zend_empty_string, either its contents or its hash (h) field. If we can get a core dump it should be possible to inspect the symbol...

Sep 11 2019, 9:15 PM · Performance-Team, Wikimedia-production-error, MediaWiki-ResourceLoader

Aug 28 2019

brion renamed T228342: Define criteria for setting explicit PHP support target for MediaWiki from Set explicit PHP 7.2 support target for MediaWiki to Define criteria for setting setting explicit PHP support target for MediaWiki.
Aug 28 2019, 8:36 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
brion updated the task description for T228342: Define criteria for setting explicit PHP support target for MediaWiki.
Aug 28 2019, 8:34 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
brion renamed T228342: Define criteria for setting explicit PHP support target for MediaWiki from Set explicit PHP support target for MediaWiki to Set explicit PHP 7.2 support target for MediaWiki.
Aug 28 2019, 8:32 PM · Performance-Team, TechCom, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support

Aug 21 2019

brion added a comment to T230661: TimedMediaHandler audio captions are out of sync in Firefox (and possibly other browsers).

I'm still not sure I can reliably tell the difference but I trust you. :) Titles being sometimes late by random amounts up to 250ms seems like it would make sense given the poor latency guarantees on the timeupdate event, so I'm not sure there's much we can do directly here...

Aug 21 2019, 8:01 PM · Kaltura player, TimedMediaHandler-TimedText

Aug 20 2019

brion added a comment to T230661: TimedMediaHandler audio captions are out of sync in Firefox (and possibly other browsers).

Could this be latency from the timeupdate event? It can trigger with a wait as long as 250ms between events per spec.

Aug 20 2019, 11:27 PM · Kaltura player, TimedMediaHandler-TimedText

Aug 14 2019

brion added a comment to T230505: Parseroutput cache issue with videojs.

Note the parser cache key is not available to the hook. Fun!

Aug 14 2019, 6:50 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), TimedMediaHandler
brion added a comment to T230505: Parseroutput cache issue with videojs.

I think default mode is checked because there's a separate pcache suffix for folks using the beta-mode -- this is targeted at clearing the non-beta-mode entries after a site-config switch.

Aug 14 2019, 6:31 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), TimedMediaHandler
brion added a comment to T188831: Some thumbnail images delivered with wrong application/x-www-form-urlencoded mime-type.

The only POSTs I see in there are in setContainerAccess, addMissingHashMetadata, and doDescribeInternal, which all update existing files. Could be there's a hole in the logic of one of them that's dropping Content-Type, or that some files were missing it to begin with but it was being filled in on high-level fetches, or something, so they worked until something updated the data?

Aug 14 2019, 6:13 PM · Operations, Traffic, Multimedia, Thumbor, Commons, MediaWiki-File-management, SRE-swift-storage
brion added a comment to T188831: Some thumbnail images delivered with wrong application/x-www-form-urlencoded mime-type.

Hmm, I notice this in SwiftFileBackend.php:

Aug 14 2019, 6:08 PM · Operations, Traffic, Multimedia, Thumbor, Commons, MediaWiki-File-management, SRE-swift-storage
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Great, I'll tidy up this patch in a bit (once I get the subtitle lazy-loading patched back in) and we'll worry about lazy-loading later.

Aug 14 2019, 2:51 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Since AFAIK extensions are meant to use wikipage.content for setup, I think any area where wikitext features are expected to work _should_ trigger the hook... A common class name would still require knowing when to run setup, and potentially one might want to update the indicator (what happens during edit preview?). So we either have to add a second hook that does the same thing as wikipage.content but is explicitly scoped to non-primary areas, or ...? Hmm, bears further thought.

Aug 14 2019, 2:50 PM · MediaWiki-Interface, TimedMediaHandler
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

For a video that triggers player setup but hasn't actually been played, in Chrome/Firefox where no ogv.js shim is needed, they seem to weigh in (as reported from mw.inspect, so uncompressed) at around 293 KiB for MwEmbed+jquery.ui and 288 KiB for video.js with the core.min.js variant.

Aug 14 2019, 2:22 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VideoJS player, Readers-Web-Backlog (Tracking), Performance-Team (Radar)