Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (257 w, 5 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Thu, Sep 19

brion added a comment to T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.

Looks like the audio wasn't getting initialized at the right time (how did it work on iOS? no clue!) unless mwEmbedSupport has already been loaded.

Thu, Sep 19, 8:52 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, TimedMediaHandler-Player
brion updated the task description for T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.
Thu, Sep 19, 8:26 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, TimedMediaHandler-Player
brion created T233360: Regression: popup videos (kaltura player) don't play on first attempt with Safari 13.
Thu, Sep 19, 8:23 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Browser-Support-Apple-Safari, TimedMediaHandler-Player

Tue, Sep 17

Perhelion awarded T106240: Colorable SVG a Yellow Medal token.
Tue, Sep 17, 7:59 AM · TechCom-RFC, Wikimedia-SVG-rendering

Wed, Sep 11

brion added a comment to T229433: ResourceLoaderWikiModule.php: PHP Notice: Undefined index: .

Looks like in PHP 7.2 the empty string gets interned to a special shared instance (zend_empty_string)... It's possible something's corrupting zend_empty_string, either its contents or its hash (h) field. If we can get a core dump it should be possible to inspect the symbol...

Wed, Sep 11, 9:15 PM · Performance-Team, Wikimedia-production-error, MediaWiki-ResourceLoader

Wed, Aug 28

brion renamed T228342: Define criteria for setting explicit PHP support target for MediaWiki from Set explicit PHP 7.2 support target for MediaWiki to Define criteria for setting setting explicit PHP support target for MediaWiki.
Wed, Aug 28, 8:36 PM · TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
brion updated the task description for T228342: Define criteria for setting explicit PHP support target for MediaWiki.
Wed, Aug 28, 8:34 PM · TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support
brion renamed T228342: Define criteria for setting explicit PHP support target for MediaWiki from Set explicit PHP support target for MediaWiki to Set explicit PHP 7.2 support target for MediaWiki.
Wed, Aug 28, 8:32 PM · TechCom-RFC (TechCom-Approved), MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support

Aug 21 2019

brion added a comment to T230661: TimedMediaHandler audio captions are out of sync in Firefox (and possibly other browsers).

I'm still not sure I can reliably tell the difference but I trust you. :) Titles being sometimes late by random amounts up to 250ms seems like it would make sense given the poor latency guarantees on the timeupdate event, so I'm not sure there's much we can do directly here...

Aug 21 2019, 8:01 PM · TimedMediaHandler-Player, TimedMediaHandler-TimedText

Aug 20 2019

brion added a comment to T230661: TimedMediaHandler audio captions are out of sync in Firefox (and possibly other browsers).

Could this be latency from the timeupdate event? It can trigger with a wait as long as 250ms between events per spec.

Aug 20 2019, 11:27 PM · TimedMediaHandler-Player, TimedMediaHandler-TimedText

Aug 14 2019

brion added a comment to T230505: Parseroutput cache issue with videojs.

Note the parser cache key is not available to the hook. Fun!

Aug 14 2019, 6:50 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), TimedMediaHandler
brion added a comment to T230505: Parseroutput cache issue with videojs.

I think default mode is checked because there's a separate pcache suffix for folks using the beta-mode -- this is targeted at clearing the non-beta-mode entries after a site-config switch.

Aug 14 2019, 6:31 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), TimedMediaHandler
brion added a comment to T188831: Some thumbnail images delivered with wrong application/x-www-form-urlencoded mime-type.

The only POSTs I see in there are in setContainerAccess, addMissingHashMetadata, and doDescribeInternal, which all update existing files. Could be there's a hole in the logic of one of them that's dropping Content-Type, or that some files were missing it to begin with but it was being filled in on high-level fetches, or something, so they worked until something updated the data?

Aug 14 2019, 6:13 PM · Traffic, Operations, Multimedia, Thumbor, Commons, MediaWiki-File-management, media-storage
brion added a comment to T188831: Some thumbnail images delivered with wrong application/x-www-form-urlencoded mime-type.

Hmm, I notice this in SwiftFileBackend.php:

Aug 14 2019, 6:08 PM · Traffic, Operations, Multimedia, Thumbor, Commons, MediaWiki-File-management, media-storage
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Great, I'll tidy up this patch in a bit (once I get the subtitle lazy-loading patched back in) and we'll worry about lazy-loading later.

Aug 14 2019, 2:51 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Since AFAIK extensions are meant to use wikipage.content for setup, I think any area where wikitext features are expected to work _should_ trigger the hook... A common class name would still require knowing when to run setup, and potentially one might want to update the indicator (what happens during edit preview?). So we either have to add a second hook that does the same thing as wikipage.content but is explicitly scoped to non-primary areas, or ...? Hmm, bears further thought.

Aug 14 2019, 2:50 PM · MediaWiki-Parser, TimedMediaHandler
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

For a video that triggers player setup but hasn't actually been played, in Chrome/Firefox where no ogv.js shim is needed, they seem to weigh in (as reported from mw.inspect, so uncompressed) at around 293 KiB for MwEmbed+jquery.ui and 288 KiB for video.js with the core.min.js variant.

Aug 14 2019, 2:22 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Or... perhaps MW should run wikipage.content against the contents of <indicator> as well?

Aug 14 2019, 1:43 PM · MediaWiki-Parser, TimedMediaHandler
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Looking at the TimedMediaHandler JS, it uses the wikipage.content hook which passes a jQuery object holding the content area in which to process elements. Anything outside the content area is not processed.

Aug 14 2019, 1:15 PM · MediaWiki-Parser, TimedMediaHandler
brion added a comment to T230471: TMH audio player missing for clips inside <indicator> .

Can you create a copy of the template that uses the form that fails? I'm uncertain what to modify from the description.

Aug 14 2019, 1:07 PM · MediaWiki-Parser, TimedMediaHandler

Aug 12 2019

brion added a comment to T230181: Precision of floating-point video length is inconsistent between HHVM and PHP 7.2.

Would you want to trim in the base handling of the metadata, or in the output API serialization specifically? Might be best to do it all around if we're going to apply such rounding in ways that are machine-readable.

Aug 12 2019, 7:57 PM · TimedMediaHandler
brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

Patch switches to the core distribution (no http-streaming component) and the more aggressively pre-minified version. Not quite complete, as this means we can't patch in the text track lazy-loading on top as easily.

Aug 12 2019, 6:32 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler

Aug 9 2019

brion added a comment to T230158: OggHandler: Undefined index: 1.

This seems to be during a chunked upload of an Ogg audio or video file. Any chance we can get the original file chunks?

Aug 9 2019, 7:11 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Commons, TimedMediaHandler, Wikimedia-production-error
brion added a comment to T230181: Precision of floating-point video length is inconsistent between HHVM and PHP 7.2.

I can repro the inconsistency on both domains. I think it's a HHVM vs Zend PHP difference; the shorter serialization is served from HHVM 3.18.6 while the longer one is served from PHP 7.2.16.

Aug 9 2019, 7:04 PM · TimedMediaHandler

Jul 29 2019

brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.

We can probably reduce the size for now by using the video.js core distribution (without the http-streaming component which we don't use yet) and using more aggressive minification (rather than using our own minifier, which doesn't shorted variable names and such).

Jul 29 2019, 9:46 PM · Performance-Team (Radar), Patch-For-Review, TimedMediaHandler-Player, TimedMediaHandler

Jul 26 2019

Quiddity awarded T18691: RFC: Section header "share" link a Love token.
Jul 26 2019, 12:25 AM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jul 13 2019

brion closed T227850: Transcode of a video gets turned upside down as Resolved.

Confirmed this fixes the transcodes; resolving.

Jul 13 2019, 6:40 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion claimed T227850: Transcode of a video gets turned upside down.

Fixing the .ogv file by setting the 'ROTATE=180' to 'ROTATE=0':

Jul 13 2019, 6:34 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

I suspect that the 'rotate' annotation in the comments is not actually handled by Firefox, VLC, or ogv.js -- certainly I never wrote code in ogv.js to handle it -- and may be a leftover from the MP4/3gpp original file the .ogv was sourced from.

Jul 13 2019, 6:17 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

This may be a problem that's been since fixed in upstream ffmpeg...?

Jul 13 2019, 6:16 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video
brion added a comment to T227850: Transcode of a video gets turned upside down.

For me, the original plays upside-down in Chrome, right-side-up in Firefox, VLC, and ogv.js. So this ain't handled quite universally I suppose. ;) I'll take a peek.

Jul 13 2019, 5:57 PM · TimedMediaHandler-Transcode, Commons, Wikimedia-Video

Jul 12 2019

Ladsgroup awarded T167246: Refactor "user" & "user_text" fields into "actor" reference table a Love token.
Jul 12 2019, 4:19 PM · CPT Initiatives (Revision Storage Schema Improvements), Schema-change, MediaWiki-General, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic

Jul 1 2019

brion added a project to T226797: Login state not propagated across domains in Safari: Browser-Support-Apple-Safari.
Jul 1 2019, 5:10 PM · Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth

Jun 29 2019

Lofhi awarded T100106: Replace Kaltura player with Video.js a Like token.
Jun 29 2019, 11:35 AM · Performance-Team (Radar), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler

Jun 28 2019

brion created T226797: Login state not propagated across domains in Safari.
Jun 28 2019, 4:42 AM · Browser-Support-Apple-Safari, MediaWiki-extensions-CentralAuth

Jun 27 2019

brion added a comment to T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object.

Note a deployment typo caused this fix to not get deployed in fact. Whoops! Roan's fixing it now.

Jun 27 2019, 11:24 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion closed T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object as Resolved.

Fix deployed. Should no longer cause fatal errors, but should log the transcoder output into the transcode table so we can review it later for suspicious commonalities.

Jun 27 2019, 9:53 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

Ok Reedy started this a while ago under T226713, so no need to re-run it a second time. It's probably the cause of seeing multiple fatals over on T226748, since all failure cases would come in a relatively short time. :D

Jun 27 2019, 9:47 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler
brion added a comment to T226713: Run cleanupTranscodes.php for current midi files.

Ah great, that'll do the job.

Jun 27 2019, 9:45 PM · Wikimedia-Site-requests, TimedMediaHandler
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

I have this ready to run on mwmaint1002 but want to wait until the fix for the fatal error in T226748 is deployed so I don't spam the error logs.

Jun 27 2019, 9:30 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler
brion claimed T226748: WebVideoTranscodeJob fatal: Call to getStdout() on a non-object.
Jun 27 2019, 9:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), TimedMediaHandler, Wikimedia-production-error
brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

cleanupTranscodes.php should be able to do this I believe, I'll test offline later.

Jun 27 2019, 12:28 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler

Jun 26 2019

brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

(main difference from previous behavior is that in practice most videos got the image with popup link where now they get a video directly)

Jun 26 2019, 10:46 PM · Browser-Support-Internet-Explorer, TimedMediaHandler-Player
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Ehhh, it's not hard to add a fallback image link that points to the file page. But I wouldn't necessarily block on it if it's not done soon.

Jun 26 2019, 10:45 PM · Browser-Support-Internet-Explorer, TimedMediaHandler-Player

Jun 24 2019

brion added a comment to T217085: Enable TimedMediaHandler video player in articles on mobile (instead of hyperlink to unplayable video).

Note that with the "New video player" beta feature enabled, this can be tested in production -- just make sure you're logged in in the mobile browser and it will pick up the preference.

Jun 24 2019, 5:34 PM · Readers-Web-Backlog (Tracking), Mobile, TimedMediaHandler
brion claimed T226371: Beta player slow at loading many videos in Firefox.

Probably should adjust the preload setting; ISTR some related issue in past. Will test further once no longer encountering unrelated server errors.

Jun 24 2019, 10:27 AM · WMSE-Bug-Reporting-and-Translation-2019, Performance, TimedMediaHandler-Player

Jun 23 2019

brion added a comment to T226311: Full size videos displayed as small videos in gallery.

Yeah, looks like we only read 1024 header bytes and it appears later in both those files, around 4000+ bytes in.

Jun 23 2019, 6:39 PM · Patch-For-Review, MediaWiki-File-management, MediaWiki-Gallery, Commons, Multimedia
brion added a comment to T203413: a small audio ogg file does not get played in full.

Confirmed that it's resolved with the video,js player frontend ("New video player" in beta features preferences)

Jun 23 2019, 6:31 PM · TimedMediaHandler-Player

Jun 22 2019

brion claimed T226311: Full size videos displayed as small videos in gallery.

I was able to reproduce this locally using the files via InstantCommons, and it looks like the root problem is that some of the files are misidentifed as audio, causing the packed-gallery code to use a small icon width instead of a large width constraint here:

Jun 22 2019, 5:57 PM · Patch-For-Review, MediaWiki-File-management, MediaWiki-Gallery, Commons, Multimedia
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

Note the root problem appears to be that some of the files are incorrectly marked as audio, causing a small width to be used for making thumbnails instead of a large one:

Jun 22 2019, 5:50 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

@Eatcha can you file a task for the unexpectedly small videos in gallery, and we'll track it down on that task. Thanks!

Jun 22 2019, 5:25 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

They seem to be small whether the old or new players are in use. Not quite sure why yet, will look into in a bit -- those are full size videos and should not be showing tiny... The polar bear video is low resolution, and seems to show at its native size. We may need to adjust things to ensure that video players can be sized larger than their originals?

Jun 22 2019, 5:23 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler

Jun 20 2019

brion closed T200813: JobQueueGroup::singleton()->getQueueSizes() returns 0 for all queues in production as Resolved.

Closing as this was worked around where needed.

Jun 20 2019, 7:49 PM · TimedMediaHandler-Transcode, MediaWiki-JobQueue

Jun 18 2019

Jdforrester-WMF awarded T174393: Video player should allow playback at multiple speeds a Like token.
Jun 18 2019, 3:30 PM · TimedMediaHandler-Player, Wikimedia-Video
brion claimed T174393: Video player should allow playback at multiple speeds.
Jun 18 2019, 2:53 PM · TimedMediaHandler-Player, Wikimedia-Video
brion added a comment to T174393: Video player should allow playback at multiple speeds.

Note that playbackRate support was recently contributed to ogv.js, so can be used when I finish packaging the new release. Shouldn't be hard to enable the rate control in the new video.js player...

Jun 18 2019, 2:48 PM · TimedMediaHandler-Player, Wikimedia-Video
brion added a comment to T148103: Provide a desktop beta feature of replacing Kaltura player with Video.js.

@Eatcha T174393 covers this; we can add it fairly easily soon (the necessary support for the Safari compatibility shim was recently added upstream; I just have to package a release and then enable the rate control)

Jun 18 2019, 2:47 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review, Beta-Feature, TimedMediaHandler-Player, Wikimedia-Video, TimedMediaHandler
brion closed T225452: MW-Vagrant 'commons' role doesn't allow CORS needed for TMH video playback in Safari as Resolved.
Jun 18 2019, 1:19 AM · MediaWiki-Vagrant

Jun 12 2019

brion added a comment to T116154: Support WebVTT subtitling.

Need to add a VTT parser; currently there's only a SRT parser that produces VTT-compatible objects which we can output in either format. Shouldn't be hard to add, just didn't get to it yet for the MVP. :D

Jun 12 2019, 4:30 PM · Patch-For-Review, TimedMediaHandler-TimedText, TimedMediaHandler
brion updated the task description for T225640: Video.js mode doesn't show subtitles by default on non-English sites.
Jun 12 2019, 4:28 PM · TimedMediaHandler-TimedText, TimedMediaHandler-Player
brion created T225640: Video.js mode doesn't show subtitles by default on non-English sites.
Jun 12 2019, 4:24 PM · TimedMediaHandler-TimedText, TimedMediaHandler-Player
brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

Basic patch added which is an updating of the old upstream PR. Seems to work but might have edge cases; I'm happy to merge it for now to get us rolling if it looks ok.

Jun 12 2019, 3:44 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
matmarex awarded T27707: Allow "html" in exif tags a Pterodactyl token.
Jun 12 2019, 3:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T224258: TimedText markup for bold, italic etc not parsed and displayed as plain text.

@TheDJ yes, it's now validated (and in many cases slightly manipulated to become conforming) before being served out. As long as the formatting uses <b>...</b> and <i>...</i> rather than wiki-style '''...''' or ''...'' it will work with the upcoming videojs player -- but the old Kaltura player we're still shipping doesn't understand those.

Jun 12 2019, 3:13 PM · TimedMediaHandler-TimedText

Jun 10 2019

brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

Upstream issue is: https://github.com/videojs/video.js/issues/5252

Jun 10 2019, 6:18 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion created T225452: MW-Vagrant 'commons' role doesn't allow CORS needed for TMH video playback in Safari.
Jun 10 2019, 6:08 PM · MediaWiki-Vagrant

Jun 6 2019

brion added a comment to T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.

@Johan @Ebe123 I've +2'd the latest patchset and added some configuration patchsets for production and MediaWiki-Vagrant. :) This should be ready to roll soon if no problems in testing.

Jun 6 2019, 9:31 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Patch-For-Review, User-notice, Wikimedia-Hackathon-2019, MediaWiki-extensions-Score, TimedMediaHandler

Jun 4 2019

brion added a comment to T27707: Allow "html" in exif tags.

Looks like the patch never got reviewed. I'll poke some people and see if we can get it moving.

Jun 4 2019, 5:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading

May 29 2019

Restricted Application added a project to T224612: Mailing list admin pass reset for winedale-l (for migration off lists.wikimedia.org): Operations.
May 29 2019, 6:08 PM · Operations, Wikimedia-Mailing-lists

May 28 2019

brion added a comment to T224522: PHP Fatal Error from ApiTimedText: Argument to WikiPage::factory must Title (WikiPage given).

Ah I see! Typo, should be $title where it's $page in this:

May 28 2019, 10:07 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikimedia-production-error, TimedMediaHandler
brion added a comment to T224367: TimedText not working on non-English wikis: Serves the translated namespace instead of canonical one for Commons files.

Ah yeah that'll do it. I'll get on it...

May 28 2019, 9:32 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), TimedMediaHandler, Regression, TimedMediaHandler-TimedText
brion claimed T224522: PHP Fatal Error from ApiTimedText: Argument to WikiPage::factory must Title (WikiPage given).
May 28 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikimedia-production-error, TimedMediaHandler

May 26 2019

brion claimed T224367: TimedText not working on non-English wikis: Serves the translated namespace instead of canonical one for Commons files.

I'll investigate this Monday, probably a regression in our recent changes.

May 26 2019, 7:33 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), TimedMediaHandler, Regression, TimedMediaHandler-TimedText

May 9 2019

Kristbaum awarded T100106: Replace Kaltura player with Video.js a Love token.
May 9 2019, 6:57 PM · Performance-Team (Radar), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler

May 7 2019

brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

Once per instance is probably ok, as it should be rare to have the same video over and over. Uh, except on the file page with versions maybe. >_<

May 7 2019, 9:33 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion claimed T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).
May 7 2019, 9:31 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion added a comment to T222763: VideoJS loads subtitles on read rather than play (and once per video instance on-page, rather than aggregated).

That ain't pretty. I'll see if can improve this.

May 7 2019, 9:31 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, TimedMediaHandler, TimedMediaHandler-TimedText
brion added a comment to T222762: TMH subtitle fetch broken (nothing returned) for ForeignFileRepo / InstantCommons.

IIRC production Commons is fetched into Beta via ForeignAPIRepo, so it's seeing only the srt-format subtitles in its list that production Commons sees. It should fix up after production Commons gets the timedtext API...

May 7 2019, 9:30 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikimedia-Hackathon-2019, TimedMediaHandler-TimedText, TimedMediaHandler

May 2 2019

brion added a comment to T212738: Deprecate $wgVersion and move to a constant.

Extension code that's dependent on specific interfaces should probably feature-detect for those specific interfaces with function_exists, class_exists etc rather than trusting version numbers as well -- and that can only be tested by running with the actual version. And you'd only detect failures (like using a new feature on the old version path) from running with the other version anyway, so I think they'd have to go together if that's something we want tested.

May 2 2019, 4:39 PM · MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General

May 1 2019

MichaelSchoenitzer awarded T100106: Replace Kaltura player with Video.js a Love token.
May 1 2019, 12:00 PM · Performance-Team (Radar), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler

Apr 23 2019

brion created T221657: 500 error when deleting ssh key from toolsadmin.
Apr 23 2019, 3:58 PM · cloud-services-team (Kanban), Striker
ToBeFree awarded T35186: Provide a well-performing API to rotate an image a Like token.
Apr 23 2019, 11:23 AM · Patch-Needs-Improvement, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-API

Apr 3 2019

nray awarded T18691: RFC: Section header "share" link a Like token.
Apr 3 2019, 5:53 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Feb 28 2019

Niedzielski awarded T18691: RFC: Section header "share" link a Love token.
Feb 28 2019, 3:37 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Feb 27 2019

brion claimed T138770: TMH video.js-mode 'info' button link normalization.
Feb 27 2019, 8:16 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), TimedMediaHandler, TimedMediaHandler-Player

Feb 21 2019

brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

(Just noting I'll be ready to work more on this in around next week-ish)

Feb 21 2019, 9:49 PM · Patch-For-Review, TimedMediaHandler
brion created T216673: Unable to install php-tidy during MediaWiki-Vagrant setup.
Feb 21 2019, 3:54 AM · MediaWiki-Vagrant

Feb 5 2019

brion created T215344: Add overlay notice recommending modern browser on slow ogv.js playback.
Feb 5 2019, 8:32 PM · TimedMediaHandler-Player

Feb 1 2019

brion added a comment to T27707: Allow "html" in exif tags.

https://www.flickr.com/photos/tinto/30943950124/ and other photos from this Flickr user.

Feb 1 2019, 10:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

The above patch https://gerrit.wikimedia.org/r/487527 removes some of the non-scripting tags from the checks in UploadBase::detectScript, and makes the conservative/exact IE heuristics called from UploadBase::verifyMimeType optional (but still on by default). This also deprecates $wgAllowTitleInSVG since <title is no longer looked for.

Feb 1 2019, 7:56 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

Ok, looking at the actual current code now... UploadBase::detectScript does the check, and combines several things:

  • looks at first 1024 bytes (more than IE checks) if binary, or all if text
  • does some text encoding checks (seems to be SVG-specific?)
  • looks for IE's trigger tags for type detection
  • looks for some Safari (old Safari?) trigger works for plain-specific type detection
  • decodes XML-style char references (seems to be SVG-specific)
  • looks for some script-like things CSS-like URLs in body content that seem to be SVG-specific
Feb 1 2019, 6:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

Though this is not needed to remove this MIME sniffing check (or at the very least, make it optional), as I've shown it can't be exploited unless the webserver is misconfigured. So it doesn't apply to Wikimedia projects.

Feb 1 2019, 5:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

@Aklapper I believe it's very on-topic to discuss the security implications of a suggested feature change. Where would you suggest we discuss this if not here, on this task?

Feb 1 2019, 5:18 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading

Jan 29 2019

brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

Thanks! Didn't mean to rush you, I'll probably poke at this next week unless I get inspired. :)

Jan 29 2019, 9:41 PM · Patch-For-Review, TimedMediaHandler

Jan 28 2019

brion added a comment to T27707: Allow "html" in exif tags.

Double-checking:

  • IE 6 and 7 were both available on Windows XP, which includes TLS 1.0 support but not TLS 1.1 or 1.2. However IE 6-8 on XP fail to work anyway due to lack of SNI.
    • This takes IE 6 off the table entirely.
  • IE 7 on Vista should still work correctly with TLS 1.0, 1.1, or 1.2 -- https://blogs.msdn.microsoft.com/kaushal/2011/10/02/support-for-ssltls-protocols-on-windows/
  • IE8 supports X-Content-Type-Options: nosniff header; if we don't already use it consistently, applying this on all file views would resolve all sniffing issues on IE 8
Jan 28 2019, 11:35 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T27707: Allow "html" in exif tags.

The chance that someone would visit using an old IE version was probably 50% when the code was originally added; IE had a very high marketshare in the early 2000s. However at this point we can't even be accessed in IE 6 as far as I know (due to servers dropping old TLS versions for HTTPS). I think it's pretty fair to change the balance of what we check for.

Jan 28 2019, 10:58 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Security, Multimedia, MediaWiki-Uploading
brion added a comment to T214480: The first Selenium test for TimedMediaHandler.

@zeljkofilipin should I take this task? I'll need to grab some documentation for starters or else grab you later when we have time. :)

Jan 28 2019, 10:13 PM · Patch-For-Review, TimedMediaHandler
brion created T214864: requeueTranscodes gets confused in some cases where null entries are left in place.
Jan 28 2019, 8:55 PM · TimedMediaHandler-Transcode

Jan 23 2019

osorio-juan-microsoft awarded T18691: RFC: Section header "share" link a Burninate token.
Jan 23 2019, 7:12 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jan 4 2019

brion added a comment to T178592: decommission/replace bast4001.wikimedia.org.

Note that bast4001 no longer works for login?

Jan 4 2019, 10:13 PM · decommission, Operations, ops-ulsfo