Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (24)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (314 w, 5 h)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Tue, Oct 20

brion added a comment to T262947: Cannot change volume (Uncaught TypeError: Cannot read property 'addClass' of undefined).

Yeah I'm in firefox so that explains the exception diff :)

Tue, Oct 20, 6:53 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), JavaScript, Wikimedia-production-error, TimedMediaHandler
brion added a comment to T262947: Cannot change volume (Uncaught TypeError: Cannot read property 'addClass' of undefined).

Yep, patch seems to fix it and the new version is nice and clean. :) +2!

Tue, Oct 20, 6:52 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), JavaScript, Wikimedia-production-error, TimedMediaHandler
brion added a comment to T262947: Cannot change volume (Uncaught TypeError: Cannot read property 'addClass' of undefined).

So if I manipulate the volume slider instead of the audio position slider, I can repro an error "Uncaught TypeError: closestHandle is undefined" but that's a different error than was reported?

Tue, Oct 20, 6:49 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), JavaScript, Wikimedia-production-error, TimedMediaHandler
brion added a comment to T262947: Cannot change volume (Uncaught TypeError: Cannot read property 'addClass' of undefined).

Are you dragging the volume slider instead of the audio position slider? That might be doing it...

Tue, Oct 20, 6:48 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), JavaScript, Wikimedia-production-error, TimedMediaHandler
brion added a comment to T262947: Cannot change volume (Uncaught TypeError: Cannot read property 'addClass' of undefined).

I can't reproduce this on current git master following the directions in the original post. Can you provide an exact repro?

Tue, Oct 20, 6:29 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), JavaScript, Wikimedia-production-error, TimedMediaHandler
brion added a comment to T259930: Archive unofficial-apps-wikipedia-windows-8 tag ?.

Sorry, hadn't seen this. Sure, as far as I know it's unused for years.

Tue, Oct 20, 6:10 PM · Unofficial-Apps-Wikipedia-Windows-8, Project-Admins

Thu, Sep 24

Kizule awarded T100106: Replace Kaltura player with Video.js a Love token.
Thu, Sep 24, 6:30 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, VideoJS player, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, Wikimedia-Video, Wikimedia-Hackathon-2015

Aug 3 2020

brion triaged T259549: The preview container for video is more pixels than the video preview itself as Low priority.

Worth double-checking yeah, these should be the same iirc. I'm giving it a low priority/severity because it seems relatively harmless but it should still get gotten to. :)

Aug 3 2020, 8:28 PM · Design, VideoJS player
brion added a comment to T258644: VideoJS audio player start button is misleading.

Note that the current audio placeholder was selected to have a similar shape and size to existing inline players to minimize disruption to article layouts.

Aug 3 2020, 6:26 PM · Accessibility, UX-Debt, Design, VideoJS player
brion triaged T258584: Align VideoJS player to Wikimedia UI design as Lowest priority.
Aug 3 2020, 6:09 PM · Patch-For-Review, Wikimedia-Video, Design, UI-Standardization, VideoJS player
brion added a comment to T246035: Videojs player for audio opens a dialog, which is unexpected.

Don't just call the OOUI window, maybe just replace the area of the audio placeholder?

Aug 3 2020, 5:51 PM · VideoJS player
brion added a comment to T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.

And what will happen after the deployment with T246035: Videojs player for audio opens a dialog, which is unexpected?

Aug 3 2020, 5:33 PM · Patch-For-Review, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video
brion added a comment to T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.

I think I lost my work patch for the subtitles >:( Will have to recreate it shortly

Aug 3 2020, 5:12 PM · Patch-For-Review, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video
brion added a comment to T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.

I might actually prefer to delay until the remember-subtitles-setting fix is merged. I'm honestly not sure what the situation with Score is at this point, but if playback is broken that might be good to fix as well.

Aug 3 2020, 5:11 PM · Patch-For-Review, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video

Jul 29 2020

BEANS-X2 awarded T100106: Replace Kaltura player with Video.js a Like token.
Jul 29 2020, 9:48 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, VideoJS player, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, Wikimedia-Video, Wikimedia-Hackathon-2015

Jul 27 2020

Volker_E awarded T100106: Replace Kaltura player with Video.js a Love token.
Jul 27 2020, 9:06 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, VideoJS player, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, Wikimedia-Video, Wikimedia-Hackathon-2015

Jul 16 2020

brion closed T254664: Unused timing/benchmarking in VideoTranscodeTest::runTranscodeJobs as Resolved.

merged and done.

Jul 16 2020, 6:29 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), TimedMediaHandler

Jul 14 2020

brion moved T244570: Create thumbnail for MPEG videos from To sort to In progress on the TimedMediaHandler board.
Jul 14 2020, 4:35 PM · Thumbor, TimedMediaHandler
brion moved T254663: Unused VideoTranscodeTest calls non existent Job::pop_type() from In progress to Backlog/maint on the TimedMediaHandler board.
Jul 14 2020, 4:34 PM · TimedMediaHandler
brion renamed T254663: Unused VideoTranscodeTest calls non existent Job::pop_type() from VideoTranscodeTest calls non existent Job::pop_type() to Unused VideoTranscodeTest calls non existent Job::pop_type().
Jul 14 2020, 4:34 PM · TimedMediaHandler
brion moved T254663: Unused VideoTranscodeTest calls non existent Job::pop_type() from To sort to In progress on the TimedMediaHandler board.
Jul 14 2020, 4:33 PM · TimedMediaHandler
brion added a comment to T254663: Unused VideoTranscodeTest calls non existent Job::pop_type().

Hmm, looks like the whole test case is pretty broken:

  • assumes jobs are stored in the job table and looks there for available jobs?
  • calls Job::pop_type() which no longer exists
  • and is all disabled since years ago
Jul 14 2020, 4:33 PM · TimedMediaHandler
brion moved T254664: Unused timing/benchmarking in VideoTranscodeTest::runTranscodeJobs from To sort to In progress on the TimedMediaHandler board.
Jul 14 2020, 4:24 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), TimedMediaHandler

Jul 13 2020

brion added a comment to T257652: Add support for AVIF: serve AVIF thumbnails where possible.

The TimedMediaHandler support won't help here directly, except insofar as actually functionally supporting ingestion of AV1 WebM video uploads will require video transcode servers to have libaom installed, so will establish that we can install the codec library on our machines in a sensible way. :)

Jul 13 2020, 7:57 PM · Thumbor, Commons, MediaWiki-File-management

Jun 22 2020

brion closed T91689: Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library), a subtask of T91658: Hacking: Wiki Radio, as Declined.
Jun 22 2020, 6:18 PM · Reading-Admin, Outreachy (Round-13), Wikimedia-Hackathon-2015
brion closed T91689: Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library), a subtask of T68722: [iOS app] Some media (esp. video) files do not work, as Declined.
Jun 22 2020, 6:17 PM · WorkType-Maintenance, Wikipedia-iOS-App-Backlog
brion closed T91689: Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library) as Declined.

I'm closing this one out as I'm retiring the incomplete but mostly working OGVKit in favor of recommending MobileVLCKit. It's more mature and better supported, and these days has better build tools than when I started.

Jun 22 2020, 6:17 PM · Wikimedia-Video

Apr 14 2020

TerraCodes awarded T21992: Support client-side date/time formatting for user's timezone, language, and preferred format (JavaScript) a Like token.
Apr 14 2020, 12:24 AM · I18n, MediaWiki-Interface

Apr 13 2020

brion closed T138767: TMH video.js-mode 'info' button doesn't highlight on hover as Invalid.

The other buttons don't seem to highlight (anymore?) so closing this.

Apr 13 2020, 6:57 PM · VideoJS player
brion moved T241107: MinimumVideoPlayerSize config setting doesn't do anything when using videojs player from Backlog to Active on the VideoJS player board.
Apr 13 2020, 6:48 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), VideoJS player
brion added a comment to T241107: MinimumVideoPlayerSize config setting doesn't do anything when using videojs player.

$wgMinimumVideoPlayerSize is a pretty difficult hammer to use for fine editorial control, and is not supported by the new videojs mode. The general intention is to add an explicit keyword for an 'inline' player mode which would always display in-place, rather than making it dependent on player size, though that's a separate bit of work and not yet done.

Apr 13 2020, 6:30 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), VideoJS player

Apr 6 2020

brion closed T246953: Docker MW installation command line doesn't work on Windows command shell or PowerShell as Resolved.

Now works as written. :D

Apr 6 2020, 8:35 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-brennen, User-kostajh, MediaWiki-Docker
Thgoiter awarded T18691: RFC: Section header "share" link a Like token.
Apr 6 2020, 7:51 PM · Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
brion added a comment to T246953: Docker MW installation command line doesn't work on Windows command shell or PowerShell.

I presume I have to create an .env file in some other way, like using a text editor? Ideally there should be a ready-to-copy-and-paste chunk of text that requires no execution in a platform-specific shell. What should I use for MW_DOCKER_UID and MW_DOCKER_GID? UID and GID are Unix-specific concepts and I don't know if they have any meaning in Windows?

Apr 6 2020, 7:46 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-brennen, User-kostajh, MediaWiki-Docker
brion added a comment to T246953: Docker MW installation command line doesn't work on Windows command shell or PowerShell.

The instructions to create an .env file from a bash command fail in both PowerShell and CMD.exe... There is a mention of a /docker/install.sh file later in the instructions but I don't know where it's supposed to come from?

Apr 6 2020, 7:39 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-brennen, User-kostajh, MediaWiki-Docker
brion added a comment to T246953: Docker MW installation command line doesn't work on Windows command shell or PowerShell.

@kostajh trying a fresh checkout now. :)

Apr 6 2020, 7:33 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-brennen, User-kostajh, MediaWiki-Docker
brion added a comment to T241392: Video wider than visible screen on mobile.

Ok, that CSS doesn't take as it's for the post-transformed player. Looks like I need to redo how the placeholders are styled to make this work. :) Easy peasy, lemon squeezy...

Apr 6 2020, 7:02 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), VideoJS player
brion added a comment to T241392: Video wider than visible screen on mobile.

Ok, the popup dialog is good but the thumbnail still doesn't get shrunk as on https://deployment.m.wikimedia.beta.wmflabs.org/wiki/Video_test

Apr 6 2020, 6:41 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), VideoJS player
brion claimed T241392: Video wider than visible screen on mobile.

Going through the backlog of visible regressions to fix up; this may have been obsoleted by the switchover to the popup player dialog but let me check.

Apr 6 2020, 6:29 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), VideoJS player
brion moved T241392: Video wider than visible screen on mobile from UI/UX Regressions to Active on the VideoJS player board.
Apr 6 2020, 6:27 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), VideoJS player
brion moved T248895: Videopreview behaves different and breaks in previewmode from Active to Backlog on the VideoJS player board.
Apr 6 2020, 4:37 PM · VideoJS player
brion placed T248895: Videopreview behaves different and breaks in previewmode up for grabs.

Ok, oddly it's started working for me even with live preview on. I don't know what changed that could have caused it to start working if it was previously broken...

Apr 6 2020, 4:37 PM · VideoJS player

Apr 2 2020

brion moved T248895: Videopreview behaves different and breaks in previewmode from UI/UX Regressions to Active on the VideoJS player board.
Apr 2 2020, 6:19 PM · VideoJS player
brion moved T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis from Backlog to Active on the VideoJS player board.
Apr 2 2020, 6:19 PM · Patch-For-Review, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video
brion moved T249249: Loading indicator renders in the top left corner instead of centre from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:19 PM · VideoJS player
brion moved T248895: Videopreview behaves different and breaks in previewmode from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:18 PM · VideoJS player
brion moved T100106: Replace Kaltura player with Video.js from Backlog to Active on the VideoJS player board.
Apr 2 2020, 6:18 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, VideoJS player, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Epic, Multimedia, Wikimedia-Video, Wikimedia-Hackathon-2015
brion moved T138767: TMH video.js-mode 'info' button doesn't highlight on hover from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · VideoJS player
brion moved T138768: TMH video.js-mode 'info' button needs localizable alt and hover text from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · I18n, Accessibility, VideoJS player
brion moved T138769: TMH video.js-mode 'info' button doesn't allow right-click to copy-paste/drag/open link from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · VideoJS player
brion moved T148586: TMH videojs mode has no fallback content for video and audio for IE 8 from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · VideoJS player, Browser-Support-Internet-Explorer
brion moved T225640: Video.js mode doesn't show subtitles by default on non-English sites from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · VideoJS player, TimedMediaHandler-TimedText
brion moved T226313: Last row of video.js players lacking title from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · VideoJS player
brion moved T227195: File description info button is useless for Score from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:17 PM · VideoJS player, MediaWiki-extensions-Score
brion moved T226910: VideoJS player is next to the score instead of below it from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:16 PM · Google-Code-in-2019, VideoJS player, MediaWiki-extensions-Score
brion moved T230651: VideoJS beta video player captions menu does not work properly when overlapping with page header(s) from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:16 PM · VideoJS player, TimedMediaHandler-TimedText
brion moved T241392: Video wider than visible screen on mobile from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:16 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), VideoJS player
brion moved T246035: Videojs player for audio opens a dialog, which is unexpected from Backlog to Audio UX on the VideoJS player board.
Apr 2 2020, 6:16 PM · VideoJS player
brion moved T249204: New video player does not leave enough space in gallery from Backlog to UI/UX Regressions on the VideoJS player board.
Apr 2 2020, 6:16 PM · Wikimedia-Video, VideoJS player
brion renamed T249204: New video player does not leave enough space in gallery from New video player does not leave enough space to New video player does not leave enough space in gallery.
Apr 2 2020, 6:14 PM · Wikimedia-Video, VideoJS player
brion added a comment to T249204: New video player does not leave enough space in gallery.

Looks like there's two things going on:

  1. the video preview doesn't resize to fit the gallery container (it's an actual <video> with a poster image under the lid, not an <img>, so styles might not be applying to it that need to be); this usually adds extra space around the image
  2. in Firefox, the video sometimes overflows the available space, causing insufficient space around the image as in the screenshot
Apr 2 2020, 6:11 PM · Wikimedia-Video, VideoJS player
brion added a comment to T249204: New video player does not leave enough space in gallery.

Can't reproduce in Chrome, but can in Firefox. Something seems wonky with the gallery layout in Firefox specifically.

Apr 2 2020, 6:02 PM · Wikimedia-Video, VideoJS player
brion added a comment to T249249: Loading indicator renders in the top left corner instead of centre.

Ah, I see what's going on... the first loading indicator is running during the time that we load up OOUI etc, before we have a dialog, so it's just sitting on the page globally instead of being anchored anywhere in specific.

Apr 2 2020, 5:54 PM · VideoJS player

Mar 31 2020

brion added a comment to T248895: Videopreview behaves different and breaks in previewmode.

@MichaelSchoenitzer looks like you have 'use live preview' on (labeled in English as "Show previews without reloading the page" in prefs editing tab). I can confirm that the player fails to work in the preview in this case -- it's probably not loading the required JS module -- but I haven't been able to repro the visual offset issue yet, at least in Chrome.

Mar 31 2020, 10:11 PM · VideoJS player
brion added a comment to T248895: Videopreview behaves different and breaks in previewmode.

Thanks for the confirmation, I'll see if I can figure out which option is troublesome...

Mar 31 2020, 9:44 PM · VideoJS player

Mar 30 2020

brion added a comment to T248895: Videopreview behaves different and breaks in previewmode.

Hmm, it's working ok for me in Chrome, Firefox, and Safari on your test page and a copy I made here: https://de.wikipedia.org/wiki/Benutzer:Brion_Vibber_(WMF)/Test

Mar 30 2020, 10:42 PM · VideoJS player
brion claimed T248895: Videopreview behaves different and breaks in previewmode.
Mar 30 2020, 6:20 PM · VideoJS player

Mar 19 2020

brion claimed T245377: Video.js player doesn’t work with Score.

Grabbing a couple high-prio TMH issues to work on the next week or two. Looks like a bug in the surrounding JS that assumes some things are marked up in one way but they aren't for Score stuff.

Mar 19 2020, 6:14 PM · Regression, TimedMediaHandler, MediaWiki-extensions-Score
brion closed T248109: TimedMediaHandler has php deprecation warnings about unparenthesized expressions when running with php7.4 as Resolved.

now success :) https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-docker/1572/console

Mar 19 2020, 6:13 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), PHP 7.4 support, TimedMediaHandler
brion claimed T248109: TimedMediaHandler has php deprecation warnings about unparenthesized expressions when running with php7.4.
Mar 19 2020, 5:07 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), PHP 7.4 support, TimedMediaHandler

Mar 7 2020

brion added a comment to T246930: Increase Docker image's PHP upload limit from 2 MiB to 100 MiB.

Confirmed working on a fresh install, thanks all!

Mar 7 2020, 2:20 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), User-brennen, Release-Engineering-Team, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), dev-images, MediaWiki-Docker
brion created T247153: ffmpeg in MW-Docker lacks -row-mt option for improved multithreaded VP9 encoding.
Mar 7 2020, 2:20 AM · EngProd-Virtual-Hackathon, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, dev-images, MediaWiki-Docker, Release-Engineering-Team (Local Dev)

Mar 5 2020

brion added a comment to T246942: TimedMediaHandler's ffmpeg processes get stuck when using resource limits on Docker image.

T206957 is the related ticket.

Mar 5 2020, 9:48 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, MediaWiki-Docker

Mar 4 2020

brion created T246953: Docker MW installation command line doesn't work on Windows command shell or PowerShell.
Mar 4 2020, 10:39 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-brennen, User-kostajh, MediaWiki-Docker
brion added a comment to T246935: Job queue runners for MediaWiki-Docker.

I think principle of least surprise leads us to want a job queue that is processed automatically without manual intervention, as it's meant to be a continuously-operating part of the MediaWiki service that code can rely on being in working condition.

Mar 4 2020, 9:45 PM · EngProd-Virtual-Hackathon, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, dev-images, MediaWiki-Docker
brion created T246942: TimedMediaHandler's ffmpeg processes get stuck when using resource limits on Docker image.
Mar 4 2020, 8:49 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, MediaWiki-Docker
brion created T246935: Job queue runners for MediaWiki-Docker.
Mar 4 2020, 7:23 PM · EngProd-Virtual-Hackathon, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), User-brennen, dev-images, MediaWiki-Docker
brion created T246930: Increase Docker image's PHP upload limit from 2 MiB to 100 MiB.
Mar 4 2020, 7:13 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), User-brennen, Release-Engineering-Team, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), dev-images, MediaWiki-Docker

Feb 25 2020

brion added a comment to T246035: Videojs player for audio opens a dialog, which is unexpected.

The alternative would be to replace the player 'inline', but then we'd have to jump through hoops to get subtitles for audio again.

Feb 25 2020, 6:37 PM · VideoJS player

Feb 17 2020

Demian awarded T18691: RFC: Section header "share" link a Yellow Medal token.
Feb 17 2020, 12:28 AM · Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Feb 10 2020

brion added a comment to T31118: Add HTML 5 semantic elements 'details' and 'summary' to Sanitizer whitelist.

From caniuse it looks like IE and old Edge are the holdouts (new Chromium based edge supports it, as well as reasonably current versions of other browsers)

Feb 10 2020, 7:14 PM · MediaWiki-Parser
brion added a comment to T31118: Add HTML 5 semantic elements 'details' and 'summary' to Sanitizer whitelist.

Neat! We should probably confirm the behavior is consistent, predictable, and either falls back cleanly or can be emulated sanely (eg in IE 11 if it doesn't support it). Also double check that neither tag is used as an extension. Then I probably have no further objection. :)

Feb 10 2020, 7:12 PM · MediaWiki-Parser

Feb 9 2020

brion added a comment to T211484: UploadBlacklist is missing licensing.

I think I wrote this yes... we'd consider this as GPLv2-or-later as part of MediaWiki. It wasn't originally labeled in detail as it was a one-off production hack that ended up being kept around, and we weren't as careful with explicit labeling on extensions back then.

Feb 9 2020, 7:35 AM · MediaWiki-extensions-UploadBlacklist, Software-Licensing

Feb 7 2020

brion added a comment to T244570: Create thumbnail for MPEG videos.

Patch is https://gerrit.wikimedia.org/r/569341

Feb 7 2020, 7:44 PM · Thumbor, TimedMediaHandler
brion claimed T244570: Create thumbnail for MPEG videos.

Patch for thumbor is in the works, needs to finish adding test cases which I'll try to do this weekend so it's ready to go out when ready.

Feb 7 2020, 7:43 PM · Thumbor, TimedMediaHandler

Feb 4 2020

brion created T244273: thumbor-plugins offline tests don't work on Debian Stretch.
Feb 4 2020, 6:48 PM · Thumbor

Feb 1 2020

brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

From the IRC log, a couple of the transaction IDs that returned 500 errors with odd messages about Swift being missing or disabled:

Feb 1 2020, 10:08 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback.

Roughly planning to soft-launch this and try replacing some of the manual .ogv conversions of old mpeg1 and 2 files from scientific papers with the originals. I'll track that on a separate task once the release train brings it live.

Feb 1 2020, 9:38 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), TimedMediaHandler-Transcode, Patch-For-Review, UploadWizard, WMF-Legal, Commons, Multimedia
brion added a project to T244067: New thumbnail generation fails for c:File:X mark.svg: Wikimedia-SVG-rendering.
Feb 1 2020, 8:42 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

@Aklapper it is an svg file being rendered to png, so I think that should stay unless we can confirm that rendering succeeded and the error was at a later stage of serving.

Feb 1 2020, 8:01 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

Ah fun, intermittent problems. :) Should be findable in logs ...

Feb 1 2020, 6:04 PM · Wikimedia-SVG-rendering, Thumbor
brion added a comment to T244067: New thumbnail generation fails for c:File:X mark.svg.

https://upload.wikimedia.org/wikipedia/commons/thumb/a/a2/X_mark.svg/526px-X_mark.svg.png is rendering ok for me at present. What error message is displayed for you?

Feb 1 2020, 5:59 PM · Wikimedia-SVG-rendering, Thumbor

Jan 31 2020

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Seem to have worked around the deprecation issue by simply not shutting down the lock manager or file group, but will test more thoroughly to see if that breaks anything later...

Jan 31 2020, 1:23 AM · Patch-Needs-Improvement, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Maintenance-system
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Looks like a little bitrot has hit this patch, with the deprecation of resetServiceForTesting outside unit tests the closing of services ends up failing.

Jan 31 2020, 12:13 AM · Patch-Needs-Improvement, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Maintenance-system

Jan 28 2020

brion added a comment to T243562: Commons video player does not work on IE 11 or older versions of Safari.

Can you check with this page? https://brionv.com/misc/vidtest/

Jan 28 2020, 11:37 PM · TimedMediaHandler, Commons, Fundraising-Backlog

Jan 26 2020

brion added a comment to T18763: Present list of matching timezone locations based on client offset.

This is much better than my originally suggested hack. :) +2'ing it.

Jan 26 2020, 3:34 AM · MediaWiki-User-preferences
brion added a comment to T40271: Review and deploy SVGEdit extension to Wikimedia wikis.

Still think this'd be a great base for us to work on, should there be time and energy to spend on it.

Jan 26 2020, 3:03 AM · Wikimedia-extension-review-queue, Commons, Wikimedia-Extension-setup

Jan 25 2020

brion claimed T243562: Commons video player does not work on IE 11 or older versions of Safari.
Jan 25 2020, 10:01 PM · TimedMediaHandler, Commons, Fundraising-Backlog
brion added a comment to T243562: Commons video player does not work on IE 11 or older versions of Safari.

Hmm, https://commons.wikimedia.org/wiki/File:Wikipedia_-_Edit_2019.webm?embedplayer=yes is currently working for me in IE 11 (though with low performance) and should be working in Safari as well (with much better performance). Can you confirm whether the URL works independently of the iframe, or whether it only fails in the iframe?

Jan 25 2020, 10:01 PM · TimedMediaHandler, Commons, Fundraising-Backlog

Jan 17 2020

brion added a comment to T227074: Transcoding fails for large videos for QHD and UHD resolution.

I suspect it's the file size limit yes -- ffmpeg seems to be exiting with SIGXFSZ (signal 25, exit code 153) which means 'exceeded file size'. This is probably not the file system limit, but the resource limit applied to the transcode process? However transcodes going over 4 GB may have trouble being stored anyway. :(

Jan 17 2020, 9:21 PM · TimedMediaHandler-Transcode