Page MenuHomePhabricator

brion (Brion Vibber)
User

Projects (19)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (477 w, 3 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Brion Vibber (WMF) [ Global Accounts ]

Recent Activity

Mon, Dec 4

brion added a comment to T68722: [iOS app] Some media (esp. video) files do not work.

BTW. I realised that HLS doesn't support media temporal fragments, so likely start and end params won't work on iOS. There is probably no easy way around that, we'll likely have to come up with something custom.

m3u8 has #EXT-X-START:TIME-OFFSET=-15, but as start/end are transclusion params, we can't easily embed them into the manifest without using dynamic manifests (currently we have static manifests)

Mon, Dec 4, 11:11 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, Maintenance-Worktype, Wikipedia-iOS-App-Backlog
brion added a comment to T68722: [iOS app] Some media (esp. video) files do not work.

Started bulk re-encoding with the remuxing being used transparently whenever possible. I expect full coverage at at least base resolution by end of calendar year. :D

Mon, Dec 4, 11:05 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, Maintenance-Worktype, Wikipedia-iOS-App-Backlog

Tue, Nov 21

brion closed T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes as Resolved.

Closing.

Tue, Nov 21, 8:52 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode

Mon, Nov 20

brion added a comment to T351557: Transcode in "Unknown status" and "reset" or purge does not help.

[In general I know we've got some order of operations problems with the transcode table and other db bits, the job queue, and the file storage -- three distinct storage systems which need to be either in sync or in the proper order to handle weird sync issues. I'm going to collect up a few of these related issues today and try to work them out in the next couple days. If we're lucky I'll have something up for code review before the Thanksgiving holiday Thursday! If not I'll keep poking at it later.]

Mon, Nov 20, 5:15 PM · Commons, TimedMediaHandler-Transcode
brion claimed T351557: Transcode in "Unknown status" and "reset" or purge does not help.

I'll add this to my queue. Currently I'm chasing down bulk encodings; chasing down ongoing errors will be next and I expect several synchronization-related problems with cached data chunks. :)

Mon, Nov 20, 4:41 PM · Commons, TimedMediaHandler-Transcode

Sun, Nov 19

brion changed the status of T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes from Open to In Progress.

Script completed. If no surprises during the next couple days of rebuilds, all should be well to resolve. :D

Sun, Nov 19, 2:08 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode

Fri, Nov 17

brion added a comment to T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes.

Script is up to the "An"s, I expect it to complete within ~24-48 hours.

Fri, Nov 17, 10:05 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode
brion reopened T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes as "Open".

Running a one-off rebuild of streaming manifests separately from the active transcodes. This should fix any that were damaged that haven't had a chance to be fixed by other runs yet:

Fri, Nov 17, 7:52 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode
brion added a comment to T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes.

It'll require actually updating one of the other transcodes on an affected file to rebuild the m3u8 to work again... I've got several batches running, but I might be able to force a simple regeneration too.

Fri, Nov 17, 7:20 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode

Wed, Nov 15

brion closed T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes as Resolved.

Fix deployed, these'll get cleaned up as transcodes run.

Wed, Nov 15, 10:43 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode

Mon, Nov 13

Krinkle awarded T152851: TMH should not make DB writes on HTTP GET for its on-the-fly transcode corrections a Love token.
Mon, Nov 13, 5:30 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Wikimedia-Performance-recommendation, Wikimedia-production-error, TimedMediaHandler
brion added a comment to T152851: TMH should not make DB writes on HTTP GET for its on-the-fly transcode corrections.

I think we can just take this bit out safely, it wasn't reliable and the requeue scripts have to handle the case where a row just got left anyway. :D Patch coming...

Mon, Nov 13, 4:35 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Wikimedia-Performance-recommendation, Wikimedia-production-error, TimedMediaHandler
brion claimed T152851: TMH should not make DB writes on HTTP GET for its on-the-fly transcode corrections.

Oof, yeah that explains it. I'll add it to my pile of fixes for this week. :D

Mon, Nov 13, 4:24 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Wikimedia-Performance-recommendation, Wikimedia-production-error, TimedMediaHandler

Sun, Nov 12

brion added a comment to T152851: TMH should not make DB writes on HTTP GET for its on-the-fly transcode corrections.

Nothing should be writing to the database from TimedMediaHandler in page views, as far as I know. I think there used to be something years ago but if it's still there it needs to be removed. Is this still a problem that anyone is aware of?

Sun, Nov 12, 1:54 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Wikimedia-Performance-recommendation, Wikimedia-production-error, TimedMediaHandler
brion closed T309823: Disable old WebM VP8 transcodes except for 360p as Resolved.

done

Sun, Nov 12, 1:48 AM · Wikimedia-Site-requests
brion closed T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files as Resolved.

this finished :D

Sun, Nov 12, 1:47 AM · Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode
brion closed T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files, a subtask of T312152: Clean up video transcode config for speed/bitrate balance, as Resolved.
Sun, Nov 12, 1:46 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), TimedMediaHandler-Transcode
brion added a comment to T200939: Intermittent transcode error "Invalid frame size: 0x0.".

This still happens, and it's mildly annoying. ;) We may need to force proper chronology on the database connections used to fetch file data? Anyway, back on the slate for cleanup work :D

Sun, Nov 12, 12:21 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), User-TheDJ, TimedMediaHandler-Transcode

Sat, Nov 11

brion closed T104062: Halve frame rate on 48/50/60fps video transcodes as Declined.

I changed my mind and, in recent updates, instead added extra bandwidth for the higher-frame-rate videos so they still compress nicely.

Sat, Nov 11, 9:22 PM · TimedMediaHandler-Transcode
brion added a subtask for T166025: Enable AAC-LC support for Commons uploads and TMH/etc. playback (not patent-encumbered anymore since 2018): T155320: Implement strict mime type detection and media type inferring of audio/video files.
Sat, Nov 11, 9:16 PM · TimedMediaHandler-Transcode, UploadWizard, WMF-Legal, Commons, Multimedia
brion added a subtask for T159885: Support upload of MJPEG video in AVI or MOV container: T155320: Implement strict mime type detection and media type inferring of audio/video files.
Sat, Nov 11, 9:16 PM · TimedMediaHandler-Transcode, Video
brion added a subtask for T329258: Enable H.264/MP4 support for Commons uploads and TMH/etc. playback : T155320: Implement strict mime type detection and media type inferring of audio/video files.
Sat, Nov 11, 9:16 PM · TimedMediaHandler-Transcode, Commons
brion added parent tasks for T155320: Implement strict mime type detection and media type inferring of audio/video files: T166025: Enable AAC-LC support for Commons uploads and TMH/etc. playback (not patent-encumbered anymore since 2018), T159885: Support upload of MJPEG video in AVI or MOV container, T329258: Enable H.264/MP4 support for Commons uploads and TMH/etc. playback .
Sat, Nov 11, 9:16 PM · TimedMediaHandler-Transcode, MediaWiki-File-management, Commons, Multimedia, Technical-Debt
brion added a comment to T159885: Support upload of MJPEG video in AVI or MOV container.

For .mov container input, which is reasonably common on certain generations of cameras, all we should need now is consistent support for ISO BMFF-family input files with proper codec validation (right now we kinda half-ass it). Depending on source files, some may have AAC audio as well (cf T166025).

Sat, Nov 11, 9:12 PM · TimedMediaHandler-Transcode, Video
brion reopened T304624: WebM with multichannel OPUS audio fails on Safari as "Open".

Hm, maybe I misremember. I'll check this back next week, it still isn't playing in Safari and I'm not sure if it's a cache thing or a breakage thing and I'll deal with it Monday.

Sat, Nov 11, 8:19 PM · Browser-Support-Apple-Safari, MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), TimedMediaHandler
brion closed T304624: WebM with multichannel OPUS audio fails on Safari as Resolved.

I've implemented the squooshing to 2-channel output in recent updates since We Can't Have Nice Things. Re-running transcodes on this file. See T351025 for the more permanent long-term solution of adding surround tracks probably using AAC

Sat, Nov 11, 7:36 PM · Browser-Support-Apple-Safari, MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), TimedMediaHandler
brion added a parent task for T166025: Enable AAC-LC support for Commons uploads and TMH/etc. playback (not patent-encumbered anymore since 2018): T351025: Multichannel surround sound track for video transcodes (at least 5.1-channel support).
Sat, Nov 11, 7:34 PM · TimedMediaHandler-Transcode, UploadWizard, WMF-Legal, Commons, Multimedia
brion added a subtask for T351025: Multichannel surround sound track for video transcodes (at least 5.1-channel support): T166025: Enable AAC-LC support for Commons uploads and TMH/etc. playback (not patent-encumbered anymore since 2018).
Sat, Nov 11, 7:34 PM · TimedMediaHandler-Transcode
brion created T351025: Multichannel surround sound track for video transcodes (at least 5.1-channel support).
Sat, Nov 11, 7:33 PM · TimedMediaHandler-Transcode
brion added a comment to T166025: Enable AAC-LC support for Commons uploads and TMH/etc. playback (not patent-encumbered anymore since 2018).

Current state of this:

Sat, Nov 11, 7:24 PM · TimedMediaHandler-Transcode, UploadWizard, WMF-Legal, Commons, Multimedia
brion created T351023: Raise hard limit for transcode sizes to 4 GiB or higher.
Sat, Nov 11, 6:48 PM · TimedMediaHandler-Transcode

Fri, Nov 10

brion created T350996: HLS meta playlist .m3u8 includes not-yet-made transcodes.
Fri, Nov 10, 4:58 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), TimedMediaHandler-Transcode

Nov 8 2023

brion created T350816: Special:Transcode_statistics is very slow to load on Commons, cuts off lots of info.
Nov 8 2023, 6:00 PM · Patch-For-Review, TimedMediaHandler

Nov 7 2023

brion created T350699: 2-day+ duration reported on particular webm media file.
Nov 7 2023, 3:49 PM · TimedMediaHandler

Nov 1 2023

brion added a comment to T340161: GetID3 returns junk bytes for description of some mp3 files. FFmpeg skips these bytes.

When time permits I'm planning to do a big refactor on the MPEG and MP3 parsers for getid3 and submit that upstream; there's a lot of things that are legit in bitstreams but it doesn't handle properly.

Nov 1 2023, 9:54 PM · TimedMediaHandler, Commons

Oct 26 2023

brion added a comment to T68722: [iOS app] Some media (esp. video) files do not work.

Background run for backfill is going; this may take quite some time to complete, but I think should have an initial low-res data set within a few days for everything. I'll continue to monitor it while tweaking the app for a cleaner display & interaction, but basic playback should "just start working" in the iOS app over time :D

Oct 26 2023, 8:55 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, Maintenance-Worktype, Wikipedia-iOS-App-Backlog
brion added a comment to T349842: Update TimedMediaHandler UI for Codex design system, MediaViewer consistency.

Short version would be to just swap OOUI dialogs for vue+Codex dialogs? Probably worth doing to future-proof.

Oct 26 2023, 4:34 PM · TimedMediaHandler
brion created T349842: Update TimedMediaHandler UI for Codex design system, MediaViewer consistency.
Oct 26 2023, 4:20 PM · TimedMediaHandler

Oct 24 2023

brion added a comment to T329258: Enable H.264/MP4 support for Commons uploads and TMH/etc. playback .

*nod*; AAC could come in as a standalone .m4a or with MPEG-4 Visual video in .3gp files for instance; we'd need to get legal clearance on both but it should be straightforward to start working towards that (eg, making sure we can selectively check for codecs in an ISO BMFF/MP4/QuickTime-family media file and start allow-listing the ones we don't have a worry about)

Oct 24 2023, 9:14 PM · TimedMediaHandler-Transcode, Commons
brion added a comment to T329258: Enable H.264/MP4 support for Commons uploads and TMH/etc. playback .

It would be pretty trivial to enable H.264 and AAC output, we have all the necessary machinery ready to go for traditonal flat .mp4 files and can very easily add definitions for HLS. AAC may be good to go as far as patent expiration but there's not a big rush to enable it unless H.264 comes along for the ride, and that's still got some time yet.

Oct 24 2023, 3:37 PM · TimedMediaHandler-Transcode, Commons

Oct 18 2023

brion added a comment to T348913: Video not appearing in embed mode.

Yep, that does it. :D Good catch!

Oct 18 2023, 6:47 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), TimedMediaHandler

Oct 17 2023

brion claimed T68722: [iOS app] Some media (esp. video) files do not work.

Note that testing with the new iOS-compatible HLS track output is very promising so far! This is enabled on local media files on test.wikipedia.org only so far; playback is functional and supports native fullscreen and picture-in-picture. I'm taking this bug assignment to do some further work on the iOS app to tweak the styles to get larger videos sized nicely etc. :D

Oct 17 2023, 5:21 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, Maintenance-Worktype, Wikipedia-iOS-App-Backlog

Oct 16 2023

brion claimed T348667: DBUnexpectedError while deleting or moving file.

This should be fixed since the deployment circa 12 hours ago. Please confirm and resolve when you have a chance, thanks!

Oct 16 2023, 8:54 PM · TimedMediaHandler, Wikimedia-production-error, Commons
brion claimed T348689: WebVideoTranscode::updateStreamingManifests: Cannot flush pre-lock snapshot.

This should be fixed since the deployment circa 12 hours ago. Please confirm and resolve when you have a chance, thanks!

Oct 16 2023, 8:54 PM · Commons, TimedMediaHandler, Wikimedia-production-error
brion claimed T348375: Commons removal of last remaining caption: Caught exception of type Wikimedia\Rdbms\DBUnexpectedError.

This should be fixed since the deployment circa 12 hours ago. Please confirm and resolve when you have a chance, thanks!

Oct 16 2023, 8:53 PM · MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), TimedMediaHandler-Transcode, Wikimedia-production-error, Structured-Data-Backlog
brion added a comment to T348667: DBUnexpectedError while deleting or moving file.

Does the legal team have a specific thing they're interested in investigating? (eg, are you claiming that a specific problem file was reported and could not be deleted, and that nobody forwarded the issue on to the ops team to expedite deployment of the fix? Or are you just thinking out loud?)

Oct 16 2023, 7:20 PM · TimedMediaHandler, Wikimedia-production-error, Commons
brion closed T109079: Enable 4320p (aka 8k) video support in TMH as Declined.

No practical use for 8k other than VR video, which we don't support, and even if we did handling the conversion would be extremely expensive. Declining.

Oct 16 2023, 7:19 PM · Patch-Needs-Improvement, TimedMediaHandler-Transcode
brion claimed T348913: Video not appearing in embed mode.

Definitely regressions in the last few months since I last tested it, I'm adding this to my short-list for this week.

Oct 16 2023, 3:46 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), TimedMediaHandler

Oct 12 2023

brion added a comment to T348753: [026f63a8-bebd-49dd-a536-746796d71575] /w/api.php Exception: Errors saving HLS playlist LL-Q8097_(tel)-V_Bhavya-క్రొ.wav.m3u8.

I could make these non-fatal errors I guess, just log and move on. :(

Oct 12 2023, 3:14 PM · MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Regression, SRE-swift-storage, TimedMediaHandler, Wikimedia-production-error
brion added a comment to T348753: [026f63a8-bebd-49dd-a536-746796d71575] /w/api.php Exception: Errors saving HLS playlist LL-Q8097_(tel)-V_Bhavya-క్రొ.wav.m3u8.

Oh I see it's saving empty playlists anyway heh. Well that's fine, it should work and be harmless...

Oct 12 2023, 3:13 PM · MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Regression, SRE-swift-storage, TimedMediaHandler, Wikimedia-production-error
brion added a comment to T348753: [026f63a8-bebd-49dd-a536-746796d71575] /w/api.php Exception: Errors saving HLS playlist LL-Q8097_(tel)-V_Bhavya-క్రొ.wav.m3u8.

Note there shouldn't be any streaming transcodes made for .wav files at this time, so something's amiss as well.

Oct 12 2023, 3:11 PM · MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Regression, SRE-swift-storage, TimedMediaHandler, Wikimedia-production-error
brion added a comment to T348689: WebVideoTranscode::updateStreamingManifests: Cannot flush pre-lock snapshot.

Is it simply unsafe to use locks in the database to ensure consistency between DB and filesystem?

Oct 12 2023, 2:06 PM · Commons, TimedMediaHandler, Wikimedia-production-error
brion added a comment to T348667: DBUnexpectedError while deleting or moving file.

So is this believed to be fixed by the recent fix? Or did the fix already go out and didn't fix this?

Oct 12 2023, 2:03 PM · TimedMediaHandler, Wikimedia-production-error, Commons

Oct 10 2023

brion added a comment to T289189: getid3: PHP Warning: Division by zero.

Not yet. wikimedia/getid3 isn't published yet, and production is still pinned to james-heinrich/getid3. Can you get it published so I can update vendor?

Oct 10 2023, 5:51 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Patch-For-Review, PHP 8.1 support, Upstream, User-brennen, TimedMediaHandler, Wikimedia-production-error

Oct 5 2023

brion added a comment to T309823: Disable old WebM VP8 transcodes except for 360p.

I'm running the cleanup batch script now on mwmaint2002

Oct 5 2023, 4:42 PM · Wikimedia-Site-requests

Oct 4 2023

brion added a comment to T246901: Support full colour 3D models on Wikimedia projects.

So if we add server-side rendering, we need a clean way to sandbox it, that works both in standalone installs and via Thumbor, and can be relatively sensibly managed and packaged, and made disableable with a switch-flip. I'm also hoping to work on some iframe sandboxing stuff for media embedding, which will later be usable in stuff like media renderers (which we can port the existing video & 3d interfaces into when it's ready)... I think we've got some tasks open for that related to Graphs, I'll track that down later :D

Oct 4 2023, 8:16 PM · User-John_Cummings, Commons, 3D
brion added a comment to T246901: Support full colour 3D models on Wikimedia projects.

[Note: in general pulling in binary file parsers/renderers is a big extra security risk for server-side execution. Pulling in a large JavaScript rendering library is also a security risk for client-side safety, as it could expose an XSS injection vector in the library that can be used against the entire page. So there's a relatively high bar, and we've seen problems in production for real with Graphs etc.]

Oct 4 2023, 8:10 PM · User-John_Cummings, Commons, 3D
brion added a comment to T246901: Support full colour 3D models on Wikimedia projects.

Note that improving media file format support is still not something that's explicitly receiving resourcing at Wikimedia Foundation, so it's good to have a low cost in terms of implementation work (note that this includes thumbnailing via thumbor, an entirely separate package), low risk in terms of tooling safety from libraries and executables used in rendering on the server or client side, an easy way to embed the resulting view into mobile apps without too much platform-specific coding, and an easy safe way to downgrade support if security problems are found in the future.

Oct 4 2023, 8:05 PM · User-John_Cummings, Commons, 3D

Oct 2 2023

brion added a comment to T304624: WebM with multichannel OPUS audio fails on Safari.

It probably wouldn't hurt to just go ahead and squoosh channels to 2 on the webms too, with the adaptive streaming tracks as the future escape hatch for full-quality output on compatible systems. Sigh. I'll prep a quick update patch.

Oct 2 2023, 9:13 PM · Browser-Support-Apple-Safari, MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), TimedMediaHandler
brion added a comment to T304624: WebM with multichannel OPUS audio fails on Safari.

Given the "fun" of difficult-to-detect channel limitations and inconsistency in playback spport, looks like we'll be generating stereo output for now. :) But I've left room open on the HLS streaming tracks to add multichannel tracks alongside the stereo tracks, which can be marked separately with their channel count (assuming iOS actually pays attention to that for compatibility checking....)

Oct 2 2023, 8:52 PM · Browser-Support-Apple-Safari, MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), TimedMediaHandler
brion closed T309811: requeueTranscodes.php --file option doesn't accept spaces as Resolved.

This turned out to be a problem with my test configuration, I was having trouble with positional parameters being passed into the command line. :D

Oct 2 2023, 8:44 PM · TimedMediaHandler

Sep 28 2023

brion closed T289189: getid3: PHP Warning: Division by zero as Resolved.

with the merge of the TMH updates including the forked getid3 library, this fix'll go out with the next train. Yay!

Sep 28 2023, 7:02 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Patch-For-Review, PHP 8.1 support, Upstream, User-brennen, TimedMediaHandler, Wikimedia-production-error
brion closed T289189: getid3: PHP Warning: Division by zero, a subtask of T319065: All Wikimedia production extensions and skins must support PHP 8.1, as Resolved.
Sep 28 2023, 7:01 PM · MediaWiki-extensions-General, PHP 8.1 support
brion added a comment to T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files.

I can start this once this config patch goes out:

Sep 28 2023, 6:11 PM · Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode
brion changed the status of T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files, a subtask of T312152: Clean up video transcode config for speed/bitrate balance, from Stalled to Open.
Sep 28 2023, 5:21 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), TimedMediaHandler-Transcode
brion changed the status of T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files from Stalled to Open.

Reviving this as we landed the much-redone patch today and it should hit live in the next train. :) Self-assigning as I'll run it myself.

Sep 28 2023, 5:21 PM · Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode

Sep 11 2023

brion changed the status of T289189: getid3: PHP Warning: Division by zero, a subtask of T319065: All Wikimedia production extensions and skins must support PHP 8.1, from Stalled to In Progress.
Sep 11 2023, 6:26 PM · MediaWiki-extensions-General, PHP 8.1 support
brion changed the status of T289189: getid3: PHP Warning: Division by zero from Stalled to In Progress.

Above patch includes an update to our newly forked copy of getid3 and should include all previously merged but unreleased patches, as well as my additional recent patches for MPEG parsing.

Sep 11 2023, 6:26 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Patch-For-Review, PHP 8.1 support, Upstream, User-brennen, TimedMediaHandler, Wikimedia-production-error

Aug 17 2023

brion added a comment to T341587: Redirect to transcoded version of [[Media:file]] links.

Hm, an alternative is to make [[Media:]] links behave magically via JS in a way that gives you a player on click instead of a raw download. I don't know if that would be a desireable change in behavior though.

Aug 17 2023, 4:57 PM · Parsoid, MediaWiki-Parser
brion added a comment to T341587: Redirect to transcoded version of [[Media:file]] links.

IMO [[Media:]] should only be used for raw download links, if at all; for things like inline pronunciation guides we need an inline-triggerable player that actually supports the use case of playing a short audio file on click without replacing the entire tab with a full-window player or a download, depending on your browser and the format.

Aug 17 2023, 4:11 PM · Parsoid, MediaWiki-Parser

Aug 15 2023

brion added a comment to T337103: Decide a standard approach for classifying temporary, IP and registered users.

In the olden days, 'anon' meant 'there's no user_id and no matching user table row, so you can't look them up in the database except for other edits via the same IP which might not be theirs". This definitely does not apply to temporary users, as I understand, who have a user_id and can have their individual contributions looked up.

Aug 15 2023, 6:31 PM · Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Temporary accounts

Jul 27 2023

brion added a comment to T342040: TypeError: undefined is not an object (evaluating 'src[src.length-1].res') .

Looks like a failure that can happen sometimes if no sources are compatible, which appears to be mostly happening on Safari and other WebKit browsers, judging by the user-agents. This should be improved by the patch for T312152 which is still in CR, which cleans up a bunch of config and adds iOS-friendly video output, but it does sound like there's a straight up bug somewhere in that it should either not assume that array is not empty or ensure it isn't. :D

Jul 27 2023, 4:38 PM · Unstewarded-production-error, TimedMediaHandler, Wikimedia-production-error

Jul 21 2023

Prototyperspective awarded T18691: RFC: Section header "share" link a Like token.
Jul 21 2023, 3:40 PM · Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Jul 7 2023

brion added a comment to T318419: Upgrade Wikimedia production's ffmpeg to 4.4 or later so we can use the fpsmax flag.

Note I've worked around this in the related cleanup on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/888279 using an explicit -r rate override as necessary based on detected input frame rate being over the max (normally 60).

Jul 7 2023, 7:56 PM · serviceops, TimedMediaHandler, SRE

Jul 6 2023

brion triaged T340399: Enhancement: TimedMediaHandler: don't transcode to higher bitrate as Low priority.
Jul 6 2023, 3:21 PM · TimedMediaHandler
brion added a comment to T340399: Enhancement: TimedMediaHandler: don't transcode to higher bitrate .

(More generally, the version of TMH you're running might still have the old dreadful encoding params for VP9 which bias it towards using a high bitrate on complex input -- which is what "noisy" encoding artifacts look like!)

Jul 6 2023, 3:18 PM · TimedMediaHandler
brion added a comment to T340399: Enhancement: TimedMediaHandler: don't transcode to higher bitrate .

Note that the problem here is that the source file is at *MUCH* too low a bitrate and is thus full of encoding artifacts. The transcode then spends a normal amount of bits replicating all the encoding artifacts as closely as possible.

Jul 6 2023, 3:17 PM · TimedMediaHandler

Jun 23 2023

brion added a comment to T282397: All audio files appear to be 0 seconds long because of preload=none.

Whoops, missed the last pings on this one. I suspect preload=meta is likely fine for audio... lemme put this back on my todo list to clear up

Jun 23 2023, 5:40 PM · TimedMediaHandler

Jun 20 2023

brion added a comment to T339918: TimedMediaHandler runs ffmpeg immediately instead of via runJobs.php .

Hmm, that file's converting ok for my local test instance with $wgTmhEnableMp4Uploads enabled to upload the .mp4, running in MediaWiki-Docker. The debug log should have the actual command lines and any returned error codes (though.... error codes should cause it to reject the conversion and not save it!)

Jun 20 2023, 7:31 PM · TimedMediaHandler
brion added a comment to T339918: TimedMediaHandler runs ffmpeg immediately instead of via runJobs.php .

My suspicion is the job run rate is the culprit, yeah. We really should think about cleaner defaults for this, but the requirement to set up some kind of background service to make the background jobs really work properly is kind of painful. :(

Jun 20 2023, 5:40 PM · TimedMediaHandler

Jun 12 2023

brion created T338820: Request creation of media-streaming VPS project.
Jun 12 2023, 4:28 PM · cloud-services-team, Cloud-VPS (Project-requests)

May 25 2023

brion committed rEBOP99c2c07ee354: please don't fuck over every other extension by canceling their message-add… (authored by brion).
please don't fuck over every other extension by canceling their message-add…
May 25 2023, 6:59 PM
brion committed rEBOP2b3742a0abe9: Update a butt-ton of extension about URLs to point to https://www.mediawiki.org/ (authored by brion).
Update a butt-ton of extension about URLs to point to https://www.mediawiki.org/
May 25 2023, 6:59 PM
brion committed rEMNLc17d9a04ca92: Update a butt-ton of extension about URLs to point to https://www.mediawiki.org/ (authored by brion).
Update a butt-ton of extension about URLs to point to https://www.mediawiki.org/
May 25 2023, 6:57 PM
brion committed rEEUS2c3e6c2b0cac: Revert r32410, r32411, r32412 -- smart quotes infecting everything (authored by brion).
Revert r32410, r32411, r32412 -- smart quotes infecting everything
May 25 2023, 5:59 PM
brion committed rEEUS8475fd571d30: Remove stray require_once of GlobalFunctions.php from EditUser extension's… (authored by brion).
Remove stray require_once of GlobalFunctions.php from EditUser extension's…
May 25 2023, 5:58 PM
brion committed rEEUS490cb69587ee: Update a butt-ton of extension about URLs to point to https://www.mediawiki.org/ (authored by brion).
Update a butt-ton of extension about URLs to point to https://www.mediawiki.org/
May 25 2023, 5:58 PM

May 17 2023

Galessandroni awarded T244570: Fix missing thumbnail for MPEG (.mpg) videos a Party Time token.
May 17 2023, 4:22 PM · Thumbor, TimedMediaHandler
valerio.bozzolan awarded T244570: Fix missing thumbnail for MPEG (.mpg) videos a Yellow Medal token.
May 17 2023, 4:13 PM · Thumbor, TimedMediaHandler

Mar 13 2023

brion added a comment to T68722: [iOS app] Some media (esp. video) files do not work.

State of the world update!

Mar 13 2023, 4:01 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, Maintenance-Worktype, Wikipedia-iOS-App-Backlog

Jan 24 2023

Nicolas_Raoul awarded T88746: Upload photos on Wikipedia mobile app's edit screen a Love token.
Jan 24 2023, 8:59 AM · Commons, NewFunctionality-Worktype, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog

Dec 16 2022

brion created T325379: Request membership in operations-software-thumbor-plugins group for brion.
Dec 16 2022, 6:08 PM · Gerrit-Privilege-Requests

Dec 11 2022

waldyrious awarded T2001: [DO NOT USE] Documentation is out of date, incomplete (tracking) [superseded by #Documentation] a Heartbreak token.
Dec 11 2022, 10:43 PM · Documentation, Tracking-Neverending, MediaWiki-Documentation

Nov 24 2022

Sj awarded T115814: Talk with Internet Archive folks about simplifying video importing, IA-side WebM transcoding a Love token.
Nov 24 2022, 8:34 PM · Video, Internet-Archive

Sep 18 2022

Qgil awarded T27854: Expose image thumbs, embedded video players via oEmbed (API + discovery <link rel>) a Love token.
Sep 18 2022, 9:34 AM · Structured-Data-Backlog, TimedMediaHandler, Structured Data Engineering, Epic

Aug 17 2022

Sophivorus awarded T131516: Reduce or eliminate the need for the user to touch <translate> tags and unit markers a Love token.
Aug 17 2022, 11:23 AM · Epic, VisualEditor, MediaWiki-Page-editing, MediaWiki-extensions-Translate

Jul 5 2022

brion added a subtask for T312152: Clean up video transcode config for speed/bitrate balance: T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files.
Jul 5 2022, 7:09 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), TimedMediaHandler-Transcode
brion added a parent task for T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files: T312152: Clean up video transcode config for speed/bitrate balance.
Jul 5 2022, 7:09 PM · Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode
brion created T312153: Batch run of TMH requeueTranscodes to remove now-unused 120p and 180p low-res files.
Jul 5 2022, 7:09 PM · Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode
brion created T312152: Clean up video transcode config for speed/bitrate balance.
Jul 5 2022, 7:01 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), TimedMediaHandler-Transcode