brion (Brion Vibber)
User

Projects (23)

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (140 w, 1 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Thu, Jun 15

brion added a comment to T150369: Record an event every time a new content namespace page is created.

I have the impression rev_parent_id isn't reliable but don't offhand recall how they can break under the hood... Worth taking a look to see if we can make it reliable. :)

Thu, Jun 15, 6:27 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), EventBus, Patch-For-Review, Community-Tech-Sprint, Wikimedia-Hackathon-2017, Analytics, Easy, Contributors-Analysis, Analytics-EventLogging
dbarratt awarded T33338: Export file thumbnail, video preview via Open Graph meta elements as Facebook posting helper a Like token.
Thu, Jun 15, 4:35 PM · MediaWiki-extension-requests
brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Recommended fix: move the sanitization in MemcacheBagOStuff->makeKeyInternal up to BagOStuff->makeKeyInternal and just apply it evenly everywhere so no surprises.

I'm not sure we can assume a single encoding will (or should) work on every backend. I'd rather keep this generic.

Thu, Jun 15, 2:46 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
brion added a comment to T143188: "Key contains invalid characters" exception when purging pages with a "ä" in the title.

Similar symptoms and root problem to T167465 (incorrectly escaped key values), though with a twist -- WikiArticleFeeds appears to be generating its own keys here, without using any key-creation function. This is probably solvable using $messageMemc->makeKey() (1.27 or later) or the older wfMemcKey() function with relevant parameters.

Thu, Jun 15, 2:24 AM · WikiArticleFeeds

Fri, Jun 9

brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Ok, my vagrant install is using MemcachedBagOStuff which has a makeKeyInternal() which uses rawurlencode() on input strings, but in production we're using MultiWriteBagOStuff which does not override the naive base implementation from BagOStuff.

Fri, Jun 9, 12:36 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Turns out Language::isValidCode() lets a lot through that I didn't expect for compatibility with weird hacks. It should prevent actual < and > and path-traversals etc, but is letting the non-ASCIIs through directly.

Fri, Jun 9, 12:15 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Per irc, note that Wikibase's splitting everything on user lang is why the userlang appears in pcache and thus the bug is visible on any page on Commons, given the URL param, but on meta or enwiki it needs to be a page that uses user-lang stuff specifically.

Fri, Jun 9, 12:00 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors

Thu, Jun 8

brion added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Note this doesn't look image-specific; I get exception thrown if I try on a regular page that exists too, such as https://commons.wikimedia.org/wiki/Main_Page?uselang=%E2%A7%BCLang%E2%A7%BD BUT - I don't see the equivalent error on enwiki. https://en.wikipedia.org/wiki/Main_Page?uselang=%E2%A7%BCLang%E2%A7%BD does not error out.

Thu, Jun 8, 11:21 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors

Wed, Jun 7

brion updated the task description for T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Wed, Jun 7, 2:17 AM · Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team
brion added a subtask for T161671: Compacting the revision table: T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Wed, Jun 7, 2:14 AM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team
brion added a parent task for T167246: Refactor "user" & "user_text" fields into "actor" reference table: T161671: Compacting the revision table.
Wed, Jun 7, 2:14 AM · Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team
brion created T167246: Refactor "user" & "user_text" fields into "actor" reference table.
Wed, Jun 7, 2:14 AM · Patch-For-Review, MediaWiki-Database, MediaWiki-Platform-Team

Fri, May 26

brion added a comment to T164401: Error creating thumbnail for webm video.

@Richard_Nevell_WMUK the file appears to have been trimmed or generated in a strange way: its timestamps start at ~201 seconds in, which confuses the heck out of Firefox, ffmpeg, etc. As a result, when ffmpeg skips through what it thinks is half the file, there's no video frames left to decode, and no thumbnail can be generated.

Fri, May 26, 6:50 PM · TimedMediaHandler, Wikimedia-Video

Thu, May 25

Krinkle awarded T158181: Aim for 1:1 feature equivalence for MediaWiki on desktop and mobile web a Orange Medal token.
Thu, May 25, 1:47 PM · Reading-Web-Backlog, Epic, MobileFrontend, MediaWiki-General-or-Unknown, Technical-Debt

May 22 2017

brion added a comment to T153333: RFC: How should we store longer revision comments?.

I'll fix that :)

May 22 2017, 10:04 AM · ArchCom-RfC, Community-Tech

May 21 2017

brion removed a parent task for T120288: Once it's not patent-encumbered, enable MP3 support for Commons uploads and TMH/etc. playback: T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback.
May 21 2017, 9:49 PM · Support-and-Safety, TimedMediaHandler, WMF-Legal, UploadWizard, Commons, User-notice, Multimedia
brion removed a subtask for T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback: T120288: Once it's not patent-encumbered, enable MP3 support for Commons uploads and TMH/etc. playback.
May 21 2017, 9:49 PM · UploadWizard, TimedMediaHandler, WMF-Legal, Commons, Multimedia
brion added a comment to T103421: Publish File_Ogg as a composer package.

Ok current status on this -- I need to pick up my modernize branch from https://github.com/brion/File_Ogg/commits/modernize and finish reworking it for PSR-4 so it's autoloader-friendly and composer-friendly.

May 21 2017, 4:43 PM · Librarization, TimedMediaHandler
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Poop, error isn't thrown until play when using preload=none. We'll need to manually check the sources against .canPlayType() via a small JS function. We'll also possibly want this for other old browsers that get degraded in future that don't have native ogg/webm but do have HTML5 video.

May 21 2017, 4:23 PM · Patch-For-Review, TimedMediaHandler-Player
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Ok we tested this at wmhack. Quick note we need special handling for IE9, which supports <video> but none of our codecs (or ogv.js) and also gets grade C non-JS mode.

May 21 2017, 4:12 PM · Patch-For-Review, TimedMediaHandler-Player

May 20 2017

brion updated subscribers of T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

@Krinkle I'm not sure we need T122965 for this; the fallback content should "just work" and the contained image would behave the same as the <video> in terms of its sizing and inline-block nature.

May 20 2017, 11:49 PM · Patch-For-Review, TimedMediaHandler-Player
brion added a comment to T148586: TMH videojs mode has no fallback content for video and audio for IE 8/7/6.

Hmm, i have a lot of open questions on this. UI wise it's pretty shitty no matter what you do, File page linking vs download media remains a problem (which goes where?), and it's a lot of extra bytes...

May 20 2017, 11:48 PM · Patch-For-Review, TimedMediaHandler-Player
brion added a comment to T70648: phpunit failure: Module prefix '' is shared between ApiQueryProofread and ApiTranscodeStatus.

We can probably change ApiTranscodeStatus to have a prefix... or kill it entirely in favor of videoinfo/imageinfo. It doesn't appear to actually be used within TMH, and it's not a great interface if anybody's using it.

May 20 2017, 10:42 PM · TimedMediaHandler
brion added a comment to T151352: Ogg Opus-File should be classified as audio not multimedia-Files..

So... this is done, but the search links in the task summary still return the old data, probably due to CirrusSearch index being out of date? Do the pages need to be refreshed somehow in the search index or will this 'just happen' after some time?

May 20 2017, 10:28 PM · MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, TimedMediaHandler, Multimedia, MediaWiki-File-management, Discovery-Search, CirrusSearch, Commons, Discovery
brion added a comment to T151352: Ogg Opus-File should be classified as audio not multimedia-Files..

(Now running on all wikis :D)

May 20 2017, 9:37 PM · MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, TimedMediaHandler, Multimedia, MediaWiki-File-management, Discovery-Search, CirrusSearch, Commons, Discovery
brion added a comment to T151352: Ogg Opus-File should be classified as audio not multimedia-Files..

Seems to work (quarry shows the old data tho). Went ahead and ran on terbium:

May 20 2017, 9:16 PM · MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, TimedMediaHandler, Multimedia, MediaWiki-File-management, Discovery-Search, CirrusSearch, Commons, Discovery
brion added a comment to T151352: Ogg Opus-File should be classified as audio not multimedia-Files..

This should work:

May 20 2017, 9:05 PM · MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, TimedMediaHandler, Multimedia, MediaWiki-File-management, Discovery-Search, CirrusSearch, Commons, Discovery
brion added a comment to T151352: Ogg Opus-File should be classified as audio not multimedia-Files..

Note that requeueTranscodes used for the formats cleanup won't redo the media type in the image table; it just does transcodes. I'll check if there's anything suitable in core to rerun them or if I need to add a maint script.

May 20 2017, 9:00 PM · MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, TimedMediaHandler, Multimedia, MediaWiki-File-management, Discovery-Search, CirrusSearch, Commons, Discovery
brion added a comment to T161671: Compacting the revision table.

Per discussion at wmhack 2017 we're planning to split this into separate pieces we can work on in parallel and potentially deploy separately:

  • comment table (T153333) plus a temporary rev<->comment association table
    • consider also starting on use of comment in other tables, since it'll be more tractable
      • revision, archive, logging, recentchanges, image (img_description), oldimage (oi_description), filearchive (fa_description, fa_deleted_reason), ipblocks (ipb_reason), protected_titles (pt_reason)
      • extension tables: cu_log.cul_reason, cu_changes.cuc_comment, flow_revision.rev_mod_reason, globalblocks.gb_reason, global_block_whitelist.gbw_reason
    • some tables may need association table added as well, others may be small enough
  • actor table plus a temporary rev<->actor association table
    • consider also starting on use of actor in other tables, since it'll be more tractable
      • revision, archive, logging, recentchanges, image, oldimage, filearchive, ipblocks (ipb_by)
    • some tables may need association table added as well,
  • content plus slot association table
May 20 2017, 1:30 PM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team
brion reopened T154731: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php as "Open".

I get this error currently when editing files in Atom with phpcs linter enabled; does MediaWiki's composer.lock need updating?

May 20 2017, 12:07 PM · Community-Tech, Patch-For-Review, MediaWiki-Codesniffer
brion reopened T154731: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php, a subtask of T154715: Release Codesniffer v0.8.0, as Open.
May 20 2017, 12:07 PM · Patch-For-Review, MediaWiki-Codesniffer
brion added a comment to T153333: RFC: How should we store longer revision comments?.

Did we decide for sure on whether to use an association table bridging rev_id to comment_id, or whether to just use rev_id=comment_id until changing the revision table structure?

May 20 2017, 10:00 AM · ArchCom-RfC, Community-Tech
brion added a comment to T162395: Add .mp3 to the list of accepted file types on Wikimedia Commons uploads.

We obviously won't accept uploads until legal signs off, regardless of the front end features. Have patience. :)

May 20 2017, 7:26 AM · WMF-Legal, Commons

May 19 2017

brion removed a project from T165820: Parser tests do not run with PageImages extension installed: Patch-For-Review.

Agh that's patch to wrong bug. Whoops. :)

May 19 2017, 10:52 PM · PageImages, MediaWiki-Parser, MediaWiki-Unit-tests
brion created T165820: Parser tests do not run with PageImages extension installed.
May 19 2017, 10:37 PM · PageImages, MediaWiki-Parser, MediaWiki-Unit-tests
brion added a subtask for T100106: Replace Kaltura player with Video.js: T165817: BlockLevelPass matches "<track" to "<tr", causing missing <p> tags.
May 19 2017, 10:14 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Multimedia, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), Patch-For-Review, TimedMediaHandler-Player, Wikimedia-Video, Performance-Team, Wikimedia-Hackathon-2015, TimedMediaHandler
brion added a parent task for T165817: BlockLevelPass matches "<track" to "<tr", causing missing <p> tags: T100106: Replace Kaltura player with Video.js.
May 19 2017, 10:14 PM · Wikimedia-Hackathon-2017, MW-1.30-release-notes, TimedMediaHandler-Player, MediaWiki-Parser
brion created T165817: BlockLevelPass matches "<track" to "<tr", causing missing <p> tags.
May 19 2017, 10:13 PM · Wikimedia-Hackathon-2017, MW-1.30-release-notes, TimedMediaHandler-Player, MediaWiki-Parser
brion added a comment to T100106: Replace Kaltura player with Video.js.

Another problem: there's something wrong with block levels / paragraph wrapping.

May 19 2017, 9:24 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Multimedia, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), Patch-For-Review, TimedMediaHandler-Player, Wikimedia-Video, Performance-Team, Wikimedia-Hackathon-2015, TimedMediaHandler
brion added a comment to T100106: Replace Kaltura player with Video.js.

Per IRC there are breakages with the videojs 6.1 update; at a minimum, the resolution switcher plugin's icon is missing.

May 19 2017, 9:17 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Multimedia, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), Patch-For-Review, TimedMediaHandler-Player, Wikimedia-Video, Performance-Team, Wikimedia-Hackathon-2015, TimedMediaHandler
brion added a comment to T100106: Replace Kaltura player with Video.js.

@Jdforrester-WMF an aggressive schedule. I might recommend pushing the beta rollout back a week, as I'll be on an airplane all Monday.

May 19 2017, 4:51 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Multimedia, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), Patch-For-Review, TimedMediaHandler-Player, Wikimedia-Video, Performance-Team, Wikimedia-Hackathon-2015, TimedMediaHandler
brion claimed T100106: Replace Kaltura player with Video.js.

I'll take over the rest of the cleanup for this, want to finally get it out the door soon :)

May 19 2017, 2:58 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Multimedia, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), Patch-For-Review, TimedMediaHandler-Player, Wikimedia-Video, Performance-Team, Wikimedia-Hackathon-2015, TimedMediaHandler
brion closed T151199: Please mass-reset the video transcodes of tens of thousand videos stuck in "Unknown" state as Resolved.

@greg looks like the requeueTranscodes.php commonswiki --video --missing --throttle run finished April 2.

May 19 2017, 2:54 PM · Wikimedia-Site-requests, Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode, TimedMediaHandler
brion added a comment to T39865: Add ability to bind pages together.

An example is pages in a Help namespace that match up with a Template, Module, or other namespace.

May 19 2017, 1:34 PM · WorkType-NewFunctionality, MediaWiki-General-or-Unknown
brion created T165717: Support transcoding audio files to MP3 for playback on IE/Edge/Safari/etc.
May 19 2017, 8:01 AM · TimedMediaHandler-Transcode
brion added a comment to T162395: Add .mp3 to the list of accepted file types on Wikimedia Commons uploads.

Note that with the TimedMediaHandler support now getting merged, enabling this in production will mean setting $wgTmhEnableMp3Uploads to true in CommonSettings.php.

May 19 2017, 7:17 AM · WMF-Legal, Commons
brion added a comment to T115170: Add support for MP3.

The TMH update has been merged but will remain off until we flip $wgTmhEnableMp3Uploads on in config, so is safe to go to production branches. Note that the core change in https://gerrit.wikimedia.org/r/349596 for the MimeAnalyzer now includes sample test files, so we're waiting on legal's confirm to merge it.

May 19 2017, 7:07 AM · Wikimedia-Hackathon-2017, MW-1.30-release-notes, Patch-For-Review, TimedMediaHandler

May 10 2017

brion added a comment to T161647: RFC: Deprecate using php serialization inside MediaWiki.

Note for migration planning of usages -- IIRC serialized database stuff is mostly arrays or stdobjects, while memcache stuff has more serialized complex classes... (Memcache is a potential attack vector in many ways, and this makes it scarier!)

May 10 2017, 8:31 PM · ArchCom-RfC, Services (watching), Security
brion added a comment to T161647: RFC: Deprecate using php serialization inside MediaWiki.

One possible stop-gap for back-compatibility of old data for usages that don't require complex classes or looping object graphs would be to use a custom unserialize that can create stdObject instances only and never runs code.

May 10 2017, 8:24 PM · ArchCom-RfC, Services (watching), Security
brion added a comment to T161671: Compacting the revision table.

Current provisional work breakdown at https://www.mediawiki.org/wiki/Revision_refactor#Work_plan

May 10 2017, 7:31 PM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team

May 8 2017

brion added a comment to T161671: Compacting the revision table.

@daniel yes, will be around. Apologies my schedule's been a bit bumpy lately! I'm ok with funky meeting times to accommodate the others, just warn me ahead so I can make sure everything's in my calendar.

May 8 2017, 4:21 PM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team

Apr 28 2017

brion removed a watcher for Wikispeech: brion.
Apr 28 2017, 4:50 PM

Apr 25 2017

brion closed T114796: Investigate hardware acceleration of VP9 encoding as Declined.

I'm going to close this one out as getting special hardware for transcodes is unlikely to happen. Stick to software encoding for now which is easy to scale out.

Apr 25 2017, 6:31 PM · TimedMediaHandler-Transcode, TimedMediaHandler

Apr 18 2017

brion added a comment to T161671: Compacting the revision table.

Quick todo update for this week's work plan:

  • update the tables.sql in a work branch
  • start planning migration
  • poke Brad about migration stuff if interested
Apr 18 2017, 3:55 AM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team

Apr 17 2017

Calexit awarded T131932: Video and audio files should expose 'player cards' to Twitter for embedded playback a Like token.
Apr 17 2017, 1:54 PM · TimedMediaHandler, MediaWiki-extensions-TwitterCards

Apr 4 2017

Bawolff awarded T162077: User::pingLimiter always fails to limit when $wgMainCacheType is CACHE_NONE a Like token.
Apr 4 2017, 3:10 PM · MediaWiki-Cache

Apr 3 2017

brion created T162077: User::pingLimiter always fails to limit when $wgMainCacheType is CACHE_NONE.
Apr 3 2017, 6:59 PM · MediaWiki-Cache
jcrespo awarded T161671: Compacting the revision table a Party Time token.
Apr 3 2017, 3:14 PM · Patch-For-Review, MediaWiki-Database, Schema-change, MediaWiki-Platform-Team

Mar 31 2017

brion added a comment to T161918: videoscalers (mw1168, mw1169) - high load / overheating.

Note there are probably a lot of jobs in the non-prioritized queue still backed up last I looked; Note I also have a fill-in batch job on terbium that's throttled by queue length, which should be adding jobs only as fast as they get done. I can turn that queue job off if necessary.

Mar 31 2017, 10:40 PM · Operations

Mar 28 2017

brion added a comment to T161623: Jessie-based Vagrant box stores uploaded files on small 9.2G root partition.

The Debian Jessie base box? Yes, I believe that's where the small partition layout is coming from.

Mar 28 2017, 4:22 PM · MediaWiki-Vagrant
brion created T161623: Jessie-based Vagrant box stores uploaded files on small 9.2G root partition.
Mar 28 2017, 4:18 PM · MediaWiki-Vagrant

Mar 26 2017

brion updated subscribers of T161465: Thumbnail fails for high-res VP9 video "Women in botany and Wikipedia.webm".

It looks like the source file only has a single marked keyframe, which makes it difficult to decode a single frame partway through (that is, you have to decode all frames from the beginning, which takes a long time).

Mar 26 2017, 7:54 PM · Wikimedia-Video, TimedMediaHandler
brion created T161465: Thumbnail fails for high-res VP9 video "Women in botany and Wikipedia.webm".
Mar 26 2017, 7:40 PM · Wikimedia-Video, TimedMediaHandler
brion created T161433: VP9 video transcodes fail under Jessie-based MediaWiki-Vagrant.
Mar 26 2017, 1:36 AM · TimedMediaHandler-Transcode, MediaWiki-Vagrant

Mar 21 2017

Jonas awarded T27854: Expose image thumbs, embedded video players via oEmbed (API + discovery <link rel>) a Like token.
Mar 21 2017, 9:37 AM · Epic, MediaWiki-API

Mar 20 2017

brion added a comment to T151199: Please mass-reset the video transcodes of tens of thousand videos stuck in "Unknown" state.

I've started a job running requeueTranscodes.php commonswiki --video --missing --throttle which should clean them all up.

Mar 20 2017, 6:49 PM · Wikimedia-Site-requests, Wikimedia-maintenance-script-run, TimedMediaHandler-Transcode, TimedMediaHandler

Mar 17 2017

brion added a comment to T108234: Run a bot to add 240p webm/ogv, re-run 360p/480p ogv video transcodes.

Fill-in jobs for 160p and 240p ogv and webm appear to have completed a while ago. Will re-start the 360p and 480p re-runs after adding one more option to avoid accidentally re-running new transcodes unnecessarily.

Mar 17 2017, 9:20 PM · Patch-For-Review, Wikimedia-Video

Mar 15 2017

RandomDSdevel awarded T107595: [RFC] Multi-Content Revisions a Mountain of Wealth token.
Mar 15 2017, 6:42 PM · MediaWiki-Platform-Team, User-Daniel, Wikidata-Sprint, ArchCom-Has-shepherd, RfC, Wikidata-Sprint-2015-11-17, Wikidata-Sprint-2015-11-03, Wikidata-Sprint-2015-10-13, Wikidata-Sprint-2015-09-29, Wikimedia-Developer-Summit-2016, Wikidata, Wikidata-Sprint-2015-09-15, ArchCom-RfC

Mar 12 2017

MichaelSchoenitzer awarded T66214: Define an official thumb API a Love token.
Mar 12 2017, 2:41 PM · Reading Epics (Thumbnails), Services (next), ArchCom-Has-shepherd, RfC, Traffic, Operations, Services-next, ArchCom-RfC, Zero, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Reading-Admin, Commons, Performance-Team, Epic, RESTBase-API, Parsoid, Multimedia, MediaWiki-File-management

Mar 8 2017

brion added a comment to T153333: RFC: How should we store longer revision comments?.

Just confirming that we're looking at this, already planning to break out the comment field as part of the revision table updates. Need to look over the structured data implications for anything fancier than just supporting a larger length.

Mar 8 2017, 9:19 PM · ArchCom-RfC, Community-Tech
brion added a comment to T159982: Transcode failed with "Error while opening encoder for output stream".

The Ogg transcodes for the first file fail with a different error than is described -- something about truncating packets.

Mar 8 2017, 8:34 PM · TimedMediaHandler-Transcode

Mar 7 2017

brion added a comment to T90908: Goal: Binding code of conduct for all Wikimedia technical spaces with consequences for breaches.

@Nemo_bis, that implies the committee will now start bootstrapping itself. As I understand, once the committee is in place the CoC will be in effect.

Mar 7 2017, 10:20 PM · Goal, Human-Resources, Community-Liaisons, DevRel-January-2016, DevRel-December-2015, DevRel-November-2015, DevRel-October-2015, Wikimedia-Developer-Summit-2016, DevRel-September-2015, ECT-August-2015, Support-and-Safety, Developer-Relations, Wikimania-Hackathon-2015
brion created T159885: Support upload of MJPEG video in AVI or MOV container.
Mar 7 2017, 10:18 PM · Wikimedia-Video, TimedMediaHandler
brion added a comment to T90908: Goal: Binding code of conduct for all Wikimedia technical spaces with consequences for breaches.

I've removed the draft status.

Mar 7 2017, 7:12 PM · Goal, Human-Resources, Community-Liaisons, DevRel-January-2016, DevRel-December-2015, DevRel-November-2015, DevRel-October-2015, Wikimedia-Developer-Summit-2016, DevRel-September-2015, ECT-August-2015, Support-and-Safety, Developer-Relations, Wikimania-Hackathon-2015
brion added a comment to T64270: Support video and audio content.

9th @ 10am PST/8pm CEST works for me.

Mar 7 2017, 6:23 PM · Patch-For-Review, Parsoid

Feb 28 2017

brion created T159250: WebM video transcodes can have slightly off aspect ratio.
Feb 28 2017, 5:57 PM · TimedMediaHandler-Transcode

Feb 25 2017

brion closed T155085: Audio/video playback fails in MS Edge in Windows 10 Insider build 15002 as Resolved.

Confirmed resolved with current Win10 Insider build and currently deployed version of ogv.js.

Feb 25 2017, 8:19 PM · MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), Patch-For-Review, Upstream, Browser-Support-Microsoft-Edge, TimedMediaHandler-Player

Feb 24 2017

brion created T158989: Add img_sha256, related columns with SHA-256 hash of file.
Feb 24 2017, 7:16 PM · Schema-change, MediaWiki-File-management, Commons, Security-General, Multimedia, Technical-Debt
brion created T158988: Migrate filearchive's fa_storage_key from SHA-1 to SHA-256.
Feb 24 2017, 7:10 PM · Schema-change, MediaWiki-File-management, MediaWiki-Page-deletion, MediaWiki-Uploading, Commons, Security-General, Multimedia, Technical-Debt
brion added a parent task for T158903: Provide other checksums than MD5 and SHA-1 for dumps: T158986: Migrate SHA-1 hashes to SHA-256 (tracking).
Feb 24 2017, 6:56 PM · Dumps-Generation
brion added a subtask for T158986: Migrate SHA-1 hashes to SHA-256 (tracking): T158903: Provide other checksums than MD5 and SHA-1 for dumps.
Feb 24 2017, 6:56 PM · Security-General, Technical-Debt, MediaWiki-General-or-Unknown
brion created T158986: Migrate SHA-1 hashes to SHA-256 (tracking).
Feb 24 2017, 6:56 PM · Security-General, Technical-Debt, MediaWiki-General-or-Unknown

Feb 22 2017

brion added a comment to T115814: Talk with Internet Archive folks about simplifying video importing, IA-side WebM transcoding.

Current status as of yesterday's update call:

Feb 22 2017, 7:02 PM · Wikimedia-Video, Internet-Archive
brion closed T102096: TMH lacks obvious way to batch-encode new transcodes for old files as Resolved.

requeueTranscodes.php is in active use, does the job. Closing.

Feb 22 2017, 6:53 PM · MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T102096: TMH lacks obvious way to batch-encode new transcodes for old files, a subtask of T108234: Run a bot to add 240p webm/ogv, re-run 360p/480p ogv video transcodes, as Resolved.
Feb 22 2017, 6:53 PM · Patch-For-Review, Wikimedia-Video
brion reopened T115814: Talk with Internet Archive folks about simplifying video importing, IA-side WebM transcoding as "Open".

Whoops, updates this bug must have fallen through my mail filters. Work is ongoing on this.

Feb 22 2017, 6:51 PM · Wikimedia-Video, Internet-Archive

Feb 21 2017

brion created T158716: Split CPU cost of transcoding large video files more evenly (chunked video transcoding).
Feb 21 2017, 11:36 PM · TimedMediaHandler-Transcode
brion created T158617: npm install fails for changeprop service in MW-Vagrant jessie-migration.
Feb 21 2017, 4:33 AM · Services (watching), MediaWiki-Vagrant
brion closed T158615: Job runner service doesn't appear to work in jessie-migration as Resolved.

Now working with the patch merged.

Feb 21 2017, 3:52 AM · Patch-For-Review, MediaWiki-Vagrant
brion closed T158615: Job runner service doesn't appear to work in jessie-migration, a subtask of T136429: [EPIC] Migrate base image to Debian Jessie, as Resolved.
Feb 21 2017, 3:52 AM · Patch-For-Review, Operations, Release-Engineering-Team, Epic, MediaWiki-Vagrant
brion added a comment to T158615: Job runner service doesn't appear to work in jessie-migration.

Note there is no logs/mediawiki-runJobs.log file, and I cannot connect to port 80 on 127.0.0.1 from within the VM (testing curl http://127.0.0.1/w/RunJobs.php).

Feb 21 2017, 2:03 AM · Patch-For-Review, MediaWiki-Vagrant
brion created T158615: Job runner service doesn't appear to work in jessie-migration.
Feb 21 2017, 1:58 AM · Patch-For-Review, MediaWiki-Vagrant
brion created T158611: Vagrant role for TimedMediaHandler doesn't run composer after git clone.
Feb 21 2017, 1:12 AM · Patch-For-Review, Easy, MediaWiki-Vagrant
brion closed T158608: Vagrant 1.8.7 fails to fetch Jessie image with vague error message as Invalid.

Running with --debug seems to indicate that Vagrant's downloader is failing to load curl or some such junk:

Feb 21 2017, 12:51 AM · Operations, Release-Engineering-Team, Epic, MediaWiki-Vagrant
brion closed T158608: Vagrant 1.8.7 fails to fetch Jessie image with vague error message, a subtask of T136429: [EPIC] Migrate base image to Debian Jessie, as Invalid.
Feb 21 2017, 12:51 AM · Patch-For-Review, Operations, Release-Engineering-Team, Epic, MediaWiki-Vagrant
brion created T158608: Vagrant 1.8.7 fails to fetch Jessie image with vague error message.
Feb 21 2017, 12:09 AM · Operations, Release-Engineering-Team, Epic, MediaWiki-Vagrant

Feb 20 2017

brion added a comment to T158300: Embedded ogv files doesn't play in Phabricator on mobile.

Workaround: should work to download the file and play it in VLC for Android. Awkward, but that's file formats for ya. :)

Feb 20 2017, 9:14 PM · WMSE-Bug-Reporting-and-Translation-2017, Mobile, Phabricator
brion added a comment to T158300: Embedded ogv files doesn't play in Phabricator on mobile.

Chrome for Android doesn't support Ogg Theora video natively: http://caniuse.com/#search=ogv

Feb 20 2017, 7:22 PM · WMSE-Bug-Reporting-and-Translation-2017, Mobile, Phabricator
brion added a subtask for T152013: RenameLink gadget on Commons causes the page tabs to jump around after it loads: T158597: Provide server-side registration for Gadgets to add tabs to skin output without flash of content.
Feb 20 2017, 7:07 PM · Multimedia, MediaWiki-General-or-Unknown, Commons
brion added a parent task for T158597: Provide server-side registration for Gadgets to add tabs to skin output without flash of content: T152013: RenameLink gadget on Commons causes the page tabs to jump around after it loads.
Feb 20 2017, 7:07 PM · Gadgets