brion (Brion Vibber)
User

Projects (21)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:30 PM (205 w, 5 d)
Availability
Available
IRC Nick
brion
LDAP User
Brion VIBBER
MediaWiki User
Unknown

Recent Activity

Tue, Sep 18

brion added a comment to T187562: Use a better method for detecting STL files on the page.

@Esanders worst case, currently should be possible to override the ThreeDHandler's doTransform method to return a custom ThumbnailImage subclass, which can add a class by sniping into the toHtml() method and appending to the img-class entry in options.

Tue, Sep 18, 6:32 PM · Performance, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Multimedia, 3D
brion added a comment to T187562: Use a better method for detecting STL files on the page.

Not a blocker, but it'd be nice to treat various media types consistently in that respect. Ought to be able to add a custom class on the <img> in some reasonable way already, though...

Tue, Sep 18, 6:25 PM · Performance, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Multimedia, 3D

Fri, Sep 14

brion moved T68398: Links in TimedText when doing a Pop up video wrong colour (CSS gets overriden) from TimedText to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:23 PM · TimedMediaHandler-TimedText, TimedMediaHandler
brion merged task T113330: Refactor long-running transcode jobs to (PHP-based) microservice into T105951: Create video/audio transcode service to replace shell-outs to avconv/ffmpeg2theora.
Fri, Sep 14, 9:21 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion merged T113330: Refactor long-running transcode jobs to (PHP-based) microservice into T105951: Create video/audio transcode service to replace shell-outs to avconv/ffmpeg2theora.
Fri, Sep 14, 9:21 PM · TimedMediaHandler-Transcode, TimedMediaHandler
brion added a comment to T199129: Consider a slimmer HTML representation for videos.

Once we're able to move to MPEG-DASH streaming we could have one or two progressive-download sources at a reasonable default resolution, plus the MPEG-DASH manifest listed as first source. We might be able to shove the timed text track references into the .mpd manifest too, though that would mean they don't work with JavaScript disabled.

Fri, Sep 14, 9:18 PM · Performance, Technical-Debt, TimedMediaHandler, Parsing-Team
brion moved T200145: Text on multiple lines is not shown for video subtitles from Backlog to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:15 PM · Regression, TimedMediaHandler-TimedText, TimedMediaHandler
brion moved T55926: TMH: <br> tags (line breaks) are not used in interface message from Backlog to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:14 PM · TimedMediaHandler
brion moved T137630: "EmbedPlayer.NativeControls" option is broken from Backlog to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:10 PM · TimedMediaHandler-Player, TimedMediaHandler
brion moved T149096: Audio closed captioning menu displayed poorly; only half of the first entry displayed from Backlog to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:10 PM · TimedMediaHandler-Player, TimedMediaHandler
brion moved T151641: Don't use underscores in the title bar of popup window for videos from Backlog to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:10 PM · TimedMediaHandler-Player, TimedMediaHandler
brion moved T169476: Video player error on Mac/Safari due to incorrect subtitles from Backlog to Player-Old on the TimedMediaHandler board.
Fri, Sep 14, 9:10 PM · TimedMediaHandler

Mon, Sep 10

brion added a comment to T203994: Link to a video file page with a specified start time.

Note that this should be made possible for both regular File: page view and the iframe-embedded view.

Mon, Sep 10, 7:49 PM · TimedMediaHandler

Sat, Sep 8

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Feedback question -- is the method name mapping from 'somethingWorker' to 'something' too clever? Should it just let you pass any method name to $controller->queue()?

Sat, Sep 8, 3:22 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion updated the task description for T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Sat, Sep 8, 3:06 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

(Still have to see if the exec mode can be got working, do a little debugging, and add a hook for closing extensions.)

Sat, Sep 8, 2:33 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Updated summary with the reworked API for ParallelMaintenance.

Sat, Sep 8, 2:15 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion updated the task description for T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Sat, Sep 8, 2:15 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Fri, Sep 7

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

using regular execute() method, with a helper fork() method (bikeshed that name!) that creates the controller, a dispatch callback, and the work/result callbacks

Fri, Sep 7, 10:17 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

I'm retooling the proposal based on feedback. Key things:

Fri, Sep 7, 10:13 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Wed, Sep 5

brion added a comment to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.

Note via Timo -- currently we run maint scripts in production through hhvm, which sets processor affinity on all child processors. :P

Wed, Sep 5, 8:26 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T101716: Support MJPEG & PCM audio as last-ditch fallback output for iOS.

Hadn't thought of trying h.263; testing... I've put up some samples at https://brionv.com/misc/pumpjack/

Wed, Sep 5, 3:44 PM · Patch-For-Review, TimedMediaHandler, Multimedia

Fri, Aug 31

brion added a comment to T203289: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment.

Seems to be a change in how plugins are loaded in 2.1.3/2.1.4. Yay semver!

Fri, Aug 31, 10:46 PM · MediaWiki-Vagrant
brion created T203289: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment.
Fri, Aug 31, 10:41 PM · MediaWiki-Vagrant

Mon, Aug 27

brion added a comment to T115692: Flash of unstyled content (FOUC) on Login page and Preferences (and possibly other highly visible pages?).

Taking a quick peek at this per an inquiry from @saper. Specifically looking at the login page...

Mon, Aug 27, 11:04 PM · MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)), MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)), Performance, MediaWiki-Special-pages

Aug 21 2018

brion renamed T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts from ParallelMaintenance helper class for multi-process maintenance scripts to RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Aug 21 2018, 2:47 AM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Aug 20 2018

brion closed T131515: extension.json is poorly documented as Resolved.

I'm pretty happy with the current documentation now; last time I needed to use it I found what I needed. :) Closing.

Aug 20 2018, 8:59 PM · Documentation, MediaWiki-Documentation
brion added a project to T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts: TechCom-RFC.

Adding to techcom-rfc board to make sure we don't forget to discuss this, if cross-cutting issues are forseen.

Aug 20 2018, 8:50 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion updated the task description for T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Aug 20 2018, 8:49 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Should we leave open for the community to delete?

Aug 20 2018, 7:12 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Existing files should be either deleted or re-encoded.

Aug 20 2018, 7:01 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Fix has been deployed; no more MP4 files should be coming in.

Aug 20 2018, 6:58 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion closed T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed" as Invalid.

AAAAAGGGGHHHH the VM has the clock wrong and thinks the cert is not yet valid. Nevermind.

Aug 20 2018, 5:48 PM · MediaWiki-Vagrant
brion added a comment to T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed".

(I think that missing file is ok cause the dir is full of other files...?)

Aug 20 2018, 5:40 PM · MediaWiki-Vagrant
brion added a comment to T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed".

The /usr/lib/ssl/cert.pem file specified in config seems to be missing?

Aug 20 2018, 5:26 PM · MediaWiki-Vagrant
brion created T202309: Composer SSL errors in MediaWiki-Vagrant: "error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed".
Aug 20 2018, 5:10 PM · MediaWiki-Vagrant
brion created T202308: PHPUnit test case warning about Special:Notifications missing aliases in SkinMinervaTest.
Aug 20 2018, 5:05 PM · Readers-Web-Backlog, Google-Code-in-2018, Need-volunteer, MinervaNeue
brion added a comment to T95899: MediaWiki core PHPUnit tests do not pass on MediaWiki-Vagrant.

PHP 5 is obsolete; use PHP 7.

Aug 20 2018, 4:43 PM · Wikidata, MediaWiki-Core-Tests, MediaWiki-Vagrant

Aug 19 2018

brion claimed T202208: Mp4 on Commons - since when did we allow it.
Aug 19 2018, 9:55 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video
brion added a comment to T202208: Mp4 on Commons - since when did we allow it.

Yep, that's a regression in the extension.json migration. The addition of file types to $wgFileExtensions was being done twice, both in the extension.json and then again dynamically, causing the way that 'mp4' was removed from the list to fail because it only removed one instance of it.

Aug 19 2018, 9:55 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Commons, TimedMediaHandler, Wikimedia-Video

Aug 14 2018

brion created T201970: RfC: ParallelMaintenance helper class for multi-process maintenance scripts.
Aug 14 2018, 10:58 PM · TechCom-RFC, Patch-For-Review, MediaWiki-Maintenance-scripts

Aug 13 2018

Imarlier awarded T66214: Define an official thumb API a Baby Tequila token.
Aug 13 2018, 5:46 PM · Reading-Infrastructure-Team-Backlog, Services (watching), Reading Epics (Thumbnails), Traffic, Operations, TechCom-RFC, Zero, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Reading-Admin, Commons, Epic, Parsoid, Multimedia, MediaWiki-File-management
brion moved T201843: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled from Backlog to Kaltura/MwEmbed on the TimedMediaHandler-Player board.
Aug 13 2018, 3:58 PM · TimedMediaHandler-Player, Technical-Debt
brion edited projects for T201843: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled, added: TimedMediaHandler-Player; removed TimedMediaHandler.
Aug 13 2018, 3:58 PM · TimedMediaHandler-Player, Technical-Debt
brion added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

As for role ids -- perhaps we should primarily use the names, not the numbers, in the <role> bit. It's analogous to a page's <title> reference (a primary identifier) not to its <ns> or <id> (which are provided informatively if you want to repro the database exactly, but can be freely discarded when doing imports and such).

Aug 13 2018, 9:05 AM · Dumps-Generation, User-ArielGlenn, User-Daniel, TechCom-RFC, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
brion added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

Ok, proposed transitional schema looks like it imports cleanly via importDump (which uses same code path as Special:Import). The proposed final schema, however, imports a revision with empty text (and throws a notice on Undefined index: text in /vagrant/mediawiki/includes/import/WikiImporter.php on line 886).

Aug 13 2018, 9:00 AM · Dumps-Generation, User-ArielGlenn, User-Daniel, TechCom-RFC, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
brion added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

My concern with the two-step transition idea is that some consumers may not update on a reliable schedule, or may not be able to do so easily. For instance, if people are using Special:Export on one wiki and Special:Import'ing those pages on another that's *not* a Wikimedia-hosted site, it's more likely to be an older version of MediaWiki.

Aug 13 2018, 8:46 AM · Dumps-Generation, User-ArielGlenn, User-Daniel, TechCom-RFC, Multi-Content-Revisions, Structured-Data-Commons, Wikidata

Aug 8 2018

brion created T201561: Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line.
Aug 8 2018, 9:25 PM · VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor

Aug 7 2018

brion closed T201433: Video thumbnail and video wont play as Resolved.

I remuxed the file with ffmpeg, and reuploaded the new file and it's happier. Looks like the cues didn't get written properly by the original conversion program.

Aug 7 2018, 8:21 PM · TimedMediaHandler-Transcode
brion added a comment to T201433: Video thumbnail and video wont play.

EBML parser thinks the file is incomplete; got cropped shortly before 128MB

Aug 7 2018, 5:27 PM · TimedMediaHandler-Transcode
brion added a project to T201433: Video thumbnail and video wont play: TimedMediaHandler-Transcode.
Aug 7 2018, 4:21 PM · TimedMediaHandler-Transcode
brion added a comment to T201433: Video thumbnail and video wont play.

file is File:GreenlandReel_Icebergs_2160APR.webm

Aug 7 2018, 4:20 PM · TimedMediaHandler-Transcode

Aug 6 2018

brion added a comment to T201358: Increase job runners on video scalers to maximize load efficiency.

Hmm, that load factor moved. I have no idea what to change now. :D

Aug 6 2018, 7:53 PM · Operations, TimedMediaHandler-Transcode
brion created T201358: Increase job runners on video scalers to maximize load efficiency.
Aug 6 2018, 7:52 PM · Operations, TimedMediaHandler-Transcode
brion created T201351: Epic: use multiple CPU cores in XML import (Special:Import, importDump.php).
Aug 6 2018, 7:16 PM · Performance, MediaWiki-Export-or-Import

Aug 4 2018

brion added a comment to T106482: Transcodes of Ogg Theora videos don't respect picture crop (libav/ffmpeg upstream?).

Yep, same cropping with the new VP9 transcodes (ffmpeg 3.2 I think)

Aug 4 2018, 12:08 AM · TimedMediaHandler-Transcode, TimedMediaHandler, Wikimedia-Video

Aug 3 2018

brion added a comment to T106482: Transcodes of Ogg Theora videos don't respect picture crop (libav/ffmpeg upstream?).

ffmpeg's behavior seems to have updated a bit; it's not perfect but may be "good enough".

Aug 3 2018, 11:51 PM · TimedMediaHandler-Transcode, TimedMediaHandler, Wikimedia-Video
brion added a comment to T200939: Intermittent transcode error "Invalid frame size: 0x0.".

Note this appears to predate the current VP9 stuff, and appears on some VP8 transcodes too.

Aug 3 2018, 11:40 PM · TimedMediaHandler-Transcode
brion added a comment to T201191: Opening PDF file pages on Android Chrome browser, results in an attempt to download, instead of viewing the page.

Seems like if it's doing this regularly to our pages, that it's a browser compatibility issue that we'd want to address in some way?

Aug 3 2018, 11:37 PM · Browser-Support-Android-Google-Chrome, MediaWiki-General-or-Unknown
brion created T201127: Some video transcodes, many audio transcodes have recorded "0" for bitrate.
Aug 3 2018, 4:27 AM · TimedMediaHandler-Transcode

Aug 2 2018

brion created T201091: requeueTranscodes.php --error option incorrectly applies to unqueued files.
Aug 2 2018, 8:21 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, TimedMediaHandler-Transcode
brion created T201090: Intermittent transcode failure 'An unknown error occurred in storage backend "local-swift-codfw".'.
Aug 2 2018, 8:19 PM · TimedMediaHandler-Transcode

Aug 1 2018

brion added a comment to T200747: Batch-convert old video files for new VP9/opus format.

Another intermittent error I see is "invalid frame size: 0x0" T200939. Doesn't seem VP9-specific but I hadn't noticed it until recently.

Aug 1 2018, 8:24 PM · TimedMediaHandler-Transcode
brion created T200939: Intermittent transcode error "Invalid frame size: 0x0.".
Aug 1 2018, 8:23 PM · TimedMediaHandler-Transcode
brion added a comment to T200747: Batch-convert old video files for new VP9/opus format.

(Restarted the batch job a while ago.)

Aug 1 2018, 11:41 AM · TimedMediaHandler-Transcode
brion added a comment to T200873: vp9 transcode failures with signal 15.

(Re-running the errored ones...)

Aug 1 2018, 11:40 AM · TimedMediaHandler-Transcode
brion added a comment to T200873: vp9 transcode failures with signal 15.

Per joe in irc this is probably from hhvm config restarts, in which case just re-queuing the failed ones should patch em up. Just need to expect more will come and run follow-ups. (Todo: improve retry logic!)

Aug 1 2018, 6:20 AM · TimedMediaHandler-Transcode
brion created T200874: Add job queue runner hostname to transcode error details.
Aug 1 2018, 6:18 AM · TimedMediaHandler-Transcode
brion added a comment to T200873: vp9 transcode failures with signal 15.

Errors continuing. Stopping the batch job.

Aug 1 2018, 6:13 AM · TimedMediaHandler-Transcode
brion added a comment to T200747: Batch-convert old video files for new VP9/opus format.

Encountered a spike in errors, details at T200873. Stopping the batch job for now.

Aug 1 2018, 6:12 AM · TimedMediaHandler-Transcode
brion added a comment to T200873: vp9 transcode failures with signal 15.

Can confirm they were all around the same time:

Aug 1 2018, 6:05 AM · TimedMediaHandler-Transcode
brion added a comment to T200873: vp9 transcode failures with signal 15.

Unfortunately the error logs in transcode table don't include the hostname yet.

Aug 1 2018, 6:02 AM · TimedMediaHandler-Transcode
brion created T200873: vp9 transcode failures with signal 15.
Aug 1 2018, 6:00 AM · TimedMediaHandler-Transcode
brion added a comment to T200747: Batch-convert old video files for new VP9/opus format.

This has been resolved (caused by T200813, worked around). Batch is running. Load is moderate on servers, we might be able to tune them to run more runners.

Aug 1 2018, 2:05 AM · TimedMediaHandler-Transcode
brion created T200866: Timeout and HTTP 500 error on 5000px thumbnail of large SVG image.
Aug 1 2018, 2:03 AM · Thumbor

Jul 31 2018

brion created T200851: Transcode updates aren't purging anon caches of file pages in production.
Jul 31 2018, 9:21 PM · TimedMediaHandler-Transcode
brion created T200813: JobQueueGroup::singleton()->getQueueSizes() returns 0 for all queues in production.
Jul 31 2018, 4:06 PM · Patch-For-Review, TimedMediaHandler-Transcode, MediaWiki-JobQueue
brion added a comment to T200747: Batch-convert old video files for new VP9/opus format.

Something seems wrong with the throttle option; it's not pausing when the queue size goes up. I'll investigate.

Jul 31 2018, 3:59 PM · TimedMediaHandler-Transcode
TheDJ awarded T111909: Enable vp9 by default a Love token.
Jul 31 2018, 8:36 AM · TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T190334: Add option to TMH's VP9 transcoding to use -row-mt option as Resolved.

This got merged and deployed.

Jul 31 2018, 12:58 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, TimedMediaHandler-Transcode
brion claimed T111909: Enable vp9 by default.

Since this is supported now, I think we're good to do this soon. :D (And WMF config is switched to vp9 now)

Jul 31 2018, 12:57 AM · TimedMediaHandler-Transcode, TimedMediaHandler
brion closed T63805: Create WebM (VP9/opus) transcodes replacing the WebM (VP8/vorbis) ones eventually as Resolved.

VP9 configuration has been switched in. T200747 covers batch process for re-running new transcodes.

Jul 31 2018, 12:56 AM · TimedMediaHandler-Transcode, WMF-deploy-2015-08-18_(1.26wmf19), Patch-For-Review, TimedMediaHandler
brion closed T63805: Create WebM (VP9/opus) transcodes replacing the WebM (VP8/vorbis) ones eventually, a subtask of T188075: eqiad/codfw: (4)+(4) hardware access request for videoscalers, as Resolved.
Jul 31 2018, 12:56 AM · hardware-requests, Operations
brion created T200747: Batch-convert old video files for new VP9/opus format.
Jul 31 2018, 12:56 AM · TimedMediaHandler-Transcode

Jul 28 2018

Kaartic awarded T34284: Update Echo Notifications in real time without page reloads a Love token.
Jul 28 2018, 6:58 PM · Growth-Team, Collaboration-Team-Triage, Notifications

Jul 26 2018

brion added a comment to T118080: Rewrite $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet settings as a map from transcode to boolean for enabled status.

Going ahead with this, as it simplifies overrides of the default config (based on my testing of our planned config for VP9 transition).

Jul 26 2018, 10:18 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Technical-Debt, TimedMediaHandler

Jul 10 2018

Krinkle awarded T190334: Add option to TMH's VP9 transcoding to use -row-mt option a Orange Medal token.
Jul 10 2018, 7:40 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, TimedMediaHandler-Transcode

Jun 29 2018

brion closed T198502: Can't reach eqiad or esams from Comcast in Portland, Oregon as Resolved.

Seems to have cleared up for me too now. Marking resolved. \o/

Jun 29 2018, 6:10 PM · Operations, Traffic, netops
brion added a comment to T198502: Can't reach eqiad or esams from Comcast in Portland, Oregon.

Now getting

Jun 29 2018, 5:23 PM · Operations, Traffic, netops
brion added a comment to T198502: Can't reach eqiad or esams from Comcast in Portland, Oregon.

and in ipv4:

Jun 29 2018, 5:11 PM · Operations, Traffic, netops
brion added a comment to T198502: Can't reach eqiad or esams from Comcast in Portland, Oregon.
$ sudo mtr bast1002.wikimedia.org -z  --report-wide
Password:
Start: 2018-06-29T10:07:32-0700
HOST: Orac.local                                             Loss%   Snt   Last   Avg  Best  Wrst StDev
  1. AS7922   2601:1c0:5201:b82:2cab:a4ff:fe47:1245           0.0%    10    5.9   5.9   3.5  13.5   2.9
  2. AS7922   2001:558:4060:26::1                             0.0%    10   13.8  21.0  13.4  55.8  12.5
  3. AS7922   ae-225-rur02.beaverton.or.bverton.comcast.net   0.0%    10   17.0  16.1  12.9  27.2   4.2
  4. AS7922   ae-51-ar01.troutdale.or.bverton.comcast.net     0.0%    10   17.6  17.4  14.0  19.5   2.0
  5. AS7922   be-33490-cr01.seattle.wa.ibone.comcast.net     10.0%    10   21.4  23.9  20.1  29.1   3.4
  6. AS7922   be-10846-pe01.seattle.wa.ibone.comcast.net      0.0%    10   27.0  22.8  18.1  28.7   3.5
  7. AS7922   2001:559::536                                   0.0%    10   17.1  22.9  16.8  45.4   9.2
  8. AS???    ???                                            100.0    10    0.0   0.0   0.0   0.0   0.0
Jun 29 2018, 5:09 PM · Operations, Traffic, netops
brion created T198502: Can't reach eqiad or esams from Comcast in Portland, Oregon.
Jun 29 2018, 4:58 PM · Operations, Traffic, netops

Jun 27 2018

brion added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

Ah, I figured it out. It was only triggering when editing was started from the article view (in which case TMH was already loaded), whereas in most of my testing I was reloading at the action=edit page, with no TMH loaded. I can now reliably trigger it. :D

Jun 27 2018, 12:43 AM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor

Jun 26 2018

brion added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

I'm having trouble reproducing this in an isolated environment.

Jun 26 2018, 11:52 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor
brion created T198266: TMH video player frontend fails to initialize on Parsoid HTML format (mwembed).
Jun 26 2018, 10:03 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), TimedMediaHandler-Player
brion added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

Yeah, looks like the old-style mwembed player in TMH is getting confused about the parsoid-style markup and is ending up with a zero-size widget. Do y'all prefer that I try to fix the frontend to work with that markup, or leave it to to changing which markup is used (T154844)?

Jun 26 2018, 9:23 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor
brion added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

Gotcha -- yes, can reproduce the bug in Chrome and Safari. Thanks for filing the side bug. :)

Jun 26 2018, 9:18 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor
brion added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

(I do see that the thumbnail changes on the example taken from the referenced article; it looks like the 'thumbtime' parameter is not being passed through when the thumbnail is reloaded, so it gets the default time.)

Jun 26 2018, 8:30 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor
brion added a comment to T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video .

In Chrome I'm not experiencing disappearing thumbnails or unusual size on https://en.wikipedia.org/wiki/User:Brion_Vibber_(WMF)/Video_VE_test when testing either of:

  • changing size of video through 'edit' / advanced
  • changing size of video by dragging the corner
  • inserting a new video
Jun 26 2018, 7:26 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor
brion edited projects for T198103: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video , added: TimedMediaHandler-Player; removed TimedMediaHandler.
Jun 26 2018, 7:17 PM · User-Ryasmeen, VisualEditor-MediaWiki, TimedMediaHandler-Player, VisualEditor