Thu, May 28
Looks good to me! Much easier than the former names!
Tue, May 26
Looking great! Big thanks to all who helped out on this ticket!
@ABorbaWMF sorry! Yes, this was updated but I forgot to update the designs on the ticket. Thanks for checking!
Fri, May 15
@bearND looks good!
Thu, May 14
Tue, May 12
@bearND thanks so much! This looks great. It looks like even on web we maintain the active color for the external link icon even when the link color is visited.
Hi @bearND sorry to be so late with this response! On web we style the External link icon as the same color as the active link color, could we do the same here? (see the info box for this article as an example: https://en.wikipedia.org/wiki/Wikipedia)
|Japanese dark mode|
Hi @Volker_E let me know what you think!
Mon, May 11
Fri, May 8
Thu, May 7
Just dropping a note in to say that the current behavior while not idea is certainly work-able for now. @JMinor should I create a new ticket for what an updated behavior might be in the future to be logged in the backlog?
Looking good! Thanks @bearND!
This is looking good so far!
Overall this is lookin good! Just moving this back to ready for dev as it appears to be showing more frequently than expected.
Thanks for this great work @Dmantena! Looking good!
Tue, May 5
Thanks @bearND sorry for the confusion!
Hi @bearND it's from a different repository but should be the same, sorry! Feel free to use the one from https://design.wikimedia.org/style-guide/resources/WikimediaUI-icons-SVGs.zip
There needs to be a few second transition between publishing an edit and viewing the article. It could be a delay, a transitional screen or something else
Mon, May 4
@bearND on the WMFLabs link I'm seeing the link color as #C8CCD1?
@bearND thanks for this ticket, just updated with an SVG of the external link icon
Fri, May 1
Apr 15 2020
LGTM, thanks @Tsevener !
Yes! That'd be great, thanks!
Apr 14 2020
@MattCleinman if this is about the preview off of the editing flow then it looks good to me padding0wise, but it's a bit confusing to show the edit pencil in the preview at the section header (appearing for me on the Intro paragraphs of articles after making a one character edit)
@MattCleinman hmm I'm wondering now how I got so confused...When I wrote in the note about padding I thought this ticket was about the hard press preview of articles from blue links within the article, but now I get a strong sense that this isn't what this ticket is about!
Apr 13 2020
I'm curious how we are currently handling this with section headers and potential trailing edit pencils?
Apr 10 2020
Apr 9 2020
I wonder if we might want to say something like "Help improve Wikipedia by taking a quick survey about this article" (just to appeal to folks as to how they'll be helping us by taking the survey).
Apr 7 2020
@schoenbaechler just wanted to double check with you that we want to shorten the line from the right side on (LTR langs) as this is not what we had agreed to in the initial spec: https://phabricator.wikimedia.org/T226094
Thanks for pulling this all together. I just met with @schoenbaechler and we've agreed that the pencil should appear by the first section text. Although this will be a change for Android, we're hoping that it will help to simplify the header area which can currently have a variety of different CTAs based on contribution type (on Android) and will soon feature some new experiments on iOS.
Apr 1 2020
Sorry! I didn't move this on purpose!
Thanks @bearND, sorry I must have remembered the weight wrong, but 500 looks good! Thank you!
Mar 31 2020
Possible sources to explore:
- OCLC (aka WorldCat) has many of the external data needs available for books.
- ArXiv might be helpful for academic articles
- Open Library / Internet Archive
Mar 30 2020
@bearND I'm sorry for the delay. It would be great to remove the list of languages for the article from the footer as it is available from the toolbar. Thank you!
Mar 27 2020
@JoeWalsh actually didn't even need to clear the cache, just trying it again today worked
@JoeWalsh sorry! Working now for me! Thanks!
@JoeWalsh this is looking really good! Thank you!
One small note, would it be possible to use a stronger (bolder) text weight on the reference links in the reference list. I believe @MattCleinman used a weight of 400 to approximate SF medium in the updated title description CTA.
Thanks @MattCleinman, while it would be great to update these strings I'm worried about needing new strings from TranslateWiki, so let's stick with what we currently have in the app. My apologies for messy work!
Mar 26 2020
Unfortunately not working on 1733 for me.
Mar 25 2020
Mar 24 2020
A suggestion from @schoenbaechler is to remove the short horizontal line when there is a page issue but no disambiguation
Mar 23 2020
Mar 20 2020
My 2 cents is that it would be great to shorten to copy if possible (I believe this is what we did with the fundraising text this past winter?).
Mar 19 2020
I'm still seeing the old behavior on 6.6.0 (1729)
@JoeWalsh, yes, sorry just 2px L/R padding to the page content within the card. Thanks!
Hi @MattCleinman, sorry the SVGs weren't available on Zeplin, I've uploaded them here.
Mar 17 2020
From talking with @schoenbaechler today here are some potential ideas and noted issues: