Moved into blocked or waiting as I will be reviewing these v1 designs tomorrow at design review

Needed: Error state when there is no internal link

Action items:

• Open from toolbar
• Consider what the 'defaults' should be
• Utilizing the CC0 structured caption

In T213979#5086402, @JMinor wrote:

• Need more flow clarity around label vs link (does link insert include the | and if so when/how to edit vs actual link/url).

I can write out some flows next week, but the initial idea I had was that if you highlight text but use a link that has text that is different from the highlighted text then a label is applied.
Example
I highlight the word canine but I select the link for dog then the wikitext would be [canine | dog]

@JMinor could we still show a web view for these?

Not a problem! Once I have a few more tickets settled on the newest iOS release I'll jump on this and start sharing some early drafts.
For a time estimate, I will start working on this most likely late next week.

Thanks for the update, @JoeWalsh!

@Tsevener, this is working well for me! Thanks so much for the update!

Woo! This is awesome, thanks @NHarateh_WMF!

@NHarateh_WMF, this is looking great! Thanks!

It’d be great to mark both single and replace all instances! Thanks @NHarateh_WMF

@NHarateh_WMF yep! It’d be great to lose the highlight now that we have the selection

Created or linked to existing subtickets for suggested updates

Looking so gooooooood! Thank you @NHarateh_WMF

@Mhurd working and looking good to me! Thank you!

Looking good to me now, thanks @Mhurd and @JoeWalsh!

Also good catch at @ABorbaWMF! Thank you!

@NHarateh_WMF I think we've now fixed the 'greyness' issue with the dark modes by not using a transparency for the pluses and removing the shadows while you worked on the animations. Just going to leave this ticket in 'needs design' until the animation / illustration updates hit the app.

@Mhurd, woo! This is looking good! Thanks for working on this!
Just one small thing, would it be possible to have the 'Clear formatting' option appear in the 'Text formatting' sub menu? (https://zpl.io/VD4jPpg)

Ah @Tsevener, perhaps for now then it'd just be best to keep things case insensitive and then in the future we could potentially have a way to denote if the find and replace will affect case?

@Tsevener Sounds like a good idea to disable if find and replace match exactly, we could keep them enabled for case differences though

I'm on 12.1.4 as well running 1593

@Volker_E oof, yeah having it be smaller than the other trash icon would be bad :(

@Volker_E, dropping in to +1 restore vs. un-trash

@chelsyx I'll pull together some flows for our meeting tomorrow!

Ah! Sorry @NHarateh_WMF! I exported each part of the illustration as a separate file for the last on boarding screens, but didn't do so for the MVP you initially implemented. I can do that for these a little later today

Awesome, thanks for the update @NHarateh_WMF !

Perfect! Thanks for fixing this, @NHarateh_WMF!

Working well for me, thanks @NHarateh_WMF!

Awesome, @Mhurd! Just played around with it on the new build

Testing scripts are written. Ready to send out whenever we've got our Beta!

Looks great! Thanks @Tsevener!

Working for me!

I'm still seeing it as grey on my iPhone X but not on my iPhone 8, I am sort of willing to admit at this point that my phone is haunted in some way so I'm going to move this over to Needs QA to see if it's repro-able on anything but my iPhone X

Thanks so much @NHarateh_WMF, looking good even on large sizes in German!

Working for me! Thanks @Tsevener!

Thanks for the update @NHarateh_WMF!

Woah! It's so speedy now! Thanks @JoeWalsh!

Hi @NHarateh_WMF! Sorry it took a while for me to figure out how to retain the bounds but here are the PDFs! Thanks for your patience.

Woot! Thanks @Monte Hurd <mhurd@wikimedia.org> :)

@NHarateh_WMF makes sense! I'll work on that now!

@JoeWalsh I can't repro this again so I'm going to move it over to needs QA.

@Mhurd this is working really well so far! YAY! But on the current beta build I'm not seeing any instances where the non-editable alert is showing (eg. over templates, across sections, very long strings or the title). If I forgot something that we made a different decision on would you mind reminding me what we had decided instead? I do think that at the very least on Titles and across sections it'd be helpful to show the alert instead of bringing them to the editor OR we could bring them to the editor but also show an alert of some kind explaining why the behavior is different than expected.