Wed, Jun 19
Tue, Jun 18
Thanks @Tsevener for all of the amazing work on this! I'm so excited for this feature!
I know things are still in progress, but I had some design tweaks and feedback. Let me know if you want any of these broken out into its own ticket.
Mon, Jun 17
Moving this over to Needs QA for testing
@Tsevener this is looking good!
Just one quick bug that I found:
Looks good! Thanks @NHarateh_WMF!
Looking great! Thanks for the updates and awesome work @NHarateh_WMF!
Thu, Jun 13
@JMinor these are looking good, Blanca has everything uploaded nicely in folders on Drive here: https://drive.google.com/drive/folders/1j9biIKJ730yzmKglRryslkesCt7amemB do we still want them in Phabricator too? Happy to do so just wanted to double check.
Seconding a vote for on.
Mon, Jun 10
Hi @Jseddon! Sorry for the late response, I've been on vacation for the past two weeks.
So glad to hear that you like the icons so far. I'd be happy to put together an icon for Requests for comment / feedback some time this week.
May 24 2019
@NHarateh_WMF thanks for the updates! Both of these changes are working well, but the 'clear line' indicator appears to be floating above the midline (x hight) of the text. Any way we could make it centered with the text vertically?
Thanks for the update and all of the amazing work on this feature @NHarateh_WMF !
Question: do we want to include more information around time stamps and chronology for users? This would be expanding beyond the Talk designs from mobile web? My instinct is to keep this as is for now, and to wait for broader updates to Talk pages before making changes, but I'm happy to work on designs around this if it feels like something we would like to do.
May 22 2019
Hi @NHarateh_WMF, one more finding from usability testing.
May 21 2019
Hi @Tsevener! Thanks for all of the amazing work so far on User Talk, this is so exciting!
So far here are a few tweaks and updates I've collected for this ongoing work:
Yes, changing these to say 'discussion' would be great, sorry, I should have done that in the mocks 😅
May 20 2019
@Tsevener When you get a chance would you mind looking these over? For the banners I'm hoping that we can just use the system alerts we use elsewhere when we are passing down info from the server or there's a connection issue. I'm not sure I fully understood each of the scenarios, so if something looks fishy, let me know and I'll update it! Thanks for your patience with this!
@NHarateh_WMF thanks for working on this! It's looking great! I have just two small tweaks:
@NHarateh_WMF this is looking really good! Thank you for the updates!
May 16 2019
@NHarateh_WMF I'm on the latest beta unfortunately and I just lose the cursor completely :(
@NHarateh_WMF Woot this is looks really great so far! Thank you!
Looking good! Thanks @NHarateh_WMF!
@NHarateh_WMF unfortunately whenever I tap on the insert media icon on 6.3.0 (1620) the app crashes :(
Looking great! Thanks Natalia!
May 14 2019
@NHarateh_WMF Ah! Yes, if you could remove them from the input views too that would be great!
Sorry! I should have linked to Zeplin: https://app.zeplin.io/project/57a120ce9787dcf26230651f/dashboard?seid=5c367a1180fc3e29bdfba1d0
@JoeWalsh Good eye, sorry the header (nav bar) should not be included (this was my mistake), but the editing toolbar should be updated so that there is enough depth without the shadow. Thank you!
May 10 2019
May 8 2019
@JoeWalsh that works for me!
May 7 2019
Here are some potential updates for the blog icon:
@spatton, a more 'news-y' direction sounds great. I'll update later this week.
May 6 2019
@Mhurd except for tables, how hard would it be to support superscript and subscript tags as well as code blocks?
I think if it's easy to do, these would all be great to have but for me they're not top priority.
May 3 2019
Added mocks for users who have multiple wikis
@JoeWalsh + @JMinor
In light of above, do we want to continue down the road of supporting signature formatting preferences? Or would it be better just support the auto sign toggle and not mess with setting specific preferences for signatures on different language Wikis?
May 2 2019
Per our sync meeting, when the user taps on 'View in Safari' we'll probably want to show them the 'View as Wikipage' view rather than the 'mobile web default user talk' view. Additionally as @Tsevener pointed out, we'll want to refresh the page after they return back to Talk in the app, just in case they made a change while in Safari
@JoeWalsh, thanks for pointing these out. You have a much better memory than me!
May 1 2019
Ah! Thanks for pointing this out @NHarateh_WMF ! Bummer, let's leave them as they are then and maybe just add 1pt of Left and Right padding to the inside of the preview element.
@NHarateh_WMF squee! This is looking so awesome! Just a few small tweaks.
Zip available in #iOS
@jmatazzoni technically you could use #D43D33 but this would drop the ratio down to 4.51 and we'd be introducing a new color rather than re-using a color from the apps.
@jmatazzoni unfortunately a lot of the colors end up needing to be bright when placed on a black background in order to achieve a minimum of AA WCAG compliance. The color you've used int he mock ups above (#BA504F) doesn't have a high enough contrast ratio on true black (#000)
@NHarateh_WMF this is looking great! Thank you so much!
@NHarateh_WMF woot! This is looking really good, it's still a little jumpy when you have tapped into the search bar and then scroll up before scrolling down. I don't think this is a huge blocker though. If getting this transition to be smoother is going to be expensive I think we can skip it.
Working well and looking good for me, but I haven't tested the 5am case.
I did once see the article flash before the splash screen, but I can't repro this.