Page MenuHomePhabricator

coldchrist (Mike Christie)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 30 2014, 7:17 PM (493 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Mike Christie [ Global Accounts ]

Recent Activity

Mar 9 2024

coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

The bot is now running under the toolforge command suggested at the VPT thread. I'll work on some other clean up issues such as using the env vars. dcaro, do you see any remaining issues that would prevent this from running once the grid shuts down next week?

Mar 9 2024, 5:32 PM · Grid-Engine-to-K8s-Migration
coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

OK, I've reverted to the code without dcaro's suggested changes -- that should be what you ran successfully.

Mar 9 2024, 4:18 PM · Grid-Engine-to-K8s-Migration
coldchrist updated subscribers of T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

See https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Bot_that_maintains_GA_nominations_page_is_down -- @SD0001 offered to be a maintainer and has managed to get a run to work. I've added the lines you suggested to the k8s version of the code and tried running it via the toolforge command you give but it failed on pywikibot again. I'm a bit concerned that the advice you're giving me may conflict with what SD0001 has done -- they resolved the issue with importlib.metadata, which was independent of the code changes I was making to switch from the grid. As you can probably tell I'm not very knowledgeable about the infrastructure here so I appreciate the help from both of you.

Mar 9 2024, 3:06 PM · Grid-Engine-to-K8s-Migration
coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

Thanks, @JJMC89, I thought I'd responded to your post yesterday but apparently not. I removed the PYTHONPATH setting from my bash profile, and checked it is unset, and now it's complaining about pywikibot:

Mar 9 2024, 10:36 AM · Grid-Engine-to-K8s-Migration

Mar 8 2024

coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

And it appears from the bot's logs that it actually stopped running just a few hours before, not long after midnight Pacific time. So when I began working on the upgrade from the grid engine it was already running into this problem, so it is presumably unrelated to that change.

Mar 8 2024, 10:20 PM · Grid-Engine-to-K8s-Migration
coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

I tried that, and it's now giving me the same importlib.metadata error as the old code which I suppose at least means I have the syntax right and it's trying to run. So it's the same problem either way -- can you tell me what I need to do to fix it? Thanks

Mar 8 2024, 8:54 PM · Grid-Engine-to-K8s-Migration
coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

@dcaro, what is much worse is that now I've reverted the code to the old version, it no longer runs. It's complaining about importlib.metadata:

Mar 8 2024, 8:37 PM · Grid-Engine-to-K8s-Migration
coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

@dcaro, I made the code changes (just to GANbot.py so far) and tried running the submit command as you give it:

Mar 8 2024, 7:00 PM · Grid-Engine-to-K8s-Migration

Mar 6 2024

coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

I'll plan on doing the switchover this weekend. Can I make the code changes first and the job changes second, or do they have to be coordinated? E.g. if I make the code changes as you suggest, and run the code from the shell, will that work, or will it have to be executed via the new job mechanism to work?

Mar 6 2024, 11:08 PM · Grid-Engine-to-K8s-Migration
coldchrist added a comment to T357554: Migrate ganfilter from Toolforge GridEngine to Toolforge Kubernetes.

@dcaro, thanks for the ping -- ganfilter doesn't use a webservice, so as far as I can tell the only thing that needs to happen is to change the cron from jsub. Currently the cron command is

Mar 6 2024, 11:07 AM · Grid-Engine-to-K8s-Migration

Sep 10 2023

coldchrist created T346002: Visual editor duplicates notes section when adding a citation.
Sep 10 2023, 6:43 PM · VisualEditor

Aug 20 2015

coldchrist added a comment to T96115: One user often can't create new articles in VisualEditor while logged in.

It can be closed; it doesn't seem to be happening any longer. Thanks.

Aug 20 2015, 4:01 PM · VisualEditor

Apr 16 2015

coldchrist added a comment to T96116: Make adding sortkeys for DEFAULTSORT easier.

From a user's point of view, I think the best thing VE could do for articles with DEFAULTSORT not set is to put the text of the article title in the default sort field so it's available for editing, but if the user makes no changes to it, do not save it. Perhaps a greyed-out look could be used to indicate that the text is unchanged and won't be saved. This gives maximum convenience with minimum need for the user to comprehend what's going on, and does not constitute a dirty diff.

Apr 16 2015, 12:18 AM · VisualEditor

Apr 6 2015

Restricted Application added a project to T90663: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia: Notice.
Apr 6 2015, 6:25 PM · Community-consensus-needed, Phlogiston-Category, User-notice, VisualEditor, Wikimedia-Site-requests

Jan 14 2015

coldchrist added a comment to T52474: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text..

It doesn't seem to have been mentioned above that this bug can cause the loss of a citation, which might affect the severity or priority. If you have a ref inside a group note (e.g. inside a tag) and delete all other copies of the ref, including the base copy, VE is unable to transfer the base text to the copy of the ref in the tag, so the citation is lost.

Jan 14 2015, 2:51 AM · Epic, VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-DataModel