Thu, May 17
I've made changes and it got merged. It's ready for design signoff now.
Wed, May 16
Regarding the task description, the original data of the explore feed on 03/20/2018
Explore feed API: https://de.wikipedia.org/api/rest_v1/feed/featured/2018/03/20, which returns the de description of the image.
Tue, May 15
Hi @RHo, ready for design signoff
Hi @RHo, ready for design signoff
Have made changes to fix the bug of showing duplicate variants in the list.
Mon, May 14
Thanks! I think this is a bug that should be fixed, will create a patch to fix it.
@RHo Ready for signoff.
Fri, May 11
Thu, May 10
@RHo Patch has been merged, let me know if any changes needed.
Wed, May 9
Tue, May 8
Does these look better?
Mon, May 7
Fri, May 4
Can we make it so that Traditional is shown as well? It would be a bad sign to Traditional speakers who likely have pinyin keyboard to only see Simplified shown as suggested.
Thu, May 3
when pinyin keyboard is on for the Nexus 5 (6.0.1), only Simplified Chinese is being shown as a suggested language
While fetching the language code from keyboard apps, the Pinyin keyboard app returns zh_CN code, which would be shown as Simplified Chinese.
Sure. I've opened a ticket for that.
12 Dialogs - use standard dialog text styling - Subhead secondary - Roboto Regular 16sp with 24 line-height (at the moment the line-height is narrower than expected)
Tue, May 1
I see, thanks! @RHo
Mon, Apr 30
Regarding the line 2 section of Other languages logic table in the description, should we show the language name base on the top most app language? (in the table you've put in as device language)
Thu, Apr 26
Wed, Apr 25
Tue, Apr 24
Looks like we cannot get a correct language list from keyboard apps. For example, the G-board keyboard app will return 25+ languages even if only enabled the Traditional Chinese.
Apr 20 2018
@RHo It works now! Thanks!
Looks like the flow on clicking on the Wikipedia language in the Settings page still be linked to the Add a language page in the Invision prototype.
@RHo Thanks, but that's not what I would like to ask.
If a user wants to only arrange or delete the app languages, should the flow go like the following steps? (or did I miss something?)
Apr 19 2018
@RHo I see, thank you!
If a user has added all the suggested languages, should we keep or hide the suggested languages section (including the section header)?
Looks like the patch got merged on Apr 12, so the 2.7.231-r-2018-04-09 version did not have this issue fixed.
the text cursor is now thicker than expected that it is Accent50 - just want to confirm that this is using the standard cursor element?
I've created a custom cursor element that the width is 2dp and the color is Accent50, I can change to 1dp to see if it works.
Apr 18 2018
Apr 12 2018
Apr 11 2018
Apr 9 2018
Apr 6 2018
Yes, my patch (https://gerrit.wikimedia.org/r/#/c/424477/) is still in CodeReview, and it fixes the issue of the Tab titledoes not match the article title but does not fix the ContextMenu Dialog issue.
For logged in user, we will still get the mixed content by fetching the specific variant URL.
I think I found where the issue came from.
@RHo I cannot reproduce it on my device. Did you test while you are logged in? Please try to log out and test it again to see whether if it is reproducible.
Apr 5 2018
Yes, it is. We cannot update the original title that shows on the search results before loading the leading section.