In T330753#8722379, @scblr wrote:

@cooltey I haven’t looked at everything yet but here are the things that I spotted for now. Gotta call it a day for now 😵‍💫

Thanks for the great work!

---

1) Can you set the inactive state of the navigation to toolbar? (T330804)

Thanks for the update, I have updated the ticket description with the APK link.

In T330645#8717317, @scblr wrote:

@cooltey = 🤴

It’s ALMOST ready for code signoff. While browsing – I noticed these two last issues:

1) Some elements in the bottom sheet of the article don’t use progressive color group in dark and black mode. It’s some kind of default Android green?

After digging into the code, I noticed that we have a custom card view and it applies all kinds of custom values to border colors and elevation.

In T330645#8710557, @scblr wrote:

Hey @cooltey – I think we almost have it! Only a few things left to tune:

1) Use the inactive color group for the bottom-border in the "default" and "filled" states. My bad; I was unclear before.

Done.

2) When an input field is in the active state, it uses the progressivecolor group for border-bottom

Done.

3) In addition to the border-bottom: input fields have a 0.5dp border-top/left/right in the `border-color group

Every item you have mentioned has been addressed. Please download the latest APK from the ticket description, thanks!

Hi @scblr, here are the text styles we have been using in the app, hope these will help you to define the replacement for the new text components in Figma.

I have noticed the color looks weird in the Sepia theme 🤔

Ok, I’ll keep an eye on that.

The updates are almost completed and you are welcome to do the first round review of the colors, please download the APK from the ticket description to see the changes.

Ongoing task

Reduce and update colors in the Android app

Ticket: T330645
Status: working-in-progress
PR: https://github.com/wikimedia/apps-android-wikipedia/pull/3871

Here are the colors that have been used somewhere else in the app, would you please help me to define the replacements?

@Seddon Please help to add the correct tag to the team that can do the request, thanks!

After lots of testing and investigation, it looks like the issue is in the OkHttp library that we are using now, which is related to the SocketTimeout issue.

After further research on the required APIs for this task, it seems like the #3 I have mentioned above cannot fit in the functionality properly.

Per discussion in the meeting:

1. No extra UI in the editing screen, we should set the cursor at the beginning of the diff text. (if possible).
2. If the revision cannot be undone, then pops up a snackbar with a warning message, but still enable the editor for users to edit the content manually.
3. We can either check the content if part of the edit of the revision matches the content, or find a possible API to get the status of the current revision vs the undo revision.

What would be the case where the undo action is actually an edit conflict? For example:
https://en.wikipedia.org/w/index.php?title=Treaty_of_Berwick_(1560)&action=edit&undoafter=1141886230&undo=1141925273

Confirmed with @JTannerWMF and created a sub-task for the edge case issue. Now, this parent ticket is able to be closed.

Update: video from Jazmin
https://youtu.be/LxC5_iE31E0

I still can not reproduce the issue. Would it be possible to restart your device and try to reproduce it again? And it would be very helpful if you can provide a video of it. Thanks!

In T315508#8638149, @Tsevener wrote:

@cooltey I tested our App Store version, and it looks like we do not push to our native talk page. It instead detects this as a link that can be opened as an in-app web view, and pushes there:

How does the iOS app handle the link which will redirect to the specific talk topic link with the comment anchor? Does the iOS read it and get the redirected URL in the app and then open the talk topic screen?

In T326648#8628787, @scblr wrote:

@cooltey

1)

Currently, the All radio option is not selected as the default. Please enable it by default to indicate filters more clearly to users.

Done.

The filter indicator now shows that 10 filters are enabled, even though I did not change the defaults:

The default filters should be indicated with just the icon and no number.

Hi @scblr

In T326648#8622064, @scblr wrote:

1) Please add separator lines between the items. I reviewed this proposal with the design team last week, and the radios are easier to parse.

In T327903#8625905, @scblr wrote:

@cooltey just checked this looks pretty good already! 👏 Two minor comments:

1) Set the default list name to Shared list %datetime to avoid alerts like this:

Reuse the title and description from here, but use a shorter form for the date and time:

The implementation is completed. You may still see the unchanged behaviors about the tooltips, which relate to another unmerged ticket.

The APK has been updated with the latest design, please download the latest alpha APK from the ticket description.

Hi @scblr. The fix has been handled in this ticket T328474 and now you can see it on the latest Alpha.

The research is completed. I have a PR of fixing it and also fixing the zero MB size when importing a list.

@scblr Since there's no alpha APK available for testing, here is a demo video for you to check:
https://youtube.com/shorts/sg2wYTH0xIE