Wed, Jan 15
The mobile-html branch has been merged into the master branch and it's ready for QA.
The testing steps could be:
- Clean app data
- Save articles for offline reading before actually reading the articles.
- Turn on airplane mode and read offline articles to see if it works.
Is this solution feasible for handling images in the captions and tags task (T240196)? If it’s really not possible, this would have substantial implications on both UI designs.
note: might have a solution for the wrap_content, but it does cause some unexpected behaviors after image loaded. (https://stackoverflow.com/a/34075281/4545041)
Tue, Jan 14
I've tried to make the image "fit screen width" and "wrap to its height", but unfortunately, the image library we've been using now does not support that. (Please see here: https://frescolib.org/docs/using-simpledraweeview.html)
Respects original image aspect ratio (similar to new image tagging UI)
Not sure if you'd like it to have a minimum height of the image, and here are some examples of the current implementation.
Mon, Jan 13
Fri, Jan 10
Found an ImageZoomHelper class inside the repo above, and it nicely makes the instagram-style pinch-zoom work!
Thu, Jan 9
Also found this repository that implement exactly the same feature, but unfortunately it is using Glide
By looking at Instagram's pinch to zoom feature, we can notice the following things:
Wed, Jan 8
Tue, Jan 7
@ABorbaWMF Please also check the link preview dialog and tab title to see if the title matches.
My bad, I should wait until the mobile-html branch merged into the master branch.
Mon, Jan 6
Requires Page Content Service to complete the changes:
09) The Edit link is not labeled.
It says "Index link" now, and it should be changed to "Edit section" with the current section title.
Fri, Jan 3
This can be fixed by setting l10n in the setup().
Thu, Jan 2
Dec 20 2019
Dec 16 2019
Report from the OTRS ticket:
Dec 14 2019
Dec 10 2019
Dec 9 2019
I see, thanks for checking @Mholloway.
Dec 6 2019
Just found this article still has the issue:
Dec 4 2019
What is the behavior when the response has no pages?
The current behavior is to hide the entire read more section, includes the section title.
Looks like the "1" page has not been updated/purged, and the source code of https://en.wikipedia.org/api/rest_v1/page/mobile-html/1 does not contain the following stylesheet:
<link rel="stylesheet" href="//meta.wikimedia.org/api/rest_v1/data/css/mobile/pcs">
We may close this ticket since not all pages have been updated/purged.
Dec 3 2019
Looks good to me now. Thanks @Mholloway
Dec 2 2019
Nov 27 2019
The version 2.7.50303 and 2.7.50302 accidentally contain the code of hiding the fundraising card from the Explore feed if the placement: article.
Nov 26 2019
@schoenbaechler You can use the current production app to test it since it has not been updated to the version that supports the red border and in-article fundraising dialog.
Anything else you need from our team?
Nov 25 2019
Nov 22 2019
Nov 21 2019
If you really need to collect the data, we can have extra code in our app to change the WikipediaApp string and add either Feed or Article of it or contains two URLs in the API with different utm_medium values for showing in feed or article.
Nov 20 2019
Perhaps my old PR might be a useful starting point:
Thanks, will check it.
Here's the donate URL that contains logging parameters:
Nov 19 2019
Nov 18 2019
Provide links (per country?) for “Donate now” CTA
Nov 15 2019
Got it, thanks!
Nov 14 2019
Have a question, what are the settings of placement and border for the announcement for each country? (Maybe that's a question for online fundraising team)
(info about placement: T235537)
@cooltey, looks good! Last thing before it’s good to go, can we use font-weight: normal; for To all our readers in the UK, as defined?
As we discussed, I've changed it globally.
Would it solve the swiping issue, described in the task’s description as well?
Nov 13 2019
This issue has been resolved: https://github.com/wikimedia/apps-android-wikipedia/pull/763
Would it be better if it uses the same header view style as other lists? Here's the implementation:
Nov 7 2019
I tested it with a newly created account and it can reproduce the issue.
Nov 6 2019
As our discussion, we will wait until completely move to mobile-html with the following changes:
Nov 5 2019
Since the Okhttp library is now using Kotlin on the project, it would be a good idea for us to also to convert our network related classes to Kotlin, so that we can continually use our current mechanism of saving article offline.
Look into any existing offline formats supported by the Android web view (webarchive, etc)
Thanks @cooltey, this is going to have a positive impact on donations. Question: what is its current behavior? It would be ideal if it always updates to the current weekday & date.
Nov 4 2019
Referencing to here and now has proven to be very effective in fundraising appeals. Is there a way to make displaying weekday and date possible above the card? I suggest to put some time into investigating on it.
I added the regular date format (just like other card type) above the fundraising card, does that work for you?
I forgot to update the API parameter for you to check. Updated!
Done. Please let me know if it need other design changes.