Fri, Sep 20
Here's the new demo video based on the styles you've recommended.
Thu, Sep 12
Wed, Sep 11
Will do it, thanks @schoenbaechler
This can wait a bit until we merge this PR: https://github.com/wikimedia/apps-android-wikipedia/pull/623
Tue, Sep 10
I see, thanks @schoenbaechler.
Mon, Sep 9
@schoenbaechler Is it ready for dev now? (Since you're still claiming this ticket)
Created a bug ticket about syncing reading list entries since it will affect the correctness when requesting page/summary.
Thu, Sep 5
Thanks @Dbrant found a solution for the issue: https://github.com/wikimedia/apps-android-wikipedia/pull/624
Wed, Sep 4
User replied with a screenshot, which actually got a null login token:
Tue, Sep 3
Note: sent a beta APK version of storing and displaying the "login token" to the users to see if it actually sends a null logintoken when logging in.
Update: the RxJava login logic does not solve the issue since both of the users reported the same "login token" message.
Sat, Aug 31
Note for iOS folks if the issue is still reproducible:
Looks like this issue has been resolved recently.
@liangent please let us know if you still can see this issue on the latest version of the app.
Updated the task description since we've changed a context dialog to a popup menu, and there's no title will be shown on the popup menu.
Note: sent a beta APK with new RxJava login logic to users who have login token issue.
Fri, Aug 30
Thu, Aug 29
Found another language variants issue in the page/related endpoint and I created a ticket for it: T231609
Wed, Aug 28
Context about updating the ticket: T227092#5444194
Tue, Aug 27
Not sure if it slows down the requesting time, but is it possible to do an extra request of /page/summary to update the displaytitle when sending the response on /feed/featured.
Mon, Aug 26
Note: we can apply the correct displaytitle to the following places:
Aug 23 2019
@ABorbaWMF I think it would be fine if just runs general browsing and editing on suggested edits related features to see if everything looks normal.
Related ticket: T230067
Aug 22 2019
This ticket is fixed by this PR: https://github.com/wikimedia/apps-android-wikipedia/pull/587
Aug 21 2019
It requires the wikimedia-page-library to merge my PR:
Never mind, I think I got this. https://github.com/wikimedia/apps-android-wikipedia/pull/577
After a long investigation, I found that this issue has happened for a while, and it is because we've changed the parent of BaseAppTheme to Theme.MaterialComponents.Light.NoActionBar.
We can find the history here: https://github.com/wikimedia/apps-android-wikipedia/commit/e18fc3f4e3d0d0c21aeda2e78baea93ab5b5d22d#diff-6f870d7e261f41dd3e52a2a129fa1fc5
Aug 20 2019
Aug 19 2019
Feedback about the article page, such as "link color", "image label", "icon size"...etc, require update from wikimedia-page-library.
I put the mention, mention-failure, and mention-success categories into one preference setting as mention
Aug 16 2019
@JoeWalsh I reopened the PR: https://github.com/wikimedia/wikimedia-page-library/pull/217
As we discussed on Slack, we will use 2x2 grid buttons with a 300dp width each row globally, for now.
Moved to Blacked/Waiting and waiting for the implementation of metadata + summary endpoints.
Aug 15 2019
Hi @RHo, do you have the information about the brand and OS version of the device?
Not sure how this happened that I can not reproduce on my other devices, but still can reproduce it on the emulator, which would probably match my assumption above.
I checked the extension file above and found that there are so many types or categories from the API response. If we want to show "ALL" notification types (categories), should we remove the logic of setting preferences? (see the image below)
Aug 14 2019
Note: notification categories from the API
Aug 13 2019
Tested on a 480x800 emulator