Page MenuHomePhabricator

cooltey (Cooltey Feng)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2017, 11:38 PM (99 w, 12 h)
Availability
Available
IRC Nick
cooltey
LDAP User
Cooltey
MediaWiki User
CFeng (WMF) [ Global Accounts ]

Recent Activity

Yesterday

cooltey moved T228103: [BUG] Copy problems on Suggested Edits v2 from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Jul 15, 10:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey moved T228103: [BUG] Copy problems on Suggested Edits v2 from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Jul 15, 9:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey added a comment to T228103: [BUG] Copy problems on Suggested Edits v2.

I can reproduce this one in the Gallery screen by tapping the "Add image caption (%language)" button

On the addition screen, the top label also says "caption" which is super confusing

Mon, Jul 15, 9:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey moved T228103: [BUG] Copy problems on Suggested Edits v2 from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Jul 15, 9:12 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey claimed T228103: [BUG] Copy problems on Suggested Edits v2.
Mon, Jul 15, 9:11 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Thu, Jul 11

cooltey claimed T226290: [BUG] Images not saved when article saved for offline reading.
Thu, Jul 11, 7:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey moved T226290: [BUG] Images not saved when article saved for offline reading from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Thu, Jul 11, 7:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey added a comment to T225442: [BUG] Logged in user still shows as logged-out in menu, cannot edit semi-protected pages.

Since I cannot reproduce this issue, could you please try to update your password or to reinstall the app to see if it happens again?

Thu, Jul 11, 7:11 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
cooltey moved T227796: Handle language variants correctly when syncing the reading lists from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.
Thu, Jul 11, 5:34 PM · Chinese-Sites, Technical-Debt, Wikipedia-Android-App-Backlog
cooltey renamed T227796: Handle language variants correctly when syncing the reading lists from Handle language variant correctly when syncing the reading lists to Handle language variants correctly when syncing the reading lists.
Thu, Jul 11, 4:15 PM · Chinese-Sites, Technical-Debt, Wikipedia-Android-App-Backlog
cooltey created T227796: Handle language variants correctly when syncing the reading lists.
Thu, Jul 11, 4:15 PM · Chinese-Sites, Technical-Debt, Wikipedia-Android-App-Backlog

Tue, Jul 9

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Thanks for checking the changes during your vacation, @schoenbaechler. Hope you have a wonderful vacation.

Tue, Jul 9, 5:23 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey updated subscribers of T209115: Add a feature to clean up all the cache and offline data.

@Charlotte
After discussing with engineers, we think it would be better if we move this ticket to the N board since we are all not sure about what is the best way of implementing it.

Tue, Jul 9, 12:21 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Technical-Debt
cooltey edited projects for T209115: Add a feature to clean up all the cache and offline data, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar); removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi).
Tue, Jul 9, 12:19 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Technical-Debt

Mon, Jul 8

cooltey moved T224789: Deep link action should open a new tab from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jul 8, 10:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T221665: Integrate with References endpoint.

Thanks @bearND!

Mon, Jul 8, 4:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
cooltey moved T221665: Integrate with References endpoint from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jul 8, 4:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Fri, Jul 5

cooltey moved T224789: Deep link action should open a new tab from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, Jul 5, 10:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.

All the PRs were merged and now it's ready for design sign off again :)

Fri, Jul 5, 9:42 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Wed, Jul 3

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

There are #20, #30, #30c, #36, #37 waiting to be merged, and the rest of the feedback items are merged and ready to be checked.

Wed, Jul 3, 11:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T224789: Deep link action should open a new tab from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Wed, Jul 3, 11:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Note:

As you can see on the screenshot, I’ve made 53 contributions. The lock message of “Translate article descriptions” says: Locked until you’ve made 50 verified contributions, which is confusing. Please change the copy to: Locked until you’ve made 50 verified article description contributions

Wed, Jul 3, 5:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Tue, Jul 2

cooltey moved T224789: Deep link action should open a new tab from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Jul 2, 4:41 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

@schoenbaechler
Yes, this behavior applied in larger viewports, portrait mode and landscape mode.

Tue, Jul 2, 3:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Mon, Jul 1

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Most of the feedback was fixed and the PRs were merged, and you are welcome to review the changes.

Mon, Jul 1, 11:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jul 1, 11:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T227037: Opening a file from commons on the web within the app in the image cation translation menu fails due to extra "file" prefix from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jul 1, 11:23 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.

The other PR made by @Dbrant has been merged, you now can see it on the latest alpha.

Mon, Jul 1, 10:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T227037: Opening a file from commons on the web within the app in the image cation translation menu fails due to extra "file" prefix.

This is hard to reproduce but my guess is that the file namespace is not "File:" but in another language.

Mon, Jul 1, 10:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T227037: Opening a file from commons on the web within the app in the image cation translation menu fails due to extra "file" prefix from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jul 1, 9:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey edited projects for T227037: Opening a file from commons on the web within the app in the image cation translation menu fails due to extra "file" prefix, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi); removed Android-app-Bugs, Wikipedia-Android-App-Backlog.
Mon, Jul 1, 9:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey claimed T227037: Opening a file from commons on the web within the app in the image cation translation menu fails due to extra "file" prefix.
Mon, Jul 1, 9:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Sat, Jun 29

cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.

I found a solution to implement the ScrollView with a great gradient bottom, and also make the ScrollView not be able to scroll. (kind of a hack way)

Sat, Jun 29, 12:07 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Thu, Jun 27

cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.

Hey @schoenbaechler, the PR has been merged. Please check it again to see if it looks good to you.

Thu, Jun 27, 9:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` from Doing to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Thu, Jun 27, 12:27 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Thanks for checking, @schoenbaechler. Now the rest of the design changes can be reviewed now (except the bottom sheet stuff we've talked about above)

Thu, Jun 27, 12:22 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

I cannot reproduce it. They are having the same gradient view on the bottom, and also the left (license) and right (CC-BY-SA 4.0) label view are in the same view group.

Thu, Jun 27, 12:04 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Tue, Jun 25

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Hi, @schoenbaechler
A comment from @Sharvaniharan talking about letting the LinkPreviewDialog becomes full width everywhere in the app.
https://github.com/wikimedia/apps-android-wikipedia/pull/404#pullrequestreview-254222940

Tue, Jun 25, 8:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Jun 25, 4:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Mon, Jun 24

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Thanks for the response, @schoenbaechler.

Mon, Jun 24, 11:48 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey added a comment to T223396: Language variant support for Suggested Edits APIs.

Thanks for the explanation, @Dbrant.

Mon, Jun 24, 11:10 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
cooltey added a comment to T223396: Language variant support for Suggested Edits APIs.

Thanks for the quick fix, @Mholloway

Mon, Jun 24, 9:28 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog

Fri, Jun 21

cooltey added a comment to T223396: Language variant support for Suggested Edits APIs.

While testing the API, I found that if passes zh-hant to get article descriptions, it will return an empty result.

Fri, Jun 21, 9:41 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, WikimediaEditorTasks, Reading-Infrastructure-Team-Backlog
cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Hi, @schoenbaechler and cc @Charlotte:

Fri, Jun 21, 5:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Mon, Jun 17

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Hmm, I think there’s probably no Commons page @cooltey, it’s hosted on Wikipedia. Is that the reason why it didn’t work? Here are the relevant links though:
...
If yes, we have to hide the translation CTA as well for files that are not hosted on Commons.

Makes sense. I think it is a bug needs to be fixed.

Mon, Jun 17, 9:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 14 2019

cooltey added a comment to T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.

Hi @schoenbaechler, I have the following questions:

Jun 14 2019, 10:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 14 2019, 10:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey claimed T225635: Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11`.
Jun 14 2019, 10:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 13 2019

cooltey added a comment to T225442: [BUG] Logged in user still shows as logged-out in menu, cannot edit semi-protected pages.

@Charlotte I cannot reproduce it using my general account. If someone has an admin account, please let him/her test if it is possible to reproduce as well.

Jun 13 2019, 10:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
cooltey moved T225436: Change copy in Suggested edits from “Add/translate descriptions” to “Add/translate article descriptions” from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 10:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T225472: [BUG] In suggested edits, lost the back arrow and publish icon in dark and black modes from Design signoff to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 10:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
cooltey moved T225472: [BUG] In suggested edits, lost the back arrow and publish icon in dark and black modes from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 10:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
cooltey moved T224595: New translation strings for CTA’s in Suggested edits from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 10:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

Hey @cooltey, do I understand correctly that both screenshots show the same gradient overlay in different situations? Is it 48px? If yes, I think it looks fine like that! Thx.

Jun 13 2019, 3:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224595: New translation strings for CTA’s in Suggested edits from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 3:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T225436: Change copy in Suggested edits from “Add/translate descriptions” to “Add/translate article descriptions” from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 3:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 12 2019

cooltey moved T224595: New translation strings for CTA’s in Suggested edits from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 6:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey claimed T224595: New translation strings for CTA’s in Suggested edits.
Jun 12 2019, 6:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T225436: Change copy in Suggested edits from “Add/translate descriptions” to “Add/translate article descriptions” from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 6:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey claimed T225436: Change copy in Suggested edits from “Add/translate descriptions” to “Add/translate article descriptions”.
Jun 12 2019, 6:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 6:32 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

Hi @schoenbaechler, we can have full control of the gradient overlay.

Jun 12 2019, 6:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

Hi @schoenbaechler, I've followed your suggestion to update the UI, and in a certain situation, it will have the text reaches the bottom to close. Not sure if it looks good to you.

Jun 12 2019, 3:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

Thanks @schoenbaechler, it looks good!

Jun 12 2019, 2:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Jun 11 2019

cooltey moved T225472: [BUG] In suggested edits, lost the back arrow and publish icon in dark and black modes from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 11 2019, 9:30 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
cooltey claimed T225472: [BUG] In suggested edits, lost the back arrow and publish icon in dark and black modes.
Jun 11 2019, 5:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Code Review to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 11 2019, 4:41 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 11 2019, 4:41 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Jun 10 2019

cooltey added a comment to T224500: Tweak gradient at bottom of cards (captions and descriptions).

Would the view be scrollable if it has the fading edge (gradient) on the bottom? For Android, when the view has a fading edge, it means that it is scrollable.

Jun 10 2019, 10:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey updated the task description for T224500: Tweak gradient at bottom of cards (captions and descriptions).
Jun 10 2019, 9:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey updated the task description for T224500: Tweak gradient at bottom of cards (captions and descriptions).
Jun 10 2019, 9:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224051: Add image captions in “Suggested edits” from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 10 2019, 8:37 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey claimed T224500: Tweak gradient at bottom of cards (captions and descriptions).
Jun 10 2019, 8:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224500: Tweak gradient at bottom of cards (captions and descriptions) from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 10 2019, 8:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224051: Add image captions in “Suggested edits” from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 10 2019, 8:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey claimed T224051: Add image captions in “Suggested edits”.
Jun 10 2019, 4:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 7 2019

cooltey added a comment to T224051: Add image captions in “Suggested edits”.

@schoenbaechler I would like to claim and work on this ticket. Is it available now?

Jun 7 2019, 6:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T224051: Add image captions in “Suggested edits” from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 6:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey placed T223128: Translating image captions in the app (workflow) up for grabs.
Jun 7 2019, 5:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey placed T223129: Editing image captions in the app up for grabs.
Jun 7 2019, 5:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223129: Editing image captions in the app from Blocked/Waiting to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 5:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223128: Translating image captions in the app (workflow) from Blocked/Waiting to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 5:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223131: Translate image captions in “Suggested edits” from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 5:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223129: Editing image captions in the app from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 1:03 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223128: Translating image captions in the app (workflow) from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 1:03 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223128: Translating image captions in the app (workflow) from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 1:03 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223129: Editing image captions in the app from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 1:03 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223128: Translating image captions in the app (workflow) from Doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 1:03 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
cooltey moved T223129: Editing image captions in the app from Doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 7 2019, 1:03 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 5 2019

cooltey moved T223131: Translate image captions in “Suggested edits” from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 5 2019, 6:55 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 3 2019

cooltey moved T224788: Deep link should handle zh.wikipedia.org/zh/ URL from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 3 2019, 5:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224789: Deep link action should open a new tab from Code Review to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 3 2019, 5:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey added a comment to T223131: Translate image captions in “Suggested edits”.

Actually, I hope to persuade you that it's not worth including any extmetadata fields (which appear structured on the page and in the API, but actually aren't), even the unstructured captions, for the same reason

My latest info on this comes from @JoeWalsh in T223130#5185241, where he suggests to start with these fields: “(...) structured captions, unstructured captions, description, artist, credit, license, and depicts (...).” Is that still the case? The ideal scenario (mentioned in T223132) would be:

  • Image caption (Source: unstructured, else structured)
  • Depicts
  • Author
  • Artist
  • Date
  • Source/Photographer
  • Licensing
  • File usage on Wikipedia in the current app language(s) [not relevant for Suggested edit feed cards]
  • More infos (link to file page on Commons) [not relevant for Suggested edit feed cards]

Maybe the engineers can chime in here, but I'd suggest doing a follow-up imageinfo query for this info on a per-image basis for selected candidates, similar to how a page summary request is performed on demand for page previews. Getting unstructured imageinfo for a single image is reasonably fast, but doing so for large numbers in a single request (as I'm doing when generating suggestions) gets to be a problem.

@cooltey and @Dbrant - Thoughts on @Mholloway's comment above?

@Charlotte
Yes, that's what I've been doing on my working in progress PR, and a follow-up imageinfo query is really doing well.

Jun 3 2019, 5:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 1 2019

cooltey moved T224789: Deep link action should open a new tab from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 1 2019, 12:45 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey edited projects for T224789: Deep link action should open a new tab, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi); removed Android-app-Bugs, Wikipedia-Android-App-Backlog.
Jun 1 2019, 12:45 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey moved T224788: Deep link should handle zh.wikipedia.org/zh/ URL from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 1 2019, 12:45 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey edited projects for T224788: Deep link should handle zh.wikipedia.org/zh/ URL, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi); removed Android-app-Bugs, Wikipedia-Android-App-Backlog.
Jun 1 2019, 12:45 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey claimed T224788: Deep link should handle zh.wikipedia.org/zh/ URL.
Jun 1 2019, 12:44 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
cooltey claimed T224789: Deep link action should open a new tab.
Jun 1 2019, 12:44 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

May 31 2019

cooltey created T224790: Color boxes does not have correct colors in dark mode.
May 31 2019, 11:17 PM · wikimedia-page-library, Wikipedia-Android-App-Backlog