I can reproduce this one in the Gallery screen by tapping the "Add image caption (%language)" button

On the addition screen, the top label also says "caption" which is super confusing

Since I cannot reproduce this issue, could you please try to update your password or to reinstall the app to see if it happens again?

Thanks for checking the changes during your vacation, @schoenbaechler. Hope you have a wonderful vacation.

@Charlotte
After discussing with engineers, we think it would be better if we move this ticket to the N board since we are all not sure about what is the best way of implementing it.

Thanks @bearND!

All the PRs were merged and now it's ready for design sign off again :)

There are #20, #30, #30c, #36, #37 waiting to be merged, and the rest of the feedback items are merged and ready to be checked.

Note:

As you can see on the screenshot, I’ve made 53 contributions. The lock message of “Translate article descriptions” says: Locked until you’ve made 50 verified contributions, which is confusing. Please change the copy to: Locked until you’ve made 50 verified article description contributions

@schoenbaechler
Yes, this behavior applied in larger viewports, portrait mode and landscape mode.

Most of the feedback was fixed and the PRs were merged, and you are welcome to review the changes.

The other PR made by @Dbrant has been merged, you now can see it on the latest alpha.

This is hard to reproduce but my guess is that the file namespace is not "File:" but in another language.

I found a solution to implement the ScrollView with a great gradient bottom, and also make the ScrollView not be able to scroll. (kind of a hack way)

Hey @schoenbaechler, the PR has been merged. Please check it again to see if it looks good to you.

Thanks for checking, @schoenbaechler. Now the rest of the design changes can be reviewed now (except the bottom sheet stuff we've talked about above)

I cannot reproduce it. They are having the same gradient view on the bottom, and also the left (license) and right (CC-BY-SA 4.0) label view are in the same view group.

Hi, @schoenbaechler
A comment from @Sharvaniharan talking about letting the LinkPreviewDialog becomes full width everywhere in the app.
https://github.com/wikimedia/apps-android-wikipedia/pull/404#pullrequestreview-254222940

Thanks for the response, @schoenbaechler.

Thanks for the explanation, @Dbrant.

Thanks for the quick fix, @Mholloway

While testing the API, I found that if passes zh-hant to get article descriptions, it will return an empty result.

Hi, @schoenbaechler and cc @Charlotte:

Hmm, I think there’s probably no Commons page @cooltey, it’s hosted on Wikipedia. Is that the reason why it didn’t work? Here are the relevant links though:
...
If yes, we have to hide the translation CTA as well for files that are not hosted on Commons.

Makes sense. I think it is a bug needs to be fixed.

Hi @schoenbaechler, I have the following questions:

@Charlotte I cannot reproduce it using my general account. If someone has an admin account, please let him/her test if it is possible to reproduce as well.

In T224500#5256181, @schoenbaechler wrote:

Hey @cooltey, do I understand correctly that both screenshots show the same gradient overlay in different situations? Is it 48px? If yes, I think it looks fine like that! Thx.

Hi @schoenbaechler, we can have full control of the gradient overlay.

Hi @schoenbaechler, I've followed your suggestion to update the UI, and in a certain situation, it will have the text reaches the bottom to close. Not sure if it looks good to you.

Thanks @schoenbaechler, it looks good!

Would the view be scrollable if it has the fading edge (gradient) on the bottom? For Android, when the view has a fading edge, it means that it is scrollable.

@schoenbaechler I would like to claim and work on this ticket. Is it available now?

In T223131#5226979, @Charlotte wrote:

In T223131#5223714, @Mholloway wrote:

In T223131#5223374, @schoenbaechler wrote:

Actually, I hope to persuade you that it's not worth including any extmetadata fields (which appear structured on the page and in the API, but actually aren't), even the unstructured captions, for the same reason

My latest info on this comes from @JoeWalsh in T223130#5185241, where he suggests to start with these fields: “(...) structured captions, unstructured captions, description, artist, credit, license, and depicts (...).” Is that still the case? The ideal scenario (mentioned in T223132) would be:

• Image caption (Source: unstructured, else structured)
• Depicts
• Author
• Artist
• Date
• Source/Photographer
• Licensing
• File usage on Wikipedia in the current app language(s) [not relevant for Suggested edit feed cards]
• More infos (link to file page on Commons) [not relevant for Suggested edit feed cards]

Maybe the engineers can chime in here, but I'd suggest doing a follow-up imageinfo query for this info on a per-image basis for selected candidates, similar to how a page summary request is performed on demand for page previews. Getting unstructured imageinfo for a single image is reasonably fast, but doing so for large numbers in a single request (as I'm doing when generating suggestions) gets to be a problem.

@cooltey and @Dbrant - Thoughts on @Mholloway's comment above?

@Charlotte
Yes, that's what I've been doing on my working in progress PR, and a follow-up imageinfo query is really doing well.