cscott (C. Scott Ananian)
Parser whisperer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2014, 6:47 PM (183 w, 13 h)
Availability
Available
IRC Nick
cscott
LDAP User
Unknown
MediaWiki User
Cscott

Editor since 2005; WMF developer since 2013. I work on Parsoid and OCG, and dabble with VE, real-time collaboration, and OOjs.

On github: https://github.com/cscott

See https://en.wikipedia.org/wiki/User:cscott for more.

Recent Activity

Thu, Apr 5

cscott added a comment to T119687: [Spike] Investigate how Chinese writing variants are stored.

FYI, the hardcoded conversion table is includes/ZhConversion.php which may help determine the language variant of arbitrary text.

There is a function LanguageConverter::guessVariant().

Thu, Apr 5, 9:50 PM · Language-Team, Scoring-platform-team (Current)
cscott created T191571: LanguageConverter::guessVariant should go away.
Thu, Apr 5, 9:49 PM · Parsing-Team, Language-Team, MediaWiki-Parser

Wed, Apr 4

cscott added a comment to T54061: Merge Poem extension into MediaWiki core.

So, looking at https://gerrit.wikimedia.org/r/328887 it seems that, if that patch is merged, the primary difference between <poem> and <pre> handling in core is:

  • <poem> generates an empty span with margin-left:1em for wikitext like : foo. But I think we could probably tweak the CSS so that the rendering of the standard parser output for :foo (aka, <dl><dd>foo</dd></dl> is the same.
  • <poem> respects leading whitespace, but compresses intraline whitespace. This is currently being done by a combination of CSS and manually substituting leading whitespace with &nbsp;. In order to clean this up, the easiest thing would be to stop compressing intraline whitespace. We'd either do that for a new <lines> tag (and merge the <lines> semantics into core) or else do a wikilint type project to simply removing inadvertent intraline whitespace. Depending on how prevalent it is, the latter might not be too hard.
Wed, Apr 4, 7:53 PM · WorkType-NewFunctionality, Patch-For-Review, MediaWiki-extensions-Poem, MediaWiki-General-or-Unknown

Tue, Apr 3

cscott added a comment to T187848: Fix token transformer return types.

cf https://gerrit.wikimedia.org/r/#/c/411293/11/lib/wt2html/TokenTransformManager.js@939 for example, which has more codepaths than it ought to because of this ambiguity in return types.

Tue, Apr 3, 3:16 PM · Performance, Technical-Debt, Parsoid

Tue, Mar 27

cscott added a comment to T187958: Parsoid and PHP parser parse <gallery caption="…"> differently.

<gallery caption="Foo&#10;&#10;bar"> ... </gallery> might be an interesting test case.

Tue, Mar 27, 3:33 PM · Patch-For-Review, MediaWiki-Parser, Parsoid

Mar 23 2018

cscott created T190534: When trimming whitespace, trim unicode whitespace as well..
Mar 23 2018, 4:17 PM · MediaWiki-Parser

Mar 20 2018

cscott added a comment to T189261: Lightweight parse mode where roundtripping is not required.

I've got no problem with skipping passes, that seems like a fairly coarse-grained tool, but it does potentially open up a new way for preview bugs to creep in. It would be interesting to explore the idea enough to determine how much time we are talking about here, though.

Mar 20 2018, 3:21 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, Parsoid

Mar 16 2018

cscott added a comment to T54061: Merge Poem extension into MediaWiki core.

This zombie bug has lurched to life again because of T188478: Parsoid needs a native implementation of <poem>.

Mar 16 2018, 8:30 PM · WorkType-NewFunctionality, Patch-For-Review, MediaWiki-extensions-Poem, MediaWiki-General-or-Unknown
cscott added a comment to T189405: Expression error on Marathi Wikipedia.

@Tiven2240 is there an answer to @Aklapper's question? That seems to me to be what's going on here, as well, but maybe I'm misunderstanding.

Mar 16 2018, 3:49 PM · MediaWiki-extensions-ParserFunctions

Mar 8 2018

cscott added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

...or just "attribute string" (output is html-escaped to be safe to include in attributes, no bare quotes allowed) or "attribute list" (validated to be valid attribute name=value pairs). I'm not convinced we should necessarily be validating number formats, css rules, etc. (Inspired by the set of template types available in spacebars, which impressed me as a good minimal-but-safe-and-structured template engine).

Mar 8 2018, 10:51 PM · Epic, MediaWiki-Parser

Mar 6 2018

cscott added a comment to T188127: Combined characters appear visually separated on macOS.

The problem seems to arise when (at least) one of the characters is written as an HTML entity, eg:

&#nnnn;o

Parsoid will wrap a <span> tag around the entity in order to support roundtripping, and that span tag will "separate" the combining character from the character it should apply to, in (broken versions of) webkit.

Mar 6 2018, 4:46 PM · Upstream, Readers-Web-Backlog (Tracking), Page-Previews, Page Content Service, Parsoid, Reading-Infrastructure-Team-Backlog

Mar 1 2018

cscott added a comment to T188164: Popups don‘t support language variant conversion and {{lang}} template.

The outer HTML for the "Girl Drop" section in https://zh.wikipedia.org/api/rest_v1/page/html/POP_TEAM_EPIC is

<span style="font-weight: normal;" about="#mwt31">(<span lang="ja"><span typeof="mw:LanguageVariant" data-mw-variant="{&quot;disabled&quot;:{&quot;t&quot;:&quot;☆色ガールドロップ&quot;}}"></span></span>)</span>

The blank section in the parens is the language variant markup. Your expandtemplates request is executing on en.wikipedia.org, instead of zh.wikipedia.org, so you're expanding the wrong template. This one contains the language converter markup:
https://zh.wikipedia.org/w/api.php?action=expandtemplates&text={{nihongo|%E3%80%8A%E6%98%9F%E8%89%B2Girl%20Drop%E3%80%8B%7C%E2%98%86%E8%89%B2%E3%82%AC%E3%83%BC%E3%83%AB%E3%83%89%E3%83%AD%E3%83%83%E3%83%97}}

Mar 1 2018, 2:18 AM · Parsoid, Readers-Web-Backlog (Tracking), Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, MediaWiki-Language-converter, Chinese-Sites, Page-Previews

Feb 28 2018

cscott added a comment to T117549: ApiParse: Do not generate warning on parameter `variant`.

Quick cross-reference: the variant parameter is only documented here in phab: T44356#439479 and T34906#381101
The patch in gerrit seems to be stuck based on resolution of caching issues. Note that caching is apparently currently broken in some cases if you use this API parameter as a logged-in user, so beware.

Feb 28 2018, 6:20 PM · Patch-Needs-Improvement, MediaWiki-API

Feb 27 2018

cscott added a comment to T106079: Parsoid includes control characters that are not allowed in HTML 5.

It probably is best to strip these as a post-processing pass on the DOM (as in my comment above), but we should think through some issues of tokenization, etc, and verify consistency with PHP etc etc. But we stripped NULLs from wikitext (T159174), we should be able to strip other characters as well.

Feb 27 2018, 4:30 PM · Patch-For-Review, Collaboration-Team-Triage, Parsoid
cscott added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

We're going to make this a child task of {{#balance}} for now, because when we add a warning people are going to want to know what to do to suppress the warning -- and the thing we're going to want people to do is opt in to balancing (to get their desired start-of-line context).

Feb 27 2018, 4:25 PM · Epic, MediaWiki-Parser

Feb 24 2018

cscott closed T47376: New API change has a pending question about language variants as Resolved.

We resolved this as some point.

Feb 24 2018, 5:12 AM · Parsoid-Web-API, Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization
cscott claimed T47376: New API change has a pending question about language variants.
Feb 24 2018, 5:12 AM · Parsoid-Web-API, Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization

Feb 21 2018

cscott added a comment to T159985: Implement language variant support in the REST API.

All the skeleton code for this has been completed in Parsoid: we honor the Accept-Language header and dispatch to an appropriate language variant converter.

Feb 21 2018, 8:42 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, MediaWiki-Language-converter, Parsing-Team, Reading Epics (Platform JS CSS and HTML consolidation), Services (blocked), RESTBase-API, Chinese-Sites, Wikipedia-Android-App-Backlog

Feb 20 2018

cscott added a comment to T187833: Fatal error: request has exceeded memory limit in StripState.php.

Also possible that someone is actually trying to do the sort of XSS attack that bawolff was protecting against? Deliberately creating a very long strip marker?

Feb 20 2018, 10:50 PM · Parsing-Team, MediaWiki-Parser, Wikimedia-log-errors
cscott added a comment to T187833: Fatal error: request has exceeded memory limit in StripState.php.

A stack trace would also be helpful. Or at least the value of $type or $text in the unstripType caller.

Feb 20 2018, 10:45 PM · Parsing-Team, MediaWiki-Parser, Wikimedia-log-errors
cscott updated subscribers of T187833: Fatal error: request has exceeded memory limit in StripState.php.

cc'ing brian wolff, since he wrote 939faea318d9c2107fab3a584bc1c023f3c592e9

Feb 20 2018, 10:41 PM · Parsing-Team, MediaWiki-Parser, Wikimedia-log-errors
cscott added a comment to T187833: Fatal error: request has exceeded memory limit in StripState.php.

First impression: somebody is adding very large strip markers, which are tripping the memory limits when unstripped to add to the output.

Feb 20 2018, 10:40 PM · Parsing-Team, MediaWiki-Parser, Wikimedia-log-errors
cscott updated subscribers of T187833: Fatal error: request has exceeded memory limit in StripState.php.
Feb 20 2018, 10:30 PM · Parsing-Team, MediaWiki-Parser, Wikimedia-log-errors
cscott added a comment to T184573: Re-enable documentation for ES6-using classes.

jsduck is dead, although we haven't fully reproduced the old jsduck organization of the documentation yet.

Feb 20 2018, 9:58 PM · Parsoid
cscott added a comment to T187672: Create a “Wikimedia” theme for JSDoc3.

To the "requirements" list I'd add "ability to show/hide method & member summaries" as well, since it's hard to get a good idea of what a given class does if you have to scroll through pages and pages of docs on every single method.

Feb 20 2018, 9:54 PM · Design, Front-end-Standards-Group, Documentation
cscott added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

My theme broke today because I was hotlinking to the WikimediaUI-Style-Guide github repo. But it should be fixed as soon as https://gerrit.wikimedia.org/r/410208 is merged.

Feb 20 2018, 9:53 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
cscott added a comment to T187672: Create a “Wikimedia” theme for JSDoc3.

I've started on this! https://github.com/cscott/jsdoc-wmf-theme

Feb 20 2018, 9:52 PM · Design, Front-end-Standards-Group, Documentation
cscott added a comment to T184755: Consider not removing multiple blank lines/white space between paragraphs.

T175421: Parsoid doesn't insert same spacers when article text starts with two or more newlines. may be related (at least in the sense that it could be fixed at the same time, if not actually due to the same cause).

Feb 20 2018, 4:24 PM · Parsoid, VisualEditor

Feb 16 2018

cscott added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

My jsdoc-wmf-theme does manage to resolve a number of these @link shortcuts.

Feb 16 2018, 10:06 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation

Feb 14 2018

cscott added a comment to T187385: Maximum call stack size exceeded.

That stack trace looks much too short for a "maximum call stack size exceeded" exception. What's shown much be just the random tip of the tree. where's the recursive call stack underneath it?

Feb 14 2018, 9:36 PM · Parsoid

Feb 9 2018

cscott added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

https://github.com/jsdoc3/jsdoc/issues/483 is a problem with jsdoc -- it currently doesn't resolve {@link Foo} or {@link #bar} -- you have to spell out the full name of the class, including module name and full class name, every time if you want it to be linked. It may be possible to resolve this in the jsdoc 'theme'.

Feb 9 2018, 11:15 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation

Feb 7 2018

cscott added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

You can see the OOUI documentation in the default theme on https://prtksxna.github.io/oojs-ui/ . For OOUI we'll definitely need our own theme, I was thinking we could do something similar to the style guide (something @Volker_E and Design has been polishing). That way all our documentation could have a similar design. Creating custom layouts for JSDoc seems pretty straightforward too: https://rebel-sisters.surge.sh/ (WIP). Thanks for introducing me to surge.sh @Jhernandez

Feb 7 2018, 10:04 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
cscott added a comment to T184573: Re-enable documentation for ES6-using classes.

ParsoidConfig.js, WikiConfig.js: https://gerrit.wikimedia.org/r/408375

Feb 7 2018, 10:01 PM · Parsoid
cscott added a comment to T184573: Re-enable documentation for ES6-using classes.

lib/utils/Util.js lib/utils/DOMUtils.js lib/wt2html/parser.defines.js : https://gerrit.wikimedia.org/r/408826

Feb 7 2018, 6:54 PM · Parsoid

Feb 6 2018

cscott added a comment to T186632: Create shortcut/alias for aligned parameter style in TemplateData.

Argument name space-padding is (apparently) considered a discouraged practice on dewiki, if I understand correctly. When a new longer argument name is added, all of the existing arguments need to get spaces added, and that (human-created) dirty diff is frowned upon.

Feb 6 2018, 7:58 PM · TemplateData, User-Ryasmeen, Parsoid, VisualEditor
cscott removed a project from T186632: Create shortcut/alias for aligned parameter style in TemplateData: Patch-For-Review.
Feb 6 2018, 7:55 PM · TemplateData, User-Ryasmeen, Parsoid, VisualEditor
cscott added a comment to T186630: Cannot read property 'length' of null.

Patch at https://gerrit.wikimedia.org/r/408593 -- assuming that the underlying failure in setPageSrc would be properly handled by the caller.

Feb 6 2018, 7:54 PM · Patch-For-Review, Parsoid
cscott added a comment to T186630: Cannot read property 'length' of null.

Yeah, probably -- the code used to be Promise#tap, so it would still have thrown an exception, but that exception would have been ignored.

Feb 6 2018, 7:49 PM · Patch-For-Review, Parsoid
cscott added a comment to T186630: Cannot read property 'length' of null.

Erk, is this my fault w/ 1f89e97a25b5413d90ad36591d0e5766883c5b25 ?

Feb 6 2018, 7:48 PM · Patch-For-Review, Parsoid

Feb 5 2018

cscott added a comment to T184573: Re-enable documentation for ES6-using classes.

One more: TokenTransformManager and friends: https://gerrit.wikimedia.org/r/408342

Feb 5 2018, 9:20 PM · Parsoid
cscott added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

but this is almost good enough to migrate to right now (and re-skin in time).

Could we articulate what needs fixing? @Prtksxna would be willing to submit a patch of what you've done so far? (No matter if it's a little raw :))

The @event naming that I mentioned and the @property documentation that Timo mentioned are I think it.

Feb 5 2018, 6:48 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
cscott added a comment to T184573: Re-enable documentation for ES6-using classes.

Next: Logger-related classes: https://gerrit.wikimedia.org/r/407868

Feb 5 2018, 4:56 PM · Parsoid
cscott added a comment to T179259: Visual Editor removing whitespace from infoboxes by default.

@Alsee in this case, if you had entries which were whitespace aligned, whichever editor put 'format:block' in the templatedata was at fault. Looking at the edit you cited, it appears as if the format should have been:

{{_\n| _____________ = _\n}}\n
Feb 5 2018, 4:44 PM · User-Ryasmeen, Parsoid, VisualEditor

Feb 3 2018

cscott added a comment to T179259: Visual Editor removing whitespace from infoboxes by default.

The parameter reordering issue was addressed (yeay), but the original task here was to stop stripping whitespace. Here's a test edit showing that the problem still exists.

Feb 3 2018, 1:21 AM · User-Ryasmeen, Parsoid, VisualEditor

Feb 2 2018

cscott added a comment to T95473: Interwiki links whose titles contain question marks are not properly escaped in HTML output..

Apparently not fixed yet, according to T186281: titles with trailing question marks aren't properly URL-encoded.

Feb 2 2018, 12:45 AM · Patch-For-Review, Parsoid
cscott added a comment to T186281: titles with trailing question marks aren't properly URL-encoded.

Yes, I think so! Darn it, should have fixed this bug the first time I found it.

Feb 2 2018, 12:44 AM · Patch-For-Review, Parsoid

Feb 1 2018

cscott created T186281: titles with trailing question marks aren't properly URL-encoded.
Feb 1 2018, 11:47 PM · Patch-For-Review, Parsoid
cscott added a comment to T185607: Provide an inline discussion feature, "DiscussThis".

@JMinor: +1 on dogfooding our own software, instead of using google docs and etherpads!

Feb 1 2018, 11:40 PM · VisualEditor-MediaWiki-Plugins, Collaboration-Team-Triage, StructuredDiscussions, TechCom-RFC, VisualEditor
cscott updated subscribers of T186267: Phase out legacy IDs now that HTML5 IDs are deployed everywhere.
Feb 1 2018, 10:04 PM · Technical-Debt, MediaWiki-Parser, Parsing-Team
cscott added a comment to T152540: Migrate to HTML5 section ids.

More followup: T186272: Convert all parser tests to html5 ids

Feb 1 2018, 9:53 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team
cscott added a comment to T186267: Phase out legacy IDs now that HTML5 IDs are deployed everywhere.

Probably the first step is to flip the DefaultSettings.php $wgFragmentMode from ['legacy','html5'] to ['html5','legacy'].

Feb 1 2018, 9:50 PM · Technical-Debt, MediaWiki-Parser, Parsing-Team
cscott created T186272: Convert all parser tests to html5 ids.
Feb 1 2018, 9:46 PM · MediaWiki-Parser
cscott updated subscribers of T186241: Add rel="nofollow" to Parsoid links.
Feb 1 2018, 5:27 PM · Parsoid
cscott added a comment to T186241: Add rel="nofollow" to Parsoid links.

If this is implemented in Parsoid, the Flow code added for T68289: A16. Flow: external links should have rel="nofollow" property can/should be removed.

Feb 1 2018, 5:26 PM · Parsoid
cscott added a comment to T186241: Add rel="nofollow" to Parsoid links.

Repeating a comment from T58756:

I'd *strongly* prefer to see this added as a post-processing pass, instead of directly to the wt2html pass. We should maintain a good discipline about separating out redundant information which is only used for read views or styling, so that (in the future) this can be generated on-demand and we don't waste storage or transmission bandwidth on unnecessary bits.

Feb 1 2018, 5:25 PM · Parsoid
cscott added a comment to T58756: Parsoid doesn't give external links class="external free|text".

Repeating a comment from the patch:

I'd *strongly* prefer to see this added as a post-processing pass, instead of directly to the wt2html pass. We should maintain a good discipline about separating out redundant information which is only used for read views or styling, so that (in the future) this can be generated on-demand and we don't waste storage or transmission bandwidth on unnecessary bits.

Feb 1 2018, 5:20 PM · Patch-For-Review, Parsoid
cscott created T186241: Add rel="nofollow" to Parsoid links.
Feb 1 2018, 5:15 PM · Parsoid

Jan 26 2018

cscott added a comment to T178803: `qsub sync -y` jobs failing on Grid Engine with "range_list containes no elements" error.

Mumble mumble OCG mumble mumble.

Jan 26 2018, 6:59 AM · cloud-services-team (Kanban), Toolforge, Wikisource
cscott added a comment to T57370: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing.

This would be a good use of a general "fork storage" mechanism: the edit-in-progress would get stored as an unmerged fork of the main revision.

Jan 26 2018, 6:55 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Community-Wishlist-Survey-2017, Community-Tech, Front-end-Standards-Group, Epic, VisualEditor-MediaWiki
cscott updated subscribers of T2639: [Epic] Add feature annotate/blame command, to indicate who last changed each line / word.

@tstarling and I are interested in the implementation of this. It would be a good use of the "derived" slots in multicontent revisions. You'd checkpoint the authorship map every N revisions, and store the most recent authorship non-peristently in memcached.

Jan 26 2018, 6:54 AM · Community-Tech, Community-Wishlist-Survey-2017, Wikimedia-Hackathon-2017, Community-Wishlist-Survey-2016, Community-Wishlist-Survey-2015, MediaWiki-History-or-Diffs
cscott added a comment to T134455: Add experimental option for direct SVG output via srcset.

Don't forget that our use of the "lang" feature in SVGs differ from the w3c standard, as implemented by browsers. In addition to blacklisting large SVGs we need to blacklist SVGs using the language selector feature.

Jan 26 2018, 6:48 AM · Patch-For-Review, Commons, MediaWiki-File-management, Wikimedia-SVG-rendering, Multimedia
cscott added a comment to T20231: provide a way to specify what text/statement is supported by a <ref> block..

The parsing team has a proposal for "heredoc arguments" (T114432) which would allow the use of the {{cite}} template to easily enclose a region of text.

Jan 26 2018, 6:43 AM · Cite

Jan 24 2018

cscott added a comment to T185012: WMDS 18: Collect feedback as it comes.

I was a little disappointed that the position papers weren't used more. I understand that the session leaders used the position papers to group sessions and seed the session with topics, but there was a still a lot of oral discussion that just restated points folks have previously made in their position papers.

Jan 24 2018, 6:05 PM · Wikimedia-Developer-Summit (2018)
cscott added a comment to T185012: WMDS 18: Collect feedback as it comes.

The posters at the event called it a "development summit". FWIW. ;)

Jan 24 2018, 6:00 PM · Wikimedia-Developer-Summit (2018)
cscott added a comment to T151327: Explore designs for FileAnnotations.

See also the UX mockup at https://phabricator.wikimedia.org/T146397#3241037

Jan 24 2018, 5:59 PM · Design, Multimedia, FileAnnotations
cscott added a comment to T145458: Editing a file annotation requires very careful mouse movement.

See also the UX mockup at https://phabricator.wikimedia.org/T146397#3241037

Jan 24 2018, 5:59 PM · Structured-Data-Commons, Wikidata, Patch-For-Review, FileAnnotations (Beta Cluster Release), Multimedia
cscott added a comment to T185012: WMDS 18: Collect feedback as it comes.

I'd like to see next steps from the session leaders include some means of publicizing the sessions and result of the sessions to all the folks who couldn't be present, including a means to collect feedback from nonparticipants who may support/object/amend conclusions of the session.

Jan 24 2018, 1:26 AM · Wikimedia-Developer-Summit (2018)

Jan 23 2018

cscott added a comment to T185353: WikiDev'18 Keynote by Toby Negrin.

Can we get the slides from this keynote posted?

Jan 23 2018, 6:35 PM · Wikimedia-Developer-Summit (2018)

Jan 18 2018

cscott updated subscribers of T113004: Make it easy to fork, branch, and merge pages (or more).

Some more notes from a twitter discussion started by @Sj, whose developer summit position statement is strongly related to this task.
@cscott says:

I think that's my cue to pitch T113004 which seeks to incorporate a more GitHub-like fork/merge model in Wikipedia. It would allow contributions to be visible, even when unmerged. (Which has its own issues, of course...)

@Phoebe says:

What is an unmerged contrib? Someone makes an edit, someone takes it out again? Or are you imagining that ppl don't contribute directly to article, they propose a change a la GitHub and others can see that change? Wouldn't that take a huge amount of personhours to approve pulls?
I'm sure ideas about this are in the proposal somewhere but as you know the vast amount of edits are added w/o controversy, so keeping workloads the same or lower would be A+
Ps I'm reading all the stuff about enhancing diffs & edit review screens - that's fantastic. Though I'll keep my "diff to penultimate revision" t-shirt forever, diffing could really use some love <3

@cscott says:

Once the basic infrastructure for forked revisions was in place, you could experiment with lots of merge strategies. Automatically merge after N hrs, say, or merge edits scored as not-vandalism...
I think the least disruptive thing would be to automatically merge, but keep the fork when there is a roll back or merge conflict. You could choose to start a revision as a fork as well, like w/ the draft namespace.
The key psychological breakthrough would be to change first-time editors' experience from "I tried to help and it was reverted and thrown away" to "I tried to help and it wasn't merged yet but there were some helpful suggestions for improvements".

I'll add: the happiness kick you see when your constructive edit is made and immediately goes live on the site is even better! And should definitely be preserved whenever possible. But fork/merge can provide gentler off-ramps other than revert in case of issues with an edit.

Jan 18 2018, 10:12 PM · Community-Wishlist-Survey-2015, Contributors-Team, Wikimedia-Developer-Summit-2016

Jan 11 2018

cscott added a comment to T97225: Consider using preq in parsoid.

Hm, not only does it have a hard dependency on bluebird, it uses bluebird's non-standard methods, so it can't be easily ported to actual standard ES6 promises. :(

Jan 11 2018, 9:58 PM · Parsoid
cscott added a comment to T97225: Consider using preq in parsoid.

Does preq let you use native Promises? We don't use bluebird.

Jan 11 2018, 9:49 PM · Parsoid

Jan 9 2018

cscott committed rELINT174949922f9c: Always return some category name, even if it's just a placeholder (authored by cscott).
Always return some category name, even if it's just a placeholder
Jan 9 2018, 11:48 PM
cscott added a comment to T184573: Re-enable documentation for ES6-using classes.

First up: lib/api/ParsoidService.js: https://gerrit.wikimedia.org/r/402435

Jan 9 2018, 11:26 PM · Parsoid
cscott added parent tasks for T184573: Re-enable documentation for ES6-using classes: T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases, T156469: jsduck doesn't support ES6.
Jan 9 2018, 11:26 PM · Parsoid
cscott added a subtask for T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases: T184573: Re-enable documentation for ES6-using classes.
Jan 9 2018, 11:26 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
cscott added a subtask for T156469: jsduck doesn't support ES6: T184573: Re-enable documentation for ES6-using classes.
Jan 9 2018, 11:26 PM · Documentation, MediaWiki-Documentation
cscott created T184573: Re-enable documentation for ES6-using classes.
Jan 9 2018, 11:25 PM · Parsoid
cscott committed rELINTa5830cf00098: Always return some category name, even if it's just a placeholder (authored by cscott).
Always return some category name, even if it's just a placeholder
Jan 9 2018, 11:20 PM
cscott committed rELINT0d5867719495: Add IPv6 localhost to default whitelist along with IPv4 localhost (authored by cscott).
Add IPv6 localhost to default whitelist along with IPv4 localhost
Jan 9 2018, 11:19 PM
cscott committed rELINTe2f24aed4050: Don't crash RecordLintJob if the lint info doesn't contain `params` (authored by cscott).
Don't crash RecordLintJob if the lint info doesn't contain `params`
Jan 9 2018, 11:19 PM
cscott committed rELINTc019ce50321d: Allow Parsoid to provide category ID hints (authored by cscott).
Allow Parsoid to provide category ID hints
Jan 9 2018, 11:19 PM
cscott committed rELINT43d8c91e9d76: Always return some category name, even if it's just a placeholder (authored by cscott).
Always return some category name, even if it's just a placeholder
Jan 9 2018, 11:13 PM
cscott committed rELINTbbe2d443c653: Don't crash RecordLintJob if the lint info doesn't contain `params` (authored by cscott).
Don't crash RecordLintJob if the lint info doesn't contain `params`
Jan 9 2018, 11:13 PM
cscott committed rELINTfc9dd9dbfbf1: Add IPv6 localhost to default whitelist along with IPv4 localhost (authored by cscott).
Add IPv6 localhost to default whitelist along with IPv4 localhost
Jan 9 2018, 11:13 PM
cscott committed rELINTde9d200fa290: Allow Parsoid to provide category ID hints (authored by cscott).
Allow Parsoid to provide category ID hints
Jan 9 2018, 11:13 PM
cscott committed rELINT45dc792ff478: Allow Parsoid to provide category ID hints (authored by cscott).
Allow Parsoid to provide category ID hints
Jan 9 2018, 8:47 PM

Jan 3 2018

cscott created T184122: MCR refactoring broke tests/parser/parserTests.php.
Jan 3 2018, 9:09 PM · MediaWiki-Parser

Dec 21 2017

cscott added a comment to T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec".

Recapping some discussion in IRC:

Dec 21 2017, 4:09 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Tidy, Community-Liaisons, Parsoid, MediaWiki-Parser

Dec 20 2017

cscott added a watcher for Wikimedia-Developer-Summit (2018): cscott.
Dec 20 2017, 8:55 PM

Dec 19 2017

cscott added a comment to T95931: Parsoid automatically changes pseudo-interlanguage interwiki link text to match link prefix + full target page name.

Context: https://meta.wikimedia.org/wiki/Help:Interwiki_linking#Interlanguage_links

For projects like Meta, a missing leading colon has no effect, because Meta doesn't support interlanguage links. For Wikipedia and similar projects, it is a major difference.

Dec 19 2017, 6:30 PM · Parsoid

Dec 15 2017

cscott added a comment to T102556: VE should indicate when it wants external links "WikiLink-ified".

IMO the examples you give would probably be okay (especially the RFC one), but if editors see [[google:this]] or [[flickr:that]], then they will be surprised and angry.

See https://meta.wikimedia.org/wiki/Talk:Interwiki_map/Archives/2009-04#Google and https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)/Archive_46#Jumbled_up_mess_of_link_types and https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_AF#[[MemoryAlpha:articlename]]_links:_how,_when,_why? for some previous discussions on this point.

Dec 15 2017, 10:09 PM · VisualEditor, Parsoid

Dec 14 2017

cscott claimed T29109: Design a new parser function which runs LanguageConverter::findVariantLink().
Dec 14 2017, 9:19 PM · MediaWiki-extensions-ParserFunctions, Chinese-Sites, MediaWiki-Language-converter
cscott added a project to T114194: MediaWiki should be able to support multiple parser engines: Parsing-Team.
Dec 14 2017, 9:14 PM · Parsing-Team, MediaWiki-Parser, Patch-For-Review, Epic
cscott added a subtask for T43716: Support language variant conversion in Parsoid: T95497: Flow conversion support for all Wikipedias that use multiple writing systems.
Dec 14 2017, 9:12 PM · Patch-For-Review, Epic, MediaWiki-Language-converter, Chinese-Sites, I18n, Parsoid
cscott added a parent task for T95497: Flow conversion support for all Wikipedias that use multiple writing systems: T43716: Support language variant conversion in Parsoid.
Dec 14 2017, 9:12 PM · MediaWiki-Language-converter, Collaboration-Team-Triage, StructuredDiscussions
cscott claimed T11419: Allow Special:Export to work with converted aliases (for Chinese, Kazakh, ...).
Dec 14 2017, 9:09 PM · Chinese-Sites, MediaWiki-Export-or-Import
cscott claimed T160952: Generate Language-converted section anchors/ids.
Dec 14 2017, 9:09 PM · MediaWiki-Language-converter, I18n, Chinese-Sites, MediaWiki-Parser
cscott claimed T53587: Parsoid needs to run findVariantLink or some equivalent thing.
Dec 14 2017, 9:06 PM · Parsoid
cscott added a comment to T152540: Migrate to HTML5 section ids.

See https://bugs.chromium.org/p/chromium/issues/detail?id=789163. The change in Google Chrome behaviour is possible.

Dec 14 2017, 9:03 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team
cscott added a comment to T152540: Migrate to HTML5 section ids.

I wonder if the technology here (invisible <span> tags) could also help with T160952: Generate Language-converted section anchors/ids? Strawman: $wgFragmentMode could include one or more language variant codes along with the special 'html5' and 'legacy' values; similarly something similar to $wgExternalInterwikiFragmentMode (except for internal wikilinks) could select whether the "canonical" ID is used for a wikilink (matching source text) or a language-converted variant is preferred?

Dec 14 2017, 8:54 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team