cscott (C. Scott Ananian)
Parser whisperer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2014, 6:47 PM (195 w, 5 d)
Availability
Available
IRC Nick
cscott
LDAP User
Unknown
MediaWiki User
Cscott [ Global Accounts ]

Editor since 2005; WMF developer since 2013. I work on Parsoid and OCG, and dabble with VE, real-time collaboration, and OOjs.

On github: https://github.com/cscott

See https://en.wikipedia.org/wiki/User:cscott for more.

Recent Activity

Yesterday

cscott added a comment to T58656: Create a new, nice logo for Parsoid.

Teapot is "fun" logo, for team T-shirts. The one @ssastry likes would be the "official" logo, for the wiki, etc. The version with just the brackets and the sunflower (without the word "parsoid") would be appropriate for compact use, for example on the sheet of little hexagon logo stickers that somehow appear at every wikimania/hackathon/allhands.

Sun, Jul 22, 4:55 AM · Design, Parsoid
cscott added a comment to T58656: Create a new, nice logo for Parsoid.

I thought I'd see what it would look like with the stems angled the other way...

Sun, Jul 22, 3:09 AM · Design, Parsoid
cscott created T200142: Create a logo for LanguageConverter.
Sun, Jul 22, 12:45 AM · MediaWiki-Language-converter
cscott updated subscribers of T58656: Create a new, nice logo for Parsoid.

I think @Trevor-at-Wikia probably should get one as well, considering we (ab)used his wordmark.

Sun, Jul 22, 12:40 AM · Design, Parsoid

Sat, Jul 21

cscott added a comment to T58656: Create a new, nice logo for Parsoid.

@Isarra and @cscott think that a purple T-shirt with the terrible teapot on the front, and <parsoid> on the back would be pretty ... "terrible"? In the best sense of the word.

Sat, Jul 21, 11:15 PM · Design, Parsoid
cscott added a comment to T58656: Create a new, nice logo for Parsoid.

I slightly tweaked @Isarra's teapot logo to mash it together with Trevor's logo because, uh, I like slanted stems on my p and d's? So, hey, choices. https://commons.wikimedia.org/wiki/File:Parsoid_terrible_logo.svg

Sat, Jul 21, 11:03 PM · Design, Parsoid
cscott added a comment to T58656: Create a new, nice logo for Parsoid.

For the historical record, @Isarra pointed me at https://commons.wikimedia.org/wiki/File:Parsoid_terrible_logo.svg -- terrible horrible wikitext goes in to the pot, beautiful sparklies come out.

Sat, Jul 21, 10:37 PM · Design, Parsoid

Fri, Jul 20

cscott added a comment to T198970: Epic: Implement SEO improvements suggested by Go Fish Digital.

Z. Z. from Google is at Wikimania. He confirmed they still spider the site at a low rate, but only to check errors (ie sanity check their internal representation against what the site actually displays to keep us honest/validate our parsing/validate their internal pipeline). They use a variety of sources to build their representation, including ores, wikidata, restbase, the recentchanges feed, and direct queries to the action API.

Fri, Jul 20, 8:47 AM · SEO, Epic
cscott created T200057: Separate dumps for Items and Properties.
Fri, Jul 20, 3:47 AM · Wikidata
cscott updated subscribers of T199941: Fatal MWException in Babel: "Language::isValidBuiltInCode must be passed a string" .

There's a patch with a C+1, but it's not merged (waiting for review from @Nikerabbit I think). I'm not sure what "recent change" @Nemo_bis is referring to; if you wanted to revert core patches I think you'd need to revert both I807dd55d49e9bd19443329231326a5b0d3e6c453 and I8468a56d5b88f5786abd0a17b67bda2f1687fd0c (the latter is on top of the former).

Fri, Jul 20, 2:15 AM · Patch-For-Review, Language-Team, Editing-team, Regression, Wikimedia-log-errors, MediaWiki-extensions-Babel
cscott added a comment to T159014: Disambiguator parser tests broken due to parser tests using dummy parser.

I remember when Tim wrote that patch (https://gerrit.wikimedia.org/r/314490). My vague memory is that it was motivated by the difficulty trying to use a parser test to debug the parser. You couldn't set breakpoints or emit sensible logging because every !! article added triggered the parser (to parse the completely-automatically-generated-and-meaningless revision comment), so you'd have to dig through a couple hundred parser invocations before you got to the place where the actual parser test you were interested in was being run.

Fri, Jul 20, 12:05 AM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, MediaWiki-Parser, MediaWiki-extensions-Disambiguator

Thu, Jul 19

cscott committed rJWTH65aba7c9c9c3: Release 0.0.2 (authored by cscott).
Release 0.0.2
Thu, Jul 19, 10:43 PM
cscott committed rJWTH563a0ca88434: Move summary and description closer to method name (authored by Prtksxna).
Move summary and description closer to method name
Thu, Jul 19, 10:43 PM
cscott committed rJWTH38a0f52bec02: Bump version after release. (authored by cscott).
Bump version after release.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH1ffbdea99f79: Make header sticky (authored by Prtksxna).
Make header sticky
Thu, Jul 19, 10:43 PM
cscott committed rJWTHac25fcbc736c: Set .nav--main scroll to auto (authored by Prtksxna).
Set .nav--main scroll to auto
Thu, Jul 19, 10:43 PM
cscott committed rJWTH61cd7bf63d48: Break sentences inside <pre> (authored by Prtksxna).
Break sentences inside <pre>
Thu, Jul 19, 10:43 PM
cscott committed rJWTHca5ce16ec4d4: Make sidebar sticky (authored by Prtksxna).
Make sidebar sticky
Thu, Jul 19, 10:43 PM
cscott committed rJWTHff6f4c241db3: Further tweak to Contribute text. (authored by cscott).
Further tweak to Contribute text.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH192cdd4c6d01: Set constructor toggle to true (authored by Prtksxna).
Set constructor toggle to true
Thu, Jul 19, 10:43 PM
cscott committed rJWTHaa50b2c6d0d4: Add hideSections config (authored by Prtksxna).
Add hideSections config
Thu, Jul 19, 10:43 PM
cscott committed rJWTH17d58e6ae434: Remove table heading styling which was doing more harm than good. (authored by cscott).
Remove table heading styling which was doing more harm than good.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH0eb8d54991af: Make method/member details collapsable. (authored by cscott).
Make method/member details collapsable.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH3581093adf83: Remove "GitHub" from layout (authored by Prtksxna).
Remove "GitHub" from layout
Thu, Jul 19, 10:43 PM
cscott committed rJWTH9fdc7c2712b9: Bump version after release. (authored by cscott).
Bump version after release.
Thu, Jul 19, 10:43 PM
cscott committed rJWTHc658e2986681: Fix flash when using navbox. (authored by cscott).
Fix flash when using navbox.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH15dc998a54f7: Link phab tickets (authored by cscott).
Link phab tickets
Thu, Jul 19, 10:43 PM
cscott committed rJWTH4f8af139b13d: Make highlighting work properly in side nav bar (authored by cscott).
Make highlighting work properly in side nav bar
Thu, Jul 19, 10:43 PM
cscott committed rJWTH58b153aac76f: Import WikimediaUI-Style-Guide as a submodule (authored by cscott).
Import WikimediaUI-Style-Guide as a submodule
Thu, Jul 19, 10:43 PM
cscott committed rJWTH4e85fb870736: Import some styles from the default jsdoc stylesheet. (authored by cscott).
Import some styles from the default jsdoc stylesheet.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH88a32ad6ec74: Allow `~Class` to be a synonym for "Class, in my same module" (authored by cscott).
Allow `~Class` to be a synonym for "Class, in my same module"
Thu, Jul 19, 10:43 PM
cscott committed rJWTH0a1f2ced7b1f: First hacky attempts at fitting content into WMF style guide framework. (authored by cscott).
First hacky attempts at fitting content into WMF style guide framework.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH2a537f8fdb47: Fork the JSDoc3 default template to start the WMF theme. (authored by cscott).
Fork the JSDoc3 default template to start the WMF theme.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH2c547daf8562: Improve linkability. (authored by cscott).
Improve linkability.
Thu, Jul 19, 10:43 PM
cscott committed rJWTH776c637fc86a: Remove unneeded fonts and CSS from default theme. (authored by cscott).
Remove unneeded fonts and CSS from default theme.
Thu, Jul 19, 10:43 PM
cscott added a comment to T198976: Make it easier for google to index anchors on mobile.

Unbreaking section links on mobile would be a good idea. I'm not sure I understand exactly how they are broken, however?

Thu, Jul 19, 2:04 PM · Readers-Web-Backlog, MobileFrontend, Mobile, SEO
cscott added a comment to T3433: Add metainformation for interlanguage links (link rel="alternate" hreflang).

See my comment at https://phabricator.wikimedia.org/T93213#4438137 re interlanguage links generated (or not) by Parsoid (or wikidata).

Thu, Jul 19, 2:00 PM · MediaWiki-Interface
cscott added a comment to T93213: Improve access to local language wikis by fixing bug in generation of hreflang tags in <head> of article pages.

Note that AFAIK google is using Parsoid-format HTML for indexing, not our PHP front end output. Also: they have their own dedicated pipeline for wikipedia content. Not sure that adding hreflang tags to the PHP output will do anything at all. We used to emit interlanguage links in Parsoid output ( https://www.mediawiki.org/wiki/Specs/HTML/1.6.x#Language_links ) but I thing most (all?) of these went away when we switched to using WikiData for interlanguage links.

Thu, Jul 19, 12:59 PM · SEO, Patch-For-Review, MediaWiki-Internationalization, I18n
cscott added a comment to T198970: Epic: Implement SEO improvements suggested by Go Fish Digital.

I believe they still hit our front end for zh.wikipedia.org, because I haven't finished implementing LanguageConverter yet for the Parsoid output. But that is the main reason why finishing LanguageConverter parity is a priority for us, so that Google can stop using their legacy crawler for zhwiki. There might be other corner cases where they still use their spider. You can actually test this directly by searching google for content which appears only in Parsoid format HTML (or in the UX, or in the mobile front end). This was easier to do when Parsoid had more bugs/differences when compared to the PHP parser, so it was easier then to find corner cases that were searchable. But I used to be able to easily verify in this way that the non-Parsoid content was not indexed.

Thu, Jul 19, 12:52 PM · SEO, Epic
cscott added a comment to T198946: Add Schema property 'sameAs' pointing to Wikidata entries.

This property would probably have to be added to the Parsoid-format HTML <head> in order to have any actual effect. But I'm not certain how/whether Google's search pipeline for WMF projects actually does anything with our <head> content. We should probably talk to our contacts at Google first and ask them specifically how to better link wikidata entries.

Thu, Jul 19, 12:48 PM · MediaWiki-extensions-WikibaseClient, Wikidata, SEO
cscott added a comment to T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility.

Google isn't using our mobile content for indexing anyway. They are using the Parsoid-format HTML directly from RESTbase AFAIK.

Thu, Jul 19, 12:46 PM · Readers-Web-Kanbanana-Board, Accessibility, Readers-Web-Backlog, MinervaNeue, Mobile, SEO
cscott added a comment to T198949: Add navbox links to mobile page HTML.

AFAIK google isn't indexing the mobile version of the page, they are indexing Parsoid content. So this should have no effect on SEO for google either way.

Thu, Jul 19, 12:45 PM · Readers-Web-Backlog (Tracking), MobileFrontend, Mobile, SEO
cscott added a comment to T198963: Add "Did you know..." and "On this day" sections from desktop main page to mobile main page.

I agree content shouldn't be stripped. But AFAIK google isn't indexing the mobile version of our site, they are using (unstripped) Parsoid content directly. So this should have no effect on SEO for google, at least.

Thu, Jul 19, 12:44 PM · Readers-Web-Backlog (Tracking), MobileFrontend, Mobile, SEO
cscott added a comment to T198965: Create XML sitemaps so search engine crawlers can crawl more effectively.

(FWIW: a sitemap which listed every article title on our projects would be *huge*. The list of all titles *just on english wikipedia* is 240MB *compressed*. See https://dumps.wikimedia.org/enwiki/20180701/ -- and that 240MB file would have to be rewritten (and re-fetched) every time a new article was created.)

Thu, Jul 19, 12:43 PM · SEO
cscott added a comment to T198965: Create XML sitemaps so search engine crawlers can crawl more effectively.

Google doesn't spider our site, AFAIK. They subscribe to notifications directly from the ChangeProp service AFAIK and fetch Parsoid-format content directly from RESTBase when it changes.

Thu, Jul 19, 12:40 PM · SEO
cscott added a comment to T198969: Ensure links on the mobile version of pages are not to the desktop version.

Can I -1 this suggestion? I often want to share a link from the mobile site with someone. It is extremely annoying to manually edit my pasted URL, and worse still if I forget to edit it and the person I'm sending the link to opens the site on desktop and ends up with the mobile site. On the other hand, if my recipient opens a desktop link while they are on mobile, the link is transparently redirected to desktop --- that's a much nicer failure mode. I don't think the extra redirects are that bad for our users, and I'm almost *certain* they have nothing to do with SEO, since Google is getting our page content directly from Parsoid, and Parsoid doesn't "mobile-ify" any of its hrefs.

Thu, Jul 19, 12:39 PM · Readers-Web-Backlog (Tracking), MobileFrontend, Mobile, SEO
cscott added a comment to T198970: Epic: Implement SEO improvements suggested by Go Fish Digital.

More technically: has anyone informed Go Fish digital that Google isn't actually touching our front end pages at all? They don't spider us any more, AIUI we give them a direct feed of the (Parsoid format HTML) content of our pages and notify them directly whenever page content changes.

Thu, Jul 19, 12:37 PM · SEO, Epic
cscott updated subscribers of T146072: Parsoid DOM spec: Improve Cite representation to support section editing & simpler clients.

Pinging @Catrope, who is working on a similar problem with CX.

Thu, Jul 19, 9:33 AM · Parsoid (Section-Editing-Support), VisualEditor-MediaWiki-References, VisualEditor-MediaWiki, VisualEditor, Cite
cscott added a comment to T199941: Fatal MWException in Babel: "Language::isValidBuiltInCode must be passed a string" .

I'm guessing the problem is with the code nrm, which we use for "Norman French", which used to be mapped in codes.txt to the language "Narom", but is now BCP 47-normalized to nrf (the actual code for norman french) which doesn't exist in codes.txt so is resulting in getCode() returning false. The simplest patch might be to add nrf to codes.txt.

Thu, Jul 19, 8:52 AM · Patch-For-Review, Language-Team, Editing-team, Regression, Wikimedia-log-errors, MediaWiki-extensions-Babel
cscott added a comment to T199941: Fatal MWException in Babel: "Language::isValidBuiltInCode must be passed a string" .

Hm. As far as I can tell, we're falling through the wfDebug(...) in BabelLanguageCodes::getCode( $code ) and returning false. Probably because getCode() is being given a new BCP 47-normalized code which doesn't appear in Babel's codes.txt database?

Thu, Jul 19, 8:39 AM · Patch-For-Review, Language-Team, Editing-team, Regression, Wikimedia-log-errors, MediaWiki-extensions-Babel

Wed, Jul 18

cscott added a comment to T146072: Parsoid DOM spec: Improve Cite representation to support section editing & simpler clients.

WMDE would like to think about citation changes for T100645: Efficient way to refer to different pages of the same work when adding references to an article (#17). I don't know, perhaps we can work together on this?

Wed, Jul 18, 8:37 PM · Parsoid (Section-Editing-Support), VisualEditor-MediaWiki-References, VisualEditor-MediaWiki, VisualEditor, Cite
cscott added a comment to T124840: Section edit preview doesn't let you preview references defined outside the section being previewed.

Just for reference, see also T146072: Parsoid DOM spec: Improve Cite representation to support section editing & simpler clients. It *may* be that we can collaborate on improving the infrastructure for citations to solve both of our problems at once? (/me dreams)

Wed, Jul 18, 8:36 PM · Patch-For-Review, German-Community-Wishlist, TCB-Team, Cite
cscott added a comment to T58656: Create a new, nice logo for Parsoid.

"It's not even valid SGML"

Wed, Jul 18, 5:41 PM · Design, Parsoid
cscott added a comment to T58656: Create a new, nice logo for Parsoid.

@Esanders that's, er, aggressively minimalist?

Wed, Jul 18, 5:11 PM · Design, Parsoid
cscott created T199895: Arabic transliteration in Kazakh and Kurdish.
Wed, Jul 18, 10:45 AM · MediaWiki-Language-converter
cscott added a comment to T58656: Create a new, nice logo for Parsoid.

Ping @Isarra -- I wonder if we could get this task unstuck? The Parsing team needs new T-shirts for our Sept offsite.

Wed, Jul 18, 8:53 AM · Design, Parsoid

Mon, Jul 16

Volker_E awarded T106367: Generate BCP 47 conform language codes for the HTML attribute `lang` a Like token.
Mon, Jul 16, 9:53 AM · Wikidata, Patch-For-Review, MediaWiki-Internationalization

Sat, Jul 14

cscott added a comment to T198214: Deprecate and remove non-remex Tidy modes of the core parser.

It's my todo, not subbu's, but yeah. It's an honor to be mistaken for subbu. ;)

Sat, Jul 14, 2:22 AM · MediaWiki-Parser, Technical-Debt (Deprecation), Patch-For-Review, Tidy, Parsing-Team

Fri, Jul 13

cscott added a comment to T198214: Deprecate and remove non-remex Tidy modes of the core parser.

I'm suggesting step 1 and 2 in 1.31, and 3 either in 1.31 or wait until 1.32.

1.31 was released on June 13, so it's probably too late to get anything into that version.

Fri, Jul 13, 11:29 PM · MediaWiki-Parser, Technical-Debt (Deprecation), Patch-For-Review, Tidy, Parsing-Team
cscott added a comment to T181677: Implement syntax highlight for U+00A0 (no-break space, nbsp).

This seems reasonable: most pages shouldn't have invisible non-breaking spaces anyway, so making them visible shouldn't disturb editors.

Fri, Jul 13, 10:03 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
cscott created T199579: Parsoid fails to round-trip &nbsp; embedded in html comments.
Fri, Jul 13, 9:58 PM · Parsoid
cscott added a comment to T96701: VE silently alters non-breaking spaces into normal spaces.

@cscott Could you please take a look at this: https://en.wikipedia.org/w/index.php?title=Toyota_Land_Cruiser&oldid=prev&diff=720847140

The nbsp was entered in the wikitext editor, in a previous edit. It was removed when an unrelated change was made (on a different line) in the visual editor.

Can you tell me whether the nbsp code was removed by VisualEditor or by Parsoid?

Fri, Jul 13, 9:54 PM · Parsoid, VisualEditor-MediaWiki, VisualEditor
cscott added a comment to T139301: Remove @author lines from code.

FWIW, I agree with @Isarra . The comments are harmless, and freely dispensing credit is part of what makes the open source ecosystem tick. Note https://www.mediawiki.org/wiki/Gerrit/New_repositories#Step_3:_Review_community_expectations :

Credit

Credit for your work being preserved in future versions — including any merged extensions.
  Similarly, you should credit the developers of any extensions whose code you borrow from — especially when performing a merger.
Fri, Jul 13, 8:47 PM · MW-1.30-release-notes, Patch-For-Review, MediaWiki-General-or-Unknown, WMF-Legal, RfC, Developer-Advocacy
cscott added a comment to T198419: send an Accept-Language header and verify it is sending the correct one (iOS).

@Jdforrester-WMF looking more closely, we do special case the Chinese variants. Instead of zh-Hant-HK, we send zh-hk. The same is true for -cn, -tw, -sg, and -mo

Fri, Jul 13, 8:25 PM · Wikipedia-iOS-App-Backlog
cscott added a comment to T117845: Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl.

https://gerrit.wikimedia.org/r/445664 will help ensure that if there are any explicit languageconverter rules on srwiki, they will continue to work after the rename.

Fri, Jul 13, 8:12 PM · Patch-For-Review, MediaWiki-Internationalization, I18n
cscott added a comment to T198419: send an Accept-Language header and verify it is sending the correct one (iOS).

Looks like we might fix this partially in core: https://gerrit.wikimedia.org/r/443687 and https://gerrit.wikimedia.org/r/442200

Fri, Jul 13, 6:26 PM · Wikipedia-iOS-App-Backlog
cscott added a comment to T179229: Decide whether we want the package-lock.json to commit or ignore.

Ah, so Parsoid (a top-level app) including npm-shrinkwrap.json in its repo while domino (a library) including package-lock.json is entirely correct. That way domino developers are protected from unexpected packages, but upstream users of domino are free to chose alternate package resolutions to maximize library sharing.

Fri, Jul 13, 4:13 PM · Services (designing), Front-end-Standards-Group, Continuous-Integration-Infrastructure, MediaWiki-extensions-General
cscott added a comment to T179229: Decide whether we want the package-lock.json to commit or ignore.

FWIW, Parsoid commits the package-lock.json in our repo. With it, we were able to quickly verify that we never deployed a bad eslint-related package in the last compromise, nor would any of our developers inadvertently have done so if they happened to npm install to work on Parsoid at a vulnerable time. I think that's a compelling argument for continuing to use lock files for any "top-level" (deployable) WMF projects. I'd include extensions, services, and standalone apps in this.

Fri, Jul 13, 3:21 PM · Services (designing), Front-end-Standards-Group, Continuous-Integration-Infrastructure, MediaWiki-extensions-General

Wed, Jul 11

cscott added a comment to T199332: PHP Warning: count(): Parameter must be an array or an object that implements Countable in Serializer.php.

Here's the function in question, note the comment at the end:

	public function endTag( Element $element, $sourceStart, $sourceLength ) {
		if ( $element->htmlName === 'head' || $element->isVirtual ) {
			// <head> elements are immortal
			return;
		}
		$self = $element->userData;
		$parent = $this->nodes[$self->parentId];
		$children =& $parent->children;
		for ( $index = count( $children ) - 1; $index >= 0; $index-- ) {
			if ( $children[$index] === $self ) {
				unset( $this->nodes[$self->id] );
				$children[$index] = $this->stringify( $parent, $self );
				return;
			}
		}
		// Ignore requests to end non-existent elements (this happens sometimes)
	}
Wed, Jul 11, 3:18 PM · PHP 7.2 support, RemexHtml
cscott updated subscribers of T199332: PHP Warning: count(): Parameter must be an array or an object that implements Countable in Serializer.php.
Wed, Jul 11, 3:15 PM · PHP 7.2 support, RemexHtml

Tue, Jul 10

cscott created T199245: Session: Doing cool things with Wiki Content (Parsoid power).
Tue, Jul 10, 4:27 PM · Wikimania-Hackathon-2018
cscott updated subscribers of T198988: Note Taking Feedback: Wikimedia Technical Conference .

It would be great if the notes could be further distilled into a blog post or readable discussion summary after the conference. @Sj and I had big plans to do some of this sum-up after the 2017 conference, but we ran out of steam after the conference ended. Perhaps a "writeathon" in the last hour of the conference where everyone participating could divvy up sessions and write up narratives which could be published daily/weekly/whatever on the WMF blog after the summit. (Important is to get at least the first draft done before the summit ends, or else it ends up getting postponed indefinitely and memories fade.)

Tue, Jul 10, 4:19 PM · Wikimedia-Technical-Conference-2018-Organization
cscott created T199238: Session: Languages, Scripts and Variants: LanguageConverter.
Tue, Jul 10, 3:48 PM · Wikimania-Hackathon-2018

Fri, Jul 6

cscott closed T195675: en-rtl listed under other projects on beta.wmflabs.org as Resolved.
Fri, Jul 6, 3:49 PM · Patch-For-Review, Easy, Beta-Cluster-Infrastructure

Thu, Jul 5

cscott created T198887: Request for languageconverter@lists.wikimedia.org.
Thu, Jul 5, 4:59 PM · Operations, Wikimedia-Mailing-lists
cscott added a comment to T133410: Deploy TemplateStyles to WMF production.

As @Anomie noted there, T186965: Output HTML should not contain `<p><style>...</style></p>` is fixed (or will be once the patch is merged) for wikis using Remex but not for ones using Tidy (there a <templatestyles> tag in the middle of a paragraph will break it into two paragraphs), so switching to Remex should be a blocker for deploying TemplateStyles. (Tracking task: T175706: Progressively switch Wikimedia wikis from Tidy to RemexHTML. Search for wgTidyConfig here to see the current state; the ones with a null line still use Tidy.) Swedish and Russian have already switched so this has no immediate impact on plans.

Thu, Jul 5, 4:14 PM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles

Tue, Jul 3

cscott added a comment to T125073: [Story] Replace bad, but currently necessary language codes.

I've got a patch to fix the BCP 47 mappings in core: https://gerrit.wikimedia.org/r/442200

Tue, Jul 3, 2:54 PM · Story, Wikidata

Mon, Jul 2

cscott added a comment to T198214: Deprecate and remove non-remex Tidy modes of the core parser.

@Anomie Exactly. @tstarling did a great job on Remex, and I don't believe performance is (ought to be) a critical issue either. We all win if we can reduce the set of supported modes, especially old features "we all know don't work quite right any more" like the non-tidy modes in the core parser.

Mon, Jul 2, 6:25 PM · MediaWiki-Parser, Technical-Debt (Deprecation), Patch-For-Review, Tidy, Parsing-Team
cscott added a comment to T195675: en-rtl listed under other projects on beta.wmflabs.org.

https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix shows a blank for the name of en_rtlwiki, but
https://en-rtl.wikipedia.beta.wmflabs.org/wiki/Special:SiteMatrix shows the name.

Mon, Jul 2, 6:00 PM · Patch-For-Review, Easy, Beta-Cluster-Infrastructure
cscott added a comment to T195675: en-rtl listed under other projects on beta.wmflabs.org.

Quoting the gerrit comment from MarcoAurelio:

Mon, Jul 2, 5:55 PM · Patch-For-Review, Easy, Beta-Cluster-Infrastructure
cscott added a comment to T198625: MediaWiki core patches fail with: ParserIntegrationTest::testParse with data set "parserTests.txt: -{}- tags within headlines (within html for parserConvert())".

Parsoid doesn't embed the edit hint in the generated HTML, FWIW.

Mon, Jul 2, 5:50 PM · Wikimedia-log-errors (Shared Build Failure), Technical-Debt, Parsing-Team, Continuous-Integration-Infrastructure

Sat, Jun 30

IKhitron awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Love token.
Sat, Jun 30, 4:15 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC

Fri, Jun 29

cscott updated the task description for T125073: [Story] Replace bad, but currently necessary language codes.
Fri, Jun 29, 6:15 PM · Story, Wikidata
cscott added a comment to T125073: [Story] Replace bad, but currently necessary language codes.

roa-tara would more specifically be nap-x-tara, since it is a dialect of Neapolitan.

Fri, Jun 29, 6:02 PM · Story, Wikidata
cscott added a comment to T120847: Use BCP 47 conform language codes for the HTML attribute lang.

There's a patch for proper BCP-47 validity conversion in core: I807dd55d49e9bd19443329231326a5b0d3e6c453

Fri, Jun 29, 4:50 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseView, Wikidata
cscott added a comment to T198421: VE is not loading on Beta Cluster, getting 503s.

Confirmed that Parsoid is on b068bb51d29e294a4f4a875ae829cca8cf314205 in both prod and beta.
beta:

deployment-tin$ curl http://deployment-parsoid09.deployment-prep.eqiad.wmflabs:8000/_version
{"name":"parsoid","version":"0.9.0","sha":"b068bb51d29e294a4f4a875ae829cca8cf314205"}

and prod:

deployment:~$ for wtp in `grep wtp /etc/dsh/group/parsoid`; do echo -n "Querying $wtp: "; curl "http://$wtp:8000/_version"; echo; done;
Querying wtp1025.eqiad.wmnet: {"name":"parsoid","version":"0.9.0","sha":"b068bb51d29e294a4f4a875ae829cca8cf314205"}
[...etc...]
Fri, Jun 29, 3:51 PM · User-Ryasmeen, VisualEditor, Parsoid, Beta-Cluster-Infrastructure
cscott added a comment to T198348: Quibble CI jobs time out after 30min due to instance stalling at "npm install parse" step.

parallel-lint is timing out and failing as well: https://gerrit.wikimedia.org/r/442209

That is a patch for Wikibase which has a lot of php files. parallel-lint with HHVM is slow hence the 350 seconds timeout being reached. Can you fill it as another task please? It is probably missing a COMPOSER_PROCESS_TIMEOUT=600 and ideally we should only lint files that got changed by the patch (which we do for mediawiki/core).

Fri, Jun 29, 3:44 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Upstream, Wikimedia-log-errors (Shared Build Failure), Continuous-Integration-Infrastructure
cscott created T198493: php-lint in wikibase times out.
Fri, Jun 29, 3:42 PM · Jenkins, Wikidata, Continuous-Integration-Infrastructure

Thu, Jun 28

Jdlrobson awarded T112999: Let MediaWiki operate entirely without wikitext a Like token.
Thu, Jun 28, 11:59 PM · Epic, VisualEditor-MediaWiki, VisualEditor, Wikimedia-Developer-Summit-2016
cscott added a comment to T198348: Quibble CI jobs time out after 30min due to instance stalling at "npm install parse" step.

parallel-lint is timing out and failing as well: https://gerrit.wikimedia.org/r/442209

Thu, Jun 28, 8:46 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Upstream, Wikimedia-log-errors (Shared Build Failure), Continuous-Integration-Infrastructure

Tue, Jun 26

cscott added a comment to T198186: VisualEditor should explicitly set Accept-Language.

In order to unblock the current stage of RESTBase work, VE could also just hardcode Accept-Language: en for every request. Then it could land the "correct" patch w/o schedule pressure from RESTBase.

Tue, Jun 26, 5:35 PM · Services (done), MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor-MediaWiki, VisualEditor (Current work), RESTBase-API
cscott added a comment to T198186: VisualEditor should explicitly set Accept-Language.

Even after editing in variants works, we'll want to set accept-language to the user's mediawiki-preferred variant, not necessarily whatever the browser happens to emit. So overriding the browser header is definitely necessary.

Tue, Jun 26, 5:15 PM · Services (done), MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor-MediaWiki, VisualEditor (Current work), RESTBase-API
Krinkle awarded T198214: Deprecate and remove non-remex Tidy modes of the core parser a Orange Medal token.
Tue, Jun 26, 2:15 PM · MediaWiki-Parser, Technical-Debt (Deprecation), Patch-For-Review, Tidy, Parsing-Team
cscott moved T198214: Deprecate and remove non-remex Tidy modes of the core parser from Unsorted to Deprecate / Remove on the Technical-Debt board.
Tue, Jun 26, 1:40 PM · MediaWiki-Parser, Technical-Debt (Deprecation), Patch-For-Review, Tidy, Parsing-Team
cscott created T198214: Deprecate and remove non-remex Tidy modes of the core parser.
Tue, Jun 26, 1:39 PM · MediaWiki-Parser, Technical-Debt (Deprecation), Patch-For-Review, Tidy, Parsing-Team

Mon, Jun 25

cscott created T198138: Disable agent forwarding to important hosts.
Mon, Jun 25, 7:13 PM · Operations, Security
cscott added a comment to T198133: Document deployment-tin.deployment-prep.eqiad.wmflabs.

I created the SSH finger print page, but it ought to be fully-protected by a sysop on wikitech.

Mon, Jun 25, 6:55 PM · Beta-Cluster-Infrastructure
cscott created T198133: Document deployment-tin.deployment-prep.eqiad.wmflabs.
Mon, Jun 25, 6:37 PM · Beta-Cluster-Infrastructure

Jun 22 2018

cscott closed T197702: Parsoid should not set Vary: Content-Type as Resolved.
Jun 22 2018, 10:04 PM · Services (watching), Parsoid
cscott closed T197949: Parsoid dies if trying to transform to not-yet-supported language variant as Resolved.
Jun 22 2018, 10:04 PM · Parsoid, Services (blocked), RESTBase