Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (492 w, 3 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Sat, Mar 16

daniel added a comment to T352899: performer struct fields NULL in event_sanitized.mediawiki_revision_tags_change.

I can't fiogure out what triggered the change in behavior. I made an experimental patch that may address the issue. However, I am not sure it is semantically correct in al lcases.

Sat, Mar 16, 10:45 AM · Patch-For-Review, MW-Interfaces-Team, Product-Analytics, Data-Platform
daniel updated subscribers of T352899: performer struct fields NULL in event_sanitized.mediawiki_revision_tags_change.

The relevant code was refactored by @Ladsgroup in June 2023, but

Sat, Mar 16, 10:18 AM · Patch-For-Review, MW-Interfaces-Team, Product-Analytics, Data-Platform

Thu, Mar 14

daniel added a comment to T305506: Promote or remove experimental MW core API endpoints.

We decided to go ahead and remove the endpoints. We can always bring them back from Git histroy.

Thu, Mar 14, 8:51 AM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform

Wed, Mar 13

daniel added a comment to T359032: mediawiki_job_generatecaptcha maintenance job fails to run.

On T307816: Installing MediaWiki: Error: Class "FormatJson" not found, Tim says: "Maybe something in this file triggers an opcache bug." I don't really have a better idea...

Wed, Mar 13, 1:51 PM · MediaWiki-Engineering, serviceops-radar, Wikimedia-production-error, ConfirmEdit (CAPTCHA extension)
daniel added a comment to T359583: Provide a way to get sampled POST body logs.

I think it would be good to have that for rest.php as well.

Wed, Mar 13, 1:42 PM · MW-Interfaces-Team, Sustainability (Incident Followup), Observability-Logging
daniel added a project to T353199: prop=description does not respect language variants properly: MW-Interfaces-Team.
Wed, Mar 13, 1:30 PM · MW-Interfaces-Team, API Platform, Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-Engineering, Wikipedia-Android-App-Backlog
daniel added a comment to T249745: Could not enqueue jobs: "Unable to deliver all events: 503: Service Unavailable".

It would be good if we could distinguish between "critical" jobs and "not-su-critical" jobs in the code.

Wed, Mar 13, 1:28 PM · MediaWiki-Engineering, Data-Engineering, Unstewarded-production-error, User-brennen, serviceops, WMF-JobQueue, Wikimedia-production-error
daniel moved T356157: Unable to fetch Parsoid HTML from MediaWiki Interfaces team to Content Transform Team on the MediaWiki-Engineering board.
Wed, Mar 13, 1:22 PM · Content-Transform-Team, Essential-Work, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
daniel closed T355375: Removed wgTemporaryParsoidHandlerParserCacheWriteRatio as Resolved.
Wed, Mar 13, 1:18 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MediaWiki-Engineering, Parsoid (Tracking), Patch-For-Review, API Platform (RESTbase Deprecation Roadmap)
daniel reopened T359426: REST: endpoints that return rendered page content should support all content models as "Open".

Reopened pending merging of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1008538

Wed, Mar 13, 1:09 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team, MediaWiki-REST-API, Parsoid, Parsoid-Read-Views
daniel closed T359426: REST: endpoints that return rendered page content should support all content models as Resolved.
Wed, Mar 13, 10:46 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team, MediaWiki-REST-API, Parsoid, Parsoid-Read-Views
daniel closed T331148: Unify the read-views and REST API caches for Parsoid content as Resolved.
Wed, Mar 13, 8:12 AM · Parsoid

Tue, Mar 12

daniel added a comment to T358799: CommunityConfiguration: Switch to generating schemas from PHP classes rather than committing them as JSON files directly.
  • Is it a good idea to use ReflectionSchemaSource directly? Or does Growth need to maintain its own version of the class?
Tue, Mar 12, 1:18 PM · Growth-Team (Sprint 9 (Growth Team)), CommunityConfiguration

Mon, Mar 11

daniel closed T358709: Parser output missing render ID, a subtask of T350538: Move all cache property initialization into ContentRenderer, as Resolved.
Mon, Mar 11, 8:22 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), RESTBase Sunsetting, Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-Parser, MediaWiki-General
daniel closed T358709: Parser output missing render ID as Resolved.
Mon, Mar 11, 8:22 PM · Essential-Work, RESTBase Sunsetting, MediaWiki-Parser
daniel moved T358709: Parser output missing render ID from Unsorted to Doing on the RESTBase Sunsetting board.
Mon, Mar 11, 8:21 PM · Essential-Work, RESTBase Sunsetting, MediaWiki-Parser
daniel created T359880: Allow list-hook-usage.py to operate directly on /wmf-config/extension-list.
Mon, Mar 11, 7:46 PM · MW-Interfaces-Team
daniel created T359807: ReadingLists: Stop using JsonBodyValidator in REST endpoints..
Mon, Mar 11, 11:55 AM · Patch-For-Review, Reading List Service, MW-Interfaces-Team

Fri, Mar 8

daniel added a comment to T359509: REST API calls suddenly all returning 400.

We need a client patch. It's not OK to use lower-case method names.

Fri, Mar 8, 8:56 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API

Thu, Mar 7

daniel added a comment to T359509: REST API calls suddenly all returning 400.

Thank you all for investigating! And sorry for causing a mess...

Thu, Mar 7, 5:03 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API
daniel added a comment to T359509: REST API calls suddenly all returning 400.

Body is null in both, the only difference I see that the underlying library gzips the lowercase version but doesn't gzip the uppercase version.

Thu, Mar 7, 3:28 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API
daniel added a comment to T359509: REST API calls suddenly all returning 400.

I put the patch in mwdebug2001 and tested it and it doesn't fix it. We need to find a way to test this.

Thu, Mar 7, 3:27 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API
daniel added a comment to T359509: REST API calls suddenly all returning 400.

If someone gives me an example of a failure url (the one on the description works now, I guess rollback?) I can try.

Thu, Mar 7, 3:10 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API
daniel added a comment to T359509: REST API calls suddenly all returning 400.

@jnuche Can you try this one? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1009542

Thu, Mar 7, 2:31 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team-WIP, Patch-For-Review, RESTBase-API
daniel added a comment to T353859: Parsoid errors not fully propagated to VisualEditor errors.

@daniel my main doubt now is if this falls into the bucket "should be maintained by teams that own the endpoint" or if it's a "core" change that should be tagged to MediaWiki-Platform-Team, what's your opinion on that?

Thu, Mar 7, 11:11 AM · MediaWiki-REST-API, Parsoid (Tracking), VisualEditor
daniel added a comment to T353859: Parsoid errors not fully propagated to VisualEditor errors.

Logging code is on all servers now, but I'm not seeing anything in the HtmlOutputRendererHelper channel so far.

Thu, Mar 7, 10:53 AM · MediaWiki-REST-API, Parsoid (Tracking), VisualEditor
daniel added a comment to T356157: Unable to fetch Parsoid HTML.

Logging code is on all servers now, but I'm not seeing anything in the HtmlOutputRendererHelper channel so far.

Thu, Mar 7, 10:53 AM · Content-Transform-Team, Essential-Work, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor

Wed, Mar 6

daniel triaged T359426: REST: endpoints that return rendered page content should support all content models as Medium priority.
Wed, Mar 6, 5:20 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team, MediaWiki-REST-API, Parsoid, Parsoid-Read-Views
daniel claimed T359426: REST: endpoints that return rendered page content should support all content models.
Wed, Mar 6, 5:19 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team, MediaWiki-REST-API, Parsoid, Parsoid-Read-Views
daniel added a project to T359426: REST: endpoints that return rendered page content should support all content models: MW-Interfaces-Team.
Wed, Mar 6, 5:18 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team, MediaWiki-REST-API, Parsoid, Parsoid-Read-Views
daniel created T359426: REST: endpoints that return rendered page content should support all content models.
Wed, Mar 6, 5:17 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-Interfaces-Team, Content-Transform-Team, MediaWiki-REST-API, Parsoid, Parsoid-Read-Views
daniel added a comment to T359306: PCS is raising errors related to the request method when querying rest.php.

I'm still confused about the actual error though. The error message is triggered in a conditional block starting with if ( in_array( $requestMethod, RequestInterface::NO_BODY_METHODS ) ). NO_BODY_METHODS is defined as public const NO_BODY_METHODS = [ 'GET', 'HEAD' ]. So if the client sends "get", that shouldn't match...

Wed, Mar 6, 12:18 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Page Content Service, Content-Transform-Team-WIP
daniel added a comment to T359306: PCS is raising errors related to the request method when querying rest.php.

FWIW it used to work before in our test suite so there must be a change meanwhile that caused this issue.
From Jenkins, the last successful run was on Feb 26.

Wed, Mar 6, 12:12 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Page Content Service, Content-Transform-Team-WIP
daniel added a comment to T359306: PCS is raising errors related to the request method when querying rest.php.

I didn't realize that lower case method names are actually a violation of the HTTP spec: https://stackoverflow.com/questions/10766221/is-serverrequest-method-guaranteed-to-be-uppercase

Wed, Mar 6, 12:05 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Page Content Service, Content-Transform-Team-WIP
daniel added a comment to T359306: PCS is raising errors related to the request method when querying rest.php.

Oh, that shouldn't be needed. The framework should normalized that. I'll make a fix.

Wed, Mar 6, 12:03 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Page Content Service, Content-Transform-Team-WIP

Tue, Mar 5

daniel added a comment to T358956: Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing.

I can't replicate on my system. Are you running this in an odd environment?

Tue, Mar 5, 7:56 PM · Upstream, MediaWiki-Codesniffer
daniel added a comment to T354439: 1.42.0-wmf.21 deployment blockers.

Potential blocker: T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json. This issue may affect other extensions in production. There is a fix for review on the ticket.

Tue, Mar 5, 12:36 PM · Release-Engineering-Team (Now this 🫠), Release, Train Deployments
daniel added a comment to T359149: Wikibase apitests broken in CI: Unsupported Content-Type: application/json-patch+json.

Working on a fix

Tue, Mar 5, 12:16 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-REST-API, ci-test-error (WMF-deployed Build Failure), Wikidata

Mon, Mar 4

daniel renamed T358956: Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing from PhpStorm complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing to Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing.
Mon, Mar 4, 8:05 PM · Upstream, MediaWiki-Codesniffer
daniel added a comment to T358956: Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing.

I have the same problem on the command line:

Mon, Mar 4, 8:01 PM · Upstream, MediaWiki-Codesniffer
daniel updated the task description for T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.
Mon, Mar 4, 7:06 PM · API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel updated the task description for T353689: REST HTML endpoint returning 500 for JSON page.
Mon, Mar 4, 7:01 PM · Content-Transform-Team-WIP, Parsoid (Tracking), RESTBase Sunsetting, API Platform, MediaWiki-REST-API
daniel added a comment to T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.

I can't reproduce this locally anymore. But it still happens in production.

Mon, Mar 4, 6:56 PM · API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel added a comment to T353689: REST HTML endpoint returning 500 for JSON page.

I can't reproduce this locally.

Mon, Mar 4, 6:55 PM · Content-Transform-Team-WIP, Parsoid (Tracking), RESTBase Sunsetting, API Platform, MediaWiki-REST-API
daniel triaged T358850: Rest: make getValidatedBody return body parameters as Medium priority.
Mon, Mar 4, 10:10 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel moved T358850: Rest: make getValidatedBody return body parameters from Incoming (Needs Triage) to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
Mon, Mar 4, 10:09 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MW-Interfaces-Team, API Platform, MediaWiki-REST-API

Fri, Mar 1

daniel updated the task description for T354216: Create a base class to use in all web entry points.
Fri, Mar 1, 12:07 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-General
daniel added a parent task for T358558: Rest ParamValidator should support validation of fields in the request body: T358850: Rest: make getValidatedBody return body parameters.
Fri, Mar 1, 11:13 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a subtask for T358850: Rest: make getValidatedBody return body parameters: T358558: Rest ParamValidator should support validation of fields in the request body.
Fri, Mar 1, 11:13 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel created T358850: Rest: make getValidatedBody return body parameters.
Fri, Mar 1, 11:13 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel updated the task description for T358560: Rest: Replace BodyValidator with JSON schema based validation.
Fri, Mar 1, 10:57 AM · MW-Interfaces-Team, API Platform, MediaWiki-REST-API

Thu, Feb 29

daniel triaged T313731: Long term plan for reducing maintenance workload on the Search Platform team of supporting APIFeatureUsage as Medium priority.
Thu, Feb 29, 4:47 PM · MW-Interfaces-Team, ApiFeatureUsage, Platform Engineering, Discovery-Search
daniel triaged T358745: Improve error localization in REST handlers as Low priority.
Thu, Feb 29, 4:47 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, RESTBase-API
daniel moved T358745: Improve error localization in REST handlers from Incoming (Needs Triage) to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
Thu, Feb 29, 4:47 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, RESTBase-API
daniel triaged T355956: Add support for skins to list-hook-usage.py as Low priority.
Thu, Feb 29, 4:47 PM · Utilities-code-utils, MediaWiki-Core-Hooks, MW-Interfaces-Team
daniel triaged T358557: Rest router should provide parsed body data to handler. as Medium priority.
Thu, Feb 29, 4:46 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel triaged T348494: Reading List REST Interface: remove Action API endpoints as Low priority.
Thu, Feb 29, 4:46 PM · MW-Interfaces-Team, API Platform, MediaWiki-extensions-ReadingList, Reading List Service, RESTBase Sunsetting
daniel triaged T348136: Error: Class 'MediaWiki\HookContainer\HookRunner' not found as High priority.
Thu, Feb 29, 4:45 PM · MW-Interfaces-Team, API Platform, MediaWiki-Core-Hooks, Wikimedia-production-error
daniel triaged T358558: Rest ParamValidator should support validation of fields in the request body as Medium priority.
Thu, Feb 29, 4:45 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel triaged T305973: JsonBodyValidator does not validate the parameter types as Medium priority.
Thu, Feb 29, 4:45 PM · MW-Interfaces-Team, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), API Platform, MediaWiki-REST-API
daniel claimed T305973: JsonBodyValidator does not validate the parameter types.
Thu, Feb 29, 4:44 PM · MW-Interfaces-Team, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), API Platform, MediaWiki-REST-API
daniel assigned T358557: Rest router should provide parsed body data to handler. to codebug.
Thu, Feb 29, 4:44 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel closed T357025: Add getParsedBody to RequestInterface in the REST framework, a subtask of T305973: JsonBodyValidator does not validate the parameter types, as Resolved.
Thu, Feb 29, 4:26 PM · MW-Interfaces-Team, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), API Platform, MediaWiki-REST-API
daniel closed T357025: Add getParsedBody to RequestInterface in the REST framework, a subtask of T358557: Rest router should provide parsed body data to handler., as Resolved.
Thu, Feb 29, 4:25 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel closed T357025: Add getParsedBody to RequestInterface in the REST framework, a subtask of T358558: Rest ParamValidator should support validation of fields in the request body, as Resolved.
Thu, Feb 29, 4:25 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel closed T357025: Add getParsedBody to RequestInterface in the REST framework, a subtask of T358560: Rest: Replace BodyValidator with JSON schema based validation, as Resolved.
Thu, Feb 29, 4:25 PM · MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel closed T357025: Add getParsedBody to RequestInterface in the REST framework as Resolved.
Thu, Feb 29, 4:25 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel moved T357025: Add getParsedBody to RequestInterface in the REST framework from In Progress to Done on the MW-Interfaces-Team board.
Thu, Feb 29, 4:25 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel moved T358558: Rest ParamValidator should support validation of fields in the request body from Incoming (Needs Triage) to In Progress on the MW-Interfaces-Team board.
Thu, Feb 29, 4:25 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel moved T358557: Rest router should provide parsed body data to handler. from Incoming (Needs Triage) to In Progress on the MW-Interfaces-Team board.
Thu, Feb 29, 4:24 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel moved T305973: JsonBodyValidator does not validate the parameter types from Backlog (Triaged and Ready) to In Progress on the MW-Interfaces-Team board.
Thu, Feb 29, 4:23 PM · MW-Interfaces-Team, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), API Platform, MediaWiki-REST-API
daniel closed T339866: Remove TemporaryParsoidHandlerParserCacheWriteRatio setting from MediaWiki as Resolved.
Thu, Feb 29, 4:18 PM · Parsoid (Tracking), RESTBase Sunsetting, Code-Health
daniel closed T339866: Remove TemporaryParsoidHandlerParserCacheWriteRatio setting from MediaWiki, a subtask of T262315: <CORE TECHNOLOGY> API Migration & RESTbase Sunset, as Resolved.
Thu, Feb 29, 4:18 PM · API Platform (RESTbase Deprecation Roadmap), Epic, Foundational Technology Requests, Code-Health, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel closed T346765: Control ParserCache use per namespace, based on parse time and output size. as Resolved.
Thu, Feb 29, 4:17 PM · MediaWiki-Parser, Parsoid (Tracking), RESTBase Sunsetting
daniel closed T346765: Control ParserCache use per namespace, based on parse time and output size., a subtask of T339866: Remove TemporaryParsoidHandlerParserCacheWriteRatio setting from MediaWiki, as Resolved.
Thu, Feb 29, 4:17 PM · Parsoid (Tracking), RESTBase Sunsetting, Code-Health
daniel created T358745: Improve error localization in REST handlers.
Thu, Feb 29, 9:56 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, RESTBase-API

Tue, Feb 27

daniel updated the task description for T358558: Rest ParamValidator should support validation of fields in the request body.
Tue, Feb 27, 7:30 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a comment to T356157: Unable to fetch Parsoid HTML.

Made a couple of improvements to loggign and error reporting. That will hopefully give us more to work with. Once the patches are deployed, we should see these errors pop up in the HtmlOutputRendererHelper error.

Tue, Feb 27, 6:14 PM · Content-Transform-Team, Essential-Work, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
daniel updated the task description for T305973: JsonBodyValidator does not validate the parameter types.
Tue, Feb 27, 10:13 AM · MW-Interfaces-Team, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), API Platform, MediaWiki-REST-API
daniel updated the task description for T358557: Rest router should provide parsed body data to handler..
Tue, Feb 27, 9:59 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel updated the task description for T358557: Rest router should provide parsed body data to handler..
Tue, Feb 27, 9:55 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a comment to T353000: QA MathML rendering.

Thinking about text browsers, I just realized that using MathML natively should be a huge improvement for screen readers. Do we know how well they support MathML? I just skimmed https://w3c.github.io/mathml-docs/gap-analysis/

Tue, Feb 27, 9:52 AM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4), Math, Mathoid, RESTBase Sunsetting
daniel added a comment to T357025: Add getParsedBody to RequestInterface in the REST framework.

I filed new tickets for parts of this, see T358557: Rest router should provide parsed body data to handler. and T358558: Rest ParamValidator should support validation of fields in the request body.

Tue, Feb 27, 9:24 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel added a parent task for T357025: Add getParsedBody to RequestInterface in the REST framework: T358560: Rest: Replace BodyValidator with JSON schema based validation.
Tue, Feb 27, 9:21 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel added a parent task for T358558: Rest ParamValidator should support validation of fields in the request body: T358560: Rest: Replace BodyValidator with JSON schema based validation.
Tue, Feb 27, 9:21 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added subtasks for T358560: Rest: Replace BodyValidator with JSON schema based validation: T357025: Add getParsedBody to RequestInterface in the REST framework, T358558: Rest ParamValidator should support validation of fields in the request body.
Tue, Feb 27, 9:21 AM · MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel removed a project from T358560: Rest: Replace BodyValidator with JSON schema based validation: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).
Tue, Feb 27, 9:20 AM · MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel created T358560: Rest: Replace BodyValidator with JSON schema based validation.
Tue, Feb 27, 9:20 AM · MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a parent task for T357025: Add getParsedBody to RequestInterface in the REST framework: T358558: Rest ParamValidator should support validation of fields in the request body.
Tue, Feb 27, 9:04 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel added a subtask for T358558: Rest ParamValidator should support validation of fields in the request body: T357025: Add getParsedBody to RequestInterface in the REST framework.
Tue, Feb 27, 9:04 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel created T358558: Rest ParamValidator should support validation of fields in the request body.
Tue, Feb 27, 9:04 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a parent task for T357025: Add getParsedBody to RequestInterface in the REST framework: T358557: Rest router should provide parsed body data to handler..
Tue, Feb 27, 8:59 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel added a subtask for T358557: Rest router should provide parsed body data to handler.: T357025: Add getParsedBody to RequestInterface in the REST framework.
Tue, Feb 27, 8:59 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel removed a subtask for T357025: Add getParsedBody to RequestInterface in the REST framework: T358557: Rest router should provide parsed body data to handler..
Tue, Feb 27, 8:59 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel removed a parent task for T358557: Rest router should provide parsed body data to handler.: T357025: Add getParsedBody to RequestInterface in the REST framework.
Tue, Feb 27, 8:59 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a subtask for T357025: Add getParsedBody to RequestInterface in the REST framework: T358557: Rest router should provide parsed body data to handler..
Tue, Feb 27, 8:59 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-Interfaces-Team, MediaWiki-REST-API
daniel added a parent task for T358557: Rest router should provide parsed body data to handler.: T357025: Add getParsedBody to RequestInterface in the REST framework.
Tue, Feb 27, 8:59 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel created T358557: Rest router should provide parsed body data to handler..
Tue, Feb 27, 8:58 AM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-Interfaces-Team, API Platform, MediaWiki-REST-API
daniel added a comment to T358492: Clarify current status and future directions for Status and StatusValue classes.

I think having fatals and warnings is useful and reasonable. What seems confusing now is that we have kind-of-three levels of errors, one of which is confusingly called an "error" type error:

Tue, Feb 27, 8:52 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-General

Mon, Feb 26

daniel added a comment to T358492: Clarify current status and future directions for Status and StatusValue classes.

Which comment by @Tgr?

This one (I hope the link works, Gerrit isn’t great at linking to comments. The one from 11:24 UTC).

Mon, Feb 26, 6:53 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-General