Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (241 w, 1 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Fri, May 24

daniel added a comment to T212482: Evolve hook system to support "filters" and "actions" only.

@daniel Given a filter only mutating one value (previously written as "taking one parameter", we since then loosened it up to allow any number of parameters, but only one of which should be mutated by the hook), this could also be solved by using the return value.

Fri, May 24, 5:55 PM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom
daniel closed T221089: Phester: Support regular expression based value matching as Resolved.

This seems to be done

Fri, May 24, 5:39 PM · Core Platform Team Backlog (Next), Core Platform Team (Code Health (TEC13))
daniel closed T221089: Phester: Support regular expression based value matching, a subtask of T219879: Create a test runner for end-to-end API tests (Phester), as Resolved.
Fri, May 24, 5:39 PM · Epic, Code-Health, Core Platform Team (Code Health (TEC13))
daniel added a comment to T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.

SlotRoleRegistry (rMW023fec5d7b3a1a4b57d7bd3c555eeb06fd6bae22) already uses the registry-as-a-lazy-factory-with-DI approach: it gets a bunch of callables injected. For REST Router it seems we are going to use a similar approach, with injecting the name of a JSON file which contains object declarations for use with ObjectFactory.

Fri, May 24, 5:00 PM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Later), MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt
daniel added a comment to T221177: REST route handler extension interface RFC.

Can we agree for now that the rest routing should live in libs OR a separate repo, and nothing under the Wikimedia/REST namespace (or whatever we may end up using) should depend on anything that is not itself a library (either a real composer component, or a pseudo-library in libs)?

There is no harm in putting it in libs, and IMO we should be conscious about dependencies and avoid them were possible, but if using Message or Hooks seems to be the sane thing somewhere, I don't think we should go out of our way to avoid it just because those haven't been librarized yet.

Fri, May 24, 1:48 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
daniel added a comment to T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope.

So, we have a potential fix, but it doesn't seem to work with wikibase? Does the wikidata team know?

Fri, May 24, 12:32 PM · Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error
daniel added a comment to T223933: Database error when moving pages: LinksUpdate::updateCategoryCounts does not have outer scope..

Maybe this will fix the issue? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/497537

Fri, May 24, 12:28 PM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team, Wikimedia-production-error, MediaWiki-Database, User-DannyS712
daniel added a comment to T221177: REST route handler extension interface RFC.

@Tgr I see your point, and I share your concern about the annoying procedures for a version bump.

Fri, May 24, 12:23 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
daniel added a comment to T223239: REST API Parameter Validation.

I like @Anomie's proposal a lot. Some minor points:

Fri, May 24, 12:04 PM · MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
daniel added a comment to T224224: [GrowthExperiments] Sessions are disabled for this entry point.

Here be dragons indeed. It's very hard to know what will eventually rely on a session. For example I have seen the same error in ResourceLoaderProjectIconsModule which works fine, until a file it references is not found, in which case code deep in the trace is trying to generate error messages... in user language.

In this case any hook which would have caused the $userLang parameter to unstub would have caused this. It just happens always and consistently now.

Fri, May 24, 11:32 AM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
daniel closed T222827: WMHack19: TechCom office hour, live edition as Resolved.

The session took place.

Fri, May 24, 11:29 AM · Wikimedia-Hackathon-2019, TechCom
daniel closed T222825: WMHack19: Avoiding cyclic dependencies as Resolved.

Follow-ups:

Fri, May 24, 11:22 AM · Wikimedia-Hackathon-2019
daniel closed T223724: Ruprecht: measure LoC in tangels. as Resolved.
Fri, May 24, 11:20 AM · Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel added a comment to T202094: Deprecate Title::getUserCaseDBKey().

@daniel asked me about this, following a complaint in CR from @Simetrical that the function was deprecated despite its usage not having significantly changed since it was introduced, without apparent awareness of what it is for. The idea is that if you have a remote file repository hosted on a wiki with $wgCapitalLinks=false, or a remote file repository that is not a MediaWiki instance, then [[File:foo.jpg]] and [[File:Foo.jpg]] may refer to two different files. So to know which one was intended, you have to get the link text before it was mangled by ucfirst().

Fri, May 24, 7:39 AM · Core Platform Team Backlog (Watching / External), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Thu, May 23

daniel added a comment to T212521: RFC: Let's stop running QUnit unit tests as integration tests.

If moving the integration tests out of QUnit means moving them to Selenium, then I'm not in favor if this RFC as is,

The proposal is to keep the existing setup, but migrate tests which are not actually needed as integration tests to a quicker isolated build.

Thu, May 23, 6:59 AM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
daniel added a comment to T223646: Create a policy on importing global classes.

My personal take is that it would be silly to forbid global classes from being imported via use, thus requiring the leading backslash.

Thu, May 23, 6:56 AM · MediaWiki-Codesniffer, Code-Health

Wed, May 22

daniel added a comment to T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.

Change 511979 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make userLink() not fail too hard on false and null.

https://gerrit.wikimedia.org/r/511979

Wed, May 22, 8:16 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
daniel updated subscribers of T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.

Pinging @matthiasmullie, because he last touched the relevant code in Flow.

Wed, May 22, 8:16 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
daniel reopened T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty as "Open".

This is not the same as T222628, which is about a problem in Linker::formatAutocomments. This here is about a problem with Linker::userLink, which needs a different fix. Both were triggered by the same change, b6e1e99bec8d -- but while the code in formatAutocomments was actually wrong, the problem here seems to be different. The error is triggered in line 915 of Linker, which has:

Wed, May 22, 8:07 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
daniel added a comment to T222628: Some history views and diffs unavailable on Wikipedias (Fatal ParameterAssertionException: Bad value for parameter $dbkey).

There are various code path from extensions or mediawiki/core that ends up hitting the error. It has been added in mediawiki/core by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/504000/

Wed, May 22, 7:55 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), User-notice, MediaWiki-Comment-backend, MediaWiki-History-and-Diffs, Wikimedia-production-error
zeljkofilipin awarded T219883: Draft file format for phester test definitions a Burninate token.
Wed, May 22, 6:26 PM · Core Platform Team Kanban (Doing), Core Platform Team (Code Health (TEC13))
daniel updated the task description for T224165: Don't pass Config object to service constructors.
Wed, May 22, 6:22 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-ServiceContainer, Core Platform Team (Decoupling (CDP2))
daniel created T224165: Don't pass Config object to service constructors.
Wed, May 22, 6:12 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-ServiceContainer, Core Platform Team (Decoupling (CDP2))
daniel created T224107: Ruprecht: investigate visualization of dependency graph.
Wed, May 22, 10:59 AM · Core Platform Team (Decoupling (CDP2))
daniel committed rMTDA969d47bee9ea: Account for LoC weight in stats. (authored by daniel).
Account for LoC weight in stats.
Wed, May 22, 10:52 AM
daniel closed T222598: NamespaceInfo::getRestrictionLevels() does not correctly handle namespace restrictions that require more than one permission as Resolved.
Wed, May 22, 10:10 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Security-Team, MediaWiki-Page-protection, MediaWiki-User-management, Patch-For-Review, MediaWiki-General-or-Unknown
daniel added a comment to T223933: Database error when moving pages: LinksUpdate::updateCategoryCounts does not have outer scope..

This looks similar at a glance: T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope

Wed, May 22, 9:13 AM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team, Wikimedia-production-error, MediaWiki-Database, User-DannyS712

Tue, May 21

daniel updated the task description for T223726: Ruprecht: Investigate filtering dependencies by Connascence.
Tue, May 21, 5:09 PM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel added a comment to T220493: Xml stubs dumps are running 5 to 15x slower than previously.

Hm, my experimental patch makes CI tests time out. I must have broken something, but I really don't see what. Running the "relevant" tests locally, everything seems to be doing fine.

Tue, May 21, 2:06 PM · Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-General-or-Unknown, Dumps-Generation
daniel added a project to T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap: Core Platform Team (Cross-Wiki (CDP2)).
Tue, May 21, 2:05 PM · Core Platform Team (Cross-Wiki (CDP2)), Wikidata-Ministry-Of-Magic-Tech-Debt, TechCom-RFC, User-Daniel, Proposal, MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)), MW-1.27-release-notes, MediaWiki-Interwiki, Wikidata, MediaWiki-Sites, SiteMatrix, MediaWiki-extensions-Interwiki
daniel created T224020: Create a class to represent the identity of wikis on the same wiki farm.
Tue, May 21, 2:01 PM · Proposal, MediaWiki-General-or-Unknown, MediaWiki-Farmers, User-Daniel, Core Platform Team (Cross-Wiki (CDP2))
daniel added a comment to T222907: Determine if per-request TTLs are needed.

FYI, I think CentralAuth needs a TTL different to that of regular sessions (IIRC, this was cited as a reason for exposing the TTL). Regardless of whether or not this is true, we should probably consider using a different instance of the service for CentralAuth (it's trivial to do). If we do, we can configure it with a different default TTL as well.

Tue, May 21, 1:20 PM · Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))
daniel edited projects for T223294: Deprecate the $mRights field in the User class, replacing it with a cache in PermissionManager., added: Core Platform Team Kanban (Contractor - Doing); removed Core Platform Team Backlog (Next).
Tue, May 21, 1:05 PM · Core Platform Team Kanban (Contractor - Doing), Patch-For-Review, Core Platform Team (Decoupling (CDP2))
daniel committed rMTDA70f015ab7e91: Account for LoC weight in stats. (authored by daniel).
Account for LoC weight in stats.
Tue, May 21, 1:00 PM
daniel edited projects for T223724: Ruprecht: measure LoC in tangels. , added: Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Doing); removed Core Platform Team.
Tue, May 21, 12:55 PM · Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel updated the task description for T223726: Ruprecht: Investigate filtering dependencies by Connascence.
Tue, May 21, 12:51 PM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel claimed T220493: Xml stubs dumps are running 5 to 15x slower than previously.
Tue, May 21, 12:45 PM · Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-General-or-Unknown, Dumps-Generation
daniel claimed T222628: Some history views and diffs unavailable on Wikipedias (Fatal ParameterAssertionException: Bad value for parameter $dbkey).
Tue, May 21, 10:30 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), User-notice, MediaWiki-Comment-backend, MediaWiki-History-and-Diffs, Wikimedia-production-error
daniel committed rMTDAb7590ef1f36f: Account for LoC weight in stats. (authored by daniel).
Account for LoC weight in stats.
Tue, May 21, 8:21 AM
daniel edited projects for T212284: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki'), added: Core Platform Team; removed Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)).

Flagging for re-triage in the CPT team. I personally don't know where to start with investigating this, but perhaps @amonie or @tstarling would know. The performance team has a lot of log wrangling expertise, so perhaps we could team up for the investigation.

Tue, May 21, 8:12 AM · Patch-For-Review, Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team (Radar), Services (next), MediaWiki-Database, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
daniel added a comment to T221177: REST route handler extension interface RFC.

This was perhaps discussed elsewhere (and I'm simply not aware of it), but the ticket and its discussion seem to be based on the (unspoken) assumption that modules/extensions have to be able to register their own REST API paths and end points independently, much in the way the Action API currently works.

That's because they do, unless you're wanting to force every site administrator to configure the router endpoints manually for every extension they install.

Tue, May 21, 8:05 AM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
daniel added a comment to T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed..

Expectations of MediaWiki 'Main stash' are (as documented in ObjectCache.php):

  • Stored in primary DC.
  • Replicated to other DCs.
Tue, May 21, 7:51 AM · User-mobrovac, Services (doing), User-jijiki, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team (Radar), Operations, MediaWiki-Cache, serviceops

Mon, May 20

daniel added a comment to T220493: Xml stubs dumps are running 5 to 15x slower than previously.

@daniel Any new information that we'll have for slots/content that we need to include, besides length, content model/stuff, and sha1?

Mon, May 20, 4:12 PM · Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-General-or-Unknown, Dumps-Generation
daniel added a comment to T220493: Xml stubs dumps are running 5 to 15x slower than previously.

@Anomie while you're here, do you know if there are further plans to move fields out of the revision table in the short/near term or otherwise to refactor its schema?

Mon, May 20, 4:06 PM · Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-General-or-Unknown, Dumps-Generation
daniel added a comment to T220493: Xml stubs dumps are running 5 to 15x slower than previously.

Please have a look at the WIP patch linked above. My approach there is to join in the slots and content tables directly instead of doing a second query for each batch to fetch them. The code would not have to change much to adopt that approach, though.

Mon, May 20, 4:01 PM · Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-General-or-Unknown, Dumps-Generation
daniel added a comment to T223447: AbuseFilter log error on fiwiki: /srv/mediawiki/php-1.34.0-wmf.5/includes/Revision.php:639 Call to a member function getId() on a non-object (null).

Have you seen T187153? If it's the same issue (and I think it is), mRecord is null because there's a Revision object serialized and stuffed into the DB which could be 10 years old now, it's pretty obvious that unserializing and using it is not going to work...

Mon, May 20, 3:28 PM · User-Daimona, AbuseFilter, Wikimedia-production-error
daniel added a comment to T223447: AbuseFilter log error on fiwiki: /srv/mediawiki/php-1.34.0-wmf.5/includes/Revision.php:639 Call to a member function getId() on a non-object (null).

And mRecord is null somehow :-(

Mon, May 20, 3:17 PM · User-Daimona, AbuseFilter, Wikimedia-production-error

Sun, May 19

daniel added a comment to T223099: Factor code for handling for options (preferences) out of User class.

In the current state, memcache entries for User instances include their configured preferences as an array. Should this be kept for B/C during the refactor?

Sun, May 19, 10:45 AM · Wikimedia-Hackathon-2019, Patch-For-Review, Core Platform Team Kanban (Contractor - Ready), Core Platform Team (Decoupling (CDP2)), MediaWiki-User-management, MediaWiki-User-preferences

Sat, May 18

daniel committed rMTDA7c874ab095d2: WIP: Account for LoC weight in stats. (authored by daniel).
WIP: Account for LoC weight in stats.
Sat, May 18, 7:28 PM
daniel committed rMTDAfb8519cb6c6f: Merge branch 'master' of ssh://gerrit.wikimedia.org… (authored by daniel).
Merge branch 'master' of ssh://gerrit.wikimedia.org…
Sat, May 18, 7:28 PM
daniel created T223726: Ruprecht: Investigate filtering dependencies by Connascence.
Sat, May 18, 3:17 PM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel created T223724: Ruprecht: measure LoC in tangels. .
Sat, May 18, 3:09 PM · Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel created T223723: Ruprecht: measure inverse transitive reach.
Sat, May 18, 3:07 PM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2)), Code-Health
daniel updated the task description for T222825: WMHack19: Avoiding cyclic dependencies.
Sat, May 18, 1:04 PM · Wikimedia-Hackathon-2019
daniel updated the task description for T222825: WMHack19: Avoiding cyclic dependencies.
Sat, May 18, 1:04 PM · Wikimedia-Hackathon-2019

Fri, May 17

daniel updated subscribers of T219883: Draft file format for phester test definitions.

ping @zeljkofilipin: you are already on the other relevant tickets and also on the spreadsheet, but I though you may want to have a look at the test file example here.

Fri, May 17, 2:49 PM · Core Platform Team Kanban (Doing), Core Platform Team (Code Health (TEC13))
daniel added a comment to T221177: REST route handler extension interface RFC.

I think it would be necessary to:

  • Introduce and libraryize a new interface for BagOStuff
Fri, May 17, 9:22 AM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
daniel added a comment to T221177: REST route handler extension interface RFC.

Conversation copied from Gerrit, to be continued here:

Fri, May 17, 9:10 AM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
daniel added a project to T220493: Xml stubs dumps are running 5 to 15x slower than previously: Core Platform Team.

Tagging Core Platform Team for triage.

Fri, May 17, 8:51 AM · Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-General-or-Unknown, Dumps-Generation
daniel updated the task description for T222827: WMHack19: TechCom office hour, live edition.
Fri, May 17, 8:11 AM · Wikimedia-Hackathon-2019, TechCom
daniel updated the task description for T222827: WMHack19: TechCom office hour, live edition.
Fri, May 17, 8:10 AM · Wikimedia-Hackathon-2019, TechCom

Thu, May 16

Tgr awarded T222825: WMHack19: Avoiding cyclic dependencies a Like token.
Thu, May 16, 12:16 PM · Wikimedia-Hackathon-2019
Tgr awarded T222827: WMHack19: TechCom office hour, live edition a Like token.
Thu, May 16, 12:16 PM · Wikimedia-Hackathon-2019, TechCom

Wed, May 15

daniel closed T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only) as Resolved.
Wed, May 15, 10:03 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Core Platform Team Kanban (Waiting for Review), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel closed T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only), a subtask of T174031: MCR: Include all slots in XML dumps, as Resolved.
Wed, May 15, 10:03 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Core Platform Team (MCR), Multi-Content-Revisions (New Features), SDC Engineering, Wikidata
daniel updated the task description for T222827: WMHack19: TechCom office hour, live edition.
Wed, May 15, 8:49 PM · Wikimedia-Hackathon-2019, TechCom
daniel added a comment to T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.

See T222409: Standardize declarative object construction in MediaWiki for a discussion of a generalized mechanism for allowing dependency injection when creating objects from some kind of non-code specification, as may be provided via extension.json.

Wed, May 15, 11:32 AM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Later), MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt
daniel added a comment to T222409: Standardize declarative object construction in MediaWiki.

One thing that we could add would be a convenience function that allows the caller to assert that the return value actually has the correct type.

Wed, May 15, 11:30 AM · Patch-For-Review, Performance-Team (Radar), MediaWiki-General-or-Unknown, ObjectFactory
daniel added a comment to T222409: Standardize declarative object construction in MediaWiki.

I like this proposal a lot. I can't find anything missing, either.

Wed, May 15, 11:29 AM · Patch-For-Review, Performance-Team (Radar), MediaWiki-General-or-Unknown, ObjectFactory

Tue, May 14

daniel updated subscribers of T222825: WMHack19: Avoiding cyclic dependencies.
Tue, May 14, 8:29 PM · Wikimedia-Hackathon-2019
daniel updated the task description for T222825: WMHack19: Avoiding cyclic dependencies.
Tue, May 14, 8:28 PM · Wikimedia-Hackathon-2019
daniel claimed T222827: WMHack19: TechCom office hour, live edition.
Tue, May 14, 8:22 PM · Wikimedia-Hackathon-2019, TechCom
daniel added a comment to T222827: WMHack19: TechCom office hour, live edition.

Hi @daniel can you provide some links, background & current issues being work on for the TechCom?

Tue, May 14, 8:22 PM · Wikimedia-Hackathon-2019, TechCom
daniel updated the task description for T222827: WMHack19: TechCom office hour, live edition.
Tue, May 14, 8:22 PM · Wikimedia-Hackathon-2019, TechCom
daniel updated the task description for T222100: Decide whether creating Phester is actually worth while.
Tue, May 14, 8:08 PM · User-Daniel, Core Platform Team Kanban, Code-Health, Core Platform Team (Code Health (TEC13))
daniel removed a member for SDC General: daniel.
Tue, May 14, 6:12 PM
daniel added a parent task for T218558: Move User::getRights and related methods into PermissionManager: T223295: Make PermissionManager aware of the current user's session..
Tue, May 14, 4:10 PM · Patch-For-Review, Core Platform Team Kanban (Contractor - Ready), Core Platform Team (Decoupling (CDP2))
daniel added a subtask for T223295: Make PermissionManager aware of the current user's session.: T218558: Move User::getRights and related methods into PermissionManager.
Tue, May 14, 4:10 PM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2))
daniel created T223295: Make PermissionManager aware of the current user's session..
Tue, May 14, 4:09 PM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2))
daniel created T223294: Deprecate the $mRights field in the User class, replacing it with a cache in PermissionManager..
Tue, May 14, 4:05 PM · Core Platform Team Kanban (Contractor - Doing), Patch-For-Review, Core Platform Team (Decoupling (CDP2))
daniel closed T208768: Create a PermissionManager service as Resolved.
Tue, May 14, 3:54 PM · Anti-Harassment, Core Platform Team Kanban (Contractor - Doing), Core Platform Team (Decoupling (CDP2)), MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel closed T208768: Create a PermissionManager service, a subtask of T208764: Remove cyclic dependency between Title and User classes, as Resolved.
Tue, May 14, 3:54 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later)
daniel added a parent task for T208768: Create a PermissionManager service: T212639: Separate could do / can do / is doing permission checks in MediaWiki.
Tue, May 14, 3:54 PM · Anti-Harassment, Core Platform Team Kanban (Contractor - Doing), Core Platform Team (Decoupling (CDP2)), MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel added a subtask for T212639: Separate could do / can do / is doing permission checks in MediaWiki: T208768: Create a PermissionManager service.
Tue, May 14, 3:54 PM · MediaWiki-Authentication-and-authorization
daniel removed subtasks for T208768: Create a PermissionManager service: T212639: Separate could do / can do / is doing permission checks in MediaWiki, T208776: Introduce PageIdentity to be used instead of Title.
Tue, May 14, 3:54 PM · Anti-Harassment, Core Platform Team Kanban (Contractor - Doing), Core Platform Team (Decoupling (CDP2)), MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel removed a parent task for T208776: Introduce PageIdentity to be used instead of Title: T208768: Create a PermissionManager service.
Tue, May 14, 3:54 PM · TechCom-RFC, Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later)
daniel removed a parent task for T212639: Separate could do / can do / is doing permission checks in MediaWiki: T208768: Create a PermissionManager service.
Tue, May 14, 3:54 PM · MediaWiki-Authentication-and-authorization
daniel edited projects for T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them, added: Core Platform Team Backlog (Later), Core Platform Team (Code Health (TEC13)); removed Core Platform Team.
Tue, May 14, 12:48 PM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Later), MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt
daniel added a comment to T222533: Add message to Special:Watchlist /raw and /clear to indicate slower speed.

Maybe I'm naive, but I'm wondering why any jobs need to be involved at all. Shouldn't be deleting all items for a given user be a split second operation on the db table? Can anyone shed some light on why this is slow enough to require cascading jobs

Tue, May 14, 12:45 PM · Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)), Growth-Team, MediaWiki-Watchlist

Mon, May 13

daniel updated the task description for T208766: Deprecate User::isWatched, addWatch, and removeWatch.
Mon, May 13, 8:27 PM · Core Platform Team Kanban (Contractor - Doing), Patch-For-Review, Core Platform Team (Decoupling (CDP2)), Growth-Team, MediaWiki-Watchlist
daniel edited projects for T208766: Deprecate User::isWatched, addWatch, and removeWatch, added: Core Platform Team Kanban (Contractor - Doing); removed Core Platform Team Backlog (Later).
Mon, May 13, 8:26 PM · Core Platform Team Kanban (Contractor - Doing), Patch-For-Review, Core Platform Team (Decoupling (CDP2)), Growth-Team, MediaWiki-Watchlist
daniel created T223165: Implement access restrictions in WatchedItemStore.
Mon, May 13, 8:26 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later), Growth-Team, MediaWiki-Watchlist
daniel removed a subtask for T208766: Deprecate User::isWatched, addWatch, and removeWatch: T208776: Introduce PageIdentity to be used instead of Title.
Mon, May 13, 8:10 PM · Core Platform Team Kanban (Contractor - Doing), Patch-For-Review, Core Platform Team (Decoupling (CDP2)), Growth-Team, MediaWiki-Watchlist
daniel removed a parent task for T208776: Introduce PageIdentity to be used instead of Title: T208766: Deprecate User::isWatched, addWatch, and removeWatch.
Mon, May 13, 8:10 PM · TechCom-RFC, Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later)
daniel reopened T207977: remove prev/next message dependency from Language as "Open".

Re-opening, extensions still need to be fixed.

Mon, May 13, 3:32 PM · MediaWiki-extensions-General, Core Platform Team Kanban, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review
daniel closed T207977: remove prev/next message dependency from Language as Resolved.
Mon, May 13, 3:31 PM · MediaWiki-extensions-General, Core Platform Team Kanban, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review
daniel placed T219689: Undeprecate User::setPassword() up for grabs.

Disengaging for lack of consensus. It seems the focus/purpse of this ticket shifted a lot, so at least the task decsiption should be changed.

Mon, May 13, 3:21 PM · Core Platform Team Backlog (Later), Patch-For-Review, Core Platform Team, MediaWiki-Authentication-and-authorization
daniel added a comment to T220353: Unable to create redirect on dewiki - fatal DBQueryError.

How frequent is this? Should it be high priority?

Mon, May 13, 3:17 PM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), User-Marostegui, MediaWiki-Revision-backend, Wikimedia-production-error, MediaWiki-Redirects
daniel placed T220353: Unable to create redirect on dewiki - fatal DBQueryError up for grabs.

Unassigning myself, since I don't know what do to about this. I'm probably not the best person to investigate this issue, either.

Mon, May 13, 3:16 PM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), User-Marostegui, MediaWiki-Revision-backend, Wikimedia-production-error, MediaWiki-Redirects
daniel closed T214318: Replace usage of Title with usage of LinkTarget in Linker as Resolved.
Mon, May 13, 2:49 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), MediaWiki-File-management, Multimedia, Commons