Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (276 w, 9 h)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Today

daniel renamed T221949: Remove Title::moveTo from Remove uses of Title::moveTo to Remove Title::moveTo.
Fri, Jan 24, 10:23 AM · Core Platform Team, Core Platform Team Workboards (Contractor Workboard), MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-Maintenance, MediaWiki-extensions-LiquidThreads, Wikidata, MediaWiki-extensions-UserMerge, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Patch-For-Review, User-DannyS712, CPT Initiatives (Decoupling (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Technical-Debt (Deprecation process)
daniel updated the task description for T221949: Remove Title::moveTo.
Fri, Jan 24, 10:22 AM · Core Platform Team, Core Platform Team Workboards (Contractor Workboard), MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-Maintenance, MediaWiki-extensions-LiquidThreads, Wikidata, MediaWiki-extensions-UserMerge, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Patch-For-Review, User-DannyS712, CPT Initiatives (Decoupling (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Technical-Debt (Deprecation process)
daniel closed T224165: Don't pass Config object to service constructors as Resolved.
Fri, Jan 24, 10:17 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-ServiceContainer

Yesterday

daniel added a comment to T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler..

I just created T243560: Use ObjectFactory to construct ContentHandlers. The way to inject services into a ContentHandler would be similar to what SpecialPageFactory does for EditTags and RevisionDelete: instead of using the plain class name as the "spec", an array is used that specifies the class name and also a list of services to pass. This in this case, the "spec" would be in $wgContentHandlers in DefaultSettings.php.

Thu, Jan 23, 10:46 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a parent task for T243560: Use ObjectFactory to construct ContentHandlers: T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler..
Thu, Jan 23, 10:42 PM · Core Platform Team Workboards (Contractor Workboard), MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel added a subtask for T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler.: T243560: Use ObjectFactory to construct ContentHandlers.
Thu, Jan 23, 10:42 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel created T243560: Use ObjectFactory to construct ContentHandlers.
Thu, Jan 23, 10:42 PM · Core Platform Team Workboards (Contractor Workboard), MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler..

ContentHandler currently doesn't use LanguageConverter, as far as I can see.

It does! I'm not sure what for but:

Thu, Jan 23, 10:33 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243461: Decrease visibility of public variables in LanguageConverter class.

This definitely seems like a good idea. The trick is making sure that nothing relies on these fields. We don't have a formal deprecation process for reducing visibility, but it's technically removing something from the public interface, so care should be taken.

Thu, Jan 23, 10:25 PM · Core Platform Team, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243213: Allow extensions to register handlers with factories without the use of global variables..

Is there very much difference between global configuration arrays and configuration arrays wrapped in a global service?

Thu, Jan 23, 10:23 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel added a comment to T243213: Allow extensions to register handlers with factories without the use of global variables..

Make ExtensionRegistry a service.

Last time I tried doing this (never posted to Gerrit) there was some bootstrapping problem where the ExtensionRegistry is needed right away in LocalSettings.php, but that's too early to invoke MediaWikiServices. See rMW69aecc2eeae0: Don't initialize MediaWikiServices before extensions have been loaded as well.

Thu, Jan 23, 10:12 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel added a comment to T243515: Refactor MediaWikiServices::forceGlobalInstance to return void instead of old instance..

If I understand correctly, the idea is: make it possible to use the MediaWikiServices class in MediaWikiUnitTests, with a mocked instance of MediaWikiServices.

Thu, Jan 23, 8:04 PM · MediaWiki-Core-Testing, MediaWiki-ServiceContainer, Core Platform Team
daniel added a project to T243515: Refactor MediaWikiServices::forceGlobalInstance to return void instead of old instance.: MediaWiki-Core-Testing.
Thu, Jan 23, 8:02 PM · MediaWiki-Core-Testing, MediaWiki-ServiceContainer, Core Platform Team
daniel created T243523: The phpunit wrapper mishandles parsing of --wiki parameter..
Thu, Jan 23, 4:08 PM · Core Platform Team, MediaWiki-Core-Testing

Wed, Jan 22

daniel added a comment to T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage.

Yes, we need this!
This decision is one of the 2 rfcs blocking continued work on constraint checks for Wikidata that was started in either late 2018 or early 2019. :)

Wed, Jan 22, 9:43 PM · User-Addshore, Wikibase-Quality-Constraints, Core Platform Team Legacy (Designing), Services (designing), User-mobrovac, wikidata-tech-focus, TechCom-RFC, Wikibase-Quality, Wikidata
daniel added a comment to T208188: RFC: Partial opt-out method for Content security policy.

Tagging Core Platform Team to keep in the loop, and possible provide code review.

Wed, Jan 22, 9:38 PM · Core Platform Team, Patch-For-Review, ContentSecurityPolicy, TechCom-RFC, TechCom, Security-Team, Security
daniel added a project to T208188: RFC: Partial opt-out method for Content security policy: Core Platform Team.
Wed, Jan 22, 9:37 PM · Core Platform Team, Patch-For-Review, ContentSecurityPolicy, TechCom-RFC, TechCom, Security-Team, Security
daniel edited projects for T240307: Hook container with strong types and DI, added: TechCom-RFC (TechCom-Approved); removed TechCom-RFC.

This RFC has been approved as proposed per today's TechCom meeting

Wed, Jan 22, 9:36 PM · TechCom-RFC (TechCom-Approved), User-Daniel, Core Platform Team
daniel added a comment to T243213: Allow extensions to register handlers with factories without the use of global variables..

This step seems premature.

Wed, Jan 22, 9:12 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel closed T225197: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent" as Resolved.

I assume this is resolved now.

Wed, Jan 22, 8:33 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Commons, MediaWiki-File-management, Multimedia, Wikimedia-production-error
daniel added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

In any case, I think we should have two sets of API tests:

  • "structure test" that verify basic API functionality that must always work, e.g. action=help, action=paraminfo, action=query with no other parameters, etc. regardless of what extension is installed. This would be a rather small set of tests that run against both vanilla MediaWiki core and core plus arbitrary extensions.
  • "core tests" that do more extensive API testing, but run just against vanilla MediaWiki core instances.

Then there could be a third category of tests, which extensions can extend the core tests and run against core plus arbitrary extensions.

Wed, Jan 22, 7:04 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T243332: Create table with mapping between lang code and converter instead of using name convention.

Looks to me like the initial patch is already doing this.

Wed, Jan 22, 5:39 PM · Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel triaged T243326: Rename ILanguageInterface::convert function to eliminate ambiguity as Low priority.
Wed, Jan 22, 5:38 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel renamed T243326: Rename ILanguageInterface::convert function to eliminate ambiguity from Rename ILanguageInterface convertHtml function to eliminate ambiguity to Rename ILanguageInterface::convert function to eliminate ambiguity.
Wed, Jan 22, 5:38 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243326: Rename ILanguageInterface::convert function to eliminate ambiguity.

If we want to do this, we should do it soon, before callers of Language::convert are changed to call LanguageConverter::convert.

Wed, Jan 22, 5:37 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel triaged T243325: Avoid LanguageConverter from usage of Language by introducing specialised interface as Low priority.
Wed, Jan 22, 5:33 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243325: Avoid LanguageConverter from usage of Language by introducing specialised interface .

Would be nice, but I'd push taht back. LanguageConverter knowing about Language isn't a huge problem. Language knowing about LanguageConverter is a lot worse.

Wed, Jan 22, 5:31 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243323: Inject LanguageConverter through constructor in SearchNearMatcher.

This should indeed be done. See T243317#5823612 for the pattern.

Wed, Jan 22, 5:30 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243321: Inject LanguageConverter via DI DefaultPreferencesFactory.

DefaultPreferencesFactory is already using DI and is constructed in ServiceWiring.php. Injecting should be trivial.

Wed, Jan 22, 5:29 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243320: Inject a LanguageConverterFactory through ParserFactory into Parser.

This should indeed be done. See T243317#5823612 for the pattern.

Wed, Jan 22, 5:28 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243317: Create or define better approach to inject languageConverter according to deprecation policy.

This lacks context.

Wed, Jan 22, 5:26 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler..

I recall making this comment, but I don't recall the context... ContentHandler currently doesn't use LanguageConverter, as far as I can see. Once we have ContentHandlerFactory, we could start to inject all things into ContentHandler subclasses. That would certainly be good. But I don't quite understand what this task is calling for.

Wed, Jan 22, 5:23 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T243306: Introduce shorthand to LanguageConverter for al SpecialPage hierarchy.

Sounds sensible

Wed, Jan 22, 5:20 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T226833: Introduce LanguageConverterFactory service.
  • Replace and remove Language::newConverter() - Done!
  • Move the knowledge encoded in the various implementations of newConverter() into the respective LanguageConverter subclasses - Done!
  • Remove $variants, $variantFallback, and similar parameters from the constructor signature of LanguageConverter, hard-coding the values insead. - Done!
  • Create LanguageConverterFactory, managed by MediaWikiServices. - Done!
  • Hard-code a mapping from language code to LanguageConverter subclass in * LanguageConverterFactory. - Working On Right Now!
  • Make the LanguageConverter base class abstract. - Done!
Wed, Jan 22, 5:19 PM · Patch-For-Review, Core Platform Team, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n

Tue, Jan 21

daniel added a comment to T243051: A query builder for MediaWiki core.

If the plan isn't to replace getQueryInfo(), we can leave this point until then. When we do come back to it, the issue IMO is more in "combining" than "filling".

Tue, Jan 21, 7:21 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-General
daniel added a comment to T243051: A query builder for MediaWiki core.

Is it easier to accept a context-sensitive useIndex() function if you consider it to be effectively appending to a query string?

Tue, Jan 21, 7:02 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-General
daniel added a project to T231930: Introduce ActingUser to represent the user performing the current request: User-Daniel.
Tue, Jan 21, 11:55 AM · User-Daniel, MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
daniel updated the task description for T223165: Implement access restrictions in WatchedItemStore.
Tue, Jan 21, 11:54 AM · CPT Initiatives (Decoupling (CDP2)), Growth-Team, MediaWiki-Watchlist
daniel added a project to T243213: Allow extensions to register handlers with factories without the use of global variables.: User-Daniel.
Tue, Jan 21, 11:35 AM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel added a project to T243213: Allow extensions to register handlers with factories without the use of global variables.: TechCom.

Tagging TechCom for discussion, since this seems like a cross-cutting concern.

Tue, Jan 21, 11:35 AM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel updated the task description for T243213: Allow extensions to register handlers with factories without the use of global variables..
Tue, Jan 21, 11:34 AM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel renamed T235165: Introduce ContentHandlerFactory from Introduce ContentHandlerRegistry to Introduce ContentHandlerFactory.
Tue, Jan 21, 11:32 AM · Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))

Mon, Jan 20

daniel updated subscribers of T243213: Allow extensions to register handlers with factories without the use of global variables..
Mon, Jan 20, 2:37 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel created T243213: Allow extensions to register handlers with factories without the use of global variables..
Mon, Jan 20, 2:34 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
daniel updated the task description for T235165: Introduce ContentHandlerFactory.
Mon, Jan 20, 2:21 PM · Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T243051: A query builder for MediaWiki core.

How about

$queryBuilder ->table( $tableName, $alias )->useIndex( $index )->ignoreIndex( $otherIndex );

Where useIndex() and ignoreIndex() act on the most recently declared table? It's implicit but brief, and you could be creative with line breaks to help readability. Note that there is also $queryBuilder->options() as a last resort array hacking function, so it's never necessary to parse an options array and convert it to a call chain.

Mon, Jan 20, 11:36 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-General

Thu, Jan 16

daniel added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

@hashar Is there a mechanism that would allow for disabling tests for extensions but not core as @daniel suggests?

No. (And I would oppose attempts to do such a thing; the whole point of CI is to see what tests from which repos are broken by which other repos.)

Thu, Jan 16, 10:48 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel updated subscribers of T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage.

I see that T227776 has had little activity since November, is there any way to move this forward?

Thu, Jan 16, 1:19 PM · User-Addshore, Wikibase-Quality-Constraints, Core Platform Team Legacy (Designing), Services (designing), User-mobrovac, wikidata-tech-focus, TechCom-RFC, Wikibase-Quality, Wikidata
daniel added a comment to T235165: Introduce ContentHandlerFactory.

On the subject of using php interfaces, as briefly discussed on slack: I'm not opposed to introducing IContentHandler, but I don't see much value in it. I do see the value in having a narrow IContentHandlerFactory interface that is implemented by ContentHandlerRegistry.

Thu, Jan 16, 11:58 AM · Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T240884: Standalone service to evaluate user-provided regular expressions.

Condensed outcome of a conversation between @Ladsgroup, @Addshore, @Joe, @Krinkle, @tstarling, and myself:

Thu, Jan 16, 11:23 AM · User-Addshore, TechCom-RFC, Wikidata
daniel updated subscribers of T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo.

Adding core platform team to get some feedback and figure out:

  • When exactly this change in behaviour happened?
    • I have looked through various gerrit changes and code paths but i'm sure someone that has worked on this code would be able to figure out exactly when this happened.
    • It's slightly confusing as some stages look like a partial implementation, in some places, that may not have worked as expected etc.
Thu, Jan 16, 9:39 AM · Core Platform Team Workboards (Clinic Duty Team), User-Addshore, Wikidata-Campsite, Commons, Wikidata
daniel added a comment to T99268: RfC: Create a proper command-line runner for MediaWiki maintenance tasks.

@WDoranWMF @kchapman @daniel Would you all be interested in promoting/mentoring this project via Google Summer of Code 2020 or Outreachy Round 20?

Thu, Jan 16, 9:32 AM · Outreachy (Round 19), Core Platform Team, TechCom-RFC (TechCom-Approved), MediaWiki-Maintenance-scripts

Wed, Jan 15

daniel added a comment to T225197: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent".

Those two lines using thumb are the only two in the codebase that use that channel. The previous one being introduced in 2015 and never enabled in prod from what I can see. There is however a more common thumbnail channel enabled in prod.

Wed, Jan 15, 11:11 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Commons, MediaWiki-File-management, Multimedia, Wikimedia-production-error
daniel moved T242835: [RFC] Port MobileFrontend Feature Management into core from Inbox to Under discussion on the TechCom-RFC board.
Wed, Jan 15, 9:41 PM · Desktop Improvements, MobileFrontend, TechCom-RFC, Readers-Web-Backlog
daniel moved T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki from Inbox to Under discussion on the TechCom-RFC board.
Wed, Jan 15, 9:38 PM · Security-Team, TechCom-RFC
daniel added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

We should probably disable the integration tests for extensions for now.

Wed, Jan 15, 9:00 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T226833: Introduce LanguageConverterFactory service.

By the way - our deployment cycle is weekly, but the release cycle is twice a year. The next release would be some time in the summer.

Can we remove these lines then:

Wed, Jan 15, 6:31 PM · Patch-For-Review, Core Platform Team, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

Can the tests be run with a bot password?

Wed, Jan 15, 6:28 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T225197: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent".

@daniel Remember to enable the thumb channel in production, or, given this is probably temporary instrumentation, perhaps use AdhocDebug instead (and cherry-pick to wmf, leave unmerged in master).

Wed, Jan 15, 11:59 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Commons, MediaWiki-File-management, Multimedia, Wikimedia-production-error
daniel added a comment to T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo.

I haven't done a full analysis, but I'm wondering why this is using the ContentAlterParserOutput hook, instead of RevisionDataUpdates? Conceptually, ContentAlterParserOutput is a filter-style hook that shouldn't have side effects. RevisionDataUpdates is specifically designed for recording information into the database after an edit.

Wed, Jan 15, 11:35 AM · Core Platform Team Workboards (Clinic Duty Team), User-Addshore, Wikidata-Campsite, Commons, Wikidata
daniel added a comment to T226833: Introduce LanguageConverterFactory service.
  1. I left mutual dependency for now as I have to make sure about the goal. Therefore LanguageConverterFactory::createFromCode

has got weird signature:

public function createFromCode($code, \Language $language)
Wed, Jan 15, 11:28 AM · Patch-For-Review, Core Platform Team, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

So far all the failures are assumptions about permissions or login, which are fully compliant with the API and applications should be coded around that. Can those tests be disabled/fixed?

Wed, Jan 15, 10:40 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

If these tests are just for core, can they just run against mediawiki/core patches and not extensions?

Wed, Jan 15, 10:27 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T222918: Put "shim" code for namespaces, logs, and log i18n into WikimediaMessages so we can undeploy extensions.

Might be relevant in this context: T220608: Introduce UnknownContentHandler and UnknownContent

Wed, Jan 15, 10:24 AM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), WikimediaMessages, Wikimedia-Site-requests
daniel closed T220608: Introduce UnknownContentHandler and UnknownContent, a subtask of T220594: abstracts dumps for dewikiversity fail with MWUnknownContentModelException from ContentHandler.php, as Resolved.
Wed, Jan 15, 10:22 AM · MediaWiki-General, Dumps-Generation
daniel closed T220608: Introduce UnknownContentHandler and UnknownContent, a subtask of T228921: incomplete conversion of flow revisions after disabling flow, breaks stubs dumps, as Resolved.
Wed, Jan 15, 10:22 AM · Patch-For-Review, Dumps-Generation
daniel closed T220608: Introduce UnknownContentHandler and UnknownContent as Resolved.
Wed, Jan 15, 10:22 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler

Tue, Jan 14

daniel added a project to T236880: Document when to use different ILoadBalancer::get*Connection* methods: Documentation.
Tue, Jan 14, 7:42 PM · Documentation, Core Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms, MediaWiki-Documentation
daniel added a project to T232506: Inject services into special pages: CPT Initiatives (Decoupling (CDP2)).
Tue, Jan 14, 7:41 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
daniel added a comment to T211450: importDump does not work with actor if the user name is not in canonical form.

Is there any way to get around this issue? I'm currently trying to import an XML dump into a local MediaWiki install but getting this error.

Tue, Jan 14, 5:18 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Export-or-Import
daniel renamed T211450: importDump does not work with actor if the user name is not in canonical form from importDump does not work with actor if the user does not exist to importDump does not work with actor if the user name is not in canonical form.
Tue, Jan 14, 5:15 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Export-or-Import
daniel updated the task description for T242764: Test schema update from old versions to MCR-only schema.
Tue, Jan 14, 4:22 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-release, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel updated the task description for T242764: Test schema update from old versions to MCR-only schema.
Tue, Jan 14, 4:16 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-release, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel created T242764: Test schema update from old versions to MCR-only schema.
Tue, Jan 14, 4:12 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.35-release, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a comment to T221949: Remove Title::moveTo.

The sole remaining issue here is to add a test for UserMerge that tests the page move, so we can merge the respective patch with confidence:

Tue, Jan 14, 1:16 PM · Core Platform Team, Core Platform Team Workboards (Contractor Workboard), MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-Maintenance, MediaWiki-extensions-LiquidThreads, Wikidata, MediaWiki-extensions-UserMerge, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Patch-For-Review, User-DannyS712, CPT Initiatives (Decoupling (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Technical-Debt (Deprecation process)
daniel updated the task description for T226833: Introduce LanguageConverterFactory service.
Tue, Jan 14, 12:51 PM · Patch-For-Review, Core Platform Team, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
daniel updated the task description for T235165: Introduce ContentHandlerFactory.
Tue, Jan 14, 12:22 PM · Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-ContentHandler, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T242378: Test the section and sectiontitle parameters of action=edit.

@Somebody please use the "Edit task" link at the top of the page to update the task description. Your description is good, but it should be at the top, not in a comment down here.

Tue, Jan 14, 9:53 AM · Core Platform Team Workboards (Outreachy Interns), CPT Initiatives (API Integration Tests), Outreachy (Round 19)

Fri, Jan 10

daniel added a comment to T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English.

Looks like this boils down to wfGetLangObj() returning $wgLang, which has a stale Language object. The same stale object would also be contained in the main RequestContext.

Fri, Jan 10, 10:48 AM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel added a comment to T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English.

Thanks for testing @jcrespo, I'll check it out!

Fri, Jan 10, 10:14 AM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel renamed T242375: Write integration tests for action API's "edit" module. from Action: Edit to Write integration tests for action API's "edit" module..
Fri, Jan 10, 10:08 AM · Core Platform Team Workboards (Outreachy Interns), CPT Initiatives (API Integration Tests), Outreachy (Round 19), Outreach-Programs-Projects
daniel added a comment to T242375: Write integration tests for action API's "edit" module..

Hi Esther!

Fri, Jan 10, 10:05 AM · Core Platform Team Workboards (Outreachy Interns), CPT Initiatives (API Integration Tests), Outreachy (Round 19), Outreach-Programs-Projects

Thu, Jan 9

daniel moved T240307: Hook container with strong types and DI from Under discussion to Last Call on the TechCom-RFC board.

This RFC has been put on Last Call per the TechCom meeting on January 8. If there are no issues left unresolved by January 22, this RFC will be approved as proposed.

Thu, Jan 9, 10:53 PM · TechCom-RFC (TechCom-Approved), User-Daniel, Core Platform Team
daniel added a comment to T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English.

Out of curiosity, do you know why specifically with Turkish and not with other (non-English) languages?

Thu, Jan 9, 5:26 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel added a comment to T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English.

Not the original reporter, but after applying the patch I can confirm the turkish installation went through correctly (twice):

Thu, Jan 9, 5:25 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel triaged T238966: Drop pre-MCR schema fields in Wikimedia production as High priority.
Thu, Jan 9, 12:58 PM · Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration)
daniel claimed T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English.
Thu, Jan 9, 12:57 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel claimed T225197: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent".
Thu, Jan 9, 12:57 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Commons, MediaWiki-File-management, Multimedia, Wikimedia-production-error

Wed, Jan 8

daniel added a project to T220056: MediaWiki database policy and/or guidelines (2019): TechCom.

Putting on the TechCom board for implementation. That is, putting the document in the correct place on the wiki.

Wed, Jan 8, 10:13 PM · TechCom, TechCom-RFC (TechCom-Approved), DBA
daniel edited projects for T220056: MediaWiki database policy and/or guidelines (2019), added: TechCom-RFC (TechCom-Approved); removed TechCom-RFC.
Wed, Jan 8, 9:23 PM · TechCom, TechCom-RFC (TechCom-Approved), DBA
daniel added a comment to T240307: Hook container with strong types and DI.

I like it. Simple and straightforward while still covering the necessary use cases.

Wed, Jan 8, 5:56 PM · TechCom-RFC (TechCom-Approved), User-Daniel, Core Platform Team
daniel added a comment to T240307: Hook container with strong types and DI.

Task description edit: remove the term "listener" and move hook interfaces into the namespace of the caller.

Wed, Jan 8, 5:55 PM · TechCom-RFC (TechCom-Approved), User-Daniel, Core Platform Team

Tue, Jan 7

daniel moved T225197: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent" from Backlog to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Jan 7, 7:52 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Commons, MediaWiki-File-management, Multimedia, Wikimedia-production-error
daniel moved T221763: Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y. from Doing to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Jan 7, 7:30 PM · User-brennen, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, User-ArielGlenn, CPT Initiatives (MCR), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MediaWiki-Revision-backend, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), PageImages, Multi-Content-Revisions (Reactive), Wikimedia-production-error, Regression
daniel moved T221763: Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y. from Backlog to Doing on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Jan 7, 7:21 PM · User-brennen, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, User-ArielGlenn, CPT Initiatives (MCR), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MediaWiki-Revision-backend, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), PageImages, Multi-Content-Revisions (Reactive), Wikimedia-production-error, Regression
daniel added a comment to T221763: Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y..

The instances of this I currently see on Kibana all come from FlaggedRevs:

Tue, Jan 7, 7:20 PM · User-brennen, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, User-ArielGlenn, CPT Initiatives (MCR), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MediaWiki-Revision-backend, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), PageImages, Multi-Content-Revisions (Reactive), Wikimedia-production-error, Regression
daniel moved T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English from Doing to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Jan 7, 2:05 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel moved T235360: Page view fatal from LanguageConverter: "Call to a member function isSafeToLoad() on null" from Backlog to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Jan 7, 2:05 PM · Patch-For-Review, MediaWiki-Parser, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, Wikimedia-production-error
daniel added a comment to T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English.

I made a patch for the 1_34 branch, https://gerrit.wikimedia.org/r/c/mediawiki/core/+/562510

Tue, Jan 7, 1:53 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer
daniel moved T241638: ContainerDisabledException in ServiceContainer due to failed installation with different language then English from Backlog to Doing on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Jan 7, 1:32 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-Internationalization, MediaWiki-Installer