Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (300 w, 6 h)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Today

daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jul 10, 1:56 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel moved T235073: Moderator gets user contributions from Waiting for Review to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.

Patch is merged. Note that the implementation follows the adjustments we made to T252202, so the description on this task is obsolete. In particular, we use a single segment parameter rather than using older_than and newer_than.

Fri, Jul 10, 8:35 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Yesterday

daniel added a comment to T256841: slot_revision_origin_role should be a UNIQUE INDEX.

Since it is already guaranteed to be unique, it's probably unnecessary to explicitly define it as unique. I once thought that doing so would improve database performance, by providing additional hints to the query planner. I have since learned that it may instead degrade write performance. So perhaps this should not be done.

Thu, Jul 9, 4:00 PM · Core Platform Team, Schema-change, DBA, User-DannyS712
daniel created T257556: Jenkins is sometimes not picking up +2 votes, some patches don't get merged.
Thu, Jul 9, 10:16 AM · Release-Engineering-Team, Gerrit, Jenkins

Wed, Jul 8

daniel created T257472: Turn Diff into a proper value object..
Wed, Jul 8, 4:03 PM · MediaWiki-General, Core Platform Team
DannyS712 awarded T257464: UserFactory should have a method for constructing an anonymous User a Like token.
Wed, Jul 8, 3:36 PM · Core Platform Team
daniel created T257464: UserFactory should have a method for constructing an anonymous User .
Wed, Jul 8, 2:52 PM · Core Platform Team

Tue, Jul 7

daniel moved T235073: Moderator gets user contributions from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Tue, Jul 7, 6:50 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel moved T251806: Contributor gets count of tagged contributions from Doing to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.
Tue, Jul 7, 12:47 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Mon, Jul 6

daniel moved T251803: Contributor gets own contributions by tag from Waiting for Review to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.
Mon, Jul 6, 2:19 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
daniel moved T251805: Contributor gets own contribution count from Waiting for Review to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.
Mon, Jul 6, 2:17 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Fri, Jul 3

daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

While applying @stable to override annotations, I realized that we have quite a few methods that are technically stable to override, but we don't want extensions to override them. This is typically the case if the method at hand is inherited from a parent class or interface, and implemented in a canonical way for the present class. Such a method is technically stable for overriding, because the abstract definition in the parent class is. But we don't want to encourage extensions to override them. We really want to tell them not to.

Fri, Jul 3, 2:24 PM · TechCom-RFC (TechCom-RFC-Closed)
daniel added a comment to T257002: Internal error on Special:Contributions in Wikidata.

might be related to T253289: Remove USE INDEX usertext_timestamp and other references from code

Fri, Jul 3, 11:12 AM · MediaWiki-Special-pages, Wikimedia-production-error, Wikidata
daniel added a comment to T246284: Hard deprecate the Revision class.

I think we should merge it this week and closely monitor the deprecations log. The more time we have to detect and fix the long tail of things that might have escaped the better. Also, it would be really easy to revert and worst case scenario we will have some logspam

Fri, Jul 3, 11:11 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team, Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712
daniel added a comment to T256367: WMF-NDA access for DannyS712.

I can try, but there really isn't an established process for this I'm afraid.

I was following the steps laid out in https://wikitech.wikimedia.org/wiki/Volunteer_NDA

Fri, Jul 3, 9:40 AM · User-DannyS712, WMF-NDA-Requests
daniel added a comment to T256367: WMF-NDA access for DannyS712.

@daniel can you ask your manager to take a look and (hopefully) approve this?

Fri, Jul 3, 9:25 AM · User-DannyS712, WMF-NDA-Requests

Thu, Jul 2

daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

I just remembered an important distinction between @unstable and @internal: An interface or class that is marked @internal should not be used in a public interfaces, since code outside the repo should have no knowledge of them. Interfaces or classes marked as @unstable can be used in signatures of public methods, and code outside the repo may have knowledge of the type, but should not rely on members and methods to be stable (yet).

Thu, Jul 2, 9:29 PM · TechCom-RFC (TechCom-RFC-Closed)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

Something that might be helpful to include is stability of public constants, since those cannot emit deprecation warnings when deprecated. Eg for the removal of the Revision class, it has public constants that. How should those be deprecated?

Thu, Jul 2, 9:27 PM · TechCom-RFC (TechCom-RFC-Closed)
daniel added a comment to T256922: {{SUBPAGENAME}} no longer returning the title for pages without subpages.

I got the expected behavior wrong for getSubpageText() when writing the fix for getBaseText(). Sorry about that.

Thu, Jul 2, 8:35 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, MW-1.35-release, Core Platform Team, Regression, MediaWiki-General
daniel added a comment to T199004: RFC: Add a frontend build step to skins/extensions to our deploy process.

Thank you for the detailed response, @dcipoletti! I'm looking forward to learning more once you have progressed in your experimentation.

Thu, Jul 2, 8:21 PM · User-brennen, TechCom-RFC, Proposal, User-Jdlrobson
daniel added a comment to T199004: RFC: Add a frontend build step to skins/extensions to our deploy process.

It seems to me that the discussion on this RFC has been made difficult by of the wide range of use cases and possible solution covered by the umbrella of a "build step". For instance, the idea of pre-compiling vue templates as described above by @Niedzielski seems relatively uncontroversial. On the other hand, automatically downloading npm packages along with their dependencies seems to be much more problematic. It is unclear if the experiment @dcipoletti describes would involve automatic deployment of unaudited third party code.

Thu, Jul 2, 8:15 AM · User-brennen, TechCom-RFC, Proposal, User-Jdlrobson

Wed, Jul 1

daniel added a comment to T251778: LBFactoryMulti: Unknown cluster 'cluster14'.

This shows an empty page now with no error message (no server error, but no user-facing/200-OK'ed error either). Is that intentional? Anyway, LGTM.

Wed, Jul 1, 4:26 PM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-General-or-Unknown, Wikimedia-production-error

Mon, Jun 29

daniel moved T164538: Send regular overview about Wikimedia development policies from Inbox to In progress on the TechCom board.
Mon, Jun 29, 5:26 PM · Developer-Advocacy, TechCom
daniel updated the task description for T252202: Contributor gets their own contributions.
Mon, Jun 29, 5:00 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Mon, Jun 29, 12:16 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated subscribers of T247862: Stable Interface Policy annotations.
Mon, Jun 29, 12:16 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Mon, Jun 29, 12:15 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

I'm just going through all exceptions to mark them as newable, and their constructor stable to call... While it's good to have that for clarity, should we declare all extensions newable per default? Or will adding exceptions to the rules make things confusing?

Mon, Jun 29, 12:02 PM · TechCom-RFC (TechCom-RFC-Closed)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Mon, Jun 29, 9:37 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Mon, Jun 29, 9:37 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

By the way, we have quite a few usages of @private, apparently applied with the intent of @internal. I propose to just replace them in the code base.

Mon, Jun 29, 9:09 AM · TechCom-RFC (TechCom-RFC-Closed)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

Would you prefer @stable to type hint, @stable to type-hint or @stable to hint instead? If that's clearer and preferred by others, I'd be fine with that. Note that they're meant to be verbs, and I was aiming for each being a single word, but that might be hard in English :)

Mon, Jun 29, 9:04 AM · TechCom-RFC (TechCom-RFC-Closed)

Fri, Jun 26

daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 3:51 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 3:37 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel moved T252202: Contributor gets their own contributions from Doing to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.
Fri, Jun 26, 3:10 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Fri, Jun 26, 3:09 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 2:52 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

Stable to type

Fri, Jun 26, 2:49 PM · TechCom-RFC (TechCom-RFC-Closed)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.
Any method marked @deprecated, @internal or @unstable.

I would a bit more consistency how this is expressed.

Fri, Jun 26, 2:46 PM · TechCom-RFC (TechCom-RFC-Closed)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 2:09 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel added a comment to T256367: WMF-NDA access for DannyS712.

I support DannyS712's request. In particular, access to logstash would be useful for investigating issues.

Fri, Jun 26, 2:02 PM · User-DannyS712, WMF-NDA-Requests
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 12:59 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 12:36 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel removed a project from T247862: Stable Interface Policy annotations: Patch-For-Review.
Fri, Jun 26, 12:35 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 12:33 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel updated the task description for T247862: Stable Interface Policy annotations.
Fri, Jun 26, 12:15 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)
daniel moved T255803: RFC: Amendment to the Stability interface policy from P3: Explore to P5: Last Call on the TechCom-RFC board.
Fri, Jun 26, 11:23 AM · TechCom-RFC (TechCom-RFC-Closed)
daniel added a comment to T255803: RFC: Amendment to the Stability interface policy.

Per the TechCom meeting on June 24, this proposal enters the Last Call period. If no concerns remain unaddressed by July 9, the draft will replace the existing policy.

Fri, Jun 26, 11:23 AM · TechCom-RFC (TechCom-RFC-Closed)

Thu, Jun 25

daniel created T256401: ChangeTags are broken in postgres (at least in unit tests).
Thu, Jun 25, 5:24 PM · Core Platform Team (Icebox), PostgreSQL, MediaWiki-Change-tagging
daniel updated subscribers of T255213: MW service factories supply local wiki config into services created for foreign wikis.

Pinging @Tgr, since we have discussed this before.

Thu, Jun 25, 3:55 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team
daniel added a comment to T255213: MW service factories supply local wiki config into services created for foreign wikis.

My take on this is:

Thu, Jun 25, 3:54 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team
daniel added a comment to T246284: Hard deprecate the Revision class.

Yes, my point was that doing it in the *same* release should only be done if we are sure it's totally unused.
With the new policy, after 1.35 has been branched, we could skip deprecation entirely in such cases, and just remove the code.

That works for me too (just removing in 1.36) but shouldn't we give the deprecation warnings if we are planning on removing it?

Thu, Jun 25, 11:11 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team, Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712
daniel added a comment to T246284: Hard deprecate the Revision class.

Not sure I follow - if it has been soft deprecated for at least one release, and it isn't used by anything that is bundled or deployed, the policy already allows hard deprecation in the second release

Thu, Jun 25, 10:20 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team, Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712
daniel added a comment to T246284: Hard deprecate the Revision class.

Hooks can be hard and soft deprecated in the same release, and the hooks added to DeprecatedHooks that use Revision objects were mostly soft and hard deprecated in 1.35.

Thu, Jun 25, 9:08 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team, Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712

Wed, Jun 24

daniel added a comment to T249434: Replace hooks using Revision objects with RevisionRecord.

(Probably the policy should instead or also say that software deployed to Wikimedia servers MUST NOT have hard deprecation warnings, since there are extensions/skins deployed to Wikimedia that are not in the tarball.)

Wed, Jun 24, 9:10 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
daniel moved T248061: RFC: Remove IE 8 from basic support from Untriaged to Approved on the TechCom-RFC (TechCom-RFC-Closed) board.
Wed, Jun 24, 8:11 PM · Patch-For-Review, MW-1.36-release, TechCom-RFC (TechCom-RFC-Closed), Tech-Ambassadors, User-notice, MediaWiki-General, Browser-Support-Internet-Explorer, Front-end-Standards-Group
daniel edited projects for T248061: RFC: Remove IE 8 from basic support, added: TechCom-RFC (TechCom-RFC-Closed); removed TechCom-RFC.

Per today's TechCom meeting, this RFC is approved as proposed and discussed. Compatibility with IE8 can be dropped from master once 1.35 has been branched. This means that compatibility is retained for the 1.35 released, compatibility for the Wikimedia sites is dropped as soon as 1.35 has been branched (probably some time in July).

Wed, Jun 24, 8:10 PM · Patch-For-Review, MW-1.36-release, TechCom-RFC (TechCom-RFC-Closed), Tech-Ambassadors, User-notice, MediaWiki-General, Browser-Support-Internet-Explorer, Front-end-Standards-Group
daniel added a comment to T249434: Replace hooks using Revision objects with RevisionRecord.

Who "tries to get it in 1.35"? The Core Platform Team? Where is this decision documented?

Wed, Jun 24, 3:47 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
daniel added a comment to T249434: Replace hooks using Revision objects with RevisionRecord.

[…] only create Revision objects when they are needed, so that the class can (eventually) be hard deprecated

I know. But what is the point of that if the class is not hard-deprecated? The constructor is as cheap as it can be. The extra conditionals are possibly expensive, and add unnecessary additional sources of errors, mistakes, and confusing.

Wed, Jun 24, 3:28 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
daniel added a comment to T246284: Hard deprecate the Revision class.

Let me again try and summarize the key points. Please tell me if I got anything wrong.

  • Hard-deprecating the class means making the constructor emit a deprecation warning.
  • Deprecation breaks nothing in production, but is does effectively block development until, since it makes phpunit tests fail for code that uses deprecated functionality.
  • We can hard-deprecate things only if we have no callers in deployed code (except in code that is itself hard-deprecated).
  • We may delay hard-deprecating things still in use by third parties, but only in exceptional cases.
  • We are currently constructing Revision objects in non-deprecated code in core in about 20 places, in order to pass them to hooks.
  • All hooks that take Revision objects seem to be (soft) deprecated
  • IIRC, adding hooks to DeprecatedHooks means hard-deprecating them, causing a warning when extensions use them. This should currently only be the case for hooks soft-deprecated in 1.34 or earlier.
Wed, Jun 24, 3:23 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team, Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712

Tue, Jun 23

daniel updated the task description for T247862: Stable Interface Policy annotations.
Tue, Jun 23, 3:39 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Core Platform Team Workboards (Green)

Mon, Jun 22

daniel awarded T256006: Test fails with "Can't reopen table" error. a The World Burns token.
Mon, Jun 22, 3:00 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Tracking-Neverending, Core Platform Team, MediaWiki-Core-Testing, Wikimedia-Rdbms, Testing-Roadblocks
daniel updated the task description for T256006: Test fails with "Can't reopen table" error..
Mon, Jun 22, 2:59 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Tracking-Neverending, Core Platform Team, MediaWiki-Core-Testing, Wikimedia-Rdbms, Testing-Roadblocks
daniel updated the task description for T256006: Test fails with "Can't reopen table" error..
Mon, Jun 22, 2:57 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Tracking-Neverending, Core Platform Team, MediaWiki-Core-Testing, Wikimedia-Rdbms, Testing-Roadblocks
daniel created T256006: Test fails with "Can't reopen table" error..
Mon, Jun 22, 2:55 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Tracking-Neverending, Core Platform Team, MediaWiki-Core-Testing, Wikimedia-Rdbms, Testing-Roadblocks
daniel added a comment to T251778: LBFactoryMulti: Unknown cluster 'cluster14'.

I think the solution is to have one mode that lists IDs and problems, and another to mark IDs. The latter should still only mark if there are indeed problems with the given IDs, and warn if there are none.

Mon, Jun 22, 10:42 AM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-General-or-Unknown, Wikimedia-production-error

Fri, Jun 19

daniel added a comment to T251778: LBFactoryMulti: Unknown cluster 'cluster14'.

findBadBlobs already has a mode that thaks a list of revision IDs, […], and marks the inaccessible ones in that batch.

Awesome, I didn't know that :)

I tried to use it just now for e.g. testwiki rev ID 27195. But it doesn't work right now because it requires a BlobAccessException/ExternalStoreException and for the one we are facing now, it fatals due to LBFactory InvalidArgumentException

Fri, Jun 19, 7:00 PM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-General-or-Unknown, Wikimedia-production-error
daniel added a comment to T251805: Contributor gets own contribution count.

Counting revisions created by a user is simple enough, but as we discovered during our work on T200259, not all contributions are revisions, some or other things defined by extensions (e.g. discussion contributions from the Flow extension). That complicates things a lot. We would have to live with an inconsistency between the number of contributions listed by /me/contributions, and the number returned by /me/contributions/count for now. We can then introduce a new hook that allows extensions to add to that number to make things consistent again.

Fri, Jun 19, 3:49 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel added a comment to T252202: Contributor gets their own contributions.

We hit a snag with the "stable paging" requirement, as details in T200259: While we could implement stable paging based on timestamp and revision ID for a vanilla MediaWiki install, there are extensions (most notably Flow) that inject "contributions" that are not revisions. It be additional effort to ensure we are not breaking such extensions when changing how the paging works. But more importantly, it's unclear even on a conceptual level how stable paging could work if extensions can mix in arbitrary kinds of "contributions" that do not share a set of unique keys. We will leave the resolution of this issue for later.

Fri, Jun 19, 3:27 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Fri, Jun 19, 3:24 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Thu, Jun 18

daniel awarded T157658: Factor out a backend from EditPage a Love token.
Thu, Jun 18, 9:35 PM · User-DannyS712, Core Platform Team, MediaWiki-Page-editing
daniel updated the task description for T200259: ContribsPager should use a unique criterion for paging.
Thu, Jun 18, 9:03 PM · Core Platform Team Workboards (External Code Reviews), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), WMDE-QWERTY-X-Mas-Sprint-2018-12-18, MediaWiki-Special-pages, WMDE-QWERTY-Sprint-2018-12-04

Wed, Jun 17

daniel added projects to T255704: Fatal LogicException: Role mediainfo is already defined (DiscussionTools conflicts with WikibaseMediaInfo): Core Platform Team, User-Daniel, Dependency injection.

Tagging CPT to have a look, in the light of @matmarex analysis.

Wed, Jun 17, 9:21 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Dependency injection, User-Daniel, Core Platform Team, Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools, Structured-Data-Backlog, Structured Data Engineering, WikibaseMediaInfo, User-brennen, Wikimedia-production-error
daniel added a comment to T250406: RFC: Hybrid extension management.

Unless I'm missing something, composer-merge-plugin is currently the only way cleanly and sanely set up extensions in a development environment. @bd808 is there an alternative to merge-plugin for that use case? Running composer for each extension only works if there are no version conflicts...

Wed, Jun 17, 8:50 PM · MediaWiki-Stakeholders-Group, TechCom-RFC
daniel added a comment to T254271: Should HookRunner be in the service container?.

This reminds me of Symfony's concept of Public vs Private services. Effectively, "private" services can only be injected. They cannot be accessed directly from the container. They even insist that private services are the norm, rather than the exception. Perhaps it would be wise to make a pattern like this in MediaWiki?

Wed, Jun 17, 3:14 PM · CPT Initiatives (New Hook System), MediaWiki-Core-Hooks, MediaWiki-ServiceContainer, Core Platform Team, TechCom
daniel added a comment to T254271: Should HookRunner be in the service container?.

That makes perfect sense to me. Although, @Anomie's comment in T240307#5728354 seems to imply the exact opposite. :/

Wed, Jun 17, 2:55 PM · CPT Initiatives (New Hook System), MediaWiki-Core-Hooks, MediaWiki-ServiceContainer, Core Platform Team, TechCom
daniel moved T255572: Should MediaWiki services encourage the command pattern or avoid it? from Inbox to Watching on the TechCom board.
Wed, Jun 17, 2:32 PM · Core Platform Team, TechCom, MediaWiki-ServiceContainer
daniel added a comment to T254271: Should HookRunner be in the service container?.

I just realized that the HookRunner in the patch is CheckUser's own hook runner. I'd argue that extensions can handle their own hook runners as they please. CheckUser could add a CheckUserHookRunner service to the service container, or instantiate HookRunners on the fly, as seems convenient. CheckUser could also make a CheckUserServices class that wraps MediaWikiServices (or just has its own wiring) to provide a getHookRunner() method. The things I said above apply to core's HookRunner, and to core's MediaWikiServices and service wiring.

Wed, Jun 17, 2:20 PM · CPT Initiatives (New Hook System), MediaWiki-Core-Hooks, MediaWiki-ServiceContainer, Core Platform Team, TechCom
daniel added a comment to T255572: Should MediaWiki services encourage the command pattern or avoid it? .

The "command" pattern is useful especially for operations that take a lot of operations or parameters, and that produce complex state. Creating dedicated value objects for the input and output would be possible, but I don't see the advantage in that. It seems awkward to have a PageMover and a PageMoveParameters and a PageMoveResult class. a MovePage command comming from a PageCommandFactory seems more straight forward.

Wed, Jun 17, 9:01 AM · Core Platform Team, TechCom, MediaWiki-ServiceContainer
daniel added a comment to T251778: LBFactoryMulti: Unknown cluster 'cluster14'.

Per my code review at https://gerrit.wikimedia.org/r/597283, I don't think we should tolerate undefined ES or LBFactory stores, this is an infrastructure issue, not an issue with the format of anything in the database, and hopefully a one-off. Ignoring these at the cost of a general bad-wipe in the future due to something intermittent seems like a high risk that we can avoid at little to no cost by fixing these by hand instead.

Wed, Jun 17, 8:54 AM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-General-or-Unknown, Wikimedia-production-error

Tue, Jun 16

daniel added a comment to T254175: 1.35.0-wmf.38 deployment blockers.

Just adding a quick note, that cpt has moved some mediawiki REST endpoints from /v0 namespace into /v1 (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/604441). This shouldn't be a problem but just making a note of it.

Tue, Jun 16, 9:12 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Release, Train Deployments
daniel added a comment to T249434: Replace hooks using Revision objects with RevisionRecord.

I'm confused - this ticket is about deprecating hooks, right? Skimmed the discussion, and it seems to be about deprecating construction of Revision objects.

Tue, Jun 16, 8:10 AM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712

Mon, Jun 15

daniel updated the task description for T252202: Contributor gets their own contributions.
Mon, Jun 15, 8:45 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Mon, Jun 15, 8:44 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel added a comment to T238966: Apply updates for MCR, actor migration, and content migration, to production wikis..

@daniel the new columns can be replicated safely to labsdb hosts?

rev_comment_id
rev_actor
Mon, Jun 15, 8:40 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Cloud-Services, DBA, Schema-change, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration)
daniel added a comment to T238966: Apply updates for MCR, actor migration, and content migration, to production wikis..

Some other exceptions seeing on testwiki right now

...

Probably unrelated, but given how complex this schema change is, better be safe than sorry so asking @daniel to confirm this and the previous errors are not related to this schema change before proceeding.

Mon, Jun 15, 8:38 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Cloud-Services, DBA, Schema-change, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration)

Fri, Jun 12

daniel added a comment to T249598: Wikibase schema updaters must not modify database directly.

The original core test still throws errors that seem related to Wikibase

You mean this one? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/475065

Fri, Jun 12, 11:18 AM · User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Patch-For-Review, Wikidata
daniel moved T229443: Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle makeTitleSafe via GeoCrumbsHooks) from Next to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Jun 12, 10:25 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), User-brennen, MediaWiki-extensions-WikimediaIncubator, Core Platform Team Workboards (Clinic Duty Team), GeoCrumbs, incubator.wikimedia.org, Wikimedia-production-error
daniel added a comment to T229443: Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle makeTitleSafe via GeoCrumbsHooks).

This is cased by getBaseTitle() when the title starts with a "/", e.g. https://de.wikivoyage.org/wiki//portugal (https://de.wikivoyage.org/wiki/portugal works fine).

Fri, Jun 12, 10:25 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), User-brennen, MediaWiki-extensions-WikimediaIncubator, Core Platform Team Workboards (Clinic Duty Team), GeoCrumbs, incubator.wikimedia.org, Wikimedia-production-error

Thu, Jun 11

daniel added a project to T230211: Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests.: Testing-Roadblocks.
Thu, Jun 11, 8:04 PM · Testing-Roadblocks, CPT Initiatives (API Integration Tests), Performance-Team (Radar), Patch-For-Review, MediaWiki-API
daniel updated subscribers of T230211: Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests..

Pinging @aaron, since we were just talking about this.
This is currently not a huge problem, though I think we could speed up the e2e tests by having this. We could avoid calling Special:RunJobs for nearly all cases. This will become more relevant as we get more e2e tests.

Thu, Jun 11, 8:04 PM · Testing-Roadblocks, CPT Initiatives (API Integration Tests), Performance-Team (Radar), Patch-For-Review, MediaWiki-API

Wed, Jun 10

daniel added a comment to T254271: Should HookRunner be in the service container?.

I'm not sure I understand why the HookRunner wouldn't be in the service container itself? Is there a value to instantiating a new instance of the HookRunner for each service?

Wed, Jun 10, 7:30 PM · CPT Initiatives (New Hook System), MediaWiki-Core-Hooks, MediaWiki-ServiceContainer, Core Platform Team, TechCom
daniel added a comment to T255043: Move Minimal client REST API endpoints from coredev/v0 to v1.

Cool. Can we change "html_type" to the actual values?

Wed, Jun 10, 7:20 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel added a comment to T255043: Move Minimal client REST API endpoints from coredev/v0 to v1.

Seems like we have two conflicting routes:

Wed, Jun 10, 6:32 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Wed, Jun 10, 4:25 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel closed T248684: Add support for logged in clients to REST testing framework as Resolved.
Wed, Jun 10, 4:13 PM · Patch-For-Review, Core Platform Team Workboards (Green), Testing-Roadblocks, CPT Initiatives (API Integration Tests)

Jun 9 2020

daniel updated the task description for T252202: Contributor gets their own contributions.
Jun 9 2020, 6:12 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Jun 9 2020, 3:59 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Jun 9 2020, 3:32 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
daniel updated the task description for T252202: Contributor gets their own contributions.
Jun 9 2020, 3:31 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)