Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Projects (18)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (231 w, 3 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Today

daniel added a comment to T218456: mwselenium-quibble-docker test broken for WikibaseLexeme.

@daniel I guess that is actually https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/466981/ for the retry strategy? Which doesn't appear to be merged yet.

Mon, Mar 18, 4:09 PM · CirrusSearch, Discovery-Search, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error (Shared Build Failure), Wikidata, Lexicographical data
daniel added a comment to T218456: mwselenium-quibble-docker test broken for WikibaseLexeme.

Is it possible that you are seeing something fail during the retry, but the cause for the retry was something else?

Mon, Mar 18, 4:01 PM · CirrusSearch, Discovery-Search, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error (Shared Build Failure), Wikidata, Lexicographical data
daniel added a comment to T218456: mwselenium-quibble-docker test broken for WikibaseLexeme.

That raises the question why that job fails.

Mon, Mar 18, 4:00 PM · CirrusSearch, Discovery-Search, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error (Shared Build Failure), Wikidata, Lexicographical data
daniel added a comment to T218456: mwselenium-quibble-docker test broken for WikibaseLexeme.

The patch in question should only chnange the behavior of *failing* DataUpdates. If no DataUpdates fail, the new behavior should be exactly the same as the old.

Mon, Mar 18, 3:55 PM · CirrusSearch, Discovery-Search, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error (Shared Build Failure), Wikidata, Lexicographical data
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

It also sounds like using DBAL, if it works out, would be only one piece of the whole task here? So some amount of additional development would probably be needed in any case to achieve the goals here.

Mon, Mar 18, 3:31 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
daniel updated the task description for T218558: Move User::getRights and related methods into PermissionManager.
Mon, Mar 18, 2:59 PM · MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Core Platform Team Backlog (Next), Core Platform Team (Decoupling (CDP2))
daniel updated the task description for T218558: Move User::getRights and related methods into PermissionManager.
Mon, Mar 18, 2:58 PM · MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Core Platform Team Backlog (Next), Core Platform Team (Decoupling (CDP2))
daniel edited projects for T208776: Introduce PageIdentity to be used instead of Title, added: Core Platform Team (Decoupling (CDP2)), MediaWiki-Decoupling; removed Core Platform Team (Code Health (TEC13)).
Mon, Mar 18, 2:42 PM · MediaWiki-Decoupling, Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later)
daniel updated the task description for T208776: Introduce PageIdentity to be used instead of Title.
Mon, Mar 18, 2:42 PM · MediaWiki-Decoupling, Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later)
daniel updated the task description for T208776: Introduce PageIdentity to be used instead of Title.
Mon, Mar 18, 2:32 PM · MediaWiki-Decoupling, Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Later)
daniel updated the task description for T218558: Move User::getRights and related methods into PermissionManager.
Mon, Mar 18, 2:06 PM · MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Core Platform Team Backlog (Next), Core Platform Team (Decoupling (CDP2))
daniel added a parent task for T208768: Create a PermissionManager service: T218558: Move User::getRights and related methods into PermissionManager.
Mon, Mar 18, 11:27 AM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Patch-For-Review, MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel added a subtask for T218558: Move User::getRights and related methods into PermissionManager: T208768: Create a PermissionManager service.
Mon, Mar 18, 11:26 AM · MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Core Platform Team Backlog (Next), Core Platform Team (Decoupling (CDP2))
daniel created T218558: Move User::getRights and related methods into PermissionManager.
Mon, Mar 18, 11:26 AM · MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Core Platform Team Backlog (Next), Core Platform Team (Decoupling (CDP2))
daniel created T218555: Provide access to WebRequest and associated information via a service object.
Mon, Mar 18, 11:10 AM · Core Platform Team Backlog (Later), Core Platform Team (Decoupling (CDP2)), MediaWiki-Decoupling
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

Yes, That's my suggestion here, we can use DBAL as much as possible and write other parts we need.

Mon, Mar 18, 10:08 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Fri, Mar 15

daniel placed T218395: Create RestrictionStore service up for grabs.
Fri, Mar 15, 4:21 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4)
daniel edited projects for T208768: Create a PermissionManager service, added: Core Platform Team Backlog (Watching / External); removed Core Platform Team Backlog (Later).
Fri, Mar 15, 4:19 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Patch-For-Review, MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel added a parent task for T218394: Create BlockStore service: T208764: Remove cyclic dependency between Title and User classes.
Fri, Mar 15, 12:28 PM · Core Platform Team Backlog (Watching / External), Core Platform Team (Decoupling (CDP2)), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4)
daniel added a subtask for T208764: Remove cyclic dependency between Title and User classes: T218394: Create BlockStore service.
Fri, Mar 15, 12:28 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team (Code Health (TEC13))
daniel created T218395: Create RestrictionStore service.
Fri, Mar 15, 12:23 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4)
daniel edited projects for T218394: Create BlockStore service, added: MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Core Platform Team Backlog (Next); removed MediaWiki-Decoupling.
Fri, Mar 15, 12:16 PM · Core Platform Team Backlog (Watching / External), Core Platform Team (Decoupling (CDP2)), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4)
daniel created T218394: Create BlockStore service.
Fri, Mar 15, 12:10 PM · Core Platform Team Backlog (Watching / External), Core Platform Team (Decoupling (CDP2)), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4)
daniel added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Should compressOld.php and trackBlobs.php be in the same patch, as they both suffer from the " processing multiple blobs per revision" problem?

Fri, Mar 15, 11:11 AM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

I would like to understand the problem better. If DBAL can do the schema changes, why can't we use it for the schema changes, even if it doesn't help us with the other parts of the issue?

Fri, Mar 15, 11:02 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Thu, Mar 14

daniel added a comment to T217158: RFC: Skin templating.

Consistent CSS classes and element IDs would indeed be great. This could go along with documentation stating explicitly what guarantees are (not) given.

Thu, Mar 14, 9:29 PM · TechCom-RFC
daniel added a comment to T217158: RFC: Skin templating.
I would truly value having a proper API for accessing skins via gadgets rather than relying on CSS selectors.
Thu, Mar 14, 8:53 PM · TechCom-RFC
daniel edited projects for T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only), added: Core Platform Team Kanban (Waiting for Review); removed Core Platform Team Kanban (Doing).
Thu, Mar 14, 7:56 PM · Core Platform Team Kanban (Waiting for Review), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Here's one place where Daniel and I differ: I'd put most of these in one patch instead of having 10+ single-file changes.

Thu, Mar 14, 7:49 PM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T217158: RFC: Skin templating.

What are everyone's thoughts on how to address making a consistent DOM across all skins?

Thu, Mar 14, 7:45 PM · TechCom-RFC
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

I note the review so far seems to have ignored that part of schema changes is checking the existing schema to determine whether the schema needs changing (MW currently does a somewhat crappy job of this).

Good point but I think we should focus scope of this ticket to unify and abstract away schema changes and not fix all of the issues with our current schema change system.

Thu, Mar 14, 12:51 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
daniel added a comment to T218183: Audit uses of PHP DOM in Wikimedia software.

We could use this in the PageLayoutFormatter stuff that MCR promises but hasn't yet delivered (see T209878). Right now in WikibaseMediaInfo we're having to do a series of regexs (:-().

Thu, Mar 14, 7:20 AM · TechCom, MediaWiki-General-or-Unknown, Parsoid-PHP
daniel added a comment to T193613: Come up with a strategy for handling PHP interface changes.

This came up a while back in an internal meeting to revisit at some point. I'm not 100% sure whether the above is result of that already happening or whether there is something specific Daniel wanted us to do as a group.

Thu, Mar 14, 7:15 AM · TechCom, TechCom-RFC, MediaWiki-General-or-Unknown
daniel added a comment to T217158: RFC: Skin templating.

@Skizzerz TechCom is trying to shift weight from IRC meetings to discussion here on phabricator. For this purpose, I suggest to copy the essential parts of the RFC from the wiki to the task description and writing an email to wikitech-l, asking for input. This would mean moving the RFC to "under discussion" on the RFC board for now. If it appears like there is consensus forming in the discussion on this ticket, we could perhaps move the RFC directly to last call without the need for an IRC meeting (or you could request an IRC meeting again, if you think it would be useful).

Thu, Mar 14, 7:08 AM · TechCom-RFC
daniel moved T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL from Inbox to Under discussion on the TechCom-RFC board.
Thu, Mar 14, 6:25 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
daniel edited projects for T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL, added: TechCom-RFC; removed TechCom.

Accepted as an RFC

Thu, Mar 14, 6:24 AM · TechCom-RFC, Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations

Wed, Mar 13

daniel added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

rev_text_id references that will be removed/refactored in this task:

  • includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated)
Wed, Mar 13, 8:32 PM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated)

Wed, Mar 13, 8:08 PM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T218127: Use CommentStoreComment throughout MediaWiki.

Then why are we even using the Message class for comments?

Because Wikibase wants i18n.

Wed, Mar 13, 5:32 PM · Shape Expressions, Wikidata, MediaWiki-Comment-backend
daniel added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Question on one occurrence of these fields: is the maintenance script fixT22757.php still relevant?

Wed, Mar 13, 9:33 AM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T218135: +2 in mediawiki/* for WMDE engineers.

To clarify: the intent of the new policy is to allow +2 access to be granted without community discussion or consensus building, upon request of trusted organizations. This does not imply a right or automatism for that request to be followed, it can still be denied or revoked at the discretion of the groups/roles mentioned in the policy. This means that membership in a trusted org's own group must not auomatically imply membership in the mediawiki group.

Wed, Mar 13, 9:24 AM · MediaWiki-Gerrit-Group-Requests

Tue, Mar 12

daniel added a comment to T138708: [Epic] Signed statements.

Note that "click 'sign this' icon next to a statement" imply a fundamentally insecure and broken process. You don't sign something after it is uploaded, you sign it before and while it is still on your own machine. The JSON code snippet should be signed, and then a provenance for the statement including that snippet should be provided.

Tue, Mar 12, 11:47 AM · Epic, Need-volunteer, Wikidata
daniel added a comment to T217881: Decide whether to keep violating OpenAPI/Swagger specification in our REST services.
/required?optional1=value1&optional2=value2
Tue, Mar 12, 9:57 AM · Core Platform Team Kanban (Done with CPT), Services (done), TechCom, RESTBase-API, serviceops, Operations

Mon, Mar 11

daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

@Ladsgroup that seems quite promising! @Anomie, do you think this is ready for a prove-of-concept?

Mon, Mar 11, 1:51 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Fri, Mar 8

daniel added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.

@daniel: You should go read what I wrote in T212482#4841064.

Fri, Mar 8, 4:23 PM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom
daniel added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.

The proposal states:

Fri, Mar 8, 1:07 PM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom

Thu, Mar 7

daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

Reading the minutes of the meeting (sorry I couldn't join) I volunteer to do a basic research on Doctorine and how feasible it is to use. Is it okay with the TechCom and @Anomie ?

Thu, Mar 7, 3:21 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Wed, Mar 6

daniel added a comment to T216308: RFC Process: 2019 amendments.

I put some related thoughts here: https://www.mediawiki.org/wiki/User:DKinzler_(WMF)/TechCom_MO#RFC_Facilitation

Wed, Mar 6, 9:35 PM · TechCom-RFC, TechCom
daniel added a comment to T208768: Create a PermissionManager service.

Another thing that would be nice to figure out if there's an authz refactoring is T212639: Separate could do / can do / is doing permission checks in MediaWiki.

Wed, Mar 6, 12:53 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Patch-For-Review, MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel added a parent task for T212639: Separate could do / can do / is doing permission checks in MediaWiki: T208768: Create a PermissionManager service.
Wed, Mar 6, 12:49 PM · MediaWiki-Authentication-and-authorization
daniel added a subtask for T208768: Create a PermissionManager service: T212639: Separate could do / can do / is doing permission checks in MediaWiki.
Wed, Mar 6, 12:49 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Backlog (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4), Patch-For-Review, MediaWiki-Authentication-and-authorization, MediaWiki-User-management
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

But discussion of this argument with regards to things other than databases is off topic here.

That makes no sense, why is it off topic? I don't think it's very fair for you to make a broad claim saying that we should remove support for non-free software in core that CI doesn't test and then respond to a counter-argument with "that's off topic".

Wed, Mar 6, 12:41 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Tue, Mar 5

daniel changed IRC Nick from DanielK_WMDE to dues, duesen on daniel.
Tue, Mar 5, 7:26 PM
daniel created T217698: Security Issue Access Request for daniel.
Tue, Mar 5, 7:25 PM · Security-Team, Security
daniel added a project to T198099: Improve MCR handling of RevisionAccessException family: User-Daniel.
Tue, Mar 5, 5:36 PM · User-Daniel, Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel triaged T198099: Improve MCR handling of RevisionAccessException family as Normal priority.
Tue, Mar 5, 5:35 PM · User-Daniel, Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel updated the task description for T198099: Improve MCR handling of RevisionAccessException family.
Tue, Mar 5, 5:34 PM · User-Daniel, Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel renamed T203587: Major overhaul for "throttle" action in AbuseFilter from Major overhaul for "throttle" action to Major overhaul for "throttle" action in AbuseFilter.
Tue, Mar 5, 3:22 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Code Health (TEC13)), User-Daimona, Patch-For-Review, Technical-Debt, AbuseFilter
daniel added a comment to T216842: Specify license of mediawiki/Wikibase/WikibaseLexeme ontology.

Any of the patches require a +1 from all of people who contributed to the files otherwise will be legally in trouble (we can't just change license of a file)

Tue, Mar 5, 10:48 AM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

Are you proposing to drop support for all calls to wfIsWindows() for Windows compatibility or any macOS workarounds? What about the few hacks that are there for proprietary webservers? Or the compatibility JavaScript we have for proprietary web browsers? None of those run through our CI.

Tue, Mar 5, 9:16 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

So while it was fun working on this project i have lost track of the changes more than a year ago and I think it's best interest of everyone, that if you do not plan to keep it in the core and offer active support and maintenance from the core dev side, to just draw a line and drop the proprietary DB code from repos.

Tue, Mar 5, 8:16 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Mon, Mar 4

daniel updated the task description for T217607: MediaWikiTestCase::copyTestData does not work on Postgres and SQLite.
Mon, Mar 4, 9:54 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Core-Testing, PostgreSQL, SQLite, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Code Health (TEC13))
daniel moved T217607: MediaWikiTestCase::copyTestData does not work on Postgres and SQLite from Inbox to Doing on the Core Platform Team Kanban board.
Mon, Mar 4, 9:50 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Core-Testing, PostgreSQL, SQLite, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Code Health (TEC13))
daniel created T217607: MediaWikiTestCase::copyTestData does not work on Postgres and SQLite.
Mon, Mar 4, 9:49 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Core-Testing, PostgreSQL, SQLite, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Code Health (TEC13))
daniel closed T214316: Remove unused method Title::validateFileMoveOperation as Resolved.
Mon, Mar 4, 6:46 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Core Platform Team (Code Health (TEC13)), Technical-Debt, Multimedia, Commons, MediaWiki-Decoupling, MediaWiki-File-management
daniel closed T214316: Remove unused method Title::validateFileMoveOperation, a subtask of T208786: Untangle MediaHandler, FileRepo, File, Title and Linker, as Resolved.
Mon, Mar 4, 6:46 PM · Core Platform Team Kanban, MediaWiki-Decoupling, MediaWiki-File-management, Core Platform Team (Code Health (TEC13)), Multimedia, Commons
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

Wikimedia CI as a matter of principle (backed up by the terms of use) isn't going to support any non-free software regardless of whether it's installed locally or connecting over the network.

Mon, Mar 4, 1:57 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Thu, Feb 21

daniel added a comment to T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage.

We can continue to generate constraint check data on the fly when missing in GETs and simply not put it in the storage.

Thu, Feb 21, 8:54 AM · Core Platform Team Backlog (Designing), Services (designing), User-mobrovac, wikidata-tech-focus, TechCom-RFC, Wikibase-Quality, Wikidata
daniel added a comment to T215465: Development policy amendment: Require use of storage abstraction layers.

I guess there is no harm in writing this down but it happens even without a policy. Why would anyone not use service abstraction layers?
RedisConnectionPool and BagOStuff are at very different levels of abstraction, though.

What about higher abstraction layers like the XxxStore classes? Do we generally expect non-legacy code to use that?

Thu, Feb 21, 8:23 AM · Services (watching), Core Platform Team Backlog (Watching / External), Performance-Team, TechCom

Tue, Feb 19

daniel moved T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only) from Waiting for Review to Doing on the Core Platform Team Kanban board.
Tue, Feb 19, 3:57 PM · Core Platform Team Kanban (Waiting for Review), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

@ssastry @Anomie is this done? Can the ticket be closed?

Tue, Feb 19, 3:29 PM · Patch-For-Review, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Parsoid, TemplateStyles, MediaWiki-Parser
daniel added a comment to T215918: Integration testing for email.

Sendmail integration could perhaps be tested on the beta cluster, but it would need manual patching.

Tue, Feb 19, 3:19 PM · Core Platform Team Kanban (Doing)
daniel moved T216200: includes/specials/pagers/ActiveUsersPager.php: PHP Notice: Undefined index: dir from Inbox to Security, stability, performance and scalability (TEC1) on the Core Platform Team board.
Tue, Feb 19, 3:11 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, MediaWiki-User-management, Wikimedia-production-error
daniel moved T212521: RFC: Let's stop using QUnit as a mechanism for integration tests from Inbox to Under discussion on the TechCom-RFC board.
Tue, Feb 19, 1:53 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
daniel moved T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage from Inbox to Backlog on the TechCom-RFC board.

Moving to backlog, since we are waiting for feedback from the RFC's author.

Tue, Feb 19, 1:52 PM · Core Platform Team Backlog (Designing), Services (designing), User-mobrovac, wikidata-tech-focus, TechCom-RFC, Wikibase-Quality, Wikidata
daniel added a comment to T212521: RFC: Let's stop using QUnit as a mechanism for integration tests.

I think this is a good direction, but I'm skeptical that we can, without a lot more effort, get rid of browser QUnit tests. A number of them depend on the MediaWiki environment (or literally on being in a browser) and it can be difficult or cumbersome to mock the MW environment and/or the browser environment (including the DOM) faithfully enough to make these tests work.

Tue, Feb 19, 1:51 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
daniel added a comment to T216308: RFC Process: 2019 amendments.

Here are a few ideas I have:

  • provide a checklist for "when should I file an RFC"
  • provide a checklist for "what should be in an RFC document"
  • consider a last call with no feedback from outside TechCom failed. Positive feedback would be required for an RFC to be approved. This ensures that we solicit input from relevant stakeholders.
  • make explicit that it is TechCom's job to solicit input from relevant stakeholders. Presently, we usually just hope that relevant people would read the radar email and react.
Tue, Feb 19, 1:45 PM · TechCom-RFC, TechCom
daniel added a comment to T216308: RFC Process: 2019 amendments.

There is also the change that Marko proposed: require the RFC to be on phabricator, with the option to reference wiki pages; and require teh RFC discussion to be on phabricator, and discourage on-wiki discussion once discussion on phab has started.

Tue, Feb 19, 1:42 PM · TechCom-RFC, TechCom
daniel added a comment to T203860: Consider making NameTableStore easier to use.

I propose that getID() return null instead of throwing a NameTableAccessException

Tue, Feb 19, 8:27 AM · User-Addshore, MediaWiki-General-or-Unknown

Mon, Feb 18

daniel added a comment to T198557: Remove support for legacy pre-MCR schema.

I'm happy to, but it appears that I cannot edit or claim the task.

Mon, Feb 18, 7:16 PM · Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Later), Core Platform Team (MCR), MW-1.33-release, Wikidata
daniel updated the task description for T198341: Remove all references to the rev_text_id and ar_text_id fields.
Mon, Feb 18, 7:15 PM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
daniel added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Task description refers to "RevisionStore::newRevisionRecordFromRow()". Should that be "RevisionStore::newRevisionFromRow()"?

Mon, Feb 18, 7:15 PM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Sun, Feb 17

daniel added a comment to T212911: My account was removed from the Wikimedia Github group.

@Aklapper As far as I understand, the ultimate authority on who should have access to which of our repos is the CTO. Relevant angles on the issue can probably be provided by community engagement, legal, and HR. No idea what the best venue for discussion is, sorry...

Sun, Feb 17, 10:55 PM · Security

Feb 15 2019

daniel added a comment to T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .

All usages in core are gone. Now we should remove usages in extensions, at least in the ones WMF maintains. Dow we want to have a separate ticket for that? The current task description doesn't call for usages to be removed.

Feb 15 2019, 6:46 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Feb 14 2019

daniel added a comment to T213318: Wikibase Front-End Architecture.

On the other hand (at least for those employed by the Foundation), this is real money that is being used by our "customers" (our donors), so I think it's important to know what our Product strategy is (I assume we have one, but I'm not aware of it). Without that, I don't know how we can make informed decisions about the platforms we should or should not support.

Feb 14 2019, 8:58 PM · TechCom-RFC (TechCom-Approved), Wikidata
daniel added a comment to T213318: Wikibase Front-End Architecture.

Are our target demographics (and the reason why we are targeting them) documented somewhere?

Feb 14 2019, 8:50 PM · TechCom-RFC (TechCom-Approved), Wikidata
daniel added a comment to T213318: Wikibase Front-End Architecture.

Having both 1 and 2 at the same time would be awesome, but I guess I'd also be fine with saying "you can have 1 but lose support for 2 or you can have 2 but then you need to have install beyond 1". By which I mean, if the install runs only minimum LAMP stack, basic functionality supplied may not necessary include all necessary for supporting 2. That would not be perfect but I think still OK.

Feb 14 2019, 8:48 PM · TechCom-RFC (TechCom-Approved), Wikidata
daniel added a comment to T213318: Wikibase Front-End Architecture.

I wasn't aware of that. Could we update the Principles page to reflect that?

Feb 14 2019, 2:52 PM · TechCom-RFC (TechCom-Approved), Wikidata
daniel added a comment to T213318: Wikibase Front-End Architecture.

Another solution to this problem would be to require Docker and Kuberneties which are both free and trivial to setup (especially if we distribute MediaWiki and all of it's services with Helm)

Feb 14 2019, 2:33 PM · TechCom-RFC (TechCom-Approved), Wikidata
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

@Smalyshev My understanding (which may be dated or incomplete) is this: there would be no PHP rendering, JS rendering would need to happen either in the browser on on the server. If the server supports SSR (e.g. for Wikimedia projects), you can read with a non-JS browser. If the server does not support SSR (e.g. on shared hosting), then you need a JS enabled browser to read.

Feb 14 2019, 7:28 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Feb 13 2019

daniel renamed T208764: Remove cyclic dependency between Title and User classes from Remove circular dependency between Title and User classes to Remove cyclic dependency between Title and User classes.
Feb 13 2019, 4:28 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team (Code Health (TEC13))
daniel added a comment to T205133: Review code metric tools.

Let me know if you need help triggering a build for core or an extension. Once https://gerrit.wikimedia.org/r/c/integration/config/+/487880 is merged you should be able to create a patch which defines a sonar-project.properties file and then run "check experimental", but until then it's a more manual process.

Feb 13 2019, 4:26 PM · Patch-For-Review, Code-Health-Metrics
daniel added a comment to T205133: Review code metric tools.

@daniel, could you elaborate? I would like to create a sub-task, but I want to make sure that it's not my interpretation.

Feb 13 2019, 11:46 AM · Patch-For-Review, Code-Health-Metrics
daniel added a comment to T205133: Review code metric tools.

Where can I find the sonarquebe interface?

Feb 13 2019, 11:44 AM · Patch-For-Review, Code-Health-Metrics
daniel added a comment to T205133: Review code metric tools.

For the record, I'm currently evaluating sonograph (a desktop code analysis tool).

Feb 13 2019, 11:43 AM · Patch-For-Review, Code-Health-Metrics
daniel removed a project from T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().: Release-Engineering-Team (Kanban).

@daniel: sorry, I don't see how/why this should go on the releng-kanban board?

Feb 13 2019, 11:40 AM · Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Feb 11 2019

daniel added a comment to T213318: Wikibase Front-End Architecture.

For reference: https://www.mediawiki.org/wiki/Wikibase/DataModel/Primer#Statements

Feb 11 2019, 3:10 PM · TechCom-RFC (TechCom-Approved), Wikidata
daniel added a comment to T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).

As I said multiple times, hypernormalization would bring performance concerns- right now image and revision are handled on separate tables. Unless you also implement MCR sharding, we should try to make separate concerns into separate tables. Let's not convert Mediawiki into Drupal. That doesn't mean image could not be a "slot", but leave metadata to its own separate table.

Feb 11 2019, 3:03 PM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Later), Commons, Multimedia, Schema-change, MediaWiki-File-management

Feb 10 2019

daniel added a comment to T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).
In T28741#4940685, @Tgr wrote:

Also revision deletion would have to trigger file version deletion, but only if all revisions of the page that reference a certain version of the file have been deleted. That would have to be a whole new mechanism, and does not fit neatly into MCR which treats content objects as completely opaque.

Feb 10 2019, 2:09 AM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Later), Commons, Multimedia, Schema-change, MediaWiki-File-management

Feb 9 2019

daniel added a comment to T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).
In T28741#4939578, @Tgr wrote:

We need the file metadata for the current version of the file and basic info like size and mime type for the old/deleted versions, so we'd still need two tables, a page analog and a content analog.

Feb 9 2019, 4:37 AM · Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Later), Commons, Multimedia, Schema-change, MediaWiki-File-management