Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (363 w, 2 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Fri, Sep 24

daniel added a comment to T284921: Remove "auto-number headings" preference .

Okay, even if there are some performance issues, let us decide ourselves if we want to live with these issues. The problems with this features affect only those who have activated it, did I understand that correctly?

Fri, Sep 24, 3:18 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering
daniel added a comment to T284921: Remove "auto-number headings" preference .

Another long time user of this feature here.

As it long as the current system is replaced by CSS counting I won’t complain.

Fri, Sep 24, 3:16 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering
daniel added a comment to T284921: Remove "auto-number headings" preference .

Okay, so why not writing a whole new version of this feature?

Fri, Sep 24, 3:15 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering

Mon, Sep 20

daniel edited projects for T285951: Some section links in search results are redlinks, added: Platform Team Workboards (MW Expedition); removed Platform Engineering.

I just looked at it for 15 minutes, and I can't see why this is broken, but other section titles with spaces and non-ascii chars work fine. I'll see if I can find some time to dig deeper next week.

Mon, Sep 20, 6:50 PM · Platform Team Workboards (MW Expedition), MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), User-brennen, Regression, Discovery-Search, CirrusSearch
daniel added a project to T285951: Some section links in search results are redlinks: Platform Engineering.
Mon, Sep 20, 6:21 PM · Platform Team Workboards (MW Expedition), MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), User-brennen, Regression, Discovery-Search, CirrusSearch

Sat, Sep 18

daniel added a comment to T284921: Remove "auto-number headings" preference .

Thanks. But you might remember the Hitchhiker's Guide to the Galaxy and the part about the planning charts that had been on display somewhere around Alpha Centauri for some fifty earth years without anyone ever realising it? ;)

Sat, Sep 18, 8:52 AM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering

Fri, Sep 17

daniel added a comment to T284917: Remove "stub threshold" preference.

Only a few people read the tech news. It was not properly announced in the projects. And of course no one could object this when no one knew of this. You're taking the easy way out...

Fri, Sep 17, 7:23 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), User-notice, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering
daniel added a comment to T284921: Remove "auto-number headings" preference .

The option to auto-number headings is very useful. I stronly oppose any plans to remove this feature. If you want to remove it, ask the communities locally but don't decide this covertly on Phabricator.

Fri, Sep 17, 7:00 AM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering

Thu, Sep 16

daniel closed T286877: newRevisionSlots argument check breaks stub dumps for svwiki as Resolved.

The root cause is still unclear, filed as T291164

Thu, Sep 16, 10:00 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Dumps-Generation
daniel merged task T291108: PHP Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete] into T290871: Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete in /var/www/html/core/includes/actions/DeleteAction.php at line 230].
Thu, Sep 16, 9:44 AM · MW-1.37-release, Platform Engineering, Wikimedia-production-error
daniel merged T291108: PHP Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete] into T290871: Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete in /var/www/html/core/includes/actions/DeleteAction.php at line 230].
Thu, Sep 16, 9:44 AM · MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), MW-1.37-release, MediaWiki-Page-deletion, User-Zabe
daniel closed T142295: Need for re-caching even in cases where user groups are not accessed!? as Resolved.

I assume this is no longer an issue since the introduction of UserGroupManager. Please re-open as apporpriate.

Thu, Sep 16, 8:48 AM · Patch-Needs-Improvement, User-Daniel, MediaWiki-User-preferences, MediaWiki-extensions-Lockdown
daniel added a comment to T291124: PHP Notice: Undefined index: format.

Once deployed, my understanding is the cache will still have objects serialized by the old wmf.21 code and thus contain the format property, they would thus fail to unserialize leading to the same issue. Or am I misunderstanding?

Thu, Sep 16, 8:13 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Performance-Team, MediaWiki-Cache, MW-1.37-release, Wikimedia-production-error

Tue, Sep 14

daniel updated the task description for T42786: Remove AjaxDispatcher from MediaWiki core.
Tue, Sep 14, 10:08 AM · Technical-Debt (Deprecation process), MW-1.27-release-notes, JavaScript, MediaWiki-General

Mon, Sep 13

daniel updated the task description for T284921: Remove "auto-number headings" preference .
Mon, Sep 13, 7:31 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering
daniel updated the task description for T284917: Remove "stub threshold" preference.
Mon, Sep 13, 7:31 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), User-notice, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering

Fri, Sep 10

daniel added a comment to T290706: Parser code for special page transclusion replaces main context.

and then SpecialPage::capturePath() does this:

Fri, Sep 10, 8:44 AM · MediaWiki-General, Dependency injection
daniel updated subscribers of T290706: Parser code for special page transclusion replaces main context.

@daniel I couldn't find the right tags but maybe this is interesting to you.

Fri, Sep 10, 8:41 AM · MediaWiki-General, Dependency injection
daniel added a comment to T290706: Parser code for special page transclusion replaces main context.

fetching the Vector.FeatureManager service, which is initialized using the request context;

Fri, Sep 10, 8:40 AM · MediaWiki-General, Dependency injection

Thu, Sep 9

daniel added a comment to T290211: EventStreams sending same data over and over (page links change).

Some observations off the top of my head:

  • If a link update (more specifically, a RefreshLinksJob) fails, it will be re-scheduled. That would cause the event to be re-sent (but for the same page and revision ID)
  • when a page gets re-parsed because a template was updated (e.g. by adding links to it), that will trigger an event with links updates that has nothing to do with the current revision ID of that page. Attributing the links update to the edit identified by rev_id is very often wrong.
  • Adding links to a template will cause the same links to show up as added to all pages that use that template.
  • The links go to external "authority files" (BNF, GND, LCCN, LNB are all classification systems used by libraries). Templates for external identifiers are often fed from Wikidata, so an edit on Wikidata would cause the page to be re-parsed and a links-update event to be fired. However, these identifiers are usually specific to a single page, so seeing the same update for multiple pages is surprising. Is it really the *exact* same, or does it just look kind of the same, because it's the same set of external identifiers, and most of them stay the same, and just one of them was updated?
Thu, Sep 9, 11:02 AM · Platform Engineering, Analytics, Event-Platform
daniel moved T290639: Move redirect lookup logic into a service object from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Thu, Sep 9, 9:54 AM · MediaWiki-Redirects, Platform Team Workboards (MW Expedition)
daniel created T290639: Move redirect lookup logic into a service object.
Thu, Sep 9, 9:53 AM · MediaWiki-Redirects, Platform Team Workboards (MW Expedition)

Fri, Sep 3

daniel added a comment to T284258: Knowledge store data model.

but if it's something we want to commit to long term then we absolutely need to consider making sections a Real Thing inside MediaWiki

Hm, I disagree. Sometimes it will be necessary to have 'materialized views' of data inside outside of the monolith in separate places. Wikidata Query Service is a great example (and the basic event driven architecture is similar to what is proposed for this Knowledge Store, IIUC). It runs a transformed view of Wikibase context to serve a different query model. Building everything in MediaWiki isn't going to scale (performance-wise and people-wise). We should make it is easier for more products (that are transformed materialized views of MW data) to be built outside of MediaWiki.

Fri, Sep 3, 1:54 PM · tech-decision-forum

Thu, Sep 2

daniel added a comment to T290203: Discussion of Event Driven Systems.

I made this doodle of an "event driven mediawiki" architecture a while ago. I had forgotten about this, but listening the "db inside out talk" made me remember. I'd be curious to hear in how far this matches other people's ideas:
https://lucid.app/documents/view/c5edd03c-677e-4e24-a7e2-d0aedbc73280

Thu, Sep 2, 7:30 PM · Data-Engineering, Analytics, Event-Platform

Wed, Sep 1

daniel added a comment to T281164: 1.37.0-wmf.23 deployment blockers.
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/549909
  • Summary:
    • This moves the code that handles page protection out of the Title class. It's a complex refactoring or critical functionality, and the code is hit on pretty much every request, in order to perform permission checks.
  • Test plan:
    • We improved phpunit test coverage of the old code and ensured good coverage of the new code. We also wrote extensive end-to-end tests to ensure that page protection still works as expected.
  • Places to monitor:
    • It is hard to ferosee what kind of issue would be cause by this. We were very careful not to break things, but we may still see errors due to e.g. type hints that have become more strict, or performance issues if we got the caching wrong somewhere. We may also see unintended changes in user facing behavior. All of these seem unlikely, but you never know.
    • Logstash: mediawiki-errors
    • Grafana: mediawiki-errors
  • Revert plan:
    • Identify and fix specific issue
    • Revert patch. This does not touch many files, we might see some conflicts in Title though. Note that the relevant code reads and writes to WanObjectCache. The structure of cache entries should be forward and backwards compatible.
    • If all fails, rollback train.
  • Affected wikis:
    • all
  • IRC contact: Duesen, Pchelolo. But better find Daniel or Petr on the platform-engineering slack channel.
  • UBN Task Projects/tags: Platform Team Workboards (MW Expedition) Platform Engineering
Wed, Sep 1, 8:14 AM · Release-Engineering-Team (Doing), Release, Train Deployments

Mon, Aug 30

daniel updated subscribers of T263166: Convert static mediawiki configuration to form more suitable for containers.

Pinging @hnowlan for contextual awareness.

Mon, Aug 30, 5:23 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s
daniel moved T290015: BacklinkCache: update callers of deprecated methods from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Mon, Aug 30, 3:43 PM · Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel created T290015: BacklinkCache: update callers of deprecated methods.
Mon, Aug 30, 3:43 PM · Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel created T289998: Improve test coverage of comment formatting methods in Linker.
Mon, Aug 30, 12:30 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Platform Team Workboards (MW Expedition)
daniel moved T272424: Make WikiPage a ProperPageIdentity from Waiting for release to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Mon, Aug 30, 8:02 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition)
daniel added a comment to T272424: Make WikiPage a ProperPageIdentity.

Is this task still blocked?

Mon, Aug 30, 8:02 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition)
daniel updated the task description for T272424: Make WikiPage a ProperPageIdentity.
Mon, Aug 30, 7:59 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition)
daniel updated the task description for T272424: Make WikiPage a ProperPageIdentity.
Mon, Aug 30, 7:59 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (MW Expedition)

Aug 26 2021

daniel added a comment to T263166: Convert static mediawiki configuration to form more suitable for containers.

The base layer would be per-site configuration. This can be pre-generated for each wiki, and be copied or mounted into the mediawiki containers. This rarely changes.

To clarify, when you say "into the containers" do you mean the container images or at runtime via a k8s volume (sourced from a configmap or otherwise)?

Aug 26 2021, 6:50 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s
daniel updated the task description for T278482: Add message parameter types for user groups, PageIdentity, LinkTarget, and UserIdentity..
Aug 26 2021, 5:49 PM · User-ArielGlenn, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MediaWiki-Internationalization, Platform Team Workboards (MW Expedition)
daniel claimed T282283: Create PageURLLookup service.
Aug 26 2021, 5:34 PM · Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel closed T281337: The internal cache used by Title::newFromText gets corrupted when Title instances are modified. as Resolved.
Aug 26 2021, 5:30 PM · Platform Team Workboards (MW Expedition), MediaWiki-General
daniel moved T281068: Remove Title in public interface of Parser from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.
Aug 26 2021, 5:27 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Parser, Platform Team Workboards (MW Expedition)
daniel moved T289625: PHP Deprecated: Use of ParserOptions::getUser was deprecated in MediaWiki 1.36. [Called from Flow\Content\BoardContent::getParserOutput] from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Aug 26 2021, 5:21 PM · User-Urbanecm, MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Platform Team Workboards (MW Expedition), Growth-Team, StructuredDiscussions, Wikimedia-production-error
daniel moved T289717: Wikimedia\Assert\PostconditionException: Postcondition failed: Revision had no page from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Aug 26 2021, 5:21 PM · Platform Team Workboards (MW Expedition), Editing-team (FY2021-22 Kanban Board), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), DiscussionTools, Wikimedia-production-error
daniel edited projects for T289717: Wikimedia\Assert\PostconditionException: Postcondition failed: Revision had no page, added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Aug 26 2021, 5:15 PM · Platform Team Workboards (MW Expedition), Editing-team (FY2021-22 Kanban Board), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), DiscussionTools, Wikimedia-production-error
daniel moved T255309: Remove UserRightsProxy and replace it's usages with UserGroupManager from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Aug 26 2021, 3:41 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Platform Team Workboards (MW Expedition), MediaWiki-extensions-CentralAuth, Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-User-management
daniel added a project to T255309: Remove UserRightsProxy and replace it's usages with UserGroupManager: Platform Team Workboards (MW Expedition).
Aug 26 2021, 3:41 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Platform Team Workboards (MW Expedition), MediaWiki-extensions-CentralAuth, Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-User-management
daniel updated Other Assignee for T287247: Create new UserGroupManager::addUserToGroups method, added: tchin.
Aug 26 2021, 3:36 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Platform Team Workboards (MW Expedition)
daniel added a comment to T287405: Refactor ILocalizedException to be DI-friendly..

Sequence to do this in a backwards-compatible way, according to the stable interface policy:

  1. write email to wikitech-l
  2. introduce abstract base class with old and new method. New method is implemented based on the old, old method is abstract.
  3. make all exceptions that are implementing ILocalizedException extend the base class
  4. wait for response on email
  5. add new method to to the interface, soft-deprecate the old method
  6. change callers of old method to new method
  7. change exceptions to implement the new method as well as the old method
  8. on the base class, implement the old method based on the new, deprecate calls to the old method
  9. remove old method from all relevant exceptions
Aug 26 2021, 3:33 PM · User-thiemowmde, WMDE-Technical-Wishes-Maintenance, Move-Files-To-Commons, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Dependency injection, User-DannyS712, Platform Team Workboards (MW Expedition)

Aug 25 2021

daniel added a comment to T289692: api.wikimedia.org fatal exception: Error: Call to a member function text() on string.

Educated guess based on a quick look at the code: In NotificationAlertComponent line 63, 'title' => $notificationAlert['text']->text() needs to be replaced by 'title' => $notificationAlert['text'].

Aug 25 2021, 2:59 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), MediaWiki-skins-WikimediaApiPortal, API-Portal, Platform Engineering
daniel moved T289190: ActionFactory: Error: Class 'New-topicAction' not found from Inbox to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.
Aug 25 2021, 12:32 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), User-DannyS712, Platform Team Workboards (Clinic Duty Team), Growth-Team, StructuredDiscussions, SecTeam-Processed
daniel added a comment to T289190: ActionFactory: Error: Class 'New-topicAction' not found.

Still happening, wasn't the fix supposed to be in 1.37.0-wmf.19?

Aug 25 2021, 12:32 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), User-DannyS712, Platform Team Workboards (Clinic Duty Team), Growth-Team, StructuredDiscussions, SecTeam-Processed
daniel added a project to T218446: Remove use of legacy page.page_restrictions field: Platform Engineering Code Jam.
Aug 25 2021, 12:25 PM · Platform Engineering Code Jam, MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Schema-change, MediaWiki-General, Technical-Debt (Deprecation process)
daniel added a project to T282105: WatchedItemStore should not write MapCacheLRU instances to a BagOStuff: Platform Engineering Code Jam.

tagging for code jam

Aug 25 2021, 12:22 PM · Platform Engineering Code Jam, Unstewarded-production-error, Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MediaWiki-Watchlist, Growth-Team, Performance-Team (Radar)
daniel claimed T261848: Simulate databases for sister sites in phpunit.
Aug 25 2021, 11:27 AM · Platform Engineering Code Jam, Patch-For-Review, Platform Engineering Roadmap Decision Making, Code-Health, MediaWiki-Core-Tests, Testing-Roadblocks
daniel moved T261848: Simulate databases for sister sites in phpunit from Ideas Q1 21/22 to Ready Q1 21/22 on the Platform Engineering Code Jam board.
Aug 25 2021, 11:27 AM · Platform Engineering Code Jam, Patch-For-Review, Platform Engineering Roadmap Decision Making, Code-Health, MediaWiki-Core-Tests, Testing-Roadblocks

Aug 24 2021

daniel added a comment to T289351: SpecialWhatLinksHere: Trying to get property 'page_id' of non-object.

Not that this needs to be a security patch (it can go through gerrit) but this should fix the immediate issue of better handling the non-object error. Tested fine locally against master (89259d5a61):

Aug 24 2021, 10:10 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Wikimedia-production-error, SecTeam-Processed, MediaWiki-Special-pages, Platform Engineering
daniel added a project to T289351: SpecialWhatLinksHere: Trying to get property 'page_id' of non-object: Patch-For-Review.
Aug 24 2021, 9:56 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Wikimedia-production-error, SecTeam-Processed, MediaWiki-Special-pages, Platform Engineering
daniel triaged T289625: PHP Deprecated: Use of ParserOptions::getUser was deprecated in MediaWiki 1.36. [Called from Flow\Content\BoardContent::getParserOutput] as High priority.
Aug 24 2021, 9:44 PM · User-Urbanecm, MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Platform Team Workboards (MW Expedition), Growth-Team, StructuredDiscussions, Wikimedia-production-error
daniel edited projects for T289625: PHP Deprecated: Use of ParserOptions::getUser was deprecated in MediaWiki 1.36. [Called from Flow\Content\BoardContent::getParserOutput], added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Aug 24 2021, 9:42 PM · User-Urbanecm, MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Platform Team Workboards (MW Expedition), Growth-Team, StructuredDiscussions, Wikimedia-production-error

Aug 23 2021

daniel added a comment to T263166: Convert static mediawiki configuration to form more suitable for containers.

Based on my limited understanding of Kubernetes, I could imagine a multi-layered configuration system, where one layer can override the other. I'd be interested to hear if I'm at all thinking in the right direction with this.

Aug 23 2021, 10:36 AM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s

Aug 22 2021

daniel renamed T278940: Make LinkCache usable from PageStore from Convert LinkCache to PageRecord to Make LinkCache usable from PageStore.
Aug 22 2021, 3:09 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Platform Team Workboards (MW Expedition)

Aug 19 2021

daniel added a comment to T288707: Detect and monitor against multiple Parser invocation during edit requests.

If you don't mind, we'd like to keep this issue on our radar. We use that tag for tracking performance-related issues, even if another team is working on them.

Aug 19 2021, 4:28 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Performance-Team (Radar), Platform Engineering Code Jam, MediaWiki-Page-derived-data
daniel edited projects for T286672: Error: Call to a member function getInterwiki() on null, added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Aug 19 2021, 4:24 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CategoryTree, MediaWiki-extensions-DoubleWiki, Wikimedia-production-error
daniel triaged T287623: InvalidArgumentException: Expected IJobSpecification objects as High priority.
Aug 19 2021, 4:23 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-JobQueue, Wikimedia-production-error
daniel edited projects for T287650: Stop extending core actions, added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Aug 19 2021, 4:21 PM · Platform Team Workboards (MW Expedition), wdwb-tech, Wikidata, ProofreadPage, MediaWiki-extensions-WikibaseRepository, Shape Expressions, Dependency injection, User-DannyS712
daniel edited projects for T287712: Stop extending core actions in ProofreadPage, added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Aug 19 2021, 4:20 PM · Platform Team Workboards (MW Expedition), ProofreadPage, Dependency injection, User-DannyS712
daniel removed a project from T288707: Detect and monitor against multiple Parser invocation during edit requests: Platform Engineering.
Aug 19 2021, 4:20 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Performance-Team (Radar), Platform Engineering Code Jam, MediaWiki-Page-derived-data
daniel added a comment to T289190: ActionFactory: Error: Class 'New-topicAction' not found.

This error was caused by the introduction of ActionFactory.

Aug 19 2021, 1:10 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), User-DannyS712, Platform Team Workboards (Clinic Duty Team), Growth-Team, StructuredDiscussions, SecTeam-Processed
daniel lowered the priority of T289190: ActionFactory: Error: Class 'New-topicAction' not found from Unbreak Now! to High.

Dropping the priority from UBN to "high" after re-assessing the impact: This error only occurs when attempting to apply an action that is defined to a page that it is not applicable to. The action still works as expected if used as intended, and we will only attempt to instantiate classes that have a name that match a defined action, not arbitrary classes.

Aug 19 2021, 12:55 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), User-DannyS712, Platform Team Workboards (Clinic Duty Team), Growth-Team, StructuredDiscussions, SecTeam-Processed
daniel added a comment to T289190: ActionFactory: Error: Class 'New-topicAction' not found.

Flagged as UBN until we can confirm that this does not break Flow in a critical way, and does not pose a security risk.

Aug 19 2021, 11:53 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), User-DannyS712, Platform Team Workboards (Clinic Duty Team), Growth-Team, StructuredDiscussions, SecTeam-Processed
daniel edited projects for T289188: SecurePoll: PHP Notice: unserialize(): Error at offset 0 of 249 bytes, added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Aug 19 2021, 10:59 AM · Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-extensions-SecurePoll, Wikimedia-production-error
daniel triaged T287730: HomepageModuleRegistry shouldn't have MediaWikiServices as a parameter as Medium priority.
Aug 19 2021, 10:54 AM · Platform Team Workboards (MW Expedition), User-DannyS712, Growth-Team, Dependency injection, GrowthExperiments-MentorDashboard, GrowthExperiments-Homepage
daniel triaged T287713: Stop extending core actions in EntitySchema as Medium priority.
Aug 19 2021, 10:53 AM · Platform Team Workboards (MW Expedition), wdwb-tech, Wikidata, Shape Expressions, Dependency injection, User-DannyS712
daniel triaged T287714: Stop extending core actions in Wikibase as Medium priority.
Aug 19 2021, 10:52 AM · Platform Team Workboards (MW Expedition), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseRepository, Dependency injection, User-DannyS712
daniel removed a project from T288707: Detect and monitor against multiple Parser invocation during edit requests: Performance-Team (Radar).
Aug 19 2021, 10:49 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Performance-Team (Radar), Platform Engineering Code Jam, MediaWiki-Page-derived-data
daniel triaged T288882: SelectQueryBuilder::where() should not overwrite previous conditions as Medium priority.
Aug 19 2021, 10:48 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Performance-Team (Radar), Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms
daniel triaged T289190: ActionFactory: Error: Class 'New-topicAction' not found as Unbreak Now! priority.
Aug 19 2021, 10:43 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), User-DannyS712, Platform Team Workboards (Clinic Duty Team), Growth-Team, StructuredDiscussions, SecTeam-Processed
daniel removed a project from T289204: Move service-scaffold-golang & servicelib-golang to Gerrit and document: Platform Engineering.
Aug 19 2021, 10:40 AM · Platform Engineering Code Jam, User-Eevans
daniel edited projects for T289223: Page content language should be settable in OutputPage, added: Platform Team Workboards (MW Expedition), Language-Team; removed Platform Engineering.
Aug 19 2021, 10:39 AM · Language-Team, Platform Team Workboards (MW Expedition)

Aug 18 2021

daniel added a comment to T289014: TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromArchiveRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\DeletedContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php on line 1535.

I think the easiest thing to do for now is to implement Tim's previous solution to this since it's throwing at the same logical spot, but this time for archived rows

Aug 18 2021, 6:39 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), StructuredDiscussions, Growth-Team, Wikimedia-production-error
daniel added a comment to T289014: TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromArchiveRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\DeletedContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php on line 1535.

So, Flow injects fake rows into the contribs pager. These fake rows are *not* instances of stdClass (which is the class of anonymous objects only). Flow has a hierarchy of classes it uses for fake contributions rows, with FormatterRow as the base class.

Aug 18 2021, 4:49 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), StructuredDiscussions, Growth-Team, Wikimedia-production-error
daniel added a comment to T289014: TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromArchiveRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\DeletedContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php on line 1535.

The way Flow injects fake rows into the contribs pager is quite horrid, but pretty much impossible to fix. It's a direct consequence of the fact that flow implements its own revision storage instead of using core's.

Aug 18 2021, 4:41 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), StructuredDiscussions, Growth-Team, Wikimedia-production-error

Aug 17 2021

daniel added a comment to T255309: Remove UserRightsProxy and replace it's usages with UserGroupManager.

It may be useful to make UserRIghtsProxy implement UserIdentity. This way, we can just start passing $user to UserGroupManager without worrying about whether it's a User or a UserRightsProxy. Then we can make the constructor of UserrightsProxy emit deprecation warnings.

Aug 17 2021, 4:51 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Platform Team Workboards (MW Expedition), MediaWiki-extensions-CentralAuth, Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-User-management
daniel triaged T287158: Move Content::getParserOutput method that don't belong in Content to ContentHandler as High priority.
Aug 17 2021, 3:46 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel triaged T287159: Move Content::prepareSave method that don't belong in Content to ContentHandler as High priority.
Aug 17 2021, 3:45 PM · Platform Team Workboards (MW Expedition)
daniel triaged T281029: Deprecated TitleArray and replace it with PageSelectQueryBuilder as Medium priority.
Aug 17 2021, 3:45 PM · MediaWiki-General, Platform Team Workboards (MW Expedition)
daniel lowered the priority of T278591: Make PageRecord::getLanguage() behave consistently with Title::getPageLanguage() from High to Medium.
Aug 17 2021, 3:42 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Platform Team Workboards (MW Expedition)
daniel lowered the priority of T274177: PageContentAccess service as a replacement for WikiPage::getContent from High to Medium.
Aug 17 2021, 3:41 PM · MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
daniel added a comment to T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice.

I agree: keep using WikiPage::prepareContentForEdit() until Id5ba40a21 lands, then start using that. Feedback on that patch would be appreciated.

Aug 17 2021, 9:07 AM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, SpamBlacklist, Regression, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Performance-Team (Radar)
daniel added a project to T288707: Detect and monitor against multiple Parser invocation during edit requests: Platform Engineering Code Jam.
Aug 17 2021, 9:02 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Performance-Team (Radar), Platform Engineering Code Jam, MediaWiki-Page-derived-data
daniel added a comment to T289008: Make page.page_is_new be = 0 for restored pages with multiple revisions.

The second part doesn't seem to make much sense, and talking with @daniel we agreed that it looks more like a bug than a feature. Fixing this not only requires a code change, but also a maintenance script to set page_is_new back to 0 for pages with more than one revision.

Aug 17 2021, 8:48 AM · Platform Engineering, MediaWiki-Page-derived-data

Aug 16 2021

daniel renamed T287157: Move Content::preloadTransform method that don't belong in Content to ContentHandler from Move Content::preLoadTransform method that don't belong in Content to ContentHandler to Move Content::preloadTransform method that don't belong in Content to ContentHandler.
Aug 16 2021, 2:57 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel added a project to T243977: Expose flags for controlling API tests from the action API : User-Daniel.
Aug 16 2021, 12:26 PM · User-Daniel, MediaWiki-API, Platform Team Initiatives (API Integration Tests), Code-Health
daniel added a project to T223602: Define variant Wikimedia production config in compiled, static files: User-Daniel.
Aug 16 2021, 12:25 PM · User-Daniel, Release-Engineering-Team (Seen), MW-on-K8s, Performance-Team (Radar), Platform Engineering, Scap, Epic, serviceops, Continuous-Integration-Config
daniel added a project to T263166: Convert static mediawiki configuration to form more suitable for containers: User-Daniel.
Aug 16 2021, 12:25 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s
daniel added a comment to T284258: Knowledge store data model.

Rather than a product, I would say a platform, or an abstraction layer, needs a data model. But this may be semantics. (Personal side note: in yesterday's Enterprise discussion, this would refer to the WME stream specifically.) The platform/layer protects us from needing One Ultimate Standard because it maps data from sources (a wiki, ORES, a 3rd party, wikidata) to a standard. Consumers can consume it ... but the source data is also still available, as it is, where it is.

Aug 16 2021, 9:36 AM · tech-decision-forum

Aug 12 2021

daniel closed T284920: Remove "thumb size" preference as Declined.

Per above.

Aug 12 2021, 6:07 PM · Performance-Team (Radar), MediaWiki-Parser, MediaWiki-Cache, MediaWiki-User-preferences, Platform Engineering
daniel closed T284920: Remove "thumb size" preference, a subtask of T54807: Identify and remove legacy preferences from MediaWiki core (tracking), as Declined.
Aug 12 2021, 6:07 PM · Tracking-Neverending, MediaWiki-User-preferences
daniel added a comment to T284258: Knowledge store data model.

It does not describe changes to our current underlying systems, databases, or event schemas; it describes an overlay layer for systems that are directly meant for distribution, rather than strictly editing within the context of MediaWiki.

Aug 12 2021, 10:24 AM · tech-decision-forum

Aug 3 2021

MichaelSchoenitzer awarded T284920: Remove "thumb size" preference a Heartbreak token.
Aug 3 2021, 12:30 AM · Performance-Team (Radar), MediaWiki-Parser, MediaWiki-Cache, MediaWiki-User-preferences, Platform Engineering

Jul 29 2021

daniel added members for Platform Engineering Code Jam: CCicalese_WMF, tstarling.
Jul 29 2021, 4:06 PM
daniel added a member for Platform Engineering Code Jam: daniel.
Jul 29 2021, 4:06 PM
daniel set the icon for Platform Engineering Code Jam to Umbrella.
Jul 29 2021, 4:02 PM