Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (476 w, 5 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Yesterday

daniel updated the task description for T322426: Create REST endpoint for getting the latest "stable" HTML .
Tue, Nov 28, 10:14 AM · RESTBase Sunsetting, Platform Team Workboards (MW Expedition), Product-Infrastructure-Team-Backlog-Deprecated, Page Content Service
daniel updated the task description for T322426: Create REST endpoint for getting the latest "stable" HTML .
Tue, Nov 28, 10:10 AM · RESTBase Sunsetting, Platform Team Workboards (MW Expedition), Product-Infrastructure-Team-Backlog-Deprecated, Page Content Service

Mon, Nov 27

daniel added a comment to T352012: Error: Object of class Wikimedia\Message\ScalarParam could not be converted to string (in action=visualeditor).

The underlying problem is that the REST framework uses MessageValue is was intended as a nicer replacement of Message. MessageParam works with MessageValue, but not with Message. The two should be made to work together more nicely...

Mon, Nov 27, 4:23 PM · MediaWiki-REST-API, API Platform, VisualEditor, affects-translatewiki.net
daniel triaged T350353: Parsoid instance on beta not accesible from restbase CI/dev envs as High priority.
Mon, Nov 27, 3:29 PM · RESTBase Sunsetting, RESTBase, Beta-Cluster-Infrastructure
daniel updated the task description for T350353: Parsoid instance on beta not accesible from restbase CI/dev envs.
Mon, Nov 27, 3:28 PM · RESTBase Sunsetting, RESTBase, Beta-Cluster-Infrastructure

Sun, Nov 26

daniel added a comment to T229475: Monitoring.

@daniel is there any benefit to leaving this task open at this point? If so, maybe you have more context?

Sun, Nov 26, 11:34 AM · Platform Team Initiatives (Session Management Service (CDP2)), Platform Team Workboards (User Stories), Story, Code-Health

Wed, Nov 22

daniel added a comment to T338429: Prepare Mathoid for RESTbase sunsetting.

@MSantos Web team is no familiar with the Mathoid extension so would you be able to put together a test plan?

Wed, Nov 22, 6:26 PM · Web-Team-Backlog, Math, Mathoid, RESTBase Sunsetting
daniel added a comment to T20493: RFC: Unify the various deletion systems.

See T351411#9338177 for some scenarios

Wed, Nov 22, 5:16 PM · MediaWiki-Revision-deletion, TechCom-RFC, Stewards-and-global-tools, MediaWiki-Page-deletion

Tue, Nov 21

daniel added a comment to T338429: Prepare Mathoid for RESTbase sunsetting.

To clarify a few points:

A few notes from our discussion on mathoid future:

  • New functionality relies on MathML rendered natively in browsers
Tue, Nov 21, 4:40 PM · Web-Team-Backlog, Math, Mathoid, RESTBase Sunsetting

Sun, Nov 19

daniel added a comment to T350219: Page html output on testwiki returns 404.

These endpoints don't expose the same functionality that RESTBase did (based on the documentation). For example, there's no way to get the HTML of an old revision. How are redirects handled? Happy to file tickets for missing functionality or comment elsewhere, but right now it's incomplete for switching.

Sun, Nov 19, 1:44 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase

Fri, Nov 17

daniel added a comment to T350219: Page html output on testwiki returns 404.

Looks like this is an actual bug. https://github.com/wikimedia/restbase/pull/1337 should fix it.

Fri, Nov 17, 9:47 AM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase
daniel added a comment to T350219: Page html output on testwiki returns 404.

@Legoktm This works now:

curl -X POST -F "html=test" 'https://en.wikipedia.org/w/rest.php/v1/transform/html/to/wikitext/Mwbot-rs%2FDISPLAYTITLE'
Fri, Nov 17, 8:41 AM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase
daniel added a comment to T350661: Expose parsoid transformation API from MediaWiki core..

All new endpoints should be documented on the wiki page. Thanks!

Fri, Nov 17, 7:04 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting
daniel closed T350661: Expose parsoid transformation API from MediaWiki core. as Resolved.

The transform endpoint is now live, e.g. at https://en.wikipedia.org/w/rest.php/v1/transform/ (POST only).

Fri, Nov 17, 7:02 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting
daniel closed T350661: Expose parsoid transformation API from MediaWiki core., a subtask of T301370: Move transform endpoints from RESTBase to MediaWiki, as Resolved.
Fri, Nov 17, 7:02 AM · Epic, RESTBase Sunsetting, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor, Platform Engineering Roadmap
daniel closed T350661: Expose parsoid transformation API from MediaWiki core., a subtask of T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase, as Resolved.
Fri, Nov 17, 7:01 AM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel closed T350661: Expose parsoid transformation API from MediaWiki core., a subtask of T334238: Create deprecation plan for public parsoid endpoints, as Resolved.
Fri, Nov 17, 7:01 AM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel added a comment to T351357: In CI, only run tests for code that is affected by a given change.

But the key question is: would that speed up overall test times (for a subset of patches)? And, if so, would it result in broken builds when we run the full test suite?

Fri, Nov 17, 6:54 AM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests

Thu, Nov 16

daniel updated the task description for T351357: In CI, only run tests for code that is affected by a given change.
Thu, Nov 16, 3:32 PM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
daniel added a comment to T351357: In CI, only run tests for code that is affected by a given change.

Given the monolithic nature of MediaWiki, I don't think it's reasonable to think we can determine as an expert human (much less through a heuristic) what will and won't affect Wikibase (or any other sub-system).

Thu, Nov 16, 3:22 PM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
daniel added a comment to T351357: In CI, only run tests for code that is affected by a given change.

This has been discussed extensively many times, with lots of discussion for the benefits and costs; this task should probably be merged into one of the existing (generally Declined) tasks and that re-opened. T42008 is the oldest one I can find quickly – should we merge to that?

Thu, Nov 16, 1:44 PM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
daniel updated the task description for T351357: In CI, only run tests for code that is affected by a given change.
Thu, Nov 16, 1:29 PM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
daniel added a comment to T351357: In CI, only run tests for code that is affected by a given change.
Thu, Nov 16, 1:28 PM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
daniel updated the task description for T351336: Regularly generate a dependency graph for MediaWiki code.
Thu, Nov 16, 12:09 PM · Code-Health, Continuous-Integration-Infrastructure, Developer Productivity
daniel updated the task description for T351336: Regularly generate a dependency graph for MediaWiki code.
Thu, Nov 16, 11:58 AM · Code-Health, Continuous-Integration-Infrastructure, Developer Productivity
thcipriani awarded T351357: In CI, only run tests for code that is affected by a given change a Like token.
Thu, Nov 16, 12:40 AM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests

Wed, Nov 15

daniel created T351357: In CI, only run tests for code that is affected by a given change.
Wed, Nov 15, 9:44 PM · Code-Health, Developer Productivity, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests
daniel added a project to T351336: Regularly generate a dependency graph for MediaWiki code: Code-Health.
Wed, Nov 15, 9:44 PM · Code-Health, Continuous-Integration-Infrastructure, Developer Productivity
daniel created T351336: Regularly generate a dependency graph for MediaWiki code.
Wed, Nov 15, 6:05 PM · Code-Health, Continuous-Integration-Infrastructure, Developer Productivity
daniel added a comment to T346811: Stop adding Platform Engineering to new wiki creation tasks.

Does that sound good to people?

Wed, Nov 15, 5:09 PM · MediaWiki-Engineering, Content-Transform-Team, API Platform, Phabricator maintenance bot

Tue, Nov 14

daniel updated subscribers of T351040: Re-implement the REST endpoint for related pages in PHP.

@Jdlrobson @Gehel The fist step is to figure out where this should live, and who should own it. Ideally, APIs should be owned by the team that maintains the underlying logic (Cirrus), or team that maintains a similar component (RelatedPages), or a the team that consumes the API (native apps). The API Platform team can assist, but should not end up owning specific APIs.

Tue, Nov 14, 10:08 AM · Web-Team-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, RelatedArticles, Discovery-Search, RESTBase Sunsetting

Mon, Nov 13

daniel added a comment to T350219: Page html output on testwiki returns 404.

The actual Rust test case that was failing was posting the page's HTML back at it to see how it roundtrips, but I couldn't figure out how to escape the HTML for the command line so I just tried with a plain string and it reproduced the 404 error so..

Ok. I'll try to figure out what's going on with that.

Mon, Nov 13, 3:16 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase
daniel added a comment to T350219: Page html output on testwiki returns 404.

It can, it depends on what you post. And it only works if you had originally requested the HTML with the "stash" flag set.

That's not my experience, I've never set the stash parameter/flag but selser still applies.

Mon, Nov 13, 1:54 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase

Sun, Nov 12

Pppery awarded T5893: Import/Export should support zipped XML a Like token.
Sun, Nov 12, 9:59 PM · MediaWiki-Core-Snapshots
daniel added a comment to T347034: RESTBase /v1/related endpoint should call the MW action API with a GET not a POST.

The RelatedArticle MW extension could perhaps be a good fit? It provides the UI for the mobile web frontend for this similar feature and is making a similar request to the search API via the action API.

Sun, Nov 12, 6:33 PM · API Platform, RESTBase Sunsetting, Maintenance-Worktype, Wikifeeds, Sustainability (Incident Followup), Discovery-Search
daniel created T351040: Re-implement the REST endpoint for related pages in PHP.
Sun, Nov 12, 6:31 PM · Web-Team-Backlog, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, RelatedArticles, Discovery-Search, RESTBase Sunsetting

Fri, Nov 10

daniel added a comment to T347034: RESTBase /v1/related endpoint should call the MW action API with a GET not a POST.

According to Turnilo, the endpoint is used mostly by the Wikipedia app, and I suspect that it was built for that purpose. Maybe that means the Apps team owns it?

Fri, Nov 10, 8:36 AM · API Platform, RESTBase Sunsetting, Maintenance-Worktype, Wikifeeds, Sustainability (Incident Followup), Discovery-Search
daniel updated subscribers of T346811: Stop adding Platform Engineering to new wiki creation tasks.

That being said, this is not about creating new wikis, this is explicitly about one-post creation work. Adding the URL to the list in https://gerrit.wikimedia.org/g/mediawiki/services/restbase/deploy/+/master/scap/vars.yaml. Who owns restbase deploy? We add that team to the post-creation ticket.

Fri, Nov 10, 8:21 AM · MediaWiki-Engineering, Content-Transform-Team, API Platform, Phabricator maintenance bot
daniel added a comment to T350219: Page html output on testwiki returns 404.

My understanding is that transformation relies on the current content for selser to work (@ssastry can correct me if I'm wrong!)

Fri, Nov 10, 8:16 AM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase

Thu, Nov 9

daniel closed T320021: Migrate ruprecht from Toolforge GridEngine to Toolforge Kubernetes as Declined.

I disabled the tool.

Thu, Nov 9, 4:44 PM · MediaWiki-Engineering, Grid-Engine-to-K8s-Migration
daniel added a comment to T320021: Migrate ruprecht from Toolforge GridEngine to Toolforge Kubernetes.

You're looking at the wrong button. The correct one is this one at the bottom of the left sidebar:

Thu, Nov 9, 4:44 PM · MediaWiki-Engineering, Grid-Engine-to-K8s-Migration
daniel added a comment to T347034: RESTBase /v1/related endpoint should call the MW action API with a GET not a POST.

I made a pull request: https://github.com/wikimedia/restbase/pull/1336

Thu, Nov 9, 4:32 PM · API Platform, RESTBase Sunsetting, Maintenance-Worktype, Wikifeeds, Sustainability (Incident Followup), Discovery-Search
daniel added a comment to T350219: Page html output on testwiki returns 404.

I'm seeing less 404s now (yay), but I'm still getting one when POSTing to https://test.wikipedia.org/api/rest_v1/transform/html/to/wikitext/Mwbot-rs%2FDISPLAYTITLE/554795.

Thu, Nov 9, 4:24 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase
daniel added a comment to T349677: MediaWiki:Editcheck-config.json: Invariant failed: Page should be known.

I think the fix for now is to return a 404 instead of failing hard.
Note that with this fix, page/MediaWiki:Editcheck-config.json will return a 404, but page/MediaWiki:Editcheck-config.json/html will return the rendered message (modulo a fix for T349868). That seems ok to me, but it means that page/MediaWiki:Editcheck-config.json/with_html will also return a 404. That's a bit awkward.

Thu, Nov 9, 12:16 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-Engineering, API Platform, Content-Transform-Team, Editing-team, MediaWiki-REST-API
daniel added a comment to T346811: Stop adding Platform Engineering to new wiki creation tasks.

A while ago, I wrote a doc about why creating wikis is hard: https://docs.google.com/document/d/1EyRfxM39srUGB1bFt_8W36Lthqw8BXrKqnL8se_mgng/edit

Thu, Nov 9, 12:01 PM · MediaWiki-Engineering, Content-Transform-Team, API Platform, Phabricator maintenance bot
daniel triaged T349677: MediaWiki:Editcheck-config.json: Invariant failed: Page should be known as High priority.
Thu, Nov 9, 11:48 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-Engineering, API Platform, Content-Transform-Team, Editing-team, MediaWiki-REST-API
daniel claimed T349677: MediaWiki:Editcheck-config.json: Invariant failed: Page should be known.
Thu, Nov 9, 11:48 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-Engineering, API Platform, Content-Transform-Team, Editing-team, MediaWiki-REST-API
daniel claimed T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.
Thu, Nov 9, 11:48 AM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel triaged T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content as High priority.
Thu, Nov 9, 11:48 AM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel added a comment to T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.

The immediate cause of the error is this:

  1. HtmlOutputRendererHelper::getETag() calls getParserOutput(), and then calls ParsoidOutputAccess::getParsoidRenderID() on the ParserOutput object returned from getParserOutput().
  2. ParsoidOutputAccess::getParsoidRenderID() calls getParsoidRenderId() on that ParserOutput, but gets null and throws an InvalidArgumentException.
Thu, Nov 9, 11:48 AM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel updated the task description for T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.
Thu, Nov 9, 11:12 AM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel added a comment to T320021: Migrate ruprecht from Toolforge GridEngine to Toolforge Kubernetes.

The ruprecht tool is still running on the grid engine. If it's no longer used, please stop the grid web services and/or properly delete the tool.

Thu, Nov 9, 10:50 AM · MediaWiki-Engineering, Grid-Engine-to-K8s-Migration
daniel added a comment to T346811: Stop adding Platform Engineering to new wiki creation tasks.
Thu, Nov 9, 7:38 AM · MediaWiki-Engineering, Content-Transform-Team, API Platform, Phabricator maintenance bot

Wed, Nov 8

daniel added a comment to T350661: Expose parsoid transformation API from MediaWiki core..

Duplicate of T310398? Subtask of T334238?

Wed, Nov 8, 12:45 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting
daniel added a subtask for T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase: T350661: Expose parsoid transformation API from MediaWiki core..
Wed, Nov 8, 12:44 PM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel added a subtask for T334238: Create deprecation plan for public parsoid endpoints: T350661: Expose parsoid transformation API from MediaWiki core..
Wed, Nov 8, 12:44 PM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel added parent tasks for T350661: Expose parsoid transformation API from MediaWiki core.: T334238: Create deprecation plan for public parsoid endpoints, T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.
Wed, Nov 8, 12:44 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting

Tue, Nov 7

daniel added a comment to T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.).

@daniel @matmarex @Krinkle the LIKE expression implementation gave me an idea for cases of ipb_range_end = ipb_range_start in WHERE conditions and possibly join conditions. We could introduce a RawValue class and turn ipb_range_end = ipb_range_start into $dbr->expr('ipb_range_end', '=', RawValue( 'ipb_range_start' ) ) instead. It's not pretty but it's clearly not a common usecase. Thoughts?

Basically flipping the default of "raw SQL unless specified" to "quoted unless explicitly specified"

Tue, Nov 7, 6:45 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, DBA, API Platform, MediaWiki-libs-Rdbms
daniel created T350669: Use short term cache when skipping ParserCache due to fast parse time.
Tue, Nov 7, 9:59 AM · Parsoid (Tracking), MediaWiki-Core-HTTP-Cache
daniel updated the task description for T350661: Expose parsoid transformation API from MediaWiki core..
Tue, Nov 7, 8:50 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting
daniel added a comment to T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.

@santhosh ok, I filed T350661: Expose parsoid transformation API from MediaWiki core. for enabling it.

Tue, Nov 7, 8:46 AM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel updated the task description for T350661: Expose parsoid transformation API from MediaWiki core..
Tue, Nov 7, 8:45 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting
daniel added a comment to T350661: Expose parsoid transformation API from MediaWiki core..

@MSantos @ssastry Can the Conten Transform team commit to maintaining the transform endpoint as a public API? CT has been looking after this functionality when it lived in RESTbase, and has ported it to PHP. Derick and I moved it into core last year, and refactored it a bit.

Tue, Nov 7, 8:44 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting
daniel created T350661: Expose parsoid transformation API from MediaWiki core..
Tue, Nov 7, 8:42 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Language-Team, CX-cxserver, RESTBase Sunsetting

Mon, Nov 6

daniel added a comment to T350600: Lots of parsoidCachePrewarm jobs are created, creating a huge backlog making it unsustainable.

Some thoughts on this:

Mon, Nov 6, 5:56 PM · Parsoid (Third-party), User-RhinosF1, affects-Miraheze, MediaWiki-Core-JobQueue, Performance Issue
daniel added a comment to T349757: [RFC] Community configuration 2.0: Validating site configuration.

Required changes in MediaWiki Core: sandbox/urbanecm/community-configuration in Gerrit, see Gerrit

Mon, Nov 6, 11:11 AM · Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Platform-Team (Radar), GrowthExperiments-CommunityConfiguration (2.0)
daniel added a comment to T349757: [RFC] Community configuration 2.0: Validating site configuration.

If there is anything we didn’t consider and we should know about, please tell us in the comments in this task.

Mon, Nov 6, 11:05 AM · Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Platform-Team (Radar), GrowthExperiments-CommunityConfiguration (2.0)
daniel added a comment to T349757: [RFC] Community configuration 2.0: Validating site configuration.

Upon invocation of a maintenance script, Community configuration 2.0 converts the content of the wiki page.

Mon, Nov 6, 10:46 AM · Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Platform-Team (Radar), GrowthExperiments-CommunityConfiguration (2.0)
daniel added a comment to T349757: [RFC] Community configuration 2.0: Validating site configuration.

In that direction three libraries have been evaluated and the current proposal is to use Opis/json-schema

Mon, Nov 6, 10:43 AM · Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Platform-Team (Radar), GrowthExperiments-CommunityConfiguration (2.0)
daniel awarded T350517: Visual diff should not enable stashing when requesting HTML from Parsoid a Like token.
Mon, Nov 6, 10:32 AM · VisualEditor-MediaWiki, VisualEditor-VisualDiffs, VisualEditor
daniel added a comment to T341010: DiscussionTools doesn't recognize talk threads with Parsoid HTML.

I agree that #1 seems like the most future proof approach.

Mon, Nov 6, 7:40 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Content-Transform-Team-WIP, Editing-team, DiscussionTools, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
daniel added a comment to T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.

cxserver(nodejs)->VisualEditor Extension -> parsoid internal endpoint(production) seems a hacky round about way. If VE already exposes the production parsoid endpoint via an API, why not make the parsoid endpoint public?

Mon, Nov 6, 7:02 AM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting

Fri, Nov 3

daniel added a comment to T350219: Page html output on testwiki returns 404.

I imagine that for most, if not all, of these a redirect follow would generally not retain a Host: header from the first request.

Fri, Nov 3, 11:29 AM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase

Thu, Nov 2

daniel updated the task description for T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.
Thu, Nov 2, 5:01 PM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel updated subscribers of T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.

http://parsoid-external-ci-access.beta.wmflabs.org - Does this use actual production wiki? Or beta.wmflabs.org? If it is beta.wmflabs.org, then we will be limited by content and supported languages right?

Thu, Nov 2, 3:47 PM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel added a comment to T320021: Migrate ruprecht from Toolforge GridEngine to Toolforge Kubernetes.

The ruprecht tool is still running on the grid engine. If it's no longer used, please stop the grid web services and/or properly delete the tool.

Thu, Nov 2, 3:41 PM · MediaWiki-Engineering, Grid-Engine-to-K8s-Migration
daniel added a comment to T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.

If you need access to pagebundles or the transform endpoints, then we have to figure something out.

We need tranform endpoints from production wikis in our nodejs based cxserver. We also need the same tranform endpoints while we test/debug/develop publishing as CX works with html and do wikitext tranformation at end. We use production restbase endpoints to avoid having templates and pages available in localwiki.

Thu, Nov 2, 10:52 AM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel created T350359: Parsoid extension page endpoints should not redirect to latest revision.
Thu, Nov 2, 10:30 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Content-Transform-Team-WIP, RESTBase Sunsetting, Parsoid
daniel added a comment to T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.

CX specifically need to connect to production parsoid instances for fetching pages. It does not make any sense to use local wiki pages for translation during development workflows. It will also limit our ability to debug issues related to production wiki pages.

Thu, Nov 2, 9:25 AM · Patch-For-Review, Language-Team (Language-2023-October-December), CX-cxserver, serviceops, RESTBase Sunsetting
daniel added a comment to T350202: "Stashing failed because rate limit was exceeded" (parsoid-stash-rate-limit-error) shown in various interfaces when the user is blocked.

Maybe on diff view with diffonly=0 it is possible to directly edit the page as it is shown there. Maybe the error does not happen on diffonly=1 view as there is no content shown.
Not sure if the content after the diff is editable by the visual editor.

Thu, Nov 2, 8:47 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Content-Transform-Team, API Platform, MediaWiki-REST-API, Editing-team
daniel added a subtask for T346919: Release MediaWiki 1.41.0: T350347: Blocks should not apply to implicit rights.
Thu, Nov 2, 8:45 AM · Release, MediaWiki-Releasing, MW-1.41-release
daniel added a subtask for T346927: Release MW 1.41.0-rc.0: T350347: Blocks should not apply to implicit rights.
Thu, Nov 2, 8:45 AM · Release, MediaWiki-Releasing, MW-1.41-release
daniel added parent tasks for T350347: Blocks should not apply to implicit rights: T346927: Release MW 1.41.0-rc.0, T346919: Release MediaWiki 1.41.0.
Thu, Nov 2, 8:45 AM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-release, MediaWiki-Blocks, MediaWiki-User-management
daniel created T350347: Blocks should not apply to implicit rights.
Thu, Nov 2, 8:44 AM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-release, MediaWiki-Blocks, MediaWiki-User-management

Wed, Nov 1

daniel added a comment to T350117: Action API with action=visualeditor returns rate limit error for articles in Mediawiki namespace.

Related change is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/960663

The call to Authority::authorizeWrite now also checks permission of the authority against $wgNamespaceProtection for the given page, but reports any failure as ratelimited, so it needs something like https://gerrit.wikimedia.org/r/c/mediawiki/core/+/964563 to improve error handling.

Wed, Nov 1, 7:28 PM · Content-Transform-Team, API Platform, MediaWiki-REST-API
daniel added a comment to T350202: "Stashing failed because rate limit was exceeded" (parsoid-stash-rate-limit-error) shown in various interfaces when the user is blocked.

In tools that perform edits (VisualEditor, DiscussionTools), I should see the block message, not an unrelated error.

Wed, Nov 1, 7:25 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Content-Transform-Team, API Platform, MediaWiki-REST-API, Editing-team
daniel closed T320021: Migrate ruprecht from Toolforge GridEngine to Toolforge Kubernetes as Declined.

We'll want a fresh start on dependency analysis. The Ruprecht projet was an early proof of concept.

Wed, Nov 1, 1:08 PM · MediaWiki-Engineering, Grid-Engine-to-K8s-Migration
daniel closed T223726: Ruprecht: Investigate filtering dependencies by Connascence as Declined.
Wed, Nov 1, 1:06 PM · MediaWiki-Engineering, Platform Team Initiatives (Decoupling (CDP2)), Code-Health
daniel added a comment to T223726: Ruprecht: Investigate filtering dependencies by Connascence.

Would declining tasks also imply requesting to archive the code repository?

Wed, Nov 1, 1:06 PM · MediaWiki-Engineering, Platform Team Initiatives (Decoupling (CDP2)), Code-Health
daniel created T350258: Archive the mediawiki/tools/dependency-analysis/ repo.
Wed, Nov 1, 1:05 PM · Projects-Cleanup
daniel added a comment to T350219: Page html output on testwiki returns 404.

The issue seems to be that the parsoid endpoints send a full URL in redirect responses, e.g. when redirecting from a page URL to a revision URL, e.g. /page/html/Dog to /page/html/Dog/12345. Since the target URL uses an external domain name, it will not be routed to the parsoid cluster, where the Parsoid extension is enabled on MediaWiki. The request will instead be routed to the public API cluster, where the relevant endpoints are unavailable, resulting in a 404 response.

Wed, Nov 1, 12:55 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase
daniel added a comment to T350219: Page html output on testwiki returns 404.

This issue may also be affecting other public-facing services like https://en.wikipedia.org/w/rest.php/en.wikipedia.org/v3/transform/wikitext/to/html

Wed, Nov 1, 12:52 PM · Patch-For-Review, mwbot-rs, RESTBase Sunsetting, RESTBase

Mon, Oct 30

daniel added a comment to T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.

This seems to only fail for messages that have non-wikitext content. This works fine, even though it's overwritten: https://fr.wikipedia.org/w/rest.php/v1/page/MediaWiki:Abusefilter/html

Mon, Oct 30, 6:34 PM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel renamed T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content from page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages to page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.
Mon, Oct 30, 6:34 PM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel added a comment to T349868: page/<title>/html and with_html endpoints fails with InvalidArgumentException for overridden interface messages with JSON content.

I'll take a look in a bit

Mon, Oct 30, 6:05 PM · Patch-For-Review, MediaWiki-Engineering, API Platform, Content-Transform-Team, MediaWiki-REST-API
daniel closed T349001: Use relative URLs in redirects emitted by rest.php as Resolved.
Mon, Oct 30, 5:53 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), SRE, serviceops, Traffic, API Platform, MediaWiki-REST-API
daniel added a comment to T349792: Gadget definition syntax should allow restricting a gadget to logged in users only.

I haven't done this yet, but I would recommend limiting these to autoconfirmed instead

Mon, Oct 30, 12:03 PM · Patch-For-Review, MediaWiki-extensions-Gadgets

Oct 25 2023

daniel added a comment to T291316: 'purge' permission is not checked for action=purge.

I made a patch that allows groups to be specified in a gadget definition, e.g.

Oct 25 2023, 11:22 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes, MediaWiki-Core-AuthManager
daniel added a comment to T291316: 'purge' permission is not checked for action=purge.

Ah, I was unaware of this mechansim in Gadgets. Thank you for the explanation.

Oct 25 2023, 7:10 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes, MediaWiki-Core-AuthManager
daniel added a comment to T349348: UserRightsError: User does not have required user right "purge".

Making the purge right implcite should not cause permission errors. To the contrary, it should make sure that the permission is always granted.

Special:ListGroupRights no longer had purge for any group, and the API does not have it included in the list of a user's rights.

Pywikibot checks the if the user has the purge right before making a POST to the purge API.

Oct 25 2023, 7:02 AM · Pywikibot