Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (258 w, 2 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Fri, Sep 20

daniel moved T233350: ActiveAbstract: remove dependency on pre-MCR database schema from Blocked to Done on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 7:15 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel updated the task description for T214308: Force usage of MCR aware database schema.
Fri, Sep 20, 12:17 PM · Core Platform Team Workboards (Purple), MW-1.34-release, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a project to T214308: Force usage of MCR aware database schema: Core Platform Team Workboards (Purple).
Fri, Sep 20, 12:15 PM · Core Platform Team Workboards (Purple), MW-1.34-release, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel placed T198341: Remove all references to the rev_text_id and ar_text_id fields up for grabs.
Fri, Sep 20, 12:12 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel placed T198343: Replace all calls to Revision::getRevisionText() up for grabs.
Fri, Sep 20, 12:12 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
daniel moved T200918: Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode. from Engineering Tasks Ready for Estimation to Ready on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 10:23 AM · Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment), Wikidata
daniel closed T230353: Create scripts to take and restore snapshots of a wiki database, a subtask of T229639: Known State, as Resolved.
Fri, Sep 20, 10:22 AM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (API Integration Tests), Code-Health
daniel closed T230353: Create scripts to take and restore snapshots of a wiki database as Resolved.
Fri, Sep 20, 10:22 AM · Core Platform Team Workboards (Purple), CPT Initiatives (API Integration Tests), Code-Health
daniel closed T231822: API integration tests need a way to flush the job queue. as Resolved.
Fri, Sep 20, 10:22 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Purple), CPT Initiatives (API Integration Tests)
daniel closed T231822: API integration tests need a way to flush the job queue., a subtask of T231890: Wait for effects before continuing, as Resolved.
Fri, Sep 20, 10:22 AM · Story, Core Platform Team Workboards (User Stories), CPT Initiatives (API Integration Tests), Code-Health
daniel moved T233356: Flow: remove dependency on pre-MCR database schema from Ready to Done on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 10:20 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), StructuredDiscussions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Growth-Team, Multi-Content-Revisions (Tech Debt)
daniel moved T233355: WikimediaMaintenance: remove dependency on pre-MCR database schema from Doing to Waiting for Review on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 10:20 AM · Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233358: SpamBlacklist: remove dependency on pre-MCR database schema from Doing to Waiting for Review on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 10:18 AM · Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233353: EntitySchema: remove dependency on pre-MCR database schema from Ready to Doing on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 9:21 AM · Wikidata, Shape Expressions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233355: WikimediaMaintenance: remove dependency on pre-MCR database schema from Ready to Doing on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 9:21 AM · Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233358: SpamBlacklist: remove dependency on pre-MCR database schema from Ready to Doing on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 9:21 AM · Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel claimed T233350: ActiveAbstract: remove dependency on pre-MCR database schema.
Fri, Sep 20, 9:17 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233350: ActiveAbstract: remove dependency on pre-MCR database schema from Ready to Blocked on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 9:16 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter from Waiting for Review to Blocked on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 8:10 AM · Patch-For-Review, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)

Thu, Sep 19

daniel added a comment to T222099: Staging release of RESTBagOStuff using Kask.

So, yeah, it's Kask (even if indirectly), and the way MW uses it is breaking this behaviour. It worked not using Kask. So the next question is does this just break OATHAuth? Or do other extensions put objects in and therefore will expect it to work?

Thu, Sep 19, 9:09 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
daniel updated the task description for T198341: Remove all references to the rev_text_id and ar_text_id fields.
Thu, Sep 19, 9:06 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel added projects to T233179: Use ExternalStoreAccess::fetchFromURLs in blobStore::getBlobBatch: Performance, MediaWiki-Revision-backend.
Thu, Sep 19, 8:09 PM · MediaWiki-Revision-backend, Performance, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). from Ready to Blocked on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 8:07 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel moved T198343: Replace all calls to Revision::getRevisionText() from Doing to Blocked on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 8:07 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
daniel moved T198341: Remove all references to the rev_text_id and ar_text_id fields from Doing to Blocked on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 8:07 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel claimed T233358: SpamBlacklist: remove dependency on pre-MCR database schema.
Thu, Sep 19, 8:07 PM · Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233358: SpamBlacklist: remove dependency on pre-MCR database schema from Backlog to Ready on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 8:03 PM · Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel updated the task description for T233358: SpamBlacklist: remove dependency on pre-MCR database schema.
Thu, Sep 19, 8:03 PM · Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel created T233358: SpamBlacklist: remove dependency on pre-MCR database schema.
Thu, Sep 19, 8:01 PM · Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233350: ActiveAbstract: remove dependency on pre-MCR database schema from Backlog to Ready on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 7:54 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233353: EntitySchema: remove dependency on pre-MCR database schema from Backlog to Ready on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 7:54 PM · Wikidata, Shape Expressions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233355: WikimediaMaintenance: remove dependency on pre-MCR database schema from Backlog to Ready on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 7:54 PM · Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel moved T233356: Flow: remove dependency on pre-MCR database schema from Backlog to Ready on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 7:54 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), StructuredDiscussions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Growth-Team, Multi-Content-Revisions (Tech Debt)
daniel moved T233357: ReplaceText: remove dependency on pre-MCR database schema from Backlog to Ready on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 7:54 PM · Patch-For-Review, MediaWiki-extensions-ReplaceText, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a subtask for T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().: T233357: ReplaceText: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:53 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel added a parent task for T233357: ReplaceText: remove dependency on pre-MCR database schema: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..
Thu, Sep 19, 7:53 PM · Patch-For-Review, MediaWiki-extensions-ReplaceText, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel created T233357: ReplaceText: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:53 PM · Patch-For-Review, MediaWiki-extensions-ReplaceText, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a subtask for T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().: T233356: Flow: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:52 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel added a parent task for T233356: Flow: remove dependency on pre-MCR database schema: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..
Thu, Sep 19, 7:52 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), StructuredDiscussions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Growth-Team, Multi-Content-Revisions (Tech Debt)
daniel created T233356: Flow: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:51 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), StructuredDiscussions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Growth-Team, Multi-Content-Revisions (Tech Debt)
daniel created T233355: WikimediaMaintenance: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:50 PM · Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel created T233353: EntitySchema: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:48 PM · Wikidata, Shape Expressions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a project to T233350: ActiveAbstract: remove dependency on pre-MCR database schema: ActiveAbstract.
Thu, Sep 19, 7:45 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel updated the task description for T233350: ActiveAbstract: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:45 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel removed a subtask for T198341: Remove all references to the rev_text_id and ar_text_id fields: T233350: ActiveAbstract: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:42 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel added a subtask for T198343: Replace all calls to Revision::getRevisionText(): T233350: ActiveAbstract: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:42 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
daniel edited parent tasks for T233350: ActiveAbstract: remove dependency on pre-MCR database schema, added: T198343: Replace all calls to Revision::getRevisionText(); removed: T198341: Remove all references to the rev_text_id and ar_text_id fields.
Thu, Sep 19, 7:42 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel created T233350: ActiveAbstract: remove dependency on pre-MCR database schema.
Thu, Sep 19, 7:41 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, ActiveAbstract, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel updated the task description for T198341: Remove all references to the rev_text_id and ar_text_id fields.
Thu, Sep 19, 6:28 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel moved T230340: Set up CI for mediawiki/tools/api-testing from Waiting for Review to Doing on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 6:25 PM · Patch-For-Review, Release-Engineering-Team-TODO (201909), Release-Engineering-Team (CI & Testing services), Core Platform Team Workboards (Purple), Continuous-Integration-Config, CPT Initiatives (API Integration Tests)
daniel moved T230353: Create scripts to take and restore snapshots of a wiki database from Waiting for Review to Done on the Core Platform Team Workboards (Purple) board.
Thu, Sep 19, 6:25 PM · Core Platform Team Workboards (Purple), CPT Initiatives (API Integration Tests), Code-Health
daniel added a comment to T232485: RFC: Core REST API namespace and version.

@Krinkle @daniel So, I guess this is an RFC now? What do I need to do next?

Thu, Sep 19, 6:23 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel added a comment to T232485: RFC: Core REST API namespace and version.

Discussing this proposal on Tuesday with Tim, he strongly objected to having the word "core" in the prefix, since none of the other APIs referenced above have the word "core" in them. So, I've removed the "core" from the proposal.

Thu, Sep 19, 6:21 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel moved T232563: Drop IE6 and IE7 basic compatibility and security support from Under discussion to Last Call on the TechCom-RFC board.

This RFC has entered the Last Call period per the TechCom meeting on September 18. The last call will end on October 2nd. If no issues remain unaddressed by that time, this RFC will be approved as proposed.

Thu, Sep 19, 5:43 PM · MediaWiki-General, TechCom-RFC
daniel moved T193613: Strategy for PHP interface changes from Backlog to Inbox on the TechCom board.

Moved by to TechCom inbox. I have updated the task description to reflect the current state of the proposal. The draft for the stable interface policy can be found at https://www.mediawiki.org/wiki/Stable_Interface_Policy. If there are no objections, I think the draft can go on Last Call next week. Please put any comments or questions here rather than the talk page on the wiki. I'm more likely to see them here, and they are in context of the prior discussion.

Thu, Sep 19, 2:52 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel added a comment to T193613: Strategy for PHP interface changes.

Just in case it helps the discussion: here is a list of all the PHP interfaces declared in core and how they are implemented in extensions. In the end there are very few and even fewer are the ones that could not be transformed to an abstract base class. I did not analyze inter-extension dependencies.

Thu, Sep 19, 2:49 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel updated the task description for T193613: Strategy for PHP interface changes.
Thu, Sep 19, 2:49 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel moved T18691: RFC: Section header "share" link from Under discussion to Inbox on the TechCom-RFC board.

Putting this in the RFC inbox for discussion.

Thu, Sep 19, 9:37 AM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Wed, Sep 18

daniel moved T232485: RFC: Core REST API namespace and version from Inbox to Under discussion on the TechCom-RFC board.
Wed, Sep 18, 8:36 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel moved T193613: Strategy for PHP interface changes from In progress to Backlog on the TechCom board.

Proposal needs an update, I plan to do this next week.

Wed, Sep 18, 8:34 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel removed a project from T106363: Migrate Flow content to new separate logical External Store in production: TechCom.

Untagging TechCom, since this has been decoupled from the text table and content table.

Wed, Sep 18, 8:33 PM · Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), WorkType-Maintenance, Patch-For-Review, StructuredDiscussions, Collaboration-Team-Sprint-E-Everywhere-2015-07-14
daniel added a comment to T230862: Create a way to filter only WB-related changes from Commons recentchanges.

So say we add a 'structured-data-mediainfo' tag to every revision that has a mediainfo slot - would that be adequate? @EBernhardson ?

Wed, Sep 18, 5:36 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog, MediaWiki-API, Wikidata-Query-Service, SDC General, Commons, Wikidata
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.
Wed, Sep 18, 4:18 PM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General

Tue, Sep 17

daniel added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

I think ActingUser comes in two flavors, which could be subclasses or distinguished by asking the object: 1) a user acting via a web request. Additional restrictions may applies. 2) a user user acting without a web request, so no additional restrictions apply.

Then what exactly is the difference between your "ActingUser2" and a normal UserIdentity? Just some semantics with no actual code difference?

Tue, Sep 17, 7:01 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T222497: dumpRDF for MediaInfo entities loads each page individually.

The link cache is for the title -> id lookup. Seems to me like you need the opposite here. The batch interface would be Title::newFromIDs (note the plural), but that does no caching.

Tue, Sep 17, 6:36 PM · Core Platform Team, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Dumps-Generation, User-Smalyshev, WikibaseMediaInfo, Wikidata-Query-Service, SDC General, Commons, Wikidata
daniel removed a project from T233140: Quibble should not rely on dynamically detecting the value of $wgServer: Technical-Debt (Deprecation).
Tue, Sep 17, 6:29 PM · Continuous-Integration-Infrastructure, MediaWiki-General
daniel created T233140: Quibble should not rely on dynamically detecting the value of $wgServer.
Tue, Sep 17, 6:28 PM · Continuous-Integration-Infrastructure, MediaWiki-General
daniel updated the task description for T200918: Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode..
Tue, Sep 17, 4:54 PM · Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment), Wikidata
daniel removed a project from T214308: Force usage of MCR aware database schema: Wikidata.

Why is this tagged Wikidata? Is Wikibase incompatible with the new schema or something? (It looks like production is currently configured to write both but read new – perhaps Wikibase still reads old somewhere?)

Tue, Sep 17, 1:35 PM · Core Platform Team Workboards (Purple), MW-1.34-release, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
daniel added a comment to T233092: CI: Create a way to share a secret between MediaWiki and the testing framework..

What about using the RunSingleJob.php RPC end point that is used in production? It doesn't require a special token and since it's the way it's done in production, it brings CI tests closer to a more realistic set-up.

Tue, Sep 17, 11:57 AM · Patch-For-Review, Quibble, Release-Engineering-Team-TODO (201909), Release-Engineering-Team (CI & Testing services), Core Platform Team Workboards (Purple), Continuous-Integration-Config, CPT Initiatives (API Integration Tests)
daniel created T233092: CI: Create a way to share a secret between MediaWiki and the testing framework..
Tue, Sep 17, 10:05 AM · Patch-For-Review, Quibble, Release-Engineering-Team-TODO (201909), Release-Engineering-Team (CI & Testing services), Core Platform Team Workboards (Purple), Continuous-Integration-Config, CPT Initiatives (API Integration Tests)
daniel added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

I think all code that does "secure" permission checks should require that an ActingUser is given.

One implication there is that system users would have to be ActingUser since they do perform actions which trigger secure permission checks, even though they don't have associated IPs or requests. So ActingUser (with the interface envisioned in the task description) doesn't seem like a natural abstraction.

Tue, Sep 17, 8:43 AM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))

Mon, Sep 16

daniel added a comment to T18691: RFC: Section header "share" link.

Yes, we are planning on enabling the feature on en.wiki once it becomes available.

Mon, Sep 16, 2:35 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
daniel updated subscribers of T231930: Introduce ActingUser to represent the user performing the current request.
Mon, Sep 16, 1:20 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
daniel updated subscribers of T218555: Provide access to WebRequest and associated information via a service object.
Mon, Sep 16, 1:20 PM · TechCom, MediaWiki-ServiceContainer, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) seems to indicate that we need to be able to manipulate the response (cookies) from the context of block management as well.

Mon, Sep 16, 1:20 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
daniel added a comment to T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend).

Calling trackBlockWithCookie() as standard part of pre-shutdown on web requests will:

  • [...] Let getUserBlock remain predictable (no side-effect), and keep BlockManager separate from implicitly depending on WebResponse or otherwise making it unsafe to use post-send or outside web requests.

getUserBlock can still have the side-effect of clearing the block cookie. Have suggested a fix in: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/537099/

Mon, Sep 16, 1:18 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management

Fri, Sep 13

daniel edited projects for T190178: DeferredUpdates should not silently ignore critical exceptions, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team Legacy (Watching / External).
Fri, Sep 13, 4:44 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Daniel, MediaWiki-Debug-Logger
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

fixed by adding a row with role_id=2 and role_name='aux'

Fri, Sep 13, 8:13 AM · CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General

Thu, Sep 12

daniel added a comment to T18691: RFC: Section header "share" link.

@osorio-juan-microsoft Thanks, that does sound like it would be difficult to do this in an extension. And if we (WMF) don't enable it, it probably wouldn't need an RFC. But if we are planning to enable it on WMF sites, it will need a closer look.

Thu, Sep 12, 8:31 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
daniel added a comment to T18691: RFC: Section header "share" link.

#2 - Does "deployment on WMF systems" mean to make this part of MediaWiki core software? I think this has always been the expectation, which is why it has gone through many iterations of design, i18n and perf improvement :) Could WMF friends chime in to confirm this is still the case?

Thu, Sep 12, 8:13 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
daniel claimed T230353: Create scripts to take and restore snapshots of a wiki database.
Thu, Sep 12, 7:17 PM · Core Platform Team Workboards (Purple), CPT Initiatives (API Integration Tests), Code-Health
daniel moved T229853: Create example tests set 1 (Clara) from Waiting for Review to Done on the Core Platform Team Workboards (Purple) board.
Thu, Sep 12, 7:16 PM · Core Platform Team Workboards (Purple), CPT Initiatives (API Integration Tests), Code-Health
daniel added a comment to T18691: RFC: Section header "share" link.

It seems that the design questions are resolved and the implementation is under review. Should the RFC be scheduled for discussion at TechCom?

Thu, Sep 12, 5:52 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
daniel added a comment to T232485: RFC: Core REST API namespace and version.

Quick summary from a conversation I had with Tim just now:

Thu, Sep 12, 11:20 AM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel closed T206070: Wikimedia Technical Conference 2018 Session - Mapping our data and content pipeline as Resolved.
Thu, Sep 12, 10:28 AM · Wikimedia-Technical-Conference-2018
daniel closed T206084: Wikimedia Technical Conference 2018 Session - Architecting core: concepts as Resolved.
Thu, Sep 12, 10:28 AM · Wikimedia-Technical-Conference-2018

Wed, Sep 11

daniel added a comment to T193613: Strategy for PHP interface changes.

After some discussion, it seems to me that this is primarily about defining what we consider a stable interface. I thnk we should amend the deprecation policy to be explicit about this. Draft here:
https://www.mediawiki.org/wiki/User:DKinzler_(WMF)/Stable_Interface

Wed, Sep 11, 8:22 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
daniel added a comment to T221763: Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y..

One more I have noticed today:

enwikiRevisionStoreRecord.phpThe given Title does not belong to page ID 52943292 but actually belongs to 61713901
Wed, Sep 11, 3:20 PM · CPT Initiatives (MCR), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MediaWiki-Revision-backend, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), PageImages, Multi-Content-Revisions (Reactive), Wikimedia-production-error, Regression
daniel added a comment to T198492: Create a maintenance script to drop rev_text_id and ar_text_id from the database..

No, it was never true. update.php has been used to drop fields since MW 1.5, 14 years ago, but there was no backlog of undropped fields at that time. update.php has always been the correct script in which to drop fields and tables.

Wed, Sep 11, 6:44 AM · MW-1.35-release, CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt), Wikidata

Tue, Sep 10

daniel added a comment to T232485: RFC: Core REST API namespace and version.

As I understand, we intend to bump versions for non-breaking changes. Having a minor version bump for any new field or new endpoint in the whole core, I could easily imagine API v1.100500 which makes the cache split problem more and more intimidating.

Tue, Sep 10, 5:42 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel added a comment to T232485: RFC: Core REST API namespace and version.

@daniel I meant that client developers will probably appreciate any drag on breaking changes. My guess is that we'll need to do it pretty often to begin with, but that breaking changes will get much more costly as we get more users on this API.

Tue, Sep 10, 5:36 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel added a comment to T232485: RFC: Core REST API namespace and version.

Client developers will probably think of that as a feature, not a bug! ;-)

Tue, Sep 10, 5:33 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel moved T230211: Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests. from Waiting for Review to Doing on the Core Platform Team Workboards (Purple) board.
Tue, Sep 10, 5:04 PM · CPT Initiatives (API Integration Tests), Core Platform Team Workboards (Purple), Performance-Team (Radar), Patch-For-Review, MediaWiki-API
daniel moved T230211: Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests. from Doing to Waiting for Review on the Core Platform Team Workboards (Purple) board.
Tue, Sep 10, 5:04 PM · CPT Initiatives (API Integration Tests), Core Platform Team Workboards (Purple), Performance-Team (Radar), Patch-For-Review, MediaWiki-API
daniel moved T231822: API integration tests need a way to flush the job queue. from Doing to Waiting for Review on the Core Platform Team Workboards (Purple) board.
Tue, Sep 10, 4:48 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Purple), CPT Initiatives (API Integration Tests)
daniel added a comment to T232485: RFC: Core REST API namespace and version.

I don't see a problem here unless we remove a version. If we always return the latest minor version for the requested major version, and only make backwards-compatible changes (adding fields), we'd never bring an existing client by adding a new minor version.

Tue, Sep 10, 4:43 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel added a comment to T232485: RFC: Core REST API namespace and version.

Exposing minor versions of the API in the path seems like a questionable solution. Changes between minor API versions should be backwards-compatible, so there's not real need for the client to request a specific non-latest version of the API.

Tue, Sep 10, 4:35 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
daniel added a comment to T229601: Service disabled: DBLoadBalancerFactory while CLI installation failed.

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

Tue, Sep 10, 6:25 AM · MW-1.34-release, MediaWiki-Installer, MediaWiki-ServiceContainer

Sat, Sep 7

daniel added a comment to T228988: Create batch access interface for page content.

We have the batch API to grab revisions from rows and the batch API to fetch blobs T230834, but we haven't really connected the 2 together yet, so no, this is not entirely done.

Sat, Sep 7, 8:46 PM · Core Platform Team Workboards (Purple), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)