Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (467 w, 5 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Yesterday

daniel added a comment to T345185: Provide a method for internal services to run api requests in a private context.

The NetworkAuth extension would cover the need, though we'd likely want to trim it down a bit for production use.

Wed, Sep 27, 3:39 PM · serviceops, Discovery-Search (Current work), MediaWiki-Configuration, MediaWiki-Platform-Team, CirrusSearch
daniel added a comment to T346383: Edits to file description pages schedule recursive refreshLinks jobs unnecessarily.

By the way, I was very pleasantly surprised to find the wasRedirect() method already existing on DerivedPageDataUpdater. When I was starting this task, I thought I'd have to go on a big adventure just to ferry that piece of data from wherever it is generated to where I needed it, but it was already there! Thanks @daniel, amazing foresight :)

Wed, Sep 27, 7:04 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), MediaWiki-Platform-Team, MediaWiki-Page-derived-data, MediaWiki-General

Mon, Sep 25

daniel added a comment to T336693: Re-implement reading lists REST interface outside RESTbase.

testing of the RESTBase endpoint /data/lists/{id}/entries does not show these additional fields actually being included in the response, although review of the code suggests they should be there. The reasons for this are currently unclear.

Mon, Sep 25, 4:33 PM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel renamed T336693: Re-implement reading lists REST interface outside RESTbase from Re-implement reading lists REST interface in PHP to Re-implement reading lists REST interface outside RESTbase.
Mon, Sep 25, 4:31 PM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel added a comment to T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.).

If we do need some other combination of SQL and data built around a binary operator, another method would be needed.

Mon, Sep 25, 11:57 AM · Patch-For-Review, Platform Engineering (Icebox), MediaWiki-libs-Rdbms

Fri, Sep 22

daniel added a comment to T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.

Note that there are two options:

  1. call the parsoid endpoints exposed by the extension
  2. call the page endpoints exposed by core
Fri, Sep 22, 9:54 AM · Language-Team (Language-2023-July-September), CX-cxserver, serviceops, RESTBase Sunsetting

Thu, Sep 21

daniel updated subscribers of T346765: Control ParserCache use per namespace, based on parse time and output size..
Thu, Sep 21, 11:26 AM · MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting, Parsoid

Wed, Sep 20

daniel added a comment to T336693: Re-implement reading lists REST interface outside RESTbase.

This could be a problem... To put this in perspective, I dug around and made a histogram of how many different projects are references from individual reading lists.

Wed, Sep 20, 5:35 PM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel created P52546 Histogram of how many different projects are used in reading lists.
Wed, Sep 20, 5:29 PM
daniel added a comment to T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.).

Some ideas:

Wed, Sep 20, 5:02 PM · Patch-For-Review, Platform Engineering (Icebox), MediaWiki-libs-Rdbms
daniel added a subtask for T339866: Remove TemporaryParsoidHandlerParserCacheWriteRatio setting from MediaWiki: T346765: Control ParserCache use per namespace, based on parse time and output size..
Wed, Sep 20, 3:27 PM · Patch-For-Review, Parsoid (Tracking), RESTBase Sunsetting, Code-Health
daniel added a parent task for T346765: Control ParserCache use per namespace, based on parse time and output size.: T339866: Remove TemporaryParsoidHandlerParserCacheWriteRatio setting from MediaWiki.
Wed, Sep 20, 3:27 PM · MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting, Parsoid
daniel added projects to T267067: Make language variant a parser option: Content-Transform-Team, Parsoid-Read-Views.
Wed, Sep 20, 5:39 AM · MediaWiki-Language-converter, Parsoid, MediaWiki-General, MediaWiki-Parser

Tue, Sep 19

daniel added a comment to T336693: Re-implement reading lists REST interface outside RESTbase.
  • The RESTBase API depends on (and internally calls) the Action API endpoints

Probably worth emphasizing that a single RESTBase API call might involve Action API calls to multiple wikis.

Tue, Sep 19, 5:20 PM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel added a comment to T336693: Re-implement reading lists REST interface outside RESTbase.

Looks like the summary isn't actually used by the app, see T346739.

Tue, Sep 19, 4:31 PM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel added a parent task for T346739: Remove 'summary' field from reading list sync structures.: T336693: Re-implement reading lists REST interface outside RESTbase.
Tue, Sep 19, 4:30 PM · Wikipedia-Android-App-Backlog (Android Release - FY2023-24)
daniel added a subtask for T336693: Re-implement reading lists REST interface outside RESTbase: T346739: Remove 'summary' field from reading list sync structures..
Tue, Sep 19, 4:30 PM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel added a comment to T333235: [Epic] Technical Decision Forum retrospective: Phase 1.

A quick update on the status of the retrospective process: We have concluded the survey and had two listening sessions last week. We are currently evaluating the survey response and deciding whether more listening sessions are needed.

Tue, Sep 19, 4:13 PM · tech-decision-forum
daniel triaged T333235: [Epic] Technical Decision Forum retrospective: Phase 1 as Medium priority.
Tue, Sep 19, 4:08 PM · tech-decision-forum
daniel updated subscribers of T346765: Control ParserCache use per namespace, based on parse time and output size..
Tue, Sep 19, 2:42 PM · MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting, Parsoid
daniel updated the task description for T346765: Control ParserCache use per namespace, based on parse time and output size..
Tue, Sep 19, 2:41 PM · MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting, Parsoid
daniel created T346765: Control ParserCache use per namespace, based on parse time and output size..
Tue, Sep 19, 2:29 PM · MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting, Parsoid

Mon, Sep 18

daniel added a comment to T226644: WikiPage::isRedirect and WikiPage::getRedirectTarget() seemingly disagree.

I found this task while working on T346290. It seems that this has already been fixed once in rMW6feea17779d3: Safer WikiPage redirect functions, then un-fixed in rMWf37ebf4478d2: Introduce PageRecord interface. Let's try to fix it one more time.

Mon, Sep 18, 8:31 AM · MediaWiki-Platform-Team, MediaWiki-Redirects, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Core-Revision-backend
daniel added a comment to T336693: Re-implement reading lists REST interface outside RESTbase.

Thanks for looking into this @BPirkle! What you write mastly matches my own superficial understanding.

Mon, Sep 18, 6:53 AM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting

Thu, Sep 14

daniel updated the task description for T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.
Thu, Sep 14, 3:57 PM · Language-Team (Language-2023-July-September), CX-cxserver, serviceops, RESTBase Sunsetting
daniel added a comment to T336693: Re-implement reading lists REST interface outside RESTbase.

Not really. The RESTBase API fetches a list of (wiki ID, page ID) pairs from the action API (doesn't matter which wiki), then sends parallel the RESTBase summary endpoint to get the page titles and summaries (I think those are cached internally in RESTBase).

Thu, Sep 14, 6:46 AM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting
daniel updated the task description for T336693: Re-implement reading lists REST interface outside RESTbase.
Thu, Sep 14, 6:45 AM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting

Wed, Sep 13

daniel updated the task description for T336693: Re-implement reading lists REST interface outside RESTbase.
Wed, Sep 13, 10:49 AM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting

Tue, Sep 12

daniel added a comment to T344946: Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase).

After some discussion, we collectively realized that WikiPage::doPurge will invalidate all relevant parser cache entries, and any resource-change event emitted by it applies to output of parsoid and the old parser alike. This makes it a lot easier to reason about things, we don't have to worry about when things actually get written to the parser cache.

Tue, Sep 12, 4:09 PM · Parsoid (Tracking), ChangeProp, MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting
daniel updated the task description for T344946: Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase).
Tue, Sep 12, 4:06 PM · Parsoid (Tracking), ChangeProp, MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting
daniel updated the task description for T336693: Re-implement reading lists REST interface outside RESTbase.
Tue, Sep 12, 9:33 AM · Reading List Service, MediaWiki-extensions-ReadingList, RESTBase Sunsetting

Mon, Sep 11

daniel created T346036: ActionFactory should determine action info without instantiating the Action object.
Mon, Sep 11, 12:37 PM · MediaWiki-User-management, MediaWiki-Interface (actions)

Thu, Sep 7

daniel added a comment to T345777: Consider making RevisionArchiveRecord::userCan() also check the page deletion permissions.

I support this idea. I can't think of a situation where the current behavior would be required. The check can still be bypassed using RevisionRecord::RAW if needed.

Thu, Sep 7, 8:27 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, Security, MediaWiki-General
daniel added a comment to T20493: RFC: Unify the various deletion systems.

A very old idea, T5843: Implement semi-deletion, may also be taken into account when we start to do this (it is not required, but a future schema change may make some reservation to make it easier to happen). Probably I will write a longer comment about this later.

Thu, Sep 7, 8:14 AM · MediaWiki-Revision-deletion, TechCom-RFC, Stewards-and-global-tools, MediaWiki-Page-deletion
daniel updated the task description for T5843: Implement semi-deletion.
Thu, Sep 7, 8:10 AM · MediaWiki-Page-deletion

Mon, Sep 4

daniel added a comment to T286610: Exception: Serialization of 'Closure' is not allowed.

It would be nice to resolve the underlying design flaw that caused this issue. I added a comment to the patch with some thoughts.

Mon, Sep 4, 11:26 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Data-Engineering, MediaWiki-extensions-EventLogging, Analytics-Radar, Wikimedia-production-error

Wed, Aug 30

daniel added a comment to T345289: Come up with a way to make Wikifunctions calls not keep a PHP process alive whilst waiting for the backend.

The now not-really-stateless back-end service

Wed, Aug 30, 8:21 PM · function-orchestrator, serviceops, WikiLambda, Abstract Wikipedia team
daniel updated subscribers of T345289: Come up with a way to make Wikifunctions calls not keep a PHP process alive whilst waiting for the backend.

The idea sounds good, but I have no idea whether it's practical.

Wed, Aug 30, 8:15 PM · function-orchestrator, serviceops, WikiLambda, Abstract Wikipedia team

Tue, Aug 29

daniel added a comment to T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates..

re polymorphic modeling: I not that we have the same problem with the ipblocks_restrictions table, where the ir_value field may reepresent a page ID or a namespace ID.

Tue, Aug 29, 9:41 AM · Multi-Blocks, Community-Wishlist-Survey-2023, MediaWiki-Blocks
daniel added a comment to T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates..

In this context, please note that we are relying on the assumption that there can only be a single active block in some places. In particular, when we want to provide information about the block of a given user, we just look at the most recent block log entry for that user. There is no good way right now to list all active blocks for a user and provide all relevant details about each block, because some of the info is in the block itself, and some is in the respective log entry. If we can have multiple active blocks for a given user, we should have a better way to link block log entries to blocks.

Tue, Aug 29, 9:38 AM · Multi-Blocks, Community-Wishlist-Survey-2023, MediaWiki-Blocks

Aug 25 2023

daniel added a comment to T335513: Selective outage of `/wikitext/to/lint` and `/html/to/wikitext` RESTBase endpoints.

Someone should really clarify what we are talking about here.

API servers, endpoints, gateways apps, envoy, internal, external, public, the terminology is used all mixed and inconsistently. Ppl don't know what to expect. To quote discord: "i'm screaming pre-emptively [..] no docs on what's supposed to be the new endpoints"

Aug 25 2023, 3:30 PM · Parsoid, RESTBase Sunsetting
daniel updated the task description for T333536: Survey RESTBase services and find which ones accesses Parsoid via RESTBase.
Aug 25 2023, 10:23 AM · API Platform (RESTbase Deprecation Roadmap), serviceops, RESTBase Sunsetting, Epic, Platform Engineering Roadmap
daniel created T344982: Make cxserver call parsoid endpoints on MediaWiki, instead of going through RESTbase.
Aug 25 2023, 10:00 AM · Language-Team (Language-2023-July-September), CX-cxserver, serviceops, RESTBase Sunsetting
daniel updated the task description for T334238: Create deprecation plan for public parsoid endpoints.
Aug 25 2023, 8:45 AM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel updated the task description for T334238: Create deprecation plan for public parsoid endpoints.
Aug 25 2023, 8:40 AM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel removed a subtask for T262315: <CORE TECHNOLOGY> API Migration & RESTbase Sunset: T334238: Create deprecation plan for public parsoid endpoints.
Aug 25 2023, 8:40 AM · API Platform (RESTbase Deprecation Roadmap), Epic, Foundational Technology Requests, Code-Health, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel added a subtask for T344944: Move Parsoid endpoints out of RESTbase: T334238: Create deprecation plan for public parsoid endpoints.
Aug 25 2023, 8:40 AM · Content-Transform-Team, Parsoid, RESTBase Sunsetting, Epic
daniel edited parent tasks for T334238: Create deprecation plan for public parsoid endpoints, added: T344944: Move Parsoid endpoints out of RESTbase; removed: T262315: <CORE TECHNOLOGY> API Migration & RESTbase Sunset.
Aug 25 2023, 8:40 AM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel closed T329366: Enable WarmParsoidParserCache on all wikis, a subtask of T320534: Put Parsoid output into the ParserCache on every edit, as Resolved.
Aug 25 2023, 8:37 AM · Patch-For-Review, RESTBase Sunsetting, Performance-Team (Radar), MediaWiki-Parser, Platform Team Workboards (MW Expedition)
daniel closed T329366: Enable WarmParsoidParserCache on all wikis, a subtask of T344945: Disable storage of Parsoid content in RESTbase, as Resolved.
Aug 25 2023, 8:37 AM · Parsoid (Tracking), RESTBase Sunsetting, Epic
daniel closed T329366: Enable WarmParsoidParserCache on all wikis as Resolved.

Parsoid cache warming has been enabled everywhere for a couple of months now.

Aug 25 2023, 8:37 AM · serviceops, Parsoid (Tracking), RESTBase Sunsetting
daniel closed T341123: High insertion rate of ParsoidCachePrewarmJob causes substantial backlog as Resolved.

Resolved by increasing processing concurrency for the cache warming jobs.

Aug 25 2023, 8:36 AM · MW-1.41-notes (1.41.0-wmf.19; 2023-07-25), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid (Tracking), serviceops-radar, Patch-For-Review, RESTBase Sunsetting
daniel closed T341123: High insertion rate of ParsoidCachePrewarmJob causes substantial backlog, a subtask of T327164: Trigger ParsoidCachePrewarmJob on page views, as Resolved.
Aug 25 2023, 8:36 AM · Content-Transform-Team, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid (Tracking), MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Performance-Team (Radar), MediaWiki-Parser, RESTBase Sunsetting
daniel updated the task description for T328559: Replace usage of RESTbase parsoid endpoints.
Aug 25 2023, 8:35 AM · serviceops, RESTBase Sunsetting, Epic, Platform Engineering Roadmap
daniel closed T320536: Ensure that stashing backend for the VE API has sufficient capacity as Resolved.

We have been using the new backend for a couple of months now. It has been working fine.

Aug 25 2023, 8:34 AM · RESTBase Sunsetting, Data-Persistence, MediaWiki-Configuration, Editing-team, VisualEditor, Platform Team Workboards (MW Expedition)
daniel closed T320536: Ensure that stashing backend for the VE API has sufficient capacity, a subtask of T320529: Configure VE backend to use Parsoid directly, instead of calling RESTbase, as Resolved.
Aug 25 2023, 8:34 AM · User-notice-archive, RESTBase Sunsetting, MediaWiki-Configuration, Editing-team, VisualEditor, Platform Team Workboards (MW Expedition)
daniel removed a subtask for T262315: <CORE TECHNOLOGY> API Migration & RESTbase Sunset: T328559: Replace usage of RESTbase parsoid endpoints.
Aug 25 2023, 8:33 AM · API Platform (RESTbase Deprecation Roadmap), Epic, Foundational Technology Requests, Code-Health, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel added a subtask for T344944: Move Parsoid endpoints out of RESTbase: T328559: Replace usage of RESTbase parsoid endpoints.
Aug 25 2023, 8:32 AM · Content-Transform-Team, Parsoid, RESTBase Sunsetting, Epic
daniel edited parent tasks for T328559: Replace usage of RESTbase parsoid endpoints, added: T344944: Move Parsoid endpoints out of RESTbase; removed: T262315: <CORE TECHNOLOGY> API Migration & RESTbase Sunset.
Aug 25 2023, 8:32 AM · serviceops, RESTBase Sunsetting, Epic, Platform Engineering Roadmap
daniel updated the task description for T328559: Replace usage of RESTbase parsoid endpoints.
Aug 25 2023, 8:32 AM · serviceops, RESTBase Sunsetting, Epic, Platform Engineering Roadmap
daniel updated the task description for T344946: Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase).
Aug 25 2023, 8:30 AM · Parsoid (Tracking), ChangeProp, MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting
daniel updated the task description for T344946: Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase).
Aug 25 2023, 8:23 AM · Parsoid (Tracking), ChangeProp, MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting

Aug 24 2023

daniel added a comment to T332435: Update VisualEditor for IP masking.

I wouldn't mind that, but the whole project is called IP Masking

Aug 24 2023, 7:11 PM · Skipped QA, Goal, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Editing-team (Kanban Board), IP Masking, VisualEditor-MediaWiki, VisualEditor
daniel created T344946: Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase).
Aug 24 2023, 5:48 PM · Parsoid (Tracking), ChangeProp, MediaWiki-Core-HTTP-Cache, RESTBase Sunsetting
daniel updated the task description for T344944: Move Parsoid endpoints out of RESTbase.
Aug 24 2023, 5:44 PM · Content-Transform-Team, Parsoid, RESTBase Sunsetting, Epic
daniel added a project to T344943: Determine how PCS will be informed about resource changes in a world without RESTbase: ChangeProp.
Aug 24 2023, 5:42 PM · ChangeProp, RESTBase Sunsetting, Page Content Service
daniel added a parent task for T329366: Enable WarmParsoidParserCache on all wikis: T344945: Disable storage of Parsoid content in RESTbase.
Aug 24 2023, 5:38 PM · serviceops, Parsoid (Tracking), RESTBase Sunsetting
daniel added a subtask for T344945: Disable storage of Parsoid content in RESTbase: T329366: Enable WarmParsoidParserCache on all wikis.
Aug 24 2023, 5:38 PM · Parsoid (Tracking), RESTBase Sunsetting, Epic
daniel updated subscribers of T344945: Disable storage of Parsoid content in RESTbase.
Aug 24 2023, 5:32 PM · Parsoid (Tracking), RESTBase Sunsetting, Epic
daniel created T344945: Disable storage of Parsoid content in RESTbase.
Aug 24 2023, 5:32 PM · Parsoid (Tracking), RESTBase Sunsetting, Epic
daniel created T344944: Move Parsoid endpoints out of RESTbase.
Aug 24 2023, 5:29 PM · Content-Transform-Team, Parsoid, RESTBase Sunsetting, Epic
daniel created T344943: Determine how PCS will be informed about resource changes in a world without RESTbase.
Aug 24 2023, 5:23 PM · ChangeProp, RESTBase Sunsetting, Page Content Service
daniel added a comment to T332435: Update VisualEditor for IP masking.

I find the term "IP masking" really misleading, can we rename the task so it talks about "automatic temp accounts" or something?

Aug 24 2023, 5:16 PM · Skipped QA, Goal, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Editing-team (Kanban Board), IP Masking, VisualEditor-MediaWiki, VisualEditor
daniel added a comment to T265749: Research to create service for DeferredUpdates::addUpdate().

I like the idea of having DeferredUpdate act as a simple extension of the PHP runtime. However, its current implementation integrates with the per-wiki DB LoadBalancer instance. That logic would need to be factored out of the DeferredUpdate class. I added a comment on the patch with some ideas around that: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/951187/34#message-52b48595021e45b8f6c39f78a1bffd50feb88808

Aug 24 2023, 10:27 AM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), Patch-For-Review, User-xSavitar, MediaWiki-Platform-Team, User-DannyS712, MediaWiki-General, Dependency injection

Aug 21 2023

daniel added a comment to T337103: Decide a standard approach for classifying temporary, IP and registered users.

"Classification" in which context?

  • From a users perspective there is not really a difference between anonymous (a.k.a. "ip") and temporary (a.k.a. "unnamed"). There is especially nothing the user can do about this. The wiki's configuration dictates which of the two gets assigned to users without an account. So for users the new "temporary account" system is the same as what we previously called "anonymous". In a sense the new system is even more anonymous and I would continue calling it like that.
  • From a devs perspective there is not much of a difference between "named" and "unnamed" user accounts. The outlier here is the ip address. This leads to a fundamentally different classification than above.

Sorry if I'm late to the show. But unfortunately the ticket appears to confuse these two scenarios. Or I get it wrong.

Aug 21 2023, 2:20 PM · Anti-Harassment (AHaT Sprint 32 - Baseball Cap), IP Masking

Aug 17 2023

daniel added a comment to T167246: Refactor "user" & "user_text" fields into "actor" reference table.

We worked on this at the hackathon a bit and I think we figured it out on our usecase (the first uploader is sometimes in the image table and sometimes in the oldimage table, so you have to use both.

Aug 17 2023, 12:16 PM · MediaWiki-Core-Revision-backend, Platform Team Initiatives (Revision Storage Schema Improvements), Schema-change, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic
daniel added a comment to T167246: Refactor "user" & "user_text" fields into "actor" reference table.

I'm a bit confused now, how is it supposed to get the first uploader of the file now?

Aug 17 2023, 7:44 AM · MediaWiki-Core-Revision-backend, Platform Team Initiatives (Revision Storage Schema Improvements), Schema-change, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic

Aug 16 2023

daniel renamed T344329: Determine the cause of x8 increase in requests to math endpoints between july 6 and August 3 2023 from Determin the cause of a sudden 80% drop in requests to math endpoints to Determin the cause of x8 increase in requests to math endpoints between july 6 and August 3.
Aug 16 2023, 3:03 PM · SRE, RESTBase Sunsetting, Traffic, Math
daniel updated the task description for T344329: Determine the cause of x8 increase in requests to math endpoints between july 6 and August 3 2023.
Aug 16 2023, 3:01 PM · SRE, RESTBase Sunsetting, Traffic, Math
daniel created T344329: Determine the cause of x8 increase in requests to math endpoints between july 6 and August 3 2023.
Aug 16 2023, 9:43 AM · SRE, RESTBase Sunsetting, Traffic, Math

Jul 28 2023

daniel added projects to T339293: Wikimedia\Assert\PostconditionException: Postcondition failed: Regex failed: 4: MediaWiki-REST-API, API Platform.

Ping @FJoseph-WMF: we need some kind of intake process for this kind of thing...

Jul 28 2023, 2:48 PM · API Platform, MediaWiki-REST-API, CirrusSearch, Wikimedia-production-error

Jul 26 2023

daniel added a comment to T339867: RESTbase: Turn off pre-generation and caching for parsoid endpoints.

The experiment of disabling parser cache writes in the parsoid endpoints was successfull: the jobrunner cluster can handle the load of doing all the parsoid re-parses on page edits without the help of the parsoid cluster. To achieve this, allowed concurrency for the parsoidCachePrewarm job had to be increased significantly.

Jul 26 2023, 2:33 PM · Parsoid (Tracking), RESTBase Sunsetting
daniel added a comment to T342733: SkinException: No registered builder available for ..

I have not looked at the details, but the only recently merged change that seems potentially relevant is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/935921 by @tstarling.

Jul 26 2023, 10:44 AM · MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), MediaWiki-Interface, Wikimedia-production-error

Jul 24 2023

daniel added a comment to T340247: 1.41.0-wmf.19 deployment blockers.
  1. Risky Patch! 🚂🔥
Jul 24 2023, 7:25 AM · Patch-For-Review, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments

Jul 20 2023

daniel changed the status of T339138: TDMP: Client Software Guidelines from Open to Stalled.

Stalled for now, the plan is to come back to this in a month or two when we have team priorities sorted out.

Jul 20 2023, 6:08 PM · tech-decision-forum
daniel added a comment to T342085: Increase to >3s for parsoid average get/200 latency since 2023-7-15 12:30.

Ok that explains it. Can't we make restbase just invalidate content instead of also re-generating it?

Jul 20 2023, 2:52 PM · Parsoid (Tracking), serviceops
daniel added a comment to T342085: Increase to >3s for parsoid average get/200 latency since 2023-7-15 12:30.

Correcting myself, the edit that is causing all these pages to be re-rendered is a template edit:

https://commons.wikimedia.org/w/index.php?title=Template%3ANARA-image-full&diff=783237367&oldid=417690735

Again @daniel @ssastry can you imagine a reason why this propagated via restbase but not in the parsoidPreWarm job?

Jul 20 2023, 9:34 AM · Parsoid (Tracking), serviceops

Jul 19 2023

daniel added a comment to T341102: addWiki.php fails with CannotReplaceActiveServiceException.

I wonder if it's possible to just split out "create the main MediaWiki DB" into a separate script, so the main script can be called with the actual wiki as its --wiki parameter.

Jul 19 2023, 7:54 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
daniel added a comment to T341102: addWiki.php fails with CannotReplaceActiveServiceException.

The general way is to reserve a window, pull this patch onto an mwmaint server, and try to do the next one on the list (so probably T335216?). Which is… not ideal.

Jul 19 2023, 7:52 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance

Jul 18 2023

daniel added a comment to T341102: addWiki.php fails with CannotReplaceActiveServiceException.

I made a patch that shows how I think this should be approached.
I have no way to safely test this. @Ladsgroup do you have thoughts on how to figure out if this works, without breaking stuff?

Jul 18 2023, 4:54 PM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
daniel triaged T341102: addWiki.php fails with CannotReplaceActiveServiceException as High priority.

Bumping to "high" since this is blocking the deployment of wikifunctions which is scheduled for next week.

Jul 18 2023, 4:29 PM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
daniel updated subscribers of T341102: addWiki.php fails with CannotReplaceActiveServiceException.

The offending code is:

Jul 18 2023, 4:28 PM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
daniel added a comment to T341102: addWiki.php fails with CannotReplaceActiveServiceException.

It would be nice to have a debug option in MediaWikiServices where for each service it stores the stack trace of when it was initialized the first time, and prints that on conflict.

Jul 18 2023, 4:19 PM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
daniel updated the task description for T320559: Trace header propagation for MediaWiki.
Jul 18 2023, 2:29 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing
daniel updated the task description for T320559: Trace header propagation for MediaWiki.
Jul 18 2023, 6:45 AM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing

Jul 17 2023

daniel added a comment to T155147: Do not initialise the database in tests when not needed.

I was thinking about this, and I think we should allow calls to simple methods like LBFactory::getLocalDomainID for now, but mock their return value. As long as the tests don't make any queries, it should be fine. getLocalDomainID is used a lot in ServiceWiring and other places that simply try to figure out what's the local wiki. I think this is fine, and it would avoid the majority of the failures I've seen.

Jul 17 2023, 3:24 PM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), Technical-Debt, MediaWiki-Core-Tests
daniel created P49564 Daniel's RESTbase Config.
Jul 17 2023, 9:56 AM

Jul 12 2023

daniel added a comment to T341666: Wikimedia\RequestTimeout\RequestTimeoutException on de:Holomorphe_Funktion and several other math-heavy articles.

When developing the runMulti approach to render formulae in parallel we did assume that the onParserAfterTidy hook would be called once. This seems not to be the case for that example page.

Jul 12 2023, 8:03 PM · Cite, Math, Performance Issue, Wikimedia-production-error
daniel added projects to T341666: Wikimedia\RequestTimeout\RequestTimeoutException on de:Holomorphe_Funktion and several other math-heavy articles: Math, Cite.
Jul 12 2023, 7:54 PM · Cite, Math, Performance Issue, Wikimedia-production-error
daniel updated subscribers of T341666: Wikimedia\RequestTimeout\RequestTimeoutException on de:Holomorphe_Funktion and several other math-heavy articles.

@daniel Do you think it would be a good idea to increase the number of concurrent requests for formulae (default 50)?

Jul 12 2023, 7:34 PM · Cite, Math, Performance Issue, Wikimedia-production-error