daniel (Daniel Kinzler)
User

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (222 w, 4 d)
Availability
Available
IRC Nick
DanielK_WMDE
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Yesterday

daniel added a comment to T213318: Wikibase Front-End Architecture.

24% of all wikimedia pageviews are for Wikidata? I find that extremely surprising. Is that on the app servers, or does it include CDN cache hits?

Tue, Jan 15, 10:48 PM · Wikidata, TechCom-RFC
daniel added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

The second instance involves the TitleMoveComplete hook. Moving a page creates a dummy revision, which probably has not yet been replicated to all replicas when the hook handler is called. The hook handler, FlaggedRevsHooks::onTitleMoveComplete, may have to force the master database to be used, via the appropriate query flags. This should be safe, since the hook is only fired in requests that write to master anyway.

Tue, Jan 15, 9:18 PM · Multi-Content-Revisions (Reactive), Core Platform Team Kanban, Core Platform Team (MCR), Wikimedia-production-error, MediaWiki-General-or-Unknown
daniel updated subscribers of T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

The first instance looks like a race condition including a 3rd party client (bot). E.g. bot makes and edit, and immediately tries to load the revision. Or a bot lists revisions, and then tries to load their content by ID, in a different request, hitting a different replica that is more lagged.

Tue, Jan 15, 9:15 PM · Multi-Content-Revisions (Reactive), Core Platform Team Kanban, Core Platform Team (MCR), Wikimedia-production-error, MediaWiki-General-or-Unknown
daniel added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

Option "a" could cause an outage on the master if for any reason all the replicas are lagging

Tue, Jan 15, 4:13 PM · Multi-Content-Revisions (Reactive), Core Platform Team Kanban, Core Platform Team (MCR), Wikimedia-production-error, MediaWiki-General-or-Unknown
daniel added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

To go out on a limb here, this looks like it's caused by replication lag: some bit of code is trying to load the vision from a replica right after it has been saved, and it hasn't been replicated yet. This can be avoided by a) falling back to loading from master if the revision isn't found on the replica, and b) making the RevisionRecord that was created when the edit was made directly available to the code that needs it. (b) is preferable, but often rather hard to do.

Tue, Jan 15, 4:03 PM · Multi-Content-Revisions (Reactive), Core Platform Team Kanban, Core Platform Team (MCR), Wikimedia-production-error, MediaWiki-General-or-Unknown
daniel added a project to T207621: Improve maintainability and scalability of Mail component: MediaWiki-Decoupling.
Tue, Jan 15, 3:53 PM · Core Platform Team Kanban (Waiting for Review), Core Platform Team ( Code Health (TEC13)), MediaWiki-Decoupling, TechCom, Patch-For-Review, MediaWiki-Email
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

The reason this is a dedicated service is the language it is written in (typescript), which was chosen because it allows us to create an implementation which can be compiled/transpiled to work on both server and client - something not possible with PHP.

Tue, Jan 15, 1:25 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T213318: Wikibase Front-End Architecture.

A quick note on how Wikidata is different, particularly from Wikipedia:

Tue, Jan 15, 12:43 PM · Wikidata, TechCom-RFC

Thu, Jan 10

daniel added a comment to T213453: AbuseFilter MCR diff is comparing old value of one slot with the new value from another, not the old whole page with the new whole page.

Getting the whole old revision in the form expected is easy, AbuseFilter::revisionToString
We need to get from the Content / string text to the new revision though. So we need to figure out what slot has been edited so that we can make a "pretend" whole revision to use for extracting the whole text, or just have that whole revision passed all the way down, instead of just the content / text.

Thu, Jan 10, 5:36 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), User-Addshore, SDC Engineering, Core Platform Team (MCR), AbuseFilter

Tue, Jan 8

daniel added a comment to T212911: My account was removed from the Wikimedia Github group.

@Bawolff my assumption was that project membership was intended to reflect current staff. Unfortunately, there seems to be no documentation for this. Perhaps this should be reviews as part of the upcoming revamp of the +2 policy for gerrit.

Tue, Jan 8, 5:38 PM · Security
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

Did the chat with @Joe happen? What was the outcome?

Tue, Jan 8, 2:59 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel closed T107595: [RFC] Multi-Content Revisions as Resolved.

This RFC is done. The storage layer of MCR is implemented and deployed. Further refactoring and new features building on top of that will be discussed in separate RFCs if needed.

Tue, Jan 8, 2:53 PM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Epic), Epic, User-Daniel, Wikidata-Sprint-2015-11-17, Wikimedia-Developer-Summit-2016, Wikidata, Wikidata-Sprint-2015-09-15, TechCom-RFC
daniel closed T107595: [RFC] Multi-Content Revisions, a subtask of T146637: Wikidata 2016 Q4 goals, as Resolved.
Tue, Jan 8, 2:53 PM · Tracking, Wikidata
daniel added a comment to T168726: Create syntax documentation page for Special:PageData.

Special:PageData is intended to provide a canonical way to get the raw content of a page, in machine readable form. The syntax depends on the page's content model - on most pages, it will be WikiText. Note that raw content is different from the page's meta-data. In case of media files, this line is somewhat blurry. EXIF data is currently treated as meta-data, not content. And the actual media blob is treated as a raw file, not page content either. Both could potentially be treated as page content in the future, but there are no concrete plans for this.

Tue, Jan 8, 2:51 PM · Documentation, MediaWiki-Special-pages
daniel removed a subtask for T107595: [RFC] Multi-Content Revisions: T198492: Drop rev_text_id and ar_text_id when running update.php.
Tue, Jan 8, 2:47 PM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Epic), Epic, User-Daniel, Wikidata-Sprint-2015-11-17, Wikimedia-Developer-Summit-2016, Wikidata, Wikidata-Sprint-2015-09-15, TechCom-RFC
daniel edited parent tasks for T198492: Drop rev_text_id and ar_text_id when running update.php, added: T174043: Deploy Multi-Content Revisions, T174022: Implement multi-content revisions; removed: T107595: [RFC] Multi-Content Revisions.
Tue, Jan 8, 2:47 PM · Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), Core Platform Team Backlog (Later), MW-1.33-release, Wikidata
daniel added a subtask for T174022: Implement multi-content revisions: T198492: Drop rev_text_id and ar_text_id when running update.php.
Tue, Jan 8, 2:47 PM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Epic), SDC Engineering, SDC General, Wikidata, Epic
daniel added a subtask for T174043: Deploy Multi-Content Revisions: T198492: Drop rev_text_id and ar_text_id when running update.php.
Tue, Jan 8, 2:47 PM · Core Platform Team (MCR), Multi-Content-Revisions (Deployment), Core Platform Team Backlog (Epic), SDC Engineering, Epic, SDC General, Wikidata
daniel moved T200297: Introduce a new namespace for collaborative judgments about wiki entities from Inbox to Backlog on the TechCom-RFC board.

Moving this to "backlog" for now. This should have happened right after last week's TechCom meeting, but I forgot to do it.

Tue, Jan 8, 2:42 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Scoring-platform-team (Current), DBA, Operations, Jade, TechCom-RFC
daniel moved T212482: RFC: MediaWiki 2018 extension interfaces from Inbox to Under discussion on the TechCom-RFC board.
Tue, Jan 8, 2:31 PM · Performance-Team (Radar), TechCom-RFC, TechCom

Fri, Jan 4

daniel added a comment to T200297: Introduce a new namespace for collaborative judgments about wiki entities.

Quick meta-point:

Fri, Jan 4, 11:31 AM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Scoring-platform-team (Current), DBA, Operations, Jade, TechCom-RFC

Thu, Jan 3

daniel added a comment to T212911: My account was removed from the Wikimedia Github group.

Hi Jan! I removed you (and a few other former employees, IIRC) when looking over group membership in github; We are trying to consolidate onboarding/offboarding procedures, and keep groups on different services in sync. You being in that group seemed like an oversight. As far as I'm aware, membership in the wikimedia organization on github is intended to reflect current staff, with the exception off external people actively involved in ongoing projects. The cleanup is still incomplete, I just took care of the people from the wikidata team.

Thu, Jan 3, 11:58 PM · Security

Mon, Dec 31

Liuxinyu970226 awarded T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap a Mountain of Wealth token.
Mon, Dec 31, 12:44 AM · Wikidata-Ministry-Of-Magic-Tech-Debt, TechCom-RFC, User-Daniel, Proposal, MW-1.27-release (WMF-deploy-2016-05-03_(1.27.0-wmf.23)), MW-1.27-release-notes, MediaWiki-Interwiki, Wikidata, MediaWiki-Sites, SiteMatrix, MediaWiki-extensions-Interwiki

Sat, Dec 22

daniel added a comment to T211849: A particular edit not showing on watchlist.

It's possible that this was caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/452708/. Shouldn't happen, but who knows. Perhaps we should just revert the patch and see what happens.

Sat, Dec 22, 2:35 PM · MediaWiki-Recent-changes, User-Ladsgroup, Regression, Growth-Team, MediaWiki-Watchlist
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

@Krinkle said:

Rather, it starts out on the assumption that we're going to have UI code in production (based on Vue.js) written in a way that contains too much business logic in its templating code.

Sat, Dec 22, 11:10 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Fri, Dec 21

daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

As far as I can see, the situation is this: Option 1 is ruled out already, since data access from wikitext doesn't work with that approach. Options 2 would need community consensus. Option 3 (default repo per entity type, with prefixes used internally) is still on the table. Option 4, proposed by Leszek (federation directly based on entity type, with no prefixes used internally) is made unattractive by by Lydia's statement that we cannot guarantee that we will not need prefixes in the future, which would put us back into the position we are now, giving us the choice between option 2 and 3.

Fri, Dec 21, 5:14 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel added a comment to T210307: Forcelinkupdate appears to have stopped working (on ENWIKI at least).

I pushed a new version of https://gerrit.wikimedia.org/r/481015. The reference to SlotRoleHandler is simply not needed in 1.32. I just removed it. No need to drag in the new service.

Fri, Dec 21, 3:38 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.32-release, Core Platform Team Kanban (Waiting for Review), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), MediaWiki-API, Regression
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

@Joe said:

the SSR service should not need to call the mediawiki api. It should accept all the information needed to render the termbox in the call from mediawiki.
Fri, Dec 21, 3:16 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Thu, Dec 20

daniel added a comment to T210307: Forcelinkupdate appears to have stopped working (on ENWIKI at least).

@Reedy this is really more of a conflict than a dependency. I would recoommend against backportinng SlotRoleHandler to 1.32. I'll touch up the original patch.

Thu, Dec 20, 8:15 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.32-release, Core Platform Team Kanban (Waiting for Review), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), MediaWiki-API, Regression
daniel added a comment to T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).

It should not be possible for $this->mRecord to be null in line 652 of /srv/mediawiki/php-1.33.0-wmf.8/includes/Revision.php. I made a patch that should help us to find out how it does become null.

Thu, Dec 20, 6:27 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
daniel moved T200297: Introduce a new namespace for collaborative judgments about wiki entities from Under discussion to Inbox on the TechCom-RFC board.

Moving to the RFC inbox, so TechCom will look at it during the next meeting. Since DBA have approved the plan, TechCom will probably put the RFC on last call (per T200297#4787259) during its next meeting, which will be on January 3rd.

Thu, Dec 20, 5:36 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Scoring-platform-team (Current), DBA, Operations, Jade, TechCom-RFC
daniel added a comment to T212432: Category membership and wikidata not showing up in recent changes.

@Tgr No, that error is specific to forced updates that are not edits.

Thu, Dec 20, 5:31 PM · Growth-Team, MediaWiki-Recent-changes
daniel added a comment to T212427: No namespace configured for entity type `form`.

For the record, the revert should be temporary, on the deployment branch, not on master. This is exposing a problem in the calling code, which needs to be addressed. The revert is not a proper fix, just a stop-gap.

Thu, Dec 20, 4:35 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikidata
daniel updated subscribers of T212427: No namespace configured for entity type `form`.

Pinging @Jakob_WMDE and @Pablo-WMDE, since the rest of the Wikidata team is already out for the holidays. Pinging @Lucas_Werkmeister_WMDE, since he probably knows most about wbcheckconstraints.

Thu, Dec 20, 2:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikidata
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

You first need to render the page on the server before you know whether the client supports JS/SW or not, so it will need to be rendered on the server irrespective of the client's capabilities in case where MW calls the service directly before handing out the page.

Thu, Dec 20, 1:58 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

When rendering the page, index.php knows the exact data that needs to be rendered already, correct?

Thu, Dec 20, 1:55 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

When rendering the page, index.php knows the exact data that needs to be rendered already, correct? If so, it can send that to the client, and then based on whether JS/SW is available or not, the client either renders it or sends a request to the service which sits behind Varnish. Or am I missing something.

Thu, Dec 20, 1:33 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

@Milimetric wrote:

In the simplest case, this code would be almost identical client and server-side. No matter where it's running, nodejs or the browser, it would request data, receive it, and render it as html.

Thu, Dec 20, 1:07 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Wed, Dec 19

daniel added a comment to T200375: Implement Pingback v2.

It would be nice to collect stats about number of pages, users, edits, etc; and info about whether the wiki is open (allows anon edits) or private (allows anon reads).

Wed, Dec 19, 3:42 PM · Core Platform Team, Core Platform Team Backlog (Later), MediaWiki-General-or-Unknown
daniel updated subscribers of T211800: Resolve ambiguity of entity ID prefixes used on Commons..

ping Lydia

Wed, Dec 19, 11:14 AM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

Well, I consider calling the MW api from a service called by MediaWiki an antipattern that we should absolutely avoid.

Wed, Dec 19, 9:10 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

As I am gone for two more weeks, it would probably the best that I shortly answer here: to me it seems both kinds of federation are completely separate and possibly even mutually exclusive. So I would rather not mix these, neither conceptually nor in terms of code. So depending on how you look at it, the difference might be either "a lot" or "not at all".

Wed, Dec 19, 8:41 AM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

I agree with Joe that it would be better to have the service be internal, and be called from MW. It doesn't have to be that way, but it's preferable because:

  • we would not expose a new endpoint
  • we should in general avoid (more) services calling MediaWiki, because:
    • PHP has high startup time, and also for reasons of general hygiene of the architecture
    • we don't want MW and external services calling each other, back and forth
  • "pure functional" services that do not interact with storage are easier to reason about, and easier to run and maintain.
Wed, Dec 19, 8:32 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

Using accept-language is not an option, at least not the accept-language from the browser. The relevant list of languages comes from user preferences and the Babel extension. This also means that it typically contains more than one language, and there are many, many combinations to consider.

Wed, Dec 19, 8:27 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Tue, Dec 18

daniel added a comment to T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed..

Calls to getMainObjectStash: https://codesearch.wmflabs.org/search/?q=getMainObjectStash&i=nope&files=&repos=

Tue, Dec 18, 4:30 PM · Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team (Radar), Operations, MediaWiki-Cache, serviceops
daniel claimed T205444: Provide a way of having a meaningful slot header.
Tue, Dec 18, 3:56 PM · SDC Engineering, Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR)
daniel moved T174031: MCR: Include all slots in XML dumps from Inbox to Waiting for Review on the Core Platform Team Kanban board.
Tue, Dec 18, 3:17 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Core Platform Team (MCR), Multi-Content-Revisions (New Features), SDC Engineering, Wikidata
daniel added a comment to T212189: New Service Request: Wikidata Termbox SSR.

@mobrovac Please note that the term box is shown based on user preferences (languages spoken), the initially served DOM however needs to be the same for all users, so it can be cached. Also note that the language specific data that goes into the term box has to be loaded from the wikibase entity. So the only way to make it work as you suggested would be to always send all the terms in all languages, which, for some items, would be quite a bit of data.

Tue, Dec 18, 2:52 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

A detail to consider when going for "federation without prefixes": does this mean no prefixes just for user input, or also in the JSON serialization? Using no prefixes there either may seem intuitive, but it make the data more brittle, and harder to exchange between instances. Other repos consuming that data will then need to replicate the data-type mapping instead of a prefix mapping. That seems error prone to me.

Tue, Dec 18, 2:42 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel committed rEWBId5cec407383f: Allow MediaInfoIds to have a prefix (authored by daniel).
Allow MediaInfoIds to have a prefix
Tue, Dec 18, 2:33 PM
daniel committed rEWBI625010d5e16f: Allow MediaInfoIds to have a prefix (authored by daniel).
Allow MediaInfoIds to have a prefix
Tue, Dec 18, 2:15 PM
daniel updated subscribers of T211800: Resolve ambiguity of entity ID prefixes used on Commons..
Tue, Dec 18, 2:14 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..
  • Having two not-necessarily same config flying around and parts of code arbitrarily picking one config, and other parts picking up the other seems like a bug/unfinished implementation to me. I am surprised it only surfaces now (it has been for 99% me who had messed that up), but should be fixed. If the current "broken" state actually makes commons work the fixing schedule can be of course postponed :)
Tue, Dec 18, 2:08 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

One source of confusion is the fact that the CachingPropertyInfoLookup used by client code and repo code are hitting the same cache entry. That cache entry ends up containing both prefixed (wikidata:P1) and unprefixed (just P1) property IDs, side by side. This in turn causes API modules, which use the repo service instances, to also accept unprefixed property IDs, which causes data corruption: MediaInfo entities can have some Statements that use prefixed property IDs, and some that use unprefixed property IDs, and these are treated as different and incompatible (correctly - according to the configuration, they come from different repos). Repo side code (in "split brain" operation) should not accept unprefixed property IDs or unprefixed item IDs, since there are no properties or items on the local repo.

Tue, Dec 18, 1:58 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel committed rEWBIb5b949fc1f20: Allow MediaInfoIds to have a prefix (authored by daniel).
Allow MediaInfoIds to have a prefix
Tue, Dec 18, 1:53 PM
daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

I have confirmed locally that the current situations prevents access to MediaInfo entities using the {{#statements}} (nor presumably from Lua, which uses the same underlying mechanism). This means that MediaInfo cannot be used on file description pages as intended, until this is resolved.

Tue, Dec 18, 1:49 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons

Mon, Dec 17

daniel closed T73781: Add support for a "Multi-Part" content model for use with MediaInfo / structured meta-data, a subtask of T68108: [Epic] Store media information for files on Wikimedia Commons as structured data, as Invalid.
Mon, Dec 17, 3:46 PM · GLAM-Tech, Multimedia, Commons, Epic, Wikidata, SDC General
daniel closed T73781: Add support for a "Multi-Part" content model for use with MediaInfo / structured meta-data, a subtask of T66288: basic support for structured data on mediawiki files, as Invalid.
Mon, Dec 17, 3:46 PM · Wikidata, Multimedia, SDC General, MediaWiki-extensions-WikibaseRepository
daniel closed T73781: Add support for a "Multi-Part" content model for use with MediaInfo / structured meta-data as Invalid.

Superseded by MCR.

Mon, Dec 17, 3:46 PM · MediaWiki-ContentHandler
daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

I just realized that this probably blocks access to MediaInfo from wikitext on commons. I have not confirmed this, but if my mental model is right, this needs to be fixed before we'll be able to access MediaInfo from wikitext.

Mon, Dec 17, 3:44 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel added a comment to T210307: Forcelinkupdate appears to have stopped working (on ENWIKI at least).

This should probably be in the 1.32 release.

Mon, Dec 17, 3:36 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.32-release, Core Platform Team Kanban (Waiting for Review), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), MediaWiki-API, Regression
daniel added a project to T210307: Forcelinkupdate appears to have stopped working (on ENWIKI at least): MW-1.32-release.
Mon, Dec 17, 3:36 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.32-release, Core Platform Team Kanban (Waiting for Review), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), MediaWiki-API, Regression
daniel added a comment to T64103: Drop ss_admins from postgres.

As far as I can tell, all patches are merged. Can this be closed now?

Mon, Dec 17, 1:02 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.32-release, Technical-Debt, MediaWiki-Installer, PostgreSQL
daniel added a comment to T191922: Enable $wgCookieSetOnIpBlock by default after the IP cookie block feature is fully tested and released.

Let's do it.

Mon, Dec 17, 1:01 PM · MW-1.33-release, MediaWiki-User-management, MediaWiki-Configuration
daniel added a comment to T197535: extension.json should be able to express dependency on PHP version / PHP extension version.

What's still missing here? The ability for extensions to require a php version, as requested by this ticket, appears to have landed, plus the ability to require php extensions. The patch that is still open seems to be for specifying platform capabilities. That seems to go well beyond the scope of this ticket. Should that really block the release? Am I missing something?

Mon, Dec 17, 12:59 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.32-release, Patch-For-Review, MediaWiki-Configuration
daniel updated subscribers of T203061: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load..

Is anyone committing to implementing this? It's in the backlog for the release, but in no team's backlog, and not assigned to anyone. If nobody committed to doing this, it probably should not block the release.

Mon, Dec 17, 12:49 PM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, MediaWiki-Debian, MediaWiki-General-or-Unknown
daniel added a comment to T200626: Standardize on a single PHP static array writer implementation.

This is marked as a release blocker. What's still needed here?

Mon, Dec 17, 12:42 PM · MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), MW-1.32-release, Librarization, Technical-Debt, MediaWiki-General-or-Unknown
daniel updated subscribers of T203433: Viewing first revision via API gives baddiff error.

If I read the discussion on the patch correctly, this ticket currently blocks the release of 1.32 on the question of whether the API should issue a warning when producing a diff against a revision that does not exist. This seems disproportionate. I think neither solution (having or not having the warning) is so problematic that it should be prevented from being in the release. I would default to restoring the old behavior as-is, even if I didn't particularly like it. On the other hand, if the patch author insists on having the warning, I wouldn't block on that either. In theory, this should be decided by the product owner of the API - which is the job that @EvanProdromou just started. But really, it just doesn't seem big enough of a deal to me to block on it.

Mon, Dec 17, 12:40 PM · MW-1.32-notes, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.32-release, Anti-Harassment, InteractionTimeline, Patch-For-Review, Regression, MediaWiki-API, MediaWiki-History-or-Diffs
daniel added a project to T207628: stubs dumps run much slower after move from bufferied queries to batches: User-Daniel.
Mon, Dec 17, 12:21 PM · User-Daniel, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Dumps-Generation
daniel added a comment to T207628: stubs dumps run much slower after move from bufferied queries to batches.

@ArielGlenn there is a lot of stuff here, I lost track at some point. Can you tell me whether anything urgent remains to be done here? Also, do we have tickets for the things that are not urgent, but should be addressed or investigated?

Mon, Dec 17, 12:21 PM · User-Daniel, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Dumps-Generation

Dec 14 2018

daniel added a comment to T211800: Resolve ambiguity of entity ID prefixes used on Commons..

For option three, we'd have to decide whether the per-entity-type-defaults should be defined separately from the prefix mapping, or whether it should use some kind of special syntax., I'd suggest the hybrid approach we have also been using for including the target slot in EntityNamespaceLookup: use separate arrays internally (cleaner), but use some special syntax in the config (simpler). So for commons, you would have a mapping like [ '@item' => 'wikidata', '@propert' => 'wikidata' ], with the @ indicating that the mapping is not for prefixes, but for entity types.

Dec 14 2018, 10:50 AM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons

Dec 13 2018

daniel added a comment to T211927: SnakDeserializer must apply ID prefix mapping.

This needs a (minor) release of wikibase/data-model-serialization.

Dec 13 2018, 8:44 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Wikibase-DataModel-Serialization, SDC Engineering, Wikidata
daniel added a comment to T211927: SnakDeserializer must apply ID prefix mapping.

Pull request: https://github.com/wmde/WikibaseDataModelSerialization/pull/250

Dec 13 2018, 8:44 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Wikibase-DataModel-Serialization, SDC Engineering, Wikidata
daniel closed T204748: Create Federated Wikibase instance on Beta Commons as Resolved.

Thanks for testing, James!

Dec 13 2018, 7:59 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
daniel created T211927: SnakDeserializer must apply ID prefix mapping.
Dec 13 2018, 7:51 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Wikibase-DataModel-Serialization, SDC Engineering, Wikidata
daniel closed T211801: Find out how to deploy MediaInfo without breaking Commons, a subtask of T204748: Create Federated Wikibase instance on Beta Commons, as Resolved.
Dec 13 2018, 6:04 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
daniel closed T211801: Find out how to deploy MediaInfo without breaking Commons as Resolved.
Dec 13 2018, 6:04 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), WikibaseMediaInfo, SDC Engineering
daniel added a comment to T211801: Find out how to deploy MediaInfo without breaking Commons.

As it turns out, I missed to crucial line of configuration when replicating the setup locally:

Dec 13 2018, 6:04 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), WikibaseMediaInfo, SDC Engineering
daniel committed rEWBIc66731497b5a: Fail hard if no entity namespace is configured for MediaInfo. (authored by daniel).
Fail hard if no entity namespace is configured for MediaInfo.
Dec 13 2018, 1:17 PM
daniel added a comment to T204748: Create Federated Wikibase instance on Beta Commons.

So should MediaInfo items have the page namespace, or their own namespace?

Dec 13 2018, 12:55 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
daniel added a comment to T204748: Create Federated Wikibase instance on Beta Commons.

If MediaInfo items only exist as slots, then I don't really understand why they need a namespace

Dec 13 2018, 12:52 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
daniel committed rEWBI9ef58f8a5199: [DNM] Log entity namespace settings (authored by daniel).
[DNM] Log entity namespace settings
Dec 13 2018, 12:50 PM
daniel added a comment to T204748: Create Federated Wikibase instance on Beta Commons.

I don't think this is the reason that MediaInfo doesn't work on beta, though. That still needs more investigation.

Dec 13 2018, 12:27 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
daniel committed rEWBI8ce9a3a36657: Fail hard if no entity namespace is configured for MediaInfo. (authored by daniel).
Fail hard if no entity namespace is configured for MediaInfo.
Dec 13 2018, 11:54 AM
daniel added a comment to T211801: Find out how to deploy MediaInfo without breaking Commons.

Looking at T204748#4783220 and poking at the code, it seems that the problem is that the entityNamespace setting for MediaInfo is missing. However, this should be impossible, since that setting is forced by the onWikibaseRepoEntityNamespaces hook.

Dec 13 2018, 11:50 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), WikibaseMediaInfo, SDC Engineering
daniel added a comment to T204748: Create Federated Wikibase instance on Beta Commons.

Change 476403 merged by Ladsgroup:
[mediawiki/extensions/WikibaseMediaInfo@master] Don't check for integer namespace in MediaInfoIdLookup

https://gerrit.wikimedia.org/r/476403

Dec 13 2018, 11:20 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata

Dec 12 2018

daniel added a subtask for T204748: Create Federated Wikibase instance on Beta Commons: T211801: Find out how to deploy MediaInfo without breaking Commons.
Dec 12 2018, 6:00 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, SDC Engineering, Wikidata
daniel added a parent task for T211801: Find out how to deploy MediaInfo without breaking Commons: T204748: Create Federated Wikibase instance on Beta Commons.
Dec 12 2018, 6:00 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), WikibaseMediaInfo, SDC Engineering
daniel updated the task description for T211800: Resolve ambiguity of entity ID prefixes used on Commons..
Dec 12 2018, 5:55 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel created T211801: Find out how to deploy MediaInfo without breaking Commons.
Dec 12 2018, 5:45 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), WikibaseMediaInfo, SDC Engineering
daniel created T211800: Resolve ambiguity of entity ID prefixes used on Commons..
Dec 12 2018, 5:44 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, SDC General, Commons
daniel updated subscribers of T211799: Make RDF prefixes configurable.

ping @LucasWerkmeister @Lydia_Pintscher

Dec 12 2018, 5:33 PM · MediaWiki-extensions-WikibaseRepository, Wikidata
daniel added subtasks for T211799: Make RDF prefixes configurable: T196042: Configurable RDF prefixes for WDQS, T194180: Make WDQS UI’s RDF namespaces and standard prefixes configurable.
Dec 12 2018, 5:32 PM · MediaWiki-extensions-WikibaseRepository, Wikidata
daniel added a parent task for T194180: Make WDQS UI’s RDF namespaces and standard prefixes configurable: T211799: Make RDF prefixes configurable.
Dec 12 2018, 5:32 PM · Wikidata-Campsite, Wikidata Query UI, Wikidata
daniel added a parent task for T196042: Configurable RDF prefixes for WDQS: T211799: Make RDF prefixes configurable.
Dec 12 2018, 5:32 PM · Wikibase-Containers, Wikidata
daniel created T211799: Make RDF prefixes configurable.
Dec 12 2018, 5:32 PM · MediaWiki-extensions-WikibaseRepository, Wikidata
daniel renamed T196042: Configurable RDF prefixes for WDQS from Configurable RDF prefixes to Configurable RDF prefixes for WDQS.
Dec 12 2018, 5:29 PM · Wikibase-Containers, Wikidata
daniel added a comment to T194180: Make WDQS UI’s RDF namespaces and standard prefixes configurable.

Is this the same as T196042: Configurable RDF prefixes for WDQS?

Dec 12 2018, 5:26 PM · Wikidata-Campsite, Wikidata Query UI, Wikidata
daniel updated the task description for T200915: Allow SlotRoleHandlers to control page layout.
Dec 12 2018, 4:31 PM · Core Platform Team Backlog (Next), Core Platform Team (MCR), Multi-Content-Revisions (New Features)

Dec 11 2018

daniel added a comment to T211237: wbgetentities has stopped returning content on Beta Cluster Commons.

I have a suspicion about this, but I want to dig some more to confirm. But if I am correct, this never worked on beta, at least not with MediaInfo in slots, with the config that is there now.

Dec 11 2018, 4:55 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, SDC Engineering, WikibaseMediaInfo, Wikidata