daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (184 w, 6 d)
Availability
Available
IRC Nick
DanielK_WMDE
LDAP User
Daniel Kinzler
MediaWiki User
Daniel Kinzler (WMDE)

Recent Activity

Yesterday

daniel added a comment to T106240: Colorable SVG.

Mentioning T66214: Define an official thumb API for reference.

Wed, Apr 25, 9:57 PM · TechCom-RFC, Patch-For-Review, Wikimania-Hackathon-2015, Wikimedia-SVG-rendering
daniel moved T353: RFC: Vertical writing support from Backlog to Declined on the TechCom-RFC board.

Declining as an RFC, since this is not proposing a technical solution. But it's certainly interestingly as a problem statement.

Wed, Apr 25, 9:49 PM · MediaWiki-General-or-Unknown, Language-Team, TechCom-RFC
daniel moved T105845: RFC: Page components / content widgets from Inbox to Radar on the TechCom board.
Wed, Apr 25, 9:41 PM · Services (watching), TechCom, Wikidata, Wikimedia-Developer-Summit-2016, Contributors-Team, Parsoid
daniel edited projects for T105845: RFC: Page components / content widgets, added: TechCom; removed TechCom-RFC.

Dropping this off the RFC board, since it's not actionable. Adding to TechCom radar, since this seems relevant to platform evolution.

Wed, Apr 25, 9:41 PM · Services (watching), TechCom, Wikidata, Wikimedia-Developer-Summit-2016, Contributors-Team, Parsoid
daniel moved T120414: RFC: MediaWiki should provide a pluggable registry for editor interfaces from Under discussion to Backlog on the TechCom-RFC board.

Moving to backlog. Needs to be more of a technical proposal to work as an RFC. @Krinkle said he'd find a related older task and improve the this.

Wed, Apr 25, 9:34 PM · User-Daniel, MediaWiki-Page-editing, CodeEditor, WikiEditor, VisualEditor, Epic, Contributors-Team, TechCom-RFC

Tue, Apr 24

daniel added a comment to T186915: Revision::ensureTitle: Could not determine title for page ID....

The "fell back to READ_LATEST" warning seems to be triggers as follows:

Tue, Apr 24, 9:47 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Wikimedia-log-errors
daniel added a comment to T190015: Create separate user group for editing sitewide JavaScript that does not include administrators by default.

Pinging TechCom. I don't think this needs an RFC, but it's worth a heads up.

Tue, Apr 24, 3:07 PM · TechCom, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
daniel awarded T190015: Create separate user group for editing sitewide JavaScript that does not include administrators by default a Yellow Medal token.
Tue, Apr 24, 3:03 PM · TechCom, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
daniel added a comment to T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints).

prepareSave() is indeed a misnomer, but this is hard to fix. There is an isValid() method which we could call when performing an edit, but that returns a boolean. It does not provide a way to report anything helpful to the user.

Tue, Apr 24, 12:10 PM · User-Daniel, Multi-Content-Revisions, Wikidata, MediaWiki-Platform-Team, MediaWiki-Page-deletion
daniel added a comment to T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints).

@Tgr wrote

Or just allow multiple sitelinks and treat them like constraint violations.

Tue, Apr 24, 9:48 AM · User-Daniel, Multi-Content-Revisions, Wikidata, MediaWiki-Platform-Team, MediaWiki-Page-deletion

Mon, Apr 23

daniel added a comment to T143842: Choose a color for linking article placeholders in place of redlinks.

I don't think the statement in T143842#4151062 is useful, or even correct. ;)

Mon, Apr 23, 7:02 PM · Design, WMDE-Design, ArticlePlaceholder, MediaWiki-extensions-WikibaseClient, Wikidata
daniel lowered the priority of T192189: RevisionArchiveRecord incorrectly changes null ar_len to 0 from High to Normal.

RevisionArchiveRecord bug is fixed, prio of the rest is not high.

Mon, Apr 23, 6:37 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Multi-Content-Revisions
daniel added a comment to T192384: PHPCS should not complain about @covers and @dataProvider being used in traits.

@thiemowmde ah, with "local" you mean per-repo, not local to my system.

Mon, Apr 23, 5:46 PM · MediaWiki-Codesniffer
daniel added a project to T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints): User-Daniel.
Mon, Apr 23, 1:20 PM · User-Daniel, Multi-Content-Revisions, Wikidata, MediaWiki-Platform-Team, MediaWiki-Page-deletion
daniel added a comment to T74430: Re-implement uniqueness constraint in a consistent and efficient way.

Note T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints)

Mon, Apr 23, 1:06 PM · User-Daniel, Wikidata, MediaWiki-extensions-WikibaseRepository
daniel created T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints).
Mon, Apr 23, 1:05 PM · User-Daniel, Multi-Content-Revisions, Wikidata, MediaWiki-Platform-Team, MediaWiki-Page-deletion

Sat, Apr 21

daniel added a comment to T192384: PHPCS should not complain about @covers and @dataProvider being used in traits.

@daniel: Please feel free to disable this part of the sniff in your local .phpcs.xml for now.

Sat, Apr 21, 12:10 PM · MediaWiki-Codesniffer

Fri, Apr 20

daniel added a comment to T120487: Cite : Share : Export (Consolidate and replace a variety of items on the sidebar).

This ties in with something I have been wanting for a long time for Wikidata: an easy way to discover the entity URI associated with a wikidata page, as well as different data URLs (see T161527). For example, on https://www.wikidata.org/wiki/Q64, I would want to be able to discover:

Fri, Apr 20, 11:57 AM · CiteThisPage, Community-Wishlist-Survey-2015
daniel added a project to T163922: Create a URL rewrite to handle the /data/ path for canonical URLs for machine readable page content: User-Daniel.
Fri, Apr 20, 11:54 AM · User-Daniel, Patch-For-Review, Wikimedia-Apache-configuration, Wikimedia-Site-requests
daniel awarded T120487: Cite : Share : Export (Consolidate and replace a variety of items on the sidebar) a Love token.
Fri, Apr 20, 11:41 AM · CiteThisPage, Community-Wishlist-Survey-2015

Thu, Apr 19

daniel added a comment to T192384: PHPCS should not complain about @covers and @dataProvider being used in traits.

@Umherirrender hm, I'd like to avoid using the "Test" suffix - it's not a runnable test case afterall. We use the "TestBase" or "TestCase" ending for abstract test classes for the same reason, and I have used the "Tester" suffix for helper classes that I wrote for the same purpose as the trait: asserting compliance with the contract of an interface, across implementations.

Thu, Apr 19, 6:59 PM · MediaWiki-Codesniffer
daniel updated the task description for T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.
Thu, Apr 19, 6:43 PM · Commons, Wikidata
daniel updated the task description for T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.
Thu, Apr 19, 6:43 PM · Commons, Wikidata
daniel updated the task description for T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.
Thu, Apr 19, 6:42 PM · Commons, Wikidata
daniel closed T174025: Implement MCR revision retrieval legacy version as Resolved.

It's done and deployed.

Thu, Apr 19, 6:29 PM · MediaWiki-Platform-Team, Patch-For-Review, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
daniel closed T174025: Implement MCR revision retrieval legacy version, a subtask of T174024: Implement MCR revision retrieval interface, as Resolved.
Thu, Apr 19, 6:29 PM · MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), Patch-For-Review, User-Addshore, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
daniel closed T174025: Implement MCR revision retrieval legacy version, a subtask of T174032: Make relevant API modules aware of MCR, as Resolved.
Thu, Apr 19, 6:29 PM · MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), Patch-For-Review, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
daniel added a comment to T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.

Oh! So, the problem description should be:

Thu, Apr 19, 6:22 PM · Commons, Wikidata
daniel closed T174039: Implement MCR page update legacy version as Invalid.

Folded into T174038: Implement MCR page update interface

Thu, Apr 19, 4:58 PM · MediaWiki-Platform-Team, Patch-For-Review, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
daniel closed T174039: Implement MCR page update legacy version, a subtask of T174038: Implement MCR page update interface, as Invalid.
Thu, Apr 19, 4:57 PM · Patch-For-Review, MediaWiki-Platform-Team, Multi-Content-Revisions, Structured-Data-Commons, Wikidata

Wed, Apr 18

daniel added a comment to T192249: Support for non-integer Wikidata IDs (or alternative).

Sounds like you are re-inventing what wikidata calls "constraints" - have a look at https://www.wikidata.org/wiki/Help:Property_constraints_portal

Wed, Apr 18, 7:11 PM · Wikidata
daniel added a comment to T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.

@Jarekt You can check which pages depend on which entity using Special:EntityUsage on the client wiki, e.g. https://commons.wikimedia.org/wiki/Special:EntityUsage/Q23.

Wed, Apr 18, 4:11 PM · Commons, Wikidata
daniel added a comment to T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.

@aaron My confusion is understanding the subtleties of the timestamp handling in RefreshLinksJob, and the interaction between HTMLCacheUpdateJob and RefreshLinksJob, and the ParserCache.

Wed, Apr 18, 2:57 PM · Commons, Wikidata
daniel added a comment to T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified.

A wikidata change triggers links updates as follows:

  • ChangeHandler::handleChange calls WikiPageUpdater::scheduleRefreshLinks
  • WikiPageUpdater::scheduleRefreshLinks schedules a RefreshLinksJob
  • RefreshLinksJob::runForTitle() then...
    • re-parses the page (hopefully - the interaction with the parser cache is somewhat complex. But since the page itself is getting re-rendered, this part seems to work)
    • calls WikitextContent::getSecondaryDataUpdates, which returns a LinksUpdate
    • calls LinksUpdate::doUpdate, which updates the database, including the categorylinks table
Wed, Apr 18, 2:55 PM · Commons, Wikidata
daniel triaged T192459: Allow SearchUpdate to process multiple slots as Normal priority.
Wed, Apr 18, 2:50 PM · Discovery-Search, Structured-Data-Commons, Wikidata, Multi-Content-Revisions

Tue, Apr 17

daniel created T192384: PHPCS should not complain about @covers and @dataProvider being used in traits.
Tue, Apr 17, 5:25 PM · MediaWiki-Codesniffer
daniel added a comment to T192189: RevisionArchiveRecord incorrectly changes null ar_len to 0.

Bumping to "high" for the RevisionArchiveRecord revision fix, to avoid incorrect revisions being created on undeletion.
Udpating and running populateRevisionLength probably doesn't have high prio.

Tue, Apr 17, 4:57 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Multi-Content-Revisions
daniel triaged T192189: RevisionArchiveRecord incorrectly changes null ar_len to 0 as High priority.
Tue, Apr 17, 4:54 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Multi-Content-Revisions
daniel added a comment to T192189: RevisionArchiveRecord incorrectly changes null ar_len to 0.

I'll fix RevisionArchiveRecord.

Tue, Apr 17, 3:59 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Multi-Content-Revisions
daniel added a comment to T192249: Support for non-integer Wikidata IDs (or alternative).

@Yurik now you lost me. "relgion" isn't a unique ID. And it should be editable. Why not use a regular statement? That's what we do on wikidata. But this seems to be entirely unrelated to this ticket.

Tue, Apr 17, 10:42 AM · Wikidata

Mon, Apr 16

daniel triaged T192307: Provide MCR-aware hook points as Normal priority.
Mon, Apr 16, 5:19 PM · Multi-Content-Revisions
daniel triaged T192306: Create MCR test wiki on WM Cloud as Normal priority.
Mon, Apr 16, 5:14 PM · Multi-Content-Revisions, Structured-Data-Commons, Wikidata
daniel added a comment to T192249: Support for non-integer Wikidata IDs (or alternative).

Oh, I just realized. You could fake this using a fake sitelink. On wikidata, an item's sitelinks points to articles in sister projects like wikipedia. It should not be hard to allow pages on non-mediawiki sites to be references in the same way - or even just pretend to reference a page. Sitelinks are unique, and can even be used to address items in the API.

Mon, Apr 16, 10:26 AM · Wikidata
daniel added a comment to T192249: Support for non-integer Wikidata IDs (or alternative).

A good example of how to add a custom entity type is https://www.mediawiki.org/wiki/Extension:WikibaseMediaInfo. The entry point for defining an entity type is the wiring file at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseMediaInfo/+/master/WikibaseMediaInfo.entitytypes.php. For creating entities of a new type, especially with extra requirements, a new API module should be implemented, similar to the one we introduced for Lexeme Forms: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseLexeme/+/master/src/Api/AddForm.php.

Mon, Apr 16, 10:24 AM · Wikidata
daniel added a comment to T192249: Support for non-integer Wikidata IDs (or alternative).

For a 3rd party site, it would not be terribly hard to implement a new entity type that extends the Item type to have an additional immutable string ID. This would be done by a custom extension on top of Wikibase. I don't think we'd deploy such a thin on Wikidata, though - we'd end up with hundreds of such custom types that only differ by a handful of fields, which with it's own slightly different logic.

Mon, Apr 16, 8:14 AM · Wikidata

Fri, Apr 13

daniel added a comment to T184446: Configure Toolforge replica views and dumps for the new MCR tables.

content.content_address doesn't have to be nulled. There will just be no mechanism on labs for resolving these addresses.

Fri, Apr 13, 11:30 PM · Patch-For-Review, Dumps-Generation, Data-Services, DBA, MediaWiki-Platform-Team

Wed, Apr 11

daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Wed, Apr 11, 9:16 PM · User-Daniel, TechCom-RFC
daniel moved T191925: Discuss use of Finite State Transducer based formalism for language variant implementations from Inbox to Radar on the TechCom board.
Wed, Apr 11, 8:32 PM · Services (watching), TechCom, Parsoid
daniel added a comment to T99899: [Story] Looking up entities by external identifiers.

Why is uniqueness even an issue? Just provide a way to search items by the value associated with a property. The result will be a ranked list, potentially incomplete if there are many matches. If the client just wants the "best" match, it should just use the top match.

Wed, Apr 11, 11:29 AM · Discovery-Search (Current work), Patch-For-Review, Wikibase-Lua, User-Smalyshev, Story, Wikidata

Tue, Apr 10

daniel added a comment to T183804: Citations from Wikidata generate errors on huWiki: "Invalid <ref> tag; name defined multiple times with different content".

I didn't look at the Lua code, but here is my guess based on what was written above:

Tue, Apr 10, 4:04 PM · Wikidata
daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

The "main" slot has always been somewhat special, for example it has to be present (even if empty) on every page.

Tue, Apr 10, 10:03 AM · User-Daniel, TechCom-RFC
daniel updated subscribers of T74430: Re-implement uniqueness constraint in a consistent and efficient way.
Tue, Apr 10, 9:50 AM · User-Daniel, Wikidata, MediaWiki-extensions-WikibaseRepository

Mon, Apr 9

daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

Anomie wants Content objects to know how to add "their" meta-data to a ParserOutput.

This is not incorrect. That would be done by the SlotHandler, not the Content object.

Mon, Apr 9, 11:45 AM · User-Daniel, TechCom-RFC

Sun, Apr 1

Kghbln awarded T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist a Heartbreak token.
Sun, Apr 1, 8:59 PM · Operations, Gerrit

Fri, Mar 30

daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Fri, Mar 30, 4:22 PM · User-Daniel, TechCom-RFC

Thu, Mar 29

daniel added a comment to T190178: DeferredUpdates should not silently ignore critical exceptions.

@Krinkle wrote:

Any "php error" (notice, warning, error) is turned into an exception by PHPUnit and fails the test.

Thu, Mar 29, 7:41 PM · Patch-For-Review, User-Daniel, MediaWiki-Logging, MediaWiki-Debug-Logger, Wikimedia-log-errors, MediaWiki-Platform-Team
daniel awarded T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions() a Like token.
Thu, Mar 29, 3:03 PM · User-Daniel, Wikidata, MediaWiki-extensions-WikibaseRepository
daniel added a comment to T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions().

While working on MCR, we really noticed that having Content-specific ParserOptions doesn't make much sense anywhere, and we want to remove that option. If I understand correctly, @Anomie is pointing out a better way to achieve what we wanted: splitting the parser cache on the user language.

Thu, Mar 29, 3:03 PM · User-Daniel, Wikidata, MediaWiki-extensions-WikibaseRepository
daniel added a project to T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions(): User-Daniel.
Thu, Mar 29, 3:01 PM · User-Daniel, Wikidata, MediaWiki-extensions-WikibaseRepository
daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Thu, Mar 29, 2:38 PM · User-Daniel, TechCom-RFC
daniel updated subscribers of T190063: Tracking dependencies for multiple Content objects per page (MCR).

Here's my attempt of the summary of yesterday's discussion, which featured @tstarling, @Tgr, @Anomie and myself:

Thu, Mar 29, 2:30 PM · User-Daniel, TechCom-RFC

Wed, Mar 28

daniel added a comment to T190813: Module for unit conversions.

@DePiep You can mention people, and you can quite them. You can't really "reply".

Wed, Mar 28, 10:02 PM · MediaWiki-extension-requests
daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

Note to self: look at @Tgr's comments on https://www.mediawiki.org/wiki/Topic:U8zvaqr5vxw5d1pw

Wed, Mar 28, 8:29 PM · User-Daniel, TechCom-RFC
daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Wed, Mar 28, 8:29 PM · User-Daniel, TechCom-RFC
daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

@Tgr You are right, we need fine grained per-slot tracking to enable efficient purging. We should keep this in mind. This RFC however is about what to do as long as we don't have that. What behavior do we aim for with the current db schema for tracking meta-data.

Wed, Mar 28, 8:05 PM · User-Daniel, TechCom-RFC
daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Wed, Mar 28, 7:58 PM · User-Daniel, TechCom-RFC
daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Wed, Mar 28, 7:27 PM · User-Daniel, TechCom-RFC
daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

the only way lack of tracking would happen would be if whoever wrote the "display it on the template page's default view" code screwed it up.

Wed, Mar 28, 7:21 PM · User-Daniel, TechCom-RFC
daniel updated the task description for T190063: Tracking dependencies for multiple Content objects per page (MCR).
Wed, Mar 28, 7:11 PM · User-Daniel, TechCom-RFC
daniel added a comment to T190813: Module for unit conversions.

I'd like to point out that Wikibase has code for unit conversion, along with conversion factors for several thousand units in the config. We currently only use this when exporting to RDF. It wouldn't be very hard to make this functionality available via Lua, though.

Wed, Mar 28, 11:13 AM · MediaWiki-extension-requests

Tue, Mar 27

daniel created P6903 ApiFlowEditHeaderTest fails.
Tue, Mar 27, 2:06 PM
daniel added a comment to T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.

@Ladsgroup I agree that it's a bug and should be fixed. But if I understand correctly, it's a bug in git.

Tue, Mar 27, 1:01 PM · Operations, Gerrit

Mar 26 2018

daniel added a comment to T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.

I feel like filing an upstream bug. "fatal: protocol error: bad pack header" is NOT a good way to say "the branch you are tracking no longer exists on the remote repo"...

Mar 26 2018, 1:04 PM · Operations, Gerrit
daniel added a comment to T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.

Ah, thank you!
Is this somehow a new thing? I wonder why I'm running into this for the first time now.

Mar 26 2018, 1:03 PM · Operations, Gerrit
Nikerabbit awarded T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist a Heartbreak token.
Mar 26 2018, 12:56 PM · Operations, Gerrit
daniel updated the task description for T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.
Mar 26 2018, 12:54 PM · Operations, Gerrit
daniel added a comment to T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.

A fresh clone seems to fix the problem. So no UBN.

Mar 26 2018, 12:53 PM · Operations, Gerrit
daniel added a comment to T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.

[14:49] <zhuyifei1999_> worked for me
[14:49] <zhuyifei1999_> https://www.irccloud.com/pastebin/U3V1obs5/

Mar 26 2018, 12:50 PM · Operations, Gerrit
daniel triaged T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist as High priority.

Bumping to high. May even be UBN. I'm trying a fresh clone now.

Mar 26 2018, 12:48 PM · Operations, Gerrit
daniel created T190676: git pull fails for MW core with "fatal: protocol error: bad pack header" when local branches point to remote branches that no more exist.
Mar 26 2018, 12:47 PM · Operations, Gerrit
daniel created P6897 git can't fetch core.
Mar 26 2018, 12:38 PM

Mar 23 2018

Liuxinyu970226 awarded T99899: [Story] Looking up entities by external identifiers a Like token.
Mar 23 2018, 1:35 PM · Discovery-Search (Current work), Patch-For-Review, Wikibase-Lua, User-Smalyshev, Story, Wikidata

Mar 22 2018

daniel added a project to T190178: DeferredUpdates should not silently ignore critical exceptions: User-Daniel.
Mar 22 2018, 11:12 AM · Patch-For-Review, User-Daniel, MediaWiki-Logging, MediaWiki-Debug-Logger, Wikimedia-log-errors, MediaWiki-Platform-Team

Mar 21 2018

daniel moved T111597: Devise means for experimental software working with live data from Inbox to Backlog on the TechCom board.
Mar 21 2018, 8:35 PM · TechCom, Services (watching), Availability
daniel added a comment to T166956: Cannot use Composer's CLI to manage a project's dependencies.

@dbarratt Creating such a wrapper project indeed does not need an RFC. Proposing the structure defined by that wrapper for new 3rd party installations, or for wmf deployments, or for the standard development environment - that would need an RFC.

Mar 21 2018, 7:49 PM · TechCom, Wikimedia-Hackathon-2018, MediaWiki-General-or-Unknown, Composer
daniel added a comment to T186915: Revision::ensureTitle: Could not determine title for page ID....

A stack trace would be helpful. What's the easiest way to get one these days?

Mar 21 2018, 7:34 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Wikimedia-log-errors

Mar 20 2018

daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

@Tgr You are right: tracking dependencies between resources needs to become more fine grained. That's the idea behind https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/DependencyEngine (which needs an update). The services team has an investigation of this in their anual plan. I don't think there's an empic for this on phabricator yet - perhaps I will add one.

Mar 20 2018, 5:05 PM · User-Daniel, TechCom-RFC
daniel awarded T190124: MediaWikiServices should not rely on globals a Love token.
Mar 20 2018, 4:45 PM · MediaWiki-Configuration
daniel added projects to T114662: RFC: Per-language URLs for multilingual wiki pages: RfC, TechCom-Has-shepherd.

@kchapman no resources. unlikely to move any time soon. the discussion and conclusions are still relevant. I suppose that means it can either sit in the backlog, or drop off the board. I'm fine with either.

Mar 20 2018, 4:34 PM · TechCom-Has-shepherd, RfC, User-Daniel, TechCom-RFC
daniel created T190178: DeferredUpdates should not silently ignore critical exceptions.
Mar 20 2018, 4:09 PM · Patch-For-Review, User-Daniel, MediaWiki-Logging, MediaWiki-Debug-Logger, Wikimedia-log-errors, MediaWiki-Platform-Team
daniel added a comment to T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin).

@Anomie, @aude: let's wait with re-creating the table until we need it, before running the populating script in phase I.

Mar 20 2018, 2:25 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel added a comment to T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin).

@Marostegui wrote:

Sure, I can drop the table in core (I will check to make sure it has no data) and you can take care of creating it again with the correct schema?

Mar 20 2018, 2:24 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel added a comment to T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin).

@jcrespo I had actually forgotten that we had already created these tables. But apparently you approved it: T183486#3883181

Mar 20 2018, 2:22 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel added a subtask for T183488: MCR schema migration stage 2: populate new fields: T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin).
Mar 20 2018, 2:18 PM · Patch-For-Review, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
daniel added a parent task for T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin): T183488: MCR schema migration stage 2: populate new fields.
Mar 20 2018, 2:18 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel added a comment to T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin).

@Marostegui If that's fine with you, that's fine with me.

Mar 20 2018, 2:16 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel placed T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin) up for grabs.
Mar 20 2018, 2:06 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel triaged T190153: DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin) as Normal priority.
Mar 20 2018, 2:05 PM · Blocked-on-schema-change, DBA, Multi-Content-Revisions, Wikidata, Structured-Data-Commons
daniel added a comment to T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?.

@WMDE-leszek

External stuff can be changed, on the cost of making breaking change. But doing changing in the storage is more painful, from the developer point of view.

Mar 20 2018, 1:52 PM · Lexicographical data, Wikidata

Mar 19 2018

daniel added a comment to T190063: Tracking dependencies for multiple Content objects per page (MCR).

Also IMO, there's no need for #2B;

Mar 19 2018, 9:08 PM · User-Daniel, TechCom-RFC