Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (402 w, 5 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Today

daniel added a subtask for T55784: [EPIC] Use Parsoid HTML for all page views: T311648: Make Parsoid usable via the ParserOutputAccess interface.
Wed, Jun 29, 4:21 PM · Parsoid-Rendering, Parsoid, Platform Team Legacy (Designing), MediaWiki-General, Product-Infrastructure-Team-Backlog, Services (designing), User-notice, Notice, Roadmap, Epic, VisualEditor-Performance, Blocked-on-Services, RESTBase, Service-Architecture, VisualEditor, MediaWiki-Interface
daniel added a parent task for T311648: Make Parsoid usable via the ParserOutputAccess interface: T55784: [EPIC] Use Parsoid HTML for all page views.
Wed, Jun 29, 4:21 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid (Tracking), VisualEditor
daniel created T311648: Make Parsoid usable via the ParserOutputAccess interface.
Wed, Jun 29, 4:20 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid (Tracking), VisualEditor
daniel added a project to T301371: Preemptively warm caches for Parsoid output: Platform Team Workboards (MW Expedition).
Wed, Jun 29, 4:17 PM · Platform Team Workboards (MW Expedition), Parsoid (Tracking), Patch-For-Review, VisualEditor, serviceops, Performance-Team (Radar), Platform Engineering Roadmap
daniel updated the task description for T311477: Remove pagebundle support from public transform endpoint.
Wed, Jun 29, 4:10 PM · Patch-For-Review, MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel triaged T311645: Split the TransformHandler class as Medium priority.
Wed, Jun 29, 4:09 PM · Parsoid-Nowiki, MediaWiki-REST-API, Platform Team Workboards (MW Expedition)
daniel created T311645: Split the TransformHandler class.
Wed, Jun 29, 4:09 PM · Parsoid-Nowiki, MediaWiki-REST-API, Platform Team Workboards (MW Expedition)
daniel updated the task description for T311477: Remove pagebundle support from public transform endpoint.
Wed, Jun 29, 3:54 PM · Patch-For-Review, MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel claimed T310476: Add rate limiting to Authority.
Wed, Jun 29, 11:00 AM · Platform Team Workboards (MW Expedition), User-Daniel, MediaWiki-User-management
daniel triaged T310476: Add rate limiting to Authority as Medium priority.
Wed, Jun 29, 11:00 AM · Platform Team Workboards (MW Expedition), User-Daniel, MediaWiki-User-management
daniel moved T277693: ForeignDBFile attempts to load users in the context of the wrong wiki from UserStore pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 29, 11:00 AM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
daniel moved T273284: Make RevisionRecord::getPageId() take a wiki ID from Waiting for release to PageStore pile on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 29, 10:59 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel moved T275531: Make RevisionRecord return a ProperPageIdentity from Blocked to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 29, 10:58 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)
daniel moved T273287: UserIdentityValue should require a Wiki ID to be passed to the constructor. from Blocked to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 29, 10:58 AM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel moved T275148: Prepare User group methods for hard deprecation from Blocked to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 29, 10:57 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Technical-Debt (Deprecation process), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)
daniel closed T234921: Factor group membership management out of User class as Resolved.
Wed, Jun 29, 10:57 AM · Platform Team Workboards (MW Expedition), MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), MediaWiki-User-management, Platform Team Initiatives (Decoupling (CDP2))
daniel closed T267990: Support stashing in page/html and revision/html endpoints in MW core, a subtask of T264669: Move VE API from RESTBase into core., as Resolved.
Wed, Jun 29, 10:57 AM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel closed T267990: Support stashing in page/html and revision/html endpoints in MW core as Resolved.
Wed, Jun 29, 10:57 AM · Performance-Team (Radar), Platform Team Workboards (MW Expedition), Patch-For-Review, MediaWiki-REST-API
daniel lowered the priority of T275772: Create an easy way to determine whether the wiki is private, and whether it is read only. from High to Low.
Wed, Jun 29, 10:57 AM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
daniel lowered the priority of T283265: Many Special pages that query user blocks make primary database connections on GET requests from High to Low.
Wed, Jun 29, 10:56 AM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Anti-Harassment (AHaT Sprint 9: The Beret), Sustainability (MediaWiki-MultiDC), Platform Team Workboards (MW Expedition), Performance-Team (Radar)
daniel triaged T292683: WikiPage::doUpdateRestrictions should become a page command as Low priority.
Wed, Jun 29, 10:56 AM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-General
daniel triaged T287343: Remove hooks from Title::get**URL methods as Low priority.
Wed, Jun 29, 10:56 AM · Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel triaged T281394: Hard-deprecate User::whoIs as Low priority.
Wed, Jun 29, 10:55 AM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel triaged T278458: Undeprecate NamespaceInfo::getRestrictionLevels as Low priority.
Wed, Jun 29, 10:55 AM · Patch-For-Review, Platform Team Workboards (MW Expedition)
daniel moved T310467: Remove implementation of the transform endpoint from the parsoid extension from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 29, 10:54 AM · Patch-For-Review, Parsoid, Platform Team Workboards (MW Expedition)
daniel closed T267991: Simple per-IP ratelimit for HTML stashing, a subtask of T267990: Support stashing in page/html and revision/html endpoints in MW core, as Resolved.
Wed, Jun 29, 10:54 AM · Performance-Team (Radar), Platform Team Workboards (MW Expedition), Patch-For-Review, MediaWiki-REST-API
daniel closed T267991: Simple per-IP ratelimit for HTML stashing as Resolved.
Wed, Jun 29, 10:54 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Platform Team Workboards (MW Expedition), MediaWiki-REST-API
daniel updated the task description for T310377: Make parsoid transformation API available internally.
Wed, Jun 29, 10:35 AM · Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor
daniel triaged T310464: Make use of stashed data-parsoid mapping in transform endpoint as High priority.
Wed, Jun 29, 10:31 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel triaged T310377: Make parsoid transformation API available internally as High priority.
Wed, Jun 29, 10:31 AM · Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor
daniel triaged T310376: Make VE Action API use Parsoid directly as Medium priority.
Wed, Jun 29, 10:31 AM · Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor
daniel triaged T310398: Move transform endpoint to a stable path as Medium priority.
Wed, Jun 29, 10:30 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor, Platform Engineering Roadmap
daniel triaged T301372: Core HTML REST API should follow redirects as Medium priority.
Wed, Jun 29, 10:30 AM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective, VisualEditor, Platform Engineering Roadmap
daniel triaged T310489: Collect statistics on stash read failures as Medium priority.
Wed, Jun 29, 10:29 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel added a project to T301372: Core HTML REST API should follow redirects: Epic.
Wed, Jun 29, 10:29 AM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective, VisualEditor, Platform Engineering Roadmap
daniel triaged T310904: Find out if Varnish is messing with ETags, and what to do about it. as Medium priority.
Wed, Jun 29, 10:28 AM · Parsoid (Tracking), SRE, Traffic, API Platform, Platform Team Workboards (MW Expedition), VisualEditor
daniel triaged T310878: Consolidate ParsoidHandler base class with ParsoidHTMLHelper as High priority.
Wed, Jun 29, 10:28 AM · Parsoid, Platform Team Workboards (MW Expedition), User-xSavitar
daniel triaged T311477: Remove pagebundle support from public transform endpoint as High priority.
Wed, Jun 29, 10:28 AM · Patch-For-Review, MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel triaged T293514: Unify ParserOutput::{get,set}{TitleText,DisplayTitle} as Low priority.
Wed, Jun 29, 10:20 AM · Platform Team Workboards (MW Expedition), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
daniel triaged T292865: Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid) as Low priority.
Wed, Jun 29, 10:20 AM · MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Platform Team Workboards (MW Expedition), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
daniel triaged T293513: Deprecate and remove ParserOutput::setTOCHTML() as Low priority.
Wed, Jun 29, 10:20 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Platform Team Workboards (MW Expedition), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid

Yesterday

daniel created T311527: Implement stampede protection for parsoid rendering.
Tue, Jun 28, 4:01 PM · Performance Issue, Platform Team Workboards (MW Expedition), Parsoid-Rendering
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Tue, Jun 28, 10:59 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Tue, Jun 28, 10:48 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel closed T310710: Do not ignore HTTP conditionals in transform REST endpoint., a subtask of T264669: Move VE API from RESTBase into core., as Resolved.
Tue, Jun 28, 10:45 AM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel closed T310710: Do not ignore HTTP conditionals in transform REST endpoint. as Resolved.

Further, we could have a "quirk" setting in the REST framework that allows weak etags to match in an If-Match header for specific endpoints.

Tue, Jun 28, 10:45 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel moved T291662: Actor ID is null when creating RCDatabaseLogEntry from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
Tue, Jun 28, 8:39 AM · Platform Team Workboards (MW Expedition)
daniel moved T293513: Deprecate and remove ParserOutput::setTOCHTML() from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Tue, Jun 28, 8:39 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Platform Team Workboards (MW Expedition), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
daniel moved T292865: Plumb revision information from ParserOptions through to ParserOutput (bypassing Parsoid) from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Tue, Jun 28, 8:39 AM · MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Platform Team Workboards (MW Expedition), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
daniel moved T293514: Unify ParserOutput::{get,set}{TitleText,DisplayTitle} from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Tue, Jun 28, 8:38 AM · Platform Team Workboards (MW Expedition), Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
daniel moved T311477: Remove pagebundle support from public transform endpoint from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Tue, Jun 28, 8:38 AM · Patch-For-Review, MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel created T311477: Remove pagebundle support from public transform endpoint.
Tue, Jun 28, 8:09 AM · Patch-For-Review, MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor

Mon, Jun 27

daniel added a comment to T92465: Fully wrap all time operations in interface.

Similar task: T203481: Use a mock clock in unit tests

Mon, Jun 27, 1:32 PM · Growth-Team-Filtering, Growth-Team, StructuredDiscussions

Wed, Jun 22

daniel claimed T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 22, 8:41 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel moved T310904: Find out if Varnish is messing with ETags, and what to do about it. from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 22, 8:37 AM · Parsoid (Tracking), SRE, Traffic, API Platform, Platform Team Workboards (MW Expedition), VisualEditor

Tue, Jun 21

daniel closed T175146: [RfC] Move RunSingleJob.php to the mediawiki (core) repository as Resolved.

RunJobs.php has been deleted

Tue, Jun 21, 3:56 PM · Platform Team Workboards (Initiatives), Patch-For-Review, WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
daniel closed T175146: [RfC] Move RunSingleJob.php to the mediawiki (core) repository, a subtask of T157088: [EPIC] Develop a JobQueue backend based on EventBus, as Resolved.
Tue, Jun 21, 3:56 PM · Data-Engineering, Analytics-Radar, WMF-JobQueue, Platform Team Workboards (Done with CPT), Services (done), MediaWiki-Core-JobQueue, Epic, User-mobrovac, ChangeProp, Event-Platform
daniel moved T309016: Determine storage requirements for stashing parsoid output for VE edits from VE Backend pile to Doing on the Platform Team Workboards (MW Expedition) board.
Tue, Jun 21, 10:21 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Platform Team Workboards (MW Expedition), MediaWiki-REST-API

Fri, Jun 17

daniel updated subscribers of T310904: Find out if Varnish is messing with ETags, and what to do about it..

Pinging @BBlack and @Vgutierrez in the hope they can shed some light...

Fri, Jun 17, 4:21 PM · Parsoid (Tracking), SRE, Traffic, API Platform, Platform Team Workboards (MW Expedition), VisualEditor
daniel created T310904: Find out if Varnish is messing with ETags, and what to do about it..
Fri, Jun 17, 4:20 PM · Parsoid (Tracking), SRE, Traffic, API Platform, Platform Team Workboards (MW Expedition), VisualEditor
daniel added a comment to T128525: Strip old metadata from old Parsoid content <head>: mw:TimeUuid, user, comment.

There's been 700 cases when the If-Match was not supplied over the last month and only 2 user agents:

  1. https://en.wikipedia.org/wiki/User:Jackmcbarn/editProtectedHelper - a user script. I will reach out to the maintainer
  2. And, surprisingly, still VE https://logstash.wikimedia.org/goto/4b751b3fbf5de1044bd4255c693fc724
Fri, Jun 17, 1:48 PM · Platform Team Legacy (Later), User-Clarakosi, good first task, Services (next), RESTBase
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Fri, Jun 17, 1:43 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel updated the task description for T310464: Make use of stashed data-parsoid mapping in transform endpoint.
Fri, Jun 17, 1:37 PM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel updated the task description for T310464: Make use of stashed data-parsoid mapping in transform endpoint.
Fri, Jun 17, 1:37 PM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel moved T310878: Consolidate ParsoidHandler base class with ParsoidHTMLHelper from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Fri, Jun 17, 11:44 AM · Parsoid, Platform Team Workboards (MW Expedition), User-xSavitar
daniel created T310878: Consolidate ParsoidHandler base class with ParsoidHTMLHelper.
Fri, Jun 17, 11:44 AM · Parsoid, Platform Team Workboards (MW Expedition), User-xSavitar
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Fri, Jun 17, 9:45 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Fri, Jun 17, 9:41 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Fri, Jun 17, 9:32 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel added a comment to T310710: Do not ignore HTTP conditionals in transform REST endpoint..

So let me see if I'm getting this right: VE gets HTML via Varnish and RESTbase. It's getting an ETag generated by RESTbase, and "weakened" by Varnish.

Fri, Jun 17, 9:17 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor

Thu, Jun 16

daniel updated subscribers of T310710: Do not ignore HTTP conditionals in transform REST endpoint..

On Slack, @Arlolra pointed out that it may be Varnish adding the W/ prefix to "weaken" the etag. Per the varnish docs, this might indeed be the case: https://varnish-cache.org/docs/6.0/users-guide/compression.html

Thu, Jun 16, 6:19 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel added a comment to T310710: Do not ignore HTTP conditionals in transform REST endpoint..

The issue originates in I5edfa8aa54dedaec418579bbef37aa040170d09b, which sais: ETag harmonisation Add custom weak ETag to page requests in the format used by RESTBase.

Thu, Jun 16, 9:37 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel added a comment to T238849: Post switchover to Parsoid/PHP on private wikis, VE edit saves on officewiki responded with a HTTP 412.

The issue originates in I5edfa8aa54dedaec418579bbef37aa040170d09b, which sais: ETag harmonisation Add custom weak ETag to page requests in the format used by RESTBase.

Thu, Jun 16, 9:36 AM · User-Ryasmeen, Parsoid-PHP, VisualEditor

Wed, Jun 15

daniel moved T301372: Core HTML REST API should follow redirects from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 15, 6:57 PM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective, VisualEditor, Platform Engineering Roadmap
daniel moved T310489: Collect statistics on stash read failures from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 15, 6:57 PM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel moved T310476: Add rate limiting to Authority from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 15, 6:57 PM · Platform Team Workboards (MW Expedition), User-Daniel, MediaWiki-User-management
daniel moved T308588: Do not cache fast parsoid output in ParserCache (exploration) from VE Backend pile to Doing on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 15, 6:57 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Editing-team (Tracking), Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel moved T310710: Do not ignore HTTP conditionals in transform REST endpoint. from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Wed, Jun 15, 6:56 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel renamed T310710: Do not ignore HTTP conditionals in transform REST endpoint. from Visual Editor should send strong eTags in If-Match headers to Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 15, 5:47 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel added a comment to T303370: Parsoid should implement getETag().

The RESTBase stashing mechanism also allows *lookup* by TID if i understand correctly, since you might have multiple parses of the same title/revision but at different timestamps. Maybe that's not actually required, and just keeping a single "latest parse" is sufficient. But if you wanted to lookup by TID you'd need to add it to ParserOptions as well, since that is used as the key for the <ParserOptions,ParserOutput> datastore implemented by ParserCache. (You'd might also want to tweak the cache lifetime mechanisms.)

Wed, Jun 15, 5:09 PM · Parsoid
daniel added a comment to T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 15, 3:31 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel added a comment to T303370: Parsoid should implement getETag().

But, once Parsoid is integrated into core and with ParserCache, and when HTML stashing is implemented for VE (similar to how it is done in RESTBase), the etag will come from this stashed entry.

Wed, Jun 15, 3:00 PM · Parsoid
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 15, 2:53 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 15, 2:38 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel placed T310710: Do not ignore HTTP conditionals in transform REST endpoint. up for grabs.
Wed, Jun 15, 2:33 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel updated the task description for T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 15, 2:17 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor
daniel created T310710: Do not ignore HTTP conditionals in transform REST endpoint..
Wed, Jun 15, 2:16 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Patch-For-Review, Platform Team Workboards (MW Expedition), Parsoid, API Platform, VisualEditor

Mon, Jun 13

daniel created T310489: Collect statistics on stash read failures.
Mon, Jun 13, 11:49 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel created T310476: Add rate limiting to Authority.
Mon, Jun 13, 9:40 AM · Platform Team Workboards (MW Expedition), User-Daniel, MediaWiki-User-management
daniel updated the task description for T310464: Make use of stashed data-parsoid mapping in transform endpoint.
Mon, Jun 13, 8:03 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel updated the task description for T310464: Make use of stashed data-parsoid mapping in transform endpoint.
Mon, Jun 13, 8:01 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel updated the task description for T301370: Move transform endpoints from RESTBase to MediaWiki.
Mon, Jun 13, 8:01 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor, Platform Engineering Roadmap
daniel updated the task description for T310464: Make use of stashed data-parsoid mapping in transform endpoint.
Mon, Jun 13, 8:00 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel raised the priority of T301370: Move transform endpoints from RESTBase to MediaWiki from Medium to High.
Mon, Jun 13, 7:59 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor, Platform Engineering Roadmap
daniel updated the task description for T310464: Make use of stashed data-parsoid mapping in transform endpoint.
Mon, Jun 13, 7:59 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor
daniel triaged T310467: Remove implementation of the transform endpoint from the parsoid extension as High priority.
Mon, Jun 13, 7:58 AM · Patch-For-Review, Parsoid, Platform Team Workboards (MW Expedition)
daniel moved T310467: Remove implementation of the transform endpoint from the parsoid extension from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Mon, Jun 13, 7:58 AM · Patch-For-Review, Parsoid, Platform Team Workboards (MW Expedition)
daniel created T310467: Remove implementation of the transform endpoint from the parsoid extension.
Mon, Jun 13, 7:58 AM · Patch-For-Review, Parsoid, Platform Team Workboards (MW Expedition)
daniel moved T310398: Move transform endpoint to a stable path from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Mon, Jun 13, 7:49 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor, Platform Engineering Roadmap
daniel moved T310464: Make use of stashed data-parsoid mapping in transform endpoint from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.
Mon, Jun 13, 7:49 AM · MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor