daniel (Daniel Kinzler)
User

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (213 w, 6 d)
Availability
Available
IRC Nick
DanielK_WMDE
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Yesterday

daniel added a comment to T205369: Investigate > 40% Save Timing regression (2018-09-05).

Since CategoryMembershipChangeJob runs via the job queue, wouldn't that have little effect on save timing itself? I guess it wouldn't hurt to optimize.

Wed, Nov 14, 11:03 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Performance-Team
daniel moved T208188: Proposal for partial opt-out method for Content security policy from Request IRC meeting to Under discussion on the TechCom-RFC board.

Looks like I put this under "request IRC meeting" by mistake last week. @Bawolff, do you think this would benefit from a public IRC meeting soon?

Wed, Nov 14, 9:42 PM · TechCom-RFC, TechCom, Security-Team, Security
daniel closed T208487: [RfC] Add CURRENT_TIMESTAMP support for `wl_notificationtimestamps` in watchlist table as Declined.

Retracted per @D3r1ck01's comment.

Wed, Nov 14, 9:33 PM · User-D3r1ck01, TechCom-RFC, Growth-Team, MediaWiki-Database
daniel added a comment to T208769: Ensure that AbuseFilter applies to the content of all MCR slots.

But that would mean every wiki needs to manually update each of their filters each time a new slot rolls out, even if it's the same content type as before – e.g. if we add a documentation wikitext slot to templates. Letting filter authors match against content_model generically would be more powerful and involve less work for them…

Wed, Nov 14, 8:26 PM · Core Platform Team Kanban, AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering
daniel added a comment to T208769: Ensure that AbuseFilter applies to the content of all MCR slots.

I suggest to use variable suffixes instead of arrays. old_content_model_main, old_content_model_mediainfo, etc. Not a great example, but I suppose you see what I mean.

Wed, Nov 14, 8:00 PM · Core Platform Team Kanban, AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering
daniel added a comment to T205369: Investigate > 40% Save Timing regression (2018-09-05).

Another thing I found: SpamBlacklist causes a re-parse on every edit. Reason:

Wed, Nov 14, 6:32 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Performance-Team

Tue, Nov 13

daniel added a comment to T205369: Investigate > 40% Save Timing regression (2018-09-05).

Another note: it seems like the

$this->revision->getUser( RevisionRecord::RAW )->getName() !== $user->getName()

check works correctly for null edits.

Tue, Nov 13, 6:24 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Performance-Team
daniel added a comment to T205369: Investigate > 40% Save Timing regression (2018-09-05).

Another outcome of this analysis: SpamBlacklist causes a re-parse on every edit. Reason:

Tue, Nov 13, 6:13 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Performance-Team
daniel added a comment to T205369: Investigate > 40% Save Timing regression (2018-09-05).

The first thing I just found looking into this is this bit in CategoryMembershipChangeJob:

Tue, Nov 13, 5:40 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Performance-Team
daniel added a comment to T208524: RfC: Standards for external services that integrate with MediaWiki.

@Joe I think it would be excellent if you could take this on, thank you!

Tue, Nov 13, 4:49 PM · TechCom, TechCom-RFC
daniel added a comment to T209031: Not able to scoop comment table in labs for mediawiki reconstruction process.

@daniel : We were using sanitized comment view (named comment), not the compat one (named revision_compat).

Tue, Nov 13, 1:53 PM · Analytics-Kanban, DBA, Data-Services, Analytics
daniel added a comment to T209031: Not able to scoop comment table in labs for mediawiki reconstruction process.

In any case, I'm wondering: doen't labs also offer a sanitized view of the new schema? That should be a lot more efficient than the compat views.

That's what they're talking about, the sanitised views in labs.

Tue, Nov 13, 12:09 PM · Analytics-Kanban, DBA, Data-Services, Analytics
daniel added a comment to T209031: Not able to scoop comment table in labs for mediawiki reconstruction process.

@Krenair: we are looking how to best import the public dataset from labs, we have already looked into scooping data from the non public data hosts and the sanitization is a lot harder than you might (by no means as simple as "runing your own views") so we need to come up with a strategy for us to scoop data from labs efficiently. Let's keep this ticket about the ways we can make the scooping task easier.

Tue, Nov 13, 9:33 AM · Analytics-Kanban, DBA, Data-Services, Analytics

Mon, Nov 12

daniel edited projects for T209291: Make AbuseFilter::revisionToString work across slots, added: Core Platform Team Kanban (Waiting for Review); removed Core Platform Team Kanban.
Mon, Nov 12, 4:08 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering
daniel triaged T209291: Make AbuseFilter::revisionToString work across slots as High priority.
Mon, Nov 12, 3:28 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering

Sun, Nov 11

Liuxinyu970226 awarded T3392: "What links here" should show only the template linking, not all pages containing the template. Same for "pages that use this image". a Like token.
Sun, Nov 11, 8:24 AM · MediaWiki-Special-pages
Liuxinyu970226 awarded T77978: [Story] Support unit conversion a Like token.
Sun, Nov 11, 7:00 AM · Story, Wikidata, MediaWiki-extensions-WikibaseRepository
Liuxinyu970226 awarded T38902: Refactor DifferenceEngine et.al. to make parts reusable a Like token.
Sun, Nov 11, 6:53 AM · Librarization, Technical-Debt, MediaWiki-History-or-Diffs

Fri, Nov 9

daniel added a comment to T208487: [RfC] Add CURRENT_TIMESTAMP support for `wl_notificationtimestamps` in watchlist table.

For wl_notificationtimestamp, we set it to NULL when the user views the latest revision of the page, and when the page is edited we set all non-NULL entries to the time of the edit. This allows us to trivially find all watchlist entries where the page has/hasn't been edited since the last view: "has been edited" has wl_notificationtimestamp IS NOT NULL, while "hasn't been edited" has wl_notificationtimestamp IS NULL.

Fri, Nov 9, 2:23 PM · User-D3r1ck01, TechCom-RFC, Growth-Team, MediaWiki-Database
daniel added a comment to T190066: Expose all slots to the search interface.

@Cparle this ticket here *is* about making sure all slots are passed to cirrus. Cirrus should then also pass them on via its own hooks. Changing a hook signature isn't trivial though, it's generally better to introduce a new hook.

Fri, Nov 9, 12:39 PM · Patch-For-Review, SDC Engineering, Multi-Content-Revisions, Discovery, CirrusSearch, Discovery-Search, Wikidata
daniel added a comment to rEWBI2a0610b8a2d0: Use the CirrusSearchBuildDocumentParse hook.

Oh, this is in MediaInfo. I suppose there is no way to do better here, then. But Cirrus should needs a better hook.

Fri, Nov 9, 12:31 PM
daniel added a comment to T190066: Expose all slots to the search interface.

Update: We switched to CirrusSearchBuildDocumentParse in 2a0610b8a2d05d872878da292117f140520f5098.

Fri, Nov 9, 12:29 PM · Patch-For-Review, SDC Engineering, Multi-Content-Revisions, Discovery, CirrusSearch, Discovery-Search, Wikidata
daniel added inline comments to rEWBI2a0610b8a2d0: Use the CirrusSearchBuildDocumentParse hook.
Fri, Nov 9, 12:28 PM
daniel added a comment to T208487: [RfC] Add CURRENT_TIMESTAMP support for `wl_notificationtimestamps` in watchlist table.

@aaron if I understand correctly, the intention is not to permanently record when the page was watched. The intention is instead to initialize the "last viewed" timestamp to the time the page was watched. This makes sense semantically: Assuming a page that is added to the watchlist was never viewed makes little sense. Asssuming that the user was looking at that page when they added it to the watchlist makes a lot more sense. With respecct to the functionality controlled by wl_notificationtimestamp this should make no difference: either way, no notifications will be shown for the time prior to the point at which the page was added to the watchlist.

Fri, Nov 9, 12:25 PM · User-D3r1ck01, TechCom-RFC, Growth-Team, MediaWiki-Database
daniel added a comment to T208524: RfC: Standards for external services that integrate with MediaWiki.

@Imarlier you wrote this RFC as the outcome of a session that you took on at the last minute. I suppose it's not fair to expect you to go through with getting this RFC through the process. Reaching consensus on this is not going to be quick or easy. Are you interested in (and have capacity to) take this on? If not, we should designate someone else to drive this.

Fri, Nov 9, 12:12 PM · TechCom, TechCom-RFC

Thu, Nov 8

daniel updated subscribers of T208188: Proposal for partial opt-out method for Content security policy.
Thu, Nov 8, 2:47 PM · TechCom-RFC, TechCom, Security-Team, Security
daniel moved T208487: [RfC] Add CURRENT_TIMESTAMP support for `wl_notificationtimestamps` in watchlist table from Inbox to Backlog on the TechCom-RFC board.

Moving this to the backlog of the RFC board, indicating that this ticket needs to be fleshed out more to make it a viable RFC.

Thu, Nov 8, 1:06 PM · User-D3r1ck01, TechCom-RFC, Growth-Team, MediaWiki-Database
daniel renamed T208766: Deprecate User::isWatched, addWatch, and removeWatch from Create a WatchlistManager service to Deprecate User::isWatched, addWatch, and removeWatch.
Thu, Nov 8, 12:57 PM · Core Platform Team Backlog (Later), Growth-Team, MediaWiki-Watchlist, Core Platform Team ( Code Health (TEC13))
daniel added a comment to T208766: Deprecate User::isWatched, addWatch, and removeWatch.

Since WatchedItemStore already exists, re-purposing this ticket to just call for isWatched, addWatch and removeWatch to be deprecated.

Thu, Nov 8, 12:54 PM · Core Platform Team Backlog (Later), Growth-Team, MediaWiki-Watchlist, Core Platform Team ( Code Health (TEC13))
daniel added a comment to T206070: Wikimedia Technical Conference 2018 Session - Mapping our data and content pipeline.

Relevant document: https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture

Thu, Nov 8, 12:04 PM · Wikimedia-Technical-Conference-2018
Addshore awarded T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs. a Goat token.
Thu, Nov 8, 11:58 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel updated the task description for T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs..
Thu, Nov 8, 11:51 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel updated the task description for T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs..
Thu, Nov 8, 11:50 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel updated the task description for T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs..
Thu, Nov 8, 11:49 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel updated subscribers of T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs..

Pinging some folks who have in the past expressed interest in this idea: @Fjalapeno @WMDE-leszek @Halfak.

Thu, Nov 8, 11:48 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel added a parent task for T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs.: T107595: [RFC] Multi-Content Revisions.
Thu, Nov 8, 11:46 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel added a subtask for T107595: [RFC] Multi-Content Revisions: T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs..
Thu, Nov 8, 11:46 AM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Epic), Epic, User-Daniel, Wikidata-Sprint-2015-11-17, Wikimedia-Developer-Summit-2016, Wikidata, Wikidata-Sprint-2015-09-15, TechCom-RFC
daniel triaged T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs. as Low priority.
Thu, Nov 8, 11:45 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel created T209044: Introduce a ContentStore service to allow certain types of content to not be stored as serialized blobs..
Thu, Nov 8, 11:45 AM · Multi-Content-Revisions (New Features), Core Platform Team Backlog (Next), Core Platform Team (MCR)
daniel added a comment to T208524: RfC: Standards for external services that integrate with MediaWiki.

@Joe the only distinction I see there is "stuff we write" vs "stuff we don't write", really.

Thu, Nov 8, 11:28 AM · TechCom, TechCom-RFC
daniel added a comment to T208524: RfC: Standards for external services that integrate with MediaWiki.

Reading through the session notes and this proposal, several aspects come to mind that I believe would be worth mentioning. I'll try to give a quick brain dump:

  • Distinction between public services (that clients use instead of or in addition of mediawiki), and internal services (that are used by mediawiki).
  • Distinction between stateless and stateful services. MediaWiki uses several external services to maintain state (MySQL, memcached, redis, etc).
  • Distinction between long-running tasks (transcoding), async notifications (event logging), and tasks to be performed synchronously during a request "while the user waits" (like the proposed new session storage service).
  • Per the above, stateless services that perform synchronous in-request tasks tend to be pointless. The same functionality can generally be implemented inline, in core or as an extension, without the communication and operational overhead of a standalone service.
  • Discussion of whether HTTP is the preferred method of communication between services (probably yes, at least for synchronous calls)
  • The "chattyness with the API" criterion also works the other way around: if MediaWiki would have to talk to the service a lot, that's an indicator that the functionality should probablly not be in a separate process.
  • Having the need to be synchronous as a counter-indicator doesn't seem useful. Several prime candidates for external services would need synchronous call semantics, e.g. an authentication service.
  • Functionality invoked via shell-out or implemented by forking should be treated separately, as it has very different characteristics.
  • The statement that it's "very likely" that an extension would be used for integration is misleading, as it implies that functionality that is presently in core should not be factored out into an external service. But factoring core functionality out into external services should indeed be considered, especially for security relevant functionality.
  • Anything that needs to function in a shared hosting environment (LAMP) can't be an external service (or needs to have an alternative PHP implementation)
  • Anything that needs to parse wikitext or need access to MediaWiki i18n messages (which are wikitext) should probably not be an external service.
Thu, Nov 8, 8:50 AM · TechCom, TechCom-RFC
daniel added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Storage note: may need/want to include a reverse-domain copy of the domain for indexing purposes for bulk lookups.

Thu, Nov 8, 7:49 AM · TechCom-RFC, TechCom, Security-Team, Security
daniel moved T208188: Proposal for partial opt-out method for Content security policy from Inbox to Request IRC meeting on the TechCom-RFC board.
Thu, Nov 8, 7:46 AM · TechCom-RFC, TechCom, Security-Team, Security
daniel moved T208188: Proposal for partial opt-out method for Content security policy from Inbox to Radar on the TechCom board.

Accepted as an RFC per today's TechCom meeting. This is considered as "under discussion" for now. When the discussion has settled down, move this to the "request IRC meeting" on the TechCom board (or to thhe inbox column for review).

Thu, Nov 8, 7:45 AM · TechCom-RFC, TechCom, Security-Team, Security
daniel moved T208524: RfC: Standards for external services that integrate with MediaWiki from Inbox to Under discussion on the TechCom-RFC board.
Thu, Nov 8, 6:43 AM · TechCom, TechCom-RFC
daniel assigned T208487: [RfC] Add CURRENT_TIMESTAMP support for `wl_notificationtimestamps` in watchlist table to aaron.
Thu, Nov 8, 6:37 AM · User-D3r1ck01, TechCom-RFC, Growth-Team, MediaWiki-Database
daniel moved T208472: Block::getTarget() can return a User object or a string that is an invalid user name from Inbox to Radar on the TechCom board.
Thu, Nov 8, 6:14 AM · TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management
daniel added a project to T208472: Block::getTarget() can return a User object or a string that is an invalid user name: TechCom.
Thu, Nov 8, 6:14 AM · TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management

Wed, Nov 7

daniel closed T206065: Wikimedia Technical Conference 2018 Session - Applying the MediaWiki Platform Architecture Principles as Resolved.

Closing task.

Wed, Nov 7, 6:49 PM · Wikimedia-Technical-Conference-2018
daniel updated the task description for T206065: Wikimedia Technical Conference 2018 Session - Applying the MediaWiki Platform Architecture Principles.
Wed, Nov 7, 6:48 PM · Wikimedia-Technical-Conference-2018
daniel added a comment to T208926: PHP Fatal from ApiMain.php: Header may not contain more than a single header, new line detected.

As far as I can tell, this is an error raised while handling another error (a ApiUsageException). Something somewhere is writing something that contains a newline (a stack trace, perhaps) into the field that is supposed to contain an error code.

Wed, Nov 7, 1:43 PM · Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Reading-Infrastructure-Team-Backlog, Reading List Service, MediaWiki-API, Wikimedia-production-error
daniel added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.

That's almost as bad as Wil's idea. That would produce a triangular distribution, like throwing two dice and adding the results. https://en.wikipedia.org/wiki/Irwin%E2%80%93Hall_distribution

Wed, Nov 7, 1:29 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
daniel added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.

wfRandom currently uses:

Wed, Nov 7, 8:56 AM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown

Tue, Nov 6

daniel added a comment to T206084: Wikimedia Technical Conference 2018 Session - Architecting core: concepts.

Quite a few "features" discussed in T206075: Wikimedia Technical Conference 2018 Session - Building MediaWiki to Support Collaboration align with "missing" concepts.

Tue, Nov 6, 4:53 PM · Wikimedia-Technical-Conference-2018
Jdforrester-WMF awarded T208767: Ensure that SpamBlacklist applies to the content of all MCR slots a Party Time token.
Tue, Nov 6, 4:38 PM · Core Platform Team Kanban (Done with CPT), SpamBlacklist, Core Platform Team (MCR), SDC Engineering
daniel closed T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries as Resolved.

Session done, tickets filed.

Tue, Nov 6, 2:07 PM · Wikimedia-Technical-Conference-2018
daniel updated the task description for T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.
Tue, Nov 6, 2:07 PM · Wikimedia-Technical-Conference-2018
daniel removed a parent task for T207977: remove prev/next message dependency from Language: T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.
Tue, Nov 6, 1:58 PM · MediaWiki-Decoupling, MediaWiki-Internationalization, Patch-For-Review
daniel removed a subtask for T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries: T207977: remove prev/next message dependency from Language.
Tue, Nov 6, 1:58 PM · Wikimedia-Technical-Conference-2018
daniel removed a parent task for T208764: Remove circular dependency between Title and User classes: T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.
Tue, Nov 6, 1:58 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team ( Code Health (TEC13))
daniel removed a subtask for T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries: T208764: Remove circular dependency between Title and User classes.
Tue, Nov 6, 1:58 PM · Wikimedia-Technical-Conference-2018
daniel removed a parent task for T208786: Untangle MediaHandler, FileRepo, File, Title and Linker.: T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.
Tue, Nov 6, 1:57 PM · MediaWiki-Decoupling, MediaWiki-File-management, Core Platform Team ( Code Health (TEC13)), Multimedia, Commons
daniel removed a subtask for T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries: T208786: Untangle MediaHandler, FileRepo, File, Title and Linker..
Tue, Nov 6, 1:57 PM · Wikimedia-Technical-Conference-2018
daniel added a project to T208786: Untangle MediaHandler, FileRepo, File, Title and Linker.: MediaWiki-Decoupling.
Tue, Nov 6, 1:57 PM · MediaWiki-Decoupling, MediaWiki-File-management, Core Platform Team ( Code Health (TEC13)), Multimedia, Commons
daniel added a project to T208764: Remove circular dependency between Title and User classes: MediaWiki-Decoupling.
Tue, Nov 6, 1:57 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team ( Code Health (TEC13))
daniel added a project to T207977: remove prev/next message dependency from Language: MediaWiki-Decoupling.
Tue, Nov 6, 1:57 PM · MediaWiki-Decoupling, MediaWiki-Internationalization, Patch-For-Review
daniel added hashtags to MediaWiki-Decoupling: #mw-modularize, #mw-decouple.
Tue, Nov 6, 1:55 PM
daniel added a member for MediaWiki-Decoupling: CCicalese_WMF.
Tue, Nov 6, 1:54 PM
daniel removed a watcher for MediaWiki-Decoupling: daniel.
Tue, Nov 6, 1:54 PM
daniel added a member for MediaWiki-Decoupling: daniel.
Tue, Nov 6, 1:54 PM
daniel added a watcher for MediaWiki-Decoupling: daniel.
Tue, Nov 6, 1:53 PM
daniel removed projects from T208786: Untangle MediaHandler, FileRepo, File, Title and Linker.: Core Platform Team Backlog, Wikimedia-Technical-Conference-2018.
Tue, Nov 6, 1:52 PM · MediaWiki-Decoupling, MediaWiki-File-management, Core Platform Team ( Code Health (TEC13)), Multimedia, Commons
daniel closed T208767: Ensure that SpamBlacklist applies to the content of all MCR slots as Resolved.

Analysis: SpamBlacklists uses the EditFilterMergedContent hook, to which it binds the handle function SpamBlacklistHooks::filterMergedContent.
In that method, it calls WikiPage::prepareContentForEdit which returns an EditInfo instances with a ParserOutput object in the $output field. This object comes from DerivedPageDataUpdater::getPreparedEdit, which sets the $output field to the combined ParserOutput for all slots as returned by getCanonicalParserOutput(). SpamBlacklistHooks::filterMergedContent() then calls getExternalLinks() on that ParserOutput, and applies the blacklist filter to it.

Tue, Nov 6, 1:43 PM · Core Platform Team Kanban (Done with CPT), SpamBlacklist, Core Platform Team (MCR), SDC Engineering
daniel closed T208767: Ensure that SpamBlacklist applies to the content of all MCR slots, a subtask of T189220: Ensure that relevant extensions are MCR-aware, as Resolved.
Tue, Nov 6, 1:42 PM · Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), Core Platform Team Backlog (Epic), Epic, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23))
daniel closed T208767: Ensure that SpamBlacklist applies to the content of all MCR slots, a subtask of T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo, as Resolved.
Tue, Nov 6, 1:42 PM · SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata, SDC General
daniel updated the task description for T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo.
Tue, Nov 6, 1:11 PM · SDC Engineering, MediaWiki-extensions-WikibaseMediaInfo, Wikidata, SDC General

Mon, Nov 5

daniel added a comment to T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.

I created several tasks for implementing the things that were discussed during the session. They currently hang off the session as sub-tasks, but that doesn't make sense semantically (they don't block the session, the session is done). As soon as the new tag proposed in T207976: Create "MediaWiki-Decoupling" phabricator project exists, they should be tagged accordingly, and this ticket should be closed.

Mon, Nov 5, 8:50 PM · Wikimedia-Technical-Conference-2018
daniel created T208786: Untangle MediaHandler, FileRepo, File, Title and Linker..
Mon, Nov 5, 8:48 PM · MediaWiki-Decoupling, MediaWiki-File-management, Core Platform Team ( Code Health (TEC13)), Multimedia, Commons
daniel added a parent task for T208776: Introduce PageIdentity to be used instead of Title: T195069: Factor PageStore and PageRecord out of WikiPage.
Mon, Nov 5, 8:06 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel added a subtask for T195069: Factor PageStore and PageRecord out of WikiPage: T208776: Introduce PageIdentity to be used instead of Title.
Mon, Nov 5, 8:06 PM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Later)
daniel added a parent task for T208776: Introduce PageIdentity to be used instead of Title: T208766: Deprecate User::isWatched, addWatch, and removeWatch.
Mon, Nov 5, 8:06 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel added a subtask for T208766: Deprecate User::isWatched, addWatch, and removeWatch: T208776: Introduce PageIdentity to be used instead of Title.
Mon, Nov 5, 8:06 PM · Core Platform Team Backlog (Later), Growth-Team, MediaWiki-Watchlist, Core Platform Team ( Code Health (TEC13))
daniel removed a subtask for T208764: Remove circular dependency between Title and User classes: T208776: Introduce PageIdentity to be used instead of Title.
Mon, Nov 5, 8:05 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team ( Code Health (TEC13))
daniel removed a parent task for T208776: Introduce PageIdentity to be used instead of Title: T208764: Remove circular dependency between Title and User classes.
Mon, Nov 5, 8:05 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel created T208778: Make User::getPage and User::getTalkPage return a LinkTarget.
Mon, Nov 5, 8:05 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel removed a parent task for T208768: Create a PermissionManager service: T208766: Deprecate User::isWatched, addWatch, and removeWatch.
Mon, Nov 5, 8:03 PM · Core Platform Team Backlog (Later), MediaWiki-User-management, Core Platform Team ( Code Health (TEC13))
daniel removed a subtask for T208766: Deprecate User::isWatched, addWatch, and removeWatch: T208768: Create a PermissionManager service.
Mon, Nov 5, 8:03 PM · Core Platform Team Backlog (Later), Growth-Team, MediaWiki-Watchlist, Core Platform Team ( Code Health (TEC13))
daniel added a parent task for T208776: Introduce PageIdentity to be used instead of Title: T208768: Create a PermissionManager service.
Mon, Nov 5, 8:03 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel added a subtask for T208768: Create a PermissionManager service: T208776: Introduce PageIdentity to be used instead of Title.
Mon, Nov 5, 8:03 PM · Core Platform Team Backlog (Later), MediaWiki-User-management, Core Platform Team ( Code Health (TEC13))
daniel added a subtask for T208766: Deprecate User::isWatched, addWatch, and removeWatch: T208768: Create a PermissionManager service.
Mon, Nov 5, 8:02 PM · Core Platform Team Backlog (Later), Growth-Team, MediaWiki-Watchlist, Core Platform Team ( Code Health (TEC13))
daniel added a parent task for T208768: Create a PermissionManager service: T208766: Deprecate User::isWatched, addWatch, and removeWatch.
Mon, Nov 5, 8:02 PM · Core Platform Team Backlog (Later), MediaWiki-User-management, Core Platform Team ( Code Health (TEC13))
daniel created T208777: Decide how to factor notification-related methods out of User and Title.
Mon, Nov 5, 8:02 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel created T208776: Introduce PageIdentity to be used instead of Title.
Mon, Nov 5, 7:59 PM · Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel removed a parent task for T195069: Factor PageStore and PageRecord out of WikiPage: T208764: Remove circular dependency between Title and User classes.
Mon, Nov 5, 7:54 PM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Later)
daniel removed a subtask for T208764: Remove circular dependency between Title and User classes: T195069: Factor PageStore and PageRecord out of WikiPage.
Mon, Nov 5, 7:54 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team ( Code Health (TEC13))
daniel created T208775: Deprecate Title::moveTo.
Mon, Nov 5, 7:54 PM · Technical-Debt (Deprecation), Core Platform Team Backlog (Later), Core Platform Team ( Code Health (TEC13))
daniel added a parent task for T195069: Factor PageStore and PageRecord out of WikiPage: T208764: Remove circular dependency between Title and User classes.
Mon, Nov 5, 7:50 PM · Core Platform Team (MCR), Multi-Content-Revisions (New Features), Core Platform Team Backlog (Later)
daniel added a subtask for T208764: Remove circular dependency between Title and User classes: T195069: Factor PageStore and PageRecord out of WikiPage.
Mon, Nov 5, 7:50 PM · Core Platform Team Backlog (Later), MediaWiki-Decoupling, Core Platform Team ( Code Health (TEC13))
daniel renamed T208769: Ensure that AbuseFilter applies to the content of all MCR slots from Ensure that AbuseFilter applies to the content of all MCR slots to AbuseFilter applies to the content of all slots.
Mon, Nov 5, 7:50 PM · Core Platform Team Kanban, AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering
daniel created T208768: Create a PermissionManager service.
Mon, Nov 5, 7:35 PM · Core Platform Team Backlog (Later), MediaWiki-User-management, Core Platform Team ( Code Health (TEC13))