Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (265 w, 4 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Yesterday

daniel triaged T238117: Add gcrwiki to restbase as Normal priority.
Tue, Nov 12, 10:51 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), RESTBase
daniel triaged T238116: Add shywiktionary to restbase as Normal priority.
Tue, Nov 12, 10:51 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), RESTBase
daniel triaged T237856: Live preview not working with Cologne Blue as Low priority.
Tue, Nov 12, 10:51 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Interface, CologneBlue, MediaWiki-API

Mon, Nov 11

daniel moved T224949: Failed to access name from slot_roles using id = 1 from Backlog to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Nov 11, 8:11 PM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General
daniel raised the priority of T236412: Refactor BagOStuff to use a more storage/multi-DC aware interface hieararchy from Low to Normal.

Probably needs discussion and re-architecting. Note that php interfaces cannot really be refactored, they can only be replaced.
This doesn't seem immediately actionable, and thus unsuitable as a clinic duty ticket. May make more sense to track this as a future initiative, or an rfc.

Mon, Nov 11, 8:11 PM · Core Platform Team, Patch-For-Review, MediaWiki-Cache, Performance-Team
daniel triaged T229443: Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks) as Normal priority.
Mon, Nov 11, 8:09 PM · MediaWiki-extensions-WikimediaIncubator, Core Platform Team Workboards (Clinic Duty Team), GeoCrumbs, incubator.wikimedia.org, Wikimedia-production-error
daniel triaged T235358: Could not enqueue jobs: "Unable to deliver all events: 500: Internal Server Error" as High priority.
Mon, Nov 11, 8:08 PM · Core Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Wikimedia-production-error
daniel triaged T232392: EventBus extension must not send batches that are too large as Normal priority.
Mon, Nov 11, 8:07 PM · Core Platform Team Workboards (Clinic Duty Team), Analytics, good first bug, Event-Platform, CPT Initiatives (Modern Event Platform (TEC2)), WMF-JobQueue
daniel triaged T235357: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62 as High priority.
Mon, Nov 11, 8:06 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error
daniel triaged T235360: Page view fatal from LanguageConverter: "Call to a member function isSafeToLoad() on null" as High priority.
Mon, Nov 11, 8:06 PM · MediaWiki-Parser, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, Wikimedia-production-error
daniel triaged T235551: InstantCommons should cache remote images as Normal priority.
Mon, Nov 11, 8:05 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-File-management, Commons, Multimedia
daniel triaged T236414: CPT review/work for MediaWiki caching class maintenance ramp-up as Normal priority.
Mon, Nov 11, 8:05 PM · Performance-Team (Radar), User-Eevans, Core Platform Team Workboards (Clinic Duty Team)
daniel added a comment to T235551: InstantCommons should cache remote images.

So, it seems to me and @CCicalese_WMF that this has impact on our Commons servers, and would be helpful for remote MediaWiki sites using Instant Commons. It's not clear why turning off caching was helpful for anyone.

Mon, Nov 11, 8:04 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-File-management, Commons, Multimedia
daniel triaged T236412: Refactor BagOStuff to use a more storage/multi-DC aware interface hieararchy as Low priority.
Mon, Nov 11, 8:01 PM · Core Platform Team, Patch-For-Review, MediaWiki-Cache, Performance-Team
daniel edited projects for T237709: Cannot view diffs on Special:Undelete - ends in InvalidArgumentException, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Mon, Nov 11, 8:00 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-Diffs, MediaWiki-Page-deletion, Wikimedia-production-error
daniel added a comment to T237709: Cannot view diffs on Special:Undelete - ends in InvalidArgumentException.

Probably introduced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/543718. Pinging @Pchelolo.

Mon, Nov 11, 8:00 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-Diffs, MediaWiki-Page-deletion, Wikimedia-production-error
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

Could you clarify what sounds risky? Is it the use of mwdumper? Or my automation?

Mon, Nov 11, 7:18 PM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General

Sat, Nov 9

daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

You can see the exact process I used here. I used these tools to create an SQL dump that I then loaded with mysql's cli.

Sat, Nov 9, 9:13 PM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General

Thu, Nov 7

daniel added a comment to T198312: Set the WMF cluster to use the new MCR-only schema.

Config patch scheduled to be deployed on November 12.

Thu, Nov 7, 11:30 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)

Wed, Nov 6

daniel added a comment to T233222: Factor rev_deleted logic out of the API modules.

this logic should be folded into RevisionStore::getQueryInfo() or an associated method. RevisionStore provides encapsulation for the schema of the revision table, so that's where this logic should live.

Wed, Nov 6, 12:21 PM · Patch-For-Review, Core Platform Team Workboards (Green), Technical-Debt, MediaWiki-Revision-backend

Tue, Nov 5

CCicalese_WMF awarded T236701: Consider enforcing read permissions at the storage layer a Like token.
Tue, Nov 5, 3:12 PM · MediaWiki-User-management, Core Platform Team

Mon, Nov 4

daniel edited projects for T237049: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team Workboards.

@daniel is probably needed to fix this, sorry.

Mon, Nov 4, 6:30 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes, Core Platform Team Workboards (Clinic Duty Team), wikidiff2, Release-Engineering-Team-TODO (201911), MediaWiki-Page-Diffs, MediaWiki-General, ci-test-error
daniel updated subscribers of T236680: Enable API integration tests in CI for MediaWiki core.

@zeljkofilipin suggested to move only the tests proper into the core repo, and leave the framework in a separate repo. We'd publish the framework as an npm package and add it as a dependency to core's package.json file. We'd also add a command for running these tests to core's package.json file, and trigger them from quibble, just like we do for selenium.

Mon, Nov 4, 4:55 PM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T230211: Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests..

After discussing this with Cindy, we decided to push this back. While we still want a solution that provides some kind of "deterministic mode" for interaction with MediaWiki, this is not a problem for tests in practice if we poll and wait for job execution anyway.

Mon, Nov 4, 4:49 PM · CPT Initiatives (API Integration Tests), Performance-Team (Radar), Patch-For-Review, MediaWiki-API
daniel moved T224949: Failed to access name from slot_roles using id = 1 from Done to Inbox on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Nov 4, 9:12 AM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

@daniel: it happened before and after. I upgraded to see if the fixes here would fix this issue.

Mon, Nov 4, 8:38 AM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General

Sun, Nov 3

daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

@MarkAHershberger Does this happen while upgrading, or after? Where there any errors reported during the upgrade?

Sun, Nov 3, 12:37 PM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General

Thu, Oct 31

daniel moved T236778: Use of deprecated methods should cause unit tests to fail. from Waiting for Review to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Oct 31, 8:45 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-Testing

Wed, Oct 30

daniel closed T198558: Set testwiki to use the new MCR-only schema, a subtask of T198312: Set the WMF cluster to use the new MCR-only schema, as Resolved.
Wed, Oct 30, 1:01 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel closed T198558: Set testwiki to use the new MCR-only schema as Resolved.
Wed, Oct 30, 1:01 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)
daniel added a comment to T234636: Wikimedia Technical Conference 2019 Session: API Integration Testing.

What is the problem that led to this session proposal ?

Wed, Oct 30, 12:16 PM · User-greg, International-Developer-Events, Wikimedia-Technical-Conference-2019
daniel updated subscribers of T236680: Enable API integration tests in CI for MediaWiki core.
Wed, Oct 30, 10:09 AM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel updated subscribers of T236680: Enable API integration tests in CI for MediaWiki core.
Wed, Oct 30, 10:09 AM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel updated subscribers of T236680: Enable API integration tests in CI for MediaWiki core.

@kostajh suggested to move the API integration test infrastructure into the MW core repo, along with the tests themselves. We already have this kind of situation for phpunit, qunit, phan, and selenium, so why not for mocha?

Wed, Oct 30, 10:08 AM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel committed rMTDA8189df23b57a: Read csv as directed graph (authored by daniel).
Read csv as directed graph
Wed, Oct 30, 1:19 AM

Tue, Oct 29

daniel added a comment to T235955: Update Revision classes to clarify that they accept DB domain values.

An object to wrap a single string seems like overkill to me.

Tue, Oct 29, 8:11 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), MediaWiki-Revision-backend
daniel added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

I see no mention of such an understanding at https://www.php.net/JsonSerializable or https://www.php.net/manual/en/jsonserializable.jsonserialize.php. And json_decode() still wouldn't round-trip it.

Tue, Oct 29, 4:37 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
daniel added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

PHP serialization will often round-trip it while JSON never will (whether it's JSONSerializable or not).

Tue, Oct 29, 12:54 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
daniel updated subscribers of T236778: Use of deprecated methods should cause unit tests to fail..
Tue, Oct 29, 11:50 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-Testing
daniel created T236778: Use of deprecated methods should cause unit tests to fail..
Tue, Oct 29, 11:48 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-Testing
daniel added a comment to T235955: Update Revision classes to clarify that they accept DB domain values.

IMO the exposure of "db domains" outside of internal LoadBalancer→Database communication was and is a bad idea. Most of the code should consider "wiki ids" as opaque strings. The public interfaces of LBFactory, LoadBalancer, and Database should follow suit.

Tue, Oct 29, 9:23 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), MediaWiki-Revision-backend
daniel closed T198559: Set Beta Cluster wikis to use the new MCR-only schema, a subtask of T198558: Set testwiki to use the new MCR-only schema, as Resolved.
Tue, Oct 29, 8:49 AM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)
daniel closed T198559: Set Beta Cluster wikis to use the new MCR-only schema as Resolved.

Bug fixed, see T236735: Allow WikiExporter to function with MCR-only schema.

Tue, Oct 29, 8:49 AM · Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel closed T236735: Allow WikiExporter to function with MCR-only schema, a subtask of T198558: Set testwiki to use the new MCR-only schema, as Resolved.
Tue, Oct 29, 8:48 AM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)
daniel closed T236735: Allow WikiExporter to function with MCR-only schema, a subtask of T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema, as Resolved.
Tue, Oct 29, 8:48 AM · Patch-For-Review, MW-1.34-release, Core Platform Team Workboards (Epics), Epic, CPT Initiatives (MCR Schema Migration)
daniel closed T236735: Allow WikiExporter to function with MCR-only schema, a subtask of T198559: Set Beta Cluster wikis to use the new MCR-only schema, as Resolved.
Tue, Oct 29, 8:48 AM · Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel closed T236735: Allow WikiExporter to function with MCR-only schema as Resolved.

Fixed, confirmed on beta:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Export/0.42323637011943815

Tue, Oct 29, 8:48 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)

Mon, Oct 28

daniel added a comment to T230843: Contributor updates a page.

if you post without a version ID, you are signalling that you want to create a new page, which will cause a conflict if the page doesn't already exist.

Mon, Oct 28, 8:49 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
daniel added a comment to T230843: Contributor updates a page.

if you post without a version ID, you are signalling that you want to create a new page, which will cause a conflict if the page doesn't already exist.

Mon, Oct 28, 8:47 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
daniel moved T198341: Remove all references to the rev_text_id and ar_text_id fields from Blocked to Done on the Core Platform Team Workboards (Purple) board.
Mon, Oct 28, 8:44 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel closed T198341: Remove all references to the rev_text_id and ar_text_id fields as Resolved.

All subtasks are resolved. I just went over the remaining open patches for this task and abandoned a few obsolete ones. There are only two patches remaining open, one for the Duplicator extension and one for the DeletePagesForGood extension. Neither of these is supported by WMF (deployed or bundled).

Mon, Oct 28, 8:43 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
daniel closed T198341: Remove all references to the rev_text_id and ar_text_id fields, a subtask of T231693: No direct or indirect access to pre-MCR fields is ungated, as Resolved.
Mon, Oct 28, 8:43 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (MCR Schema Migration)
daniel added a comment to T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema.
Mon, Oct 28, 8:23 PM · Patch-For-Review, MW-1.34-release, Core Platform Team Workboards (Epics), Epic, CPT Initiatives (MCR Schema Migration)
daniel added a subtask for T198558: Set testwiki to use the new MCR-only schema: T236735: Allow WikiExporter to function with MCR-only schema.
Mon, Oct 28, 8:05 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)
daniel added a subtask for T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema: T236735: Allow WikiExporter to function with MCR-only schema.
Mon, Oct 28, 8:04 PM · Patch-For-Review, MW-1.34-release, Core Platform Team Workboards (Epics), Epic, CPT Initiatives (MCR Schema Migration)
daniel added parent tasks for T236735: Allow WikiExporter to function with MCR-only schema: T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema, T198558: Set testwiki to use the new MCR-only schema.
Mon, Oct 28, 8:04 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel created T236735: Allow WikiExporter to function with MCR-only schema.
Mon, Oct 28, 8:04 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel added a comment to T198559: Set Beta Cluster wikis to use the new MCR-only schema.

Stack trace:

Mon, Oct 28, 7:23 PM · Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel reopened T198559: Set Beta Cluster wikis to use the new MCR-only schema, a subtask of T198558: Set testwiki to use the new MCR-only schema, as Open.
Mon, Oct 28, 4:31 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)
daniel reopened T198559: Set Beta Cluster wikis to use the new MCR-only schema as "Open".

Re-opening. This broke Special:Export, see e.g.
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Export/0.42323637011943815

Mon, Oct 28, 4:31 PM · Core Platform Team Workboards (Clinic Duty Team), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Structured Data Engineering, Multi-Content-Revisions (Deployment)
daniel added a comment to T198558: Set testwiki to use the new MCR-only schema.

Config change was reverted, since it broke Special:Export.

Mon, Oct 28, 4:28 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)
daniel created T236701: Consider enforcing read permissions at the storage layer.
Mon, Oct 28, 3:42 PM · MediaWiki-User-management, Core Platform Team
daniel updated the task description for T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema.
Mon, Oct 28, 1:42 PM · Patch-For-Review, MW-1.34-release, Core Platform Team Workboards (Epics), Epic, CPT Initiatives (MCR Schema Migration)
daniel updated the task description for T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema.
Mon, Oct 28, 1:41 PM · Patch-For-Review, MW-1.34-release, Core Platform Team Workboards (Epics), Epic, CPT Initiatives (MCR Schema Migration)
daniel added a project to T236680: Enable API integration tests in CI for MediaWiki core: Code-Health.
Mon, Oct 28, 12:49 PM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel created T236680: Enable API integration tests in CI for MediaWiki core.
Mon, Oct 28, 12:48 PM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
daniel added a comment to T236593: Cannot enter multiple forms for the same language variant.

I recall that we had long discussions about this when initially deciding on the data model. In technical terms, the question was whether we would allow only a single literal value for a spelling variant, or a list or set of words. Allowing a list or set would enable the kind of flexibility @jhsoby is asking for. But the down side is that it introduces ambiguity when listing forms (you would always have to list all of them, in undefined order), and when generating text (which one should you use)?

Mon, Oct 28, 9:06 AM · Lexicographical data, Wikidata

Sun, Oct 27

daniel added a project to T198558: Set testwiki to use the new MCR-only schema: Patch-For-Review.

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/543007

Sun, Oct 27, 12:44 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Deployment)

Fri, Oct 18

SD0001 awarded T12331: Introduce page creation log a Love token.
Fri, Oct 18, 7:20 PM · MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), MediaWiki-Logging, User-notice, MediaWiki-Page-editing, TechCom-RFC

Tue, Oct 15

daniel closed T224949: Failed to access name from slot_roles using id = 1 as Resolved.

I assume this is resolved now. Please re-open as needed.

Tue, Oct 15, 9:44 PM · MW-1.34-notes, CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), Multi-Content-Revisions (Reactive), Patch-For-Review, MediaWiki-General
daniel moved T235207: Some MediaWiki API call examples show an empty result set due to chosen query parameters from Triage Meeting Inbox to Feature Requests to Review on the Core Platform Team board.
Tue, Oct 15, 8:33 PM · good first bug, Documentation, Core Platform Team, MediaWiki-API
daniel triaged T235011: API query times out as Low priority.
Tue, Oct 15, 8:29 PM · Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-API
daniel moved T235244: Ensure operational visibility in ChronologyProtector from Triage Meeting Inbox to Tracking/Watching on the Core Platform Team board.
Tue, Oct 15, 8:27 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Patch-For-Review, Core Platform Team, Wikimedia-Rdbms, observability
daniel added a comment to T235216: Reconsider memcached connection method for MW in PHP7 world.

What's the ask for CPT here?

Tue, Oct 15, 8:26 PM · Performance-Team (Radar), serviceops
daniel moved T235477: ApiWatch result should emit namespace from Triage Meeting Inbox to Feature Requests to Review on the Core Platform Team board.
Tue, Oct 15, 8:25 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), User-DannyS712, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
daniel closed T235476: ApiQueryExtLinksUsage euprop needs sanity check as Invalid.

closing per @RobinHood70's comment

Tue, Oct 15, 8:24 PM · Core Platform Team, MediaWiki-API
daniel edited projects for T235360: Page view fatal from LanguageConverter: "Call to a member function isSafeToLoad() on null", added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 8:22 PM · MediaWiki-Parser, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, Wikimedia-production-error
daniel moved T181555: Remove use of PHP serialization in revision storage from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 15, 8:18 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Patch-For-Review
daniel edited projects for T181555: Remove use of PHP serialization in revision storage, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 8:18 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Patch-For-Review
daniel edited projects for T219702: Page import can fail with "Lock wait timeout exceeded" in WikiPage::insertOn, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

Going by the comments, this sounds like imports causing lock retention on the page table. Needs further investigation.

Tue, Oct 15, 8:17 PM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-database-error, MediaWiki-Revision-backend, MediaWiki-Export-or-Import, Wikimedia-production-error, Chinese-Sites
daniel edited projects for T235357: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 8:13 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error
daniel edited projects for T235512: Invalid magic word error on updating to MediaWiki 1.33.1, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 8:11 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Parser, MediaWiki-Cache
daniel removed a project from T229443: Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks): Core Platform Team.
Tue, Oct 15, 8:10 PM · MediaWiki-extensions-WikimediaIncubator, Core Platform Team Workboards (Clinic Duty Team), GeoCrumbs, incubator.wikimedia.org, Wikimedia-production-error
daniel edited projects for T235311: LBFactoryTest doesn't check for exception in the expected place, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 8:08 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-Testing, Wikimedia-Rdbms
daniel removed a project from T235168: Clarify which methods on RevisionStore enforce audience checks when accessing content: Core Platform Team.
Tue, Oct 15, 8:06 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Patch-For-Review
daniel moved T235027: Translate does not update content page when saving units from Icebox to Tracking/Watching on the Core Platform Team board.
Tue, Oct 15, 8:06 PM · Core Platform Team, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), MediaWiki-extensions-Translate
daniel moved T235027: Translate does not update content page when saving units from Inbox to Icebox on the Core Platform Team board.
Tue, Oct 15, 8:06 PM · Core Platform Team, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), MediaWiki-extensions-Translate
daniel moved T235168: Clarify which methods on RevisionStore enforce audience checks when accessing content from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 15, 8:05 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Patch-For-Review
daniel added a project to T235168: Clarify which methods on RevisionStore enforce audience checks when accessing content: Core Platform Team Workboards (Clinic Duty Team).
Tue, Oct 15, 8:05 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Patch-For-Review
daniel edited projects for T232392: EventBus extension must not send batches that are too large, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 8:04 PM · Core Platform Team Workboards (Clinic Duty Team), Analytics, good first bug, Event-Platform, CPT Initiatives (Modern Event Platform (TEC2)), WMF-JobQueue
daniel moved T235551: InstantCommons should cache remote images from Inbox to Feature Requests to Review on the Core Platform Team board.
Tue, Oct 15, 8:04 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-File-management, Commons, Multimedia
daniel moved T206283: Failed deferred updates should be queued as jobs if possible (Deadlock from LinksUpdate in WikiPage::updateCategoryCounts) from External Code Review Completed to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.

Looks like both linked tasks need review/merging.

Tue, Oct 15, 7:52 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Page-derived-data, Performance-Team, Wikimedia-production-error
daniel added a comment to T230843: Contributor updates a page.

I'm having a hard time finding any other public API (besides Action API and RESTBase) that include CSRF tokens. I'll see if I can do some more research to come up with how other providers do it.

Tue, Oct 15, 6:44 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
daniel added a comment to T235528: Check read permissions for from and to revision in comparison endpoint.

@daniel You say "pages", but this endpoint is defined for comparison across revisions of a single page. I assume we need one permission check for the page, and a second and third for each revision?

Tue, Oct 15, 4:09 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP), MediaWiki-REST-API
daniel added a comment to T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter.

I have found the reason for triple lookups of content; the third lookup, performed from within the Abstract Filter extension, is to determine whether or not the revision is a redirect or not.

Tue, Oct 15, 10:01 AM · CPT Initiatives (MCR), Patch-For-Review, Multi-Content-Revisions (Tech Debt)
daniel added a comment to T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter.

Thank you for investigating, Ariel!

Tue, Oct 15, 9:58 AM · CPT Initiatives (MCR), Patch-For-Review, Multi-Content-Revisions (Tech Debt)

Mon, Oct 14

daniel added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Pinging Performance-Team since they own WANObjectCache.

Mon, Oct 14, 3:22 PM · serviceops, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
daniel added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

I put this up for SWAT in 3 hours: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/542963

Mon, Oct 14, 3:15 PM · serviceops, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net

Oct 12 2019

daniel added a comment to T231580: Implement GET Revision Comparison.

The handler for this route doesn't seem to check read permissions for the pages it is comparing. That means it could be used to bypass per-page read permissions. The DifferenceEngine class responsible for showing diffs in the UI does apply these checks, though I note that ApiComparePages seems to be lacking them as well.

Oct 12 2019, 8:58 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 11 2019

daniel added a comment to T231588: Implement GET Page Revision.

On the patch @BPirkle asked:

Thank you Daniel. Was that comment informational, or did you see something we need to change?

Oct 11 2019, 1:46 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)