Page MenuHomePhabricator

daniel (Daniel Kinzler)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (248 w, 3 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity

Yesterday

daniel added a comment to T226598: REST API i18n.

@Anomie said

In general, we need the code doing the outputting to be able to know what it's getting back: output safe for HTML output (whether parsed or escaped) or output not safe for HTML output, which doesn't depend on the input format

Mon, Jul 15, 6:34 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)
daniel added a comment to T226598: REST API i18n.

So I now propose that MessageFormatter::format() will correspond to Message::text(), which just does preprocessing. It would be up to the caller to interpret the result as either plain text or HTML.

Mon, Jul 15, 8:50 AM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)

Fri, Jul 12

daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

That may be true of a general abstraction layer, but we're talking about a specific abstraction layer for MediaWiki. Therefore, by definition, it is the choice of the application.

Fri, Jul 12, 2:44 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
daniel updated the task description for T221100: Phester: Add support for variables.
Fri, Jul 12, 2:37 PM · Core Platform Team (API Integration Tests)
daniel added a parent task for T227885: Phester: support session context: T227887: Phester: bind variables to sessions.
Fri, Jul 12, 2:34 PM · Core Platform Team (API Integration Tests), Code-Health
daniel added a parent task for T221100: Phester: Add support for variables: T227887: Phester: bind variables to sessions.
Fri, Jul 12, 2:34 PM · Core Platform Team (API Integration Tests)
daniel added subtasks for T227887: Phester: bind variables to sessions: T227885: Phester: support session context, T221100: Phester: Add support for variables.
Fri, Jul 12, 2:34 PM · Core Platform Team (API Integration Tests), Code-Health
daniel created T227887: Phester: bind variables to sessions.
Fri, Jul 12, 2:33 PM · Core Platform Team (API Integration Tests), Code-Health
daniel added a parent task for T221088: Baseline implementation of Phester test runner: T227885: Phester: support session context.
Fri, Jul 12, 2:31 PM · Epic, Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3)
daniel added a subtask for T227885: Phester: support session context: T221088: Baseline implementation of Phester test runner.
Fri, Jul 12, 2:31 PM · Core Platform Team (API Integration Tests), Code-Health
daniel updated the task description for T224932: Phester: add support for cookies and sessions.
Fri, Jul 12, 2:30 PM · Core Platform Team (API Integration Tests), Code-Health
daniel updated the task description for T227885: Phester: support session context.
Fri, Jul 12, 2:29 PM · Core Platform Team (API Integration Tests), Code-Health
daniel created T227885: Phester: support session context.
Fri, Jul 12, 2:29 PM · Core Platform Team (API Integration Tests), Code-Health
daniel closed T174031: MCR: Include all slots in XML dumps as Resolved.

This is done. Here is a link to the API:Sandbox for exporting a file description page with a mediainfo slot:

Fri, Jul 12, 2:27 PM · Core Platform Team Workboards (Team 3), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Core Platform Team (MCR), Multi-Content-Revisions (New Features), SDC Engineering, Wikidata
daniel added a comment to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link".

The merged patch, 522401, should address the critical problem. Should probably be backported and go on SWAT.

Fri, Jul 12, 1:00 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error
daniel added a comment to T32211: Detect conflict on move.

Hmm, then the fact two users were moving on the same time might be just a coincidence.

Fri, Jul 12, 11:30 AM · MediaWiki-Special-pages
daniel added a comment to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link".

meta:MediaWiki Stakeholders' Group is an interwiki redirect:

#REDIRECT [[mw:MediaWiki_Stakeholders%27_Group]]
Fri, Jul 12, 10:09 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error
daniel added a comment to T191231: RFC: Abstract schemas and schema changes.

This. A proper DB abstraction should not be about trying to define the lowest common denominator of, for example, an INT field (can't be signed, limited to 16 bits because we need to support FoobarDB, etc.). It should be about defining high-level data types (e.g. EMAIL, ARTICLE_TEXT, etc.) and allowing the individual abstraction layers to map them to the most appropriate type in the back-end system.

Fri, Jul 12, 9:05 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
daniel added a comment to T226598: REST API i18n.

I agree with the plan Tim outlined above.

Fri, Jul 12, 8:54 AM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)
daniel added a comment to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link".

Such as:

Fri, Jul 12, 8:29 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error

Thu, Jul 11

daniel added a project to T227772: Fix or remove capability to override user rights for the current request: Core Platform Team.

Tagging CPT for review.

Thu, Jul 11, 9:07 PM · Core Platform Team, Patch-For-Review, Stewards-and-global-tools, ArticleFeedbackv5, GraphViz, MediaWiki-extensions-CentralAuth
daniel added a comment to T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.

At the moment we don't have a concept of "non-public REST API routes", unless I missed something when I was on vacation recently. The closest would be a public route that we document as internal and that requires some sort of shared secret to function.

Thu, Jul 11, 9:04 PM · Core Platform Team, TechCom, User-Daniel, Proposal
daniel added a comment to T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.

Kask,[1] accessed via RESTBagOStuff?

Thu, Jul 11, 9:02 PM · Core Platform Team, TechCom, User-Daniel, Proposal
daniel added a comment to T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.

Overall I like the idea, but I'd want to see more details as to how all the "in addition support" stuff is actually going to work at an interface level that doesn't wind up turning it into just another generic key-value store.

Thu, Jul 11, 8:31 PM · Core Platform Team, TechCom, User-Daniel, Proposal
daniel added a comment to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link".

But if you are confident it will get fixed in the last 7 days, I don't see a reason to block the train today.

Thu, Jul 11, 8:12 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error
daniel added a comment to T213505: RfC: OpenGraph descriptions in wiki pages.

The issue here is that the cached HTML would have to be updated at some later point, when the summary became available. At a glance, the proposed change to ParserCache does not make that easier (or harder).

Thu, Jul 11, 8:04 PM · Reading-Infrastructure-Team-Backlog, MediaWiki-General-or-Unknown, TechCom-RFC
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

@Anomie time to revive https://gerrit.wikimedia.org/r/c/mediawiki/core/+/514245?

Thu, Jul 11, 8:02 PM · MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (MCR), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General-or-Unknown
daniel moved T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage from Inbox to Backlog on the TechCom-RFC board.

Moved to the RFC backlog for improvement after discussion at the TechCom meeting. The proposed functionality seems sensible enough, but this ticket is lacking information about system design that is needed to make this viable as an RFC.

Thu, Jul 11, 2:27 PM · Wikibase-Quality-Constraints, Core Platform Team Backlog (Designing), Services (designing), User-mobrovac, wikidata-tech-focus, TechCom-RFC, Wikibase-Quality, Wikidata
daniel moved T222224: Normalizing *links tables from Inbox to Under discussion on the TechCom-RFC board.
Thu, Jul 11, 2:18 PM · Patch-For-Review, MediaWiki-Database, TechCom-RFC
daniel added a comment to T222224: Normalizing *links tables.

@Ladsgroup we discussed this at the TechCom meeting. This proposal seems sensible at the database level, but there are two aspects that are not really clear: need and cost.

Thu, Jul 11, 1:58 PM · Patch-For-Review, MediaWiki-Database, TechCom-RFC
daniel moved T99268: RfC: Create a proper command-line runner for MediaWiki maintenance tasks from Inbox to Last Call on the TechCom-RFC board.

Per the TechCom meeting on July 10, this goes on Last Call until July 24. If no relevant objections remain unaddressed by that time, this RFC will be approved as proposed.

Thu, Jul 11, 1:51 PM · Core Platform Team (Code Health (TEC13)), MediaWiki-Maintenance-scripts, TechCom-RFC
daniel added a comment to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link".

The reason that it's UBN is because it's a train blocker and they all are UBN. Whether this should be considered as train blocker or not. I don't know. (Just case it's not clear why it's UBN)

Thu, Jul 11, 1:47 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error
daniel added projects to T227776: Generalize ParserCache, create a service for storing data derived from a page's current content: User-Daniel, TechCom.
Thu, Jul 11, 1:44 PM · Core Platform Team, TechCom, User-Daniel, Proposal
daniel added a comment to T220449: Split RESTBase in two services: storage service and API router/proxy.

We should thin about how the RESTbase storage component relates to the ideas outlined in T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.

Thu, Jul 11, 1:43 PM · Core Platform Team Workboards (Team 2), User-mobrovac, serviceops, Epic, RESTBase, Core Platform Team (RESTBase Split (CDP2))
daniel added a comment to T119043: Graph/Graphoid/Kartographer - data storage architecture.

This is a potential use case for T227776: Generalize ParserCache, create a service for storing data derived from a page's current content

Thu, Jul 11, 1:42 PM · Core Platform Team Backlog (Watching / External), Reading-Infrastructure-Team-Backlog, Services (watching), Maps (Kartographer), TechCom-RFC, Graphoid, Graphs, Service-Architecture, RESTBase-architecture
daniel added a comment to T213505: RfC: OpenGraph descriptions in wiki pages.

Might be a use case for T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.

Thu, Jul 11, 1:40 PM · Reading-Infrastructure-Team-Backlog, MediaWiki-General-or-Unknown, TechCom-RFC
daniel updated the task description for T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.
Thu, Jul 11, 1:39 PM · Core Platform Team, TechCom, User-Daniel, Proposal
daniel created T227776: Generalize ParserCache, create a service for storing data derived from a page's current content.
Thu, Jul 11, 1:37 PM · Core Platform Team, TechCom, User-Daniel, Proposal
daniel added a comment to T212521: RFC: Let's stop running QUnit unit tests as integration tests.

@Jdlrobson thanks for the clarification, Jon!

Thu, Jul 11, 1:29 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
daniel added a comment to T216165: Drop PHP 7.0 support from MediaWiki.

Can you please go have an RfC on another task with Timo's proposal (which would also encompass T216166 ), rather than disrupt this task?

Thu, Jul 11, 8:36 AM · TechCom-RFC, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.0 support
daniel added a project to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link": Core Platform Team Workboards (Clinic Duty Team).
Thu, Jul 11, 8:29 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error
daniel added a comment to T227700: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link".

Thanks for the analysis, @Krinkle! Looks like the Title/NamespaceInfo refactoring is flushing out more places were we inadvertently use invalid titles or make unwarranted assumptions about titles.

Thu, Jul 11, 8:28 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, MediaWiki-Internationalization, Wikimedia-production-error

Wed, Jul 10

daniel added a comment to T216165: Drop PHP 7.0 support from MediaWiki.

This should be an RFC since it has wide ranging implications.

Wed, Jul 10, 9:38 PM · TechCom-RFC, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.0 support
daniel moved T216165: Drop PHP 7.0 support from MediaWiki from Inbox to Under discussion on the TechCom-RFC board.
Wed, Jul 10, 9:38 PM · TechCom-RFC, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.0 support
daniel edited projects for T216165: Drop PHP 7.0 support from MediaWiki, added: TechCom-RFC; removed TechCom.
Wed, Jul 10, 9:38 PM · TechCom-RFC, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.0 support
daniel committed rMTDA86299843303f: Work around dephpend being incomatible with symphony 4.3 (authored by daniel).
Work around dephpend being incomatible with symphony 4.3
Wed, Jul 10, 4:36 PM
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

Before upgrade the wiki was 1.31.0, cache was filled with its data and everything worked after upgrade

Wed, Jul 10, 10:04 AM · MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (MCR), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General-or-Unknown

Tue, Jul 9

daniel added a comment to T223165: Implement access restrictions in WatchedItemStore.

It appears Core Platform Team is taking this on so the Growth-Team is moving this to external.

Tue, Jul 9, 9:29 PM · Core Platform Team (Decoupling (CDP2)), Growth-Team, MediaWiki-Watchlist
daniel added a comment to T227603: Create a CI container for mediawiki/tools/dependency-analysis.

@hashar on a related note: T227600: Make graph-tool available on tool forge

Tue, Jul 9, 7:16 PM · Release-Engineering-Team (Code Health), Code-Health, Continuous-Integration-Config
daniel added a comment to T227603: Create a CI container for mediawiki/tools/dependency-analysis.

@daniel I am not sure why networkx has to be used with python 2. It has been supporting python 3 for a while and even dropped python 2 support with v2.3.

Tue, Jul 9, 7:15 PM · Release-Engineering-Team (Code Health), Code-Health, Continuous-Integration-Config
daniel edited projects for T221088: Baseline implementation of Phester test runner, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:07 PM · Epic, Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3)
daniel edited projects for T222100: Decide whether creating Phester is actually worth while, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:07 PM · Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3), User-Daniel, Code-Health
daniel edited projects for T219876: Create action API test cases, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Epic, Core Platform Team (API Integration Tests), Code-Health
daniel edited projects for T219877: Create a containerized environment for running end-to-end API tests, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Epic, Core Platform Team (API Integration Tests)
daniel edited projects for T219879: Create a test runner for end-to-end API tests (Phester), added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests), Epic, Code-Health
daniel edited projects for T221092: Phester: support HTML output, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T221093: Phester: support JSON output, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T221094: Phester: discover tests specified by extensions, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T221096: Phester: parallel test execution, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T221098: Phester: support fixture files, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T221100: Phester: Add support for variables, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T221102: Phester: allow test suites to be filtered by tag, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T222103: Finalize file format for phester test definitions, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests)
daniel edited projects for T224932: Phester: add support for cookies and sessions, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests), Code-Health
daniel edited projects for T224987: Phester: allow for retries, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests), Code-Health
daniel edited projects for T225192: Support running the same tests with several sets of parameters (test cases), added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:06 PM · Core Platform Team (API Integration Tests), Code-Health
daniel edited projects for T225608: Phester: allow test for interactions spanning multiple sites, added: Core Platform Team (API Integration Tests); removed Core Platform Team (Code Health (TEC13)).
Tue, Jul 9, 7:05 PM · Core Platform Team (API Integration Tests), Code-Health
daniel edited projects for T227600: Make graph-tool available on tool forge, added: Toolforge; removed Toolforge (Software install/update).
Tue, Jul 9, 6:00 PM · cloud-services-team (Kanban), Toolforge
daniel created T227600: Make graph-tool available on tool forge.
Tue, Jul 9, 6:00 PM · cloud-services-team (Kanban), Toolforge
daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

Caching should not be the cause of any problems during upgrade. Unless the desired is found in the cache but isn't actually in the table, in which case it wouldn't get created in the table. But how would it get into the cache if it's not in the table? The cache is populated by loading from the database.

Tue, Jul 9, 2:52 PM · MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (MCR), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General-or-Unknown
daniel updated subscribers of T193824: Determine a standard way of installing MediaWiki lib/extension dependencies within containers.

Pinging @Physikerwelt for the Mathoid use case.

Tue, Jul 9, 2:08 PM · Release-Engineering-Team-TODO (201907), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Core Platform Team (Extension Management (TEC13)), Patch-For-Review, Release Pipeline
daniel added a comment to T226598: REST API i18n.

There will either need to be a factory class, or the formatting functions will need to have a language parameter.

That's a good question, and one that will also be relevant if/when I get around to the MessageSpecifier thing.

Tue, Jul 9, 12:18 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)
daniel added a comment to T226598: REST API i18n.

Implementations ignoring the hint and just displaying the raw quantity and unit would still be usable, if a bit awkward.

Tue, Jul 9, 12:03 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)
daniel added a comment to T184529: Define a way to get a database connection based on a logical wiki ID..
Tue, Jul 9, 11:42 AM · Core Platform Team (Cross-Wiki (CDP2)), User-Daniel, MediaWiki-Database
daniel updated the task description for T227305: Define a WikiID class for uniquely identifying wikis.
Tue, Jul 9, 11:41 AM · Performance-Team (Radar), User-Daniel, Core Platform Team (Cross-Wiki (CDP2)), MediaWiki-General-or-Unknown
daniel added a project to T224020: Create a class to represent the identity of wikis on the same wiki farm: Performance-Team.
Tue, Jul 9, 11:40 AM · Performance-Team (Radar), Proposal, MediaWiki-General-or-Unknown, MediaWiki-Farmers, User-Daniel, Core Platform Team (Cross-Wiki (CDP2))
daniel merged task T227305: Define a WikiID class for uniquely identifying wikis into T224020: Create a class to represent the identity of wikis on the same wiki farm.
Tue, Jul 9, 11:37 AM · Performance-Team (Radar), User-Daniel, Core Platform Team (Cross-Wiki (CDP2)), MediaWiki-General-or-Unknown
daniel merged T227305: Define a WikiID class for uniquely identifying wikis into T224020: Create a class to represent the identity of wikis on the same wiki farm.
Tue, Jul 9, 11:37 AM · Performance-Team (Radar), Proposal, MediaWiki-General-or-Unknown, MediaWiki-Farmers, User-Daniel, Core Platform Team (Cross-Wiki (CDP2))
daniel moved T99268: RfC: Create a proper command-line runner for MediaWiki maintenance tasks from Under discussion to Inbox on the TechCom-RFC board.

up for review per legoktm

Tue, Jul 9, 11:30 AM · Core Platform Team (Code Health (TEC13)), MediaWiki-Maintenance-scripts, TechCom-RFC
daniel added a comment to T193824: Determine a standard way of installing MediaWiki lib/extension dependencies within containers.

I've been operating under the assumption that at some stage we're going to have some kind of containers with just some extensions installed, and we'll need to resolve those dependencies for testing or whatever.

Tue, Jul 9, 11:28 AM · Release-Engineering-Team-TODO (201907), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Core Platform Team (Extension Management (TEC13)), Patch-For-Review, Release Pipeline
daniel updated the task description for T221098: Phester: support fixture files.
Tue, Jul 9, 9:46 AM · Core Platform Team (API Integration Tests)

Mon, Jul 8

daniel added a comment to T224949: Failed to access name from slot_roles using id = 1.

@Absorbcium is there anything in the log about the PopulateContentTables script being run? Try running it manually if in doubt.

Mon, Jul 8, 7:57 PM · MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (MCR), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General-or-Unknown
daniel created T227494: Phester: PHPUnit integration (experiment).
Mon, Jul 8, 3:58 PM · Core Platform Team (API Integration Tests), Epic, Code-Health
daniel updated the task description for T219879: Create a test runner for end-to-end API tests (Phester).
Mon, Jul 8, 3:55 PM · Core Platform Team (API Integration Tests), Epic, Code-Health
daniel added a comment to T222100: Decide whether creating Phester is actually worth while.

In other news, I'm investigating the possibility of making a codeception plugin for phester style tests. Seems quite doable, but I have only just started to poke around.

Mon, Jul 8, 1:51 PM · Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3), User-Daniel, Code-Health
daniel added a comment to T222100: Decide whether creating Phester is actually worth while.

I found another tool that is relatively close to phester conceptually: htt the HTTP Test Tool (hosted on sourceforge - I didn't know that was still a thing). As far as I can tell, htt was created by the FSF in 2011 and as seen little activity between 2013 and 2019, but had version 2.4 release this year.

Mon, Jul 8, 1:50 PM · Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3), User-Daniel, Code-Health
daniel closed T225585: Unable to open user sub pages with trailing space (Blank page fatal: "invalid DB key") as Resolved.
Mon, Jul 8, 11:53 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Workboards (Team 3), WikiLove, Growth-Team, Wikimedia-production-error
daniel added a comment to T225585: Unable to open user sub pages with trailing space (Blank page fatal: "invalid DB key").

@daniel i've backported this into wmf.11 to speed up the fixing. Can you (or somebody else) verify it's indeed fixed now please?

Mon, Jul 8, 11:52 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Workboards (Team 3), WikiLove, Growth-Team, Wikimedia-production-error

Fri, Jul 5

daniel added a comment to T225366: "Fatal exception: MediaWiki\Revision\InvalidArgumentException" when trying to move user JS page on en.wp.

So, the concrete issue was fixed by moving the check, but we still don't know the root cause. Is that correct?

Fri, Jul 5, 5:12 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Revision-backend, Wikimedia-production-error
daniel added a comment to T222100: Decide whether creating Phester is actually worth while.

Meanwhile you could have a look at https://github.com/deminy/behat-rest-testing

Fri, Jul 5, 5:05 PM · Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3), User-Daniel, Code-Health
daniel created P8716 API CRUD test in Behat.
Fri, Jul 5, 4:55 PM
daniel closed T217829: Update populateRevisionSha1.php to run over the content table, a subtask of T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !, as Resolved.
Fri, Jul 5, 3:31 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions
daniel closed T217829: Update populateRevisionSha1.php to run over the content table as Resolved.

The relevant patches mentioned above are merged now.

Fri, Jul 5, 3:31 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (Security, stability, performance and scalability (TEC1))
daniel closed T224368: Ensure Linker::userLink is not called with empty user name as Resolved.
Fri, Jul 5, 1:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging
daniel updated the task description for T224368: Ensure Linker::userLink is not called with empty user name.
Fri, Jul 5, 1:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging
daniel added a comment to T217829: Update populateRevisionSha1.php to run over the content table.

This task is invalid as described, because the updater has always been running PopulateRevisionSha1 after PopulateContentTables. I changed PopulateContentTables to calculate the SHA1 (and the size) on the fly if needed and write it to the content table
(https://gerrit.wikimedia.org/r/520735), and Bill updated PopulateRevisionSha1 to make use of that information to populate rev_sha1 and ar_sha1 at the end of the update process (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/516730/).

Fri, Jul 5, 1:30 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (Security, stability, performance and scalability (TEC1))
daniel closed T217831: Add a check to populateContentTables.php to ensure that populateRevisionSha1.php is run first, a subtask of T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !, as Resolved.
Fri, Jul 5, 1:29 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions
daniel closed T217831: Add a check to populateContentTables.php to ensure that populateRevisionSha1.php is run first as Resolved.

This task is invalid as described, because the updater has always been running PopulateRevisionSha1 after PopulateContentTables. I changed PopulateContentTables to calculate the SHA1 (and the size) on the fly if needed and write it to the content table
(https://gerrit.wikimedia.org/r/520735), and Bill updated PopulateRevisionSha1 to make use of that information to populate rev_sha1 and ar_sha1 at the end of the update process (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/516730/).

Fri, Jul 5, 1:29 PM · MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (Security, stability, performance and scalability (TEC1))
daniel added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

Update: Seems the "populateRevisionSha1" maintenance script needed to be run with some "--force" option.
To make note of a personal point here ... I'm kinda disappointed that option was not mentioned here.

Fri, Jul 5, 1:24 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions
daniel added a comment to T222100: Decide whether creating Phester is actually worth while.

So I played with codeception a bit. Here's the basic CRUD tests:

1<?php
2
3class CRUDCest {
4 public function _before(ApiTester $I) {
5 }
6
7 // tests
8 public function testCreateEditDelete(ApiTester $I) {
9 $I->wantTo( 'Create, edit, and delete' );
10
11 $I->haveHttpHeader('Content-Type', 'application/x-www-form-urlencoded');
12 $I->sendPOST( 'api.php',
13 [ 'action' => 'edit',
14 'title' => 'Test',
15 'creatonly' => 'true',
16 'format' => 'json',
17 'summary' => 'some test',
18 'text' => 'test text',
19 'token' => '+\\',
20 ]
21 );
22 $I->seeResponseCodeIs(\Codeception\Util\HttpCode::OK); // 200
23 $I->seeResponseContainsJson( [
24 'edit' => [
25 'result' => 'Success'
26 ]
27 ]);
28
29 $I->sendGET( 'api.php',
30 [ 'action' => 'parse',
31 'page' => 'Test',
32 'format' => 'json',
33 ]
34 );
35 $I->seeResponseCodeIs(\Codeception\Util\HttpCode::OK); // 200
36 $I->seeResponseIsJson();
37 $I->seeResponseMatches( '/test text/');
38
39 $I->haveHttpHeader('Content-Type', 'application/x-www-form-urlencoded');
40 $I->sendPOST( 'api.php',
41 [ 'action' => 'edit',
42 'title' => 'Test',
43 'format' => 'json',
44 'summary' => 'some edit',
45 'text' => 'edited test text',
46 'token' => '+\\',
47 ]
48 );
49 $I->seeResponseCodeIs(\Codeception\Util\HttpCode::OK); // 200
50 $I->seeResponseContainsJson( [
51 'edit' => [
52 'result' => 'Success'
53 ]
54 ]);
55
56 $I->sendGET( 'api.php',
57 [ 'action' => 'parse',
58 'page' => 'Test',
59 'format' => 'json',
60 ]
61 );
62 $I->seeResponseCodeIs(\Codeception\Util\HttpCode::OK); // 200
63 $I->seeResponseIsJson();
64 $I->seeResponseMatches( '/edited test text/');
65
66 $I->haveHttpHeader('Content-Type', 'application/x-www-form-urlencoded');
67 $I->sendPOST( 'api.php',
68 [ 'action' => 'delete',
69 'title' => 'Test',
70 'format' => 'json',
71 'token' => '+\\',
72 ]
73 );
74 $I->seeResponseCodeIs(\Codeception\Util\HttpCode::OK); // 200
75 $I->seeResponseContainsJson( [
76 'delete' => [
77 'title' => 'Test'
78 ]
79 ]);
80
81 $I->sendGET( 'api.php',
82 [ 'action' => 'parse',
83 'page' => 'Test',
84 'format' => 'json',
85 ]
86 );
87 $I->seeResponseContainsJson( [
88 'error' => [
89 'code' => 'missingtitle'
90 ]
91 ]);
92 }
93}

Fri, Jul 5, 1:13 PM · Core Platform Team (API Integration Tests), Core Platform Team Workboards (Team 3), User-Daniel, Code-Health