dbarratt (David Barratt)
Software Engineer, Anti-Harassment Tools

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 30 2017, 9:17 PM (79 w, 6 d)
Availability
Available
IRC Nick
davidwbarratt
LDAP User
Dbarratt
MediaWiki User
DBarratt (WMF) [ Global Accounts ]

Recent Activity

Today

Krinkle awarded T210474: Make failures on foreachwiki more obvious the deployer a Orange Medal token.
Mon, Dec 10, 7:31 PM · Deployments

Mon, Dec 3

dbarratt added a comment to T210953: Wikidata is editable for blocked users.

@TBolliger FYI T208862 is being reverted, so plan accordingly. :)

Mon, Dec 3, 12:41 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
dbarratt updated subscribers of T210953: Wikidata is editable for blocked users.
Mon, Dec 3, 12:40 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
dbarratt added a comment to T210953: Wikidata is editable for blocked users.

It looks like this stems from Title::checkUserBlock and then Action::requiresUnblock.
ViewEntityAction::requiresUnblock returns false and has done since 2012.
EditEntityView extends this, but doesnt override the methods, so has the same behaviour as a view...
This method has a confusing name...
I'm not yet sure why this didn't work while testing terms, perhaps it uses a different action? hmpf..

Mon, Dec 3, 12:12 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security

Sat, Dec 1

dbarratt added a comment to T210791: The origin param in the Action API exposes intranet installs to any web page.

I mean I think that's fine to say that we don't support open MediaWiki installs on private intranets (without some sort of other authorization).

Sat, Dec 1, 12:05 AM · MediaWiki-API, Security

Fri, Nov 30

dbarratt added a comment to T210791: The origin param in the Action API exposes intranet installs to any web page.

I think its debatable if access control to intranet sites is really in the threat model of the same origin policy (for example, consider https://en.wikipedia.org/wiki/DNS_rebinding attacks more generally). [Of course, at some point that doesn't matter. We have to deal with the consequences regardless]

Fri, Nov 30, 5:20 AM · MediaWiki-API, Security
dbarratt added a comment to T210791: The origin param in the Action API exposes intranet installs to any web page.

In fact, we're allowing the client to make that exception, which makes the setting pointless. If we set Access-Control-Allow-Origin: * on every request, we'd have the same thing we have now (as far as I can tell).

Fri, Nov 30, 4:24 AM · MediaWiki-API, Security
dbarratt updated the task description for T210791: The origin param in the Action API exposes intranet installs to any web page.
Fri, Nov 30, 4:14 AM · MediaWiki-API, Security
dbarratt added a comment to T210791: The origin param in the Action API exposes intranet installs to any web page.

On one hand, I kind of feel like its a browser issue - Should they really allow globally routed internet apps make requests to private IP space intranet app. But that's probably kind of impossible.

Fri, Nov 30, 4:08 AM · MediaWiki-API, Security

Thu, Nov 29

dbarratt updated the task description for T210791: The origin param in the Action API exposes intranet installs to any web page.
Thu, Nov 29, 9:46 PM · MediaWiki-API, Security
dbarratt added a project to T210791: The origin param in the Action API exposes intranet installs to any web page: MediaWiki-API.
Thu, Nov 29, 9:44 PM · MediaWiki-API, Security
dbarratt updated subscribers of T210791: The origin param in the Action API exposes intranet installs to any web page.
Thu, Nov 29, 9:42 PM · MediaWiki-API, Security
dbarratt created T210791: The origin param in the Action API exposes intranet installs to any web page.
Thu, Nov 29, 9:41 PM · MediaWiki-API, Security
dbarratt updated the task description for T210790: Action API should default to origin=* on Wikimedia Wikis.
Thu, Nov 29, 9:33 PM · MediaWiki-API
dbarratt updated subscribers of T210790: Action API should default to origin=* on Wikimedia Wikis.
Thu, Nov 29, 9:28 PM · MediaWiki-API
dbarratt updated the task description for T210790: Action API should default to origin=* on Wikimedia Wikis.
Thu, Nov 29, 9:27 PM · MediaWiki-API
dbarratt created T210790: Action API should default to origin=* on Wikimedia Wikis.
Thu, Nov 29, 9:27 PM · MediaWiki-API
dbarratt added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

In T204991 we've added the method Block::appliesToNamespace() which can be used for new entity creation.

Thu, Nov 29, 9:12 PM · Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata
dbarratt updated the task description for T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.
Thu, Nov 29, 9:11 PM · Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata
dbarratt added a comment to T210107: The Action API should allow input in JSON.

So, if we were going to implement this as an API module, I'd recommend:

Thu, Nov 29, 8:54 PM · MediaWiki-API
dbarratt added a comment to T206163: If a user/IP combo is partially/sitewide (overlapping) blocked, always enforce the sitewide block.

The user could have two overlapping partial blocks... and I think those should be enforced together rather than picking one or the other, so I don't think this issue strictly has to do with sitewide blocks exclusively. However it is possible for the user to get a partial block enforcement, when they also have a sitewide block

Thu, Nov 29, 7:58 PM · Anti-Harassment, MediaWiki-User-management

Tue, Nov 27

dbarratt closed T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) as Resolved.
Tue, Nov 27, 4:33 PM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt added a comment to T210474: Make failures on foreachwiki more obvious the deployer.

What's a "failure"?

Tue, Nov 27, 3:27 PM · Deployments
dbarratt added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

@Dinoguy1000 I've updated this for namespaces here:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/470656

Tue, Nov 27, 3:16 PM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

The OP specifically calls for a user to be blocked from their UTP if the UTP block box is not checked, but they are partial-blocked from the User_talk namespace.

Tue, Nov 27, 2:51 PM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt updated the task description for T204988: Add tests for NamespaceRestriction enforcement.
Tue, Nov 27, 2:49 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

This change basically means that specifying User_talk:Apples or checking Prevent this user from editing his own talk page while blocked are treated the same way, which makes sense to me and resolves the edge case.

Is it possible to automatically convert the former to the latter when the block form is saved?

Tue, Nov 27, 2:45 PM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt updated subscribers of T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

@TBolliger This change basically means that specifying User_talk:Apples or checking Prevent this user from editing his own talk page while blocked are treated the same way, which makes sense to me and resolves the edge case.

Tue, Nov 27, 7:31 AM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt moved T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) from In progress to Review on the Anti-Harassment (AHT Sprint 34) board.
Tue, Nov 27, 6:47 AM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt placed T204988: Add tests for NamespaceRestriction enforcement up for grabs.
Tue, Nov 27, 6:28 AM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt claimed T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).
Tue, Nov 27, 6:27 AM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt moved T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) from Ready to In progress on the Anti-Harassment (AHT Sprint 34) board.
Tue, Nov 27, 6:27 AM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt moved T204988: Add tests for NamespaceRestriction enforcement from In progress to Ready on the Anti-Harassment (AHT Sprint 34) board.
Tue, Nov 27, 6:27 AM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt updated the task description for T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).
Tue, Nov 27, 6:01 AM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt updated the task description for T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).
Tue, Nov 27, 6:01 AM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review
dbarratt updated the task description for T204988: Add tests for NamespaceRestriction enforcement.
Tue, Nov 27, 5:42 AM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt added a comment to T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.

Yep, l'll resolve this as the original issue is good to go. Thanks all, a separate task to pursue the larger contributing issue seems ideal. @dbarratt would you mind making that?

Tue, Nov 27, 5:27 AM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt added a parent task for T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist: T210474: Make failures on foreachwiki more obvious the deployer.
Tue, Nov 27, 5:26 AM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt added a subtask for T210474: Make failures on foreachwiki more obvious the deployer: T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.
Tue, Nov 27, 5:26 AM · Deployments
dbarratt created T210474: Make failures on foreachwiki more obvious the deployer.
Tue, Nov 27, 5:26 AM · Deployments

Mon, Nov 26

dbarratt added a comment to T210444: SWAT deploy PartialBlocks on Italian Wikipedia — 🇮🇹.

I assume we need to wait until after 1.33.0-wmf.5 is deployed to Group 2? https://tools.wmflabs.org/versions/

Mon, Nov 26, 9:33 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review
dbarratt closed T209633: Track when block notices are displayed on VisualEditor client side as Resolved.
Mon, Nov 26, 3:30 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33)
dbarratt closed T209633: Track when block notices are displayed on VisualEditor client side, a subtask of T201718: Tracking blocks: Log when the desktop VisualEditor + 2010 wikitext editor block notice is displayed , as Resolved.
Mon, Nov 26, 3:30 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 34), Performance-Team, Patch-For-Review
dbarratt moved T210369: Add @since 1.33 tags to every new public method in BlockRestriction from Backlog to User blocking on the MediaWiki-User-management board.
Mon, Nov 26, 3:21 PM · MediaWiki-User-management, Anti-Harassment
dbarratt renamed T210369: Add @since 1.33 tags to every new public method in BlockRestriction from Add @since tags to every new public method in BlockRestriction to Add @since 1.33 tags to every new public method in BlockRestriction.
Mon, Nov 26, 3:21 PM · MediaWiki-User-management, Anti-Harassment
dbarratt added a parent task for T202036: Create block restrictions related classes: T210369: Add @since 1.33 tags to every new public method in BlockRestriction.
Mon, Nov 26, 5:43 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Anti-Harassment (AHT Sprint 31), Patch-For-Review
dbarratt added a subtask for T210369: Add @since 1.33 tags to every new public method in BlockRestriction: T202036: Create block restrictions related classes.
Mon, Nov 26, 5:42 AM · MediaWiki-User-management, Anti-Harassment
dbarratt created T210369: Add @since 1.33 tags to every new public method in BlockRestriction.
Mon, Nov 26, 5:42 AM · MediaWiki-User-management, Anti-Harassment

Sat, Nov 24

dbarratt committed rEGQL9a37318d08aa: Create the GraphQL extension. (authored by dbarratt).
Create the GraphQL extension.
Sat, Nov 24, 7:06 AM
dbarratt committed rEGQL5dceeda6a75d: Create the GraphQL extension. (authored by dbarratt).
Create the GraphQL extension.
Sat, Nov 24, 12:37 AM

Fri, Nov 23

dbarratt moved T204988: Add tests for NamespaceRestriction enforcement from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 23, 11:15 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt claimed T204988: Add tests for NamespaceRestriction enforcement.
Fri, Nov 23, 11:15 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt moved T204988: Add tests for NamespaceRestriction enforcement from Cards ready for development to AHT Sprint 33 on the Anti-Harassment board.
Fri, Nov 23, 11:15 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt moved T204990: Update Special:BlockList with namespace blocks from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 23, 11:13 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt added a comment to T208276: Do not indicate on Special:ListUsers if a user is partially blocked.

Do we want to do the same for Special:ActiveUsers?

Fri, Nov 23, 6:29 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
dbarratt updated the task description for T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks.
Fri, Nov 23, 4:29 AM · Patch-For-Review, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management

Thu, Nov 22

dbarratt added a comment to T210107: The Action API should allow input in JSON.

To summarize the choices (that I can think of):

  1. Make the GraphQL Server an Action API module (i.e. action=graphql) with 3 parameters. This would not break any of the spec, but would have some changes from the de facto. We could resolve T210045 to allow an in-browser IDE within the ApiSandbox and T210107 could be resolved which would bring us more inline with the de facto standards. Having the GraphQL server available at /graphql is another de facto standard, but every IDE I've seen has allowed the URL to be customized, so I wouldn't worry about that.
  2. Make the GraphQL Server a Special Page (i.e. Special:GraphQL) with a non-localized route of /graphql. This can meet all of the de facto standards. The special page could use content-negotiation to display an in-browser IDE for users who request text/html (but the default would be a JSON response). This has obvious drawbacks though (no changing format, global tokens, specifying the CORS policy, etc.)
Thu, Nov 22, 12:32 AM · MediaWiki-API
dbarratt added a comment to T210107: The Action API should allow input in JSON.

I should also mention that the variable "keys" are defined in the user's query, so they cannot be predetermined.

Thu, Nov 22, 12:10 AM · MediaWiki-API

Wed, Nov 21

dbarratt added a comment to T210107: The Action API should allow input in JSON.

Tell me more about the 'variables' field. Is it always a map of scalar values that get substituted into the query, or can it have values that are arrays of scalars, or can the values themselves be basically anything representable in JSON?

I'm trying to get an idea of the requirements so I can try to make a good recommendation as to how this would best fit into the way the API does things.

Wed, Nov 21, 10:05 PM · MediaWiki-API
dbarratt added a comment to T210107: The Action API should allow input in JSON.

I'm not too familiar with GraphQL. Ignoring details about format for a moment, what parameters would a GraphQL endpoint need as input, and what pieces of data would it output?

Glancing through https://graphql.org/, it seems like it would take one input field for the query, and outputs a blob of structured data (that could be represented in any of the API's output formats). Is that right?

Wed, Nov 21, 9:58 PM · MediaWiki-API
dbarratt removed a project from T210045: Allow extensions to specify a custom PARAM_TYPE: MediaWiki-extensions-ApiSandbox.

For some background, I was working on T209133 and I initially created a special page (and a non-localized custom route). But then I was thinking it might be better if it was a module in the action API (which would allow different return formats, etc.).

Wed, Nov 21, 9:27 PM · MediaWiki-API
dbarratt added a comment to T210107: The Action API should allow input in JSON.

You say "it would be helpful", but you don't say what it would actually help. It seems to me that it would be as likely to complicate and confuse things.

Wed, Nov 21, 9:18 PM · MediaWiki-API
dbarratt added a comment to T210107: The Action API should allow input in JSON.
Wed, Nov 21, 9:10 PM · MediaWiki-API
dbarratt created T210107: The Action API should allow input in JSON.
Wed, Nov 21, 7:29 PM · MediaWiki-API
dbarratt added a comment to T210045: Allow extensions to specify a custom PARAM_TYPE.

@Anomie yes it does, I've updated the description to be more broad in what I was trying to do. :)

Wed, Nov 21, 5:28 PM · MediaWiki-API
dbarratt renamed T210045: Allow extensions to specify a custom PARAM_TYPE from Allow extensions to modify mw.special.ApiSandbox.Util.createWidgetForParameter() to Allow extensions to specify a custom PARAM_TYPE.
Wed, Nov 21, 5:28 PM · MediaWiki-API
dbarratt created T210045: Allow extensions to specify a custom PARAM_TYPE.
Wed, Nov 21, 6:38 AM · MediaWiki-API

Tue, Nov 20

dbarratt closed T208876: TitlesMultiselectWidget does not suggest exact matches as Resolved.
Tue, Nov 20, 8:12 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
dbarratt edited projects for T209969: Tracking blocks: Log direction actions, added: Anti-Harassment; removed Anti-Harassment (AHT Sprint 33).
Tue, Nov 20, 4:38 PM · Anti-Harassment, Analytics
dbarratt triaged T209969: Tracking blocks: Log direction actions as Low priority.
Tue, Nov 20, 4:36 PM · Anti-Harassment, Analytics
dbarratt moved T201718: Tracking blocks: Log when the desktop VisualEditor + 2010 wikitext editor block notice is displayed from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Tue, Nov 20, 4:53 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 34), Performance-Team, Patch-For-Review
dbarratt closed T208806: Change the partial block log entry for 'non-editing actions' to 'specified non-editing actions' as Resolved.
Tue, Nov 20, 1:46 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-User-management

Mon, Nov 19

dbarratt closed T208472: Block::getTarget() can return a User object or a string that is an invalid user name as Resolved.
Mon, Nov 19, 11:58 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 33), TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management
dbarratt moved T208472: Block::getTarget() can return a User object or a string that is an invalid user name from Ready to Review on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 19, 11:41 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 33), TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management
dbarratt added a project to T208472: Block::getTarget() can return a User object or a string that is an invalid user name: Anti-Harassment (AHT Sprint 33).
Mon, Nov 19, 11:40 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 33), TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management
dbarratt closed T209284: Action::checkCanExecute should only block an Action if the user is sitewide blocked as Resolved.
Mon, Nov 19, 11:33 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-User-management
dbarratt closed T209284: Action::checkCanExecute should only block an Action if the user is sitewide blocked, a subtask of T208560: If a user is partially blocked they should be able to perform rollback on unrelated pages, as Resolved.
Mon, Nov 19, 11:33 PM · Anti-Harassment (AHT Sprint 33), MediaWiki-User-management
dbarratt closed T208862: Title::checkUserBlock should call User::isBlockedFrom for every action as Resolved.
Mon, Nov 19, 11:30 PM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-User-management
dbarratt closed T208862: Title::checkUserBlock should call User::isBlockedFrom for every action, a subtask of T208273: Partially blocked users should be able to rename/move pages (outside their block), as Resolved.
Mon, Nov 19, 11:30 PM · Anti-Harassment (AHT Sprint 33), MediaWiki-User-management
dbarratt moved T208876: TitlesMultiselectWidget does not suggest exact matches from Review to In progress on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 19, 7:40 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
dbarratt moved T208876: TitlesMultiselectWidget does not suggest exact matches from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 19, 6:48 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
dbarratt moved T201718: Tracking blocks: Log when the desktop VisualEditor + 2010 wikitext editor block notice is displayed from Review to In progress on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 19, 6:48 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 34), Performance-Team, Patch-For-Review

Sat, Nov 17

dbarratt committed rEGQL96afd858b1a5: Create the GraphQL extension. (authored by dbarratt).
Create the GraphQL extension.
Sat, Nov 17, 5:29 PM

Fri, Nov 16

dbarratt added a comment to T195274: Rewrite ORES "reference" UI using React.

I've been keeping jQuery out of the React components library to allow others to use it.
Given all strings can be passed in as properties it should work well with this.

Fri, Nov 16, 11:34 PM · Scoring-platform-team (Current), User-Ladsgroup, Wikimedia-Hackathon-2018, ORES
dbarratt added a comment to T201717: Tracking blocks: Log hard edits that fail via API or page rejection.

@TBolliger Is this limited to create/edit actions or should it include any action on a page that invokes a block (i.e. rollback)?

Fri, Nov 16, 10:17 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 34), Patch-For-Review
dbarratt moved T201717: Tracking blocks: Log hard edits that fail via API or page rejection from Review to In progress on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 16, 9:44 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 34), Patch-For-Review
dbarratt added a comment to T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.

The humans running the maintenance probably just missed seeing the readonly error messages for those two wikis in the middle of the foreachwiki boilerplate and success messages for the other 930 wikis.

Fri, Nov 16, 8:28 PM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt added a comment to T209003: Extensions should be able to declare how blocks should handle their rights.

David, is this aspirational or a technical requirement for extension support?

Fri, Nov 16, 8:23 PM · Anti-Harassment, MediaWiki-User-management
dbarratt added a comment to T209662: Partially blocked admins should be able to restore revisions of deleted pages.

@TBolliger is this a regression? (i.e. is this a problem on testwiki right now?)

Fri, Nov 16, 3:40 PM · MediaWiki-User-management, Anti-Harassment
dbarratt added a comment to T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.

Thanks @Marostegui!

Fri, Nov 16, 2:58 PM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt added a comment to T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.

Here is the SWAT deploy IRC log:

[23:00:04] <jouncebot>	 addshore, hashar, aude, MaxSem, twentyafterfour, RoanKattouw, Dereckson, thcipriani, Niharika, and zeljkof: #bothumor Q:How do functions break up? A:They stop calling each other. Rise for Evening SWAT (Max 6 patches) deploy. (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20181001T2300).
[23:00:05] <jouncebot>	 davidwbarratt: A patch you scheduled for Evening SWAT (Max 6 patches) is about to be deployed. Please be around during the process. Note: If you break AND fix the wikis, you will be rewarded with a sticker.
[23:00:17] <davidwbarratt>	 I'm here!
[23:02:02] <davidwbarratt>	 who is SWATing?
[23:06:18] <davidwbarratt>	 hello?
[23:08:29] <dmaza>	 hello :p
[23:10:44] <davidwbarratt>	 ping addshore, hashar, aude, MaxSem, twentyafterfour, RoanKattouw, Dereckson, thcipriani, Niharika, and zeljkof:
[23:11:00] <MaxSem>	 I'm in a meeting, sorry
[23:11:03] <twentyafterfour>	 I can swat
[23:11:06] <davidwbarratt>	 no problem
[23:11:09] <wikibugs>	 10Operations, 10ops-ulsfo, 10netops: Interface errors on cr4-ulsfo:et-0/0/1 - https://phabricator.wikimedia.org/T205937 (10ayounsi) p:05Triage>03Normal
[23:11:11] <davidwbarratt>	 twentyafterfour thanks!
[23:11:27] <davidwbarratt>	 twentyafterfour it's a SQL patch to create a table
[23:12:04] <twentyafterfour>	 have we gotten any dba review of the change? 
[23:12:17] <davidwbarratt>	 yes, it's already merged into master
[23:12:51] <davidwbarratt>	 here's the task https://phabricator.wikimedia.org/T197144 and the DBA review(s) https://phabricator.wikimedia.org/T193449
[23:12:59] <davidwbarratt>	 but it is not a "schema change"
[23:13:17] <davidwbarratt>	 https://wikitech.wikimedia.org/wiki/Schema_changes#What_is_not_a_schema_change
[23:13:30] <twentyafterfour>	 ah I see
[23:13:43] <twentyafterfour>	 ok just creating a table should be fine, indeed 
[23:14:35] <RoanKattouw>	 Looks to me like you should run foreachwiki sql.php maintenance/postgres/archives/patch-ipblocks_restrictions-table.sql  , right?
[23:14:44] <RoanKattouw>	 Uh, except without the /postgres/ bit
[23:14:51] <wikibugs>	 (03CR) 10Cwhite: [C: 032] "NOOP on existing: https://puppet-compiler.wmflabs.org/compiler1001/12705/" [puppet] - 10https://gerrit.wikimedia.org/r/463868 (https://phabricator.wikimedia.org/T202782) (owner: 10Cwhite)
[23:14:52] <davidwbarratt>	 yep, just this: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/440871/21/maintenance/archives/patch-ipblocks_restrictions-table.sql
[23:15:36] <twentyafterfour>	 ok do we need to cherry pick anything to the branch or was this already merged prior to branch cut?
[23:15:43] * twentyafterfour looks at date of merge
[23:15:54] <RoanKattouw>	 "Included in" says wmf.22 and wmf.23
[23:16:00] <davidwbarratt>	 it's already merged, it should be deployed already
[23:16:05] <twentyafterfour>	 yeah cool 
[23:16:13] <twentyafterfour>	 so just the foreachwiki should do it 
[23:16:34] <Reedy>	 gonna have to be run from a codfw mtx host though, not deploy1001
[23:16:51] <RoanKattouw>	 What is the codfw maintenance host? mwmaint2001?
[23:16:55] <Reedy>	 yeah
[23:17:06] <Reedy>	 codfw is the active, but deployment still is in eqiad
[23:17:06] <RoanKattouw>	 Also, for completeness, let me correct my mistake:  foreachwiki sql.php maintenance/archives/patch-ipblocks_restrictions-table.sql
[23:17:11] <twentyafterfour>	 not sure if I have access to that? 
[23:17:14] * twentyafterfour checks
[23:17:18] <Reedy>	 you will :)
[23:17:20] <RoanKattouw>	 OK cool. I've never been on mwmaint2001, only on mwmaint1001
[23:17:32] <Reedy>	 mwmaint2001.codfw.wmnet obvs
[23:18:12] <davidwbarratt>	 I assume that creating the tables will persist after the datacenter switch-backover ?
[23:18:21] <twentyafterfour>	 !log creating ipblocks_restrictions table (command run on mwmaint2001: foreachwiki sql.php maintenance/archives/patch-ipblocks_restrictions-table.sql)
[23:18:23] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[23:18:31] <twentyafterfour>	 davidwbarratt: it should
[23:18:42] <davidwbarratt>	 good
[23:18:48] <Reedy>	 we're still replicating across DC
[23:18:53] <davidwbarratt>	 ah
[23:18:54] <Reedy>	 just the masters are currently in codfw
[23:19:06] <Reedy>	 https://dbtree.wikimedia.org/ is a nice illustration of it
[23:19:35] <James_F>	 RoanKattouw: Welcome, newbie. ;-)
[23:19:50] <twentyafterfour>	 ok the queries are running
[23:20:00] <davidwbarratt>	 yay!
[23:20:09] <twentyafterfour>	 so far all say " Query OK, 0 row(s) affected"
[23:20:30] <Reedy>	 That's normal IIRC
[23:20:44] <twentyafterfour>	 is there an easy way to confirm that the table is created?
[23:21:01] <Reedy>	 sql aawiki
[23:21:07] <Reedy>	 explain ipblocks_restrictions;
[23:21:16] <Reedy>	 I've just confirmed it's there on the eqiad hosts
[23:21:40] <twentyafterfour>	 Cool, Thanks Reedy!
[23:21:46] <James_F>	 Table exists on codfw aawiki too.
[23:21:54] <twentyafterfour>	 still running, there are a lot of wikis ;) 
[23:21:56] <Reedy>	 James_F: I'd be amazed if they didn't :P
[23:22:03] <Reedy>	 That would be some witchcraft
[23:22:36] <twentyafterfour>	 replag == witchcraft
[23:22:48] <James_F>	 Reedy: I've seen some stuff you wouldn't believe. RepLag, C-beams glittering off the belt of Orion, etc.
[23:22:54] <James_F>	 Bah, twentyafterfour got there first.
[23:23:02] <twentyafterfour>	 hah 
[23:23:02] <Reedy>	 Are you planning on deploying code that uses that table soon after?
[23:23:30] <davidwbarratt>	 we can't until the schema change is complete (i.e. the patch that changes a column)
[23:24:00] <davidwbarratt>	 https://phabricator.wikimedia.org/T204006
[23:24:34] <Reedy>	 fair
[23:27:50] <icinga-wm>	 PROBLEM - puppet last run on wdqs1010 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[enforce-users-groups-cleanup]
[23:30:01] <davidwbarratt>	 twentyafterfour still running?
[23:30:21] <Reedy>	 probably...  over 900 wikis takes a while :)
[23:30:39] <twentyafterfour>	 davidwbarratt: yeah almost done I think 
[23:30:57] <twentyafterfour>	 at zawiki
[23:31:06] <twentyafterfour>	 and now it's done
[23:31:16] <mutante>	 herron: is the wdqs error about the new group?
[23:31:24] <twentyafterfour>	 !log finished creating database tables
[23:31:26] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[23:32:48] <wikibugs>	 (03Abandoned) 10MacFan4000: Remove MW 1.29 from ExtDist as it is now no longer supported [mediawiki-config] - 10https://gerrit.wikimedia.org/r/440745 (owner: 10MacFan4000)
[23:33:25] <mutante>	 herron: ignore it. it is definitely not. i see an unrelated issue
[23:34:05] <herron>	 mutante ok, I didn’t merge that yet fwiw
[23:34:26] <mutante>	 herron: yea, i see it. it just seemed like it because "groups-cleanup" 
[23:34:37] <davidwbarratt>	 YAY!
[23:34:46] <davidwbarratt>	 thanks twentyafterfour !
[23:34:51] <mutante>	 but the issue that somebody manually added a user or installed softare
[23:35:06] <twentyafterfour>	 davidwbarratt: You're welcome. Thanks to Reedy and RoanKattouw for helping out.
Fri, Nov 16, 2:56 PM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt added a comment to T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.

Since a table creation is not a schema change, then the folks on DBA might not be aware of this change.

Fri, Nov 16, 2:50 PM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt added a comment to T209674: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist.

The CREATE TABLE SWAT was requested by me in T204151 and put it on the schedule here:
https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=1804762&oldid=1804728
I don't recall who performed the SWAT deploy but I can dig through and find out if that's important.

Fri, Nov 16, 2:36 PM · Anti-Harassment, MediaWiki-User-management, Wikimedia-production-error, wikitech.wikimedia.org, Security
dbarratt moved T204990: Update Special:BlockList with namespace blocks from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 16, 12:54 AM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt claimed T204990: Update Special:BlockList with namespace blocks.
Fri, Nov 16, 12:54 AM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt moved T204989: Update Block APIs to list namespace blocks from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 16, 12:49 AM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management

Thu, Nov 15

dbarratt added a comment to T209133: Create a GraphQL MediaWiki extension and delegate schema & queries to the relevant sites.

Repository created: https://gerrit.wikimedia.org/g/mediawiki/extensions/GraphQL

Thu, Nov 15, 10:11 PM · Patch-For-Review, GraphQL
dbarratt moved T204989: Update Block APIs to list namespace blocks from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Thu, Nov 15, 10:09 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt edited projects for T204989: Update Block APIs to list namespace blocks, added: Anti-Harassment (AHT Sprint 33); removed Anti-Harassment.
Thu, Nov 15, 9:03 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dbarratt closed T208621: AbuseFilter Log and Edit/Create is inaccessible while partially blocked as Resolved.

Thanks @Daimona!

Thu, Nov 15, 6:12 PM · Anti-Harassment (AHT Sprint 33), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), AbuseFilter, MediaWiki-User-management