Page MenuHomePhabricator

dbarratt (David Barratt)
Software Engineer, Anti-Harassment Tools

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 30 2017, 9:17 PM (142 w, 4 d)
Availability
Available
IRC Nick
davidwbarratt
LDAP User
Dbarratt
MediaWiki User
DBarratt (WMF) [ Global Accounts ]

Recent Activity

Yesterday

dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

I forgot to add the ANALYZE results of the proposed query (without inner limit):

idselect_typetabletypepossible_keyskeykey_lenrefrowsr_rowsfilteredr_filteredExtra
1PRIMARY<derived2>ALLNULLNULLNULLNULL3953710601.00100.00100.00Using temporary; Using filesort
2DERIVEDcu_changesrangecuc_user_ip_timecuc_user_ip_time4NULL545544.00100.0098.35Using index condition; Using where
3UNIONcu_changesrefcuc_ip_hex_timecuc_ip_hex_time258const1949610596.00100.0099.92Using index condition; Using where
4UNIONcu_changesrangecuc_ip_hex_timecuc_ip_hex_time258NULL1949610596.00100.0099.92Using index condition; Using where
NULLUNION RESULT<union2,3,4>ALLNULLNULLNULLNULLNULL10601.00NULLNULL
Sat, Feb 22, 5:27 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

I did a bit of testing on the proposed query changes (the first row in the table above), and it does perform significantly better.

Sat, Feb 22, 5:15 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T245893: Determine whether to have browser autocomplete for Special:Investigate reason.

I don't see a reason to disable the autocomplete on that field.

Sat, Feb 22, 4:20 PM · Anti-Harassment
dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

The schema in T245499#5907670 could be simplified a bit more by removing cua_ip (and use cua_ip_hex instead). I can't see a reason why that would be needed?

Sat, Feb 22, 4:16 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

Only solution that gets all the data. (Data may be paginated, but it will all be there.)

Sat, Feb 22, 4:09 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T237299: CU 2.0: Sticky highlighting in Preliminary check and Compare tabs.

@Tchanders To confirm - sticky highlights persist across paginated tabs right?

Sat, Feb 22, 3:06 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Fri, Feb 21

dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

Perhaps an even better way to do this is to create a new cu_changes table instead of altering the existing one, something like:

CREATE TABLE /*_*/cu_revision (
  -- CheckUser Actor ID
  cua_id BIGINT NOT NULL,
Fri, Feb 21, 7:10 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

Another proposal is to create another table, something like this:

CREATE TABLE /*_*/cu_actor (
  -- Primary key
  cua_id bigint unsigned NOT NULL PRIMARY KEY AUTO_INCREMENT
Fri, Feb 21, 6:30 PM · Performance Issue, CheckUser, Anti-Harassment

Thu, Feb 20

dbarratt added a comment to T245662: CU 2.0: Logging for Special:Investigate.

I kind of like the idea of using the existing logging table because then as the user adds additional targets during the course of their investigation, those targets can be added as individual log entries, rather than modifying the existing log entry.

Thu, Feb 20, 7:41 PM · CheckUser, Anti-Harassment
dbarratt updated subscribers of T245662: CU 2.0: Logging for Special:Investigate.

@Tchanders pointed out that there is an existing "type" field on the cu_log table:

-- String indicating the type of query, may be:
-- "useredits", "userips", "ipedits", "ipusers", "ipedits-xff", "ipusers-xff"
cul_type varbinary(30) not null,
Thu, Feb 20, 7:12 PM · CheckUser, Anti-Harassment
dbarratt claimed T238809: CU 2.0: Filters in the Compare tab.
Thu, Feb 20, 3:22 PM · Anti-Harassment (The Letter Song), CheckUser
dbarratt moved T238809: CU 2.0: Filters in the Compare tab from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Thu, Feb 20, 3:21 PM · Anti-Harassment (The Letter Song), CheckUser

Wed, Feb 19

dbarratt moved T233441: Cookie blocks apply regardless of ipblock-exempt right from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Wed, Feb 19, 11:25 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song), MediaWiki-User-management
dbarratt moved T244157: Special:BlockList paginates on a non-unique column from Ready to QA/Testing on the Anti-Harassment (The Letter Song) board.
Wed, Feb 19, 10:13 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
dbarratt edited projects for T244157: Special:BlockList paginates on a non-unique column, added: Anti-Harassment (The Letter Song); removed Anti-Harassment.
Wed, Feb 19, 10:13 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
dbarratt added a comment to T245662: CU 2.0: Logging for Special:Investigate.

Maybe we could "tag" the logs from the new tool and keep them in the same DB, he said without looking at the schema.

Wed, Feb 19, 9:04 PM · CheckUser, Anti-Harassment
dbarratt added a comment to T245662: CU 2.0: Logging for Special:Investigate.

There will be a new special page for the log, associated with Special:Investigate so we can keep track of the lookups happening through the new page.

Wed, Feb 19, 8:45 PM · CheckUser, Anti-Harassment
dbarratt added a comment to T245662: CU 2.0: Logging for Special:Investigate.

@Niharika will this be a separate log or will we use the existing log?

Wed, Feb 19, 8:30 PM · CheckUser, Anti-Harassment
dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

As mentioned in the task description, indexing doesn't solve the problem of setting a limit on the number of rows being accessed.

Wed, Feb 19, 4:27 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

We should probably keep in mind the schema changes that are happening in T233004. Not necessarily a blocker though.

Wed, Feb 19, 3:09 PM · Performance Issue, CheckUser, Anti-Harassment

Tue, Feb 18

dbarratt added a comment to T245499: Improve performance of Compare query for Special:Investigate.

I ran the query above on Wikidata with my two user accounts, my home IP address, and an 8 IP range around my IP address

7 rows in set (4 min 16.03 sec)

clearly what we have isn't going to work.

Tue, Feb 18, 9:35 PM · Performance Issue, CheckUser, Anti-Harassment
dbarratt added a comment to T244157: Special:BlockList paginates on a non-unique column.

If we were certain that timestamp always increased with ID, we could even paginate on the single ipb_id column. It seems this is not the case (see DatabaseBlock::updateTimestamp), so we can paginate on timestamp and ID together.

Yeah the timestamp is non-unique as well, so you could (in theory I suppose) have two different blocks with the same timestamp.

Tue, Feb 18, 2:25 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
dbarratt added a comment to T244157: Special:BlockList paginates on a non-unique column.

If we were certain that timestamp always increased with ID, we could even paginate on the single ipb_id column. It seems this is not the case (see DatabaseBlock::updateTimestamp), so we can paginate on timestamp and ID together.

Tue, Feb 18, 2:23 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
dbarratt added a comment to T245181: Improve test coverage for Special:Investigate.

@dbarratt We should discuss that as a team. Does it impact on whether we do this task though?

Tue, Feb 18, 2:21 PM · Anti-Harassment (The Letter Song), CheckUser

Mon, Feb 17

dbarratt moved T239680: CU 2.0: Persist the form state from QA/Testing to Review on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 11:25 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt moved T240366: CU 2.0: Figure out how to do tabs in a special page from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 11:24 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), Spike, CheckUser
dbarratt moved T243631: Add links to preliminary check results table from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 11:16 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), CheckUser
dbarratt moved T244517: Use IndexPager's multi-column pagination for preliminary check from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 11:08 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song)
dbarratt added a comment to T244579: MediaWiki does not support consistent pagination on non-unique fields.

explore the method that does not involve using OFFSET with GROUP BY for this product.

Mon, Feb 17, 10:05 PM · MediaWiki-General, TechCom
dbarratt added a comment to T245181: Improve test coverage for Special:Investigate.

A long time ago (perhaps too long ago!) we talked about making code coverage an implied part of Anti-Harassment tasks acceptance criteria, did we abandon that?

Mon, Feb 17, 7:32 PM · Anti-Harassment (The Letter Song), CheckUser
dbarratt added a comment to T240000: Config on the RequestContext may not be the same as the main config.

@Catrope That totally makes sense to me, it would be great if we picked a direction either way.

Mon, Feb 17, 7:24 PM · TechCom, Anti-Harassment, MediaWiki-General
dbarratt added a comment to T245167: Re-purposing MediaWiki-Docker and friends.

That'd be fine by me if that label works for you; it's a good name for it.

Mon, Feb 17, 7:04 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release Pipeline, Project-Admins, MediaWiki-Containers, Docker-Hub-MediaWiki
dbarratt added a comment to T244157: Special:BlockList paginates on a non-unique column.

@Tchanders now that T244492 has been resolved I imagine this can be done?

Mon, Feb 17, 6:46 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
dbarratt moved T244492: Support pagination on multiple columns in IndexPager from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 6:44 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Anti-Harassment (The Letter Song)
dbarratt closed T244026: Incomplete and bad instructions regarding volumes in docker container as Invalid.

@Qwertysdf There are a lot of different ways in which you might want to setup MediaWiki using the docker image. Forcing a specific setup by specifying the VOLUMES might be helpful to some use-cases, but is a detriment to others. For instance, I personally might mount the entire /var/www/html directory for development as a volume, but on my server, I might create a new image that extends this one and copies the extensions I want at build time and does not mount anything. In either instance, I don't want the VOLUMES being declared/forced. If docker provided a way to remove the volumes, I think it would be fine to define the most popular use case in the Dockerfile, but that isn't the case. If you want the VOLUMES to be declared, I would suggest extending the image with the FROM directive.

Mon, Feb 17, 6:37 PM · MediaWiki-Documentation, Docker-Hub-MediaWiki
dbarratt moved T239716: CU 2.0: Use a factory to create the pager from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 5:39 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), CheckUser, Anti-Harassment (The Letter Song)
dbarratt moved T239716: CU 2.0: Use a factory to create the pager from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Mon, Feb 17, 4:56 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), CheckUser, Anti-Harassment (The Letter Song)

Thu, Feb 13

dbarratt added a comment to T242945: CheckUser 2.0: Provide a way to start a new investigation.

@dbarratt We had a conversation about this in a team meeting but I don't remember the outcome - will the user be able to run multiple investigations at once or will they not? I am perfectly happy either way but that will influence my choice of the mock we go with.

Thu, Feb 13, 8:00 PM · Anti-Harassment, CheckUser
dbarratt updated the task description for T237300: CU 2.0: Sorting in the Compare tab.
Thu, Feb 13, 6:20 PM · Anti-Harassment, CheckUser
dbarratt updated the task description for T237300: CU 2.0: Sorting in the Compare tab.
Thu, Feb 13, 6:20 PM · Anti-Harassment, CheckUser
dbarratt added a comment to T244579: MediaWiki does not support consistent pagination on non-unique fields.

I see T244579 is done: the change is merged so it presumably should be closed. Does that answer all use cases in T236225, or is there something remaining that still needs OFFSET?

Thu, Feb 13, 6:19 PM · MediaWiki-General, TechCom
dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Thu, Feb 13, 6:13 PM · MediaWiki-General, TechCom
dbarratt added a comment to T245167: Re-purposing MediaWiki-Docker and friends.

Perhaps move the existing tasks to a new tag like Docker-Hub-MediaWiki since it's hosted at https://hub.docker.com/_/mediawiki ?

Thu, Feb 13, 6:12 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release Pipeline, Project-Admins, MediaWiki-Containers, Docker-Hub-MediaWiki
dbarratt added a comment to T239680: CU 2.0: Persist the form state.

@dbarratt (After cherry picking your latest patch) On the preliminary check table, when I attempt to go to a previous or next page I get:

Thu, Feb 13, 5:25 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt added a comment to T245084: Improve layout of Special:Investigate tabs.

The style fixes in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/571794 should fix this problem (I think).

Thu, Feb 13, 12:56 AM · CheckUser, Anti-Harassment
dbarratt added a comment to T245084: Improve layout of Special:Investigate tabs.

I can wrap the elements being added to the content panel in a TabPanelLayout but in my testing that didn't make a difference to the spacing (but maybe I did something wrong).

Thu, Feb 13, 12:54 AM · CheckUser, Anti-Harassment
dbarratt added a comment to T245084: Improve layout of Special:Investigate tabs.

In T240366 I was forced to bypass the IndexLayout::addTabPanels() method because it is hard-coded to use a <span> instead of an <a> and from my testing the label would not allow an unescaped string of HTML.

Thu, Feb 13, 12:51 AM · CheckUser, Anti-Harassment

Wed, Feb 12

dbarratt moved T231577: Deploy Special:Mute features from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Wed, Feb 12, 11:47 PM · Anti-Harassment (The Letter Song), Epic
dbarratt moved T240366: CU 2.0: Figure out how to do tabs in a special page from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Wed, Feb 12, 6:36 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), Spike, CheckUser
dbarratt closed T244941: IndexPager: Cast properties passed to implode to arrays as Resolved.
Wed, Feb 12, 4:22 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Anti-Harassment
dbarratt added a comment to T244937: [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed.

and @Catrope and @Jdforrester-WMF !

Wed, Feb 12, 4:06 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Anti-Harassment, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))
dbarratt closed T244937: [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed as Resolved.

Boldly closing as it appears to have been merged... thanks @Tchanders !

Wed, Feb 12, 4:05 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Anti-Harassment, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))
dbarratt closed T244937: [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed, a subtask of T233867: 1.35.0-wmf.19 deployment blockers, as Resolved.
Wed, Feb 12, 4:05 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments

Tue, Feb 11

dbarratt added a comment to T239680: CU 2.0: Persist the form state.

Updated example (removed the iv): https://jwt.io/?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1ODE0NzczMjgsImRhdGEiOiJ1NFFpaWdubkM1NTVCUjdNRE42WEtjNzZVVlp6cWt2WE8veXZHQTMvNi9EVGlBPT0ifQ.MjLKVAWEffgQ1qm4IFGnQOvp705hXDjZt2mYsXX32vk

Tue, Feb 11, 3:24 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Mon, Feb 10

dbarratt added a comment to T239680: CU 2.0: Persist the form state.

@dbarratt - One comment for you on the patch. Sorry I don't have any good suggestions :/ Also, I'm curious how large the data from these CU queries can get on-wiki. Playing around with str_repeat() a bit, I can pretty quickly generate some massive base64 strings with both aes-256-ctr and aes-256-cbc, which then gets base64-encoded again as part of the token, I believe. I'm not sure if all web browsers will be fine with passing potentially massive strings around as a query parameter. Have you noticed any issues during your testing?

Mon, Feb 10, 10:54 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt added a comment to T239680: CU 2.0: Persist the form state.

Here's an example with the changes:
https://jwt.io/?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1ODE0NTEwOTgsIml2IjoiSXFjNU1HQ051Q1Z2cHlcL1B0dlwvVDNRPT0iLCJkYXRhIjoiOHk1bWk4Qm94MFJXMzZ3M2ZcLzhVMlV1T3dKdCtXSjFFb1hzQ21KWWRRS1ZiT1E9PSJ9.w0SgWkClfhAdMBvLKb7jhpvDPk_kqFMZDAXfLDy0fbI

Mon, Feb 10, 8:19 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt added a comment to T239680: CU 2.0: Persist the form state.

@sbassett FYI we've made some improvements to the way the token is generated https://gerrit.wikimedia.org/r/571337

Mon, Feb 10, 8:06 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Fri, Feb 7

dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 6:15 PM · MediaWiki-General, TechCom
dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 6:03 PM · MediaWiki-General, TechCom
dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 6:03 PM · MediaWiki-General, TechCom
dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 5:56 PM · MediaWiki-General, TechCom
dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 3:32 PM · MediaWiki-General, TechCom
dbarratt updated the task description for T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 3:27 PM · MediaWiki-General, TechCom
dbarratt created T244579: MediaWiki does not support consistent pagination on non-unique fields.
Fri, Feb 7, 3:25 PM · MediaWiki-General, TechCom

Thu, Feb 6

dbarratt renamed T240366: CU 2.0: Figure out how to do tabs in a special page from [Spike: 4 hours] CU 2.0: Figure out how to do tabs in a special page to CU 2.0: Figure out how to do tabs in a special page.
Thu, Feb 6, 9:14 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), Spike, CheckUser

Wed, Feb 5

dbarratt claimed T240366: CU 2.0: Figure out how to do tabs in a special page.
Wed, Feb 5, 5:00 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), Spike, CheckUser
dbarratt moved T240366: CU 2.0: Figure out how to do tabs in a special page from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Wed, Feb 5, 5:00 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Anti-Harassment (The Letter Song), Spike, CheckUser

Tue, Feb 4

Vedmaka awarded T167547: Replace Gerrit & GitHub with GitLab a Like token.
Tue, Feb 4, 10:29 PM · Wikimedia-GitHub, Gerrit, TechCom-RFC

Jan 24 2020

dbarratt added a comment to T243582: Fatal exception of type "TypeError" when submitting IP address in Special:Investigate when CentralAuth is disabled.

This error only occurs if CentralAuth is disabled.

Jan 24 2020, 3:21 PM · CheckUser, Anti-Harassment
dbarratt moved T243075: TagMultiselectWidget clears input before adding tag, causing validation failure in downstream widgets from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Jan 24 2020, 3:08 AM · OOUI (OOUI-0.36.3), Anti-Harassment (The Letter Song), CheckUser
dbarratt moved T238714: CU 2.0: Fetch information to be displayed in Compare tab from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Jan 24 2020, 3:07 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dbarratt moved T243077: TagMultiselectWidget performs unnecessary validity check in change handler from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Jan 24 2020, 3:06 AM · OOUI (OOUI-0.36.3), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser
dbarratt moved T238318: Let UsersMultiselectWidget disallow arbitrary input from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Jan 24 2020, 3:05 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Anti-Harassment (The Letter Song), CheckUser

Jan 23 2020

dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

From the Vue docs

When using in-DOM templates or in-JavaScript template strings, the template-to-render-function compilation is performed on the fly. This is usually fast enough in most cases, but is best avoided if your application is performance-sensitive.

Jan 23 2020, 7:58 PM · Security-Team, TechCom-RFC
dbarratt moved T239680: CU 2.0: Persist the form state from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jan 23 2020, 7:29 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

@dbarratt regarding need for a build step: there's some discussion of this in the original RFC; it's true that React can be used sans build-step with the CreateElement API.

Jan 23 2020, 5:57 PM · Security-Team, TechCom-RFC
dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.
  • It will be much easier to integrate Vue into the Mediawiki tech stack as it presently exists because it doesn't require a build step.
Jan 23 2020, 4:07 PM · Security-Team, TechCom-RFC
dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I don't believe anyone has said any of these frameworks are the "best in the world", so this analogy probably doesn't make sense.

Jan 23 2020, 2:33 PM · Security-Team, TechCom-RFC

Jan 22 2020

dbarratt moved T239716: CU 2.0: Use a factory to create the pager from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jan 22 2020, 6:25 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), CheckUser, Anti-Harassment (The Letter Song)
dbarratt moved T239680: CU 2.0: Persist the form state from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Jan 22 2020, 6:25 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt moved T239680: CU 2.0: Persist the form state from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jan 22 2020, 4:15 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Jan 21 2020

dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

[citation needed]
(An example, yahoo being the most popular search engine back in early days)

Jan 21 2020, 10:29 PM · Security-Team, TechCom-RFC

Jan 17 2020

dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Indeed, we can cite companies using either framework all day. I assume the underlying point of these examples is that React is more popular than Vue. And yes this is a fact. But is being most popular an argument in favor of choosing React for MW? If yes, why? What does the most popular framework has that Vue doesn't provide?

Jan 17 2020, 4:37 AM · Security-Team, TechCom-RFC

Jan 16 2020

dbarratt moved T239680: CU 2.0: Persist the form state from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Jan 16 2020, 2:43 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt added a comment to T239680: CU 2.0: Persist the form state.

I've updated the JWT's payload, which now looks like this:

{
  "iss": "local",
  "sub": "Jim Gordon",
  "exp": 1579233518,
  "data": "u4QjmB7yHcgwfAbdQf+dMImkUTA4jQL9dMmkBQey2K8="
}
Jan 16 2020, 1:56 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt moved T239680: CU 2.0: Persist the form state from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jan 16 2020, 5:28 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
dbarratt moved T239716: CU 2.0: Use a factory to create the pager from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Jan 16 2020, 5:28 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), CheckUser, Anti-Harassment (The Letter Song)
dbarratt added a parent task for T237034: CheckUser 2.0: Input form: T242945: CheckUser 2.0: Provide a way to start a new investigation.
Jan 16 2020, 5:14 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), CheckUser
dbarratt added a subtask for T242945: CheckUser 2.0: Provide a way to start a new investigation: T237034: CheckUser 2.0: Input form.
Jan 16 2020, 5:14 AM · Anti-Harassment, CheckUser
dbarratt removed a subtask for T237034: CheckUser 2.0: Input form: T242945: CheckUser 2.0: Provide a way to start a new investigation.
Jan 16 2020, 5:14 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), CheckUser
dbarratt removed a parent task for T242945: CheckUser 2.0: Provide a way to start a new investigation: T237034: CheckUser 2.0: Input form.
Jan 16 2020, 5:14 AM · Anti-Harassment, CheckUser
dbarratt created T242945: CheckUser 2.0: Provide a way to start a new investigation.
Jan 16 2020, 5:14 AM · Anti-Harassment, CheckUser

Jan 15 2020

dbarratt updated subscribers of T242793: Add support for private wikis to pageviews API.
Jan 15 2020, 7:54 PM · Pageviews-API, Analytics, Tool-Pageviews

Jan 14 2020

dbarratt added a comment to T242793: Add support for private wikis to pageviews API.

Are we okay with the idea of stuff running in labs accessing data from private wikis via OAuth?

Jan 14 2020, 9:09 PM · Pageviews-API, Analytics, Tool-Pageviews
dbarratt created T242793: Add support for private wikis to pageviews API.
Jan 14 2020, 9:00 PM · Pageviews-API, Analytics, Tool-Pageviews
dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

@Tonina_Zhelyazkova_WMDE my point is that it doesn't mitigate uncertainty, the BDFL could change the direction of Vue just as easily as a public corporation could (I would argue even easier because he has little risk involved in changing, where Facebook has a lot of risk). The reality is, is that the point being made (about mitigating uncertainty) is a business decision, not a technical one, and I don't think it takes all of the factors into account.

Jan 14 2020, 5:20 PM · Security-Team, TechCom-RFC
dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I forgot to mention that both WordPress (as of version 5.0) and Drupal (future) use React. I think it might be wise to consult with these two projects and see why they chose React over Vue.

Jan 14 2020, 2:54 AM · Security-Team, TechCom-RFC
dbarratt added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Overall I think this is awesome. I think it's an overdue change. 👏 Thanks for all of your hard work. 😃

Jan 14 2020, 2:27 AM · Security-Team, TechCom-RFC

Jan 13 2020

dbarratt added a comment to T239680: CU 2.0: Persist the form state.

@dbarratt Can you elaborate a bit on what the user-facing impact of such an expiry would be?

Jan 13 2020, 10:39 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Jan 10 2020

dbarratt added a comment to T239680: CU 2.0: Persist the form state.

errrrr... to further clarify, we like #2 as a solution over #3 because it allows us a place to put things like filters that are not necessarily in the log itself, but could reveal information. For instance, if a CheckUser filters by a User Agent, on its own, that's not PII, but if you knew what user they were investigating at the time of the request, you could pretty easily put two and two together. These filters aren't currently recorded in the CheckUserLog. However, again, if someone has checkuser permission, they could repeat the investigation and they would have access to all of the data that was encrypted in the token in the first place.

Jan 10 2020, 11:11 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)