Page MenuHomePhabricator

dbarratt (David Barratt)
Software Engineer, Anti-Harassment Tools

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 30 2017, 9:17 PM (107 w, 7 h)
Availability
Available
IRC Nick
davidwbarratt
LDAP User
Dbarratt
MediaWiki User
DBarratt (WMF) [ Global Accounts ]

Recent Activity

Yesterday

dbarratt changed the edit policy for T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.
Tue, Jun 18, 4:17 PM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt claimed T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.
Tue, Jun 18, 4:16 PM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt moved T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does from Ready to In Progress on the Anti-Harassment (Lāmed - ל) board.
Tue, Jun 18, 4:16 PM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt moved T225675: Add OAuth to Citation bot from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Tue, Jun 18, 4:12 PM · Anti-Harassment (Lāmed - ל)
dbarratt moved T225748: Fix block message for CompositeBlocks from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Tue, Jun 18, 4:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
dbarratt assigned T225748: Fix block message for CompositeBlocks to Tchanders.
Tue, Jun 18, 4:11 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
dbarratt closed T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures as Resolved.
Tue, Jun 18, 4:11 PM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools
dbarratt closed T225141: Move cookie-related logic from User and Block to BlockManager as Resolved.
Tue, Jun 18, 4:11 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
dbarratt closed T225141: Move cookie-related logic from User and Block to BlockManager, a subtask of T225011: Clean up code related to blocking, as Resolved.
Tue, Jun 18, 4:11 PM · MediaWiki-User-management
dbarratt closed T225141: Move cookie-related logic from User and Block to BlockManager, a subtask of T225470: Move cookie block methods into a new BlockCookieService, as Resolved.
Tue, Jun 18, 4:11 PM · MediaWiki-User-management
dbarratt closed T206163: Restrictions of overlapping blocks should be merged on enforcement as Resolved.
Tue, Jun 18, 4:11 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dbarratt closed T206163: Restrictions of overlapping blocks should be merged on enforcement, a subtask of T212326: Overlapping blocks may display incorrect block notice, as Resolved.
Tue, Jun 18, 4:11 PM · Anti-Harassment, MediaWiki-User-management
dbarratt closed T206163: Restrictions of overlapping blocks should be merged on enforcement, a subtask of T213752: Check with the performance team about any potential performance impact of merging overlapping blocks, as Resolved.
Tue, Jun 18, 4:11 PM · Anti-Harassment, MediaWiki-User-management
dbarratt changed the visibility for T225675: Add OAuth to Citation bot.
Tue, Jun 18, 1:32 PM · Anti-Harassment (Lāmed - ל)

Mon, Jun 17

dbarratt renamed T225975: Dynamically update an OOUI element's config after construction from Create a method to update an OOUI Element's config to Dynamically update an OOUI element's config after construction.
Mon, Jun 17, 10:30 PM · OOUI
dbarratt created T225975: Dynamically update an OOUI element's config after construction.
Mon, Jun 17, 10:30 PM · OOUI
dbarratt added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

You can see an example of not knowing in MediaWiki by blocking a test user from a namespace (say MediaWiki) and then attempting to create a new page in that namespace.

Mon, Jun 17, 10:09 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata
dbarratt added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

This is rather lots of work, SpecialWikibasePage is not the right place to keep the list, Making it per special page also is complex, like Special:SetLabel can be used on property and item and if the person is blocked on item namespace, there's no way to make sure it's applied until the user actually tries it (in which EntityStore should handle it properly using PermissionManager), so maybe we should just drop it? I would prefer if the special page still checks for site-wide bans.

Mon, Jun 17, 10:07 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata
dbarratt added a comment to T225675: Add OAuth to Citation bot.

This appears to work now!
https://tools.wmflabs.org/citations/

Mon, Jun 17, 7:37 PM · Anti-Harassment (Lāmed - ל)
dbarratt added a comment to T225675: Add OAuth to Citation bot.

There is a problem with the protocol in the redirect, here is a PR to fix the problem: https://github.com/ms609/citation-bot/pull/1794

Mon, Jun 17, 6:24 PM · Anti-Harassment (Lāmed - ל)
dbarratt added a comment to T225675: Add OAuth to Citation bot.

The bot should work as soon as this consumer is approved:
https://meta.wikimedia.org/wiki/Special:OAuthListConsumers/view/7daa1b8fcc04fb584da0a76baf115f5c

Mon, Jun 17, 5:38 PM · Anti-Harassment (Lāmed - ל)
dbarratt added a comment to T225872: not possible to set email when email blocked.

I think this has to do with the confirmation email that is sent when you change your email. I suppose someone could use the conformation email to harass you, though if the other person already has your email address, there's nothing stoping them from using a bazillion other systems to send you an email.

Mon, Jun 17, 5:25 AM · Anti-Harassment, MediaWiki-Email, MediaWiki-User-management

Sat, Jun 15

dbarratt updated the task description for T225854: Using append() loses focus of the active element..
Sat, Jun 15, 2:54 PM · OOUI
dbarratt updated the task description for T225854: Using append() loses focus of the active element..
Sat, Jun 15, 2:40 PM · OOUI
dbarratt renamed T225854: Using append() loses focus of the active element. from Using $.append() loses focus of the active element. to Using append() loses focus of the active element..
Sat, Jun 15, 4:48 AM · OOUI
dbarratt created T225854: Using append() loses focus of the active element..
Sat, Jun 15, 4:16 AM · OOUI
dbarratt added a comment to T225675: Add OAuth to Citation bot.

@dbarratt - When I try to submit the form on the web interface, I get "Error authenticating. Resetting. Please try again." Is that related to the callback issue?

Sat, Jun 15, 3:24 AM · Anti-Harassment (Lāmed - ל)
dbarratt added a comment to T225675: Add OAuth to Citation bot.

It looks like the callback url is wrong:
https://github.com/ms609/citation-bot/issues/1767#issuecomment-502329568

Sat, Jun 15, 3:08 AM · Anti-Harassment (Lāmed - ל)
dbarratt added a comment to T225675: Add OAuth to Citation bot.

The changes were merged and deployed by the maintainers: https://tools.wmflabs.org/citations/

Sat, Jun 15, 3:01 AM · Anti-Harassment (Lāmed - ל)
dbarratt moved T225675: Add OAuth to Citation bot from In Progress to Review on the Anti-Harassment (Lāmed - ל) board.

ok, I've made the small UX change. After you fill out the form (or use the gadget) it will ask you to authenticate, then it will redirect you back to your original request.

Sat, Jun 15, 1:13 AM · Anti-Harassment (Lāmed - ל)

Fri, Jun 14

dbarratt added a comment to T225675: Add OAuth to Citation bot.

I created a new PR ontop of the existing one:
https://github.com/ms609/citation-bot/pull/1780

Fri, Jun 14, 11:35 PM · Anti-Harassment (Lāmed - ל)
dbarratt updated subscribers of T126257: The API should not require CSRF tokens for an OAuth request.

@EvanProdromou ran into this one again today. :)

Fri, Jun 14, 6:28 PM · MediaWiki-extensions-OAuth, MediaWiki-API
dbarratt updated subscribers of T170438: Edit token should not be required when an Authorization (OAuth) header is present.
Fri, Jun 14, 6:27 PM · MediaWiki-extensions-OAuth, MediaWiki-API

Thu, Jun 13

dbarratt added a comment to T225675: Add OAuth to Citation bot.

@kaldari thanks!

Thu, Jun 13, 3:56 PM · Anti-Harassment (Lāmed - ל)
dbarratt moved T225675: Add OAuth to Citation bot from Ready to In Progress on the Anti-Harassment (Lāmed - ל) board.
Thu, Jun 13, 2:37 PM · Anti-Harassment (Lāmed - ל)
dbarratt claimed T225675: Add OAuth to Citation bot.
Thu, Jun 13, 2:37 PM · Anti-Harassment (Lāmed - ל)
dbarratt placed T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does up for grabs.
Thu, Jun 13, 2:36 PM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt moved T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does from In Progress to Ready on the Anti-Harassment (Lāmed - ל) board.
Thu, Jun 13, 2:36 PM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management

Wed, Jun 12

dbarratt closed T225599: Hidden Beacon pixel in Toolforge as Invalid.
Wed, Jun 12, 3:52 PM · Privacy, InteractionTimeline
dbarratt changed the visibility for T225599: Hidden Beacon pixel in Toolforge .
Wed, Jun 12, 2:32 PM · Privacy, InteractionTimeline
Restricted Application added a project to T225599: Hidden Beacon pixel in Toolforge : Security.

Matomo is an open source analytics platform. The foundation hosts an instance of this software at piwik.wikimedia.org. Access to this instance is restricted. This software is used to collect analytics data on several small tools and projects to better inform our decision making. The data is collected, retained, and deleted in accordance with our Privacy Policy.

Wed, Jun 12, 2:32 PM · Privacy, InteractionTimeline
dbarratt updated the task description for T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.
Wed, Jun 12, 12:22 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata
dbarratt moved T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities from Blocked / Waiting / External to Needs Work on the Wikidata-Campsite board.

> So I guess we use BlockManager to get the blocks of a user?

Wed, Jun 12, 12:22 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata

Tue, Jun 11

dbarratt added a comment to T173145: Global users should be Wikibase items on Meta.

I suppose now that we have MCR this could be rephrased as: "Adding structured data to global user pages" much like StructuredDataOnCommons adds structured data to global files.

Tue, Jun 11, 6:12 PM · Wikidata
dbarratt added a comment to T221177: REST route handler extension interface RFC.

So are we going to implement PSR-7 properly? If so, can the task description be updated? If not, could it be explained why we wont be?

Tue, Jun 11, 6:03 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)

Mon, Jun 10

dbarratt moved T225470: Move cookie block methods into a new BlockCookieService from Backlog to User blocking on the MediaWiki-User-management board.
Mon, Jun 10, 10:25 PM · MediaWiki-User-management
dbarratt added a subtask for T225470: Move cookie block methods into a new BlockCookieService: T225141: Move cookie-related logic from User and Block to BlockManager.
Mon, Jun 10, 10:21 PM · MediaWiki-User-management
dbarratt added a parent task for T225141: Move cookie-related logic from User and Block to BlockManager: T225470: Move cookie block methods into a new BlockCookieService.
Mon, Jun 10, 10:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
dbarratt created T225470: Move cookie block methods into a new BlockCookieService.
Mon, Jun 10, 10:20 PM · MediaWiki-User-management

Thu, Jun 6

dbarratt added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

I don't have a preference. :)

Thu, Jun 6, 2:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management

Wed, Jun 5

dbarratt added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

@Mooeypoo @dmaza @dbarratt As discussed, MultipleBlock might be too easily confused with the concept of storing multiple blocks against exactly the same target; whereas this work is about enforcing (but not storing) multiple blocks against different targets that all apply to a given user.

Wed, Jun 5, 8:53 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dbarratt moved T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures from Done to QA/Testing on the Anti-Harassment (Kaf - כ) board.
Wed, Jun 5, 6:07 PM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools

Tue, Jun 4

dbarratt moved T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures from QA/Testing to Done on the Anti-Harassment (Kaf - כ) board.
Tue, Jun 4, 10:15 PM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools
dbarratt added a comment to T221177: REST route handler extension interface RFC.

@tstarling have all of your concerns with PSR-7 been resolved? If so, can we move forward with a proper implementation?

Tue, Jun 4, 1:54 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt committed rWTDTed7842be91d0: T213490 Fix timezone of time picker (authored by dbarratt).
T213490 Fix timezone of time picker
Tue, Jun 4, 12:54 AM
dbarratt moved T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does from Ready to In Progress on the Anti-Harassment (Kaf - כ) board.
Tue, Jun 4, 12:01 AM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt claimed T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.
Tue, Jun 4, 12:01 AM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt moved T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures from In Progress to Review on the Anti-Harassment (Kaf - כ) board.

https://github.com/wikimedia/takedown-tools/pull/18

Tue, Jun 4, 12:00 AM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools

Mon, Jun 3

dbarratt added a comment to T222170: InvalidArgumentException from SpecialBlock.php: "$comment can not be null".

We could display an error message, but if we do that then we should try to be consistent across all forms, ie always be prepared to handle submission of forms that haven't loaded properly.

Mon, Jun 3, 9:46 PM · Anti-Harassment, MediaWiki-User-management, MediaWiki-Comment-backend, Wikimedia-production-error, Chinese-Sites
dbarratt added a comment to T221177: REST route handler extension interface RFC.

OTOH, a real implementation would likely have more data in the object that would have to be copied.

Mon, Jun 3, 4:43 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt added a comment to T221177: REST route handler extension interface RFC.

To put this another way, you have to do this operation at least 18,867 times in order to see a difference of 1 millisecond.

Mon, Jun 3, 4:08 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt added a comment to T221177: REST route handler extension interface RFC.

So we're talking about a difference of (0.83 / 1e7) - (0.30 / 1e7) = ~0.000000053 seconds (if my math is correct). Seems like a micro-optimization at best.

Mon, Jun 3, 3:46 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt added a comment to T221177: REST route handler extension interface RFC.

It appears (from what I can tell) that PHP (as of version 7?) implements a copy-on-write strategy for cloning objects. If this is the case, then the performance concerns with implementing PSR-7 do not appear to be justified.

Mon, Jun 3, 2:47 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)

Fri, May 31

dbarratt added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

@dbarratt I don't see any reason why we can't move to enabling it for all preferences after testing it on a whitelisted set of preferences. There are some weird preferences out there. I am being a bit cautious so we don't cause a change that catches users by surprise.

Fri, May 31, 10:25 PM · Patch-For-Review, Community-Tech (Kanban), Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dbarratt added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

Do you think the risk is still high if the config list is global and not per-wiki?

Fri, May 31, 10:21 PM · Patch-For-Review, Community-Tech (Kanban), Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dbarratt added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

So there are three potential behaviors with the API:

  1. The preference is saved locally
  2. The preference is saved locally OR globally depending on the user's preference for that preference
  3. The preference is saved locally OR globally depending on the user's preference for that preference IF the preference is in the config (which is different for each wiki and is not exposed with the API) OTHERWISE it is saved locally.
Fri, May 31, 9:55 PM · Patch-For-Review, Community-Tech (Kanban), Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dbarratt assigned T224704: CI build failing for some ext repos due to PhanUndeclaredClassMethod "undeclared class \Block" to Tchanders.
Fri, May 31, 9:14 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Growth-Team, PageCuration, Wikimedia-production-error (Shared Build Failure)
dbarratt moved T224613: Update Interaction Timeline to use the new actor table from Review to QA/Testing on the Anti-Harassment (Kaf - כ) board.
Fri, May 31, 9:13 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dbarratt @Niharika @aezell Can any of you update the task description and summarize how this should look/behave/text in the page and so on? I'm not 100% sure what's the consensus here.

Fri, May 31, 7:52 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt updated the task description for T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Fri, May 31, 7:52 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

This is what I was doing initially and we talked and agreed on not using a checkbox because there is only one option and it was bad UX (merging the lists or no)

Fri, May 31, 1:04 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

I wanna bring back the attention to the mocks. Let me know which of those messages I should change and to what. Some of them are very short and "cold".
Also, this page could also use a bit more text documenting how things work. Maybe adding a paragraph to clarify things? Or maybe not ?

Fri, May 31, 12:20 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email

Thu, May 30

dbarratt added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

I'm not sure how this resolves the problem(s) I mentioned above. You're allowing an extension to change the behavior of a preference regardless of where it is saved.

Thu, May 30, 11:37 PM · Patch-For-Review, Community-Tech (Kanban), Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dbarratt moved T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures from QA/Testing to In Progress on the Anti-Harassment (Kaf - כ) board.
Thu, May 30, 11:23 PM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools
dbarratt moved T221371: 'Thanks' are completely blocked when a user is partially blocked from Review to QA/Testing on the Anti-Harassment (Kaf - כ) board.
Thu, May 30, 6:46 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Anti-Harassment (Kaf - כ), Growth-Team, Thanks
dbarratt added a comment to T221177: REST route handler extension interface RFC.

That's what PSR-7's interface does: it has various methods that return a new ResponseInterface object similar to $this but with some bit of state different. The down side is that it means every change has to allocate a new object and copy the data from the old, only for the old one to typically be immediately discarded. When performance is a concern, all that cloning can add up.

Thu, May 30, 5:56 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt added a comment to T221177: REST route handler extension interface RFC.

This might be naive, but why are immutable Responses so bad? Couldn't we provide a mechanism to replace the response rather than mutating it?

Thu, May 30, 3:33 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

That's true, the model is different for this page and Special:Preferences. This page is changing the mute preferences of a single user where Special:Preferences is changing the muting preferences for multiple users.

Thu, May 30, 3:22 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T222170: InvalidArgumentException from SpecialBlock.php: "$comment can not be null".

This exception can be reproduced by removing this node (and it's children) from the DOM:

<select tabindex="0" aria-disabled="false" name="wpReason" class="oo-ui-inputWidget-input oo-ui-indicator-down"></select>

and then saving the form.

Thu, May 30, 1:30 PM · Anti-Harassment, MediaWiki-User-management, MediaWiki-Comment-backend, Wikimedia-production-error, Chinese-Sites
dbarratt placed T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does up for grabs.
Thu, May 30, 3:54 AM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
dbarratt moved T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does from In Progress to Ready on the Anti-Harassment (Kaf - כ) board.
Thu, May 30, 3:54 AM · Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management

Wed, May 29

Restricted Application changed the subtype of T224613: Update Interaction Timeline to use the new actor table from "Task" to "Deadline".
Wed, May 29, 6:13 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I agree with David that "mute" by itself is ambiguous here. We should indicate that they are attempting to mute emails. So, for the first case, it should be like: "You have requested to mute emails from User:Vandal" and similarly for others.

Wed, May 29, 4:41 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dbarratt Based on T216185#5018338, I would agree with Trevor's comments there that the data does not give us conclusive evidence that merging the lists is a good idea. As a first step, I would like us to move the two mute lists on the same page in Special:Preferences because it is hard to discover the existence of the other list when you are on one. We can then get a better view of whether users add someone to both lists or just one.
Also we can collect some data from this special page - see how often users check both boxes when muting a user.

Wed, May 29, 4:33 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

In our standup yesterday, we discussed this. @Niharika made it clear that she would prefer to have the checkboxes. I'll let her provide her reasoning if she wishes.

Wed, May 29, 3:50 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

If we do unify the lists, the messaging (and the clarity of the action(s) being performed) can remain, which is what I would do. This can be done at a later date, but I would prefer to unify the lists over adding the checkboxes.

Wed, May 29, 2:55 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

Yes, since we are not unifying the lists atm (as per our conversation in other channels)

Wed, May 29, 2:50 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email

Fri, May 24

dbarratt added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

To clarify, we can only go with that display if we are committing to combine the two lists soon after.

Fri, May 24, 11:16 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt added a subtask for T220163: Allow user to mute notifications from Special:Mute page: T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Fri, May 24, 8:02 PM · Anti-Harassment (Lāmed - ל)
dbarratt added a parent task for T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser: T220163: Allow user to mute notifications from Special:Mute page.
Fri, May 24, 8:02 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt removed a parent task for T220163: Allow user to mute notifications from Special:Mute page: T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Fri, May 24, 8:01 PM · Anti-Harassment (Lāmed - ל)
dbarratt removed a subtask for T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser: T220163: Allow user to mute notifications from Special:Mute page.
Fri, May 24, 8:01 PM · Patch-For-Review, Anti-Harassment (Lāmed - ל), MediaWiki-Email
dbarratt archived Anti-Harassment (Yōd - י).
Fri, May 24, 6:13 PM
dbarratt set Is Sprint to 0 on Anti-Harassment (Kaf - כ).
Fri, May 24, 6:06 PM
dbarratt set the image for Anti-Harassment (Kaf - כ) to F29235275: profile.
Fri, May 24, 6:05 PM
dbarratt added a comment to T221177: REST route handler extension interface RFC.

There will be a new entry point file, rest.php, which invokes the static method MediaWiki\Rest\EntryPoint::main().

Fri, May 24, 5:35 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)
dbarratt added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

@dbarratt I meant to check on GlobalPreferences not on core. Same thing @Mooeypoo is suggesting but checking against what we already have on the db instead of a config

Fri, May 24, 5:19 PM · Patch-For-Review, Community-Tech (Kanban), Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dbarratt added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

I think I already asked this but it escapes me if I did. Why was it that we can't check if a given option is already a global preference or a local exception?
In other words, when saving "whatever-option" on onUserSaveOptions we could determine if it is a global preference and/or if it has a local override and make the changes wherever they need to be done.

Fri, May 24, 5:14 PM · Patch-For-Review, Community-Tech (Kanban), Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dbarratt added a comment to T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked.

Errr... well, I guess we could always fake it and use the same logic again, so if we know it's an empty partial block, then we can remove that from being displayed.

Fri, May 24, 2:18 PM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)
dbarratt added a comment to T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked.

Oh, nevermind, I remember why we did this, it's because there is no database flag for if it is editing or not. A non-editing block is an empty sitewide block (for now). If you would like to create a task for that, I can write what would be needed (a new field in the database to distinguish editing blocks for non-editing blocks).

Fri, May 24, 2:17 PM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)