Page MenuHomePhabricator

dcausse (David Causse)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 9:03 AM (218 w, 4 d)
Availability
Available
IRC Nick
dcausse
LDAP User
DCausse
MediaWiki User
DCausse (WMF) [ Global Accounts ]

Recent Activity

Wed, Jul 31

dcausse committed rECIR5a6e9be4a85c: Normalize request param name (authored by dcausse).
Normalize request param name
Wed, Jul 31, 6:08 PM
dcausse removed a project from T227098: Flow stores invalid UTF8 sequences in ParserOutput::mExternalLinks: Patch-For-Review.

tagged the wrong ticket in the patch, please ignore.

Wed, Jul 31, 5:17 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team, StructuredDiscussions, Discovery-Search (Current work)
dcausse moved T228496: EventBusMonologHandler: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send. from Waiting/Blocked to Needs review on the Discovery-Search (Current work) board.
Wed, Jul 31, 5:14 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikimedia-production-error, Discovery-Search (Current work), CirrusSearch

Tue, Jul 30

dcausse moved T228626: Extract interfaces and base classes from SearchResultSet and SearchResult from Done to in progress on the Discovery-Search (Current work) board.
Tue, Jul 30, 5:26 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch
dcausse moved T216429: CirrusSearch should provide a query dispatcher from Needs review to Done on the Discovery-Search (Current work) board.
Tue, Jul 30, 5:21 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Discovery-Search (Current work), CirrusSearch
dcausse updated subscribers of T229329: WDQS Updater: java.lang.StringIndexOutOfBoundsException: String index out of range: -8.
Tue, Jul 30, 1:48 PM · Wikidata-Query-Service, Wikidata
dcausse added a comment to T229329: WDQS Updater: java.lang.StringIndexOutOfBoundsException: String index out of range: -8.

if uris.entity().length() is greater than entityId.length() by 8 char it'll cause this exception. Since it's a test server it's perhaps misconfigured.

Tue, Jul 30, 1:40 PM · Wikidata-Query-Service, Wikidata
dcausse updated the task description for T229329: WDQS Updater: java.lang.StringIndexOutOfBoundsException: String index out of range: -8.
Tue, Jul 30, 1:17 PM · Wikidata-Query-Service, Wikidata
dcausse created T229329: WDQS Updater: java.lang.StringIndexOutOfBoundsException: String index out of range: -8.
Tue, Jul 30, 1:16 PM · Wikidata-Query-Service, Wikidata
dcausse committed rEWCS0cd8339c8054: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Tue, Jul 30, 1:16 AM

Mon, Jul 29

dcausse committed rEWLC8c54d904e038: Fix namespace for NewForm and NewLexeme (authored by dcausse).
Fix namespace for NewForm and NewLexeme
Mon, Jul 29, 3:42 PM
dcausse created T229233: DCausse: can't log into Superset.
Mon, Jul 29, 2:57 PM · Analytics
dcausse moved T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme from in progress to Needs review on the Discovery-Search (Current work) board.

Thanks, this worked!
As for codesearch and WikibaseLexemeCirrusSearch I double checked and this project is available.

Mon, Jul 29, 1:44 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch
dcausse added a comment to T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme.

Why not fixing WikibaseLexemeCirrusSearch instead of reverting the change? (We searched in codesearch, is WikibaseLexemeCirrusSearch missing there?)

Mon, Jul 29, 1:10 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch
dcausse claimed T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme.
Mon, Jul 29, 10:55 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch
dcausse added a project to T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme: CirrusSearch.
Mon, Jul 29, 10:51 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch
dcausse added a project to T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme: Discovery-Search (Current work).
Mon, Jul 29, 10:51 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch
dcausse updated the task description for T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme.
Mon, Jul 29, 10:50 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch
dcausse created T229215: CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme.
Mon, Jul 29, 10:47 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch

Fri, Jul 26

dcausse renamed T228626: Extract interfaces and base classes from SearchResultSet and SearchResult from Extract interfaces from SearchResultSet and SearchResult to Extract interfaces and base classes from SearchResultSet and SearchResult.
Fri, Jul 26, 3:50 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch

Wed, Jul 24

dcausse added a comment to T193613: Come up with a strategy for handling PHP interface changes.

I feel that this guideline is very limiting esp the fact that it prevents to introduce short and isolated contract (e.g. things like LoggerAwareInterface).
For instance how this guideline would apply for things like DestructibleService?

Wed, Jul 24, 1:23 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
dcausse added a comment to T193613: Come up with a strategy for handling PHP interface changes.

Would a solution using a trait as an adapter to ease the transition be helpful to mitigate the constraints involved by only having a Base class?
Please see: P8791 for a short example
cons:

  • more code files

pros:

  • BC code isolated to a dedicated trait
  • can still implement the interface (and thus multiple ones) as long as you adhere to the BCTrait
  • call sites are type hinting with the interface
  • the interface remains a clear contract as opposed to a Base class that could rapidly become hard to read.
Wed, Jul 24, 9:23 AM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
dcausse created P8791 Use trait as an adapter to ease interface changes.
Wed, Jul 24, 9:16 AM

Tue, Jul 23

dcausse added a comment to T193613: Come up with a strategy for handling PHP interface changes.

I have to extend this type hierarchy but the constructor parameters expected no longer make sense

If you extend a class, it shouldn't matter what the constructor parameters of the original class were. (Unless the class is constructed in code not controlled by you via some non-extensible mechanism, in which case that's your fundamental problem.)

Tue, Jul 23, 7:18 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
dcausse added a comment to T193613: Come up with a strategy for handling PHP interface changes.

Sorry I came to this task because I face the problem where having an interface used for consumption would have helped a lot. My example is the SearchResult/SearchResultSet objects that a SearchEngine must produce. My problem is:

  • SearchResult and SearchResultSet are concrete classes used as type hint all over the place
  • I have to extend this type hierarchy but the constructor parameters expected no longer make sense
Tue, Jul 23, 5:03 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General
dcausse added a comment to T193613: Come up with a strategy for handling PHP interface changes.

Is the sole purpose of using abstract classes to give some time for the deprecation process to happen?

Tue, Jul 23, 4:09 PM · Discovery-Search, TechCom, TechCom-RFC, MediaWiki-General

Mon, Jul 22

dcausse renamed T228626: Extract interfaces and base classes from SearchResultSet and SearchResult from Extract interfaces from SearchResultSet and SearchResultSet to Extract interfaces from SearchResultSet and SearchResult.
Mon, Jul 22, 9:28 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch
dcausse triaged T228626: Extract interfaces and base classes from SearchResultSet and SearchResult as Normal priority.
Mon, Jul 22, 9:24 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch
dcausse moved T228626: Extract interfaces and base classes from SearchResultSet and SearchResult from making others happy to Current work on the Discovery-Search board.
Mon, Jul 22, 9:24 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch
dcausse moved T228626: Extract interfaces and base classes from SearchResultSet and SearchResult from needs triage to making others happy on the Discovery-Search board.
Mon, Jul 22, 9:24 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch
dcausse created T228626: Extract interfaces and base classes from SearchResultSet and SearchResult.
Mon, Jul 22, 9:24 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Discovery-Search (Current work), Discovery, CirrusSearch

Sat, Jul 20

dcausse committed rECIRea6cf5274ab2: Adapt IndexLookupFallback method for glent requirements (authored by dcausse).
Adapt IndexLookupFallback method for glent requirements
Sat, Jul 20, 12:35 AM

Fri, Jul 19

dcausse committed rECIRf31e50df4e3d: Use sanitized request params and headers (authored by dcausse).
Use sanitized request params and headers
Fri, Jul 19, 4:00 PM
dcausse added a comment to T225199: Fatal error during RecentChange::notifyEdit (deferred update) from ORES/RecentChangeSaveHookHandler.

Beware that a lot of failures reported as FormatJson::encode($events) failed: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send. are due to T228496 and relate to sending log events through kafja (these are not MW jobs). These are all search related api requests.
Unless I'm searching incorrectly I can only find 3 instances of this particular failure in the last 7days (ORES RecentChangeSaveHookHandler failing to push due to invalid UTF-8 sequences). Search string I'm using: EventBus AND Malformed NOT "EventBusMonologHandler"

Fri, Jul 19, 1:51 PM · Growth-Team (Current Sprint), MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Scoring-platform-team, WMF-JobQueue, ORES, Wikimedia-production-error
dcausse moved T228496: EventBusMonologHandler: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send. from Untriaged to Since May 2019 / 1.34.wmf5–7 on the Wikimedia-production-error board.
Fri, Jul 19, 8:57 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikimedia-production-error, Discovery-Search (Current work), CirrusSearch
dcausse added a project to T228496: EventBusMonologHandler: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send.: Wikimedia-production-error.
Fri, Jul 19, 8:57 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikimedia-production-error, Discovery-Search (Current work), CirrusSearch
dcausse triaged T228496: EventBusMonologHandler: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send. as Normal priority.
Fri, Jul 19, 8:52 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikimedia-production-error, Discovery-Search (Current work), CirrusSearch
dcausse moved T228496: EventBusMonologHandler: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send. from needs triage to Current work on the Discovery-Search board.
Fri, Jul 19, 8:35 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikimedia-production-error, Discovery-Search (Current work), CirrusSearch
dcausse created T228496: EventBusMonologHandler: Malformed UTF-8 characters, possibly incorrectly encoded. Aborting send..
Fri, Jul 19, 8:35 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikimedia-production-error, Discovery-Search (Current work), CirrusSearch

Jul 18 2019

dcausse created T228430: Improve resiliency of the reindexing process.
Jul 18 2019, 3:00 PM · Discovery-Search, CirrusSearch
dcausse moved T206613: Search of wikidata string property values using haswbstatement is case sensitive from Waiting/Blocked to Done on the Discovery-Search (Current work) board.
Jul 18 2019, 1:48 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), User-Smalyshev, CirrusSearch, Discovery, Wikidata
dcausse moved T227136: Reindexing search index wikidatawiki for eqiad fails from in progress to Done on the Discovery-Search (Current work) board.
Jul 18 2019, 1:47 PM · Patch-For-Review, Discovery-Search (Current work), CirrusSearch
dcausse moved T227718: Delete search indices for now-deleted zerowiki from production, if appropriate from in progress to Done on the Discovery-Search (Current work) board.
Jul 18 2019, 7:00 AM · Discovery-Search (Current work), Release-Engineering-Team-TODO, Reading-Infrastructure-Team-Backlog
dcausse moved T226722: Index captions as description fields not label from in progress to Done on the Discovery-Search (Current work) board.
Jul 18 2019, 6:50 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Multimedia, Structured-Data-Team-Current-Work, WikibaseMediaInfo, Discovery-Search (Current work)

Jul 17 2019

dcausse closed T228283: ElasticaErrorHandler.php: Object of class Elastica\Response could not be converted to string, a subtask of T220739: 1.34.0-wmf.14 deployment blockers, as Resolved.
Jul 17 2019, 4:58 PM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Deployment services), Release, Train Deployments
dcausse closed T228283: ElasticaErrorHandler.php: Object of class Elastica\Response could not be converted to string as Resolved.
Jul 17 2019, 4:58 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Discovery-Search, CirrusSearch, Wikimedia-production-error
dcausse committed rECIRfec8063a4cb1: Log response data JSON on errors (authored by dcausse).
Log response data JSON on errors
Jul 17 2019, 4:50 PM
dcausse committed rECIR22cafa2c7de4: Log response data JSON on errors (authored by dcausse).
Log response data JSON on errors
Jul 17 2019, 4:46 PM
dcausse added a comment to T173248: Convert blank nodes to “unknown value” .

I see that the response is

		<result>
			<binding name='type'>
				<bnode>t1514691780</bnode>
			</binding>
			<binding name='typeLabel'>
				<literal>t1514691780</literal>
			</binding>
		</result>
Jul 17 2019, 2:54 PM · Wikidata-Query-Service, Wikidata, Discovery
dcausse committed rECIR955fc9dc1640: Do not serialize ResultsType instance (authored by dcausse).
Do not serialize ResultsType instance
Jul 17 2019, 1:50 PM
dcausse added a comment to T186037: Need mvn build mode that does not build gui.

We could also use mvn -pl -gui which does not require any changes

Jul 17 2019, 10:59 AM · Discovery-Wikidata-Query-Service-Sprint, Discovery, Wikidata, Wikidata-Query-Service
dcausse added a comment to T227136: Reindexing search index wikidatawiki for eqiad fails.

Failed again (56850851 / 58244355) with:

Reindex task was not successfull: Failed: [{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [803795624]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [854883345]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [562256487]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [894521381]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [825290081]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [894521383]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [825290085]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [894521384]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [854883344]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [854883343]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [803795626]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [803795625]"}},{"shard":-1,"reason":{"type":"search_context_missing_exception","reason":"No search context found for id [825290078]"}}]
Jul 17 2019, 6:59 AM · Patch-For-Review, Discovery-Search (Current work), CirrusSearch
dcausse committed rEWCSe62637aeccc7: Query description fields with incaption keyword (authored by dcausse).
Query description fields with incaption keyword
Jul 17 2019, 12:17 AM

Jul 16 2019

dcausse claimed T186037: Need mvn build mode that does not build gui.
Jul 16 2019, 4:36 PM · Discovery-Wikidata-Query-Service-Sprint, Discovery, Wikidata, Wikidata-Query-Service
dcausse added a project to T186037: Need mvn build mode that does not build gui: Discovery-Wikidata-Query-Service-Sprint.
Jul 16 2019, 4:35 PM · Discovery-Wikidata-Query-Service-Sprint, Discovery, Wikidata, Wikidata-Query-Service

Jul 12 2019

dcausse committed rECIR4cf427e9acd7: Add FetchPhaseConfigBuilder (authored by dcausse).
Add FetchPhaseConfigBuilder
Jul 12 2019, 7:32 PM

Jul 11 2019

dcausse added a comment to T87781: Split mediawiki tests into unit and integration tests.

In general, it's better to combine composer dependencies of extension into core using composer merge plugin: https://www.mediawiki.org/wiki/Composer#Using_composer-merge-plugin

Jul 11 2019, 6:39 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
dcausse committed rEWCSacee722d8943: Support new factory_method format in query builder profile (authored by dcausse).
Support new factory_method format in query builder profile
Jul 11 2019, 5:53 PM
dcausse added a comment to T87781: Split mediawiki tests into unit and integration tests.

Testing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/521955 I found that the extension dependencies are not loaded by the php unit boostrap script.
I'm perhaps running this incorrectly (vendor/bin/phpunit extensions/CirrusSearch/tests/phpunit/unit/ or composer phpunit:unit extensions/CirrusSearch/tests/phpunit/unit/).
Loading extensions/*/vendor/autoload.php makes the tests pass for cirrus.

Jul 11 2019, 5:52 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing

Jul 8 2019

dcausse moved T225068: Add a PHPUnit group to skip test on gated CI runs from in progress to Waiting/Blocked on the Discovery-Search (Current work) board.
Jul 8 2019, 5:06 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Quibble, Move-Files-To-Commons, CirrusSearch, MediaWiki-extensions-Scribunto, TCB-Team, Continuous-Integration-Config
dcausse claimed T227262: Adapt IndexLookupFallbackMethod for glent requirements.
Jul 8 2019, 4:26 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Discovery-Search (Current work), CirrusSearch
dcausse moved T227262: Adapt IndexLookupFallbackMethod for glent requirements from elastic / cirrus to Current work on the Discovery-Search board.
Jul 8 2019, 4:26 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Discovery-Search (Current work), CirrusSearch

Jul 4 2019

dcausse added a comment to T225225: Create a browser test to make sure that the related articles are shown on the beta cluster.

Thanks, we will try to be more cautious on this feature in the future, if there is anything else we can collectively do to improve this I am happy to help otherwise please feel free to close this task as Invalid.

Jul 4 2019, 2:14 PM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles
dcausse triaged T227262: Adapt IndexLookupFallbackMethod for glent requirements as Normal priority.
Jul 4 2019, 9:28 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Discovery-Search (Current work), CirrusSearch
dcausse created T227262: Adapt IndexLookupFallbackMethod for glent requirements.
Jul 4 2019, 9:27 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Discovery-Search (Current work), CirrusSearch

Jul 3 2019

dcausse added a comment to T225225: Create a browser test to make sure that the related articles are shown on the beta cluster.

Found https://lists.wikimedia.org/pipermail/qa-alerts/2019-May/date.html#start and https://lists.wikimedia.org/pipermail/qa-alerts/2019-June/date.html#start and indeed the browser test properly failed 6 times consecutively.
I'll start monitoring this particular job but Is there something we can do so that we take actions when it happens again in the future?

Jul 3 2019, 2:49 PM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles
dcausse added a comment to T227136: Reindexing search index wikidatawiki for eqiad fails.

The process_cluster_event_timeout_exception is something that can be addressed by increasing the masterTimeout we reverted it back to 30s hoping that the multi-instance cluster setup would help here. Apparently we're still seeing this kind of issue Let's bump this value up to 5m.

Jul 3 2019, 1:59 PM · Patch-For-Review, Discovery-Search (Current work), CirrusSearch
dcausse added a comment to T225225: Create a browser test to make sure that the related articles are shown on the beta cluster.

@Jdlrobson thanks, I should have looked more closely at jenkins before creating this task. Could someone verify that it actually failed between May 28 and June 2 (jenkins history is too short but hopefully a mail was sent to someone)?

Jul 3 2019, 6:28 AM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles

Jul 2 2019

dcausse moved T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push from in progress to Waiting/Blocked on the Discovery-Search (Current work) board.
Jul 2 2019, 3:32 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse triaged T227098: Flow stores invalid UTF8 sequences in ParserOutput::mExternalLinks as Normal priority.
Jul 2 2019, 3:08 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team, StructuredDiscussions, Discovery-Search (Current work)
dcausse renamed T227098: Flow stores invalid UTF8 sequences in ParserOutput::mExternalLinks from Flow stores invalid UTF8 sequences in ParserOutput::mExternalLinks when parsing to Flow stores invalid UTF8 sequences in ParserOutput::mExternalLinks.
Jul 2 2019, 3:03 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team, StructuredDiscussions, Discovery-Search (Current work)
Restricted Application added a project to T227098: Flow stores invalid UTF8 sequences in ParserOutput::mExternalLinks: Growth-Team.
Jul 2 2019, 3:02 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team, StructuredDiscussions, Discovery-Search (Current work)
dcausse moved T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push from Waiting/Blocked to in progress on the Discovery-Search (Current work) board.
Jul 2 2019, 7:38 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

Jul 1 2019

dcausse claimed T226969: PHP Warning: Invalid argument supplied for foreach().
Jul 1 2019, 2:23 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Discovery-Search (Current work), Beta-Cluster-Infrastructure, Wikidata-Termbox, CirrusSearch, Wikimedia-production-error
dcausse edited projects for T226969: PHP Warning: Invalid argument supplied for foreach(), added: Discovery-Search (Current work); removed Discovery-Search.
Jul 1 2019, 2:23 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Discovery-Search (Current work), Beta-Cluster-Infrastructure, Wikidata-Termbox, CirrusSearch, Wikimedia-production-error
dcausse committed rEWCSe65d1b8f8bbb: Use proper defaults for StatementBoost (authored by dcausse).
Use proper defaults for StatementBoost
Jul 1 2019, 12:05 PM

Jun 28 2019

dcausse added a comment to T226722: Index captions as description fields not label.

Note however we don't have a field like labels_all for descriptions, right? Also, hascaption is now an alias to haslabel, so they both work on the same field. May be moved to be an alias for hasdescription, of course. But then not clear how hascaption:* would work if at all.

Jun 28 2019, 8:49 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Multimedia, Structured-Data-Team-Current-Work, WikibaseMediaInfo, Discovery-Search (Current work)

Jun 27 2019

dcausse added a comment to T224611: Implement match for any-language label (haslabel:*).

Created T226722 to fix this.

Jun 27 2019, 2:53 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Smalyshev, Discovery-Search (Current work), WikibaseMediaInfo
dcausse triaged T226722: Index captions as description fields not label as High priority.
Jun 27 2019, 2:52 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Multimedia, Structured-Data-Team-Current-Work, WikibaseMediaInfo, Discovery-Search (Current work)
dcausse created T226722: Index captions as description fields not label.
Jun 27 2019, 2:50 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Multimedia, Structured-Data-Team-Current-Work, WikibaseMediaInfo, Discovery-Search (Current work)

Jun 26 2019

dcausse claimed T226592: Fatal error from CirrusSearch/IncomingLinkCount Job: Argument to WikiPage::__construct must be Title.
Jun 26 2019, 7:12 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse edited projects for T226592: Fatal error from CirrusSearch/IncomingLinkCount Job: Argument to WikiPage::__construct must be Title, added: Discovery-Search (Current work); removed Discovery-Search.
Jun 26 2019, 7:11 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse added a comment to T224611: Implement match for any-language label (haslabel:*).

I have no clue why it's not working yet but I think youwe should have indexed the captions to description fields not label fields. Label fields are optimized for exact matches which is not suited for captions.

Jun 26 2019, 6:56 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Smalyshev, Discovery-Search (Current work), WikibaseMediaInfo

Jun 25 2019

dcausse moved T226568: PHP error from CirrusSearch/RequestLogger: "Array to string conversion" from in progress to Needs review on the Discovery-Search (Current work) board.
Jun 25 2019, 8:13 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse edited projects for T226568: PHP error from CirrusSearch/RequestLogger: "Array to string conversion", added: Discovery-Search (Current work); removed Discovery-Search.
Jun 25 2019, 8:13 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse claimed T226568: PHP error from CirrusSearch/RequestLogger: "Array to string conversion".
Jun 25 2019, 8:12 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse updated the task description for T218994: Epic: Deprecation warning on elasticsearch 6 .
Jun 25 2019, 5:36 PM · Epic, CirrusSearch, Discovery-Search, Operations
dcausse assigned T220637: [Bug] Unexpected result set returned by Elasticsearch to EBernhardson.
Jun 25 2019, 5:20 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Discovery-Search (Current work), Readers-Web-Backlog (Tracking), Elasticsearch, GeoData
dcausse committed rEWLC3e8abd7ec8a3: Fix tests to use the dispatch service (authored by dcausse).
Fix tests to use the dispatch service
Jun 25 2019, 2:03 PM

Jun 24 2019

dcausse committed rEWCSbecca9f6ebb4: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Jun 24 2019, 2:58 PM
dcausse committed rEWCS706e5c424846: Avoid referencing cirrus behaviors in fixtures (authored by dcausse).
Avoid referencing cirrus behaviors in fixtures
Jun 24 2019, 10:01 AM

Jun 21 2019

dcausse committed rEWCS4a442c3ffe1f: Update tests (authored by dcausse).
Update tests
Jun 21 2019, 3:57 PM
dcausse claimed T226241: Ascii folding behaves differently for autocomplete vs. search.
Jun 21 2019, 2:57 PM · Discovery-Search (Current work), CirrusSearch, I18n
dcausse edited projects for T226241: Ascii folding behaves differently for autocomplete vs. search, added: Discovery-Search (Current work); removed Discovery-Search.
Jun 21 2019, 2:56 PM · Discovery-Search (Current work), CirrusSearch, I18n
dcausse triaged T226241: Ascii folding behaves differently for autocomplete vs. search as Normal priority.

There is a discrepancy for langues where we do not apply any accent folding. We always apply accent removal (with either asciifolding or icu_folding) on autocomplete and go but we do not on fulltext.
This is inconsistent, I think we should query all_near_match.asciifolding alongside all_near_match for fulltext queries.

Jun 21 2019, 1:49 PM · Discovery-Search (Current work), CirrusSearch, I18n

Jun 20 2019

dcausse changed the status of T202254: Use ExtensionRegistry instead of class_exists to check for CirrusSearch in Wikibase from Stalled to Open.
Jun 20 2019, 8:25 AM · Technical-Debt, wikidata-tech-focus, Wikidata
dcausse moved T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails from Resolved to Untriaged on the Wikimedia-production-error (Shared Build Failure) board.

it's happening again on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/516637 :

07:16:01 Undefined index: imageinfo
07:16:01 
07:16:01 /workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/WBMIApiTestCase.php:118
07:16:01 /workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/MultiLingualCaptionsTest.php:28
07:16:01 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
Jun 20 2019, 7:31 AM · ci-test-error, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
dcausse added a comment to T204135: Warn when CirrusSearch is not configured to use local DC for an extended time.

I changed the output to:

{
  "wmfMasterDatacenter": "eqiad",
  "wmfEtcdLastModifiedIndex": 3672,
  "wmgCirrusSearchDefaultCluster": "local",
  "wgCirrusSearchDefaultCluster": "eqiad"
}
Jun 20 2019, 6:50 AM · Discovery-Search, Datacenter-Switchover-2018, Operations

Jun 19 2019

dcausse committed rEWCS5e0a53a30b03: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Jun 19 2019, 2:04 PM

Jun 18 2019

Stanislav Malyshev <smalyshev@gmail.com> committed rEWLCfc0fd5bba5ac: Fix LexemeCompletionSearchTest::testSearchElastic (authored by dcausse).
Fix LexemeCompletionSearchTest::testSearchElastic
Jun 18 2019, 5:47 PM