Page MenuHomePhabricator

dcausse (David Causse)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2015, 9:03 AM (211 w, 10 h)
Availability
Available
IRC Nick
dcausse
LDAP User
DCausse
MediaWiki User
DCausse (WMF) [ Global Accounts ]

Recent Activity

Today

dcausse updated the task description for T218994: Epic: Deprecation warning on elasticsearch 6 .
Tue, Jun 25, 5:36 PM · Epic, CirrusSearch, Discovery-Search, Operations
dcausse assigned T220637: [Bug] Unexpected result set returned by Elasticsearch to EBernhardson.
Tue, Jun 25, 5:20 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Discovery-Search (Current work), Readers-Web-Backlog (Tracking), Elasticsearch, GeoData
dcausse committed rEWLC3e8abd7ec8a3: Fix tests to use the dispatch service (authored by dcausse).
Fix tests to use the dispatch service
Tue, Jun 25, 2:03 PM

Yesterday

dcausse committed rEWCSbecca9f6ebb4: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Mon, Jun 24, 2:58 PM
dcausse committed rEWCS706e5c424846: Avoid referencing cirrus behaviors in fixtures (authored by dcausse).
Avoid referencing cirrus behaviors in fixtures
Mon, Jun 24, 10:01 AM

Fri, Jun 21

dcausse committed rEWCS4a442c3ffe1f: Update tests (authored by dcausse).
Update tests
Fri, Jun 21, 3:57 PM
dcausse claimed T226241: Ascii folding behaves differently for autocomplete vs. search.
Fri, Jun 21, 2:57 PM · Discovery-Search (Current work), Patch-For-Review, CirrusSearch, I18n
dcausse edited projects for T226241: Ascii folding behaves differently for autocomplete vs. search, added: Discovery-Search (Current work); removed Discovery-Search.
Fri, Jun 21, 2:56 PM · Discovery-Search (Current work), Patch-For-Review, CirrusSearch, I18n
dcausse triaged T226241: Ascii folding behaves differently for autocomplete vs. search as Normal priority.

There is a discrepancy for langues where we do not apply any accent folding. We always apply accent removal (with either asciifolding or icu_folding) on autocomplete and go but we do not on fulltext.
This is inconsistent, I think we should query all_near_match.asciifolding alongside all_near_match for fulltext queries.

Fri, Jun 21, 1:49 PM · Discovery-Search (Current work), Patch-For-Review, CirrusSearch, I18n

Thu, Jun 20

dcausse changed the status of T202254: Use ExtensionRegistry instead of class_exists to check for CirrusSearch in Wikibase from Stalled to Open.
Thu, Jun 20, 8:25 AM · Technical-Debt, wikidata-tech-focus, Wikidata
dcausse moved T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails from Resolved to Untriaged on the Wikimedia-production-error (Shared Build Failure) board.

it's happening again on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/516637 :

07:16:01 Undefined index: imageinfo
07:16:01 
07:16:01 /workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/WBMIApiTestCase.php:118
07:16:01 /workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/MultiLingualCaptionsTest.php:28
07:16:01 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
Thu, Jun 20, 7:31 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
dcausse added a comment to T204135: Warn when CirrusSearch is not configured to use local DC for an extended time.

I changed the output to:

{
  "wmfMasterDatacenter": "eqiad",
  "wmfEtcdLastModifiedIndex": 3672,
  "wmgCirrusSearchDefaultCluster": "local",
  "wgCirrusSearchDefaultCluster": "eqiad"
}
Thu, Jun 20, 6:50 AM · Discovery-Search, Datacenter-Switchover-2018, Operations

Wed, Jun 19

dcausse committed rEWCS5e0a53a30b03: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Wed, Jun 19, 2:04 PM

Tue, Jun 18

Stanislav Malyshev <smalyshev@gmail.com> committed rEWLCfc0fd5bba5ac: Fix LexemeCompletionSearchTest::testSearchElastic (authored by dcausse).
Fix LexemeCompletionSearchTest::testSearchElastic
Tue, Jun 18, 5:47 PM
dcausse moved T190130: HighlightBuilder: Introduce a way to control the highlighting behaviors from Waiting/Blocked to in progress on the Discovery-Search (Current work) board.
Tue, Jun 18, 1:16 PM · Discovery-Search (Current work), Discovery, CirrusSearch
dcausse moved T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push from in progress to Waiting/Blocked on the Discovery-Search (Current work) board.
Tue, Jun 18, 1:16 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

Mon, Jun 17

dcausse committed rEWLCc9aece354772: Make the Result::getTextSnippet $terms optional (authored by dcausse).
Make the Result::getTextSnippet $terms optional
Mon, Jun 17, 3:34 PM
dcausse committed rEWLCa2bfb24db3b0: Fix LexemeCompletionSearchTest::testSearchElastic (authored by dcausse).
Fix LexemeCompletionSearchTest::testSearchElastic
Mon, Jun 17, 3:34 PM
dcausse committed rEWCS2e32652a7114: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Mon, Jun 17, 3:26 PM
dcausse committed rEWLCc3645f780b42: Make the Result::getTextSnippet $terms optional (authored by dcausse).
Make the Result::getTextSnippet $terms optional
Mon, Jun 17, 3:18 PM
dcausse committed rEWCS4af9513ffb60: Make the Result::getTextSnippet $terms optional (authored by dcausse).
Make the Result::getTextSnippet $terms optional
Mon, Jun 17, 2:47 PM
dcausse committed rEWCSeac45e5a7898: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Mon, Jun 17, 1:14 PM
dcausse moved T225904: Mjolnir bulk update failure check - eqiad from needs triage to Ops / SRE on the Discovery-Search board.

possibly related to the patch merged on T214494

Mon, Jun 17, 6:58 AM · Discovery-Search
dcausse added a project to T225904: Mjolnir bulk update failure check - eqiad: Discovery-Search.
Mon, Jun 17, 6:57 AM · Discovery-Search

Fri, Jun 14

dcausse added a comment to T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push.

Tested various PHP versions hoping to find an explanation in vain.
Moving forward I think I'll add some temporary code in cirrus to detect invalid UTF-8 sequences in the source text so that we can flag and fix such pages in the elasticsearch index. Since Cirrus is refreshing its index constantly we might be able to use its data to filter the list of non-deleted pages that contain invalid UTF8 sequences in their text content.

Fri, Jun 14, 3:54 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

Thu, Jun 13

dcausse added a comment to T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push.

Checked few examples and there seem to be a mix of

  • LiquidThread pages
  • old pages in (generally CJK languages) and do not seem to have been updated in a while (~2004)
Thu, Jun 13, 5:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse moved T216429: CirrusSearch should provide a query dispatcher from in progress to Needs review on the Discovery-Search (Current work) board.
Thu, Jun 13, 2:11 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Discovery-Search (Current work), CirrusSearch
dcausse triaged T225724: Cleanup old Wikibase CirrusSearch config in wmf mediawiki-config as Normal priority.
Thu, Jun 13, 1:55 PM · Discovery-Search, CirrusSearch
dcausse created T225724: Cleanup old Wikibase CirrusSearch config in wmf mediawiki-config.
Thu, Jun 13, 1:53 PM · Discovery-Search, CirrusSearch
dcausse committed rEWCS76c016fefa3f: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Thu, Jun 13, 1:38 PM

Thu, Jun 6

dcausse updated the task description for T225225: Create a browser test to make sure that the related articles are shown on the beta cluster.
Thu, Jun 6, 4:13 PM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles
dcausse renamed T225225: Create a browser test to make sure that the related articles are shown on the beta cluster from Create a browser tests to make sure the related articles are shown on the beta cluster to Create a browser test to make sure that the related articles are shown on the beta cluster.
Thu, Jun 6, 3:30 PM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles
dcausse added a project to T225225: Create a browser test to make sure that the related articles are shown on the beta cluster: Wikimedia-Incident.
Thu, Jun 6, 3:30 PM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles
dcausse created T225225: Create a browser test to make sure that the related articles are shown on the beta cluster.
Thu, Jun 6, 3:29 PM · Readers-Web-Backlog, Wikimedia-Incident, RelatedArticles
dcausse removed a parent task for T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push: T220733: 1.34.0-wmf.8 deployment blockers.
Thu, Jun 6, 1:09 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse removed a subtask for T220733: 1.34.0-wmf.8 deployment blockers: T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push.
Thu, Jun 6, 1:09 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Release, Train Deployments
dcausse lowered the priority of T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push from Unbreak Now! to Normal.

This error is not new, it's just that we changed some class names (message:"Unable to serialize events" AND exception.trace:"CirrusSearch"). Removing from deployment blocker.
I think it's caused by something similar to T184698

Thu, Jun 6, 1:09 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse claimed T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push.
Thu, Jun 6, 12:06 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse edited projects for T225200: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push, added: Discovery-Search (Current work); removed Discovery-Search.
Thu, Jun 6, 12:05 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMF-JobQueue, Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse moved T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone from in progress to Needs review on the Discovery-Search (Current work) board.
Thu, Jun 6, 11:44 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch
dcausse added a comment to T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone.

I finally opted for a randomized approach where I limit the number of fixture at 200 by default per run. The fixtures to test are selected randomly. If merged the full suite of unit tests for Cirrus would now take 25sec instead of 1m30 on my laptop.

Thu, Jun 6, 11:43 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch
Ladsgroup awarded T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone a Like token.
Thu, Jun 6, 8:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch
dcausse claimed T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone.

we blindly copied all browser tests fixtures and run them on 3 different setup, I'm sure we can prune down the list of tested cases.

Thu, Jun 6, 8:46 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch
dcausse edited projects for T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone, added: Discovery-Search (Current work); removed Discovery-Search.
Thu, Jun 6, 8:44 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch

Tue, Jun 4

dcausse moved T224879: Suggested articles are no longer shown from Needs review to Done on the Discovery-Search (Current work) board.
Tue, Jun 4, 5:17 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), RelatedArticles
dcausse committed rEWCS51be0dc1eb1f: [WIP] Use CirrusSearch query dispatch service (authored by dcausse).
[WIP] Use CirrusSearch query dispatch service
Tue, Jun 4, 5:00 PM
dcausse committed rEWCScc70280fc686: Use CirrusSearch query dispatch service (authored by dcausse).
Use CirrusSearch query dispatch service
Tue, Jun 4, 4:50 PM
dcausse merged T215615: Stop using negative scores for deboosting statements into T209859: Wikidata autocomplete (wbsearchentities) results with score <= 0.
Tue, Jun 4, 12:44 PM · Wikidata, Discovery-Search
dcausse merged task T215615: Stop using negative scores for deboosting statements into T209859: Wikidata autocomplete (wbsearchentities) results with score <= 0.
Tue, Jun 4, 12:44 PM · Wikidata, CirrusSearch, Discovery-Search
dcausse added a comment to T206613: Search of wikidata string property values using haswbstatement is case sensitive.

@Smalyshev I totally agree, I was suggesting a UX where a first attempt search would try to match using the haswbstatement keyword (switched to case insensitive) and then a second try could be made using the fulltext mode if the first attempt is unsuccessful.

Tue, Jun 4, 7:20 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), User-Smalyshev, CirrusSearch, Discovery, Wikidata
dcausse added a comment to T206613: Search of wikidata string property values using haswbstatement is case sensitive.

we should also note we index this data in the main filter field which means that for searches that are unlikely to be ambiguous (IDs and such) one could simply search for 10.1371/journal.pcbi.1002947. Benefit is that it's tolerant to small variation in punctuation but also accept partial searches like:
journal.pcbi.1002947 or even with small variations: journal pcbi 1002947.

Tue, Jun 4, 6:56 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), User-Smalyshev, CirrusSearch, Discovery, Wikidata
dcausse added a comment to T206613: Search of wikidata string property values using haswbstatement is case sensitive.

@Smalyshev switching the main field for statements to lowercase_keyword won't break anything, it's like a new field it'll be taken into account just after the next reindex. I would advise against a new field here, the cardinality would nearly double.

Tue, Jun 4, 6:42 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), User-Smalyshev, CirrusSearch, Discovery, Wikidata

Mon, Jun 3

dcausse claimed T224879: Suggested articles are no longer shown.
Mon, Jun 3, 1:09 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), RelatedArticles
dcausse triaged T224879: Suggested articles are no longer shown as High priority.
Mon, Jun 3, 1:08 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), RelatedArticles
dcausse created T224879: Suggested articles are no longer shown.
Mon, Jun 3, 1:03 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), RelatedArticles

Fri, May 31

dcausse claimed T222921: extensions/CirrusSearch/includes/Sanity/Checker.php:369 Cannot fetch ids from index.
Fri, May 31, 12:44 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

Wed, May 29

dcausse added a comment to T87892: Convert CirrusSearch to use extension registration.

yes, we need to find a good way to version cirrus indeed :)
I was thinking of aligning it to the version of elasticsearch it supports. We should be at something like 6.x.

Wed, May 29, 10:07 AM · Discovery-Search (Current work), Discovery, CirrusSearch
dcausse moved T87892: Convert CirrusSearch to use extension registration from in progress to Needs review on the Discovery-Search (Current work) board.
Wed, May 29, 9:52 AM · Discovery-Search (Current work), Discovery, CirrusSearch
dcausse edited projects for T87892: Convert CirrusSearch to use extension registration, added: Discovery-Search (Current work); removed Discovery-Search.
Wed, May 29, 9:52 AM · Discovery-Search (Current work), Discovery, CirrusSearch
dcausse moved T216429: CirrusSearch should provide a query dispatcher from Waiting/Blocked to in progress on the Discovery-Search (Current work) board.
Wed, May 29, 9:50 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Discovery-Search (Current work), CirrusSearch
dcausse edited projects for T224494: Add maint script to import data from swift to elasticsearch, added: Discovery-Search; removed Discovery-Search (Current work).
Wed, May 29, 9:50 AM · Discovery-Search, CirrusSearch
dcausse updated the task description for T87892: Convert CirrusSearch to use extension registration.
Wed, May 29, 9:46 AM · Discovery-Search (Current work), Discovery, CirrusSearch

Tue, May 28

dcausse triaged T224494: Add maint script to import data from swift to elasticsearch as Normal priority.
Tue, May 28, 5:25 PM · Discovery-Search, CirrusSearch
dcausse moved T222652: Create a fallback method based on a generic index from Needs review to Done on the Discovery-Search (Current work) board.
Tue, May 28, 5:19 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Discovery-Search (Current work), CirrusSearch
dcausse moved T222152: Make fallback methods configurable from Needs review to Done on the Discovery-Search (Current work) board.
Tue, May 28, 5:19 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Discovery-Search (Current work), CirrusSearch
dcausse moved T221621: Allow FallbackMethod to create their own SearchQuery from Needs review to Done on the Discovery-Search (Current work) board.
Tue, May 28, 5:19 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Discovery-Search (Current work), CirrusSearch
dcausse edited projects for T224494: Add maint script to import data from swift to elasticsearch, added: Discovery-Search (Current work); removed Discovery-Search.
Tue, May 28, 4:14 PM · Discovery-Search, CirrusSearch
Restricted Application edited projects for T224494: Add maint script to import data from swift to elasticsearch, added: Discovery-Search; removed Discovery-Search (Current work).
Tue, May 28, 4:14 PM · Discovery-Search, CirrusSearch
dcausse added a comment to T224448: Gerrit http threads stuck behind sendemail thread.

Here SendEmail-1 is not "blocked" it's just waiting for jobs, however the dump says:
Locked ownable synchronizers:- <0x00000001c13617f8> (a java.util.concurrent.locks.ReentrantLock$NonfairSync).
Meaning that this SendEmail-1 thread holds the ReentrantLock lock which is blocking Http threads.
So something happened previously in that thread that caused the lock to still be held.

Is it also possible that it's some kind of blocking read causing a deadlock that doesn't show up in dumps? i.e., https://dzone.com/articles/java-concurrency-hidden-thread

Tue, May 28, 2:34 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, serviceops-radar, Gerrit
dcausse added a comment to T224448: Gerrit http threads stuck behind sendemail thread.

Here SendEmail-1 is not "blocked" it's just waiting for jobs, however the dump says:
Locked ownable synchronizers:- <0x00000001c13617f8> (a java.util.concurrent.locks.ReentrantLock$NonfairSync).
Meaning that this SendEmail-1 thread holds the ReentrantLock lock which is blocking Http threads.
So something happened previously in that thread that caused the lock to still be held.

Tue, May 28, 1:29 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, serviceops-radar, Gerrit

Mon, May 27

dcausse updated the task description for T224425: MW Job consumers sometimes pause for several minutes.
Mon, May 27, 12:54 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Next), Services (next), WMF-JobQueue, Discovery-Search (Current work)
dcausse updated the task description for T224425: MW Job consumers sometimes pause for several minutes.
Mon, May 27, 12:51 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Next), Services (next), WMF-JobQueue, Discovery-Search (Current work)
dcausse moved T224425: MW Job consumers sometimes pause for several minutes from in progress to Waiting/Blocked on the Discovery-Search (Current work) board.
Mon, May 27, 12:38 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Next), Services (next), WMF-JobQueue, Discovery-Search (Current work)
dcausse edited projects for T224425: MW Job consumers sometimes pause for several minutes, added: WMF-JobQueue; removed MediaWiki-JobQueue.
Mon, May 27, 12:37 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Next), Services (next), WMF-JobQueue, Discovery-Search (Current work)
dcausse updated the task description for T224425: MW Job consumers sometimes pause for several minutes.
Mon, May 27, 12:36 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Next), Services (next), WMF-JobQueue, Discovery-Search (Current work)
dcausse created T224425: MW Job consumers sometimes pause for several minutes.
Mon, May 27, 12:36 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Next), Services (next), WMF-JobQueue, Discovery-Search (Current work)

May 23 2019

dcausse moved T223767: Geodata not being returned for some files from in progress to Needs review on the Discovery-Search (Current work) board.
May 23 2019, 5:48 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), Tool-flickrdash, GeoData
dcausse merged T223722: PHP Notice: Undefined index: __main__ from MSearchResponses.php into T223738: PHP Fatal Error on Special:Search with certain offset query parameter.
May 23 2019, 5:48 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse merged task T223722: PHP Notice: Undefined index: __main__ from MSearchResponses.php into T223738: PHP Fatal Error on Special:Search with certain offset query parameter.
May 23 2019, 5:48 PM · Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse added a comment to T223722: PHP Notice: Undefined index: __main__ from MSearchResponses.php.

Looking at the URL (crazy offset usage) I think it's related to T223738 and already fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/511455

May 23 2019, 5:44 PM · Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

May 22 2019

dcausse added a comment to T224082: No results for specific string in Global Phab Search, while Advanced Search lists expected results.

This is using the simple search form (triggered from the search box top-right): https://phabricator.wikimedia.org/search/query/ZRnM6OqnN6iE/#R (this current task should be present in the search results)
Thanks for pointing at the advanced search form I was not aware of it.

May 22 2019, 2:55 PM · Phabricator
dcausse added a comment to T223869: Geosearch yields no results for Slovak Wikipedia.

Is this a regression?
At a glance I don't see the parser function coordinates being called when parsing for instance Bratislava. If this is a regression would it be possible that a change to a template on-wiki caused this?
Testing the parser function {{#coordinates:48.143889|17.109722}} I can see the coordinates being indexed but I failed to use templates such as {{Súradnice|48.143889|S|17.109722|V|format=dms}} in such case the coordinates does not seem to be sent to the coordinates parser function.

May 22 2019, 2:19 PM · GeoData, Discovery-Search
dcausse claimed T223767: Geodata not being returned for some files.
May 22 2019, 10:05 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), Tool-flickrdash, GeoData
dcausse moved T223767: Geodata not being returned for some files from needs triage to Current work on the Discovery-Search board.
May 22 2019, 10:05 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Discovery-Search (Current work), Tool-flickrdash, GeoData
dcausse created T224082: No results for specific string in Global Phab Search, while Advanced Search lists expected results.
May 22 2019, 7:24 AM · Phabricator
dcausse merged task T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... into T223738: PHP Fatal Error on Special:Search with certain offset query parameter.
May 22 2019, 7:14 AM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse merged T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... into T223738: PHP Fatal Error on Special:Search with certain offset query parameter.
May 22 2019, 7:14 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse claimed T223738: PHP Fatal Error on Special:Search with certain offset query parameter.
May 22 2019, 7:13 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
dcausse moved T223738: PHP Fatal Error on Special:Search with certain offset query parameter from needs triage to Current work on the Discovery-Search board.
May 22 2019, 7:12 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

May 20 2019

dcausse moved T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... from in progress to Needs review on the Discovery-Search (Current work) board.
May 20 2019, 4:50 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse renamed T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... from PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult() to PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()....
May 20 2019, 2:58 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse moved T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... from Since July 2019 / 1.34.wmf12 to Since May 2019 / 1.34.wmf5—7 on the Wikimedia-production-error board.
May 20 2019, 2:56 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse moved T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... from Untriaged to Since July 2019 / 1.34.wmf12 on the Wikimedia-production-error board.
May 20 2019, 2:56 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse moved T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... from elastic / cirrus to Current work on the Discovery-Search board.
May 20 2019, 2:55 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse triaged T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()... as Normal priority.
May 20 2019, 2:54 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch
dcausse created T223912: PHP Fatal Error from line 90 of /srv/mediawiki/php-1.34.0-wmf.5/extensions/CirrusSearch/includes/Search/MSearchResponses.php: Argument 1 passed to CirrusSearch\Search\FullTextResultsType::transformElasticsearchResult()....
May 20 2019, 2:53 PM · Patch-For-Review, Discovery-Search (Current work), Wikimedia-production-error, CirrusSearch

May 7 2019

dcausse committed rEWCS8b87fc511228: Remove SearchContext from ResultsType signature (authored by dcausse).
Remove SearchContext from ResultsType signature
May 7 2019, 7:29 PM
Stanislav Malyshev <smalyshev@gmail.com> committed rEWCS2e04369bf61a: Remove SearchContext from ResultsType signature (authored by dcausse).
Remove SearchContext from ResultsType signature
May 7 2019, 7:29 PM
dcausse committed rEWCSde91e8b3e392: Remove SearchContext from ResultsType signature (authored by dcausse).
Remove SearchContext from ResultsType signature
May 7 2019, 7:29 PM
dcausse committed rEWLCf13c8e5602a9: Remove SearchContext from ResultsType signature (authored by dcausse).
Remove SearchContext from ResultsType signature
May 7 2019, 6:30 PM