dchan (David Chan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 23 2014, 10:14 AM (199 w, 2 d)
Availability
Available
IRC Nick
divec
LDAP User
Unknown
MediaWiki User
DChan (WMF) [ Global Accounts ]

Recent Activity

Mon, Aug 13

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (?).

I agree with @matmarex 's proposal that we shouldn't revert to the   behaviour for visual editing (because we want nbsp to represent actual non-breaking spaces). It's a different issue in wikitext because non-breaking spaces are inferred heuristically.

Mon, Aug 13, 11:43 AM · VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Thu, Aug 9

dchan moved T201599: It is possible to get the cursor into a block slug from Up next to In progress on the VisualEditor (Current work) board.
Thu, Aug 9, 10:20 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable
dchan edited projects for T201599: It is possible to get the cursor into a block slug, added: VisualEditor (Current work); removed VisualEditor.
Thu, Aug 9, 10:19 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable
dchan added a comment to T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

Ok, I created T201599 for the separate slug cursoring issue, which is really a corruption problem as @Deskana suggests.

Thu, Aug 9, 10:05 AM · VisualEditor (Current work)
dchan created T201599: It is possible to get the cursor into a block slug.
Thu, Aug 9, 10:02 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable

Wed, Aug 8

dchan added a comment to T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

And the problem happens because Chromium natively puts the cursor into the slug even though the click is outside the slug, but not in Firefox because its native behaviour is different (it puts the cursor directly into the surrounding div).

Wed, Aug 8, 8:45 PM · VisualEditor (Current work)
dchan added a comment to T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

Clicking twice to the left of the node puts the cursor into the slug text and lets you edit it

Wed, Aug 8, 8:37 PM · VisualEditor (Current work)
dchan claimed T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

This is reproducible with any focusable block node, e.g. on this minimal document:

<hr>x
Wed, Aug 8, 8:34 PM · VisualEditor (Current work)

Fri, Jul 27

dchan added a comment to T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

I feel the following code isn't that sensible now that meta items live in the main linear data:

Fri, Jul 27, 6:20 PM · Verified-in-Phase2, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs
dchan added a comment to T199011: CX2: Paragraph becomes unusable when switching to 'Don't use machine translation' or 'Use source text' .

Thanks! I'm not seeing the error, with parameters:page=Foo&from=en&to=es&targettitle=Bar&version=2&revision=<XXX> . It seems to work fine for me, on both my local installation and on wikipedia.org . Can you confirm a particular page+paragraph that fails for you on wikipedia.org?

Fri, Jul 27, 2:38 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Language-2018-July-September, ContentTranslation
dchan added a comment to T199011: CX2: Paragraph becomes unusable when switching to 'Don't use machine translation' or 'Use source text' .

Hi @Petar.petkovic, can you tell me steps to reproduce the continuing issues (after Change 446198) you mentioned above? The points you make in T199754 look good, but I'd like to have a failing test case to verify against.

Fri, Jul 27, 2:01 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Language-2018-July-September, ContentTranslation
dchan added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

I'm also failing to reproduce this — I tried on 4c51ee9ec57678f29b320868161d570dba7c4ccb and on aca98533eab67e3154c4b243cbcadd155b69398e .

Fri, Jul 27, 1:00 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Ryasmeen, Verified, VisualEditor (Current work)

Jul 12 2018

dchan added a comment to T199464: PolyGerrit unified diff view is too narrow without enabling "Fit to screen" setting.

Thanks, that solves it for me - is there any way that can be the default (at least for Unified)?

Jul 12 2018, 5:18 PM · Gerrit
dchan created T199464: PolyGerrit unified diff view is too narrow without enabling "Fit to screen" setting.
Jul 12 2018, 4:50 PM · Gerrit

Jul 10 2018

dchan added a comment to T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.

Sure, thanks

Jul 10 2018, 6:31 AM · Security

Jun 25 2018

dchan added a comment to T193587: CX2: Rich text editing in dialogs is not possible since cards are shown in a deactivated tools column.

Let me comment on the specific issue of modality. There are definitely parts of the VE code that assume dialogs operating on a portion of the document must be modal. One example is that there's a transaction undo stack that mirrors the dialog opening stack. Another is that there are places where stored offsets could be invalidated if the main document remains editable while the dialog is visible.

Jun 25 2018, 11:19 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Language-2018-Apr-June, ContentTranslation

Jun 14 2018

dchan added a comment to T196921: Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception).

@Esanders : yes, that seems to solve the issue, both in my local testing and when I monkey patch the live pl.wikisource.org page above.

Jun 14 2018, 7:29 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), ProofreadPage, VisualEditor-MediaWiki

May 20 2018

dchan added a comment to T76541: Load/display document-level data (e.g. internal lists, meta lists) for the whole document but only the content for a part of the document.

As well as the approach in https://gerrit.wikimedia.org/r/433753 , we should also consider the following alternative:

  • A class provides the LinearData interface on a live slice of the linear data (performing offset translation and bounds checking)
  • ve.dm.Document builds on top of that class

That approach would more robustly prevent access outside the slice. But one drawback would be apparent dangling references in the slice.

May 20 2018, 7:47 AM · Patch-For-Review, VisualEditor (Current work), Epic, VisualEditor-MediaWiki, VisualEditor-Performance

May 18 2018

dchan added a comment to T49344: Internal nodes should eventually be in a separate document ("sub-documents").

Here is a proposal for refinement:

May 18 2018, 2:10 PM · Epic, Patch-For-Review, VisualEditor-Performance, VisualEditor, Technical-Debt

May 2 2018

dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

With change 430413, "change citation, undo, redo" seems to work fine in all the cases I've tried.

May 2 2018, 4:53 PM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools
dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

Hmm, thanks, it seems I overlooked that there are a few different ways reference-instead-of-copy can happen here - investigating further.

May 2 2018, 9:10 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools

Apr 29 2018

dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

Ooooh, this happens because ve.dm.TransactionBuilder#pushAttributeChanges( { key: val }, ... ) puts a live reference to val into the Transaction object. So if val subsequently gets mutated, that invalidates the Transaction object.

Apr 29 2018, 2:52 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools

Apr 15 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (?).

A hotfix for the problem I describe is to open the console (CTRL+SHIFT+i), then type

$( '.ve-ce-surface' ).css( 'word-break', 'break-all' )

then press <ENTER>, then close the console (CTRL+SHIFT+i again).

Apr 15 2018, 2:40 AM · VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor
dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (?).

Oh, I can reproduce what might be the same problem, or at least related: I think it's to do with browser rules for wrapping spaces.

Apr 15 2018, 2:29 AM · VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Apr 11 2018

dchan added a comment to T171374: Make CodeMirror support IME functionality.

That sounds like a good idea, because even if we switched to listening for keydown, we'd be depending on our keydown listener to run first, which would be quite brittle.

Apr 11 2018, 4:41 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan added a comment to T171374: Make CodeMirror support IME functionality.

@MusikAnimal I think listening to keydown might work here, but might break other uses of jQuery.IME . If it does work here, perhaps we could consider making it an option. Anyone want to try changing the binding and see whether it works?

Apr 11 2018, 1:16 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror

Apr 8 2018

dchan edited projects for T191700: VE: Avoid piping links for formatting where possible, added: Parsoid; removed VisualEditor-EditingTools, VisualEditor.

Thanks SoWhy, things like this would happen during the HTML->wikitext conversion in Parsoid, so I've tagged it as an issue for the Parsoid team to look at.

Apr 8 2018, 1:32 AM · Patch-For-Review, Parsoid

Mar 29 2018

dchan added a comment to T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.

Thanks, that's most informative and makes me understand the situation a lot better. I wonder can we publish this sort of info for users in sensitive situations (if we haven't already) — and I guess advise them to use something like tor if they still have really serious concerns.

Mar 29 2018, 1:15 PM · Security

Mar 28 2018

dchan updated subscribers of T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.
Mar 28 2018, 3:29 PM · Security
dchan created T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.
Mar 28 2018, 3:27 PM · Security

Mar 19 2018

dchan moved T188709: Annotation ordering is hazily defined in Transactions from In progress to Code review on the VisualEditor (Current work) board.
Mar 19 2018, 4:47 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 15 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Well, it should improve such situations by giving us the precision to treat them all properly.

Mar 15 2018, 9:00 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 14 2018

dchan added a comment to T171374: Make CodeMirror support IME functionality.

Oh, the keypress behaviour we're seeing in Chromium doesn't seem to happen on the CodeMirror demo, either on https://codemirror.net/index.html (presumably the current version 5.35.0) or bundled in http://codemirror.net/codemirror-5.30.0.zip (which is the version the mediawiki extension currently includes).

Mar 14 2018, 12:56 PM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan closed T189643: Error while building VE document model with a translation section containing block image as Resolved.

See https://gerrit.wikimedia.org/r/#/c/419151/1..2/modules/ve-cx/dm/ve.dm.CXBlockImageNode.js .

Mar 14 2018, 11:29 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T189643: Error while building VE document model with a translation section containing block image.

Oh, of course - we have to allow mwImageCaption to have cxBlockImageNode as a parent ... I'll upload a patch

Mar 14 2018, 11:25 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T189643: Error while building VE document model with a translation section containing block image.

After debugging this with the help of @santhosh , It seems ve.dm.Document#fixupInsertion is returning unbalanced data . Before the fixup, we have:

Mar 14 2018, 9:26 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T171374: Make CodeMirror support IME functionality.

Ok, I put some small fixes into https://gerrit.wikimedia.org/r/#/c/398602/5/ and https://gerrit.wikimedia.org/r/#/c/399460/5/ .

Mar 14 2018, 5:39 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan added a comment to T171374: Make CodeMirror support IME functionality.

Hi, it's currently not working for me on either Firefox 57 or Chromium 63, both on Ubuntu. Here are exact steps to reproduce:

Mar 14 2018, 4:38 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror

Mar 13 2018

dchan added a comment to T189118: Find out why a <nowiki/> tag are causing edits to get mangled.

Hmmm, that makes sense, because since 21a5d55b85dd , we only round-trip the meta item back into the ContentBranchNode on serialization if the ContentBranchNode is unmodified - so clearly if the <nowiki/> is being used to separate out pieces of wiki syntax, the behaviour will now not be as intended.

Mar 13 2018, 9:15 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan reassigned T189118: Find out why a <nowiki/> tag are causing edits to get mangled from dchan to matmarex.
Mar 13 2018, 9:03 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan claimed T189118: Find out why a <nowiki/> tag are causing edits to get mangled.

Thanks @matmarex (and oops) - taking a look.

Mar 13 2018, 8:51 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan added a comment to T189557: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines.

Thanks, @matmarex ! The purpose of the TreeModifier is to perform the linear modifiations in an order such that the tree structure is at all times valid and the view can stay closely in sync with the linear model. Even so, there may be scope to reduce the number of splices in such an obvious case - I'll take a look.

Mar 13 2018, 6:35 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Mar 12 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Change 416735 fixes this

Mar 12 2018, 7:54 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 5 2018

dchan moved T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store from Up next to Code review on the VisualEditor (Current work) board.
Mar 5 2018, 9:44 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel
dchan moved T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store from To Triage to Current work on the VisualEditor board.
Mar 5 2018, 9:43 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel
dchan added a project to T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store: Technical-Debt.
Mar 5 2018, 9:39 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel
dchan created T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store.
Mar 5 2018, 9:37 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel

Mar 4 2018

dchan claimed T188709: Annotation ordering is hazily defined in Transactions.
Mar 4 2018, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan moved T188709: Annotation ordering is hazily defined in Transactions from Up next to In progress on the VisualEditor (Current work) board.
Mar 4 2018, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan moved T188709: Annotation ordering is hazily defined in Transactions from To Triage to Current work on the VisualEditor board.
Mar 4 2018, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188026: Provide a way to compact multiple transactions into one.

Squashing exacerbates T188709 , which hitherto was only bothering us in a few rare-ish edge cases.

Mar 4 2018, 6:48 AM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Performance, VisualEditor (Current work), VisualEditor-DataModel
dchan added a subtask for T188026: Provide a way to compact multiple transactions into one: T188709: Annotation ordering is hazily defined in Transactions.
Mar 4 2018, 6:46 AM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Performance, VisualEditor (Current work), VisualEditor-DataModel
dchan added a parent task for T188709: Annotation ordering is hazily defined in Transactions: T188026: Provide a way to compact multiple transactions into one.
Mar 4 2018, 6:46 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Patch set https://gerrit.wikimedia.org/r/416335 is preparatory work, not a solution in itself

Mar 4 2018, 6:45 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

A less drastic option would be to add a spliceAt field to the current structure:

Mar 4 2018, 4:04 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 2 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

OTOH the theoretical logic perspective is that treating all annotations as ordered, and losing some clarity of intent in the transactions in order to preserve that order, is a somewhat "hammer" approach - a more "scalpel" approach would be to make a way to express order only when order does matter, and then only relative to the thing it matters to.

Mar 2 2018, 4:40 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan updated the task description for T188709: Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 2:04 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan renamed T188709: Annotation ordering is hazily defined in Transactions from Annotation ordering is hazily defined to Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 1:22 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan updated the task description for T188709: Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 10:49 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

@Esanders suggests we could change our annotation transactions to define the whole annotation array before and after. So the unbold transaction in the above example would effectively become "change annotations from [bold,italic] to [italic]", and its reverse would say "change annotations from [italic] to [bold,italic]".

Mar 2 2018, 10:43 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan created T188709: Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 10:41 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Feb 26 2018

dchan added a comment to T76426: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are.

We can resurrect https://gerrit.wikimedia.org/r/329448 if we provide a tool for blockquote insertion

Feb 26 2018, 2:27 PM · Patch-For-Review, VisualEditor-EditingTools, VisualEditor

Feb 25 2018

dchan added a comment to T188020: Minify Transaction/Change serialization.

For a typical authoring session, document history as a Change will contain a large proportion of transactions that are consecutive text insertions in the same place, with the same annotation as the insertion context. There may be a transaction for every keystroke (but somewhat fewer for many IMEs).

Feb 25 2018, 9:05 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
dchan renamed T188020: Minify Transaction/Change serialization from Minify transactions to Minify Transaction/Change serialization.
Feb 25 2018, 8:58 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel

Feb 22 2018

dchan moved T188026: Provide a way to compact multiple transactions into one from Up next to In progress on the VisualEditor (Current work) board.
Feb 22 2018, 6:00 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Performance, VisualEditor (Current work), VisualEditor-DataModel
dchan moved T188026: Provide a way to compact multiple transactions into one from To Triage to Current work on the VisualEditor board.
Feb 22 2018, 6:00 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Performance, VisualEditor (Current work), VisualEditor-DataModel
dchan set the point value for T188021: Improve control of resource growth during VisualEditor editing sessions to 0.
Feb 22 2018, 5:59 PM · Performance, Epic, VisualEditor
dchan added a parent task for T188026: Provide a way to compact multiple transactions into one: T188021: Improve control of resource growth during VisualEditor editing sessions.
Feb 22 2018, 5:59 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Performance, VisualEditor (Current work), VisualEditor-DataModel
dchan added a subtask for T188021: Improve control of resource growth during VisualEditor editing sessions: T188026: Provide a way to compact multiple transactions into one.
Feb 22 2018, 5:59 PM · Performance, Epic, VisualEditor
dchan created T188026: Provide a way to compact multiple transactions into one.
Feb 22 2018, 5:58 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Performance, VisualEditor (Current work), VisualEditor-DataModel
dchan created T188021: Improve control of resource growth during VisualEditor editing sessions.
Feb 22 2018, 5:30 PM · Performance, Epic, VisualEditor
dchan updated subscribers of T187976: Length limit truncation should use the cursor position, not fallible heuristics.
Feb 22 2018, 5:19 AM · JavaScript, MediaWiki-General-or-Unknown
dchan triaged T187976: Length limit truncation should use the cursor position, not fallible heuristics as Low priority.
Feb 22 2018, 5:17 AM · JavaScript, MediaWiki-General-or-Unknown
dchan updated subscribers of T187976: Length limit truncation should use the cursor position, not fallible heuristics.

See also the videos that @Catrope posted on T186364 (showing the difference in truncation timing for keyboard paste and mouse paste, the latter being later and therefore easier not to notice):

Feb 22 2018, 5:16 AM · JavaScript, MediaWiki-General-or-Unknown
dchan created T187976: Length limit truncation should use the cursor position, not fallible heuristics.
Feb 22 2018, 5:10 AM · JavaScript, MediaWiki-General-or-Unknown

Feb 21 2018

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

I like this idea of VisualEditor doing something nice with window.onerror .

Feb 21 2018, 10:38 AM · OOjs, VisualEditor-DataModel, VisualEditor

Feb 14 2018

Elitre awarded T56299: (Re-) unify data and metadata a Like token.
Feb 14 2018, 12:53 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor-DataModel, Epic, VisualEditor, Technical-Debt

Feb 3 2018

dchan added a comment to T186364: mw.widgets.visibleByteLimit doesn't truncate correctly.

I can confirm that you don't have to have a complex grapheme cluster like a flag to break this: it also happens with single non-BMP codepoints, such as U+282E2 (𨋢).

Feb 3 2018, 2:12 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), MediaWiki-General-or-Unknown, JavaScript

Feb 1 2018

dchan updated the task description for T186109: Select all throws an exception (recent regression).
Feb 1 2018, 2:30 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), VisualEditor-DataModel, VisualEditor-ContentEditable, User-Ryasmeen, Regression, VisualEditor
dchan added a comment to T186109: Select all throws an exception (recent regression).

Ooh, interesting. Minimal case for throwing the error:

Feb 1 2018, 2:25 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), VisualEditor-DataModel, VisualEditor-ContentEditable, User-Ryasmeen, Regression, VisualEditor

Jan 26 2018

dchan updated the task description for T185546: EventEmitters must behave appropriately if a handler raises an exception.
Jan 26 2018, 5:29 PM · OOjs, VisualEditor-DataModel, VisualEditor
dchan added a comment to T185745: Rebaser: A SurfaceSynchronizer sometimes receives newChange before registered/initDoc.

Change 406269 is a workround, not a fix

Jan 26 2018, 11:38 AM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor
dchan updated the task description for T185747: SurfaceSynchronizer: nameChange is emitted twice on connect.
Jan 26 2018, 11:21 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor
dchan created T185747: SurfaceSynchronizer: nameChange is emitted twice on connect.
Jan 26 2018, 11:15 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor
dchan updated the task description for T185716: Rebaser: onDisconnect does not uninitialize sufficiently.
Jan 26 2018, 10:43 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor
dchan created T185745: Rebaser: A SurfaceSynchronizer sometimes receives newChange before registered/initDoc.
Jan 26 2018, 10:16 AM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor

Jan 25 2018

dchan created T185716: Rebaser: onDisconnect does not uninitialize sufficiently.
Jan 25 2018, 7:14 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor

Jan 23 2018

dchan created T185556: SurfaceSynchronizer doesn't propagate annotations first seen in a reverted change.
Jan 23 2018, 7:54 AM · VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor

Jan 22 2018

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

Steps to reproduce (one specific example of data corruption):

Jan 22 2018, 11:28 PM · OOjs, VisualEditor-DataModel, VisualEditor
dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

That's true (I was imagining the callback only being used for debugging purposes).

Jan 22 2018, 11:28 PM · OOjs, VisualEditor-DataModel, VisualEditor
dchan created T185546: EventEmitters must behave appropriately if a handler raises an exception.
Jan 22 2018, 11:11 PM · OOjs, VisualEditor-DataModel, VisualEditor

Jan 20 2018

dchan created T185395: SurfaceSynchronizer: outdated author selections can leak.
Jan 20 2018, 8:07 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor

Dec 7 2017

dchan added a comment to T182270: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11).

Oh, command.execute( surface ) is happening twice, and it so happens that the commands are self-inverse (toggling).

Dec 7 2017, 3:35 AM · Verified-in-Phase2, Verified-in-Phase0, Verified, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), User-Ryasmeen, Patch-For-Review, VisualEditor-EditingTools, VisualEditor

Nov 26 2017

dchan added a comment to T179574: List editing exception: TypeError: Cannot read property 'getSurface' of null.

I think this is happening because zombie CE nodes (that have been splice-removed) are still listening to events.

Nov 26 2017, 6:43 AM · Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), VisualEditor-ContentEditable, VisualEditor

Oct 9 2017

dchan added a comment to T177517: [regression wmf.2] Typing in a newly created empty <pre> doesn't work.

I'm unable to reproduce this. I've tried:

Oct 9 2017, 1:19 AM · VisualEditor

Oct 7 2017

dchan added a comment to T175826: Fix RTL on text input fields.

And there's already a method in Language.php to recognize the directionality of the first character of a string...
[...]
It's a php method, but we can migrate it to JS fairly easily - the regexp is the same, and @dchan created a javascript unicode library, if I remember correctly, as well, that could help here if we want to go that direction.

Oct 7 2017, 8:36 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
dchan added a comment to T176104: jQuery.IME not working in VisualEditor/2017 wikitext editor.

This was introduced in 37d0c27478983c9607cd85fdc6551b16a9bbb3a5 - an exception is thrown whenever jQuery.IME attempts to do any text replacement, and the timing of the exception means that the document ends up with both the substitution and the typed character text.

Oct 7 2017, 12:21 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), VisualEditor-MediaWiki-2017WikitextEditor, UniversalLanguageSelector, VisualEditor
dchan renamed T176104: jQuery.IME not working in VisualEditor/2017 wikitext editor from ULS not working properly for Indic wikis in visual editor/2017 wikitext editor to jQuery.IME not working in VisualEditor/2017 wikitext editor.
Oct 7 2017, 12:14 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), VisualEditor-MediaWiki-2017WikitextEditor, UniversalLanguageSelector, VisualEditor

Sep 25 2017

dchan claimed T176453: VisualEditor IME test failing in CI on pull-through, but not locally or in the source repo?.
Sep 25 2017, 9:37 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, VisualEditor-ContentEditable, VisualEditor
dchan added a comment to T176453: VisualEditor IME test failing in CI on pull-through, but not locally or in the source repo?.

OK, I have tested a rewritten version of ve.ce.TestRunner#changeText on the CI environment with Filibuster ( https://gerrit.wikimedia.org/r/#/c/379557/23/ ), and it looks like it works. So now we just need to put it into VE standalone then pull that through into VE-MW. And then see whether I'm completely wrong or not :)

Sep 25 2017, 9:14 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, VisualEditor-ContentEditable, VisualEditor