Page MenuHomePhabricator

dchan (David Chan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 23 2014, 10:14 AM (251 w, 3 d)
Availability
Available
IRC Nick
divec
LDAP User
Unknown
MediaWiki User
DChan (WMF) [ Global Accounts ]

Recent Activity

Tue, Aug 13

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

I filed a separate task about using window.onerror (T230441)

Tue, Aug 13, 6:31 PM · VisualEditor (Current work), Patch-For-Review, OOjs, VisualEditor-DataModel
dchan created T230441: Uncaught errors: inform the editor, or log, or both.
Tue, Aug 13, 6:28 PM · VisualEditor

Mon, Aug 12

dchan moved T227616: Conduct Edit Cards v2 on-wiki test from In progress to Ready for Pick Up on the VisualEditor (Current work) board.
Mon, Aug 12, 10:53 AM · VisualEditor (Current work)
dchan moved T230325: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Mon, Aug 12, 10:53 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
dchan moved T230323: Use MutationObservers to detect structural changes from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Mon, Aug 12, 10:53 AM · VisualEditor (Current work), VisualEditor-ContentEditable
dchan moved T230325: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState from To Triage to Current work on the VisualEditor board.
Mon, Aug 12, 10:52 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
dchan moved T230323: Use MutationObservers to detect structural changes from To Triage to Current work on the VisualEditor board.
Mon, Aug 12, 10:52 AM · VisualEditor (Current work), VisualEditor-ContentEditable
dchan added a subtask for T230325: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState: T220629: Right click to delete across paragraphs in Firefox results in no model transaction.
Mon, Aug 12, 10:51 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
dchan added a parent task for T220629: Right click to delete across paragraphs in Firefox results in no model transaction: T230325: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState.
Mon, Aug 12, 10:51 AM · VisualEditor-ContentEditable, VisualEditor
dchan created T230325: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState.
Mon, Aug 12, 10:50 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
dchan added a subtask for T230323: Use MutationObservers to detect structural changes: T220629: Right click to delete across paragraphs in Firefox results in no model transaction.
Mon, Aug 12, 10:43 AM · VisualEditor (Current work), VisualEditor-ContentEditable
dchan added a parent task for T220629: Right click to delete across paragraphs in Firefox results in no model transaction: T230323: Use MutationObservers to detect structural changes.
Mon, Aug 12, 10:43 AM · VisualEditor-ContentEditable, VisualEditor
dchan created T230323: Use MutationObservers to detect structural changes.
Mon, Aug 12, 10:42 AM · VisualEditor (Current work), VisualEditor-ContentEditable

Fri, Aug 9

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

Ok, the VE engineers have now examined many different possible VE-level fixes to this. Unfortunately, all seem to worsen the codebase.

Fri, Aug 9, 2:55 PM · VisualEditor (Current work), Patch-For-Review, OOjs, VisualEditor-DataModel

Fri, Aug 2

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

Hmm, can we perhaps modify the prototype on loading VE? I think when VE is running the chances of anything (VE or otherwise) relying on the non-catchy behaviour are pretty low.

Fri, Aug 2, 10:17 PM · VisualEditor (Current work), Patch-For-Review, OOjs, VisualEditor-DataModel
dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

Change 527510 is the code from 84df3f0b9f59626749db6e00b197c18979b0bacd , reimplemented inside VisualEditor as an extension of OO.EventEmitter.

Fri, Aug 2, 11:16 AM · VisualEditor (Current work), Patch-For-Review, OOjs, VisualEditor-DataModel

Tue, Jul 23

dchan moved T228767: Fix VisualEditor unit test failures on Firefox headless from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Tue, Jul 23, 3:49 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
dchan moved T228767: Fix VisualEditor unit test failures on Firefox headless from To Triage to Current work on the VisualEditor board.
Tue, Jul 23, 3:49 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
dchan created T228767: Fix VisualEditor unit test failures on Firefox headless.
Tue, Jul 23, 3:11 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable

Jul 13 2019

dchan added a comment to T215717: When section editing, do not build whole CE tree.

Monkey patched on live and edited a section of a long article (mobile site on desktop) (https://en.m.wikipedia.org/wiki/Megan_Rapinoe)
Testing second load times (i.e with the code and page data already fetched and cached), time to loaded was ~2300ms without the patch, and ~1300ms with.

Jul 13 2019, 2:38 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable

Jun 24 2019

dchan added a comment to T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.

On looking again, it seems enabling input debugging changes the behaviour (at least now it does).

Jun 24 2019, 3:58 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Jun 23 2019

dchan updated subscribers of T215567: Split TreeModifier into a tree diff generator and tree diff applier.
Jun 23 2019, 3:58 PM · Patch-For-Review, VisualEditor-DataModel, VisualEditor
dchan added a comment to T215567: Split TreeModifier into a tree diff generator and tree diff applier.

I think this is looking more or less in shape. How about we work out a fairly quiet time to merge it? I ask because, although in theory the behaviour should be unchanged, in practice the internals are fairly radically new, so it would be good to have capacity for reactive QA / debugging if required.

Jun 23 2019, 3:57 PM · Patch-For-Review, VisualEditor-DataModel, VisualEditor

Jun 3 2019

dchan created T224881: OO.ui.throttle should always be asynchronous.
Jun 3 2019, 1:25 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.0)

May 9 2019

dchan added a comment to T222894: Chinese IME issue in 2017 WTE.

Hi @deryckchan , do we know which IME / browser / Cangjie IME software combination User:恐狼博士 is using? I can't reproduce the problem, and I've tried a few different Chinese IMEs on zh-yue.wikipedia.org using 2017 wikitext editor, both mobile and desktop.

May 9 2019, 6:30 PM · VisualEditor (Current work), Chinese-Sites

Apr 11 2019

dchan added a comment to T219812: Editor wants to quickly move back to whole page editing.

My only immediate thought to add is a reactive corrector may need to make the same small correction across a few places. E.g. updating a statistic mentioned in an infobox and in free text. For consistency, you wouldn't want to commit that change in two stages.

Apr 11 2019, 6:31 AM · Section Editing, VisualEditor

Apr 4 2019

dchan added a comment to T217223: Backspacing multiple VE paragraphs in Gboard causes model corruption.

I am reasonably satisfied with Change 498528 now. I cannot find a case where this breaks input, having tested on multiple types of IME, on Chromium, Firefox and Safari, and on Android, iOS, Windows, Linux and MacOS. Of course, there are almost limitless combinations, so it's always possible there is some breakage I've not managed to find.

Apr 4 2019, 11:04 AM · VisualEditor-Mobile-UsabilityImprovements, Skipped QA, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Mar 18 2019

dchan added a parent task for T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome): T218545: Cope with IMEs that make uncancellable alterations to DOM structural nodes.
Mar 18 2019, 9:19 AM · VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan added a subtask for T218545: Cope with IMEs that make uncancellable alterations to DOM structural nodes: T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome).
Mar 18 2019, 9:19 AM · VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan created T218545: Cope with IMEs that make uncancellable alterations to DOM structural nodes.
Mar 18 2019, 9:18 AM · VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Mar 1 2019

dchan added a comment to T215908: Section Editing: Pre-Deployment QA .

To see the real speed benefits of section editing, we may need to test long articles on entry-level devices. Here are recordings of a stark difference, editing United States on the (entry-level) Xiaomi Redmi 6A.

Mar 1 2019, 5:54 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor
dchan added a comment to T217223: Backspacing multiple VE paragraphs in Gboard causes model corruption.

Ok, with Gboard English, this is what happens when you select "de</h1><h1>fg" and press backspace:

  1. The selection collapses to the end
  2. A keydown event with an unknown keycode is fired
  3. The content is deleted (unifying the paragraphs)
Mar 1 2019, 5:12 AM · VisualEditor-Mobile-UsabilityImprovements, Skipped QA, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Feb 27 2019

dchan created T217223: Backspacing multiple VE paragraphs in Gboard causes model corruption.
Feb 27 2019, 4:20 AM · VisualEditor-Mobile-UsabilityImprovements, Skipped QA, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Feb 12 2019

dchan added a comment to T209987: [Engineering EPIC]: Isolate Section Editing.

See also T215717 (which is a related optimization task, but not a blocking subtask)

Feb 12 2019, 12:56 AM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor

Feb 10 2019

dchan created T215717: When section editing, do not build whole CE tree.
Feb 10 2019, 9:18 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable

Feb 9 2019

dchan added a comment to T209874: CX2: Unable to type diacritics in the translation.

Thanks, those "steps to reproduce" are impressively precise. I will investigate.

Feb 9 2019, 2:34 PM · VisualEditor (Current work), ContentTranslation

Feb 8 2019

dchan added a comment to T215567: Split TreeModifier into a tree diff generator and tree diff applier.

Oh, good point – yes, that is correct.

Feb 8 2019, 10:29 PM · Patch-For-Review, VisualEditor-DataModel, VisualEditor

Feb 7 2019

dchan created T215567: Split TreeModifier into a tree diff generator and tree diff applier.
Feb 7 2019, 11:09 PM · Patch-For-Review, VisualEditor-DataModel, VisualEditor

Jan 22 2019

dchan added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

Let's go forward with your patch, because it's simple, neat and works fine for links, which in practice are by far the most significant case.

Jan 22 2019, 3:41 AM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)

Jan 17 2019

dchan added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

@DLynch : Do you mean when setting up a view selection or a model selection?

Jan 17 2019, 1:52 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)

Jan 14 2019

dchan added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

I think the current approach is about right for links, which have "nails" anchoring the annotation boundaries – I'll review the details of the patch later on.

Jan 14 2019, 11:17 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)

Jan 11 2019

dchan added a comment to T209984: Isolate Section Editing: Determine New Workflows .

@Neil_P._Quinn_WMF : With our implementation of section editing (T76541), we're fetching, loading and editing against the full article's data model in any case, so in technical terms a "continue editing with full article" button would be feasible.

Jan 11 2019, 6:58 PM · User-Ryasmeen, VisualEditor

Dec 15 2018

dchan added subtasks for T149667: Amazing Article Annotations: T20231: provide a way to specify what text/statement is supported by a <ref> block., T89578: Allow readers to mark a sentence/selection as needing a citation.
Dec 15 2018, 3:35 AM · Parsing-Team, Cite, VisualEditor, ContentTranslation, MediaWiki-extensions-Translate, Wikispeech, Wikimedia-Developer-Summit (2017)
dchan added a parent task for T20231: provide a way to specify what text/statement is supported by a <ref> block.: T149667: Amazing Article Annotations.
Dec 15 2018, 3:35 AM · Cite
dchan added a parent task for T89578: Allow readers to mark a sentence/selection as needing a citation: T149667: Amazing Article Annotations.
Dec 15 2018, 3:35 AM · Cite

Nov 26 2018

dchan added a comment to T209874: CX2: Unable to type diacritics in the translation.

Hello, thanks for the detailed explanation.

Nov 26 2018, 8:58 PM · VisualEditor (Current work), ContentTranslation

Nov 20 2018

dchan added a comment to T209533: Research faking linear selections on mobile.

Still thinking about programmatic (a.k.a. "fake") selections, but stepping back from the idea that they should be as similar as possible to real ones, some sort of mechanism to select large amounts of content would be useful for large copy/paste tasks (see https://www.mediawiki.org/wiki/Topic:Ul1orwmwk2q32l1v for one such request)

Nov 20 2018, 6:01 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor

Nov 16 2018

dchan added a comment to T209648: Changing text in a TargetWidget does not enable dialog's "Apply" button (in media, gallery, reference dialog) until second keypress.

Oooh, thanks. Do we think the behaviour happens because of setTimeout subtlety? (That would instinctively be my first guess but I haven't checked).

Nov 16 2018, 2:25 AM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools

Nov 14 2018

dchan created T209533: Research faking linear selections on mobile.
Nov 14 2018, 8:12 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor
dchan added a parent task for T202723: Mobile native selection context menu can obscure the VE toolbar: T209505: EPIC: Fix selection issues on mobile.
Nov 14 2018, 4:59 PM · User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan added subtasks for T209505: EPIC: Fix selection issues on mobile: T136840: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome, T204387: Can't drag a collapsed selection across a reference on mobile, T202723: Mobile native selection context menu can obscure the VE toolbar, T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly, T204718: Mobile: Selection handles obscured after scrollCursorIntoView .
Nov 14 2018, 4:59 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor
dchan added a parent task for T136840: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome: T209505: EPIC: Fix selection issues on mobile.
Nov 14 2018, 4:59 PM · Editing QA, VisualEditor (Current work), VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor-ContentEditable, VisualEditor-MediaWiki-Mobile
dchan created T209505: EPIC: Fix selection issues on mobile.
Nov 14 2018, 4:51 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor

Oct 31 2018

dchan updated the task description for T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Oct 31 2018, 4:08 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan added a comment to T206228: Analyse load time performance of FA-length pages on mobile.

See also T208428 .

Oct 31 2018, 4:05 PM · Performance-Team (Radar), Performance-Team-publish, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
dchan updated the task description for T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Oct 31 2018, 4:00 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan updated the task description for T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Oct 31 2018, 2:57 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan created T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Oct 31 2018, 2:56 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor

Oct 30 2018

dchan moved T201877: EPIC: What are the current best UI practices for mobile editing? from In progress to Code review on the VisualEditor (Current work) board.
Oct 30 2018, 5:04 PM · VisualEditor, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Design-Research, Design

Oct 29 2018

dchan created T208228: DM Selections should not cache document model data.
Oct 29 2018, 2:54 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), VisualEditor-DataModel

Oct 24 2018

dchan created T207874: Find a good way round IME limitations, especially on mobile.
Oct 24 2018, 6:11 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor

Oct 10 2018

dchan added a comment to T204387: Can't drag a collapsed selection across a reference on mobile.

I filed an upstream bug about the dragging across ce=false: https://bugs.chromium.org/p/chromium/issues/detail?id=894003

Oct 10 2018, 10:53 AM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Oct 9 2018

dchan added a comment to T204387: Can't drag a collapsed selection across a reference on mobile.

Maybe we should experiment to see whether we can get anywhere using newer features now fairly reliably available on Chrome mobile, e.g. shadow DOM.

Oct 9 2018, 1:07 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Oct 4 2018

dchan added a comment to T202138: Snapshot: what proportion of edits are made using the visual and wikitext editors?.

Hi @Neil_P._Quinn_WMF , the configuration variables shown here should help:

Oct 4 2018, 12:07 AM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics

Sep 26 2018

dchan updated the task description for T205535: Remove dedicated annotation operation types.
Sep 26 2018, 1:29 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
marcella awarded T205535: Remove dedicated annotation operation types a Mountain of Wealth token.
Sep 26 2018, 1:07 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
dchan updated the task description for T205535: Remove dedicated annotation operation types.
Sep 26 2018, 12:54 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
dchan created T205535: Remove dedicated annotation operation types.
Sep 26 2018, 11:51 AM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel

Sep 19 2018

dchan added a comment to T203580: Create technical debt heat map for VE codebase.

Here's a version where the text is more or less readable, but JPEG compressed enough that Phabricator accepts it:

Sep 19 2018, 4:20 PM · VisualEditor (Current work), Technical-Debt

Sep 14 2018

dchan added a comment to T204387: Can't drag a collapsed selection across a reference on mobile.

I guess this may be the same issue as in T203555.

Sep 14 2018, 11:07 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 13 2018

marcella awarded T203580: Create technical debt heat map for VE codebase a Doubloon token.
Sep 13 2018, 7:05 PM · VisualEditor (Current work), Technical-Debt
dchan updated the task description for T204192: Research text input support for Indian scripts.
Sep 13 2018, 7:13 AM · Language-Team, VisualEditor
dchan updated the task description for T204192: Research text input support for Indian scripts.
Sep 13 2018, 7:08 AM · Language-Team, VisualEditor
dchan updated the task description for T204192: Research text input support for Indian scripts.
Sep 13 2018, 6:57 AM · Language-Team, VisualEditor

Sep 10 2018

dchan claimed T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.
Sep 10 2018, 4:24 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan moved T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Sep 10 2018, 4:24 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan moved T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly from Up next to Current work on the VisualEditor board.
Sep 10 2018, 4:23 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan edited projects for T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly, added: VisualEditor; removed VisualEditor (Current work).

With input debugging enabled, it's easier to see that if the selection pin lands between the pre-close nail and the post-close nail then the selection collapses. In fact you can see this just editing <h1><a href='x'>foo</a> bar</h1>.

Sep 10 2018, 4:20 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Sep 5 2018

dchan moved T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome) from To Triage to Needs Discussion/Analysis on the VisualEditor board.
Sep 5 2018, 4:41 PM · VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan moved T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly from To Triage to Needs Discussion/Analysis on the VisualEditor board.
Sep 5 2018, 4:38 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

Given the context disappearance is an iOS-specific issue, would it be worth doing the 60px scroll on non-iOS devices only?

Sep 5 2018, 2:09 PM · User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan closed T64028: VisualEditor: Cursor skips by one character for Thai characters (expected skipping by one block) as Resolved.

This is working now; I guess it has been since 2d8c3e799601d3eb70127b32e262dbe1d64a7e4e .

Sep 5 2018, 1:39 PM · User-Ryasmeen, I18n, VisualEditor, VisualEditor-ContentLanguage
dchan closed T64028: VisualEditor: Cursor skips by one character for Thai characters (expected skipping by one block), a subtask of T35077: VisualEditor multilingual input / i18n issues (tracking), as Resolved.
Sep 5 2018, 1:39 PM · VisualEditor, Tracking-Neverending, VisualEditor-ContentLanguage
dchan added a parent task for T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly: T202647: Assess VE mobile text input situation for each target wiki.
Sep 5 2018, 12:23 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan added a subtask for T202647: Assess VE mobile text input situation for each target wiki: T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.
Sep 5 2018, 12:23 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage
dchan created T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.
Sep 5 2018, 12:20 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan added a comment to T50429: [Epic] Support editing parts of a page in VisualEditor-MediaWiki.

Thanks @kaldari! As I understand it the fundamental differences between T76541 and T146072 are:

Sep 5 2018, 2:29 AM · VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki

Sep 4 2018

dchan updated the task description for T202647: Assess VE mobile text input situation for each target wiki.
Sep 4 2018, 5:24 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage

Sep 3 2018

dchan updated the task description for T202647: Assess VE mobile text input situation for each target wiki.
Sep 3 2018, 6:02 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage
dchan renamed T202647: Assess VE mobile text input situation for each target wiki from Assess the current VE-mobile situation for target wikis to Assess VE mobile text input situation for each target wiki.
Sep 3 2018, 6:00 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage

Aug 29 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

@matmarex Ohhh that's a really good point. And unfortunately you're right to be suspicious; some IMEs can add / remove whitespace without committing all candidate text so we can't safely rerender.

Aug 29 2018, 3:43 PM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Aug 28 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

@matmarex , do you want to go forward with the solution you suggested? (I.e. use &nbsp; for every other space, on NWE only)

Aug 28 2018, 8:37 AM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Aug 26 2018

dchan added a comment to T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome).

Hmm, looking at the Filibuster trace, it looks very much like the native backspace action leaves the DOM unchanged. Will investigate further.

Aug 26 2018, 12:09 PM · VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Aug 24 2018

dchan updated subscribers of T202723: Mobile native selection context menu can obscure the VE toolbar.

@Esanders , should we work round this by having a minimum gap above the CE surface?

Aug 24 2018, 12:29 PM · User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan updated the task description for T202723: Mobile native selection context menu can obscure the VE toolbar.
Aug 24 2018, 12:26 PM · User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan created T202723: Mobile native selection context menu can obscure the VE toolbar.
Aug 24 2018, 12:24 PM · User-Ryasmeen, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan created T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome).
Aug 24 2018, 11:12 AM · VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Aug 23 2018

dchan added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

I don't know much about this, but will/can we get the data broken down by wiki (and therefore effectively by language)? That could be pretty useful for script / IME support purposes

Aug 23 2018, 5:19 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
dchan created T202647: Assess VE mobile text input situation for each target wiki.
Aug 23 2018, 4:55 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage

Aug 20 2018

dchan updated the task description for T116275: DM/DOM sync can break if you use an IME.
Aug 20 2018, 2:05 PM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Epic, VisualEditor-ContentEditable, VisualEditor