Page MenuHomePhabricator

dchan (David Chan)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 23 2014, 10:14 AM (488 w, 1 d)
Availability
Available
IRC Nick
divec
LDAP User
Unknown
MediaWiki User
DChan (WMF) [ Global Accounts ]

Recent Activity

Thu, Feb 29

dchan changed the status of T346157: Documentation for VisualEditor internals from Open to In Progress.
Thu, Feb 29, 10:04 AM · Editing-team (Kanban Board), VisualEditor
dchan changed the status of T358747: Write a set of exercises for learning the VisualEditor source code from Open to In Progress.
Thu, Feb 29, 10:04 AM · VisualEditor
dchan created T358747: Write a set of exercises for learning the VisualEditor source code.
Thu, Feb 29, 10:04 AM · VisualEditor
dchan closed T349265: Investigate feasibility of leveraging the sentencex library within Edit Check as Resolved.
Thu, Feb 29, 9:55 AM · Goal, Editing-team (Kanban Board), EditCheck
dchan closed T349265: Investigate feasibility of leveraging the sentencex library within Edit Check, a subtask of T347643: Enable volunteers to define new content added in terms of sentences, as Resolved.
Thu, Feb 29, 9:55 AM · Editing-team, EditCheck
dchan added a comment to T349265: Investigate feasibility of leveraging the sentencex library within Edit Check.

We have decided the Editing Team will not use sentencex for the time being as we are not ready to commit to a sentence boundary API. We can revisit this in future as circumstances change.

Thu, Feb 29, 9:52 AM · Goal, Editing-team (Kanban Board), EditCheck

Oct 20 2023

dchan added a comment to T349265: Investigate feasibility of leveraging the sentencex library within Edit Check.

Issue in the sentencex-js repo: https://github.com/wikimedia/sentencex-js/issues/1

Oct 20 2023, 2:52 AM · Goal, Editing-team (Kanban Board), EditCheck
dchan added a comment to T349265: Investigate feasibility of leveraging the sentencex library within Edit Check.

I've taken a look at sentencex-js specifically, which I understand has been ported from the sentencex original written in python. It looks good! There is certainly significant overlap with the Editing Team's UnicodeJS sentencebreak code.

Oct 20 2023, 2:32 AM · Goal, Editing-team (Kanban Board), EditCheck

Sep 28 2023

ppelberg awarded T324363: Investigate sentence splitting a Like token.
Sep 28 2023, 11:33 PM · Release, Goal, Patch-For-Review, EditCheck, Spike

Sep 26 2023

dchan added a comment to T324363: Investigate sentence splitting.

Examining the code's behaviour on the citation placement examples above, we can see that positions ⓿❶❷❸ would be sufficient for all those examples, except the Japanese close bracket, for which the citation placement comes before the Unicode TR29 definition of a sentence boundary would begin.

Sep 26 2023, 3:54 PM · Release, Goal, Patch-For-Review, EditCheck, Spike
dchan added a comment to T324363: Investigate sentence splitting.

Patchdemo instance of the above patch set (thanks @DLynch) https://patchdemo.wmflabs.org/wikis/4b31a139ad/w/index.php?title=Douglas_Adams&veaction=edit

Sep 26 2023, 3:46 PM · Release, Goal, Patch-For-Review, EditCheck, Spike
dchan added a comment to T324363: Investigate sentence splitting.

Proof-of-concept patch set to surface sentence segmentation in VisualEditor: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/961095

Sep 26 2023, 3:30 PM · Release, Goal, Patch-For-Review, EditCheck, Spike
dchan added a comment to T347385: VisualEditor unit tests will not run on Firefox snap.

The proof of concept patch set above is probably no good for CI and messy even for local development. It may be better just to fix the upstream bug.

Sep 26 2023, 10:34 AM · Patch-For-Review, VisualEditor
dchan added a comment to T347385: VisualEditor unit tests will not run on Firefox snap.

Upstream issue: https://github.com/karma-runner/karma-firefox-launcher/issues/183 . They suggest a workaround of using a custom launcher FirefoxCustom that passes profile: <some-temp-dir>. This works but you have to create the tempdir yourself. Contrary to the discussion there, just setting TMPDIR=/var/tmp in the environment does not seem to work.

Sep 26 2023, 10:20 AM · Patch-For-Review, VisualEditor
dchan created T347385: VisualEditor unit tests will not run on Firefox snap.
Sep 26 2023, 10:04 AM · Patch-For-Review, VisualEditor
dchan created T347380: VisualEditor unit tests will not run on Chromium snap.
Sep 26 2023, 9:07 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), VisualEditor

Sep 12 2023

dchan created T346157: Documentation for VisualEditor internals.
Sep 12 2023, 2:52 PM · Editing-team (Kanban Board), VisualEditor

Jun 27 2023

dchan closed T142320: Allow client to send back empty top-level sections if they are unchanged, a subtask of T55093: For very large pages on slow connections (when a timeout happens?), users get an "Error: Unknown error" on saving changes in VisualEditor (but change is indeed saved), as Declined.
Jun 27 2023, 4:09 PM · VisualEditor-Performance, VisualEditor, VisualEditor-MediaWiki
dchan closed T142320: Allow client to send back empty top-level sections if they are unchanged as Declined.
Jun 27 2023, 4:08 PM · Epic, VisualEditor, Parsoid

Jun 22 2023

dchan created T340088: Trigger reference check only on pure insertions (remove.length === 0).
Jun 22 2023, 1:34 AM · Verified, MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Editing-team (Kanban Board), EditCheck

Apr 22 2023

dchan claimed T334677: Internal copy/paste can cause an unbalanced transaction.
Apr 22 2023, 3:16 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Editing-team (Kanban Board), VisualEditor-CopyPaste, VisualEditor-ContentEditable, VisualEditor
dchan claimed T333710: Fix TransactionSquasher crashes.
Apr 22 2023, 3:16 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Goal, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
dchan updated the task description for T334677: Internal copy/paste can cause an unbalanced transaction.
Apr 22 2023, 3:14 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Editing-team (Kanban Board), VisualEditor-CopyPaste, VisualEditor-ContentEditable, VisualEditor

Apr 14 2023

dchan added a comment to T334677: Internal copy/paste can cause an unbalanced transaction.

The above patch set fixes the case described above. More generally, is it correct that the paste code should pass arbitrary unbalanced content to the TransactionProcessor, and rely on an error being thrown to switch to "safer" processing? Or is that something we wish to change?

Apr 14 2023, 2:07 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Editing-team (Kanban Board), VisualEditor-CopyPaste, VisualEditor-ContentEditable, VisualEditor

Apr 13 2023

dchan added a comment to T333710: Fix TransactionSquasher crashes.

After investigating, I think the "Remove does not match insert" errors are caused by actual invalid transactions: see T334677 .

Apr 13 2023, 2:44 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Goal, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
dchan created T334677: Internal copy/paste can cause an unbalanced transaction.
Apr 13 2023, 2:37 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Editing-team (Kanban Board), VisualEditor-CopyPaste, VisualEditor-ContentEditable, VisualEditor

Apr 12 2023

dchan added a comment to T333710: Fix TransactionSquasher crashes.

The patch set above fixes the "Unexpected prior attribute value" errors.

Apr 12 2023, 1:35 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Goal, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor

Mar 16 2023

dchan added a comment to T331083: Link up WIP sentence splitting to content detection.

This update better detects inserted text, by disregarding HTML tree structure (which isn't very relevant for these purposes).

Mar 16 2023, 1:45 PM · EditCheck
dchan added a comment to T331686: Evaluate reliability of sentence splitting approach.

I think these are good suggestions. I'd also suggest adding an Indic script.

Mar 16 2023, 12:51 PM · Goal, EditCheck, Editing-team (Kanban Board), Spike

Mar 8 2023

dchan added a comment to T324733: Introduce a tag to identify edits that meet the Edit Check heuristic .

Oh, probably I'm not being clear. I was thinking:

  • we want to tag edits that should contain a reference (according to our heuristic)
  • regardless whether or not they do contain one
  • and regardless whether the reference check UI is deployed
Mar 8 2023, 3:18 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Editing-team (Kanban Board), EditCheck, VisualEditor

Mar 3 2023

dchan added a subtask for T324363: Investigate sentence splitting: T331083: Link up WIP sentence splitting to content detection.
Mar 3 2023, 3:44 AM · Release, Goal, Patch-For-Review, EditCheck, Spike
dchan added a parent task for T331083: Link up WIP sentence splitting to content detection: T324363: Investigate sentence splitting.
Mar 3 2023, 3:44 AM · EditCheck
dchan created T331083: Link up WIP sentence splitting to content detection.
Mar 3 2023, 3:44 AM · EditCheck
dchan added a comment to T324733: Introduce a tag to identify edits that meet the Edit Check heuristic .

On reflection, I suggest we consider removing requirement 1B ("the new paragraph does not include a reference"), because:

Mar 3 2023, 1:46 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Editing-team (Kanban Board), EditCheck, VisualEditor
dchan added a subtask for T324363: Investigate sentence splitting: T331080: Hook up WIP sentence splitting as a bookmarklet.
Mar 3 2023, 1:32 AM · Release, Goal, Patch-For-Review, EditCheck, Spike
dchan added a parent task for T331080: Hook up WIP sentence splitting as a bookmarklet: T324363: Investigate sentence splitting.
Mar 3 2023, 1:32 AM · EditCheck
dchan created T331080: Hook up WIP sentence splitting as a bookmarklet.
Mar 3 2023, 1:32 AM · EditCheck

Feb 23 2023

dchan added a comment to T324363: Investigate sentence splitting.

We're currently envisaging two uses for sentence segmentation in Edit Check:

Feb 23 2023, 3:58 PM · Release, Goal, Patch-For-Review, EditCheck, Spike

Feb 22 2023

dchan added a comment to T325129: On-screen keyboard disappears when cursor encounters non-breaking space in Chrome; cannot delete nbsp in Firefox.

Based on investigations, I believe Change 881705 fixes the likeliest occurrences of this Gboard bug. I don't think it breaks any case that works at the moment, even though it allows the user to experience T330284 (which needs a separate fix).

Feb 22 2023, 12:47 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team, VisualEditor-ContentEditable, VisualEditor, VisualEditor-MediaWiki-Mobile
dchan added a comment to T330284: English Gboard causes corruption when backspacing a focusable node that ends with a Latin letter.

Technical notes copied from T325129:

Feb 22 2023, 12:40 PM · Patch-For-Review, VisualEditor-ContentEditable, VisualEditor
dchan created T330284: English Gboard causes corruption when backspacing a focusable node that ends with a Latin letter.
Feb 22 2023, 12:27 PM · Patch-For-Review, VisualEditor-ContentEditable, VisualEditor

Jan 11 2023

dchan added a comment to T325129: On-screen keyboard disappears when cursor encounters non-breaking space in Chrome; cannot delete nbsp in Firefox.

Yes, here is a viable fixup for the above case:

  1. On an input event of inputType 'deleteContentBackward', save the current cursor position (but only if the selection is collapsed).
  2. If a subsequent keyup event occurs during the same tick, and lands inside a contentEditable=false node, then restore the saved cursor position.
  3. In any case, clear the saved cursor position at the end of the tick (i.e. using setTimeout).

The fixup has to occur in the keyup event: waiting for the more logical selectionchange event means the soft keyboard has already closed and it's too late.

Jan 11 2023, 12:06 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team, VisualEditor-ContentEditable, VisualEditor, VisualEditor-MediaWiki-Mobile

Jan 10 2023

dchan added a comment to T325129: On-screen keyboard disappears when cursor encounters non-breaking space in Chrome; cannot delete nbsp in Firefox.

This appears to happen because English Gboard + Android Chrome lets the cursor land inside a contenteditable=false span. It does not happen with certain other Gboard languages (e.g. Cantonese). Below is a minimal test case.

Jan 10 2023, 11:03 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team, VisualEditor-ContentEditable, VisualEditor, VisualEditor-MediaWiki-Mobile

Jul 29 2022

dchan added a comment to T312558: Google Keyboard input events can leave VisualEditor DM out of sync.

Change 812093 Patch set 5 handles the <div><br></div> but fails in other cases (e.g. when the native action adds a list item).

Jul 29 2022, 8:55 AM · Verified, MW-1.40-notes (1.40.0-wmf.4; 2022-10-03), Editing-team (Kanban Board), VisualEditor-ContentEditable, VisualEditor, Browser-Support-Android-Google-Chrome, VisualEditor-MediaWiki-Mobile
dchan added a comment to T312558: Google Keyboard input events can leave VisualEditor DM out of sync.

Ok, change 812093 triggers the VE Enter handler — which is a big improvement! As it stands, it still leaves a spurious <div><br></div>, into which we can drag the cursor and type text which then doesn't get put into the model (see screenshot). We should check for this spurious div and clean it up — and as a bonus, we can condition triggering the VE Enter handler on finding this div, so that if another IME behaves as we want it to already, then it won't be affected.

Jul 29 2022, 8:34 AM · Verified, MW-1.40-notes (1.40.0-wmf.4; 2022-10-03), Editing-team (Kanban Board), VisualEditor-ContentEditable, VisualEditor, Browser-Support-Android-Google-Chrome, VisualEditor-MediaWiki-Mobile

Jul 5 2022

dchan added a comment to T312174: Provide a way to run undeployed VE code against live mediawiki instances.

The video below shows the bookmarklet used to run undeployed code against a live mediawiki instance:

Jul 5 2022, 9:44 PM · Patch-For-Review, VisualEditor
dchan created T312174: Provide a way to run undeployed VE code against live mediawiki instances.
Jul 5 2022, 8:53 PM · Patch-For-Review, VisualEditor
dchan moved T261662: undo/redo is slow on large documents from Doing to Code Review on the Editing-team (Kanban Board) board.
Jul 5 2022, 8:07 PM · Patch-For-Review, User-Ryasmeen, Performance Issue, VisualEditor-ContentEditable, VisualEditor
dchan moved T311513: Fix or remove well-formedness check in ve.dm.TransactionProcessor from Doing to Code Review on the Editing-team (Kanban Board) board.
Jul 5 2022, 8:07 PM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor-DataModel, VisualEditor
dchan added a comment to T261662: undo/redo is slow on large documents.

On a quick test I see a ~5x speedup, testing on 809052 and 909093 above.

Jul 5 2022, 8:04 PM · Patch-For-Review, User-Ryasmeen, Performance Issue, VisualEditor-ContentEditable, VisualEditor

Jun 28 2022

dchan updated the task description for T308714: Spike: Make proof of concept VE link context using Vue.
Jun 28 2022, 2:08 PM · Editing-team (Kanban Board), Design-System-Team, Vue.js, VisualEditor
dchan moved T308714: Spike: Make proof of concept VE link context using Vue from Incoming to Doing on the Editing-team (Kanban Board) board.
Jun 28 2022, 2:07 PM · Editing-team (Kanban Board), Design-System-Team, Vue.js, VisualEditor
dchan added a project to T308714: Spike: Make proof of concept VE link context using Vue: Editing-team (Kanban Board).
Jun 28 2022, 2:06 PM · Editing-team (Kanban Board), Design-System-Team, Vue.js, VisualEditor
dchan moved T311513: Fix or remove well-formedness check in ve.dm.TransactionProcessor from Incoming to Doing on the Editing-team (Kanban Board) board.
Jun 28 2022, 1:51 PM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor-DataModel, VisualEditor
dchan moved T261662: undo/redo is slow on large documents from Ready for Sign Off to Doing on the Editing-team (Kanban Board) board.
Jun 28 2022, 1:51 PM · Patch-For-Review, User-Ryasmeen, Performance Issue, VisualEditor-ContentEditable, VisualEditor
dchan claimed T261662: undo/redo is slow on large documents.
Jun 28 2022, 1:50 PM · Patch-For-Review, User-Ryasmeen, Performance Issue, VisualEditor-ContentEditable, VisualEditor
dchan claimed T311513: Fix or remove well-formedness check in ve.dm.TransactionProcessor.
Jun 28 2022, 1:49 PM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor-DataModel, VisualEditor
dchan triaged T311513: Fix or remove well-formedness check in ve.dm.TransactionProcessor as Low priority.
Jun 28 2022, 1:41 PM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor-DataModel, VisualEditor
dchan created T311513: Fix or remove well-formedness check in ve.dm.TransactionProcessor.
Jun 28 2022, 1:40 PM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor-DataModel, VisualEditor
dchan added a comment to T261662: undo/redo is slow on large documents.

It's done because a model change within a ContentBranchNode gets propagated to the view by replacing the entire contents of the CBN, which resets the native selection to the start of the CBN.

Jun 28 2022, 5:54 AM · Patch-For-Review, User-Ryasmeen, Performance Issue, VisualEditor-ContentEditable, VisualEditor

Mar 30 2022

dchan added a comment to T304579: Create user experience for when a comment can't be found on the page, but is available on another page (e.g. an archive).

How about "topic is renamed"?

Mar 30 2022, 2:41 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Design, TPP-Phase1, Goal, DiscussionTools

Feb 10 2022

dchan renamed T230325: Make each ve.ce.ContentBranchNode track its own most recently rendered state from Make each ve.ce.ContentBranchNode track its own most recently rendered state. to Make each ve.ce.ContentBranchNode track its own most recently rendered state.
Feb 10 2022, 3:44 AM · Patch-Needs-Improvement, Editing-team (Tracking), VisualEditor, VisualEditor-ContentEditable
dchan added a comment to T220629: Right click to delete across paragraphs in Firefox results in no model transaction.

Deleted text is supported by resolving T230325 . Deleted DOM nodes need T230323 (which does not fix deleted text).

Feb 10 2022, 3:43 AM · VisualEditor, VisualEditor-ContentEditable
dchan renamed T230325: Make each ve.ce.ContentBranchNode track its own most recently rendered state from Make each ve.ce.ContentBranchNode track its own ve.ce.TextState to Make each ve.ce.ContentBranchNode track its own most recently rendered state..
Feb 10 2022, 3:40 AM · Patch-Needs-Improvement, Editing-team (Tracking), VisualEditor, VisualEditor-ContentEditable
dchan updated the task description for T220629: Right click to delete across paragraphs in Firefox results in no model transaction.
Feb 10 2022, 3:28 AM · VisualEditor, VisualEditor-ContentEditable

Jan 20 2022

dchan added a comment to T111672: Ugly wrapping of link cartouches.

Glitch behaviour for the 754986 option

Jan 20 2022, 8:41 AM · VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor
dchan added a comment to T111672: Ugly wrapping of link cartouches.

@matmarex coded the approach of styling the link node with "white-space: no-wrap", then adding an inner span styled as "white-space: normal". See here: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/754986/

Jan 20 2022, 8:36 AM · VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor

Dec 22 2021

Waddie96 awarded T274814: In VisualEditor clicking white space to the right of the end of a paragraph does not place cursor correctly a Burninate token.
Dec 22 2021, 4:13 PM · Verified, Editing-team (Kanban Board), VisualEditor

Dec 10 2021

dchan added a comment to T296905: Content pasted just after a link is always placed inside a link.

Confirmed that this happens even with the cursor outside the link cartouche. It happens because the paste is calculated entirely within the DM, and the DM cursor positions do not specify on which side of the annotation boundary they lie.

Dec 10 2021, 2:56 AM · Verified, Editing-team (Kanban Board), VisualEditor-CopyPaste, VisualEditor

Nov 9 2021

dchan added a comment to T295166: Determine how the TextInput component should work with IMEs.

Some brief points from our conversation just now. It's great that you're looking at this issue early on, so thank you!

Nov 9 2021, 5:18 PM · Design-System-Team, Codex

Oct 19 2021

dchan added a comment to T293661: Clicking from text to a link in iOS Safari doesn't open the link context.

Hmm, can't reproduce the behaviour on iOS 12. Can you give a specific minimal example (exactly what content, where to click etc)?

Oct 19 2021, 10:23 AM · Verified, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Editing-team (Kanban Board), VisualEditor
dchan added a comment to T274068: Can't place cursor to the right of a link at the end of paragraph (beyond the cartouche/nail) by clicking..

I think the second patch means you may have to tap again sometimes to get into the link, but that's better than not being able to drop the cursor outside the link at all.

Oct 19 2021, 12:26 AM · Verified, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), VisualEditor-ContentEditable, Editing-team (Kanban Board), VisualEditor

Jun 6 2021

dchan claimed T284402: Don't show toolbar in LanguageVariantInspector text targets.
Jun 6 2021, 4:20 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
dchan moved T284402: Don't show toolbar in LanguageVariantInspector text targets from Incoming to Doing on the Editing-team (Kanban Board) board.
Jun 6 2021, 4:19 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
dchan added a project to T284402: Don't show toolbar in LanguageVariantInspector text targets: Editing-team (Kanban Board).
Jun 6 2021, 4:19 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
dchan added a comment to T284402: Don't show toolbar in LanguageVariantInspector text targets.

Without the toolbars, the interface is less unwieldy and easier to navigate, especially on mobile:

LanguageVariantInspector2.png (596×402 px, 39 KB)

Jun 6 2021, 4:13 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
dchan created T284402: Don't show toolbar in LanguageVariantInspector text targets.
Jun 6 2021, 3:55 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor

May 23 2021

dchan created T283445: Error when selecting an image on mobile.
May 23 2021, 3:10 AM · Skipped QA, Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor

Mar 16 2021

dchan added a comment to T274068: Can't place cursor to the right of a link at the end of paragraph (beyond the cartouche/nail) by clicking..

Hmmm I'm not seeing this as a regression — I get the same behaviour going right back to 2016. Investigating further.

Mar 16 2021, 1:33 PM · Verified, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), VisualEditor-ContentEditable, Editing-team (Kanban Board), VisualEditor
dchan added a comment to T272207: Unable to place cursor or type after reference at end of line.

This is due to a Firefox issue. A minimal test case for it is:

Mar 16 2021, 1:22 PM · Editing-team, Browser-Support-Firefox, VisualEditor-ContentEditable, VisualEditor-MediaWiki-References, VisualEditor

Mar 2 2021

dchan claimed T276164: Opening special character toolbar moves the cursor to [1,1].
Mar 2 2021, 4:47 PM · Verified, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Editing-team (Kanban Board), Regression, VisualEditor

Jan 16 2021

dchan created T272219: ve.dm.Surface#setNullSelection should not clear a native selection that is outside of the document.
Jan 16 2021, 3:01 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor

Oct 21 2020

dchan added a comment to T195265: As a Chinese reader, I want better control of which character set I see zh wiki content in.

If I've understood the meaning of the diagram above correctly, I don't think the fallback case will ever happen — because LanguageConverter will always return output for whichever zh variant is specified.

Oct 21 2020, 6:03 AM · iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower, Chinese-Sites, Wikipedia-iOS-App-Backlog

Jul 2 2020

dchan added a comment to T247083: Research spike: vue.js and visual editor.

Further detail (from discussing with @DLynch): it's not clear what document data a top-level wrapper could usefully expose as a Vue-style reactive property.

Jul 2 2020, 5:23 PM · Editing-team (Kanban Board), Design-Systems-team-20200324-20220422, Spike, VisualEditor

Apr 24 2020

dchan added a comment to T250702: Document corruption when inserting linebreak while annotating.

Ah, i see ... with TreeModifier, pressing Enter at the end of a paragraph leaves that paragraph unchanged (whereas before TreeModifier, it was getting rebuilt entirely). Then it moves the focus into the new paragraph below. That means we're escaping the paragraph without cleaning up the unicorns, which the current code assumes to be impossible.

Apr 24 2020, 9:52 AM · User-Ryasmeen, Skipped QA, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing-team (Q3 2019-2020 Kanban Board), Regression, VisualEditor, VisualEditor-ContentEditable

Mar 18 2020

ToBeFree awarded T246481: Prevent page corruption in DiscussionTools caused by broken and incomplete table syntax a Like token.
Mar 18 2020, 12:58 AM · Skipped QA, Editing-team (Kanban Board), MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), OWC2020 (OWC2020 Replying 1.0), DiscussionTools

Mar 10 2020

dchan added a comment to T246481: Prevent page corruption in DiscussionTools caused by broken and incomplete table syntax.

As discussed, I'll base on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DiscussionTools/+/578387/ and use the https://en.wikipedia.org/api/rest_v1/page/lint api.

Mar 10 2020, 4:17 PM · Skipped QA, Editing-team (Kanban Board), MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), OWC2020 (OWC2020 Replying 1.0), DiscussionTools

Feb 15 2020

marcella awarded T243860: Clicking on a slug while the selection is inside a table causes an exception a Cookie token.
Feb 15 2020, 7:39 PM · User-Ryasmeen, Verified, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VisualEditor-ContentEditable

Jan 28 2020

dchan added a comment to T243860: Clicking on a slug while the selection is inside a table causes an exception.

The table selection update is incorrect, because we're calling tx.translateRange with excludeInsertion=false, but there should always be excludeInsertion=true for a table.

Jan 28 2020, 8:23 PM · User-Ryasmeen, Verified, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VisualEditor-ContentEditable
dchan updated the task description for T243860: Clicking on a slug while the selection is inside a table causes an exception.
Jan 28 2020, 8:22 PM · User-Ryasmeen, Verified, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VisualEditor-ContentEditable
dchan created T243860: Clicking on a slug while the selection is inside a table causes an exception.
Jan 28 2020, 8:07 PM · User-Ryasmeen, Verified, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), VisualEditor-ContentEditable

Jan 22 2020

dchan added a comment to T233480: Find a way to detect unhandled jQuery promise rejections in VisualEditor.

The technique in https://gerrit.wikimedia.org/r/539074 does work. And I've used that patchset a few times now to debug silent errors. But it's perhaps too hacky to merge even for debug mode only (it shadows each jQuery promise with a native promise). Maybe it could be merged but needing specific activation.

Jan 22 2020, 7:05 PM · MediaWiki-Platform-Team (Radar), Developer Productivity, MediaWiki-ResourceLoader, VisualEditor, Editing-team (Tracking)

Jan 7 2020

dchan claimed T185546: EventEmitters must behave appropriately if a handler raises an exception.
Jan 7 2020, 5:34 PM · VisualEditor (Current work), OOjs core, VisualEditor-DataModel
dchan created T242134: Security Review For Talk pages project.
Jan 7 2020, 5:21 PM · secscrum, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Security, user-sbassett, Editing-team (Tracking), DiscussionTools, Application Security Reviews

Dec 19 2019

dchan added a comment to T240955: Firefox CI tests keep failing in VE with Firefox 68.

Ooh, thanks!

Dec 19 2019, 5:14 PM · Release-Engineering-Team, Patch-For-Review, Technical-Debt, Editing-team (Tracking), Continuous-Integration-Config, VisualEditor

Dec 3 2019

dchan added a comment to T239209: XSS in Visual Editor via Copy&Paste (CVE-2019-19708).

Apologies @sbassett , I judged the patch wasn't particularly revealing but maybe that wasn't really my call. Given it's already up, should we now proceed as we would with a non-security-related UBN?

Dec 3 2019, 1:00 AM · Security, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS

Dec 2 2019

dchan added a project to T239209: XSS in Visual Editor via Copy&Paste (CVE-2019-19708): Patch-For-Review.

This patchset should fix ithe security issue: https://gerrit.wikimedia.org/r/553888

Dec 2 2019, 11:08 PM · Security, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS

Nov 27 2019

dchan claimed T239209: XSS in Visual Editor via Copy&Paste (CVE-2019-19708).
Nov 27 2019, 4:57 PM · Security, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS

Oct 21 2019

dchan added a comment to T235959: Visual Editor: deleting selected text not working.

Yes that looks like the same pattern – thanks for the additional info!

Oct 21 2019, 10:12 AM · Verified, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), VisualEditor-DataModel, VisualEditor (Current work)
dchan added a comment to T235959: Visual Editor: deleting selected text not working.

Technical details for triage: this is triggered if a transaction contains a removal starting in the interior of a text node, crosses an inline element, and moves immediately into another text node, and then is followed by a subsequent retain and removal. See the patch set above for a minimal example.

Oct 21 2019, 3:11 AM · Verified, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), VisualEditor-DataModel, VisualEditor (Current work)