dchan (David Chan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 23 2014, 10:14 AM (186 w, 3 d)
Availability
Available
IRC Nick
divec
LDAP User
Unknown
MediaWiki User
DChan (WMF)

Recent Activity

Today

dchan added a comment to T76541: Load/display document-level data (e.g. internal lists, meta lists) for the whole document but only the content for a part of the document.

As well as the approach in https://gerrit.wikimedia.org/r/433753 , we should also consider the following alternative:

  • A class provides the LinearData interface on a live slice of the linear data (performing offset translation and bounds checking)
  • ve.dm.Document builds on top of that class

That approach would more robustly prevent access outside the slice. But one drawback would be apparent dangling references in the slice.

Sun, May 20, 7:47 AM · Patch-For-Review, VisualEditor (Current work), Epic, VisualEditor-MediaWiki, VisualEditor-Performance

Fri, May 18

dchan added a comment to T49344: Internal nodes should eventually be in a separate document ("sub-documents").

Here is a proposal for refinement:

Fri, May 18, 2:10 PM · Epic, Patch-For-Review, VisualEditor-Performance, VisualEditor, Technical-Debt

Wed, May 2

dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

With change 430413, "change citation, undo, redo" seems to work fine in all the cases I've tried.

Wed, May 2, 4:53 PM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools
dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

Hmm, thanks, it seems I overlooked that there are a few different ways reference-instead-of-copy can happen here - investigating further.

Wed, May 2, 9:10 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools

Sun, Apr 29

dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

Ooooh, this happens because ve.dm.TransactionBuilder#pushAttributeChanges( { key: val }, ... ) puts a live reference to val into the Transaction object. So if val subsequently gets mutated, that invalidates the Transaction object.

Sun, Apr 29, 2:52 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools

Apr 15 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (?).

A hotfix for the problem I describe is to open the console (CTRL+SHIFT+i), then type

$( '.ve-ce-surface' ).css( 'word-break', 'break-all' )

then press <ENTER>, then close the console (CTRL+SHIFT+i again).

Apr 15 2018, 2:40 AM · VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor
dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (?).

Oh, I can reproduce what might be the same problem, or at least related: I think it's to do with browser rules for wrapping spaces.

Apr 15 2018, 2:29 AM · VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Apr 11 2018

dchan added a comment to T171374: Make CodeMirror support IME functionality.

That sounds like a good idea, because even if we switched to listening for keydown, we'd be depending on our keydown listener to run first, which would be quite brittle.

Apr 11 2018, 4:41 AM · Patch-For-Review, UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan added a comment to T171374: Make CodeMirror support IME functionality.

@MusikAnimal I think listening to keydown might work here, but might break other uses of jQuery.IME . If it does work here, perhaps we could consider making it an option. Anyone want to try changing the binding and see whether it works?

Apr 11 2018, 1:16 AM · Patch-For-Review, UniversalLanguageSelector, MediaWiki-extensions-CodeMirror

Apr 8 2018

dchan edited projects for T191700: VE: Avoid piping links for formatting where possible, added: Parsoid; removed VisualEditor-EditingTools, VisualEditor.

Thanks SoWhy, things like this would happen during the HTML->wikitext conversion in Parsoid, so I've tagged it as an issue for the Parsoid team to look at.

Apr 8 2018, 1:32 AM · Patch-For-Review, Parsoid

Mar 19 2018

dchan moved T188709: Annotation ordering is hazily defined in Transactions from In progress to Code review and QA on the VisualEditor (Current work) board.
Mar 19 2018, 4:47 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 15 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Well, it should improve such situations by giving us the precision to treat them all properly.

Mar 15 2018, 9:00 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 14 2018

dchan added a comment to T171374: Make CodeMirror support IME functionality.

Oh, the keypress behaviour we're seeing in Chromium doesn't seem to happen on the CodeMirror demo, either on https://codemirror.net/index.html (presumably the current version 5.35.0) or bundled in http://codemirror.net/codemirror-5.30.0.zip (which is the version the mediawiki extension currently includes).

Mar 14 2018, 12:56 PM · Patch-For-Review, UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan closed T189643: Error while building VE document model with a translation section containing block image as Resolved.

See https://gerrit.wikimedia.org/r/#/c/419151/1..2/modules/ve-cx/dm/ve.dm.CXBlockImageNode.js .

Mar 14 2018, 11:29 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T189643: Error while building VE document model with a translation section containing block image.

Oh, of course - we have to allow mwImageCaption to have cxBlockImageNode as a parent ... I'll upload a patch

Mar 14 2018, 11:25 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T189643: Error while building VE document model with a translation section containing block image.

After debugging this with the help of @santhosh , It seems ve.dm.Document#fixupInsertion is returning unbalanced data . Before the fixup, we have:

Mar 14 2018, 9:26 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T171374: Make CodeMirror support IME functionality.

Ok, I put some small fixes into https://gerrit.wikimedia.org/r/#/c/398602/5/ and https://gerrit.wikimedia.org/r/#/c/399460/5/ .

Mar 14 2018, 5:39 AM · Patch-For-Review, UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan added a comment to T171374: Make CodeMirror support IME functionality.

Hi, it's currently not working for me on either Firefox 57 or Chromium 63, both on Ubuntu. Here are exact steps to reproduce:

Mar 14 2018, 4:38 AM · Patch-For-Review, UniversalLanguageSelector, MediaWiki-extensions-CodeMirror

Mar 13 2018

dchan added a comment to T189118: Find out why a <nowiki/> tag are causing edits to get mangled.

Hmmm, that makes sense, because since 21a5d55b85dd , we only round-trip the meta item back into the ContentBranchNode on serialization if the ContentBranchNode is unmodified - so clearly if the <nowiki/> is being used to separate out pieces of wiki syntax, the behaviour will now not be as intended.

Mar 13 2018, 9:15 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan reassigned T189118: Find out why a <nowiki/> tag are causing edits to get mangled from dchan to matmarex.
Mar 13 2018, 9:03 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan claimed T189118: Find out why a <nowiki/> tag are causing edits to get mangled.

Thanks @matmarex (and oops) - taking a look.

Mar 13 2018, 8:51 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan added a comment to T189557: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines.

Thanks, @matmarex ! The purpose of the TreeModifier is to perform the linear modifiations in an order such that the tree structure is at all times valid and the view can stay closely in sync with the linear model. Even so, there may be scope to reduce the number of splices in such an obvious case - I'll take a look.

Mar 13 2018, 6:35 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Mar 12 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Change 416735 fixes this

Mar 12 2018, 7:54 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 5 2018

dchan moved T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store from Up next to Code review and QA on the VisualEditor (Current work) board.
Mar 5 2018, 9:44 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel
dchan moved T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store from To Triage to Current work on the VisualEditor board.
Mar 5 2018, 9:43 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel
dchan added a project to T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store: Technical-Debt.
Mar 5 2018, 9:39 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel
dchan created T188900: Rename ve.dm.IndexValueStore to ve.dm.HashValueStore, as it is now a hash-value store.
Mar 5 2018, 9:37 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), Technical-Debt, Patch-For-Review, VisualEditor-DataModel

Mar 4 2018

dchan claimed T188709: Annotation ordering is hazily defined in Transactions.
Mar 4 2018, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan moved T188709: Annotation ordering is hazily defined in Transactions from Up next to In progress on the VisualEditor (Current work) board.
Mar 4 2018, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan moved T188709: Annotation ordering is hazily defined in Transactions from To Triage to Current work on the VisualEditor board.
Mar 4 2018, 6:51 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188026: Provide a way to compact multiple transactions into one.

Squashing exacerbates T188709 , which hitherto was only bothering us in a few rare-ish edge cases.

Mar 4 2018, 6:48 AM · Performance, Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
dchan added a subtask for T188026: Provide a way to compact multiple transactions into one: T188709: Annotation ordering is hazily defined in Transactions.
Mar 4 2018, 6:46 AM · Performance, Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
dchan added a parent task for T188709: Annotation ordering is hazily defined in Transactions: T188026: Provide a way to compact multiple transactions into one.
Mar 4 2018, 6:46 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Patch set https://gerrit.wikimedia.org/r/416335 is preparatory work, not a solution in itself

Mar 4 2018, 6:45 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

A less drastic option would be to add a spliceAt field to the current structure:

Mar 4 2018, 4:04 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 2 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

OTOH the theoretical logic perspective is that treating all annotations as ordered, and losing some clarity of intent in the transactions in order to preserve that order, is a somewhat "hammer" approach - a more "scalpel" approach would be to make a way to express order only when order does matter, and then only relative to the thing it matters to.

Mar 2 2018, 4:40 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan updated the task description for T188709: Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 2:04 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan renamed T188709: Annotation ordering is hazily defined in Transactions from Annotation ordering is hazily defined to Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 1:22 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan updated the task description for T188709: Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 10:49 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

@Esanders suggests we could change our annotation transactions to define the whole annotation array before and after. So the unbold transaction in the above example would effectively become "change annotations from [bold,italic] to [italic]", and its reverse would say "change annotations from [italic] to [bold,italic]".

Mar 2 2018, 10:43 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel
dchan created T188709: Annotation ordering is hazily defined in Transactions.
Mar 2 2018, 10:41 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Feb 26 2018

dchan added a comment to T76426: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are.

We can resurrect https://gerrit.wikimedia.org/r/329448 if we provide a tool for blockquote insertion

Feb 26 2018, 2:27 PM · Patch-For-Review, VisualEditor-EditingTools, VisualEditor

Feb 25 2018

dchan added a comment to T188020: Minify Transaction/Change serialization.

For a typical authoring session, document history as a Change will contain a large proportion of transactions that are consecutive text insertions in the same place, with the same annotation as the insertion context. There may be a transaction for every keystroke (but somewhat fewer for many IMEs).

Feb 25 2018, 9:05 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
dchan renamed T188020: Minify Transaction/Change serialization from Minify transactions to Minify Transaction/Change serialization.
Feb 25 2018, 8:58 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel

Feb 22 2018

dchan moved T188026: Provide a way to compact multiple transactions into one from Up next to In progress on the VisualEditor (Current work) board.
Feb 22 2018, 6:00 PM · Performance, Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
dchan moved T188026: Provide a way to compact multiple transactions into one from To Triage to Current work on the VisualEditor board.
Feb 22 2018, 6:00 PM · Performance, Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
dchan set the point value for T188021: Improve control of resource growth during VisualEditor editing sessions to 0.
Feb 22 2018, 5:59 PM · Performance, Epic, VisualEditor
dchan added a parent task for T188026: Provide a way to compact multiple transactions into one: T188021: Improve control of resource growth during VisualEditor editing sessions.
Feb 22 2018, 5:59 PM · Performance, Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
dchan added a subtask for T188021: Improve control of resource growth during VisualEditor editing sessions: T188026: Provide a way to compact multiple transactions into one.
Feb 22 2018, 5:59 PM · Performance, Epic, VisualEditor
dchan created T188026: Provide a way to compact multiple transactions into one.
Feb 22 2018, 5:58 PM · Performance, Patch-For-Review, VisualEditor (Current work), VisualEditor-DataModel
dchan created T188021: Improve control of resource growth during VisualEditor editing sessions.
Feb 22 2018, 5:30 PM · Performance, Epic, VisualEditor
dchan updated subscribers of T187976: Length limit truncation should use the cursor position, not fallible heuristics.
Feb 22 2018, 5:19 AM · JavaScript, MediaWiki-General-or-Unknown
dchan triaged T187976: Length limit truncation should use the cursor position, not fallible heuristics as Low priority.
Feb 22 2018, 5:17 AM · JavaScript, MediaWiki-General-or-Unknown
dchan updated subscribers of T187976: Length limit truncation should use the cursor position, not fallible heuristics.

See also the videos that @Catrope posted on T186364 (showing the difference in truncation timing for keyboard paste and mouse paste, the latter being later and therefore easier not to notice):

Feb 22 2018, 5:16 AM · JavaScript, MediaWiki-General-or-Unknown
dchan created T187976: Length limit truncation should use the cursor position, not fallible heuristics.
Feb 22 2018, 5:10 AM · JavaScript, MediaWiki-General-or-Unknown

Feb 21 2018

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

I like this idea of VisualEditor doing something nice with window.onerror .

Feb 21 2018, 10:38 AM · OOjs, VisualEditor-DataModel, VisualEditor

Feb 14 2018

Elitre awarded T56299: (Re-) unify data and metadata a Like token.
Feb 14 2018, 12:53 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor-DataModel, Epic, VisualEditor, Technical-Debt

Feb 3 2018

dchan added a comment to T186364: mw.widgets.visibleByteLimit doesn't truncate correctly.

I can confirm that you don't have to have a complex grapheme cluster like a flag to break this: it also happens with single non-BMP codepoints, such as U+282E2 (𨋢).

Feb 3 2018, 2:12 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), MediaWiki-General-or-Unknown, JavaScript

Feb 1 2018

dchan updated the task description for T186109: Select all throws an exception (recent regression).
Feb 1 2018, 2:30 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), VisualEditor-DataModel, VisualEditor-ContentEditable, User-Ryasmeen, Regression, VisualEditor
dchan added a comment to T186109: Select all throws an exception (recent regression).

Ooh, interesting. Minimal case for throwing the error:

Feb 1 2018, 2:25 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), VisualEditor-DataModel, VisualEditor-ContentEditable, User-Ryasmeen, Regression, VisualEditor

Jan 26 2018

dchan updated the task description for T185546: EventEmitters must behave appropriately if a handler raises an exception.
Jan 26 2018, 5:29 PM · OOjs, VisualEditor-DataModel, VisualEditor
dchan added a comment to T185745: Rebaser: A SurfaceSynchronizer sometimes receives newChange before registered/initDoc.

Change 406269 is a workround, not a fix

Jan 26 2018, 11:38 AM · Patch-For-Review, VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor
dchan updated the task description for T185747: SurfaceSynchronizer: nameChange is emitted twice on connect.
Jan 26 2018, 11:21 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor
dchan created T185747: SurfaceSynchronizer: nameChange is emitted twice on connect.
Jan 26 2018, 11:15 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor
dchan updated the task description for T185716: Rebaser: onDisconnect does not uninitialize sufficiently.
Jan 26 2018, 10:43 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor
dchan created T185745: Rebaser: A SurfaceSynchronizer sometimes receives newChange before registered/initDoc.
Jan 26 2018, 10:16 AM · Patch-For-Review, VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor

Jan 25 2018

dchan created T185716: Rebaser: onDisconnect does not uninitialize sufficiently.
Jan 25 2018, 7:14 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor

Jan 23 2018

dchan created T185556: SurfaceSynchronizer doesn't propagate annotations first seen in a reverted change.
Jan 23 2018, 7:54 AM · VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor

Jan 22 2018

dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

Steps to reproduce (one specific example of data corruption):

Jan 22 2018, 11:28 PM · OOjs, VisualEditor-DataModel, VisualEditor
dchan added a comment to T185546: EventEmitters must behave appropriately if a handler raises an exception.

That's true (I was imagining the callback only being used for debugging purposes).

Jan 22 2018, 11:28 PM · OOjs, VisualEditor-DataModel, VisualEditor
dchan created T185546: EventEmitters must behave appropriately if a handler raises an exception.
Jan 22 2018, 11:11 PM · OOjs, VisualEditor-DataModel, VisualEditor

Jan 20 2018

dchan created T185395: SurfaceSynchronizer: outdated author selections can leak.
Jan 20 2018, 8:07 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-DataModel, VisualEditor-ContentEditable, VisualEditor

Dec 7 2017

dchan added a comment to T182270: Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11).

Oh, command.execute( surface ) is happening twice, and it so happens that the commands are self-inverse (toggling).

Dec 7 2017, 3:35 AM · Verified-in-Phase2, Verified-in-Phase0, Verified, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), User-Ryasmeen, Patch-For-Review, VisualEditor-EditingTools, VisualEditor

Nov 26 2017

dchan added a comment to T179574: List editing exception: TypeError: Cannot read property 'getSurface' of null.

I think this is happening because zombie CE nodes (that have been splice-removed) are still listening to events.

Nov 26 2017, 6:43 AM · Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), VisualEditor-ContentEditable, VisualEditor

Oct 9 2017

dchan added a comment to T177517: [regression wmf.2] Typing in a newly created empty <pre> doesn't work.

I'm unable to reproduce this. I've tried:

Oct 9 2017, 1:19 AM · VisualEditor

Oct 7 2017

dchan added a comment to T175826: Fix RTL on text input fields.

And there's already a method in Language.php to recognize the directionality of the first character of a string...
[...]
It's a php method, but we can migrate it to JS fairly easily - the regexp is the same, and @dchan created a javascript unicode library, if I remember correctly, as well, that could help here if we want to go that direction.

Oct 7 2017, 8:36 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
dchan added a comment to T176104: jQuery.IME not working in VisualEditor/2017 wikitext editor.

This was introduced in 37d0c27478983c9607cd85fdc6551b16a9bbb3a5 - an exception is thrown whenever jQuery.IME attempts to do any text replacement, and the timing of the exception means that the document ends up with both the substitution and the typed character text.

Oct 7 2017, 12:21 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), VisualEditor-MediaWiki-2017WikitextEditor, UniversalLanguageSelector, VisualEditor
dchan renamed T176104: jQuery.IME not working in VisualEditor/2017 wikitext editor from ULS not working properly for Indic wikis in visual editor/2017 wikitext editor to jQuery.IME not working in VisualEditor/2017 wikitext editor.
Oct 7 2017, 12:14 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), VisualEditor-MediaWiki-2017WikitextEditor, UniversalLanguageSelector, VisualEditor

Sep 25 2017

dchan claimed T176453: VisualEditor IME test failing in CI on pull-through, but not locally or in the source repo?.
Sep 25 2017, 9:37 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, VisualEditor-ContentEditable, VisualEditor
dchan added a comment to T176453: VisualEditor IME test failing in CI on pull-through, but not locally or in the source repo?.

OK, I have tested a rewritten version of ve.ce.TestRunner#changeText on the CI environment with Filibuster ( https://gerrit.wikimedia.org/r/#/c/379557/23/ ), and it looks like it works. So now we just need to put it into VE standalone then pull that through into VE-MW. And then see whether I'm completely wrong or not :)

Sep 25 2017, 9:14 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, VisualEditor-ContentEditable, VisualEditor
dchan added a comment to T176453: VisualEditor IME test failing in CI on pull-through, but not locally or in the source repo?.

As I've noted in gerrit, the Filibuster dump at patchset https://gerrit.wikimedia.org/r/#/c/379557/21/ on the CI system differs from the one I get on my local machine. At the very start of the first IME test, when "गा" is inserted, the CI system has

Sep 25 2017, 3:23 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), User-Ryasmeen, Patch-For-Review, Continuous-Integration-Config, VisualEditor-ContentEditable, VisualEditor

Sep 24 2017

dchan added a comment to T176142: Please add David Chan back to ldap/wmf.

Thank you, that's working now - and you're right, that's exactly what happened in my case, I first contributed as a volunteer.

Sep 24 2017, 8:31 AM · Patch-For-Review, LDAP-Access-Requests

Sep 19 2017

dchan added a comment to T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert".

I think this is essentially the same as T175852 (which https://gerrit.wikimedia.org/r/378378/ fixes)

Sep 19 2017, 1:46 AM · Verified, User-Ryasmeen, VisualEditor

Sep 18 2017

dchan added a comment to T176142: Please add David Chan back to ldap/wmf.

Hi, I still don't see +2 on https://gerrit.wikimedia.org/r/7738/ , even after logging in afresh.

Sep 18 2017, 11:58 PM · Patch-For-Review, LDAP-Access-Requests

Sep 14 2017

dchan added a comment to T175852: Firefox throws an exception every time enter is pressed.

The superficial reason for the exception is that ve.ce.LinearSelection#getNodeClientRectFromRange fails if the range lies in the middle of an empty <p></p>.

Sep 14 2017, 2:24 AM · User-Ryasmeen, Patch-For-Review, Regression, VisualEditor-ContentEditable, VisualEditor

Sep 13 2017

dchan added a comment to T175828: [wmf.18] VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs).

We should separate rebaser server and client code, and ensure there is no ES6-ness in the client. ve.dm.TestRebaseClient.prototype.deliverOne also contains ES6 code. Pinging @dchan

Sep 13 2017, 4:01 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Browser-Support-Internet-Explorer, VisualEditor, VisualEditor-MediaWiki

Sep 12 2017

dchan added a comment to T175548: Exception when unbulleting the final bullet of a list.

It looks like we were leaving zombie connections to nodes long ago torn down, which then reacted badly to TreeModifier causing methods to be called on their non-existent root.

Sep 12 2017, 5:07 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor

Sep 11 2017

dchan created T175548: Exception when unbulleting the final bullet of a list.
Sep 11 2017, 11:48 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-ContentEditable, VisualEditor

Sep 5 2017

dchan updated the task description for T175059: Insertions with references too easily cause rebase conflicts.
Sep 5 2017, 7:13 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-DataModel, VisualEditor
dchan renamed T175059: Insertions with references too easily cause rebase conflicts from Insertions with references too easily causes rebase conflicts to Insertions with references too easily cause rebase conflicts.
Sep 5 2017, 7:12 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-DataModel, VisualEditor
dchan created T175059: Insertions with references too easily cause rebase conflicts.
Sep 5 2017, 7:04 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-DataModel, VisualEditor

Aug 30 2017

dchan added a comment to T174464: Typing enter to complete unicode character entry also adds a line break.

On Firefox 53 for Ubuntu 17.04 I get essentially the same log as @Esanders with the following keyboard layouts:

  • English (UK, extended WinKeys)
  • English (US)
  • English (Dvorak)
Aug 30 2017, 10:20 AM · VisualEditor-ContentEditable, VisualEditor

Aug 29 2017

dchan added a comment to T174464: Typing enter to complete unicode character entry also adds a line break.

Hmm, that <br> stuff in the log is characteristic of Firefox ... I'll take a look to see what could be going on.

Aug 29 2017, 8:06 PM · VisualEditor-ContentEditable, VisualEditor

Aug 15 2017

dchan updated subscribers of T162762: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding them afresh.
Aug 15 2017, 10:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Technical-Debt, VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor

Jun 19 2017

dchan added a comment to T168221: ContentTranslation: integrate VisualEditor.

As mentioned in gerrit, the translation unit handling needs updating to take advantage of the rewritten transaction processing in VE.

Jun 19 2017, 6:56 AM · Epic, VisualEditor, ContentTranslation
dchan created T168221: ContentTranslation: integrate VisualEditor.
Jun 19 2017, 6:19 AM · Epic, VisualEditor, ContentTranslation

Jun 5 2017

dchan added a comment to T167027: Re-fix "Inserting a reference sometimes breaks horribly (due to trees in TransactionProcessor?)".

Thanks!

Jun 5 2017, 2:57 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-DataModel, VisualEditor

Apr 29 2017

dchan claimed T162761: Introduce DM events for "a node of this type was inserted/deleted/modified"?.
Apr 29 2017, 3:33 AM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), User-Ryasmeen, Patch-For-Review, VisualEditor-DataModel, VisualEditor

Apr 12 2017

dchan added a comment to T162762: ve.dm.TransactionProcessor: Restructure DM tree branches using existing nodes, instead of rebuilding them afresh.

Processing transactions - two pointer method for tree modification (Thanks to @Catrope for input on this)

Apr 12 2017, 2:24 AM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Technical-Debt, VisualEditor-ContentEditable, VisualEditor-DataModel, VisualEditor
dchan added a comment to T162761: Introduce DM events for "a node of this type was inserted/deleted/modified"?.

Interesting question. On the tree side of things, I've been considering the shortcomings of detecting ancestry modifications (e.g. see https://gerrit.wikimedia.org/r/#/c/345955/4/src/ce/nodes/ve.ce.ContentEditableNode.js ). It isn't a huge issue right now, because we rebuild branches (ve.dm.Document#rebuildNodes) rather than altering them, so the only ancestry modifications we support are birth and death. But if in the future we change ve.dm.TransactionProcessor to be able to graft branches (see T162762 ), it will become more important.

Apr 12 2017, 2:18 AM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), User-Ryasmeen, Patch-For-Review, VisualEditor-DataModel, VisualEditor