dchan (David Chan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 23 2014, 10:14 AM (212 w, 4 d)
Availability
Available
IRC Nick
divec
LDAP User
Unknown
MediaWiki User
DChan (WMF) [ Global Accounts ]

Recent Activity

Fri, Nov 16

dchan added a comment to T209648: Changing text in a TargetWidget does not enable dialog's "Apply" button (in media, gallery, reference dialog) until second keypress.

Oooh, thanks. Do we think the behaviour happens because of setTimeout subtlety? (That would instinctively be my first guess but I haven't checked).

Fri, Nov 16, 2:25 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools

Wed, Nov 14

dchan created T209533: Research faking linear selections on mobile.
Wed, Nov 14, 8:12 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor
dchan added a parent task for T202723: Mobile native selection context menu can obscure the VE toolbar: T209505: EPIC: Fix selection issues on mobile.
Wed, Nov 14, 4:59 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan added subtasks for T209505: EPIC: Fix selection issues on mobile: T136840: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome, T204387: Can't drag a collapsed selection across a reference on mobile, T202723: Mobile native selection context menu can obscure the VE toolbar, T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly, T204718: Mobile: Selection handles obscured after scrollCursorIntoView .
Wed, Nov 14, 4:59 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor
dchan added a parent task for T136840: Selection dragging opens context menu on mobile, causing surface to move and breaking drag in Android Chrome: T209505: EPIC: Fix selection issues on mobile.
Wed, Nov 14, 4:59 PM · Browser-Support-Android-Google-Chrome, VisualEditor-ContentEditable, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan created T209505: EPIC: Fix selection issues on mobile.
Wed, Nov 14, 4:51 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor

Wed, Oct 31

dchan updated the task description for T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Wed, Oct 31, 4:08 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan added a comment to T206228: Analyse load time performance of FA-length pages on mobile.

See also T208428 .

Wed, Oct 31, 4:05 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor-Performance
dchan updated the task description for T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Wed, Oct 31, 4:00 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan updated the task description for T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Wed, Oct 31, 2:57 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor
dchan created T208428: Decide mobile target hardware specification and decide performance acceptance criteria.
Wed, Oct 31, 2:56 PM · Internet-Archive, VisualEditor-MediaWiki-Mobile, VisualEditor

Tue, Oct 30

dchan moved T201877: EPIC: What are the current best UI practices for mobile editing? from In progress to Code review on the VisualEditor (Current work) board.
Tue, Oct 30, 5:04 PM · VisualEditor, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Design-Research, Design

Mon, Oct 29

dchan created T208228: DM Selections should not cache document model data.
Mon, Oct 29, 2:54 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), VisualEditor-DataModel

Wed, Oct 24

dchan created T207874: Find a good way round IME limitations, especially on mobile.
Wed, Oct 24, 6:11 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable, VisualEditor

Oct 10 2018

dchan added a comment to T204387: Can't drag a collapsed selection across a reference on mobile.

I filed an upstream bug about the dragging across ce=false: https://bugs.chromium.org/p/chromium/issues/detail?id=894003

Oct 10 2018, 10:53 AM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Oct 9 2018

dchan added a comment to T204387: Can't drag a collapsed selection across a reference on mobile.

Maybe we should experiment to see whether we can get anywhere using newer features now fairly reliably available on Chrome mobile, e.g. shadow DOM.

Oct 9 2018, 1:07 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Oct 4 2018

dchan added a comment to T202138: Snapshot: what proportion of edits are made using the visual and wikitext editors?.

Hi @Neil_P._Quinn_WMF , the configuration variables shown here should help:

Oct 4 2018, 12:07 AM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics

Sep 26 2018

dchan updated the task description for T205535: Remove dedicated annotation operation types.
Sep 26 2018, 1:29 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
marcella awarded T205535: Remove dedicated annotation operation types a Mountain of Wealth token.
Sep 26 2018, 1:07 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
dchan updated the task description for T205535: Remove dedicated annotation operation types.
Sep 26 2018, 12:54 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel
dchan created T205535: Remove dedicated annotation operation types.
Sep 26 2018, 11:51 AM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, Technical-Debt, VisualEditor-DataModel

Sep 19 2018

dchan added a comment to T203580: Create technical debt heat map for VE codebase.

Here's a version where the text is more or less readable, but JPEG compressed enough that Phabricator accepts it:

Sep 19 2018, 4:20 PM · VisualEditor (Current work), Technical-Debt

Sep 14 2018

dchan added a comment to T204387: Can't drag a collapsed selection across a reference on mobile.

I guess this may be the same issue as in T203555.

Sep 14 2018, 11:07 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 13 2018

marcella awarded T203580: Create technical debt heat map for VE codebase a Doubloon token.
Sep 13 2018, 7:05 PM · VisualEditor (Current work), Technical-Debt
dchan updated the task description for T204192: Research text input support for Indian scripts.
Sep 13 2018, 7:13 AM · Language-Team, VisualEditor
dchan updated the task description for T204192: Research text input support for Indian scripts.
Sep 13 2018, 7:08 AM · Language-Team, VisualEditor
dchan updated the task description for T204192: Research text input support for Indian scripts.
Sep 13 2018, 6:57 AM · Language-Team, VisualEditor

Sep 10 2018

dchan claimed T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.
Sep 10 2018, 4:24 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan moved T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Sep 10 2018, 4:24 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan moved T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly from Up next to Current work on the VisualEditor board.
Sep 10 2018, 4:23 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan edited projects for T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly, added: VisualEditor; removed VisualEditor (Current work).

With input debugging enabled, it's easier to see that if the selection pin lands between the pre-close nail and the post-close nail then the selection collapses. In fact you can see this just editing <h1><a href='x'>foo</a> bar</h1>.

Sep 10 2018, 4:20 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable

Sep 5 2018

dchan moved T202719: Backspace across paragraphs is broken on mobile VE from To Triage to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:41 PM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan moved T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly from To Triage to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:38 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

Given the context disappearance is an iOS-specific issue, would it be worth doing the 60px scroll on non-iOS devices only?

Sep 5 2018, 2:09 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan closed T64028: VisualEditor: Cursor skips by one character for Thai characters (expected skipping by one block) as Resolved.

This is working now; I guess it has been since 2d8c3e799601d3eb70127b32e262dbe1d64a7e4e .

Sep 5 2018, 1:39 PM · User-Ryasmeen, I18n, VisualEditor, VisualEditor-ContentLanguage
dchan closed T64028: VisualEditor: Cursor skips by one character for Thai characters (expected skipping by one block), a subtask of T35077: VisualEditor multilingual input / i18n issues (tracking), as Resolved.
Sep 5 2018, 1:39 PM · VisualEditor, Tracking, VisualEditor-ContentLanguage
dchan added a parent task for T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly: T202647: Assess VE mobile text input situation for each target wiki.
Sep 5 2018, 12:23 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan added a subtask for T202647: Assess VE mobile text input situation for each target wiki: T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.
Sep 5 2018, 12:23 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage
dchan created T203555: On Android Chrome, Thai text selections next to a link can collapse unexpectedly.
Sep 5 2018, 12:20 PM · VisualEditor (Current work), VisualEditor-ContentLanguage, VisualEditor-ContentEditable
dchan added a comment to T50429: [Epic] Support editing parts of a page in VisualEditor-MediaWiki.

Thanks @kaldari! As I understand it the fundamental differences between T76541 and T146072 are:

Sep 5 2018, 2:29 AM · VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki

Sep 4 2018

dchan updated the task description for T202647: Assess VE mobile text input situation for each target wiki.
Sep 4 2018, 5:24 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage

Sep 3 2018

dchan updated the task description for T202647: Assess VE mobile text input situation for each target wiki.
Sep 3 2018, 6:02 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage
dchan renamed T202647: Assess VE mobile text input situation for each target wiki from Assess the current VE-mobile situation for target wikis to Assess VE mobile text input situation for each target wiki.
Sep 3 2018, 6:00 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage

Aug 29 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

@matmarex Ohhh that's a really good point. And unfortunately you're right to be suspicious; some IMEs can add / remove whitespace without committing all candidate text so we can't safely rerender.

Aug 29 2018, 3:43 PM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Aug 28 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

@matmarex , do you want to go forward with the solution you suggested? (I.e. use &nbsp; for every other space, on NWE only)

Aug 28 2018, 8:37 AM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Aug 26 2018

dchan added a comment to T202719: Backspace across paragraphs is broken on mobile VE.

Hmm, looking at the Filibuster trace, it looks very much like the native backspace action leaves the DOM unchanged. Will investigate further.

Aug 26 2018, 12:09 PM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Aug 24 2018

dchan updated subscribers of T202723: Mobile native selection context menu can obscure the VE toolbar.

@Esanders , should we work round this by having a minimum gap above the CE surface?

Aug 24 2018, 12:29 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan updated the task description for T202723: Mobile native selection context menu can obscure the VE toolbar.
Aug 24 2018, 12:26 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan created T202723: Mobile native selection context menu can obscure the VE toolbar.
Aug 24 2018, 12:24 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
dchan created T202719: Backspace across paragraphs is broken on mobile VE.
Aug 24 2018, 11:12 AM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Aug 23 2018

dchan added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

I don't know much about this, but will/can we get the data broken down by wiki (and therefore effectively by language)? That could be pretty useful for script / IME support purposes

Aug 23 2018, 5:19 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
dchan created T202647: Assess VE mobile text input situation for each target wiki.
Aug 23 2018, 4:55 PM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-ContentLanguage

Aug 20 2018

dchan updated the task description for T116275: DM/DOM sync can break if you use an IME.
Aug 20 2018, 2:05 PM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Epic, VisualEditor-ContentEditable, VisualEditor
dchan reopened T116275: DM/DOM sync can break if you use an IME as "Open".

It's still possible to trigger this bug, though Change 247800 made things much better. Will update the description.

Aug 20 2018, 1:45 PM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Epic, VisualEditor-ContentEditable, VisualEditor
dchan moved T201870: Cursor into and out of table captions correctly with up/down arrow from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Aug 20 2018, 1:13 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), VisualEditor (Current work), Accessibility, VisualEditor-Tables

Aug 19 2018

dchan claimed T201870: Cursor into and out of table captions correctly with up/down arrow.

Ok, I think we should worry about Firefox in a separate task, because the issues are different (and I guess more intractable).

Aug 19 2018, 6:31 AM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), VisualEditor (Current work), Accessibility, VisualEditor-Tables
dchan added a comment to T201870: Cursor into and out of table captions correctly with up/down arrow.

Ok, I added some code for cursoring downwards out of a caption. Note though that none of this code fixes things on Firefox.

Aug 19 2018, 6:22 AM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), VisualEditor (Current work), Accessibility, VisualEditor-Tables

Aug 13 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

I agree with @matmarex 's proposal that we shouldn't revert to the &nbsp; behaviour for visual editing (because we want nbsp to represent actual non-breaking spaces). It's a different issue in wikitext because non-breaking spaces are inferred heuristically.

Aug 13 2018, 11:43 AM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Aug 9 2018

dchan moved T201599: It is possible to get the cursor into a block slug from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Aug 9 2018, 10:20 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable
dchan edited projects for T201599: It is possible to get the cursor into a block slug, added: VisualEditor (Current work); removed VisualEditor.
Aug 9 2018, 10:19 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable
dchan added a comment to T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

Ok, I created T201599 for the separate slug cursoring issue, which is really a corruption problem as @Deskana suggests.

Aug 9 2018, 10:05 AM · VisualEditor (Current work)
dchan created T201599: It is possible to get the cursor into a block slug.
Aug 9 2018, 10:02 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable

Aug 8 2018

dchan added a comment to T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

And the problem happens because Chromium natively puts the cursor into the slug even though the click is outside the slug, but not in Firefox because its native behaviour is different (it puts the cursor directly into the surrounding div).

Aug 8 2018, 8:45 PM · VisualEditor (Current work)
dchan added a comment to T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

Clicking twice to the left of the node puts the cursor into the slug text and lets you edit it

Aug 8 2018, 8:37 PM · VisualEditor (Current work)
dchan claimed T200819: Clicking to the left of a line moves the cursor few lines above in some cases .

This is reproducible with any focusable block node, e.g. on this minimal document:

<hr>x
Aug 8 2018, 8:34 PM · VisualEditor (Current work)

Jul 27 2018

dchan added a comment to T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

I feel the following code isn't that sensible now that meta items live in the main linear data:

Jul 27 2018, 6:20 PM · Verified-in-Phase2, MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs
dchan added a comment to T199011: CX2: Paragraph becomes unusable when switching to 'Don't use machine translation' or 'Use source text' .

Thanks! I'm not seeing the error, with parameters: page=Foo&from=en&to=es&targettitle=Bar&version=2&revision=<XXX> . It seems to work fine for me, on both my local installation and on wikipedia.org . Can you confirm a particular page+paragraph that fails for you on wikipedia.org?

Jul 27 2018, 2:38 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Language-2018-July-September, ContentTranslation
dchan added a comment to T199011: CX2: Paragraph becomes unusable when switching to 'Don't use machine translation' or 'Use source text' .

Hi @Petar.petkovic, can you tell me steps to reproduce the continuing issues (after Change 446198) you mentioned above? The points you make in T199754 look good, but I'd like to have a failing test case to verify against.

Jul 27 2018, 2:01 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Language-2018-July-September, ContentTranslation
dchan added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

I'm also failing to reproduce this — I tried on 4c51ee9ec57678f29b320868161d570dba7c4ccb and on aca98533eab67e3154c4b243cbcadd155b69398e .

Jul 27 2018, 1:00 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Ryasmeen, Verified, VisualEditor (Current work)

Jul 12 2018

dchan added a comment to T199464: PolyGerrit unified diff view is too narrow without enabling "Fit to screen" setting.

Thanks, that solves it for me - is there any way that can be the default (at least for Unified)?

Jul 12 2018, 5:18 PM · Gerrit
dchan created T199464: PolyGerrit unified diff view is too narrow without enabling "Fit to screen" setting.
Jul 12 2018, 4:50 PM · Gerrit

Jul 10 2018

dchan added a comment to T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.

Sure, thanks

Jul 10 2018, 6:31 AM · Security

Jun 25 2018

dchan added a comment to T193587: CX2: Rich text editing in dialogs is not possible since cards are shown in a deactivated tools column.

Let me comment on the specific issue of modality. There are definitely parts of the VE code that assume dialogs operating on a portion of the document must be modal. One example is that there's a transaction undo stack that mirrors the dialog opening stack. Another is that there are places where stored offsets could be invalidated if the main document remains editable while the dialog is visible.

Jun 25 2018, 11:19 AM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Language-2018-Apr-June, ContentTranslation

Jun 14 2018

dchan added a comment to T196921: Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception).

@Esanders : yes, that seems to solve the issue, both in my local testing and when I monkey patch the live pl.wikisource.org page above.

Jun 14 2018, 7:29 PM · Verified, MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), ProofreadPage, VisualEditor-MediaWiki

May 20 2018

dchan added a comment to T76541: Client-side approach to true section editing: Load/display document-level data (e.g. internal lists, meta lists) for the whole document but only the content for a part of the document.

As well as the approach in https://gerrit.wikimedia.org/r/433753 , we should also consider the following alternative:

  • A class provides the LinearData interface on a live slice of the linear data (performing offset translation and bounds checking)
  • ve.dm.Document builds on top of that class

That approach would more robustly prevent access outside the slice. But one drawback would be apparent dangling references in the slice.

May 20 2018, 7:47 AM · VisualEditor, Patch-For-Review, Epic, VisualEditor-MediaWiki, VisualEditor-Performance

May 18 2018

dchan added a comment to T49344: Internal nodes should eventually be in a separate document ("sub-documents").

Here is a proposal for refinement:

May 18 2018, 2:10 PM · Epic, Patch-For-Review, VisualEditor-Performance, VisualEditor, Technical-Debt

May 2 2018

dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

With change 430413, "change citation, undo, redo" seems to work fine in all the cases I've tried.

May 2 2018, 4:53 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools
dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

Hmm, thanks, it seems I overlooked that there are a few different ways reference-instead-of-copy can happen here - investigating further.

May 2 2018, 9:10 AM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools

Apr 29 2018

dchan added a comment to T193062: Undo/redo on citations doesn't work correctly.

Ooooh, this happens because ve.dm.TransactionBuilder#pushAttributeChanges( { key: val }, ... ) puts a live reference to val into the Transaction object. So if val subsequently gets mutated, that invalidates the Transaction object.

Apr 29 2018, 2:52 AM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work), VisualEditor-EditingTools

Apr 15 2018

dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

A hotfix for the problem I describe is to open the console (CTRL+SHIFT+i), then type

$( '.ve-ce-surface' ).css( 'word-break', 'break-all' )

then press <ENTER>, then close the console (CTRL+SHIFT+i again).

Apr 15 2018, 2:40 AM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor
dchan added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).

Oh, I can reproduce what might be the same problem, or at least related: I think it's to do with browser rules for wrapping spaces.

Apr 15 2018, 2:29 AM · VisualEditor, MediaWiki-extensions-CodeMirror, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor

Apr 11 2018

dchan added a comment to T171374: Make CodeMirror support IME functionality.

That sounds like a good idea, because even if we switched to listening for keydown, we'd be depending on our keydown listener to run first, which would be quite brittle.

Apr 11 2018, 4:41 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan added a comment to T171374: Make CodeMirror support IME functionality.

@MusikAnimal I think listening to keydown might work here, but might break other uses of jQuery.IME . If it does work here, perhaps we could consider making it an option. Anyone want to try changing the binding and see whether it works?

Apr 11 2018, 1:16 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror

Apr 8 2018

dchan edited projects for T191700: VE: Avoid piping links for formatting where possible, added: Parsoid; removed VisualEditor-EditingTools, VisualEditor.

Thanks SoWhy, things like this would happen during the HTML->wikitext conversion in Parsoid, so I've tagged it as an issue for the Parsoid team to look at.

Apr 8 2018, 1:32 AM · Patch-For-Review, Parsoid

Mar 29 2018

dchan added a comment to T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.

Thanks, that's most informative and makes me understand the situation a lot better. I wonder can we publish this sort of info for users in sensitive situations (if we haven't already) — and I guess advise them to use something like tor if they still have really serious concerns.

Mar 29 2018, 1:15 PM · Security

Mar 28 2018

dchan updated subscribers of T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.
Mar 28 2018, 3:29 PM · Security
dchan created T190941: Our HTTPS private keys seem to be obtainable under non-US surveillance laws, creating a worldwide MITM attack vector.
Mar 28 2018, 3:27 PM · Security

Mar 19 2018

dchan moved T188709: Annotation ordering is hazily defined in Transactions from In progress to Code review on the VisualEditor (Current work) board.
Mar 19 2018, 4:47 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 15 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Well, it should improve such situations by giving us the precision to treat them all properly.

Mar 15 2018, 9:00 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel

Mar 14 2018

dchan added a comment to T171374: Make CodeMirror support IME functionality.

Oh, the keypress behaviour we're seeing in Chromium doesn't seem to happen on the CodeMirror demo, either on https://codemirror.net/index.html (presumably the current version 5.35.0) or bundled in http://codemirror.net/codemirror-5.30.0.zip (which is the version the mediawiki extension currently includes).

Mar 14 2018, 12:56 PM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan closed T189643: Error while building VE document model with a translation section containing block image as Resolved.

See https://gerrit.wikimedia.org/r/#/c/419151/1..2/modules/ve-cx/dm/ve.dm.CXBlockImageNode.js .

Mar 14 2018, 11:29 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T189643: Error while building VE document model with a translation section containing block image.

Oh, of course - we have to allow mwImageCaption to have cxBlockImageNode as a parent ... I'll upload a patch

Mar 14 2018, 11:25 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T189643: Error while building VE document model with a translation section containing block image.

After debugging this with the help of @santhosh , It seems ve.dm.Document#fixupInsertion is returning unbalanced data . Before the fixup, we have:

Mar 14 2018, 9:26 AM · User-Ryasmeen, VisualEditor-DataModel, ContentTranslation, VisualEditor
dchan added a comment to T171374: Make CodeMirror support IME functionality.

Ok, I put some small fixes into https://gerrit.wikimedia.org/r/#/c/398602/5/ and https://gerrit.wikimedia.org/r/#/c/399460/5/ .

Mar 14 2018, 5:39 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror
dchan added a comment to T171374: Make CodeMirror support IME functionality.

Hi, it's currently not working for me on either Firefox 57 or Chromium 63, both on Ubuntu. Here are exact steps to reproduce:

Mar 14 2018, 4:38 AM · UniversalLanguageSelector, MediaWiki-extensions-CodeMirror

Mar 13 2018

dchan added a comment to T189118: Find out why a <nowiki/> tag are causing edits to get mangled.

Hmmm, that makes sense, because since 21a5d55b85dd , we only round-trip the meta item back into the ContentBranchNode on serialization if the ContentBranchNode is unmodified - so clearly if the <nowiki/> is being used to separate out pieces of wiki syntax, the behaviour will now not be as intended.

Mar 13 2018, 9:15 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan reassigned T189118: Find out why a <nowiki/> tag are causing edits to get mangled from dchan to matmarex.
Mar 13 2018, 9:03 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan claimed T189118: Find out why a <nowiki/> tag are causing edits to get mangled.

Thanks @matmarex (and oops) - taking a look.

Mar 13 2018, 8:51 AM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), VisualEditor-MediaWiki, VisualEditor (Current work)
dchan added a comment to T189557: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines.

Thanks, @matmarex ! The purpose of the TreeModifier is to perform the linear modifiations in an order such that the tree structure is at all times valid and the view can stay closely in sync with the linear model. Even so, there may be scope to reduce the number of splices in such an obvious case - I'll take a look.

Mar 13 2018, 6:35 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Mar 12 2018

dchan added a comment to T188709: Annotation ordering is hazily defined in Transactions.

Change 416735 fixes this

Mar 12 2018, 7:54 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Chinese-Sites, VisualEditor (Current work), VisualEditor-DataModel