demon (Chad Horohoe)Administrator
Senior Software Engineer, Wikimedia

Projects (31)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:05 PM (178 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
no_justification
LDAP User
Chad
MediaWiki User
๐Ÿ˜‚

I've been around for a really long time now. I work for @greg on the Release-Engineering-Team

These days I make Deployments (and Release) of MediaWiki, work on Scap, and generally putter around fixing things--many of which are my fault to begin with. Oh, I really love deleting code.

Easily nerd sniped.

Recent Activity

Today

demon committed rGERRITDEPLOY23ebf75c093c: Adding webhooks plugin (authored by demon).
Adding webhooks plugin
Fri, Feb 23, 3:22 AM

Yesterday

demon triaged T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002 as Low priority.
Thu, Feb 22, 12:44 AM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

So we think --delete-excluded will solve this. The patch above adds support to Scap's core for this. I'll follow-up with a change to the clean plugin to make use of it.

Thu, Feb 22, 12:44 AM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T109939: For mirrored GitHub repositories, actually give the canonical source Gerrit URL in the repo description.

I actually think we shouldn't bother replicating everything....there's a ton of crap.

What I want to do is re-write my old github plugin again (the upstream one I don't like). It'd handle repo creation (as appropriate), along with keeping descriptions in sync.

Thu, Feb 22, 12:39 AM ยท GitHub-Mirrors
demon closed D983: Remove `scap l10n-update`.
Thu, Feb 22, 12:36 AM ยท Release-Engineering-Team
demon committed rMSCA892c4f5c8fd9: Remove `scap l10n-update` (authored by demon).
Remove `scap l10n-update`
Thu, Feb 22, 12:36 AM

Wed, Feb 21

demon committed rMSCA815ff7cfae6e: Remove `scap hhvm-graceful` (authored by demon).
Remove `scap hhvm-graceful`
Wed, Feb 21, 11:52 PM
demon closed D982: Remove `scap hhvm-graceful`.
Wed, Feb 21, 11:52 PM ยท Release-Engineering-Team
demon added a comment to D983: Remove `scap l10n-update`.

Also: could easily be a scap plugin

Wed, Feb 21, 10:54 PM ยท Release-Engineering-Team
demon added a comment to D983: Remove `scap l10n-update`.

I think retaining non-standard behaviors outside of scap sync is harmful in our ultimate quest to unify scap2 and scap3 style deployments.

Wed, Feb 21, 10:49 PM ยท Release-Engineering-Team
demon closed T183959: 1.31.0-wmf.20 deployment blockers as Resolved.
Wed, Feb 21, 10:37 PM ยท Release-Engineering-Team (Kanban), Release, Train Deployments
demon committed rMSCA98f9dfef6e91: Allow passing extra arguments to rsync in sync_common() (authored by demon).
Allow passing extra arguments to rsync in sync_common()
Wed, Feb 21, 10:36 PM
demon closed D981: Allow passing extra arguments to rsync in sync_common().
Wed, Feb 21, 10:35 PM ยท Release-Engineering-Team
demon retitled D981: Allow passing extra arguments to rsync in sync_common() from WIP: Allow passing extra arguments to rsync on sync common to Allow passing extra arguments to rsync in sync_common().
Wed, Feb 21, 10:25 PM ยท Release-Engineering-Team
demon removed a watcher for LDAP-Access-Requests: demon.
Wed, Feb 21, 9:53 PM
demon added a comment to T184805: Move some wikis to s5.

Only adding Release-Engineering-Team and #wmcs in case they can think of a reason not to move them (groupX reasons) or not to put labswiki there.

Wed, Feb 21, 9:46 PM ยท Release-Engineering-Team (Watching / External), wikitech.wikimedia.org, cloud-services-team, DBA, Operations
demon updated the diff for D981: Allow passing extra arguments to rsync in sync_common().
  • Redo overcomplication for generic rsync args as use-case-specific --delete-excluded
Wed, Feb 21, 9:21 PM ยท Release-Engineering-Team
demon added inline comments to D981: Allow passing extra arguments to rsync in sync_common().
Wed, Feb 21, 9:11 PM ยท Release-Engineering-Team
demon added a comment to T187942: Replication lag detection broken in wmf.22.

The array-to-string conversion bug was already in the old branch---it got triggered likely because of the underlying lag as an unrelated symptom.

Wed, Feb 21, 8:56 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), User-notice, Patch-For-Review, Performance-Team, MediaWiki-Database, Wikimedia-log-errors
demon requested review of D983: Remove `scap l10n-update`.
Wed, Feb 21, 8:12 PM ยท Release-Engineering-Team
demon requested review of D982: Remove `scap hhvm-graceful`.
Wed, Feb 21, 8:04 PM ยท Release-Engineering-Team
demon closed D957: Document all checks.
Wed, Feb 21, 8:04 PM ยท Release-Engineering-Team
demon committed rMSCA08b86a334721: Document all checks (authored by awight).
Document all checks
Wed, Feb 21, 8:04 PM
demon abandoned D929: WIP: Dropping bin/scap in favor of setup.py support.

This change tried to accomplish like 3 things. Bad Chad.

Wed, Feb 21, 8:02 PM ยท Release-Engineering-Team
demon added inline comments to D981: Allow passing extra arguments to rsync in sync_common().
Wed, Feb 21, 8:00 PM ยท Release-Engineering-Team
demon updated the diff for D981: Allow passing extra arguments to rsync in sync_common().
  • Tidy up rsync_args logic, make it more like includes.
Wed, Feb 21, 7:43 PM ยท Release-Engineering-Team
demon requested review of D981: Allow passing extra arguments to rsync in sync_common().
Wed, Feb 21, 5:50 PM ยท Release-Engineering-Team
demon added a comment to T187845: Run initSiteStats.php for large.dblist wikis.

wikidatawiki, commonswiki and 'pedias are all that's left now.

Wed, Feb 21, 4:56 PM ยท Wikimedia-Site-requests, Wikimedia-maintenance-script-run
demon updated the task description for T187845: Run initSiteStats.php for large.dblist wikis.
Wed, Feb 21, 4:56 PM ยท Wikimedia-Site-requests, Wikimedia-maintenance-script-run
demon updated the task description for T187845: Run initSiteStats.php for large.dblist wikis.
Wed, Feb 21, 4:49 PM ยท Wikimedia-Site-requests, Wikimedia-maintenance-script-run
demon added a comment to T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis.

If a script has wait-for-slaves support, that would be between individual passes of that script for that wiki. I'm talking about a script that would do a single heavy query for a wiki, then exit. I'd like to wait before doing the next one.

Wed, Feb 21, 3:55 PM ยท MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

I'm curious if scap clean is the wrong approach. A daily (or heck, weekly even) cron that Does The Right Thing is less likely to be forgotten (I'm the only one who ever runs clean) and it would prevent #2 above ^

Wed, Feb 21, 3:46 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
zeljkofilipin awarded T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002 a Mountain of Wealth token.
Wed, Feb 21, 3:43 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

I think there's two actionables here!

  1. Make sure we delete these directories as part of the first pass on scap clean. I think --force will handle this but I need to test
  2. Really really really f'ing make sure old directories get pruned. The fact that we had 1.29.0-wmf.* branches around is pretty f'ing embarrassing.
Wed, Feb 21, 3:42 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

In the old method, we just did ^^^ and never had a "partial" cleanup like we do now.

Wed, Feb 21, 3:38 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

Fwiw, this works just fine:

SSH_AUTH_SOCK=/run/keyholder/proxy.sock dsh -F 20 -M -g mediawiki-installation -r ssh -o -oUser=mwdeploy -- rm -rf /srv/mediawiki/php-1.31.0-wmf.{4,3}/
Wed, Feb 21, 3:37 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

Sorta. From what I can tell, rsync won't delete a destination directory if it still has files in it (considering the source directory didn't have them). mwdeploy /can/ delete them (and in fact, it's what I use to delete them).

Wed, Feb 21, 3:35 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon added a comment to T157030: cannot delete non-empty directory: php-1.29.0-wmf.3 messages on 'scap sync' on mwdebug1002.

Has nothing to do with scap clean. We've been fighting this same error message for years.

Wed, Feb 21, 3:26 PM ยท Release-Engineering-Team (Kanban), Deployments, Operations, User-Addshore
demon updated the task description for T187845: Run initSiteStats.php for large.dblist wikis.
Wed, Feb 21, 2:59 AM ยท Wikimedia-Site-requests, Wikimedia-maintenance-script-run
demon added a comment to T187845: Run initSiteStats.php for large.dblist wikis.

So this has been done for all wikis in small and medium dblists. large.dblist is left, but needs to be done slowly and 1-by-1 to make sure our long-running selects don't explode too hard.

Wed, Feb 21, 2:56 AM ยท Wikimedia-Site-requests, Wikimedia-maintenance-script-run
demon renamed T187845: Run initSiteStats.php for large.dblist wikis from Run initSiteStats.php for medium/large.dblist to Run initSiteStats.php for large.dblist wikis.
Wed, Feb 21, 2:55 AM ยท Wikimedia-Site-requests, Wikimedia-maintenance-script-run
demon updated subscribers of T187850: Cleanup remaining WikipediaMobileFirefoxOS references.
Wed, Feb 21, 2:54 AM ยท Patch-For-Review, Release-Engineering-Team (Kanban), Wikimedia-Apache-configuration
demon updated subscribers of T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis.
Wed, Feb 21, 2:13 AM ยท MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
demon added a project to T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis: Release-Engineering-Team.
Wed, Feb 21, 2:12 AM ยท MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
demon triaged T187852: Write some version of foreachwiki(indblist) that respects replag and/or has some --delay parameter between wikis as Normal priority.
Wed, Feb 21, 2:12 AM ยท MediaWiki-Maintenance-scripts, Utilities-code-utils, Release-Engineering-Team
demon triaged T187850: Cleanup remaining WikipediaMobileFirefoxOS references as High priority.
Wed, Feb 21, 1:53 AM ยท Patch-For-Review, Release-Engineering-Team (Kanban), Wikimedia-Apache-configuration

Tue, Feb 20

demon added a comment to T187757: Thanks thanking the wrong edit.

Ok, this is live now!

Tue, Feb 20, 10:30 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
demon added a comment to T187757: Thanks thanking the wrong edit.

This is fixed in master, just needs a backport (which Roan started already). I'm finishing that now.

Tue, Feb 20, 10:17 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
demon created P6723 cleanupTitles for enwikiversity.
Tue, Feb 20, 10:13 PM
demon added a comment to T179680: RFC: deprecate VirtualRESTService.

Jfdi!

Tue, Feb 20, 9:42 PM ยท TechCom-RFC
demon created P6722 (An Untitled Masterwork).
Tue, Feb 20, 9:11 PM
demon added a comment to T187761: Proposal: Effective immediately, disallow multi-sync patch deployment.

I agree with this proposal. In fact, let's just go ahead and make this Officialโ„ข -- all we'd need to do is make some doc changes and announce it.

Tue, Feb 20, 4:14 PM ยท MediaWiki-SWAT-deployments, Release-Engineering-Team
demon added a comment to T187761: Proposal: Effective immediately, disallow multi-sync patch deployment.

(removed sync-dir references in description since it's just a deprecated back-compat alias to sync-file)

Tue, Feb 20, 4:11 PM ยท MediaWiki-SWAT-deployments, Release-Engineering-Team
demon updated the task description for T187761: Proposal: Effective immediately, disallow multi-sync patch deployment.
Tue, Feb 20, 4:10 PM ยท MediaWiki-SWAT-deployments, Release-Engineering-Team

Sat, Feb 17

demon committed rMSCAc2e25672d9f3: Remove python2 shebang stuff from tests (authored by demon).
Remove python2 shebang stuff from tests
Sat, Feb 17, 7:19 PM
demon closed D978: Remove python2 shebang stuff from tests.
Sat, Feb 17, 7:19 PM ยท Release-Engineering-Team

Fri, Feb 16

demon added a comment to T187153: BadMethodCallException (mRecord->getContent() when mRecord is null) when viewing details or examine of Abuselog of Abusefilter 131 on zh.wikipedia.

This is now the most frequent error in fatal monitor by a full order of magnitude. It probably should have blocked the train, however, it slipped through the cracks yesterday during the train rollout. I'm going to make this block wmf.22 for now, for the sake of visibility at least.

Fri, Feb 16, 9:24 PM ยท Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-log-errors, Chinese-Sites, AbuseFilter
demon requested review of D979: Little bit of debian/control cleanup to prep for py3 transition.
Fri, Feb 16, 1:51 AM ยท Release-Engineering-Team
demon requested review of D978: Remove python2 shebang stuff from tests.
Fri, Feb 16, 1:21 AM ยท Release-Engineering-Team

Thu, Feb 15

demon added a comment to T100922: Create separate XMP parsing library.

The project was forked, I guess we just need to submit to packagist then add to vendor and remove the core bits? Should be easy to finish out :)

Thu, Feb 15, 11:35 PM ยท Patch-For-Review, MW-1.28-release-notes, Commons, Multimedia, Librarization, MediaWiki-File-management
demon requested review of D977: Less shit version of `git submodule foreach`.
Thu, Feb 15, 10:07 PM ยท Release-Engineering-Team
demon added a comment to T177974: Drop #wikimedia-codereview channel.

I understand that #wikimedia-dev is often criticised for being crowded with bots.

Thu, Feb 15, 4:06 AM ยท Patch-For-Review, wikimedia-irc-freenode
demon closed T130420: Phase 2 repository migrations to Differential as Declined.

Declining outright as we don't have any sort of plan here. There's no "phase 2" and the suggested repos are non-viable (I know ops has little appetite for Differential)

Thu, Feb 15, 3:06 AM ยท Goal, releng-201617-q3, Gerrit-Migration
demon added a comment to T187149: Delete all Phabricator git repos that haven't been referenced / aren't used..

Gerrit also provides multi-datacenter capability, so we've got local mirrors. I understand maybe wanting a non-Gerrit mirror we control...but the complete lack of organization of our repo setup there makes it a pain to work with...manual repo maintenance is the ultimate killer for me... I'd rather replicate to a random VM and expose them over git:// than the status quo.

Thu, Feb 15, 2:10 AM ยท Diffusion, Gerrit, Phabricator

Wed, Feb 14

demon created P6700 hiwiki namespace dupes post-T187286.
Wed, Feb 14, 7:29 PM
demon added inline comments to D976: Support Python projects.
Wed, Feb 14, 6:56 PM ยท Release-Engineering-Team
demon added a comment to T184298: WIki name can't handle ยซ ' ยป char.

Related/dupe? T132009

Wed, Feb 14, 4:59 PM ยท Timeless
demon added a comment to T186848: Get download / clone stats for MediaWiki and other repos.

Why do we need to use Github? What snapshots are we talking about? Extension distributor should be able do this for us....

I don't know if we need it, but right now the top two links in WikimediaDownload (the template used for all gerrit extension infoboxes) are a link to ExtensionDistributor and a link to the Github tarball, with the wording implying that the latter is the way to get a master tarball.

Wed, Feb 14, 2:43 AM ยท MediaWiki-Stakeholders-Group-General
demon added a comment to T186690: Access to manage Gerrit repos to @MarcoAurelio.

They are project owners. Project ownership inherits. I guess what we need to do is give "Project and Group Creators" project ownership rights on All-Projects? But then they might as well be admins....

Wed, Feb 14, 1:45 AM ยท Gerrit, Release-Engineering-Team
demon added a comment to T186848: Get download / clone stats for MediaWiki and other repos.

For extensions this is a problem since we use Github to provide master snapshots, and there is no way to get any download stats about those.

Wed, Feb 14, 1:44 AM ยท MediaWiki-Stakeholders-Group-General
demon committed rGERRITDEPLOYb234c85198ed: Revert "Adding reviewers plugin" (authored by demon).
Revert "Adding reviewers plugin"
Wed, Feb 14, 1:37 AM
demon added a reverting change for rGERRITDEPLOY6adde70b6464: Adding reviewers plugin: rGERRITDEPLOYb234c85198ed: Revert "Adding reviewers plugin".
Wed, Feb 14, 1:37 AM
demon committed rMSCAbf9e0d0bc215: Add quick environment variable to disable scap plugins (authored by demon).
Add quick environment variable to disable scap plugins
Wed, Feb 14, 1:32 AM
demon closed D965: Add quick environment variable to disable scap plugins.
Wed, Feb 14, 1:32 AM ยท Release-Engineering-Team

Tue, Feb 13

demon triaged T187229: Jouncebot: `jouncebot thisweek` functionality as Normal priority.
Tue, Feb 13, 7:09 PM ยท Jouncebot, Deployments
demon triaged T187228: Jouncebot: Ability to mark calendar entries as non-reporting as Normal priority.
Tue, Feb 13, 7:08 PM ยท Jouncebot, Deployments
demon closed T186908: Array-to-string conversion in flow_block_topiclist_newtopic as Resolved.
Tue, Feb 13, 4:42 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Wikimedia-log-errors
demon closed T186908: Array-to-string conversion in flow_block_topiclist_newtopic, a subtask of T183959: 1.31.0-wmf.20 deployment blockers, as Resolved.
Tue, Feb 13, 4:42 PM ยท Release-Engineering-Team (Kanban), Release, Train Deployments
demon added a comment to T187160: /srv/mediawiki-staging/scap/plugins/clean.py had a live hack.

Ugh, should've committed it instead....

Tue, Feb 13, 4:31 PM ยท Scap
demon added a comment to T187076: Deploy error: insufficient permission for adding an object to repository database .git/objects.

scap IMO should be warning or refuse to continue if the user has a busted umask to avoid similar situation in the future

Tue, Feb 13, 4:31 PM ยท Operations, Scap
demon added a comment to T187153: BadMethodCallException (mRecord->getContent() when mRecord is null) when viewing details or examine of Abuselog of Abusefilter 131 on zh.wikipedia.

Stacktrace:

#0 /srv/mediawiki/php-1.31.0-wmf.20/includes/page/WikiPage.php(722): Revision->getContent(integer, NULL)
#1 /srv/mediawiki/php-1.31.0-wmf.20/includes/page/WikiPage.php(2129): WikiPage->getContent(integer)
#2 /srv/mediawiki/php-1.31.0-wmf.20/extensions/AbuseFilter/includes/AFComputedVariable.php(192): WikiPage->prepareContentForEdit(WikitextContent)
#3 /srv/mediawiki/php-1.31.0-wmf.20/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(46): AFComputedVariable->compute(AbuseFilterVariableHolder)
#4 /srv/mediawiki/php-1.31.0-wmf.20/extensions/AbuseFilter/includes/AbuseFilterVariableHolder.php(185): AbuseFilterVariableHolder->getVar(string)
#5 /srv/mediawiki/php-1.31.0-wmf.20/extensions/AbuseFilter/includes/Views/AbuseFilterViewExamine.php(128): AbuseFilterVariableHolder->dumpAllVars(boolean)
#6 /srv/mediawiki/php-1.31.0-wmf.20/extensions/AbuseFilter/includes/Views/AbuseFilterViewExamine.php(24): AbuseFilterViewExamine->showExaminerForLogEntry(string)
#7 /srv/mediawiki/php-1.31.0-wmf.20/extensions/AbuseFilter/includes/special/SpecialAbuseFilter.php(116): AbuseFilterViewExamine->show()
#8 /srv/mediawiki/php-1.31.0-wmf.20/includes/specialpage/SpecialPage.php(522): SpecialAbuseFilter->execute(string)
#9 /srv/mediawiki/php-1.31.0-wmf.20/includes/specialpage/SpecialPageFactory.php(579): SpecialPage->run(string)
#10 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(861): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(524): MediaWiki->main()
#13 /srv/mediawiki/php-1.31.0-wmf.20/index.php(42): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)
#15 {main}
Tue, Feb 13, 5:54 AM ยท Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-log-errors, Chinese-Sites, AbuseFilter
demon added a comment to T187149: Delete all Phabricator git repos that haven't been referenced / aren't used..

Well, if a particular project wants to use Phabricator, they're more than welcome to. But some can probably be declined.

Tue, Feb 13, 5:10 AM ยท Diffusion, Gerrit, Phabricator
demon updated the task description for T187149: Delete all Phabricator git repos that haven't been referenced / aren't used..
Tue, Feb 13, 4:11 AM ยท Diffusion, Gerrit, Phabricator
demon updated the task description for T187149: Delete all Phabricator git repos that haven't been referenced / aren't used..
Tue, Feb 13, 4:09 AM ยท Diffusion, Gerrit, Phabricator
demon triaged T187149: Delete all Phabricator git repos that haven't been referenced / aren't used. as Normal priority.
Tue, Feb 13, 4:08 AM ยท Diffusion, Gerrit, Phabricator
demon moved T184086: Add prometheus exporter to Gerrit from Bugs & stuff to Local hacks on the Gerrit board.
Tue, Feb 13, 4:02 AM ยท Release-Engineering-Team, Gerrit, Operations
demon closed T184116: Setup gitiles for use with gerrit as a repo viewer as Resolved.
Tue, Feb 13, 4:01 AM ยท Patch-For-Review, Gerrit
demon closed T184116: Setup gitiles for use with gerrit as a repo viewer, a subtask of T156120: Update gerrit to 2.14.6, as Resolved.
Tue, Feb 13, 4:01 AM ยท Release-Engineering-Team (Someday), Patch-For-Review, Gerrit

Mon, Feb 12

demon added a comment to T186690: Access to manage Gerrit repos to @MarcoAurelio.

Ahhhh, found the issue:

Mon, Feb 12, 11:55 PM ยท Gerrit, Release-Engineering-Team
demon committed rGERRITDEPLOY6adde70b6464: Adding reviewers plugin (authored by demon).
Adding reviewers plugin
Mon, Feb 12, 11:46 PM
demon closed T186909: Unknown input type to UUID class: array as Resolved.
Mon, Feb 12, 8:12 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
demon closed T186909: Unknown input type to UUID class: array, a subtask of T183959: 1.31.0-wmf.20 deployment blockers, as Resolved.
Mon, Feb 12, 8:12 PM ยท Release-Engineering-Team (Kanban), Release, Train Deployments
demon added a comment to T186909: Unknown input type to UUID class: array.

This appears to be coming from some bot calling at (mostly) regular interval with an invalid URL parameter (header_newRevision[$acunetix]=1). It's an invalid request and an error is the correct response. Should it not be logged?

Also, I'll create a patch to make the error more meaningful.

Mon, Feb 12, 4:57 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
demon closed T186884: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor as Resolved.
Mon, Feb 12, 4:54 PM ยท User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Wikimedia-log-errors, VisualEditor
demon closed T186934: Undefined variable: bodyOnly in ApiVisualEditor as Resolved.
Mon, Feb 12, 4:54 PM ยท MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-Ryasmeen, Patch-For-Review, VisualEditor, Wikimedia-log-errors
demon closed T186884: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor, a subtask of T183959: 1.31.0-wmf.20 deployment blockers, as Resolved.
Mon, Feb 12, 4:54 PM ยท Release-Engineering-Team (Kanban), Release, Train Deployments
demon closed T186934: Undefined variable: bodyOnly in ApiVisualEditor, a subtask of T183959: 1.31.0-wmf.20 deployment blockers, as Resolved.
Mon, Feb 12, 4:54 PM ยท Release-Engineering-Team (Kanban), Release, Train Deployments
demon added a comment to T126597: [Task] Move WikibaseDataModel to Gerrit.

I understand it might make sense from WMF point of view as "all things in one place" (but then it should probably rather be moved to Diffusion than to Gerrit, right?). But this library is not installed from github any way, but it is part of mediawiki vendor, so I guess the location of the "main" git repo does not make much of a difference?

Mon, Feb 12, 4:50 PM ยท Wikidata-Sprint-2016-04-12, Wikidata-Sprint-2016-03-15, Wikidata-Sprint-2016-03-01, Wikibase-DataModel, Wikidata, Gerrit
demon added a comment to T187076: Deploy error: insufficient permission for adding an object to repository database .git/objects.

This usually happens for one of two reasons

  1. A root user has come along and stolen ownership to root. This should't happen often in practice, as we've got icinga alerting us (and scap itself yells if you try to run it as geteuid() == 0)
  2. A user has a busted umask
Mon, Feb 12, 4:08 PM ยท Operations, Scap

Fri, Feb 9

demon added a subtask for T183959: 1.31.0-wmf.20 deployment blockers: T186934: Undefined variable: bodyOnly in ApiVisualEditor.
Fri, Feb 9, 11:14 PM ยท Release-Engineering-Team (Kanban), Release, Train Deployments