In T156491#2976602, @TTO wrote:

Maybe the tarball creation process could just strip out all symlinks? That would seem easiest.

Plus, I disagree with the assertion that we didn't do a full reindex. We did. Twice.

Why would the changes need to be reindexed if we're talking about accounts? This whole thing is stupid mess....

I don't need a date, reindexing accounts will take all of thirty seconds.

Ok, I guess we can reindex....again.

I mean not always, but it does most of the time I believe. In any case, we should still stop using OutputPage in maintenance scripts anyway.

Given that we've been unable to reliably reproduce this, I'm going to remove it from the 1.29 blockers for now.

In T168337#3361621, @matmarex wrote:

This should be fixed after f8b8d2689d57042401d7b25cac29a45ea77e58c4.

I'm upgrading today to include the upstream patches for this, no need for deletion.

Thanks everyone for your help on this! Was quite a rabbit hole from the initial bug report :)

In T114616#3359325, @Tgr wrote:

It would be be nice to get stats of how many of these projects actually use Github, as opposed to just fooling contributors into believing they are using it. E.g. https://github.com/wikimedia/puppet-kafka/pulls looks rather sad.

Hmm, all this started after we tried swapping SysV init for systemd. Funny how that correlates 🤔 😏

I'll have a look Monday

Updated on Gerrit as well.

That's not actually where it's timing out (yay buffered output and multi-threaded updates). It's actually wikidatawiki. But yeah, I'm on it.

NOT VENDOR DEFINITELY NOT VENDOR

In T166738#3349403, @demon wrote:

Basically this bug needs me to undo the madness I started on in T137564.

Basically this bug needs me to undo the madness I started on in T137564.

This is totally related: T143188: "Key contains invalid characters" exception when purging pages with a "ä" in the title

Awesome progress, thanks!

In T166738#3322416, @Seb35 wrote:

Note sure if the previous procedure "git clone + composer update" should remain the same.

In T154424#3287219, @Legoktm wrote:

given that this warning is mainly intended for developers I don't think it should be a release blocker (since it's not trivial to fix).

I mean the performance gain over a get/set is pretty obvious. But if we can support it reliably we might need some sort of fallback.

As I said on IRC: why do we even attempt this codepath when we're not in binary mode?

Thanks for the quick fix!

I thought we shut this error up at least. It's back on wmf.5

In T125678#3343022, @Legoktm wrote:

Could we add a "beta-only" section in make-wmf-branch's config.json?

Possibly. But we also deploy some extensions to beta that we don't branch for prod yet. I'd rather just stop using that meta repo entirely--can we think up another solution?

I'm not afraid of using it, I'm mostly concerned of how we'll handle beta. We currently have the extension meta repo symlink'd for easy installation. Sadly, this would make l10n regeneration impossibly slow if we only used --extensions-dir

In T165540#3336569, @MZMcBride wrote:

In T165540#3336220, @demon wrote:

In T165540#3335372, @MZMcBride wrote:

Instead people are hastily and haphazardly spamming this file to repositories, bypassing Gerrit and other normal approval processes. This is unacceptable.

Point of clarification: this is acceptable. It's what I told people to do when questioned about the best way to do it. I said to push to Gerrit (not directly pushing) and setting them to auto-submit. The changes are all still in gerrit, they just didn't wait for someone to come along and +2. That would've been an even bigger waste of time.

If I go to https://phabricator.wikimedia.org/rEUSNbe3601d67e1ac12a6bf770847553f52971b31e04 (linked above) and click the ChangeId link, I end up at https://gerrit.wikimedia.org/r/#/q/I05c1ad258c895c5f58cba0487fe7bca0cf7bbba5, which shows no results. When you say the changes are in Gerrit (emphasis yours), what do you mean?

"Note: In GitLab EE, you can configure multiple LDAP servers to connect to one GitLab server." - first thing that jumped out.

Sooo, I looked into Gitlab some time ago. It's a nice tool. The UI is certainly easy to use. Unfortunately, the feature list is incredibly lacking without buying the enterprise version--features that we'd absolutely need. For that, it basically became a non-starter in my book.

Cf: https://www.mediawiki.org/wiki/Requests_for_comment/Migrate_code_review_and_management_to_Phabricator_from_Gerrit

In T165540#3335372, @MZMcBride wrote:

IInstead people are hastily and haphazardly spamming this file to repositories, bypassing Gerrit and other normal approval processes. This is unacceptable.

Looks better with the new UI

Per IRC, it's looking like these queries are coming from a malformed Bingbot request. So removed as blocker, although this is still pretty nasty and needs fixing.

Looks fixed, thanks!

Now it's fixed.

On re-reading the patch, it looks like $newRev does this, $oldRev still doesn't. I'll get a patch up.

The fix above ^ won't fix this at all. The error is that the function is being *passed* a null value, not that a null value is being *used*

Was backported and is now fixed.

In T167461#3334026, @Jdlrobson wrote:

This appears to be blocking deployment?

I'm still seeing this in production.

Done

Doesn't matter if it's one person or 300, cleaning up old patch sets is a pretty big pain in the ass :(

Kind of a pain if there's already patch sets :\

Nope, renaming is not possible :(

Rolled back because T152640.

Ugh. This came back with 2.13.8. @tstarling was unable to log in. After logging out, I could not log in again either. Casing didn't help, nor did reindexing accounts.

This should be fixed in all branches now. Resolve?

In T165624#3321441, @bd808 wrote:

User MacFan4000 has no contributions on wikitech, so we could just delete the local MediaWiki account and its associated LDAP record and then treat the LegoFan4000 -> MacFan4000 like a "normal" LDAP+wikitech+gerrit rename. We could also skip the delete if that seems scary for some reason and instead rename MacFan4000 to something else before renaming LegoFan4000.

It would be an improvement if you could submit comments (including ones on older patch sets) and do +/- replies (which of course would apply to the top set) in one action instead of three actions.

Actually, this is fixed. You cannot begin editing from an older version of a change anymore.

This shouldn't actually be a problem anymore.