demon (Chad Horohoe)Administrator
Software Engineer, Wikimedia

Projects (30)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:05 PM (144 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
ostriches
LDAP User
Chad
MediaWiki User
^demon

I've been around for a really long time now.

Recent Activity

Today

demon closed T33327: Make default interwiki map links protocol-relative as Declined.
Tue, Jun 27, 4:11 AM · Operations, Traffic, HTTPS, MediaWiki-General-or-Unknown
demon closed T156491: Symbolic link in MediaWiki distribution causes problems for some Windows users as Resolved.

Maybe the tarball creation process could just strip out all symlinks? That would seem easiest.

Tue, Jun 27, 1:49 AM · Release-Engineering-Team (Kanban), Patch-For-Review, MW-1.29-release, MW-1.28-release, MediaWiki-Releasing, MediaWiki-Vendor

Fri, Jun 23

demon merged T168707: Cannot login to gerrit using webinterface into T152640: Cannot log into Gerrit as of recent upgrade.
Fri, Jun 23, 5:42 PM · Release-Engineering-Team (Kanban), Upstream, Regression, Gerrit
demon merged task T168707: Cannot login to gerrit using webinterface into T152640: Cannot log into Gerrit as of recent upgrade.
Fri, Jun 23, 5:42 PM · Upstream, Release-Engineering-Team, Gerrit

Thu, Jun 22

demon added a comment to T168670: Setup maintenance date to reindex gerrit (offline reindex).

Plus, I disagree with the assertion that we didn't do a full reindex. We did. Twice.

Thu, Jun 22, 10:00 PM · Release-Engineering-Team (Kanban), Gerrit, Operations
demon added a comment to T168670: Setup maintenance date to reindex gerrit (offline reindex).

Why would the changes need to be reindexed if we're talking about accounts? This whole thing is stupid mess....

Thu, Jun 22, 9:59 PM · Release-Engineering-Team (Kanban), Gerrit, Operations
demon closed T168670: Setup maintenance date to reindex gerrit (offline reindex) as Resolved.
gerrit2@cobalt /var/lib/gerrit2/review_site$ java -jar bin/gerrit.war reindex --index accounts
[2017-06-22 21:44:26,810] [main] INFO  com.google.gerrit.server.cache.h2.H2CacheFactory : Enabling disk cache /var/lib/gerrit2/review_site/cache
[2017-06-22 21:44:27,890] [main] INFO  com.google.gerrit.server.project.ProjectCacheWarmer : Loading project cache
Reindexing accounts:    100% (4569/4569)
Reindexed 4569 documents in accounts index in 10.2s (445.8/s)
Thu, Jun 22, 9:45 PM · Release-Engineering-Team (Kanban), Gerrit, Operations
demon added a comment to T168670: Setup maintenance date to reindex gerrit (offline reindex).

I don't need a date, reindexing accounts will take all of thirty seconds.

Thu, Jun 22, 9:41 PM · Release-Engineering-Team (Kanban), Gerrit, Operations
demon added a comment to T152640: Cannot log into Gerrit as of recent upgrade.

Ok, I guess we can reindex....again.

Thu, Jun 22, 9:40 PM · Release-Engineering-Team (Kanban), Upstream, Regression, Gerrit
demon abandoned D656: Drop `scap l10n-update`: unused.
Thu, Jun 22, 9:33 PM · Release-Engineering-Team
demon added a comment to T168337: PHP Fatal error: Uncaught Error: Call to a member function canExist() on null.

I mean not always, but it does most of the time I believe. In any case, we should still stop using OutputPage in maintenance scripts anyway.

Thu, Jun 22, 8:47 PM · MediaWiki-General-or-Unknown, MW-1.29-release
demon removed a project from T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0: MW-1.29-release.

Given that we've been unable to reliably reproduce this, I'm going to remove it from the 1.29 blockers for now.

Thu, Jun 22, 8:44 PM · Timestamp
demon added a comment to T168337: PHP Fatal error: Uncaught Error: Call to a member function canExist() on null.

This should be fixed after f8b8d2689d57042401d7b25cac29a45ea77e58c4.

Thu, Jun 22, 7:42 PM · MediaWiki-General-or-Unknown, MW-1.29-release
demon closed D688: Move PHP to required packages, also allow HHVM to satisfy the dependency by committing rMSCA88ca5552ce11: Move PHP to required packages, also allow HHVM to satisfy the dependency.
Thu, Jun 22, 6:44 PM · Release-Engineering-Team
demon committed rMSCA88ca5552ce11: Move PHP to required packages, also allow HHVM to satisfy the dependency (authored by demon).
Move PHP to required packages, also allow HHVM to satisfy the dependency
Thu, Jun 22, 6:44 PM

Wed, Jun 21

demon closed T168360: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") as Resolved.
Wed, Jun 21, 9:47 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Operations, Gerrit
demon closed T168012: Internal server error when accessing change as Resolved.
Wed, Jun 21, 9:46 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Upstream, Gerrit
demon moved T168562: Reimage gerrit2001 as stretch from Bugs & stuff to Local hacks on the Gerrit board.
Wed, Jun 21, 9:45 PM · Gerrit, Operations, Release-Engineering-Team
demon added a comment to T168012: Internal server error when accessing change.

I'm upgrading today to include the upstream patches for this, no need for deletion.

Wed, Jun 21, 8:44 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Upstream, Gerrit
demon created D688: Move PHP to required packages, also allow HHVM to satisfy the dependency.
Wed, Jun 21, 7:25 PM · Release-Engineering-Team
demon added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Thanks everyone for your help on this! Was quite a rabbit hole from the initial bug report :)

Wed, Jun 21, 6:56 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
demon triaged T168562: Reimage gerrit2001 as stretch as Lowest priority.
Wed, Jun 21, 6:37 PM · Gerrit, Operations, Release-Engineering-Team
demon added a comment to T114616: Review and update GitHub mirror repo descriptions with standard text.

It would be be nice to get stats of how many of these projects actually use Github, as opposed to just fooling contributors into believing they are using it. E.g. https://github.com/wikimedia/puppet-kafka/pulls looks rather sad.

Wed, Jun 21, 4:53 PM · GitHub-Mirrors
demon added a comment to T168360: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files").

Hmm, all this started after we tried swapping SysV init for systemd. Funny how that correlates 🤔 😏

Wed, Jun 21, 5:20 AM · Release-Engineering-Team (Kanban), Patch-For-Review, Operations, Gerrit

Fri, Jun 16

demon added a comment to T168012: Internal server error when accessing change.

I'll have a look Monday

Fri, Jun 16, 11:03 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Upstream, Gerrit
demon closed T165624: Request to rename LegoFan4000 to MacFan4000 on WikiTech as Resolved.

Updated on Gerrit as well.

Fri, Jun 16, 12:15 AM · Release-Engineering-Team (Kanban), Gerrit, Labs, wikitech.wikimedia.org

Thu, Jun 15

demon renamed T167981: beta-update-databases-eqiad times out on wikidatawiki (maintenance update) from beta-update-databases-eqiad times out at "index flow_workflow_update_timestamp already" for ukwiki to beta-update-databases-eqiad times out on wikidatawiki (maintenance update).
Thu, Jun 15, 5:05 PM · Wikidata, Release-Engineering-Team (Kanban), Beta-Cluster-Infrastructure
demon raised the priority of T167981: beta-update-databases-eqiad times out on wikidatawiki (maintenance update) from High to Unbreak Now!.
Thu, Jun 15, 5:05 PM · Wikidata, Release-Engineering-Team (Kanban), Beta-Cluster-Infrastructure
demon added a comment to T167981: beta-update-databases-eqiad times out on wikidatawiki (maintenance update).

That's not actually where it's timing out (yay buffered output and multi-threaded updates). It's actually wikidatawiki. But yeah, I'm on it.

Thu, Jun 15, 5:05 PM · Wikidata, Release-Engineering-Team (Kanban), Beta-Cluster-Infrastructure
demon closed T149454: 1.28-alpha / Error: 42P01 ERROR: table "unittest_user_groups" does not exist as Resolved.
Thu, Jun 15, 4:13 PM · Release-Engineering-Team (Kanban), MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Patch-For-Review, MW-1.29-release, PostgreSQL, Regression, MediaWiki-Unit-tests, MediaWiki-Database
demon reopened T167978: Truncate 'searchindex' table on all wikis, a subtask of T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking), as Open.
Thu, Jun 15, 4:00 PM · Epic, DBA, Tracking
demon created T167978: Truncate 'searchindex' table on all wikis.
Thu, Jun 15, 4:00 PM · DBA

Wed, Jun 14

demon updated the task description for T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking).
Wed, Jun 14, 9:01 PM · Epic, DBA, Tracking
demon added a comment to T137564: Include release extensions/skins as submodules of core.

NOT VENDOR DEFINITELY NOT VENDOR

Wed, Jun 14, 7:18 PM · Release-Engineering-Team (Kanban), MW-1.29-release-notes, Patch-For-Review, MediaWiki-Releasing
demon renamed T137564: Include release extensions/skins as submodules of core from Include release extensions/skins as submodules of core (maybe vendor too?) to Include release extensions/skins as submodules of core.
Wed, Jun 14, 7:18 PM · Release-Engineering-Team (Kanban), MW-1.29-release-notes, Patch-For-Review, MediaWiki-Releasing
demon added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

Basically this bug needs me to undo the madness I started on in T137564.

Wed, Jun 14, 7:17 PM · Timestamp
demon reopened T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0 as "Open".

Basically this bug needs me to undo the madness I started on in T137564.

Wed, Jun 14, 7:16 PM · Timestamp
demon added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

This is totally related: T143188: "Key contains invalid characters" exception when purging pages with a "ä" in the title

Wed, Jun 14, 7:11 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
demon added a comment to T164949: Drop titlekey table from all wmf databases.

Awesome progress, thanks!

Wed, Jun 14, 5:37 PM · Schema-change, DBA
demon added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

Note sure if the previous procedure "git clone + composer update" should remain the same.

Wed, Jun 14, 5:06 PM · Timestamp
demon removed a project from T154424: TransactionProfiler should not apply to SqlBagOStuff: MW-1.29-release.

given that this warning is mainly intended for developers I don't think it should be a release blocker (since it's not trivial to fix).

Wed, Jun 14, 5:03 PM · MediaWiki-Cache, MediaWiki-Database
demon placed T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor up for grabs.
Wed, Jun 14, 5:34 AM · Release-Engineering-Team (Kanban), Story, Wikidata
demon added a comment to T143464: "Memcached::touch(): touch is only supported with binary protocol" from wikitech as it's not running HHVM.

I mean the performance gain over a get/set is pretty obvious. But if we can support it reliably we might need some sort of fallback.

Wed, Jun 14, 5:12 AM · wikitech.wikimedia.org, Labs, Wikimedia-log-errors, MW-1.28-release-notes, MediaWiki-Cache
demon closed T166266: Beta update.php fails with Can't DROP 'flow_ext_ref_idx_v2'; as Resolved.
Wed, Jun 14, 12:21 AM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Release-Engineering-Team (Kanban), Patch-For-Review, MediaWiki-Database, Beta-Cluster-Infrastructure, Flow
demon added a comment to T143464: "Memcached::touch(): touch is only supported with binary protocol" from wikitech as it's not running HHVM.

As I said on IRC: why do we even attempt this codepath when we're not in binary mode?

Wed, Jun 14, 12:20 AM · wikitech.wikimedia.org, Labs, Wikimedia-log-errors, MW-1.28-release-notes, MediaWiki-Cache

Tue, Jun 13

demon closed T152640: Cannot log into Gerrit as of recent upgrade as Resolved.
Tue, Jun 13, 11:31 PM · Release-Engineering-Team (Kanban), Upstream, Regression, Gerrit
demon closed T158946: Update gerrit to 2.13.8 as Resolved.
Tue, Jun 13, 11:31 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Gerrit
demon closed T167826: ApiParse: Call to member function getModel() on non-object as Resolved.

Thanks for the quick fix!

Tue, Jun 13, 8:03 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, MediaWiki-API, Wikimedia-log-errors
demon added a comment to T143464: "Memcached::touch(): touch is only supported with binary protocol" from wikitech as it's not running HHVM.

I thought we shut this error up at least. It's back on wmf.5

Tue, Jun 13, 7:43 PM · wikitech.wikimedia.org, Labs, Wikimedia-log-errors, MW-1.28-release-notes, MediaWiki-Cache
demon created T167826: ApiParse: Call to member function getModel() on non-object.
Tue, Jun 13, 7:37 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, MediaWiki-API, Wikimedia-log-errors
demon created P5573 AbstractSync with no --force defined.
Tue, Jun 13, 5:32 PM

Mon, Jun 12

demon moved T167533: MW-1.30.0-wmf.5 deployment blockers from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
Mon, Jun 12, 11:08 PM · Release, Release-Engineering-Team (Kanban), Train Deployments
demon moved T153271: Release MediaWiki 1.29 from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
Mon, Jun 12, 11:08 PM · Release-Engineering-Team (Kanban), releng-201617-q4, MW-1.29-release, MediaWiki-General-or-Unknown, Release
demon claimed T153271: Release MediaWiki 1.29.
Mon, Jun 12, 11:07 PM · Release-Engineering-Team (Kanban), releng-201617-q4, MW-1.29-release, MediaWiki-General-or-Unknown, Release
demon added a comment to T125678: SCAP should not rely on extension-list, instead pass --extension-dir to mergeMessageFileList.php.

Could we add a "beta-only" section in make-wmf-branch's config.json?

Mon, Jun 12, 10:12 PM · Release-Engineering-Team (Kanban), Scap (Scap3-MediaWiki-MVP), MediaWiki-Configuration
demon added a comment to T125678: SCAP should not rely on extension-list, instead pass --extension-dir to mergeMessageFileList.php.

Possibly. But we also deploy some extensions to beta that we don't branch for prod yet. I'd rather just stop using that meta repo entirely--can we think up another solution?

Mon, Jun 12, 9:50 PM · Release-Engineering-Team (Kanban), Scap (Scap3-MediaWiki-MVP), MediaWiki-Configuration
demon added a comment to T125678: SCAP should not rely on extension-list, instead pass --extension-dir to mergeMessageFileList.php.

I'm not afraid of using it, I'm mostly concerned of how we'll handle beta. We currently have the extension meta repo symlink'd for easy installation. Sadly, this would make l10n regeneration impossibly slow if we only used --extensions-dir

Mon, Jun 12, 5:00 PM · Release-Engineering-Team (Kanban), Scap (Scap3-MediaWiki-MVP), MediaWiki-Configuration
demon committed rMSCAca6b7471eb04: Minor fixups to doc underlining (authored by demon).
Minor fixups to doc underlining
Mon, Jun 12, 4:59 PM
demon closed D682: Minor fixups to doc underlining by committing rMSCAca6b7471eb04: Minor fixups to doc underlining.
Mon, Jun 12, 4:59 PM · Release-Engineering-Team

Fri, Jun 9

demon added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

Instead people are hastily and haphazardly spamming this file to repositories, bypassing Gerrit and other normal approval processes. This is unacceptable.

Point of clarification: this is acceptable. It's what I told people to do when questioned about the best way to do it. I said to push to Gerrit (not directly pushing) and setting them to auto-submit. The changes are all still in gerrit, they just didn't wait for someone to come along and +2. That would've been an even bigger waste of time.

If I go to https://phabricator.wikimedia.org/rEUSNbe3601d67e1ac12a6bf770847553f52971b31e04 (linked above) and click the ChangeId link, I end up at https://gerrit.wikimedia.org/r/#/q/I05c1ad258c895c5f58cba0487fe7bca0cf7bbba5, which shows no results. When you say the changes are in Gerrit (emphasis yours), what do you mean?

Fri, Jun 9, 10:28 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
demon added a comment to T167547: Replace Gerrit & GitHub with GitLab.

"Note: In GitLab EE, you can configure multiple LDAP servers to connect to one GitLab server." - first thing that jumped out.

Fri, Jun 9, 9:21 PM · GitHub-Mirrors, Gerrit, ArchCom-RfC
demon closed T167547: Replace Gerrit & GitHub with GitLab as Declined.

Sooo, I looked into Gitlab some time ago. It's a nice tool. The UI is certainly easy to use. Unfortunately, the feature list is incredibly lacking without buying the enterprise version--features that we'd absolutely need. For that, it basically became a non-starter in my book.

Fri, Jun 9, 8:23 PM · GitHub-Mirrors, Gerrit, ArchCom-RfC
demon added a comment to T167547: Replace Gerrit & GitHub with GitLab.

Cf: https://www.mediawiki.org/wiki/Requests_for_comment/Migrate_code_review_and_management_to_Phabricator_from_Gerrit

Fri, Jun 9, 8:15 PM · GitHub-Mirrors, Gerrit, ArchCom-RfC
demon added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

IInstead people are hastily and haphazardly spamming this file to repositories, bypassing Gerrit and other normal approval processes. This is unacceptable.

Fri, Jun 9, 7:24 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
demon created D682: Minor fixups to doc underlining.
Fri, Jun 9, 6:08 PM · Release-Engineering-Team
demon added a comment to T141947: Unable to see which patch is the parent/dependency of specific patch.

Looks better with the new UI

Fri, Jun 9, 3:39 PM · Upstream, Gerrit
demon created T167480: Unexpected general module ext.proofreadpage.page* in styles queue.
Fri, Jun 9, 12:02 AM · ProofreadPage, Wikisource, Wikimedia-log-errors

Thu, Jun 8

demon closed T166829: MW-1.30.0-wmf.4 deployment blockers as Resolved.
Thu, Jun 8, 11:58 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
demon added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

Per IRC, it's looking like these queries are coming from a malformed Bingbot request. So removed as blocker, although this is still pretty nasty and needs fixing.

Thu, Jun 8, 11:33 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
demon removed a parent task for T167465: "Key contains invalid characters" when using MultiWriteBagOStuff: T166829: MW-1.30.0-wmf.4 deployment blockers.
Thu, Jun 8, 11:32 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
demon removed a subtask for T166829: MW-1.30.0-wmf.4 deployment blockers: T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.
Thu, Jun 8, 11:32 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
demon closed T167473: DeleteArchive: Object does not implement ArrayAccess as Resolved.

Looks fixed, thanks!

Thu, Jun 8, 11:18 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Discovery-Search, CirrusSearch, Discovery, Wikimedia-log-errors
demon closed T167359: Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given as Resolved.

Now it's fixed.

Thu, Jun 8, 10:57 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Release-Engineering-Team (Kanban), Patch-For-Review, Revision-Slider, TCB-Team, Wikimedia-log-errors
demon closed T167359: Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given , a subtask of T166829: MW-1.30.0-wmf.4 deployment blockers, as Resolved.
Thu, Jun 8, 10:57 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
demon committed rERSL319e382d41f0: Also drop Revision typehint from $oldRev (authored by demon).
Also drop Revision typehint from $oldRev
Thu, Jun 8, 10:40 PM
demon committed rERSL0687de3fbdc3: Also drop Revision typehint from $oldRev (authored by demon).
Also drop Revision typehint from $oldRev
Thu, Jun 8, 10:35 PM
demon added a comment to T167359: Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given .

On re-reading the patch, it looks like $newRev does this, $oldRev still doesn't. I'll get a patch up.

Thu, Jun 8, 10:27 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Release-Engineering-Team (Kanban), Patch-For-Review, Revision-Slider, TCB-Team, Wikimedia-log-errors
demon added a comment to T167359: Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given .

The fix above ^ won't fix this at all. The error is that the function is being *passed* a null value, not that a null value is being *used*

Thu, Jun 8, 10:22 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Release-Engineering-Team (Kanban), Patch-For-Review, Revision-Slider, TCB-Team, Wikimedia-log-errors
demon closed T167461: SpecialMobileDiff: Call to member function getDiffBody() on non-object as Resolved.

Was backported and is now fixed.

Thu, Jun 8, 10:19 PM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), Release-Engineering-Team (Kanban), Patch-For-Review, Reading-Web-Kanban-Board, Unplanned-Sprint-Work, Reading-Web-Backlog, MobileFrontend, Wikimedia-log-errors
demon closed T167461: SpecialMobileDiff: Call to member function getDiffBody() on non-object, a subtask of T166829: MW-1.30.0-wmf.4 deployment blockers, as Resolved.
Thu, Jun 8, 10:18 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
demon created T167473: DeleteArchive: Object does not implement ArrayAccess.
Thu, Jun 8, 10:09 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Discovery-Search, CirrusSearch, Discovery, Wikimedia-log-errors
demon added a comment to T167461: SpecialMobileDiff: Call to member function getDiffBody() on non-object.

This appears to be blocking deployment?

Thu, Jun 8, 9:05 PM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), Release-Engineering-Team (Kanban), Patch-For-Review, Reading-Web-Kanban-Board, Unplanned-Sprint-Work, Reading-Web-Backlog, MobileFrontend, Wikimedia-log-errors
demon created T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.
Thu, Jun 8, 8:10 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
demon created T167461: SpecialMobileDiff: Call to member function getDiffBody() on non-object.
Thu, Jun 8, 7:45 PM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), Release-Engineering-Team (Kanban), Patch-For-Review, Reading-Web-Kanban-Board, Unplanned-Sprint-Work, Reading-Web-Backlog, MobileFrontend, Wikimedia-log-errors
demon added a comment to T167359: Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given .

I'm still seeing this in production.

Thu, Jun 8, 7:42 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Release-Engineering-Team (Kanban), Patch-For-Review, Revision-Slider, TCB-Team, Wikimedia-log-errors
demon closed T167315: mirror search/MjoLniR repository to github as Resolved.

Done

Thu, Jun 8, 6:48 PM · Release-Engineering-Team (Kanban), Gerrit
demon added a comment to T167315: mirror search/MjoLniR repository to github.

Doesn't matter if it's one person or 300, cleaning up old patch sets is a pretty big pain in the ass :(

Thu, Jun 8, 6:36 PM · Release-Engineering-Team (Kanban), Gerrit
demon added a comment to T167315: mirror search/MjoLniR repository to github.

Kind of a pain if there's already patch sets :\

Thu, Jun 8, 6:33 PM · Release-Engineering-Team (Kanban), Gerrit
demon added a comment to T167315: mirror search/MjoLniR repository to github.

Nope, renaming is not possible :(

Thu, Jun 8, 6:17 PM · Release-Engineering-Team (Kanban), Gerrit

Wed, Jun 7

demon reopened T158946: Update gerrit to 2.13.8 as "Open".

Rolled back because T152640.

Wed, Jun 7, 12:26 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Gerrit
demon moved T152640: Cannot log into Gerrit as of recent upgrade from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
Wed, Jun 7, 12:24 AM · Release-Engineering-Team (Kanban), Upstream, Regression, Gerrit
demon reopened T152640: Cannot log into Gerrit as of recent upgrade as "Open".

Ugh. This came back with 2.13.8. @tstarling was unable to log in. After logging out, I could not log in again either. Casing didn't help, nor did reindexing accounts.

Wed, Jun 7, 12:23 AM · Release-Engineering-Team (Kanban), Upstream, Regression, Gerrit
demon created P5553 gerrit accounts (Chad vs Tim).
Wed, Jun 7, 12:08 AM

Tue, Jun 6

demon added a comment to T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.

This should be fixed in all branches now. Resolve?

Tue, Jun 6, 10:56 PM · MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
demon added a comment to T165624: Request to rename LegoFan4000 to MacFan4000 on WikiTech.

User MacFan4000 has no contributions on wikitech, so we could just delete the local MediaWiki account and its associated LDAP record and then treat the LegoFan4000 -> MacFan4000 like a "normal" LDAP+wikitech+gerrit rename. We could also skip the delete if that seems scary for some reason and instead rename MacFan4000 to something else before renaming LegoFan4000.

Tue, Jun 6, 10:21 PM · Release-Engineering-Team (Kanban), Gerrit, Labs, wikitech.wikimedia.org
demon added a comment to T142256: Inconvenient review workflow for Gerrit.

It would be an improvement if you could submit comments (including ones on older patch sets) and do +/- replies (which of course would apply to the top set) in one action instead of three actions.

Tue, Jun 6, 10:18 PM · Gerrit
demon closed T54292: Changing the commit description creates out-dated patch. as Resolved.

Actually, this is fixed. You cannot begin editing from an older version of a change anymore.

Tue, Jun 6, 10:14 PM · Release-Engineering-Team (Kanban), Gerrit
demon moved T62412: ldap/wmf group should not have +2 in Gerrit from Repo Admin to Discussiony & doc stuff on the Gerrit board.
Tue, Jun 6, 10:09 PM · Gerrit
demon closed T151676: gerrit jgit gc caused mediawiki/core repo problems as Resolved.

This shouldn't actually be a problem anymore.

Tue, Jun 6, 10:04 PM · Release-Engineering-Team (Kanban), Upstream, Beta-Cluster-reproducible, Operations, Gerrit
demon closed T151676: gerrit jgit gc caused mediawiki/core repo problems, a subtask of T153079: Merge/Submit error on Gerrit: "org.eclipse.jgit.errors.MissingObjectException: Missing unknown" for BlueSpiceExtensions' REL1_27 branch, as Resolved.
Tue, Jun 6, 10:04 PM · Patch-For-Review, Upstream, Gerrit, BlueSpice