demon (Chad Horohoe)Administrator
Software Engineer, Wikimedia

Projects (34)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 7:05 PM (160 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
ostriches
LDAP User
Chad
MediaWiki User
^demon

I've been around for a really long time now.

Recent Activity

Yesterday

demon closed T175324: It shouldn't be possible to create WMF branches on master as Resolved.

Should be fixed now.

Mon, Oct 16, 11:40 PM · MediaWiki-Release-Tools, Release-Engineering-Team (Kanban), Patch-For-Review
demon updated the diff for D822: Remove support for DOLOGMSGNOLOG environment variable.
  • Still support environment variable as a fallback, with a warning
Mon, Oct 16, 9:43 PM · Release-Engineering-Team
demon moved T171758: Support git-lfs files in gerrit from Backlog to It's happening on the Scap (Tech Debt Sprint FY201718-Q2) board.
Mon, Oct 16, 9:18 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), Scoring-platform-team, Gerrit, Operations, ORES
demon moved T68049: [scap] Add a command line flag to replace DOLOGMSGNOLOG from Backlog to It's happening on the Scap (Tech Debt Sprint FY201718-Q2) board.
Mon, Oct 16, 9:18 PM · Scap (Tech Debt Sprint FY201718-Q2)
demon created D822: Remove support for DOLOGMSGNOLOG environment variable.
Mon, Oct 16, 9:15 PM · Release-Engineering-Team
demon committed rMSCA87ad3bc49ae2: Remove blacklisted variable name "bar" (authored by demon).
Remove blacklisted variable name "bar"
Mon, Oct 16, 9:02 PM
demon closed D817: Remove blacklisted variable name "bar".
Mon, Oct 16, 9:02 PM · Release-Engineering-Team
demon created D821: Stop using len() as a conditional.
Mon, Oct 16, 8:54 PM · Release-Engineering-Team
demon committed rMSCA64bcd5fae4bd: Fix various indentation/continuation errors (authored by demon).
Fix various indentation/continuation errors
Mon, Oct 16, 8:40 PM
demon closed D815: Fix various indentation/continuation errors.
Mon, Oct 16, 8:40 PM · Release-Engineering-Team
demon created D820: Custom exception tidying.
Mon, Oct 16, 8:36 PM · Release-Engineering-Team
demon created D819: Missed a CONSTANT.
Mon, Oct 16, 8:02 PM · Release-Engineering-Team
demon created D817: Remove blacklisted variable name "bar".
Mon, Oct 16, 6:45 PM · Release-Engineering-Team
demon closed T178322: Enable auto submodule updates on operations/puppet as Declined.

I'm pretty sure nobody in ops wants this functionality on puppet -- the parent repo operates by the policy of "if you merge it, you should deploy it right now." Merging a submodule doesn't imply that they want to deploy it right now.

Mon, Oct 16, 6:38 PM · Patch-For-Review, Gerrit, Operations

Sat, Oct 14

demon added a comment to T171758: Support git-lfs files in gerrit.

The /srv/ partition on Gerrit is only 1% full, we've got plenty of space.

Sat, Oct 14, 1:01 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), Scoring-platform-team, Gerrit, Operations, ORES
demon added a comment to T171758: Support git-lfs files in gerrit.

We could possibly do FS-based for now, pending work on supporting Swift.

Sat, Oct 14, 12:59 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), Scoring-platform-team, Gerrit, Operations, ORES

Fri, Oct 13

demon added a comment to T178189: Temporarily allow pushing large objects.

temporary solutions have a terrible habit of becoming permanent, around here.

Fri, Oct 13, 11:37 PM · Unplanned-Sprint-Work, Readers-Web-Kanban-Board, Patch-For-Review, Readers-Web-Backlog, Gerrit
demon created D815: Fix various indentation/continuation errors.
Fri, Oct 13, 11:08 PM · Release-Engineering-Team
demon committed rMSCA1cb405570890: Consistently SHOUT AT PEOPLE FOR CONSTANTS (authored by demon).
Consistently SHOUT AT PEOPLE FOR CONSTANTS
Fri, Oct 13, 10:38 PM
demon closed D813: Consistently SHOUT AT PEOPLE FOR CONSTANTS.
Fri, Oct 13, 10:38 PM · Release-Engineering-Team
demon accepted D807: Key_name is None for some reason..
Fri, Oct 13, 9:59 PM · Release-Engineering-Team
demon created P6119 current pylint E-level issues in scap.
Fri, Oct 13, 5:35 PM
demon closed T174359: 1.31.0-wmf.3 deployment blockers as Resolved.
Fri, Oct 13, 3:45 PM · Release-Engineering-Team (Kanban), Train Deployments, Release
demon added a comment to T177082: Archive the AntiBot extension.

Done.

Fri, Oct 13, 3:19 PM · MediaWiki-extensions-Other, Repository-Admins, User-MarcoAurelio, Cleanup
demon closed T164030: setup releases1001.eqiad.wmnet (was: setup mwreleases1001) as Resolved.

The machine itself is up and running with Jenkins as expected, resolving. Other changes are outside the scope of this task.

Fri, Oct 13, 3:17 PM · Release-Engineering-Team (Kanban), RelEng-Archive-FY201718-Q1, Patch-For-Review, Operations, Security-General
demon closed T164030: setup releases1001.eqiad.wmnet (was: setup mwreleases1001), a subtask of T163743: New ganeti VM for MW release pipeline work, as Resolved.
Fri, Oct 13, 3:17 PM · Operations, Security-General, Release-Engineering-Team, vm-requests
demon committed rMSCAed7e2e5d22cf: Nicer logging syntax, less characters (authored by demon).
Nicer logging syntax, less characters
Fri, Oct 13, 3:15 PM
demon closed D814: Nicer logging syntax, less characters.
Fri, Oct 13, 3:15 PM · Release-Engineering-Team
demon committed rMSCA89f016309239: Reorder some imports to satisfy pylints super strict desires (authored by demon).
Reorder some imports to satisfy pylints super strict desires
Fri, Oct 13, 3:14 PM
demon closed D812: Reorder some imports to satisfy pylints super strict desires.
Fri, Oct 13, 3:14 PM · Release-Engineering-Team
demon closed D811: Remove useless else: branches after return statements.
Fri, Oct 13, 3:14 PM · Release-Engineering-Team
demon committed rMSCA4703af62c58c: Remove useless else: branches after return statements (authored by demon).
Remove useless else: branches after return statements
Fri, Oct 13, 3:14 PM
demon closed D810: Use idiomatic isinstance() instead of type() == foo checks.
Fri, Oct 13, 3:10 PM · Release-Engineering-Team
demon committed rMSCAfc117d98b4d1: Use idiomatic isinstance() instead of type() == foo checks (authored by demon).
Use idiomatic isinstance() instead of type() == foo checks
Fri, Oct 13, 3:10 PM
demon added inline comments to D808: Add php-cli to Debian suggests options.
Fri, Oct 13, 12:53 AM · Release-Engineering-Team

Thu, Oct 12

demon added a comment to T117470: Ensure CAS errors aren't cause problems / trending up.

I'm well aware of that. I mean what's the status on somebody actually caring and doing something about it.

Thu, Oct 12, 10:44 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-User-management, Wikimedia-log-errors
demon created D814: Nicer logging syntax, less characters.
Thu, Oct 12, 10:28 PM · Release-Engineering-Team
demon created D813: Consistently SHOUT AT PEOPLE FOR CONSTANTS.
Thu, Oct 12, 10:14 PM · Release-Engineering-Team
demon created D812: Reorder some imports to satisfy pylints super strict desires.
Thu, Oct 12, 10:01 PM · Release-Engineering-Team
demon created D811: Remove useless else: branches after return statements.
Thu, Oct 12, 9:36 PM · Release-Engineering-Team
demon created D810: Use idiomatic isinstance() instead of type() == foo checks.
Thu, Oct 12, 9:23 PM · Release-Engineering-Team
demon accepted D809: Fix local variable 'search_path' referenced before assignment.
Thu, Oct 12, 9:17 PM · Release-Engineering-Team
demon committed rMSCAebf2cecef570: Remove superfluous parens (authored by demon).
Remove superfluous parens
Thu, Oct 12, 8:46 PM
demon committed rMSCAa6f848c9dc6e: [] as a default value is considered "dangerous" (authored by demon).
[] as a default value is considered "dangerous"
Thu, Oct 12, 8:43 PM
demon closed D806: [] as a default value is considered "dangerous".
Thu, Oct 12, 8:43 PM · Release-Engineering-Team
demon updated the diff for D806: [] as a default value is considered "dangerous".
  • Slightly more strict value checking
Thu, Oct 12, 8:37 PM · Release-Engineering-Team
demon created D806: [] as a default value is considered "dangerous".
Thu, Oct 12, 8:26 PM · Release-Engineering-Team
demon added a comment to T117470: Ensure CAS errors aren't cause problems / trending up.

What's the current status on this?

Thu, Oct 12, 7:18 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-User-management, Wikimedia-log-errors
zeljkofilipin awarded T170484: Play elevator music while scap is running a Love token.
Thu, Oct 12, 5:25 PM · Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), WorkType-NewFunctionality
demon reopened T170484: Play elevator music while scap is running as "Open".
Thu, Oct 12, 4:25 PM · Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), WorkType-NewFunctionality
demon reopened T170484: Play elevator music while scap is running, a subtask of T31079: RESOLVED HUMOROUS (TRACKING), as Open.
Thu, Oct 12, 4:25 PM · Wikimedia-General-or-Unknown, Tracking
zeljkofilipin awarded T170484: Play elevator music while scap is running a Heartbreak token.
Thu, Oct 12, 3:33 PM · Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), WorkType-NewFunctionality
demon added a comment to T178039: scap should not pull in HHVM on stretch hosts using PHP7.

PHP should probably be a Suggests, not a Depends. It's only used by the master and only used for linting. This is a packaging issue -- easily fixed.

Thu, Oct 12, 3:12 AM · Operations, Scap

Wed, Oct 11

demon added a comment to T177974: Drop #wikimedia-codereview channel.

We have too many damn channels as it is.... so +100000 for killing this.

Wed, Oct 11, 6:19 PM · Patch-For-Review, wikimedia-irc-freenode

Thu, Oct 5

demon added a comment to T153033: Drop MoodBar tables from all wikis.

Testwiki we can drop for sure. So that just leaves 7 total wikis with viable data. Farrrrrrrr better.

Thu, Oct 5, 7:48 AM · Analytics, DBA

Wed, Oct 4

demon added a comment to T153033: Drop MoodBar tables from all wikis.

Just to be clear, you are talking about dbstore1002/db1047?
We also have to keep in mind that there are thousands of tables (two per wiki basically), so we would need to rename them to something like:

wikiname_moodbar_feedback
wikiname_moodbar_feedback_response

Before (or during) the import there.

If dbstore1002 is involved, I would wait until T168303 is in a better state

Wed, Oct 4, 8:25 PM · Analytics, DBA
demon triaged T176532: Gerrit is failing to connect to db on gerrit2001 thus preventing systemd from working as Low priority.
Wed, Oct 4, 8:22 PM · DBA, Patch-For-Review, Release-Engineering-Team (Next), Operations, Gerrit

Tue, Oct 3

demon created T177352: PageTranslationHooks::onPageContentLanguage() must be an instance of Language, StubUserLang given.
Tue, Oct 3, 11:36 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), MediaWiki-extensions-Translate, Patch-For-Review, Wikimedia-log-errors
demon planned changes to D802: Revert "Revert "Refactor most git commands to use a single wrapper"".

Per IRC: definitely remove checkout() from this change for now, and remove the exception handling in the lower-level function so we don't mask errors.

Tue, Oct 3, 11:24 PM · Release-Engineering-Team
demon created D802: Revert "Revert "Refactor most git commands to use a single wrapper"".
Tue, Oct 3, 11:23 PM · Release-Engineering-Team
demon created T177334: Determine status of fundraising-related branches and tags.
Tue, Oct 3, 9:03 PM · Release-Engineering-Team (Kanban), Fundraising-Backlog, Gerrit
demon added a comment to T142345: Consider archiving #MediaWiki-Documentation & #Pywikibot-documentation in favour of single #Documentation.

I usually prefer combining two generic tags in a search and taking the intersection, instead of creating gazillions of very specialized tags.

Tue, Oct 3, 8:54 PM · Pywikibot-Documentation, MediaWiki-Documentation, Documentation, RfC, Project-Admins
demon committed rMSCAadbeba3d447f: Tidy up some low-level exception handling (authored by demon).
Tidy up some low-level exception handling
Tue, Oct 3, 1:19 AM
demon closed D795: Tidy up some low-level exception handling.
Tue, Oct 3, 1:19 AM · Release-Engineering-Team
demon updated the diff for D795: Tidy up some low-level exception handling.
  • Rebased
Tue, Oct 3, 1:11 AM · Release-Engineering-Team
demon updated the diff for D795: Tidy up some low-level exception handling.
  • Remove SystemExit catch entirely -- no point really per code review
Tue, Oct 3, 1:00 AM · Release-Engineering-Team
demon added a comment to T146226: Purge the hhvm fcgi and cli bytecache as part of deployment.
Tue, Oct 3, 12:26 AM · Scap

Mon, Oct 2

demon closed T94149: Get rid of Zend 5.5 tests for wmf branches as Declined.
Mon, Oct 2, 10:45 PM · Release-Engineering-Team (Backlog), Continuous-Integration-Config, Continuous-Integration-Infrastructure (Little Steps Sprint)
zeljkofilipin awarded T170484: Play elevator music while scap is running a Y So Serious token.
Mon, Oct 2, 10:47 AM · Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), WorkType-NewFunctionality

Thu, Sep 28

demon closed D771: Refactor most git commands to use a single wrapper.
Thu, Sep 28, 9:15 PM · Release-Engineering-Team
demon committed rMSCA7df5576f40af: Refactor most git commands to use a single wrapper (authored by demon).
Refactor most git commands to use a single wrapper
Thu, Sep 28, 9:15 PM

Wed, Sep 27

demon added inline comments to D795: Tidy up some low-level exception handling.
Wed, Sep 27, 8:35 PM · Release-Engineering-Team
demon created D795: Tidy up some low-level exception handling.
Wed, Sep 27, 8:33 PM · Release-Engineering-Team

Tue, Sep 26

demon created P6046 Probably why gerrit2001 won't start -- it can't reach the DB.
Tue, Sep 26, 6:38 PM
demon created P6045 (An Untitled Masterwork).
Tue, Sep 26, 5:44 PM

Mon, Sep 25

demon added a comment to T173576: Templates rendering as links on beta cluster.

Yes, it's controlled through a combination of several settings: final page size, expansion depths, etc etc etc. As far as I know, these are basically all kept to default core values except $wgMaxGeneratedPPNodeCount. They're not purposefully low, and definitely are the same between beta & production--curious why production doesn't fail in the same manner.... I'd recommend having an article with fewer references 🤔

Mon, Sep 25, 5:34 PM · Parsing-Team, Release-Engineering-Team, Readers-Web-Backlog (Tracking), MediaWiki-Parser, Beta-Cluster-Infrastructure
demon closed T170637: 1.30.0-wmf.19 deployment blockers as Resolved.
Mon, Sep 25, 4:43 PM · RelEng-Archive-FY201718-Q1, Train Deployments, Release

Fri, Sep 22

demon updated subscribers of T175499: Tool to archive extensions (and do related stuff)?.

Note: a "template" for requesting archive is provided by @mmodell: T174410. But it would be love to migrate it to a Toolforge tool, isn't that?

Fri, Sep 22, 11:57 PM · Diffusion, Continuous-Integration-Config, GitHub-Mirrors, Gerrit, Cleanup
demon added a comment to D792: Support SSH_AGENT_RSA_SHA2_512.

Not a complaint here, but generally: do we have to stick to RSA keys? I'm thinking like ed25519 specifically.

Fri, Sep 22, 11:54 PM · Release-Engineering-Team
demon added a comment to T175324: It shouldn't be possible to create WMF branches on master.

What I said on IRC after going down a very deep rabbit hole with @thcipriani on this.

Fri, Sep 22, 10:06 PM · MediaWiki-Release-Tools, Release-Engineering-Team (Kanban), Patch-For-Review
demon created P6041 git branch contains.
Fri, Sep 22, 9:34 PM

Thu, Sep 21

demon created T176440: Undefined variable: content in ApiVisualEditor.
Thu, Sep 21, 8:53 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), VisualEditor-MediaWiki, User-Ryasmeen, Patch-For-Review, VisualEditor, Wikimedia-log-errors

Wed, Sep 20

demon closed T176080: Archive the SemanticMediaWiki on gerrit.wikimedia.org as Resolved.
Wed, Sep 20, 6:28 PM · Patch-For-Review, Repository-Admins, Cleanup
demon added a comment to T176080: Archive the SemanticMediaWiki on gerrit.wikimedia.org.

Deleted on github, read-only in Gerrit, archived in Phab

Wed, Sep 20, 6:27 PM · Patch-For-Review, Repository-Admins, Cleanup
demon updated the task description for T176080: Archive the SemanticMediaWiki on gerrit.wikimedia.org.
Wed, Sep 20, 6:27 PM · Patch-For-Review, Repository-Admins, Cleanup
demon added a comment to T176080: Archive the SemanticMediaWiki on gerrit.wikimedia.org.

Repo has already been emptied in Gerrit, can probably go straight to archiving.

Wed, Sep 20, 6:13 PM · Patch-For-Review, Repository-Admins, Cleanup
demon updated the task description for T176080: Archive the SemanticMediaWiki on gerrit.wikimedia.org.
Wed, Sep 20, 6:04 PM · Patch-For-Review, Repository-Admins, Cleanup
demon added a comment to T176314: Replace salt on integration and deployment-prep projects.

I don't really feel like nitpicking over projects or dependencies, but I'm pretty much in agreement with @faidon here and I definitely see our path forward....

Wed, Sep 20, 3:13 PM · RelEng-Archive-FY201718-Q1, Patch-For-Review, Continuous-Integration-Infrastructure, Beta-Cluster-Infrastructure, Technical-Debt, Operations-Software-Development

Tue, Sep 19

demon added a comment to T176133: Archive the USERINFO repo.

Hehe, let's archive/delete it. I was being silly :P

Tue, Sep 19, 5:03 PM · Repository-Admins, User-MarcoAurelio
demon closed T170636: 1.30.0-wmf.18 deployment blockers as Resolved.
Tue, Sep 19, 4:16 PM · RelEng-Archive-FY201718-Q1, Train Deployments, Release

Mon, Sep 18

demon added a comment to T126306: Eliminate symlinks in mediawiki-config (as much as possible).

PrivateSettings shouldn't happen anymore. CommonSettings just uses PrivateSettings directly now instead of a silly symlink.

Mon, Sep 18, 11:10 PM · Release-Engineering-Team (Kanban), Scap (Tech Debt Sprint FY201718-Q2), scap2
demon added a comment to T116630: Remove apache dependency from scap3 deployment host.

I don't think this is really the direction we were planning to go in anymore.

Mon, Sep 18, 10:38 PM · Scap (Scap3-MediaWiki-MVP), scap2, WorkType-NewFunctionality
demon updated the task description for T164780: Sunset our use of Salt.
Mon, Sep 18, 9:23 PM · Patch-For-Review, Goal, Technical-Debt, Operations-Software-Development, Operations
demon added a comment to T129148: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner).

Docs lgtm

Mon, Sep 18, 9:00 PM · RelEng-Archive-FY201718-Q1, Performance-Team (Radar), JobRunner-Service, Deployments, Scap (Scap3-Adoption-Phase1), scap2
demon triaged T176164: Switch to mariadb java connector once we upgrade to gerrit 2.14 as Low priority.
Mon, Sep 18, 6:50 PM · Patch-For-Review, Gerrit
demon added a comment to T176133: Archive the USERINFO repo.

THIS IS THE MOST IMPORTANT REPO IN THE HISTORY OF MEDIAWIKI

Mon, Sep 18, 4:58 PM · Repository-Admins, User-MarcoAurelio
demon added a comment to T148825: Deprecate unmaintained/inactive XMLContentExtension.

Done.

Mon, Sep 18, 4:58 PM · RelEng-Archive-FY201718-Q1, User-MarcoAurelio, Repository-Admins, Cleanup
demon added a comment to T176131: Make sure uses of PrivateSettings file in dumps don't rely on symlink.

Yeah I already went through all repos and everything seems to reference it directly. I'm also going to go in two stages: swap the wmf-config to point to the direct file. Wait a bit. Thennnnnn we'll drop the symlink.

Mon, Sep 18, 4:56 PM · User-ArielGlenn, Dumps-Generation
demon raised the priority of T137564: Include release extensions/skins/vendor as submodules of core from Lowest to High.
Mon, Sep 18, 4:32 PM · Release-Engineering-Team (Kanban), MW-1.29-release-notes, Patch-For-Review, MediaWiki-Releasing
demon lowered the priority of T148478: Investigate seemingly random Gerrit slow-downs from High to Low.
Mon, Sep 18, 4:31 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Gerrit, Operations