Page MenuHomePhabricator

dmitriy.sky (Dmitriy.sky)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 19 2021, 3:11 PM (153 w, 4 h)
Availability
Available
LDAP User
Dmitriy.sky
MediaWiki User
Unknown

Recent Activity

Jun 29 2021

dmitriy.sky added a comment to T282105: WatchedItemStore should not write MapCacheLRU instances to a BagOStuff.

@tstarling Question: in order to test what's in private property WatchedItemStore::stash after resetNotificationTimestamp execution we have to somehow access it and check what's in the bag.
There are several approaches to do it. The question is which one is favorable?

  • Implement the getter - WatchedItemStore::getStash()
  • Use magic method __get and return $this-> stash by unmanifest key (eg. prefixed with underscore, like _stash) so that private visibility is still making sense
  • Utilize Reflection API and change WatchedItemStore::stash visibility only within a test

Or maybe you can suggest a better approach.

Jun 29 2021, 6:58 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Platform Engineering Code Jam-2021, Unstewarded-production-error, Platform Team Workboards (Clinic Duty Team), MediaWiki-Watchlist, Performance-Team (Radar), Growth-Team

May 26 2021

dmitriy.sky moved T282105: WatchedItemStore should not write MapCacheLRU instances to a BagOStuff from Ready (S&F) to Doing (S&F WIP:2) on the Platform Team Workboards (Clinic Duty Team) board.
May 26 2021, 9:33 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Platform Engineering Code Jam-2021, Unstewarded-production-error, Platform Team Workboards (Clinic Duty Team), MediaWiki-Watchlist, Performance-Team (Radar), Growth-Team
dmitriy.sky claimed T282105: WatchedItemStore should not write MapCacheLRU instances to a BagOStuff.
May 26 2021, 9:32 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Platform Engineering Code Jam-2021, Unstewarded-production-error, Platform Team Workboards (Clinic Duty Team), MediaWiki-Watchlist, Performance-Team (Radar), Growth-Team
dmitriy.sky moved T261282: ApiQueryAllUsers with activeusers=1 includes users with 0 recent actions from Doing (S&F WIP:2) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
May 26 2021, 9:00 AM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), Platform Team Workboards (Clinic Duty Team), MediaWiki-Action-API

May 24 2021

dmitriy.sky moved T261282: ApiQueryAllUsers with activeusers=1 includes users with 0 recent actions from Ready (S&F) to Doing (S&F WIP:2) on the Platform Team Workboards (Clinic Duty Team) board.
May 24 2021, 3:19 PM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), Platform Team Workboards (Clinic Duty Team), MediaWiki-Action-API
dmitriy.sky claimed T261282: ApiQueryAllUsers with activeusers=1 includes users with 0 recent actions.
May 24 2021, 3:19 PM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), Platform Team Workboards (Clinic Duty Team), MediaWiki-Action-API