Page MenuHomePhabricator

dusek (Boris Dušek)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 14 2015, 4:02 PM (423 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
BorisDušek [ Global Accounts ]

Recent Activity

Jun 30 2016

dusek committed rAPIOSa64b2ca0e2d3: Mention build requires imagemagick and ghostscript (authored by dusek).
Mention build requires imagemagick and ghostscript
Jun 30 2016, 1:10 AM
dusek committed rAPIOSd2331852cc93: Merge a64b2ca0e2d348528d564b73e7eba8bfdb4fcd9b into… (authored by dusek).
Merge a64b2ca0e2d348528d564b73e7eba8bfdb4fcd9b into…
Jun 30 2016, 1:10 AM

Feb 22 2016

dusek added a comment to T126922: Links interrupt text for VoiceOver users, text is therefore hard to understand in the iOS app.

@hhanke a few notes:

  • this looks awesome
  • have you tried using ARIA and setting (and removing) role=presentation on the <a> elements? If it worked, then that would not require appending a span with the text. It might also help with the noticeable lag experienced when invoking the switching - adding and removing an attribute (role) should be hopefully roughly twice as fast than adding an attribute (style) and appending element to DOM with already present textual content, effectively roughly doubling the size of the HTML (and DOM); not to speak that just adding role would not require complete visual re-layout of the whole web content by WebKit.
  • the bug you are referring to that I discovered and reported in the mailing list (and rdar) was fixed in iOS 9b2. So if it is present again, it is a regression. I just tried with the sample code attached to the rdar and while the magic tap gets reported to accessibiltiyPerformMagicTap on the view controller, it still starts/stops playing my music nevertheless (i.e. magic tap gets propagated to 2 places, does 2 things), as if I were returning false from the method (which I am not). So it would be worthwile to open a new rdar (or reopen the current one at rdar://problem/20940938 ). If you are however seeing the behavior that the magic tap is indeed not reported to the view controller at all in your code, then ... well let's say WebKit really has a spirit (not only) accessibility-wise :-) (My sample code does not load content from the web but from a static HTML string, maybe that is the reason for the difference...)
  • I guess a general solution directly in VoiceOver could be to allow to play an indicator in the form of a supershort sound when a link is encountered, and not say the usual "link" or pause the speech anyhow. VoiceOver already allows that on OS X (and some screen readers on other platforms allow for such possibility too), though perhaps the user experience could still be improved a little more (no/smaller delay due to the sound, no splitting of text on link/non-link boundaries, more "fluent" feeling to the reading). And the sound could be also turned off completely by the user (to approach the uncompromising efficiency of UX you have in the demo).
Feb 22 2016, 7:46 AM · iOS-app-Bugs, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Backlog, Accessibility

Feb 11 2016

dusek updated the task description for T124712: Implement accessibility escape for ShareOptions and ReferencesVC in iOS app.
Feb 11 2016, 8:02 PM · iOS-app-v5.3.2-Lighthouse, iOS-app-feature-Accessibility (October-2016-Sprint), Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype
dusek reopened T124712: Implement accessibility escape for ShareOptions and ReferencesVC in iOS app as "Open".

I am reopening, as neither of the two mentioned instances are fixed: share sheet did get "Cancel" button, but this is not invokable through accessibility escape gesture. ReferencesVC still does not have accessibilityEscape implemented.

Feb 11 2016, 8:01 PM · iOS-app-v5.3.2-Lighthouse, iOS-app-feature-Accessibility (October-2016-Sprint), Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype
dusek reopened T124712: Implement accessibility escape for ShareOptions and ReferencesVC in iOS app, a subtask of T71120: [EPIC] Improve iOS app accessibility for the disabled, as Open.
Feb 11 2016, 8:01 PM · iOS-app-feature-Accessibility, Epic, Wikipedia-iOS-App-Backlog, Tracking-Neverending, Phlogiston-Category, Accessibility

Feb 8 2016

dusek added a comment to T124595: Provide accessibility language attributes in iOS UI.

@BGerstle-WMF this can be closed, the PR was indeed merged.

Feb 8 2016, 9:18 PM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production

Feb 1 2016

dusek added a comment to T124595: Provide accessibility language attributes in iOS UI.

@TheDJ I think @hhanke opened a rdar for this too; since OS X Lion, voices for dozen of languages are preinstalled on OS X (just like on iOS), so there is nothing in the way apart from making a decision to implement it; would love to see this feature on OS X too!

Feb 1 2016, 9:43 PM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production

Jan 25 2016

dusek committed rAPIOS0d27596057b6: Fix T124593: Implement accessibility escape (authored by dusek).
Fix T124593: Implement accessibility escape
Jan 25 2016, 11:25 PM
dusek closed T124593: Implement accessibility escape where appropriate as Resolved by committing rAPIOS0d27596057b6: Fix T124593: Implement accessibility escape.
Jan 25 2016, 11:25 PM · iOS-app-feature-Accessibility, Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek closed T124593: Implement accessibility escape where appropriate, a subtask of T71120: [EPIC] Improve iOS app accessibility for the disabled, as Resolved.
Jan 25 2016, 11:25 PM · iOS-app-feature-Accessibility, Epic, Wikipedia-iOS-App-Backlog, Tracking-Neverending, Phlogiston-Category, Accessibility
dusek added a comment to T124595: Provide accessibility language attributes in iOS UI.

For those interested, here is a short video demonstrating VoiceOver switching languages in the language list for languages it has voices for (to this day, I still find it cool that VoiceOver for iOS can do this :-)

Jan 25 2016, 9:46 PM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek added a comment to T124604: Implement accessibility language attribute for "$1" in "Redirected from: $1" (search screen).

Just realized this does not work as I imagined. E.g. on Czech wikipedia London Underground redirects to Metro v Londýně. The London Underground page on Czech Wikipedia is not in any way connected with the London Underground article on English Wikipedia.

Jan 25 2016, 9:42 PM · iOS-app-v5.3.2-Lighthouse, iOS-app-feature-Accessibility (October-2016-Sprint), Wikipedia-iOS-App-Backlog, Accessibility, NewFunctionality-Worktype
dusek added a comment to T124593: Implement accessibility escape where appropriate.

I think I better handle the ShareOptions and References in a new bug (T124712), because I might not get to it soon, especially given that both these situations seem harder code-wise than the above ones (I tried yesterday).

Jan 25 2016, 9:12 PM · iOS-app-feature-Accessibility, Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek created T124712: Implement accessibility escape for ShareOptions and ReferencesVC in iOS app.
Jan 25 2016, 9:10 PM · iOS-app-v5.3.2-Lighthouse, iOS-app-feature-Accessibility (October-2016-Sprint), Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype
dusek committed rAPIOS54b2d70a6738: T124595: Accessibility language 1/2: lang chooser (authored by dusek).
T124595: Accessibility language 1/2: lang chooser
Jan 25 2016, 8:25 PM
dusek committed rAPIOS24a9470a17d5: T124595: Accessibility language 2/2: search (authored by dusek).
T124595: Accessibility language 2/2: search
Jan 25 2016, 8:25 PM

Jan 24 2016

dusek added a comment to T124595: Provide accessibility language attributes in iOS UI.

PR #411

Jan 24 2016, 2:24 PM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek created T124604: Implement accessibility language attribute for "$1" in "Redirected from: $1" (search screen).
Jan 24 2016, 2:21 PM · iOS-app-v5.3.2-Lighthouse, iOS-app-feature-Accessibility (October-2016-Sprint), Wikipedia-iOS-App-Backlog, Accessibility, NewFunctionality-Worktype
dusek updated the task description for T124595: Provide accessibility language attributes in iOS UI.
Jan 24 2016, 1:56 PM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek updated the task description for T124595: Provide accessibility language attributes in iOS UI.
Jan 24 2016, 11:43 AM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek created T124595: Provide accessibility language attributes in iOS UI.
Jan 24 2016, 11:39 AM · Wikipedia-iOS-App-Backlog, iOS-app-feature-Accessibility, Wikipedia-iOS-App-Development, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek added a comment to T124593: Implement accessibility escape where appropriate.

PR #410

Jan 24 2016, 11:35 AM · iOS-app-feature-Accessibility, Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek closed T124591: Implement accessibility escape where appropriate as Invalid.

Closing in favor of: https://phabricator.wikimedia.org/T124593?workflow=71120 (because that one is a proper subtask of accessibility meta bug).

Jan 24 2016, 10:41 AM · Accessibility, Wikipedia-iOS-App-Backlog
dusek created T124593: Implement accessibility escape where appropriate.
Jan 24 2016, 10:39 AM · iOS-app-feature-Accessibility, Wikipedia-iOS-App-Backlog, Accessibility, Patch-For-Review, NewFunctionality-Worktype, iOS-app-v5-production
dusek created T124591: Implement accessibility escape where appropriate.
Jan 24 2016, 9:38 AM · Accessibility, Wikipedia-iOS-App-Backlog