Page MenuHomePhabricator

eflyjason (He Yifei)
Animal

Projects

Today

  • No visible events.

Tomorrow

  • No visible events.

Monday

  • No visible events.

User Details

User Since
Nov 30 2016, 9:00 AM (466 w, 3 d)
Availability
Available
IRC Nick
hesyifei
LDAP User
Efly
MediaWiki User
Efly [ Global Accounts ]

Languages: zh-N, en-2~3

Recent Activity

Mar 18 2020

eflyjason placed T178998: Table collapsing button is too close to the caption - add some CSS spacing up for grabs.
Mar 18 2020, 4:20 PM · MediaWiki-User-Interface (collapsible elements), Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, CSS, good first task
eflyjason placed T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org up for grabs.
Mar 18 2020, 4:19 PM · Wikidata, Wikidata Query UI

Mar 23 2019

eflyjason updated eflyjason.
Mar 23 2019, 12:08 AM

Jan 14 2018

eflyjason added a comment to T183788: Fix large font size of items in hierarchy filters on Special:Drilldown page on mobile screen.

Another observation. It seems that it's some sort of random bug?

Jan 14 2018, 3:09 PM · Google-Code-in-2017, MediaWiki-extensions-Cargo

Jan 13 2018

eflyjason added a comment to T183788: Fix large font size of items in hierarchy filters on Special:Drilldown page on mobile screen.

I can't recreate the problem:

Screen Shot 2018-01-13 at 12.43.56 PM.png (1×784 px, 141 KB)

Jan 13 2018, 4:44 AM · Google-Code-in-2017, MediaWiki-extensions-Cargo

Jan 12 2018

eflyjason added a comment to T183788: Fix large font size of items in hierarchy filters on Special:Drilldown page on mobile screen.

I thought this is a common problem (or design?) for all Mediawiki page on mobile phones? Viewing desktop version of Wikipedia on a mobile phone also shows bigger article content font size (see image). I'm not sure if this page should be treated separately?

Jan 12 2018, 1:51 PM · Google-Code-in-2017, MediaWiki-extensions-Cargo

Jan 11 2018

eflyjason renamed T184718: Make query.wikidata.org query main part (query helper + query editor) responsive from Make query.wikidata.org query part (upper part) responsive to Make query.wikidata.org query main part (query helper + query editor) responsive.
Jan 11 2018, 3:17 PM · Wikidata Query UI, Patch-For-Review, Discovery-ARCHIVED, Wikidata
eflyjason triaged T184718: Make query.wikidata.org query main part (query helper + query editor) responsive as Low priority.
Jan 11 2018, 1:36 PM · Wikidata Query UI, Patch-For-Review, Discovery-ARCHIVED, Wikidata
eflyjason triaged T184717: Make query.wikidata.org responsive as Medium priority.
Jan 11 2018, 1:33 PM · Wikidata Query UI, Discovery-ARCHIVED, Wikidata
eflyjason added a parent task for T154890: [Story] Mobile/responsive menus : T184717: Make query.wikidata.org responsive.
Jan 11 2018, 1:27 PM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery-ARCHIVED
eflyjason added a subtask for T184717: Make query.wikidata.org responsive: T154890: [Story] Mobile/responsive menus .
Jan 11 2018, 1:27 PM · Wikidata Query UI, Discovery-ARCHIVED, Wikidata
eflyjason created T184717: Make query.wikidata.org responsive.
Jan 11 2018, 1:27 PM · Wikidata Query UI, Discovery-ARCHIVED, Wikidata
eflyjason added a comment to T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org.

On the time when _keyboardShortcut is called, the CodeMirror-hints is already closed and removed, so we cannot use that way to check if a code hint is displayed.

Jan 11 2018, 12:48 PM · Wikidata, Wikidata Query UI
eflyjason triaged T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org as Low priority.
Jan 11 2018, 12:16 PM · Wikidata, Wikidata Query UI

Jan 9 2018

eflyjason added a comment to T180961: Add basic Phabricator support to git-repo.

Is the clone API inside https://secure.phabricator.com/conduit/ or simply git clone?

Jan 9 2018, 2:49 PM · Google-Code-in-2017
eflyjason updated the task description for T179000: Blog about your GCI experience (findings and learnings) with Wikimedia [recurring].
Jan 9 2018, 1:52 PM · Google-Code-in-2017

Jan 8 2018

eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Mentioning at corresponding UI elements sound like a good idea. Currently the "execute query" already have a shortcut hint:

Jan 8 2018, 3:53 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
eflyjason added a comment to T179000: Blog about your GCI experience (findings and learnings) with Wikimedia [recurring].

I wrote one on my blog in Chinese: https://www.arefly.com/google-code-in-2017-wikimedia/ ☺️ (hope Google Translation works well!)

Jan 8 2018, 3:35 PM · Google-Code-in-2017
eflyjason created T184419: Keyboard accessibility for Query.Wikidata.org not working as intended on mobile devices.
Jan 8 2018, 12:10 PM · Patch-For-Review, Wikidata, Wikidata Query UI
eflyjason reassigned T183807: Add highlight and selection feature for query result table for Query.Wikidata.org from eflyjason to Anpans.
Jan 8 2018, 12:05 PM · Patch-For-Review, Google-Code-in-2017, Wikidata, Wikidata Query UI

Jan 7 2018

eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

I changed the "Tools" from a dropdown item to a button. The design will be more consistent and also can work better on small screens.

Jan 7 2018, 10:35 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery-ARCHIVED
eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

The result view's dropdown should be working too.

Jan 7 2018, 5:54 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery-ARCHIVED
eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

(Click to view this GIF)

Jan 7 2018, 5:36 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery-ARCHIVED

Jan 5 2018

eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

So we are trying to make the drop-down menu become something like this drop-down menu right?

Screen Shot 2018-01-05 at 7.16.53 PM.png (1×676 px, 186 KB)

Jan 5 2018, 11:17 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery-ARCHIVED

Jan 4 2018

eflyjason added a comment to T178484: Remove or regenerate PNG files for Translate.

https://gerrit.wikimedia.org/r/#/c/402039/

Jan 4 2018, 1:00 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, good first task, Technical-Debt, MediaWiki-extensions-Translate
eflyjason claimed T184070: Add "This page requires JavaScript" notes to special pages in the Translate extension.
Jan 4 2018, 11:12 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, good first task, Google-Code-in-2017, MediaWiki-extensions-Translate
eflyjason added a comment to T178484: Remove or regenerate PNG files for Translate.

We can remove search.png too after T184070: Add "This page requires JavaScript" notes to special pages in the Translate extension :)

Jan 4 2018, 11:10 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, good first task, Technical-Debt, MediaWiki-extensions-Translate
eflyjason removed a watcher for Chinese-Sites: eflyjason.
Jan 4 2018, 9:37 AM

Jan 3 2018

eflyjason added a comment to T183923: Keyboard accessibility help dialog.

Screen Shot 2018-01-03 at 9.43.47 PM.png (1×1 px, 163 KB)

Jan 3 2018, 1:45 PM · Patch-For-Review, Design, WMDE-Design, Wikidata, Google-Code-in-2017, Wikidata Query UI
eflyjason claimed T183923: Keyboard accessibility help dialog.
Jan 3 2018, 8:02 AM · Patch-For-Review, Design, WMDE-Design, Wikidata, Google-Code-in-2017, Wikidata Query UI
eflyjason added a comment to T178484: Remove or regenerate PNG files for Translate.

We have to remove the .png reference from the .less/.css files right?

Jan 3 2018, 3:12 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, good first task, Technical-Debt, MediaWiki-extensions-Translate

Jan 1 2018

eflyjason added a comment to T183667: download_dump.py: Handle cases when the dump file already exists.

Perhaps we could do something like:

Jan 1 2018, 3:29 AM · Patch-Needs-Improvement, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Dec 31 2017

eflyjason added a comment to T183664: download_dump.py: Add a progress bar.

@Ryan10145 can you try and see if https://stackoverflow.com/a/15645088/2603230 works first? If no, perhaps the pywikibot.comms.http is not behaving the same way as requests and we'll need to look into that.

Dec 31 2017, 4:29 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Dec 30 2017

eflyjason created T183807: Add highlight and selection feature for query result table for Query.Wikidata.org.
Dec 30 2017, 2:52 PM · Patch-For-Review, Google-Code-in-2017, Wikidata, Wikidata Query UI
eflyjason added a comment to T183789: download_dump.py: Support for "date specified" dumps.

I think if the user don't specify the -revision we will assume that the revision is latest and find out the latest date from the site. See T183667#3864150 for details.

Dec 30 2017, 11:23 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot
eflyjason added a comment to T183667: download_dump.py: Handle cases when the dump file already exists.

I assume that with

Dec 30 2017, 11:22 AM · Patch-Needs-Improvement, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Added R to jump to query result and Arrow Up/Arrow Down to select item in query result

Dec 30 2017, 10:52 AM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic

Dec 29 2017

eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Updated. Should be all working now :)

Dec 29 2017, 1:11 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic

Dec 28 2017

eflyjason updated the task description for T183664: download_dump.py: Add a progress bar.
Dec 28 2017, 4:29 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason updated the task description for T183664: download_dump.py: Add a progress bar.
Dec 28 2017, 4:26 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Ctrl/Command+Enter: Run query
Esc: Leave current input field/textarea
Alt+F: Click "Fliter" button in Query Helper
Alt+S: Click "Show" button in Query Helper
Alt+L: Click "Limit" button in Query Helper
Alt+D: Clear query
Alt+R: Restore previous query
?: Toggle Help menu
E: Show examples
F: Focus on "Fliter" button in Query Helper
S: Focus on "Show" button in Query Helper
~: Focus on query textarea
L: Show language menu

Dec 28 2017, 3:53 AM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic

Dec 27 2017

eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

to be a better layout for accessibility? So that the user lands on textarea, then uses tab to go through the Query Helper, and finally goes to Run button.

Dec 27 2017, 3:19 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Just tested. We are currently able to use alt+tab to

Dec 27 2017, 2:54 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
eflyjason claimed T173213: Implement keyboard accessibility for Query.Wikidata.org.
Dec 27 2017, 2:47 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Was already imported as: https://codein.withgoogle.com/dashboard/tasks/4880480144982016/

With the title: "Keyboard accessibility for Query.Wikidata.org" and the request to add keyboard-accessibility to the index.html file. However, @Jonas do you want to mention, which keys should trigger what function? :)

Dec 27 2017, 2:43 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
eflyjason renamed T183707: Add an add_only parameter to replaceCategoryInPlace in textlib from Add a add_only parameter to replaceCategoryInPlace in textlib to Add an add_only parameter to replaceCategoryInPlace in textlib.
Dec 27 2017, 1:51 AM · Patch-For-Review, Pywikibot-textlib, Pywikibot
eflyjason triaged T183707: Add an add_only parameter to replaceCategoryInPlace in textlib as Low priority.
Dec 27 2017, 1:44 AM · Patch-For-Review, Pywikibot-textlib, Pywikibot
eflyjason created T183707: Add an add_only parameter to replaceCategoryInPlace in textlib.
Dec 27 2017, 1:44 AM · Patch-For-Review, Pywikibot-textlib, Pywikibot
eflyjason closed T183666: download_dump.py: Use response.iter_content as Resolved.
Dec 27 2017, 12:47 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason closed T183666: download_dump.py: Use response.iter_content, a subtask of T183663: Improve the maintenance script that download Wikimedia database dump, as Resolved.
Dec 27 2017, 12:47 AM · Pywikibot-Scripts, Pywikibot

Dec 26 2017

eflyjason added a subtask for T183664: download_dump.py: Add a progress bar: T183666: download_dump.py: Use response.iter_content.
Dec 26 2017, 9:16 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a parent task for T183666: download_dump.py: Use response.iter_content: T183664: download_dump.py: Add a progress bar.
Dec 26 2017, 9:16 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason removed a subtask for T183667: download_dump.py: Handle cases when the dump file already exists: T183675: download_dump.py: Make download process atomic.
Dec 26 2017, 9:14 AM · Patch-Needs-Improvement, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason removed a parent task for T183675: download_dump.py: Make download process atomic: T183667: download_dump.py: Handle cases when the dump file already exists.
Dec 26 2017, 9:14 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason removed a parent task for T183664: download_dump.py: Add a progress bar: T183666: download_dump.py: Use response.iter_content.
Dec 26 2017, 9:14 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason removed a subtask for T183666: download_dump.py: Use response.iter_content: T183664: download_dump.py: Add a progress bar.
Dec 26 2017, 9:14 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183670: download_dump.py: Verify the file using the checksum.

Can the maxretries parameters load from config2.py in default? (Though 15 retries in default would be too many...)

Dec 26 2017, 9:06 AM · Pywikibot-Scripts, Pywikibot
eflyjason updated the task description for T183670: download_dump.py: Verify the file using the checksum.
Dec 26 2017, 9:00 AM · Pywikibot-Scripts, Pywikibot
eflyjason added a comment to T183670: download_dump.py: Verify the file using the checksum.

Note that all filenames in the list are in the date format, so latest will ne to be converted.

Dec 26 2017, 8:51 AM · Pywikibot-Scripts, Pywikibot
eflyjason added a parent task for T183675: download_dump.py: Make download process atomic: T183667: download_dump.py: Handle cases when the dump file already exists.
Dec 26 2017, 8:47 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a subtask for T183667: download_dump.py: Handle cases when the dump file already exists: T183675: download_dump.py: Make download process atomic.
Dec 26 2017, 8:47 AM · Patch-Needs-Improvement, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183675: download_dump.py: Make download process atomic.

The two parts can actually combine to:

Dec 26 2017, 8:44 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason claimed T100404: Mobile talk page editor fails if the talk page is a redirect.
Dec 26 2017, 5:20 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Patch-For-Review, Google-Code-in-2017, User-Jdlrobson, Web-Team-Backlog-Archived
eflyjason edited projects for T100404: Mobile talk page editor fails if the talk page is a redirect, added: MobileFrontend; removed MinervaNeue.
Dec 26 2017, 4:11 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Patch-For-Review, Google-Code-in-2017, User-Jdlrobson, Web-Team-Backlog-Archived
eflyjason added a comment to T100404: Mobile talk page editor fails if the talk page is a redirect.

It seems that using [[ https://www.mediawiki.org/wiki/API:Edit | redirect: true ]] in Edit API in MobileFronted's TalkSectionOverlay solve the problem.

Dec 26 2017, 2:45 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Patch-For-Review, Google-Code-in-2017, User-Jdlrobson, Web-Team-Backlog-Archived
eflyjason added a comment to T100404: Mobile talk page editor fails if the talk page is a redirect.

Is the main problem in skins/MinervaNeue/resources/skins.minerva.talk/init.js or other file?

Dec 26 2017, 1:49 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanbanana-Board-Old, MobileFrontend, Patch-For-Review, Google-Code-in-2017, User-Jdlrobson, Web-Team-Backlog-Archived

Dec 25 2017

eflyjason added a watcher for Chinese-Sites: eflyjason.
Dec 25 2017, 11:38 AM
eflyjason added a member for Chinese-Sites: eflyjason.
Dec 25 2017, 11:37 AM
eflyjason added a comment to T156572: Consider dropping "大马简体 (aka 中文(马来西亚)zh-my)"?.

I would suggest first request for comments at https://zh.wikipedia.org/wiki/Wikipedia:互助客棧/其他 in Chinese Wikipedia.

Dec 25 2017, 2:53 AM · Wikidata, MediaWiki-Internationalization, I18n, Chinese-Sites
eflyjason added a comment to T179554: Add phan to MediaWiki extensions and skins for static analysis [cloneable].

Is there any way we could use phan in MediaWiki-Vagrant which still runs PHP 5?

Dec 25 2017, 1:43 AM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MediaWiki-extensions-General, Continuous-Integration-Config, Google-Code-in-2017
eflyjason added a comment to T183016: Create a "Play with Pywikibot" set of tasks for GCI.

I suggest using https://www.mediawiki.org/wiki/Manual:Pywikibot/PAWS for this. Less complicated.

Dec 25 2017, 1:32 AM · Pywikibot-Documentation, Pywikibot-General, Pywikibot, Google-Code-in-2017, Documentation
eflyjason added a comment to T183675: download_dump.py: Make download process atomic.

One implementation is to perform file locking on whichever is being downloaded on, and exit with an error if the will-be-written file is locked. Another is to avoid same-filenames entirely.

Dec 25 2017, 1:28 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183675: download_dump.py: Make download process atomic.

(clarification: by iff I meant if and only if)

Dec 25 2017, 1:23 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason updated the task description for T183675: download_dump.py: Make download process atomic.
Dec 25 2017, 1:22 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason updated the task description for T183675: download_dump.py: Make download process atomic.
Dec 25 2017, 1:19 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason updated the task description for T183666: download_dump.py: Use response.iter_content.
Dec 25 2017, 1:04 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183664: download_dump.py: Add a progress bar.

We have to do task T183666: download_dump.py: Use response.iter_content first as we cannot implement progress bar without using iter_content.

Dec 25 2017, 12:57 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a parent task for T183664: download_dump.py: Add a progress bar: T183666: download_dump.py: Use response.iter_content.
Dec 25 2017, 12:56 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a subtask for T183666: download_dump.py: Use response.iter_content: T183664: download_dump.py: Add a progress bar.
Dec 25 2017, 12:56 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183670: download_dump.py: Verify the file using the checksum.

It seems that file like enwiki-latest-abstract.xml does not have a md5 code in https://dumps.wikimedia.org/enwiki/latest/enwiki-latest-md5sums.txt. How can we check those files?

Dec 25 2017, 12:53 AM · Pywikibot-Scripts, Pywikibot
eflyjason added a comment to T183667: download_dump.py: Handle cases when the dump file already exists.

Would timezone settings on bot user's computer be a problem to this?

Dec 25 2017, 12:47 AM · Patch-Needs-Improvement, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183664: download_dump.py: Add a progress bar.

If we are to use an external library, does that mean we have to add this library to requirements.txt?

Dec 25 2017, 12:46 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
eflyjason added a comment to T183664: download_dump.py: Add a progress bar.

I would suggest something like https://stackoverflow.com/a/15645088/2603230. (See also: https://github.com/wikimedia/pywikibot/blob/master/pywikibot/page.py#L2686-L2693)

Dec 25 2017, 12:39 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Dec 24 2017

eflyjason updated the task description for T130523: Convert imagecopy.py to requests.
Dec 24 2017, 12:00 PM · Patch-For-Review, Google-Code-in-2017, Pywikibot-Scripts, Pywikibot, Pywikibot-network
eflyjason added a comment to T135339: Category add should categorize inside noinclude tags and /doc subpages of templates.

I guess there should be a simpler solution (without having to modify replaceCategoryInPlace in textlib)?

Dec 24 2017, 8:27 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot, Pywikibot-category.py
eflyjason added a comment to T133644: http://wm-bot.wmflabs.org/browser/ should not load assets from external 3rd party domains.

Pull request merged.

Dec 24 2017, 12:36 AM · Google-Code-in-2017, Privacy, Cloud-Services, WM-Bot

Dec 22 2017

eflyjason added a comment to T133644: http://wm-bot.wmflabs.org/browser/ should not load assets from external 3rd party domains.

Pull request here: https://github.com/benapetr/wikimedia-bot/pull/71

Dec 22 2017, 11:59 AM · Google-Code-in-2017, Privacy, Cloud-Services, WM-Bot
eflyjason added a comment to T89561: Implement a CSS preprocessor for direction flipping based on the content direction.

I guess we might have to wait till margin-start got supported by major browsers to solve it?

Dec 22 2017, 2:25 AM · MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader
Restricted Application added a project to T89561: Implement a CSS preprocessor for direction flipping based on the content direction: Performance-Team.
Dec 22 2017, 2:00 AM · MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader

Dec 21 2017

eflyjason updated subscribers of T130523: Convert imagecopy.py to requests.

Just curious, @Xqt suggests here in another patch that [[ https://doc.wikimedia.org/pywikibot/_modules/pywikibot/comms/http.html | pywikibot.comms.http ]] could be used instead of requests. Would pywikibot.comms.http be better here too?

Dec 21 2017, 11:16 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-Scripts, Pywikibot, Pywikibot-network
eflyjason added a comment to T182074: Ignore whitespaces between wiki table syntax and table content.

By the way, currently Wikipedia already has the expected output because of Tidy (https://www.w3.org/People/Raggett/tidy/). But I think this patch is still needed for general Mediawiki sites.

Dec 21 2017, 11:09 AM · MediaWiki-Parser
eflyjason added a project to T183387: Cite tags should not appear in the article table of contents: MediaWiki-User-Interface.
Dec 21 2017, 10:18 AM · MediaWiki-Parser, MediaWiki-User-Interface
eflyjason added a comment to T183387: Cite tags should not appear in the article table of contents.

Note that according to https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style#Section_headings

Dec 21 2017, 10:16 AM · MediaWiki-Parser, MediaWiki-User-Interface
eflyjason added a comment to T151541: replaceCategoryLinks should not fail on de-wiki when page contains {{Personendaten}}.

Second is it really necessary to use these affected textlib methods for template removements which breaks the script? A single C:\pwb\GIT\core>pwb.py replace -regex "\[\[Kategorie\:Antifaschist\]\]\r?\n" ""-cat:Antifaschist does the job too. This means category.py should be able always to do the job. In my sample the cosmetic_changes didn't care for replace.py. This is a bit curious.

Dec 21 2017, 4:08 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-textlib, Pywikibot-category.py, Pywikibot
eflyjason added a comment to T151541: replaceCategoryLinks should not fail on de-wiki when page contains {{Personendaten}}.

According to the error message

Dec 21 2017, 3:51 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-textlib, Pywikibot-category.py, Pywikibot

Dec 19 2017

eflyjason closed T182854: Add protocol in Page.permalink() as Resolved.
Dec 19 2017, 3:42 PM · Pywikibot-compat-to-core, Regression, Patch-For-Review, Google-Code-in-2017, Pywikibot
eflyjason closed T182854: Add protocol in Page.permalink(), a subtask of T151110: RFC: Regressions of core should be rethought or solved, as Resolved.
Dec 19 2017, 3:42 PM · Pywikibot-compat-to-core, Pywikibot, Pywikibot-RfCs

Dec 18 2017

eflyjason added a comment to T123885: Create a Python Pywikibot script to download Wikimedia database dump.

Is this script something like https://github.com/WikiTeam/wikiteam/blob/master/wikipediadownloader.py?

Dec 18 2017, 9:15 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot, Pywikibot-Scripts

Dec 17 2017

eflyjason created T183093: imagecopy.py: super in Constructor of TkdialogIC might be wrong.
Dec 17 2017, 3:06 PM · Pywikibot, Pywikibot-Scripts
eflyjason closed T164164: pywikibot.userinterfaces.gui is broken in Python 3.6 as Resolved.
Dec 17 2017, 2:42 PM · Pywikibot