Page MenuHomePhabricator

eflyjason (He Yifei)
Animal

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 30 2016, 9:00 AM (128 w, 6 d)
Availability
Available
IRC Nick
hesyifei
LDAP User
Efly
MediaWiki User
Efly [ Global Accounts ]

Languages: zh-N, en-2~3

Recent Activity

Mar 23 2019

eflyjason updated eflyjason.
Mar 23 2019, 12:08 AM

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG43d5addbd0bf: Final NoteDb migration updates (authored by eflyjason).
Final NoteDb migration updates
Jun 11 2018, 3:54 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG2f5b280b3b19: Create patch set 5 (authored by eflyjason).
Create patch set 5
Jun 11 2018, 3:54 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGf01dbdaa5c2c: Create patch set 4 (authored by eflyjason).
Create patch set 4
Jun 11 2018, 3:54 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGaf4a6888ecec: Create patch set 3 (authored by eflyjason).
Create patch set 3
Jun 11 2018, 3:54 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGf47f5538b02b: Create patch set 2 (authored by eflyjason).
Create patch set 2
Jun 11 2018, 3:54 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG266292a69a73: Create change (authored by eflyjason).
Create change
Jun 11 2018, 3:54 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGe171309ba5d0: Final NoteDb migration updates (authored by eflyjason).
Final NoteDb migration updates
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGf6a4b7ded3e6: Update patch set 16 (authored by eflyjason).
Update patch set 16
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGfdc9d3f85f03: Create patch set 16 (authored by eflyjason).
Create patch set 16
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG21e540607856: Create patch set 15 (authored by eflyjason).
Create patch set 15
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG1fbe7ae2aa60: Create patch set 14 (authored by eflyjason).
Create patch set 14
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG2bab8e6e09b8: Create patch set 13 (authored by eflyjason).
Create patch set 13
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGb7866f62c3da: Create patch set 12 (authored by eflyjason).
Create patch set 12
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGa58abe88e2f9: Create patch set 11 (authored by eflyjason).
Create patch set 11
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGcbaad42dcd8d: Create patch set 10 (authored by eflyjason).
Create patch set 10
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG1e8afea2d5a7: Create patch set 9 (authored by eflyjason).
Create patch set 9
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGd3a9b7e99e93: Create patch set 8 (authored by eflyjason).
Create patch set 8
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG0bf8750c316d: Create patch set 7 (authored by eflyjason).
Create patch set 7
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGed19bf01f489: Update patch set 6 (authored by eflyjason).
Update patch set 6
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG063a50e33006: Create patch set 6 (authored by eflyjason).
Create patch set 6
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG32e477371124: Create patch set 5 (authored by eflyjason).
Create patch set 5
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG02c607726700: Create patch set 4 (authored by eflyjason).
Create patch set 4
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG29bcee3c7ad6: Create patch set 3 (authored by eflyjason).
Create patch set 3
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG9676488e2ce2: Create patch set 2 (authored by eflyjason).
Create patch set 2
Jun 11 2018, 3:53 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG6a37e732e2d0: Create change (authored by eflyjason).
Create change
Jun 11 2018, 3:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG3e0e6e7b4339: Final NoteDb migration updates (authored by eflyjason).
Final NoteDb migration updates
Jun 11 2018, 3:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG9a4abe3c89c0: Create change (authored by eflyjason).
Create change
Jun 11 2018, 3:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGdaae44a6692c: Final NoteDb migration updates (authored by eflyjason).
Final NoteDb migration updates
Jun 11 2018, 3:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG01a09dc0572e: Create patch set 11 (authored by eflyjason).
Create patch set 11
Jun 11 2018, 3:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG47fbe769e735: Create patch set 10 (authored by eflyjason).
Create patch set 10
Jun 11 2018, 3:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGf268c8cf3061: Create patch set 9 (authored by eflyjason).
Create patch set 9
Jun 11 2018, 3:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG8999850b0d66: Create patch set 8 (authored by eflyjason).
Create patch set 8
Jun 11 2018, 3:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG3a9dd7be0cda: Update patch set 7 (authored by eflyjason).
Update patch set 7
Jun 11 2018, 3:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG4a63dd9d4ab6: Create patch set 7 (authored by eflyjason).
Create patch set 7
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG9c81307e6de5: Create patch set 6 (authored by eflyjason).
Create patch set 6
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG4c1963c7f0bb: Create patch set 5 (authored by eflyjason).
Create patch set 5
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG8d9b0be1e698: Update patch set 4 (authored by eflyjason).
Update patch set 4
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG04371fb59159: Create patch set 4 (authored by eflyjason).
Create patch set 4
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG6c867747e7a8: Update patch set 3 (authored by eflyjason).
Update patch set 3
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGbcfb1981f2be: Update patch set 3 (authored by eflyjason).
Update patch set 3
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG871ae93a5648: Create patch set 3 (authored by eflyjason).
Create patch set 3
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG9eefea621344: Create patch set 2 (authored by eflyjason).
Create patch set 2
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGcb2c1f9b5a09: Create change (authored by eflyjason).
Create change
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGf53f5f80d69b: Final NoteDb migration updates (authored by eflyjason).
Final NoteDb migration updates
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGe87868fccfc9: Create patch set 2 (authored by eflyjason).
Create patch set 2
Jun 11 2018, 3:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGe11738a36ea8: Create change (authored by eflyjason).
Create change
Jun 11 2018, 3:50 AM

Jun 9 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEPFM11a4c0865704: Final NoteDb migration updates (authored by eflyjason).
Final NoteDb migration updates
Jun 9 2018, 7:01 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEPFMed3d0470fd74: Update patch set 1 (authored by eflyjason).
Update patch set 1
Jun 9 2018, 7:01 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEPFMb37c9e61be6f: Create change (authored by eflyjason).
Create change
Jun 9 2018, 7:01 PM

Jan 14 2018

eflyjason added a comment to T183788: Fix large font size of items in hierarchy filters on Special:Drilldown page on mobile screen.

Another observation. It seems that it's some sort of random bug?

Jan 14 2018, 3:09 PM · Google-Code-in-2017, MediaWiki-extensions-Cargo

Jan 13 2018

eflyjason added a comment to T183788: Fix large font size of items in hierarchy filters on Special:Drilldown page on mobile screen.

I can't recreate the problem:

Jan 13 2018, 4:44 AM · Google-Code-in-2017, MediaWiki-extensions-Cargo

Jan 12 2018

eflyjason added a comment to T183788: Fix large font size of items in hierarchy filters on Special:Drilldown page on mobile screen.

I thought this is a common problem (or design?) for all Mediawiki page on mobile phones? Viewing desktop version of Wikipedia on a mobile phone also shows bigger article content font size (see image). I'm not sure if this page should be treated separately?

Jan 12 2018, 1:51 PM · Google-Code-in-2017, MediaWiki-extensions-Cargo
eflyjason committed rWDQG65a876c3eb72: Make query.wikidata.org query part (upper part) responsive (authored by eflyjason).
Make query.wikidata.org query part (upper part) responsive
Jan 12 2018, 1:13 PM

Jan 11 2018

eflyjason renamed T184718: Make query.wikidata.org query main part (query helper + query editor) responsive from Make query.wikidata.org query part (upper part) responsive to Make query.wikidata.org query main part (query helper + query editor) responsive.
Jan 11 2018, 3:17 PM · Wikidata Query UI, Patch-For-Review, Discovery, Wikidata
eflyjason committed rWDQGebe204b81403: Make query.wikidata.org query part (upper part) responsive (authored by eflyjason).
Make query.wikidata.org query part (upper part) responsive
Jan 11 2018, 1:38 PM
eflyjason triaged T184718: Make query.wikidata.org query main part (query helper + query editor) responsive as Low priority.
Jan 11 2018, 1:36 PM · Wikidata Query UI, Patch-For-Review, Discovery, Wikidata
eflyjason triaged T184717: Make query.wikidata.org responsive as Normal priority.
Jan 11 2018, 1:33 PM · Wikidata Query UI, Discovery, Wikidata
eflyjason added a parent task for T154890: [Story] Mobile/responsive menus : T184717: Make query.wikidata.org responsive.
Jan 11 2018, 1:27 PM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery
eflyjason added a subtask for T184717: Make query.wikidata.org responsive: T154890: [Story] Mobile/responsive menus .
Jan 11 2018, 1:27 PM · Wikidata Query UI, Discovery, Wikidata
eflyjason created T184717: Make query.wikidata.org responsive.
Jan 11 2018, 1:27 PM · Wikidata Query UI, Discovery, Wikidata
eflyjason added a comment to T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org.

On the time when _keyboardShortcut is called, the CodeMirror-hints is already closed and removed, so we cannot use that way to check if a code hint is displayed.

Jan 11 2018, 12:48 PM · Wikidata, Wikidata Query UI
eflyjason triaged T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org as Low priority.
Jan 11 2018, 12:16 PM · Wikidata, Wikidata Query UI

Jan 10 2018

eflyjason committed rWDQG483ae426fa9c: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 10 2018, 4:22 PM
eflyjason committed rWDQGc0b59e71cad4: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 10 2018, 4:13 PM
eflyjason committed rWDQGd8c84457e0ff: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 10 2018, 3:08 PM
eflyjason committed rWDQG898c106f6cb1: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 10 2018, 3:30 AM

Jan 9 2018

eflyjason committed rWDQG2d3b07240d7f: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 9 2018, 4:00 PM
eflyjason committed rWDQG0a1d854fa97e: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 9 2018, 3:58 PM
eflyjason committed rEPFM89009b47446b: Make "Category name" field on Special:CreateClass page as optional (authored by eflyjason).
Make "Category name" field on Special:CreateClass page as optional
Jan 9 2018, 3:05 PM
eflyjason added a comment to T180961: Add basic Phabricator support to git-repo.

Is the clone API inside https://secure.phabricator.com/conduit/ or simply git clone?

Jan 9 2018, 2:49 PM · Google-Code-in-2017
eflyjason updated the task description for T179000: Blog about your GCI experience (findings and learnings) with Wikimedia [recurring].
Jan 9 2018, 1:52 PM · Google-Code-in-2017
eflyjason committed rWDQGa0e7b71e89e2: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 9 2018, 1:12 PM

Jan 8 2018

eflyjason added a comment to T173213: Implement keyboard accessibility for Query.Wikidata.org.

Mentioning at corresponding UI elements sound like a good idea. Currently the "execute query" already have a shortcut hint:

Jan 8 2018, 3:53 PM · Design, Patch-For-Review, Wikidata, Google-Code-in-2017, Wikidata Query UI, Epic
eflyjason added a comment to T179000: Blog about your GCI experience (findings and learnings) with Wikimedia [recurring].

I wrote one on my blog in Chinese: https://www.arefly.com/google-code-in-2017-wikimedia/ ☺️ (hope Google Translation works well!)

Jan 8 2018, 3:35 PM · Google-Code-in-2017
eflyjason committed rWDQGf8f66adfeae9: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 8 2018, 1:00 PM
eflyjason committed rWDQGe67effb917dd: Fix document.activeElement when focusing on textarea on mobile devices (authored by eflyjason).
Fix document.activeElement when focusing on textarea on mobile devices
Jan 8 2018, 12:31 PM
eflyjason created T184419: Keyboard accessibility for Query.Wikidata.org not working as intended on mobile devices.
Jan 8 2018, 12:10 PM · Patch-For-Review, Wikidata, Wikidata Query UI
eflyjason reassigned T183807: Add highlight and selection feature for query result table for Query.Wikidata.org from eflyjason to Anpans.
Jan 8 2018, 12:05 PM · Patch-For-Review, Google-Code-in-2017, Wikidata, Wikidata Query UI

Jan 7 2018

eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

I changed the "Tools" from a dropdown item to a button. The design will be more consistent and also can work better on small screens.

Jan 7 2018, 10:35 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery
eflyjason committed rWDQG56727010bc51: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 7 2018, 10:31 AM
eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

The result view's dropdown should be working too.

Jan 7 2018, 5:54 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery
eflyjason committed rWDQGe76b0ff563ad: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 7 2018, 5:49 AM
eflyjason committed rWDQG95083f64ff8d: Mobile/responsive menus (authored by eflyjason).
Mobile/responsive menus
Jan 7 2018, 5:47 AM
eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

(Click to view this GIF)

Jan 7 2018, 5:36 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery

Jan 5 2018

eflyjason added a comment to T154890: [Story] Mobile/responsive menus .

So we are trying to make the drop-down menu become something like this drop-down menu right?

Jan 5 2018, 11:17 AM · Wikidata Query UI, Google-Code-in-2017, Wikimedia-Hackathon-2017, Google-Code-In-2016, Wikidata, Discovery

Jan 4 2018

eflyjason committed rWDQG13449321a579: Keyboard accessibility help dialog (authored by eflyjason).
Keyboard accessibility help dialog
Jan 4 2018, 3:33 PM
eflyjason committed rWDQG629751a89e59: Keyboard accessibility help dialog (authored by eflyjason).
Keyboard accessibility help dialog
Jan 4 2018, 3:12 PM
eflyjason added a comment to T178484: Remove or regenerate PNG files for Translate.

https://gerrit.wikimedia.org/r/#/c/402039/

Jan 4 2018, 1:00 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, good first bug, Technical-Debt, MediaWiki-extensions-Translate
eflyjason claimed T184070: Add "This page requires JavaScript" notes to special pages in the Translate extension.
Jan 4 2018, 11:12 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, good first bug, Google-Code-in-2017, MediaWiki-extensions-Translate
eflyjason added a comment to T178484: Remove or regenerate PNG files for Translate.

We can remove search.png too after T184070: Add "This page requires JavaScript" notes to special pages in the Translate extension :)

Jan 4 2018, 11:10 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, good first bug, Technical-Debt, MediaWiki-extensions-Translate
eflyjason committed rWDQG1565ef0d5298: Keyboard accessibility help dialog (authored by eflyjason).
Keyboard accessibility help dialog
Jan 4 2018, 10:58 AM
eflyjason removed a watcher for Chinese-Sites: eflyjason.
Jan 4 2018, 9:37 AM

Jan 3 2018

eflyjason committed rWDQG24da6d551ab3: Keyboard accessibility help dialog (authored by eflyjason).
Keyboard accessibility help dialog
Jan 3 2018, 1:47 PM
eflyjason added a comment to T183923: Keyboard accessibility help dialog.

Jan 3 2018, 1:45 PM · Patch-For-Review, Design, WMDE-Design, Wikidata, Google-Code-in-2017, Wikidata Query UI
eflyjason committed rWDQG3dcfd9b0f4bf: Keyboard accessibility help dialog (authored by eflyjason).
Keyboard accessibility help dialog
Jan 3 2018, 1:44 PM
eflyjason claimed T183923: Keyboard accessibility help dialog.
Jan 3 2018, 8:02 AM · Patch-For-Review, Design, WMDE-Design, Wikidata, Google-Code-in-2017, Wikidata Query UI
eflyjason added a comment to T178484: Remove or regenerate PNG files for Translate.

We have to remove the .png reference from the .less/.css files right?

Jan 3 2018, 3:12 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, good first bug, Technical-Debt, MediaWiki-extensions-Translate

Jan 1 2018

eflyjason added a comment to T183667: download_dump.py: Handle cases when the dump file already exists.

Perhaps we could do something like:

Jan 1 2018, 3:29 AM · Patch-For-Review, Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Dec 31 2017

eflyjason committed rWDQG3926e3efb6ba: Implement basic keyboard accessibility for Query.Wikidata.org (authored by eflyjason).
Implement basic keyboard accessibility for Query.Wikidata.org
Dec 31 2017, 8:02 AM