Page MenuHomePhabricator

egardner (Eric Gardner)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (125 w, 2 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Thu, Jun 17

egardner added a comment to T272879: Migrate WVUI library to Rollup or Vite.
Thu, Jun 17, 8:31 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board

Mon, Jun 14

egardner added a comment to T283819: MediaSearch results are not a list.

Note that links cannot be list items at the same time though (an element can only have one role)

Mon, Jun 14, 5:19 PM · Structured-Data-Backlog (Current Work), Accessibility, SDAW-MediaSearch

Fri, Jun 11

egardner added a comment to T284782: Improve the way WVUI ships type definitions.

Point 2: the ExtendedVue thing doesn't look pretty and isn't helpful in the view that you showed, but it does enable TypeScript to know which props and methods exist and what their types/signatures are. This is helpful because if you do need to call a method on a component (not super common, but it happens), TypeScript will type check your method call. So I would advocate for keeping that.

To illustrate what that looks like in practice: if I have <wvui-options-menu ref="menu" /> in my template, then in JS I can do ( this.$refs.menu as InstanceOf<typeof WvuiOptionsMenu> ).handleKeyboardEvent( event ), and the IDE will show me the method documentation for that method, and TypeScript will type check the parameters and return value. You don't get this if everything is just a generic VueConstructor.

Fri, Jun 11, 4:37 PM · WVUI
egardner added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

@mwilliams Adding the assessment filter to all tabs should be simple. There may be more searches that come back without results in these tabs but I don't see that as a problem.

Fri, Jun 11, 4:09 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Thu, Jun 10

egardner updated the task description for T284782: Improve the way WVUI ships type definitions.
Thu, Jun 10, 9:15 PM · WVUI
egardner updated the task description for T284782: Improve the way WVUI ships type definitions.
Thu, Jun 10, 9:00 PM · WVUI
egardner updated the task description for T284782: Improve the way WVUI ships type definitions.
Thu, Jun 10, 8:59 PM · WVUI
egardner updated the task description for T284782: Improve the way WVUI ships type definitions.
Thu, Jun 10, 8:49 PM · WVUI
egardner added a comment to T282835: Evaluate use of TypeScript in WVUI.

I've created a dedicated task for some of the typing improvements I mentioned above here: T284782

Thu, Jun 10, 8:47 PM · Design-Systems-team-board, WVUI
egardner created T284782: Improve the way WVUI ships type definitions.
Thu, Jun 10, 8:46 PM · WVUI
egardner added a comment to T284768: Error: write cursor too small.

Based on the stack trace, this looks to be related to the new OGV.js shim we started using; it's something related to TimedMediaHandler or VideoJS most likely.

Thu, Jun 10, 5:31 PM · Structured-Data-Backlog (Current Work), VideoJS player, Wikimedia-production-error

Wed, Jun 9

egardner added a comment to T284681: Evaluate and implement different WVUI bundles.

Is this task still necessary if we can adopt a front-end build step that supports tree-shaking? In that case, consuming applications would just run the build step to ensure that only relevant components get included in their respective payloads.

Wed, Jun 9, 10:31 PM · WVUI
egardner created T284707: Treat @vue/composition-api as a peer dependency.
Wed, Jun 9, 10:02 PM · WVUI
egardner updated the task description for T284673: Determine best practices for communicating between VE and other UI components.
Wed, Jun 9, 4:02 PM · Editing-team, Design-Systems-team-board
egardner created T284673: Determine best practices for communicating between VE and other UI components.
Wed, Jun 9, 4:02 PM · Editing-team, Design-Systems-team-board
egardner added a comment to T284511: Support the "exports" shortcut in addition to "module.exports" in packageFiles.

@Krinkle both work-arounds you mention (using a wrapper file and limiting the change to packageFiles) sound workable to me. My motivation here is to ensure that any bundled modules we generate with newer build tools (Rollup/Vite/etc) are usable in ResourceLoader without too much additional effort. Existing 3rd-party libraries can continue to be handled the way they are now.

Wed, Jun 9, 12:37 AM · Performance-Team (Radar), MediaWiki-ResourceLoader, Design-Systems-team-board (Vue.js Migration Team Radar)

Tue, Jun 8

egardner added a comment to T282835: Evaluate use of TypeScript in WVUI.

It seems clear that we want to use Typescript as we move forward with a shared component library. But there is still the question of the best way to use Typescript.

Tue, Jun 8, 11:12 PM · Design-Systems-team-board, WVUI
Krinkle awarded T284511: Support the "exports" shortcut in addition to "module.exports" in packageFiles a Orange Medal token.
Tue, Jun 8, 4:24 AM · Performance-Team (Radar), MediaWiki-ResourceLoader, Design-Systems-team-board (Vue.js Migration Team Radar)

Mon, Jun 7

egardner updated the task description for T284511: Support the "exports" shortcut in addition to "module.exports" in packageFiles.
Mon, Jun 7, 9:58 PM · Performance-Team (Radar), MediaWiki-ResourceLoader, Design-Systems-team-board (Vue.js Migration Team Radar)
egardner updated the task description for T284511: Support the "exports" shortcut in addition to "module.exports" in packageFiles.
Mon, Jun 7, 9:56 PM · Performance-Team (Radar), MediaWiki-ResourceLoader, Design-Systems-team-board (Vue.js Migration Team Radar)
egardner created T284511: Support the "exports" shortcut in addition to "module.exports" in packageFiles.
Mon, Jun 7, 9:53 PM · Performance-Team (Radar), MediaWiki-ResourceLoader, Design-Systems-team-board (Vue.js Migration Team Radar)
egardner updated the task description for T284480: Create and document a migration planning process.
Mon, Jun 7, 6:36 PM · Design-Systems-team-board
egardner updated the task description for T284480: Create and document a migration planning process.
Mon, Jun 7, 5:38 PM · Design-Systems-team-board
egardner added a comment to T284480: Create and document a migration planning process.

A couple of thoughts on what this could contain:

Mon, Jun 7, 5:33 PM · Design-Systems-team-board

Fri, Jun 4

egardner moved T284253: Upgrade WVUI node.js version from To Do to Blocked on the Design-Systems-team-board board.
Fri, Jun 4, 7:03 PM · WVUI, Design-Systems-team-board
egardner added a comment to T272879: Migrate WVUI library to Rollup or Vite.

Sounds good to me. But it might be nice to have the option of running a local Storybook, because some of the stories do exist for testing purposes, and I don't think we want to duplicate them all in demo pages. The basic story for every component also provides controls for tweaking all the props, which can be handy for testing while developing.

Fri, Jun 4, 6:40 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board
egardner updated the task description for T284341: Security Readiness Review For Vite.
Fri, Jun 4, 6:35 PM · Design-Systems-team-board (Vue.js Migration Team Radar), Security, Security Readiness Reviews, secscrum
egardner added a project to T267891: Create Debian packages for Node.js 14 upgrade: Design-Systems-team-board (Vue.js Migration Team Radar).
Fri, Jun 4, 6:35 PM · Design-Systems-team-board (Vue.js Migration Team Radar), Packaging, serviceops, SRE
egardner updated the task description for T284341: Security Readiness Review For Vite.
Fri, Jun 4, 6:34 PM · Design-Systems-team-board (Vue.js Migration Team Radar), Security, Security Readiness Reviews, secscrum
egardner added a project to T284341: Security Readiness Review For Vite: Design-Systems-team-board (Vue.js Migration Team Radar).
Fri, Jun 4, 6:33 PM · Design-Systems-team-board (Vue.js Migration Team Radar), Security, Security Readiness Reviews, secscrum
egardner created T284341: Security Readiness Review For Vite.
Fri, Jun 4, 6:32 PM · Design-Systems-team-board (Vue.js Migration Team Radar), Security, Security Readiness Reviews, secscrum
egardner added a project to T284338: Security Readiness Review For Rollup.js: Design-Systems-team-board (Vue.js Migration Team Radar).
Fri, Jun 4, 6:23 PM · Design-Systems-team-board (Vue.js Migration Team Radar), secscrum, Security, Security Readiness Reviews
egardner created T284338: Security Readiness Review For Rollup.js.
Fri, Jun 4, 6:23 PM · Design-Systems-team-board (Vue.js Migration Team Radar), secscrum, Security, Security Readiness Reviews
egardner updated subscribers of T272879: Migrate WVUI library to Rollup or Vite.

One thing I did wonder, if we are concerned about using storybook for code that doesn't run on our production wikis, but haven't explored, is whether it would make sense to have a single storybook repo for all our extensions, skins inside core or a separate extension.

Fri, Jun 4, 5:58 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board

Thu, Jun 3

egardner moved T272879: Migrate WVUI library to Rollup or Vite from Doing to Blocked on the Design-Systems-team-board board.
Thu, Jun 3, 8:28 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board
egardner created T284253: Upgrade WVUI node.js version.
Thu, Jun 3, 8:27 PM · WVUI, Design-Systems-team-board

Wed, Jun 2

xSavitar awarded T272104: Allow modules to opt-in to ES6 syntax support a Like token.
Wed, Jun 2, 10:33 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Design-Systems-team-board, Performance-Team, MediaWiki-ResourceLoader
egardner committed rEMED7db97af711c2: Adjust filter horizontal layout to accommodate new dropdown (authored by egardner).
Adjust filter horizontal layout to accommodate new dropdown
Wed, Jun 2, 7:03 PM

Tue, Jun 1

egardner added a comment to T284105: Clarify "breaking changes" policy for WVUI.

For OOUI, we deemed breaking changes to be those that changed the programmatic API or changed environmental requirements (//e.g. dropping Node 6 compatibility). Changes to the output CSS/DOM weren't considered part of our contract, so they didn't count as breaking changes.

Each breaking change release was announced in an e-mail to wikitech-l, and planned deprecations where possible were made and announced in the previous breaking change. For example, if we were replacing the method doX(), in version 0.X.Y we'd tag it as deprecated and document the replacement if appropriate. This would be noted in the release e-mail for 0.X+1.0. It would be removed in 0.X+2.0.

This might be a bit heavy-weight whilst you're still in active early development, however.

Tue, Jun 1, 7:28 PM · WVUI, Design-Systems-team-board
egardner added a project to T284105: Clarify "breaking changes" policy for WVUI: WVUI.
Tue, Jun 1, 7:02 PM · WVUI, Design-Systems-team-board
egardner created T284105: Clarify "breaking changes" policy for WVUI.
Tue, Jun 1, 7:02 PM · WVUI, Design-Systems-team-board

Thu, May 27

egardner removed a project from T283870: Quickview Error: Unsupported time zone specified UTC: Wikimedia-production-error.
Thu, May 27, 8:11 PM · Structured-Data-Backlog (Current Work)
egardner removed a project from T283864: TypeError: searchOptions[this.currentTab] is not an Object. (evaluating 'key in searchOptions[this.currentTab]'): Wikimedia-production-error.
Thu, May 27, 8:11 PM · Structured-Data-Backlog (Current Work)
egardner created T283870: Quickview Error: Unsupported time zone specified UTC.
Thu, May 27, 8:10 PM · Structured-Data-Backlog (Current Work)
egardner created T283864: TypeError: searchOptions[this.currentTab] is not an Object. (evaluating 'key in searchOptions[this.currentTab]').
Thu, May 27, 7:30 PM · Structured-Data-Backlog (Current Work)
egardner edited projects for T283843: filterValues is not an Object. (evaluating 'filter in filterValues'), added: Structured-Data-Backlog (Current Work); removed Wikimedia-production-error.
Thu, May 27, 5:34 PM · Structured-Data-Backlog (Current Work)
egardner created T283843: filterValues is not an Object. (evaluating 'filter in filterValues').
Thu, May 27, 5:33 PM · Structured-Data-Backlog (Current Work)

Wed, May 26

egardner moved T272879: Migrate WVUI library to Rollup or Vite from Backlog to Doing on the WVUI board.
Wed, May 26, 9:31 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board
egardner added a project to T272879: Migrate WVUI library to Rollup or Vite: WVUI.
Wed, May 26, 9:31 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board
egardner added a comment to T272879: Migrate WVUI library to Rollup or Vite.

Quick update on this: I've opened a patch that ports WVUI over to Rollup for builds. So far here's what's working:

Wed, May 26, 9:24 PM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board
egardner claimed T272879: Migrate WVUI library to Rollup or Vite.
Wed, May 26, 1:24 AM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board
egardner moved T272879: Migrate WVUI library to Rollup or Vite from Vue.js Migration to Doing on the Design-Systems-team-board board.
Wed, May 26, 1:24 AM · WVUI, Patch-For-Review, Performance-Team (Radar), Design-Systems-team-board

Tue, May 25

egardner created T283630: Deployment training request for egardner.
Tue, May 25, 8:36 PM · Release-Engineering-Team (Deployment Training Requests)
egardner added a comment to T283541: Requesting access to production deployment for Eric Gardner.

@thcipriani that's correct – I just need access to do the occasional backport and config deploy, I wasn't sure what the exact name for that group was supposed to be. Thanks!

Tue, May 25, 4:04 PM · SRE, SRE-Access-Requests

Mon, May 24

egardner updated the task description for T283541: Requesting access to production deployment for Eric Gardner.
Mon, May 24, 9:23 PM · SRE, SRE-Access-Requests
egardner added a comment to T282061: Deployment credentials for @egardner.

Thanks, @thcipriani! I just opened a request ticket here to request shell access: T283541. Let me know if you need anything else!

Mon, May 24, 9:20 PM · Release-Engineering-Team (Deployment Training Requests)
egardner created T283541: Requesting access to production deployment for Eric Gardner.
Mon, May 24, 9:18 PM · SRE, SRE-Access-Requests
egardner closed T252469: [Spike] Compare MachineVision performance metrics before and after Vue.js port as Declined.

It's going to be some time before we are able to re-write the front-end of this extension to remove all OOUI dependencies; this may happen if we port it over to a new WMF component library at some point. Closing for now.

Mon, May 24, 7:54 PM · Performance-Team (Radar), Vue.js, Structured-Data-Backlog (Current Work)
egardner added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

@Etonkovidova – that is the correct param, but the patch was updated to include some config variables that likely need to be set on Beta and Production commons before this feature will work. I'll see about making sure this happens some time soon.

Mon, May 24, 5:39 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

May 14 2021

egardner closed T280891: Remove local Array polyfills in favor of those provided by core, a subtask of T264135: Add polyfill for ES6 array methods to improve experience in Internet Explorer, as Resolved.
May 14 2021, 9:06 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Performance-Team (Radar), MediaWiki-ResourceLoader, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Browser-Support-Internet-Explorer, Structured Data Engineering
egardner closed T280891: Remove local Array polyfills in favor of those provided by core as Resolved.
May 14 2021, 9:06 PM · Structured-Data-Backlog (Current Work), Browser-Support-Internet-Explorer
egardner moved T279565: [M] Add assessment information to Quickview from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
May 14 2021, 9:06 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
egardner moved T276257: [M] Create "assessment" filter in MediaSearch from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
May 14 2021, 9:06 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch
egardner committed rEMEDf624ce8f1868: Assessment filter and assessment in QuickView (authored by Seddon).
Assessment filter and assessment in QuickView
May 14 2021, 9:06 PM

May 10 2021

egardner added a comment to T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview).

Updated some docs on https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/VideoJS_Player#Usage so that others can more easily integrate Video.js and Ogv.js the same way.

May 10 2021, 11:18 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari
egardner updated subscribers of T266831: IE 11 - video player does not work on MediaSearch page.

Bumping this task to the main team board. @brion do you know anything about IE support for various video formats?

May 10 2021, 9:48 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch, Browser-Support-Internet-Explorer
egardner edited projects for T266831: IE 11 - video player does not work on MediaSearch page, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
May 10 2021, 9:34 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch, Browser-Support-Internet-Explorer
egardner added a comment to T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview).

Current status on Beta commons:

May 10 2021, 9:24 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari
egardner placed T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview) up for grabs.
May 10 2021, 9:18 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari
egardner moved T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview) from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
May 10 2021, 3:24 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari
egardner added a comment to T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview).

This will need some testing in production (or Beta) once the new MediaSearch extension is enabled and publicly visible (may not happen for another week or two).

May 10 2021, 3:24 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari

May 7 2021

egardner committed rEMED0b9ca8949cb4: Use ogvjs with videojs for cross-platform playback support (authored by egardner).
Use ogvjs with videojs for cross-platform playback support
May 7 2021, 7:24 PM
egardner committed rEMEDa0f773810aaa: Remove unnecessary Array method polyfills (authored by egardner).
Remove unnecessary Array method polyfills
May 7 2021, 7:19 PM

May 6 2021

egardner moved T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview) from Blocked to Code Review on the Structured-Data-Backlog (Current Work) board.
May 6 2021, 10:29 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari
egardner added a comment to T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview).

Ok, success! I'll upload a patch shortly. For posterity, the problem was that some extra configuration is needed to get the modules for videojs and ogvjs working together. The complete player initialization code looks like this:

May 6 2021, 10:22 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari
egardner added a comment to T262470: [S] Error: Missing MediaInfo tabs.

Pretty sure this error is the result of some unsupported gadget or user script. I am unable to repro locally.

May 6 2021, 1:11 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work), wdwb-tech, Wikidata, JavaScript, WikibaseMediaInfo, Wikimedia-production-error
egardner moved T262470: [S] Error: Missing MediaInfo tabs from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
May 6 2021, 1:08 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work), wdwb-tech, Wikidata, JavaScript, WikibaseMediaInfo, Wikimedia-production-error

May 5 2021

egardner added a comment to T281145: 1.37.0-wmf.4 deployment blockers.

Chatted to @egardner and the above error is likely limited to commons so not likely to be an issue tomorrow.

May 5 2021, 11:35 PM · User-brennen, Release-Engineering-Team (Doing), Release, Train Deployments
egardner claimed T262470: [S] Error: Missing MediaInfo tabs.
May 5 2021, 11:00 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work), wdwb-tech, Wikidata, JavaScript, WikibaseMediaInfo, Wikimedia-production-error
egardner added a comment to T280425: [M] Handle users who arrive on the page with the obsolete "bitmap" parameter.

@Etonkovidova this patch (like most patches going forward) was applied to the stand-alone MediaSearch extension version of this code – as opposed to the code that lives inside of WikibaseMediaInfo.

May 5 2021, 10:53 PM · Structured-Data-Backlog (Current Work)
egardner added a comment to T281781: Proposal: support for ES Modules via script type="module" tags.

@Krinkle fair enough – I agree that ResourceLoader currently gives us most of the benefits that <script type="module"> would already, with greater backwards-compatibility. However, I do think it's good to keep an eye on the evolving state of the web here. There may be a time when we want to do less of this work ourselves and rely more on built-in browser functionality.

May 5 2021, 7:41 PM · Performance-Team (Radar), Patch-For-Review, Design-Systems-team-board, MediaWiki-ResourceLoader
egardner created T282040: PHP Warning: Cannot modify header information - headers already sent by (output started at /srv/mediawiki/php-1.37.0-wmf.3/includes/MediaWiki.php:817).
May 5 2021, 6:32 PM · Parsoid, Wikimedia-production-error
egardner added a parent task for T282038: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from SpecialRecentChanges::doMainQuery: [1054] Unknown column 'actor_user' in 'on clause' (10.64.0.44): T281146: 1.37.0-wmf.5 deployment blockers.
May 5 2021, 6:26 PM · Platform Team Workboards (MW Expedition), MediaWiki-Recent-changes, Wikimedia-production-error
egardner added a subtask for T281146: 1.37.0-wmf.5 deployment blockers: T282038: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from SpecialRecentChanges::doMainQuery: [1054] Unknown column 'actor_user' in 'on clause' (10.64.0.44).
May 5 2021, 6:26 PM · User-brennen, Release-Engineering-Team (Doing), Release, Train Deployments
egardner created T282038: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from SpecialRecentChanges::doMainQuery: [1054] Unknown column 'actor_user' in 'on clause' (10.64.0.44).
May 5 2021, 6:24 PM · Platform Team Workboards (MW Expedition), MediaWiki-Recent-changes, Wikimedia-production-error
egardner added projects to T282036: Precondition failed: Must have a latest revision (from CirrusSearch IncomingLinkCount job): CirrusSearch, Discovery-Search.
May 5 2021, 6:19 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
egardner created T282036: Precondition failed: Must have a latest revision (from CirrusSearch IncomingLinkCount job).
May 5 2021, 6:19 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error

May 4 2021

egardner moved T281173: Restore server-side error handling to MediaSearch UI from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
May 4 2021, 3:17 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work)
egardner claimed T281173: Restore server-side error handling to MediaSearch UI.
May 4 2021, 3:17 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work)
egardner added a comment to T281173: Restore server-side error handling to MediaSearch UI.

Invalid search queries and bad type params have been addressed at this point. I'll open a separate patch to try and deal with bad values for search filters.

May 4 2021, 3:17 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work)
egardner committed rEMEDb0955dcbee95: Error handling improvements in JS and PHP (authored by egardner).
Error handling improvements in JS and PHP
May 4 2021, 1:26 PM

May 3 2021

egardner added a comment to T281781: Proposal: support for ES Modules via script type="module" tags.

developers will benefit from better IDE tooling and will be able to write code in a more standardized way

What do you mean by this exactly? If you mean import and export, then I think there would be additional challenges in getting those to work/coexist with ResourceLoader. Are there other language features that are only available when type="module" is used?

May 3 2021, 11:35 PM · Performance-Team (Radar), Patch-For-Review, Design-Systems-team-board, MediaWiki-ResourceLoader
egardner created T281781: Proposal: support for ES Modules via script type="module" tags.
May 3 2021, 10:17 PM · Performance-Team (Radar), Patch-For-Review, Design-Systems-team-board, MediaWiki-ResourceLoader

Apr 29 2021

egardner updated subscribers of T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview).

@MarkTraceur, @dr0ptp4kt, and I chatted today about trying to unblock this task. I'm going to spend some time on a spike to see if I can apply the OGVJS shim to the "beta" VideoJs player that we are using in order to support OGG/WEBP playback in Desktop Safari in the same manner that we're currently doing for the legacy video player used on Commons File pages.

Apr 29 2021, 6:39 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work), Browser-Support-Apple-Safari

Apr 28 2021

egardner added a comment to T278509: Unify button implementations.

I've been thinking about this some more and it raises a major question that we should answer early on in this process: when do we make a component more complex, and when do we create a new component?

I generally tend to support additional, separate components for the following reasons:

  • It keeps components simpler, which benefits library authors (easier to write code iteratively and maintain code) and users (fewer props/etc. to keep track of per component)
  • It makes components' purposes clearer to the library user
Apr 28 2021, 8:09 PM · WVUI, Design-Systems-team-board
egardner added a comment to T279034: CentralNotice code to fix the banner bump with “pageview+1 with exceptions for infrequent visitors and as needed”.

Mentioned this at today's Front-End Standards Group meeting, but I think this problem would be a good candidate for the new Technical Decision Making Process because it cuts across the concerns of several different teams. This process already includes a framework for evaluating different possible solutions (including the "solution" of leaving the current status quo in place).

Apr 28 2021, 4:02 PM · Readers-Web-Backlog (Tracking), Product Infrastructure Roadmap, SEO, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Apr 27 2021

egardner updated the task description for T281173: Restore server-side error handling to MediaSearch UI.
Apr 27 2021, 9:23 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Structured-Data-Backlog (Current Work)
egardner moved T279108: Introduce a Front-end Build Step for MediaWiki Skins and Extensions from Backlog to Doing on the Design-Systems-team-board board.
Apr 27 2021, 7:54 PM · Design-Systems-team-board, tech-decision-forum
egardner moved T280828: Create a temporary entry for all WVUI components from Doing to Code review on the Design-Systems-team-board board.
Apr 27 2021, 7:45 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), WVUI, Design-Systems-team-board
egardner moved T280828: Create a temporary entry for all WVUI components from To Do to Doing on the Design-Systems-team-board board.
Apr 27 2021, 7:45 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), WVUI, Design-Systems-team-board