Page MenuHomePhabricator

egardner ((on leave though 7/2022))
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (179 w, 3 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Apr 13 2022

egardner updated egardner.
Apr 13 2022, 9:17 PM
egardner updated egardner.
Apr 13 2022, 9:16 PM
egardner updated egardner.
Apr 13 2022, 9:16 PM

Apr 8 2022

egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 8 2022, 5:08 PM · Design-Systems-Team, Design, Codex

Apr 7 2022

egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 7 2022, 9:43 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 7 2022, 9:26 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 7 2022, 5:33 PM · Design-Systems-Team, Design, Codex
egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

To ensure things don't get lost in the comments here, I'm adding the specific design review tasks (and patches that address them) to the top of this ticket.

Apr 7 2022, 5:33 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 7 2022, 5:31 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 7 2022, 5:15 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 7 2022, 5:14 PM · Design-Systems-Team, Design, Codex
egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@egardner I don't agree with this, we should have one only Tab/Tabs page. If you want we can add two different demos in the same page, but having 2 different pages for the same componen will be confusing for users. It seems that the Tab only has 2 tabs while Tabs has more than 2 tabs, why don't we mix both in the same page and we add a demo prop to configure the number of tabs you want the component to display?

Apr 7 2022, 3:02 PM · Design-Systems-Team, Design, Codex

Apr 6 2022

egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Apr 6 2022, 9:49 PM · Design-Systems-Team, Design, Codex
egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@egardner I send you some corrections I've found in the tabs while reviewing the demo:

  1. Why we have 2 different component demos: Tab and Tabs?

Captura de pantalla 2022-04-06 a las 10.23.03.png (1×1 px, 647 KB)

Apr 6 2022, 9:45 PM · Design-Systems-Team, Design, Codex
egardner added a comment to T302541: Vue.js progressive enhancement proof-of-concept.

I've added a basic prototype MW skin called "Incunabula" – the project repo is here: https://gitlab.wikimedia.org/egardner/incunabula-skin

Apr 6 2022, 3:23 AM · Design-Systems-Team, Vue.js
egardner updated the task description for T302541: Vue.js progressive enhancement proof-of-concept.
Apr 6 2022, 3:15 AM · Design-Systems-Team, Vue.js
egardner moved T302541: Vue.js progressive enhancement proof-of-concept from In Development to Code Review on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Apr 6 2022, 3:15 AM · Design-Systems-Team, Vue.js

Apr 5 2022

egardner moved T303321: Add Tabs/Tab (Tabbed layout) component to Codex from Code Review to Design Review on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Apr 5 2022, 8:43 PM · Design-Systems-Team, Design, Codex

Mar 31 2022

egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

Another scroll-related issue is that, when you use the arrow keys to navigate to a tab that is out of view, the tabs bar doesn't scroll, and you end up navigating between tabs that are invisible.

Mar 31 2022, 9:32 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 31 2022, 8:40 PM · Design-Systems-Team, Design, Codex
egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@bmartinezcalvo One reason to rely on box-shadow and border combination for the focus in OOUI was to have rounded focus outlines. The tabs above in your example feature 0 radius edges. I'd unify those.

Mar 31 2022, 3:05 PM · Design-Systems-Team, Design, Codex

Mar 28 2022

egardner updated the task description for T304894: VitePress docs link handlers introduce unwanted behavior into component demos.
Mar 28 2022, 7:49 PM · Upstream, Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint)
egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

I've filed a bug task for the demo behavior I mentioned upthread: https://phabricator.wikimedia.org/T304894. This is an issue coming from Vitepress, not from the component itself.

Mar 28 2022, 7:37 PM · Design-Systems-Team, Design, Codex
egardner created T304894: VitePress docs link handlers introduce unwanted behavior into component demos.
Mar 28 2022, 7:35 PM · Upstream, Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint)
egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

If it's possible to update the focus state, I think option 2 (blue outline around the tab for both type of tabs) is the most unified option with the rest of our components with focus state.

Focus.png (566×1 px, 15 KB)

Mar 28 2022, 5:59 PM · Design-Systems-Team, Design, Codex

Mar 26 2022

egardner added a comment to T286946: [Epic] Resolve key questions for development of shared component library.

Personally I would like to see gadget and user script authors gain the ability to start using Vue and Codex for their own projects. I think this will eventually be possible but there are a couple of blockers at the moment.

Mar 26 2022, 4:52 PM · Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board), Epic

Mar 25 2022

egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

You can see a live demo of the Tabs component here:
https://772516--wikimedia-codex.netlify.app/components/tabs.html

Mar 25 2022, 6:39 PM · Design-Systems-Team, Design, Codex
egardner moved T303321: Add Tabs/Tab (Tabbed layout) component to Codex from In Development to Code Review on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 25 2022, 6:37 PM · Design-Systems-Team, Design, Codex

Mar 24 2022

egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@Volker_E I agree that we should evaluate some of the keyboard behavior (like how Up and Down arrows should work). It should be pretty easy to change things if we decide that one approach or the other is the best. Same goes for the "wrap-around" behavior – I can enable this if needed but I wonder if things are clearer/more obvious to the end user without it.

Mar 24 2022, 9:13 PM · Design-Systems-Team, Design, Codex

Mar 23 2022

egardner closed T300666: Enable support for "ES6" RL modules in Safari 11+ as Resolved.

This has been resolved, the impacted code is running again in the target browsers.

Mar 23 2022, 7:55 PM · Design-Systems-team-20200324-20220422, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review
egardner closed T300666: Enable support for "ES6" RL modules in Safari 11+, a subtask of T299253: Suggested tags page just loads without stopping, as Resolved.
Mar 23 2022, 7:55 PM · Structured-Data-Backlog (Current Work), User-Josve05a, MachineVision, StructuredDataOnCommons
egardner closed T300666: Enable support for "ES6" RL modules in Safari 11+, a subtask of T300094: MediaSearch - Safari older versions support , as Resolved.
Mar 23 2022, 7:55 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
egardner closed T272879: Migrate WVUI library to Rollup or Vite as Declined.

Closing as declined since we're deprecating WVUI for Codex (which uses Vite, built on top of rollup) shortly.

Mar 23 2022, 7:54 PM · Design-Systems-team-20200324-20220422, WVUI, Patch-For-Review, Performance-Team (Radar)

Mar 21 2022

egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@bmartinezcalvo I was just working on this today. I'd like to propose a few changes to this based on what I've been reading in this article: https://inclusive-components.design/tabbed-interfaces/#keyboardbehavior.

Mar 21 2022, 5:56 PM · Design-Systems-Team, Design, Codex
egardner claimed T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 21 2022, 4:32 PM · Design-Systems-Team, Design, Codex
egardner moved T303321: Add Tabs/Tab (Tabbed layout) component to Codex from Research to In Development on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 21 2022, 4:32 PM · Design-Systems-Team, Design, Codex
egardner edited projects for T303321: Add Tabs/Tab (Tabbed layout) component to Codex, added: Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint); removed Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board).
Mar 21 2022, 4:29 PM · Design-Systems-Team, Design, Codex
egardner committed rEVTEa6da7aaa9e51: Update <cdx-select> usage: "options" was renamed to "menu-items" (authored by Catrope).
Update <cdx-select> usage: "options" was renamed to "menu-items"
Mar 21 2022, 6:01 AM
egardner added a comment to T303992: VueTest repo lagging in extensions meta repo because it uses main not master.

I've deleted the main branch in Gerrit, and cherry-picked the only commit which had been merged there but not to master. The master branch can be considered canonical from here on out.

Mar 21 2022, 5:55 AM · Gerrit, Codex

Mar 19 2022

egardner added a comment to T303992: VueTest repo lagging in extensions meta repo because it uses main not master.

Sorry about this – I initially created this repo in Gitlab where main was used, I didn't realize this would cause problems.

Mar 19 2022, 8:59 PM · Gerrit, Codex

Mar 17 2022

egardner merged T294161: Add a tabbed layout component to Codex into T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 17 2022, 4:48 PM · Design-Systems-Team, Design, Codex
egardner merged task T294161: Add a tabbed layout component to Codex into T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 17 2022, 4:48 PM · Codex, Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board)
egardner added a comment to T299143: Test/stage environment to view Codex on MediaWiki.

Wow, this is cool! Now that we have this capability, I'm open to suggestions on ways to develop the VueTest extension to make it more useful for QA testing purposes. Would it make sense to have a single dedicated Special page per Codex component (one page could show multiple variations of course)? Should we try to embed the actual demo code from the docs site inside of MW somehow?

Mar 17 2022, 3:13 AM · Codex, Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board)

Mar 16 2022

egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 16 2022, 9:10 PM · Design-Systems-Team, Design, Codex
egardner closed T299956: Create a MediaWiki extension to test Codex as Resolved.

Closing this because the extension exists and is in Gerrit. We can open follow-up tasks later if we need to add new functionality here.

Mar 16 2022, 6:00 PM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), Codex
egardner closed T299956: Create a MediaWiki extension to test Codex, a subtask of T299143: Test/stage environment to view Codex on MediaWiki, as Resolved.
Mar 16 2022, 6:00 PM · Codex, Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board)
egardner added a comment to T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex.

I've set this task as a subtask of the Codex Alpha milestone, because it seems like the bulk of the Codex / Abstract Wiki case study is going to revolve around swapping out the existing SD components with Codex equivalents, and making small adjustments where necessary.

Mar 16 2022, 5:59 PM · Design-Systems-Team, Abstract Wikipedia team (Phase κ – Clean-up), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda
egardner updated the task description for T303278: Switch WikiLambda from copied MediaSearch Lookup component to Codex Lookup.
Mar 16 2022, 5:56 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
egardner renamed T303278: Switch WikiLambda from copied MediaSearch Lookup component to Codex Lookup from Switch WikiLambda from copied MediaSearch Lookup component to using Codex TypeaheadSearch to Switch WikiLambda from copied MediaSearch Lookup component to Codex Lookup.
Mar 16 2022, 5:51 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
egardner updated the task description for T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex.
Mar 16 2022, 5:49 PM · Design-Systems-Team, Abstract Wikipedia team (Phase κ – Clean-up), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda
egardner updated the task description for T299138: [Milestone] Codex Alpha: First Release.
Mar 16 2022, 5:48 PM · Design-Systems-Team, Release, Codex, Epic
egardner added a parent task for T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex: T299138: [Milestone] Codex Alpha: First Release.
Mar 16 2022, 5:46 PM · Design-Systems-Team, Abstract Wikipedia team (Phase κ – Clean-up), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda
egardner added a subtask for T299138: [Milestone] Codex Alpha: First Release: T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex.
Mar 16 2022, 5:46 PM · Design-Systems-Team, Release, Codex, Epic
egardner removed a subtask for T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex: T299138: [Milestone] Codex Alpha: First Release.
Mar 16 2022, 5:46 PM · Design-Systems-Team, Abstract Wikipedia team (Phase κ – Clean-up), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda
egardner removed a parent task for T299138: [Milestone] Codex Alpha: First Release: T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex.
Mar 16 2022, 5:46 PM · Design-Systems-Team, Release, Codex, Epic
egardner updated the task description for T284843: Add Message component to Codex.
Mar 16 2022, 5:44 PM · Design-Systems-Team, Patch-For-Review, Design, Codex
egardner updated the task description for T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex.
Mar 16 2022, 5:35 PM · Design-Systems-Team, Abstract Wikipedia team (Phase κ – Clean-up), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda
egardner updated the task description for T286668: [Codex Alpha] Switch WikiLambda from copied MediaSearch components to using Codex.
Mar 16 2022, 5:32 PM · Design-Systems-Team, Abstract Wikipedia team (Phase κ – Clean-up), MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Patch-For-Review, Abstract Wikipedia Fix-It tasks, WikiLambda

Mar 15 2022

egardner added a comment to T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@STHart @egardner I've assigned this task to add the disabled state. Do we have the example with disabled tabs for AW? I would like to review it to better understand this use case.

Mar 15 2022, 4:39 PM · Design-Systems-Team, Design, Codex

Mar 14 2022

egardner added a comment to T303781: Type definitions import from packages that aren't listed as dependencies.

I support investigating clever ways to import/embed type definitions, but I know that can be a bit of a rabbit hole.

Mar 14 2022, 11:58 PM · Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board), Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 14 2022, 8:21 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 14 2022, 8:15 PM · Design-Systems-Team, Design, Codex
egardner moved T303321: Add Tabs/Tab (Tabbed layout) component to Codex from Open Tasks to Needs Design on the Codex board.
Mar 14 2022, 8:14 PM · Design-Systems-Team, Design, Codex
egardner updated subscribers of T303321: Add Tabs/Tab (Tabbed layout) component to Codex.

@Sarai-WMDE @bmartinezcalvo I've fleshed out this task a bit more and added some relevant information. @STHart I think we may need to prioritize development of this component because not having it will block Vue 3 migration for some projects (because folks who need this layout are relying on an earlier version of this component which is not Vue 3 compatible). Fortunately we 1) have the designs more or less (going back to OOUI), and 2) some implementation work has already been done in old patches and can be used as a starting point.

Mar 14 2022, 5:21 PM · Design-Systems-Team, Design, Codex
egardner updated the task description for T303321: Add Tabs/Tab (Tabbed layout) component to Codex.
Mar 14 2022, 5:14 PM · Design-Systems-Team, Design, Codex

Mar 11 2022

egardner moved T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation from Ready for Development to Code Review on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 11 2022, 11:44 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
egardner placed T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode up for grabs.
Mar 11 2022, 10:41 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner added a comment to T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.

This task is looking like it is probably not worth the effort; moving to "blocked" for now.

Mar 11 2022, 10:40 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner moved T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode from Ready for Development to In Design on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 11 2022, 10:39 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner claimed T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation.
Mar 11 2022, 10:39 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
egardner moved T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation from Research to Ready for Development on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 11 2022, 10:39 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
egardner updated subscribers of T300573: Upgrade Vue.js development version in web team extensions / skins.

@egardner @Catrope I've come to the conclusion that it's going to be too painful to convert WVUI to Vue 3, so I think switching WVUI+Vue 2 for Codex and Vue 3 at the same time is inevitable.

Mar 11 2022, 10:35 PM · Design-Systems-Team, Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Vector, NearbyPages, QuickSurveys
egardner added a comment to T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation.

I think I was unclear on the desired UX when we were working on selectHighlighted – we actually never want something to be selected and highlighted at the same time due to keyboard navigation, correct?

Mar 11 2022, 10:07 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
egardner added a comment to T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation.

Is merging of https://gerrit.wikimedia.org/r/c/design/codex/+/770014 blocked until this issue is resolved, or should this be handled in a follow-up patch? I assume the latter but just want to make sure.

Mar 11 2022, 9:28 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
egardner updated subscribers of T299956: Create a MediaWiki extension to test Codex.

@Mhurd We've migrated this extension into Gerrit, so you may want to update your Makefile / Docker setup to clone from the new repo: https://gerrit.wikimedia.org/r/mediawiki/extensions/VueTest

Mar 11 2022, 5:08 PM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), Codex
egardner moved T299956: Create a MediaWiki extension to test Codex from In Development to Design Sign-Off on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 11 2022, 5:06 PM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), Codex
egardner updated the task description for T299956: Create a MediaWiki extension to test Codex.
Mar 11 2022, 5:06 PM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), Codex
egardner updated the task description for T299956: Create a MediaWiki extension to test Codex.
Mar 11 2022, 5:04 PM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), Codex
egardner added a comment to T303569: Add TypeaheadSearch-only build.

So is the appropriate comparison codex-typeaheadSearch.umd.js (at 23.5KB) vs wvui-search.js (at 19.8KB)?

Mar 11 2022, 1:57 AM · Design-Systems-Team (Design-Systems-Sprint), Codex

Mar 10 2022

egardner committed rEVTEa3c8a5bac1a9: Update Vue and Codex dependencies (authored by egardner).
Update Vue and Codex dependencies
Mar 10 2022, 11:52 PM
egardner added a comment to T300656: Add SearchInput component to Codex and TypeaheadSearch component.

Great, glad that idea makes sense to everyone!

Mar 10 2022, 4:54 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex

Mar 8 2022

egardner added a comment to T300625: Add MenuItem component to Codex and TypeaheadSearch component.

Does the spacing between MenuItem Icons and labels/descriptions look a bit tight to anyone else?

Mar 8 2022, 9:37 PM · Design-Systems-Team, Patch-For-Review, Design, Codex
egardner updated the task description for T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.
Mar 8 2022, 8:52 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner moved T295179: Add ToggleButton component to Codex from Research to Code Review on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 8 2022, 5:14 PM · Design-Systems-Team, User-DannyS712, Codex
egardner edited projects for T295179: Add ToggleButton component to Codex, added: Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint); removed Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board).
Mar 8 2022, 5:14 PM · Design-Systems-Team, User-DannyS712, Codex
egardner moved T303180: Combobox handle icon spacing is off from Research to Design Sign-Off on the Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint) board.
Mar 8 2022, 1:00 AM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), Codex

Mar 4 2022

egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 4 2022, 9:06 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)
egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 4 2022, 9:04 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)
egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 4 2022, 7:40 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)
egardner added a comment to T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.

Getting all the Typescript configuration working properly will be a big hassle here I think. The guidelines I was developing over at T302831 assume a JS migration; migrating between two TS codebases adds a lot more effort because the types shipped in Vue have undergone a lot of changes as well.

Mar 4 2022, 6:33 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner updated the task description for T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.
Mar 4 2022, 5:01 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner added a subtask for T302129: Migrate all CLI testing of Vue code (jest etc.) from Vue 2 to Vue 3 in compatibility mode: T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.
Mar 4 2022, 5:00 PM · Technical-Debt, Vue.js
egardner added a parent task for T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode: T302129: Migrate all CLI testing of Vue code (jest etc.) from Vue 2 to Vue 3 in compatibility mode.
Mar 4 2022, 5:00 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner claimed T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.
Mar 4 2022, 5:00 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner created T303063: Migrate WVUI code and test suite to Vue 3 compatibility mode.
Mar 4 2022, 4:59 PM · Design-Systems-Team, Patch-For-Review, WVUI
egardner added a comment to T299291: Improve videoJS MediaSearch integration.

@TheDJ thanks! I think that in our case the initialization code will look something like this (inside the mounted() hook for the Player.vue component):

Mar 4 2022, 4:32 PM · Structured-Data-Backlog, VideoJS player

Mar 3 2022

egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 3 2022, 11:54 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)
egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 3 2022, 11:53 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)
egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 3 2022, 11:51 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)
egardner updated the task description for T302831: Develop guidelines for migrating Vue test suites to V3.
Mar 3 2022, 11:51 PM · Design-Systems-Team, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07)