Page MenuHomePhabricator

egardner (Eric Gardner)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (34 w, 2 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Thu, Sep 19

egardner moved T233228: Style cards to match new design from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 19, 7:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner moved T231926: Replace "feed" UI with card/stack metaphor from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 19, 7:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner moved T233228: Style cards to match new design from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 19, 7:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner moved T231926: Replace "feed" UI with card/stack metaphor from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 19, 7:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner added a comment to T221015: Enforce statement uniqueness on Filepage.

I think that it may be worth returning to this issue now that we are working on support for other data types.

Thu, Sep 19, 7:00 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner removed a project from T221015: Enforce statement uniqueness on Filepage: Technical-Debt.
Thu, Sep 19, 6:57 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner edited projects for T221015: Enforce statement uniqueness on Filepage, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Thu, Sep 19, 6:56 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering

Mon, Sep 16

egardner added a parent task for T224060: Add support for geo-coordinate Wikibase datatype for qualifiers only: T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:10 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T224060: Add support for geo-coordinate Wikibase datatype for qualifiers only.
Mon, Sep 16, 5:10 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T227112: Add UI support for time Wikibase datatype for qualifiers only.
Mon, Sep 16, 5:07 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a parent task for T227112: Add UI support for time Wikibase datatype for qualifiers only: T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:07 PM · SDC-Statements (other-input-types-on-a-dirigible), WikibaseMediaInfo, UploadWizard, Structured-Data-Backlog, Structured Data Engineering
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files.
Mon, Sep 16, 5:06 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a parent task for T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files: T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:06 PM · SDC-Statements (other-input-types-on-a-dirigible), Structured Data Engineering, UploadWizard, WikibaseMediaInfo, Structured-Data-Backlog
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T231979: Add UI support for time Wikibase datatype for top-level statements.
Mon, Sep 16, 5:06 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a parent task for T231979: Add UI support for time Wikibase datatype for top-level statements: T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:06 PM · SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering, Structured-Data-Backlog
egardner added a parent task for T231981: Add support for top-level statements with quantity values, and units for quantity data type : T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:05 PM · SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured-Data-Backlog, Structured Data Engineering
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T231981: Add support for top-level statements with quantity values, and units for quantity data type .
Mon, Sep 16, 5:05 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a parent task for T231995: Add support for 'external identifier' data type (top-level and qualifiers): T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:05 PM · Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, Structured Data Engineering
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T231995: Add support for 'external identifier' data type (top-level and qualifiers).
Mon, Sep 16, 5:05 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T231996: Add support for 'monolingual text' data type (top-level and qualifiers).
Mon, Sep 16, 5:04 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a parent task for T231996: Add support for 'monolingual text' data type (top-level and qualifiers): T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 5:04 PM · SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering, Structured-Data-Backlog
egardner added a parent task for T231994: Add support for url data type (top-level statements and qualifiers): T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 4:52 PM · SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard
egardner added a subtask for T233036: Enable support for all WB data types in top-level Statements and Qualifiers: T231994: Add support for url data type (top-level statements and qualifiers).
Mon, Sep 16, 4:52 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner moved T233036: Enable support for all WB data types in top-level Statements and Qualifiers from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Mon, Sep 16, 4:51 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner created T233036: Enable support for all WB data types in top-level Statements and Qualifiers.
Mon, Sep 16, 4:51 PM · Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work)
egardner added a comment to T224604: Allow to middle-click through to the Wikidata item from search results when adding Depicts statements.

Everything works as far as I can tell (I don't have a 3-button mouse to test with), but it introduces some changes to design and behavior that we should make sure are desired.

Mon, Sep 16, 3:34 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering

Thu, Sep 12

egardner moved T231994: Add support for url data type (top-level statements and qualifiers) from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 12, 1:35 AM · SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard

Wed, Sep 11

egardner claimed T231994: Add support for url data type (top-level statements and qualifiers).
Wed, Sep 11, 11:22 PM · SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard

Tue, Sep 10

egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Since this issue has fallen to the wayside for a while, I want to put an updated summary here so we can see everything in a single comment. My goal is to get final clarification on what the desired behavior here is.

Tue, Sep 10, 4:10 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, RTL, I18n, Structured-Data-Team-Current-Work

Mon, Sep 9

egardner moved T231927: Change behavior of accepted/rejected labels from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Mon, Sep 9, 4:21 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner added a comment to T231927: Change behavior of accepted/rejected labels.

Ok cool – if you are still finalizing the design I can always make visual adjustments in a follow-up patch.

Mon, Sep 9, 4:05 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner added a comment to T231927: Change behavior of accepted/rejected labels.

Screenshot of the new "single-track" UI with the patch I'm currently working on:

Mon, Sep 9, 3:57 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner updated the task description for T231927: Change behavior of accepted/rejected labels.
Mon, Sep 9, 3:54 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)

Sat, Sep 7

egardner moved T231927: Change behavior of accepted/rejected labels from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Sat, Sep 7, 4:11 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)

Wed, Sep 4

egardner moved T224060: Add support for geo-coordinate Wikibase datatype for qualifiers only from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Sep 4, 8:18 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner moved T224060: Add support for geo-coordinate Wikibase datatype for qualifiers only from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Wed, Sep 4, 4:48 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner moved T222283: In RTL languages, default instructional text for statement auto-suggest search field overlaps from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Sep 4, 4:48 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), I18n, RTL, Structured Data Engineering, Structured-Data-Team-Current-Work
egardner added a comment to T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null).

@alaa_wmde I'm not working actively on this at the moment, so I've un-assigned myself.

Wed, Sep 4, 2:16 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
egardner placed T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null) up for grabs.
Wed, Sep 4, 2:15 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error

Tue, Sep 3

egardner renamed T231918: Clarify issues around Federation for Machine Vision extension from Clarify issues around Federation to Clarify issues around Federation for Machine Vision extension.
Tue, Sep 3, 6:05 PM · Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts)
egardner edited projects for T231926: Replace "feed" UI with card/stack metaphor, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Tue, Sep 3, 6:04 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner edited projects for T231927: Change behavior of accepted/rejected labels, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Tue, Sep 3, 6:03 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner edited projects for T231915: Reconcile UI with latest designs, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Tue, Sep 3, 6:03 PM · Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner created T231927: Change behavior of accepted/rejected labels.
Tue, Sep 3, 6:02 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner placed T231915: Reconcile UI with latest designs up for grabs.
Tue, Sep 3, 5:58 PM · Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner created T231926: Replace "feed" UI with card/stack metaphor.
Tue, Sep 3, 5:58 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)
egardner created T231918: Clarify issues around Federation for Machine Vision extension.
Tue, Sep 3, 5:06 PM · Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts)
egardner created T231917: Enable users to actually edit structured data for relevant files through this tool.
Tue, Sep 3, 5:03 PM · Structured-Data-Backlog, SDC-Statements (Machine-vision-depicts)
egardner created T231915: Reconcile UI with latest designs.
Tue, Sep 3, 4:58 PM · Structured-Data-Backlog (Current Work), Machine vision, SDC-Statements (Machine-vision-depicts)

Tue, Aug 27

egardner added a comment to T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.

Left two small questions in code review. I can approve this tomorrow (which will also fix T228912).

Tue, Aug 27, 9:58 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)
egardner added a comment to T228912: Update how "Remove all" works for statement panels.

This should be fixed once the patch for T231225 is merged.

Tue, Aug 27, 9:56 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured Data Engineering

Mon, Aug 26

egardner edited projects for T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Mon, Aug 26, 11:16 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Fri, Aug 23

egardner moved T228474: Insert a horizontal divider between statements on UW from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Fri, Aug 23, 4:58 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Patch-For-Review, Structured-Data-Team-Current-Work, SDC Design
egardner added a comment to T228474: Insert a horizontal divider between statements on UW.

Moving to "verify on production", this is all live and working properly on Beta.

Fri, Aug 23, 4:57 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Patch-For-Review, Structured-Data-Team-Current-Work, SDC Design
egardner added a comment to T225102: Refactor UW statements code.

This patch has been merged. Regarding QA needs, we've done extensive testing locally but it would be good to go through the basic UW tasks (both within and outside of campaigns) on Beta just to ensure everything is ok. Then this ticket can probably be closed.

Fri, Aug 23, 4:56 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner moved T225102: Refactor UW statements code from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Aug 23, 4:55 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 23 2019

egardner moved T221732: Visually indicate to users that they can't add/edit captions/structured data to protected files from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Aug 23 2019, 2:27 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), Structured-Data-Design, Structured Data Engineering, SDC Design
egardner edited projects for T221732: Visually indicate to users that they can't add/edit captions/structured data to protected files, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Aug 23 2019, 2:27 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), Structured-Data-Design, Structured Data Engineering, SDC Design
egardner added a comment to T230849: Labels for newly-added values don't show up as links.

Merged some patches yesterday that should have addressed this. Just went to a random file on Beta commons and added a new value; it's label was properly linked from the moment it was added. Please double-check but I think this is fixed.

Aug 23 2019, 2:17 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner moved T230849: Labels for newly-added values don't show up as links from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.
Aug 23 2019, 2:15 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering

Aug 22 2019

egardner added a comment to T230849: Labels for newly-added values don't show up as links.

Just want to confirm that I can reproduce this locally – the problem is not limited to Beta.

Aug 22 2019, 4:14 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner moved T228327: Add option to skip structured data parts in upload wizard campaigns from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Aug 22 2019, 2:41 PM · Structured-Data-Team-Current-Work, UploadWizard, Structured-Data-Backlog (Current Work), Wiki-Loves-Monuments, SDC-Statements (Campaigns-jogging), Structured Data Engineering
egardner moved T230849: Labels for newly-added values don't show up as links from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Aug 22 2019, 2:41 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering

Aug 21 2019

egardner edited projects for T230849: Labels for newly-added values don't show up as links, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Aug 21 2019, 10:37 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T228327: Add option to skip structured data parts in upload wizard campaigns.

Ok – I think I found why Description fields are being treated as optional. It actually doesn't have anything to do with Structured Data. UploadWizard as it is presently written is designed to treat description fields as optional if any additional wikitext field has been provided. Here's the relevant part of the code (starts at line 78 in resources/mw.UploadWizardDetails.js:

Aug 21 2019, 10:13 PM · Structured-Data-Team-Current-Work, UploadWizard, Structured-Data-Backlog (Current Work), Wiki-Loves-Monuments, SDC-Statements (Campaigns-jogging), Structured Data Engineering
egardner moved T225102: Refactor UW statements code from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Aug 21 2019, 2:16 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 20 2019

egardner closed T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic] as Resolved.
Aug 20 2019, 4:57 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner added a comment to T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic].

Now that the basic scaffolding is in place, this is going to become an ongoing background task. This ticket can be closed.

Aug 20 2019, 4:57 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner added a comment to T224890: Depicts: uploading multiple images issue.

We will try to address some usability issues in the "UI Consolidation" milestone, adding this ticket there.

Aug 20 2019, 4:50 PM · SDC-Statements (UI-consolidation-on-a-Ferris-wheel), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC Design
egardner edited projects for T224890: Depicts: uploading multiple images issue, added: SDC-Statements (UI-consolidation-on-a-Ferris-wheel); removed SDC-Statements (Other-statements-running).
Aug 20 2019, 4:50 PM · SDC-Statements (UI-consolidation-on-a-Ferris-wheel), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC Design
egardner claimed T228327: Add option to skip structured data parts in upload wizard campaigns.
Aug 20 2019, 4:17 PM · Structured-Data-Team-Current-Work, UploadWizard, Structured-Data-Backlog (Current Work), Wiki-Loves-Monuments, SDC-Statements (Campaigns-jogging), Structured Data Engineering

Aug 19 2019

egardner claimed T224060: Add support for geo-coordinate Wikibase datatype for qualifiers only.
Aug 19 2019, 4:50 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured-Data-Backlog (Current Work), Structured Data Engineering

Aug 12 2019

egardner added a comment to T225102: Refactor UW statements code.

I'm going to take a stab at this. I spent a large chunk of today walking through the UW code in a JS debugger to get a better sense of the flow.

Aug 12 2019, 11:45 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner claimed T225102: Refactor UW statements code.
Aug 12 2019, 11:39 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 9 2019

egardner added a comment to T222283: In RTL languages, default instructional text for statement auto-suggest search field overlaps.

Patch is ready for review. I've added a very narrow override for when the <body> element possesses both the rtl and sitedir-ltr classes; I still don't understand why the latter class gets added at all when the language is set to something like Hebrew or Arabic.

Aug 9 2019, 9:56 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), I18n, RTL, Structured Data Engineering, Structured-Data-Team-Current-Work
egardner moved T222283: In RTL languages, default instructional text for statement auto-suggest search field overlaps from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Aug 9 2019, 9:54 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), I18n, RTL, Structured Data Engineering, Structured-Data-Team-Current-Work
egardner added a comment to T222283: In RTL languages, default instructional text for statement auto-suggest search field overlaps.

I assume the correct appearance in RTL languages would be something like this:

Aug 9 2019, 9:18 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), I18n, RTL, Structured Data Engineering, Structured-Data-Team-Current-Work
egardner moved T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null) from Doing to Blocked on the Structured-Data-Team-Current-Work board.
Aug 9 2019, 4:04 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
Amire80 awarded T222283: In RTL languages, default instructional text for statement auto-suggest search field overlaps a Like token.
Aug 9 2019, 1:22 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Structured-Data-Backlog (Current Work), I18n, RTL, Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 8 2019

egardner added a comment to T224147: Mechanism to allow a campaign admin to add help text for pre-selected statements.

Could we design a treatment for "suggested statements" that could work both for campaigns and for the hypothetical use-case where machine-generated suggestions are shown right on the file page? I know such a feature is not currently planned, but it seems like it may be something we consider eventually.

Aug 8 2019, 4:12 PM · Structured-Data-Design, Structured-Data-Backlog, SDC-Statements (Campaigns-jogging), SDC Design, Structured Data Engineering

Aug 7 2019

egardner moved T229602: Handle language fallback chain consistently in Statement UI from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Aug 7 2019, 9:43 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner moved T229602: Handle language fallback chain consistently in Statement UI from To Do to Doing on the Structured-Data-Team-Current-Work board.
Aug 7 2019, 5:52 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner updated subscribers of T229602: Handle language fallback chain consistently in Statement UI.

@Ramsey-WMF and @PDrouin-WMF, I've language-indicatored all the things – let me know if this looks right to you:

Aug 7 2019, 5:52 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 6 2019

egardner moved T228474: Insert a horizontal divider between statements on UW from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Aug 6 2019, 11:24 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Patch-For-Review, Structured-Data-Team-Current-Work, SDC Design
egardner added a comment to T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null).

I'm still trying to follow the exact code-path here. This is what I can say after digging around so far:

Aug 6 2019, 8:06 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
egardner added a comment to T228474: Insert a horizontal divider between statements on UW.

Let me know if this is good to go, design-wise, and I will review & approve so we can merge.

Aug 6 2019, 6:22 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Patch-For-Review, Structured-Data-Team-Current-Work, SDC Design
egardner moved T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null) from To Do to Doing on the Structured-Data-Team-Current-Work board.
Aug 6 2019, 6:17 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
egardner added a project to T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null): Structured-Data-Team-Current-Work.
Aug 6 2019, 6:17 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
egardner added a comment to T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null).

Timebox of "today" at any rate. I'll post updates based on what I can discover.

Aug 6 2019, 4:22 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
egardner added a comment to T228912: Update how "Remove all" works for statement panels.

You can disregard the abandoned patch above (it was redundant); the two patches linked in my previous comment are the ones we need.

Aug 6 2019, 12:49 AM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured Data Engineering

Aug 5 2019

egardner moved T228912: Update how "Remove all" works for statement panels from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Aug 5 2019, 11:55 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T228912: Update how "Remove all" works for statement panels.

Here is the current status of this change in UploadWizard:

Aug 5 2019, 11:55 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner moved T229572: Write a new js config var containing the MediaInfo entity on the File page from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Aug 5 2019, 8:56 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work
egardner moved T229572: Write a new js config var containing the MediaInfo entity on the File page from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Aug 5 2019, 4:31 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work

Aug 2 2019

egardner moved T229572: Write a new js config var containing the MediaInfo entity on the File page from To Do to Doing on the Structured-Data-Team-Current-Work board.
Aug 2 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work

Aug 1 2019

egardner claimed T229572: Write a new js config var containing the MediaInfo entity on the File page.
Aug 1 2019, 6:01 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work
egardner added a comment to T228693: Properties lacking a label in the user's language have the fallback language name appended to the fallback label.

That ticket is here: https://phabricator.wikimedia.org/T229602

Aug 1 2019, 5:59 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
egardner claimed T229602: Handle language fallback chain consistently in Statement UI.
Aug 1 2019, 5:58 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner created T229602: Handle language fallback chain consistently in Statement UI.
Aug 1 2019, 5:58 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
egardner moved T228912: Update how "Remove all" works for statement panels from Code Review to Doing on the Structured-Data-Team-Current-Work board.
Aug 1 2019, 4:03 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured Data Engineering