User Details
- User Since
- Jan 24 2019, 7:02 PM (34 w, 2 d)
- Availability
- Available
- LDAP User
- Eric Gardner
- MediaWiki User
- EGardner (WMF) [ Global Accounts ]
Thu, Sep 19
I think that it may be worth returning to this issue now that we are working on support for other data types.
Mon, Sep 16
Everything works as far as I can tell (I don't have a 3-button mouse to test with), but it introduces some changes to design and behavior that we should make sure are desired.
Thu, Sep 12
Wed, Sep 11
Tue, Sep 10
Since this issue has fallen to the wayside for a while, I want to put an updated summary here so we can see everything in a single comment. My goal is to get final clarification on what the desired behavior here is.
Mon, Sep 9
Ok cool – if you are still finalizing the design I can always make visual adjustments in a follow-up patch.
Screenshot of the new "single-track" UI with the patch I'm currently working on:
Sat, Sep 7
Wed, Sep 4
@alaa_wmde I'm not working actively on this at the moment, so I've un-assigned myself.
Tue, Sep 3
Tue, Aug 27
Left two small questions in code review. I can approve this tomorrow (which will also fix T228912).
This should be fixed once the patch for T231225 is merged.
Mon, Aug 26
Fri, Aug 23
Moving to "verify on production", this is all live and working properly on Beta.
This patch has been merged. Regarding QA needs, we've done extensive testing locally but it would be good to go through the basic UW tasks (both within and outside of campaigns) on Beta just to ensure everything is ok. Then this ticket can probably be closed.
Aug 23 2019
Merged some patches yesterday that should have addressed this. Just went to a random file on Beta commons and added a new value; it's label was properly linked from the moment it was added. Please double-check but I think this is fixed.
Aug 22 2019
Just want to confirm that I can reproduce this locally – the problem is not limited to Beta.
Aug 21 2019
Ok – I think I found why Description fields are being treated as optional. It actually doesn't have anything to do with Structured Data. UploadWizard as it is presently written is designed to treat description fields as optional if any additional wikitext field has been provided. Here's the relevant part of the code (starts at line 78 in resources/mw.UploadWizardDetails.js:
Aug 20 2019
Now that the basic scaffolding is in place, this is going to become an ongoing background task. This ticket can be closed.
We will try to address some usability issues in the "UI Consolidation" milestone, adding this ticket there.
Aug 19 2019
Aug 12 2019
I'm going to take a stab at this. I spent a large chunk of today walking through the UW code in a JS debugger to get a better sense of the flow.
Aug 9 2019
Patch is ready for review. I've added a very narrow override for when the <body> element possesses both the rtl and sitedir-ltr classes; I still don't understand why the latter class gets added at all when the language is set to something like Hebrew or Arabic.
I assume the correct appearance in RTL languages would be something like this:
Aug 8 2019
Could we design a treatment for "suggested statements" that could work both for campaigns and for the hypothetical use-case where machine-generated suggestions are shown right on the file page? I know such a feature is not currently planned, but it seems like it may be something we consider eventually.
Aug 7 2019
@Ramsey-WMF and @PDrouin-WMF, I've language-indicatored all the things – let me know if this looks right to you:
Aug 6 2019
I'm still trying to follow the exact code-path here. This is what I can say after digging around so far:
Let me know if this is good to go, design-wise, and I will review & approve so we can merge.
Timebox of "today" at any rate. I'll post updates based on what I can discover.
You can disregard the abandoned patch above (it was redundant); the two patches linked in my previous comment are the ones we need.
Aug 5 2019
Here is the current status of this change in UploadWizard:
Aug 2 2019
Aug 1 2019
That ticket is here: https://phabricator.wikimedia.org/T229602