Page MenuHomePhabricator

egardner (Eric Gardner)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (25 w, 4 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Today

egardner moved T228693: Properties lacking a label in the user's language have the fallback language name appended to the fallback label from To Do to Doing on the Multimedia-Current-Work board.
Mon, Jul 22, 11:07 PM · SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
egardner added a comment to T228693: Properties lacking a label in the user's language have the fallback language name appended to the fallback label.

Just wanted to add that I can reproduce this locally. My own dev instance only has a few Wikibase items/properties defined, and none of them have multi-language labels. So if I go to a file page and add &uselang=fr to the URL params, I get this:

Mon, Jul 22, 11:06 PM · SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
egardner added a comment to T228694: Design a system for recording votes on depicts suggestions.

I'm trying to imagine the full scenario here:

Mon, Jul 22, 10:05 PM · SDC-Statements (Machine-vision-depicts), Reading-Infrastructure-Team-Backlog, Machine vision, Multimedia
egardner added a comment to T228694: Design a system for recording votes on depicts suggestions.

This sounds like a lot of conditions to account for :)

I think all the "queue" would have to keep track of is: all qualifying images (prominent/ above minimum size/ not nsfw/ etc): that:

  • do not have structured data currently
  • possess one or more "machine-aided depicts statements" (at or above a given confidence threshold, if that is factored in)
  • have not had their machine-aided suggestions rejected by user action
Mon, Jul 22, 9:52 PM · SDC-Statements (Machine-vision-depicts), Reading-Infrastructure-Team-Backlog, Machine vision, Multimedia
egardner added a comment to T228694: Design a system for recording votes on depicts suggestions.

@Ramsey-WMF if a user downvoted a suggestion on an image, and then someone "reverted" that downvote, I'd assume the image could go back into the queue with all of the original suggestions back in place – assuming no other structured data existed for it yet. We could treat it as if they had made an edit to Special:ConfirmDepicts/File:Foo.jpg. That would be in keeping with https://www.mediawiki.org/wiki/Everything_is_a_wiki_page.

Mon, Jul 22, 9:27 PM · SDC-Statements (Machine-vision-depicts), Reading-Infrastructure-Team-Backlog, Machine vision, Multimedia
egardner added a comment to T228694: Design a system for recording votes on depicts suggestions.

Would we want to store the entire "Depicts: Dog" statement (P180: Q12345) at the DB level (as opposed to just the label/Q-number), in case this tool was ever re-purposed to work for other properties beyond Depicts?

Mon, Jul 22, 9:18 PM · SDC-Statements (Machine-vision-depicts), Reading-Infrastructure-Team-Backlog, Machine vision, Multimedia
egardner claimed T224249: Deleting statement panels.
Mon, Jul 22, 4:32 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), SDC Engineering, Multimedia-Current-Work, SDC Design, Multimedia
egardner moved T224249: Deleting statement panels from Needs QA to To Do on the Multimedia-Current-Work board.
Mon, Jul 22, 4:31 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), SDC Engineering, Multimedia-Current-Work, SDC Design, Multimedia
egardner moved T227230: Link statement labels with their respective Wikidata urls from Code Review to Needs QA on the Multimedia-Current-Work board.
Mon, Jul 22, 4:04 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Tue, Jul 16

Ramsey-WMF awarded T227230: Link statement labels with their respective Wikidata urls a Like token.
Tue, Jul 16, 2:21 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
egardner added a comment to T227230: Link statement labels with their respective Wikidata urls.

Here's a current example of how the links message appears. Styling just follows the UI defaults. Clicking the "X" removes the message and saves the user's decision.

Tue, Jul 16, 2:12 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Thu, Jul 11

egardner added a comment to T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

Looks like this has been merged – is this ticket good to close?

Thu, Jul 11, 1:56 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

Wed, Jul 10

egardner added a comment to T227230: Link statement labels with their respective Wikidata urls.

@PDrouin-WMF thanks – I'll add the notice bar in a separate patch.

Wed, Jul 10, 8:38 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Tue, Jul 9

egardner moved T227230: Link statement labels with their respective Wikidata urls from Doing to Code Review on the Multimedia-Current-Work board.
Tue, Jul 9, 8:30 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Mon, Jul 8

egardner moved T227230: Link statement labels with their respective Wikidata urls from To Do to Doing on the Multimedia-Current-Work board.
Mon, Jul 8, 9:48 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
egardner added a comment to T227230: Link statement labels with their respective Wikidata urls.

There are two tasks here, and it may be good to separate them.

Mon, Jul 8, 8:08 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Wed, Jul 3

egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

@Aklapper part of this issue has been resolved with the merger of this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/512435. That took care of the problem where the entire Captions panel remained stuck on the left side when it should flip along with the text orientation (LTR or RTL).

Wed, Jul 3, 8:24 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work

Jun 10 2019

egardner moved T224040: Qualifier properties should chosen via autosuggest instead of a dropdown from Doing to Code Review on the Multimedia-Current-Work board.
Jun 10 2019, 3:58 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia

May 30 2019

egardner added a comment to T215644: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs).

Per our design/dev conversation today, I can take a stab at a "spike" patch to enable frameless tabs and see how it works on the file page. This could happen once work related to Other Statements is out of the way (so maybe in 1-2 weeks from now). If we are happy with how this works we could push to Beta or Test Commons and get some wider user feedback.

May 30 2019, 4:54 PM · Multimedia-Current-Work, OOUI (OOUI-0.32.0), SDC Design, Multimedia
egardner added a comment to T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.

@Cparle and @matthiasmullie there are two stages to this process if I understand correctly – let me know if I'm really off the rails here.

May 30 2019, 3:04 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T224040: Qualifier properties should chosen via autosuggest instead of a dropdown from To Do to Doing on the Multimedia-Current-Work board.
May 30 2019, 2:33 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
Restricted Application added a project to T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind: Multimedia.
May 30 2019, 12:45 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner claimed T224624: Quantity qualifier value box is not visible on smartphones.
May 30 2019, 12:29 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
egardner claimed T224625: On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element.
May 30 2019, 12:29 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a comment to T224625: On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element.

I can look at this in the next couple of days, I'm poking around in Qualifier widget stuff anyway.

May 30 2019, 12:29 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia

May 29 2019

egardner added a comment to T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.

Ah, ok, thanks for the clarification.

May 29 2019, 7:45 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a comment to T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.

Are we sure that we want an auto-suggest UI for the data type selection? I imagine that many users will not be familiar with the Wikibase data-types in advance – typing in an autocomplete widget might feel like taking a shot in the dark when they don't really know what they are looking for. Also, if there are only a small number of data types for them to choose between, being able to see all the available types in a dropdown menu may be useful. Will there eventually be lots and lots of options available here? Even if we supported every data type currently listed here, there are only 17 currently, which is still potentially within the limit of what someone could select from an options list.

May 29 2019, 6:33 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia

May 28 2019

egardner closed T224519: Non-depicts statements treated as unsupported on subsequent page visits as Declined.
May 28 2019, 8:22 PM · SDC-Statements (Other-statements-running), Multimedia-Current-Work, Multimedia
egardner updated subscribers of T224519: Non-depicts statements treated as unsupported on subsequent page visits.

Whoops, just saw that @Cparle has already created a ticket for this at T224461 – closing this in favor of that one.

May 28 2019, 8:22 PM · SDC-Statements (Other-statements-running), Multimedia-Current-Work, Multimedia
Restricted Application added a project to T224519: Non-depicts statements treated as unsupported on subsequent page visits: Multimedia.
May 28 2019, 8:09 PM · SDC-Statements (Other-statements-running), Multimedia-Current-Work, Multimedia
Restricted Application added a project to T224498: Add dedicated "remove" controls to the "Add Statement" input: Multimedia.
May 28 2019, 4:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Multimedia, SDC-Statements (Other-statements-running), Multimedia-Current-Work

May 24 2019

egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

I think that there is something to be said for the visual tidiness of this approach, and that using a consistent placement of label elements might allow users to figure out what is going on here more quickly. I find this approach to be more intuitive, personally.

May 24 2019, 10:20 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner moved T222867: Captions Panel alignment and overlapping issues in RTL languages from To Do to Doing on the Multimedia-Current-Work board.
May 24 2019, 9:21 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Here is a follow-up question about the layout of the Captions panel contents themselves, when both RTL and LTR languages are present.

May 24 2019, 9:17 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Thanks @matthiasmullie for putting me on the right track. I was able to do exactly what you suggested to prepend the captions HTML to the rest of the tab1 contents, so that it comes before #mw-imagepage-content and #mw-parser-output. As far as I can tell, that solves the initial problem here – the Captions panel is now correctly oriented in an RTL page. Here's what it looks like in my local dev environment:

May 24 2019, 8:56 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

I'm willing to give that a try and see what the results are locally. Would pulling Captions out of the content block mean that it no longer gets included in the parser cache?

May 24 2019, 3:37 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

This is running in a local development environment on my machine. I just switched the language to Hebrew using the menu at the top of the page. But adding “uselang=he” to the URL creates the same results. Haven’t been looking at debug mode yet.

May 24 2019, 2:43 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work

May 23 2019

egardner updated subscribers of T222867: Captions Panel alignment and overlapping issues in RTL languages .

There is a lot I don't know about the way that Mediawiki handles RTL language mode. It seems like the first problem here – the fact that the Captions panel remains aligned to the left side of the screen, even when most other things align to the right – is visible even when Javascript is disabled:

May 23 2019, 11:20 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work

May 22 2019

egardner moved T222361: UploadWizard should indicate that statements are being submitted from Doing to Code Review on the Multimedia-Current-Work board.
May 22 2019, 7:36 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner claimed T222361: UploadWizard should indicate that statements are being submitted.
May 22 2019, 7:36 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner moved T221732: Visually indicate to users that they can't add/edit captions/structured data to protected files from Code Review to To Do on the Multimedia-Current-Work board.
May 22 2019, 7:35 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner reassigned T221732: Visually indicate to users that they can't add/edit captions/structured data to protected files from egardner to PDrouin-WMF.
May 22 2019, 7:35 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner claimed T221732: Visually indicate to users that they can't add/edit captions/structured data to protected files.
May 22 2019, 7:34 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner moved T221732: Visually indicate to users that they can't add/edit captions/structured data to protected files from To Do to Code Review on the Multimedia-Current-Work board.
May 22 2019, 7:34 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner added a comment to T222361: UploadWizard should indicate that statements are being submitted.

Right now I'm just centering it horizontally and vertically on top of the form.

May 22 2019, 4:03 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner moved T222361: UploadWizard should indicate that statements are being submitted from To Do to Doing on the Multimedia-Current-Work board.
May 22 2019, 4:02 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner added a comment to T222361: UploadWizard should indicate that statements are being submitted.

Hey @PDrouin-WMF: I spent some time poking around in UW yesterday. I'm afraid that the solution you proposed above (placing a spinner to the right as in previous steps) is not feasible for the "Add Data" screen. That's because this step can accommodate multiple files at once, in which case there is a "booklet" layout (you can click which image you want to add details to on the left-hand submenu, and the right-hand area is filled with information about that file).

May 22 2019, 3:55 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering

May 21 2019

egardner moved T221861: Structured Data table overflows when wikidata label is too long from To Do to Doing on the Multimedia-Current-Work board.
May 21 2019, 3:06 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons

May 20 2019

egardner added a comment to T221861: Structured Data table overflows when wikidata label is too long.

I'm pretty sure that some of the recent mobile-related patches we have merged on master will fix this once we deploy a new release.

May 20 2019, 7:15 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons

May 17 2019

egardner moved T223655: Wikidata icon doesn't align with property link in statements widget when secondary statement label is present from To Do to Code Review on the Multimedia-Current-Work board.
May 17 2019, 6:50 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner created T223655: Wikidata icon doesn't align with property link in statements widget when secondary statement label is present.
May 17 2019, 6:38 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner added a comment to T222361: UploadWizard should indicate that statements are being submitted.

@PDrouin-WMF I can take a stab at this if using the already-existing spinner element is ok. Haven't done much in the UW codebase yet, this would be a good excuse to dig a bit deeper.

May 17 2019, 6:07 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner updated subscribers of T223432: Captions mobile improvements.

Ok, I've updated the patch to make footer behavior consistent between the panels. The footer buttons share a row when there is sufficient space, but stack otherwise. Here's what that looks like now:

May 17 2019, 2:49 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering

May 16 2019

egardner moved T223432: Captions mobile improvements from Doing to Code Review on the Multimedia-Current-Work board.
May 16 2019, 10:42 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner moved T223432: Captions mobile improvements from To Do to Doing on the Multimedia-Current-Work board.
May 16 2019, 10:42 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner added a comment to T223432: Captions mobile improvements.

Basic patch for this is up. Here's what the Captions panel looks like now at various sizes & states:

May 16 2019, 10:41 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner added a comment to T223432: Captions mobile improvements.

I think that this is doable with some flexbox tweaking, but the trash-can button will probably need to be appended to the .wbmi-entityview-caption div, as opposed to the child .wbmi-caption-value div as it is now. That would allow you to achieve this:

May 16 2019, 10:03 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner claimed T223432: Captions mobile improvements.
May 16 2019, 9:43 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner updated subscribers of T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

@Ramsey-WMF was able to grant increased privileges on Beta Commons to the fake user account we are using here, which gets around the Abuse Filter problem for testing logged-in edits. Anonymous edits will still be thwarted by that filter.

May 16 2019, 8:24 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner moved T219815: Create integration tests to cover potential issues with editing and uploading on Commons from Doing to Code Review on the Multimedia-Current-Work board.
May 16 2019, 8:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner added a comment to T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

One additional issue here:

May 16 2019, 12:04 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

May 15 2019

egardner claimed T219815: Create integration tests to cover potential issues with editing and uploading on Commons.
May 15 2019, 10:48 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner moved T219815: Create integration tests to cover potential issues with editing and uploading on Commons from Blocked to Doing on the Multimedia-Current-Work board.
May 15 2019, 10:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner added a comment to T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

Update to the above – I've re-worked this patch to focus on testing against beta-commons; everything that would run in the normal CI process (tests in the Selenium "specs" folder, for instance), has been moved into a beta-commons-specific folder instead. This should mean that the patch is safe to merge.

May 15 2019, 8:29 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

May 14 2019

egardner updated subscribers of T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

I'm trying to determine if this task is still blocked or not. Our attempts to get some Selenium tests working have faced a couple of problems, but several of them seem to have been fixed:

May 14 2019, 8:45 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

May 1 2019

egardner closed T221778: Update MediaInfo README with more information about how to set up locally as Resolved.
May 1 2019, 12:42 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner closed T221778: Update MediaInfo README with more information about how to set up locally, a subtask of T221480: Update README files with latest configuration instructions, as Resolved.
May 1 2019, 12:42 AM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner moved T221674: On mobile skin, Captions/Statements panel should fill container from Code Review to Needs QA on the Multimedia-Current-Work board.
May 1 2019, 12:42 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner closed T221480: Update README files with latest configuration instructions as Resolved.
May 1 2019, 12:42 AM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work

Apr 30 2019

egardner added a comment to T218951: Make button placement for Captions consistent with Depicts/statements.

Do you mean the P# for depicts, or the Q# for the individual statements? I moved the depicts number over with its label in attempt to consolidate things and save space. They could also be stacked on top of one another, which I think was what you originally had in your mock-up.

Apr 30 2019, 9:43 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner claimed T218951: Make button placement for Captions consistent with Depicts/statements.
Apr 30 2019, 7:52 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T218951: Make button placement for Captions consistent with Depicts/statements from To Do to Code Review on the Multimedia-Current-Work board.
Apr 30 2019, 7:51 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T221228: Depicts widget has a couple of visual quirks on mobile/small screens from Doing to Code Review on the Multimedia-Current-Work board.
Apr 30 2019, 7:51 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner moved T221658: Poor/non-functional experience on mobile [Epic] from Blocked to Doing on the Multimedia-Current-Work board.
Apr 30 2019, 7:51 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner added a comment to T218951: Make button placement for Captions consistent with Depicts/statements.

Hey @PDrouin-WMF, how does this look – it's mostly what we talked about with some small adjustments:

Apr 30 2019, 6:57 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T221480: Update README files with latest configuration instructions from Doing to Code Review on the Multimedia-Current-Work board.
Apr 30 2019, 4:04 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner claimed T221480: Update README files with latest configuration instructions.
Apr 30 2019, 4:03 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work

Apr 25 2019

egardner added a comment to T221658: Poor/non-functional experience on mobile [Epic].
Apr 25 2019, 9:29 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work

Apr 24 2019

egardner claimed T221778: Update MediaInfo README with more information about how to set up locally.
Apr 24 2019, 4:38 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner closed T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment) as Resolved.
Apr 24 2019, 4:33 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner added a comment to T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).

Thanks for clarifying. I've added some info around this in the README for the related ticket at T221480, closing this one.

Apr 24 2019, 4:33 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner moved T221480: Update README files with latest configuration instructions from To Do to Doing on the Multimedia-Current-Work board.
Apr 24 2019, 4:32 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner moved T221778: Update MediaInfo README with more information about how to set up locally from To Do to Code Review on the Multimedia-Current-Work board.
Apr 24 2019, 4:32 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T221778: Update MediaInfo README with more information about how to set up locally.

Here's a related question – what are the type requirements for valid qualifiers if the user is creating them locally?

Apr 24 2019, 3:05 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T221778: Update MediaInfo README with more information about how to set up locally.

Tangentially related to T221717

Apr 24 2019, 2:47 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner created T221778: Update MediaInfo README with more information about how to set up locally.
Apr 24 2019, 2:45 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).

That works, thanks – I thought my problem was with the Entity types for some reason, not the type of the depicts Property.
Incidentally, the distinction between Property: type property (what I had defaulted to) and Property: type item is not very clear to me at all.

Apr 24 2019, 2:37 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work

Apr 23 2019

egardner added a comment to T218951: Make button placement for Captions consistent with Depicts/statements.

I think that this issue can be addressed as part of T221658 and T221228. The fact that the Captions panel separates the label (top of panel) from the cancel/publish controls (bottom of panel) means the layout functions better on small screens. On the Statement Panel, the panel label and the controls widget both exist in the top region of the panel, and on small screens they collide.

Apr 23 2019, 11:31 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a parent task for T218951: Make button placement for Captions consistent with Depicts/statements: T221228: Depicts widget has a couple of visual quirks on mobile/small screens.
Apr 23 2019, 11:27 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a subtask for T221228: Depicts widget has a couple of visual quirks on mobile/small screens: T218951: Make button placement for Captions consistent with Depicts/statements.
Apr 23 2019, 11:27 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner added a parent task for T218951: Make button placement for Captions consistent with Depicts/statements: T221658: Poor/non-functional experience on mobile [Epic].
Apr 23 2019, 11:26 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a subtask for T221658: Poor/non-functional experience on mobile [Epic]: T218951: Make button placement for Captions consistent with Depicts/statements.
Apr 23 2019, 11:26 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner moved T221228: Depicts widget has a couple of visual quirks on mobile/small screens from To Do to Doing on the Multimedia-Current-Work board.
Apr 23 2019, 11:25 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner added a project to T221228: Depicts widget has a couple of visual quirks on mobile/small screens: Multimedia-Current-Work.
Apr 23 2019, 11:24 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner added a comment to T221678: Statements auto-complete does not work on mobile skin.

Looks like this is a CORS error: when I attempt to add statements in mobile view on production, I get this error in the JS console:

Apr 23 2019, 10:52 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner moved T221674: On mobile skin, Captions/Statements panel should fill container from Doing to Code Review on the Multimedia-Current-Work board.
Apr 23 2019, 10:35 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner renamed T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment) from "Unexpected entity type item" error when attempting to add Depicts statement on Filepage to "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).
Apr 23 2019, 9:22 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner created T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).
Apr 23 2019, 9:22 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner moved T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic] from Blocked to Doing on the Multimedia-Current-Work board.
Apr 23 2019, 8:57 PM · SDC Engineering, Multimedia, Multimedia-Current-Work
egardner renamed T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic] from Add JS Unit tests to safeguard Filepage UI happy-paths to Add JS Unit tests to safeguard Filepage UI happy-paths [Epic].
Apr 23 2019, 8:57 PM · SDC Engineering, Multimedia, Multimedia-Current-Work