Thu, Jun 17
Mon, Jun 14
Note that links cannot be list items at the same time though (an element can only have one role)
Fri, Jun 11
@mwilliams Adding the assessment filter to all tabs should be simple. There may be more searches that come back without results in these tabs but I don't see that as a problem.
Thu, Jun 10
I've created a dedicated task for some of the typing improvements I mentioned above here: T284782
Based on the stack trace, this looks to be related to the new OGV.js shim we started using; it's something related to TimedMediaHandler or VideoJS most likely.
Wed, Jun 9
Is this task still necessary if we can adopt a front-end build step that supports tree-shaking? In that case, consuming applications would just run the build step to ensure that only relevant components get included in their respective payloads.
@Krinkle both work-arounds you mention (using a wrapper file and limiting the change to packageFiles) sound workable to me. My motivation here is to ensure that any bundled modules we generate with newer build tools (Rollup/Vite/etc) are usable in ResourceLoader without too much additional effort. Existing 3rd-party libraries can continue to be handled the way they are now.
Tue, Jun 8
It seems clear that we want to use Typescript as we move forward with a shared component library. But there is still the question of the best way to use Typescript.
Mon, Jun 7
A couple of thoughts on what this could contain:
Fri, Jun 4
Thu, Jun 3
Wed, Jun 2
Tue, Jun 1
Thu, May 27
Wed, May 26
Quick update on this: I've opened a patch that ports WVUI over to Rollup for builds. So far here's what's working:
Tue, May 25
@thcipriani that's correct – I just need access to do the occasional backport and config deploy, I wasn't sure what the exact name for that group was supposed to be. Thanks!
Mon, May 24
It's going to be some time before we are able to re-write the front-end of this extension to remove all OOUI dependencies; this may happen if we port it over to a new WMF component library at some point. Closing for now.
@Etonkovidova – that is the correct param, but the patch was updated to include some config variables that likely need to be set on Beta and Production commons before this feature will work. I'll see about making sure this happens some time soon.
May 14 2021
May 10 2021
Updated some docs on https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/VideoJS_Player#Usage so that others can more easily integrate Video.js and Ogv.js the same way.
Bumping this task to the main team board. @brion do you know anything about IE support for various video formats?
Current status on Beta commons:
This will need some testing in production (or Beta) once the new MediaSearch extension is enabled and publicly visible (may not happen for another week or two).
May 7 2021
May 6 2021
Ok, success! I'll upload a patch shortly. For posterity, the problem was that some extra configuration is needed to get the modules for videojs and ogvjs working together. The complete player initialization code looks like this:
Pretty sure this error is the result of some unsupported gadget or user script. I am unable to repro locally.
May 5 2021
@Etonkovidova this patch (like most patches going forward) was applied to the stand-alone MediaSearch extension version of this code – as opposed to the code that lives inside of WikibaseMediaInfo.
@Krinkle fair enough – I agree that ResourceLoader currently gives us most of the benefits that <script type="module"> would already, with greater backwards-compatibility. However, I do think it's good to keep an eye on the evolving state of the web here. There may be a time when we want to do less of this work ourselves and rely more on built-in browser functionality.
May 4 2021
Invalid search queries and bad type params have been addressed at this point. I'll open a separate patch to try and deal with bad values for search filters.
May 3 2021
Apr 29 2021
@MarkTraceur, @dr0ptp4kt, and I chatted today about trying to unblock this task. I'm going to spend some time on a spike to see if I can apply the OGVJS shim to the "beta" VideoJs player that we are using in order to support OGG/WEBP playback in Desktop Safari in the same manner that we're currently doing for the legacy video player used on Commons File pages.
Apr 28 2021
Mentioned this at today's Front-End Standards Group meeting, but I think this problem would be a good candidate for the new Technical Decision Making Process because it cuts across the concerns of several different teams. This process already includes a framework for evaluating different possible solutions (including the "solution" of leaving the current status quo in place).