Page MenuHomePhabricator

egardner (Eric Gardner)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (62 w, 1 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Yesterday

egardner moved T245769: [L] Add ability for CAT/Suggested Tags users to add additional tags (depicts statements) from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Apr 3, 8:29 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Structured-Data-Backlog (Current Work), MachineVision, SDC-Statements (Machine-vision-depicts), Structured Data Engineering, Structured-Data-Design
egardner moved T249270: Update CAT/SuggestedTags logic to prioritize assessed (featured/quality/valued) images explicitly from Doing to Ready for Development on the Structured-Data-Backlog (Current Work) board.
Fri, Apr 3, 8:28 PM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog, Structured Data Engineering, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog (Current Work)

Thu, Apr 2

egardner added a comment to T249133: Update LabelResolver class to gather the description and aliases.

One other thing about this patch – this is a breaking API change so we'll need to make sure the Android team knows about this and has time to prepare a patch for compatibility before we merge. @Ramsey-WMF or @CBogen can you ensure that they get a heads up about this? We don't version our APIs in the traditional way here as far as I understand, but is there anything else we need to do before changing the response of a public endpoint in the way we're considering here?

Thu, Apr 2, 10:45 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)
egardner placed T249270: Update CAT/SuggestedTags logic to prioritize assessed (featured/quality/valued) images explicitly up for grabs.
Thu, Apr 2, 9:55 PM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog, Structured Data Engineering, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog (Current Work)
egardner moved T249270: Update CAT/SuggestedTags logic to prioritize assessed (featured/quality/valued) images explicitly from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
Thu, Apr 2, 9:43 PM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog, Structured Data Engineering, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog (Current Work)
egardner claimed T249270: Update CAT/SuggestedTags logic to prioritize assessed (featured/quality/valued) images explicitly.
Thu, Apr 2, 9:43 PM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog, Structured Data Engineering, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog (Current Work)
egardner added a comment to T249270: Update CAT/SuggestedTags logic to prioritize assessed (featured/quality/valued) images explicitly.

I'm willing to take a stab at the "simple" implementation here, but will probably need some code review assistance again.

Thu, Apr 2, 9:43 PM · Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, Wikipedia-Android-App-Backlog, Structured Data Engineering, SDC-Statements (Machine-vision-depicts), Structured-Data-Backlog (Current Work)
egardner moved T249133: Update LabelResolver class to gather the description and aliases from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Apr 2, 9:37 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)
egardner updated subscribers of T249133: Update LabelResolver class to gather the description and aliases.

It looks like labels and descriptions could be handled the same way in terms of language fallback chains, but aliases might need to be treated differently – namely, just don't display them at all if we can't find one for the current language. @Ramsey-WMF does that sound right to you?

Thu, Apr 2, 8:50 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)
egardner moved T249133: Update LabelResolver class to gather the description and aliases from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
Thu, Apr 2, 4:25 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)

Wed, Apr 1

egardner claimed T249133: Update LabelResolver class to gather the description and aliases.
Wed, Apr 1, 4:50 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)
egardner added a comment to T249133: Update LabelResolver class to gather the description and aliases.

I'm willing to take a stab at this, as it should be pretty straightforward and I'd like to learn more about how to work with API endpoints in MediaWiki PHP. @Mholloway would it be okay to add you as a reviewer to any patches I submit here?

Wed, Apr 1, 4:29 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)

Tue, Mar 31

egardner updated subscribers of T245023: [L] Add UI elements with the description for better differentiation of suggested tags for identical labels.

The new designs will require some additional data (mainly: descriptions/aliases for each tag being displayed). We've also just added the ability to display the categories a File belongs to, which required a new API request from the client.

Tue, Mar 31, 9:48 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Design, MachineVision
egardner added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

That screenshot is showing incorrect behavior at the Qualifier level. Just uploaded a 1-line patch which should address that by simply wrapping the qualifier value in <bdi> tags, like we do for Items. Let's get this on Beta quickly and check the same file again.

Tue, Mar 31, 4:22 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

So I think things are working fine at the level of the ItemWidget. Here's the markup for Item labels as currently deployed on production:

Tue, Mar 31, 1:44 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner claimed T246797: Structured Data on Commons: RTL support for geographical co-ordinates.
Tue, Mar 31, 1:25 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner moved T247577: [XS] Visual design adjustments for CAT from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Tue, Mar 31, 1:24 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work)

Fri, Mar 27

Ash_Crow awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Pterodactyl token.
Fri, Mar 27, 5:48 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Thu, Mar 26

egardner updated subscribers of T248322: Improved bundling of SuggestedTags/CAT notifications..

It seems like the problem is that Echo doesn't really have a way to know that multiple events generated on the server at different times (as part of a job queue, for example) should be consolidated.

Thu, Mar 26, 8:38 PM · Structured Data Engineering, Structured-Data-Backlog (Current Work)

Wed, Mar 25

AnneT awarded T248405: [Spike] explore porting MachineVision front-end to Vue.js a Party Time token.
Wed, Mar 25, 4:55 PM · Vue.js, MachineVision, Structured-Data-Backlog (Current Work)

Tue, Mar 24

egardner added a comment to T248408: Create a 'vuejs' tag for Vue.js work.

I think a tag is good for now; later on we can organize things into projects as needed. It will be helpful to have a window into Vue-related development happening across teams.

Tue, Mar 24, 7:20 PM · Project-Admins
egardner updated subscribers of T248405: [Spike] explore porting MachineVision front-end to Vue.js.

@Catrope This is not urgent, but it would be nice to have a resource module for Vuex in core that works similar to the one for Vue itself. Right now I'm including the Vuex code in a vendor subfolder but other projects will presumably need to use this soon as well.

Tue, Mar 24, 6:12 PM · Vue.js, MachineVision, Structured-Data-Backlog (Current Work)
egardner moved T248405: [Spike] explore porting MachineVision front-end to Vue.js from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
Tue, Mar 24, 6:07 PM · Vue.js, MachineVision, Structured-Data-Backlog (Current Work)
egardner created T248405: [Spike] explore porting MachineVision front-end to Vue.js.
Tue, Mar 24, 6:07 PM · Vue.js, MachineVision, Structured-Data-Backlog (Current Work)
egardner moved T228947: [M] Add a "pending" state to QualifierWidget read-mode from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Mar 24, 3:16 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work

Thu, Mar 19

Peb awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Thu, Mar 19, 9:07 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Pablo-WMDE awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Orange Medal token.
Thu, Mar 19, 8:49 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Wed, Mar 18

egardner moved T228947: [M] Add a "pending" state to QualifierWidget read-mode from Ready for Estimation to Doing on the Structured-Data-Backlog (Current Work) board.
Wed, Mar 18, 4:54 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work

Thu, Mar 12

egardner moved T233052: Improve handling of invalid qualifiers from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Mar 12, 3:50 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (UI-consolidation-on-a-Ferris-wheel)

Wed, Mar 11

egardner moved T233052: Improve handling of invalid qualifiers from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Wed, Mar 11, 10:29 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (UI-consolidation-on-a-Ferris-wheel)
egardner added a comment to T233052: Improve handling of invalid qualifiers .

@Ramsey-WMF just posted a new patch for this. Here's the new behavior if the user tries to change a previously-valid qualifier to an invalid one:

Wed, Mar 11, 10:29 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (UI-consolidation-on-a-Ferris-wheel)
egardner claimed T233052: Improve handling of invalid qualifiers .
Wed, Mar 11, 9:25 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (UI-consolidation-on-a-Ferris-wheel)
egardner moved T242667: Reduce flash of empty page and hoisted footer when loading Special:SuggestedTags (FOUC) from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Mar 11, 2:55 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured-Data-Backlog (Current Work), SDC-Statements (Machine-vision-depicts), Performance-Team (Radar), MachineVision

Tue, Mar 10

egardner moved T246797: Structured Data on Commons: RTL support for geographical co-ordinates from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Tue, Mar 10, 11:36 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner moved T246797: Structured Data on Commons: RTL support for geographical co-ordinates from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Mar 10, 7:00 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

Here's the updated coordinate input in Hebrew:

Tue, Mar 10, 6:59 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner moved T246797: Structured Data on Commons: RTL support for geographical co-ordinates from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
Tue, Mar 10, 5:05 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

I believe that this is a matter of hard-coding the dir=ltr attribute (or doing the equivalent in CSS) on the actual coordinate input & display elements – the idea is that we don't want the letters/numbers getting shuffled around in lat/lng strings because then they become nonsensical, even when the rest of the text needs to change.

Tue, Mar 10, 4:17 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering
egardner claimed T246797: Structured Data on Commons: RTL support for geographical co-ordinates.
Tue, Mar 10, 4:10 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, I18n, Structured Data Engineering

Mon, Mar 9

eranroz awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Mon, Mar 9, 10:39 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Sat, Mar 7

egardner moved T247044: 'Add qualifier' field displays 'Unsupported data type' default text from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Sat, Mar 7, 2:29 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured Data Engineering, Structured-Data-Backlog (Current Work)
egardner created T247150: [BetaCommons] Structured Data added by anonymous users not displaying properly.
Sat, Mar 7, 1:18 AM · Structured-Data-Backlog

Fri, Mar 6

egardner added a comment to T247044: 'Add qualifier' field displays 'Unsupported data type' default text.

This looks like a situation where we need to apply a different label (or simply show no label at all) in the second disabled field before the user has specified a property in the first field. I propose we handle this situation like so:

Fri, Mar 6, 8:15 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Structured Data Engineering, Structured-Data-Backlog (Current Work)

Feb 28 2020

egardner added a subtask for T227116: Enhanced support for geo-coordinate Wikibase datatype: T245992: "Select on map" button shows up for geo-coordinates when I don't have kartographer provisioned.
Feb 28 2020, 7:48 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a parent task for T245992: "Select on map" button shows up for geo-coordinates when I don't have kartographer provisioned: T227116: Enhanced support for geo-coordinate Wikibase datatype.
Feb 28 2020, 7:48 PM · Structured-Data-Backlog (Current Work), WikibaseMediaInfo
egardner moved T239474: [M] Units support for quantity datatype from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Feb 28 2020, 7:47 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
egardner moved T231996: [M] Add support for 'monolingual text' data type (top-level and qualifiers) from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Feb 28 2020, 7:46 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
egardner moved T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Feb 28 2020, 7:46 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering

Feb 27 2020

egardner moved T227116: Enhanced support for geo-coordinate Wikibase datatype from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Feb 27 2020, 10:56 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
Pablo-WMDE awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Grey Medal token.
Feb 27 2020, 3:20 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
egardner added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I stepped away from this discussion for a moment, but I wanted to say thanks to everyone for all the thoughtful contributions. And a special thanks to @EvanYou for engaging with us here, it's really great to have his perspective as the creator of the framework under discussion! Thanks for sharing some information about how the Vue team is managing the introduction of new features and project sustainability.

Feb 27 2020, 2:13 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Feb 25 2020

egardner added a comment to T245992: "Select on map" button shows up for geo-coordinates when I don't have kartographer provisioned.

This should be addressed by this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/574603

Feb 25 2020, 12:05 AM · Structured-Data-Backlog (Current Work), WikibaseMediaInfo

Feb 22 2020

egardner added a comment to T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers.

Just submitted a patch that removes the "primary" class from the "Add" button in the String, Quantity, and GlobeCoordinate input widgets. Here's an example of how it looks just as a "progressive" button, in a QuantityInputWidget:

Feb 22 2020, 3:20 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering

Feb 13 2020

Mvolz awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Party Time token.
Feb 13 2020, 10:55 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Feb 5 2020

WMDE-leszek awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Mountain of Wealth token.
Feb 5 2020, 5:28 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 24 2020

egardner added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

@AronManning I think a tool like MMV is exactly the kind of thing that could really benefit from a Vue.js re-write. The UploadWizard tool is another.

Jan 24 2020, 7:21 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 23 2020

egardner added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

We will definitely need to study any possible performance impacts from using the template compiler at runtime. If it turns out that relying on the compiler at runtime causes significant perf regressions then we will need to come up with another solution (and re-open some points in this discussion).

Jan 23 2020, 8:51 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
egardner added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

@dbarratt regarding need for a build step: there's some discussion of this in the original RFC; it's true that React can be used sans build-step with the CreateElement API.

Jan 23 2020, 4:56 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 22 2020

egardner added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I wanted to join in this discussion earlier, but I spent the last two weeks fighting off the flu. Thanks to everyone who has participated so far, it's great to see interest in this topic. I'd like to try and speak to a few points that have been raised so far. I'll paraphrase some of the questions I've seen upthread:

Jan 22 2020, 1:57 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 21 2020

egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

Thanks for the feedback about real-world use-cases here, it's useful.

Jan 21 2020, 7:39 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 20 2020

Osnard awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Party Time token.
Jan 20 2020, 7:37 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 17 2020

Addshore awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Party Time token.
Jan 17 2020, 9:43 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Jakob_WMDE awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Jan 17 2020, 9:42 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 13 2020

Demian awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Jan 13 2020, 8:23 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Demian awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Orange Medal token.
Jan 13 2020, 7:59 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 9 2020

egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

@AnneT this was bugging me a little bit too. The problem is that ItemWidgets appear directly beneath their statement input widget in all other cases. If the map is part of the ItemWidget, it will appear flush with the input (leading to confusion about which map relates to which element).

Jan 9 2020, 8:02 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T224890: [S] Depicts: uploading multiple images issue.

One thing we should keep in mind is how the proposed changes here would impact the "copy to all" functionality.

Jan 9 2020, 3:19 PM · Patch-For-Review, SDC-Statements (UI-consolidation-on-a-Ferris-wheel), Structured-Data-Design, Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC Design
egardner moved T227116: Enhanced support for geo-coordinate Wikibase datatype from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 9 2020, 3:12 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

@kchapman I assume that after Last Call, there is some kind of official vote on whether or not to adopt a given proposal – is this correct?

Jan 9 2020, 3:00 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 8 2020

egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

Here are some new screenshots representing the approach described above:

Jan 8 2020, 7:42 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

In that case, I think the best way forward would be to introduce this functionality in a new patch that builds on top of the two previous ones. I can start on that tomorrow.

Jan 8 2020, 12:08 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 7 2020

egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

Right now I can think of two ways to try to support the use-case you are describing (make it easier for the user to visually see previously-entered coordinates on a map):

Jan 7 2020, 11:34 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

@Ramsey-WMF we don't currently support a lot of edit-in-place functionality anywhere in the SDC UI – users are encouraged to just add new values or delete old ones. Compare with cases where a string or URL field is entered – if a user sees a typo in a URL, they can't just edit that value; they need to delete the old one and add a new one. I think that this is all a legacy around the initial designs assuming item-types and dropdown inputs everywhere. (Qualifiers do allow edit-in-place functionality however – so we are inconsistent in our inconsistencies).

Jan 7 2020, 11:19 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

Ok, I've updated the design a bit of the expanded/collapsed map. Here are some new screenshots:

Jan 7 2020, 10:32 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
gabriel-wmde awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Jan 7 2020, 4:05 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

I'm in agreement with @matthiasmullie that the map is very prominent by default, probably too much so. It will also cause a bunch of image tiles to be loaded which is a consideration for bandwidth.

Jan 7 2020, 3:52 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
awight awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Barnstar token.
Jan 7 2020, 8:39 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

@Ramsey-WMF if you want, we can merge the first patch (that enables the map feature at all) and then wait to merge the second one (which hides it by default and consolidates the input fields to a single row), adding further tweaks if necessary.

Jan 7 2020, 12:13 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 6 2020

egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

@Ramsey-WMF the map itself works OK on mobile, but we could probably stack the compact row elements a little more nicely. I'll take a stab at that next.

Jan 6 2020, 10:33 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner added a comment to T240878: Echo email notifications not bundling properly.

Hi @SBisson, I agree that this would be a useful feature. I'm happy to turn this ticket into a formal request (not sure if there are any tags that I should add for that).

Jan 6 2020, 9:37 PM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision
egardner added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

There are currently two patches which are ready or near-ready that address this issue. Currently the UX for "enhanced" coordinate input looks like this:

Jan 6 2020, 9:08 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 2 2020

alexhollender awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Yellow Medal token.
Jan 2 2020, 2:49 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
abi_ awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Jan 2 2020, 7:00 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Dec 30 2019

Jan_Dittrich awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Dec 30 2019, 8:14 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Dec 20 2019

MSantos awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Dec 20 2019, 9:13 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
nray awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Dec 20 2019, 6:24 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
AnneT awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Dec 20 2019, 5:19 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Masumrezarock100 awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Dec 20 2019, 4:12 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
kchapman awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Dec 20 2019, 2:27 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Ladsgroup awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Dec 20 2019, 11:37 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Tonina_Zhelyazkova_WMDE awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Love token.
Dec 20 2019, 9:35 AM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Dec 19 2019

Niedzielski awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Party Time token.
Dec 19 2019, 10:47 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
egardner created T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.
Dec 19 2019, 10:41 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Dec 18 2019

egardner added a comment to T240878: Echo email notifications not bundling properly.

Don't worry, nothing is obvious as far as I'm concerned. This is my first attempt using Echo (most of my work is on the JS side).

Dec 18 2019, 10:07 PM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision

Dec 17 2019

egardner added a comment to T240878: Echo email notifications not bundling properly.

In the short term, we may disable the email notifications entirely – it's likely that very few users have opted-in to this in the first place.

Dec 17 2019, 5:08 PM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision
egardner added a project to T240878: Echo email notifications not bundling properly: Notifications.
Dec 17 2019, 1:15 AM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision
egardner moved T227116: Enhanced support for geo-coordinate Wikibase datatype from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Dec 17 2019, 1:08 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Structured-Data-Backlog (Current Work), Structured Data Engineering
egardner moved T240878: Echo email notifications not bundling properly from Doing to Blocked on the Structured-Data-Backlog (Current Work) board.
Dec 17 2019, 1:08 AM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision
egardner updated subscribers of T240878: Echo email notifications not bundling properly.

@Ramsey-WMF I'm able to reproduce this locally, but I don't understand why email notifications are not bundling; I've followed the instructions in the Echo docs but I must be missing something. I'm pinging the Notifications project and @Catrope in the hope that they can shed some light.

Dec 17 2019, 1:07 AM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision
egardner updated the task description for T240878: Echo email notifications not bundling properly.
Dec 17 2019, 1:06 AM · Structured-Data-Backlog, Growth-Team, Notifications, MachineVision