Page MenuHomePhabricator

egardner (Eric Gardner)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (17 w, 2 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Fri, May 24

egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

I think that there is something to be said for the visual tidiness of this approach, and that using a consistent placement of label elements might allow users to figure out what is going on here more quickly. I find this approach to be more intuitive, personally.

Fri, May 24, 10:20 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner moved T222867: Captions Panel alignment and overlapping issues in RTL languages from To Do to Doing on the Multimedia-Current-Work board.
Fri, May 24, 9:21 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Here is a follow-up question about the layout of the Captions panel contents themselves, when both RTL and LTR languages are present.

Fri, May 24, 9:17 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Thanks @matthiasmullie for putting me on the right track. I was able to do exactly what you suggested to prepend the captions HTML to the rest of the tab1 contents, so that it comes before #mw-imagepage-content and #mw-parser-output. As far as I can tell, that solves the initial problem here – the Captions panel is now correctly oriented in an RTL page. Here's what it looks like in my local dev environment:

Fri, May 24, 8:56 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

I'm willing to give that a try and see what the results are locally. Would pulling Captions out of the content block mean that it no longer gets included in the parser cache?

Fri, May 24, 3:37 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
egardner added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

This is running in a local development environment on my machine. I just switched the language to Hebrew using the menu at the top of the page. But adding “uselang=he” to the URL creates the same results. Haven’t been looking at debug mode yet.

Fri, May 24, 2:43 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work

Thu, May 23

egardner updated subscribers of T222867: Captions Panel alignment and overlapping issues in RTL languages .

There is a lot I don't know about the way that Mediawiki handles RTL language mode. It seems like the first problem here – the fact that the Captions panel remains aligned to the left side of the screen, even when most other things align to the right – is visible even when Javascript is disabled:

Thu, May 23, 11:20 PM · Patch-For-Review, SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work

Wed, May 22

egardner moved T222361: UploadWizard should indicate that statements are being submitted from Doing to Code Review on the Multimedia-Current-Work board.
Wed, May 22, 7:36 PM · Patch-For-Review, SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner claimed T222361: UploadWizard should indicate that statements are being submitted.
Wed, May 22, 7:36 PM · Patch-For-Review, SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner moved T221732: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files from Code Review to To Do on the Multimedia-Current-Work board.
Wed, May 22, 7:35 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner reassigned T221732: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files from egardner to PDrouin-WMF.
Wed, May 22, 7:35 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner claimed T221732: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files.
Wed, May 22, 7:34 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner moved T221732: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files from To Do to Code Review on the Multimedia-Current-Work board.
Wed, May 22, 7:34 PM · Multimedia-Current-Work, SDC Design, Multimedia
egardner added a comment to T222361: UploadWizard should indicate that statements are being submitted.

Right now I'm just centering it horizontally and vertically on top of the form.

Wed, May 22, 4:03 PM · Patch-For-Review, SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner moved T222361: UploadWizard should indicate that statements are being submitted from To Do to Doing on the Multimedia-Current-Work board.
Wed, May 22, 4:02 PM · Patch-For-Review, SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner added a comment to T222361: UploadWizard should indicate that statements are being submitted.

Hey @PDrouin-WMF: I spent some time poking around in UW yesterday. I'm afraid that the solution you proposed above (placing a spinner to the right as in previous steps) is not feasible for the "Add Data" screen. That's because this step can accommodate multiple files at once, in which case there is a "booklet" layout (you can click which image you want to add details to on the left-hand submenu, and the right-hand area is filled with information about that file).

Wed, May 22, 3:55 PM · Patch-For-Review, SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering

Tue, May 21

egardner moved T221861: Structured Data table overflows when wikidata label is too long from To Do to Doing on the Multimedia-Current-Work board.
Tue, May 21, 3:06 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons

Mon, May 20

egardner added a comment to T221861: Structured Data table overflows when wikidata label is too long.

I'm pretty sure that some of the recent mobile-related patches we have merged on master will fix this once we deploy a new release.

Mon, May 20, 7:15 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons

Fri, May 17

egardner moved T223655: Wikidata icon doesn't align with property link in statements widget when secondary statement label is present from To Do to Code Review on the Multimedia-Current-Work board.
Fri, May 17, 6:50 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC Engineering, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner created T223655: Wikidata icon doesn't align with property link in statements widget when secondary statement label is present.
Fri, May 17, 6:38 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC Engineering, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T222361: UploadWizard should indicate that statements are being submitted.

@PDrouin-WMF I can take a stab at this if using the already-existing spinner element is ok. Haven't done much in the UW codebase yet, this would be a good excuse to dig a bit deeper.

Fri, May 17, 6:07 PM · Patch-For-Review, SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
egardner updated subscribers of T223432: Captions mobile improvements.

Ok, I've updated the patch to make footer behavior consistent between the panels. The footer buttons share a row when there is sufficient space, but stack otherwise. Here's what that looks like now:

Fri, May 17, 2:49 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, Multimedia, SDC Engineering

Thu, May 16

egardner moved T223432: Captions mobile improvements from Doing to Code Review on the Multimedia-Current-Work board.
Thu, May 16, 10:42 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, Multimedia, SDC Engineering
egardner moved T223432: Captions mobile improvements from To Do to Doing on the Multimedia-Current-Work board.
Thu, May 16, 10:42 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, Multimedia, SDC Engineering
egardner added a comment to T223432: Captions mobile improvements.

Basic patch for this is up. Here's what the Captions panel looks like now at various sizes & states:

Thu, May 16, 10:41 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, Multimedia, SDC Engineering
egardner added a comment to T223432: Captions mobile improvements.

I think that this is doable with some flexbox tweaking, but the trash-can button will probably need to be appended to the .wbmi-entityview-caption div, as opposed to the child .wbmi-caption-value div as it is now. That would allow you to achieve this:

Thu, May 16, 10:03 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, Multimedia, SDC Engineering
egardner claimed T223432: Captions mobile improvements.
Thu, May 16, 9:43 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, Multimedia, SDC Engineering
egardner updated subscribers of T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

@Ramsey-WMF was able to grant increased privileges on Beta Commons to the fake user account we are using here, which gets around the Abuse Filter problem for testing logged-in edits. Anonymous edits will still be thwarted by that filter.

Thu, May 16, 8:24 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner moved T219815: Create integration tests to cover potential issues with editing and uploading on Commons from Doing to Code Review on the Multimedia-Current-Work board.
Thu, May 16, 8:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner added a comment to T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

One additional issue here:

Thu, May 16, 12:04 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

Wed, May 15

egardner claimed T219815: Create integration tests to cover potential issues with editing and uploading on Commons.
Wed, May 15, 10:48 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner moved T219815: Create integration tests to cover potential issues with editing and uploading on Commons from Blocked to Doing on the Multimedia-Current-Work board.
Wed, May 15, 10:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner added a comment to T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

Update to the above – I've re-worked this patch to focus on testing against beta-commons; everything that would run in the normal CI process (tests in the Selenium "specs" folder, for instance), has been moved into a beta-commons-specific folder instead.

Wed, May 15, 8:29 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

Tue, May 14

egardner updated subscribers of T219815: Create integration tests to cover potential issues with editing and uploading on Commons.

I'm trying to determine if this task is still blocked or not. Our attempts to get some Selenium tests working have faced a couple of problems, but several of them seem to have been fixed:

Tue, May 14, 8:45 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work

Wed, May 1

egardner closed T221778: Update MediaInfo README with more information about how to set up locally as Resolved.
Wed, May 1, 12:42 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner closed T221778: Update MediaInfo README with more information about how to set up locally, a subtask of T221480: Update README files with latest configuration instructions, as Resolved.
Wed, May 1, 12:42 AM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner moved T221674: On mobile skin, Captions/Statements panel should fill container from Code Review to Needs QA on the Multimedia-Current-Work board.
Wed, May 1, 12:42 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner closed T221480: Update README files with latest configuration instructions as Resolved.
Wed, May 1, 12:42 AM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work

Tue, Apr 30

egardner added a comment to T218951: Make button placement for Captions consistent with Depicts/statements.

Oh – good catch! I think that was a side-effect of something else I did. I'll switch those back and update the patch.

Tue, Apr 30, 9:43 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner claimed T218951: Make button placement for Captions consistent with Depicts/statements.
Tue, Apr 30, 7:52 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T218951: Make button placement for Captions consistent with Depicts/statements from To Do to Code Review on the Multimedia-Current-Work board.
Tue, Apr 30, 7:51 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T221228: Depicts widget has a couple of visual quirks on mobile/small screens from Doing to Code Review on the Multimedia-Current-Work board.
Tue, Apr 30, 7:51 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner moved T221658: Poor/non-functional experience on mobile [Epic] from Blocked to Doing on the Multimedia-Current-Work board.
Tue, Apr 30, 7:51 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner added a comment to T218951: Make button placement for Captions consistent with Depicts/statements.

Hey @PDrouin-WMF, how does this look – it's mostly what we talked about with some small adjustments:

Tue, Apr 30, 6:57 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner moved T221480: Update README files with latest configuration instructions from Doing to Code Review on the Multimedia-Current-Work board.
Tue, Apr 30, 4:04 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner claimed T221480: Update README files with latest configuration instructions.
Tue, Apr 30, 4:03 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work

Apr 25 2019

egardner added a comment to T221658: Poor/non-functional experience on mobile [Epic].
Apr 25 2019, 9:29 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work

Apr 24 2019

egardner claimed T221778: Update MediaInfo README with more information about how to set up locally.
Apr 24 2019, 4:38 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner closed T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment) as Resolved.
Apr 24 2019, 4:33 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner added a comment to T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).

Thanks for clarifying. I've added some info around this in the README for the related ticket at T221480, closing this one.

Apr 24 2019, 4:33 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner moved T221480: Update README files with latest configuration instructions from To Do to Doing on the Multimedia-Current-Work board.
Apr 24 2019, 4:32 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner moved T221778: Update MediaInfo README with more information about how to set up locally from To Do to Code Review on the Multimedia-Current-Work board.
Apr 24 2019, 4:32 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T221778: Update MediaInfo README with more information about how to set up locally.

Here's a related question – what are the type requirements for valid qualifiers if the user is creating them locally?

Apr 24 2019, 3:05 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T221778: Update MediaInfo README with more information about how to set up locally.

Tangentially related to T221717

Apr 24 2019, 2:47 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner created T221778: Update MediaInfo README with more information about how to set up locally.
Apr 24 2019, 2:45 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work
egardner added a comment to T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).

That works, thanks – I thought my problem was with the Entity types for some reason, not the type of the depicts Property.
Incidentally, the distinction between Property: type property (what I had defaulted to) and Property: type item is not very clear to me at all.

Apr 24 2019, 2:37 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work

Apr 23 2019

egardner added a comment to T218951: Make button placement for Captions consistent with Depicts/statements.

I think that this issue can be addressed as part of T221658 and T221228. The fact that the Captions panel separates the label (top of panel) from the cancel/publish controls (bottom of panel) means the layout functions better on small screens. On the Statement Panel, the panel label and the controls widget both exist in the top region of the panel, and on small screens they collide.

Apr 23 2019, 11:31 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a parent task for T218951: Make button placement for Captions consistent with Depicts/statements: T221228: Depicts widget has a couple of visual quirks on mobile/small screens.
Apr 23 2019, 11:27 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a subtask for T221228: Depicts widget has a couple of visual quirks on mobile/small screens: T218951: Make button placement for Captions consistent with Depicts/statements.
Apr 23 2019, 11:27 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner added a parent task for T218951: Make button placement for Captions consistent with Depicts/statements: T221658: Poor/non-functional experience on mobile [Epic].
Apr 23 2019, 11:26 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
egardner added a subtask for T221658: Poor/non-functional experience on mobile [Epic]: T218951: Make button placement for Captions consistent with Depicts/statements.
Apr 23 2019, 11:26 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner moved T221228: Depicts widget has a couple of visual quirks on mobile/small screens from To Do to Doing on the Multimedia-Current-Work board.
Apr 23 2019, 11:25 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner added a project to T221228: Depicts widget has a couple of visual quirks on mobile/small screens: Multimedia-Current-Work.
Apr 23 2019, 11:24 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
egardner added a comment to T221678: Statements auto-complete does not work on mobile skin.

Looks like this is a CORS error: when I attempt to add statements in mobile view on production, I get this error in the JS console:

Apr 23 2019, 10:52 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner moved T221674: On mobile skin, Captions/Statements panel should fill container from Doing to Code Review on the Multimedia-Current-Work board.
Apr 23 2019, 10:35 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner renamed T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment) from "Unexpected entity type item" error when attempting to add Depicts statement on Filepage to "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).
Apr 23 2019, 9:22 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner created T221717: "Unexpected entity type item" error when attempting to add Depicts statement on Filepage (in local dev environment).
Apr 23 2019, 9:22 PM · WikibaseMediaInfo, Multimedia, Multimedia-Current-Work
egardner moved T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic] from Blocked to Doing on the Multimedia-Current-Work board.
Apr 23 2019, 8:57 PM · SDC Engineering, Multimedia-Current-Work, Multimedia
egardner renamed T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic] from Add JS Unit tests to safeguard Filepage UI happy-paths to Add JS Unit tests to safeguard Filepage UI happy-paths [Epic].
Apr 23 2019, 8:57 PM · SDC Engineering, Multimedia-Current-Work, Multimedia
egardner moved T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic] from To Do to Blocked on the Multimedia-Current-Work board.
Apr 23 2019, 8:56 PM · SDC Engineering, Multimedia-Current-Work, Multimedia
egardner closed T221057: Add basic unit tests for StatementPanel as Resolved.
Apr 23 2019, 8:56 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, SDC Engineering, Multimedia, Multimedia-Current-Work
egardner closed T221057: Add basic unit tests for StatementPanel, a subtask of T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic], as Resolved.
Apr 23 2019, 8:56 PM · SDC Engineering, Multimedia-Current-Work, Multimedia
egardner moved T221364: Image dimension scaling on UW "Add data" step is wonky [Labs] from Code Review to Needs QA on the Multimedia-Current-Work board.
Apr 23 2019, 8:56 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multimedia, Multimedia-Current-Work, SDC Design
egardner moved T221674: On mobile skin, Captions/Statements panel should fill container from To Do to Doing on the Multimedia-Current-Work board.
Apr 23 2019, 8:55 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner claimed T221674: On mobile skin, Captions/Statements panel should fill container.
Apr 23 2019, 8:49 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner added a project to T221658: Poor/non-functional experience on mobile [Epic]: SDC Design.
Apr 23 2019, 5:37 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner placed T219815: Create integration tests to cover potential issues with editing and uploading on Commons up for grabs.
Apr 23 2019, 5:36 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, User-zeljkofilipin, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia, Multimedia-Current-Work
egardner added a parent task for T221015: Enforce statement uniqueness on Filepage: T221681: Clarify the MediaInfo data model in relation to Wikibase [Epic].
Apr 23 2019, 5:34 PM · Technical-Debt, Multimedia-Current-Work, Multimedia
egardner added a subtask for T221681: Clarify the MediaInfo data model in relation to Wikibase [Epic]: T221015: Enforce statement uniqueness on Filepage.
Apr 23 2019, 5:34 PM · SDC Engineering, Multimedia, Multimedia-Current-Work
egardner created T221681: Clarify the MediaInfo data model in relation to Wikibase [Epic].
Apr 23 2019, 5:34 PM · SDC Engineering, Multimedia, Multimedia-Current-Work
egardner created T221678: Statements auto-complete does not work on mobile skin.
Apr 23 2019, 5:16 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner created T221674: On mobile skin, Captions/Statements panel should fill container.
Apr 23 2019, 5:10 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner moved T221658: Poor/non-functional experience on mobile [Epic] from To Do to Blocked on the Multimedia-Current-Work board.
Apr 23 2019, 5:05 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner renamed T221658: Poor/non-functional experience on mobile [Epic] from Poor/non-functional experience on mobile to Poor/non-functional experience on mobile [Epic].
Apr 23 2019, 5:05 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner added a subtask for T221658: Poor/non-functional experience on mobile [Epic]: T221229: Statements submitted on mobile don't show up until refresh.
Apr 23 2019, 5:04 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
egardner added a parent task for T221229: Statements submitted on mobile don't show up until refresh: T221658: Poor/non-functional experience on mobile [Epic].
Apr 23 2019, 5:04 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia, SDC Engineering
egardner created T221658: Poor/non-functional experience on mobile [Epic].
Apr 23 2019, 3:59 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work

Apr 19 2019

egardner moved T221364: Image dimension scaling on UW "Add data" step is wonky [Labs] from To Do to Code Review on the Multimedia-Current-Work board.
Apr 19 2019, 8:18 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multimedia, Multimedia-Current-Work, SDC Design
egardner added a comment to T221364: Image dimension scaling on UW "Add data" step is wonky [Labs].

Ok, this should be a simple fix (just made one change from width to max-width in the CSS.
@PDrouin-WMF this is not on Labs/Beta yet (maybe someone can push there so you can verify), but here's a screenshot from my local instance:

Apr 19 2019, 8:18 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multimedia, Multimedia-Current-Work, SDC Design
egardner claimed T221364: Image dimension scaling on UW "Add data" step is wonky [Labs].
Apr 19 2019, 8:15 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multimedia, Multimedia-Current-Work, SDC Design
egardner created T221480: Update README files with latest configuration instructions.
Apr 19 2019, 8:07 PM · WikibaseMediaInfo, Patch-For-Review, Multimedia, Multimedia-Current-Work

Apr 17 2019

egardner moved T221057: Add basic unit tests for StatementPanel from Doing to Code Review on the Multimedia-Current-Work board.
Apr 17 2019, 8:58 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, SDC Engineering, Multimedia, Multimedia-Current-Work

Apr 16 2019

egardner moved T220234: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified from Needs QA to Verify on Production on the Multimedia-Current-Work board.
Apr 16 2019, 9:49 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
egardner added a comment to T220234: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified.

This feature seems to be working correctly on both Beta and Test commons; moving to "Verify on Production".

Apr 16 2019, 9:48 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
egardner moved T218628: Structured fields don't show a notice about IP logging for users who aren't logged in from Needs QA to Verify on Production on the Multimedia-Current-Work board.
Apr 16 2019, 9:46 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Multimedia-Current-Work, SDC Design, Multimedia
egardner added a comment to T218628: Structured fields don't show a notice about IP logging for users who aren't logged in.

It is my understanding that the text is always going to depend on the way the Wiki in question has been configured. I think this is the correct behavior, even if some sites have been configured to display text different than what we are expecting.

Apr 16 2019, 9:46 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Multimedia-Current-Work, SDC Design, Multimedia
egardner placed T221123: Adding multiple captions at once is v broken (Beta Commons) up for grabs.
Apr 16 2019, 6:54 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, WikibaseMediaInfo, Multimedia-Current-Work
egardner claimed T221123: Adding multiple captions at once is v broken (Beta Commons).
Apr 16 2019, 6:27 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, WikibaseMediaInfo, Multimedia-Current-Work
egardner added a comment to T221123: Adding multiple captions at once is v broken (Beta Commons).

Even the brokenness is broken...

Apr 16 2019, 6:00 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, WikibaseMediaInfo, Multimedia-Current-Work
egardner added a comment to T221123: Adding multiple captions at once is v broken (Beta Commons).

In my case the panel ended up in a frozen disabled state, where some captions had been submitted and others not – no error message or failed requests, just UI freeze:

Apr 16 2019, 5:56 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, WikibaseMediaInfo, Multimedia-Current-Work