Page MenuHomePhabricator

freephile (Greg Rundlett)
President / CEO eQuality Technology

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2015, 7:19 PM (299 w, 6 d)
Availability
Available
IRC Nick
freephile
LDAP User
Freephile
MediaWiki User
GregRundlett [ Global Accounts ]

Recent Activity

Fri, Nov 6

freephile added a comment to T266678: Actor Migration breaks images in 1.34.x.

@tstarling I believe I do -- from 9/11/2020, but the main DB backup is 12GB compressed. Due to space constraints, I only have these on a 'snapshot' -- not a live system. If you give me a public SSH key, I could spin up an environment temporarily (cost us $20/day) from one of these snapshots, and give you direct SSH access. I do believe that I already deleted some records from the logging table (where log_user_text = '') prior to snapshot. I don't have earlier backups.

Fri, Nov 6, 6:00 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General

Thu, Nov 5

freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

Ultimately, I was able to complete an upgrade by 1) using maintenance/eval.php to create the missing User; and 2) deleting some old entries from the logging table.

php ./maintenance/eval.php
User::createNew( 'Redirect fixer', [ 'id' => 7425 ] )
Ctrl + c
mysql wiki_en -e 'select * from user where user_id = 7425;'
mysql wiki_en -e 'delete from `wiki_en`.`logging` where log_user_text = "";' -- 21733 rows deleted

Then I was able to run update.php

Thu, Nov 5, 4:48 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

Wed, Oct 28

freephile updated the task description for T266678: Actor Migration breaks images in 1.34.x.
Wed, Oct 28, 11:28 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General
freephile added a comment to T266678: Actor Migration breaks images in 1.34.x.

Just a little more info on what a 'broken image' looks like in the database.

-- A broken image
select img_name, img_actor from image where img_name = 'Flag_of_Norway.png'; -- img_actor = 0
select page_id from page where page_title = 'Flag_of_Norway.png'; -- the page id is 15395
select rev_user, rev_user_text from revision where rev_page = 15395; -- There are 4 entries in revisions, while page info says the second one 20027 Claudiaj64 is the Creator
select rev_user, rev_user_text from revision where rev_page = 15395 having min(rev_id); -- the original creator was user 145 Jtrev
select * from user where user_id in (145, 20027); -- Between Jtrev and Claudia, Claudia is the only one in the user table
select * from user where user_name = 'Jtrev'; -- Jtrev is just plain missing. Not found by name or id
select * from actor where actor_user = 20027; -- Claudia has actor id of 29 on beta, 30 on prod
update image set img_actor = 30 where img_name = 'Flag_of_Norway.png'; -- one row affected, but img still not visible (due to caching)
Wed, Oct 28, 7:26 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General

Oct 28 2020

freephile added a comment to T266678: Actor Migration breaks images in 1.34.x.

@Reedy @Ciencia_Al_Poder Thanks for the heads up on purgePage v. purgeList (If there's a 50/50 chance of doing the wrong thing, I do the wrong thing 100% of the time!)

Oct 28 2020, 3:47 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General
freephile added a comment to T266678: Actor Migration breaks images in 1.34.x.

No shared tables. Just shared file repo.

Oct 28 2020, 3:29 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General
freephile updated the task description for T266678: Actor Migration breaks images in 1.34.x.
Oct 28 2020, 3:26 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General
freephile updated the task description for T266678: Actor Migration breaks images in 1.34.x.
Oct 28 2020, 3:19 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General
freephile updated the task description for T266678: Actor Migration breaks images in 1.34.x.
Oct 28 2020, 3:18 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General
freephile created T266678: Actor Migration breaks images in 1.34.x.
Oct 28 2020, 3:16 PM · Platform Engineering Roadmap Decision Making, MediaWiki-General

Oct 12 2020

freephile added a comment to T265164: Evaluate usage of MediaWiki-Vagrant by technical contributors.

If this is meant to compare to MediaWiki-Docker (distributed now with core), then I'd say I'm more inclined to use MediaWiki-Docker because it's more lightweight (using LXC instead of VirtualBox), and because it is probably easier to setup (my estimation) in popular cloud environments like AWS, Google Cloud Platform, Microsoft Azure. I ran into problems with MediaWiki-Vagrant back in 2015 when I first tried it in earnest on AWS (documented on my wiki at https://wiki.freephile.org/wiki/MediaWiki-Vagrant)

Oct 12 2020, 8:41 PM · User-bd808, MediaWiki-Vagrant

Oct 8 2020

freephile added a comment to T208189: "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again.".

Duplicate of T254647 reported for Extension:PageForms

Oct 8 2020, 9:14 PM · VisualEditor
freephile added a comment to T254647: "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." when using Preview with Page Forms.

When you try to create a new property (using the normal Form Interface at Special:CreateProperty), you get the following error when previewing or saving the edit:

Oct 8 2020, 9:12 PM · MediaWiki-extensions-Page_Forms
freephile committed rESHG24d418bced44: The word Python was misspelled (authored by freephile).
The word Python was misspelled
Oct 8 2020, 5:37 PM

Oct 7 2020

freephile renamed T264912: Who Is Watching showing extraneous user output from Whos Watching showing extraneous user output to Who Is Watching showing extraneous user output.
Oct 7 2020, 4:58 PM · MediaWiki-extensions-WhoIsWatching
freephile created T264912: Who Is Watching showing extraneous user output.
Oct 7 2020, 4:58 PM · MediaWiki-extensions-WhoIsWatching

Sep 30 2020

freephile awarded T225027: long queries in Extension ApprovedRevs a Like token.
Sep 30 2020, 9:20 PM · Performance Issue, MediaWiki-extensions-Approved-Revs
freephile renamed T225027: long queries in Extension ApprovedRevs from long queries to long queries in Extension ApprovedRevs.
Sep 30 2020, 6:59 PM · Performance Issue, MediaWiki-extensions-Approved-Revs
freephile added a comment to T225027: long queries in Extension ApprovedRevs.

This issue persists in MW 1.34.4 / ApprovedRevs version 'master'

Sep 30 2020, 6:58 PM · Performance Issue, MediaWiki-extensions-Approved-Revs

Sep 29 2020

freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

Ultimately, I was able to complete an upgrade by 1) using maintenance/eval.php to create the missing User; and 2) deleting some old entries from the logging table.

Sep 29 2020, 4:51 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

Sep 18 2020

freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

I'm still struggling with this. I am unable to upgrade a 1.32 wiki to 1.34 because no matter what I have tried, I still get multiple errors; with fatal errors relating to duplicate Actors.

Sep 18 2020, 5:34 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

Aug 31 2020

freephile added a comment to T259771: RFC: Drop support for database upgrade older than two LTS releases.

So just for concrete example's sake (please rebut each as appropriate):

Upgrading to 1.35 (LTS)

  1. There would not be support for 1.23 (-3 LTS) to 1.35 (LTS)
  2. There would not be support for 1.24, 1.25, or 1.26 to 1.35 (LTS)
  3. There would be support for 1.27 (-2 LTS) to 1.35 (LTS)
  4. There would be support for 1.28, 1.29, 1.30 to 1.35 (LTS)
  5. There would be support for 1.31 (-1 LTS) to 1.35 (LTS)
  6. There would be support for 1.32, 1.33, or 1.34 to 1.35 (LTS)

Upgrading to 1.36 (LTS +1)

  1. There would not be support for 1.23 (-3 LTS) to 1.36 (LTS +1)
  2. There would not be support for 1.24, 1.25, or 1.26 to 1.36 (LTS +1)
  3. There would not be support for 1.27 (-2 LTS) to 1.36 (LTS +1)
  4. There would not be support for 1.28, 1.29, 1.30 to 1.36 (LTS +1)
  5. There would be support for 1.31 (-1 LTS) to 1.36 (LTS +1)
  6. There would be support for 1.32, 1.33, or 1.34 to 1.36 (LTS +1)

I think you got this wrong. The way the proposal is worded, support for upgrades would continue for old LTS releases until a new LTS release bumps the oldest supported LTS release off the list.
In other words, I believe the release of 1.36 (non-LTS) doesn't affect the migration support for 1.27+

Aug 31 2020, 6:44 PM · MediaWiki-Stakeholders-Group, Platform Engineering, TechCom-RFC

Aug 20 2020

freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

Expanding on the above, using a different larger wiki database with the same issue, there are 1,571 records in the logging table having an empty log_user_text (aka username) where the type is "newusers" and action = "create" [1]. Not one of those log_user (ids) exists in the user table. [2]

Aug 20 2020, 7:56 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system
freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

I noticed something interesting about the nature of records in the logging table with empty log_user_text: There are many with the 'log_action' = 'create' and the 'log_title' appears to be the username. Eg.

select log_type, log_action, log_timestamp, log_user, log_title from logging where log_user_text = "" AND log_action = "create" ORDER BY log_timestamp LIMIT 10;
Aug 20 2020, 3:00 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system
freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

Hoping that logic improvements in the latest Actor Migration codebase could save me, I setup MediaWiki-Docker (with MySQL backing),

Product	Version
MediaWiki	1.36.0-alpha (2cc3d4f)
15:13, 19 August 2020
PHP	7.2.31-1+0~20200514.41+debian9~1.gbpe2a56b+wmf1 (fpm-fcgi)
MariaDB	10.5.4-MariaDB-log
ICU	57.1
Aug 20 2020, 4:29 AM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

Aug 19 2020

freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

Latest example:
Setup fresh 'demo' wiki

Aug 19 2020, 10:58 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

Aug 18 2020

freephile closed T260437: Add CSS class to enable Search Suggestions for type=Search as Resolved.
Aug 18 2020, 9:58 PM · Patch-For-Review, MediaWiki-extensions-InputBox
freephile claimed T260437: Add CSS class to enable Search Suggestions for type=Search.
Aug 18 2020, 9:09 PM · Patch-For-Review, MediaWiki-extensions-InputBox
freephile added a comment to T260437: Add CSS class to enable Search Suggestions for type=Search.

Thanks Mark @MarkAHershberger, but I already fixed the style issues in the latest commit. There are now assertions in the unit tests that are failing, due to the new class attribute not conforming to the declared / expected output of the parser tags for InputBox.

Aug 18 2020, 3:00 PM · Patch-For-Review, MediaWiki-extensions-InputBox
freephile added a comment to T260437: Add CSS class to enable Search Suggestions for type=Search.

Based on test failures, it looks like I need to update the unit tests for InputBox.

Aug 18 2020, 12:28 PM · Patch-For-Review, MediaWiki-extensions-InputBox
freephile added a comment to T260437: Add CSS class to enable Search Suggestions for type=Search.

I uploaded a revised patch at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/InputBox/+/620780

Aug 18 2020, 11:11 AM · Patch-For-Review, MediaWiki-extensions-InputBox

Aug 14 2020

freephile added a comment to T260437: Add CSS class to enable Search Suggestions for type=Search.

I uploaded a patch here

Aug 14 2020, 3:06 PM · Patch-For-Review, MediaWiki-extensions-InputBox
freephile created T260437: Add CSS class to enable Search Suggestions for type=Search.
Aug 14 2020, 2:45 PM · Patch-For-Review, MediaWiki-extensions-InputBox

Aug 5 2020

freephile added a comment to T250406: RFC: Hybrid extension management.

I would like to see MediaWiki core, libraries, extensions and skins installable by composer -- just like you can do with Drupal (introduced in Drupal Core 8.8 and mentioned earlier in this RFC). "But wiki extensions don't use semantic versioning." Drupal modules (mostly) don't follow semantic versioning, but there's a shim to accomodate that. End users aren't forced to use composer - because it's not the only way to download/install/manage Drupal. In fact, it's not even mentioned on the project download page. The point is, I wholeheartedly support this RFC in terms of improving and clarifying composer support in the MediaWiki ecosystem.

Aug 5 2020, 5:07 PM · MediaWiki-Stakeholders-Group, TechCom-RFC
freephile awarded T249573: RFC: Remove ability to install extensions and skins with Composer a Dislike token.
Aug 5 2020, 4:02 PM · Patch-For-Review, TechCom-RFC, Composer, MediaWiki-General

Jul 31 2020

freephile added a comment to T188731: preserve search query when navigating to different silos.

New codesearch UI looks great! THANKS!

Jul 31 2020, 12:33 PM · VPS-project-Codesearch
freephile awarded T188731: preserve search query when navigating to different silos a Love token.
Jul 31 2020, 12:32 PM · VPS-project-Codesearch

Jul 1 2020

freephile added a comment to T224854: maintenance/cleanupUsersWithNoId.php doesn't do anything.

It seems to be choking on the logging table. When I look at those records, there are many with empty log_user_text
mysql wiki_fr -e 'select distinct log_user from logging where log_user_text = "" order by log_user;'

Jul 1 2020, 3:05 AM · MediaWiki-Maintenance-system
freephile added a comment to T224854: maintenance/cleanupUsersWithNoId.php doesn't do anything.

I'm trying to upgrade from 1.32 to 1.34 Actor Migration is still failing for me. Using --force with cleanupUsersWithNoId.php did not change the results of my upgrade attempt. Here is what update.php is reporting... lots of errors:

Completed actor creation, added 0 new actor(s)
Beginning migration of revision.rev_user and revision.rev_user_text to revision_actor_temp.revactor_actor
User name "Crowtherdr" is usable, cannot create an anonymous actor for it. Run maintenance/cleanupUsersWithNoId.php to fix this situation.
Jul 1 2020, 2:55 AM · MediaWiki-Maintenance-system

Jun 12 2020

freephile added a comment to T224854: maintenance/cleanupUsersWithNoId.php doesn't do anything.

For me, migrateActors.php was failing with a duplicate for 'Redirect fixer' https://phabricator.wikimedia.org/T229092. After I manually updated the revision table like Anomie suggested, I re-ran the cleanupUsersWithNoId.php -- which didn't make any changes or corrections. Now when I run migrateActors.php, it fails with

Function: MigrateActors::addActorsForRows
Error: 1062 Duplicate entry '' for key 'actor_name'

I can't update revision with rev_user = 0 because rev_user is already zero for the 24 records in question. What can I try next?

Jun 12 2020, 6:32 PM · MediaWiki-Maintenance-system
freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

Additional Details: Attempting to run php /opt/htdocs/mediawiki/maintenance/migrateActors.php on a large 60GB wiki database.

Jun 12 2020, 4:53 PM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

May 1 2020

freephile added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

I'm running into this problem upgrading from REL1_32 to REL1_34. I'd be happy to provide any additional details.

May 1 2020, 11:26 AM · Platform Engineering (Icebox), MediaWiki-Maintenance-system

Apr 29 2020

freephile added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

For some reason, the attached test docx file (I obtained from the vendor/ruflin/elastica tree in MediaWiki 1.28) causes the error: "File extension ".docx" does not match the detected MIME type of the file (application/zip)." on my REL1_34 MediaWiki

Apr 29 2020, 9:45 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Multimedia, MediaWiki-Uploading

Apr 17 2020

freephile awarded T250406: RFC: Hybrid extension management a Like token.
Apr 17 2020, 9:54 AM · MediaWiki-Stakeholders-Group, TechCom-RFC

Feb 11 2020

freephile closed T244921: ERROR: "Content model must be stored in the database for multi content revision migration" as Invalid.

Changing to invalid since I did not turn off all extensions prior to update.php (I was attempting to upgrade the database while simultaneously enabling a bunch of extensions.)

Feb 11 2020, 11:23 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile added a comment to T244921: ERROR: "Content model must be stored in the database for multi content revision migration".

OK, so I made the mistake of not disabling all extensions prior to running update.php.

Feb 11 2020, 9:53 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile added a comment to T244921: ERROR: "Content model must be stored in the database for multi content revision migration".

I'm going to try

$wgActorTableSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD
Feb 11 2020, 9:16 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile added a comment to T244921: ERROR: "Content model must be stored in the database for multi content revision migration".
Creating uploadstash table ...done.
Creating user_former_groups table ...done.
Adding rev_sha1 field to table revision ...done.
...batch conversion of user_options: [8c1d711dfd82a2a456414ac5] [no req]   MWException from line 264 of /opt/mediawiki/1.33.0/includes/Revision/RevisionStore.php: Content model must be stored in the database for multi content revision migration.
Backtrace:
#0 /opt/mediawiki/1.33.0/includes/Revision/RevisionStoreFactory.php(140): MediaWiki\Revision\RevisionStore->setContentHandlerUseDB(boolean)
#1 /opt/mediawiki/1.33.0/includes/ServiceWiring.php(471): MediaWiki\Revision\RevisionStoreFactory->getRevisionStore()
#2 /opt/mediawiki/1.33.0/includes/libs/services/ServiceContainer.php(430): Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
#3 /opt/mediawiki/1.33.0/includes/libs/services/ServiceContainer.php(414): Wikimedia\Services\ServiceContainer->createService(string)
#4 /opt/mediawiki/1.33.0/includes/MediaWikiServices.php(803): Wikimedia\Services\ServiceContainer->getService(string)
#5 /opt/mediawiki/1.33.0/includes/ServiceWiring.php(457): MediaWiki\MediaWikiServices->getRevisionStore()
#6 /opt/mediawiki/1.33.0/includes/libs/services/ServiceContainer.php(430): Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
#7 /opt/mediawiki/1.33.0/includes/libs/services/ServiceContainer.php(414): Wikimedia\Services\ServiceContainer->createService(string)
#8 /opt/mediawiki/1.33.0/includes/MediaWikiServices.php(787): Wikimedia\Services\ServiceContainer->getService(string)
#9 /opt/mediawiki/1.33.0/includes/Revision.php(76): MediaWiki\MediaWikiServices->getRevisionLookup()
#10 /opt/mediawiki/1.33.0/includes/Revision.php(138): Revision::getRevisionLookup()
#11 /opt/mediawiki/1.33.0/extensions/Gadgets/includes/MediaWikiGadgetsDefinitionRepo.php(139): Revision::newFromTitle(Title)
#12 /opt/mediawiki/1.33.0/extensions/Gadgets/includes/MediaWikiGadgetsDefinitionRepo.php(108): MediaWikiGadgetsDefinitionRepo->fetchStructuredList()
#13 /opt/mediawiki/1.33.0/includes/libs/objectcache/WANObjectCache.php(1414): MediaWikiGadgetsDefinitionRepo->{closure}(boolean, integer, array, NULL)
#14 /opt/mediawiki/1.33.0/includes/libs/objectcache/WANObjectCache.php(1275): WANObjectCache->doGetWithSetCallback(string, integer, Closure, array)
#15 /opt/mediawiki/1.33.0/extensions/Gadgets/includes/MediaWikiGadgetsDefinitionRepo.php(115): WANObjectCache->getWithSetCallback(string, integer, Closure, array)
#16 /opt/mediawiki/1.33.0/extensions/Gadgets/includes/MediaWikiGadgetsDefinitionRepo.php(31): MediaWikiGadgetsDefinitionRepo->loadGadgets()
#17 /opt/mediawiki/1.33.0/extensions/Gadgets/includes/GadgetRepo.php(71): MediaWikiGadgetsDefinitionRepo->getGadgetIds()
#18 /opt/mediawiki/1.33.0/extensions/Gadgets/includes/GadgetHooks.php(47): GadgetRepo->getStructuredList()
#19 /opt/mediawiki/1.33.0/includes/Hooks.php(174): GadgetHooks::userGetDefaultOptions(array)
#20 /opt/mediawiki/1.33.0/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#21 /opt/mediawiki/1.33.0/includes/user/User.php(1807): Hooks::run(string, array)
#22 /opt/mediawiki/1.33.0/includes/user/User.php(1819): User::getDefaultOptions()
#23 /opt/mediawiki/1.33.0/maintenance/convertUserOptions.php(96): User::getDefaultOption(string)
#24 /opt/mediawiki/1.33.0/maintenance/convertUserOptions.php(67): ConvertUserOptions->convertOptionBatch(Wikimedia\Rdbms\ResultWrapper, Wikimedia\Rdbms\DatabaseMysqli)
#25 /opt/mediawiki/1.33.0/includes/installer/DatabaseUpdater.php(1195): ConvertUserOptions->execute()
#26 /opt/mediawiki/1.33.0/includes/installer/DatabaseUpdater.php(489): DatabaseUpdater->doMigrateUserOptions()
#27 /opt/mediawiki/1.33.0/includes/installer/DatabaseUpdater.php(453): DatabaseUpdater->runUpdates(array, boolean)
#28 /opt/mediawiki/1.33.0/maintenance/update.php(203): DatabaseUpdater->doUpdates(array)
#29 /opt/mediawiki/1.33.0/maintenance/doMaintenance.php(96): UpdateMediaWiki->execute()
#30 /opt/mediawiki/1.33.0/maintenance/update.php(266): require_once(string)
#31 {main}
Feb 11 2020, 8:37 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile added a comment to T244921: ERROR: "Content model must be stored in the database for multi content revision migration".

Answering myself:
It comes from this line of code in RevisionStore.php where the hasMcrSchemaFlags concept is connected. Is there a COMPAT flag I can use?

Feb 11 2020, 8:35 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile updated the task description for T244921: ERROR: "Content model must be stored in the database for multi content revision migration".
Feb 11 2020, 8:34 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile updated the task description for T244921: ERROR: "Content model must be stored in the database for multi content revision migration".
Feb 11 2020, 8:23 PM · MediaWiki-Revision-backend, MediaWiki-Installer
freephile created T244921: ERROR: "Content model must be stored in the database for multi content revision migration".
Feb 11 2020, 8:22 PM · MediaWiki-Revision-backend, MediaWiki-Installer

Jan 21 2020

freephile claimed T242171: invalid dependency check causes silent failure.
Jan 21 2020, 9:32 PM · MediaWiki-extensions-TwitterCards

Jan 7 2020

freephile added a comment to T242171: invalid dependency check causes silent failure.

Product Version
MediaWiki 1.32.6 (5807cdf)
06:31, 19 December 2019
PHP 7.1.33-3+0~20191218.29+debian9~1.gbp18b07c (apache2handler)
MariaDB 10.1.41-MariaDB-0+deb9u1
ICU 64.1
Elasticsearch 5.6.16
Lua 5.1.5

Jan 7 2020, 10:47 PM · MediaWiki-extensions-TwitterCards
freephile created T242171: invalid dependency check causes silent failure.
Jan 7 2020, 10:46 PM · MediaWiki-extensions-TwitterCards

Nov 12 2019

freephile awarded T219671: Mixed whitespace a Love token.
Nov 12 2019, 6:18 PM · User-Kizule, MediaWiki-extensions-Html2Wiki

Nov 7 2019

freephile added a comment to T226616: Not compatible with MediaWiki 1.33 (img_description column doesn't exist).

We use the GraphViz extension on the slicer.org wiki which we're upgrading from 1.27 to 1.33. Is there any hope for a fix? I've tried patching the database as described here, but get Error: Image is invalid or non-existent.

Nov 7 2019, 9:10 PM · Patch-For-Review, GraphViz

Oct 31 2019

freephile awarded T236914: Requesting new Gerrit repository for XSL extension a Like token.
Oct 31 2019, 3:42 PM · User-MarcoAurelio, Diffusion-Repository-Administrators, Gerrit-Privilege-Requests
freephile added a comment to T236914: Requesting new Gerrit repository for XSL extension.

I uploaded the code. I also posted in IRC looking for a reviewer. Not sure what else I should do. Thanks for your help.

Oct 31 2019, 3:34 PM · User-MarcoAurelio, Diffusion-Repository-Administrators, Gerrit-Privilege-Requests

Oct 30 2019

freephile created T236914: Requesting new Gerrit repository for XSL extension.
Oct 30 2019, 2:58 PM · User-MarcoAurelio, Diffusion-Repository-Administrators, Gerrit-Privilege-Requests

Sep 30 2019

freephile added a comment to T233750: Unable to run update.php Fatal error on wgDisableCounters.

MediaWiki version 1.32.3
https://beta.familysearch.org/wiki/en/Special:Version
master branch for HitCounters

Sep 30 2019, 3:16 PM · MediaWiki-extensions-HitCounters

Sep 24 2019

freephile created T233750: Unable to run update.php Fatal error on wgDisableCounters.
Sep 24 2019, 6:22 PM · MediaWiki-extensions-HitCounters

Sep 23 2019

freephile claimed T233540: Html2Wiki needs 'editToken' replaced with 'csrfToken'.
Sep 23 2019, 2:17 PM · User-TheSandDoctor, MediaWiki-extensions-Html2Wiki
freephile closed T233540: Html2Wiki needs 'editToken' replaced with 'csrfToken', a subtask of T233442: Remove use of deprecated 'editToken' in mw.user.tokens (replace with 'csrfToken'), as Resolved.
Sep 23 2019, 2:16 PM · Performance-Team (Radar), Technical-Debt, MediaWiki-extensions-General, User-TheSandDoctor
freephile closed T233540: Html2Wiki needs 'editToken' replaced with 'csrfToken' as Resolved.

commit pushed to master branch of Html2Wiki

Sep 23 2019, 2:16 PM · User-TheSandDoctor, MediaWiki-extensions-Html2Wiki
freephile committed rEHTWd52d83a2a4b7: Deprecated editToken replaced by csrfToken to fix #T233442 (authored by freephile).
Deprecated editToken replaced by csrfToken to fix #T233442
Sep 23 2019, 1:45 PM
freephile added a comment to T233540: Html2Wiki needs 'editToken' replaced with 'csrfToken'.

I just pushed a commit that should fix this. I don't know how to attach that commit to this issue.

Sep 23 2019, 1:32 PM · User-TheSandDoctor, MediaWiki-extensions-Html2Wiki

Jul 23 2019

freephile added a comment to T228504: 500 error trying to setup monoversion template.

First of all, you need to set

Jul 23 2019, 11:52 AM · MediaWiki-extensions-MediaWikiFarm

Jul 19 2019

freephile created T228504: 500 error trying to setup monoversion template.
Jul 19 2019, 11:26 AM · MediaWiki-extensions-MediaWikiFarm

Jul 12 2019

freephile updated the task description for T199984: Support background autologin in MediaWiki core.
Jul 12 2019, 11:14 AM · MediaWiki-Authentication-and-authorization

Jul 3 2019

freephile added a comment to T217669: Using "insert media" VisualEditor feature fails if you have wgForeignFileRepos set.

I'm not seeing this error on my wiki (unable to reproduce) although I do use wgForeignFileRepo as described here.

Jul 3 2019, 9:44 AM · VisualEditor

Jun 5 2019

freephile added a comment to T225027: long queries in Extension ApprovedRevs.

MediaWiki 1.32.1 (4012d8a)
PHP 7.1.29-1+0~20190503101539.18+stretch~1.gbp946c98 (apache2handler)
MariaDB 10.1.38-MariaDB-0+deb9u1
ICU 64.1
Elasticsearch 5.6.16
Lua 5.1.5

Jun 5 2019, 12:53 PM · Performance Issue, MediaWiki-extensions-Approved-Revs

Jun 4 2019

freephile updated the task description for T225027: long queries in Extension ApprovedRevs.
Jun 4 2019, 11:20 PM · Performance Issue, MediaWiki-extensions-Approved-Revs
freephile created T225027: long queries in Extension ApprovedRevs.
Jun 4 2019, 9:06 PM · Performance Issue, MediaWiki-extensions-Approved-Revs

May 12 2019

freephile added a comment to T218694: fatal: Project not found: p/VisualEditor/VisualEditor.

The r/p path is still present in .gitmodules for REL1_32 (and others). This breaks the ability to clone anything but master. Should I open a new ticket, or can these patches be applied to other branches besides master?

May 12 2019, 2:00 PM · Patch-For-Review, User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor, User-zeljkofilipin, MediaWiki-Release-Tools, Release-Engineering-Team (Kanban)

Feb 21 2019

freephile added a comment to T216743: Page disappears when searching on tablet/desktop.

I assume this is intended behavior because search results are retrieved instantly using XHR (AJAX) and thus the page you're viewing becomes a "search results" page the instant you focus on the search box. Results start appearing as you type characters. I would argue that the search box is taking over the interface prematurely. In our case (fswiki.familysearch.org), the search box itself disappears so you're literally on a white (blank) page. I'm sure we can fix our CSS to continue the display of the search box. Still, I think the display should be more intentional meaning it should update after you click 'submit' rather than being 'predictive' by responding to each character typed in the search box.

Feb 21 2019, 5:35 PM · Readers-Web-Backlog (Design), MobileFrontend
freephile updated the task description for T216743: Page disappears when searching on tablet/desktop.
Feb 21 2019, 5:18 PM · Readers-Web-Backlog (Design), MobileFrontend
freephile created T216743: Page disappears when searching on tablet/desktop.
Feb 21 2019, 5:12 PM · Readers-Web-Backlog (Design), MobileFrontend

Jan 2 2019

freephile added a comment to P7943 Unindexed pages.

@Reedy Thanks for the review and updates.

Jan 2 2019, 2:03 PM · CirrusSearch

Dec 31 2018

freephile edited P7943 Unindexed pages.
Dec 31 2018, 6:41 PM · CirrusSearch

Dec 30 2018

freephile added a comment to P7943 Unindexed pages.

I also discovered that some (~100/564) of the edits were destructive (RecentChanges) instead of being a so-called 'null edit'. It turns out that this was due to a character encoding issue in some content -- not due to the null edit action.

Dec 30 2018, 5:17 PM · CirrusSearch
freephile added a comment to P7943 Unindexed pages.

Looking at the Elasticsearch contents of known "good" articles v. known "bad" articles (ones without index content), we find that all articles are marked "OK", but bad articles do not have any 'value' so I switched the conditional to check for an empty 'value'

Dec 30 2018, 5:10 PM · CirrusSearch

Dec 28 2018

freephile added a comment to P7943 Unindexed pages.
Dec 28 2018, 8:24 PM · CirrusSearch
freephile added a comment to P7943 Unindexed pages.

I tried this and other variations, but can't quite figure out how to get output. If I extend Maintenance, I get a 'class not found error' for MediaWikiServices. If I extend FormlessAction (like Dump.php) I dont' get any output from the CLI (php fixSearch.php) , and get 500 error if I access the file via browser (https://wiki.freephile.org/w/maintenance/fixSearch.php).

<?php
Dec 28 2018, 5:20 PM · CirrusSearch
freephile added a comment to T152294: PHP Notice: Use of undefined constant CT_MODE_PAGES - assumed 'CT_MODE_PAGES' since MW 1.28+.

I've observed this in 1.28 (I think 1.29) 1.30 1.31.

Dec 28 2018, 2:12 AM · MediaWiki-Configuration, MediaWiki-extensions-CategoryTree

Dec 27 2018

freephile renamed T152294: PHP Notice: Use of undefined constant CT_MODE_PAGES - assumed 'CT_MODE_PAGES' since MW 1.28+ from PHP Notice: Use of undefined constant CT_MODE_PAGES - assumed 'CT_MODE_PAGES' under MW 1.28 to PHP Notice: Use of undefined constant CT_MODE_PAGES - assumed 'CT_MODE_PAGES' since MW 1.28+.
Dec 27 2018, 7:49 PM · MediaWiki-Configuration, MediaWiki-extensions-CategoryTree

Nov 28 2018

freephile added a watcher for deprecated-security-team-reviews: freephile.
Nov 28 2018, 1:46 PM

Nov 27 2018

freephile added a comment to T209862: Html2Wiki hangs up and does not convert the file.

@Sferg008, glad you were able to get Html2Wiki installed and running. I have not had time to focus on Html2Wiki development at all, so if you've got any info to share (on the talk page, or project page) that would help others, (or patches) for running on MW1.31 that would be great!

Nov 27 2018, 3:53 PM · MediaWiki-extensions-Html2Wiki

Nov 21 2018

freephile awarded T100841: Support for dynamically enabling new wikis a Mountain of Wealth token.
Nov 21 2018, 2:43 PM · Patch-For-Review, Parsoid

Nov 3 2018

freephile added a comment to T208650: Elastica dependencies need update to v5.3.2.

Could someone help me out with a pointer on how I'm supposed to contribute a patch? I tried to push to a new branch using my developer account, but was rejected:

root@ubuntu-DCS-wiki:/srv/www/sites/mediawiki/extensions/Elastica# git push 
fatal: The current branch T208650 has no upstream branch.
To push the current branch and set the remote as upstream, use
Nov 3 2018, 6:57 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Discovery-Search (Current work), Patch-For-Review, Elasticsearch
freephile added a comment to T208650: Elastica dependencies need update to v5.3.2.

(I'd commit this change to the appropriate branch (or fork) of Extension:Elastica and make a pull request, but I can't find how to do that here.)

Nov 3 2018, 3:24 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Discovery-Search (Current work), Patch-For-Review, Elasticsearch
freephile created T208650: Elastica dependencies need update to v5.3.2.
Nov 3 2018, 3:17 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Discovery-Search (Current work), Patch-For-Review, Elasticsearch

Jun 27 2018

freephile awarded T198325: Using $this when not in object context when uploading html file or archive in Html2Wiki 1.31 a Like token.
Jun 27 2018, 5:17 PM · MediaWiki-extensions-Html2Wiki

Jun 11 2018

Krinkle awarded T188731: preserve search query when navigating to different silos a Orange Medal token.
Jun 11 2018, 1:56 PM · VPS-project-Codesearch

May 23 2018

freephile added a comment to T195067: Dockerize MediaWiki installations: a rookie's working solution in search for best practices.

I compiled a list of some of the resources and projects I know about: https://wiki.freephile.org/wiki/Automated_deployment_of_MediaWiki

May 23 2018, 6:37 PM · Wikimedia-Hackathon-2018
freephile added a comment to T195067: Dockerize MediaWiki installations: a rookie's working solution in search for best practices.

Thanks for the links @dbarratt and @gabriel-wmde . @Lex were there any notes/slides/blog post from your presentation? (Wish I were there in Barcelona!)

May 23 2018, 2:13 PM · Wikimedia-Hackathon-2018

May 19 2018

freephile updated the task description for T194901: MediaWiki and GDPR.
May 19 2018, 3:14 PM · MediaWiki-Stakeholders-Group, Wikimedia-Hackathon-2018

May 18 2018

freephile added a comment to T194901: MediaWiki and GDPR.

I would very much like to have the session recorded and/or broadcast live so people who can't attend personally can view the presentation.

May 18 2018, 6:22 PM · MediaWiki-Stakeholders-Group, Wikimedia-Hackathon-2018

Mar 29 2018

freephile added a comment to T190560: Integrate Discourse into Wikimedia wikis search.

As I understand it, Discourse will output .json if you ask it to. And Elasticsearch only cares about json. So wouldn't the work be to create a new index in Elasticsearch that consumes the .json available from Discourse? (I haven't done this, so I don't know the particulars)

Mar 29 2018, 5:26 PM · Discovery-Search, Discourse

Mar 28 2018

freephile created T190900: Uncaught Error: Unknown dependency: ext.cards.
Mar 28 2018, 2:59 AM · RelatedArticles