Page MenuHomePhabricator

gengh (Genoveva Galarza)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 3 2020, 11:59 AM (18 w, 6 d)
Availability
Available
LDAP User
Genoveva Galarza
MediaWiki User
Geno (WMF) [ Global Accounts ]

Recent Activity

Yesterday

gengh added a comment to T260198: Add fetch polyfill to mediawiki core.

Some options, as suggested:

Wed, Apr 14, 3:18 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, Performance-Team, MediaWiki-Interface
gengh claimed T260198: Add fetch polyfill to mediawiki core.
Wed, Apr 14, 1:25 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, Performance-Team, MediaWiki-Interface
gengh closed T280134: Fix wikilambda_fetch so that it doesn't return escaped characters as Invalid.
Wed, Apr 14, 1:17 PM · Abstract Wikipedia team
gengh created T280134: Fix wikilambda_fetch so that it doesn't return escaped characters.
Wed, Apr 14, 1:15 PM · Abstract Wikipedia team

Tue, Apr 13

gengh claimed T279679: Switch page payload embedded ZObject from canonical to normal form, to be the same form as the API requests we make.
Tue, Apr 13, 2:11 PM · Abstract Wikipedia team (Phase δ), WikiLambda

Wed, Mar 31

gengh added a comment to T278733: Use local storage VUEX to reduce fetchZKeys requests.

Agreed, sounds good! Thanks :D

Wed, Mar 31, 8:46 AM · Abstract Wikipedia team (Phase δ), Abstract Wikipedia UX

Tue, Mar 30

gengh added a comment to T278733: Use local storage VUEX to reduce fetchZKeys requests.

Notice that this already happens in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/resources/ext.wikilambda.edit/components/ZObjectKeyList.vue#166 and https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/resources/ext.wikilambda.edit/components/ZObjectGeneric.vue#164

Tue, Mar 30, 10:41 AM · Abstract Wikipedia team (Phase δ), Abstract Wikipedia UX

Mon, Mar 29

gengh moved T278554: Change Hooks::createInitialContent to use the ZObjectStore from To triage to Phase γ on the Abstract Wikipedia team board.
Mon, Mar 29, 5:19 PM · Abstract Wikipedia team (Phase δ), Patch-For-Review, WikiLambda
gengh moved T278553: Change Vue app to create/edit ZObjects using new wikilambda_edit API instead of mw.api.create/edit from To triage to Phase γ on the Abstract Wikipedia team board.
Mon, Mar 29, 5:19 PM · Abstract Wikipedia team (Phase γ), WikiLambda, Abstract Wikipedia UX
gengh moved T278688: Remove ZTypeRegistry::revisterType and its tests (it's not used) from To triage to Phase γ on the Abstract Wikipedia team board.
Mon, Mar 29, 5:19 PM · Abstract Wikipedia team (Phase γ), WikiLambda
gengh claimed T278688: Remove ZTypeRegistry::revisterType and its tests (it's not used).
Mon, Mar 29, 11:11 AM · Abstract Wikipedia team (Phase γ), WikiLambda
gengh created T278688: Remove ZTypeRegistry::revisterType and its tests (it's not used).
Mon, Mar 29, 11:11 AM · Abstract Wikipedia team (Phase γ), WikiLambda

Fri, Mar 26

gengh updated the task description for T278554: Change Hooks::createInitialContent to use the ZObjectStore.
Fri, Mar 26, 3:39 PM · Abstract Wikipedia team (Phase δ), Patch-For-Review, WikiLambda
gengh claimed T278553: Change Vue app to create/edit ZObjects using new wikilambda_edit API instead of mw.api.create/edit.
Fri, Mar 26, 3:03 PM · Abstract Wikipedia team (Phase γ), WikiLambda, Abstract Wikipedia UX
gengh claimed T278554: Change Hooks::createInitialContent to use the ZObjectStore.
Fri, Mar 26, 3:03 PM · Abstract Wikipedia team (Phase δ), Patch-For-Review, WikiLambda
gengh created T278554: Change Hooks::createInitialContent to use the ZObjectStore.
Fri, Mar 26, 3:02 PM · Abstract Wikipedia team (Phase δ), Patch-For-Review, WikiLambda
gengh created T278553: Change Vue app to create/edit ZObjects using new wikilambda_edit API instead of mw.api.create/edit.
Fri, Mar 26, 3:00 PM · Abstract Wikipedia team (Phase γ), WikiLambda, Abstract Wikipedia UX

Thu, Mar 25

gengh created T278469: Adapt ZObjectViewer Vue component to use the zobject from the store.
Thu, Mar 25, 6:21 PM · Abstract Wikipedia team (Phase γ), WikiLambda, Abstract Wikipedia UX
gengh added projects to T278468: Agree on a convention for Vuex mutation naming.: Abstract Wikipedia UX, WikiLambda.
Thu, Mar 25, 6:19 PM · Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX
gengh created T278468: Agree on a convention for Vuex mutation naming..
Thu, Mar 25, 6:19 PM · Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX

Tue, Mar 23

gengh created T278228: Remove zid from ZTypeRegistry's cache when a known ZType is deleted.
Tue, Mar 23, 11:46 AM · WikiLambda, Abstract Wikipedia team (Phase γ)

Wed, Mar 17

gengh created T277673: Create ZArguments component.
Wed, Mar 17, 4:14 PM · WikiLambda, Abstract Wikipedia UX, Abstract Wikipedia team (Phase γ)
gengh created T277672: Create Z16/ZCode component.
Wed, Mar 17, 4:13 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase γ)
gengh assigned T276819: Allow mechanism for choosing mode within a type to SimoneThisDot.
Wed, Mar 17, 2:43 PM · Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX
gengh added a comment to T268296: Display to user why an object is not stored.

Closely related to (if not duplicate of) T276824

Wed, Mar 17, 10:43 AM · WikiLambda, Abstract Wikipedia team (Phase δ), Abstract Wikipedia UX
gengh assigned T268296: Display to user why an object is not stored to SimoneThisDot.
Wed, Mar 17, 10:42 AM · WikiLambda, Abstract Wikipedia team (Phase δ), Abstract Wikipedia UX

Mar 10 2021

gengh added a project to T277040: Update base components: Abstract Wikipedia UX.
Mar 10 2021, 1:44 PM · WikiLambda, Abstract Wikipedia team (Phase δ), Abstract Wikipedia UX
gengh created T277040: Update base components.
Mar 10 2021, 1:44 PM · WikiLambda, Abstract Wikipedia team (Phase δ), Abstract Wikipedia UX
gengh reassigned T276069: Create Z8/ZFunction Vue component from gengh to Lindsaykwardell.
Mar 10 2021, 10:09 AM · Patch-For-Review, Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX
gengh assigned T276824: Create a component to show error messages returned by the APIs to SimoneThisDot.
Mar 10 2021, 10:07 AM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX

Mar 8 2021

gengh created T276824: Create a component to show error messages returned by the APIs.
Mar 8 2021, 4:13 PM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX
gengh created T276823: Rethink "add key" input field.
Mar 8 2021, 4:12 PM · WikiLambda, Abstract Wikipedia team (Phase ε), Abstract Wikipedia UX
gengh created T276822: When having a ZReference, filter the types of options displayed to the type of the key.
Mar 8 2021, 4:11 PM · WikiLambda, Abstract Wikipedia team (Phase ε), Abstract Wikipedia UX
gengh created T276821: When a key is added and its type is known, preselect that type instead of showing type selector..
Mar 8 2021, 4:09 PM · Abstract Wikipedia team (Phase ε), WikiLambda, Abstract Wikipedia UX
gengh created T276819: Allow mechanism for choosing mode within a type.
Mar 8 2021, 4:06 PM · Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX
gengh created T276818: Create component ModeSelector to add it into the ZKey creation process.
Mar 8 2021, 4:04 PM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX
gengh claimed T276361: Special:CreateZObject always returning Z100 even if it exists?.
Mar 8 2021, 10:43 AM · WikiLambda, Abstract Wikipedia team (Phase δ)

Mar 5 2021

gengh claimed T276069: Create Z8/ZFunction Vue component.
Mar 5 2021, 10:49 AM · Patch-For-Review, Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX
gengh added a comment to T273564: Overlapping dropdown menus on Type selector.

As mentioned in the closed T276356, when selecting an element in the fake dropdown, the event is not being captured and so there's no value being accepted for the component even if the input form has a valid option as value.

Mar 5 2021, 9:12 AM · Abstract Wikipedia team (Phase γ), WikiLambda, Abstract Wikipedia UX
gengh closed T276356: When creating a Z17, no value is being 'locked in' for Z17K1 as Resolved.
Mar 5 2021, 9:01 AM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX
gengh added a comment to T276356: When creating a Z17, no value is being 'locked in' for Z17K1.

Closing this task, as it's a side-effect of T273564:

Mar 5 2021, 8:59 AM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX

Mar 4 2021

gengh added a comment to T273128: Documentation for the different API action modules.

Initial version documenting our three current APIs createad at https://www.mediawiki.org/wiki/Extension:WikiLambda/API

Mar 4 2021, 3:11 PM · Abstract Wikipedia team (Phase γ)

Mar 3 2021

gengh claimed T275395: Replace internal use of wikilambda_fetch with new API query wikilambdaload_zobjects.
Mar 3 2021, 12:16 PM · Abstract Wikipedia team (Phase δ)

Mar 1 2021

gengh created T276069: Create Z8/ZFunction Vue component.
Mar 1 2021, 11:28 AM · Patch-For-Review, Abstract Wikipedia team (Phase δ), WikiLambda, Abstract Wikipedia UX
gengh added a comment to T273561: Strings that look like references are stored as references.

With current work for T273560 the strings and references are being normalized every time we are in edit mode. Apart from this, I've removed from the ZString component the render of a link when the string matches a ZID. No link will be shown.

Mar 1 2021, 10:44 AM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase γ)

Feb 25 2021

gengh created T275779: Update name of the api parameters in ZObjectSelector .
Feb 25 2021, 2:46 PM · Abstract Wikipedia team (Phase γ)

Feb 22 2021

gengh created T275395: Replace internal use of wikilambda_fetch with new API query wikilambdaload_zobjects.
Feb 22 2021, 2:46 PM · Abstract Wikipedia team (Phase δ)
gengh claimed T271879: Rename HACK_ internal types for the ObjectFactory to something more durable.
Feb 22 2021, 2:20 PM · Abstract Wikipedia team (Phase γ)

Feb 10 2021

gengh added a comment to T273127: Define and implement new API action to replace the internal use of wikilambda-fetch.

Current components that use wikilambda_fetch API:

Feb 10 2021, 3:20 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ)

Feb 2 2021

gengh added a comment to T273321: Have the ZMultilingualString component fetch the list of allowed languages from an API.

Wonderful!!! Thanks, Gabriel :D

Feb 2 2021, 12:05 PM · Abstract Wikipedia UX, Abstract Wikipedia team
gengh added a comment to T273564: Overlapping dropdown menus on Type selector.

Hmm Chrome autofill might be doing that, yeah.

Feb 2 2021, 12:05 PM · Abstract Wikipedia team (Phase γ), WikiLambda, Abstract Wikipedia UX
gengh added a comment to T272630: Define interface for the function-evaluator.

Probably something that the evaluator will need is some kind of health check API so that the orchestrator (or/and anything working as load balancer) can check out availability of the different language services, or the current load state of these.

Feb 2 2021, 11:39 AM · Abstract Wikipedia team (Phase ε), function-evaluator

Feb 1 2021

gengh updated the task description for T273519: Add intermediate object ZObjectGeneric.
Feb 1 2021, 7:05 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX
gengh claimed T273519: Add intermediate object ZObjectGeneric.
Feb 1 2021, 7:03 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX
gengh created T273519: Add intermediate object ZObjectGeneric.
Feb 1 2021, 7:03 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX

Jan 29 2021

gengh created T273321: Have the ZMultilingualString component fetch the list of allowed languages from an API.
Jan 29 2021, 7:48 PM · Abstract Wikipedia UX, Abstract Wikipedia team
gengh created T273320: Create root App component so that either ZObjectEditor or ZObjectViewer are instantiated, instead of both..
Jan 29 2021, 7:33 PM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX
gengh created T273319: Disable re-selection of type in a ZObject that has its type already assigned..
Jan 29 2021, 7:19 PM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX

Jan 22 2021

gengh claimed T271878: Refactor the Vue component model.
Jan 22 2021, 11:23 AM · Epic, Patch-For-Review, Abstract Wikipedia team (Phase γ)

Jan 20 2021

gengh added a comment to T266267: Prefill keys when adding an object.

Some possible improvements over current behavior can be:

  • Adapt the API call to follow the Vuex store pattern: when adding an object, we can ask the store if it has the Zid information available, it will only follow through and make the API call if the Zid has not been fetched yet. The action fetchZkeys already does that, and handles the storage of both Zids and labels, so this could be used here as well.
  • When a type is selected during creation, initialize it with the labels as well.
  • When the type is changed, apart from adding the new labels, remove the labels that belonged to the previous type.
Jan 20 2021, 4:44 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase γ)

Jan 14 2021

gengh updated the task description for T271878: Refactor the Vue component model.
Jan 14 2021, 3:45 PM · Epic, Patch-For-Review, Abstract Wikipedia team (Phase γ)

Jan 13 2021

gengh added a comment to T269192: Rewrite the type selector.

Marked T270295 as parent, because TypeSelector should just really be a SelectZObject component with a configuration parameter, so that it filters the types of objects to display to only ZTypes.

Jan 13 2021, 5:30 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 12 2021

gengh added a comment to T270299: Fix two-way binding on the OtherKeys component.

Yes! Good one! As far as I've been able to test, the fields now keep their values when the object changes :D

Jan 12 2021, 2:49 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 8 2021

gengh added a comment to T268668: Keys should be displayed as labels in chosen language.

I checked jquery.i18n as suggested but I couldn't find a way to use it for our benefit. However, navigating a bit on codesearch I saw that few projects use mw.language.getFallbackLanguageChain() to get the array of the language fallback chain. I finally used this in the strategy to decide which label to display.

Jan 8 2021, 4:42 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 7 2021

gengh added a comment to T268668: Keys should be displayed as labels in chosen language.

You are right, for the key labels it should not be necessary to request anything to wikilambda_searchlabel, although we will need it for the type/zobject selector anyway, so thanks!!

Jan 7 2021, 3:06 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh added a comment to T270299: Fix two-way binding on the OtherKeys component.

One fast way to reproduce the error should be:

Jan 7 2021, 12:44 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 5 2021

gengh added a comment to T268668: Keys should be displayed as labels in chosen language.

@Jdforrester-WMF I am using wikilambda_searchlabels to get the labels in the user defined language, but somehow the language fallback doesn't seem to be working for me. For example:

Jan 5 2021, 6:13 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 4 2021

gengh claimed T268668: Keys should be displayed as labels in chosen language.
Jan 4 2021, 5:50 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh added a comment to T270295: Fix behaviour of SelectZObject component to make it more usable and similar to OOUI component.

A similar component implemented in Vue by the mediasearch team to the LookupElement mentioned above is this one:

Jan 4 2021, 1:11 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh claimed T270295: Fix behaviour of SelectZObject component to make it more usable and similar to OOUI component.
Jan 4 2021, 12:59 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Dec 18 2020

gengh claimed T270301: Minimize the times OtherKeys component calls wikilambda_fetch; create a global state manager?.
Dec 18 2020, 11:43 AM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Dec 17 2020

gengh added a comment to T270290: Fix direct mutations of properties..

Submitted two patches fixing this (actually, four), hopefully I've done this alright:

Dec 17 2020, 4:07 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh claimed T270290: Fix direct mutations of properties..
Dec 17 2020, 2:05 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Dec 16 2020

gengh updated the task description for T270304: Create a "Publish" component according to MediaWiki standards (minor edit, edit summary, copyright warning, watchlist state, etc.).
Dec 16 2020, 3:33 PM · Abstract Wikipedia team (Phase ζ), Abstract Wikipedia UX
gengh renamed T270304: Create a "Publish" component according to MediaWiki standards (minor edit, edit summary, copyright warning, watchlist state, etc.) from Save component should be according to mediawiki standards to Create a "Save" component according to mediawiki standards .
Dec 16 2020, 3:32 PM · Abstract Wikipedia team (Phase ζ), Abstract Wikipedia UX
gengh created T270304: Create a "Publish" component according to MediaWiki standards (minor edit, edit summary, copyright warning, watchlist state, etc.).
Dec 16 2020, 3:31 PM · Abstract Wikipedia team (Phase ζ), Abstract Wikipedia UX
gengh created T270301: Minimize the times OtherKeys component calls wikilambda_fetch; create a global state manager?.
Dec 16 2020, 3:29 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh created T270299: Fix two-way binding on the OtherKeys component.
Dec 16 2020, 3:20 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh created T270295: Fix behaviour of SelectZObject component to make it more usable and similar to OOUI component.
Dec 16 2020, 3:11 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh created T270290: Fix direct mutations of properties..
Dec 16 2020, 2:22 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
gengh created T270288: Take hardcoded labels in the front-end to a constants file.
Dec 16 2020, 2:14 PM · good first task, Abstract Wikipedia UX, Abstract Wikipedia team (Phase β)
gengh created T270287: Apply Vue.js coding conventions.
Dec 16 2020, 2:03 PM · Abstract Wikipedia team (Phase γ)

Dec 4 2020

gengh added a watcher for Abstract Wikipedia team: gengh.
Dec 4 2020, 2:01 PM

Dec 3 2020

gengh created T269365: Onboarding Genoveva, access request to ldap/wmf.
Dec 3 2020, 3:45 PM · SRE, LDAP-Access-Requests