Page MenuHomePhabricator

hashar (Antoine "hashar" Musso (WMF))
WMF Software developer - Release Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 2:31 PM (267 w, 2 d)
Availability
Available
IRC Nick
hashar
LDAP User
Hashar
MediaWiki User
Unknown

https://www.mediawiki.org/wiki/User:Hashar

Based in Nantes, France CET/CEST (UTC+1, UTC+2)

Main IRC channel is #wikimedia-releng

antoine-approve

Recent Activity

Yesterday

hashar added a comment to T70113: Alert when Zuul/Gearman queue is stalled.

The alarm got removed via https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/550943/ for some reason ...

Sun, Nov 17, 9:38 PM · Release-Engineering-Team, Patch-For-Review, observability, Continuous-Integration-Infrastructure
hashar added a comment to T236685: Migrate JJB usage --config-xml.

Note that JJB 3.0.x does not enforce it.

Sun, Nov 17, 7:39 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Jenkins, Continuous-Integration-Infrastructure

Fri, Nov 15

hashar updated the task description for T238250: Unconference: logspam - how do we have less / surface it to the right people?.
Fri, Nov 15, 6:36 PM · Wikimedia-Technical-Conference-2019
hashar added a comment to T238275: Unconference: [Workshop] CI counselling session.

That went well overall, we got some useful feedback and calls for actions.

Fri, Nov 15, 4:53 PM · Wikimedia-Technical-Conference-2019, Release-Engineering-Team (CI & Testing services)

Wed, Nov 13

hashar added a comment to T238203: Composer-merge-plugin might be suppressing errors.

In Quibble the composer update is run from the root of mediawiki/core which then uses the composer merge plugin which process the extension installation. I would guess the issue is that either the update done via the plugin is not bubbled up properly to the composer command or maybe its Quibble shallowing it.

Wed, Nov 13, 3:52 PM · Quibble, Continuous-Integration-Infrastructure
hashar triaged T238225: Quibble --git-cache should be configurable via a user .quibblerc file as Low priority.
Wed, Nov 13, 3:48 PM · Quibble
hashar created T238225: Quibble --git-cache should be configurable via a user .quibblerc file.
Wed, Nov 13, 3:48 PM · Quibble
hashar added a project to T238197: Jenkins fails for mediawiki/core: MediaWiki-Core-Testing.

It might be that this test is flapping / unreliable or has some kind of time based race condition?

Wed, Nov 13, 3:38 PM · MediaWiki-Core-Testing, Wikimedia-production-error (Shared Build Failure), ci-test-error, MediaWiki-General
hashar triaged T238197: Jenkins fails for mediawiki/core as High priority.
Wed, Nov 13, 3:33 PM · MediaWiki-Core-Testing, Wikimedia-production-error (Shared Build Failure), ci-test-error, MediaWiki-General
hashar updated subscribers of T235807: BlueSpice related tests fails on gate-and-submit-1.31 in quibble-composer tests.

There are some technical details at T224285#5216226

Wed, Nov 13, 3:30 PM · Continuous-Integration-Config, BlueSpice
hashar updated the task description for T234638: Wikimedia Technical Conference 2019 Session: Running tests locally: an introduction.
Wed, Nov 13, 2:15 PM · User-greg, International-Developer-Events, Wikimedia-Technical-Conference-2019
hashar added a comment to T238055: quibble-composer-mysql-php72-docker fails in MachineVision.

I think the confusion is caused by a late failure. The original error is from composer install, where one dependency requires wikimedia/assert:v0.4.0, and then wikibase-lexeme requires wikimedia/assert ([>= 0.2.2.0-dev < 0.3.0.0-dev]). Composer reports,

14:48:37 [500.2MB/9.66s] Your requirements could not be resolved to an installable set of packages.
14:48:37 [500.2MB/9.66s] 
14:48:37   Problem 1
14:48:37     - The requested package wikimedia/assert ~0.2.2 is satisfiable by wikimedia/assert[v0.2.2] but these conflict with your requirements or minimum-stability.

This should have immediately crashed the build. Instead, we start installing MediaWiki and run into missing classes caused by incomplete PHP libs installation.

Wed, Nov 13, 11:08 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata, Release-Engineering-Team (CI & Testing services), Quibble, Machine vision

Tue, Nov 12

hashar updated the task description for T234662: Wikimedia Technical Conference 2019 Session: Integrating contributions from other teams or volunteers.
Tue, Nov 12, 2:02 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
hashar updated the task description for T234662: Wikimedia Technical Conference 2019 Session: Integrating contributions from other teams or volunteers.
Tue, Nov 12, 1:53 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
hashar updated the task description for T237894: Archive the TimezoneSelector extension.
Tue, Nov 12, 11:37 AM · User-Zoranzoki21, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
hashar added a comment to T237894: Archive the TimezoneSelector extension.

And I have marked it read-only in Gerrit https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/TimezoneSelector

Tue, Nov 12, 11:37 AM · User-Zoranzoki21, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
hashar updated the task description for T237894: Archive the TimezoneSelector extension.
Tue, Nov 12, 11:37 AM · User-Zoranzoki21, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
hashar added a comment to T237894: Archive the TimezoneSelector extension.

I have abandoned a change was still opened https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimezoneSelector/+/422202/

Tue, Nov 12, 11:15 AM · User-Zoranzoki21, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup

Sun, Nov 10

hashar added a comment to T235118: Create an integration test running Quibble with mediawiki/core.

I thought I could reuse the releng/quibble-stretch-php72 container but it lacks pip to do the installation, though it has easy_install through setuptools. Maybe that is sufficient to install Quibble from a local clone/fetch.

Sun, Nov 10, 11:10 AM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Quibble
hashar added a comment to T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator.

(comment best seen via the web interface)

Sun, Nov 10, 10:58 AM · GerritBot, Phabricator, Code-Review-Workgroup
hashar triaged T237807: gerrit: scoring/ores/editquality takes a long time to git gc as Normal priority.
$ git count-objects -vH
count: 0
size: 0 bytes
in-pack: 9589
packs: 3
size-pack: 2.54 GiB
prune-packable: 0
garbage: 0
size-garbage: 0 bytes
Sun, Nov 10, 10:45 AM · Release-Engineering-Team-TODO, Release-Engineering-Team (Development services), Scoring-platform-team, Gerrit
hashar added a comment to T224448: Gerrit account cache has a faulty reentrant lock causing http/sendemail threads to stall completely.

Interestingly this may have been a kernel bug: https://gerrit-review.googlesource.com/c/gerrit/+/153090/4#message-10cc8f42c24c28b1cb29c441c9aff13684555654
So when we upgraded to buster, that came with a new kernel that included the fix!

Sun, Nov 10, 10:35 AM · Patch-For-Review, Upstream, Release-Engineering-Team-TODO, Release-Engineering-Team (Development services), serviceops-radar, Gerrit

Fri, Nov 8

hashar added a comment to T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator.

10/10 totally aced.

Fri, Nov 8, 3:11 PM · GerritBot, Phabricator, Code-Review-Workgroup
hashar closed T231869: Extension quibble-vendor-mysql-hhvm-docker failing with Undefined interface: Psr\Container\ContainerInterface as Resolved.

Assuming that got fixed somewhere :]

Fri, Nov 8, 2:35 PM · MediaWiki-General, Continuous-Integration-Config
hashar added a comment to T226945: Decide on future of running Phan tests on release branches.

You guys are amazing. As soon as the extras field is not needed anymore, lets definitely clear it up from the CI phan shell scripts :]

Fri, Nov 8, 2:21 PM · Patch-For-Review, Continuous-Integration-Config, phan, MW-1.32-release, MW-1.31-release, MediaWiki-Core-Testing
hashar awarded T235049: Upgrade mediawiki-phan-config to 0.8.0 for all repos a Love token.
Fri, Nov 8, 2:20 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, LibUp, phan
hashar added a parent task for T235049: Upgrade mediawiki-phan-config to 0.8.0 for all repos: T226945: Decide on future of running Phan tests on release branches.
Fri, Nov 8, 2:19 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, LibUp, phan
hashar added a subtask for T226945: Decide on future of running Phan tests on release branches: T235049: Upgrade mediawiki-phan-config to 0.8.0 for all repos.
Fri, Nov 8, 2:19 PM · Patch-For-Review, Continuous-Integration-Config, phan, MW-1.32-release, MW-1.31-release, MediaWiki-Core-Testing
hashar added a comment to T226945: Decide on future of running Phan tests on release branches.

I am not active on the Phan front, but could we imagine upgrading Phan in our release branches toward 0.8 to get rid of that extra in composer.json? It might be possible simply by adding some ignore/exclude for newly introduced rules we probably do not want to fix in release branches.

Fri, Nov 8, 2:11 PM · Patch-For-Review, Continuous-Integration-Config, phan, MW-1.32-release, MW-1.31-release, MediaWiki-Core-Testing
hashar edited projects for T235251: Gerrit replica does not support the 'query' command, added: Release-Engineering-Team; removed Release-Engineering-Team-TODO (201911), Release-Engineering-Team (Development services).

Out of the TODO queue; It is upstreamed and not a priority.

Fri, Nov 8, 2:03 PM · Release-Engineering-Team, wikimedia.biterg.io, Upstream, Gerrit
hashar added a comment to T234224: Gerrit workflow: "Merge review" AND "Open push" for BlueSpice?.

Yes, I actually want to push instead of review, as I just want to synchronize branches REL1_31 and REL1_31_dev. In REL1_31_dev everything has already been reviewed, so I don't want to review all those commits again when merging them into REL1_31. I believe the above workflow works just fine. The only issue is the Push permission. But there is a solution now.

Fri, Nov 8, 2:02 PM · Gerrit
hashar added a comment to T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator.

I guess that would address a feature I have listed T209463 namely for each task add a link to a Gerrit search query for bug:Txxxx ( https://gerrit.wikimedia.org/r/#/q/bug:T12345 ) :] I have marked it as a duplicate of your task :]

Fri, Nov 8, 11:41 AM · GerritBot, Phabricator, Code-Review-Workgroup
hashar merged task T209463: Add a link from Phabricator task to a Gerrit search for bug:TXXXXX into T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator.
Fri, Nov 8, 11:40 AM · Code-Review-Workgroup, Phabricator
hashar merged T209463: Add a link from Phabricator task to a Gerrit search for bug:TXXXXX into T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator.
Fri, Nov 8, 11:40 AM · GerritBot, Phabricator, Code-Review-Workgroup
hashar added a comment to T234638: Wikimedia Technical Conference 2019 Session: Running tests locally: an introduction.

@kostajh and I had several exchanges and we even prepared a quick slide deck. Seems we orient ourselves toward:

Fri, Nov 8, 9:51 AM · User-greg, International-Developer-Events, Wikimedia-Technical-Conference-2019
hashar added a subtask for T137890: Relocate CI generated docs and coverage reports: T237707: doc1001 permission problems.
Fri, Nov 8, 9:39 AM · serviceops, Release-Engineering-Team (Kanban), Patch-For-Review, Test-Coverage, Developer-Wishlist (2017), Technical-Debt, Continuous-Integration-Infrastructure
hashar added a subtask for T235715: Add Design Style Guide link to doc.wikimedia.org: T237707: doc1001 permission problems.
Fri, Nov 8, 9:39 AM · Wikimedia Design Style Guide (Wikimedia Design Style Guide v1.1), Design
hashar added parent tasks for T237707: doc1001 permission problems: T235715: Add Design Style Guide link to doc.wikimedia.org, T137890: Relocate CI generated docs and coverage reports.
Fri, Nov 8, 9:39 AM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
hashar claimed T237707: doc1001 permission problems.
Fri, Nov 8, 9:38 AM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
hashar added a comment to T237707: doc1001 permission problems.

The long story is at T235715#5588924

Fri, Nov 8, 9:07 AM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
hashar updated the post content for Blog Post: Production Excellence: October 2019.
Fri, Nov 8, 9:05 AM

Thu, Nov 7

hashar added a comment to T235715: Add Design Style Guide link to doc.wikimedia.org.

The issue we had should be addressed by:

Thu, Nov 7, 8:13 PM · Wikimedia Design Style Guide (Wikimedia Design Style Guide v1.1), Design
hashar closed T234328: biterg.io Gerrit crawling probably stresses the server too much as Resolved.

The bot is less active in the recent days. We have upgraded the Gerrit server meanwhile and have lot more memory allocated to the JVM.

Thu, Nov 7, 7:46 PM · Release-Engineering-Team-TODO (201911), Developer-Advocacy, wikimedia.biterg.io, Release-Engineering-Team (Development services), Gerrit
hashar awarded T232055: MW core doxygen / jsduck build should run for git tags (again) a Love token.
Thu, Nov 7, 7:29 PM · Patch-For-Review, Release-Engineering-Team-TODO, Continuous-Integration-Config
hashar added a comment to T237049: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed.

Awesome, thank you for the backport to REL1_34!

Thu, Nov 7, 1:56 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes, Core Platform Team Workboards (Clinic Duty Team), wikidiff2, Release-Engineering-Team-TODO (201911), MediaWiki-Page-Diffs, MediaWiki-General, ci-test-error
hashar added a comment to T234610: ERROR webdriver: Request failed due to Error: session not created: Chrome version must be between 70 and 73.

There are two issues:

Thu, Nov 7, 1:55 PM · Release-Engineering-Team-TODO (201911), MediaWiki-Core-Testing, Release-Engineering-Team (Unit & Int & System Tooling)
hashar renamed T237491: Archive labs/tools/discordwiki on Gerrrit from Delete labs/tools/discordwiki on Gerrrit to Archive labs/tools/discordwiki on Gerrrit.
Thu, Nov 7, 1:47 PM · User-MarcoAurelio, Cleanup, Patch-For-Review, Repository-Admins
hashar added a comment to T222166: Jessie rsyslog_8.1901.0-1~bpo8+wmf1_amd64.deb package fails to upgrade.

I did, that was in a sub task blocking this change.

Thu, Nov 7, 1:44 PM · Continuous-Integration-Infrastructure, Operations
hashar added a comment to T222166: Jessie rsyslog_8.1901.0-1~bpo8+wmf1_amd64.deb package fails to upgrade.

Really that is unfair, when all that was needed is to simply rebuild the Jessie base image :-\

Thu, Nov 7, 1:22 PM · Continuous-Integration-Infrastructure, Operations
hashar closed T227173: Please rebuild Jessie base image due to rsyslog upgrade breakage, a subtask of T222166: Jessie rsyslog_8.1901.0-1~bpo8+wmf1_amd64.deb package fails to upgrade, as Declined.
Thu, Nov 7, 1:22 PM · Continuous-Integration-Infrastructure, Operations
hashar closed T227173: Please rebuild Jessie base image due to rsyslog upgrade breakage as Declined.

the rsyslog package is broken on jessie and nobody care. The workaround to use when building a jessie instance is T222166#5147045

apt install rsyslog rsyslog-gnutls ; apt install rsyslog rsyslog-gnutls
Thu, Nov 7, 1:22 PM · Cloud-VPS, cloud-services-team, Continuous-Integration-Infrastructure
hashar added a comment to T228346: PHP 7.2 garbage collector segfault.

Else I guess this task can be closed with the resolution being PHP 7.2.22.

In that case, should we bump the minimum version the MW requires to 7.2.22? Would be good to decide this before 1.34.0 final ships.

Thu, Nov 7, 1:17 PM · Release-Engineering-Team-TODO, MW-1.35-release, Upstream, MediaWiki-General, PHP 7.2 support

Wed, Nov 6

hashar closed T236746: JJB is too slow as Resolved.

Before 3.1.0:

$ time ./utils/jjb-diff.sh
real	1m25,691s
user	1m22,462s
sys	0m1,487s
Wed, Nov 6, 2:26 PM · Release-Engineering-Team-TODO (201911), Upstream, Release-Engineering-Team (CI & Testing services), Jenkins, Continuous-Integration-Infrastructure
hashar updated subscribers of T225713: CPU scaling governor audit.

@Andrew @bd808 @aborrero can you look at updating the bios setting for some of the affected cloudvirt?

Wed, Nov 6, 2:20 PM · cloud-services-team (Kanban), Cloud-VPS, User-fgiunchedi, Operations
hashar added a comment to T232706: mwcore-phpunit-coverage-master times out after 5 hours.

All the builds since last capture:

Wed, Nov 6, 2:12 PM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar added a comment to T236675: Investigate Docker slowness between 18.06.2 and 18.09.7.

I guess I can do some profiling using perf record for both case and hope that perf diff would shows anything standing up. Else I guess I would attempt to bisect the affected Docker version. Then 18.06 -> 18.09 is a major change, 18.06 had the Docker daemon spawning the containers while 18.09 delegates that to containerd.io which is managed by systemd.

Wed, Nov 6, 2:02 PM · Release-Engineering-Team-TODO (201911), Patch-For-Review, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
hashar added a comment to T237491: Archive labs/tools/discordwiki on Gerrrit.

Whenever changes have been to the repository (see https://gerrit.wikimedia.org/r/#/q/project:labs/tools/discordwiki
), it is indeed better to archive the repository. Else all the review comments, approvals etc are lost :]

Wed, Nov 6, 12:53 PM · User-MarcoAurelio, Cleanup, Patch-For-Review, Repository-Admins
hashar added a comment to T228346: PHP 7.2 garbage collector segfault.

Thank you @Joe. From CI containers perspective adding a var_dump( 'PHP_VERSION' ); to Tim script:

$ cat fail.php|docker run --entrypoint=php --rm -i docker-registry.wikimedia.org/releng/php72:0.2.2-s1
string(53) "7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82+wmf1"
object(C)#2 (1) {
  ["p"]=>
  object(stdClass)#1 (1) {
    ["x"]=>
    array(1) {
      ["p"]=>
      *RECURSION*
    }
  }
}
$ cat fail.php|docker run --entrypoint=php --rm -i docker-registry.wikimedia.org/releng/php72:0.2.2-s2
string(47) "7.2.22-1+0~20190902.26+debian9~1.gbpd64eb7+wmf1"
object(C)#2 (1) {
  ["p"]=>
  object(stdClass)#1 (1) {
    ["x"]=>
    array(0) {
    }
  }
}
Wed, Nov 6, 10:42 AM · Release-Engineering-Team-TODO, MW-1.35-release, Upstream, MediaWiki-General, PHP 7.2 support
hashar added a comment to T218783: `scap clean` failure.

The error now more shows up since the cleaning has been disabled behind a feature flag by https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/502316/

Wed, Nov 6, 10:17 AM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO, Gerrit, Scap
hashar closed T225166: Gerrit crashed due to out of Heap as Resolved.

The heap size has been grown from 20G to 32G ( https://gerrit.wikimedia.org/r/545381 )

Wed, Nov 6, 10:07 AM · Release-Engineering-Team, serviceops, Gerrit
hashar added a comment to T236443: git review notes split brain.

Well done Tyler thank you :]

Wed, Nov 6, 10:02 AM · Wikimedia-Incident, Release-Engineering-Team-TODO (201910), Release-Engineering-Team (Development services), Gerrit
hashar added a project to T237470: Create and maintain somehow a list of repos mastered in GitHub (and in Differential): Release-Engineering-Team (Development services).

Github had a feature to declare a repository has being a mirror but it can no more be used. There is a hint at https://help.github.com/en/github/getting-started-with-github/finding-open-source-projects-on-github#open-source-projects-with-mirrors-on-github and an example is chromium/chromium:

Wed, Nov 6, 10:00 AM · Release-Engineering-Team (Development services), Gerrit, Differential, GitHub-Mirrors, Release-Engineering-Team-TODO
hashar reopened T237049: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed, a subtask of T236907: mwgate-composer-php72-docker missing php-intl, as Open.
Wed, Nov 6, 9:45 AM · Release-Engineering-Team-TODO (201911), Continuous-Integration-Infrastructure
hashar reopened T237049: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed as "Open".

That fix it for master but the release branches would face the same issue. The CI containers are the same for all branches and thus all include wikidiff2.
We might have to backport $wgDiffEngine to our previous releases (REL1_31, REL1_32 and REL1_33).

Wed, Nov 6, 9:45 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes, Core Platform Team Workboards (Clinic Duty Team), wikidiff2, Release-Engineering-Team-TODO (201911), MediaWiki-Page-Diffs, MediaWiki-General, ci-test-error
hashar added a comment to T236187: decom cobalt.

Thank you @Dzahn for all the clean up tasks!

Wed, Nov 6, 9:38 AM · serviceops, Operations
hashar closed T227766: Remove link to defunct https://rest.wikimedia.org/ on https://doc.wikimedia.org/, a subtask of T133001: Decom legacy ex-parsoidcache cxserver, citoid, and restbase service hostnames, as Resolved.
Wed, Nov 6, 9:18 AM · Core Platform Team (Needs Cleaning - Services Operations), Patch-For-Review, CX-cxserver, VisualEditor, Citoid, RESTBase, Traffic, Operations
hashar closed T227766: Remove link to defunct https://rest.wikimedia.org/ on https://doc.wikimedia.org/ as Resolved.

https://doc.wikimedia.org/ updated. Thank you!

Wed, Nov 6, 9:18 AM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201911), Patch-For-Review, Continuous-Integration-Config, good first bug, Documentation, RESTBase
hashar closed T164296: Missing XML files cause "Publish Performance test result report" as Resolved.
Wed, Nov 6, 8:57 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Growth-Team, Upstream, Jenkins, MediaWiki-extensions-GettingStarted, Continuous-Integration-Infrastructure
hashar changed the status of T236746: JJB is too slow from Stalled to Open.
Wed, Nov 6, 8:47 AM · Release-Engineering-Team-TODO (201911), Upstream, Release-Engineering-Team (CI & Testing services), Jenkins, Continuous-Integration-Infrastructure
hashar claimed T236746: JJB is too slow.
Wed, Nov 6, 8:47 AM · Release-Engineering-Team-TODO (201911), Upstream, Release-Engineering-Team (CI & Testing services), Jenkins, Continuous-Integration-Infrastructure

Tue, Nov 5

hashar added a comment to T236689: Upgrade integration/config to use Fabric 2.x / python3.

I thought about using spicerack written by volans but that is a different use case. The outcome of the discussion is probably that we should use scap to populate our deployment scripts and then just shell out to run those scripts. So eg:

ssh contint1001.wikimedia.org ci-deploy-docker
Tue, Nov 5, 8:27 PM · Release-Engineering-Team-TODO, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure
hashar added a project to T228346: PHP 7.2 garbage collector segfault: Upstream.

@tstarling did fill https://bugs.php.net/bug.php?id=78379 and some commits are in PHP 7.2.22 (see my previous comment T228346#5491809).

Tue, Nov 5, 8:23 PM · Release-Engineering-Team-TODO, MW-1.35-release, Upstream, MediaWiki-General, PHP 7.2 support
hashar added a project to T232678: Update JavaMelody on Gerrit to 1.80.0: Release-Engineering-Team-TODO.
Tue, Nov 5, 8:17 PM · Release-Engineering-Team-TODO, Release-Engineering-Team (Development services), Gerrit
hashar renamed T232678: Update JavaMelody on Gerrit to 1.80.0 from Update JavaMelody on Gerrit to 1.79.0 to Update JavaMelody on Gerrit to 1.80.0.
Tue, Nov 5, 8:17 PM · Release-Engineering-Team-TODO, Release-Engineering-Team (Development services), Gerrit
hashar awarded T237383: Close QA mailing list a Like token.
Tue, Nov 5, 8:08 PM · Wikimedia-Mailing-lists, Operations, Release-Engineering-Team-TODO (201911), User-zeljkofilipin
hashar added a comment to T237335: AnonPrivacy breaks Special:RecentChanges, so quibble-vendor-mysql-php72-docker fails when running core's selenium tests.

I have marked the build to be kept for ever https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/28791/ in the build artifacts there is mw-error.log which has errors such as:

Tue, Nov 5, 1:08 PM · MediaWiki-extensions-Other, User-Zoranzoki21
hashar updated the task description for T237335: AnonPrivacy breaks Special:RecentChanges, so quibble-vendor-mysql-php72-docker fails when running core's selenium tests.
Tue, Nov 5, 1:05 PM · MediaWiki-extensions-Other, User-Zoranzoki21

Mon, Nov 4

hashar added a comment to T236680: Enable API integration tests in CI for MediaWiki core.

Once api-testing is made a npm package, each extension interested in having such tests would add the module to its package.json. Then we can establish a convention that there must be npm script defined. Quibble can then process each extension and run the suite if that script is present.

Mon, Nov 4, 9:04 PM · CPT Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
hashar added a comment to T237049: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed.

$wgExternalDiffEngine defaults to false which also mean it would first use wikidiff2 when the function wikidiff2_do_diff is detected. There is no way to force the php native one :-\

Mon, Nov 4, 8:53 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes, Core Platform Team Workboards (Clinic Duty Team), wikidiff2, Release-Engineering-Team-TODO (201911), MediaWiki-Page-Diffs, MediaWiki-General, ci-test-error
hashar added a comment to T220586: Quibble to output markers for processing its output.

Yes, try it and see whether we can parse them with the Jenkins Collapsible plugin :]

Mon, Nov 4, 8:00 PM · Quibble
hashar removed a watcher for Gerrit-Privilege-Requests: hashar.
Mon, Nov 4, 7:57 PM
hashar added a comment to T236746: JJB is too slow.

Both changes got merged. Pending release.

Mon, Nov 4, 7:15 PM · Release-Engineering-Team-TODO (201911), Upstream, Release-Engineering-Team (CI & Testing services), Jenkins, Continuous-Integration-Infrastructure
hashar assigned T236019: Remove HHVM support from Quibble to awight.
Mon, Nov 4, 10:47 AM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Quibble, HHVM
hashar closed T237207: Docker image missing for php-compile-php72-docker as Resolved.

Did a recheck and Awight even +2ed both patches:

Mon, Nov 4, 9:11 AM · Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201911), ci-test-error
hashar edited projects for T237207: Docker image missing for php-compile-php72-docker , added: Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config; removed Release-Engineering-Team.

That has been broken since October 15th due to https://gerrit.wikimedia.org/r/#/c/integration/config/+/543170/2/jjb/php-extensions.yaml which supposedly should have changed the job to use an image with php 7.2.22 but the image version is wrong.

Mon, Nov 4, 9:06 AM · Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201911), ci-test-error

Thu, Oct 31

hashar added a watcher for Gerrit-Privilege-Requests: hashar.
Thu, Oct 31, 11:25 PM
hashar added a comment to T237004: mediawiki/tools/codesniffer phpunit coverage fatal error.

I had the issue on my local machine (php7.3). I have just run composer install ./vendor/bin/phpunit --coverage-clover clover.xml.

Thu, Oct 31, 3:57 PM · MediaWiki-Codesniffer
hashar added a comment to T234418: Upgrade our php-xdebug package for php7.2.

I have rebuild the container, updated a job, ran perf top -g -p on the php process. getpid() is gone \o/

Thu, Oct 31, 3:21 PM · Patch-For-Review, serviceops, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar added a comment to T232706: mwcore-phpunit-coverage-master times out after 5 hours.
  • the CI instances are back to Docker 18.06.2
  • the job uses a container with an updated xdebug ( docker-registry.wikimedia.org/releng/quibble-coverage:0.0.39-s3 )
Thu, Oct 31, 3:14 PM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar closed T234418: Upgrade our php-xdebug package for php7.2, a subtask of T232706: mwcore-phpunit-coverage-master times out after 5 hours, as Resolved.
Thu, Oct 31, 3:10 PM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar closed T234418: Upgrade our php-xdebug package for php7.2 as Resolved.

All good thank you @jijiki !

Thu, Oct 31, 3:10 PM · Patch-For-Review, serviceops, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar reopened T234418: Upgrade our php-xdebug package for php7.2 as "Open".

Gotta rebuild the CI containers and switch jobs to it ;]

Thu, Oct 31, 2:26 PM · Patch-For-Review, serviceops, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar reopened T234418: Upgrade our php-xdebug package for php7.2, a subtask of T232706: mwcore-phpunit-coverage-master times out after 5 hours, as Open.
Thu, Oct 31, 2:26 PM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar added a comment to T234418: Upgrade our php-xdebug package for php7.2.

So I have downloaded https://people.wikimedia.org/~jiji/php-xdebug_2.7.0-1+wmf2_amd64.deb

Thu, Oct 31, 1:40 PM · Patch-For-Review, serviceops, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar added a comment to T237004: mediawiki/tools/codesniffer phpunit coverage fatal error.

Well actually it is due to the PHPUnit 6 upgrade which has been done by 6edf7d939f499137e40aab1aca2739ce5ce4d805

Thu, Oct 31, 1:00 PM · MediaWiki-Codesniffer
hashar created T237004: mediawiki/tools/codesniffer phpunit coverage fatal error.
Thu, Oct 31, 12:53 PM · MediaWiki-Codesniffer
hashar assigned T234418: Upgrade our php-xdebug package for php7.2 to jijiki.

Phabricator edit conflict. @jijiki is indeed working on it :]

Thu, Oct 31, 11:34 AM · Patch-For-Review, serviceops, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
hashar added a comment to T236994: https://doc.wikimedia.org/Wikibase/master/php/namespaces.html doesnt list a Client namespace, but Wikibase does have one.

I guess we want:

# If the EXTRACT_ALL tag is set to YES, doxygen will assume all entities in
# documentation are documented, even if no documentation was available. Private
# class members and static file members will be hidden unless the
# EXTRACT_PRIVATE respectively EXTRACT_STATIC tags are set to YES.
# Note: This will also disable the warnings about undocumented members that are
# normally produced when WARNINGS is set to YES.
# The default value is: NO.
Thu, Oct 31, 11:13 AM · User-Addshore, Wikidata, Documentation, Continuous-Integration-Infrastructure
hashar added a comment to T236994: https://doc.wikimedia.org/Wikibase/master/php/namespaces.html doesnt list a Client namespace, but Wikibase does have one.

Heading to docs/php/namespaces.html that shows:

Wikibase	
  Lib	-file-suppress PhanTypeInvalidThrowsIsInterface
  Repo
    Specials	
      HTMLForm	-file-suppress PhanParamSignatureMismatch The point of this class is to change signatures
Thu, Oct 31, 10:58 AM · User-Addshore, Wikidata, Documentation, Continuous-Integration-Infrastructure
hashar renamed T236675: Investigate Docker slowness between 18.06.2 and 18.09.7 from Investigate Stretch VM being slower than Jessie VM to Investigate Docker slowness between 18.06.2 and 18.09.7.
Thu, Oct 31, 9:20 AM · Release-Engineering-Team-TODO (201911), Patch-For-Review, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure