Page MenuHomePhabricator

hashar (Antoine Musso)
LogisticsAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 2:31 PM (426 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
hashar
LDAP User
Hashar
MediaWiki User
Unknown

https://www.mediawiki.org/wiki/User:Hashar

I am based in France CET/CEST (UTC+1, UTC+2). I have been a volunteer since ~ 2002 and employed at the Wikimedia Foundation since 2011.

My team is Release-Engineering-Team in which I notably maintain Jenkins Zuul Gerrit Continuous-Integration-Infrastructure Continuous-Integration-Config and various other things such as running the weekly MediaWiki deployment.

The preferred ways to reach me are:

IRC Libera.Chat

  • #wikimedia-releng
  • #wikimedia-operations
  • Direct message /query hashar

File a task in Phabricator and subscribe me to it (@hashar).

Email, Slack etc are read on an inconsistent best effort basis

Recent Activity

Yesterday

hashar added a comment to T323754: Investigate Gerrit h2 cache being way too large.

After looking at the H2 Database source code 'see below) we might be able to set MAX_COMPACT_TIME via a system setting: -Dh2.maxCompactTime. It is not explicitly mentioned in the documentation but the code seems to look up the properties:

version-1.3.176/h2/src/main/org/h2/engine/SettingsBase.java
/**
 * Get the setting for the given key.
 *
 * @param key the key
 * @param defaultValue the default value
 * @return the setting
 */
protected String get(String key, String defaultValue) {
    StringBuilder buff = new StringBuilder("h2.");
    boolean nextUpper = false;
    for (char c : key.toCharArray()) {
        if (c == '_') {
            nextUpper = true;
        } else {
            // Character.toUpperCase / toLowerCase ignores the locale
            buff.append(nextUpper ? Character.toUpperCase(c) : Character.toLowerCase(c));
            nextUpper = false;
        }
    }
    String sysProperty = buff.toString();
    String v = settings.get(key);
    if (v == null) {
        v = Utils.getProperty(sysProperty, defaultValue);
        settings.put(key, v);
    }
    return v;
}
Mon, Dec 5, 3:44 PM · Gerrit, Sustainability (Incident Followup)
hashar added a comment to T324394: test-prio job for operations/puppet/+/863332/2 stuck.

Indeed I have restarted Zuul after I got ping on IRC about some merge failures occurring. It is indeed the same as T309376.

Mon, Dec 5, 1:53 PM · Continuous-Integration-Config
hashar added a comment to T214068: Display Zuul status of jobs for a change on Gerrit UI.

I have posted to wikitech-l how one can try out the plugin locally: https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/message/3ULF5NPVC4MSVABZBSXAMDODLZUKFXHS/ . That should provide a bit of feedback and bug reporting before deploying it live.

Mon, Dec 5, 1:47 PM · Patch-For-Review, Release-Engineering-Team (Seen), Gerrit, Zuul, Continuous-Integration-Infrastructure

Sun, Dec 4

hashar added a comment to T321350: Phabricator translations can no more be received due to decommissioning of git-ssh.

L10n-bot doesn't do a direct push in Gerrit, so we would need the default l10n-bot(-watcher) permissions and i18n-check on this repo.

We could also look into making it into a direct push, but I think former is preferable.

Sun, Dec 4, 9:32 AM · Patch-For-Review, Unplanned-Sprint-Work, Language-Team (Language-2022-October-December), Release-Engineering-Team, translatewiki.net, Phabricator

Fri, Dec 2

hashar closed T256575: Jenkins comments no longer formatted on Gerrit 3 as Declined.

I gave it a try using a JavaScript plugin that would crawl the DOM for reported message, parse the messages emitted by Zuul and replace the inner HTML by a nicer version. I had several issue cause I could not reliably catch the elements being rendered to hijack the content and I could not find out how to catch an event such as one clicking on a comment to collapse/uncollapse it. Essentially the code was fragile.

Fri, Dec 2, 9:58 AM · Release-Engineering-Team (Seen), Developer Productivity, Continuous-Integration-Config, Gerrit
hashar closed T256575: Jenkins comments no longer formatted on Gerrit 3, a subtask of T254158: Gerrit 3.2 upgrade, as Declined.
Fri, Dec 2, 9:58 AM · Patch-For-Review, Gerrit

Thu, Dec 1

hashar added a comment to T324262: Gitlab message after push point to a 404 merge request URL when not logged in.

(I filed that one before I forget, I haven't looked into upstream issue tracker)

Thu, Dec 1, 9:14 PM · GitLab
hashar created T324262: Gitlab message after push point to a 404 merge request URL when not logged in.
Thu, Dec 1, 9:13 PM · GitLab
hashar added a comment to T323262: gerrit1001 running out of space on /.

@Jelto thank you for the excellent analysis about monitoring. I will look at integrating that to the deployment runbook we have at https://wikitech.wikimedia.org/wiki/Gerrit/Upgrade#Deploying

Thu, Dec 1, 3:13 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar updated the task description for T323754: Investigate Gerrit h2 cache being way too large.
Thu, Dec 1, 3:05 PM · Gerrit, Sustainability (Incident Followup)
hashar added a comment to T323262: gerrit1001 running out of space on /.

Sorry for lack of update. I did dig into the Gerrit cache which are backed up by H2 Database. Some finding are at T323754 and it looks like the easiest path is to empty up the cache and let Gerrit regenerate them. That would include deleting the web session cache which would logout every single users, which I don't think it is a problem granted some announcement is made before the operation. I will look at scheduling that at some point next week.

Thu, Dec 1, 2:57 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar added a comment to T323985: Parsoid LanguageConverter test failures on wmf.12.

Daniel and I talked about it this morning.

Thu, Dec 1, 10:01 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), MediaWiki-Language-converter, I18n, Parsoid

Tue, Nov 29

hashar added a comment to P41716 (An Untitled Masterwork).

The reason was that all 3 containers were added in the hosts file with 127.0.0.1. So it tries to ssh to itself and that broke the world. Solved by updating podman compose to a more recent (with a new way to do networking) and installing dnsmasq locally to enable a DNS resolver local to the pod. Another couple fixes needed:

Tue, Nov 29, 4:10 PM
hashar created P41716 (An Untitled Masterwork).
Tue, Nov 29, 1:24 PM

Mon, Nov 28

hashar added a comment to T238720: Deprecate and disable port 80 for one-off sites under canonical domains.

For Gerrit, I have made the announcement on wikitech-l: Gerrit now forbids plain HTTP.

Mon, Nov 28, 9:53 AM · Traffic, Patch-For-Review, SRE
hashar added a comment to T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.

@hashar Afaik for PHPUnit we only install (and thus test) dependency extensions, based on the dependency map in CI config. Is this not the case for the Selenium job? If there's a default list applied also, perhaps we can opt-out from that for the Selenium job.

Mon, Nov 28, 8:27 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Release-Engineering-Team (Priority Backlog 📥), MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Patch-For-Review, Developer Productivity, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Tests, Continuous-Integration-Config

Fri, Nov 25

hashar added a comment to T323654: Coverage documentation text generated on phpunit/php-code-coverage 9.2.19 is too large.

Nice finding @Reedy :)

Fri, Nov 25, 7:53 AM · Upstream, Continuous-Integration-Infrastructure

Thu, Nov 24

hashar added a comment to T323259: Investigate changes having a wrong server id.

We have gerrit.serverId set to e9e9afe9-4712-486d-8885-f54b72dd1951 since December 2016 commit 15bc9b80a7a91c54567d3fb63442ac13c955e603.

Thu, Nov 24, 8:49 PM · Gerrit
hashar updated the task description for T323259: Investigate changes having a wrong server id.
Thu, Nov 24, 8:44 PM · Gerrit
hashar updated the task description for T323262: gerrit1001 running out of space on /.
Thu, Nov 24, 8:42 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar added a comment to T323754: Investigate Gerrit h2 cache being way too large.

maxCompactTime
Database setting MAX_COMPACT_TIME (default: 200).

Thu, Nov 24, 12:26 PM · Gerrit, Sustainability (Incident Followup)
hashar added a comment to T323754: Investigate Gerrit h2 cache being way too large.

And to get a SQL prompt:

java -cp h2-1.3.176.jar org.h2.tools.Shell -url 'jdbc:h2:file:./git_file_diff;IFEXISTS=TRUE'
Thu, Nov 24, 12:10 PM · Gerrit, Sustainability (Incident Followup)
hashar added a comment to T323754: Investigate Gerrit h2 cache being way too large.

I did a few wrong things:

Thu, Nov 24, 11:50 AM · Gerrit, Sustainability (Incident Followup)
hashar updated the task description for T323754: Investigate Gerrit h2 cache being way too large.
Thu, Nov 24, 8:53 AM · Gerrit, Sustainability (Incident Followup)
hashar created T323754: Investigate Gerrit h2 cache being way too large.
Thu, Nov 24, 8:53 AM · Gerrit, Sustainability (Incident Followup)
hashar added a comment to T323750: Provide early feedback when a patch has job failures.

Ideally Zuul would report immediately when it knows that a change is not going to pass. As you found out that is T248531 which probably should be declined given I don't want to make any change to the legacy forked Zuul code were are using.

Thu, Nov 24, 8:29 AM · Developer Productivity, Continuous-Integration-Infrastructure, Quibble

Tue, Nov 22

hashar added a comment to T214068: Display Zuul status of jobs for a change on Gerrit UI.

As a teaser I found a way to load the plugin against our own instance (using incognito mode to be sure and the Chromium extension [[ chrome://extensions/?id=jimgomcnodkialnpmienbomamgomglkd | Gerrit FE Dev Helper ]].

Tue, Nov 22, 11:19 PM · Patch-For-Review, Release-Engineering-Team (Seen), Gerrit, Zuul, Continuous-Integration-Infrastructure
hashar added a comment to F35814298: Zuul 2.5 report in Gerrit Checks UI.

Made against https://gerrit.wikimedia.org/r/c/mediawiki/core/+/859146/4 side loading the plugin https://gerrit.wikimedia.org/r/c/operations/software/gerrit/+/859083/4

Tue, Nov 22, 11:08 PM

Mon, Nov 21

Krinkle awarded T214068: Display Zuul status of jobs for a change on Gerrit UI a Love token.
Mon, Nov 21, 6:40 PM · Patch-For-Review, Release-Engineering-Team (Seen), Gerrit, Zuul, Continuous-Integration-Infrastructure
hashar added a comment to T214068: Display Zuul status of jobs for a change on Gerrit UI.

It is merely a proof of concept:

Mon, Nov 21, 6:33 PM · Patch-For-Review, Release-Engineering-Team (Seen), Gerrit, Zuul, Continuous-Integration-Infrastructure

Thu, Nov 17

hashar added a comment to P8606 gerritUsernameToLowercase.sh.

This script has been used to migrate Gerrit accounts in the gerrit: scheme to be all lower case which was done for T216605.

Thu, Nov 17, 8:59 PM
hashar updated the task description for T323262: gerrit1001 running out of space on /.
Thu, Nov 17, 4:43 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar updated the task description for T323262: gerrit1001 running out of space on /.
Thu, Nov 17, 4:37 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar updated the task description for T323262: gerrit1001 running out of space on /.
Thu, Nov 17, 3:11 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar closed T287189: Gitiles monospaced text is bolded again as Resolved.

We have upgraded to Gerrit 3.5.4 (T307334) which upgrades the gitiles plugin which does have @QChris fix.

Thu, Nov 17, 3:06 PM · Upstream, Gerrit (Gerrit 3.5), Regression
hashar closed T315445: Update Gerrit CI result table CSS style as Resolved.

That has been addressed and the Gerrit 3.5 obsolete @apply statement has been removed.

Thu, Nov 17, 3:04 PM · Release-Engineering-Team (Priority Backlog 📥), Patch-For-Review, Gerrit (Gerrit 3.5)
hashar closed T315445: Update Gerrit CI result table CSS style, a subtask of T307334: Upgrade to Gerrit 3.5, as Resolved.
Thu, Nov 17, 3:04 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar edited projects for T192666: Gerrit's New UI reply dialog ignores Ctrl-Z, added: Gerrit (Gerrit 3.6); removed Gerrit (Gerrit 3.5).

Still happening on our Gerrit 3.5.4.

Thu, Nov 17, 3:03 PM · Gerrit (Gerrit 3.6), Upstream
hashar edited projects for T219809: Triple-clicking in Gerrit doesn't work with firefox (was: change subject selects unwanted space at the beginning), added: Gerrit (Gerrit 3.6); removed Gerrit (Gerrit 3.5).

After upgrading to Gerrit 3.5.4 (T307334), the triple clicking on the first line of the commit message still does NOT work on Firefox. A workaround is the change title can be copied to the clipboard via a paperclip icon.

Thu, Nov 17, 3:02 PM · Gerrit (Gerrit 3.6), Upstream
hashar closed T322964: reviewer comments missing on a specific change as Resolved.

Fixed after I have upgraded to Gerrit 3.5.4 this morning (T307334):

Thu, Nov 17, 2:59 PM · Gerrit (Gerrit 3.5)
hashar closed T307334: Upgrade to Gerrit 3.5 as Resolved.

We are on Gerrit 3.5.4 there are a few UI changes which would probably trigger some discussions here and there but overall everything else is working as far as I can tell.

Thu, Nov 17, 2:55 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar closed T307334: Upgrade to Gerrit 3.5, a subtask of T287189: Gitiles monospaced text is bolded again, as Resolved.
Thu, Nov 17, 2:55 PM · Upstream, Gerrit (Gerrit 3.5), Regression
hashar added a project to T323262: gerrit1001 running out of space on /: Gerrit.
Thu, Nov 17, 2:48 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar added a comment to T323262: gerrit1001 running out of space on /.

I have marked with Sustainability (Incident Followup) and SRE-OnFire based on the incident report template.

Thu, Nov 17, 2:48 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar moved T323262: gerrit1001 running out of space on / from Backlog to Pending Review & Scorecard on the SRE-OnFire board.
Thu, Nov 17, 2:45 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar added a project to T323262: gerrit1001 running out of space on /: SRE-OnFire.
Thu, Nov 17, 2:45 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
Urbanecm awarded T321203: scap backport CR+2 a change that has already been merged a Like token.
Thu, Nov 17, 2:35 PM · Scap
hashar added a project to T323262: gerrit1001 running out of space on /: Sustainability (Incident Followup).

@jcrespo I am writing the incident report at https://wikitech.wikimedia.org/wiki/Incidents/2022-11-17_Gerrit_3.5_upgrade ;)

Thu, Nov 17, 1:27 PM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar updated the task description for T323262: gerrit1001 running out of space on /.
Thu, Nov 17, 11:55 AM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar added a comment to T323262: gerrit1001 running out of space on /.

Largest H2 files:

-rw-r--r--  1 gerrit2 gerrit2 8.2G Nov 17 11:47 git_file_diff.h2.db
-rw-r--r--  1 gerrit2 gerrit2  12G Nov 17 11:47 gerrit_file_diff.h2.db
Thu, Nov 17, 11:51 AM · Release-Engineering-Team (GitLab III: GitLab in LA 🪃), Gerrit, SRE-OnFire, Sustainability (Incident Followup), Wikimedia-Incident, serviceops-collab
hashar added a comment to T307334: Upgrade to Gerrit 3.5.

The indexing completed at roughlly 11:05 UTC. That caused Gerrit to be automatically started either by Puppet or systemd. It had some more disk space issue.

Thu, Nov 17, 11:46 AM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar created T323259: Investigate changes having a wrong server id.
Thu, Nov 17, 10:57 AM · Gerrit
hashar added a comment to T307334: Upgrade to Gerrit 3.5.

I have started a full offline reindexing at 9:56 UTC.

Thu, Nov 17, 10:15 AM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar added a comment to T307334: Upgrade to Gerrit 3.5.

The update had some issues:

Thu, Nov 17, 10:14 AM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)

Wed, Nov 16

hashar closed T228084: Support posting screenshots in Gerrit as Declined.

I have asked the upstream authors and the plugin is indeed legacy. It would need a complete rewrite of the UI part and probably some addition to Gerrit UI itself. It was not wide spread used by them and they have choose to discontinue it.

Wed, Nov 16, 5:49 PM · Upstream, Gerrit
hashar added a comment to T307334: Upgrade to Gerrit 3.5.

I have scheduled the upgrade for tomorrow Thursday November 17th at 9:00 UTC which is just after the backport window. https://wikitech.wikimedia.org/wiki/Deployments#Thursday%2C_November_17

Wed, Nov 16, 3:58 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar updated the task description for T262944: Do not expand large files (like package-lock.json) by default when `Expand All` is clicked.
Wed, Nov 16, 10:32 AM · Gerrit
hashar closed T70598: Gerrit email subject line should distinguish between "has posted comments on this change" and " I'd like you to reexamine a change." as Declined.

Gerrit now has the attention set feature ( https://gerrit.wikimedia.org/r/Documentation/user-attention-set.html ) which should help keeping track of changes one has to act on.

Wed, Nov 16, 10:24 AM · Gerrit
hashar added a comment to T228084: Support posting screenshots in Gerrit.

You can either configure the inbuilt image server or use an external one, see https://gerrit.googlesource.com/plugins/imagare/+/refs/heads/master/src/main/resources/Documentation/about.md

Wed, Nov 16, 10:16 AM · Upstream, Gerrit
hashar closed T323135: Fix up Gerrit duplicate LDAP external ids as Resolved.

Upstream script contrib/find-duplicate-usernames.sh no more reports any duplicate against username:, gerrit: or external: scheme \o/

Wed, Nov 16, 9:16 AM · Gerrit
hashar closed T323135: Fix up Gerrit duplicate LDAP external ids, a subtask of T307334: Upgrade to Gerrit 3.5, as Resolved.
Wed, Nov 16, 9:16 AM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar added a comment to T323135: Fix up Gerrit duplicate LDAP external ids.

And this morning I thought: what about upper case unicode characters? There are three such accounts found by matching against unicode characters having the property letter + uppercase which in pcre is \p{Lu}.

0e/9f1ce0b97ba6f98633efb889ade8e90704d797
[externalId "gerrit:Ál"]  # LDAP account
	accountId = 2172
	email = al@blogmail.cc
Wed, Nov 16, 8:38 AM · Gerrit

Tue, Nov 15

Krinkle awarded T323135: Fix up Gerrit duplicate LDAP external ids a Love token.
Tue, Nov 15, 10:07 PM · Gerrit
hashar added a comment to T323135: Fix up Gerrit duplicate LDAP external ids.

I have pushed a commit to All-Users.git to adjust all those accounts (cecd04c3ccd7b40097b753d0c7226b6861c6d5a2).

Tue, Nov 15, 8:19 PM · Gerrit
hashar added a comment to T323135: Fix up Gerrit duplicate LDAP external ids.

Most of the 199 accounts having an upper case letter are the same as the lower case version (checked with diff -i). I though 7 accounts that had a mismatch:

Tue, Nov 15, 7:59 PM · Gerrit
hashar added a comment to T323135: Fix up Gerrit duplicate LDAP external ids.

I have verified all of the Gerrit external ids for LDAP (scheme gerrit:) having an upper case letter have an equivalent all lower case. The only differences I have spotted is some email addresses have been updated.

Tue, Nov 15, 4:57 PM · Gerrit
hashar updated subscribers of T323135: Fix up Gerrit duplicate LDAP external ids.

The reason is we have ldap.localUsernameToLowerCase=true. The upstream script to do the conversion had issue and instead @thcipriani crafted a shell script for that:

1#!/usr/bin/env bash
2#
3# Gerrit Username To Lowercase
4# =====================
5#
6# Script for converting gerrit:-scheme usernames to lowercase directly
7# in a checkout of refs/meta/external-ids of the All-Users git repo.
8#
9# Copyright: Tyler Cipriani <tcipriani@wikimedia.org> 2019
10# License: GPLv3+
11
12# Utility logging methods
13info() {
14 printf '[INFO] %s' "$@"
15}
16println() {
17 printf '%s\n' "$@"
18}
19
20# Convert username with gerrit: schema to lowercase
21#
22# accepts a username as a mixed case string without a schema by:
23#
24# 1. Convert username mixed case to username lowercase
25# 2. Compute sha1sum of lowercase schema for use as new file name
26# 3. Find the old file name using git grep
27# 4. Git move the old file to the new file path (computed with sha1sum)
28# 5. Replace the username mixed-case in the new file with username lowercase
29#
30# param username: string, mixed case
31usernameToLower() {
32 local username username_lower shasum new_file old_file
33
34 username="$1"
35 username_lower="${username,,}"
36
37 shasum=$(printf "gerrit:%s" "${username_lower}" | shasum -a 1)
38
39 new_file=$(printf '%s/%s\n' "${shasum:0:2}" "${shasum:2:38}")
40 old_file=$(git grep --full-name --files-with-matches "\"gerrit:${username}\"")
41
42 if [ -f "$new_file" ]; then
43 println "The new file '${new_file}' exists!!!! for '${username}'. Aborting!"
44 exit 1
45 fi
46
47 git mv "$old_file" "$new_file"
48
49 # Change username to lowercase in new file
50 sed -i "s/gerrit:${username}/gerrit:${username_lower}/" "$new_file"
51}
52
53# Find any gerrit:-schema users with capital letters
54# Look to see if there is a lowercase version
55# If not, convert user to lowercase
56main() {
57 while read -r user; do
58 # Grep for lowercase user
59 if git grep "\\[externalId \"gerrit:${user,,}\"\\]" &>/dev/null; then
60 continue
61 fi
62 info "Converting ${user}..."
63 usernameToLower "$user"
64 println "DONE!"
65 done < <(git grep -P 'gerrit:.*[A-Z]+.*' | sed -e 's/.*:\[externalId "gerrit:\(.*\)"]/\1/')
66}
67
68main "$@"

Tue, Nov 15, 4:52 PM · Gerrit
hashar added a parent task for T323135: Fix up Gerrit duplicate LDAP external ids: T307334: Upgrade to Gerrit 3.5.
Tue, Nov 15, 4:35 PM · Gerrit
hashar added a subtask for T307334: Upgrade to Gerrit 3.5: T323135: Fix up Gerrit duplicate LDAP external ids.
Tue, Nov 15, 4:35 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar created T323135: Fix up Gerrit duplicate LDAP external ids.
Tue, Nov 15, 4:34 PM · Gerrit
hashar added a parent task for T323097: Fix up Gerrit usernames having upper case character(s): T307334: Upgrade to Gerrit 3.5.
Tue, Nov 15, 3:42 PM · Release-Engineering-Team, Gerrit
hashar added a subtask for T307334: Upgrade to Gerrit 3.5: T323097: Fix up Gerrit usernames having upper case character(s).
Tue, Nov 15, 3:42 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar closed T323097: Fix up Gerrit usernames having upper case character(s) as Resolved.

There is no more any upper case letter in Gerrit accounts (scheme username:):

$ git grep -P 'username:.*[A-Z]' refs/meta/external-ids --
$
Tue, Nov 15, 3:21 PM · Release-Engineering-Team, Gerrit
hashar added a comment to T323097: Fix up Gerrit usernames having upper case character(s).

I have reindexed all accounts with ssh -p 29418 gerrit.wikimedia.org -- gerrit index start accounts --force then queried again the three accounts via the REST API and ran a diff:

diff -u99 -r before/78 after/78
--- before/78	2022-11-15 16:17:21.000980424 +0100
+++ after/78	2022-11-15 16:17:55.937418442 +0100
@@ -1,6 +1,6 @@
 {
   "_account_id": 78,
   "name": "Kaldari",
   "email": "kaldari@gmail.com",
-  "username": "Kaldari"
+  "username": "kaldari"
 }
diff -u99 -r before/381 after/381
--- before/381	2022-11-15 16:17:30.761102834 +0100
+++ after/381	2022-11-15 16:18:02.741503701 +0100
@@ -1,6 +1,6 @@
 {
   "_account_id": 381,
   "name": "Fran",
   "email": "fran@dumetella.net",
-  "username": "Fran McCrory"
+  "username": "fran mccrory"
 }
diff -u99 -r before/3327 after/3327
--- before/3327	2022-11-15 16:17:40.485224760 +0100
+++ after/3327	2022-11-15 16:18:10.313598566 +0100
@@ -1,6 +1,6 @@
 {
   "_account_id": 3327,
   "name": "SamanthaNguyen",
   "email": "codynguyen1116@gmail.com",
-  "username": "SamanthaNguyen"
+  "username": "samanthanguyen"
 }
Tue, Nov 15, 3:20 PM · Release-Engineering-Team, Gerrit
hashar added a comment to T323097: Fix up Gerrit usernames having upper case character(s).

I have converted SamanthaNguyen to all lower case:

commit f8b7cc2dc1844518cdd92495d8df1cf5b94bc3d5 (HEAD -> meta/external-ids, origin/meta/external-ids, refs/meta/external-ids)
Author: Antoine Musso <hashar@free.fr>
Date:   Tue Nov 15 15:14:12 2022 +0000
Tue, Nov 15, 3:16 PM · Release-Engineering-Team, Gerrit
hashar added a comment to T323097: Fix up Gerrit usernames having upper case character(s).

I have converted username:Fran McCrory to be all lower case:

Tue, Nov 15, 3:11 PM · Release-Engineering-Team, Gerrit
hashar updated the task description for T323097: Fix up Gerrit usernames having upper case character(s).
Tue, Nov 15, 3:10 PM · Release-Engineering-Team, Gerrit
hashar updated the task description for T323097: Fix up Gerrit usernames having upper case character(s).
Tue, Nov 15, 2:50 PM · Release-Engineering-Team, Gerrit
hashar added a comment to T323097: Fix up Gerrit usernames having upper case character(s).

I have manually deleted username:Kaldari in All-Users.git:

commit 495ec6989a771ca345d89d6df8055c66dd91e888 (HEAD -> meta/external-ids, origin/meta/external-ids, refs/meta/external-ids)
Author: Antoine Musso <hashar@free.fr>
Date:   Tue Nov 15 14:44:13 2022 +0000
Tue, Nov 15, 2:50 PM · Release-Engineering-Team, Gerrit
hashar updated the task description for T323097: Fix up Gerrit usernames having upper case character(s).
Tue, Nov 15, 9:28 AM · Release-Engineering-Team, Gerrit
hashar created T323097: Fix up Gerrit usernames having upper case character(s).
Tue, Nov 15, 9:27 AM · Release-Engineering-Team, Gerrit
hashar updated the task description for T296158: Archive the IndexFunction extension.
Tue, Nov 15, 8:55 AM · Patch-For-Review, User-Kizule, MediaWiki-extensions-IndexFunction, translatewiki.net, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup

Mon, Nov 14

hashar added a comment to T307334: Upgrade to Gerrit 3.5.

My plan:

Mon, Nov 14, 11:13 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar updated subscribers of T307334: Upgrade to Gerrit 3.5.

The reason for those accounts originates from when we turned on ldap.localUsernameToLowerCase T152640, T197083, T197257 etc. The upstream script to handle that LDAP username change failed apparently and left some accounts broken.

Mon, Nov 14, 11:10 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar added a comment to T307334: Upgrade to Gerrit 3.5.

The major change which affects us is normalizing username to be all lower case. I initially gave it a try with a local checkout of the All-Users.git database but it lacks a copy of refs/users/* and thus the script was essentially doing nothing.

Mon, Nov 14, 11:04 PM · Release-Engineering-Team (Priority Backlog 📥), Gerrit (Gerrit 3.5)
hashar closed T323051: Castor cache is ineffective due to a split brain as Resolved.

I think it is good now :-]

Mon, Nov 14, 6:13 PM · Release-Engineering-Team, Continuous-Integration-Infrastructure
hashar set Due Date to Mon, Nov 14, 11:00 PM on T323054: Jenkins plugins security advisory - 2022-11-15.
Mon, Nov 14, 5:44 PM · Security, Jenkins, Continuous-Integration-Infrastructure
hashar created T323054: Jenkins plugins security advisory - 2022-11-15.
Mon, Nov 14, 5:44 PM · Security, Jenkins, Continuous-Integration-Infrastructure
hashar added a comment to T252071: Move all Wikimedia CI (WMCS integration project) instances from stretch to buster/bullseye.

Part of this task relocated the Castor instance and I took that opportunity to also change the directory layout for the service. As a result we have been serving stall caches for quite a while. T323051 fixes it.

Mon, Nov 14, 5:37 PM · Patch-For-Review, Cloud-VPS (Debian Stretch Deprecation), Release-Engineering-Team (Seen), Continuous-Integration-Infrastructure
hashar created T323051: Castor cache is ineffective due to a split brain.
Mon, Nov 14, 5:25 PM · Release-Engineering-Team, Continuous-Integration-Infrastructure
hashar added a comment to T237807: gerrit: scoring/ores/editquality takes a long time to git gc.

I ran Tyler's script from /home/thcipriani/elapsed_gc_time.py

gerrit1001:~$ python /home/thcipriani/elapsed_gc_time.py|sort -g|tail -n 10
0:00:27	operations/software/netbox-deploy
0:00:30	scoring/ores/editquality
0:00:35	analytics/superset/deploy
0:00:35	wikimedia/production
0:00:42	mediawiki/extensions/Wikibase
0:01:17	All-Users
0:01:31	mediawiki/extensions
0:03:49	operations/puppet
0:04:01	mediawiki/core
0:31:26	TOTAL
Mon, Nov 14, 3:39 PM · Patch-For-Review, Release-Engineering-Team (Seen), Machine-Learning-Team, Gerrit
hashar moved T322964: reviewer comments missing on a specific change from Bugs & stuff to PolyGerrit on the Gerrit board.

This is most probably a representation bug in the Web interface (PolyGerrit).

Mon, Nov 14, 8:45 AM · Gerrit (Gerrit 3.5)
hashar added a comment to T322964: reviewer comments missing on a specific change.

Even in Phabricator, vanish @ori comments!

Mon, Nov 14, 8:41 AM · Gerrit (Gerrit 3.5)

Fri, Nov 11

hashar added a comment to T222472: Investigate gerrit session expiration.

For later reference, we restarted Gerrit a couple time on November 10th 2022 and some users reported being logged out after the restart(s).

Fri, Nov 11, 10:06 AM · Release-Engineering-Team-TODO, Release-Engineering-Team (Development services), Gerrit

Thu, Nov 10

hashar closed T322724: Upgrade Gerrit to 3.4.8 as Resolved.
Thu, Nov 10, 8:35 AM · Release-Engineering-Team, Gerrit (Gerrit 3.4)
hashar claimed T322724: Upgrade Gerrit to 3.4.8.
Thu, Nov 10, 7:55 AM · Release-Engineering-Team, Gerrit (Gerrit 3.4)

Wed, Nov 9

hashar closed T319378: Move Gerrit Javascript plugins from gerrit-theme.js to standalone files in the deploy repository as Resolved.

Done! I have confirmed the JavaScript plugins are properly loaded and gerrit-theme.js is gone :-]

Wed, Nov 9, 12:30 PM · Patch-For-Review, Release-Engineering-Team, Gerrit
hashar added a comment to T319378: Move Gerrit Javascript plugins from gerrit-theme.js to standalone files in the deploy repository.

I have published them to gerrit2002 (the replica). Gerrit automatically reloaded plugins, from error log:

[2022-11-09T12:17:00.676Z] [PluginScanner] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin wm-app-theme, version app-theme
[2022-11-09T12:17:00.677Z] [PluginScanner] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin wm-custom-links, version custom-links
[2022-11-09T12:17:00.677Z] [PluginScanner] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin wm-test-result-table, version test-result-table

And I had to reinstall the builtin plugins with:

sudo -u gerrit2 java -jar /var/lib/gerrit2/review_site/bin/gerrit.war init --batch --install-all-plugins
Wed, Nov 9, 12:22 PM · Patch-For-Review, Release-Engineering-Team, Gerrit
hashar added a comment to T319378: Move Gerrit Javascript plugins from gerrit-theme.js to standalone files in the deploy repository.

On gerrit1001 and gerrit2002:

Info: Applying configuration version '(0ff3c7b7bc) Filippo Giunchedi - gerrit: remove gerrit-theme.js'
Notice: Applied catalog in 31.94 seconds
Wed, Nov 9, 11:03 AM · Patch-For-Review, Release-Engineering-Team, Gerrit
hashar closed T259611: The python-build images regenerate wheels even when matching ones are already available as Declined.

Most dependencies on Pypi now provides wheels and our build download them. It is not really optimal but it is good enough. Maybe I will revisit this again later if I need it, meanwhile I am declining the task.

Wed, Nov 9, 9:11 AM · Release-Engineering-Team (Priority Backlog 📥), Patch-For-Review, Continuous-Integration-Infrastructure, SRE