hashar (Antoine "hashar" Musso (WMF))
WMF Software developer - Release Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 2:31 PM (193 w, 3 d)
Availability
Available
IRC Nick
hashar
LDAP User
Hashar
MediaWiki User
Unknown

https://www.mediawiki.org/wiki/User:Hashar

Based in Nantes, France CET/CEST (UTC+1, UTC+2)

Main IRC channel is #wikimedia-releng

antoine-approve

Recent Activity

Yesterday

hashar added a comment to T196084: [BlueSpiceFoundation] onMakeGlobalVariablesScript calls deprecated BsConfig::loadSettings.

Any chance to have the deprecation notice to be either removed or fixed? :]

Mon, Jun 18, 3:06 PM · BlueSpice
hashar added a comment to T197601: Failed to invoke Pygments: /usr/bin/env: python: No such file or directory.

The Docker images for Quibble have the python3 which is a dependency of Quibble itself. There is no python2 package installed which would provide /usr/bin/python.

Mon, Jun 18, 2:26 PM · Patch-For-Review, Continuous-Integration-Infrastructure, SyntaxHighlight
hashar created T197578: Wikibase client ApiListEntityUsage and ApiPropsEntityUsage share the same prefix 'wbeu'.
Mon, Jun 18, 9:22 AM · Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-API

Fri, Jun 15

hashar updated subscribers of T137310: Provide tracking category or page property for <timeline> uses.

Well done @matmarex 🏅

Fri, Jun 15, 9:58 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), EasyTimeline
hashar added a comment to T197469: Migrate gated extensions jobs to Quibble/Docker.

As noted on b493d4e558368ab6fe9995051c6d9e2992df8bf2 :

Fri, Jun 15, 2:38 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Fri, Jun 15, 2:11 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar updated the task description for T197469: Migrate gated extensions jobs to Quibble/Docker.
Fri, Jun 15, 2:10 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a commit to T197469: Migrate gated extensions jobs to Quibble/Docker: rCICFb493d4e55836: Quibble jobs for Wikimedia extensions.
Fri, Jun 15, 2:02 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar triaged T197469: Migrate gated extensions jobs to Quibble/Docker as Normal priority.
Fri, Jun 15, 2:02 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a comment to T180864: Inactive extensions and skins in Diffusion / Github.

I have deleted most of them. Some repositories are read-only / archived but still have php / content file, so potentially one might still be able to clone them from Gerrit and expect the code to work.

Fri, Jun 15, 8:30 AM · GitHub-Mirrors, Repository-Admins, Cleanup
hashar updated the task description for T180864: Inactive extensions and skins in Diffusion / Github.
Fri, Jun 15, 8:27 AM · GitHub-Mirrors, Repository-Admins, Cleanup
hashar added a comment to T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure.

Maybe we can reenable the test in REL1_31 and apply the fix there? It is only for tests though so it is probably not needed.

Fri, Jun 15, 8:01 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Shared Build Failure)

Thu, Jun 14

hashar awarded T196585: Deploy some MCR related patches on test / group0 for an extended period a Love token.
Thu, Jun 14, 9:31 PM · Patch-For-Review, Multi-Content-Revisions (MCR-SDC phase 1), Release-Engineering-Team, User-Addshore
hashar closed T196429: Archive the CustomPage skin as Resolved.
Thu, Jun 14, 5:28 PM · Patch-For-Review, User-MarcoAurelio, GitHub-Mirrors, Repository-Admins, Cleanup
hashar closed T196429: Archive the CustomPage skin, a subtask of T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker, as Resolved.
Thu, Jun 14, 5:28 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Thu, Jun 14, 3:36 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Thu, Jun 14, 2:43 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar closed T195831: [AkismetKlik] MWException Set $wgAKkey in LocalSettings.php or relevant configuration file., a subtask of T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker, as Resolved.
Thu, Jun 14, 2:42 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar closed T195831: [AkismetKlik] MWException Set $wgAKkey in LocalSettings.php or relevant configuration file. as Resolved.
Thu, Jun 14, 2:42 PM · Patch-For-Review, MediaWiki-extensions-Other
hashar closed T195831: [AkismetKlik] MWException Set $wgAKkey in LocalSettings.php or relevant configuration file. as Resolved.
Thu, Jun 14, 2:42 PM · Patch-For-Review, MediaWiki-extensions-Other
hashar closed T195831: [AkismetKlik] MWException Set $wgAKkey in LocalSettings.php or relevant configuration file., a subtask of T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker, as Resolved.
Thu, Jun 14, 2:42 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a comment to T196429: Archive the CustomPage skin.

Left to do is to rebase the mediawiki/skins change https://gerrit.wikimedia.org/r/c/mediawiki/skins/+/440106 :]

Thu, Jun 14, 2:30 PM · Patch-For-Review, User-MarcoAurelio, GitHub-Mirrors, Repository-Admins, Cleanup
hashar updated the task description for T196429: Archive the CustomPage skin.
Thu, Jun 14, 2:29 PM · Patch-For-Review, User-MarcoAurelio, GitHub-Mirrors, Repository-Admins, Cleanup
hashar updated the task description for T196436: EditSubpages extension fails mediawiki/core webdriver.io tests.
Thu, Jun 14, 9:45 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Release-Engineering-Team (Kanban), MediaWiki-extensions-Other
hashar updated the task description for T196960: Quibble should have a way for extensions to opt out of core browser tests.
Thu, Jun 14, 9:44 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Quibble
hashar updated the task description for T196960: Quibble should have a way for extensions to opt out of core browser tests.
Thu, Jun 14, 9:44 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Quibble
hashar added a subtask for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker: T196960: Quibble should have a way for extensions to opt out of core browser tests.
Thu, Jun 14, 9:43 AM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a parent task for T196960: Quibble should have a way for extensions to opt out of core browser tests: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Thu, Jun 14, 9:43 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Quibble
hashar updated the task description for T196960: Quibble should have a way for extensions to opt out of core browser tests.
Thu, Jun 14, 9:42 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Quibble
hashar removed a project from T195020: AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker: Continuous-Integration-Infrastructure.
Thu, Jun 14, 9:37 AM · Patch-For-Review, AntiSpoof
hashar added a comment to T195020: AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker.

@Umherirrender seems like using binary has a database character set fix the test. Thus I am not sure whether the database is still needed, but then I havent looked at your change.

Thu, Jun 14, 9:37 AM · Patch-For-Review, AntiSpoof
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Thu, Jun 14, 9:28 AM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar moved T196013: Get Wikibase + dependencies to run with Quibble from Backlog to In progress on the Continuous-Integration-Infrastructure (shipyard) board.
Thu, Jun 14, 9:11 AM · Release-Engineering-Team (Kanban), Patch-For-Review, MediaWiki-extensions-WikibaseRepository, Wikidata, Continuous-Integration-Infrastructure (shipyard)
hashar added a comment to T197192: Unable to edit external-ids ref in notedb due to validation.

Lets do the analysis on our Phabricator task based on upstream questions. Then we can come back to them with a detailed bug report. At least at first glance there is no duplicate external id, but we have some emails associated to multiple accounts. That was already the case in ReviewDB as one can see by looking at the accounts_external_ids table. I guess the migration did not take that in account, and since Gerrit 2.15 no enforce uniqueness of emails address we get screwed up.

Thu, Jun 14, 8:34 AM · Upstream, Release-Engineering-Team, Gerrit
hashar closed T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions as Resolved.

Fixed via T189762 and T191537

Thu, Jun 14, 8:29 AM · Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar closed T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions, a subtask of T164721: Run Selenium tests in CI for extensions, as Resolved.
Thu, Jun 14, 8:29 AM · Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar closed T195206: mediawiki-core-qunit-selenium-jessie tests for math broken as Resolved.

That is most probably related to T189762 T191537 . The user session being logged out due to a bug in mediawiki/core. Fixed by https://gerrit.wikimedia.org/r/439289

Thu, Jun 14, 8:28 AM · Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin, Math, Continuous-Integration-Infrastructure
hashar closed T195206: mediawiki-core-qunit-selenium-jessie tests for math broken, a subtask of T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions, as Resolved.
Thu, Jun 14, 8:28 AM · Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar closed T189762: selenium test for Wikibase is unstable as Resolved.

As @Smalyshev , the test ends up being logged out at some point. I am pretty sure that is the same issue we have encountered on T191537 which is that cookie from a different session were sent by a background job executed when logging in. That invalidate the session and causes the logged out page issue.

Thu, Jun 14, 8:25 AM · Wikimedia-log-errors (Shared Build Failure), MediaWiki-extensions-WikibaseRepository, Wikidata, Continuous-Integration-Infrastructure, Release-Engineering-Team
hashar closed T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job as Resolved.

We have good reason to think that preventing jobs from sendinig cookie/headers is the definitive fix. https://gerrit.wikimedia.org/r/439289

Thu, Jun 14, 8:23 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Math, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin, Lexicographical data, Wikidata, Continuous-Integration-Infrastructure
hashar closed T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job, a subtask of T189762: selenium test for Wikibase is unstable, as Resolved.
Thu, Jun 14, 8:23 AM · Wikimedia-log-errors (Shared Build Failure), MediaWiki-extensions-WikibaseRepository, Wikidata, Continuous-Integration-Infrastructure, Release-Engineering-Team
hashar closed T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job, a subtask of T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions, as Resolved.
Thu, Jun 14, 8:23 AM · Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar added a comment to T197192: Unable to edit external-ids ref in notedb due to validation.

Yup I got that Gerrit is now relying on NoteDB for the accounts data, but at least the database give us a snapshot of the state pre migration. I guess the conversion from ReviewDB to NoteDB has not been straightforward and cause a wild bunch of issues and errors.

Thu, Jun 14, 7:38 AM · Upstream, Release-Engineering-Team, Gerrit
hashar added a comment to T197192: Unable to edit external-ids ref in notedb due to validation.
$ ssh -p 29418 gerrit.wikimedia.org 'gerrit gsql'
gerrit> select * from account_external_ids where email_address='jbranaa@wikimedia.org';
 account_id | email_address         | password | external_id
 -----------+-----------------------+----------+----------------
 59yy       | jbranaa@wikimedia.org | NULL     | gerrit:jbranaa
 45xx       | jbranaa@wikimedia.org | NULL     | gerrit:jrbranaa

Note how the same email is known with two different ids.

Thu, Jun 14, 7:35 AM · Upstream, Release-Engineering-Team, Gerrit
hashar closed T197207: integration cumin can't ssh to instances: Connection closed by integration-cumin [preauth] as Resolved.

Found the passphrase from integration-puppetmaster01 in the labs/private repo

# keyholder arm
Enter passphrase for /etc/keyholder.d/cumin_openstack_integration_master: 
Identity added: /etc/keyholder.d/cumin_openstack_integration_master (/etc/keyholder.d/cumin_openstack_integration_master)
root@integration-cumin:~# keyholder status
keyholder-agent: active
- 256 06:36:d8:17:14:ac:73:73:3b:71:ea:bf:1f:59:e1:23 /etc/keyholder.d/cumin_openstack_integration_master (ED25519)
keyholder-proxy: active
- 256 06:36:d8:17:14:ac:73:73:3b:71:ea:bf:1f:59:e1:23 /etc/keyholder.d/cumin_openstack_integration_master (ED25519)
Thu, Jun 14, 7:13 AM · Release-Engineering-Team (Kanban), Operations-Software-Development, Continuous-Integration-Infrastructure
hashar claimed T197207: integration cumin can't ssh to instances: Connection closed by integration-cumin [preauth].
Thu, Jun 14, 7:09 AM · Release-Engineering-Team (Kanban), Operations-Software-Development, Continuous-Integration-Infrastructure
hashar added a comment to T197207: integration cumin can't ssh to instances: Connection closed by integration-cumin [preauth].
$ keyholder status
keyholder-agent: active
- The agent has no identities.
keyholder-proxy: active
- The agent has no identities.
Thu, Jun 14, 7:09 AM · Release-Engineering-Team (Kanban), Operations-Software-Development, Continuous-Integration-Infrastructure
hashar created T197207: integration cumin can't ssh to instances: Connection closed by integration-cumin [preauth].
Thu, Jun 14, 7:08 AM · Release-Engineering-Team (Kanban), Operations-Software-Development, Continuous-Integration-Infrastructure

Wed, Jun 13

hashar added a comment to T195020: AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker.

I have triggered the Quibble jobs against the dummy change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AntiSpoof/+/54376

Wed, Jun 13, 1:54 PM · Patch-For-Review, AntiSpoof
hashar added a comment to T195020: AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker.

MariaDB has been changed in the Quibble containers to use binary. 7d740b5167e1625c690d6f59b6b0e0ac35c4694d T193222

--- a/dockerfiles/quibble-stretch/mariadb.cnf
+++ b/dockerfiles/quibble-stretch/mariadb.cnf
 [mysqld]
+character_set_server     = binary
+character_set_filesystem = binary
+collation_server         = binary
Wed, Jun 13, 1:53 PM · Patch-For-Review, AntiSpoof
hashar updated the task description for T197102: Archive the CustomPage extension.
Wed, Jun 13, 1:49 PM · Patch-For-Review, GitHub-Mirrors, Repository-Admins, Cleanup, User-MarcoAurelio
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Wed, Jun 13, 1:48 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a comment to T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.

@hashar The CustomPage extension is also archive ongoing: T197102

Wed, Jun 13, 1:48 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Wed, Jun 13, 12:56 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a subtask for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker: T188523: Mpdf extension fails PHP 7.0 lint.
Wed, Jun 13, 12:15 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a parent task for T188523: Mpdf extension fails PHP 7.0 lint: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Wed, Jun 13, 12:15 PM · Patch-For-Review, PHP 7.0 support, MediaWiki-extensions-Other
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Wed, Jun 13, 12:15 PM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar closed T151871: SpellingDictionary: Message 'uls-select-language' required by 'ext.SpellingDictionary.viewByLanguage' must exist as Resolved.
Wed, Jun 13, 11:17 AM · Patch-For-Review, UniversalLanguageSelector, Spelling-Dictionary
hashar closed T151871: SpellingDictionary: Message 'uls-select-language' required by 'ext.SpellingDictionary.viewByLanguage' must exist, a subtask of T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker, as Resolved.
Wed, Jun 13, 11:17 AM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar updated the task description for T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.
Wed, Jun 13, 10:36 AM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar added a comment to T197070: +2 for MarcoAurelio in mediawiki/*.

Definitely. @MarcoAurelio nicely baby sit the Cleanup project and has shown to be careful. He also have all the connections to reach out to other reviews as needed.

Wed, Jun 13, 8:38 AM · Repository-Ownership-Requests
hashar closed T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: <span class="wbqc-status wbqc-status-warning"/> not found as Resolved.

I triggered builds of the Math change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/436237 and it passed all CI jobs. So I am assuming it is definitely fixed.

Wed, Jun 13, 7:53 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Wikibase-Quality-Constraints, Patch-For-Review, Wikibase-Quality, Wikidata
hashar added a parent task for T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job: T189762: selenium test for Wikibase is unstable.
Wed, Jun 13, 7:45 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Math, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin, Lexicographical data, Wikidata, Continuous-Integration-Infrastructure
hashar added a subtask for T189762: selenium test for Wikibase is unstable: T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job.
Wed, Jun 13, 7:45 AM · Wikimedia-log-errors (Shared Build Failure), MediaWiki-extensions-WikibaseRepository, Wikidata, Continuous-Integration-Infrastructure, Release-Engineering-Team
hashar added a comment to T189762: selenium test for Wikibase is unstable.
Wed, Jun 13, 7:44 AM · Wikimedia-log-errors (Shared Build Failure), MediaWiki-extensions-WikibaseRepository, Wikidata, Continuous-Integration-Infrastructure, Release-Engineering-Team
hashar removed a project from T167504: New tool to track package updates/status for hosts and images (debmonitor): Continuous-Integration-Infrastructure (shipyard).
Wed, Jun 13, 7:24 AM · Patch-For-Review, Operations-Software-Development, Operations
hashar closed T181898: Special:Preferences "Global default '' is invalid for field theme" MWException on 1.30 RC as Resolved.
Wed, Jun 13, 7:23 AM · Patch-For-Review, Theme, MediaWiki-User-preferences
hashar closed T181898: Special:Preferences "Global default '' is invalid for field theme" MWException on 1.30 RC , a subtask of T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker, as Resolved.
Wed, Jun 13, 7:23 AM · Patch-For-Review, Epic, Release-Engineering-Team (Kanban), releng-201718-q3, Continuous-Integration-Infrastructure (shipyard)
hashar closed T186096: Archive gerrit repo operations/software/tessera and github mirror as Resolved.

@hashar Could you please take care of taking down https://github.com/wikimedia/operations-software-tessera when you can? Afterwards this task can be closed. Thanks.

Wed, Jun 13, 7:22 AM · GitHub-Mirrors, User-MarcoAurelio, Repository-Admins
hashar added a comment to T196939: Build base image for math extension pipeline tests.

A summary of our chat yesterday:

Wed, Jun 13, 7:19 AM · Release-Engineering-Team (Kanban), Release Pipeline
hashar added a subtask for T191182: Stop using Differential for code review: T191374: Move OOjs Router code review from Differential to Gerrit.
Wed, Jun 13, 7:04 AM · Release-Engineering-Team (Someday), Phabricator, Gerrit
hashar renamed T191374: Move OOjs Router code review from Differential to Gerrit from Move OOjs Router to Gerrit (from Diffusion) to Move OOjs Router code feview from Differential to Gerrit.
Wed, Jun 13, 7:04 AM · Continuous-Integration-Config, Patch-For-Review, User-MarcoAurelio, Repository-Admins, OOjs-Router

Tue, Jun 12

hashar added a comment to T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: <span class="wbqc-status wbqc-status-warning"/> not found.

@Lucas_Werkmeister_WMDE dont worry that can wait tomorrow :-] Feel free to poke me on IRC tomorrow morning.

Tue, Jun 12, 5:09 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Wikibase-Quality-Constraints, Patch-For-Review, Wikibase-Quality, Wikidata
hashar removed a project from T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: <span class="wbqc-status wbqc-status-warning"/> not found: Math.

In CI, WikibaseQuality does not depend on Math:

$ colordiff -u Math WikibaseQuality 
--- Math	2018-06-12 18:54:57.569521197 +0200
+++ WikibaseQuality	2018-06-12 18:55:13.609284832 +0200
@@ -1,4 +1,3 @@
-mediawiki/extensions/Math 
 mediawiki/extensions/BetaFeatures
 mediawiki/extensions/Capiunto
 mediawiki/extensions/CentralAuth
Tue, Jun 12, 5:08 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Wikibase-Quality-Constraints, Patch-For-Review, Wikibase-Quality, Wikidata
hashar added a comment to T196812: Make PolyGerrit the default ui.

Or delay it to after the SRE offsite? It is not that urgent anyway :] That also let time for people to react on the announcement, specially volunteers who are usually active solely during the week-end.

Tue, Jun 12, 4:58 PM · Release-Engineering-Team, User-notice, Patch-For-Review, Gerrit
hashar created T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: <span class="wbqc-status wbqc-status-warning"/> not found.
Tue, Jun 12, 4:50 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Wikibase-Quality-Constraints, Patch-For-Review, Wikibase-Quality, Wikidata
hashar added a comment to T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job.

From https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439289

Wikibase was failing the Selenium tests which are run by the 'quibble' job at least for the php7. It might be faster and thus ended up hitting the race condition.

I have crafted a dummy change for Wikibase which depends on the mediawiki/core patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/439847 One build passed and a second is being run. On another Wikibase change the selenium test was failing constantly.

So I think it is a proper fix :]

Tue, Jun 12, 2:48 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Math, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin, Lexicographical data, Wikidata, Continuous-Integration-Infrastructure
hashar closed T190894: Archive EditPageTracking extension as Resolved.

Thank you!

Tue, Jun 12, 2:00 PM · Cleanup, MediaWiki-extensions-Other
hashar updated the task description for T190894: Archive EditPageTracking extension.
Tue, Jun 12, 2:00 PM · Cleanup, MediaWiki-extensions-Other
hashar assigned T196812: Make PolyGerrit the default ui to Paladox.

We definitely should use polygerrit as the default. It still beta in 2.15 but that will prepare people to switch to it when later on there is no other choice.

Tue, Jun 12, 1:12 PM · Release-Engineering-Team, User-notice, Patch-For-Review, Gerrit
hashar awarded T196812: Make PolyGerrit the default ui a Orange Medal token.
Tue, Jun 12, 1:02 PM · Release-Engineering-Team, User-notice, Patch-For-Review, Gerrit
hashar added a comment to T193957: php-session-serializer tests fail on PHP 7.2: ini_set(): Headers already sent. You cannot change the session module's ini settings at this time.

Yesterday I have tried to use @runInSeparateProcess to write a test for headers/cookies, there are a few things that need to be fixed first but eventually it leads to an infinite loop. I have filled T193957

Tue, Jun 12, 10:23 AM · Patch-For-Review, PHP 7.2 support, php-session-serializer
hashar created T196977: @runInSeparateProcess causes an infite loop preventing test from running.
Tue, Jun 12, 10:22 AM · MediaWiki-Core-Tests
hashar committed rEWLEee842bc87c11: [DO NOT SUBMIT] No cookies in post-send job (authored by hashar).
[DO NOT SUBMIT] No cookies in post-send job
Tue, Jun 12, 8:29 AM

Mon, Jun 11

Gerrit Code Review <gerrit@wikimedia.org> committed rENPU750a629efd4f: Update patch set 1 (authored by hashar).
Update patch set 1
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENPUc08881b3eda3: Update patch set 1 (authored by hashar).
Update patch set 1
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENPUfc851471e69d: Create change (authored by hashar).
Create change
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENPU4c429241e9ef: Update patch set 4 (authored by hashar).
Update patch set 4
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENPUe249cd991abc: Update patch set 2 (authored by hashar).
Update patch set 2
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENPUab96ba593017: Update patch set 2 (authored by hashar).
Update patch set 2
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENPU888a6cf38939: Update patch set 2 (authored by hashar).
Update patch set 2
Mon, Jun 11, 9:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENUAC6cdfc8a8e88c: Final NoteDb migration updates (authored by hashar).
Final NoteDb migration updates
Mon, Jun 11, 9:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENUACe53af2dcd8b8: Update patch set 1 (authored by hashar).
Update patch set 1
Mon, Jun 11, 9:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENUACdbe975f06000: Create change (authored by hashar).
Create change
Mon, Jun 11, 9:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENUAC05df2834630c: Create change (authored by hashar).
Create change
Mon, Jun 11, 9:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENUAC04d5b519a417: Update patch set 1 (authored by hashar).
Update patch set 1
Mon, Jun 11, 9:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rENUAC10b0e18e5eb3: Update patch set 3 (authored by hashar).
Update patch set 3
Mon, Jun 11, 9:16 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSRf825a2849561: Update patch set 1 (authored by hashar).
Update patch set 1
Mon, Jun 11, 9:04 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEQGVca3ceb20c3f6: Update patch set 1 (authored by hashar).
Update patch set 1
Mon, Jun 11, 8:46 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEQGV7fb8ea16b3c6: Final NoteDb migration updates (authored by hashar).
Final NoteDb migration updates
Mon, Jun 11, 8:46 PM