Page MenuHomePhabricator

holger.knust (Holger Knust)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 14 2019, 4:23 PM (18 w, 5 d)
Availability
Available
LDAP User
Holger Knust
MediaWiki User
Unknown

Recent Activity

Sat, May 18

mobrovac awarded T223690: Replace Cassandra-uuid with uuid a 100 token.
Sat, May 18, 2:52 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Services (later)

Apr 17 2019

holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Apr 17 2019, 1:09 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Apr 15 2019

holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Apr 15 2019, 11:05 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Apr 11 2019

bearND awarded T200374: Update indirect dependency on github.com/gwicke/kad.git a Pterodactyl token.
Apr 11 2019, 3:01 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Services (later), service-runner

Mar 28 2019

holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 28 2019, 7:54 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust committed rECKTd136c8c7066c: Call method getText() instead of getNativeData() (authored by holger.knust).
Call method getText() instead of getNativeData()
Mar 28 2019, 7:49 PM
holger.knust committed rECKT8f63b6a96c64: Call method getText() instead of getNativeData() (authored by holger.knust).
Call method getText() instead of getNativeData()
Mar 28 2019, 5:36 PM

Mar 27 2019

holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 5:38 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 3:58 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 3:56 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 3:20 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 2:48 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 2:21 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 27 2019, 2:20 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust committed rEBSI5c4d169256d8: Call method getText() instead of getNativeData() (authored by holger.knust).
Call method getText() instead of getNativeData()
Mar 27 2019, 2:06 PM

Mar 25 2019

holger.knust claimed T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 25 2019, 6:21 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust added a comment to T214317: Phase out deprecated Title::isValidMoveTarget.

Yes, currently on hold until T216089 is merged.

Mar 25 2019, 6:19 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Decoupling (CDP2)), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Mar 22 2019

holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 22 2019, 10:35 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Mar 22 2019, 9:49 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
holger.knust reassigned T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. from BPirkle to Hknust.
Mar 22 2019, 7:52 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Feb 28 2019

holger.knust added a comment to T214316: Remove unused method Title::validateFileMoveOperation.

Looks like it. :) I removed the comment but left the actual test case since that should be covered by the replacement method
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/493508/

Feb 28 2019, 9:52 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management
holger.knust added a comment to T214316: Remove unused method Title::validateFileMoveOperation.

I removed Title::validateFileMoveOperation and also removed the test comment saying the method was covered in the test but not the test itself since it is calling the replacement method.

Feb 28 2019, 9:44 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Feb 25 2019

holger.knust closed T203617: Use hot-shots native childClient in service-runner makeChild as Resolved.

Merged and tagged 2.6.10

Feb 25 2019, 11:03 PM · Core Platform Team Kanban (Done with CPT), Services (done), good first bug, service-runner

Feb 21 2019

holger.knust added a comment to T216069: Flaky quibble-vendor-mysql-hhvm-docker test in Jenkins.

Antoine, I tried to recreate the test results locally using the instructions in the link you shared but it failed (see below). Anything I am doing wrong?

Feb 21 2019, 12:01 AM · Core Platform Team Kanban (Done with CPT), Services (blocked), Analytics, EventBus, MediaWiki-Core-Testing, Release-Engineering-Team, Jenkins, Quibble

Feb 11 2019

holger.knust committed rMSCP3c90f156b297: Remove eslint dep since it is also in eslint-config-wikimedia (authored by holger.knust).
Remove eslint dep since it is also in eslint-config-wikimedia
Feb 11 2019, 7:03 PM
holger.knust committed rMSCPa001802fd66f: Reordered test execution order (authored by holger.knust).
Reordered test execution order
Feb 11 2019, 7:02 PM
holger.knust committed rMSCPb16d3f3fda20: Removed eslint-config-node-services and mocha-eslint (authored by holger.knust).
Removed eslint-config-node-services and mocha-eslint
Feb 11 2019, 7:02 PM

Jan 25 2019

holger.knust updated the task description for T210460: Eliminate usage of mocha-eslint.
Jan 25 2019, 5:17 PM · Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Later), Services (later)
holger.knust updated the task description for T210460: Eliminate usage of mocha-eslint.
Jan 25 2019, 4:39 PM · Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Later), Services (later)
holger.knust updated the task description for T210460: Eliminate usage of mocha-eslint.
Jan 25 2019, 2:15 PM · Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Later), Services (later)

Jan 24 2019

holger.knust updated the task description for T210460: Eliminate usage of mocha-eslint.
Jan 24 2019, 11:05 PM · Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Later), Services (later)
holger.knust updated the task description for T210460: Eliminate usage of mocha-eslint.
Jan 24 2019, 4:56 PM · Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Later), Services (later)

Jan 17 2019

holger.knust added a comment to T210460: Eliminate usage of mocha-eslint.

Ok, I'll remove eslint-config-node-services then and override where necessary

Jan 17 2019, 6:55 PM · Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Later), Services (later)
holger.knust added a watcher for EventBus: holger.knust.
Jan 17 2019, 2:46 PM
holger.knust added a watcher for Core Platform Team Backlog (Later): holger.knust.
Jan 17 2019, 12:23 PM

Jan 15 2019

holger.knust added a member for Services: holger.knust.
Jan 15 2019, 7:53 PM
holger.knust created T213812: Add `holger` to `wmf` LDAP group.
Jan 15 2019, 12:27 PM · Patch-For-Review, LDAP-Access-Requests