Page MenuHomePhabricator

hoo (Marius Hoch)
User

Projects (26)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 12:09 PM (267 w, 5 d)
Availability
Available
LDAP User
Hoo man
MediaWiki User
Hoo man [ Global Accounts ]

Recent Activity

Today

hoo moved T238562: Don't access the Vue-$parent, but use props from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Wed, Nov 20, 10:24 AM · Patch-For-Review, Wikidata-Tainted-References-Sprint5
hoo moved T238402: Add tracking code relating to TaintedIcon clicks from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Wed, Nov 20, 9:04 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Noarave, Wikidata-Tainted-References-Sprint5, Wikidata
hoo moved T238402: Add tracking code relating to TaintedIcon clicks from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Wed, Nov 20, 7:53 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Noarave, Wikidata-Tainted-References-Sprint5, Wikidata

Yesterday

hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Tue, Nov 19, 9:47 PM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo added a comment to T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”.

Thanks @Anomie, that makes sense.

Tue, Nov 19, 3:08 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
hoo added a comment to T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”.

But what is actually stored in the database (SELECT TYPEOF)?

Tue, Nov 19, 1:58 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
hoo claimed T238562: Don't access the Vue-$parent, but use props.
Tue, Nov 19, 1:15 PM · Patch-For-Review, Wikidata-Tainted-References-Sprint5
hoo added a comment to T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”.

Hm, it still fails when calling initState() with [ '0' => 'foowiki' ], so I don’t think casting $siteID to a string in initState() would change anything. There’s some confusion between strings and numbers somewhere…

Tue, Nov 19, 1:13 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Nov 18

hoo created T238562: Don't access the Vue-$parent, but use props.
Mon, Nov 18, 3:37 PM · Patch-For-Review, Wikidata-Tainted-References-Sprint5

Sat, Nov 16

hoo created P9648 Wikibase Client EntityAccessor::renumber benchmarks.
Sat, Nov 16, 2:39 PM

Fri, Nov 15

hoo moved T237734: Mount Popper Component from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.

I think we're done here, the popper is now properly mounted to the tainted icon. Everything else (styling, wording, …) is out of scope for this task.

Fri, Nov 15, 12:32 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo closed T237261: Track help link click metrics as Resolved.
Fri, Nov 15, 11:37 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo closed T237261: Track help link click metrics, a subtask of T231730: Step 1: Help link, as Resolved.
Fri, Nov 15, 11:37 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata

Thu, Nov 14

hoo moved T237261: Track help link click metrics from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Thu, Nov 14, 11:00 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata

Wed, Nov 13

hoo closed T237903: Wikibase: Change JS-esque entries to Lua as Resolved.
Wed, Nov 13, 4:09 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata, Wikibase-Lua
hoo added a comment to T237261: Track help link click metrics.

Note: We decided to wrap mw.track in a Vue component now. I made some initial progress here and will (hopefully) finish that tomorrow.

Wed, Nov 13, 1:51 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo added a comment to T237261: Track help link click metrics.

So bridge uses a ServiceContainer which to hold (as 'tracker') a mw.track instance. They use that, via their EventTracker and via DataBridgeTrackerService. We should probably do the same or something similar, although we can probably get away with a little less abstraction?

Wed, Nov 13, 12:32 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo claimed T237261: Track help link click metrics.
Wed, Nov 13, 12:11 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata

Mon, Nov 11

hoo committed rEBQC5c6cf50b2dad: Constraints report "Help" should link using SpecialMyLanguage (authored by hoo).
Constraints report "Help" should link using SpecialMyLanguage
Mon, Nov 11, 1:01 PM
hoo updated the task description for T237968: Add browser tests for the tainted icon.
Mon, Nov 11, 12:22 PM · Wikidata-Tainted-References-Sprint5
hoo moved T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Mon, Nov 11, 12:17 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikibase-Quality-Constraints, Wikidata
hoo created T237968: Add browser tests for the tainted icon.
Mon, Nov 11, 12:16 PM · Wikidata-Tainted-References-Sprint5
hoo closed T237867: Popper state needs to be initialized (set via Vue.set) as Resolved.
Mon, Nov 11, 12:06 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo moved T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Mon, Nov 11, 11:24 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikibase-Quality-Constraints, Wikidata
hoo claimed T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage.
Mon, Nov 11, 11:17 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikibase-Quality-Constraints, Wikidata
hoo added a comment to T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings.

I purged all pages from above (which haven't been re-parsed since) and gathered new numbers:

  1. The average PC size is 101219.66 (down ~2.7%)
  2. The median PC size is 68137 (down ~7.2%)
  3. The minimum PC size is 12911 (down ~3.1%)
  4. The maximum PC size is 393856 (down ~1.4%)
Mon, Nov 11, 9:59 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient

Sun, Nov 10

hoo updated subscribers of T153844: Don't load jquery.uls.data unless it's needed.

The same seems to be true for enwiki (logged out, private mode, random article):

Sun, Nov 10, 6:24 PM · Performance Issue, UniversalLanguageSelector
hoo updated the task description for T237867: Popper state needs to be initialized (set via Vue.set).
Sun, Nov 10, 5:38 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo claimed T237867: Popper state needs to be initialized (set via Vue.set).
Sun, Nov 10, 5:32 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo created T237867: Popper state needs to be initialized (set via Vue.set).
Sun, Nov 10, 5:32 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4

Fri, Nov 8

hoo created T237734: Mount Popper Component.
Fri, Nov 8, 3:22 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Peer Review to Doing on the Wikidata-Tainted-References-Sprint4 board.
Fri, Nov 8, 12:58 PM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236890: Fix TaintedIcon alignment style from Doing to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Fri, Nov 8, 11:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Fri, Nov 8, 12:21 AM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo added a comment to T236889: Wire Close Popper Action to 'cross' and blur action.

I just implemented it like this, but I'm not sure that's going to suffice… if the user clicks on the popper, this will probably also trigger the blur and thus close the popper. Maybe if the popper is a direct child of the TaintedIcon <a> this will work, but I'm not sure.

Fri, Nov 8, 12:21 AM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4

Thu, Nov 7

hoo added a comment to T236889: Wire Close Popper Action to 'cross' and blur action.

So apparently OOUI sets tabindex="0" on the constraints icon, with that we can actually focus (and thus also handle blur). I'll do the same for us in order to re-implement the behavior as closely as possible.

Thu, Nov 7, 10:38 AM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo closed T237247: Untaint action should also set the popper to be closed as Resolved.
Thu, Nov 7, 10:11 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Peer Review to Doing on the Wikidata-Tainted-References-Sprint4 board.
Thu, Nov 7, 10:11 AM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4

Wed, Nov 6

hoo added a comment to T236889: Wire Close Popper Action to 'cross' and blur action.

I have a patch that wires up the "x" to close the popper, I didn't yet look into closing it if the user clicks onto something else.

Wed, Nov 6, 1:55 PM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Wed, Nov 6, 1:55 PM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo claimed T236889: Wire Close Popper Action to 'cross' and blur action.
Wed, Nov 6, 11:08 AM · Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T237247: Untaint action should also set the popper to be closed from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Wed, Nov 6, 11:06 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo claimed T237247: Untaint action should also set the popper to be closed.
Wed, Nov 6, 11:02 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T237247: Untaint action should also set the popper to be closed from To Do to Doing on the Wikidata-Tainted-References-Sprint4 board.
Wed, Nov 6, 11:02 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo claimed T237260: Add help link to Popper Component.
Wed, Nov 6, 10:56 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo added a comment to T233213: XSS in Wikidata Query Service UI.

I just checked the live site and I still see the old code deployed when looking at the minified JS.

The new minified versions are present (alongside the current versions), but index.html was not updated on the individual hosts (so the state on deploy1001 differs from the state on the actual wdqs servers).

hoo@deploy1001:/srv/deployment/wdqs/wdqs/gui$ md5sum $(pwd)/index.html
11ee88217d78d98e52f9008add62a23c  /srv/deployment/wdqs/wdqs/gui/index.html
hoo@wdqs1005:/srv/deployment/wdqs/wdqs/gui$ md5sum $(pwd)/index.html
29ce000ed3201781a6c06eb03d73b002  /srv/deployment/wdqs/wdqs/gui/index.html

@Mathew.onipe Do you want to re-scap?

Wed, Nov 6, 9:11 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security
hoo added a comment to T233213: XSS in Wikidata Query Service UI.

I just checked the live site and I still see the old code deployed when looking at the minified JS.

Wed, Nov 6, 9:07 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security
hoo added a comment to T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings.

I collected some data about the parser cache sizes of the ruwiki pages with the most hits this month (as per stats.wikimedia.org).

Wed, Nov 6, 1:24 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient
hoo created P9535 Top 100 ruwiki pages parser cache size.
Wed, Nov 6, 1:12 AM · Wikidata
hoo added a comment to T193781: [task] Configure ArticlePlaceholder for nowiki.

With T195751 fixed, will ArticlePlaceholders show up in Special:Search once the extension is configured for nowiki?

Wed, Nov 6, 12:24 AM · ArticlePlaceholder, Wikidata, Wikimedia-Extension-setup
hoo closed T236888: Wire Open Action to TaintedIcon click as Resolved.

This is in verification but I don't think I can verify this. Close?

Wed, Nov 6, 12:04 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4

Tue, Nov 5

hoo added a comment to T236491: Cache php.getEntityStatements in mw.wikibase.

@hoo now that this is all merged and deployed, how is it looking? :) can we close?

Tue, Nov 5, 9:34 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

Possibly related: T236749

Tue, Nov 5, 9:30 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

@hoo now that this is deployed, how is it performing?

Tue, Nov 5, 9:29 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo added a comment to T237258: Decide how to make mw.wikibase.getReferencedEntityId (or a new function) useful to lookup referenced entity ids based on multiple starting points.

Another possible signature: wikibase.getReferencedEntityId( { ...fromEntityIds }, propertyId, { ...toIds } ). (Some previous discussion for this is in T179155#4104367 and following comments.)

Tue, Nov 5, 9:25 PM · Wikidata, Wikibase-Lua
hoo added a comment to T233213: XSS in Wikidata Query Service UI.

@hoo you mentioned you still have access to the WDQS servers, do you know how to deploy a change to the UI? (T233213#5584298 is probably the most important comment to catch up on.)

Tue, Nov 5, 9:20 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security
hoo moved T236888: Wire Open Action to TaintedIcon click from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Tue, Nov 5, 9:13 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4

Mon, Nov 4

hoo created T237258: Decide how to make mw.wikibase.getReferencedEntityId (or a new function) useful to lookup referenced entity ids based on multiple starting points.
Mon, Nov 4, 2:21 PM · Wikidata, Wikibase-Lua
hoo created T237249: Globally track Scribunto LuaSandbox profiling data.
Mon, Nov 4, 12:18 PM · Wikidata, Wikibase-Lua, MediaWiki-extensions-Scribunto
hoo added a project to T237247: Untaint action should also set the popper to be closed: Wikidata-Tainted-References-Sprint4.
Mon, Nov 4, 11:51 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo created T237247: Untaint action should also set the popper to be closed.
Mon, Nov 4, 11:50 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4

Sun, Nov 3

Pppery awarded T194023: Expose siteGlobalID in Lua a Dislike token.
Sun, Nov 3, 2:55 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikibase-Lua, Wikidata

Fri, Nov 1

hoo moved T236888: Wire Open Action to TaintedIcon click from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Fri, Nov 1, 12:42 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4
hoo added a comment to T236347: Wikibase Travis build runs twice for each commit.

@hoo Any idea on how this should be fixed?

Fri, Nov 1, 12:05 PM · Continuous-Integration-Config, MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite, Wikidata
hoo added a comment to T226925: mw.wikibase.getReferencedEntityId() fails.

This is possibly related to stashed edits, we might need to reset the limit on parser init, but that needs to be tested.

Fri, Nov 1, 11:27 AM · MediaWiki-Documentation, Wikibase-Lua, Wikidata-Campsite, Wikidata

Thu, Oct 31

hoo moved T236355: Create popper Vue component from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 31, 1:06 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Noarave, Wikidata-Tainted-References-Sprint4, Wikidata
hoo moved T236380: Add popper component to storybook from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 31, 1:06 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Noarave, Wikidata-Tainted-References-Sprint4, Wikidata
hoo claimed T236888: Wire Open Action to TaintedIcon click.
Thu, Oct 31, 12:05 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4
hoo moved T236888: Wire Open Action to TaintedIcon click from To Do to Doing on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 31, 12:05 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4
hoo moved T236381: Add a getter for the popper store key from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 31, 11:43 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4, Wikidata
hoo moved T236368: Create action and mutation to open popper from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 31, 10:46 AM · Wikidata-Tainted-References-Sprint4, Wikidata
hoo moved T236369: Create action and mutation to close popper from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 31, 10:46 AM · Wikidata-Tainted-References-Sprint4, Wikidata
hoo moved T236673: [4h timebox] Investigate wrapping OOUI component in Web Component from Doing to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.

Apparently we can't yet use webcomponents in all supported browsers, so this is not the way to go.

Thu, Oct 31, 9:31 AM · Wikidata-Tainted-References-Sprint4
hoo claimed T236673: [4h timebox] Investigate wrapping OOUI component in Web Component.
Thu, Oct 31, 9:21 AM · Wikidata-Tainted-References-Sprint4

Mon, Oct 28

hoo updated the task description for T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings.
Mon, Oct 28, 11:26 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient
hoo created T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings.
Mon, Oct 28, 11:06 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient

Sun, Oct 27

hoo closed T236094: ArticlePlaceholder fails at items with references: "attempt to call method 'getCurrentFrame' (a nil value)." as Resolved.
Sun, Oct 27, 11:27 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite, ArticlePlaceholder, Wikidata
hoo added a comment to T236513: Jenkins jobs failing with Composer TransportException: 404 Not Found (October 2019).

With the above patches, core tests pass - however other repositories are still broken. Ugh.

Sun, Oct 27, 9:11 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Patch-For-Review, Release-Engineering-Team, Continuous-Integration-Infrastructure, Wikimedia-production-error (Shared Build Failure)
hoo created T236609: Consider using hashed module names in RL startup module.
Sun, Oct 27, 8:37 AM · Performance-Team, MediaWiki-ResourceLoader
hoo created P9485 RL hashed module names test script.
Sun, Oct 27, 8:33 AM
hoo created P9484 RL hashed module names test setup.
Sun, Oct 27, 8:32 AM

Sat, Oct 26

hoo added a comment to T236094: ArticlePlaceholder fails at items with references: "attempt to call method 'getCurrentFrame' (a nil value).".

This was caused by 1617bb3deb4e6f761caf3a7bfbee338bfbfe502a upstream, needs further investigating.

Sat, Oct 26, 3:00 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite, ArticlePlaceholder, Wikidata
hoo closed T138819: Create empty Wikidata LUA extension to be installed on Wikidata clients, a subtask of T112073: Lua in Wikibase (tracking), as Invalid.
Sat, Oct 26, 1:08 PM · MediaWiki-extensions-WikibaseClient, Tracking-Neverending, Wikidata
hoo closed T138819: Create empty Wikidata LUA extension to be installed on Wikidata clients as Invalid.

This is not actionable as is, a similar task can be reopened if there's a more concrete proposal.

Sat, Oct 26, 1:08 PM · Wikibase-Lua, Wikidata

Fri, Oct 25

Krinkle awarded T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive a Orange Medal token.
Fri, Oct 25, 4:59 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo claimed T236491: Cache php.getEntityStatements in mw.wikibase.
Fri, Oct 25, 4:23 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

I just purged the page and it is gone now:

Lua Profile:
    Scribunto_LuaSandboxCallback::getEntityStatements               2240 ms       41.6%
    Scribunto_LuaSandboxCallback::callParserFunction                1920 ms       35.7%
    Scribunto_LuaSandboxCallback::getSiteLinkPageName                280 ms        5.2%
    Scribunto_LuaSandboxCallback::gsub                               120 ms        2.2%
    Scribunto_LuaSandboxCallback::incrementStatsKey                  100 ms        1.9%
    Scribunto_LuaSandboxCallback::entityExists                       100 ms        1.9%
    init <Modul:Languages>                                            80 ms        1.5%
    Scribunto_LuaSandboxCallback::anchorEncode                        80 ms        1.5%
    ?                                                                 60 ms        1.1%
    recursiveClone <mwInit.lua:41>                                    60 ms        1.1%
    [others]                                                         340 ms        6.3%

Also I couldn't reproduce it locally… maybe it was just a hhvm thing?

Fri, Oct 25, 3:30 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo updated subscribers of T236491: Cache php.getEntityStatements in mw.wikibase.
Fri, Oct 25, 3:19 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua
hoo created T236491: Cache php.getEntityStatements in mw.wikibase.
Fri, Oct 25, 3:18 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

I just purged the page and it is gone now:

Fri, Oct 25, 3:00 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

That page has almost 700 entity usages:

Fri, Oct 25, 2:36 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo updated subscribers of T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.
Fri, Oct 25, 1:46 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo created T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.
Fri, Oct 25, 1:46 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo added a comment to T236355: Create popper Vue component .

I talked to @Tarrow about this yesterday and we decided it would probably be better to not use OOUI, but do this with Vue ourselves.

Fri, Oct 25, 8:04 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Noarave, Wikidata-Tainted-References-Sprint4, Wikidata
hoo closed T221025: WikibaseClient phpunit tests fail if the "repoDatabase" setting is not false as Resolved.
Fri, Oct 25, 7:22 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata, MediaWiki-extensions-WikibaseClient

Thu, Oct 24

hoo moved T236353: Create new store entry for popper from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Thu, Oct 24, 5:24 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Tainted-References-Sprint4, Wikidata
hoo added a comment to T236355: Create popper Vue component .

Maybe OO.ui.PopupButtonWidget is what we should be using?

Thu, Oct 24, 3:34 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Noarave, Wikidata-Tainted-References-Sprint4, Wikidata
hoo renamed T235734: Use only one RL module for all of tainted references from Investigate why we need two RL modules to Use only one RL module for all of tainted references.
Thu, Oct 24, 3:20 PM · Wikidata-Tainted-References-Sprint4, Wikidata-Tainted-References-Sprint3
hoo moved T235734: Use only one RL module for all of tainted references from To Do to Peer Review on the Wikidata-Tainted-References-Sprint4 board.

I just look at this again and it was easy to get this to work, after I figured that we need to specific the init JS in scripts first (before the common one).

Thu, Oct 24, 3:19 PM · Wikidata-Tainted-References-Sprint4, Wikidata-Tainted-References-Sprint3
hoo added a comment to T236355: Create popper Vue component .

Do we want/ need to use OOUI for this? It probably has something adequate for this?!

Thu, Oct 24, 3:07 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Noarave, Wikidata-Tainted-References-Sprint4, Wikidata