Page MenuHomePhabricator

hoo (Marius Hoch)
User

Projects (25)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 12:09 PM (249 w, 6 d)
Availability
Available
LDAP User
Hoo man
MediaWiki User
Hoo man [ Global Accounts ]

Recent Activity

Today

hoo moved T224844: Show number of senses and forms on page information for WikibaseLexeme entities from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jul 18, 5:52 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata

Yesterday

hoo moved T220826: Wikibase Special:EntityData has 2 parameters that do the same thing from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jul 17, 10:27 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, wikidata-tech-focus, Wikidata
hoo added a comment to T228104: Wikibase dump scripts fail on external storage access.

We backported this to wmf14 now to check for fallout. If there's none, we will also target wmf13 later on.

Wed, Jul 17, 7:42 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error
hoo moved T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

I assume this is fixed now (didn't test, though).

Wed, Jul 17, 7:41 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
hoo moved T228104: Wikibase dump scripts fail on external storage access from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jul 17, 7:10 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error

Tue, Jul 16

hoo added a comment to T227866: Statement indicators for problematic constraints are not visible.
{"P39$D9B5B54E-3763-42E7-95B2-EB38B15A235A":{"status":"not-okay","problems":[{"message-html":"The parameter &quot;<span class=\"wbqc-role wbqc-role-constraint-parameter-property\"><a title=\"Property:P2306\" href=\"/wiki/Property:P2306\">property</a></span>&quot; must only have a single value."}]}}
Tue, Jul 16, 12:52 PM · Wikidata-Campsite, Wikidata, Wikibase-Quality-Constraints
hoo added a comment to T228104: Wikibase dump scripts fail on external storage access.

Alternative patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/523412

Tue, Jul 16, 11:30 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error

Mon, Jul 15

hoo added a comment to T228104: Wikibase dump scripts fail on external storage access.

This is again related to dbgroupdefault (caused by ab09cf2fa59).

Mon, Jul 15, 9:06 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error
hoo created T228104: Wikibase dump scripts fail on external storage access.
Mon, Jul 15, 9:01 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error
hoo moved T227504: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 15, 3:42 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Multimedia, Commons, Wikidata, Lexicographical data
hoo moved T227788: broken site stats dashboard from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 15, 3:28 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
hoo moved T218710: Wikidata grafana dashboard for number of instances of various things is broken from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 15, 10:23 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, WMDE-Analytics-Engineering
hoo added a comment to T227063: Database primary master failover on s8 (wikidatawiki).

@hoo Shouldn't happen, as in "won't happen, we're worrying unnecessarily"?

Mon, Jul 15, 9:23 AM · User-Johan, CommRel-Specialists-Support (Jul-Sep-2019), Wikidata, User-notice

Sat, Jul 13

hoo added a comment to T227063: Database primary master failover on s8 (wikidatawiki).

but strangely UpdateRepoOnMoveJob (more precisely UpdateRepoJob) doesn't fail if it can't edit, it just sends a debug message and act like nothing happened in saveChanges

More specifically, saveChanges() does return true/false to indicate if everything’s okay, but run() ignores the return value and unconditionally returns true itself. I don’t know if this was intentional at the time, but I also think it would probably be better to retry such cases (i. e. return $this->saveChanges( $item, $user );).

Sat, Jul 13, 12:46 PM · User-Johan, CommRel-Specialists-Support (Jul-Sep-2019), Wikidata, User-notice

Thu, Jul 11

hoo added a comment to T223552: external ID linking issue on Factgrid.

Please try to follow these steps: T226499#5326479

Thu, Jul 11, 9:06 PM · FactGrid, Wikidata, Wikidata-Campsite
hoo added a comment to T226499: Check functionality and documenation of formatter URL property configuration.

I followed this documentation https://www.mediawiki.org/wiki/Wikibase/Installation/Advanced_configuration#Define_links_for_external_identifiers localy and the Formatted URL did not work. It happened just like on Factgrid. I am thinking it is a bug on our side.

Thu, Jul 11, 9:05 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), FactGrid, Wikidata

Wed, Jul 10

hoo added a comment to T221917: Create RDF dump of structured data on Commons.

Apparently this is related to the --dbgroupdefault (doesn't seem to depend on the value):

Wed, Jul 10, 5:17 PM · Dumps-Generation, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, WikibaseMediaInfo, Wikidata-Query-Service, SDC General, Commons, Wikidata

Mon, Jul 8

hoo moved T226292: Remove all tracking except for format usage from wmde-analytics-scripts apiLogScanner.php script from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 8, 5:42 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, WMDE-Analytics-Engineering

Thu, Jul 4

hoo moved T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

This is all done.

Thu, Jul 4, 1:34 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
hoo created T227283: Create integration test for dump scripts using the scripts via CLI.
Thu, Jul 4, 1:32 PM · Wikidata, MediaWiki-extensions-WikibaseRepository
hoo added a project to T227276: Check usages/ purpose of GenericServices::getCompactBaseDataModelSerializerFactory: MediaWiki-extensions-WikibaseRepository.
Thu, Jul 4, 1:27 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite
hoo added a comment to T227276: Check usages/ purpose of GenericServices::getCompactBaseDataModelSerializerFactory.

GenericServices::getCompactBaseDataModelSerializerFactory, which is set to omit hashes for references and mainsnaks, is used for everything, but references are correctly included. So either they're injected later on (but I don't see that happening) or the requested omission is not working correctly, it seems.

Thu, Jul 4, 1:27 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite
hoo created T227276: Check usages/ purpose of GenericServices::getCompactBaseDataModelSerializerFactory.
Thu, Jul 4, 12:55 PM · MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite

Wed, Jul 3

hoo added a comment to T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes.

Only thing left to do: Merge https://gerrit.wikimedia.org/r/520501 (makes the integration test cover the actual serialization code).

Wed, Jul 3, 10:26 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
hoo moved T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jul 3, 10:24 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
hoo edited projects for T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
Wed, Jul 3, 10:24 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
hoo added a comment to T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes.

This was caused by a1c5b7ed3eccef653a7041f42d65a09ff83bf6da

Wed, Jul 3, 4:45 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
Restricted Application added a project to T227207: Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes: Wikidata.
Wed, Jul 3, 4:30 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
hoo added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

I think we also need to pass domain in the call to ILoadBalancer::getConnection in PrefetchingPropertyTermLookup::getDbr (remember, when a specific domain is requested, you also need to mark the connection with LoadBalancer::reuseConnection later on).

@hoo what are domains actually?

Wed, Jul 3, 4:26 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
hoo added a comment to T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.

I think we also need to pass domain in the call to ILoadBalancer::getConnection in PrefetchingPropertyTermLookup::getDbr (remember, when a specific domain is requested, you also need to mark the connection with LoadBalancer::reuseConnection later on).

Wed, Jul 3, 1:23 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Tue, Jul 2

hoo added a comment to T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW.

This broke beta commons: https://commons.wikimedia.beta.wmflabs.org/wiki/File:CLD_test.webm (Error: 1146 Table 'commonswiki.wbt_property_terms' doesn't exist (172.16.4.147:3306))

Tue, Jul 2, 6:11 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
hoo reassigned T227031: Update wikibase-docker configuration for wdqs-frontend from hoo to Ladsgroup.
Tue, Jul 2, 2:46 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikibase-Containers, Wikidata
hoo claimed T227031: Update wikibase-docker configuration for wdqs-frontend.
Tue, Jul 2, 2:28 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikibase-Containers, Wikidata
hoo moved T226601: Wikidata JSON dump generation broken from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

This should(tm) should never happen again.

Tue, Jul 2, 1:16 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata
hoo moved T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

I assume this is done now… feel free to move this back if anything is missing.

Tue, Jul 2, 12:36 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata

Mon, Jul 1

hoo added a comment to T221774: Add Wikidata query service lag to Wikidata maxlag.

@maho re feedback on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/512393

Do we even want to do this via Prometheus (WikimediaPrometheusSparqlEndpointReplicationStatus)

Sounds like the right thing to do so to me too, as per https://phabricator.wikimedia.org/T221774#5165165. Warning though, I have very limited knowledge so far on what Prometheus is setup to monitor in our stack. Links are welcome :)
If I understand correctly, it's main and probably only downside is when Prometheus has outdated data on the lag for some reason (if WDQS instance is down/depooled? or the refresh job fails often?) .. which is the same scenario that raises your last questions, I believe:

Shall we disregard lag data if it's really old

I think here I'd rather keep counting that lag. It is at the end the latest known lag to the user querying the lag (last refresh, refresh rate and interval are implementation details). And to this implementation detail, if the latest lag that is known is much farther in the past than I expected it to be, then I should for safety sake go with the assumption that the instance is actually lagging at least that much rather than assuming than risking ignoring that lag, which might in edge cases result in processing the edit instead of rejecting it due to lag.
Does that sound reasonable? or did I misunderstood too much in there?

Mon, Jul 1, 4:46 PM · Patch-For-Review, observability, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Query-Service, Wikidata
hoo moved T226977: Wikibase Travis CI failing, Failed asserting that file "LocalSettings.php" exists. from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jul 1, 4:20 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Fri, Jun 28

hoo moved T226601: Wikidata JSON dump generation broken from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Jun 28, 11:10 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata
hoo added a project to T226601: Wikidata JSON dump generation broken: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
Fri, Jun 28, 11:10 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata

Thu, Jun 27

hoo added a comment to T226601: Wikidata JSON dump generation broken.

I looked into why these incomplete and broken dumps were even published, found and fixed the cause(s) (see above).

Thu, Jun 27, 7:18 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Dumps-Generation, Wikidata
hoo added a comment to T226639: DBError on Wikibase term store.

I wonder if waiting for replication might be another option here to avoid duplicate inserts caused by lag altogether?

Thu, Jun 27, 4:52 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikidata

Wed, Jun 19

hoo added a comment to T220769: Account created without having a loginwiki or metawiki automatically created.

I just discovered a very similar case when locking AureliaSperry. Nothing of interest in the logs at a glance (no obviously related exceptions, fatals, …).

Wed, Jun 19, 2:21 PM · Stewards-and-global-tools, MediaWiki-extensions-CentralAuth
hoo closed T225818: Add type and language filtering capabilities to DatabaseTermIdsResolver::resolveTermsViaJoin as Resolved.
Wed, Jun 19, 8:58 AM · Wikidata, Wikidata wb_terms Trailblazing
hoo closed T225818: Add type and language filtering capabilities to DatabaseTermIdsResolver::resolveTermsViaJoin, a subtask of T225003: Implement PropertyLabelResolver using normalized storage, as Resolved.
Wed, Jun 19, 8:58 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo closed T225717: Implement DatabaseTermIdsResolver::resolveTermsViaJoin as Resolved.
Wed, Jun 19, 8:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
hoo closed T225717: Implement DatabaseTermIdsResolver::resolveTermsViaJoin, a subtask of T225003: Implement PropertyLabelResolver using normalized storage, as Resolved.
Wed, Jun 19, 8:57 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing

Jun 18 2019

hoo created T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource.
Jun 18 2019, 11:13 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Jun 17 2019

hoo committed rEWCScd4f9d95717a: Tests: Change DataAccessSettings constructor call (authored by hoo).
Tests: Change DataAccessSettings constructor call
Jun 17 2019, 2:21 PM
hoo added a comment to T225521: Investigate whether the AbuseFilter can specify which revisions to execute a rule on.

I was asked to quickly chime in on this, AFAIS the best way for you would be to hook into AbuseFilter-filterAction and then figure out your context based on the other variables present (yeah this is not exactly nice :/).

Jun 17 2019, 1:59 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, AbuseFilter, Move-Files-To-Commons, TCB-Team

Jun 14 2019

hoo moved T225718: Add TypeIdsLookup and implement it in DatabaseTypeIdsStore from In Review to Done on the Wikidata wb_terms Trailblazing board.
Jun 14 2019, 9:26 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing

Jun 13 2019

hoo added a comment to T225003: Implement PropertyLabelResolver using normalized storage.

I just realized that limiting the type and language in TermIdsResolver wont do the trick, as we then still need to get all wbpt_term_in_lang_ids first.

Jun 13 2019, 10:36 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo moved T225003: Implement PropertyLabelResolver using normalized storage from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Jun 13 2019, 8:29 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo moved T225002: Implement PrefetchingTermLookup for items using normalized storage from In Review to Done on the Wikidata wb_terms Trailblazing board.
Jun 13 2019, 8:29 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
hoo added a comment to T198676: Add versioning to DCAT-AP config.

Oh, congrats belatedly then :-) I don't know if dcat has special format requirements; if not, then even a simple text file looking kind of like http://get-simple.info/start/changelog/ would be fine as far as I'm concerned. @hoo begging you for assistance once again!

Jun 13 2019, 7:36 AM · Patch-For-Review, Dumps-Generation, User-LokalProfil

Jun 12 2019

hoo moved T225626: Remove fallback to master logic from resolver from In Review to Done on the Wikidata wb_terms Trailblazing board.
Jun 12 2019, 4:49 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata wb_terms Trailblazing

Jun 11 2019

hoo added a comment to T225003: Implement PropertyLabelResolver using normalized storage.

@alaa_wmde @Lucas_Werkmeister_WMDE Does that make sense to ^?

Jun 11 2019, 10:41 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo added a comment to T225003: Implement PropertyLabelResolver using normalized storage.

We could change resolveTermIds( array $termIds ): array (from TermIdsResolver) to resolveTermIds( array $termIds, array $types = null, array $languages = null ): array where we restrict the result set to only contain thing of $types and/ or only things in language(s) $languages. I would change resolveGroupedTermIds accordingly.

Jun 11 2019, 10:40 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo moved T225003: Implement PropertyLabelResolver using normalized storage from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Jun 11 2019, 10:32 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo claimed T225003: Implement PropertyLabelResolver using normalized storage.
Jun 11 2019, 8:47 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
hoo moved T225050: Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer from In Review to Done on the Wikidata wb_terms Trailblazing board.
Jun 11 2019, 8:14 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing

Jun 6 2019

hoo placed T221704: Update wikibase logic to queue a deferred update for cleanup after updating/delete terms in terms store up for grabs.

Moving this to review, so that we can decide if we want to abandon this (probably, yes).

Jun 6 2019, 10:26 PM · Wikidata, Wikidata wb_terms Trailblazing
hoo added a comment to T225212: Specify $wgWBRepoSettings['conceptBaseUri'].

I dimly remember @hoo saying that this would cause debug log warnings and we should expliclitly specify the correct value in mediawiki-config instead.

I'm not sure what level exactly it logs at, but it at very least debug logs… and given we resolve this on almost every Wikidata related request, we should try to avoid this also for performance reasons (even if no one listens to that log).

Jun 6 2019, 10:23 PM · Wikidata

Jun 5 2019

hoo added a comment to T225040: Check if filtering is needed in labs for new term store data.

I also don't see any reason to filter this, the current design is mostly equivalent to wb_terms which is also fully available (only public data is present).

Jun 5 2019, 11:31 AM · Wikidata wb_terms Trailblazing
hoo claimed T221704: Update wikibase logic to queue a deferred update for cleanup after updating/delete terms in terms store.
Jun 5 2019, 11:26 AM · Wikidata, Wikidata wb_terms Trailblazing

Jun 4 2019

hoo updated the task description for T224542: Update Wikibase entity saving logic to use ItemTermStore.
Jun 4 2019, 10:52 AM · Wikidata, Wikidata wb_terms Trailblazing
hoo added a comment to T224269: Handle race-conditions between storage and cleanup logic.

@hoo for wrapping DatabasePropertyTermStore/DatabaseItemTermStore logic (storeTerms() and deleteTerms() methods) inside transactions, I'd probably create a separate task for that (and merge the changes that introduce the classes for now). Make sense to you?

Jun 4 2019, 10:30 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata wb_terms Trailblazing

May 31 2019

hoo added a comment to T224269: Handle race-conditions between storage and cleanup logic.

As also briefly noted in Gerrit, relying on application logic only to ensure that rows are (still) in place seems to be a fairly weak consistency pledge. Exceptions, DB failures, sudden HW failures, …, can prevent these (re-)checks from happening, leaving the tables in an inconsistent state… unlike in transactions, this wont result in a rollback of all changes, but leave us in that inconsistent state.
That shouldn't block us from doing this, but it's something we need to be very well aware of… doing this means we can never be sure all tables are consistent (although I guess we can't ever be really sure about that, thus shouldn't make that assumption).

May 31 2019, 11:10 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata wb_terms Trailblazing

May 29 2019

hoo added a comment to T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException.

This might be fixed along with T223995 which both might have the same root cause.

May 29 2019, 3:53 PM · Wikidata-Campsite, Wikimedia-production-error, Lexicographical data, Wikidata
Restricted Application added a project to T224593: WikibaseLanguageIndependentLuaBindings::getEntityId should normalize page titles if necessary: Wikidata.
May 29 2019, 2:20 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua

May 21 2019

hoo renamed T224014: Figure out the limits in which versions fallback to the next one from Figureout the limits in which versions fallback to the next one to Figure out the limits in which versions fallback to the next one.
May 21 2019, 1:38 PM · Wikidata-Campsite, Wikidata
hoo added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

This used to work, see T196297 (but we didn't write tests back then :S )

May 21 2019, 1:08 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
hoo renamed T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses) from BadMethodCallException wbgetentities when getting Lexemes to BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).
May 21 2019, 1:03 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
hoo renamed T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses) from BadMethodCallException wbgetentities when getting Lexeme Form to BadMethodCallException wbgetentities when getting Lexemes.
May 21 2019, 1:03 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
hoo added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

Also results in error: https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&origin=*&ids=L11533-F7&languages=de&languagefallback=1

May 21 2019, 1:01 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
hoo renamed T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses) from BadMethodCallException wbgetentities when getting label + description for Lexeme Form to BadMethodCallException wbgetentities when getting Lexeme Form.
May 21 2019, 1:01 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata

May 17 2019

hoo moved T223311: Use correct validator in alias changeop and provide error messages if alias is too short from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 17 2019, 11:22 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
hoo moved T223312: feature flag Fix wbeditentity API ignoring setting aliases to an empty set from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 17 2019, 11:22 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository

May 15 2019

hoo moved T223270: Fail on the use of special pages Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 15 2019, 10:54 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Noarave, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

May 13 2019

hoo added a comment to T221774: Add Wikidata query service lag to Wikidata maxlag.

@fgiunchedi @Smalyshev How about I do something like this:

$result = json_decode(file_get_contents('http://prometheus.svc.eqiad.wmnet/ops/api/v1/query?query=blazegraph_lastupdated'), true)['data']['result'];
foreach ( $result as $resultByInstance ) {
	echo $resultByInstance['metric']['instance'] . ' (' .$resultByInstance['metric']['cluster'] . ') has been updated at ' . $resultByInstance['value'][1] . PHP_EOL;
}
wdqs1004:9193 (wdqs) has been updated at 1557755605
wdqs1005:9193 (wdqs) has been updated at 1557755946
wdqs1006:9193 (wdqs) has been updated at 1557758395
wdqs1003:9193 (wdqs-internal) has been updated at 1557758386
wdqs1007:9193 (wdqs-internal) has been updated at 1557758374
wdqs1008:9193 (wdqs-internal) has been updated at 1557758353
wdqs1009:9193 (wdqs-test) has been updated at 1557758403
wdqs1010:9193 (wdqs-test) has been updated at 1557758409
May 13 2019, 3:03 PM · Patch-For-Review, observability, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Query-Service, Wikidata
hoo moved T222621: Not possible to edit items via wbeditentity if they have same label and description from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 13 2019, 2:34 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
hoo closed T198116: Do not load the entire item into the Lua memory without the need as Invalid.

This has always been the case: Ever since that was introduced with 9f25055cd98293aa0b49fe16acd9490b231b29c1 (the function was later renamed, but this is about the implementation).

May 13 2019, 9:52 AM · Wikidata, Wikibase-Lua
hoo added a project to T112658: [Task] WikiPageEntityRevisionLookup::getLatestRevisionId() should throw an UnsersolvedRedirectException when encountering a redirect. : Wikidata-Campsite.
May 13 2019, 9:44 AM · Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, MediaWiki-extensions-WikibaseRepository, Wikidata
hoo added a comment to T221650: Add WikibaseSchema to wmf-config/extension-list.

Per https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/509437#message-f7b925c6397cdb5a95b2561998b51e3d7c798d51: "can be merged after Tuesday next week." (so after May 14)

May 13 2019, 9:42 AM · User-Michael, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo added a comment to T222449: Make existing daily selenium nodejs tests for WikibaseLexeme green again.

@Michael In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/509100#message-105c66f111a3e15944690f1bef71889e210a61b5 you said that https://gerrit.wikimedia.org/r/509356 will probably fix all of that? So… is this done, can we abandon the other patches?

May 13 2019, 9:39 AM · User-Michael, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Browser-Tests, wikidata-tech-focus, Technical-Debt, Lexicographical data, Wikidata

May 10 2019

hoo moved T221644: Port WikibaseLexeme forms.feature Selenium tests from Ruby to Node.js from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 10 2019, 2:49 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Browser-Tests, Story, wikidata-tech-focus, Wikidata-Turtles-Tech-Debt, Technical-Debt, Lexicographical data, Wikidata

May 9 2019

D3r1ck01 awarded T218378: Flaky test Wikibase\Repo SetAliasesTest::testUserCannotSetAliasesWhenTheyLackPermission [4h] a Like token.
May 9 2019, 1:37 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error (Shared Build Failure)
hoo updated subscribers of T194179: Allow configuring WDQS UI without changes to files under version control.

@WMDE-leszek Why was this reopened?

May 9 2019, 11:34 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
hoo updated the task description for T207683: Wikibase Repo api modules and special pages should be conditionally loaded based on entity types enabled (or at least, not crash).
May 9 2019, 11:33 AM · Multimedia, SDC Engineering, StructuredDataOnCommons, Wikidata

May 8 2019

hoo added a comment to T221774: Add Wikidata query service lag to Wikidata maxlag.

@Smalyshev Do you think it would be enough to look at http://prometheus.svc.eqiad.wmnet/ops/api/v1/query?query=blazegraph_lastupdated and http://prometheus.svc.codfw.wmnet/ops/api/v1/query?query=blazegraph_lastupdated (no matter which DC MW is running in) and just take all servers into account? Or do we need a whitelist/blacklist (or both) or some other mechanism to make sure we don't eg. take servers into account that are being maintained.

May 8 2019, 12:22 PM · Patch-For-Review, observability, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Query-Service, Wikidata

May 6 2019

hoo moved T221648: Add EntitySchema to make-wmf-branch/config.json from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 6 2019, 2:55 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo claimed T221648: Add EntitySchema to make-wmf-branch/config.json.
May 6 2019, 2:52 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo renamed T221648: Add EntitySchema to make-wmf-branch/config.json from Add WikibaseSchema to make-wmf-branch/config.json to Add EntitySchema to make-wmf-branch/config.json.
May 6 2019, 2:51 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo added a comment to T222259: random "edit" text on Schema edit page.

I still see the "edit" text on https://wikidata-shex.wmflabs.org/w/index.php?title=EntitySchema:E44&action=edit does it mean it's not yet merged?

May 6 2019, 2:34 PM · Patch-For-Review, User-Noarave, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo moved T222596: EntitySchema\Tests\DataAccess\ArrayRevisionLookup must be compatible with RevisionLookup from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 6 2019, 1:30 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo updated subscribers of T221774: Add Wikidata query service lag to Wikidata maxlag.

Alternative approach:

May 6 2019, 11:00 AM · Patch-For-Review, observability, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Query-Service, Wikidata
hoo added a project to T221774: Add Wikidata query service lag to Wikidata maxlag: observability.
May 6 2019, 10:56 AM · Patch-For-Review, observability, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata-Query-Service, Wikidata
hoo moved T222596: EntitySchema\Tests\DataAccess\ArrayRevisionLookup must be compatible with RevisionLookup from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 6 2019, 10:12 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo moved T222596: EntitySchema\Tests\DataAccess\ArrayRevisionLookup must be compatible with RevisionLookup from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 6 2019, 9:58 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo created T222596: EntitySchema\Tests\DataAccess\ArrayRevisionLookup must be compatible with RevisionLookup.
May 6 2019, 9:57 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
hoo moved T221646: Port WikibaseLexeme non_existing_lexeme.feature Selenium tests from Ruby to Node.js from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
May 6 2019, 9:50 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Browser-Tests, Story, wikidata-tech-focus, Wikidata-Turtles-Tech-Debt, Technical-Debt, Lexicographical data, Wikidata