Page MenuHomePhabricator

hoo (Marius Hoch)
User

Projects (26)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 3 2014, 12:09 PM (277 w, 4 d)
Availability
Available
LDAP User
Hoo man
MediaWiki User
Hoo man [ Global Accounts ]

Recent Activity

Yesterday

hoo moved T243781: Provide a tacking metric for counting "yes that's fine" confirmation clicks. from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint9 board.
Tue, Jan 28, 9:51 PM · Wikidata-Tainted-References-Sprint9, Wikidata
hoo moved T243291: Update Storybook version from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint9 board.
Tue, Jan 28, 1:00 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Documentation, Wikidata
hoo moved T243392: Move storybook to doc.wikimedia.org from Done to Peer Review on the Wikidata-Tainted-References-Sprint9 board.
Tue, Jan 28, 11:13 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Documentation, Wikidata

Mon, Jan 27

hoo moved T243392: Move storybook to doc.wikimedia.org from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.
Mon, Jan 27, 7:40 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Documentation, Wikidata
hoo moved T243392: Move storybook to doc.wikimedia.org from To Do to Doing on the Wikidata-Tainted-References-Sprint9 board.
Mon, Jan 27, 10:41 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Documentation, Wikidata
hoo claimed T243392: Move storybook to doc.wikimedia.org.
Mon, Jan 27, 10:41 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Documentation, Wikidata
hoo moved T234789: Step 2: confirm existing reference when edit doesn't influence it from To Do to Doing on the Wikidata-Tainted-References-Sprint9 board.
Mon, Jan 27, 10:40 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Wikidata

Tue, Jan 21

hoo moved T234789: Step 2: confirm existing reference when edit doesn't influence it from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.
Tue, Jan 21, 5:35 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Wikidata

Mon, Jan 20

hoo claimed T234789: Step 2: confirm existing reference when edit doesn't influence it.
Mon, Jan 20, 12:55 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Tainted-References-Sprint9, Wikidata
hoo moved T242119: StopEditing Hook should dispatch STOP_EDIT action from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.
Mon, Jan 20, 11:48 AM · Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata
hoo added a comment to T242119: StopEditing Hook should dispatch STOP_EDIT action.

The patch up now doesn't change the visible behaviour, as it still explicitly untaints the statement once the edit is cancelled. Changing that behavior (so that the statement will be shown as tainted still) is just a matter of deleting a line now, though.

Mon, Jan 20, 11:00 AM · Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata

Fri, Jan 17

hoo moved T242119: StopEditing Hook should dispatch STOP_EDIT action from Doing to Peer Review on the Wikidata-Tainted-References-Sprint8 board.
Fri, Jan 17, 5:41 PM · Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata
hoo claimed T242119: StopEditing Hook should dispatch STOP_EDIT action.
Fri, Jan 17, 10:56 AM · Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata

Fri, Jan 10

hoo claimed T242117: Test that icon shows only when taintedState is true and editState is false.
Fri, Jan 10, 2:17 PM · Wikidata-Tainted-References-Sprint8, Wikidata

Thu, Jan 9

hoo claimed T242121: Add Cancel hook.
Thu, Jan 9, 12:13 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Wikidata-Tainted-References-Sprint8, Wikidata

Wed, Jan 8

hoo renamed T242119: StopEditing Hook should dispatch STOP_EDIT action from Change cancel hook to set taintState to false if taintState is true and editState is false to Cancel hook handler should set taintState to false if taintState is true and editState is false.
Wed, Jan 8, 11:53 PM · Wikidata-Tainted-References-Sprint9, Wikidata-Tainted-References-Sprint8, Wikidata
hoo moved T240669: Make popper reusable from Doing to Done on the Wikidata-Tainted-References-Sprint8 board.

I think we're done as far as this task goes, the popper is now a easily-reusable component within our source tree (pulling it out would be trivial, but is out of scope here).

Wed, Jan 8, 9:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Wikidata-Tainted-References-Sprint8, Wikidata-Tainted-References-Sprint7
hoo moved T242116: Add an editstate to Store from Doing to Peer Review on the Wikidata-Tainted-References-Sprint8 board.
Wed, Jan 8, 2:45 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata-Tainted-References-Sprint8, Wikidata

Dec 17 2019

hoo moved T237968: Add browser tests for the tainted icon from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint7 board.
Dec 17 2019, 12:03 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6

Dec 16 2019

hoo claimed T240669: Make popper reusable.
Dec 16 2019, 12:20 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Wikidata-Tainted-References-Sprint8, Wikidata-Tainted-References-Sprint7

Dec 13 2019

hoo added a comment to T240669: Make popper reusable.

I just talked to @Tarrow about this, and for now it should be enough to use that new component directly in App.vue, but if that turns out to bloat App.vue to much we will revisit this.

Dec 13 2019, 11:11 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Wikidata-Tainted-References-Sprint8, Wikidata-Tainted-References-Sprint7

Dec 12 2019

hoo moved T240476: Add and use correct X button asset from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint7 board.
Dec 12 2019, 6:49 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Tainted-References-Sprint7
hoo moved T233097: Step 1: Localise any currently hardcoded messages from Peer Review to Done on the Wikidata-Tainted-References-Sprint7 board.
Dec 12 2019, 9:53 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata

Dec 11 2019

hoo moved T233097: Step 1: Localise any currently hardcoded messages from Doing to Peer Review on the Wikidata-Tainted-References-Sprint7 board.
Dec 11 2019, 1:36 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata
hoo moved T238423: Getting direct user feedback (Step 1) from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint7 board.
Dec 11 2019, 1:36 PM · Wikidata-Tainted-References-Sprint7, Patch-For-Review, User-Noarave, Wikidata-Tainted-References-Sprint6, Wikidata

Dec 9 2019

hoo moved T233097: Step 1: Localise any currently hardcoded messages from Done to Peer Review on the Wikidata-Tainted-References-Sprint7 board.
Dec 9 2019, 7:37 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata
hoo moved T238423: Getting direct user feedback (Step 1) from Peer Review to Doing on the Wikidata-Tainted-References-Sprint7 board.
Dec 9 2019, 7:37 PM · Wikidata-Tainted-References-Sprint7, Patch-For-Review, User-Noarave, Wikidata-Tainted-References-Sprint6, Wikidata
hoo moved T238423: Getting direct user feedback (Step 1) from Doing to Peer Review on the Wikidata-Tainted-References-Sprint7 board.
Dec 9 2019, 7:37 PM · Wikidata-Tainted-References-Sprint7, Patch-For-Review, User-Noarave, Wikidata-Tainted-References-Sprint6, Wikidata
hoo claimed T233097: Step 1: Localise any currently hardcoded messages.
Dec 9 2019, 3:58 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata
hoo moved T233097: Step 1: Localise any currently hardcoded messages from Test (Product Review) to Doing on the Wikidata-Tainted-References-Sprint6 board.
Dec 9 2019, 3:58 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata

Dec 6 2019

hoo added a comment to T237968: Add browser tests for the tainted icon.

@Tarrow Can you link the respective changes here?

Dec 6 2019, 1:57 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6
hoo moved T236407: Share ESLint config from Peer Review to Done on the Wikidata-Tainted-References-Sprint6 board.
Dec 6 2019, 10:47 AM · Wikidata-Tainted-References-Sprint6, Wikidata
hoo moved T233097: Step 1: Localise any currently hardcoded messages from Doing to Peer Review on the Wikidata-Tainted-References-Sprint6 board.
Dec 6 2019, 10:45 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata

Dec 4 2019

hoo moved T233097: Step 1: Localise any currently hardcoded messages from Peer Review to Doing on the Wikidata-Tainted-References-Sprint6 board.
Dec 4 2019, 10:45 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata

Dec 2 2019

hoo moved T233097: Step 1: Localise any currently hardcoded messages from To Do to Peer Review on the Wikidata-Tainted-References-Sprint6 board.
Dec 2 2019, 6:44 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, Wikidata

Nov 28 2019

hoo added a comment to T185313: mw.wikibase.entity:getBacklinks (lua API in wikibase client).

So I just looked into this a bit and sadly this is not a trivial change. First of all, I don't think we want to expose backlinks (as in Special:WhatLinksHere) as these don't have the semantics the use cases here call for (and using them still would probably lead to strange behavior in the long run). That's because these are just all links pointing to a page, no matter where these originate from: statement (main) values, reference values, qualifier values (and probably even more).

Nov 28 2019, 4:58 PM · patch-welcome, Wikibase-Lua, Wikidata, MediaWiki-extensions-WikibaseClient

Nov 22 2019

hoo moved T238401: Add tracking code relating to statement changes from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Nov 22 2019, 3:05 PM · Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6, User-Noarave, Wikidata

Nov 21 2019

hoo moved T231730: Step 1: Help link from To Do to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.

I think this is actually fully done by now.

Nov 21 2019, 9:02 PM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo moved T238562: Don't access the Vue-$parent, but use props from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Nov 21 2019, 11:10 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5

Nov 20 2019

hoo moved T238562: Don't access the Vue-$parent, but use props from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Nov 20 2019, 10:24 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5
hoo moved T238402: Add tracking code relating to TaintedIcon clicks from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Nov 20 2019, 9:04 AM · Wikidata-Tainted-References-Sprint6, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Noarave, Wikidata-Tainted-References-Sprint5, Wikidata
hoo moved T238402: Add tracking code relating to TaintedIcon clicks from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Nov 20 2019, 7:53 AM · Wikidata-Tainted-References-Sprint6, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Noarave, Wikidata-Tainted-References-Sprint5, Wikidata

Nov 19 2019

hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Nov 19 2019, 9:47 PM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo added a comment to T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”.

Thanks @Anomie, that makes sense.

Nov 19 2019, 3:08 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
hoo added a comment to T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”.

But what is actually stored in the database (SELECT TYPEOF)?

Nov 19 2019, 1:58 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
hoo claimed T238562: Don't access the Vue-$parent, but use props.
Nov 19 2019, 1:15 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5
hoo added a comment to T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”.

Hm, it still fails when calling initState() with [ '0' => 'foowiki' ], so I don’t think casting $siteID to a string in initState() would change anything. There’s some confusion between strings and numbers somewhere…

Nov 19 2019, 1:13 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Nov 18 2019

hoo created T238562: Don't access the Vue-$parent, but use props.
Nov 18 2019, 3:37 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5

Nov 16 2019

hoo created P9648 Wikibase Client EntityAccessor::renumber benchmarks.
Nov 16 2019, 2:39 PM

Nov 15 2019

hoo moved T237734: Mount Popper Component from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.

I think we're done here, the popper is now properly mounted to the tainted icon. Everything else (styling, wording, …) is out of scope for this task.

Nov 15 2019, 12:32 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo closed T237261: Track help link click metrics as Resolved.
Nov 15 2019, 11:37 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo closed T237261: Track help link click metrics, a subtask of T231730: Step 1: Help link, as Resolved.
Nov 15 2019, 11:37 AM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata

Nov 14 2019

hoo moved T237261: Track help link click metrics from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Nov 14 2019, 11:00 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata

Nov 13 2019

hoo closed T237903: Wikibase: Change JS-esque entries to Lua as Resolved.
Nov 13 2019, 4:09 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata, Wikibase-Lua
hoo added a comment to T237261: Track help link click metrics.

Note: We decided to wrap mw.track in a Vue component now. I made some initial progress here and will (hopefully) finish that tomorrow.

Nov 13 2019, 1:51 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo added a comment to T237261: Track help link click metrics.

So bridge uses a ServiceContainer to hold (as 'tracker') a mw.track instance. They use that, via their EventTracker and via DataBridgeTrackerService. We should probably do the same or something similar, although we can probably get away with a little less abstraction?

Nov 13 2019, 12:32 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo claimed T237261: Track help link click metrics.
Nov 13 2019, 12:11 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata

Nov 11 2019

hoo committed rEBQC5c6cf50b2dad: Constraints report "Help" should link using SpecialMyLanguage (authored by hoo).
Constraints report "Help" should link using SpecialMyLanguage
Nov 11 2019, 1:01 PM
hoo updated the task description for T237968: Add browser tests for the tainted icon.
Nov 11 2019, 12:22 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6
hoo moved T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board.
Nov 11 2019, 12:17 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikibase-Quality-Constraints, Wikidata
hoo created T237968: Add browser tests for the tainted icon.
Nov 11 2019, 12:16 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Wikidata-Tainted-References-Sprint7, Wikidata-Tainted-References-Sprint6
hoo closed T237867: Popper state needs to be initialized (set via Vue.set) as Resolved.
Nov 11 2019, 12:06 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo moved T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage from Doing to Peer Review on the Wikidata-Tainted-References-Sprint5 board.
Nov 11 2019, 11:24 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikibase-Quality-Constraints, Wikidata
hoo claimed T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage.
Nov 11 2019, 11:17 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikibase-Quality-Constraints, Wikidata
hoo added a comment to T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings.

I purged all pages from above (which haven't been re-parsed since) and gathered new numbers:

  1. The average PC size is 101219.66 (down ~2.7%)
  2. The median PC size is 68137 (down ~7.2%)
  3. The minimum PC size is 12911 (down ~3.1%)
  4. The maximum PC size is 393856 (down ~1.4%)
Nov 11 2019, 9:59 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient

Nov 10 2019

hoo updated subscribers of T153844: Don't load jquery.uls.data unless it's needed.

The same seems to be true for enwiki (logged out, private mode, random article):

Nov 10 2019, 6:24 PM · Performance Issue, UniversalLanguageSelector
hoo updated the task description for T237867: Popper state needs to be initialized (set via Vue.set).
Nov 10 2019, 5:38 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo claimed T237867: Popper state needs to be initialized (set via Vue.set).
Nov 10 2019, 5:32 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo created T237867: Popper state needs to be initialized (set via Vue.set).
Nov 10 2019, 5:32 PM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4

Nov 8 2019

hoo created T237734: Mount Popper Component.
Nov 8 2019, 3:22 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Peer Review to Doing on the Wikidata-Tainted-References-Sprint4 board.
Nov 8 2019, 12:58 PM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236890: Fix TaintedIcon alignment style from Doing to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Nov 8 2019, 11:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Nov 8 2019, 12:21 AM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo added a comment to T236889: Wire Close Popper Action to 'cross' and blur action.

I just implemented it like this, but I'm not sure that's going to suffice… if the user clicks on the popper, this will probably also trigger the blur and thus close the popper. Maybe if the popper is a direct child of the TaintedIcon <a> this will work, but I'm not sure.

Nov 8 2019, 12:21 AM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4

Nov 7 2019

hoo added a comment to T236889: Wire Close Popper Action to 'cross' and blur action.

So apparently OOUI sets tabindex="0" on the constraints icon, with that we can actually focus (and thus also handle blur). I'll do the same for us in order to re-implement the behavior as closely as possible.

Nov 7 2019, 10:38 AM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo closed T237247: Untaint action should also set the popper to be closed as Resolved.
Nov 7 2019, 10:11 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Peer Review to Doing on the Wikidata-Tainted-References-Sprint4 board.
Nov 7 2019, 10:11 AM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4

Nov 6 2019

hoo added a comment to T236889: Wire Close Popper Action to 'cross' and blur action.

I have a patch that wires up the "x" to close the popper, I didn't yet look into closing it if the user clicks onto something else.

Nov 6 2019, 1:55 PM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T236889: Wire Close Popper Action to 'cross' and blur action from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Nov 6 2019, 1:55 PM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo claimed T236889: Wire Close Popper Action to 'cross' and blur action.
Nov 6 2019, 11:08 AM · Wikidata-Tainted-References-Sprint6, Wikidata-Tainted-References-Sprint5, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T237247: Untaint action should also set the popper to be closed from Doing to Peer Review on the Wikidata-Tainted-References-Sprint4 board.
Nov 6 2019, 11:06 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo claimed T237247: Untaint action should also set the popper to be closed.
Nov 6 2019, 11:02 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo moved T237247: Untaint action should also set the popper to be closed from To Do to Doing on the Wikidata-Tainted-References-Sprint4 board.
Nov 6 2019, 11:02 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo claimed T237260: Add help link to Popper Component.
Nov 6 2019, 10:56 AM · Wikidata-Tainted-References-Sprint5, Wikidata-Tainted-References-Sprint4, Wikidata
hoo added a comment to T233213: XSS in Wikidata Query Service UI, DATATYPE_MATHML - CVE-2019-19329.

I just checked the live site and I still see the old code deployed when looking at the minified JS.

The new minified versions are present (alongside the current versions), but index.html was not updated on the individual hosts (so the state on deploy1001 differs from the state on the actual wdqs servers).

hoo@deploy1001:/srv/deployment/wdqs/wdqs/gui$ md5sum $(pwd)/index.html
11ee88217d78d98e52f9008add62a23c  /srv/deployment/wdqs/wdqs/gui/index.html
hoo@wdqs1005:/srv/deployment/wdqs/wdqs/gui$ md5sum $(pwd)/index.html
29ce000ed3201781a6c06eb03d73b002  /srv/deployment/wdqs/wdqs/gui/index.html

@Mathew.onipe Do you want to re-scap?

Nov 6 2019, 9:11 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security
hoo added a comment to T233213: XSS in Wikidata Query Service UI, DATATYPE_MATHML - CVE-2019-19329.

I just checked the live site and I still see the old code deployed when looking at the minified JS.

Nov 6 2019, 9:07 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security
hoo added a comment to T236749: Don't store actual EntityUsage objects in ParserOutput, but just minimal identifier strings.

I collected some data about the parser cache sizes of the ruwiki pages with the most hits this month (as per stats.wikimedia.org).

Nov 6 2019, 1:24 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Performance Issue, MediaWiki-extensions-WikibaseClient
hoo created P9535 Top 100 ruwiki pages parser cache size.
Nov 6 2019, 1:12 AM · Wikidata
hoo added a comment to T193781: [task] Configure ArticlePlaceholder for nowiki.

With T195751 fixed, will ArticlePlaceholders show up in Special:Search once the extension is configured for nowiki?

Nov 6 2019, 12:24 AM · ArticlePlaceholder, Wikidata, Wikimedia-Extension-setup
hoo closed T236888: Wire Open Action to TaintedIcon click as Resolved.

This is in verification but I don't think I can verify this. Close?

Nov 6 2019, 12:04 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4

Nov 5 2019

hoo added a comment to T236491: Cache php.getEntityStatements in mw.wikibase.

@hoo now that this is all merged and deployed, how is it looking? :) can we close?

Nov 5 2019, 9:34 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

Possibly related: T236749

Nov 5 2019, 9:30 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo added a comment to T236485: Wikibase Lua: addStatementUsage seems unjustifiably expensive.

@hoo now that this is deployed, how is it performing?

Nov 5 2019, 9:29 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
hoo added a comment to T237258: Decide how to make mw.wikibase.getReferencedEntityId (or a new function) useful to lookup referenced entity ids based on multiple starting points.

Another possible signature: wikibase.getReferencedEntityId( { ...fromEntityIds }, propertyId, { ...toIds } ). (Some previous discussion for this is in T179155#4104367 and following comments.)

Nov 5 2019, 9:25 PM · Wikidata, Wikibase-Lua
hoo added a comment to T233213: XSS in Wikidata Query Service UI, DATATYPE_MATHML - CVE-2019-19329.

@hoo you mentioned you still have access to the WDQS servers, do you know how to deploy a change to the UI? (T233213#5584298 is probably the most important comment to catch up on.)

Nov 5 2019, 9:20 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security
hoo moved T236888: Wire Open Action to TaintedIcon click from Peer Review to Test (Product Review) on the Wikidata-Tainted-References-Sprint4 board.
Nov 5 2019, 9:13 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Tainted-References-Sprint4

Nov 4 2019

hoo created T237258: Decide how to make mw.wikibase.getReferencedEntityId (or a new function) useful to lookup referenced entity ids based on multiple starting points.
Nov 4 2019, 2:21 PM · Wikidata, Wikibase-Lua
hoo created T237249: Globally track Scribunto LuaSandbox profiling data.
Nov 4 2019, 12:18 PM · Wikidata, Wikibase-Lua, MediaWiki-extensions-Scribunto
hoo added a project to T237247: Untaint action should also set the popper to be closed: Wikidata-Tainted-References-Sprint4.
Nov 4 2019, 11:51 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4
hoo created T237247: Untaint action should also set the popper to be closed.
Nov 4 2019, 11:50 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Tainted-References-Sprint4