Page MenuHomePhabricator

hueitan (Huei Tan)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2019, 11:41 AM (67 w, 1 d)
Availability
Available
LDAP User
Huei Tan
MediaWiki User
HTan (WMF) [ Global Accounts ]

Recent Activity

Mon, Mar 1

hueitan moved T275621: Enable/disable experiment based on config on mediawiki from Dev to Code Review on the Inuka-Team (Kanban) board.

PR https://github.com/wikimedia/wikipedia-kaios/pull/328

Mon, Mar 1, 2:33 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)

Fri, Feb 26

hueitan moved T272276: Empty space search result from Code Review to QA on the Inuka-Team (Kanban) board.
Fri, Feb 26, 9:02 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Thu, Feb 25

hueitan added a comment to T275810: Should we host Wikipedia Preview?.

May not be up to our privacy standards for readers

Thu, Feb 25, 11:56 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T269934: Provide hooks for 3rd party instrumentation from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Feb 25, 11:27 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan added a comment to T275621: Enable/disable experiment based on config on mediawiki.

You are right, after trying on device, we are able to get the info, thanks!

Thu, Feb 25, 3:36 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
hueitan added a comment to T275621: Enable/disable experiment based on config on mediawiki.

The current country of the app can be obtained by reading the Geojson string in the 'set-cookie' header of the API call to get the experiment config. See this commit

Thu, Feb 25, 1:46 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)

Wed, Feb 24

hueitan moved T275621: Enable/disable experiment based on config on mediawiki from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Wed, Feb 24, 3:35 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
hueitan claimed T275621: Enable/disable experiment based on config on mediawiki.
Wed, Feb 24, 3:35 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
hueitan edited projects for T271910: Topic feed on app homepage, added: Inuka-Team; removed Inuka-Team (Kanban).
Wed, Feb 24, 3:33 PM · Inuka-Team, KaiOS-Wikipedia-app (Engagement-1)
hueitan placed T271910: Topic feed on app homepage up for grabs.

As of today, the branch T271910-topics-feed has the following UI in this Pull Request.

Wed, Feb 24, 3:33 PM · Inuka-Team, KaiOS-Wikipedia-app (Engagement-1)

Mon, Feb 22

hueitan added a comment to F34118926: image.png.

image taken from https://github.com/wikimedia/wikipedia-kaios/pull/320#issuecomment-783449927

Mon, Feb 22, 4:27 PM
hueitan moved T271916: Loading indicator for slow connection on app homepage from Dev to Code Review on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/320

Mon, Feb 22, 4:26 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T271916: Loading indicator for slow connection on app homepage.
Mon, Feb 22, 1:42 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Wed, Feb 10

hueitan reassigned T271904: Popular article feed on app homepage from hueitan to eamedina.
Wed, Feb 10, 3:49 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
hueitan added a comment to T271904: Popular article feed on app homepage.

Note to dev :

Wed, Feb 10, 1:44 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
hueitan added a comment to T247735: Edit pencil in quick facts section.

@hueitan is the fix here to not select the pencil icon inside the quick fact page?

Wed, Feb 10, 1:21 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Tue, Feb 9

hueitan moved T270469: Remove onboarding screens. from Code Review to QA on the Inuka-Team (Kanban) board.
Tue, Feb 9, 11:09 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Thu, Feb 4

hueitan claimed T271904: Popular article feed on app homepage.
Thu, Feb 4, 3:17 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
hueitan moved T253224: Group images within an article from QA WAITING FOR FEEDBACK to QA on the Inuka-Team (Kanban) board.

@hueitan I can't select the ASDA image
http://0.0.0.0:8080/#/article/sv/Asda
it is an image on https://sv.wikipedia.org/wiki/Asda but it has a different template

[[Fil:ASDA logo.svg|right|70px]]
[[File:ASDA house.jpg|thumb|right|''Asda House'', [[Leeds]].]]

is this an issue for another ticket?

Thu, Feb 4, 11:04 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Wed, Feb 3

hueitan updated the task description for T273631: Zero configuration Wikipedia Preview integration.
Wed, Feb 3, 4:25 PM · Inuka-Team, Wikipedia-Preview
hueitan placed T267634: label of map shows on top of article text up for grabs.

Unfotunately, I don't see any solution to handle this case for now, therefore moving back to ready for dev colun

Wed, Feb 3, 10:04 AM · Inuka-Team, KaiOS-Wikipedia-app

Feb 1 2021

hueitan updated the task description for T253224: Group images within an article.
Feb 1 2021, 4:31 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T272276: Empty space search result from Code Review to QA on the Inuka-Team (Kanban) board.
Feb 1 2021, 3:26 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Jan 22 2021

hueitan added a comment to T272484: "listaref" renders badly in the article.

Not sure this is directly related to this task or a separate bug, the pagination breaks in some parts of the article "Elecciones presidenciales de estados unidos en Minesota de 2020"

Jan 22 2021, 2:09 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Jan 21 2021

hueitan updated the task description for T253224: Group images within an article.
Jan 21 2021, 6:04 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan updated the task description for T271697: Unable to select image in quickfact page.
Jan 21 2021, 2:43 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T253224: Group images within an article from Dev to Code Review on the Inuka-Team (Kanban) board.

Fix in PR https://github.com/wikimedia/wikipedia-kaios/pull/308

Jan 21 2021, 11:17 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T247735: Edit pencil in quick facts section from Dev to Code Review on the Inuka-Team (Kanban) board.

Fix in PR https://github.com/wikimedia/wikipedia-kaios/pull/308

Jan 21 2021, 11:17 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T271697: Unable to select image in quickfact page from Dev to Code Review on the Inuka-Team (Kanban) board.

Fix in PR https://github.com/wikimedia/wikipedia-kaios/pull/308

Jan 21 2021, 11:16 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T272581: Image highlighted is not visible in Quickfact.
Jan 21 2021, 10:58 AM · Inuka-Team, KaiOS-Wikipedia-app

Jan 20 2021

hueitan added a comment to T272484: "listaref" renders badly in the article.

let me know if anyone find more cases in this form.

Jan 20 2021, 1:42 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T272484: "listaref" renders badly in the article.

PR in https://github.com/wikimedia/wikipedia-kaios/pull/310

Jan 20 2021, 1:40 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T272484: "listaref" renders badly in the article.
Jan 20 2021, 1:38 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Jan 19 2021

hueitan moved T247735: Edit pencil in quick facts section from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Jan 19 2021, 4:00 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T247735: Edit pencil in quick facts section from Bugs to Kanban on the Inuka-Team board.
Jan 19 2021, 3:59 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan reopened T247735: Edit pencil in quick facts section as "Open".

It is possible to handle this case on the recent change in the image link selector code, moving this into Kanban board.

Jan 19 2021, 3:59 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Jan 18 2021

hueitan claimed T253224: Group images within an article.
Jan 18 2021, 5:31 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T253224: Group images within an article from Backlog to Kanban on the Inuka-Team board.
Jan 18 2021, 5:31 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T267634: label of map shows on top of article text.
Jan 18 2021, 10:29 AM · Inuka-Team, KaiOS-Wikipedia-app
hueitan created T272276: Empty space search result.
Jan 18 2021, 10:23 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T271461: Polish textsize slider and add RTL support in TextSize component.

this task doesn't change anything of the select softkey, your case might be some other specific reason, can you show us your step to reproduce?

Jan 18 2021, 9:58 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Jan 14 2021

hueitan added a comment to T271697: Unable to select image in quickfact page.

Html Markup of this

Jan 14 2021, 2:50 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Jan 13 2021

hueitan added a comment to T269934: Provide hooks for 3rd party instrumentation.

I vote for the first option

Jan 13 2021, 9:46 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T270110: Re-order settings menu from Code Review to QA on the Inuka-Team (Kanban) board.
Jan 13 2021, 3:10 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T270110: Re-order settings menu .

PR https://github.com/wikimedia/wikipedia-kaios/pull/305 (merged)

Jan 13 2021, 4:59 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Jan 12 2021

hueitan moved T268751: Search for every word in a query from QA WAITING FOR FEEDBACK to QA on the Inuka-Team (Kanban) board.

this is expected behaviour to show snippet in the description line.

Jan 12 2021, 5:03 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to F31830559: Screenshot 2020-05-18 at 16.21.19.png.

article Australia

Jan 12 2021, 5:44 AM

Jan 11 2021

hueitan added a comment to T271697: Unable to select image in quickfact page.

A ticket that may relevant as this is the matter of image template T253224: Group images within an article

Jan 11 2021, 6:54 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T271697: Unable to select image in quickfact page.
Jan 11 2021, 6:19 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan updated subscribers of T267634: label of map shows on top of article text.

There are more examples share the similar template but different view

Jan 11 2021, 5:59 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan updated the task description for T271697: Unable to select image in quickfact page.
Jan 11 2021, 1:39 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T271697: Unable to select image in quickfact page.

when fixing this, if possible, don't make the pencil available for selection. T247735: Edit pencil in quick facts section

Jan 11 2021, 11:15 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T271697: Unable to select image in quickfact page.
Jan 11 2021, 10:36 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Jan 7 2021

hueitan added a comment to T271461: Polish textsize slider and add RTL support in TextSize component.

PR : https://github.com/wikimedia/wikipedia-kaios/pull/303

Jan 7 2021, 8:44 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T271461: Polish textsize slider and add RTL support in TextSize component from Dev to Code Review on the Inuka-Team (Kanban) board.
Jan 7 2021, 8:44 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T271461: Polish textsize slider and add RTL support in TextSize component.
Jan 7 2021, 8:31 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Jan 5 2021

hueitan added a comment to T267634: label of map shows on top of article text.

This is yet another form of image with the template that we never handle before

Jan 5 2021, 8:54 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan updated the task description for T268751: Search for every word in a query.
Jan 5 2021, 9:55 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Dec 17 2020

hueitan updated the task description for T268751: Search for every word in a query.
Dec 17 2020, 11:39 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Dec 16 2020

hueitan moved T268751: Search for every word in a query from Dev to Code Review on the Inuka-Team (Kanban) board.
Dec 16 2020, 12:46 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Dec 15 2020

hueitan claimed T267634: label of map shows on top of article text.
Dec 15 2020, 12:54 PM · Inuka-Team, KaiOS-Wikipedia-app

Dec 14 2020

hueitan added a comment to T244548: Set up preview counting for KaiOS app.

I also checked again for events that failed validation and this time found two from last Tuesday that were missing the required source_title property, but those were both from a Windows computer, so I don't think it's related to this.

Dec 14 2020, 1:27 PM · Inuka-Team (Kanban), Analytics, Product-Analytics

Dec 11 2020

hueitan moved T269856: Cancel feedback dialog message in French breaks the app from Code Review to QA on the Inuka-Team (Kanban) board.

PR is merged.

Dec 11 2020, 10:36 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 10 2020

hueitan moved T269822: Improve the visibility of suggested article section. from Dev to Code Review on the Inuka-Team (Kanban) board.

PR : https://github.com/wikimedia/wikipedia-kaios/pull/295

Dec 10 2020, 5:08 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T269822: Improve the visibility of suggested article section. .
Dec 10 2020, 3:37 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T268751: Search for every word in a query.

The differece between mobile web and kaios is no submit button (same to ios)

Dec 10 2020, 10:51 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T262249: Implement a confirmation dialogue when closing the app.

Follow up PR : https://github.com/wikimedia/wikipedia-kaios/pull/293

Dec 10 2020, 10:04 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T267290: For Jio users show Indian languages on top inside the article menu. .

Thanks @SBisson. @hueitan maybe I missed this point earlier, to show the Indian language on top, are we alphabetically sorting them?

Dec 10 2020, 9:50 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T262249: Implement a confirmation dialogue when closing the app from Dev to Code Review on the Inuka-Team (Kanban) board.
Dec 10 2020, 9:46 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 9 2020

hueitan added a comment to T260516: Reusable Header Component.

We have seen some inconsistency problem of the header text position due to the setting

Dec 9 2020, 4:48 PM · KaiOS-Wikipedia-app, Inuka-Team
hueitan added a comment to T262249: Implement a confirmation dialogue when closing the app.

@hueitan is it possible to center the "Exit Wikipedia" text in the header area? On the banana phone device, the tail of "p" is touching the main text area.

Dec 9 2020, 2:43 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T268751: Search for every word in a query.

Prefixsearch does exactly what it says, it searches for prefixes. If you want to use fulltext search, its something like:

{
  "action": "query",
  "list:" : "search",
  "srsearch": "my words to look for",
}
Dec 9 2020, 1:09 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T268751: Search for every word in a query.

This is useful! I don't know there is the addition query after the submission in mobile web page until your comment here!

Dec 9 2020, 1:03 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Dec 8 2020

hueitan moved T269213: Remove caption from the gallery from Code Review to QA on the Inuka-Team (Kanban) board.

PR merged.

Dec 8 2020, 8:14 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 7 2020

hueitan added a comment to T268751: Search for every word in a query.

I would generally suggest you implement something similar to what the website's do, for consistency of UX (although I'm certainly no UX expert).

Dec 7 2020, 6:02 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Dec 3 2020

hueitan moved T269158: Confirm dialog close alls the popup page that is not expected from Dev to Code Review on the Inuka-Team (Kanban) board.

PR is here https://github.com/wikimedia/wikipedia-kaios/pull/289

Dec 3 2020, 1:46 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan updated the task description for T269158: Confirm dialog close alls the popup page that is not expected.
Dec 3 2020, 1:46 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 2 2020

hueitan updated the task description for T269213: Remove caption from the gallery .
Dec 2 2020, 2:22 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan created T269217: IE11 UI glitch on the gallery caption.
Dec 2 2020, 11:04 AM · Browser-Support-Internet-Explorer, Wikipedia-Preview, Inuka-Team
hueitan added a comment to T269213: Remove caption from the gallery .

Note to dev : Remember to modify the arrow indicator css code as well

Dec 2 2020, 10:14 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T269158: Confirm dialog close alls the popup page that is not expected.

tech Implementation details summary:

Dec 2 2020, 9:59 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 1 2020

hueitan claimed T269158: Confirm dialog close alls the popup page that is not expected.
Dec 1 2020, 6:51 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T269158: Confirm dialog close alls the popup page that is not expected from Bugs to Kanban on the Inuka-Team board.
Dec 1 2020, 6:51 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan created T269158: Confirm dialog close alls the popup page that is not expected.
Dec 1 2020, 6:50 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T268751: Search for every word in a query.
Dec 1 2020, 10:24 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T244548: Set up preview counting for KaiOS app from Dev to Code Review on the Inuka-Team (Kanban) board.

Inuka Team progress PR is here https://github.com/wikimedia/wikipedia-kaios/pull/286

Dec 1 2020, 10:19 AM · Inuka-Team (Kanban), Analytics, Product-Analytics

Nov 30 2020

hueitan claimed T244548: Set up preview counting for KaiOS app.
Nov 30 2020, 3:09 PM · Inuka-Team (Kanban), Analytics, Product-Analytics

Nov 27 2020

hueitan moved T267291: Add visual indicator to show more images inside gallery. from Dev to Code Review on the Inuka-Team (Kanban) board.

PR has merged https://github.com/wikimedia/wikipedia-kaios/pull/285

Nov 27 2020, 11:59 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Nov 24 2020

hueitan claimed T267291: Add visual indicator to show more images inside gallery. .
Nov 24 2020, 10:46 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T267290: For Jio users show Indian languages on top inside the article menu. from Dev to Code Review on the Inuka-Team (Kanban) board.

PR : https://github.com/wikimedia/wikipedia-kaios/pull/284

Nov 24 2020, 10:11 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan updated the task description for T267290: For Jio users show Indian languages on top inside the article menu. .
Nov 24 2020, 9:44 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan updated the task description for T267290: For Jio users show Indian languages on top inside the article menu. .
Nov 24 2020, 9:26 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T267290: For Jio users show Indian languages on top inside the article menu. .

a to be confirmed behaviour that handle within here https://phabricator.wikimedia.org/T267289#6634905

Nov 24 2020, 8:40 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T262249: Implement a confirmation dialogue when closing the app.

@hueitan has this been addressed in the PR?

Nov 24 2020, 8:34 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Nov 23 2020

hueitan added a comment to T262249: Implement a confirmation dialogue when closing the app.

Good catch @eamedina , waiting confirmation.

Nov 23 2020, 11:32 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Nov 20 2020

hueitan moved T268057: Wrong source image link when gallery opens in offline mode from Code Review to QA on the Inuka-Team (Kanban) board.
Nov 20 2020, 4:41 PM · Inuka-Team (Kanban), Wikipedia-Preview

Nov 19 2020

hueitan updated subscribers of T267289: Improve the visibility of search results highlighter. .

@SBisson shall we remove the word default from here? Anyway now we match the default experience of the app as per the set language on device.

Nov 19 2020, 8:14 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Nov 18 2020

hueitan moved T268057: Wrong source image link when gallery opens in offline mode from Dev to Code Review on the Inuka-Team (Kanban) board.

PR https://github.com/wikimedia/wikipedia-preview/pull/91

Nov 18 2020, 6:49 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan claimed T268057: Wrong source image link when gallery opens in offline mode.
Nov 18 2020, 6:44 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan added a comment to T267290: For Jio users show Indian languages on top inside the article menu. .

When looking at the change app language option

Nov 18 2020, 12:53 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app