Page MenuHomePhabricator

hueitan (Huei Tan)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2019, 11:41 AM (87 w, 4 d)
Availability
Available
LDAP User
Huei Tan
MediaWiki User
HTan (WMF) [ Global Accounts ]

Recent Activity

Tue, Jul 20

hueitan moved T286654: The Gallery / wp-dark-screen are hidden from Dev to Code Review on the Inuka-Team (Kanban) board.

PR: https://github.com/wikimedia/wikipedia-preview/pull/129

Tue, Jul 20, 10:27 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Wed, Jul 14

hueitan claimed T286654: The Gallery / wp-dark-screen are hidden.
Wed, Jul 14, 3:20 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan moved T286654: The Gallery / wp-dark-screen are hidden from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Possible Solution:
(1) quick fix is to increase z-index;
(2) we can also grab the greatest z-index from the document, stackoverflow

Wed, Jul 14, 3:08 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan updated the task description for T286654: The Gallery / wp-dark-screen are hidden.
Wed, Jul 14, 3:05 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan created T286654: The Gallery / wp-dark-screen are hidden.
Wed, Jul 14, 3:02 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan added a comment to T286583: Plugin will not work if `entry-content` element is not found within DOM.

This is fixed earlier here (commit). Waiting for the release.

Wed, Jul 14, 2:25 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan added a comment to T286583: Plugin will not work if `entry-content` element is not found within DOM.

Currently, there is no such feature in the plugin.

Wed, Jul 14, 7:27 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Tue, Jul 13

hueitan moved T285667: `fr/navigation` broken UI from Code Review to QA on the Inuka-Team (Kanban) board.
Tue, Jul 13, 9:17 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Tue, Jun 29

hueitan moved T269787: Allow zoom in on preview gallery from Code Review to QA on the Inuka-Team (Kanban) board.

This task adds and changes a lot code, do not merge until qa/design confirm the changes.

Tue, Jun 29, 12:40 PM · Inuka-Team (Kanban), Wikipedia-Preview

Mon, Jun 28

hueitan created T285667: `fr/navigation` broken UI.
Mon, Jun 28, 10:39 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Jun 21 2021

hueitan moved T280274: Langlinks endpoint is not returning articles for no.wikipedia.org on KaiOS from Code Review to QA on the Inuka-Team (Kanban) board.
Jun 21 2021, 5:53 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Jun 18 2021

hueitan placed T279547: Gutenburg custom format - form up for grabs.
Jun 18 2021, 9:11 AM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan claimed T279547: Gutenburg custom format - form.
Jun 18 2021, 9:10 AM · Inuka-Team (Kanban), Wikipedia-Preview

Jun 7 2021

hueitan moved T282717: Add Wikipedia Preview "targets" to storybook from Dev to Code Review on the Inuka-Team (Kanban) board.

PR: https://github.com/wikimedia/wikipedia-preview/pull/119
Design ticket move to: T284455: Add image demo in the article page

Jun 7 2021, 2:18 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan created T284455: Add image demo in the article page.
Jun 7 2021, 2:17 PM · Wikipedia-Preview, Inuka-Team
hueitan added a comment to T282717: Add Wikipedia Preview "targets" to storybook.

After several trying with adding custom script, preview-head script and hacky onload event, the result doesn't idea and buggy.

I was wrong about this, the solution is quite simple, checkout here.

Jun 7 2021, 5:24 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Jun 2 2021

hueitan added a comment to T282717: Add Wikipedia Preview "targets" to storybook.

After several trying with adding custom script, preview-head script and hacky onload event, the result doesn't idea and buggy.

Jun 2 2021, 9:14 PM · Wikipedia-Preview, Inuka-Team (Kanban)

May 27 2021

hueitan added a comment to T269041: Optimize list rendering to avoid tiny flash.

Can someone describe the "tiny flash" a little more so we can really observe when it is there and when it is fixed?

May 27 2021, 9:44 AM · KaiOS-Wikipedia-app, Technical-Debt, Inuka-Team
hueitan added a comment to T261796: Optimize the Gallery Slider touch move events.

The google images use transform: translate3d() to perform slider, this is sure better than updating marginLeft/Right

image.png (826×1 px, 407 KB)

May 27 2021, 9:27 AM · Wikipedia-Preview, Inuka-Team
hueitan claimed T282717: Add Wikipedia Preview "targets" to storybook.
May 27 2021, 8:16 AM · Wikipedia-Preview, Inuka-Team (Kanban)

May 26 2021

hueitan moved T279551: Plugin linting and CI from Dev to Code Review on the Inuka-Team (Kanban) board.

PR: https://github.com/wikimedia/wikipediapreview-wordpress/pull/13

May 26 2021, 8:38 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan added a comment to T279551: Plugin linting and CI.

Let's try

May 26 2021, 9:56 AM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan claimed T279551: Plugin linting and CI.
May 26 2021, 9:03 AM · Inuka-Team (Kanban), Wikipedia-Preview

May 25 2021

hueitan closed T283581: Throw Error when navigating back from the Tips "How to search for an article" as Invalid.

My bad, false alarm.

May 25 2021, 11:48 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T283581: Throw Error when navigating back from the Tips "How to search for an article".
May 25 2021, 11:44 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

May 19 2021

hueitan added a comment to T242308: Add article last edit timestamp in "Footer" section.

To dev: code used in MobileFrontend as the example

May 19 2021, 10:41 AM · Inuka-Team, KaiOS-Wikipedia-app

May 18 2021

hueitan created T283081: Use browserslist-config-wikimedia for Wikipedia-Preview.
May 18 2021, 2:49 PM · Wikipedia-Preview, Inuka-Team

May 12 2021

hueitan moved T281299: Fail to load the wikipedia preview in the image case from Dev to Code Review on the Inuka-Team (Kanban) board.

This is now moving to another ticket T282717: Add Wikipedia Preview "targets" to storybook

May 12 2021, 7:50 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan moved T282675: URL double encode issue on wp-preview from Dev to Code Review on the Inuka-Team (Kanban) board.

please double, triple, x4.. check on the different cases.

May 12 2021, 1:58 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan claimed T282675: URL double encode issue on wp-preview.
May 12 2021, 12:21 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T282675: URL double encode issue on wp-preview from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
May 12 2021, 12:04 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T282675: URL double encode issue on wp-preview from Backlog to Kanban on the Inuka-Team board.
May 12 2021, 12:04 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan added a comment to T282675: URL double encode issue on wp-preview.

for example in this line https://github.com/wikimedia/wikipedia-preview/blob/main/src/api.js#L8

May 12 2021, 12:00 PM · Inuka-Team (Kanban), Wikipedia-Preview

May 11 2021

hueitan moved T263598: keyboard shortcuts on gallery from Dev to Code Review on the Inuka-Team (Kanban) board.

PR is here https://github.com/wikimedia/wikipedia-preview/pull/114

May 11 2021, 7:24 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan claimed T263598: keyboard shortcuts on gallery.
May 11 2021, 1:07 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T281510: Serve plugin assets individually (unbundled) from Dev to Code Review on the Inuka-Team (Kanban) board.

[1] Wikipedia Preview PR: https://github.com/wikimedia/wikipedia-preview/pull/113
[2] Wikipedia Preview Wordpress Plugin PR: https://github.com/wikimedia/wikipediapreview-wordpress/pull/7

May 11 2021, 12:13 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan updated the task description for T281510: Serve plugin assets individually (unbundled).
May 11 2021, 12:11 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan placed T282542: Serve CSS assets individually in the <head> up for grabs.
May 11 2021, 12:11 PM · Inuka-Team, Wikipedia-Preview
hueitan created T282542: Serve CSS assets individually in the <head>.
May 11 2021, 12:10 PM · Inuka-Team, Wikipedia-Preview

May 4 2021

hueitan moved T281299: Fail to load the wikipedia preview in the image case from Code Review to Dev on the Inuka-Team (Kanban) board.

Moving back to dev and add demo in the story book.

May 4 2021, 1:05 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan claimed T281510: Serve plugin assets individually (unbundled).
May 4 2021, 1:03 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan added a comment to T281510: Serve plugin assets individually (unbundled).

@hueitan why convert the svg to jpg?

May 4 2021, 12:53 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan added a comment to T280136: Combine search results from prefix and fulltext.

More search content APIs to discover :

May 4 2021, 10:10 AM · Inuka-Team, KaiOS-Wikipedia-app
hueitan added a comment to T281510: Serve plugin assets individually (unbundled).

@SBisson and I had a quick discussion on this ticket previously,

May 4 2021, 8:31 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Apr 30 2021

hueitan edited projects for T281583: Exit Gallery without keeping the preview popup opened in Desktop, added: Inuka-Team; removed Inuka-Team (Kanban).
Apr 30 2021, 3:17 PM · Inuka-Team, Wikipedia-Preview
hueitan updated subscribers of T281583: Exit Gallery without keeping the preview popup opened in Desktop.

@SGautam_WMF @AMuigai Can you confirm the behaviour?

Apr 30 2021, 3:16 PM · Inuka-Team, Wikipedia-Preview
hueitan created T281583: Exit Gallery without keeping the preview popup opened in Desktop.
Apr 30 2021, 3:15 PM · Inuka-Team, Wikipedia-Preview

Apr 29 2021

hueitan added a comment to T281512: Wikipedia Preview english demo doesn't work in IE 11.

Do you know why it's not working? See anything in the console?

Apr 29 2021, 6:14 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan claimed T281512: Wikipedia Preview english demo doesn't work in IE 11.

PR https://github.com/wikimedia/wikipedia-preview/pull/111

Apr 29 2021, 6:13 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan created T281512: Wikipedia Preview english demo doesn't work in IE 11.
Apr 29 2021, 6:07 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan moved T281299: Fail to load the wikipedia preview in the image case from Dev to Code Review on the Inuka-Team (Kanban) board.

PR https://github.com/wikimedia/wikipedia-preview/pull/110

Apr 29 2021, 6:06 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan updated the task description for T281299: Fail to load the wikipedia preview in the image case.
Apr 29 2021, 10:08 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Apr 28 2021

hueitan added a comment to T277497: Error state for KaiOS trending articles feed .

I remember @Jpita saying, when the trending articles is still loading, press enter will see the error but no harm to the user.
is it related?

image.png (208×819 px, 25 KB)

Apr 28 2021, 9:12 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app (Engagement-1)
hueitan claimed T281299: Fail to load the wikipedia preview in the image case.
Apr 28 2021, 8:04 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Apr 27 2021

hueitan added a comment to T267293: Update the article text size in real time when the user using the text size popup..

@Jpita what's the status of this ticket?

Apr 27 2021, 9:14 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T280000: Plugin detect links from Dev to Code Review on the Inuka-Team (Kanban) board.

PR done in https://github.com/wikimedia/wikipediapreview-wordpress/pull/2

Apr 27 2021, 8:20 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan created T281299: Fail to load the wikipedia preview in the image case.
Apr 27 2021, 7:33 PM · Wikipedia-Preview, Inuka-Team (Kanban)
hueitan updated the task description for T281231: Add Wikipedia-KaiOS to doc.wikimedia.org/#apps.
Apr 27 2021, 9:46 AM · KaiOS-Wikipedia-app, Inuka-Team
hueitan updated the task description for T281231: Add Wikipedia-KaiOS to doc.wikimedia.org/#apps.
Apr 27 2021, 9:45 AM · KaiOS-Wikipedia-app, Inuka-Team
hueitan updated the task description for T281231: Add Wikipedia-KaiOS to doc.wikimedia.org/#apps.
Apr 27 2021, 9:45 AM · KaiOS-Wikipedia-app, Inuka-Team
hueitan created T281231: Add Wikipedia-KaiOS to doc.wikimedia.org/#apps.
Apr 27 2021, 9:45 AM · KaiOS-Wikipedia-app, Inuka-Team

Apr 26 2021

hueitan claimed T280000: Plugin detect links.
Apr 26 2021, 6:15 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan placed T278136: LSK or back key close the wrong popup when loading article up for grabs.
Apr 26 2021, 6:15 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan updated the task description for T278136: LSK or back key close the wrong popup when loading article.
Apr 26 2021, 6:14 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan added a comment to T278136: LSK or back key close the wrong popup when loading article.

Moving this ticket back to the Ready for dev, requires more time and effort to develop.

Apr 26 2021, 6:13 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan updated the task description for T278136: LSK or back key close the wrong popup when loading article.
Apr 26 2021, 6:03 PM · Inuka-Team, KaiOS-Wikipedia-app

Apr 22 2021

hueitan updated the task description for T280907: The window.history list doesn't clean up in some cases.
Apr 22 2021, 7:53 AM · KaiOS-Wikipedia-app, Inuka-Team
hueitan created T280907: The window.history list doesn't clean up in some cases.
Apr 22 2021, 7:36 AM · KaiOS-Wikipedia-app, Inuka-Team
hueitan updated the task description for T251517: [SPIKE] Back to the previous location of the article when press back key on article page.
Apr 22 2021, 6:35 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T254401: Automatically publish a new version to npm when the version is updated.

Some useful GitHub Action to consider

Apr 22 2021, 6:27 AM · Inuka-Team, Wikipedia-Preview

Apr 21 2021

hueitan moved T271677: Loading states for KaiOS content discovery experiments. from QA WAITING FOR FEEDBACK to QA on the Inuka-Team (Kanban) board.
Apr 21 2021, 2:29 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app (Engagement-1)
hueitan added a comment to T271677: Loading states for KaiOS content discovery experiments. .

Since this is a very edge case, should I create a new ticket so we don't allow the user to open the trending list while we're still loading the articles?

Apr 21 2021, 2:29 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app (Engagement-1)
hueitan added a comment to T246786: Trigger search only for confirmed characters.

I assume this only apply to the article search page, and not for the language / article language page.

Apr 21 2021, 10:33 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app (Optimize)
hueitan moved T278381: Wikipedia Preview debug mode from QA WAITING FOR FEEDBACK to QA on the Inuka-Team (Kanban) board.

I see 3 wikipedia links found in the console but the article only has 2 links.
Is this expected?
The last link found seems to be in the footer but it is not a preview enabled word.

Apr 21 2021, 9:07 AM · Inuka-Team (Kanban), Wikipedia-Preview

Apr 20 2021

hueitan updated the task description for T278136: LSK or back key close the wrong popup when loading article.
Apr 20 2021, 1:45 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan updated the task description for T278136: LSK or back key close the wrong popup when loading article.
Apr 20 2021, 12:55 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan created T280660: Add app screenshot to the KaiStore.
Apr 20 2021, 12:14 PM · KaiOS-Wikipedia-app, Inuka-Team

Apr 19 2021

hueitan claimed T278136: LSK or back key close the wrong popup when loading article.
Apr 19 2021, 8:52 AM · Inuka-Team, KaiOS-Wikipedia-app

Apr 15 2021

hueitan added a comment to T279523: Plugin skeleton.

had to zip the repo and add new plugin using the admin panel, now I see it

We shouldn't have to do this. I think @hueitan and @eamedina were able to make it work by cloning the repo. Can you confirm?

Apr 15 2021, 7:48 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T278381: Wikipedia Preview debug mode from Dev to Code Review on the Inuka-Team (Kanban) board.

Screenshot Example : (2nd version, may change later)

image.png (241×1 px, 43 KB)

Apr 15 2021, 7:31 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan updated the task description for T278381: Wikipedia Preview debug mode.
Apr 15 2021, 7:17 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan added a comment to T279523: Plugin skeleton.

I clone the repo, and zip the folder, then upload.

Apr 15 2021, 2:46 PM · Inuka-Team (Kanban), Wikipedia-Preview

Apr 13 2021

hueitan updated the task description for T278397: Several calls to the init() function should be additive.
Apr 13 2021, 2:29 AM · Inuka-Team, Wikipedia-Preview

Apr 8 2021

hueitan removed a project from T279658: Plugin Test Spec: Epic.
Apr 8 2021, 2:55 PM · Wikipedia-Preview, Inuka-Team
hueitan created T279658: Plugin Test Spec.
Apr 8 2021, 12:55 PM · Wikipedia-Preview, Inuka-Team

Apr 7 2021

hueitan updated the task description for T278381: Wikipedia Preview debug mode.
Apr 7 2021, 1:34 PM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan claimed T278381: Wikipedia Preview debug mode.
Apr 7 2021, 9:38 AM · Inuka-Team (Kanban), Wikipedia-Preview
hueitan moved T272091: Try migrating from mobile-section to mobile-html from Dev to Code Review on the Inuka-Team (Kanban) board.
Apr 7 2021, 8:45 AM · Inuka-Team (Kanban), Technical-Debt, KaiOS-Wikipedia-app
hueitan added a comment to T272091: Try migrating from mobile-section to mobile-html.

These are the endpoints requested during the article loading (Article Cat as the example)

Apr 7 2021, 8:23 AM · Inuka-Team (Kanban), Technical-Debt, KaiOS-Wikipedia-app

Mar 29 2021

hueitan moved T267293: Update the article text size in real time when the user using the text size popup. from Dev to Code Review on the Inuka-Team (Kanban) board.

The another fix covers in PR https://github.com/wikimedia/wikipedia-kaios/pull/362

Mar 29 2021, 9:56 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Mar 27 2021

hueitan updated the task description for T278127: Support Interlanguage links.
Mar 27 2021, 7:41 PM · KaiOS-Wikipedia-app, Inuka-Team

Mar 26 2021

hueitan moved T272091: Try migrating from mobile-section to mobile-html from Code Review to Dev on the Inuka-Team (Kanban) board.

After discussion with @SBisson , there are few more steps to try

Mar 26 2021, 9:50 AM · Inuka-Team (Kanban), Technical-Debt, KaiOS-Wikipedia-app

Mar 24 2021

hueitan created T278349: open the sharemap case as the external link.
Mar 24 2021, 4:04 PM · KaiOS-Wikipedia-app, Inuka-Team

Mar 23 2021

hueitan claimed T267293: Update the article text size in real time when the user using the text size popup..
Mar 23 2021, 8:58 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T272091: Try migrating from mobile-section to mobile-html.

This spike has been done, to answer the question (✔️better;⭕ no better or difference),

Mar 23 2021, 8:51 PM · Inuka-Team (Kanban), Technical-Debt, KaiOS-Wikipedia-app
hueitan moved T267293: Update the article text size in real time when the user using the text size popup. from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

I'm ready to take this challenge ;-)

Mar 23 2021, 8:39 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T272091: Try migrating from mobile-section to mobile-html from Dev to Code Review on the Inuka-Team (Kanban) board.

PR https://github.com/wikimedia/wikipedia-kaios/pull/334

Mar 23 2021, 9:14 AM · Inuka-Team (Kanban), Technical-Debt, KaiOS-Wikipedia-app

Mar 22 2021

hueitan created T278136: LSK or back key close the wrong popup when loading article.
Mar 22 2021, 3:37 PM · Inuka-Team, KaiOS-Wikipedia-app
hueitan created T278127: Support Interlanguage links.
Mar 22 2021, 1:57 PM · KaiOS-Wikipedia-app, Inuka-Team
hueitan created T278122: Back key doesn't work properly in the Simulator.
Mar 22 2021, 1:01 PM · KaiOS-Wikipedia-app, Inuka-Team