update version of banana-i18n to 2.0.0, same pr.

I HAVE IE11 on my local env =)

PR : https://github.com/wikimedia/wikipedia-preview/pull/80

I don't see any more details in this error, therefore moving back to Ready for dev

i believe what you fixed before in isSupportedForReading also fix this

after several pressing on the arrow, i got this

this error comes from the preact, will look into more details

Moving this back as it requires more testing after the banana-i18n update with the bug fixed.

After several searching [1] Linkedin Profile Page, [2] Google Image Search Result [3] Mobile Wikipedia Web Page, these 3 use the similar technic to update history state + hash, press back/forward key and refresh will get the result whenever user in before;

the error trace ends in getAppLanguage()

I can't reproduce the error, but this upgrade may avoid this error in the future.

getCategories comes from the library intl-pluralrules, and we use the version of 1.2.1 from banana, and version 1.3.0 already replace it with the native Intl

Another example was given here in Google Image Search Result, it uses the history state + hash, press back/forward key to see result, as well as refresh.

In T262074#6527440, @Jpita wrote:

waiting for a comment reply on github

In T258014#6525301, @SBisson wrote:

Any solution that uses the URL or the history API has a high potential of conflicting with routing on the host website. Maybe a pushState with everything identical except for some metadata could work

Could someone found some live example for this? what I notice most of the site it modify the URL path [1], so when the user refreshes the page, the popup content remains until press close or back key.

Technical details :

PR : https://github.com/wikimedia/wikipedia-preview/pull/78

In T262074#6474427, @AMuigai wrote:

After research, let's use this order to determine what content to show for image descriptions:

1. Commons captions
2. If that is not available; show the description from Commoons
3. If that is not available; show the description from media-list

fyi, this is what in facebook app

Current status :

This Design Style Guide shows the font-family style, do you mean like we apply this to the entire Wikipedia Preview?

This is what I got after having the new layout and update the gradient position (Windows, Chrome, Mobile Simulator)

New PR : https://github.com/wikimedia/wikipedia-preview/pull/68

PR : https://github.com/wikimedia/wikipedia-preview/pull/68

PR is here https://github.com/wikimedia/wikipedia-preview/pull/66 (Discard the PR)

I have checked on this, the reason is that there are font-family settings in the preview code (not all) T260407: Use device default font for Wikipedia preview

A follow up PR is here https://github.com/wikimedia/wikipedia-preview/pull/65 for the feedback

PR https://github.com/wikimedia/wikipedia-kaios/pull/276

can you see if you can find when it started (commit/PR)?

@Jpita Probably here's the best place for you to add the reference preview popup test.

In T257648#6464580, @Jpita wrote:

it seems to still be broken in IE11 (1280x800)

@Jpita btw, nice finding this hidden bug we miss somewhere

In T262602#6468465, @Jpita wrote:

This branch broke the ability to open references and it wasn't supposed to touch any such thing apart from the history.
Can we investigate what happened and check if this was a directly related issue or a "let me fix this while I'm here" issue?

This is how the others show the mic icon

1. Take advantage of iiurlwidth and iiurlheight props to make each fullscreen image as light as possible while still looking good (non-pixelated) on device
2. Include white background for transparent images (from T260228)

@SGautam_WMF let me know what's in your thoughts.

Should this happen here or on a new ticket?

Merged.

possible due to the reason of only 1 rtl language in the article, see T254969: Don't show the article language action/menu item when there is only one rtl language

PR Merged. https://github.com/wikimedia/wikipedia-preview/pull/58

The above question is non-related to the original requirement, may extend the solution but the design still need more time to think about, so please ignore it for now.

In T240007#6441333, @Jpita wrote:

There is one thing we need to check or find out while coding, can we activate vertical scrolling inside preview while web page also has a browser's default vertical scroll active?

Well, we don't get this bug once we have this T261745: Gallery optimization: image best fit, it fetches the file url.

Here's another fail test case : https://en.wikipedia.org/wiki/ȏ

In general, this task splits into several steps

New PR is opened here : https://github.com/wikimedia/wikipedia-preview/pull/53