Page MenuHomePhabricator

hueitan (Huei Tan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2019, 11:41 AM (9 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
HTan (WMF) [ Global Accounts ]

Recent Activity

Wed, Jan 22

hueitan added a comment to T236302: Image view and gallery.

Regarding the article view,

Wed, Jan 22, 7:14 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T236302: Image view and gallery.
Wed, Jan 22, 2:47 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T236302: Image view and gallery from Ready to Dev on the Inuka-Team (Kanban) board.
Wed, Jan 22, 2:46 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T241364: Missing "goto" Section in article links pagination from Dev to Ready on the Inuka-Team (Kanban) board.
Wed, Jan 22, 2:46 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan triaged T241364: Missing "goto" Section in article links pagination as Low priority.

I put this under Low Priority.

Wed, Jan 22, 2:46 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Tue, Jan 21

hueitan moved T242342: Support interwiki links from Backlog to Kanban on the Inuka-Team board.
Tue, Jan 21, 12:59 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Mon, Jan 20

hueitan added a comment to T242350: Empty state for Search and Article Change language page.

I have tried on mobile web page, when we load https://en.m.wikipedia.org/wiki/Hodh_Ech_Chargui, it will redirect to https://en.m.wikipedia.org/wiki/Hodh_Ech_Chargui_Region, so the above problem won't be existed, maybe we can do the same here. will try and see

Mon, Jan 20, 12:18 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Fri, Jan 17

hueitan moved T242082: Article Preview Adjustment from Dev to Code Review on the Inuka-Team (Kanban) board.
Fri, Jan 17, 5:17 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Wed, Jan 15

hueitan moved T242082: Article Preview Adjustment from Code Review to Dev on the Inuka-Team (Kanban) board.
Wed, Jan 15, 2:35 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan merged task T242308: Add "Edit History" in Footer Section into T236301: Article footer and read more.
Wed, Jan 15, 2:33 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan merged task T242403: Article Footer - Suggested Article Section & Legal Section into T236301: Article footer and read more.
Wed, Jan 15, 2:33 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan merged tasks T242403: Article Footer - Suggested Article Section & Legal Section, T242308: Add "Edit History" in Footer Section into T236301: Article footer and read more.
Wed, Jan 15, 2:33 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T236301: Article footer and read more from Code Review to Dev on the Inuka-Team (Kanban) board.
Wed, Jan 15, 2:32 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Tue, Jan 14

hueitan added a comment to T242082: Article Preview Adjustment.

Pull Request : https://github.com/wikimedia/wikipedia-kaios/pull/85

Tue, Jan 14, 6:25 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T242082: Article Preview Adjustment.

true, using summary api can reduce the size fetching the preview message, which is a really good news

Tue, Jan 14, 6:18 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan reopened T236301: Article footer and read more as "Open".
Tue, Jan 14, 5:30 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan merged task T236301: Article footer and read more into T242403: Article Footer - Suggested Article Section & Legal Section.
Tue, Jan 14, 5:08 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan merged T236301: Article footer and read more into T242403: Article Footer - Suggested Article Section & Legal Section.
Tue, Jan 14, 5:08 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T240888: Better article loading experience.

is this going to be fixed on this task or another one?

Tue, Jan 14, 12:18 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T242350: Empty state for Search and Article Change language page.

To summarize this task, we need to show the empty state (No results found message) when searching the item in the following pages

Tue, Jan 14, 12:13 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Mon, Jan 13

hueitan moved T234622: Article text size from Dev to Code Review on the Inuka-Team (Kanban) board.
Mon, Jan 13, 10:06 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T236304: Onboarding from Dev to Code Review on the Inuka-Team (Kanban) board.
Mon, Jan 13, 3:39 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T241054: Create "No results found" error when Search returns no results from Backlog to Code Review on the Inuka-Team (Kanban) board.

This is developed in T242350: Empty state for Search and Article Change language page

Mon, Jan 13, 12:44 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T236304: Onboarding.
Mon, Jan 13, 4:20 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T242342: Support interwiki links.

@cmadeo I just checked on iOS, it opens as the external links in the device browser, same to the Wiktionary/Wikispecies/Wikimedia Commons link

Mon, Jan 13, 1:00 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T241364: Missing "goto" Section in article links pagination.

I find difficulty to get the preview message of the section, the paragraph next to the title can be random

Mon, Jan 13, 12:24 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T236301: Article footer and read more.

The current design looks "Suggested Articles" and "Legal Section" are in the same section, but in the cases the article doesn't have suggested articles, then the "Suggested Articles" shoudn't be shown in ToC, therefore no "Legal Section"

Mon, Jan 13, 12:03 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Sun, Jan 12

hueitan moved T242350: Empty state for Search and Article Change language page from Dev to Code Review on the Inuka-Team (Kanban) board.
Sun, Jan 12, 9:59 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T242553: Support article redirects.
Sun, Jan 12, 9:59 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T242350: Empty state for Search and Article Change language page.
Sun, Jan 12, 3:02 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T234628: Select language to read an article from Dev to QA on the Inuka-Team (Kanban) board.
Sun, Jan 12, 2:15 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T242350: Empty state for Search and Article Change language page.

I have tried on mobile web page, when we load https://en.m.wikipedia.org/wiki/Hodh_Ech_Chargui, it will redirect to https://en.m.wikipedia.org/wiki/Hodh_Ech_Chargui_Region, so the above problem won't be existed, maybe we can do the same here. will try and see

Sun, Jan 12, 1:18 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T242350: Empty state for Search and Article Change language page.

I think we still need the No result found page in article language page

Sun, Jan 12, 1:15 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Sat, Jan 11

hueitan added a comment to T242403: Article Footer - Suggested Article Section & Legal Section.

@cmadeo maybe we don't need this loading design, we will need to prefetch the suggested articles

Sat, Jan 11, 1:16 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T240888: Better article loading experience.

@hueitan when the phone doesn't have an internet connection and we try to go to a new article, the gif shows and doesn't disappear.
Although this is not entirely bad, maybe in this case we should put a different message?

Could we use the 'unable to load article' screen if there is no internet connection: https://phabricator.wikimedia.org/T236897

Sat, Jan 11, 12:59 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Fri, Jan 10

hueitan added a comment to T234622: Article text size.

the current setting 0~6, the actual font size in the range 14px~20px

Fri, Jan 10, 3:18 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T242350: Empty state for Search and Article Change language page.

Note that the article API output contains languagecount to indicate in how many other languages the article is available. When this is 0, we could hide or disable the article language menu option so we don't have to deal with an empty state on that screen.

Fri, Jan 10, 1:50 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T242429: Article - Empty content in <a> element.
Fri, Jan 10, 1:42 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T242403: Article Footer - Suggested Article Section & Legal Section.
Fri, Jan 10, 3:09 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T236301: Article footer and read more.

I'm fine with the external mobile link (e.g. https://en.m.wikipedia.org/wiki/Special:History/Feral_cat)

Fri, Jan 10, 12:50 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan updated the task description for T242308: Add "Edit History" in Footer Section.
Fri, Jan 10, 12:48 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Thu, Jan 9

hueitan moved T240952: encode search key when opening preview from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jan 9, 5:41 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan updated the task description for T242350: Empty state for Search and Article Change language page.
Thu, Jan 9, 5:37 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan updated the task description for T242350: Empty state for Search and Article Change language page.
Thu, Jan 9, 5:36 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T234628: Select language to read an article.

When an article doesn't exist in any other language (en/Line of succession to the British throne) there an error in the console and the language list is empty. Not sure what should happen, maybe a message.

Thu, Jan 9, 5:01 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan created T242350: Empty state for Search and Article Change language page.
Thu, Jan 9, 4:59 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T236301: Article footer and read more from Dev to Code Review on the Inuka-Team (Kanban) board.
Thu, Jan 9, 2:48 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a subtask for T236301: Article footer and read more: T242308: Add "Edit History" in Footer Section.
Thu, Jan 9, 2:47 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a parent task for T242308: Add "Edit History" in Footer Section: T236301: Article footer and read more.
Thu, Jan 9, 2:47 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T242308: Add "Edit History" in Footer Section.
Thu, Jan 9, 2:46 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T236301: Article footer and read more.

ping @cmadeo require the design change for the information of Edit history

Thu, Jan 9, 2:45 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Wed, Jan 8

hueitan added a comment to T236301: Article footer and read more.

@hueitan That's okay, if they switch their app language this will update though, correct?

Wed, Jan 8, 7:30 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T234622: Article text size from Code Review to Dev on the Inuka-Team (Kanban) board.
Wed, Jan 8, 7:11 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T241423: Go to Previous Article from Article Menu page from Dev to Code Review on the Inuka-Team (Kanban) board.
Wed, Jan 8, 6:10 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T240952: encode search key when opening preview from Dev to Ready on the Inuka-Team (Kanban) board.
Wed, Jan 8, 5:41 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T236301: Article footer and read more.

@SBisson let's call it 'Suggested articles' and not have a TOC entry for the legal footer.

Wed, Jan 8, 7:31 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan updated the task description for T242192: Error when loading article - History of Russia (1721-96).
Wed, Jan 8, 7:29 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan updated the task description for T242192: Error when loading article - History of Russia (1721-96).
Wed, Jan 8, 7:29 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T242192: Error when loading article - History of Russia (1721-96).
Wed, Jan 8, 7:26 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Tue, Jan 7

hueitan moved T241364: Missing "goto" Section in article links pagination from QA to Dev on the Inuka-Team (Kanban) board.

Moving as it requires more development

Tue, Jan 7, 9:43 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T241423: Go to Previous Article from Article Menu page from QA to Dev on the Inuka-Team (Kanban) board.

Moving back for the development for the description.

Tue, Jan 7, 9:41 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T242082: Article Preview Adjustment.
Tue, Jan 7, 9:37 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Mon, Jan 6

hueitan moved T236301: Article footer and read more from Code Review to Dev on the Inuka-Team (Kanban) board.
Mon, Jan 6, 12:48 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T240888: Better article loading experience from Dev to Code Review on the Inuka-Team (Kanban) board.
Mon, Jan 6, 10:34 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T240888: Better article loading experience.

no worry, I got it from iOS repo =)

Mon, Jan 6, 9:40 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Sun, Jan 5

hueitan added a comment to T240888: Better article loading experience.

@cmadeo can you provide either one?

Sun, Jan 5, 11:31 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Fri, Jan 3

hueitan claimed T240888: Better article loading experience.
Fri, Jan 3, 10:14 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan updated subscribers of T241423: Go to Previous Article from Article Menu page.

I'm suggesting adding the previous article title as the description in the menu list, does it helpful? @cmadeo @AMuigai

Fri, Jan 3, 9:10 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Thu, Jan 2

hueitan reopened T240790: Responsive Styling as "Open".
Thu, Jan 2, 5:04 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan closed T240790: Responsive Styling as Resolved.

This offset belongs to the problem of article styling elements https://phabricator.wikimedia.org/T236322,
this task is to make sure all the features work in different size and doesn't have screen offset of all the window styling.

Thu, Jan 2, 5:04 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T236301: Article footer and read more from Dev to Code Review on the Inuka-Team (Kanban) board.
Thu, Jan 2, 5:00 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan renamed T241720: Video not showing on device from Image not showing on device to Video not showing on device.
Thu, Jan 2, 2:39 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T241720: Video not showing on device.

just check, and that is a video, and we didn't handle video in the code.

Thu, Jan 2, 11:24 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T241364: Missing "goto" Section in article links pagination from QA to Code Review on the Inuka-Team (Kanban) board.
Thu, Jan 2, 9:44 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T241423: Go to Previous Article from Article Menu page from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jan 2, 9:44 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T241364: Missing "goto" Section in article links pagination from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jan 2, 9:44 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Tue, Dec 31

hueitan added a comment to T240952: encode search key when opening preview.

yet another cases when the title has :

Tue, Dec 31, 3:34 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T240952: encode search key when opening preview.

similar here if you seach for the key

Tue, Dec 31, 3:20 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T240992: sections menu doesn't take into account section I'm currently reading from Dev to Code Review on the Inuka-Team (Kanban) board.

I think you are testing master branch code, the code is still on reviewed with branch https://github.com/hueitan/wikipedia-kaios/tree/toc-selected

Tue, Dec 31, 12:41 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Mon, Dec 30

hueitan moved T241364: Missing "goto" Section in article links pagination from Backlog to Code Review on the Inuka-Team (Kanban) board.
Mon, Dec 30, 9:01 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan claimed T241364: Missing "goto" Section in article links pagination.

Popup a confirm dialog to ask user whether go to the selected section

Mon, Dec 30, 9:00 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a comment to T236301: Article footer and read more.

@cmadeo what's the styling when the user hovers item in the suggested article?

Mon, Dec 30, 11:32 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Sat, Dec 28

hueitan moved T234622: Article text size from Dev to Code Review on the Inuka-Team (Kanban) board.
Sat, Dec 28, 7:42 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Fri, Dec 27

hueitan moved T234622: Article text size from Ready to Dev on the Inuka-Team (Kanban) board.
Fri, Dec 27, 9:07 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T234622: Article text size.
Fri, Dec 27, 9:06 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T234622: Article text size.

Note : Controlling the font-size-adjust and line-height to achieve text size adjustment

Fri, Dec 27, 3:19 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T236301: Article footer and read more.

API GET example for Read more

Fri, Dec 27, 1:08 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T236301: Article footer and read more.
Fri, Dec 27, 1:02 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T236301: Article footer and read more from Ready to Dev on the Inuka-Team (Kanban) board.
Fri, Dec 27, 1:02 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 24 2019

hueitan added a parent task for T241423: Go to Previous Article from Article Menu page: T236266: Article page menu.
Dec 24 2019, 4:52 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan added a subtask for T236266: Article page menu: T241423: Go to Previous Article from Article Menu page.
Dec 24 2019, 4:52 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T241423: Go to Previous Article from Article Menu page.
Dec 24 2019, 4:50 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan created T241423: Go to Previous Article from Article Menu page.
Dec 24 2019, 4:50 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
hueitan moved T240992: sections menu doesn't take into account section I'm currently reading from Ready to Code Review on the Inuka-Team (Kanban) board.
Dec 24 2019, 11:49 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan claimed T240992: sections menu doesn't take into account section I'm currently reading.
Dec 24 2019, 11:49 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 23 2019

hueitan claimed T241159: The "Sections" view is broken when there are no sections.

Currently, the "Sections" view always has the lead section as the first item, therefore this is fixed.

Dec 23 2019, 10:46 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T241159: The "Sections" view is broken when there are no sections from Backlog to QA on the Inuka-Team (Kanban) board.
Dec 23 2019, 10:45 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T241159: The "Sections" view is broken when there are no sections from Backlog to Kanban on the Inuka-Team board.
Dec 23 2019, 10:45 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan moved T234628: Select language to read an article from Dev to Code Review on the Inuka-Team (Kanban) board.
Dec 23 2019, 10:06 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
hueitan added a comment to T234628: Select language to read an article.

In Change language (article) section, follow the same pattern as iOS Wikipedia Apps, we show only the Other Languages due to the current API limitation without returning the current language

Dec 23 2019, 2:56 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app