Page MenuHomePhabricator

ihurbain (Isabelle Hurbain-Palatin)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 7 2021, 8:12 AM (56 w, 3 d)
Availability
Available
LDAP User
Isabelle Hurbain-Palatin
MediaWiki User
Unknown

Recent Activity

Tue, Jul 5

ihurbain moved T272942: Make Graph extension compatible with Parsoid from Code Review to To Deploy on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Jul 5, 2:08 PM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Graph, Parsoid-Rendering, Parsoid

Tue, Jun 21

ihurbain moved T186241: Add rel="nofollow" to Parsoid links from In Progress to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Tue, Jun 21, 10:27 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Mon, Jun 13

ihurbain moved T186241: Add rel="nofollow" to Parsoid links from Code Review to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Mon, Jun 13, 3:05 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Thu, Jun 9

ihurbain moved T186241: Add rel="nofollow" to Parsoid links from In Progress to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Thu, Jun 9, 1:34 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ihurbain moved T296392: Old syntax tvar breaks templates from To Deploy to To Verify on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Thu, Jun 9, 1:34 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ihurbain moved T296392: Old syntax tvar breaks templates from In Progress to To Deploy on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
Thu, Jun 9, 1:34 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

May 31 2022

ihurbain moved T186241: Add rel="nofollow" to Parsoid links from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 31 2022, 2:23 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ihurbain claimed T186241: Add rel="nofollow" to Parsoid links.
May 31 2022, 9:49 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

May 30 2022

ihurbain moved T309024: Make Parsoid's red link output compatible with current output from Backlog to In Progress on the Parsoid-Read-Views (Phase 2 - testwiki Main namespace support) board.
May 30 2022, 3:31 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
ihurbain claimed T309024: Make Parsoid's red link output compatible with current output.
May 30 2022, 3:31 PM · Patch-For-Review, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid

May 24 2022

ihurbain moved T296408: Rendering difference between legacy and Parsoid with newlines after styling and <translate> tags from In Progress to Blocked on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 24 2022, 3:08 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Translate, Parsoid
ihurbain moved T296392: Old syntax tvar breaks templates from Blocked to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 24 2022, 3:08 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ihurbain moved T296408: Rendering difference between legacy and Parsoid with newlines after styling and <translate> tags from Blocked to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 24 2022, 1:36 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Translate, Parsoid
ihurbain moved T272942: Make Graph extension compatible with Parsoid from In Progress to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 24 2022, 12:44 PM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Graph, Parsoid-Rendering, Parsoid

May 16 2022

ihurbain moved T272942: Make Graph extension compatible with Parsoid from Talk Page Read Views to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 16 2022, 3:13 PM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Graph, Parsoid-Rendering, Parsoid
ihurbain added a comment to T272943: Make InputBox extension compatible with Parsoid.
  • getOptions()->getUserLangObj

Explicitly unsupported. Again, see the references above, this is probably a bug and either the "interface" or "page"/"content" language is what is wanted here. See T267059: Spec for precisely positioned, localized error message in Parsoid for a discussion of the {{int}} aspect; basically we'd be calling WTUtils::createLocalizationFragment here, although it wouldn't be surprising if various parts of that are not implemented yet.

May 16 2022, 9:12 AM · Parsoid-Read-Views, Patch-For-Review, MediaWiki-extensions-InputBox, Parsoid-Rendering, Parsoid

May 11 2022

ihurbain moved T296392: Old syntax tvar breaks templates from Mostly edge cases to Blocked on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 11 2022, 1:42 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ihurbain moved T296408: Rendering difference between legacy and Parsoid with newlines after styling and <translate> tags from Mostly edge cases to Blocked on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
May 11 2022, 1:42 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), MediaWiki-extensions-Translate, Parsoid

May 9 2022

ihurbain created T307908: Improve the message for mw:ExtendedAnnRange type nodes.
May 9 2022, 12:34 PM · VisualEditor
ihurbain added a comment to T307875: Visual diff does not load: TypeError: Cannot read properties of undefined (reading 'forEach').

@DLynch you're probably not over-indexing because we definitely touched things around aliennodes with the annotations/translate, so that may indeed well be related indeed.

May 9 2022, 8:19 AM · Verified, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing-team (FY2021-22 Kanban Board), VisualEditor
ihurbain added a comment to T307412: Link-in-link wikitext error resulted in duplicated content in a reply tool edit.

A-ha - that explains things, possibly, probably - thanks for the heads-up!

May 9 2022, 8:11 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, DiscussionTools, Parsoid

May 3 2022

ihurbain placed T302678: PHP Notice: Trying to get property 't' of non-object (LanguageVariantHandler) up for grabs.
May 3 2022, 3:24 PM · Parsoid, Wikimedia-production-error

Apr 25 2022

ihurbain closed T297770: Extended annotation ranges sometimes duplicate the closing tag when round-tripping with edits, a subtask of T261181: Make Translate extension compatible with Parsoid, as Resolved.
Apr 25 2022, 7:52 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Language-Team (Language-2021-October-December), Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsing-Active-Work, Patch-For-Review, Parsoid, Technical-Debt, Editing-Team-Request, MediaWiki-extensions-Translate
ihurbain closed T297770: Extended annotation ranges sometimes duplicate the closing tag when round-tripping with edits as Resolved.

Resolved by making that situation not happen anymore via https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/769071.

Apr 25 2022, 7:52 AM · Parsoid, MediaWiki-extensions-Translate

Apr 14 2022

ihurbain added a comment to T306186: TypeError: Argument 1 passed to DOMNode::appendChild() must be an instance of DOMNode, null given.

I have two patches that should fix the issue - but I don't know which one we want to deploy.

Apr 14 2022, 3:56 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Parsoid, Wikimedia-production-error
ihurbain added a comment to T306186: TypeError: Argument 1 passed to DOMNode::appendChild() must be an instance of DOMNode, null given.

Yeah, the ->nextSibling goes to null, and in the next loop iteration crashes violently.

Apr 14 2022, 3:26 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Parsoid, Wikimedia-production-error
ihurbain updated subscribers of T306186: TypeError: Argument 1 passed to DOMNode::appendChild() must be an instance of DOMNode, null given.

It's an issue that seems limited to a small subset of translatable pages - and it may only trigger on wikis where the Translate extension is running, which I believe would all be group0/group1. Also note that VE is not officially supported yet for editing these pages (although this was supposed to be the version that would make it so, basically :( ) - so this reduces the impact of Parsoid crashes.
From my point of view, this is not a train blocker due to limited impact, but I don't feel comfortable making that call definitely. @ssastry, @cscott, @Arlolra - opinions?

Apr 14 2022, 3:08 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Parsoid, Wikimedia-production-error

Apr 12 2022

ihurbain claimed T305931: TimedMediaHandler causes a failure in GrowthExperiments build.
Apr 12 2022, 1:42 PM · MediaWiki-extensions-Translate, Content-Transform-Team, Parsoid, Growth-Team, GrowthExperiments, TimedMediaHandler, ci-test-error

Mar 30 2022

ihurbain added a project to T305066: Make extended annotation ranges uneditable: MW-1.38-release.
Mar 30 2022, 1:58 PM · MW-1.38-release, Parsoid
ihurbain added a parent task for T303298: mw:Placeholder elements are editable in VE: T305066: Make extended annotation ranges uneditable.
Mar 30 2022, 1:58 PM · Skipped QA, MW-1.38-release, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Editing-team (FY2021-22 Kanban Board), VisualEditor
ihurbain added a subtask for T305066: Make extended annotation ranges uneditable: T303298: mw:Placeholder elements are editable in VE.
Mar 30 2022, 1:57 PM · MW-1.38-release, Parsoid
ihurbain added a subtask for T261181: Make Translate extension compatible with Parsoid: T305066: Make extended annotation ranges uneditable.
Mar 30 2022, 1:57 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Language-Team (Language-2021-October-December), Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsing-Active-Work, Patch-For-Review, Parsoid, Technical-Debt, Editing-Team-Request, MediaWiki-extensions-Translate
ihurbain added a parent task for T305066: Make extended annotation ranges uneditable: T261181: Make Translate extension compatible with Parsoid.
Mar 30 2022, 1:56 PM · MW-1.38-release, Parsoid
ihurbain created T305066: Make extended annotation ranges uneditable.
Mar 30 2022, 1:56 PM · MW-1.38-release, Parsoid
ihurbain added a comment to T303298: mw:Placeholder elements are editable in VE.

@matmarex thanks a lot!!

Mar 30 2022, 12:08 PM · Skipped QA, MW-1.38-release, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Editing-team (FY2021-22 Kanban Board), VisualEditor

Mar 29 2022

ihurbain added a comment to T303298: mw:Placeholder elements are editable in VE.

Hi @matmarex - quick question: is the above-merged patch a partial/complete solution to this issue? I created a patchdemo with that patch and mine - https://patchdemo.wmflabs.org/wikis/e26b32870e/wiki/Test - and I was expecting the first two elements of the list to be uneditable (because they're enclosed in a mw:Placeholder <div>) - am I missing something, or is this to be expected? Thanks!!

Mar 29 2022, 12:21 PM · Skipped QA, MW-1.38-release, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Editing-team (FY2021-22 Kanban Board), VisualEditor

Mar 21 2022

ihurbain added a comment to T303627: Translation unit markers interferes with comment markup in Parsoid rendering.

One use case I can see that would not work with <translate><!--hello--></translate> is commenting out a large part of a translatable page (where markers have already been added). I have no idea how common that would be, but I could see it happening - and at the same time, not wanting to lose the existing translated content just because it got commented out. It's also worth mentioning that the <translate> themselves are not the issue, but the TU markers (<!-- T3 -->). If there's a large area comprising several translation units, and that only some of that area (including a marker) get commented out, we're having a mess again - because in that case Parsoid will display whatever is after the TU marker, whereas the legacy parser would not.

Mar 21 2022, 1:51 PM · Parsoid, Parsoid-Read-Views, MediaWiki-extensions-Translate

Mar 15 2022

matmarex awarded T303298: mw:Placeholder elements are editable in VE a Like token.
Mar 15 2022, 8:54 PM · Skipped QA, MW-1.38-release, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Editing-team (FY2021-22 Kanban Board), VisualEditor

Mar 11 2022

ihurbain renamed T303627: Translation unit markers interferes with comment markup in Parsoid rendering from Translation unit markers interferes with comments markup in Parsoid rendering to Translation unit markers interferes with comment markup in Parsoid rendering.
Mar 11 2022, 5:01 PM · Parsoid, Parsoid-Read-Views, MediaWiki-extensions-Translate
ihurbain renamed T303627: Translation unit markers interferes with comment markup in Parsoid rendering from Translation unit markers interact with comments markup in Parsoid rendering to Translation unit markers interferes with comments markup in Parsoid rendering.
Mar 11 2022, 5:00 PM · Parsoid, Parsoid-Read-Views, MediaWiki-extensions-Translate
ihurbain created T303627: Translation unit markers interferes with comment markup in Parsoid rendering.
Mar 11 2022, 4:58 PM · Parsoid, Parsoid-Read-Views, MediaWiki-extensions-Translate
ihurbain reassigned T295170: Move Parsoid's Translate implementation into the Translate extension repo from ihurbain to ssastry.

Sending this one Subbu's way - the only thing missing there is running Parsoid tests on Translate, and I believe you were working on that.

Mar 11 2022, 11:25 AM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-extensions-Translate, Parsoid

Mar 10 2022

ihurbain closed T296412: Rendering difference between legacy and Parsoid with <translate> tags around a heading, a subtask of T261181: Make Translate extension compatible with Parsoid, as Resolved.
Mar 10 2022, 8:59 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Language-Team (Language-2021-October-December), Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsing-Active-Work, Patch-For-Review, Parsoid, Technical-Debt, Editing-Team-Request, MediaWiki-extensions-Translate
ihurbain closed T296412: Rendering difference between legacy and Parsoid with <translate> tags around a heading as Resolved.
Mar 10 2022, 8:59 AM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Mar 9 2022

ihurbain claimed T303423: Linter for badly nested Translate ranges.
Mar 9 2022, 5:39 PM · MediaWiki-extensions-Translate, Parsoid
ihurbain created T303423: Linter for badly nested Translate ranges.
Mar 9 2022, 5:39 PM · MediaWiki-extensions-Translate, Parsoid
ihurbain claimed T303409: Linter for "references in links".
Mar 9 2022, 5:16 PM · MediaWiki-extensions-Linter, Cite, Parsoid
ihurbain updated the task description for T303409: Linter for "references in links".
Mar 9 2022, 5:03 PM · MediaWiki-extensions-Linter, Cite, Parsoid
ihurbain added projects to T303409: Linter for "references in links": Parsoid, Cite, MediaWiki-extensions-Linter.
Mar 9 2022, 5:01 PM · MediaWiki-extensions-Linter, Cite, Parsoid
ihurbain created T303409: Linter for "references in links".
Mar 9 2022, 5:00 PM · MediaWiki-extensions-Linter, Cite, Parsoid

Mar 8 2022

ihurbain created T303298: mw:Placeholder elements are editable in VE.
Mar 8 2022, 5:13 PM · Skipped QA, MW-1.38-release, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Editing-team (FY2021-22 Kanban Board), VisualEditor

Mar 7 2022

ihurbain added a comment to T302964: ParserIntegrationTest::testParse with data set "parserTests.txt: Media link with nested wikilinks" ('legacy parser').

@cscott quoting you from Slack a few months ago: "as mentioned above we also have a little bit of magic that says when parsoid is loaded "as an extension" in CI then we also use the latest Parsoid source (by playing autoloader games), instead of just pulling the Parsoid composer package from mediawiki-vendor. So 'parsoid as a dependency' also means 'use the latest parsoid, not the mediawiki-vendor parsoid'. But that's only relevant for extensions which include parsoid-specific support, which is only Disambiguator right now (Cite and Translate are coming soon, though)". This is the case that we have here: Growth-Experiments has an explicit dependency on Parsoid in the CI: see https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/refs/heads/master/zuul/parameter_functions.py#348 - that's since December: https://phabricator.wikimedia.org/rCICF91612b8841a17903726eec9b9d27bd4d1fcd4f3c. Whether that's actually necessary for that purpose or whether there's a way around that, I'm not enough of a Selenium user to say :)

Mar 7 2022, 4:55 PM · ci-test-error (WMF-deployed Build Failure), Growth-Team (Current Sprint), GrowthExperiments, MediaWiki-Parser

Mar 4 2022

ihurbain updated the task description for T303057: Error: Call to a member function getName() on string.
Mar 4 2022, 3:38 PM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Parsoid, Wikimedia-production-error
ihurbain changed Request URL from http//meta.wikimedia.org/w/rest.php/meta.wikimedia.org/v3/transform/wikitext/to/pagebundle/Learning_and_Evaluation%2FArchive%2FLearning_modules%2F2Formative_Process to https://meta.wikimedia.org/w/rest.php/meta.wikimedia.org/v3/transform/wikitext/to/pagebundle/Learning_and_Evaluation%2FArchive%2FLearning_modules%2F2Formative_Process on T303057: Error: Call to a member function getName() on string.
Mar 4 2022, 3:36 PM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Parsoid, Wikimedia-production-error
ihurbain created T303057: Error: Call to a member function getName() on string.
Mar 4 2022, 3:30 PM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Parsoid, Wikimedia-production-error
ihurbain added a comment to T301293: Failed invariant in Linter.

It turns out that the <sup> tag containing the [1] is itself in a link - which is probably the initial source of the issue.

Mar 4 2022, 1:45 PM · Parsoid, Wikimedia-production-error
ihurbain added a comment to T301293: Failed invariant in Linter.

Current understanding of the issue:

  • The issue is introduced during the fixups phase. Pre-fix-up, the [1] is contained in a <a> tag in a <sup> tag; post-fixup that link is extracted from the <sup> into a later span, and the <sup> stays empty, which is what the lintHandler is complaining about.
  • This happens during the reparseTemplatedAttributes method of the TableFixups, more specifically at https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/4b1ae7dce10ad5928745a0b956abeabc5cdfebea/src/Wt2Html/PP/Handlers/TableFixups.php#429. We go through that path because we do happen to be in a template that does have attributes.
  • My current hypothesis is that something unexpected happens with the re-parsing of the content of the cell before setting the new innerHTML of the cell. To be continued: entering the Remex realm of debugging now ;)
Mar 4 2022, 1:26 PM · Parsoid, Wikimedia-production-error
ihurbain added a comment to T301293: Failed invariant in Linter.

And reducing the "Herbarium of Baltimore Woods specimen" template to

bgcolor="#fadada"|[[link|{{{1}}}]]

is also enough to reproduce the issue.

Mar 4 2022, 10:20 AM · Parsoid, Wikimedia-production-error
ihurbain created T303029: Revert ParsoidSiteConfigInit hook creation.
Mar 4 2022, 8:55 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), MW-1.38-release, MediaWiki-extensions-Translate, Parsoid

Mar 3 2022

ihurbain added a comment to T302964: ParserIntegrationTest::testParse with data set "parserTests.txt: Media link with nested wikilinks" ('legacy parser').

@kostajh should be fine, I posted a recheck on the https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/767690 patch, and it's now Verified+2 :)

Mar 3 2022, 11:50 AM · ci-test-error (WMF-deployed Build Failure), Growth-Team (Current Sprint), GrowthExperiments, MediaWiki-Parser
ihurbain updated subscribers of T302964: ParserIntegrationTest::testParse with data set "parserTests.txt: Media link with nested wikilinks" ('legacy parser').

As far as I can tell, this is a consequence of something @hashar has been warning us against - namely the dependence on CI level of GrowthExperiments to parsoid. This will pull parsoid master in the tests instead of the version of parsoid used on wmf.26, and parsoid master has https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/763858 included in it, which is almost surely what breaks these tests.
As to how to fix that.... no idea :(

Mar 3 2022, 10:21 AM · ci-test-error (WMF-deployed Build Failure), Growth-Team (Current Sprint), GrowthExperiments, MediaWiki-Parser

Mar 1 2022

ihurbain added a comment to T301293: Failed invariant in Linter.

This is still present on f34bf1865f2d6df9d0878a7bdad656b12c237953

Mar 1 2022, 5:28 PM · Parsoid, Wikimedia-production-error
ihurbain closed T296485: Annotation nesting detection is not well handled when annotations span over an attribute, a subtask of T296169: Parsoid sometimes nests the annotation tags when round-tripping wikitext, as Declined.
Mar 1 2022, 4:38 PM · Parsoid
ihurbain closed T296485: Annotation nesting detection is not well handled when annotations span over an attribute as Declined.

Declining this after discussion with @ssastry - this is not syntax we want to support, and this is also not something I remember seeing in the wild - I think it's more of a "what if" test scenario than a legitimate use case.

Mar 1 2022, 4:38 PM · Parsoid
ihurbain closed T272931: Make wikihiero extension compatible with Parsoid, a subtask of T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid, as Resolved.
Mar 1 2022, 3:54 PM · Parsing-Active-Work, Parsoid-Rendering, Parsoid
ihurbain closed T272931: Make wikihiero extension compatible with Parsoid as Resolved.
Mar 1 2022, 3:54 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), Parsoid-Rendering, Parsoid
ihurbain claimed T302678: PHP Notice: Trying to get property 't' of non-object (LanguageVariantHandler).
Mar 1 2022, 3:53 PM · Parsoid, Wikimedia-production-error
ihurbain claimed T301293: Failed invariant in Linter.
Mar 1 2022, 3:52 PM · Parsoid, Wikimedia-production-error
ihurbain added a comment to T302787: Rendering difference on nested lists with annotations.

Okay, I just did a cat ../metawiki-20210820-pages-articles-multistream.xml | node index '<translate>\n<!--T:\d+-->\n\*\*' on the Mediawiki dump I had on disk, and it returned 50 matches (number of pages, I think, not number of occurrences). That sounds indeed manageable - and I would expect that I'm catching most usages of that pattern with that.

Mar 1 2022, 3:21 PM · Parsoid, Parsoid-Read-Views
ihurbain added a comment to T302790: Annotation extended range can interfere with translation unit markup correctness.

I will also allow that none of this is recommended Translate markup as per https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration. So there's indeed a strong possibility I'm worrying too much.

Mar 1 2022, 2:29 PM · Parsoid, MediaWiki-extensions-Translate
ihurbain added a comment to T302790: Annotation extended range can interfere with translation unit markup correctness.

Commonly, I don't know yet - I'm waiting for our logging to check other instances of "extended annotations nesting another extension", if any. It does happen in the wild on https://www.mediawiki.org/wiki/Extension:Translate. I also want to point out that structures that may look absurd on a minimal example may stem from a string of edits that individually make sense - and that these might be pretty common. I will also allow that I _do_ have a pessimism bias, and that I may have been unlucky running into that case on the first page I tested - wouldn't be the first time either ;)

Mar 1 2022, 2:20 PM · Parsoid, MediaWiki-extensions-Translate
ihurbain updated the task description for T302790: Annotation extended range can interfere with translation unit markup correctness.
Mar 1 2022, 12:36 PM · Parsoid, MediaWiki-extensions-Translate
ihurbain updated subscribers of T301948: Wikimedia\Assert\InvariantException: Invariant failed: No KVs expected..

Thank @ssastry - his patch is the correct one :P (We did discuss this thing at length with @Arlolra too :) )

Mar 1 2022, 12:24 PM · Patch-For-Review, Parsoid, Wikimedia-production-error
ihurbain added a comment to T302790: Annotation extended range can interfere with translation unit markup correctness.

Creating this issue to keep track of it and be able to refer to it; Translate is not officially supported by VE yet, but this issue may be on the path to official support (to be discussed).

Mar 1 2022, 11:30 AM · Parsoid, MediaWiki-extensions-Translate
ihurbain created T302790: Annotation extended range can interfere with translation unit markup correctness.
Mar 1 2022, 11:28 AM · Parsoid, MediaWiki-extensions-Translate
ihurbain updated the task description for T302787: Rendering difference on nested lists with annotations.
Mar 1 2022, 11:20 AM · Parsoid, Parsoid-Read-Views
ihurbain updated the task description for T302787: Rendering difference on nested lists with annotations.
Mar 1 2022, 11:18 AM · Parsoid, Parsoid-Read-Views
ihurbain claimed T302787: Rendering difference on nested lists with annotations.
Mar 1 2022, 11:11 AM · Parsoid, Parsoid-Read-Views
ihurbain created T302787: Rendering difference on nested lists with annotations.
Mar 1 2022, 11:10 AM · Parsoid, Parsoid-Read-Views

Feb 21 2022

ihurbain closed T296107: Special treatment for translation unit marker comments in <translate>, a subtask of T261181: Make Translate extension compatible with Parsoid, as Resolved.
Feb 21 2022, 10:31 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Language-Team (Language-2021-October-December), Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsing-Active-Work, Patch-For-Review, Parsoid, Technical-Debt, Editing-Team-Request, MediaWiki-extensions-Translate
ihurbain closed T296107: Special treatment for translation unit marker comments in <translate> as Resolved.
Feb 21 2022, 10:31 AM · Parsoid

Feb 17 2022

ihurbain added a comment to T301948: Wikimedia\Assert\InvariantException: Invariant failed: No KVs expected..

The exact issue was introduced on https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/759621/9/src/Wt2Html/TT/TemplateHandler.php#1137, where we introduce passing the attributes instead of just a [].
Specifically, it breaks on extensions because of https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/e94f523d5db3f90e7d69e7baa9f581895e6d2d9a/src/Wt2Html/Grammar.pegphp#357 - where attribs is a KV and we don't expect it.
However, I don't know how to fix it, because I have no idea how "specific" the issue is:

Feb 17 2022, 1:23 PM · Patch-For-Review, Parsoid, Wikimedia-production-error
ihurbain added a comment to T301948: Wikimedia\Assert\InvariantException: Invariant failed: No KVs expected..

Issue introduced with commit 55da3090d0e7faa49e40a5bce0f68634fea5fc83

Feb 17 2022, 12:54 PM · Patch-For-Review, Parsoid, Wikimedia-production-error
ihurbain added a comment to T301948: Wikimedia\Assert\InvariantException: Invariant failed: No KVs expected..

Minimal reproducer:

Feb 17 2022, 12:18 PM · Patch-For-Review, Parsoid, Wikimedia-production-error

Feb 10 2022

ihurbain created T301492: Make annotation stripping in template arguments configurable.
Feb 10 2022, 5:32 PM · Parsoid
ihurbain updated the task description for T295834: Add special handling for annotation tags in template arguments.
Feb 10 2022, 5:24 PM · MediaWiki-extensions-Translate, Parsoid
ihurbain created T301490: Record stripped annotations from template arguments.
Feb 10 2022, 5:22 PM · Parsoid

Jan 31 2022

ihurbain renamed T299523: Annotations output do not expand templated attributes from Annotations do not support templated attributes to Annotations output do not expand templated attributes.
Jan 31 2022, 10:07 AM · Parsoid

Jan 26 2022

ihurbain closed T156308: Interlanguage links with spaces are parsed as wiki links as Resolved.
Jan 26 2022, 3:47 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Jan 21 2022

ihurbain committed rEHIEf2a2e713d480: Add explicit Parsoid support (authored by ihurbain).
Add explicit Parsoid support
Jan 21 2022, 2:26 PM

Jan 20 2022

ihurbain added a comment to T299523: Annotations output do not expand templated attributes.

@!# I didn't copy-paste the right example (OF COURSE my first attempts didn't escape the equals, but by now I *know* :D ). Anyway - edited the task, same conclusion.
The idea of "list of key-value pairs should be a valid return types" crossed my mind as yet another use case for this thing we discussed earlier - and if/when this gets implemented it was on the back of my mind to fix this issue that way.
+1 on Subbu's comment - exactly what I meant, thank you :)

Jan 20 2022, 8:07 AM · Parsoid
ihurbain updated the task description for T299523: Annotations output do not expand templated attributes.
Jan 20 2022, 8:02 AM · Parsoid

Jan 19 2022

ihurbain created T299523: Annotations output do not expand templated attributes.
Jan 19 2022, 2:07 PM · Parsoid

Jan 18 2022

ihurbain added a comment to T299375: PHP Warning: Illegal offset type in Parsoid's PEG tokenizer.

After having spent some quality time in the parser debug output, I have a minimal reproducer for this issue:

Jan 18 2022, 6:28 PM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Parsoid, Wikimedia-production-error
ihurbain added a comment to T299375: PHP Warning: Illegal offset type in Parsoid's PEG tokenizer.

That one is a <tvar| as argument of a template - we will eventually get rid of the source of this issue when we strip annotation from template arguments (already in progress around https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/737825). In the meantime, I switched the tvar syntax in that page to <tvar name="title"></tvar>, which fixes the issue for this specific page. I'm still going to investigate a little longer because I'd like to understand why it breaks at the PEGParser level.

Jan 18 2022, 12:15 PM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Parsoid, Wikimedia-production-error

Jan 17 2022

Krinkle awarded T261172: Much content is missing when editing a translatable page a Love token.
Jan 17 2022, 4:59 PM · Editing-team (Tracking), Parsoid, VisualEditor, VisualEditor-MediaWiki, MediaWiki-extensions-Translate
Nikerabbit awarded T261172: Much content is missing when editing a translatable page a Yellow Medal token.
Jan 17 2022, 6:33 AM · Editing-team (Tracking), Parsoid, VisualEditor, VisualEditor-MediaWiki, MediaWiki-extensions-Translate

Jan 11 2022

ihurbain claimed T295170: Move Parsoid's Translate implementation into the Translate extension repo.
Jan 11 2022, 4:07 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-extensions-Translate, Parsoid
ihurbain closed T295837: Analyze newline dirty diffs introduced by Parsoid around <translate> tags for rendering impacts, a subtask of T261181: Make Translate extension compatible with Parsoid, as Resolved.
Jan 11 2022, 12:42 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Language-Team (Language-2021-October-December), Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsing-Active-Work, Patch-For-Review, Parsoid, Technical-Debt, Editing-Team-Request, MediaWiki-extensions-Translate
ihurbain closed T295837: Analyze newline dirty diffs introduced by Parsoid around <translate> tags for rendering impacts as Resolved.

Closing this one because the analysis has been done, and more specific bugs have been filed.

Jan 11 2022, 12:42 PM · MediaWiki-extensions-Translate, Parsoid