Thu, Sep 28
Resolved by virtue of hardcoding it; the general "this only works in english" will be addressed around T345568.
Mon, Sep 25
Fri, Sep 22
Also, I actually need three of them to trigger the issue:
echo -e '<translate><tvar name="plop"></tvar></tvar></tvar></translate>' | php ./bin/parse.php
Two seems fine, somehow.
Weeeeeeeeeeeeeeeeeeeeeeeell. That's interesting. I was going to say "you actually can't save that wikitext with Translate, because it will yell at you if you try to save that", and turns out, that's wrong. It will yell at you for unbalanced <translate> tags, but NOT for unbalanced <tvar> tags.
Thu, Sep 21
T347009 is closed as a deployment side effect issue. The same issue and the associated warnings are probably to be expected during group2 deployment.
Seems like a deployment side effect issue.
Sounds good to me.
Looks like there's was a spike essentially at the moment of group1 deploy on group1 wikis, there was like 840 of these between 18:00 and 18:15, and none out of that interval. It feels highly plausible that it's related to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/942499.
Removing https://phabricator.wikimedia.org/T347007 from blockers since it's on dewiki, it's not train-blocking.
Just added two blockers for time to have another opinion on them before deploying them to group2. I'm probably overly careful, but I'm worried about cache incompatibility on T347009 and about logspam (and possibly rendering issues) on T347007.
Tue, Sep 19
Fri, Sep 15
This has been deployed for a long while by now, and it doesn't seem to be breaking the world. There are still a few bugs, but they can/will be investigated in separate tickets.
Thu, Sep 14
Tue, Sep 12
Do translated pages have translation markup in them? (I think not?)
Fri, Sep 8
I think I prefer the idea of the extension dealing with annotations by calling a Parsoid extension API method.
Reopening because I don't know how to read logstash, it seems.
Doesn't seem to have triggered in the past 3 months, marking as resolved, please reopen if new occurrences arise.
Not guidelines per se, but https://www.mediawiki.org/wiki/Parsoid/So_you_want_your_extension_to_work_with_Parsoid and https://www.mediawiki.org/wiki/Parsoid/Extension_API#Mapping_existing_parser_hooks are hopefully a reasonable starting point.
Mon, Sep 4
Aug 31 2023
Verified on beta - indicators are now processed on indicators. Will close after next deployment of Kartographer.
Aug 29 2023
Aug 4 2023
The URL rang a bell, and I wouldn't be surprised if it were another variation of https://phabricator.wikimedia.org/T260082.
Jul 31 2023
Jul 24 2023
Jun 22 2023
Jun 20 2023
Jun 16 2023
Jun 15 2023
First version of the patch is verified; still need to address some open questions in the patch, so moving back to In Progress column.
Few more instances of that one on Commons on June 14th 2023, e.g reqId: eb493356-b3b6-4b63-814c-e039e7df9764 Find reqId in Logstash
Mmmh. Error on 4 arguments passed, 4 expected - this is fishy.
Jun 12 2023
May 30 2023
This comes from
<translate>The parameter <tvar name=\"1\"><code>nowiki</code</tvar>> usually removes the link around the filepath (which can't be seen in this example).</translate>
First estimation: it's not "those many requests to that URL, it's "oops, we have an infinite loop situation going on here". So first, fixing that, and then understanding why it happens in the first place.
May 25 2023
May 22 2023
Neat, thank you! :)
May 17 2023
As far as I remember, if the language is "local", we're not exporting anything out of Kartographer anyway - it's just a shorthand to not add any language code when resolving the map. Thanks for pointing that out!
May 16 2023
I'm looking into streamlining languages for the Parsoid support of Kartographer. My not-so-hidden goal is to get rid of "target language" for Parsoid, and to be able to pass either "this is page language", "this is user language" or "this is specific language X".
Checked that data-mw="interface" has been replaced by the existence of "data-mw-kartographer" attribute on en.wikivoyage and en.wikipedia.
Apr 25 2023
It was already the case that it used the same graph ID (that's why I had that test case on my local wiki ;) ), and yeah, that'd be my guess as well that this is what causing the issue. Identical graphs are not without their issues, see T312242 and related.
The hash on the data may not be necessary per se, but it feels like a reasonable solution to ensure ID unicity (... up to using the same data, but then the same graph would be rendered, so it "shouldn't be a problem™") and ID stability, I guess.
Apr 14 2023
Mar 27 2023
Mar 16 2023
Mar 9 2023
Mar 6 2023
Indeed, updating back to mw:MediaLink seems to be enough for Parsoid to not have a dirty-diff there. It still displays a "modified-wrapper", but it round-trips without the accent as expected.