Page MenuHomePhabricator

ihurbain (Isabelle Hurbain-Palatin)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 7 2021, 8:12 AM (121 w, 1 d)
Availability
Available
LDAP User
Isabelle Hurbain-Palatin
MediaWiki User
IHurbainPalatin (WMF) [ Global Accounts ]

Recent Activity

Today

ihurbain claimed T347552: Bad rendering of map links associated map frames in on enwikivoyage (Parsoid).
Tue, Oct 3, 11:35 AM · Patch-For-Review, Parsoid, Maps (Kartographer)
ihurbain claimed T347180: Bad handling of annotations in which the end tag is fostered.
Tue, Oct 3, 11:32 AM · Patch-For-Review, Maintenance-Worktype, Parsoid

Yesterday

ihurbain created T347877: Annotations and templates misnesting don't wrap correctly around each other.
Mon, Oct 2, 2:57 PM · Parsoid

Thu, Sep 28

ihurbain updated the task description for T347552: Bad rendering of map links associated map frames in on enwikivoyage (Parsoid).
Thu, Sep 28, 10:20 AM · Patch-For-Review, Parsoid, Maps (Kartographer)
ihurbain created T347552: Bad rendering of map links associated map frames in on enwikivoyage (Parsoid).
Thu, Sep 28, 8:48 AM · Patch-For-Review, Parsoid, Maps (Kartographer)
ihurbain closed T346161: Maplinks with default coordinate labels do not display correctly with Parsoid as Resolved.

Resolved by virtue of hardcoding it; the general "this only works in english" will be addressed around T345568.

Thu, Sep 28, 8:07 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP, Maps (Kartographer)

Mon, Sep 25

ihurbain closed T342887: Maplink tags in indicators are not working with Parsoid as Resolved.
Mon, Sep 25, 3:37 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)

Fri, Sep 22

ihurbain moved T347180: Bad handling of annotations in which the end tag is fostered from Needs Triage to Bugs & Crashers on the Parsoid board.
Fri, Sep 22, 2:42 PM · Patch-For-Review, Maintenance-Worktype, Parsoid
ihurbain created T347180: Bad handling of annotations in which the end tag is fostered.
Fri, Sep 22, 2:41 PM · Patch-For-Review, Maintenance-Worktype, Parsoid
ihurbain added a comment to T346805: Erroneous detection of </> as </tvar> triggers issues with annotation range processing.

Also, I actually need three of them to trigger the issue:

echo -e '<translate><tvar name="plop"></tvar></tvar></tvar></translate>' | php ./bin/parse.php

Two seems fine, somehow.

Fri, Sep 22, 9:01 AM · Patch-For-Review, Wikimedia-production-error, Parsoid
ihurbain added a comment to T346805: Erroneous detection of </> as </tvar> triggers issues with annotation range processing.

Weeeeeeeeeeeeeeeeeeeeeeeell. That's interesting. I was going to say "you actually can't save that wikitext with Translate, because it will yell at you if you try to save that", and turns out, that's wrong. It will yell at you for unbalanced <translate> tags, but NOT for unbalanced <tvar> tags.

Fri, Sep 22, 8:22 AM · Patch-For-Review, Wikimedia-production-error, Parsoid

Thu, Sep 21

ihurbain created T347033: Align "tvar outside of translate tags" between the legacy parser and Parsoid implementations of Translate.
Thu, Sep 21, 12:27 PM · MediaWiki-extensions-Translate, Parsoid
ihurbain added a comment to T345888: 1.41.0-wmf.27 deployment blockers.

T347009 is closed as a deployment side effect issue. The same issue and the associated warnings are probably to be expected during group2 deployment.

Thu, Sep 21, 9:35 AM · Patch-For-Review, User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ihurbain closed T347009: PHP Notice: Undefined index: OutputHooks, a subtask of T345888: 1.41.0-wmf.27 deployment blockers, as Resolved.
Thu, Sep 21, 9:33 AM · Patch-For-Review, User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ihurbain closed T347009: PHP Notice: Undefined index: OutputHooks as Resolved.

Seems like a deployment side effect issue.

Thu, Sep 21, 9:33 AM · Parsoid, Wikimedia-production-error
ihurbain added a comment to T347009: PHP Notice: Undefined index: OutputHooks.

Sounds good to me.

Thu, Sep 21, 9:32 AM · Parsoid, Wikimedia-production-error
ihurbain added a comment to T347009: PHP Notice: Undefined index: OutputHooks.

Looks like there's was a spike essentially at the moment of group1 deploy on group1 wikis, there was like 840 of these between 18:00 and 18:15, and none out of that interval. It feels highly plausible that it's related to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/942499.

Thu, Sep 21, 9:28 AM · Parsoid, Wikimedia-production-error
ihurbain added a comment to T345888: 1.41.0-wmf.27 deployment blockers.

Removing https://phabricator.wikimedia.org/T347007 from blockers since it's on dewiki, it's not train-blocking.

Thu, Sep 21, 9:18 AM · Patch-For-Review, User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ihurbain removed a subtask for T345888: 1.41.0-wmf.27 deployment blockers: T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php).
Thu, Sep 21, 9:17 AM · Patch-For-Review, User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ihurbain removed a parent task for T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php): T345888: 1.41.0-wmf.27 deployment blockers.
Thu, Sep 21, 9:17 AM · Content-Transform-Team, Parsoid, Wikimedia-production-error
ihurbain added a comment to T345888: 1.41.0-wmf.27 deployment blockers.

Just added two blockers for time to have another opinion on them before deploying them to group2. I'm probably overly careful, but I'm worried about cache incompatibility on T347009 and about logspam (and possibly rendering issues) on T347007.

Thu, Sep 21, 9:04 AM · Patch-For-Review, User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ihurbain added a parent task for T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php): T345888: 1.41.0-wmf.27 deployment blockers.
Thu, Sep 21, 9:02 AM · Content-Transform-Team, Parsoid, Wikimedia-production-error
ihurbain added subtasks for T345888: 1.41.0-wmf.27 deployment blockers: T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php), T347009: PHP Notice: Undefined index: OutputHooks.
Thu, Sep 21, 9:02 AM · Patch-For-Review, User-brennen, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
ihurbain added a parent task for T347009: PHP Notice: Undefined index: OutputHooks: T345888: 1.41.0-wmf.27 deployment blockers.
Thu, Sep 21, 9:02 AM · Parsoid, Wikimedia-production-error
ihurbain created T347009: PHP Notice: Undefined index: OutputHooks.
Thu, Sep 21, 8:48 AM · Parsoid, Wikimedia-production-error
ihurbain created T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php).
Thu, Sep 21, 8:43 AM · Content-Transform-Team, Parsoid, Wikimedia-production-error

Tue, Sep 19

ihurbain created T346805: Erroneous detection of </> as </tvar> triggers issues with annotation range processing.
Tue, Sep 19, 5:02 PM · Patch-For-Review, Wikimedia-production-error, Parsoid

Fri, Sep 15

ihurbain closed T261181: Make Translate extension compatible with Parsoid as Resolved.

This has been deployed for a long while by now, and it doesn't seem to be breaking the world. There are still a few bugs, but they can/will be investigated in separate tickets.

Fri, Sep 15, 3:51 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Language-Team (Language-2021-October-December), Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsing-Active-Work, Patch-For-Review, Parsoid, Technical-Debt, Editing-Team-Request, MediaWiki-extensions-Translate
ihurbain closed T261181: Make Translate extension compatible with Parsoid, a subtask of T55974: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension), as Resolved.
Fri, Sep 15, 3:51 PM · VisualEditor-MediaWiki, VisualEditor, VisualEditor-MediaWiki-Plugins, MediaWiki-extensions-Translate
ihurbain closed T261181: Make Translate extension compatible with Parsoid, a subtask of T261172: Much content is missing when editing a translatable page, as Resolved.
Fri, Sep 15, 3:51 PM · Editing-team (Tracking), Parsoid, VisualEditor, VisualEditor-MediaWiki, MediaWiki-extensions-Translate
ihurbain closed T261181: Make Translate extension compatible with Parsoid, a subtask of T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid, as Resolved.
Fri, Sep 15, 3:51 PM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ihurbain claimed T346452: Bad translate/ref nesting prevents correct detection of annotation ranges.
Fri, Sep 15, 3:05 PM · Maintenance-Worktype, Wikimedia-production-error, Parsoid
ihurbain created T346452: Bad translate/ref nesting prevents correct detection of annotation ranges.
Fri, Sep 15, 3:05 PM · Maintenance-Worktype, Wikimedia-production-error, Parsoid
ihurbain added a subtask for T302886: [warn] The annotation ranges could not be fully detected. Annotation processing cancelled. : T303627: Translation unit markers interferes with comment markup in Parsoid rendering.
Fri, Sep 15, 2:41 PM · Maintenance-Worktype, Wikimedia-production-error, Parsoid
ihurbain added a parent task for T303627: Translation unit markers interferes with comment markup in Parsoid rendering: T302886: [warn] The annotation ranges could not be fully detected. Annotation processing cancelled. .
Fri, Sep 15, 2:41 PM · Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), Parsoid, MediaWiki-extensions-Translate

Thu, Sep 14

ihurbain moved T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php from Code Review to To Deploy on the Content-Transform-Team-WIP board.
Thu, Sep 14, 2:38 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error

Tue, Sep 12

ihurbain updated the task description for T346161: Maplinks with default coordinate labels do not display correctly with Parsoid.
Tue, Sep 12, 3:53 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP, Maps (Kartographer)
ihurbain claimed T346161: Maplinks with default coordinate labels do not display correctly with Parsoid.
Tue, Sep 12, 3:52 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP, Maps (Kartographer)
ihurbain created T346161: Maplinks with default coordinate labels do not display correctly with Parsoid.
Tue, Sep 12, 3:52 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Content-Transform-Team-WIP, Maps (Kartographer)
ihurbain added a comment to T341009: syntaxhighlight and translate don't play well together in Parsoid.

Do translated pages have translation markup in them? (I think not?)

Tue, Sep 12, 2:48 PM · Patch-For-Review, Content-Transform-Team-WIP, MediaWiki-extensions-Translate, SyntaxHighlight, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid

Fri, Sep 8

ihurbain added a comment to T341009: syntaxhighlight and translate don't play well together in Parsoid.

I think I prefer the idea of the extension dealing with annotations by calling a Parsoid extension API method.

Fri, Sep 8, 4:11 PM · Patch-For-Review, Content-Transform-Team-WIP, MediaWiki-extensions-Translate, SyntaxHighlight, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
ihurbain reopened T302886: [warn] The annotation ranges could not be fully detected. Annotation processing cancelled. as "Open".

Reopening because I don't know how to read logstash, it seems.

Fri, Sep 8, 3:41 PM · Maintenance-Worktype, Wikimedia-production-error, Parsoid
ihurbain closed T302886: [warn] The annotation ranges could not be fully detected. Annotation processing cancelled. as Resolved.

Doesn't seem to have triggered in the past 3 months, marking as resolved, please reopen if new occurrences arise.

Fri, Sep 8, 2:58 PM · Maintenance-Worktype, Wikimedia-production-error, Parsoid
ihurbain added a comment to T258838: [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid.

Not guidelines per se, but https://www.mediawiki.org/wiki/Parsoid/So_you_want_your_extension_to_work_with_Parsoid and https://www.mediawiki.org/wiki/Parsoid/Extension_API#Mapping_existing_parser_hooks are hopefully a reasonable starting point.

Fri, Sep 8, 11:02 AM · Parsoid-Read-Views, Parsing-Active-Work, Parsoid-Rendering, Parsoid
ihurbain moved T341009: syntaxhighlight and translate don't play well together in Parsoid from Backlog to In Progress on the Content-Transform-Team-WIP board.
Fri, Sep 8, 9:09 AM · Patch-For-Review, Content-Transform-Team-WIP, MediaWiki-extensions-Translate, SyntaxHighlight, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
ihurbain claimed T341009: syntaxhighlight and translate don't play well together in Parsoid.
Fri, Sep 8, 9:09 AM · Patch-For-Review, Content-Transform-Team-WIP, MediaWiki-extensions-Translate, SyntaxHighlight, Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
ihurbain moved T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php from Backlog to Code Review on the Content-Transform-Team-WIP board.
Fri, Sep 8, 9:02 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error

Mon, Sep 4

ihurbain moved T345568: Kartographer + Parsoid: Content in marker wikitext is not entirely post-processed before storing it in ExtensionData from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.
Mon, Sep 4, 2:12 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain claimed T345568: Kartographer + Parsoid: Content in marker wikitext is not entirely post-processed before storing it in ExtensionData.
Mon, Sep 4, 2:11 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain moved T345568: Kartographer + Parsoid: Content in marker wikitext is not entirely post-processed before storing it in ExtensionData from Needs Triage to Missing Functionality on the Parsoid board.
Mon, Sep 4, 2:11 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain created T345568: Kartographer + Parsoid: Content in marker wikitext is not entirely post-processed before storing it in ExtensionData.
Mon, Sep 4, 2:11 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)

Aug 31 2023

ihurbain added a comment to T342887: Maplink tags in indicators are not working with Parsoid.

Verified on beta - indicators are now processed on indicators. Will close after next deployment of Kartographer.

Aug 31 2023, 9:23 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain updated the task description for T342887: Maplink tags in indicators are not working with Parsoid.
Aug 31 2023, 9:20 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain moved T342887: Maplink tags in indicators are not working with Parsoid from Backlog to To Deploy on the Content-Transform-Team-WIP board.
Aug 31 2023, 9:20 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)

Aug 29 2023

ihurbain updated the task description for T342887: Maplink tags in indicators are not working with Parsoid.
Aug 29 2023, 1:17 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain updated the task description for T342871: Parsoid + Kartographer roll-out plan.
Aug 29 2023, 8:22 AM · Parsoid-Read-Views, Maps (Kartographer)

Aug 4 2023

ihurbain added a comment to T343245: PHP Notice: Undefined index: mwf6.

The URL rang a bell, and I wouldn't be surprised if it were another variation of https://phabricator.wikimedia.org/T260082.

Aug 4 2023, 2:52 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Wikimedia-production-error

Jul 31 2023

ihurbain moved T342876: Support map tags generated in Parsoid for labels other than English from Backlog to Blocked on the Content-Transform-Team-WIP board.
Jul 31 2023, 3:14 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain claimed T342871: Parsoid + Kartographer roll-out plan.
Jul 31 2023, 3:14 PM · Parsoid-Read-Views, Maps (Kartographer)
ihurbain claimed T342876: Support map tags generated in Parsoid for labels other than English.
Jul 31 2023, 3:13 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)
ihurbain claimed T342887: Maplink tags in indicators are not working with Parsoid.
Jul 31 2023, 3:13 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid, Maps (Kartographer)

Jul 24 2023

ihurbain moved T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php from In Progress to Backlog on the Content-Transform-Team-WIP board.
Jul 24 2023, 3:26 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error

Jun 22 2023

ihurbain created T340134: Feature flag addition/removal for Parsoid support for Kartographer.
Jun 22 2023, 4:22 PM · Maintenance-Worktype, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Parsoid, Content-Transform-Team-WIP, Parsoid-Rendering, Maps (Kartographer)

Jun 20 2023

ihurbain moved T139694: Kartographer's Wikivoyage mode relies on global state (which isn't allowed), so listing numbers are all "1" at all Wikivoyages in VE mode and other issues from Backlog to Code Review on the Content-Transform-Team-WIP board.
Jun 20 2023, 2:20 PM · Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), WMDE-TechWish-Maintenance, Epic, Maps (Kartographer), Parsoid, VisualEditor

Jun 16 2023

ihurbain renamed T339366: Address potential impact of Kiwix crawling on ParserCache before MCS decommissioning from Address potential impact of Kiwis crawling on ParserCache before MCS decommissioning to Address potential impact of Kiwix crawling on ParserCache before MCS decommissioning.
Jun 16 2023, 2:07 PM · affects-Kiwix-and-openZIM, RESTBase Sunsetting, MediaWiki-REST-API, Parsoid

Jun 15 2023

ihurbain added a comment to T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php.

First version of the patch is verified; still need to address some open questions in the patch, so moving back to In Progress column.

Jun 15 2023, 4:34 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain moved T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php from To Verify to In Progress on the Content-Transform-Team-WIP board.
Jun 15 2023, 4:33 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain added a comment to T321320: PHP Warning: get_class() expects parameter 1 to be object, unknown given.

Few more instances of that one on Commons on June 14th 2023, e.g reqId: eb493356-b3b6-4b63-814c-e039e7df9764 Find reqId in Logstash

Jun 15 2023, 8:14 AM · API Platform, MediaWiki-REST-API, Wikimedia-production-error
ihurbain added a comment to T339195: ArgumentCountError: Too few arguments to function Wikimedia\LangConv\BacktrackState::__construct(), 4 passed in /srv/mediawiki/php-1.41.0-wmf.12/vendor/wikimedia/langconv/src/FST.php on line 168 and exactly 4 expected.

Mmmh. Error on 4 arguments passed, 4 expected - this is fishy.

Jun 15 2023, 7:59 AM · Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, MediaWiki-Language-converter, Wikimedia-production-error
ihurbain created T339195: ArgumentCountError: Too few arguments to function Wikimedia\LangConv\BacktrackState::__construct(), 4 passed in /srv/mediawiki/php-1.41.0-wmf.12/vendor/wikimedia/langconv/src/FST.php on line 168 and exactly 4 expected.
Jun 15 2023, 7:58 AM · Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, MediaWiki-Language-converter, Wikimedia-production-error

Jun 12 2023

ihurbain moved T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Jun 12 2023, 3:07 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error

May 30 2023

ihurbain moved T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php from Backlog to Code Review on the Content-Transform-Team-WIP board.
May 30 2023, 12:53 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain added a project to T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php: Content-Transform-Team-WIP.
May 30 2023, 12:53 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain claimed T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php.
May 30 2023, 12:52 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain added a comment to T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php.

This comes from

<translate>The parameter <tvar name=\"1\"><code>nowiki</code</tvar>> usually removes the link around the filepath (which can't be seen in this example).</translate>
May 30 2023, 8:57 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain added a comment to T325575: "Trying to get property 'nextSibling' of non-object" in AnnotationDOMRangeBuilder.php.

First estimation: it's not "those many requests to that URL, it's "oops, we have an infinite loop situation going on here". So first, fixing that, and then understanding why it happens in the first place.

May 30 2023, 8:35 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
ihurbain closed T331652: Fix data-mw='interface' usage in Kartographer, a subtask of T263762: Make Kartographer extension compatible with Parsoid, as Resolved.
May 30 2023, 8:05 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Parsoid, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), WMDE-TechWish-Sprint-2023-01-18, Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Rendering, Maps (Kartographer), Product-Infrastructure-Team-Backlog-Deprecated
ihurbain closed T331652: Fix data-mw='interface' usage in Kartographer as Resolved.
May 30 2023, 8:05 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)

May 25 2023

ihurbain moved T263762: Make Kartographer extension compatible with Parsoid from In Progress to Code Review on the Content-Transform-Team-WIP board.
May 25 2023, 1:10 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Parsoid, Parsoid-Read-Views (Phase 1 - DiscussionTools support), MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), WMDE-TechWish-Sprint-2023-01-18, Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Parsoid-Rendering, Maps (Kartographer), Product-Infrastructure-Team-Backlog-Deprecated
ihurbain added a comment to T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.

The issue to be determined is who else besides LintHint is accessing this API and whether they want to see 'large-table' lint records or not.

This hints at removing any logic from that endpoint for filtering lints (as in the patch above) and making the default to not emit them. Then, add a configuration so that they only get emitted when we're linting as part of a full page parse that is going to be recorded by the linter extension.

May 25 2023, 8:34 AM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter

May 22 2023

ihurbain added a comment to T337219: phan PhanImpossibleTypeComparison false positive after ternary operator.

Neat, thank you! :)

May 22 2023, 9:06 AM · Upstream, phan
ihurbain created T337219: phan PhanImpossibleTypeComparison false positive after ternary operator.
May 22 2023, 8:23 AM · Upstream, phan

May 17 2023

ihurbain added a comment to T309166: Review language handling in Kartographer & Kartotherian.

As far as I remember, if the language is "local", we're not exporting anything out of Kartographer anyway - it's just a shorthand to not add any language code when resolving the map. Thanks for pointing that out!

May 17 2023, 7:38 AM · MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), WMDE-GeoInfo-FocusArea, Maps, I18n, Epic

May 16 2023

ihurbain moved T331652: Fix data-mw='interface' usage in Kartographer from Code Review to To Deploy on the Content-Transform-Team-WIP board.
May 16 2023, 4:37 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)
ihurbain added a comment to T309166: Review language handling in Kartographer & Kartotherian.

I'm looking into streamlining languages for the Parsoid support of Kartographer. My not-so-hidden goal is to get rid of "target language" for Parsoid, and to be able to pass either "this is page language", "this is user language" or "this is specific language X".

May 16 2023, 4:30 PM · MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), WMDE-GeoInfo-FocusArea, Maps, I18n, Epic
ihurbain closed T296392: Old syntax tvar breaks templates, a subtask of T295834: Add special handling for annotation tags in template arguments, as Resolved.
May 16 2023, 1:31 PM · MediaWiki-extensions-Translate, Parsoid
ihurbain closed T296392: Old syntax tvar breaks templates as Resolved.
May 16 2023, 1:31 PM · Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
ihurbain moved T331652: Fix data-mw='interface' usage in Kartographer from In Progress to Code Review on the Content-Transform-Team-WIP board.
May 16 2023, 1:10 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)
ihurbain moved T331652: Fix data-mw='interface' usage in Kartographer from To Verify to In Progress on the Content-Transform-Team-WIP board.
May 16 2023, 11:59 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)
ihurbain added a comment to T331652: Fix data-mw='interface' usage in Kartographer.

Checked that data-mw="interface" has been replaced by the existence of "data-mw-kartographer" attribute on en.wikivoyage and en.wikipedia.

May 16 2023, 11:59 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)

Apr 25 2023

ihurbain added a comment to T335335: Duplicated graph doesn't display anymore.

It was already the case that it used the same graph ID (that's why I had that test case on my local wiki ;) ), and yeah, that'd be my guess as well that this is what causing the issue. Identical graphs are not without their issues, see T312242 and related.
The hash on the data may not be necessary per se, but it feels like a reasonable solution to ensure ID unicity (... up to using the same data, but then the same graph would be rendered, so it "shouldn't be a problem™") and ID stability, I guess.

Apr 25 2023, 9:45 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), MediaWiki-extensions-Graph
ihurbain created T335335: Duplicated graph doesn't display anymore.
Apr 25 2023, 8:37 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), MediaWiki-extensions-Graph

Apr 14 2023

ihurbain claimed T334709: PHP Notice: Trying to get property 'nextSibling' of non-object.
Apr 14 2023, 7:55 AM · Parsoid, Wikimedia-production-error

Mar 27 2023

ihurbain moved T331652: Fix data-mw='interface' usage in Kartographer from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Mar 27 2023, 3:03 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)

Mar 16 2023

ihurbain moved T331652: Fix data-mw='interface' usage in Kartographer from Backlog to To Deploy on the Content-Transform-Team-WIP board.
Mar 16 2023, 5:15 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)

Mar 9 2023

ihurbain created T331652: Fix data-mw='interface' usage in Kartographer.
Mar 9 2023, 5:53 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Content-Transform-Team-WIP, Maps (Kartographer)

Mar 6 2023

ihurbain added a comment to T331122: Dirty diffs on Media: links on non-English wikis.

Indeed, updating back to mw:MediaLink seems to be enough for Parsoid to not have a dirty-diff there. It still displays a "modified-wrapper", but it round-trips without the accent as expected.

Mar 6 2023, 12:26 PM · Editing-team (Tracking), Parsoid (Tracking), VisualEditor

Mar 3 2023

ihurbain updated the task description for T331122: Dirty diffs on Media: links on non-English wikis.
Mar 3 2023, 12:35 PM · Editing-team (Tracking), Parsoid (Tracking), VisualEditor
ihurbain updated the task description for T331122: Dirty diffs on Media: links on non-English wikis.
Mar 3 2023, 12:34 PM · Editing-team (Tracking), Parsoid (Tracking), VisualEditor
ihurbain updated the task description for T331122: Dirty diffs on Media: links on non-English wikis.
Mar 3 2023, 12:34 PM · Editing-team (Tracking), Parsoid (Tracking), VisualEditor