jayvdb (John Vandenberg)
User

Projects (46)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 16 2014, 9:25 AM (188 w, 1 d)
Availability
Available
IRC Nick
jayvdb
LDAP User
Unknown
MediaWiki User
John Vandenberg

Recent Activity

Yesterday

jayvdb added a comment to T194890: test_datatypes and test_entities of paraminfo_tests.WikibaseKnownTypesTests class fails .

This can be closed?

Thu, May 24, 2:43 AM · Patch-For-Review, Easy, Pywikibot-Wikidata, Pywikibot-tests, Pywikibot-core
jayvdb added a project to T195435: Pywikibot support for Lexicographical data: Pywikibot-core.
Thu, May 24, 2:43 AM · Pywikibot-core
jayvdb created T195435: Pywikibot support for Lexicographical data.
Thu, May 24, 2:42 AM · Pywikibot-core

Sat, May 19

jayvdb added a comment to T109939: For mirrored GitHub repositories, actually give the canonical source Gerrit URL in the repo description.

We could use github repo topics to identify the repos which are active on github.

Sat, May 19, 4:40 PM · GitHub-Mirrors

Apr 18 2018

jayvdb added a comment to T179775: Add Pywikibot as a featured project to the software list on mw:New_Developers.

https://lists.wikimedia.org/pipermail/pywikibot/2016-August/009493.html is Amir attacking me without naming me, because his patches were not being accepted. It is full of lies. I have stepped away from Pywikibot as a result of that email, except for mentoring GSoC and GCI students.

Apr 18 2018, 11:18 PM · Pywikibot-RfCs, Developer-Relations, Pywikibot-General, Pywikibot-core

Mar 20 2018

jayvdb updated the task description for T57081: Implement support for Flagged Revisions in Pywikibot.
Mar 20 2018, 2:31 AM · User-Tgr, Google-Summer-of-Code (2018), MediaWiki-extensions-FlaggedRevs, Pywikibot-core, Possible-Tech-Projects

Mar 4 2018

Framawiki awarded T102317: Supporting on-wiki list of replacements similar to fixes.py a Love token.
Mar 4 2018, 8:58 PM · Pywikibot-core

Feb 26 2018

Capt_Swing awarded T124972: PAWS cron functionality a Hungry Hippo token.
Feb 26 2018, 6:44 PM · Upstream, PAWS
jayvdb added a project to T177682: Participate in the GSoC 2017 mentor summit : Google-Summer-of-Code (2017).
Feb 26 2018, 4:35 AM · Google-Summer-of-Code (2017), Developer-Relations (Oct-Dec 2017)

Feb 23 2018

jayvdb added a comment to T57081: Implement support for Flagged Revisions in Pywikibot.

Thanks @Tgr , that use case sounds perfect. I've added you as a mentor, with the expectation you'll mostly be involved in familiarisation at the beginning, and validation of the use cases and checking the final code meets the communities needs.

Feb 23 2018, 5:52 AM · User-Tgr, Google-Summer-of-Code (2018), MediaWiki-extensions-FlaggedRevs, Pywikibot-core, Possible-Tech-Projects
jayvdb moved T57081: Implement support for Flagged Revisions in Pywikibot from Need Mentors to Featured for GSoC'18/Outreachy'16 on the Possible-Tech-Projects board.
Feb 23 2018, 5:43 AM · User-Tgr, Google-Summer-of-Code (2018), MediaWiki-extensions-FlaggedRevs, Pywikibot-core, Possible-Tech-Projects
jayvdb updated the task description for T57081: Implement support for Flagged Revisions in Pywikibot.
Feb 23 2018, 5:43 AM · User-Tgr, Google-Summer-of-Code (2018), MediaWiki-extensions-FlaggedRevs, Pywikibot-core, Possible-Tech-Projects

Feb 15 2018

jayvdb added a comment to T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California.

Note I will also be attending that weekend due to being selected as the mentor for coala.

Feb 15 2018, 10:31 AM · Developer-Relations (Jan-Mar-2018), Google-Code-in-2017
jayvdb awarded T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California a Like token.
Feb 15 2018, 2:38 AM · Developer-Relations (Jan-Mar-2018), Google-Code-in-2017

Feb 9 2018

jayvdb updated the task description for T184116: Setup gitiles for use with gerrit as a repo viewer.
Feb 9 2018, 4:57 AM · Patch-For-Review, Gerrit

Feb 5 2018

jayvdb closed T183014: Support Gerrit in git-repo client as Resolved.

Merged into devel https://github.com/guyzmo/git-repo/commit/2974c3f52bc64fa8a467ac2b0e9a485ba7ed333b

Feb 5 2018, 7:09 AM · Google-Code-in-2017

Jan 19 2018

jayvdb added a comment to T181738: Google Code-in 2017: Collect Feedback and Lessons Learned.

Re notifications, I saw that a feature Google added towards the end of this years program was emails sent when the task is 24 hrs elapsed for mentors to review, i.e. 12 hrs to go.

Jan 19 2018, 10:21 PM · Google-Code-in-2017, Developer-Relations (Jan-Mar-2018)

Jan 17 2018

jayvdb added a comment to T57081: Implement support for Flagged Revisions in Pywikibot.

I am always interested in mentoring it, but refuse to do it without the support of a real community using FlaggedRevs, via a knowledgeable community member as co-mentor.
We've tried to find one , and failed. (see history of this task) I'll be very happy if you succeed where I have failed.
I've especially tried to solicit Wikimedia Indonesia to provided a co-mentor from the Indonesian community which uses FlaggedRevs , but that hasnt worked in the past either. I will try that again this year, and will also look more broadly in the Indonesian community.

Jan 17 2018, 2:04 AM · User-Tgr, Google-Summer-of-Code (2018), MediaWiki-extensions-FlaggedRevs, Pywikibot-core, Possible-Tech-Projects
jayvdb updated the task description for T57081: Implement support for Flagged Revisions in Pywikibot.
Jan 17 2018, 1:57 AM · User-Tgr, Google-Summer-of-Code (2018), MediaWiki-extensions-FlaggedRevs, Pywikibot-core, Possible-Tech-Projects

Jan 16 2018

jayvdb added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

Hi @Xqt, this was taken into account in the development. The live tests can be activated using an environment variable. see recent addition to tests/README.rst . Maybe we want to update the Travis builds on the main repo to always do live tests.

Jan 16 2018, 10:14 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core

Jan 15 2018

jayvdb added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

I've created https://codein.withgoogle.com/dashboard/tasks/4590764342378496/ as a follow-up task for this, to add more cassettes. Only three available as this is a 'last task', and there is a lot of potential for conflict.

Jan 15 2018, 10:43 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb added a comment to T179905: Make Change-Id optional.

I've added a follow up GCI task to implement this in a Wikimedia project hosted on GitHub.
https://codein.withgoogle.com/dashboard/tasks/5025736417083392/

Jan 15 2018, 10:32 AM · Patch-For-Review, Google-Code-in-2017, commit-message-validator

Jan 11 2018

jayvdb merged task T180962: Add basic Gerrit support to git-repo into T183014: Support Gerrit in git-repo client.
Jan 11 2018, 2:10 PM · Google-Code-in-2017
jayvdb merged T180962: Add basic Gerrit support to git-repo into T183014: Support Gerrit in git-repo client.
Jan 11 2018, 2:10 PM · Google-Code-in-2017
jayvdb closed T180962: Add basic Gerrit support to git-repo, a subtask of T183014: Support Gerrit in git-repo client, as Declined.
Jan 11 2018, 2:10 PM · Google-Code-in-2017
jayvdb closed T180962: Add basic Gerrit support to git-repo as Declined.

After it is merged, most of the functionality is done, and further enhancements would need to be worked on with the git-repo maintainers.

Jan 11 2018, 2:10 PM · Google-Code-in-2017
jayvdb assigned T183014: Support Gerrit in git-repo client to Phantom42.

After it is merged, most of the functionality is done, and this task should be closed. This wouldnt be suitable for a tech project, as there are only tiny chunks left to write after this patch, and git-repo is intentionally limited in what functionality is added - all features must be sensible in most backends.

Jan 11 2018, 2:10 PM · Google-Code-in-2017
jayvdb updated subscribers of T184674: Drop "2" from names of environmental variables.

PYWIKIBOT2_TEST_ are easy. They are only used in our tests. Travis CI configs will be effected. Some forks may be using these in their CI, which will break if they are renamed. I suspect this isnt a big enough problem to worry about. Easy to fix.

Jan 11 2018, 9:16 AM · Pywikibot-core
jayvdb added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

My notes about improvements probably needed.

Jan 11 2018, 3:01 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb updated the task description for T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.
Jan 11 2018, 2:59 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb updated the task description for T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.
Jan 11 2018, 2:58 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

Oops. Now I need to create a GCI task for this.

Jan 11 2018, 2:58 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb reopened T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy as "Open".
Jan 11 2018, 2:56 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb closed T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy as Resolved.
Jan 11 2018, 2:56 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core

Jan 10 2018

jayvdb added a watcher for Discourse: jayvdb.
Jan 10 2018, 6:44 AM

Jan 8 2018

jayvdb added a comment to T179905: Make Change-Id optional.

Just do it.

Jan 8 2018, 9:15 AM · Patch-For-Review, Google-Code-in-2017, commit-message-validator

Jan 7 2018

jayvdb added a comment to T183094: diff_checker should ignore new files when porting from compat.

Which scripts are left to port from compat? Has anyone asked for them? If not, we're importing more maintenance work without any clear benefit.

Jan 7 2018, 12:11 PM · Pywikibot-tests, Pywikibot-core
jayvdb added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

Also note that vcrpy is already a dependency due to nose-detecthttp

Jan 7 2018, 12:02 PM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb raised the priority of T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy from Low to High.

This is how we will have more tests running on the local developer machines very quickly and easily (not taking hours, interacting with sites), and on upload into Gerrit, instead of having to rely on Travis.

Jan 7 2018, 11:45 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb assigned T179014: Provide a pytest for database of wikilabels to Eisenhaus335.
Jan 7 2018, 6:43 AM · Google-Code-in-2017, Scoring-platform-team, Wikilabels
jayvdb added a comment to T68102: use one library for all http requests.

Two new possible GCI tasks T184360 & T184361 . Need more analysis done, and expanding the description to ensure that the work is of a high quality.

Jan 7 2018, 4:10 AM · Pywikibot-core, Pywikibot-network
jayvdb triaged T184361: Convert specialbots to use requests as High priority.
Jan 7 2018, 3:37 AM · Pywikibot-core, Pywikibot-network
jayvdb updated subscribers of T68102: use one library for all http requests.
Jan 7 2018, 3:35 AM · Pywikibot-core, Pywikibot-network
jayvdb removed a project from T68102: use one library for all http requests: Patch-For-Review.
Jan 7 2018, 3:35 AM · Pywikibot-core, Pywikibot-network
jayvdb triaged T184360: Convert imageharvest to requests as High priority.
Jan 7 2018, 3:35 AM · Pywikibot-core, Pywikibot-network
jayvdb added a comment to T124138: reflinks should fetch only 1Mb of each linked document.

sorry I missed this; could you rebase the patch and submit to travis so we can see if it doesnt break anything (reflinks has good tests, so that is sufficient to verify nothing is broken). Then make sure that one of the tests tries to fetch a 2 Mb PDF, and emit a warning to indicate that the document was trimmed.

Jan 7 2018, 2:42 AM · Patch-For-Review, Performance, Regression, Pywikibot-core, Pywikibot-network, Pywikibot-Other-scripts
jayvdb added a comment to T130523: Convert imagecopy.py to requests.

There are also requests and urllib3 workarounds in pywikibot.comms.

Jan 7 2018, 2:24 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-Other-scripts, Pywikibot-core, Pywikibot-network
jayvdb added a comment to T130523: Convert imagecopy.py to requests.

It is always required to use pywikibot.comms , because those 'features' are described in our documentation, and it is messy to need to document that the features only work sometimes.

Jan 7 2018, 2:22 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-Other-scripts, Pywikibot-core, Pywikibot-network
jayvdb reassigned T130523: Convert imagecopy.py to requests from jayvdb to rafidaslam.
Jan 7 2018, 2:19 AM · Patch-For-Review, Google-Code-in-2017, Pywikibot-Other-scripts, Pywikibot-core, Pywikibot-network

Jan 6 2018

jayvdb moved T179905: Make Change-Id optional from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.
Jan 6 2018, 5:28 PM · Patch-For-Review, Google-Code-in-2017, commit-message-validator
jayvdb added a comment to T179905: Make Change-Id optional.

Imported as https://codein.withgoogle.com/dashboard/tasks/4929536800063488/

Jan 6 2018, 5:28 PM · Patch-For-Review, Google-Code-in-2017, commit-message-validator
jayvdb added a comment to T179905: Make Change-Id optional.

There will be no impact on how this tool is installed in Gerrit.

Jan 6 2018, 5:22 PM · Patch-For-Review, Google-Code-in-2017, commit-message-validator
jayvdb added a comment to T179905: Make Change-Id optional.

@Paladox , this isnt about Gerrit. Please read first.

Jan 6 2018, 5:17 PM · Patch-For-Review, Google-Code-in-2017, commit-message-validator
jayvdb updated the task description for T179905: Make Change-Id optional.
Jan 6 2018, 5:14 PM · Patch-For-Review, Google-Code-in-2017, commit-message-validator
jayvdb added a project to T179905: Make Change-Id optional: Google-Code-in-2017.
Jan 6 2018, 5:13 PM · Patch-For-Review, Google-Code-in-2017, commit-message-validator
jayvdb added a comment to T179225: Convert MediaWiki templates on Commons to make them translateable.

I've added myself and @MtDu as mentors.

Jan 6 2018, 3:58 PM · Commons, Google-Code-in-2017
jayvdb updated the task description for T179225: Convert MediaWiki templates on Commons to make them translateable.
Jan 6 2018, 3:57 PM · Commons, Google-Code-in-2017
jayvdb moved T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.
Jan 6 2018, 3:55 PM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb added a comment to T104109: No syntax highlight for large JavaScript/CSS/Lua/API pages.

The suggested limit on https://gerrit.wikimedia.org/r/#/c/223053/2/SyntaxHighlight_GeSHi.class.php was 2000 kb.
Could you try similar JS file of that size?

Jan 6 2018, 4:13 AM · User-notice, JavaScript, SyntaxHighlight, Regression
jayvdb added a project to T76833: Gracefully fallback on older Wikibase API versions: TestMe.

@Pietrodn would be better at answering that , as they were using an older version of Wikibase.
I believe we dont have good wikibase version detection, which would be the ideal solution, but we may have hit the goal here.
We probably dont have support for wbeditentity on older Wikibase.

Jan 6 2018, 12:18 AM · TestMe, Pywikibot-Wikidata

Jan 5 2018

jayvdb closed T183908: textlib_tests.TestCategoryRearrangement.test_in_place_replace() failes for some jobs as Resolved.
Jan 5 2018, 3:34 AM · Patch-For-Review, Pywikibot-tests, Pywikibot-textlib.py, Pywikibot-core

Jan 4 2018

jayvdb created T184222: ndashredir timeout.
Jan 4 2018, 11:53 PM · Pywikibot-Other-scripts, Pywikibot-tests
jayvdb closed T184164: `flake8 --doctest` command on jenkins pywikibot-core-tox-docker raised an exception as Resolved.
Jan 4 2018, 10:44 AM · Patch-For-Review, Pywikibot-core, Pywikibot-tests
jayvdb closed T178138: Update flake8-docstrings version and remove pydocstyle version restriction from tox.ini as Resolved.
Jan 4 2018, 10:44 AM · Patch-For-Review, Upstream, Pywikibot-core
jayvdb added a comment to T178138: Update flake8-docstrings version and remove pydocstyle version restriction from tox.ini.

c.f. https://github.com/PyCQA/pydocstyle/pull/227 - this __all__ problem shouldnt exist in pydocstyle. (I'm still investigating, and this doesnt impact the current CR)

Jan 4 2018, 9:29 AM · Patch-For-Review, Upstream, Pywikibot-core
jayvdb added a comment to T178138: Update flake8-docstrings version and remove pydocstyle version restriction from tox.ini.

Note that this change is removing the existing, working, __all__ checking. It likely brings in new features and bugs fixes, so probably is worth that, but then we need to get __all__ checking working again.

Jan 4 2018, 9:06 AM · Patch-For-Review, Upstream, Pywikibot-core
jayvdb added a comment to T183663: Improve the maintenance script that download Wikimedia database dump.

No more tasks for this script should be created, as it currently untested, and mostly untestable by design.
It is not acceptable to be having students doing tasks which are not tested. The result is low quality work, and a poor educational experience for the students.
We should be increasing test coverage, not decreasing it.

Jan 4 2018, 4:11 AM · Pywikibot-Other-scripts, Pywikibot-core
jayvdb moved T100521: [clonable] APISite and DataSite method docstrings should include a link to the corresponding mw:API help from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.
Jan 4 2018, 4:04 AM · Google-Code-in-2017, Pywikibot-core, Google-Code-In-2015, Documentation, Easy, Pywikibot-Documentation
jayvdb moved T184115: Pywikibot: Add missing docstring params from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.
Jan 4 2018, 4:04 AM · Pywikibot-core, Google-Code-in-2017, Documentation, Pywikibot-Documentation
jayvdb added a comment to T100521: [clonable] APISite and DataSite method docstrings should include a link to the corresponding mw:API help.

Added to 2017 GCI https://codein.withgoogle.com/dashboard/tasks/6029008296738816/

Jan 4 2018, 4:03 AM · Google-Code-in-2017, Pywikibot-core, Google-Code-In-2015, Documentation, Easy, Pywikibot-Documentation
jayvdb updated the task description for T100521: [clonable] APISite and DataSite method docstrings should include a link to the corresponding mw:API help.
Jan 4 2018, 3:59 AM · Google-Code-in-2017, Pywikibot-core, Google-Code-In-2015, Documentation, Easy, Pywikibot-Documentation
jayvdb updated the task description for T100521: [clonable] APISite and DataSite method docstrings should include a link to the corresponding mw:API help.
Jan 4 2018, 3:59 AM · Google-Code-in-2017, Pywikibot-core, Google-Code-In-2015, Documentation, Easy, Pywikibot-Documentation
jayvdb added a comment to T100521: [clonable] APISite and DataSite method docstrings should include a link to the corresponding mw:API help.

Here is the GCI 2015 task : https://codein.withgoogle.com/archive/2015/organization/4822184463695872/task/5953614677803008/

Jan 4 2018, 3:59 AM · Google-Code-in-2017, Pywikibot-core, Google-Code-In-2015, Documentation, Easy, Pywikibot-Documentation
jayvdb added a project to T100521: [clonable] APISite and DataSite method docstrings should include a link to the corresponding mw:API help: Google-Code-in-2017.
Jan 4 2018, 3:58 AM · Google-Code-in-2017, Pywikibot-core, Google-Code-In-2015, Documentation, Easy, Pywikibot-Documentation
jayvdb added a comment to T184131: TestFactoryGeneratorWikibase.test_searchitem_language is failing in Travis.

Try cleaning your cache (see maintenance script) or just delete tests/apicache*, to check whether you can reproduce locally.

Jan 4 2018, 3:55 AM · Patch-For-Review, Pywikibot-tests, Pywikibot-core

Jan 3 2018

jayvdb added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

The first set to do would be TestItemBasePageMethods , as there are other BasePageMethods tests in other parts of the system, making this an interesting way to get basic coverage of a lot of modules/classes quickly, and hopefully easily.

Jan 3 2018, 8:27 PM · Patch-For-Review, Google-Code-in-2017, Pywikibot-core
jayvdb added a comment to T184115: Pywikibot: Add missing docstring params.

Pywikibot docstring params use epytext format.

Jan 3 2018, 7:51 PM · Pywikibot-core, Google-Code-in-2017, Documentation, Pywikibot-Documentation
jayvdb added a project to T184115: Pywikibot: Add missing docstring params: Google-Code-in-2017.
Jan 3 2018, 7:49 PM · Pywikibot-core, Google-Code-in-2017, Documentation, Pywikibot-Documentation
jayvdb added a comment to T184115: Pywikibot: Add missing docstring params.

This was already created as https://codein.withgoogle.com/dashboard/tasks/6189366353330176/ ; I am just creating a Phab task for it.
All commits should reference this Phab task

Jan 3 2018, 7:49 PM · Pywikibot-core, Google-Code-in-2017, Documentation, Pywikibot-Documentation
jayvdb created T184115: Pywikibot: Add missing docstring params.
Jan 3 2018, 7:47 PM · Pywikibot-core, Google-Code-in-2017, Documentation, Pywikibot-Documentation
jayvdb awarded T183864: diff-checker should verify that copyright comments of edited files are still year-updated a Dislike token.
Jan 3 2018, 7:36 PM · Software-Licensing, Patch-For-Review, Pywikibot-tests, Pywikibot-core
jayvdb added a comment to T183864: diff-checker should verify that copyright comments of edited files are still year-updated.

Agree, it is a waste of time to be updating this, as git log has better information if it is needed.

Jan 3 2018, 7:36 PM · Software-Licensing, Patch-For-Review, Pywikibot-tests, Pywikibot-core
jayvdb closed T109119: Check the style of the commit message as Resolved.

@Legoktm , @hashar , I guess this task can be closed. It was originally a pywikibot task, but it grew big legs and achieved many things. Re-open if I am mistaken.

Jan 3 2018, 8:44 AM · Patch-For-Review, commit-message-validator, Continuous-Integration-Config, Pywikibot-core
jayvdb updated subscribers of T184033: download_dump.py: Move the file location from `scripts/maintenance` to `scripts`.
Jan 3 2018, 8:32 AM · Patch-For-Review, Pywikibot-Other-scripts, Pywikibot-core
jayvdb added a comment to T184033: download_dump.py: Move the file location from `scripts/maintenance` to `scripts`.

This was done at my request during code review because this script wasnt being tested with tests/script_tests.py which it should be.

Jan 3 2018, 8:31 AM · Patch-For-Review, Pywikibot-Other-scripts, Pywikibot-core

Jan 1 2018

jayvdb added a project to T114483: Support ignoring the line attribute when attribute "line" set to "off" (or 0): TestMe.

Specifically testme whether line=off, line=false, line=disabled or some other reasonable boolean like value is possible.
IMO line=0 is not a good option.

Jan 1 2018, 1:41 PM · SyntaxHighlight
jayvdb added a project to T104109: No syntax highlight for large JavaScript/CSS/Lua/API pages: TestMe.
Jan 1 2018, 1:19 PM · User-notice, JavaScript, SyntaxHighlight, Regression
jayvdb added a comment to T183789: download_dump.py: Support for "date specified" dumps.

Hmm, I also a bit doubt of that, since I can't test it in toolforge.

Jan 1 2018, 1:09 PM · Patch-For-Review, Pywikibot-Other-scripts, Pywikibot-core

Dec 28 2017

jayvdb added a comment to T104109: No syntax highlight for large JavaScript/CSS/Lua/API pages.

@ori created https://people.wikimedia.org/~ori/bad.js as a test case, and 'Python' failed badly (likely Pygments with all of its regexes, but maybe one of its dependencies). That is an Upstream failure. See his comment on https://gerrit.wikimedia.org/r/#/c/223053/ . But that was two years ago. Perhaps this should be retested, and a bug files Upstream if there still a problem.

Dec 28 2017, 6:00 AM · User-notice, JavaScript, SyntaxHighlight, Regression
jayvdb added a comment to T114483: Support ignoring the line attribute when attribute "line" set to "off" (or 0).

The entire problem space has moved, as Wikimedia now uses Pygments. @Oetterer , are you still using the syntax highlighter that uses GeSHi ?

Dec 28 2017, 5:52 AM · SyntaxHighlight
jayvdb updated the task description for T182766: Create a Wikidata fact about a Google Code-in organisation or project.
Dec 28 2017, 4:54 AM · Wikidata, Google-Code-in-2017
jayvdb added a comment to T179202: Create Phabricator backend for python-social-auth.

@divadsn , you have three commits on https://github.com/python-social-auth/social-core/pull/169/commits ; that is unnecessary , and in gerrit world it would be considered messy work. Please squash them.

Dec 28 2017, 3:08 AM · Google-Code-in-2017, Phabricator

Dec 27 2017

jayvdb added a comment to T179202: Create Phabricator backend for python-social-auth.

Repeating some of what I put into the code review of https://github.com/python-social-auth/social-core/pull/169

Dec 27 2017, 4:06 AM · Google-Code-in-2017, Phabricator

Dec 26 2017

jayvdb added a comment to T179202: Create Phabricator backend for python-social-auth.

Looking good so far. The most recent PRs included a unit test module.

Dec 26 2017, 3:00 PM · Google-Code-in-2017, Phabricator
jayvdb added a comment to T183698: phab.wmflabs.org: Unhandled Exception: setConsumerKey() is required!.

Nope removing mediawiki auth will fix it, but will also prevent showing the other login form.

Dec 26 2017, 2:37 PM · VPS-project-Phabricator
jayvdb updated the task description for T179202: Create Phabricator backend for python-social-auth.
Dec 26 2017, 1:46 PM · Google-Code-in-2017, Phabricator
jayvdb updated the task description for T179202: Create Phabricator backend for python-social-auth.
Dec 26 2017, 1:46 PM · Google-Code-in-2017, Phabricator
jayvdb added a comment to T183698: phab.wmflabs.org: Unhandled Exception: setConsumerKey() is required!.

Can we add some CSS to hide the MediaWiki auth?

Dec 26 2017, 1:19 PM · VPS-project-Phabricator
jayvdb created T183698: phab.wmflabs.org: Unhandled Exception: setConsumerKey() is required!.
Dec 26 2017, 12:49 PM · VPS-project-Phabricator
jayvdb added a comment to T179202: Create Phabricator backend for python-social-auth.

First challenge is getting a test instance of Phabricator up.
https://secure.phabricator.com/ says NOTE: You can launch a test installation of Phabricator on Phacility if you want to poke around and try things out.

Dec 26 2017, 12:10 PM · Google-Code-in-2017, Phabricator