User Details
User Details
- User Since
- Dec 10 2016, 5:50 AM (290 w, 4 d)
- Availability
- Available
- IRC Nick
- jo12bar
- LDAP User
- Unknown
- MediaWiki User
- Jo12bar [ Global Accounts ]
Feb 5 2017
Feb 5 2017
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
One concern I do have: with my current solution, only one column of boxes is shown at fairly standard desktop screen sizes (anything under 1109px in width). However, there is still a very large gap on the side of that column, so that it looks like another column should fit there:
Feb 4 2017
Feb 4 2017
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
Thanks @hoo - guess I had a brain-fart ;)
Jan 27 2017
Jan 27 2017
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
Hey @Lucie, could you maybe send me the exact config in LocalSettings.php that you use when testing? I've followed the instructions at https://www.mediawiki.org/wiki/Wikibase/Installation to the letter, and even implemented a change mentioned in this comment on this issue in the WikibaseImport repo, but I am still unable to succesfully import an entity and have ArticlePlaceholder see it. Here's some of the issues I'm having:
Jan 23 2017
Jan 23 2017
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
Alright, thanks for the tip. I'll definitely look into using that extension - guess I didn't do enough research 😅
Jan 16 2017
Jan 16 2017
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
Is there any way that I can get a copy of wikidata.org, or (even better) connect the Wikibase Client to wikidata.org for testing purposes?
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
Well, magically it's now working! Thanks @Florian! Now I can actually work on the CSS for this - should be a patch on Gerrit in a few hours.
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
*face palm*
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
I keep running into this error after installing ArticlePlaceholder:
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
I keep running into this error after installing ArticlePlaceholder:
jo12bar added a comment to T154238: TypeError: result.isFulfilled is not a function in html-metadata.
As seen on the issue and as disscussed with @Mvolz, I wasn't able to find any issues even after extensive testing. Should I go ahead and close this issue as invalid?
Google-Code-In-2016 is pretty much done, but I wasn't able to finish this task before the deadline (I need to sleep!). If it's alright with everyone, I'll keep working on this - vagrant roles were just giving me a lot of issues. Going to try installing ArticlePlaceholder's dependencies manually.
Jan 13 2017
Jan 13 2017
jo12bar added a comment to T149193: Boxes act weird if the external id section is small.
I'll take a look at this 😁
Jan 7 2017
Jan 7 2017
Claimed for Google-Code-In-2016 😁
Dec 30 2016
Dec 30 2016
jo12bar added a comment to T149346: Replace Linker::link() usage with LinkRenderer in MediaWiki extensions.
Started work on extension VisualEditor
Dec 30 2016, 10:52 PM · MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Patch-For-Review, Google-Code-In-2016, Technical-Debt
jo12bar updated the task description for T149346: Replace Linker::link() usage with LinkRenderer in MediaWiki extensions.
Dec 30 2016, 10:51 PM · MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Patch-For-Review, Google-Code-In-2016, Technical-Debt
Dec 26 2016
Dec 26 2016
Claimed as part of Google Code-In 2016 :)
Dec 14 2016
Dec 14 2016
jo12bar added a comment to T124994: Vector should make use of deviceWidthTablet Less variable.
Thanks!
jo12bar added a comment to T124994: Vector should make use of deviceWidthTablet Less variable.
Just a heads up: I'm flying down to Mexico for a family vacation within the next two hours, and I probably won't have WiFi. As a result, I'll probably be unable to work on this bug until Christmas Day. Sorry about that. If I happen to find a WiFi hotspot, then I'll definitely check in, but otherwise I'll see you on the 25th!
Dec 13 2016
Dec 13 2016
jo12bar added a comment to T124994: Vector should make use of deviceWidthTablet Less variable.
Alright, I just squashed both of those reviews into the original code review. Sorry that I submitted multiple reviews - I guess I'm too used to the GitHub workflow!
jo12bar added a comment to T124994: Vector should make use of deviceWidthTablet Less variable.
Should be fixed :)
Dec 12 2016
Dec 12 2016
jo12bar added a comment to T124994: Vector should make use of deviceWidthTablet Less variable.
Alright, I'll switch it to an array when I get home from school - probably after 5:00pm.
Volker_E awarded T124994: Vector should make use of deviceWidthTablet Less variable a Like token.
jo12bar added a comment to T124994: Vector should make use of deviceWidthTablet Less variable.
Alright, I've got an issue. I took this block in skin.json:
// ... "skins.vector.styles.responsive": { "targets": [ "desktop", "mobile" ], "position": "top", "styles": { "responsive.less": { "media": "screen and (max-width: 768px)" } } }, // ...
... and replaced it with this:
// ... "skins.vector.styles.responsive": { "targets": [ "desktop", "mobile" ], "position": "top", "styles": { "responsive.less": { "media": "screen and (max-width: @deviceWidthTablet)" } } }, // ...
However, this made it so that responsive.less wasn't being loaded at all. It doesn't throw any errors in the logs as far as I can see. However, it works properly if I just leave the media query in skin.json blank, like:
"media": {}
... And manually add the media query to responsive.less, like:
/* The styles below essentially place the navigation menu below the content, instead of to the side of it. They also hide the logo, as there's no space left for it. */ @media screen and (max-width: @deviceWidthTablet){ div#mw-head { position: static !important; /* stylelint-disable-line declaration-no-important */ margin-top: 0.5em; } // ...
This feels really dirty though. Because it completely bypasses ResourceLoader. I'm not sure what's causing this. Should I just go ahead with this approach?
Claimed as part of Google Code-In 2016 :)