Page MenuHomePhabricator

jrchamp (Jonathan Champ)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 17 2016, 3:41 AM (234 w, 3 d)
Availability
Available
LDAP User
Jrchamp
MediaWiki User
Unknown

Recent Activity

Nov 11 2019

jrchamp closed T237725: Auth_remoteuser extension causes TypeError when running maintenance tasks as Resolved.

Thank you @Claashk - this was just the push I needed to learn more about the gerrit workflow.

Nov 11 2019, 10:53 PM · MediaWiki-extensions-Auth_remoteuser

Nov 8 2019

jrchamp added a comment to T237725: Auth_remoteuser extension causes TypeError when running maintenance tasks.

That bug was fixed by in April 2019: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Auth_remoteuser/+/1436b981d6ff721cb7e0072cf32779d56ce03f45%5E%21/

Nov 8 2019, 7:02 PM · MediaWiki-extensions-Auth_remoteuser

Apr 12 2019

jrchamp added a comment to T220478: Metadata may be `null`.

The change has been merged. It's not letting me cherry-pick through gerrit (complains about a merge conflict). It seems like this fix would needed to be applied to REL1_32 also, right? Which release of Mediawiki added the array type check?

Apr 12 2019, 2:26 PM · MediaWiki-extensions-Auth_remoteuser

Jul 18 2018

jrchamp added a comment to T198928: First Save bug (2018).

That's great to hear! Thank you for testing the change.

Jul 18 2018, 6:24 PM · Patch-For-Review, User-Tgr, MediaWiki-extensions-Auth_remoteuser

Jul 12 2018

jrchamp added a comment to T198928: First Save bug (2018).

I'm not sure if this is the problem, but would you be willing to try moving the wfLoadExtension call to the end. In @Ninopul's example, this would look more like:

$wgGroupPermissions['*']['createaccount'] = false;
$wgGroupPermissions['*']['autocreateaccount'] = true;
$wgAuthRemoteuserUserName = 'User005';
wfLoadExtension( 'Auth_remoteuser' );
Jul 12 2018, 7:05 PM · Patch-For-Review, User-Tgr, MediaWiki-extensions-Auth_remoteuser

Apr 7 2018

jrchamp added a comment to T188193: update namespace.

@Enst80 Now that those tasks are all closed, do you want to release another version?

Apr 7 2018, 2:26 AM · Patch-For-Review, MediaWiki-extensions-Auth_remoteuser

Mar 25 2018

jrchamp added a comment to T188195: array union operator `+=` does not work as intended.

@Enst80 Understood. I uploaded a new patch set to provide an example of how it might be simpler. I hope you like it!

Mar 25 2018, 8:25 PM · Patch-For-Review, MediaWiki-extensions-Auth_remoteuser

Feb 27 2018

jrchamp added a comment to T185391: Run hook `UserLoggedIn`.

Is this commit in Gerrit somewhere?

Feb 27 2018, 11:26 PM · Patch-For-Review, MediaWiki-extensions-Auth_remoteuser
jrchamp added a comment to T188195: array union operator `+=` does not work as intended.

Another option is to use the Special Page name as the array key and boolean true as the value. That would allow the use of the union operator without incurring duplicates. The foreach would need to be modified to match:

foreach ( $disableSpecialPages as $page => $disable )
Feb 27 2018, 11:17 PM · Patch-For-Review, MediaWiki-extensions-Auth_remoteuser

Jun 12 2017

jrchamp added a comment to T167615: Auth_remoteuser breaks google custom search.

Seems like a simple fix and it will address the specific issue. Nice find!

Jun 12 2017, 4:51 PM · MediaWiki-extensions-Auth_remoteuser

Apr 18 2017

jrchamp added a watcher for MediaWiki-extensions-Auth_remoteuser: jrchamp.
Apr 18 2017, 5:29 PM
jrchamp added a member for MediaWiki-extensions-Auth_remoteuser: jrchamp.
Apr 18 2017, 5:26 PM

Apr 16 2017

jrchamp added a comment to T110292: Update Auth_remoteuser to use AuthManager.

Hooray! Thank you both for making this milestone possible.

Apr 16 2017, 7:30 PM · Product-Infrastructure-Team-Backlog, MediaWiki-extensions-Auth_remoteuser, Patch-For-Review, MediaWiki-Authentication-and-authorization

Mar 7 2017

jrchamp assigned T110292: Update Auth_remoteuser to use AuthManager to Enst80.

Stefan has done an amazing job with this. If anyone knows how we can get this change merged, please respond. Thank you.

Mar 7 2017, 3:42 PM · Product-Infrastructure-Team-Backlog, MediaWiki-extensions-Auth_remoteuser, Patch-For-Review, MediaWiki-Authentication-and-authorization