Page MenuHomePhabricator

jsn.sherman
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2017, 7:18 PM (250 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jsn.sherman [ Global Accounts ]

Recent Activity

Fri, Dec 3

jsn.sherman moved T296900: Upgrade last partner pages to Bootstrap 4 from Review to Done on the The-Wikipedia-Library (Kanban) board.

Merged, thanks!

Fri, Dec 3, 8:06 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T296660: Add the safety translation strings to Extension:WikimediaMessages from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.

Okay, I:

  • added the privacy policy message
  • updated the question message
  • reanamed all of the existing keys for this survey in all locales to align with T296486. This rename will avoid invalidating the translation work that's already been done. This makes it quite a bit bigger change than it would otherwise be
Fri, Dec 3, 7:38 PM · Patch-For-Review, WMF-Safety-Survey, Trust and Safety Tools Team Backlog (Kanban)
jsn.sherman changed the status of T296660: Add the safety translation strings to Extension:WikimediaMessages from Stalled to Open.

Thank you 🙏 , very helpful!

Fri, Dec 3, 7:17 PM · Patch-For-Review, WMF-Safety-Survey, Trust and Safety Tools Team Backlog (Kanban)
jsn.sherman changed the status of T296660: Add the safety translation strings to Extension:WikimediaMessages, a subtask of T296486: Draft configuration of test survey before the deploy, from Stalled to Open.
Fri, Dec 3, 7:17 PM · Trust and Safety Tools Team Backlog (Kanban), Patch-For-Review, WMF-Safety-Survey
jsn.sherman changed the status of T296660: Add the safety translation strings to Extension:WikimediaMessages, a subtask of T296936: Upload Catalan and Farsi translations of the safety survey labels, from Stalled to Open.
Fri, Dec 3, 7:17 PM · WMF-Safety-Survey, Trust and Safety Tools Team Backlog
jsn.sherman moved T262164: Fix 'accounts available' not being displayed on some applications from Review to Done on the The-Wikipedia-Library (Kanban) board.

merged; thanks!

Fri, Dec 3, 7:02 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman changed the status of T296660: Add the safety translation strings to Extension:WikimediaMessages, a subtask of T296486: Draft configuration of test survey before the deploy, from Open to Stalled.
Fri, Dec 3, 6:00 PM · Trust and Safety Tools Team Backlog (Kanban), Patch-For-Review, WMF-Safety-Survey
jsn.sherman changed the status of T296660: Add the safety translation strings to Extension:WikimediaMessages, a subtask of T296936: Upload Catalan and Farsi translations of the safety survey labels, from Open to Stalled.
Fri, Dec 3, 6:00 PM · WMF-Safety-Survey, Trust and Safety Tools Team Backlog
jsn.sherman changed the status of T296660: Add the safety translation strings to Extension:WikimediaMessages from Open to Stalled.
Fri, Dec 3, 6:00 PM · Patch-For-Review, WMF-Safety-Survey, Trust and Safety Tools Team Backlog (Kanban)
jsn.sherman added a comment to T296660: Add the safety translation strings to Extension:WikimediaMessages.

@Jhernandez the existing en message ext-quicksurveys-tst-internal-survey-question uses the template variable {{SITENAME}}, but the strings listed in T296488 use literal text for the site name. The messages should be consistent in terms of variable use across locales. Which way should it be: literal or variable?

Fri, Dec 3, 5:59 PM · Patch-For-Review, WMF-Safety-Survey, Trust and Safety Tools Team Backlog (Kanban)
Jhernandez awarded T295681: [Bug] Weird answer selection on single-answer freeform survey [4H] a Doubloon token.
Fri, Dec 3, 5:29 PM · Patch-For-Review, Trust and Safety Tools Team Backlog (Kanban), WMF-Safety-Survey
jsn.sherman claimed T296660: Add the safety translation strings to Extension:WikimediaMessages.
Fri, Dec 3, 5:26 PM · Patch-For-Review, WMF-Safety-Survey, Trust and Safety Tools Team Backlog (Kanban)
jsn.sherman moved T295681: [Bug] Weird answer selection on single-answer freeform survey [4H] from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.
Fri, Dec 3, 3:42 PM · Patch-For-Review, Trust and Safety Tools Team Backlog (Kanban), WMF-Safety-Survey
jsn.sherman added a comment to T296991: Admin language list for partners should display languages in English.

My thoughts/technical context on this:
Right now the partner languages is using the same code as the user language selection, which only contains autonyms, which is the right choice for user settings. That means that we should leave that bit alone and split partner languages off to another method of localization, like the json files we use for tags, or maybe an existing django app. The localizations for all of our partner languages are well known, so IMO we should populate these ourselves instead of asking translatewiki volunteers to do so.

Fri, Dec 3, 2:26 PM · The-Wikipedia-Library, Library-Card-Platform

Thu, Dec 2

jsn.sherman added a comment to T295681: [Bug] Weird answer selection on single-answer freeform survey [4H].

it looks like all props for the button array are recomputed any time a descendant of the buttons container changes. shuffleAnswers() is part of that computation, so it's very clear why this is behaving the way it is.

Thu, Dec 2, 7:39 PM · Patch-For-Review, Trust and Safety Tools Team Backlog (Kanban), WMF-Safety-Survey
jsn.sherman moved T295681: [Bug] Weird answer selection on single-answer freeform survey [4H] from 🎬 Ready to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.
Thu, Dec 2, 6:58 PM · Patch-For-Review, Trust and Safety Tools Team Backlog (Kanban), WMF-Safety-Survey
jsn.sherman moved T296951: TheWikipediaLibrary extension should not log about missing extensions from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Thu, Dec 2, 5:05 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban)
jsn.sherman moved T296951: TheWikipediaLibrary extension should not log about missing extensions from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
Thu, Dec 2, 5:02 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban)
jsn.sherman created T296951: TheWikipediaLibrary extension should not log about missing extensions.
Thu, Dec 2, 5:02 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban)

Wed, Dec 1

jsn.sherman updated subscribers of T288070: Deploy The Wikipedia Library Echo notification with 50,000 edit count threshold.

@Reedy under your recommendation, we initially rolled this out to only meta and testwiki a few weeks back, where we got some great feedback that we have incorporated into the extension. We think we're ready to deploy to all projects pending the deployment of 1.38.0-wmf.12 across all groups. Given that your advice ahead of the last deployment was 100% on the nose, I thought I'd ask: does this seem reasonable?

Wed, Dec 1, 8:00 PM · Patch-For-Review, The-Wikipedia-Library (Kanban), Wikimedia-extension-review-queue, User-notice, Notifications
jsn.sherman moved T296762: Blank search_term requests should redirect to the homepage from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Wed, Dec 1, 7:01 PM · The-Wikipedia-Library (Kanban)
jsn.sherman claimed T296762: Blank search_term requests should redirect to the homepage.
Wed, Dec 1, 3:52 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T296761: Update secondary link destination directly to the library from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Wed, Dec 1, 3:51 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Notifications, Growth-Team
jsn.sherman moved T296761: Update secondary link destination directly to the library from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Dec 1, 3:43 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Notifications, Growth-Team
jsn.sherman added a comment to T296852: Show header searchbox in all possible views.

PR: https://github.com/WikipediaLibrary/TWLight/pull/898

Wed, Dec 1, 3:42 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T296852: Show header searchbox in all possible views from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Wed, Dec 1, 3:42 PM · The-Wikipedia-Library (Kanban)
jsn.sherman claimed T295681: [Bug] Weird answer selection on single-answer freeform survey [4H].
Wed, Dec 1, 3:38 PM · Patch-For-Review, Trust and Safety Tools Team Backlog (Kanban), WMF-Safety-Survey
jsn.sherman renamed T296852: Show header searchbox in all possible views from users.templatetags.twlight_perms.bundle_eligible() should accept a user in addition to an editor to Show header searchbox in all possible views.
Wed, Dec 1, 3:22 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T296852: Show header searchbox in all possible views from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Dec 1, 3:07 PM · The-Wikipedia-Library (Kanban)
jsn.sherman updated the task description for T296852: Show header searchbox in all possible views.
Wed, Dec 1, 3:07 PM · The-Wikipedia-Library (Kanban)
jsn.sherman created T296852: Show header searchbox in all possible views.
Wed, Dec 1, 3:07 PM · The-Wikipedia-Library (Kanban)

Tue, Nov 30

jsn.sherman added a comment to T296654: Grant Access to wmf for Jsn.sherman.

Thanks @herron!

Tue, Nov 30, 8:55 PM · SRE, LDAP-Access-Requests
jsn.sherman moved T291489: Coordinators should be able to assign new access codes from Review to Done on the The-Wikipedia-Library (Kanban) board.

Merged. We should backlog a task for tests.

Tue, Nov 30, 8:46 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T293984: Update Application list pages to Bootstrap 4 from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Tue, Nov 30, 8:43 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman added a comment to T293984: Update Application list pages to Bootstrap 4.

Update: the javascript update was due to a previously unnoticed dependency problem:

  • we're using multiple insecure EOL versions of jquery on this and other templates
  • django autocomplete light, which is used for application filtering, doesn't support the lastest version, which we're using in new_base.html
Tue, Nov 30, 3:05 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Mon, Nov 29

jsn.sherman moved T293985: Update application review page to Bootstrap 4 from Review to Done on the The-Wikipedia-Library (Kanban) board.

Merged!

Mon, Nov 29, 5:42 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T296223: Update sent applications page to Bootstrap 4 from Review to Done on the The-Wikipedia-Library (Kanban) board.

merged!

Mon, Nov 29, 5:27 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T262164: Fix 'accounts available' not being displayed on some applications from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Mon, Nov 29, 5:19 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman created T296654: Grant Access to wmf for Jsn.sherman.
Mon, Nov 29, 5:08 PM · SRE, LDAP-Access-Requests
jsn.sherman added a comment to T291489: Coordinators should be able to assign new access codes.

For my part, the code looks like a fine approach.

Mon, Nov 29, 1:51 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Fri, Nov 19

jsn.sherman added a comment to T293984: Update Application list pages to Bootstrap 4.

PR: https://github.com/WikipediaLibrary/TWLight/pull/891
It's in pretty good shape with one exception: when you click one of the filter boxes, it no longer automatically focuses on the searchable dropdown, requiring an extra click. DAL and bootstrap have a history of annoying bugs when combined, and I haven't resolved this one yet.

Fri, Nov 19, 8:44 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

Patch inbound. I was able to drop that primary link label, and everything looks happy. I tested in a few languages, and localization still works as expected.

Fri, Nov 19, 4:45 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

Okay, so is this what you're thinking?

image.png (404×785 px, 42 KB)

Fri, Nov 19, 3:46 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

Yep, we would use something like:
https://meta.wikimedia.org/wiki/Special:GoToInterwiki/google:foo

Fri, Nov 19, 3:37 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

If we wanted to switch to a standard icon as the primary, I think we could add our own for the secondary. I haven't tested that yet, though.
...
We can also use the icons provided by echo itself:
https://commons.wikimedia.org/wiki/Category:Notifications_extension_icons

Fri, Nov 19, 3:34 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

Realized I didn't answer one of your questions:

Fri, Nov 19, 2:38 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

Is this a problem for adding any new icon to the notification, or that icon specifically? I'm wondering if we can find something similar, if that would avoid this problem.

Fri, Nov 19, 2:23 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications

Thu, Nov 18

jsn.sherman claimed T293984: Update Application list pages to Bootstrap 4.
Thu, Nov 18, 7:49 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T293984: Update Application list pages to Bootstrap 4 from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
Thu, Nov 18, 7:48 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T295621: Add a secondary link to The Wikipedia Library notification from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Thu, Nov 18, 7:48 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295621: Add a secondary link to The Wikipedia Library notification.

I'm really glad @Legoktm mentioned the Interwiki map, as I think it looks like best way to handle this. We already have a special view on our platform for linked searches, and with a very small adjustment it could also handle this case very nicely.

Thu, Nov 18, 6:34 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman moved T293981: Update Suggest page to Bootstrap 4 from Review to Done on the The-Wikipedia-Library (Kanban) board.

merged!

Thu, Nov 18, 4:01 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman added a subtask for T288070: Deploy The Wikipedia Library Echo notification with 50,000 edit count threshold: T295621: Add a secondary link to The Wikipedia Library notification.
Thu, Nov 18, 3:43 PM · Patch-For-Review, The-Wikipedia-Library (Kanban), Wikimedia-extension-review-queue, User-notice, Notifications
jsn.sherman added a parent task for T295621: Add a secondary link to The Wikipedia Library notification: T288070: Deploy The Wikipedia Library Echo notification with 50,000 edit count threshold.
Thu, Nov 18, 3:43 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman moved T295484: Prevent spam from TheWikipediaLibrary extension from Review to Done on the The-Wikipedia-Library (Kanban) board.
Thu, Nov 18, 3:39 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman moved T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line from Review to Done on the The-Wikipedia-Library (Kanban) board.
Thu, Nov 18, 3:38 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error

Wed, Nov 17

jsn.sherman moved T293988: Update My Applications to Bootstrap 4 from Reviewed (waiting for changes) to Done on the The-Wikipedia-Library (Kanban) board.

Merged!

Wed, Nov 17, 10:53 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman claimed T295621: Add a secondary link to The Wikipedia Library notification.
Wed, Nov 17, 7:55 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
jsn.sherman added a comment to T295913: `/users/delete_data/` doesn't always delete data.

In this case the user account is found but not deleted. I would say they are both children of a not-yet-existent task for edge-case testing and cleanup of the delete data view.

Wed, Nov 17, 6:20 PM · The-Wikipedia-Library
jsn.sherman created T295913: `/users/delete_data/` doesn't always delete data.
Wed, Nov 17, 6:12 PM · The-Wikipedia-Library
jsn.sherman added a comment to T293982: Update user profile to Bootstrap 4.

FWIW, I did discover a bug with the delete data view, but it is not impacted by this upgrade; will add that to the backlog

Wed, Nov 17, 6:08 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T293982: Update user profile to Bootstrap 4 from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Wed, Nov 17, 6:04 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman placed T291487: Remove ability to apply for multiple collections up for grabs.

Unassigned due to lack of activity

Wed, Nov 17, 4:26 PM · The-Wikipedia-Library, Library-Card-Platform
jsn.sherman moved T293988: Update My Applications to Bootstrap 4 from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Wed, Nov 17, 4:13 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T293987: Update application request pages to Bootstrap 4 from Review to Done on the The-Wikipedia-Library (Kanban) board.

merged

Wed, Nov 17, 3:57 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Tue, Nov 16

jsn.sherman added a comment to T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .

All changes except that last one for system accounts made onto this week's train. I'm hoping we'll see the error rate drop with what we have.

Tue, Nov 16, 3:24 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman moved T295484: Prevent spam from TheWikipediaLibrary extension from In Progress to Review on the The-Wikipedia-Library (Kanban) board.

All spam-related changes made it to this week's wmf.9 train.
https://github.com/wikimedia/mediawiki-extensions-TheWikipediaLibrary/tree/wmf/1.38.0-wmf.9
Current versions tracked here:
https://versions.toolforge.org/
Deployment blockers tracked here:
T293950

Tue, Nov 16, 3:22 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman moved T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension from Review to Done on the The-Wikipedia-Library (Kanban) board.

Merged

Tue, Nov 16, 3:09 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman moved T295023: Fix My Library styling errors in Safari from Review to Done on the The-Wikipedia-Library (Kanban) board.

Merged!

Tue, Nov 16, 3:08 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .

ah, helpful. I even grepped for that, I just got the capitalization wrong. I should always set to case insensitive. Once again, I manually verified that this does not regress anything in mediawiki-vagrant just to be sure. Tiny patch inbound.

Tue, Nov 16, 1:09 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error

Mon, Nov 15

jsn.sherman moved T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Mon, Nov 15, 11:29 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman added a comment to T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .

Okay, between the stacktrace, the poc patch, and the discussion here, this is what I have in Change 739019 so far:

  • I've excluded members of bot as suggested by @Urbanecm. isSystemAccount() doesn't seem to be an available method, so maybe it used to be a thing that's now gone?
    • I manually tested in wikimedia-vagrant to verify that this works as expected. Bot accounts don't get global preferences fiddled with nor do they get notifications.
  • I also added in a guard clause to the preference helper to check for a wikipage attached to the RequestContext before attempting to set a preference. The preference factory needs a page reference, and based on a quick perusal of the source, this looks like a handy way to exclude some requests that won't have it. I manually tested and verified that this doesn't create any problems in our use cases.
  • I don't have unit tests for these changes written because I haven't come up a good unit test scenario for the error yet.
Mon, Nov 15, 11:18 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman added a comment to T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension.

tests added

Mon, Nov 15, 8:00 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman moved T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Mon, Nov 15, 7:59 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)

Sat, Nov 13

jsn.sherman added a comment to T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .

This is really great context. Thank you very much! 🙏

Sat, Nov 13, 1:47 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error

Fri, Nov 12

jsn.sherman added a comment to T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension.

This really warrants tests of its own before I ask for review

Fri, Nov 12, 9:28 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman moved T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension from Review to In Progress on the The-Wikipedia-Library (Kanban) board.
Fri, Nov 12, 9:28 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .

Update:
I've been unable to reproduce this error in mediawiki vagrant, but it looks to me like the context we're passing into setGlobalPreferences() isn't what's expected.
Right now we're just grabbing RequestContext::getMain() because that's what other examples we found were using and it works in the cases we tested.
The documentation for RequestContext says we should be only do this as a last resort, so I've been looking for other ways to pass the context to the preferences factory.

Fri, Nov 12, 9:22 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman added a subtask for T295484: Prevent spam from TheWikipediaLibrary extension: T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .
Fri, Nov 12, 9:05 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a parent task for T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line : T295484: Prevent spam from TheWikipediaLibrary extension.
Fri, Nov 12, 9:05 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman moved T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension from Ready to Review on the The-Wikipedia-Library (Kanban) board.
Fri, Nov 12, 9:03 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman added a subtask for T295484: Prevent spam from TheWikipediaLibrary extension: T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension.
Fri, Nov 12, 8:58 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a parent task for T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension: T295484: Prevent spam from TheWikipediaLibrary extension.
Fri, Nov 12, 8:58 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman created T295623: Check local Echo notification for duplicates in TheWikipediaLibrary extension.
Fri, Nov 12, 8:58 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

Update: I've ruled out null edits and renames as a potential source of the problem

Fri, Nov 12, 7:04 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman claimed T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line .
Fri, Nov 12, 2:39 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman moved T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
Fri, Nov 12, 2:18 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error

Thu, Nov 11

jsn.sherman edited projects for T295543: TypeError: Argument 2 passed to Parser::preSaveTransform() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.38.0-wmf.7/includes/preferences/DefaultPreferencesFactory.php on line , added: The-Wikipedia-Library (Kanban); removed The-Wikipedia-Library.

Thanks for bringing this to my attention. I'm out today, but wanted to acknowledge seeing this. I'll be taking a look at our global preferences helper first thing tomorrow.

Thu, Nov 11, 1:14 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), WMF-JobQueue, The-Wikipedia-Library (Kanban), MediaWiki-extensions-GlobalPreferences, Wikimedia-production-error
jsn.sherman added a comment to T294919: Create a URL which initiates a library search.

I believe the issue is resolved.

Thu, Nov 11, 2:05 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman added a comment to T294919: Create a URL which initiates a library search.

@Mathglot this is really good feedback. I have a hotfix building now. It should be deployed in ~30 - 40 minutes.

Thu, Nov 11, 1:25 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Wed, Nov 10

jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

Update: I'm rebuilding my mediawiki-vagrant environment to get it working with the Renameuser extension that the global renames depend upon. I'm probably going to spend the last bit of today on getting this configured properly, and tomorrow is a holiday, so this may sit until Friday.

Wed, Nov 10, 8:36 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman moved T295484: Prevent spam from TheWikipediaLibrary extension from Review to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Nov 10, 7:30 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

Useful! I think the patch that just got merged is going to help, but I don't believe we are at the bottom of it yet. I'm trying to reproduce this locally either with global renames or some other method in which a single user action triggers multiple edits.

Wed, Nov 10, 7:29 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman moved T295484: Prevent spam from TheWikipediaLibrary extension from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Wed, Nov 10, 5:41 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

I've been testing this in my local vagrant environment by lining up multiple narrow edit windows in a row and clicking submit on all of them as quickly as possible. I've been able to submit about 4 in the same second and haven't been able to reproduce duplicate notifications. This is looking like a race condition, and I have a straightforward patch underway to hopefully prevent such a situation. The only cost will be upping the edits required to trigger post install from 1-2 to 2-3.

Wed, Nov 10, 5:14 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman moved T295484: Prevent spam from TheWikipediaLibrary extension from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Nov 10, 4:39 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

If the notifications all came at about the same time, I'd suspect this is a different issue than what we were seeing before. If they were spread out over the hour, then I suspect it's part of the original problem.

Wed, Nov 10, 4:24 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

They jumped out at me because it was 8 edits with identical timestamps. It would be useful to see the time listed on those notifications, eg. the 'x minutes ago' plus the time viewed so we could tried to get a rough correlation.

Wed, Nov 10, 4:22 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

I think this is what caused those 8 notifications:

Wed, Nov 10, 4:12 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications
jsn.sherman added a comment to T295484: Prevent spam from TheWikipediaLibrary extension.

I noticed there are groups of contributions all with the same timestamp. I'm wondering if they are all having a race to flag the notification as sent for the user. Are they using some kind of automation to make these changes or just doing things in rapid succession in the browser?

Wed, Nov 10, 4:09 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), The-Wikipedia-Library (Kanban), Notifications