Page MenuHomePhabricator

jsn.sherman
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2017, 7:18 PM (192 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jsn.sherman [ Global Accounts ]

Recent Activity

Mon, Oct 26

jsn.sherman added a comment to T264999: Fix resources.Partner.None message when returning an authorization.

Merged. Thanks for your contribution!

Mon, Oct 26, 1:24 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
jsn.sherman moved T264999: Fix resources.Partner.None message when returning an authorization from Review to Done on the The-Wikipedia-Library (Kanban) board.
Mon, Oct 26, 1:04 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Okay, code merged. Leaving this in review so that we can keep an eye on the impact over some period of time. We should probably be checking in on this over the course of a month or more.

Mon, Oct 26, 12:48 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Fri, Oct 23

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

https://github.com/WikipediaLibrary/TWLight/pull/550 is ready to have eyes on it.

Fri, Oct 23, 4:11 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman moved T265146: Recent edit count isn't updating correctly for a user from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 23, 4:11 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman moved T265146: Recent edit count isn't updating correctly for a user from Review to In Progress on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 23, 3:38 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Actually, still have some more test cleanup to do.

Fri, Oct 23, 3:38 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Sure enough, the issue was ultimately in the logic for editor_recent edits, but the management command also had its issue. I'm going request reviews on this pr just to make sure we don't introduce any other problems.

Fri, Oct 23, 3:29 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman moved T265146: Recent edit count isn't updating correctly for a user from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 23, 3:26 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Thu, Oct 22

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

I'm on the right path to a fix, but not quite there yet.

Thu, Oct 22, 5:01 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

I have confirmed via testing that the management command incorrectly updates currently eligible editors even if they have been updated within the last 30 days. We never do this on purpose, but it happens because of the double runs of those cron tasks. This is extremely fixable with a few additional guard clauses.

Thu, Oct 22, 3:37 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Wed, Oct 21

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

I can see that my tests that deal with the recent editcount part of eligibility are all written directly against the helper functions. The user_update_eligibility management command had incomplete capabilities to work with timestamps other than now(), which I've fleshed out. I should now be able to recreate the logic of one of the recent editcount helper function tests within a management command test. Ideally, I'll find some failures there.

Wed, Oct 21, 4:09 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Setting those thoughts aside, I've been looking at the management command and I think it's the most likely cause of issues.

Wed, Oct 21, 1:15 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Fri, Oct 16

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Look at my data above - if I wasn't bundle eligible then this editcount_delta would be comparing 09-22 to 09-02, when I'd expect to be looking back to 08-22.

Fri, Oct 16, 3:27 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

I've got this started:
https://github.com/WikipediaLibrary/TWLight/pull/550

Fri, Oct 16, 2:39 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

I think there is a very strong argument for that. I think the best place to start is commenting what's there, as that will help us make sure we don't overlook anything that needs to happen to keep this thing from breaking entirely.

Fri, Oct 16, 1:28 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Yeah, this code went through a lot of iteration to keep it relatively performant but also to keep it from cutting off access too soon.

Fri, Oct 16, 1:17 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

I would expect wp_editcount_recent to be the delta of current and recent editcounts, but it isn't.

Fri, Oct 16, 11:57 AM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Here's the complete bundle eligibility for that user on 2020-09-22

select wp_bundle_eligible,wp_account_old_enough,wp_enough_edits,wp_enough_recent_edits,wp_not_blocked,wp_editcount_recent, wp_editcount, wp_editcount_updated, wp_editcount_prev, wp_editcount_prev_updated from users_editor where wp_username = 'Mhardyvallee';
+--------------------+-----------------------+-----------------+------------------------+----------------+---------------------+--------------+----------------------------+-------------------+----------------------------+
| wp_bundle_eligible | wp_account_old_enough | wp_enough_edits | wp_enough_recent_edits | wp_not_blocked | wp_editcount_recent | wp_editcount | wp_editcount_updated       | wp_editcount_prev | wp_editcount_prev_updated  |
+--------------------+-----------------------+-----------------+------------------------+----------------+---------------------+--------------+----------------------------+-------------------+----------------------------+
|                  0 |                     1 |               1 |                      0 |              1 |                   7 |          508 | 2020-09-05 13:51:43.134854 |               508 | 2020-06-09 14:27:14.059435 |
+--------------------+-----------------------+-----------------+------------------------+----------------+---------------------+--------------+----------------------------+-------------------+----------------------------+
Fri, Oct 16, 11:36 AM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

The thing that really catches my eye with this user is that the previous count and the current count have been in lockstep in every backup checked so far.

Fri, Oct 16, 11:25 AM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

So the first question I have is why did it take until 2020-09-05 to update their data?

Fri, Oct 16, 11:08 AM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Tue, Oct 13

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

The backup from 2020-09-22 shows matching wp_editcount and wp_editcount_prev once again

select wp_editcount, wp_editcount_updated, wp_editcount_prev, wp_editcount_prev_updated from users_editor where wp_username = 'Mhardyvallee';
+--------------+----------------------------+-------------------+----------------------------+
| wp_editcount | wp_editcount_updated       | wp_editcount_prev | wp_editcount_prev_updated  |
+--------------+----------------------------+-------------------+----------------------------+
|          508 | 2020-09-05 13:51:43.134854 |               508 | 2020-06-09 14:27:14.059435 |
+--------------+----------------------------+-------------------+----------------------------+

We know that the value for wp_editcount_prev as of 2020-06-09 is incorrect based on the the global user contribution logs showing activity between 2020-09-05 and 2020-06-09. That should be a lower value.

Tue, Oct 13, 4:22 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265331: Fix not being able to save any resource objects.

Tests updated:
https://github.com/WikipediaLibrary/TWLight/commit/0b3b258a9bc2b7c73096717c977d0a3a6b1276ab

Tue, Oct 13, 4:14 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265331: Fix not being able to save any resource objects.

Need to update the test here too.

Tue, Oct 13, 4:05 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

And seeing that we had the cron job run twice on 2020-09-23, I'm actually gong to start with a backup from Sept 22.

Tue, Oct 13, 4:00 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

The october 6 backup ran before that evening's user eligibility cron, and Mhardyvallee is still eligible. However their previous editcount was already equal to their current editcount, which doesn't make sense:

select wp_editcount, wp_editcount_updated, wp_editcount_prev, wp_editcount_prev_updated from users_editor where wp_username = 'Mhardyvallee';
+--------------+----------------------------+-------------------+----------------------------+
| wp_editcount | wp_editcount_updated       | wp_editcount_prev | wp_editcount_prev_updated  |
+--------------+----------------------------+-------------------+----------------------------+
|          575 | 2020-10-05 19:55:03.535886 |               575 | 2020-09-05 13:51:43.134854 |
+--------------+----------------------------+-------------------+----------------------------+

I added up all their per-project contributions visible here:
https://meta.wikimedia.org/w/api.php?action=query&meta=globaluserinfo&guiuser=Mhardyvallee&guiprop=editcount|merged&format=json&formatversion=2
and it does add up to 575, so the current count seems correct on the surface.

Tue, Oct 13, 3:52 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265331: Fix not being able to save any resource objects.

I already had a local instance running on master, so this was super simple to reproduce and fix.

Tue, Oct 13, 3:13 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265331: Fix not being able to save any resource objects.

hotfix in the pipeline:
https://github.com/WikipediaLibrary/TWLight/commit/6b54d1adb8f1bd93f732e1b2f323f846dd97a401

Tue, Oct 13, 3:12 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman moved T265331: Fix not being able to save any resource objects from Ready for Dev to Done on the The-Wikipedia-Library (Kanban) board.
Tue, Oct 13, 3:11 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

The october 8 backup (from before the eligibility cron jobs) shows Mhardyvallee's bundle authorization already expired on october 5. Going further back.

Tue, Oct 13, 2:17 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Mon, Oct 12

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

The cron task double run remains the most likely cause so far. My next step is to restore a backup from Oct 8 either locally or on staging and test simultaneous command runs to see how it impacts editor bundle eligibility.

Mon, Oct 12, 4:35 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

update: I looked through our commit log preceding this issue to see if there was any obvious cause of this behavior. I didn't come up with anything there. Really the biggest changes were related to updating auths after someone agrees to terms (@Mhardyvallee agreed last in march) and an update to the way bundle auths are included in the api view for wikilink (pretty unrelated).

Mon, Oct 12, 3:32 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)

Fri, Oct 9

jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Yeah, the hardest thing about the migration (as I imagined it anyway) will be to have it query the global contributions to calculate a correct recent edit count.

Fri, Oct 9, 5:19 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

There are enough potentially impaced edtors that the correct way to correct the information would be probably be to write a migration to check and potentially update editors that might have this issue.
That's not a thing I could get done this week.

Fri, Oct 9, 3:24 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Backup /data/project/prod/09.15.tar.gz completed

Fri, Oct 9, 3:16 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

There are 82 users returned by the following query:
select wp_username, wp_editcount, wp_editcount_updated, wp_editcount_prev, wp_editcount_prev_updated, wp_editcount_recent, wp_enough_recent_edits from users_editor where wp_editcount_recent = 0 and wp_editcount > 499 and wp_editcount_prev_updated > 2020-10-07;
I had to narrow it down since we have thousands of editors with 0 recent edits.

Fri, Oct 9, 3:11 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

@Samwalton9
Fixing this one editor would be easy enough, I can correct the values in the db based on what's shown in the global user contributions. Should I take a backup of the site as it is, fix this editor, and then investigate from the backup? Or should I do more investigation first?
Even though I don't see a direct connection right now, I agree that the cron job firing twice is suspicious, and definitely shouldn't be happening even if it isn't a direct cause of this issue.

Fri, Oct 9, 2:56 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

...Unless enough_recent_edits was already false then for some reason.

Fri, Oct 9, 2:51 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265146: Recent edit count isn't updating correctly for a user.

Hmm, I don't think that should have caused this issue, because we only update the count if at least 30 days have passed since the last update:
https://github.com/WikipediaLibrary/TWLight/blob/71e7937a19c1c8bbd5dfedb7f207f7243f7d4308/TWLight/users/helpers/editor_data.py#L161
It looks like the "previous count" last updated on 2020-10-05 19:55:03.535886

Fri, Oct 9, 2:48 PM · Library-Card-Platform, The-Wikipedia-Library (Kanban)
jsn.sherman moved T264290: Update Docker Swarm deployment process and documentation for accuracy from Ready for Dev to In Progress on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 9, 1:47 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
jsn.sherman moved T259867: Add admin validation ensuring that Partners set to the Codes or Link access methods have user_instructions from Reviewed (waiting for changes) to Done on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 9, 11:46 AM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform

Thu, Oct 8

jsn.sherman moved T259867: Add admin validation ensuring that Partners set to the Codes or Link access methods have user_instructions from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Thu, Oct 8, 3:45 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
jsn.sherman moved T263031: Migrate Travis repository to travis-ci.com from In Progress to Done on the The-Wikipedia-Library (Kanban) board.
Thu, Oct 8, 2:02 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T263031: Migrate Travis repository to travis-ci.com.

This is done

Thu, Oct 8, 2:02 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T265001: Investigate behaviour tracking software options [SPIKE] [2hr].

Additional context: we chose matomo previously because it is a widely used package with reasonably good documentation that can be configured either for JavaScript tracking or log parsing.

Thu, Oct 8, 12:43 PM · The-Wikipedia-Library (Kanban), Spike, Library-Card-Platform

Wed, Oct 7

jsn.sherman added a comment to T263031: Migrate Travis repository to travis-ci.com.

I got lost in a little bit of a navigation loop to get signed up for the migration program. But I now have TWLight staged and ready for migration to travis-ci.com

Wed, Oct 7, 5:52 PM · The-Wikipedia-Library (Kanban)
jsn.sherman triaged T263031: Migrate Travis repository to travis-ci.com as Medium priority.
Wed, Oct 7, 5:52 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T263031: Migrate Travis repository to travis-ci.com from Ready for Dev to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Oct 7, 5:50 PM · The-Wikipedia-Library (Kanban)
jsn.sherman claimed T263031: Migrate Travis repository to travis-ci.com.
Wed, Oct 7, 5:50 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T261219: Update AuthorizedUsers API to only list recently logged in Bundle users from Reviewed (waiting for changes) to Done on the The-Wikipedia-Library (Kanban) board.
Wed, Oct 7, 5:48 PM · The-Wikipedia-Library (Kanban), good first task, Wikilink-Tool, Library-Card-Platform

Tue, Oct 6

jsn.sherman moved T259867: Add admin validation ensuring that Partners set to the Codes or Link access methods have user_instructions from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Tue, Oct 6, 4:32 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
jsn.sherman moved T261219: Update AuthorizedUsers API to only list recently logged in Bundle users from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Tue, Oct 6, 4:25 PM · The-Wikipedia-Library (Kanban), good first task, Wikilink-Tool, Library-Card-Platform

Mon, Oct 5

jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

fix deployed to prod. I signed up for mgg online and the proxy appears to be doing its job.

Mon, Oct 5, 4:42 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

Deployed to preprod and flagged for prod.

Mon, Oct 5, 4:27 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

It looks like the AcceptGroups stanza has changed. It is no longer an option to leave it out, and this change basically means folks aren't getting assigned any groups at all with fresh logins. Fix (including these two resources) has been flagged for preprod pickup.

Mon, Oct 5, 3:34 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

Deployed to prod. Try again?

Mon, Oct 5, 3:01 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

deployed to preprod; flagged for prod

Mon, Oct 5, 2:35 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T259867: Add admin validation ensuring that Partners set to the Codes or Link access methods have user_instructions from Reviewed (waiting for changes) to Review on the The-Wikipedia-Library (Kanban) board.
Mon, Oct 5, 2:33 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
jsn.sherman moved T261219: Update AuthorizedUsers API to only list recently logged in Bundle users from Reviewed (waiting for changes) to Review on the The-Wikipedia-Library (Kanban) board.
Mon, Oct 5, 2:32 PM · The-Wikipedia-Library (Kanban), good first task, Wikilink-Tool, Library-Card-Platform
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

Change flagged for preprod

Mon, Oct 5, 2:08 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

I forgot to add the new groups to the authentication whitelist. I'm dropping that whitelist altogether, as it's a thing we talked about being a hassle that offers very limited security benefits.

Mon, Oct 5, 2:04 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T264429: Add EZProxy configuration for RILM from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Mon, Oct 5, 1:51 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

deployed to prod

Mon, Oct 5, 1:51 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

flagged for prod

Mon, Oct 5, 1:15 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

deployed to preprod

Mon, Oct 5, 1:04 PM · The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264211: Configure SSE Client retries and timeouts to improve reliability.

deployed and running strong in production for a few days now.

Mon, Oct 5, 12:58 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T264429: Add EZProxy configuration for RILM.

Initial config marked for deployment to preprod.
MGG Online had a canned config available, but I had to make one up for RILM Music Encyclopedias, so that one warrants additional testing.

Mon, Oct 5, 12:50 PM · The-Wikipedia-Library (Kanban)
jsn.sherman claimed T264429: Add EZProxy configuration for RILM.
Mon, Oct 5, 12:25 PM · The-Wikipedia-Library (Kanban)
jsn.sherman moved T264429: Add EZProxy configuration for RILM from Ready for Dev to In Progress on the The-Wikipedia-Library (Kanban) board.
Mon, Oct 5, 12:25 PM · The-Wikipedia-Library (Kanban)

Fri, Oct 2

jsn.sherman added a comment to T226369: Don't send coordinator comment notification email if user isn't currently the coordinator.

I put this in the waiting for changes column: this isn't waiting for changes to the pr, it's waiting for other changes to the test suite.

Fri, Oct 2, 2:03 PM · The-Wikipedia-Library, Patch-For-Review, good first task, Library-Card-Platform
jsn.sherman moved T226369: Don't send coordinator comment notification email if user isn't currently the coordinator from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 2, 2:02 PM · The-Wikipedia-Library, Patch-For-Review, good first task, Library-Card-Platform
jsn.sherman moved T261219: Update AuthorizedUsers API to only list recently logged in Bundle users from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.
Fri, Oct 2, 2:02 PM · The-Wikipedia-Library (Kanban), good first task, Wikilink-Tool, Library-Card-Platform

Thu, Oct 1

jsn.sherman added a comment to T264211: Configure SSE Client retries and timeouts to improve reliability.

This is as ready and tested as it can be without resolving a non-production environment issue first.

Thu, Oct 1, 5:07 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman moved T264211: Configure SSE Client retries and timeouts to improve reliability from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Thu, Oct 1, 3:57 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)

Wed, Sep 30

jsn.sherman added a comment to T264211: Configure SSE Client retries and timeouts to improve reliability.

Currently testing this PR on staging
https://github.com/WikipediaLibrary/externallinks/pull/50

Wed, Sep 30, 5:04 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman updated the task description for T264211: Configure SSE Client retries and timeouts to improve reliability.
Wed, Sep 30, 4:44 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
Samwalton9 awarded T264211: Configure SSE Client retries and timeouts to improve reliability a Love token.
Wed, Sep 30, 4:21 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman updated the task description for T264211: Configure SSE Client retries and timeouts to improve reliability.
Wed, Sep 30, 4:20 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman moved T264211: Configure SSE Client retries and timeouts to improve reliability from Ready for Dev to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Sep 30, 4:18 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman created T264211: Configure SSE Client retries and timeouts to improve reliability.
Wed, Sep 30, 4:18 PM · Wikilink-Tool, The-Wikipedia-Library (Kanban)
jsn.sherman added a comment to T250084: Investigate how to keep the EventStream tracking script connected [8HR].

Retries are also supported for passthrough to requests and have a default of 3000. We'll configure that too.

Wed, Sep 30, 4:17 PM · The-Wikipedia-Library (Kanban), Spike, Wikilink-Tool
jsn.sherman moved T254327: Re-establish Wikilink backups and set up a retention schedule from In Progress to Review on the The-Wikipedia-Library (Kanban) board.
Wed, Sep 30, 4:04 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman added a comment to T254327: Re-establish Wikilink backups and set up a retention schedule.

Tiny PR here
https://github.com/WikipediaLibrary/externallinks/pull/49

Wed, Sep 30, 4:04 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman claimed T254327: Re-establish Wikilink backups and set up a retention schedule.

I still need to make sure the script fails out if it can't perform the db dump. When I know that's true, I can add the deletion of old backups as a simple && in the script.

Wed, Sep 30, 1:22 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman moved T254327: Re-establish Wikilink backups and set up a retention schedule from Ready for Dev to In Progress on the The-Wikipedia-Library (Kanban) board.
Wed, Sep 30, 1:21 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool

Tue, Sep 29

jsn.sherman created T264107: Enable mounting /data/project from nfs on project Wikilink.
Tue, Sep 29, 4:11 PM · VPS-Projects, Data-Services
jsn.sherman added a comment to T250084: Investigate how to keep the EventStream tracking script connected [8HR].

And actually, it looks like this client can pass arguments through to the underlying requests library, which supports connect and read timeouts.
https://requests.readthedocs.io/en/latest/user/advanced/#timeouts

Tue, Sep 29, 3:19 PM · The-Wikipedia-Library (Kanban), Spike, Wikilink-Tool
jsn.sherman added a comment to T250084: Investigate how to keep the EventStream tracking script connected [8HR].

After poking around with deploying this, my thought is that we may just be able to wrap the sse client calls here:
https://github.com/WikipediaLibrary/externallinks/blob/e735c29e7da3b8241996581b2398a771713570b0/extlinks/links/management/commands/linkevents_collect.py#L48-L61
with a method that has a timeout of something like 30 minutes.
We could also add some additional logging here. I'm thinking of this as a quick fix alternative to T261807

Tue, Sep 29, 3:10 PM · The-Wikipedia-Library (Kanban), Spike, Wikilink-Tool
jsn.sherman added a comment to T258793: Update the Wikilink production server to use Docker Swarm.

We're using the older version for now.

Tue, Sep 29, 1:59 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool

Mon, Sep 28

jsn.sherman added a comment to T258793: Update the Wikilink production server to use Docker Swarm.

Okay, deployment complete, with only one hiccup:
docker-compose version 1.27.4, build 40524192 has a bug in the config subcommand that causes it to output depends_on elements as a dict instead of a list. This breaks our deployment. docker-compose version 1.27.1, build 509cfb99 (the latest version we previously deployed) works fine. I added a note about this to the debian server setup in the project wiki

Mon, Sep 28, 5:45 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 5:39 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 5:08 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 4:39 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 4:36 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 4:34 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 4:31 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 4:31 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman added a comment to T258793: Update the Wikilink production server to use Docker Swarm.

Okay, I added checkboxes for deployment steps into the description. I'll check them off as I progress on this deployment.

Mon, Sep 28, 4:25 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool
jsn.sherman updated the task description for T258793: Update the Wikilink production server to use Docker Swarm.
Mon, Sep 28, 4:24 PM · The-Wikipedia-Library (Kanban), Wikilink-Tool

Sep 25 2020

jsn.sherman updated the task description for T263850: Rewrite application revision handling in test suite.
Sep 25 2020, 2:14 PM · The-Wikipedia-Library, Library-Card-Platform