Page MenuHomePhabricator

jsn.sherman
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2017, 7:18 PM (135 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jsn.sherman [ Global Accounts ]

Recent Activity

Thu, Sep 5

jsn.sherman claimed T225915: Fix incorrect string value error for iPhone user agent.
Thu, Sep 5, 3:49 PM · Library-Card-Platform

Tue, Sep 3

jsn.sherman closed T226793: UnicodeDecodeError when applying for resources as Resolved.

This was a hangover from an accidental encoding regression that occurred when we migrated to docker. It's been resolved with a combination of config, code, and ops.

Tue, Sep 3, 5:45 PM · Library-Card-Platform

Tue, Aug 27

jsn.sherman added a comment to T226617: UnicodeEncodeError on OAuth callback.

deployed. Let's wait till users confirm things are working to close this out

Tue, Aug 27, 1:19 PM · Library-Card-Platform

Aug 22 2019

jsn.sherman added a comment to T226617: UnicodeEncodeError on OAuth callback.

Okay, I created a PR with code that seems to resolve the auth limbo issue, but it wouldn't be bad for @Samwalton9 to take a peek at it since it touches auth.

Aug 22 2019, 9:24 PM · Library-Card-Platform
jsn.sherman added a comment to T226617: UnicodeEncodeError on OAuth callback.

I've got the underlying issue resolved.
*However*
The user accounts that encountered this are in a half-created state that in practice will keep the user in authentication purgatory until we make the login process a little more robust or delete the affected accounts.
I'm going to try the coding option first, as we have some other non-operational accounts that were created for statistical purposes, and I don't want to have to try to identify just the right set of strange looking accounts to delete.

Aug 22 2019, 8:03 PM · Library-Card-Platform
jsn.sherman claimed T226617: UnicodeEncodeError on OAuth callback.
Aug 22 2019, 7:17 PM · Library-Card-Platform

Jun 13 2019

jsn.sherman added a comment to T203685: Ensure that logs are saved even when the environment is recreated.

If we don't need to keep them around for a super long time, then we could just use an external event/log analytics service like https://timber.io/ or https://sentry.io/

Jun 13 2019, 3:18 PM · Library-Card-Platform
jsn.sherman added a comment to T203685: Ensure that logs are saved even when the environment is recreated.

still an issue post-dockerization

Jun 13 2019, 3:16 PM · Library-Card-Platform
jsn.sherman added a comment to T200520: Log access to personal data.

This is still an outstanding task post-dockerization

Jun 13 2019, 2:37 PM · Library-Card-Platform
jsn.sherman closed T209838: Add a new script or flag for reloading gunicorn or running collectstatic when required as Resolved.

This was closed when we moved to docker.

Jun 13 2019, 2:36 PM · Library-Card-Platform

Jan 10 2019

jsn.sherman added a comment to T201159: Add a Contact Us page.

+1

Jan 10 2019, 6:51 PM · Library-Card-Platform
jsn.sherman added a comment to T201159: Add a Contact Us page.

I haven't paid to much attention to this until looking at @AVasanth_WMF 's excellent mockup this morning.
From a spaminess perspective, I'd recommend that we not have a public/anonymous form that sends email.

Jan 10 2019, 3:38 PM · Library-Card-Platform

Jan 8 2019

jsn.sherman closed T213007: Library Card platform isn't sending any emails - all 'Draft' as Resolved.

This has been resolved. It turns out that our underlying email infrastructure changed, but we weren't aware of it. All withheld emails should now be delivered.

Jan 8 2019, 4:50 PM · Library-Card-Platform

Jan 3 2019

jsn.sherman closed T209836: Improve user check behaviour in virtualenv_activate as Resolved.

fix merged into master

Jan 3 2019, 7:36 PM · good first bug, Library-Card-Platform
jsn.sherman added a comment to T209836: Improve user check behaviour in virtualenv_activate.

So, while fixing this problem in a branch, I encountered/reproduced the originally reported issue. The scripts that directly use a virtualenv do in fact have the user check thanks to the virualenv_activate script. Some of the wrapper scripts that compose those into useful workflows don't because the test for the "right thing" needs to be a little more complicated.

Jan 3 2019, 5:25 PM · good first bug, Library-Card-Platform
jsn.sherman added a comment to T209836: Improve user check behaviour in virtualenv_activate.

This is a super simple fix. I'll get it pushed right in.

Jan 3 2019, 3:45 PM · good first bug, Library-Card-Platform

Dec 4 2018

jsn.sherman closed T211136: Wikipedia Library Server Error as Resolved.

hotfix in place. verified that things are happy.

Dec 4 2018, 7:44 PM · Library-Card-Platform
jsn.sherman claimed T211136: Wikipedia Library Server Error.

pushed hotfix in git. Will get it to live site asap

Dec 4 2018, 7:34 PM · Library-Card-Platform

Oct 31 2018

jsn.sherman added a comment to T208413: Check whether twl project requires NFS or not.

Yep, we definitely need nfs, that's where we keep a month's worth of nightly backups, which we've occasionally used to roll back a bad data migration or just as a place to keep our state when we throw away a vm and provision a new one.

Oct 31 2018, 7:52 PM · The-Wikipedia-Library, Cloud-VPS

Oct 19 2018

jsn.sherman added a comment to T207455: Request creation of library-card-test VPS project.

I'm planning on separating the different bits of our platform into containers running on a small kubernetes cluster, and running the database as a vm outside the cluster. We haven't determined the best way to configure persistent storage (e.g. user uploaded attachments). If we can use a project-wide nfs export (which we only use for backups in twl) that's great. If that's a performance/workload nonstarter, then I'm open to guidance, including just running a container that provides storage, which backs itself up to a project nfs export.

Oct 19 2018, 4:00 PM · cloud-services-team (Kanban), Cloud-VPS (Project-requests)

Aug 1 2018

jsn.sherman added a comment to T196573: Create production git branch and give Travis ability to push.

This is done

Aug 1 2018, 5:15 PM · Library-Card-Platform

Jul 19 2018

jsn.sherman added a comment to T196888: Comment sections are blocked by some extensions (e.g. 1Blocker).

A few thoughts:
I'm not even sure if we should fix this, since blocking comments is one of the design goals of this addon. @Xover might be interested to know that the makers of 1blocker have also released 1blocker x, which appears to be designed to address this concern for their users.

Jul 19 2018, 1:58 PM · Library-Card-Platform

Jul 17 2018

jsn.sherman added a comment to T147465: RTL-compatible styling for the Library Card tool.

Yeah, it's because the username is part of a larger block of text that's marked for translation.
https://github.com/WikipediaLibrary/TWLight/blob/b249eb48b0af54f8c0e53b3500495c452216aea5/TWLight/templates/base.html#L76

Jul 17 2018, 7:43 PM · Library-Card-Platform, RTL, I18n

Jul 13 2018

jsn.sherman added a comment to T147465: RTL-compatible styling for the Library Card tool.

@Samwalton9 I've got the (very) partial translation with the current RTL implementation up at
https://twlight-staging.wmflabs.org/

Jul 13 2018, 8:15 PM · Library-Card-Platform, RTL, I18n
jsn.sherman added a comment to T147465: RTL-compatible styling for the Library Card tool.

The tags were running over the bullets because the bullets weren't in the right place. The background-position css attribute must be explicitly set for CSS janus to modify the position of those images. Default is top left. That issue is now fixed in the dev branch.

Jul 13 2018, 7:51 PM · Library-Card-Platform, RTL, I18n
jsn.sherman added a comment to T147465: RTL-compatible styling for the Library Card tool.

Okay, I've got the issue with the empty values resolved so that we're defaulting to English when there's no suitable translation. The biggest issue I now see is that our pipe delimited tag list is running into the blue tag bullet when there are a lot of tags. Working on it.

Jul 13 2018, 7:32 PM · Library-Card-Platform, RTL, I18n
jsn.sherman added a comment to T147465: RTL-compatible styling for the Library Card tool.

@Samwalton9 In a dev branch, I've added the partial Arabic translation and fixed up numerous issues that were apparent to me both on the RTL rendering side and the translatewiki "add languages from the translation files" side. I can see that we have the additional issue if we're missing a translation for tags or descriptions, we're not displaying anything, rather than defaulting to the English version.

Jul 13 2018, 6:46 PM · Library-Card-Platform, RTL, I18n

Jul 11 2018

jsn.sherman added a comment to T198414: Scheduled coordinator reminder emails aren't being sent.

The fix for number 1 has been pushed to master, along with a fix related to number 2. In this case, we really needed to be testing the management command that creates the reminder email signal, as that's where the problem was. Let's keep this open until we see reminder emails coming down the wire.

Jul 11 2018, 8:56 PM · Library-Card-Platform

Jul 6 2018

jsn.sherman added a comment to T198414: Scheduled coordinator reminder emails aren't being sent.

I've deployed the fix for item #3.

Jul 6 2018, 8:27 PM · Library-Card-Platform

Jun 29 2018

jsn.sherman added a comment to T198414: Scheduled coordinator reminder emails aren't being sent.

@Samwalton9 These emails are still scheduled. There are 3 issues that together caused them to stop working without our knowledge.

  1. I've modified the ListApplicationsView in such a way that the reminder email template no longer works.
  2. As we've previously identified, we have inadequate test coverage for emails, so the new builds didn't start failing after the change.
  3. We're not alerting on failed cron tasks, so the system didn't tell us that it wasn't successfully completing its housekeeping as designed.
Jun 29 2018, 6:26 PM · Library-Card-Platform

May 2 2018

jsn.sherman added a comment to T193507: Re-add renewals field data.

looks like I could be doing this more efficiently:
https://django-import-export.readthedocs.io/en/latest/index.html

May 2 2018, 4:55 PM · Library-Card-Platform
jsn.sherman added a comment to T193507: Re-add renewals field data.

just keep me posted, as it's quite time consuming to reformulate the inserts from a dump into non-destructive updates. Let's try to get any other missing data identified so that we can catch it in one pass.

May 2 2018, 4:45 PM · Library-Card-Platform

Apr 30 2018

jsn.sherman closed T193333: Error on editing users as Resolved.

Issue resolved. there was a new CSRF setting that didn't come into play in local dev and travis because of the lack of SSL there.

Apr 30 2018, 3:01 PM · Library-Card-Platform
jsn.sherman added a comment to T193333: Error on editing users.

It's looking like it related to the fact that we're behind a proxy for the labs infrastructure. The issue doesn't happen in local dev, but it's there for prod and staging. I've verified that csrf is working correctly for non-admin forms.

Apr 30 2018, 1:51 PM · Library-Card-Platform

Apr 16 2018

jsn.sherman added a comment to T185244: Scope coordinator permission to be per-partner.

This change has been pushed to master, and should get picked up at tomorrow's scheduled update.

Apr 16 2018, 7:35 PM · Library-Card-Platform
jsn.sherman added a comment to T190431: Application comments not displaying on iOS.

I suppose we should mark this as closed since I have resolved all related display issues I could produce on iOS. I haven't heard back from the reporting editor, though.

Apr 16 2018, 7:34 PM · Library-Card-Platform

Apr 5 2018

jsn.sherman added a comment to T185244: Scope coordinator permission to be per-partner.

1st cut of the app code is complete. I'm in the process of extending the test suite to accommodate the way the code works now. Right now the test suite creates partners and coordinators in unrelated way. I'll need to designate coordinator/partner relationships in the test suite so that I can separately test the cases of display for a coordinator that should or shouldn't have access to a given bit of content.

Apr 5 2018, 5:30 PM · Library-Card-Platform
jsn.sherman added a comment to T190431: Application comments not displaying on iOS.

In addition to our recent css updates, I added a 400 error template, as that was the most interesting situation I was able to create while trying to break discussions. I tested on a recently acquired iphone and application discussions seem to work as expected. Awaiting feedback from the user that reported the issue.

Apr 5 2018, 3:19 PM · Library-Card-Platform

Apr 3 2018

jsn.sherman added a comment to T187486: Pageviews download as csv button doesn't work, maybe others.

Yeah, we could probably be using requests a little smarter. It returns the status code of the logged http object...which means that you get a 404 when clicking on a 404 request object. We've got some context on that buried in closed phab task somewhere.

Apr 3 2018, 4:32 PM · Library-Card-Platform

Mar 6 2018

jsn.sherman added a comment to T170795: Allow coordinators to download a file containing username, email, and application/approval date for their partner.

I'm currently evaluating using a report builder of some kind to meet this and similar needs.

Mar 6 2018, 6:46 PM · Library-Card-Platform

Feb 14 2018

jsn.sherman added a comment to T186501: Some user edit counts show incorrectly (usually None).

Cause of null data resolved, but the user edit counts won't get updated until the impacted users login again. As @Samwalton9 suggested, it was an encoding issue: the input data fed into the user import code as well as the test code are already utf-8. The OAuth data coming back from live wikimedia was being treated as ANSI. Changes pushed to production.

Feb 14 2018, 8:36 PM · Library-Card-Platform
jsn.sherman closed T186747: Emails are being sent without paragraphing as Resolved.

Identified issues in both plaintext and html mime types. On the html side, there was no markup whatsoever. On the plaintext side, the options on the jinja text block were filtering out newline characters, along with other characters. Addressed these issues and deleted an unused/duplicate email template. Changes pushed to production.

Feb 14 2018, 7:20 PM · Library-Card-Platform

Feb 5 2018

jsn.sherman added a comment to T186501: Some user edit counts show incorrectly (usually None).

There are couple of aspects to this. None is a null value explicitly different from 0. Because we're trying our best to pull in data via a couple of different interfaces that don't always give us data, we'll never live in a world where we don't see that sometimes. We should probably make that None more informative. Basically, apps shouldn't be declined due to a null value in the system, instead the coordinator should check the link right next to that value that will often show a correct edit count. I'll also work on figuring out why we don't have data for those folks specifically.

Feb 5 2018, 11:03 PM · Library-Card-Platform

Jan 29 2018

jsn.sherman added a comment to T161821: Notify coordinators of new applications.

I've slightly updated the message template and pushed the code to production. I also fired off the task manually since it's Monday. As a sidenote, admins can view the emails we've sent under the "messages" section of the administration page.

Jan 29 2018, 2:08 PM · Library-Card-Platform

Jan 28 2018

jsn.sherman added a comment to T161821: Notify coordinators of new applications.

@Nikkimaria Yep, I'll get things pushed to the master branch this evening or early tomorrow morning. Go ahead an undo the change. Sorry for the confusion on this, all.

Jan 28 2018, 7:47 PM · Library-Card-Platform

Jan 27 2018

jsn.sherman added a comment to T161821: Notify coordinators of new applications.

@Samwalton9 absolutely. We can just not send emails on those, if @Nikkimaria doesn't need notifications.

Jan 27 2018, 1:21 PM · Library-Card-Platform

Jan 26 2018

jsn.sherman added a comment to T161821: Notify coordinators of new applications.

@Samwalton9 and @Nikkimaria just let me know once all of the partners have a coordinator set. I'll then be able to push the changes to the live site.

Jan 26 2018, 12:58 PM · Library-Card-Platform

Jan 25 2018

jsn.sherman added a comment to T161821: Notify coordinators of new applications.

I have everything pretty well wired up in my feature branch. Current email looks like:

Jan 25 2018, 8:49 PM · Library-Card-Platform

Jan 22 2018

jsn.sherman updated subscribers of T161821: Notify coordinators of new applications.

Quick update on this. Completed bits:

Jan 22 2018, 3:29 PM · Library-Card-Platform

Jan 8 2018

jsn.sherman added a comment to T159994: Library Bundle partners should be denoted (or separated) in the partner list interfaces.

I've got the model and templates wired up to Twila's bundle banner flag in her dev branch.

Jan 8 2018, 6:26 PM · Library-Card-Platform
jsn.sherman triaged T179819: support hundreds of languages, not just a handful as Normal priority.
Jan 8 2018, 6:11 PM · I18n, Library-Card-Platform
jsn.sherman added a comment to T179819: support hundreds of languages, not just a handful.

For the model issue, it sounds like we'll pull the descriptions and related fields out of the database and stick them either into templates or into a separate repo. Basically, get those things into code.

Jan 8 2018, 6:10 PM · I18n, Library-Card-Platform

Nov 15 2017

jsn.sherman added a comment to T147465: RTL-compatible styling for the Library Card tool.

Quick update: I've got a solid start on reading the ltr css into css janus, and flipping the css. I'm a nodejs novice, so I'll need to fiddle with it a bit to direct the output to programmatically named files that can then be referenced by the django bidi machinery.

Nov 15 2017, 2:01 PM · Library-Card-Platform, RTL, I18n

Nov 14 2017

jsn.sherman added a comment to T149436: Add async email-sending strategy.

async email config pushed to prod. Testing turned up a few more cases where there the user salutation ended up being the numerical ID T169525. It was down to the fact that we're using a separate system for app comments than for the rest of the things that generate emails. That's now been resolved as well.

Nov 14 2017, 12:56 PM · Library-Card-Platform

Nov 13 2017

jsn.sherman added a comment to T149436: Add async email-sending strategy.

Quick update: I'm currently testing using an async djmail backend for sending mail. Currently, it offers all of the hoped for performance benefits of an async mail queue, minus the capability to actually transfer any email messages. In other words, I'm making progress, but I still have a little work to do.

Nov 13 2017, 6:39 PM · Library-Card-Platform

Nov 9 2017

jsn.sherman added a comment to T174676: Show waitlisted applications on Review page.

I verified that this is fixed on the live site. You can check by filtering pending applications on CUP, which is waitlisted.

Nov 9 2017, 12:52 PM · Library-Card-Platform

Nov 8 2017

jsn.sherman added a comment to T174676: Show waitlisted applications on Review page.

Fix has been pushed to master. Should get picked up on live site in less than 24 hours.

Nov 8 2017, 12:39 PM · Library-Card-Platform

Nov 6 2017

jsn.sherman added a parent task for T147465: RTL-compatible styling for the Library Card tool: T162479: Set up Library Card platform on Translatewiki.net.
Nov 6 2017, 12:43 PM · Library-Card-Platform, RTL, I18n
jsn.sherman added a subtask for T162479: Set up Library Card platform on Translatewiki.net: T147465: RTL-compatible styling for the Library Card tool.
Nov 6 2017, 12:43 PM · translatewiki.net, Library-Card-Platform
jsn.sherman added a parent task for T179819: support hundreds of languages, not just a handful: T162479: Set up Library Card platform on Translatewiki.net.
Nov 6 2017, 12:41 PM · I18n, Library-Card-Platform
jsn.sherman added a subtask for T162479: Set up Library Card platform on Translatewiki.net: T179819: support hundreds of languages, not just a handful.
Nov 6 2017, 12:41 PM · translatewiki.net, Library-Card-Platform
jsn.sherman created T179819: support hundreds of languages, not just a handful.
Nov 6 2017, 12:41 PM · I18n, Library-Card-Platform

Nov 3 2017

jsn.sherman closed T177841: Translated text in the "log in" button is cut off as Resolved.

Made login button an inline element. Now text overflow pushes the box out properly.

Nov 3 2017, 11:31 AM · I18n, Library-Card-Platform
jsn.sherman closed T177841: Translated text in the "log in" button is cut off, a subtask of T162479: Set up Library Card platform on Translatewiki.net, as Resolved.
Nov 3 2017, 11:31 AM · translatewiki.net, Library-Card-Platform
jsn.sherman closed T177841: Translated text in the "log in" button is cut off, a subtask of T170977: Post-migration issues and priorities, as Resolved.
Nov 3 2017, 11:31 AM · Library-Card-Platform
jsn.sherman added a comment to T149436: Add async email-sending strategy.

Django has some decent email testing tools that we should probably be using. DJmail, which is our current mail handling library, has some asynchronous options that don't have external dependencies, but I'll need to get at least some basic email testing in place before we can reconfigure it.

Nov 3 2017, 10:39 AM · Library-Card-Platform
jsn.sherman closed T178785: email notifications aren't properly localized as Resolved.
Nov 3 2017, 10:36 AM · I18n, Library-Card-Platform
jsn.sherman closed T178785: email notifications aren't properly localized, a subtask of T162479: Set up Library Card platform on Translatewiki.net, as Resolved.
Nov 3 2017, 10:36 AM · translatewiki.net, Library-Card-Platform
jsn.sherman closed T178785: email notifications aren't properly localized, a subtask of T170977: Post-migration issues and priorities, as Resolved.
Nov 3 2017, 10:36 AM · Library-Card-Platform
jsn.sherman added a subtask for T162479: Set up Library Card platform on Translatewiki.net: T177841: Translated text in the "log in" button is cut off.
Nov 3 2017, 10:35 AM · translatewiki.net, Library-Card-Platform
jsn.sherman added a parent task for T177841: Translated text in the "log in" button is cut off: T162479: Set up Library Card platform on Translatewiki.net.
Nov 3 2017, 10:35 AM · I18n, Library-Card-Platform
jsn.sherman added a project to T177841: Translated text in the "log in" button is cut off: I18n.
Nov 3 2017, 10:35 AM · I18n, Library-Card-Platform

Nov 1 2017

jsn.sherman added a comment to T162479: Set up Library Card platform on Translatewiki.net.

official request submitted to translatewiki.

Nov 1 2017, 11:36 AM · translatewiki.net, Library-Card-Platform

Oct 31 2017

jsn.sherman added a comment to T178785: email notifications aren't properly localized.

This issue should be resolved, though the implementation looks a little different than what I had originally envisioned. I made the following changes:

  • added a user field for language preference
  • added a hook on update_from_wikipedia to set that field to the current browser language if it's empty
  • re-implemented the django i18n form to also set that field for a user if they are logged in
  • added the value of that field to the context loaded into all of the email templates
Oct 31 2017, 1:01 PM · I18n, Library-Card-Platform

Oct 30 2017

jsn.sherman added a parent task for T178785: email notifications aren't properly localized: T162479: Set up Library Card platform on Translatewiki.net.
Oct 30 2017, 10:45 AM · I18n, Library-Card-Platform
jsn.sherman added a subtask for T162479: Set up Library Card platform on Translatewiki.net: T178785: email notifications aren't properly localized.
Oct 30 2017, 10:45 AM · translatewiki.net, Library-Card-Platform

Oct 24 2017

jsn.sherman added a project to T177376: Make homepage text translatable: I18n.

The necessary changes have been merged into master. You can see the changes here. Of course, the translations themselves will need to be done as well.

Oct 24 2017, 12:40 PM · I18n, Library-Card-Platform

Oct 22 2017

jsn.sherman created T178785: email notifications aren't properly localized.
Oct 22 2017, 10:38 PM · I18n, Library-Card-Platform
jsn.sherman added a comment to T175127: Improve testing suite.

Since the test suite has received a significant upgrade that is allowing us to move forward, I think we can either mark this one as closed and create a new task for more test suite enhancements, or lower the priority.

Oct 22 2017, 10:17 PM · Library-Card-Platform

Oct 19 2017

jsn.sherman closed T173990: Waitlisting partner with pending applications results in server error as Resolved.

I finally managed to reproduce this issue in another environment and resolve it. There were several issues contributing to this problem. There was a missing email template, and separate worker and proxy timeouts due to our current email strategy. All this was made more difficult to troubleshoot due to the differences in email configuration between production and non-production environments (we only really want to send email from prod), and the configuration of the test suite in different environments.

Oct 19 2017, 6:49 PM · Library-Card-Platform
jsn.sherman closed T173990: Waitlisting partner with pending applications results in server error, a subtask of T170977: Post-migration issues and priorities, as Resolved.
Oct 19 2017, 6:49 PM · Library-Card-Platform
jsn.sherman added a comment to T178590: Newspapers.com application results in a waitlist email.

This was actually generated by me mistakenly. While troubleshooting T173990, I mistakenly set newspapers.com to waitlisted instead of Newspaperarchive. I almost immediately changed it back, so I'm sure when you went to go check it, you found that it was in the expected state.

Oct 19 2017, 4:47 PM · Library-Card-Platform

Oct 13 2017

jsn.sherman added a comment to T173990: Waitlisting partner with pending applications results in server error.

Freshly deployed production does the same thing. At this point there are only a very small number of differences in code execution between vagrant and production. This outcome tells me that's where I need to look, even though the two don't appear related at first glance.

Oct 13 2017, 12:57 PM · Library-Card-Platform

Oct 12 2017

jsn.sherman added a comment to T173990: Waitlisting partner with pending applications results in server error.

So, I'm unable to reproduce this issue anywhere besides production, using the same code checkout and the same data. I spent some time working on some of these individual issues, but the big question is why we're seeing them only in production. I'm going to redeploy the production server tomorrow, to see if that resolves the issue.

Oct 12 2017, 12:39 PM · Library-Card-Platform

Oct 11 2017

jsn.sherman added a comment to T173990: Waitlisting partner with pending applications results in server error.

The updated code has been deployed, but the issue isn't resolved. Some of the automated tests that are passing without issue in dev and staging are failing out in production. This is ... interesting. I'm going to pull down a fresh dump of the production db and see if I can reproduce the issue in another environment. At least we have the tooling in place now to ferret out things kinds of issues.

Oct 11 2017, 12:43 PM · Library-Card-Platform

Oct 9 2017

jsn.sherman added a comment to T173990: Waitlisting partner with pending applications results in server error.

I believe I have this issue resolved in the codebase, but there have been a lot of changes to the puppet module to support the testing improvements, so there are some steps I need to take to make sure deploying all of the changes together won't break the production system.

Oct 9 2017, 12:55 PM · Library-Card-Platform

Sep 13 2017

jsn.sherman added a comment to T171574: Change glyphicons to static images.

I think we determined this was noscript-specific, in which case it's fine for it to be broken.

Sep 13 2017, 6:26 PM · Library-Card-Platform

Sep 5 2017

jsn.sherman added a comment to T170115: Fix spacing for waitlisted tag.

So this turned out to be a bit of a goose chase

Sep 5 2017, 6:23 PM · Library-Card-Platform
Cameron11598 awarded T175050: Pull list of Newspapers.com users for coordinator a Like token.
Sep 5 2017, 5:36 PM · Library-Card-Platform

Sep 3 2017

jsn.sherman added a comment to T173990: Waitlisting partner with pending applications results in server error.

I've identified that the root cause of this and several other recent showstopping bugs is inadequate testing. I realized that the existing unit tests became inadequate after I wrapped a large portion of the views with login_required; the current tests don't run any of the middleware that would give them the context required to turn up the kind of problems we're encountering. I'm moving a large portion of our tests from factory-based unit tests to client-based integration tests.

Sep 3 2017, 6:10 PM · Library-Card-Platform

Sep 2 2017

jsn.sherman added a comment to T174159: Some users unable to complete oauth process.

deployed a second pass to live site. I believe this should cover all remaining reported login issues, but we can hold this issue open to get reports back in

Sep 2 2017, 1:04 AM · Library-Card-Platform

Aug 27 2017

jsn.sherman added a comment to T174159: Some users unable to complete oauth process.

I've got a first pass at a fix deployed to the live site.

Aug 27 2017, 6:40 PM · Library-Card-Platform
jsn.sherman added a comment to T173990: Waitlisting partner with pending applications results in server error.

It looks like the issue happens when you set a partner with pending applications to waitlisted; it appears that this is related to the code that sends waitlist notifications.

Aug 27 2017, 5:11 PM · Library-Card-Platform

Aug 25 2017

jsn.sherman triaged T174159: Some users unable to complete oauth process as High priority.
Aug 25 2017, 12:53 PM · Library-Card-Platform
jsn.sherman added a parent task for T174159: Some users unable to complete oauth process: T170977: Post-migration issues and priorities.
Aug 25 2017, 12:53 PM · Library-Card-Platform
jsn.sherman added a subtask for T170977: Post-migration issues and priorities: T174159: Some users unable to complete oauth process.
Aug 25 2017, 12:53 PM · Library-Card-Platform
jsn.sherman created T174159: Some users unable to complete oauth process.
Aug 25 2017, 12:49 PM · Library-Card-Platform

Aug 23 2017

jsn.sherman closed T167888: Allow users to finish logging in when unable to get valid results from global edit count api call as Resolved.
Aug 23 2017, 5:45 PM · Library-Card-Platform
jsn.sherman closed T167888: Allow users to finish logging in when unable to get valid results from global edit count api call, a subtask of T170977: Post-migration issues and priorities, as Resolved.
Aug 23 2017, 5:45 PM · Library-Card-Platform

Aug 21 2017

jsn.sherman added a comment to T173466: Filter by user - show all.

If the waitlisted apps aren't displayed in the current view, that's not too difficult to fix. We could add another view for that status, or add them into the pending view. That should probably happen whether we add an "any status" view or not. How we want to approach that is more of a design/ux discussion than a technical problem.

Aug 21 2017, 6:32 PM · Library-Card-Platform