Page MenuHomePhabricator

jsn.sherman
User

Today

  • No visible events.

Tomorrow

  • No visible events.

Friday

  • No visible events.

User Details

User Since
Feb 17 2017, 7:18 PM (495 w, 4 d)
Availability
Available
LDAP User
Jsn.sherman
MediaWiki User
JSherman (WMF) [ Global Accounts ]

Recent Activity

Yesterday

jsn.sherman moved T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.
Tue, Aug 18, 8:42 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard
jsn.sherman added a comment to T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation.

Updates from code code review and comments here:

  1. Variant tagging uses unmanaged-data fields rather than custom keys:
    • resolved module group goes in in action_context
    • assigned variant in goes in action_subtype
  2. Tagging happens in send(), not submitInteraction(), per @Sfaci's note above about the deprecation.
Tue, Aug 18, 8:41 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard
jsn.sherman updated the task description for T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation.
Tue, Aug 18, 8:13 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard
jsn.sherman moved T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.
Tue, Aug 18, 11:57 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard

Mon, Aug 17

jsn.sherman moved T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.
Mon, Aug 17, 8:40 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard

Fri, Aug 14

jsn.sherman added a comment to T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation.

I'm still confused and have not yet understood everything here. It appears there is some duplication between what pdo/PersonalDashboard does and what mpo/TestKitchen does.

For experiment-time variant validation, devs additionally use TK's existing ?mpo=experiment:variant. pdo for pre-experiment dev validation when no TK config exists; mpo for post-experiment validation once the experiment is live.

I don't fully understand that. Literally ?mpo=foo:bar works perfectly fine out of the box and needs nothing on the test-kitchen side to be configured or started or live. What does pdo do that mpo does not do? If it is mainly suppressing product health metrics instrumentation, then I wonder if that should not rather be an upstreamed functionality in WikimediaEvents/TestKitchen.

I expect ExperimentTestKitchenManager and StaticExperimentManager to go away soon, in favor of just using WikimediaEvents/TestKitchen in CI and locally directly, with a FeatureManager wrapper for convenience. These classes are holdovers from a time when there was no proper experiment tooling. GEHomepageDefaultVariant is left-over complexity that needs to be cleaned up if we ever find the time. Part of the reasoning is that we want to test the integration with TestKitchen in our tests.

Fri, Aug 14, 9:14 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard
jsn.sherman closed T434659: Create DEPLOYMENT.md as Resolved.
Fri, Aug 14, 7:46 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Documentation, The-Wikipedia-Library
jsn.sherman moved T434659: Create DEPLOYMENT.md from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.
Fri, Aug 14, 2:34 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Documentation, The-Wikipedia-Library

Thu, Aug 13

jsn.sherman updated the task description for T434725: Investigate the 9 organizations stuck for >=481 days.
Thu, Aug 13, 12:48 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman reopened T434725: Investigate the 9 organizations stuck for >=481 days, a subtask of T434529: Wikilink TWL user tracking is broken, as Open.
Thu, Aug 13, 12:45 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman reopened T434725: Investigate the 9 organizations stuck for >=481 days as "Open".

Part of what we need to do here is untangle the the application code -> database error side of this: wikilink shouldn't be trying to run userlist updates on former partners. the underlying links_urlpattern_collections foreignkey failure is still live in the code, and it'll happen again for the next partner we delete if we don't fix it.

Thu, Aug 13, 12:45 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool

Wed, Aug 12

jsn.sherman added a comment to T434725: Investigate the 9 organizations stuck for >=481 days.

SHOW ENGINE INNODB STATUS surfaced this as the latest foreign-key error on prod, timestamped 2026-08-11 23:36:31:

Wed, Aug 12, 8:37 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman created T434725: Investigate the 9 organizations stuck for >=481 days.
Wed, Aug 12, 8:34 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman created T434724: Re-enable users_update_lists and backfill on_user_list.
Wed, Aug 12, 8:29 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman updated the task description for T434714: Rewrite users_update_lists to diff instead of clear-and-reinsert.
Wed, Aug 12, 8:19 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman created T434719: org_crons healthcheck should fail on any organization.
Wed, Aug 12, 8:00 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman updated the task description for T434707: Widen username_list join table's id to bigint.
Wed, Aug 12, 7:52 PM · Moderator-Tools-Team (Kanban), Essential-Work, Wikilink-Tool
jsn.sherman updated the task description for T434714: Rewrite users_update_lists to diff instead of clear-and-reinsert.
Wed, Aug 12, 7:50 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman placed T434529: Wikilink TWL user tracking is broken up for grabs.
Wed, Aug 12, 7:46 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman moved T434714: Rewrite users_update_lists to diff instead of clear-and-reinsert from Inbox to To be estimated on the Moderator-Tools-Team board.
Wed, Aug 12, 7:45 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman created T434714: Rewrite users_update_lists to diff instead of clear-and-reinsert.
Wed, Aug 12, 7:45 PM · Essential-Work, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman renamed T434529: Wikilink TWL user tracking is broken from Wikilink TWL user tracking ia broken to Wikilink TWL user tracking is broken.
Wed, Aug 12, 7:21 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman added a project to T434529: Wikilink TWL user tracking is broken: Essential-Work.
Wed, Aug 12, 7:19 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman moved T434707: Widen username_list join table's id to bigint from Inbox to To be estimated on the Moderator-Tools-Team board.
Wed, Aug 12, 7:18 PM · Moderator-Tools-Team (Kanban), Essential-Work, Wikilink-Tool
jsn.sherman created T434707: Widen username_list join table's id to bigint.
Wed, Aug 12, 7:18 PM · Moderator-Tools-Team (Kanban), Essential-Work, Wikilink-Tool
jsn.sherman moved T434529: Wikilink TWL user tracking is broken from Inbox to Epics on the Moderator-Tools-Team board.
Wed, Aug 12, 5:53 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman renamed T434529: Wikilink TWL user tracking is broken from Wikilink TWL user tracking seems to be broken to Wikilink TWL user tracking ia broken.
Wed, Aug 12, 5:53 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman added a comment to T434529: Wikilink TWL user tracking is broken.

So we're still gathering link events, but we'll need to fix several issues that come together to make the userlist update job sad before we backfill and re-enable the cron. I'll write up a task list here.

Wed, Aug 12, 5:46 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman added a comment to T434529: Wikilink TWL user tracking is broken.

hotfix to pause userlist update:
https://github.com/WikipediaLibrary/externallinks/commit/de5186f19220af1ef3221db0449abf84a0d2d3bc

Wed, Aug 12, 5:45 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman added a comment to T434529: Wikilink TWL user tracking is broken.

verified that the update user list script is busted and has been for some time; it's been silently incrementing db ids and then discarding them until it passed the 32 bit integer limit. We have problems visible going back to April 18, 2025, which is the beginning of the discoverable record of this problem (eg. it could have started before then). That was when we fixed a whole other set of issues that were keeping the cron jobs from completing for different reasons.

Wed, Aug 12, 5:40 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman changed the status of T434529: Wikilink TWL user tracking is broken from Open to In Progress.
Wed, Aug 12, 2:57 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool
jsn.sherman moved T432039: Register Mentorship Module with PersonalDashboard from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.
Wed, Aug 12, 2:56 PM · OKR-Work (DE1 FY2026-27), Growth-Team (FY2026-27 Q1 Sprint 4), Moderator-Tools-Team (Kanban), Patch-For-Review, PersonalDashboard
jsn.sherman moved T432973: Moving Adam Matthew to Library Bundle from Eng review to QA on the Moderator-Tools-Team (Kanban) board.

merged

Wed, Aug 12, 12:32 PM · Moderator-Tools-Team (Kanban), The-Wikipedia-Library

Tue, Aug 11

jsn.sherman edited projects for T407250: Users are no longer receiving access expiry notice emails, added: Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Tue, Aug 11, 4:19 PM · Essential-Work, Patch-For-Review, Moderator-Tools-Team (Kanban), Library-Card-Platform
jsn.sherman moved T432039: Register Mentorship Module with PersonalDashboard from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.
Tue, Aug 11, 2:48 PM · OKR-Work (DE1 FY2026-27), Growth-Team (FY2026-27 Q1 Sprint 4), Moderator-Tools-Team (Kanban), Patch-For-Review, PersonalDashboard
jsn.sherman added a comment to T434529: Wikilink TWL user tracking is broken.

Verified that the api credentials are on the box where they are supposed to be and the job is firing every hour:

crons-1  | 2026-08-11T07:05:01.950708000Z [INFO] Executing users_update_lists.py
crons-1  | 2026-08-11T08:05:02.321202000Z [INFO] Executing users_update_lists.py
crons-1  | 2026-08-11T09:05:01.593929000Z [INFO] Executing users_update_lists.py
crons-1  | 2026-08-11T10:05:02.165584000Z [INFO] Executing users_update_lists.py
crons-1  | 2026-08-11T11:05:02.114458000Z [INFO] Executing users_update_lists.py
crons-1  | 2026-08-11T12:05:01.997846000Z [INFO] Executing users_update_lists.py

haven't verified what's actually happening inside those runs though

Tue, Aug 11, 12:56 PM · Essential-Work, Epic, Moderator-Tools-Team, Wikilink-Tool

Fri, Aug 7

jsn.sherman added a comment to T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation.

Experiments.php sketch

Fri, Aug 7, 10:58 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard
jsn.sherman moved T432039: Register Mentorship Module with PersonalDashboard from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.
Fri, Aug 7, 10:54 PM · OKR-Work (DE1 FY2026-27), Growth-Team (FY2026-27 Q1 Sprint 4), Moderator-Tools-Team (Kanban), Patch-For-Review, PersonalDashboard
jsn.sherman changed the status of T432039: Register Mentorship Module with PersonalDashboard from Open to In Progress.
Fri, Aug 7, 10:54 PM · OKR-Work (DE1 FY2026-27), Growth-Team (FY2026-27 Q1 Sprint 4), Moderator-Tools-Team (Kanban), Patch-For-Review, PersonalDashboard
jsn.sherman changed the status of T432039: Register Mentorship Module with PersonalDashboard, a subtask of T432031: [Epic] DE1.3.9 Migrate select Special:Homepage Modules to PersonalDashboard, from Open to In Progress.
Fri, Aug 7, 10:54 PM · OKR-Work, Epic, Moderator-Tools-Team, PersonalDashboard, Growth-Team
jsn.sherman updated the task description for T434346: Shorten module route URLs with group-defined slugs.
Fri, Aug 7, 9:54 PM · OKR-Work, PersonalDashboard, Moderator-Tools-Team
jsn.sherman created T434346: Shorten module route URLs with group-defined slugs.
Fri, Aug 7, 9:49 PM · OKR-Work, PersonalDashboard, Moderator-Tools-Team
jsn.sherman created T434341: [DRAFT] Let another extension serve the dashboard at its own special page.
Fri, Aug 7, 8:49 PM · OKR-Work, PersonalDashboard, Moderator-Tools-Team
jsn.sherman moved T434340: [DRAFT] PersonalDashboard as a toolkit for teams to build dashboards from Inbox to Epics on the Moderator-Tools-Team board.
Fri, Aug 7, 8:31 PM · Patch-For-Review, OKR-Work, PersonalDashboard, Epic, Moderator-Tools-Team
jsn.sherman created T434340: [DRAFT] PersonalDashboard as a toolkit for teams to build dashboards.
Fri, Aug 7, 8:30 PM · Patch-For-Review, OKR-Work, PersonalDashboard, Epic, Moderator-Tools-Team

Thu, Aug 6

jsn.sherman changed the status of T433416: Make PersonalDashboard interfaces use type declarations and enumerations from Stalled to In Progress.

unstuck, now it needs a rebase!

Thu, Aug 6, 1:24 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Technical-Debt, PersonalDashboard, Moderator-Tools-Team (Kanban)

Wed, Aug 5

jsn.sherman updated the task description for T433096: Default worker crashes on titles that don't resolve to a page.
Wed, Aug 5, 10:01 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman added a comment to T433096: Default worker crashes on titles that don't resolve to a page.

The // NoneType TypeError no longer appears on the default worker after deploy

I'm still seeing such errors, but they might be a different issue:

worker-default-1  | [2026-08-05 03:43:54,335: ERROR/ForkPoolWorker-4] Task api.tasks.process_article[75c29b79-137d-4b89-8af3-4e5707ff2caa] raised unexpected: TypeError('sequence item 2: expected str instance, NoneType found')
worker-default-1  | Traceback (most recent call last):
worker-default-1  |   File "/app/api/utils_pickles.py", line 141, in pickle_load
worker-default-1  |     obj = pickle.load(gz)
worker-default-1  |   File "/usr/local/lib/python3.9/gzip.py", line 300, in read
worker-default-1  |     return self._buffer.read(size)
worker-default-1  |   File "/usr/local/lib/python3.9/_compression.py", line 68, in readinto
worker-default-1  |     data = self.read(len(byte_view))
worker-default-1  |   File "/usr/local/lib/python3.9/gzip.py", line 506, in read
worker-default-1  |     raise EOFError("Compressed file ended before the "
worker-default-1  | EOFError: Compressed file ended before the end-of-stream marker was reached
worker-default-1  | 
worker-default-1  | During handling of the above exception, another exception occurred:
worker-default-1  | 
worker-default-1  | Traceback (most recent call last):
worker-default-1  |   File "/app/api/tasks.py", line 28, in process_article_task
worker-default-1  |     with WPHandler(page_title, page_id=page_id, revision_id=revision_id, language=language, is_user_request=is_user_request) as wp:
worker-default-1  |   File "/app/api/handler.py", line 339, in __enter__
worker-default-1  |     self.wikiwho = pickle_load(self._load_path)
worker-default-1  |   File "/app/api/utils_pickles.py", line 141, in pickle_load
worker-default-1  |     obj = pickle.load(gz)
worker-default-1  |   File "/usr/local/lib/python3.9/site-packages/billiard/pool.py", line 229, in soft_timeout_sighandler
worker-default-1  |     raise SoftTimeLimitExceeded()
worker-default-1  | billiard.exceptions.SoftTimeLimitExceeded: SoftTimeLimitExceeded()
worker-default-1  | 
worker-default-1  | During handling of the above exception, another exception occurred:
worker-default-1  | 
worker-default-1  | Traceback (most recent call last):
worker-default-1  |   File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 385, in trace_task
worker-default-1  |     R = retval = fun(*args, **kwargs)
worker-default-1  |   File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 648, in __protected_call__
worker-default-1  |     return self.run(*args, **kwargs)
worker-default-1  |   File "/app/api/tasks.py", line 78, in process_article
worker-default-1  |     process_article_task(language, page_title, cache_key_timeout=default_task_soft_time_limit)
worker-default-1  |   File "/app/api/tasks.py", line 47, in process_article_task
worker-default-1  |     cache.delete(cache_key)
worker-default-1  |   File "/usr/local/lib/python3.9/site-packages/django/core/cache/backends/memcached.py", line 91, in delete
worker-default-1  |     key = self.make_key(key, version=version)
worker-default-1  |   File "/usr/local/lib/python3.9/site-packages/django/core/cache/backends/memcached.py", line 71, in make_key
worker-default-1  |     return force_str(super(BaseMemcachedCache, self).make_key(key, version))
worker-default-1  |   File "/usr/local/lib/python3.9/site-packages/django/core/cache/backends/base.py", line 102, in make_key
worker-default-1  |     new_key = self.key_func(key, self.key_prefix, version)
worker-default-1  |   File "/app/wikiwho_api/settings_base.py", line 274, in make_key
worker-default-1  |     return ':'.join([key_prefix, str(version), key])

@jsn.sherman Are you able to confirm this is a separate issue? if so, we can close this task I think.

Wed, Aug 5, 9:46 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman moved T433063: vary dashboard detail from viewport, not platform from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.
Wed, Aug 5, 6:23 PM · PersonalDashboard, OKR-Work, Moderator-Tools-Team (Kanban)
jsn.sherman updated the task description for T433850: Local revert-risk scoring and a per-factor explain page for AutoModerator.
Wed, Aug 5, 3:52 AM · Patch-For-Review, Moderator-Tools-Team, Automoderator

Tue, Aug 4

jsn.sherman moved T428679: PersonalDashboard: Support Test Kitchen experiment enrollment and variant-aware instrumentation from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Tue, Aug 4, 7:43 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), OKR-Work (DE1 FY2026-27), PersonalDashboard
jsn.sherman changed the status of T433416: Make PersonalDashboard interfaces use type declarations and enumerations from In Progress to Stalled.

Stalling on T433063; waiting on its patches to get merged

Tue, Aug 4, 6:04 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Technical-Debt, PersonalDashboard, Moderator-Tools-Team (Kanban)
jsn.sherman moved T433063: vary dashboard detail from viewport, not platform from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.
Tue, Aug 4, 6:03 PM · PersonalDashboard, OKR-Work, Moderator-Tools-Team (Kanban)
jsn.sherman reopened T433896: Render the focused module view as a full-screen page as "Open".
Tue, Aug 4, 3:57 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Moderator-Tools-Team (Kanban), Regression, OKR-Work, PersonalDashboard
jsn.sherman merged T433896: Render the focused module view as a full-screen page into T432475: Improve truncation of Review Changes text.
Tue, Aug 4, 3:48 PM · Moderator-Tools-Team (Kanban), OKR-Work (WE1 FY2025-26), PersonalDashboard
jsn.sherman merged task T433896: Render the focused module view as a full-screen page into T432475: Improve truncation of Review Changes text.
Tue, Aug 4, 3:48 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Moderator-Tools-Team (Kanban), Regression, OKR-Work, PersonalDashboard
jsn.sherman updated the task description for T433900: Factor out a shared feed scaffold for dashboard modules.
Tue, Aug 4, 3:30 PM · Moderator-Tools-Team, OKR-Work, PersonalDashboard

Mon, Aug 3

jsn.sherman moved T433900: Factor out a shared feed scaffold for dashboard modules from Inbox to To be estimated on the Moderator-Tools-Team board.
Mon, Aug 3, 10:26 PM · Moderator-Tools-Team, OKR-Work, PersonalDashboard
jsn.sherman moved T433896: Render the focused module view as a full-screen page from Inbox to To be estimated on the Moderator-Tools-Team board.
Mon, Aug 3, 10:25 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Moderator-Tools-Team (Kanban), Regression, OKR-Work, PersonalDashboard
jsn.sherman created T433900: Factor out a shared feed scaffold for dashboard modules.
Mon, Aug 3, 10:22 PM · Moderator-Tools-Team, OKR-Work, PersonalDashboard
jsn.sherman updated the task description for T433896: Render the focused module view as a full-screen page.
Mon, Aug 3, 10:00 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Moderator-Tools-Team (Kanban), Regression, OKR-Work, PersonalDashboard
jsn.sherman renamed T433896: Render the focused module view as a full-screen page from Title: Render the focused module view as a full-screen page to Render the focused module view as a full-screen page.
Mon, Aug 3, 10:00 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Moderator-Tools-Team (Kanban), Regression, OKR-Work, PersonalDashboard
jsn.sherman created T433896: Render the focused module view as a full-screen page.
Mon, Aug 3, 9:59 PM · MW-1.47-notes (1.47.0-wmf.15; 2026-08-11), Moderator-Tools-Team (Kanban), Regression, OKR-Work, PersonalDashboard
jsn.sherman updated the task description for T433850: Local revert-risk scoring and a per-factor explain page for AutoModerator.
Mon, Aug 3, 3:14 PM · Patch-For-Review, Moderator-Tools-Team, Automoderator
jsn.sherman added a comment to T433850: Local revert-risk scoring and a per-factor explain page for AutoModerator.

How the scoring works

Mon, Aug 3, 3:13 PM · Patch-For-Review, Moderator-Tools-Team, Automoderator
jsn.sherman created T433850: Local revert-risk scoring and a per-factor explain page for AutoModerator.
Mon, Aug 3, 3:11 PM · Patch-For-Review, Moderator-Tools-Team, Automoderator

Sun, Aug 2

jsn.sherman added a comment to T433791: Requesting access to deployment for Chlod Alejandro.

@Chlod is a solid technical contributor who has demonstrated good judgement in the years we have known each other. Exactly the kind of human you want to have on hand for backports and troubleshooting. Let's do this!

Sun, Aug 2, 12:14 PM · SRE, SRE-Access-Requests

Sat, Jul 25

jsn.sherman moved T432595: Restore the server render contract (islands architecture) from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.
Sat, Jul 25, 11:11 AM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), OKR-Work, Patch-For-Review, PersonalDashboard
jsn.sherman moved T432779: Render Policies & Guidelines server-side on the render contract from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.
Sat, Jul 25, 11:10 AM · MW-1.47-notes (1.47.0-wmf.14; 2026-08-04), Moderator-Tools-Team (Kanban), PersonalDashboard, OKR-Work

Fri, Jul 24

jsn.sherman updated the task description for T432779: Render Policies & Guidelines server-side on the render contract.
Fri, Jul 24, 8:00 PM · MW-1.47-notes (1.47.0-wmf.14; 2026-08-04), Moderator-Tools-Team (Kanban), PersonalDashboard, OKR-Work
jsn.sherman moved T432773: Decouple the dashboard from the Minerva skin from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.
Fri, Jul 24, 7:47 PM · MW-1.47-notes (1.47.0-wmf.14; 2026-08-04), OKR-Work, PersonalDashboard, Moderator-Tools-Team (Kanban)
jsn.sherman added a comment to T432773: Decouple the dashboard from the Minerva skin.

Okay the new T433063 drops the mobile/desktop axis from rendering entirely, so nothing keys on the skin or wgMFMode for layout anymore. Detail (compact vs full) is now viewport-driven through a useViewport composable in the dashboard app; islands, integrations included, receive detail and never sniff for themselves, so the behaviour is consistent by construction and width-driven rather than skin- or wgMFMode-based. Util::isMobile() survives only as a server-side analytics label, out of the render path.

Fri, Jul 24, 7:47 PM · MW-1.47-notes (1.47.0-wmf.14; 2026-08-04), OKR-Work, PersonalDashboard, Moderator-Tools-Team (Kanban)
jsn.sherman claimed T433063: vary dashboard detail from viewport, not platform.
Fri, Jul 24, 7:27 PM · PersonalDashboard, OKR-Work, Moderator-Tools-Team (Kanban)
jsn.sherman changed the status of T433063: vary dashboard detail from viewport, not platform from Open to In Progress.

I had to make some choices along the way to get through the implementation:

Fri, Jul 24, 5:28 PM · PersonalDashboard, OKR-Work, Moderator-Tools-Team (Kanban)
jsn.sherman set the point value for T433096: Default worker crashes on titles that don't resolve to a page to 1.
Fri, Jul 24, 3:46 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman changed the status of T433096: Default worker crashes on titles that don't resolve to a page from Open to In Progress.
Fri, Jul 24, 3:26 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman triaged T433096: Default worker crashes on titles that don't resolve to a page as Low priority.
Fri, Jul 24, 3:26 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman created T433096: Default worker crashes on titles that don't resolve to a page.
Fri, Jul 24, 3:26 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman created T433063: vary dashboard detail from viewport, not platform.
Fri, Jul 24, 1:32 PM · PersonalDashboard, OKR-Work, Moderator-Tools-Team (Kanban)

Thu, Jul 23

jsn.sherman moved T432773: Decouple the dashboard from the Minerva skin from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.
Thu, Jul 23, 7:05 PM · MW-1.47-notes (1.47.0-wmf.14; 2026-08-04), OKR-Work, PersonalDashboard, Moderator-Tools-Team (Kanban)
jsn.sherman moved T432779: Render Policies & Guidelines server-side on the render contract from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.
Thu, Jul 23, 7:05 PM · MW-1.47-notes (1.47.0-wmf.14; 2026-08-04), Moderator-Tools-Team (Kanban), PersonalDashboard, OKR-Work
jsn.sherman moved T432595: Restore the server render contract (islands architecture) from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.
Thu, Jul 23, 7:05 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), OKR-Work, Patch-For-Review, PersonalDashboard
jsn.sherman added a comment to T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic.

normalized message error count as of backport was 10,273. It looks like it has stopped, but we'll keep this open for a bit.

Thu, Jul 23, 3:52 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman added a comment to T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic.

thanks @kostajh for the quick patch and @MusikAnimal for the quick backport; let's keep an eye on the error rate now that the patch is out on wmf.12

Thu, Jul 23, 3:49 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman merged T432767: TypeError: MediaWiki\Extension\AutoModerator\Util::getMultiLingualThreshold(): Return value must be of type float, string returned into T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic.
Thu, Jul 23, 3:21 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman merged task T432767: TypeError: MediaWiki\Extension\AutoModerator\Util::getMultiLingualThreshold(): Return value must be of type float, string returned into T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic.
Thu, Jul 23, 3:20 PM · Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman triaged T432767: TypeError: MediaWiki\Extension\AutoModerator\Util::getMultiLingualThreshold(): Return value must be of type float, string returned as Unbreak Now! priority.
Thu, Jul 23, 3:19 PM · Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman triaged T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic as Unbreak Now! priority.
Thu, Jul 23, 3:18 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman changed the status of T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic from Open to In Progress.
Thu, Jul 23, 3:18 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman moved T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic from Ready to QA on the Moderator-Tools-Team (Kanban) board.
Thu, Jul 23, 3:18 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman edited projects for T432910: TypeError: MediaWiki\Extension\AutoModerator\AutoModeratorRevisionStore::__construct(): Argument #6 ($maxReverts) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.12/extensions/AutoModerator/src/Servic, added: Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Thu, Jul 23, 3:18 PM · MW-1.47-notes (1.47.0-wmf.13; 2026-07-28), Moderator-Tools-Team (Kanban), Automoderator, Wikimedia-production-error
jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

Thank you so much for this, Jason! I learned a lot.

note that I initially set the env to "production" during vm setup, but I should have set it to "main" for this project. It didn't do any harm, but deploys weren't going to get through that way. I updated the instance metadata and the patches are auto deploying as expected.

I thought you were referring to a Django env var akin to Symfony's APP_ENV, in which case something like production made sense. I should have asked! Oh well, no harm no foul.

If you want, we can create a production branch so that it matches other Mod Tools repos. That might prevent accidental deploys and such.

Thu, Jul 23, 2:54 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman created T432979: Gerrit is down.
Thu, Jul 23, 2:32 PM · Wikimedia-Incident, Continuous-Integration-Infrastructure, Collaboration-Services, Gerrit

Wed, Jul 22

jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

note that I initially set the env to "production" during vm setup, but I should have set it to "main" for this project. It didn't do any harm, but deploys weren't going to get through that way. I updated the instance metadata and the patches are auto deploying as expected.

Wed, Jul 22, 11:57 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

okay, looking better with the patch. before:

Screenshot From 2026-07-22 18-47-35.png (1,812×305 px, 64 KB)

after:
Screenshot From 2026-07-22 18-54-38.png (1,820×345 px, 61 KB)

Wed, Jul 22, 11:55 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

I'm seeing some jobs succeed and a lot fail with the smell of binary incompatibility. Initially, I was worried that I did this, but I don't think so:
AttributeError("'Wikiwho' object has no attribute 'spam_hashes_set'")

Wed, Jul 22, 11:09 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman moved T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS from Eng review to QA on the Moderator-Tools-Team (Kanban) board.

Okay, we're back up and running; expect things to be shaky as the box warms up and tries to handle requests. @Ragesoss can you check your dashboard?

Wed, Jul 22, 10:45 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

The web proxies are connected to the new host, but I have all of the services down on it, so I find that not surprising. Let's recheck when we're back up.

Wed, Jul 22, 9:52 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

chown finished on another pickle store; that's pickles-02 and pickles-03 done. We're just waiting on pickles now. (note that I kicked them off in parallel since it's 3 separate volumes)

Wed, Jul 22, 9:06 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho
jsn.sherman added a comment to T432147: WikiWho: Replace deprecated Bullseye VM in Cloud VPS.

Note that the django database moved and we validated (on accident) that pickles were resolving, but we're still waiting on chown to finish fixing up permission across 2/3 stores. Web proxies are moved over, services are configured, but we have them all shutdown pending the chown. I'll check in periodically and update here when things are back up and running.

Wed, Jul 22, 8:22 PM · Essential-Work, Moderator-Tools-Team (Kanban), WikiWho