By the way, does it make sense to use this functionality in iPad banners?
I added the text form the control banner. It's almost the same, only
Wikipedia wird durch Spenden von durchschnittlich 20 € finanziert.
is replaced by
Wikipedia wird durch Spenden von durchschnittlich 20 € finanziert, aber 99 % der Leserinnen und Leser spenden nicht.
I accidentally found a bug: When changing the payment interval after entering a custom amount, the form validation fails and a message asks me to pick an amount.
Implementation happens in T209498 and its subtask.
The sentence replacement looks like you want it to be bold. Do you? And if yes, what about the sentence that currently is bold?
It's not mentioned in the task description, but the link to "use-of-funds" should pass skin=0 to make sure people see the new skin.
Never mind, I added the remaining issue to the acceptance criteria in a follow-up task.
Tue, Nov 13
The banners of mobile enwiki (T207551) still seem to use the outdated values. The others are fine now, so I guess it just wasn't deployed. Can you please have another look?
looks fine, thanks a lot!
Yes, I already changed that, while you were proof-reading. Thanks!
Looks fine, thank you!
I just checked. The banners for the mobile and ipad campaigns mentioned in the description are still using the outdated file. All other banners (also on wikipedia.de) are fine.
The progress bar is there, but it seems that the banners are still accessing the outdated BannerValues.js.
Thanks a lot for fixing!
The submit button in the large banner disappears when hovering. And the period after the highlighted text is missing (as Till already mentioned in the parent task).
@Tim_WMDE Not urgently. This can wait until after we started the campaign.
Mon, Nov 12
The campaigns for mobile devices on enwiki (T207551) and dewiki (T207490) contain a link to page/Transparenz. If I remember correctly, that this URL was redirected/rewritten to the newly implemented page, the banners for these campaigns are fine.