Page MenuHomePhabricator

kamholz
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2020, 9:46 PM (61 w, 3 d)
Availability
Available
LDAP User
David Kamholz
MediaWiki User
Unknown

Recent Activity

Wed, Mar 31

kamholz added a comment to T278623: Create a Section for Numerically Sequencing Images on Index ns.

I'm not sure if that would work because that would require parsing the text in a new format that we would have to define -- for example, newlines might be significant in this format whereas they weren't previously. There are probably also multiple possible ways to resolve the file name -- could be on another wiki, for example. I think it makes more sense to just use the existing wikitext facility for making links. Someone could make a tool to generate the wikitext from a list like you gave, though.

Wed, Mar 31, 12:11 AM · ProofreadPage

Tue, Mar 30

kamholz added a comment to T278623: Create a Section for Numerically Sequencing Images on Index ns.

Thanks for explaining the issues with PDF. I expected it would be something like that but it's good to see it all spelled out.

Tue, Mar 30, 9:24 PM · ProofreadPage
kamholz added a comment to T278623: Create a Section for Numerically Sequencing Images on Index ns.

For example, https://en.wikisource.org/wiki/Index:Lippincotts_Monthly_Magazine_51 has 1042 pages that you would need to number individually instead of being to set the numbering using page ranges.

Tue, Mar 30, 4:38 PM · ProofreadPage
kamholz added a comment to T278623: Create a Section for Numerically Sequencing Images on Index ns.

Update, while reading the documentation for Proofread page (1). I discovered that you can transclude an image sequence using the format <pages index="Index Name" from="Start Image" to="End Image"/> even if the images are in a different format. This implies that at some point, the code does numerically sequence the image files. However, on the Index ns <pagelist /> does not work. This implies that the Index ns is not aware or make usage of the numerical sequence that exists.

Tue, Mar 30, 5:36 AM · ProofreadPage

Feb 3 2021

kamholz updated the task description for T263082: add <langconvert> parser tag.
Feb 3 2021, 4:08 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review
kamholz added a comment to T47779: LanguageConverter for Javanese (from jv-Latn to jv-Java).

Thank you @Joseagush for adding me into this thread. The Balinese-Latin converter indeed so usefull! Thanks also to @kamholz for bringing the source-code here. I will adapt it for Latin-Sundanese transliteration.

Feb 3 2021, 4:06 AM · I18n, MediaWiki-Language-converter

Feb 1 2021

kamholz added a comment to T47779: LanguageConverter for Javanese (from jv-Latn to jv-Java).

Hi @kamholz, one of Sundanese Wikipedia community ask me to help this ticket for Javanese script (and Sundanese script as well). I asked your help as your same experience when adding Balinese script which already deployed last year. Let me know if you need help from the wikipedia community. At least, you can give some advice here what must they prepared for Transliteration/LanguageConverter. Thanks in advance.

Feb 1 2021, 8:36 AM · I18n, MediaWiki-Language-converter

Jan 29 2021

kamholz updated the task description for T271758: Support and require BCP 47 tags in <langconvert> arguments.
Jan 29 2021, 4:32 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), MediaWiki-Language-converter, MediaWiki-Parser

Jan 11 2021

kamholz added a comment to T263082: add <langconvert> parser tag.

Just created a new task for this.

Jan 11 2021, 10:27 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review
kamholz created T271758: Support and require BCP 47 tags in <langconvert> arguments.
Jan 11 2021, 10:26 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), MediaWiki-Language-converter, MediaWiki-Parser

Jan 8 2021

kamholz added a comment to T263082: add <langconvert> parser tag.

Better is to the use always the BCP 47 conform language codes:

<span lang="sr-Cyrl"><langconvert from="sr-Latn" to="sr-Cyrl">zdravo</langconvert></span>
Jan 8 2021, 10:39 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review

Dec 31 2020

kamholz added a comment to T270924: ProofreadPage should support jpg/png as single-page documents.

Joseagush explains the use case in the link to the talk page in the task description. The contributors in Bali are cataloging a large number of manuscripts and converting to PDF is an additional step which is not trivial for them and has resulted in decreased image resolution with their attempts so far. I'm not going to say there is no way to get around this but I also think it's important to make Wikisource accessible to smaller communities like this. They've made a lot of progress already in learning the technical aspects of Wikimedia sites. Just keep in mind that their capacity is still limited, so if they need to learn any new processes (such as img2pdf which would require them to use Python on Windows, use the command line, etc.) then we should be sure it's really needed.

Dec 31 2020, 5:31 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), ProofreadPage

Dec 29 2020

kamholz created T270924: ProofreadPage should support jpg/png as single-page documents.
Dec 29 2020, 8:25 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), ProofreadPage

Dec 17 2020

kamholz added a comment to T263082: add <langconvert> parser tag.

Added to https://meta.wikimedia.org/wiki/Tech/News/2020/52 – please let me know if there are any mistakes in the text.

Dec 17 2020, 1:57 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review

Dec 15 2020

kamholz renamed T263082: add <langconvert> parser tag from add #transliterate parser function to add <langcovnert> parser tag.
Dec 15 2020, 8:40 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review

Oct 24 2020

kamholz updated the task description for T263082: add <langconvert> parser tag.
Oct 24 2020, 12:14 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review

Sep 17 2020

kamholz updated the task description for T263082: add <langconvert> parser tag.
Sep 17 2020, 12:54 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review
kamholz created T263082: add <langconvert> parser tag.
Sep 17 2020, 12:30 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review
kamholz closed T244802: evaluate deploying the MediaWiki ArchiveLeaf extension in production, a subtask of T244796: moving palmleaf.org platform to Balinese Wikisource/Wikipedia, as Declined.
Sep 17 2020, 12:02 AM · Language-Team, Internet-Archive
kamholz closed T244802: evaluate deploying the MediaWiki ArchiveLeaf extension in production as Declined.
Sep 17 2020, 12:02 AM · Wikimedia-Extension-setup, Wikimedia-extension-review-queue, serviceops-radar, Internet-Archive
kamholz closed T260211: ProofreadPage page body template as Declined.
Sep 17 2020, 12:01 AM · Patch-For-Review, ProofreadPage
kamholz closed T259645: ProofreadPage should recognize language specification in Index as Resolved.
Sep 17 2020, 12:00 AM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage

Sep 9 2020

kamholz closed T245474: CORS not enabled for OAuth 2.0 as Resolved.

I did a quick test and it seems to work. Haven't tested with a proper OAuth library.

Sep 9 2020, 8:12 PM · Platform Team Initiatives (API Gateway), Platform Team Workboards (S&F Workboard), MediaWiki-extensions-OAuth

Aug 20 2020

kamholz added a comment to T241953: Search should let you search for the title of a book in any language and give results across languages..

Is there a way to cross-link Wikisource pages across editions, similar to how Wikipedia links articles? Does that even make sense?

Aug 20 2020, 11:32 PM · Discovery-Search, CirrusSearch, Wikisource

Aug 19 2020

kamholz added a comment to T257025: Provide a way of serving high quality scans on a per-page basis at Wikisource (such as those hosted at external source).

Unfortunately I don't have a lot of time to work on it at the moment. There are at least two things that would be involved in porting it:

Aug 19 2020, 6:39 PM · Internet-Archive, ProofreadPage, Wikisource

Aug 17 2020

kamholz added a comment to T245359: Split Bali script locale from "ban" (Balinese).

Any chance we can get this merged soon?

Aug 17 2020, 5:45 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, MediaWiki-Internationalization
kamholz added a comment to T260540: Low resolution of Palm leave images on Malayalam Wikisource makes them hard to read.

I just tested this locally. The issue arises from ProofreadPage's code in getImageWidth. If the width is not set in the index, the default (self::DEFAULT_IMAGE_WIDTH) is 1024. This is presumably meant to avoid excessively large image files, but it's counterproductive in this case.

Aug 17 2020, 4:57 PM · ProofreadPage

Aug 16 2020

kamholz added a comment to T260211: ProofreadPage page body template.

Looking into this a bit further, I'm starting to agree with @Xover that this is not a very good way of achieving what I want. Among the issues:

Aug 16 2020, 10:03 PM · Patch-For-Review, ProofreadPage
kamholz closed T178261: Add option to not create DjVu but just upload PDF as Resolved.
Aug 16 2020, 8:55 PM · Community-Tech, IA Upload

Aug 15 2020

kamholz added a comment to T260211: ProofreadPage page body template.

Here is an example of how it looks on Palmleaf.org currently. It will not look exactly like this on Wikisource of course. Sections like Leaf 1, Leaf 2, Leaf 3 will correspond to pages in the Page namespace. The content prior to the "auto-transliteration" heading is what editors will type, and the transliteration will be added below. It should be interleaved like this, page by page, so that readers don't get lost. Given that, it makes sense to me to make it part of the parser output for each page. This makes transclusion work without further effort, and it means that editors can preview the output while editing the page (which, at least in the case of the Balinese work, definitely helps their proofreading efforts).

Aug 15 2020, 9:08 AM · Patch-For-Review, ProofreadPage
kamholz updated subscribers of T260211: ProofreadPage page body template.

@kamholz I don't understand what it is you're proposing to do here, nor see how it will have applicability outside just Balinese content. From whence comes #transliterate and what does it do? Why hard-code <br> inside ProofreadPage and provide two copies of the text? Why can this not be done with a normal template?

Aug 15 2020, 8:35 AM · Patch-For-Review, ProofreadPage

Aug 13 2020

kamholz added a comment to T257025: Provide a way of serving high quality scans on a per-page basis at Wikisource (such as those hosted at external source).

This is related to something PanLex is currently doing in a gadget I've recently ported from Palmleaf.org. There's a community in Bali that's been doing Balinese palm-leaf manuscript transcription there and it's in the process of being moved to Wikisource. The manuscript scans all come from IA. I've already batch uploaded them to Commons using PDFs from IA.

Aug 13 2020, 8:09 PM · Internet-Archive, ProofreadPage, Wikisource

Aug 12 2020

kamholz added a project to T260211: ProofreadPage page body template: ProofreadPage.
Aug 12 2020, 5:21 AM · Patch-For-Review, ProofreadPage
kamholz created T260211: ProofreadPage page body template.
Aug 12 2020, 3:12 AM · Patch-For-Review, ProofreadPage

Aug 10 2020

kamholz added a comment to T245359: Split Bali script locale from "ban" (Balinese).

I've just uploaded a new patchset that splits out ban-latn. There are now three codes:

Aug 10 2020, 7:06 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, MediaWiki-Internationalization

Aug 8 2020

kamholz added a comment to T259963: Multiple Index: and Page: wikipages for a single File:.

Thanks! Yes, I can see how this would be a useful feature to have. It's not currently needed for the Balinese work I am doing, but I can imagine it could be needed in the future for the annotation use case. Annotation/correction of manuscripts is certainly a thing people do.

Aug 8 2020, 5:37 PM · ProofreadPage, Wikisource

Aug 6 2020

kamholz added a comment to T245359: Split Bali script locale from "ban" (Balinese).

Option 1 means we don't do any Bali script. To have both scripts, one of which default, we do as said in option 2. A recent minimal example is b39b3944dc8.

The languages need to be configured properly and we'll also need to move the messages to the locale with their real script.

Aug 6 2020, 4:15 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, MediaWiki-Internationalization
kamholz added a comment to T259645: ProofreadPage should recognize language specification in Index.

I don't think the language field should be completely unvalidated. In its current state, a user can (hypothetically) enter bn, Bengali, bengali, bangla, Bangla ( all of which refer to the Bengali language ) but only one of which will result in the desired change of the page language (bn).

I think an OOUI select widget which presents the user with a list of available languages while also allowing arbitrary user input could be a possible way to go. That would work in preventing users from making mistakes such as the above while also allowing users to specify unknown/unsupported languages if they need to.

Aug 6 2020, 6:16 AM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage
kamholz added a comment to T245359: Split Bali script locale from "ban" (Balinese).

I've now had a chance to discuss this with Joseagush, one of the main coordinators Balinese Wikipedia. His strong preference is for option 1: ban should be Latin-only and ban-bali should be for Balinese script. His argument is that most Balinese language online is in Latin script, and most Balinese people expect Latin and may not be comfortable with Balinese script. Another advantage is that this maintains compatibility with the coding used on ban.wikipedia.org, so that work on Balinese Wikisource (which will contain a good amount of Balinese script) will not unnecessarily interfere with existing Balinese content on Wikimedia. (Incidentally, this also seems to be how Javanese works: jv is Latin script and jv-java is Javanese script.)

Aug 6 2020, 1:44 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, MediaWiki-Internationalization

Aug 5 2020

kamholz added a comment to T259645: ProofreadPage should recognize language specification in Index.

New patchset is uploaded now. There is currently no validation of the Index page's language code, but that is arguably the preferable behavior, because Wikisource editors can add sources in whatever language they want for whatever reason they want, and thousands of languages will not be in the list known to LanguageNameUtils::getLanguageNames. To allow this freedom I think the Index field should not be further validated. It isn't currently possible to set the page language to a language not in the Names.php list (I guess for good reason? don't know), but at least it can be recorded accurately in the Index this way.

Aug 5 2020, 8:23 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage
kamholz updated subscribers of T259645: ProofreadPage should recognize language specification in Index.
Aug 5 2020, 8:14 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage
kamholz added a comment to T259645: ProofreadPage should recognize language specification in Index.

Based on @Tpt's comments on Gerrit, it looks like it's a lot cleaner to override getPageLanguage in the PageContentHandler to return the language based on the current Index value, and not modify page_lang in the database. Working on an updated patchset now -- there are a couple other things to address beyond that.

Aug 5 2020, 5:03 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage
kamholz added a comment to T259645: ProofreadPage should recognize language specification in Index.

It's still possible to override the pagelang on individual pages in the Page namespace by using Special:PageLanguage as usual. Also, if you change the Index's langcode and the pagelang of anything in a corresponding Page doesn't match, it's left alone. Example:

Aug 5 2020, 9:09 AM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage

Aug 4 2020

kamholz updated subscribers of T259645: ProofreadPage should recognize language specification in Index.
Aug 4 2020, 5:24 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage
kamholz created T259645: ProofreadPage should recognize language specification in Index.
Aug 4 2020, 5:22 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), ProofreadPage

Jul 29 2020

kamholz added a comment to T178261: Add option to not create DjVu but just upload PDF.

I think I see a fix for this, but you'll have to test it on toolforge -- shall I submit another PR on GitHub?

Jul 29 2020, 5:35 AM · Community-Tech, IA Upload
kamholz added a comment to T178261: Add option to not create DjVu but just upload PDF.

Must be an issue with views/template.twig, where it does this:

Jul 29 2020, 5:23 AM · Community-Tech, IA Upload

Mar 9 2020

kamholz closed T247142: add Balinese script fonts as Resolved.
Mar 9 2020, 3:25 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Patch-For-Review, UniversalLanguageSelector

Mar 7 2020

kamholz added a comment to T247142: add Balinese script fonts.

I haven't designed a MediaWiki-specific input method for Balinese script. I'm not sure what should be done for T245360: Add input method for ban-Bali (Balinese in Bali script). I did design a Keyman keyboard. The Keyman stuff is highly context-sensitive and the rules are pretty complex. What's the format/language for input methods?

Mar 7 2020, 12:28 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Patch-For-Review, UniversalLanguageSelector

Mar 6 2020

kamholz created T247142: add Balinese script fonts.
Mar 6 2020, 11:15 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Patch-For-Review, UniversalLanguageSelector

Feb 24 2020

kamholz added a comment to T244796: moving palmleaf.org platform to Balinese Wikisource/Wikipedia.

FYI the latest proposal has been submitted as a project grant: https://meta.wikimedia.org/wiki/Grants:Project/PanLex/Balinese_palm-leaf_transcription_platform_on_Wikisource

Feb 24 2020, 11:03 PM · Language-Team, Internet-Archive

Feb 18 2020

kamholz added a comment to T245475: OAuth 2.0 consumer form is not consistent with implementation.

Based on recent comments in the above-referenced GitHub issue for oauth2-server, it looks like current best practice is not to allow callback prefixes of any kind. That means it's just the OAuth consumer proposal form that needs to be updated.

Feb 18 2020, 11:10 PM · Platform Team Initiatives (MW REST API in PHP), MediaWiki-extensions-OAuth
kamholz added a comment to T245475: OAuth 2.0 consumer form is not consistent with implementation.

The easily fixable issue I had was that I had registered the callback URI as http://localhost:3000 but the library I was using was passing it to the server as http://localhost:3000/, which was enough to cause a mismatch. I registered a new consumer with the slash on the callback URI and it works now.

Feb 18 2020, 4:34 AM · Platform Team Initiatives (MW REST API in PHP), MediaWiki-extensions-OAuth
kamholz closed T245232: can't use new OAuth2 consumer archiveleaf-test as Resolved.

I've resolved some of the issues and turned remaining issues into separate tasks.

Feb 18 2020, 12:34 AM · MediaWiki-extensions-OAuth, Platform Team Initiatives (OAuth 2.0)
kamholz created T245475: OAuth 2.0 consumer form is not consistent with implementation.
Feb 18 2020, 12:33 AM · Platform Team Initiatives (MW REST API in PHP), MediaWiki-extensions-OAuth
kamholz created T245474: CORS not enabled for OAuth 2.0 .
Feb 18 2020, 12:17 AM · Platform Team Initiatives (API Gateway), Platform Team Workboards (S&F Workboard), MediaWiki-extensions-OAuth

Feb 17 2020

kamholz added a comment to T245232: can't use new OAuth2 consumer archiveleaf-test.

OK, I took several steps just now to investigate this and found the following:

Feb 17 2020, 9:11 PM · MediaWiki-extensions-OAuth, Platform Team Initiatives (OAuth 2.0)

Feb 14 2020

kamholz added a comment to T245232: can't use new OAuth2 consumer archiveleaf-test.

I just tried making a new OAuth 2.0 consumer called archiveleaf which is not owner-only. It's not approved yet (in fact I requested it not be approved since it's being tested) but my understanding is it should still allow me to authenticate as myself (user Lautgesetz). I get the same error.

Feb 14 2020, 7:01 AM · MediaWiki-extensions-OAuth, Platform Team Initiatives (OAuth 2.0)
kamholz updated the task description for T245232: can't use new OAuth2 consumer archiveleaf-test.
Feb 14 2020, 2:39 AM · MediaWiki-extensions-OAuth, Platform Team Initiatives (OAuth 2.0)
kamholz created T245232: can't use new OAuth2 consumer archiveleaf-test.
Feb 14 2020, 2:34 AM · MediaWiki-extensions-OAuth, Platform Team Initiatives (OAuth 2.0)

Feb 10 2020

kamholz added a comment to T244796: moving palmleaf.org platform to Balinese Wikisource/Wikipedia.

By the way, there's the possibility of using the ArchiveLeaf extension to work with palm-leaf manuscript collections in other languages. There are no solid plans for that currently but it's something PanLex is investigating. Just wanted to mention that it may be useful beyond this project.

Feb 10 2020, 10:15 PM · Language-Team, Internet-Archive
kamholz created T244796: moving palmleaf.org platform to Balinese Wikisource/Wikipedia.
Feb 10 2020, 10:13 PM · Language-Team, Internet-Archive