Page MenuHomePhabricator

kostajh (Kosta Harlan)
Staff Software Engineer, Growth Team

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2018, 2:22 PM (233 w, 4 d)
Availability
Available
IRC Nick
kostajh
LDAP User
Unknown
MediaWiki User
KHarlan (WMF) [ Global Accounts ]

Recent Activity

Fri, Dec 2

kostajh moved T323619: NewImpact: Introduce new design to existing newcomers from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Dec 2, 7:21 PM · Patch-For-Review, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh claimed T323619: NewImpact: Introduce new design to existing newcomers.
Fri, Dec 2, 12:32 PM · Patch-For-Review, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh added a comment to T323619: NewImpact: Introduce new design to existing newcomers.

Message appears for existing newcomers who had the Impact module and had visited their homepage before.

Fri, Dec 2, 12:31 PM · Patch-For-Review, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh moved T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data from Inbox to Triaged on the Growth-Team board.
Fri, Dec 2, 12:30 PM · Patch-For-Review, Growth-Team, PageTriage
kostajh moved T321807: action=growthsetmentor ignores blocks from In Progress to QA on the Growth-Team (Current Sprint) board.
Fri, Dec 2, 11:39 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Vuln-MissingAuthz, SecTeam-Processed, Growth-Team (Current Sprint), GrowthExperiments-Mentorship, Security
kostajh claimed T323999: NewPagesFeed_Templates.xml.
Fri, Dec 2, 11:04 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team, PageTriage
kostajh added a subtask for T222310: [EPIC] Positive reinforcement: New Impact Module: T324312: Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews'].
Fri, Dec 2, 8:51 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh added a parent task for T324312: Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews']: T222310: [EPIC] Positive reinforcement: New Impact Module.
Fri, Dec 2, 8:51 AM · GrowthExperiments, Growth-Team (Current Sprint), Wikimedia-production-error
kostajh triaged T324312: Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews'] as High priority.
Fri, Dec 2, 8:51 AM · GrowthExperiments, Growth-Team (Current Sprint), Wikimedia-production-error
kostajh renamed T324312: Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews'] from Exception executing job: refreshUserImpactJob Especial: impactDataBatch=array(100) staleBefore=1669945520 requestId=4c6d2fe59d744a83f1225935 : Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews']: all elements mus to Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews'].
Fri, Dec 2, 8:46 AM · GrowthExperiments, Growth-Team (Current Sprint), Wikimedia-production-error
kostajh updated the task description for T324312: Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews'].
Fri, Dec 2, 8:45 AM · GrowthExperiments, Growth-Team (Current Sprint), Wikimedia-production-error
kostajh created T324312: Exception executing job: refreshUserImpactJob Wikimedia\Assert\ParameterKeyTypeException: Bad value for parameter $json['dailyArticleViews'].
Fri, Dec 2, 8:45 AM · GrowthExperiments, Growth-Team (Current Sprint), Wikimedia-production-error

Thu, Dec 1

kostajh lowered the priority of T324222: Featured content feeds are returning 404 from Unbreak Now! to Needs Triage.

This patch appears to have fixed the issue. Thanks for the ping @kostajh

Thu, Dec 1, 6:33 PM · Platform Team Initiatives (API Gateway), RESTBase, API Platform
kostajh triaged T324222: Featured content feeds are returning 404 as Unbreak Now! priority.

Marking as unbreak now, presumably lots of clients (including maybe apps) are relying on these feeds.

Thu, Dec 1, 5:43 PM · Platform Team Initiatives (API Gateway), RESTBase, API Platform
kostajh updated the task description for T324222: Featured content feeds are returning 404 .
Thu, Dec 1, 5:42 PM · Platform Team Initiatives (API Gateway), RESTBase, API Platform
kostajh renamed T324222: Featured content feeds are returning 404 from https://api.wikimedia.org/feed/v1/wikipedia/en/onthisday/all/12/01 doesn't work to Featured content feeds are returning 404 .
Thu, Dec 1, 5:42 PM · Platform Team Initiatives (API Gateway), RESTBase, API Platform
kostajh added a project to T324222: Featured content feeds are returning 404 : Platform Team Initiatives (API Gateway).

Maybe @daniel or @hnowlan have some ideas?

Thu, Dec 1, 5:41 PM · Platform Team Initiatives (API Gateway), RESTBase, API Platform
kostajh added a project to T324222: Featured content feeds are returning 404 : RESTBase.

The featured content feed and picture of the day https://api.wikimedia.org/feed/v1/wikipedia/en/featured/2022/11/15 don't work either.

Thu, Dec 1, 5:40 PM · Platform Team Initiatives (API Gateway), RESTBase, API Platform
kostajh updated subscribers of T321983: Drop support for userspace patrolling.

That seems reasonable to me. Cc @Samwalton9

Thu, Dec 1, 4:15 PM · Growth-Team, PageTriage
kostajh added a subtask for T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data: T324072: Refactor SQL into its own layer.
Thu, Dec 1, 4:09 PM · Patch-For-Review, Growth-Team, PageTriage
kostajh added a parent task for T324072: Refactor SQL into its own layer: T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data.
Thu, Dec 1, 4:09 PM · Technical-Debt, Growth-Team, PageTriage
kostajh added a parent task for T323908: Refactor Hooks.php to use HookHandlers: T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data.
Thu, Dec 1, 4:09 PM · Patch-For-Review, Growth-Team, Technical-Debt, PageTriage
kostajh added a parent task for T324070: Refactor PageTriage static methods to be non-static: T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data.
Thu, Dec 1, 4:09 PM · Technical-Debt, Growth-Team, PageTriage
kostajh added subtasks for T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data: T323908: Refactor Hooks.php to use HookHandlers, T324070: Refactor PageTriage static methods to be non-static.
Thu, Dec 1, 4:09 PM · Patch-For-Review, Growth-Team, PageTriage
kostajh updated the task description for T222310: [EPIC] Positive reinforcement: New Impact Module.
Thu, Dec 1, 2:51 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh created T324211: Refactor PageTriage to use services with narrow scopes and value objects for passing data.
Thu, Dec 1, 2:39 PM · Patch-For-Review, Growth-Team, PageTriage
kostajh added a comment to T324157: Display ORES in Special:NewPagesFeed even if not installed (for testing).

FWIW, here's how I set up ORES data locally:

Thu, Dec 1, 1:41 PM · PageTriage, Growth-Team
kostajh added a comment to T324157: Display ORES in Special:NewPagesFeed even if not installed (for testing).

One way to do that would be to have a static provider for ApiPageTriageList. That's quite useful for e.g. Selenium tests in CI as well.

Thu, Dec 1, 1:36 PM · PageTriage, Growth-Team
kostajh edited projects for T316478: For redirects, maintenance tag menu should contain {{R to}} {{R from}} tags, added: Growth-Team (Current Sprint); removed Growth-Team.

There will need to be an update to https://en.wikipedia.org/wiki/MediaWiki:PageTriageExternalTagsOptions.js after the patch is merged and goes to production. {F35657097}

Thu, Dec 1, 1:21 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team (Current Sprint), PageTriage
kostajh moved T316478: For redirects, maintenance tag menu should contain {{R to}} {{R from}} tags from Incoming to QA on the Growth-Team (Current Sprint) board.
Thu, Dec 1, 1:20 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team (Current Sprint), PageTriage
kostajh created P42173 (An Untitled Masterwork).
Thu, Dec 1, 1:15 PM
kostajh awarded T324138: "Add an image" for established editors a Love token.
Thu, Dec 1, 12:15 PM · Growth-Structured-Tasks, Image-Suggestions, Growth-Team
kostajh moved T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Dec 1, 11:52 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh added a subtask for T310779: Impact module: Instrument loading times: T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint.
Thu, Dec 1, 11:35 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, Growth-Team (Current Sprint), Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule
kostajh added a parent task for T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint: T310779: Impact module: Instrument loading times.
Thu, Dec 1, 11:35 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh claimed T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint.
Thu, Dec 1, 11:35 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh triaged T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint as Medium priority.
Thu, Dec 1, 11:31 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh renamed T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint from Special:Homepage: Add instrumentation for monitoring transfer size to Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint.
Thu, Dec 1, 11:28 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh added a subtask for T222310: [EPIC] Positive reinforcement: New Impact Module: T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint.
Thu, Dec 1, 11:28 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh added a subtask for T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work: T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint.
Thu, Dec 1, 11:28 AM · Epic, Growth-Team
kostajh added parent tasks for T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint: T222310: [EPIC] Positive reinforcement: New Impact Module, T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.
Thu, Dec 1, 11:28 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh created T324198: Special:Homepage: Add instrumentation for monitoring transfer size and firstPaint.
Thu, Dec 1, 11:27 AM · Patch-For-Review, GrowthExperiments-Homepage, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Performance Issue
kostajh updated the task description for T222310: [EPIC] Positive reinforcement: New Impact Module.
Thu, Dec 1, 9:59 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh added a parent task for T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays: T222310: [EPIC] Positive reinforcement: New Impact Module.
Thu, Dec 1, 9:30 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error
kostajh added a subtask for T222310: [EPIC] Positive reinforcement: New Impact Module: T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays.
Thu, Dec 1, 9:30 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh moved T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Dec 1, 9:30 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error
kostajh moved T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Thu, Dec 1, 9:28 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error
kostajh claimed T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays.
Thu, Dec 1, 9:27 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error
kostajh added a comment to T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays.

Seen on the rest.php endpoint on testwiki, as well as when running the maintenance script.

Thu, Dec 1, 9:22 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error
kostajh triaged T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays as High priority.
Thu, Dec 1, 9:22 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error
kostajh created T324188: Wikimedia\Rdbms\Platform\SQLPlatform::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays.
Thu, Dec 1, 9:22 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Wikimedia-production-error

Wed, Nov 30

kostajh added a comment to T322841: NewImpact: Table list component is not keyboard accessible.

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Screenshot 2022-11-30 at 10.55.43.png (1×854 px, 145 KB)

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

image.png (546×774 px, 59 KB)

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

On Special:Impact, at least, the ?new-impact=1 query seems to work:

https://patchdemo.wmflabs.org/wikis/21a27f92de/w/index.php?title=Special:Impact/Patch_Demo&new-impact=1

Although, it's not really that useful for testing the clock change, because we export static data instead of allowing it to be dynamically generated. Let me see about changing that.

Wed, Nov 30, 8:26 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement
kostajh added a comment to T322841: NewImpact: Table list component is not keyboard accessible.

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Screenshot 2022-11-30 at 10.55.43.png (1×854 px, 145 KB)

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

image.png (546×774 px, 59 KB)

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

On Special:Impact, at least, the ?new-impact=1 query seems to work:

https://patchdemo.wmflabs.org/wikis/21a27f92de/w/index.php?title=Special:Impact/Patch_Demo&new-impact=1

Wed, Nov 30, 8:24 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement
kostajh added a comment to T322841: NewImpact: Table list component is not keyboard accessible.

Pushed a patch for this. Since our "popover" component (CInfoBox/CPopper) does not have yet the clipping arrow the informational text just displays above the clock icon. Hopefully that's fine for now @RHo ?

Screenshot 2022-11-30 at 10.55.43.png (1×854 px, 145 KB)

Hi @Sgs - I tried to create a patchdemo to have a quick look at this but am setill seeing the old impact module (I tried appending ?new-impact=1 but nothing happened):

image.png (546×774 px, 59 KB)

It looks mainly fine for now, but had wanted to confirm that it appears on mouse hover over the clock as well? And secondly, if we should create a separate task to make the styling changes later (adding in the pointer arrow)?

Wed, Nov 30, 8:16 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement
kostajh moved T323034: Clarify what are the two lists of mentors at Special:ManageMentors from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Nov 30, 1:59 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team (Current Sprint), GrowthExperiments-Mentorship
kostajh moved T323253: NewImpact module: Page view data should be limited to when user made their first edit from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Nov 30, 1:21 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
kostajh added a comment to T323253: NewImpact module: Page view data should be limited to when user made their first edit.

(2) Edits that just made (copied from the comment https://phabricator.wikimedia.org/T322410#8426854)

the pageviews for user who just made an edit, will be displayed immediately

Screen Shot 2022-11-28 at 5.00.29 PM.png (1×980 px, 112 KB)

Another example - Time edited seconds ago immediately displays large number of pageviews (because it displays 60 days worth of data), but the sparkline doesn't reflect the actual fluctuations during that time interval.

Screen Shot 2022-11-29 at 8.15.02 PM.png (1×1 px, 168 KB)
Screen Shot 2022-11-29 at 8.21.24 PM.png (1×2 px, 1 MB)

The only case when delayed stats (the clock icon) will be displayed is when a user edits "local" article (i.e. Mavetuna articles in the screenshot below).

Screen Shot 2022-11-29 at 8.38.02 PM.png (1×1 px, 140 KB)

In the current production, the pageviews won't be immediately available

Screen Shot 2022-11-28 at 5.51.46 PM.png (846×860 px, 89 KB)

Wed, Nov 30, 1:19 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
kostajh added a comment to T323748: UserImpact: Adjust time zone correction for page view URLs.

Change 862242 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] UserImpact: Set a specific end date for pageviews application URL

https://gerrit.wikimedia.org/r/862242

Wed, Nov 30, 12:33 PM · Growth-Team (Current Sprint), GrowthExperiments-ImpactModule
kostajh added a comment to T323253: NewImpact module: Page view data should be limited to when user made their first edit.

For @kostajh review
Checked two scenarios in betalabs

(1) Edits made long time ago
The current date - Nov 29/2022 A user made edits on two articles on 10 May 2022 and on one article on Nov 13, 2021 and hasn't edited since.

Screen Shot 2022-11-29 at 7.47.53 PM.png (212×2 px, 149 KB)
Screen Shot 2022-11-29 at 7.54.10 PM.png (1×898 px, 170 KB)

The numbers won't match between the number of pageviews displayed in the Impact module and pageviews stats. end=latest doesn't include the current date.

Wed, Nov 30, 12:14 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
kostajh claimed T323253: NewImpact module: Page view data should be limited to when user made their first edit.
Wed, Nov 30, 12:05 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
kostajh moved T287248: [BUG] Inconsistent question mark graphics in RTL languages in mobile web GrowthExperiments editing help panel from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Nov 30, 11:56 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team (Current Sprint), I18n, RTL
kostajh added a comment to T324092: +2 for Novem_Linguae in mediawiki/extensions/PageTriage.

Support! Thank you for all of your work in reviewing and contributing patches to PageTriage, @Novem_Linguae!

Wed, Nov 30, 11:14 AM · PageTriage, Growth-Team, Gerrit-Privilege-Requests
kostajh added a comment to T254646: Reconsidering how we name things.

Hopefully this is the right place to ask. I am not an English native speaker, so while I can sometimes get technical terms, I don't necessarily get the nuances and context, and history of the words. Hopefully you can give me some advice:

I want to create a quick tool to do some debugging for a Wikipedia-related service. It is important to name the tool to make sure it is identified, not as a proper solution, but as a quick alternative to test a bug. I've heard in the past the expression "poor man's X", for example for Linux one-liners that substitute a proper built tool. However, that doesn't sound to me as very inclusive. The obvious change, "poor person's X" also doesn't look right to me. Can you suggest alternatives that don't refer the gender or economic level of a person, but still convey the quickly put together nature of it? Please apologies if I am making already a mistake while asking.

Wed, Nov 30, 10:30 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), User-brennen, MediaWiki-extensions-General, WMF-General-or-Unknown, MediaWiki-General, Patch-For-Review, Voice & Tone
kostajh added a comment to T310665: Impact module: summary panel.

@Sgs - is the following spec will be implemented in another task?

Thanks Received count - with link to Special:Log?type=thanks filtered by the user

Wed, Nov 30, 10:29 AM · GrowthExperiments-ImpactModule, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Patch-For-Review, Growth-Team (Current Sprint), Growth-Positive-Reinforcement
kostajh updated the task description for T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user.
Wed, Nov 30, 10:28 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule
kostajh triaged T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user as Medium priority.
Wed, Nov 30, 10:27 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule
kostajh created T324087: NewImpact: Thanks Received count should be a link to Special:Log?type=thanks filtered by the user.
Wed, Nov 30, 10:27 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule
kostajh added a comment to T322410: NewImpact: Limit article table list to 5 articles with data and 5 articles pending data.

Checked in betalabs - five articles plus two articles with yet uncounted pageviews are displayed correctly - the scope of this task seem to be done:

Screen Shot 2022-11-28 at 6.19.33 PM.png (1×1 px, 144 KB)

However, two issues discussed in the comments - should they be resolved before deployment?
Added as a comment to T323253 (1) the pageviews for just made edits will be displayed immediately
The current behavior in betalabs:

Screen Shot 2022-11-28 at 5.00.29 PM.png (1×980 px, 112 KB)

In the current production, the pageviews won't be immediately available

Screen Shot 2022-11-28 at 5.51.46 PM.png (846×860 px, 89 KB)

Wed, Nov 30, 10:22 AM · GrowthExperiments-ImpactModule, Growth-Positive-Reinforcement, Growth-Team (Current Sprint)
kostajh added a comment to T323999: NewPagesFeed_Templates.xml.

I would be inclined to keep it, but better document:

Wed, Nov 30, 10:14 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team, PageTriage
kostajh placed T323253: NewImpact module: Page view data should be limited to when user made their first edit up for grabs.

Moving back to ready for development per Elena's QA. Might make sense to do T323748: UserImpact: Adjust time zone correction for page view URLs alongside this one as well.

Wed, Nov 30, 10:08 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
kostajh added a comment to T324070: Refactor PageTriage static methods to be non-static.

I'd say the answer is "it depends".

Wed, Nov 30, 9:58 AM · Technical-Debt, Growth-Team, PageTriage
kostajh closed T234077: Api: Allow enqueueing without unreviewing, a subtask of T207485: Enable page curation tools to be loaded on any page (optionally), as Declined.
Wed, Nov 30, 9:40 AM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageTriage, Growth-Team
kostajh closed T234077: Api: Allow enqueueing without unreviewing as Declined.

Declining per discussion on patch. Please re-open if you'd like to discuss this more.

Wed, Nov 30, 9:40 AM · Patch-Needs-Improvement, Growth-Team-Filtering, User-DannyS712, PageTriage, Growth-Team
kostajh added a comment to T324072: Refactor SQL into its own layer.

I'd start with maybe a single method (addToPageTriageQueue seems like as good as place as any) and think about introducing classes for:

Wed, Nov 30, 9:39 AM · Technical-Debt, Growth-Team, PageTriage
kostajh updated the task description for T321422: Use buildComparison() instead of raw SQL.
Wed, Nov 30, 9:19 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, Wikidata, MediaWiki-extensions-WikimediaMaintenance, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, PageTriage, MediaWiki-extensions-PageAssessments, GlobalUsage, GeoData, MediaWiki-extensions-FlaggedRevs, Notifications, CheckUser, Community-Tech, MediaWiki-Action-API, Discovery-Search, Growth-Team, MediaWiki-REST-API
kostajh updated the task description for T306349: Public-facing API for image suggestions data.
Wed, Nov 30, 9:05 AM · serviceops, Patch-For-Review, API Platform, Wikipedia-Android-App-Backlog (Android Release FY2022-23), Structured-Data-Backlog, Image-Suggestions, Foundational Technology Requests
kostajh added projects to T306349: Public-facing API for image suggestions data: SRE, serviceops.

@LGoto this has API Platform sign off (via Bill's comment above).
@DAbad good to advance with the Extension solution? Not sure who from SRE needs to approve.

Wed, Nov 30, 8:52 AM · serviceops, Patch-For-Review, API Platform, Wikipedia-Android-App-Backlog (Android Release FY2022-23), Structured-Data-Backlog, Image-Suggestions, Foundational Technology Requests
kostajh created P41863 scap fail.
Wed, Nov 30, 8:43 AM

Tue, Nov 29

kostajh added a comment to T229869: Homepage: feedback module.

Maybe we can do both?

Tue, Nov 29, 4:05 PM · Growth-Team-Filtering, Wikimania-Hackathon-2019, GrowthExperiments-Homepage, Growth-Team
kostajh added a comment to T318854: Application Security Review Request : d3.js.

Thanks. What does owning that risk mean, exactly?

In general, it means that the decision to put d3js into production in this fashion (prior to any security review) is a decision completely owned by your team and @DMburugu. Including any potential negative consequences.

Based on https://office.wikimedia.org/wiki/Security/Policy/Risk_Management, are we now supposed to create a risk treatment plan? (And if so, what should that contain -- are there examples?)

That's definitely the best practice - to create a risk mitigation plan. Though for situations like this that doesn't always make sense. Theoretically, the risk mitigation plan would be having a security review performed and mitigating any resultant risk prior to deployment. But given timelines and resource constraints that isn't really an option in this case, and so a default medium risk has been applied and accepted.

Tue, Nov 29, 2:06 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, secscrum, Security, Application Security Reviews
kostajh moved T252980: Support revision/change tags for PageTriage API actions from Incoming to QA on the Growth-Team (Current Sprint) board.
Tue, Nov 29, 12:15 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team (Current Sprint), Platform Team Workboards (External Code Reviews), User-DannyS712, PageTriage, MediaWiki-Action-API
kostajh edited projects for T252980: Support revision/change tags for PageTriage API actions, added: Growth-Team (Current Sprint); removed Growth-Team-Filtering, Growth-Team.
Tue, Nov 29, 12:15 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Growth-Team (Current Sprint), Platform Team Workboards (External Code Reviews), User-DannyS712, PageTriage, MediaWiki-Action-API
kostajh updated the task description for T322841: NewImpact: Table list component is not keyboard accessible.
Tue, Nov 29, 8:28 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement
kostajh updated subscribers of T322841: NewImpact: Table list component is not keyboard accessible.

I think the last item here is what @RHo commented on in T313274#8424377; one should be able to tab to the clock icon, and it should also open a tooltip with the explanatory text.

Tue, Nov 29, 8:28 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement

Mon, Nov 28

kostajh added a comment to T318854: Application Security Review Request : d3.js.

Thanks @sbassett. If I understand correctly, that means we are OK to go ahead with using d3.js in production as early as November 28th. (Realistically, it is more likely to be December 5 when we start putting this in front of users.)

Yes, with the understanding that your team and @DMburugu own the medium risk for that deployment,

Mon, Nov 28, 7:36 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, secscrum, Security, Application Security Reviews
kostajh added a comment to T322410: NewImpact: Limit article table list to 5 articles with data and 5 articles pending data.

Hi again, @kostajh or @Sgs - this is maybe minor regression but I've noticed that the new impact module's clock icon has the message in a browser tooltip on hover, and is not keyboard accessible. It should appear and behave in the same way as before, which is a pop-over info text that is shown either on hover or via keyboard select:

Expected:
image.png (370×766 px, 55 KB)
Actual:
image.png (172×706 px, 34 KB)

Should I file a ticket or can it be resolved as part of this task?

Hmm, agreed that it is changed behavior from the old impact module. From an accessibility standpoint, I wonder if the behavior in the new impact module (the title attribute on the icon) is better, since it doesn't require the non-sighted user to tab into an interface to read the message?

I think it may be worse since it is skipped entirely in keyboard navigation, so think it makes sense to go back to the original interaction.

Mon, Nov 28, 1:33 PM · GrowthExperiments-ImpactModule, Growth-Positive-Reinforcement, Growth-Team (Current Sprint)
kostajh updated subscribers of T313274: Impact Module: Check Accessibility goals & edge cases.

Bringing over another accessibility issue noticed by @RHo

Mon, Nov 28, 1:33 PM · GrowthExperiments-ImpactModule, Patch-For-Review, MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement
kostajh added a comment to T322410: NewImpact: Limit article table list to 5 articles with data and 5 articles pending data.

I found this in the backlog T313176: Impact module: Top viewed articles counts is using unexpected count logic which is related to this task.
We should prioritise T313176 because currently the numbers are misleading and confusing if counts are based on since one's last edit on any article, and not connected to last edit on the specific article.

Mon, Nov 28, 1:32 PM · GrowthExperiments-ImpactModule, Growth-Positive-Reinforcement, Growth-Team (Current Sprint)
kostajh closed T320935: api-testing tests break for GrowthExperiments as Resolved.

I see it, thanks a lot. The tests are not failing with the earlier identified error anymore.

Mon, Nov 28, 1:31 PM · MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), Continuous-Integration-Config, Quibble, ci-test-error, Growth-Team (Current Sprint), GrowthExperiments, Platform Team Initiatives (API Integration Tests)
kostajh added a comment to T323750: Provide early feedback when a patch has job failures.

Ideally Zuul would report immediately when it knows that a change is not going to pass. As you found out that is T248531 which probably should be declined given I don't want to make any change to the legacy forked Zuul code were are using.

you can watch Zuul, but most people don't know to do that

That is indeed a problem. Lot do have the Zuul status page opened and would watch that as CI is progressing.

For a quicker feedback there is T214068 which is to expose in the Gerrit interface the status of the change in Zuul. OpenDev did something like that and showed progress but I never went to integrate it in our interface. I did some work on that front over the last few days, firstly to reformat the Zuul reported messages, then an attempt to integrate the ongoing progress in the UI ( https://gerrit.wikimedia.org/r/859127 ):

zuul_status_in_gerrit.png (498×681 px, 84 KB)

I have two or three changes on that front but none I am pleased with. Eventually Gerrit has an API / UI to expose CI results: https://gerrit.wikimedia.org/r/Documentation/pg-plugin-checks-api.html and I have started porting code to it. The intent is to expose:

  • ongoing processing (by querying the Zuul status page)
  • craft a report (by crawling messages reported by Zuul and other bots)

Zuul 2.5 report in Gerrit Checks UI (865×1 px, 145 KB)

When a job fails and is voting, I guess we can make Gerrit to notify the user via the Web UI. I don't know the JavaScript API needed to do that though but there must be one since Gerrit is able to notify when a new patchset has been uploaded.

Mon, Nov 28, 1:30 PM · Developer Productivity, Continuous-Integration-Infrastructure, Quibble
kostajh added a comment to T322841: NewImpact: Table list component is not keyboard accessible.

I had to check also the option Press Tab to highlight each item on a web page on Safari's Preferences > Advanced

Screenshot 2022-11-25 at 17.37.16.png (902×1 px, 230 KB)

then the behavior is like in Chrome or Firefox (see attachement). Could it be this in your tests as well?
keyboard_safari_impact.gif (1×626 px, 257 KB)

Mon, Nov 28, 1:25 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint), Accessibility, Growth-Positive-Reinforcement
kostajh assigned T322890: Positive Reinforcement: Impact module - finalize copy and QQQ descriptions for TranslateWiki.net to Sgs.
Mon, Nov 28, 1:06 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh moved T322890: Positive Reinforcement: Impact module - finalize copy and QQQ descriptions for TranslateWiki.net from Ready for Development to QA on the Growth-Team (Current Sprint) board.
Mon, Nov 28, 1:06 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Patch-For-Review, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh added a comment to T323908: Refactor Hooks.php to use HookHandlers.

You can still call it "Hooks.php", indeed the "main" HookHandler for PageTriage currently points to that file:

Mon, Nov 28, 12:58 PM · Patch-For-Review, Growth-Team, Technical-Debt, PageTriage
kostajh awarded T323031: Check for mentors who have mentees assigned to them, while not being listed on Special:ManageMentors a Like token.
Mon, Nov 28, 11:45 AM · Growth-Team (Current Sprint), GrowthExperiments-Mentorship
kostajh added a comment to T323619: NewImpact: Introduce new design to existing newcomers.

The main point of this task is to introduce and highlight to existing users that their impact module has changed, so I don't agree with showing it the second time it is seen, it really should be the first time view.

Mon, Nov 28, 11:30 AM · Patch-For-Review, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh updated the task description for T222310: [EPIC] Positive reinforcement: New Impact Module.
Mon, Nov 28, 6:45 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Epic, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)

Sat, Nov 26

kostajh added a comment to T323478: NewImpact: graph does not show the dips and peaks that correspond to the page views.

Change 860942 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact trendcharts: use space better

https://gerrit.wikimedia.org/r/860942

Sat, Nov 26, 1:03 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh moved T323487: NewImpact: Adjust display for single day longest streak from Code Review to QA on the Growth-Team (Current Sprint) board.
Sat, Nov 26, 12:59 PM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), GrowthExperiments-ImpactModule, Growth-Team (Current Sprint)
kostajh moved T230333: Impact Module: number of pageviews in mobile impact preview should be abbreviated from Code Review to QA on the Growth-Team (Current Sprint) board.
Sat, Nov 26, 10:46 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Growth-Team (Current Sprint), GrowthExperiments-ImpactModule, Mobile, GrowthExperiments-Homepage