Page MenuHomePhabricator

kostajh (Kosta Harlan)
Senior Software Engineer (Growth)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2018, 2:22 PM (54 w, 5 h)
Availability
Available
IRC Nick
kostajh
LDAP User
Unknown
MediaWiki User
KHarlan (WMF) [ Global Accounts ]

Recent Activity

Today

kostajh added a comment to T222100: Decide whether creating Phester is actually worth while.

Decision matrix (tentative): https://docs.google.com/spreadsheets/d/1G50XPisubSRttq4QhakSij8RDF5TBAxrJBwZ7xdBZG0/edit#gid=0

Tue, Jun 25, 6:21 PM · Core Platform Team Kanban (Doing), User-Daniel, Code-Health, Core Platform Team (Code Health (TEC13))
kostajh created T226558: Performance review of hover-in/out event logging in GrowthExperiments Special:Homepage.
Tue, Jun 25, 6:08 PM · Growth-Team, Performance, GrowthExperiments-Homepage

Yesterday

kostajh moved T226146: Homepage: minor mobile instrumentation issues from In Progress to Needs PM Review on the Growth-Team (Current Sprint) board.
When I open the question dialog from the mentorship module and start typing in the question box, I correctly get a "enter-question-text" event in the HelpPanel schema. But when I do the same thing in the help module, I do not get a "enter-question-text" event.
Mon, Jun 24, 7:17 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh claimed T226146: Homepage: minor mobile instrumentation issues.
Mon, Jun 24, 6:39 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh edited projects for T226277: Signature should not be at its own line according to cswiki policies, added: Growth-Team (Current Sprint); removed Growth-Team.

@MMiller_WMF when you're back, please weigh in on this. Thanks!

Mon, Jun 24, 6:35 PM · Growth-Team (Current Sprint), User-Urbanecm, Patch-For-Review, GrowthExperiments-Help panel, GrowthExperiments-Homepage, GrowthExperiments
kostajh moved T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Mon, Jun 24, 6:10 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
kostajh updated subscribers of T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.

Can you say more why it's not a blocker?

Mon, Jun 24, 5:10 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
kostajh added a comment to T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.

IMO this is not a blocker for wmf.11 or wmf.10. We are working on a patch so that if pageUpdater->grabParentRevision->getContent() doesn't return a Content object, we won't fail as hard.

Mon, Jun 24, 4:17 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error

Fri, Jun 21

kostajh added a comment to T225218: Consider httpd for quibble instead of php built-in server.

Some benchmarks with quibble + this patch + docker on macOS.

Fri, Jun 21, 8:22 PM · Patch-For-Review, Continuous-Integration-Infrastructure, Quibble
kostajh created P8640 quibble selenium.
Fri, Jun 21, 5:10 PM
kostajh merged T226272: composer test fails with Composer\Downloader\TransportException into T226253: Composer\Downloader\TransportException in CI builds for multiple repositories.
Fri, Jun 21, 5:03 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure)
kostajh merged task T226272: composer test fails with Composer\Downloader\TransportException into T226253: Composer\Downloader\TransportException in CI builds for multiple repositories.
Fri, Jun 21, 5:03 PM · Continuous-Integration-Config
kostajh moved T226076: Homepage: "Invalid parameters" for Pageviews from Impact module from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Jun 21, 2:47 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Thu, Jun 20

kostajh moved T226205: Enable help panel and homepage in Arabic beta wiki from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Jun 20, 7:04 PM · Patch-For-Review, Growth-Team (Current Sprint)
kostajh claimed T226205: Enable help panel and homepage in Arabic beta wiki.
Thu, Jun 20, 6:15 PM · Patch-For-Review, Growth-Team (Current Sprint)
kostajh updated subscribers of T226208: Homepage: do not log HomepageVisit when handling tutorial visit POST requests.

What this bug looks like in practice:

Thu, Jun 20, 6:12 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments
kostajh moved T226208: Homepage: do not log HomepageVisit when handling tutorial visit POST requests from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Thu, Jun 20, 6:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments
kostajh edited projects for T226208: Homepage: do not log HomepageVisit when handling tutorial visit POST requests, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Jun 20, 6:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments
kostajh created T226208: Homepage: do not log HomepageVisit when handling tutorial visit POST requests.
Thu, Jun 20, 6:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments
kostajh moved T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Thu, Jun 20, 4:39 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
kostajh claimed T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.
Thu, Jun 20, 4:39 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
kostajh moved T222836: Mobile Homepage: instrumentation from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Jun 20, 4:17 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh updated subscribers of T220245: Introduce alphabetic pager for Special:EditWatchlist.

@Johan, sorry I don't know, it depends if/when the patch is merged. @Trizek-WMF suggested that we apply the tag now anyway since we know that if merged, it's a user-noticeable worthy task.

Thu, Jun 20, 2:38 PM · User-notice, Growth-Team (Current Sprint), Patch-For-Review, OOUI, MediaWiki-Watchlist, Wikimedia-production-error
kostajh added a comment to T224939: Create an interface for the local-charts ecosystem.

@thcipriani: at least on a mac with homebrew, it's as simple as brew install python

Thu, Jun 20, 2:37 PM · Release-Engineering-Team (Local Dev), Release-Engineering-Team-TODO, Developer Productivity, local-charts
kostajh added a comment to T225941: Homepage: update "posted on" timestamp client-side when overlay is opened.

@kostajh -- if the user continues to see "posted 2 seconds" ago even when a minute has gone by, how long does it take to update?

Thu, Jun 20, 2:26 PM · Growth-Team, Mobile, GrowthExperiments-Homepage, GrowthExperiments
kostajh added a comment to T226146: Homepage: minor mobile instrumentation issues.

Could be due to the validation event error - https://phabricator.wikimedia.org/T222836#5269430.

Thu, Jun 20, 1:43 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
Trizek-WMF awarded T215986: Homepage: help module a Love token.
Thu, Jun 20, 9:10 AM · GrowthExperiments-Homepage, GrowthExperiments- HelpModule, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
kostajh updated the task description for T226144: Fix flaky Selenium test: Rollback without confirmation should perform rollback via GET request without asking the user to confirm.
Thu, Jun 20, 2:15 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Confirmation prompt for rollback action, Continuous-Integration-Infrastructure, Browser-Tests
kostajh created T226144: Fix flaky Selenium test: Rollback without confirmation should perform rollback via GET request without asking the user to confirm.
Thu, Jun 20, 1:43 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Confirmation prompt for rollback action, Continuous-Integration-Infrastructure, Browser-Tests

Wed, Jun 19

kostajh moved T222836: Mobile Homepage: instrumentation from QA to Code Review on the Growth-Team (Current Sprint) board.
Wed, Jun 19, 7:29 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh moved T226041: Homepage and help panel: ask question dialog should be aware of back button from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Jun 19, 7:11 PM · Patch-For-Review, Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-Help panel
kostajh triaged T226106: Three clicks required to exit talk overlay as High priority.
Wed, Jun 19, 2:23 PM · Readers-Web-Backlog, MobileFrontend, MinervaNeue, Mobile

Tue, Jun 18

kostajh claimed T226041: Homepage and help panel: ask question dialog should be aware of back button.
Tue, Jun 18, 6:41 PM · Patch-For-Review, Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-Help panel
kostajh created T226041: Homepage and help panel: ask question dialog should be aware of back button.
Tue, Jun 18, 6:40 PM · Patch-For-Review, Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-Help panel
kostajh moved T222833: Mobile Homepage: Show module details in a mobile overlay from In Progress to QA on the Growth-Team (Current Sprint) board.

It's worth noting that the same problem exists for the help panel -- try editing a page on mobile, opening the help panel, then tapping back. (See also T215430) I'll create a new task for fixing this behavior, and will move this task back into QA.

Tue, Jun 18, 6:39 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh moved T222833: Mobile Homepage: Show module details in a mobile overlay from QA to In Progress on the Growth-Team (Current Sprint) board.
Tue, Jun 18, 6:27 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh moved T226033: Fix loading icons for Start module from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 18, 4:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), GrowthExperiments-Homepage
kostajh moved T226033: Fix loading icons for Start module from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Tue, Jun 18, 4:26 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), GrowthExperiments-Homepage
kostajh added a project to T226033: Fix loading icons for Start module: Growth-Team (Current Sprint).
Tue, Jun 18, 4:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), GrowthExperiments-Homepage
kostajh created T226033: Fix loading icons for Start module.
Tue, Jun 18, 4:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), GrowthExperiments-Homepage
kostajh moved T222836: Mobile Homepage: instrumentation from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 18, 4:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh moved T223142: Homepage: mobile tab scrolling from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 18, 4:24 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
kostajh added a comment to T225850: Homepage: mobile start module text too close.

One thing to check is to use private browsing mode, as non-private browsing mode can cache the HTML, JS and CSS pretty aggressively.

Tue, Jun 18, 3:11 PM · Growth-Team, GrowthExperiments-Homepage, GrowthExperiments, Mobile
kostajh moved T225660: Homepage: recent questions links on mobile go to desktop site from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 18, 2:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
kostajh moved T225746: Homepage: mobile help module recent questions links to top of help desk from Ready for Development to QA on the Growth-Team (Current Sprint) board.

This was occurring because @Etonkovidova created two unclosed <tt> HTML elements in test posts from May 18. While Vector doesn't have an issue with these, Minerva stopped rendering headers after those two comments. I fixed the broken HTML in the comments and jumping to the correct header now works. As for why Minerva did not render the headers after the unclosed HTML elements, I think that should be filed as a separate issue with MinervaNeue

Tue, Jun 18, 2:02 AM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
kostajh awarded T225972: Establish performance budgets for tests of each area of code, and report (later, auto-skip) suites that take too long a Yellow Medal token.
Tue, Jun 18, 1:36 AM · Release-Engineering-Team-TODO, Release-Engineering-Team, MediaWiki-Core-Testing, Code-Health, Epic

Mon, Jun 17

kostajh renamed T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel from Speed up MediaWiki PHPUnit build by running tests in parallel to Speed up MediaWiki PHPUnit build by running integration tests in parallel.
Mon, Jun 17, 5:55 PM · Continuous-Integration-Config, MediaWiki-Core-Testing
kostajh reopened T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel as "Open".

I'd like to revisit this as an experiment using fastest. In my local environment using MediaWiki-Docker-Dev, running the full test suite takes 49 minutes. With fastest, it takes 39 minutes:

Mon, Jun 17, 5:54 PM · Continuous-Integration-Config, MediaWiki-Core-Testing
kostajh created T225962: Help panel: enable storing questions posted.
Mon, Jun 17, 5:31 PM · Growth-Team, GrowthExperiments-Help panel
kostajh edited projects for T225941: Homepage: update "posted on" timestamp client-side when overlay is opened, added: Growth-Team (Current Sprint); removed Growth-Team.

@MMiller_WMF I'll leave this for you to triage, let me know if you have questions!

Mon, Jun 17, 2:47 PM · Growth-Team, Mobile, GrowthExperiments-Homepage, GrowthExperiments
Restricted Application added a project to T225941: Homepage: update "posted on" timestamp client-side when overlay is opened: Growth-Team.
Mon, Jun 17, 2:47 PM · Growth-Team, Mobile, GrowthExperiments-Homepage, GrowthExperiments

Sun, Jun 16

kostajh created T225903: Notice: $wgServerName should be derived from $wgCanonicalServer, not customized..
Sun, Jun 16, 11:19 PM · local-charts
kostajh added a comment to T221434: Ensure we're testing appropriately and not over-testing across Wikimedia-deployed code.

Ensure we're testing appropriately and not over-testing across Wikimedia-deployed code

Sun, Jun 16, 11:15 PM · Release-Engineering-Team-TODO, Release-Engineering-Team, MediaWiki-Core-Testing
kostajh created T225901: Don't deduplicate archive table on new installs.
Sun, Jun 16, 10:59 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MW-1.33-notes, Patch-For-Review, MediaWiki-Core-Testing, Continuous-Integration-Infrastructure, Core Platform Team
kostajh added a comment to T225871: Selenium and PHPUnit: Stop execution on failure.

I would actually object to this: imagine your change has caused multiple test failures that you weren't able to predict in your dev environment (because you didn't have all extensions installed or your environment is otherwise different from our CI).

Sun, Jun 16, 3:58 PM · Patch-For-Review, Continuous-Integration-Config
MaxSem awarded T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline a Love token.
Sun, Jun 16, 5:03 AM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity

Sat, Jun 15

kostajh added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

I want to +1 this as a great idea. Maybe there's a good reason to show as many errors as possible, but I think fail-fast is consistent with our CI infrastructure. As soon as your code fails one test, we can be certain that it's not mergeable, and any further testing is a waste of resources.

Sat, Jun 15, 7:39 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh added a comment to T225871: Selenium and PHPUnit: Stop execution on failure.

Here's an example of Selenium failing early (note I think we'd need to update wdio.conf.js for extensions too?)

Sat, Jun 15, 7:38 PM · Patch-For-Review, Continuous-Integration-Config
kostajh created T225871: Selenium and PHPUnit: Stop execution on failure.
Sat, Jun 15, 7:16 PM · Patch-For-Review, Continuous-Integration-Config
kostajh added a comment to T225218: Consider httpd for quibble instead of php built-in server.

Preliminary test run with Apache was not that thrilling: the selenium page.js test passed in 300 seconds instead of 345 with PHP built in server. I’ll poke at it some more though.

Sat, Jun 15, 2:58 PM · Patch-For-Review, Continuous-Integration-Infrastructure, Quibble

Fri, Jun 14

kostajh moved T225666: Homepage: mobile header style from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Jun 14, 2:31 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
kostajh moved T225665: Homepage: open user and user talk in reading mode from mobile from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Jun 14, 2:27 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage

Thu, Jun 13

kostajh updated the task description for T225758: Create structure test for MediaWikiUnitTestCase usage.
Thu, Jun 13, 9:23 PM · MediaWiki-Core-Testing, Code-Health
kostajh created T225758: Create structure test for MediaWikiUnitTestCase usage.
Thu, Jun 13, 9:22 PM · MediaWiki-Core-Testing, Code-Health
kostajh added a comment to T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.

splitting the unit and integration test runs into different jenkins votes, delivering the former faster,

Thu, Jun 13, 5:50 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config
kostajh added a watcher for Code-Health: kostajh.
Thu, Jun 13, 4:53 PM
kostajh added a comment to T224939: Create an interface for the local-charts ecosystem.

My two cents, I wanted to suggest consideration of PHP and JavaScript as languages to be used for creation of the CLI. In particular Symfony Console for PHP or Commander.js for JS. The main advantages IMHO are that one of these languages would be more friendly to contributions from existing MediaWiki developers. A secondary benefit, again very much IMHO :), is that installing the language and applications in these languages is more straightforward than Python. I haven't evaluated the client libraries for Kubernetes but I imagine they will be usablle.

Thu, Jun 13, 1:37 PM · Release-Engineering-Team (Local Dev), Release-Engineering-Team-TODO, Developer Productivity, local-charts
kostajh committed rQUIBBLEe9f93c7d3534: (wip) Add option for using Apache as server (authored by kostajh).
(wip) Add option for using Apache as server
Thu, Jun 13, 2:36 AM

Wed, Jun 12

kostajh added a comment to T225615: Homepage mobile: the icon image=message not displayed in 'Confirm your email'.

Was fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/516582

Wed, Jun 12, 11:53 PM · Mobile, Growth-Team (Current Sprint), GrowthExperiments-Homepage
kostajh added a comment to T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.

This is what I see on iOS 12

Wed, Jun 12, 7:22 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
kostajh added a comment to T225659: Homepage: different paths to User talk depending on origin tab.

Sure. MinervaNeue contains code (skins/MinervaNeue/resources/skins.minerva.talk/init.js) which takes over control of the Talk tab and displays the talk overlay. That code is currently loaded when viewing the user page or an article page. We could load it on Special:Homepage, but I think we might also need to make some modifications to init.js so it supports overriding the links when added to a Special page, since AMC tabs generally are assumed to be added to content pages and not special pages.

Wed, Jun 12, 7:16 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
kostajh added a comment to T210883: Duplicate messages delivered.
(1) Following the steps in the task description - I did not manage to sent multiple WikiLove messages.
Wed, Jun 12, 6:01 PM · Growth-Team (Current Sprint), good first bug, WikiLove
kostajh added a comment to T220245: Introduce alphabetic pager for Special:EditWatchlist.

The solution proposed in the patch for this task is to implement an alphabetic pager for Special:EditWatchlist. The pager will respect the namespace groupings currently on EditWatchlist, but the maximum number of items rendered per page will be 500 (as opposed to the unlimited number currently). Also, the TOC at the top of EditWatchlist is replaced with a namespace filter, which defaults to (all).

Wed, Jun 12, 5:58 PM · User-notice, Growth-Team (Current Sprint), Patch-For-Review, OOUI, MediaWiki-Watchlist, Wikimedia-production-error
kostajh renamed T220245: Introduce alphabetic pager for Special:EditWatchlist from Special:EditWatchlist fatal timeout from array_search() in oojs-ui/php/Tag.php to Introduce alphabetic pager for Special:EditWatchlist.
Wed, Jun 12, 5:55 PM · User-notice, Growth-Team (Current Sprint), Patch-For-Review, OOUI, MediaWiki-Watchlist, Wikimedia-production-error
kostajh added a comment to T225218: Consider httpd for quibble instead of php built-in server.

Would you be able to run the same benchmark for hhvm as well?

Wed, Jun 12, 2:38 PM · Patch-For-Review, Continuous-Integration-Infrastructure, Quibble

Tue, Jun 11

kostajh moved T222834: Mobile Homepage: Make the user option in the mobile menu go to the homepage from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jun 11, 9:16 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh closed T225339: apihelp-pagetriagelist-param-non_autoconfirmed_users has an extra space as Resolved.

Thanks @DannyS712!

Tue, Jun 11, 6:45 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, User-DannyS712, Growth-Team, PageCuration
kostajh added a comment to T223442: Homepage: include the section link on Mentorship module's questions' edit summaries.

@MMiller_WMF I think what @revi is talking about is this:

Tue, Jun 11, 6:33 PM · Growth-Team, GrowthExperiments-Homepage, User-revi
kostajh moved T222834: Mobile Homepage: Make the user option in the mobile menu go to the homepage from QA to Code Review on the Growth-Team (Current Sprint) board.
Tue, Jun 11, 5:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
kostajh added a comment to T215178: Self-hosted SonarQube.

I think having one or several (HA) VPS nodes is way better than having them in toolforge. We have more control over the node. I might be able to setup something quickly. Is there a help on how to setup a standalone service?

Tue, Jun 11, 5:05 PM · Code-Health-Metrics
kostajh added a comment to T222848: Homepage: traffic from email confirmation success page.

do you recommend that we use the exact same message that is currently used on Special:ConfirmEmail?

Tue, Jun 11, 3:01 PM · Desktop, Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
kostajh added a comment to Blog Post: Introducing the codehealth pipeline beta.

We would like to enable the pipeline for the Translate extension.

@abi_ I created a patch to do this but we have some CI resource issues to sort out before enabling the pipeline for more extensions. I'll let you know if/when it's merged. Note that you'll probably also want to create a sonar-project.properties file in the repo that specifies the source locations. I can work with you on that, but let's get the extension added to the pipeline first.

Tue, Jun 11, 2:45 PM · Continuous-Integration-Infrastructure, Code-Health-Metrics
kostajh added a comment to T179229: Decide whether we want the package-lock.json to commit or ignore.

OK, yes, this is now decided

@Jdforrester-WMF could you please add some more context – is this documented anywhere else?

Not yet. Will add it to https://www.mediawiki.org/wiki/Continuous_integration/Entry_points later today.

Tue, Jun 11, 2:39 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Core Platform Team Backlog (Designing), Services (designing), Front-end-Standards-Group, Continuous-Integration-Infrastructure, MediaWiki-extensions-General
kostajh added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

Would you like to join us to discuss this at the next Data³ meeting?

Tue, Jun 11, 2:21 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh added a comment to T224673: Automate identifying flaky tests.

Just a small note, the comment operator can be used to exclude those (few) results that match the commit messages instead.

Tue, Jun 11, 2:19 PM · Browser-Tests, Continuous-Integration-Infrastructure, Code-Health

Mon, Jun 10

kostajh moved T223138: Homepage: highlight "congratulations for first edit" copy in the last screen of the "ask a question" modal from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Jun 10, 6:11 PM · GrowthExperiments- HelpModule, Mobile, Desktop, GrowthExperiments- MentorshipModule, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Sun, Jun 9

kostajh added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

I'll comment more on Amir's note above on Monday, but for now wanted to add two other ideas:

Sun, Jun 9, 7:42 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity

Fri, Jun 7

kostajh updated the task description for T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.
Fri, Jun 7, 2:35 AM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh renamed T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline from Proposal to move browser based tests (Selenium and QUnit) to a non-voting pipeline to Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.
Fri, Jun 7, 2:02 AM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

Thank you everyone for the discussion!

Fri, Jun 7, 2:02 AM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity

Thu, Jun 6

kostajh updated the task description for T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.
Thu, Jun 6, 8:16 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh updated subscribers of T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.
Thu, Jun 6, 8:14 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh created T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.
Thu, Jun 6, 8:11 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
kostajh added a comment to T224673: Automate identifying flaky tests.

+17,000 one week later. https://gerrit.wikimedia.org/r/q/recheck,17000

Thu, Jun 6, 7:58 PM · Browser-Tests, Continuous-Integration-Infrastructure, Code-Health
kostajh added a project to T225246: Flaky test "I select item in menu - the item is added to the widget": Browser-Tests.
Thu, Jun 6, 7:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Lexicographical data
Restricted Application added a project to T225246: Flaky test "I select item in menu - the item is added to the widget": Wikidata.
Thu, Jun 6, 7:48 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Lexicographical data
kostajh merged task T168570: JavaScript function to update notifications into T219222: Make notification counts update without page reload.
Thu, Jun 6, 7:30 PM · Growth-Team, Collaboration-Team-Triage, Notifications
kostajh merged T168570: JavaScript function to update notifications into T219222: Make notification counts update without page reload.
Thu, Jun 6, 7:30 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Google-Summer-of-Code (2019), Notifications, Growth-Team
Restricted Application added a project to T168570: JavaScript function to update notifications: Growth-Team.

This is being worked on in T219222, so I'm closing this one as a duplicate.

Thu, Jun 6, 7:30 PM · Growth-Team, Collaboration-Team-Triage, Notifications
kostajh added a comment to T179229: Decide whether we want the package-lock.json to commit or ignore.

OK, yes, this is now decided

Thu, Jun 6, 5:30 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Core Platform Team Backlog (Designing), Services (designing), Front-end-Standards-Group, Continuous-Integration-Infrastructure, MediaWiki-extensions-General