Page MenuHomePhabricator

kostajh (Kosta Harlan)
Senior Software Engineer (Growth)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2018, 2:22 PM (123 w, 5 d)
Availability
Available
IRC Nick
kostajh
LDAP User
Unknown
MediaWiki User
KHarlan (WMF) [ Global Accounts ]

Recent Activity

Yesterday

kostajh added a comment to T266389: Make it easier to run integration/unit tests from IDE.

That issue happens when you have code in data providers that requires bootstrapping MediaWiki. If you have simple data providers that don’t access globals or services then there are no issues.

Sun, Oct 25, 2:07 PM · MediaWiki-Core-Testing
kostajh added a comment to T266389: Make it easier to run integration/unit tests from IDE.

Can I ask what you are using for your local dev environment (docker, vagrant, host setup?)

Sun, Oct 25, 1:43 PM · MediaWiki-Core-Testing
kostajh updated subscribers of T266389: Make it easier to run integration/unit tests from IDE.

As for the CI issue, that shouldn't be happening. The unit tests are run with the vendor/bin/phpunit entrypoint and indeed running the command that quibble executes locally shows me a failure:

Sun, Oct 25, 1:23 PM · MediaWiki-Core-Testing
kostajh added a comment to T266389: Make it easier to run integration/unit tests from IDE.

Huh, I thought it wasn't possible to specify the phpunit.php wrapper as the path to phpunit.phar, at least I don't think it worked the last time I tried that a year or two ago. In any case this is what I have in my config:

Sun, Oct 25, 1:09 PM · MediaWiki-Core-Testing

Sat, Oct 24

kostajh added a comment to T266389: Make it easier to run integration/unit tests from IDE.

@Daimona could you provide some screenshots of your config? I have a single configuration for both types of tests although I have two different PHP interpreters since one uses my host PHP and the other (for integration) uses the docker container PHP.

Sat, Oct 24, 4:32 PM · MediaWiki-Core-Testing

Thu, Oct 22

kostajh added a comment to T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load*.

What is implemented in the patch for this task is a little bit different than what the description says, because in the meantime we've done T236738: Newcomer tasks: server-side rendered version of suggested edits module. So, we can render all components of the suggested edits module on the server-side, but we add the skeleton styling for:

  • Article wikidata description
  • Article image
  • Pageview info

Given the above, maybe it makes sense to close this task in favor of T236738: Newcomer tasks: server-side rendered version of suggested edits module.

Agree that the new loading is much better when testing the patchdemo from T236738#6571595 here: https://imgur.com/a/lkYAxu5, most importantly that all elements in the task module are in place so there is no jarring shifting position.
However, one minor visual note is that the page views skeleton should be amended to the same length as the article description placeholder:

Thu, Oct 22, 3:58 PM · Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
kostajh added a comment to T236738: Newcomer tasks: server-side rendered version of suggested edits module.

Test wiki created on Patch Demo by KHarlan (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/0f28ca3e302c5a3ddd0990e2fbb6e726/w/

This looks good on mobile and desktop (see https://imgur.com/a/lkYAxu5), however, one weird thing is that on Desktop the 1st suggestion's image takes a long time to load – in the Desktop example, "Danny Ferry" was taking so long (on 3G speed but still), that I stopped recording, but does definitely have an image. Another strange thing is that when I went to the second and third articles suggested, the images on those articles loaded but when going back to the first article the Danny Ferry image still had not finished loading.

Thu, Oct 22, 3:48 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), Growth-Team-Leftovers, NewcomerTasks 1.0
kostajh added a comment to T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load*.

What is implemented in the patch for this task is a little bit different than what the description says, because in the meantime we've done T236738: Newcomer tasks: server-side rendered version of suggested edits module. So, we can render all components of the suggested edits module on the server-side, but we add the skeleton styling for:

Thu, Oct 22, 2:24 PM · Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
kostajh moved T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load* from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Oct 22, 2:19 PM · Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
kostajh moved T236738: Newcomer tasks: server-side rendered version of suggested edits module from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Oct 22, 2:19 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), Growth-Team-Leftovers, NewcomerTasks 1.0
kostajh claimed T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load*.
Thu, Oct 22, 11:52 AM · Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
kostajh updated the task description for T261408: Add a link engineering: Maintenance script for retrieving, caching, and updating search index.
Thu, Oct 22, 10:26 AM · Growth-Team (Current Sprint), Growth-Structured-Tasks
kostajh closed T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository, a subtask of T265603: Add Link engineering: Add Link Service setup, as Resolved.
Thu, Oct 22, 10:25 AM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh closed T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository as Resolved.
Thu, Oct 22, 10:25 AM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks

Wed, Oct 21

kostajh added a comment to T259658: [Bug] SonarQube bot is not working for push-notifications service.

Meh, I'm now seeing this same issue with T266110: Add Link engineering: Codehealth integration

Wed, Oct 21, 9:23 PM · User-kostajh, Push-Notification-Service, Sonarqubebot, Code-Health, Product-Infrastructure-Team-Backlog
kostajh moved T265893: Add Link engineering: Deployment Pipeline setup from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Oct 21, 10:55 AM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh moved T266110: Add Link engineering: Codehealth integration from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Oct 21, 10:54 AM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh moved T266110: Add Link engineering: Codehealth integration from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Wed, Oct 21, 10:50 AM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh created T266110: Add Link engineering: Codehealth integration.
Wed, Oct 21, 10:49 AM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh added a comment to T262607: Create "EditReminder" Echo Notification (Full Fidelity).

Since this is going to be (potentially) used by Growth maybe it makes sense to use GrowthExperiments extension

  • This way we reduce complexity in Echo
  • Scope looks like it fits well
  • We can feature flag only the Android app for now and if we want to expand to more targets we can just enable it for everyone

@Mholloway @Catrope thoughts?

Wed, Oct 21, 9:40 AM · Patch-For-Review, Growth-Team (Current Sprint), Push-Notification-Service, Notifications, Product-Infrastructure-Team-Backlog

Tue, Oct 20

kostajh claimed T236738: Newcomer tasks: server-side rendered version of suggested edits module.
Tue, Oct 20, 11:26 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), Growth-Team-Leftovers, NewcomerTasks 1.0
kostajh claimed T265893: Add Link engineering: Deployment Pipeline setup.
Tue, Oct 20, 10:49 AM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks

Mon, Oct 19

kostajh added a project to T265893: Add Link engineering: Deployment Pipeline setup: Release-Engineering-Team.

Hi Release-Engineering-Team, @MGerlach and Growth team will be working on implementing the deployment pipeline for https://gerrit.wikimedia.org/r/plugins/gitiles/research/mwaddlink/+/refs/heads/main. It's a python application, and there will be two requirements.txt files, one for building the application with the capability for training a ML model, and the other for a slimmed-down application that handles web requests and queries data dictionaries.

Mon, Oct 19, 6:05 PM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh added a comment to T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository.

@kostajh are there any naming/structuting conventions for virtual environments in production that I should follow? For example, in the solution described above there will be several requirements-files in a reuqirements-folder, with the requirements.txt in the main folder mirroring the production environment.

Mon, Oct 19, 6:02 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh renamed T261403: Move dedcode/mwaddlink from github to gerrit from Move mwaddlink-query from github to gerrit to Move dedcode/mwaddlink from github to gerrit.
Mon, Oct 19, 4:56 PM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh added a comment to T261403: Move dedcode/mwaddlink from github to gerrit.

https://github.com/dedcode/mwaddlink is now imported at https://gerrit.wikimedia.org/r/plugins/gitiles/research/mwaddlink, so we should use gerrit for pushing code / code review now instead of GitHub.

Mon, Oct 19, 4:55 PM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh edited projects for T261408: Add a link engineering: Maintenance script for retrieving, caching, and updating search index, added: Growth-Team (Current Sprint); removed Growth-Team.

I think we can get started on this (possibly breaking out into a couple of subtasks). Since we don't have a production endpoint yet, we we can work with a fake LinkRecommendationService provider for responses.

Mon, Oct 19, 12:37 PM · Growth-Team (Current Sprint), Growth-Structured-Tasks
kostajh created T265894: Add Link engineering: Local environment setup.
Mon, Oct 19, 12:34 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh created T265893: Add Link engineering: Deployment Pipeline setup.
Mon, Oct 19, 12:31 PM · Patch-For-Review, Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh added a comment to T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository.

Looks like the code is in a single repo (and will soon be imported to gerrit, where we should push patches), but leaving this open to implement the multiple requirements.txt approach.

Mon, Oct 19, 12:30 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh added a comment to T265754: Variant C/D: inconsistencies with welcome survey and discovery popups.

This issue is a consequence of logic we implemented in T229044: Homepage: users should only receive one discovery GuidedTour, where we said we didn't want to show the homepage welcome tour to users who had seen the homepage discovery tour, as well as some code in implementing T258009: Variant C/D: welcome popup on desktop where we excluded variant C and D users from the discovery tour.

Mon, Oct 19, 11:59 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team-Leftovers, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint)
kostajh assigned T265556: Variant tests: roll out variant C/D to Catrope.
Mon, Oct 19, 11:45 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
kostajh moved T265404: Redirects should be followed when posting to help desk from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Oct 19, 11:45 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team-Leftovers, Growth-Team (Current Sprint)
kostajh claimed T265592: Expectation (masterConns <= 0) by ApiMain::setRequestExpectations not met (actual: 1):[connect to 10.192.0.120 (mediawikiwiki)].
Mon, Oct 19, 11:44 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
kostajh added a comment to T243445: Deploy Growth features on Turkish Wikipedia.

@Evrifaessa we have it scheduled for deployment later today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20201019T1800

Mon, Oct 19, 11:43 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Growth-Team (Current Sprint), Turkish-Sites
kostajh added a comment to T252391: Reimage one memcached shard to Buster.

@jijiki EditorJourney logging is now switched off. We may at some point want to re-enable but will wait for this work to be finished before doing so.

Mon, Oct 19, 11:19 AM · User-jijiki, Growth-Team (Current Sprint), User-Elukey, Patch-For-Review, Operations, serviceops
kostajh added a comment to T263617: Cannot login to beta cluster: "There seems to be a problem with your login session...".

Two additional problems which I assume have the same underlying problem as this one:

Mon, Oct 19, 10:50 AM · Beta-Cluster-reproducible, Beta-Cluster-Infrastructure
kostajh added a comment to T261448: Newcomer tasks: suggested edits module linebreaks.

Thanks for catching this @Etonkovidova, can we move the icon span to be nested under the task text so that it always wraps with the last word? I think this is what we did with the user avatar icon and user name in the welcome banners.

Mon, Oct 19, 10:41 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team (Current Sprint), Growth Design, I18n, Design, Russian-Sites
kostajh added a comment to T265534: Flow - initiateChange failed to enable Flow on User talk page.

It means that for some users, checking the box to enable Flow for their user talk page fails. The error happens silently, so the user sees in their preferences the box checked for enabling Structured Discussions on their talk page, but when they view their talk page, it's still in its old wikitext format.

Mon, Oct 19, 10:29 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
kostajh added a comment to T70526: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php.

@Etonkovidova -- since you've checked this already, should it be moved to a different column? Which one?

Mon, Oct 19, 10:25 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), MediaWiki-Blocks, User-kostajh, User-brennen, Wikimedia-production-error, StructuredDiscussions
kostajh added a comment to T261403: Move dedcode/mwaddlink from github to gerrit.

The move is in progress, see https://www.mediawiki.org/wiki/Topic:Vw2qibn0ocvx95lp

Mon, Oct 19, 9:46 AM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh added a comment to T265754: Variant C/D: inconsistencies with welcome survey and discovery popups.

Potentially related report by @Dyolf77_WMF via email: "if you ignore the Welcome survey after creating an account, you are asked to enter your password again!"

Mon, Oct 19, 8:34 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team-Leftovers, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint)
kostajh moved T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Oct 19, 8:17 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments

Sat, Oct 17

kostajh added a comment to T252391: Reimage one memcached shard to Buster.

@kostajh Can you confirm whether something does or does not need to change in WikimediaEvents or GrowthExperiments prior to the partial deletion of Redis data for the maintenance here? I see a patch for turning it off, which suggests that partial loss ahead of it might be fine if it is already meant to be turned off. But, I also see a comment at https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/633514/ which says that some logic in WikimediaEvents needs to change first?

Sat, Oct 17, 2:15 PM · User-jijiki, Growth-Team (Current Sprint), User-Elukey, Patch-For-Review, Operations, serviceops

Thu, Oct 15

kostajh created T265610: Add Link engineering: Convert mwaddlink to read/write to MySQL instead of SQLite.
Thu, Oct 15, 1:52 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh added a project to T258978: Service operations setup for Add a Link project: Add-Link.
Thu, Oct 15, 1:47 PM · Add-Link, Growth-Team (Current Sprint), Product-Infrastructure-Team-Backlog, Operations, serviceops, GrowthExperiments-NewcomerTasks
kostajh added a project to T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach: Add-Link.
Thu, Oct 15, 1:47 PM · Add-Link, Growth-Team (Current Sprint), Patch-For-Review, Growth-Structured-Tasks
kostajh renamed T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach from Add a link engineering: Prototype using VisualEditor's data model libraries for rendering sections of wikitext to Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach.
Thu, Oct 15, 1:46 PM · Add-Link, Growth-Team (Current Sprint), Patch-For-Review, Growth-Structured-Tasks
kostajh changed the status of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach from Stalled to Open.

Per discussion yesterday, moving this into our current sprint.

Thu, Oct 15, 1:42 PM · Add-Link, Growth-Team (Current Sprint), Patch-For-Review, Growth-Structured-Tasks
kostajh changed the status of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach, a subtask of T261396: Add a link: engineering tasks for initial release, from Stalled to Open.
Thu, Oct 15, 1:42 PM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh edited projects for T265603: Add Link engineering: Add Link Service setup, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Oct 15, 1:41 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh edited projects for T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Oct 15, 1:41 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh assigned T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository to MGerlach.

Assigning to you, but if you'd like help with this (reviewing or implementing) let Growth-Team know.

Thu, Oct 15, 1:40 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh created T265605: Add Link engineering: Consolidate dedcode/addlink and mgerlach/mwaddlink-query into single repository.
Thu, Oct 15, 1:39 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh removed a subtask for T261396: Add a link: engineering tasks for initial release: T261403: Move dedcode/mwaddlink from github to gerrit.
Thu, Oct 15, 1:38 PM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh added a subtask for T265603: Add Link engineering: Add Link Service setup: T261403: Move dedcode/mwaddlink from github to gerrit.
Thu, Oct 15, 1:38 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh edited parent tasks for T261403: Move dedcode/mwaddlink from github to gerrit, added: T265603: Add Link engineering: Add Link Service setup; removed: T261396: Add a link: engineering tasks for initial release.
Thu, Oct 15, 1:38 PM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh added a project to T261396: Add a link: engineering tasks for initial release: Add-Link.
Thu, Oct 15, 1:37 PM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh created T265603: Add Link engineering: Add Link Service setup.
Thu, Oct 15, 1:37 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
kostajh closed T259035: Add a link: Parsing challenges (input and output), a subtask of T261396: Add a link: engineering tasks for initial release, as Resolved.
Thu, Oct 15, 1:36 PM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh closed T259035: Add a link: Parsing challenges (input and output) as Resolved.

What we've decided to do as our first pass (see meeting notes from October 14 and 15 here):

Thu, Oct 15, 1:36 PM · Add-Link, Parsing-Team--ARCHIVED, Growth-Team, Growth-Structured-Tasks
kostajh placed T264462: [Leftovers] Newcomer homepage: Visual design improvements to the homepage layout on Desktop up for grabs.

My patch assumed we could remove variant A code, which is not true just yet. Unassigning myself in case someone else wants to work on it between now and next week.

Thu, Oct 15, 12:41 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
kostajh moved T264462: [Leftovers] Newcomer homepage: Visual design improvements to the homepage layout on Desktop from In Progress to Ready for Development on the Growth-Team (Current Sprint) board.
Thu, Oct 15, 12:39 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
kostajh moved T265592: Expectation (masterConns <= 0) by ApiMain::setRequestExpectations not met (actual: 1):[connect to 10.192.0.120 (mediawikiwiki)] from Incoming to Code Review on the Growth-Team (Current Sprint) board.

This was making noise in the logs, so while looking at the cause I found it is trivial to fix. Growth engineers -- please do not prioritize code review of this over other pre-defined interlude work; I've added it it to our current sprint so it can go through the normal code review / QA process.

Thu, Oct 15, 12:13 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
kostajh added projects to T265592: Expectation (masterConns <= 0) by ApiMain::setRequestExpectations not met (actual: 1):[connect to 10.192.0.120 (mediawikiwiki)]: StructuredDiscussions, Growth-Team (Current Sprint).
Thu, Oct 15, 12:11 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
kostajh created T265592: Expectation (masterConns <= 0) by ApiMain::setRequestExpectations not met (actual: 1):[connect to 10.192.0.120 (mediawikiwiki)].
Thu, Oct 15, 12:02 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
kostajh added a comment to T261411: Add a link engineering: Determine format for accessing and storing link recommendations.

We are going to have separate tables for each wiki, right?

That wasn't entirely clear to me, if that is the case, that'd put us in a lot better position.

Thu, Oct 15, 11:51 AM · Growth-Team (Current Sprint), Data-Persistence, DBA, Growth-Structured-Tasks
kostajh added a comment to T258978: Service operations setup for Add a Link project.

A problem that we will need to find a solution for is running the model on a stat* server, then updating a production database from there. I don't know of predefined ways to do it, but on that we can ask for an opinion to the analytics team about this.

Thu, Oct 15, 7:53 AM · Add-Link, Growth-Team (Current Sprint), Product-Infrastructure-Team-Backlog, Operations, serviceops, GrowthExperiments-NewcomerTasks

Wed, Oct 14

kostajh added a comment to T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit.

I've +2'ed @Tgr's patch. Leaving in code review for https://gerrit.wikimedia.org/r/634011, which is a follow-up to

Wed, Oct 14, 1:20 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
kostajh added a comment to T261403: Move dedcode/mwaddlink from github to gerrit.
  1. Growth engineers can work with you and Release Engineering to set up the Deployment Pipeline scaffolding
  2. Growth engineers can work with you to create a docker-compose / Dockerfile setup for local development with a MySQL backend as proposed by SRE

not sure what this means. perhaps best to discuss in person.

Wed, Oct 14, 12:42 PM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh moved T264314: Task preview data incorrectly set when user uses non-default task/topic selections from QA to Code Review on the Growth-Team (Current Sprint) board.

Yeah, doesn't look great. This is a separate issue from this task though. I'd propose we handle it in T236738: Newcomer tasks: server-side rendered version of suggested edits module if that's alright?

Wed, Oct 14, 12:12 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
kostajh added a comment to T264314: Task preview data incorrectly set when user uses non-default task/topic selections.

Yeah, doesn't look great. This is a separate issue from this task though. I'd propose we handle it in T236738: Newcomer tasks: server-side rendered version of suggested edits module if that's alright?

Wed, Oct 14, 11:59 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks
kostajh added a comment to T265404: Redirects should be followed when posting to help desk.

I feel like we discussed this ~1-2 years ago and deliberately implemented in this way, but I don't remember why. And it's possible I am misremembering because I didn't find anything in phabricator to support this. The closest I could find is T222206#5150582 but that issue is about page deletion. I agree that following redirects makes sense.

Wed, Oct 14, 11:41 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team-Leftovers, Growth-Team (Current Sprint)
kostajh updated the task description for T265151: Wikimedia Technical Talks November 2020 - Unit tests for MediaWiki PHP code -- tooling, tips, best practices.
Wed, Oct 14, 11:06 AM · Developer-Advocacy (Oct-Dec 2020), Wikimedia-Tech-Talks, Documentation
kostajh renamed T265151: Wikimedia Technical Talks November 2020 - Unit tests for MediaWiki PHP code -- tooling, tips, best practices from Wikimedia Technical Talks November 2020 - Writing PHP unit tests for MediaWiki to Wikimedia Technical Talks November 2020 - Unit tests for MediaWiki PHP code -- tooling, tips, best practices.
Wed, Oct 14, 10:11 AM · Developer-Advocacy (Oct-Dec 2020), Wikimedia-Tech-Talks, Documentation
kostajh moved T264374: Variant C/D: convert legacy users to Variant D (and make it the default) from Code Review to Ready for Development on the Growth-Team (Current Sprint) board.
Wed, Oct 14, 9:20 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint)
kostajh moved T258016: Variant C: onboarding from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 14, 9:19 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
kostajh moved T265422: Help panel does not show progress indicator when posting a question from Incoming to QA on the Growth-Team (Current Sprint) board.
Wed, Oct 14, 8:26 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-Help panel
kostajh added a project to T265422: Help panel does not show progress indicator when posting a question: Growth-Team (Current Sprint).
Wed, Oct 14, 8:26 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-Help panel
kostajh added a comment to T261403: Move dedcode/mwaddlink from github to gerrit.

Second, should this go under mediawiki/services/{service-name}, or somewhere else?

Seems reasonable. I think in the past repos under this namespace were generally owned by the WMF services team so someone may need to fiddle with refs/* owners in gerrit to get it setup correctly (rather than just inherit from mediawiki/services).

Wed, Oct 14, 8:11 AM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh added a comment to T261403: Move dedcode/mwaddlink from github to gerrit.

@kostajh

  1. take https://github.com/martingerlach/mwaddlink-query and move utility methods from https://github.com/dedcode/mwaddlink into it
    1. maybe that involves making a small shared library between the two repos, depending on whether the model trainer also needs access to these methods? The overall goal would be to remove https://github.com/martingerlach/mwaddlink-query/blob/main/addlink-query_links.py#L8-L11

this could work as a temporary solution. the better option would probably be to have a shared library for both the training and the query-part in order to make the parsing is consistent across both. this will probably become more important later as we make tweaks to the training of the model (when seeing what needs improvement when applying to different languages). maybe we can deal with the more general solution later.
I also want to incorporate some of the suggestions mentioned in T258978#6532612

Wed, Oct 14, 8:10 AM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team

Tue, Oct 13

kostajh added projects to T261403: Move dedcode/mwaddlink from github to gerrit: Release-Engineering-Team, serviceops.

if you help me with requesting a gerrit-repo that would be great (no experience with that yet). also

Tue, Oct 13, 7:49 PM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh added a comment to T252391: Reimage one memcached shard to Buster.

Hmm, I spoke too soon. We rely on the wgWMEUnderstandingFirstDay being set in order to oversample in Schema:EditAttemptStep (in WikimediEvents's shouldSchemaEditAttemptStepOversample()), so we need to detangle the configuration value from that method before we can switch off EditorJourney logging. It shouldn't be that complicated -- I think instead of checking to see if wgWMEUnderstandingFirstDay is true, we instead want to see if GrowthExperiments extension is enabled, because we want to oversample edit attempts for all GrowthExperiments users regardless of whether they are opted-in to the Homepage experiment. @nettrom_WMF does that sound right to you?

From what I remember, we have two paths that require oversampling EditAttemptStep:

  1. A user opens the editor during their first 24 hours (in other words, tracked by EditorJourney).
  2. A user clicks on a suggested task from Newcomer Tasks and opens the editor.

I'm not sure if the second path is somehow intertwined with the first in the code? Apart from these two paths, I don't think we have other needs for oversampling EditAttemptStep, so I think we should make sure we fall back on EditAttemptStep's regular sampling rate if a user isn't following these paths in order to limit how much data we store. @MMiller_WMF, please pitch in if I've forgotten something or my suggestions are different from what you'd like.

Tue, Oct 13, 7:23 PM · User-jijiki, Growth-Team (Current Sprint), User-Elukey, Patch-For-Review, Operations, serviceops
kostajh claimed T264462: [Leftovers] Newcomer homepage: Visual design improvements to the homepage layout on Desktop.
Tue, Oct 13, 12:23 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
kostajh added a comment to T265346: Create addlink component.

the overall effort is called "add link" or "add a link". I don't have a strong feeling about which one we use for the component name (it can be renamed right?). The project is composed of:

Tue, Oct 13, 12:10 PM · Project-Admins
kostajh updated subscribers of T265346: Create addlink component.
Tue, Oct 13, 11:34 AM · Project-Admins
kostajh created T265346: Create addlink component.
Tue, Oct 13, 11:33 AM · Project-Admins
kostajh added a comment to T706: Requests for addition to the #acl*Project-Admins group (in comments).

I'd like to be able to create components for Growth Team projects.

Tue, Oct 13, 11:31 AM · Project-Admins
kostajh added a project to T258978: Service operations setup for Add a Link project: Growth-Team (Current Sprint).
Tue, Oct 13, 11:24 AM · Add-Link, Growth-Team (Current Sprint), Product-Infrastructure-Team-Backlog, Operations, serviceops, GrowthExperiments-NewcomerTasks
kostajh added a project to T265345: Calculate estimated requests per second to mwaddlink-query: Growth-Team.
Tue, Oct 13, 11:24 AM · Growth-Team, GrowthExperiments-NewcomerTasks
kostajh created T265345: Calculate estimated requests per second to mwaddlink-query.
Tue, Oct 13, 11:24 AM · Growth-Team, GrowthExperiments-NewcomerTasks
kostajh closed T261401: Add a link: Set up link recommendation testing environment with Cloud VPS and existing notebook code as Declined.

Let's focus on the production environment instead.

Tue, Oct 13, 11:10 AM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh closed T261401: Add a link: Set up link recommendation testing environment with Cloud VPS and existing notebook code, a subtask of T261396: Add a link: engineering tasks for initial release, as Declined.
Tue, Oct 13, 11:10 AM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh added a comment to T261411: Add a link engineering: Determine format for accessing and storing link recommendations.

Good to know. Do we have the same problem if we use the denormalized approach, where there is an upper limit of 20,000 rows per wiki x 100 wikipedias = 2,000,000 rows?

This would be a lot better, and I would feel a lot more comfortable with 2M rows for 100 wikipedias. 2M rows is a much more healthier number for a mysql table

I know this is quite far away but, 100 is the max number of wikipedias this would be enabled on?

Tue, Oct 13, 11:07 AM · Growth-Team (Current Sprint), Data-Persistence, DBA, Growth-Structured-Tasks
kostajh added a comment to T261403: Move dedcode/mwaddlink from github to gerrit.

@MGerlach how does the following sound to you:

Tue, Oct 13, 10:54 AM · serviceops, Release-Engineering-Team, Growth-Structured-Tasks, Growth-Team
kostajh changed the status of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach from Open to Stalled.

Until we finalize the ideas about using offsets or not, let's pause on this prototyping.

Tue, Oct 13, 10:50 AM · Add-Link, Growth-Team (Current Sprint), Patch-For-Review, Growth-Structured-Tasks
kostajh changed the status of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach, a subtask of T261396: Add a link: engineering tasks for initial release, from Open to Stalled.
Tue, Oct 13, 10:49 AM · Add-Link, Growth-Structured-Tasks, Growth-Team
kostajh moved T261448: Newcomer tasks: suggested edits module linebreaks from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Oct 13, 10:46 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team (Current Sprint), Growth Design, I18n, Design, Russian-Sites
kostajh moved T265262: [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Tue, Oct 13, 10:43 AM · Growth-Team (Current Sprint)
kostajh added a comment to T265262: [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected.

This was implemented with right: 10% per T238611#5789718 and T238611#5790124, but I will make a patch to center it on desktop.

Tue, Oct 13, 10:41 AM · Growth-Team (Current Sprint)