Decision matrix (tentative): https://docs.google.com/spreadsheets/d/1G50XPisubSRttq4QhakSij8RDF5TBAxrJBwZ7xdBZG0/edit#gid=0
When I open the question dialog from the mentorship module and start typing in the question box, I correctly get a "enter-question-text" event in the HelpPanel schema. But when I do the same thing in the help module, I do not get a "enter-question-text" event.
@MMiller_WMF when you're back, please weigh in on this. Thanks!
Can you say more why it's not a blocker?
IMO this is not a blocker for wmf.11 or wmf.10. We are working on a patch so that if pageUpdater->grabParentRevision->getContent() doesn't return a Content object, we won't fail as hard.
Fri, Jun 21
Some benchmarks with quibble + this patch + docker on macOS.
Thu, Jun 20
What this bug looks like in practice:
@thcipriani: at least on a mac with homebrew, it's as simple as brew install python
@kostajh -- if the user continues to see "posted 2 seconds" ago even when a minute has gone by, how long does it take to update?
Could be due to the validation event error - https://phabricator.wikimedia.org/T222836#5269430.
Wed, Jun 19
Tue, Jun 18
It's worth noting that the same problem exists for the help panel -- try editing a page on mobile, opening the help panel, then tapping back. (See also T215430) I'll create a new task for fixing this behavior, and will move this task back into QA.
One thing to check is to use private browsing mode, as non-private browsing mode can cache the HTML, JS and CSS pretty aggressively.
This was occurring because @Etonkovidova created two unclosed <tt> HTML elements in test posts from May 18. While Vector doesn't have an issue with these, Minerva stopped rendering headers after those two comments. I fixed the broken HTML in the comments and jumping to the correct header now works. As for why Minerva did not render the headers after the unclosed HTML elements, I think that should be filed as a separate issue with MinervaNeue
Mon, Jun 17
I'd like to revisit this as an experiment using fastest. In my local environment using MediaWiki-Docker-Dev, running the full test suite takes 49 minutes. With fastest, it takes 39 minutes:
@MMiller_WMF I'll leave this for you to triage, let me know if you have questions!
Sun, Jun 16
Ensure we're testing appropriately and not over-testing across Wikimedia-deployed code
I would actually object to this: imagine your change has caused multiple test failures that you weren't able to predict in your dev environment (because you didn't have all extensions installed or your environment is otherwise different from our CI).
Sat, Jun 15
I want to +1 this as a great idea. Maybe there's a good reason to show as many errors as possible, but I think fail-fast is consistent with our CI infrastructure. As soon as your code fails one test, we can be certain that it's not mergeable, and any further testing is a waste of resources.
Here's an example of Selenium failing early (note I think we'd need to update wdio.conf.js for extensions too?)
Preliminary test run with Apache was not that thrilling: the selenium page.js test passed in 300 seconds instead of 345 with PHP built in server. I’ll poke at it some more though.
Fri, Jun 14
Thu, Jun 13
splitting the unit and integration test runs into different jenkins votes, delivering the former faster,
Wed, Jun 12
This is what I see on iOS 12
Sure. MinervaNeue contains code (skins/MinervaNeue/resources/skins.minerva.talk/init.js) which takes over control of the Talk tab and displays the talk overlay. That code is currently loaded when viewing the user page or an article page. We could load it on Special:Homepage, but I think we might also need to make some modifications to init.js so it supports overriding the links when added to a Special page, since AMC tabs generally are assumed to be added to content pages and not special pages.
(1) Following the steps in the task description - I did not manage to sent multiple WikiLove messages.
The solution proposed in the patch for this task is to implement an alphabetic pager for Special:EditWatchlist. The pager will respect the namespace groupings currently on EditWatchlist, but the maximum number of items rendered per page will be 500 (as opposed to the unlimited number currently). Also, the TOC at the top of EditWatchlist is replaced with a namespace filter, which defaults to (all).
Would you be able to run the same benchmark for hhvm as well?
Tue, Jun 11
I think having one or several (HA) VPS nodes is way better than having them in toolforge. We have more control over the node. I might be able to setup something quickly. Is there a help on how to setup a standalone service?
do you recommend that we use the exact same message that is currently used on Special:ConfirmEmail?
We would like to enable the pipeline for the Translate extension.
@abi_ I created a patch to do this but we have some CI resource issues to sort out before enabling the pipeline for more extensions. I'll let you know if/when it's merged. Note that you'll probably also want to create a sonar-project.properties file in the repo that specifies the source locations. I can work with you on that, but let's get the extension added to the pipeline first.
Would you like to join us to discuss this at the next Data³ meeting?
Just a small note, the comment operator can be used to exclude those (few) results that match the commit messages instead.
Mon, Jun 10
Sun, Jun 9
I'll comment more on Amir's note above on Monday, but for now wanted to add two other ideas:
Fri, Jun 7
Thank you everyone for the discussion!
Thu, Jun 6
+17,000 one week later. https://gerrit.wikimedia.org/r/q/recheck,17000
This is being worked on in T219222, so I'm closing this one as a duplicate.
OK, yes, this is now decided