That issue happens when you have code in data providers that requires bootstrapping MediaWiki. If you have simple data providers that don’t access globals or services then there are no issues.
Can I ask what you are using for your local dev environment (docker, vagrant, host setup?)
As for the CI issue, that shouldn't be happening. The unit tests are run with the vendor/bin/phpunit entrypoint and indeed running the command that quibble executes locally shows me a failure:
Huh, I thought it wasn't possible to specify the phpunit.php wrapper as the path to phpunit.phar, at least I don't think it worked the last time I tried that a year or two ago. In any case this is what I have in my config:
Sat, Oct 24
@Daimona could you provide some screenshots of your config? I have a single configuration for both types of tests although I have two different PHP interpreters since one uses my host PHP and the other (for integration) uses the docker container PHP.
Thu, Oct 22
What is implemented in the patch for this task is a little bit different than what the description says, because in the meantime we've done T236738: Newcomer tasks: server-side rendered version of suggested edits module. So, we can render all components of the suggested edits module on the server-side, but we add the skeleton styling for:
Wed, Oct 21
Meh, I'm now seeing this same issue with T266110: Add Link engineering: Codehealth integration
Tue, Oct 20
Mon, Oct 19
Hi Release-Engineering-Team, @MGerlach and Growth team will be working on implementing the deployment pipeline for https://gerrit.wikimedia.org/r/plugins/gitiles/research/mwaddlink/+/refs/heads/main. It's a python application, and there will be two requirements.txt files, one for building the application with the capability for training a ML model, and the other for a slimmed-down application that handles web requests and queries data dictionaries.
https://github.com/dedcode/mwaddlink is now imported at https://gerrit.wikimedia.org/r/plugins/gitiles/research/mwaddlink, so we should use gerrit for pushing code / code review now instead of GitHub.
I think we can get started on this (possibly breaking out into a couple of subtasks). Since we don't have a production endpoint yet, we we can work with a fake LinkRecommendationService provider for responses.
Looks like the code is in a single repo (and will soon be imported to gerrit, where we should push patches), but leaving this open to implement the multiple requirements.txt approach.
This issue is a consequence of logic we implemented in T229044: Homepage: users should only receive one discovery GuidedTour, where we said we didn't want to show the homepage welcome tour to users who had seen the homepage discovery tour, as well as some code in implementing T258009: Variant C/D: welcome popup on desktop where we excluded variant C and D users from the discovery tour.
@Evrifaessa we have it scheduled for deployment later today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20201019T1800
@jijiki EditorJourney logging is now switched off. We may at some point want to re-enable but will wait for this work to be finished before doing so.
Two additional problems which I assume have the same underlying problem as this one:
It means that for some users, checking the box to enable Flow for their user talk page fails. The error happens silently, so the user sees in their preferences the box checked for enabling Structured Discussions on their talk page, but when they view their talk page, it's still in its old wikitext format.
The move is in progress, see https://www.mediawiki.org/wiki/Topic:Vw2qibn0ocvx95lp
Sat, Oct 17
Thu, Oct 15
Per discussion yesterday, moving this into our current sprint.
Assigning to you, but if you'd like help with this (reviewing or implementing) let Growth-Team know.
What we've decided to do as our first pass (see meeting notes from October 14 and 15 here):
My patch assumed we could remove variant A code, which is not true just yet. Unassigning myself in case someone else wants to work on it between now and next week.
This was making noise in the logs, so while looking at the cause I found it is trivial to fix. Growth engineers -- please do not prioritize code review of this over other pre-defined interlude work; I've added it it to our current sprint so it can go through the normal code review / QA process.
A problem that we will need to find a solution for is running the model on a stat* server, then updating a production database from there. I don't know of predefined ways to do it, but on that we can ask for an opinion to the analytics team about this.
Wed, Oct 14
Yeah, doesn't look great. This is a separate issue from this task though. I'd propose we handle it in T236738: Newcomer tasks: server-side rendered version of suggested edits module if that's alright?
I feel like we discussed this ~1-2 years ago and deliberately implemented in this way, but I don't remember why. And it's possible I am misremembering because I didn't find anything in phabricator to support this. The closest I could find is T222206#5150582 but that issue is about page deletion. I agree that following redirects makes sense.
Tue, Oct 13
if you help me with requesting a gerrit-repo that would be great (no experience with that yet). also
the overall effort is called "add link" or "add a link". I don't have a strong feeling about which one we use for the component name (it can be renamed right?). The project is composed of:
I'd like to be able to create components for Growth Team projects.
Let's focus on the production environment instead.
@MGerlach how does the following sound to you:
Until we finalize the ideas about using offsets or not, let's pause on this prototyping.