Wikidata developer, open source enthusiast, mediawiki volunteer developer
Babel: fa-N, en-4, de-1, tr-1
User Details
User Details
- User Since
- Oct 6 2014, 9:53 PM (270 w, 6 d)
- Roles
- Administrator
- Availability
- Available
- IRC Nick
- Amir1
- LDAP User
- Ladsgroup
- MediaWiki User
- Ladsgroup [ Global Accounts ]
Today
Today
Ladsgroup added a comment to T185664: Code stewardship review: FlaggedRevs.
Yesterday
Yesterday
Krinkle awarded T240776: Codesearch "Everything" is missing MediaWiki core a Orange Medal token.
Ladsgroup added a comment to T240776: Codesearch "Everything" is missing MediaWiki core.
The config for everything has core:
"MediaWiki core": { "ms-between-poll": 3600000, "url": "https://gerrit-replica.wikimedia.org/r/mediawiki/core.git", "url-pattern": { "base-url": "https://gerrit.wikimedia.org/g/mediawiki/core/+/{rev}/{path}{anchor}", "anchor": "#{line}" } },
Ladsgroup added a comment to T240776: Codesearch "Everything" is missing MediaWiki core.
The code says that it should be there, the logs says hound couldn't index it:
ladsgroup@codesearch4:~$ sudo service hound-core status
● hound-core.service - hound-core
Loaded: loaded (/etc/systemd/system/hound-core.service; enabled; vendor preset: enabled)
Active: active (running) since Sat 2019-12-14 10:38:55 UTC; 13h ago
Process: 18456 ExecStop=/usr/bin/docker stop hound-core (code=exited, status=0/SUCCESS)
Process: 18529 ExecStartPre=/usr/bin/docker pull etsy/hound (code=exited, status=0/SUCCESS)
Process: 18491 ExecStartPre=/usr/bin/docker rm -f hound-core (code=exited, status=0/SUCCESS)
Process: 18484 ExecStartPre=/usr/bin/docker kill hound-core (code=exited, status=1/FAILURE)
Main PID: 18536 (docker)
Tasks: 6 (limit: 4915)
Memory: 2.5M
CPU: 377ms
CGroup: /system.slice/hound-core.service
└─18536 /usr/bin/docker run -p 6084:6080 --name hound-core -v /srv/hound/hound-core:/data -v /srv/puppet:/operations/puppet etsy/houndSat, Dec 14
Sat, Dec 14
Ladsgroup added a comment to T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [].
Fri, Dec 13
Fri, Dec 13
Ladsgroup added a comment to T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [].
Ladsgroup placed T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master up for grabs.
It's caused by this patch and that $recordsToInsert doesn't necessary have all of the $idsToRestore cases because some might be already in the table. Fixing it is not easy because $recordsToInsert is an associative array of terms properly mapped and $idsToRestore is just list of term ids. I leave this for anyone else to pick up for now.
Ladsgroup added a comment to T236895: ArticlePlaceholder dashboard stopped tracking page views.
Can I just use normalized_host field instead?
Ladsgroup added a comment to T240342: Aliases should wrap nicely in editing mode.
I tried to do this but it's basically impossible or it's possible with horrible css hacks because it's an input element and not a textarea.
I suggest changing it to textarea. Some more info: https://stackoverflow.com/questions/5286663/wrapping-text-inside-input-type-text-element-html-css
Ladsgroup added a comment to T240624: Style desktop Minerva diff page to look like Special:MobileDiff .
I might be wrong here but the diff with mobile with #e07076 and #222 violates AAA WCAG contrast check, also the color of none of the diffs are from the color palette.
Thu, Dec 12
Thu, Dec 12
Ladsgroup moved T235745: Add Wikidata support for mnwwiki from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11
Wed, Dec 11
Ladsgroup claimed T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
I licked this.
Ladsgroup moved T239761: Wikibase is not compatible with PHP7.4 from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup placed T237984: Some property labels are not displayed on Item pages up for grabs.
Ladsgroup awarded T236225: [Epic] CheckUser 2.0 Improvements a Love token.
Ladsgroup added a comment to T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis.
Some shiny graphs:
Ladsgroup moved T239761: Wikibase is not compatible with PHP7.4 from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a project to T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]: Core Platform Team.
I highly doubt this is something Wikibase team would be able to fix. The usage of the LocalUserCreated hook in Wikibase code seems to be straightforward and simple, something in core or Translate extension needs to change. It might be caused by splitting Language object. I add Daniel and CPT to the ticket.
Ladsgroup added a comment to T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis.
Doing it as we speak
Added all reserved IPs for private network to the whitelist to avoid cases like that in the future.
Tue, Dec 10
Tue, Dec 10
Ladsgroup added a comment to T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5].
I might be very wrong here but can it be that it's caused by I7ca40f8eda?
Ladsgroup moved T239761: Wikibase is not compatible with PHP7.4 from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment to T239931: Reduce the impact of the sanitizer on wikidata.
Ladsgroup added a comment to T232240: New service to shorten wmflabs URLs.
I would be willing to take on this one, I just want to have a system of enforcing some whitelist/blacklist for users like an OAuth
Ladsgroup added a comment to T240316: Issue with QuickStatements "you are blocked on Wikidata".
Added. Does it fix the issue?
Ladsgroup added a comment to T239761: Wikibase is not compatible with PHP7.4.
With the patch applied the only errors and warnings left are:
10:48:30 7) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "by title" (array('query', 'pageterms', 'No11|No22|No3333'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Vienna'), array('Capitol city of Austria'))), array(array(array('Moscow'), array('Capitol city of Russia'))), array(array(array('Population'), array('number of inhabitants')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 8) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "descriptions only" (array('query', 'pageterms', 'No11|No22', 'description'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Capitol city of Austria'))), array(array(array('Capitol city of Russia')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 9) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "with uselang" (array('query', 'pageterms', 'No11|No22', 'de'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Wien'), array('Hauptstadt Österreichs'))), array(array(array('Moskau'), array('Hauptstadt Russlands')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache::isExpired(de): cache missing, need to make one []
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 10) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "title without entity" (array('query', 'pageterms', 'No11|SomeTitleWithoutEntity'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Vienna'), array('Capitol city of Austria')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 11) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "continue" (array('query', 'pageterms', 'No11|No22', '20'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Moscow'), array('Capitol city of Russia')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 --
10:48:30
10:48:30 There were 7 warnings:
10:48:30
10:48:30 1) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "full empty" (array(), 'full-dump', 'empty')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 2) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "full some entities" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'full-dump', 'entities')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 3) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "full redirect" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'full-dump', 'redirect')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 4) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "truthy empty" (array(), 'truthy-dump', 'empty')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 5) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "truthy some entities" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'truthy-dump', 'entities')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 6) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "truthy redirect" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'truthy-dump', 'redirect')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30
10:48:30 7) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testReferenceDedup with data set "references" (array(Wikibase\DataModel\Entity\ItemId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'refs')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
`Ladsgroup placed T233490: wikibase-docker, switch wikibase images to use composer merge plugin up for grabs.
Ladsgroup added a comment to T237667: PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue) [8 story points].
Sorry, When I made the patch to gerrit it made sense to open the ticket so the bots can add the patch to this ticket, when the patch is in gerrit, this can be opened. right?
Ladsgroup merged T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php] into T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Ladsgroup merged task T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php] into T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Ladsgroup updated the task description for T208425: [EPIC] Kill the wb_terms table.
Let's continue discussion in T239931: Reduce the impact of the sanitizer on wikidata. For the sense of the spikes, this is done.
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
I got my answer, PC gets purged at 1:00 UTC every day only (using mediawiki::maintenance::parsercachepurging job) meaning I have to wait a full day to get the value.
Ladsgroup added a comment to T240316: Issue with QuickStatements "you are blocked on Wikidata".
Potentially a train blocker.
Ladsgroup added a comment to T240316: Issue with QuickStatements "you are blocked on Wikidata".
I can't check right now but for whoever is debugging, this is very likely regression from wmf.8 that got deployed yesterday. (List of patches that got deployed)
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
Regarding size of ParserCache. I queries pc255 on the first PC node. it had 975,982 rows yesterday and today it had 975,580. Assuming perfect randomness in sharding, there should be a total of 308,736 rows drop (154,368 PC entries) since yesterday. Even though I don't see the drop in the graphs, maybe it needs more time.
Ladsgroup added a comment to T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction.
Ladsgroup added a comment to T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction.
This is the right issue but given the size of migration still a little bit of deadlock is unavoidable. How big the number is?
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
The spikes are gone now:
Mon, Dec 9
Mon, Dec 9
Ladsgroup added a comment to T239931: Reduce the impact of the sanitizer on wikidata.
Hey, Thanks for the comment. I'm planning to turn it back on ASAP, right now, we are at middle of the migration and it puts too much pressure on s8, once the migration of of wb_terms is over, we can turn this back on again. That's going to happen in two months (hopefully).
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
Ladsgroup edited projects for T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
Filled the follow up: T240263
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
ladsgroup@deployment-mwmaint01:/var/log/wikidata$ tail dispatchChanges-wikidatawiki.log --lines 50 12887: Starting dispatcher 20:45:02 Starting loop for unlimited passes or 540 seconds 20:45:05 Posted 6 changes to enwiki, up to ID 1681591, timestamp 20191209130228. Lag is 27757 seconds. Next ID is 1681747. 20:45:08 Posted 2 changes to dewiki, up to ID 1680869, timestamp 20191204174336. Lag is 442892 seconds. Next ID is 1681747.
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
nope, memcached php extension wasn't installed there. Then it was lack of geoip and msgpack php extensions.
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
It's because the mwmaint01 is dirty...
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
This is a big misconfiguration. ObjactCache in line 186 dynamically tries to load the cache class defined in "class" configuration (grrr). They all changed for the mcrouter stuff. I'm trying to see if I can fix it.
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
Ladsgroup added a comment to T239470: Check the success of the initial terms migration (does it have holes).
I ran some checks on your numbers. It seems in some ranges, things are clean, like only 30% have issues in some ranges more than > 95%. This is the numbers separated by millions. 1 means up to Q1Mio:
1 364510 2 415854 3 380372 4 302745 5 356028 6 326523 7 444421 8 404898 9 821285 10 590021 11 475503 12 218112 13 256970 14 384180 15 439502 16 639781 17 320441 18 409604 19 330605 20 201857 21 449418 22 426350 23 582121 24 321645 25 443846 26 462407 27 350897 28 446790 29 488908 30 322142 31 620204 32 364034 33 659610 34 815488 35 784804 36 642381 37 950938 38 912740 39 920671 40 950641 41 948308 42 807250 43 793387 44 849349 45 928451 46 644449 47 910284 48 534375 49 36997 50 397077 51 875785 52 923620 53 819251 54 607872 55 559604 56 751158 57 851437 58 915506 59 945442 60 905496 61 861103 62 841255 63 811589 64 700324 65 841526 66 831120 67 705046 68 658960 69 811256 70 620628 71 687696 72 885236 73 883354 74 878387 75 800494 76 986947 77 976292 78 236429 `
Ladsgroup added a comment to T171986: Diff summary doesn't work for foreign entities.
This is funny. Looking at commons, now linking works but the label is gone:
(For example)
Ladsgroup added a comment to T231518: Add *.wmflabs.org to w.wiki shortener.
I can create a project in cloud vps and install url shortener there. Is there anyone who wants to help maintaining it for the future?
Sun, Dec 8
Sun, Dec 8
Ladsgroup added a comment to T155425: Add monolingual language code phn (Phoenician).
@jhsoby What's the final decision here?
Sat, Dec 7
Sat, Dec 7
Ladsgroup added a comment to T192134: Personal and site-wide CSS and JavaScript is loaded on Special:PasswordReset.
Fri, Dec 6
Fri, Dec 6
Thu, Dec 5
Thu, Dec 5
Ladsgroup moved T237984: Some property labels are not displayed on Item pages from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
I think I know what's causing it but given the nature of the problem (like the ones you mentioned, they all are fixed now), it's really hard to make sure that would fix it. I will make a patch and hopefully wait to see if that stops happening.
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
So After lots of debugging it turned out that it's CirrusSearchChecker job that is causing this. The time matches perfectly:
Addshore awarded T229407: Spikes in DB traffic and rows/s reads when reading from new terms store a Baby Tequila token.
Ladsgroup updated subscribers of T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
Binlogs that @Marostegui gave me has things like this:
REPLACE /* SqlBagOStuff::updateTableKeys RunSingleJob.php@mw1335 */ INTO `pc156` (keyname,value,exptime) VALUES ('wikidatawiki:pcache:idoptions:55899217','<gibberish>...In timespan of six minutes, there's 17k of praser cache insertion on wikidata from RunSingleJob.php in one of the three PC nodes. This is, to put it mildly, insane. One of the items that got a new PC is Q55864736 that hasn't visited in the last month, has no templates or entity usage. I think it's one of wikibase jobs. I dig deeper now.
Ladsgroup added a comment to T237984: Some property labels are not displayed on Item pages.
What is the item?
Ladsgroup added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".
Given the dbs (in s7) I highly doubt it's wikidata but I also want to mention that s7 has only frwiktionary and metawiki as their group1 wikis. Is there anything special about those?
:D
Ladsgroup added a comment to T237013: Refactor the Wikidata Data Quality Report analytics procedures.
Wed, Dec 4
Wed, Dec 4
Ladsgroup added a comment to T143870: Some mw snapshot hosts are accessing main db servers.
Can this be causing spikes desribed in T229407: Spikes in DB traffic and rows/s reads when reading from new terms store as well?
Some graphs to look at:
Ladsgroup added a comment to T239594: Unexpected general module "jquery.ui.core.styles" in styles queue..
I deployed it in wmf.8, if everything goes well. This should be gone in a couple of hours.
Ladsgroup moved T237551: beta wikidata trying to dispatch to wikis that don't exist from Ready to pick up to Ready to estimate on the Wikidata-Campsite board.
Ladsgroup added a comment to T237551: beta wikidata trying to dispatch to wikis that don't exist.
This was fun. The client, the list, everything for that was fine, the problem was that somehow wb_changes_dispatch table got production data (could have happened when someone mistakenly changes to $wgWBRepoSettings['localClientDatabases'] to be as the same as production. You can quickly fix it but when it's messes up the table, it can't get fixed on its own.) I dropped everything from that table and dispatching is back to normal now.
I have been working on this since yesterday. I have a hunch what's going on here. Will write more once I'm certain.
Tue, Dec 3
Tue, Dec 3
Ladsgroup added a comment to T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Still happening: 240
Mon, Dec 2
Mon, Dec 2