Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Shah of Bugs, Chief Mailmaner, Mediocre grepperAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (340 w, 4 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata software engineer, open source enthusiast, mediawiki volunteer developer, long-term Wikipedian
Babel: fa-N, en-4, de-2, tr-1, hu-1

Recent Activity

Today

Ladsgroup added a comment to T278612: Install mailman3 and mailman2 at the same time on the cloud.

So after several changes in puppetmaster of mailman in the cloud, it works now: https://polymorphic.lists.wmcloud.org/hyperkitty/hyperkitty/list/test4@polymorphic.lists.wmcloud.org/2021/4/

Sat, Apr 17, 9:13 AM · Patch-For-Review, SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T280400: Alias or rename OTRS-wiki.

Seconding what Martin said. Renaming a wiki is extremely complex and we have done it only once (b-x-old to be-tarask and that one is not also finished properly yet) and it's still quite a mess (probably the renaming script is also terribly broken by now) and all renames are blocked T172035: Blockers for Wikimedia wiki domain renaming (while some of the blockers are not applicable here, like wikidata support). It's also risky given that it can bring down all wikis.

Sat, Apr 17, 5:50 AM · User-Urbanecm, Wiki-Setup (Rename), OTRS
Ladsgroup added a comment to T280400: Alias or rename OTRS-wiki.

From the other tickets, it looks like legal-related stuff is the reason why we're moving away from OTRS branding. To which decree do we need to get rid of "otrs"? For instance, I'm wondering whether the internal wiki ID can stay "otrs_wikiwiki" (note that changing that will likely be really really complex).

Sat, Apr 17, 5:50 AM · User-Urbanecm, Wiki-Setup (Rename), OTRS
Ladsgroup added a comment to T280408: Create a mailing list for ptwikinews.

Hi, if you can wait for two to three weeks, we will get mailman3 up and running soon and you can enjoy a much more modern system (see https://lists-next.wikimedia.org). This is by no means blocking the request and you can go ahead with the old system if you want to.

Sat, Apr 17, 5:40 AM · SRE, Wikimedia-Mailing-lists
Ladsgroup awarded T252434: Test MW code in buster as well as stretch a Love token.
Sat, Apr 17, 5:36 AM · Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Continuous-Integration-Infrastructure, Quibble, Release-Engineering-Team (CI & Testing services)

Yesterday

Ladsgroup added a comment to T279087: Update the logo for wikitech.wikimedia.org to mirror the new MediaWiki logo.

No, that's enough. I just an email asking people to vote. Thanks.

Fri, Apr 16, 4:29 PM · Logos, wikitech.wikimedia.org
Ladsgroup added a comment to T278612: Install mailman3 and mailman2 at the same time on the cloud.
[Fri Apr 16 15:25:54.109507 2021] [proxy_http:debug] [pid 12009:tid 140593783097088] mod_proxy_http.c(1920): [client 172.16.4.88:59876] AH01113: HTTP: declining URL uwsgi://localhost/hyperkitty/api/mailman/urls

:|

Fri, Apr 16, 3:37 PM · Patch-For-Review, SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T278612: Install mailman3 and mailman2 at the same time on the cloud.

exim fully works.

Fri, Apr 16, 3:29 PM · Patch-For-Review, SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T278612: Install mailman3 and mailman2 at the same time on the cloud.

https://gerrit.wikimedia.org/r/680328 is needed. https://gerrit.wikimedia.org/r/680335 is not (I disabled TLS for now there).

Fri, Apr 16, 2:43 PM · Patch-For-Review, SRE, Wikimedia-Mailing-lists
Ladsgroup closed T279068: Wikibase data-client bridge selenium failure on buster but not stretch as Resolved.
Fri, Apr 16, 2:10 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), User-Ladsgroup, Wikidata, Wikidata-Campsite, Wikibase
Ladsgroup closed T279068: Wikibase data-client bridge selenium failure on buster but not stretch, a subtask of T252434: Test MW code in buster as well as stretch, as Resolved.
Fri, Apr 16, 2:10 PM · Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Continuous-Integration-Infrastructure, Quibble, Release-Engineering-Team (CI & Testing services)
Ladsgroup added a comment to T278522: Grammatical features field is now right-aligned.

wow. Thanks!!!!

Fri, Apr 16, 12:21 PM · Patch-For-Review, User-Ladsgroup, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), OOUI, Wikidata, Wikidata Lexicographical data
Ladsgroup updated subscribers of T278522: Grammatical features field is now right-aligned.

@Tchanders @Esanders Hi, is it okay if we revert that patch?

Fri, Apr 16, 9:30 AM · Patch-For-Review, User-Ladsgroup, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), OOUI, Wikidata, Wikidata Lexicographical data
Ladsgroup updated the task description for T280322: Upgrade mailing lists from mailman2 to 3 in batches.
Fri, Apr 16, 9:15 AM · SRE, Wikimedia-Mailing-lists
Ladsgroup updated the task description for T280322: Upgrade mailing lists from mailman2 to 3 in batches.
Fri, Apr 16, 9:14 AM · SRE, Wikimedia-Mailing-lists
Ladsgroup created T280322: Upgrade mailing lists from mailman2 to 3 in batches.
Fri, Apr 16, 9:12 AM · SRE, Wikimedia-Mailing-lists
Ladsgroup created P15382 Group D of mailing lists.
Fri, Apr 16, 9:07 AM
Ladsgroup created P15381 Group E of mailing lists.
Fri, Apr 16, 9:06 AM
Ladsgroup created P15379 Group F of mailing lists.
Fri, Apr 16, 9:00 AM
Ladsgroup created P15378 Group H of mailing lists.
Fri, Apr 16, 9:00 AM
Ladsgroup created P15377 Group G of mailing lists.
Fri, Apr 16, 8:59 AM
Ladsgroup created P15376 Group C of mailing lists.
Fri, Apr 16, 8:58 AM · Wikimedia-Mailing-lists
Ladsgroup created P15375 Group B of mailing lists.
Fri, Apr 16, 8:58 AM · Wikimedia-Mailing-lists
Ladsgroup moved T277988: Make and integrate a new release of wmde/hamcrest-html-matchers from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

https://packagist.org/packages/wmde/hamcrest-html-matchers#v1.0.0

Fri, Apr 16, 8:10 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, wdwb-tech, Wikidata
Ladsgroup moved T277988: Make and integrate a new release of wmde/hamcrest-html-matchers from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Apr 16, 6:38 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, wdwb-tech, Wikidata
Ladsgroup claimed T277988: Make and integrate a new release of wmde/hamcrest-html-matchers.
Fri, Apr 16, 6:38 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, wdwb-tech, Wikidata
Ladsgroup added a comment to T279108: Introduce a Front-end Build Step for MediaWiki Skins and Extensions.

+1 to that. We do have our own apt, our own docker registry, and some more. We certainly can have our own npm registry as well (which I think is possible, correct me if I'm wrong), OT: I like to do the same for pypi so we stop shipping wheel binaries to production as well. But it would bring the whole discussion around processes and how to vet and push packages to our registry and I assume it should be determined beforehand.

Fri, Apr 16, 5:24 AM · Vue.js Migration, tech-decision-forum
Ladsgroup added a comment to T274678: Logo for MediaWiki-Docker.

The whole thing is a bit offtopic here but I want to say that I chose the installer logo like that as I have seen in another places that installer shows an incomplete logo to convey "it's being built for you" and it got even pointed out by other people that was a good choice. At end of the day, logos are subjective and you might like something someone else doesn't. We can have a semi-official voting for the installer logo somewhere if you insist.

Fri, Apr 16, 4:54 AM · Logos, MediaWiki-Docker
Ladsgroup added a comment to T280232: Uncached wiki requests partially unavailable due to excessive request rates from a bot.

There was one thing I missed in my comment on autolader and Joe pointed out in IRC that I did the test on mwdebug (where you can do xhgui) and mwdebug is a VM with different opcache (probably cold most of the time) with production. So the situation in production is better. Of course, we might need to improve things but that's another topic not related to this issue. Sorry my bad.

Fri, Apr 16, 4:33 AM · SRE, Wikimedia-Incident
Ladsgroup moved T276573: Update tainted-refs npm dependencies from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Apr 16, 4:17 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Patch-For-Review, wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T279087: Update the logo for wikitech.wikimedia.org to mirror the new MediaWiki logo.

I created https://wikitech.wikimedia.org/wiki/Wikitech_logo, @SerDIDG Can you upload them in commons and add them to the page? I'll do the similar jazz with did with mw logo but faster (only one round, two week voting period and no legal clearance) to finish it.

Fri, Apr 16, 4:15 AM · Logos, wikitech.wikimedia.org
Ladsgroup added a comment to T72470: Remove legacy javascript globals.

lots of mw-deprecate cases are actually edge case scripts iterating over window object and thus emitting a deprecation warning for every variable. It adds up really quickly.

Fri, Apr 16, 3:32 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.36-notes, MW-1.35-notes, Patch-For-Review, MW-1.35-release, User-notice, Technical-Debt (Deprecation process), Performance-Team-publish, Performance-Team, MediaWiki-ResourceLoader, JavaScript

Thu, Apr 15

Ladsgroup moved T279408: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given, called in /srv/mediawiki/php-1.36.0-wmf.37/extensions/Wikibase/client/includes/Specials/SpecialUnconnectedPages.php on line 162 from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Apr 15, 10:50 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikidata, Wikimedia-production-error
Ladsgroup updated subscribers of T280232: Uncached wiki requests partially unavailable due to excessive request rates from a bot.

Requests the bot made are not that bad but probably had a terrible regression in wmf.1 (action=purge format=json forcelinkupdate= pageids=33330972 in API ):
https://performance.wikimedia.org/xhgui/run/view?id=60780f591e29d3593756eaae

Thu, Apr 15, 10:08 AM · SRE, Wikimedia-Incident
Ladsgroup claimed T277089: WikibaseLexeme: Call to a member function getLemmas() on null.
Thu, Apr 15, 7:46 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikibase-Quality-Constraints, Wikidata, User-brennen, Wikidata Lexicographical data, Wikimedia-production-error
Ladsgroup moved T276439: Make EntityContentFactory not implement EntityTitleStoreLookup (and EntityIdLookup) from Parent tasks to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Apr 15, 7:24 AM · wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Sustainability (Incident Followup), Wikidata
Ladsgroup added a comment to T277089: WikibaseLexeme: Call to a member function getLemmas() on null.

It's in this lexeme https://www.wikidata.org/w/index.php?title=Lexeme:L456103&action=history

Thu, Apr 15, 6:26 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikibase-Quality-Constraints, Wikidata, User-brennen, Wikidata Lexicographical data, Wikimedia-production-error
Ladsgroup added a comment to T277089: WikibaseLexeme: Call to a member function getLemmas() on null.

You can reproduce it with https://www.wikidata.org/w/index.php?oldid=1394890460

Thu, Apr 15, 6:12 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikibase-Quality-Constraints, Wikidata, User-brennen, Wikidata Lexicographical data, Wikimedia-production-error
Ladsgroup moved T277157: Create a new class exists that implements EntityTitleStoreLookup from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Apr 15, 1:46 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Sustainability (Incident Followup), Wikidata
Ladsgroup claimed T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate.
Thu, Apr 15, 1:21 AM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikidata, Wikimedia-production-error
Ladsgroup moved T278427: Convert Deutsche Bahn station code (P8671) from String to External Identifier from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Basically ran this command on mwmaint1002:

mwscript extensions/Wikibase/repo/maintenance/changePropertyDataType.php wikidatawiki --property-id P8671 --new-data-type external-id
Thu, Apr 15, 1:21 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T278427: Convert Deutsche Bahn station code (P8671) from String to External Identifier.

This is an easy task. Similar work in the past: T269205: Change P920 property’s data type from string to external identifier

Thu, Apr 15, 1:18 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate.

oh my bad, we do catch db errors in DataUpdateAdapter, I thought it's a core class. Making a patch now.

Thu, Apr 15, 1:01 AM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate.

Oh this is another case of catching DBErrors.
See https://www.mediawiki.org/wiki/Database_transactions#Use_of_transaction_rollback (emphasis not mine)

Callers might catch DBError exceptions without either re-throwing them or throwing their own version of the error. Doing so is extremely bad practice and can cause all sorts of problems from partial commits to simply spewing up DBTransactionError errors. Only catch DB errors in order to do some cleanup before re-throwing an error or if the database in question is used exclusively by the code catching errors.

Thu, Apr 15, 12:51 AM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikidata, Wikimedia-production-error

Wed, Apr 14

Ladsgroup claimed T278522: Grammatical features field is now right-aligned.
Wed, Apr 14, 11:21 PM · Patch-For-Review, User-Ladsgroup, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), OOUI, Wikidata, Wikidata Lexicographical data
Ladsgroup added a comment to T278522: Grammatical features field is now right-aligned.

It's a bit hard to test it but reverting https://gerrit.wikimedia.org/r/c/oojs/ui/+/668488 would fix the issue. I'm sure this is an upstream problem

Wed, Apr 14, 11:03 PM · Patch-For-Review, User-Ladsgroup, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), OOUI, Wikidata, Wikidata Lexicographical data
Ladsgroup updated subscribers of T278522: Grammatical features field is now right-aligned.

This is very likely caused by changed in ooui (there are a lot of them touching position of input element recently in TagMultiselectWidget) (T276483: TagMultiselectWidget always puts input on separate line after line 1 for example)

Wed, Apr 14, 10:19 PM · Patch-For-Review, User-Ladsgroup, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), OOUI, Wikidata, Wikidata Lexicographical data
Ladsgroup added a comment to T264822: (MS 7) Security Readiness Review For Wikidata Query Builder.

Thanks. Greatly appreciated <3

Wed, Apr 14, 9:42 PM · user-sbassett, secscrum, Security Readiness Reviews, Wikidata Query Builder, Wikidata, Security
Ladsgroup added a comment to T275751: Security review of backbone.js and underscore.js library updates.

Thanks. This reduces a lot of deprecation warnings in enwiki.

Wed, Apr 14, 9:41 PM · Growth-Team-Filtering, Security-Team, Security Readiness Reviews, secscrum, PageCuration, Security Team AppSec, Growth-Team, Patch-For-Review, Security
Ladsgroup added a comment to T278522: Grammatical features field is now right-aligned.

To make it even more fun, in RTL languages it's left-aligned

Wed, Apr 14, 4:06 PM · Patch-For-Review, User-Ladsgroup, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), OOUI, Wikidata, Wikidata Lexicographical data
Ladsgroup added a comment to T280119: Add #observability to related projects.

Yes. Please don't add more herald rules (T108586: Herald rules causing delays to task edit saves - getting worse). You can use maintenance bot instead. Here are some examples https://github.com/Ladsgroup/Phabricator-maintenance-bot/blob/master/project_grouper.py#L7

Wed, Apr 14, 3:24 PM · User-RhinosF1, phabricator maintenance bot, Phabricator

Tue, Apr 13

Ladsgroup added a comment to T279947: Content Translation cannot publish to Altay Wikipedia (alt.wikipedia.org).

That's why we need to automate things even more. This doesn't happen with CX or analytics as their patches are made automatically. That's for later though.

Tue, Apr 13, 8:12 PM · Wiki-Setup, ContentTranslation
Ladsgroup moved T277158: Create a new class exists that implements EntityIdLookup from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Apr 13, 8:11 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), User-Ladsgroup, wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Sustainability (Incident Followup), Wikidata
Ladsgroup added a comment to T268230: Roll out the new logo of MediaWiki.

So the derivatives and misc cases don't build a MECE list and possibly will drag on for years to come. Given that the site logo and software logo has changed and all current misc cases are either done or have a ticket on the relevant team's radar. I'm inclined to call this resolved. Any objection to that?

Tue, Apr 13, 8:09 PM · User-Ladsgroup, MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.31-release-notes, MW-1.35-notes, Patch-For-Review, Logos, MW-1.36-release, Design, MediaWiki-General
Niharika awarded T279870: Request creation of masz VPS project a Doubloon token.
Tue, Apr 13, 6:58 PM · Anti-Harassment, Cloud-VPS (Project-requests)
Ladsgroup added a comment to T279589: Change the Wikimedia and Power by MediaWiki footer icons at Czech Wikipedia.

If I have to choose between removing Turkish or adding Czech, I would go with the former. Having a bad pattern doesn't mean we can add more bad patterns on top. These are binary png files that are not easily changeable (unlike svg).

Tue, Apr 13, 2:44 PM · Patch-For-Review, Wikimedia-Site-requests
Ladsgroup closed T270283: Add Wikidata support for bclwiktionary as Resolved.

I've done this a while ago.

Tue, Apr 13, 11:50 AM · User-Ladsgroup, Wikidata, Wikidata-Campsite
Ladsgroup closed T276247: Prepare MessagesTrv.php for Seediq Wikipedia, a subtask of T276246: Create Wikipedia Kari Seediq, as Resolved.
Tue, Apr 13, 11:50 AM · DBA, Data-Services, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wiki-Setup (Create), User-Urbanecm
Ladsgroup closed T276247: Prepare MessagesTrv.php for Seediq Wikipedia as Resolved.
Tue, Apr 13, 11:49 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-Internationalization
Ladsgroup closed T278144: Add Wikidata support for trvwiki as Resolved.

this is done while ago

Tue, Apr 13, 11:49 AM · User-Ladsgroup, Wikidata, Wikidata-Campsite
Ladsgroup added a comment to T259771: RFC: Drop support for older database upgrades.

It depends on the compataibility policy of the extension I assume. For example, if master of your extension is only compatible with master (most cases). It's safe to drop pre 1.27 as the update.php wouldn't work at all but if it's an edge case (I think language bundle is different, also wikibase) then it depends on the what versions it's compatible with.

Tue, Apr 13, 11:22 AM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Stakeholders-Group, Platform Engineering
Ladsgroup moved T277158: Create a new class exists that implements EntityIdLookup from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Apr 13, 11:18 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), User-Ladsgroup, wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Sustainability (Incident Followup), Wikidata
Ladsgroup claimed T277158: Create a new class exists that implements EntityIdLookup.
Tue, Apr 13, 7:18 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), User-Ladsgroup, wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Sustainability (Incident Followup), Wikidata
Ladsgroup added a comment to T279947: Content Translation cannot publish to Altay Wikipedia (alt.wikipedia.org).

Isn't this done not done properly? T271983: Add altwiki to RESTBase

Tue, Apr 13, 5:58 AM · Wiki-Setup, ContentTranslation
Ladsgroup added a comment to T277118: iw_url in interwiki is varbinary(127) in production but blob in code.

The alter table would be:

ALTER TABLE /*_*/interwiki
  MODIFY iw_url BLOB NOT NULL;
Tue, Apr 13, 5:56 AM · DBA
Ladsgroup added a comment to T277116: fa_deleted_timestamp and fa_timestamp are binary(14) in code but varbinary(14) in production.

Come up with the alter table statement

Tue, Apr 13, 5:53 AM · DBA
Ladsgroup added a comment to T278614: Create production databases for mailman3.

Thanks. We will likely bother you in two or three weeks. Most of the work is done.

Tue, Apr 13, 5:47 AM · DBA, SRE, Wikimedia-Mailing-lists

Mon, Apr 12

Ladsgroup moved T272697: (MS 6) Query for date values from Peer Review to Test (Verification) on the Wikidata Query Builder board.
Mon, Apr 12, 6:57 PM · Wikidata Query Builder, Wikidata
Ladsgroup added a comment to T279624: Tooltip-Button missing border on focus.

That's according to the designs (T275542: (MS 6) using the tooltip component in the QB)

Mon, Apr 12, 6:57 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Ladsgroup claimed T277759: Don't scroll the window when selecting dropdown items with the keyboard.

https://github.com/wmde/wikit/pull/411

Mon, Apr 12, 6:30 PM · Patch-For-Review, Wikidata-Campsite, User-Ladsgroup, Wikidata Design System, Wikidata, Wikidata Query Builder
Ladsgroup added a comment to T279928: Quantity and Date Inputs are not cleared on switching to "Regardless of Value".

So it's not that bad, it's cleared in the store. Just not rerendered. I'm looking for ways to trigger it.

Mon, Apr 12, 5:46 PM · Wikidata, Wikidata Query Builder
Ladsgroup claimed T279929: property value relation dropdown should go back to "matching" after switching from limited support to supported property.
Mon, Apr 12, 3:35 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata, Wikidata Query Builder
Ladsgroup claimed T279930: Reset property-value-relationship dropdown when switching property to a datatype that doesn't support the current dropdown value.
Mon, Apr 12, 3:32 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata Query Builder, Wikidata
Ladsgroup added a comment to T23272: Differentiate graphically deleted vs. suppressed revisions in history and log.

looked at it, it's a bit all over the place but doable. Before making a patch I think we need to find a good style. I disagree with text-decoration-style: double as it's barely distinguishable from the rest (specially keep accessibility in mind please). Color coding might not be that bad, but it'll conflict with flagged revs probably.

Mon, Apr 12, 2:45 PM · Patch-For-Review, MediaWiki-Revision-deletion
Ladsgroup reopened T279419: New MediaWiki logo is stretched on portals www.wiktionary.org, www.wikinews.org, www.wikiquote.org, www.wikibooks.org and www.wikiversity.org, a subtask of T268230: Roll out the new logo of MediaWiki, as Open.
Mon, Apr 12, 11:54 AM · User-Ladsgroup, MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.31-release-notes, MW-1.35-notes, Patch-For-Review, Logos, MW-1.36-release, Design, MediaWiki-General
Ladsgroup reopened T279419: New MediaWiki logo is stretched on portals www.wiktionary.org, www.wikinews.org, www.wikiquote.org, www.wikibooks.org and www.wikiversity.org as "Open".

Ugh. Two of them were fixed in meta, three were not. We need to wait another week for the next round of deployment.

Mon, Apr 12, 11:54 AM · User-Ladsgroup, Wikimedia-Portals
Ladsgroup added a comment to T279419: New MediaWiki logo is stretched on portals www.wiktionary.org, www.wikinews.org, www.wikiquote.org, www.wikibooks.org and www.wikiversity.org.

Yes. Please clear your browser cache.

Mon, Apr 12, 11:48 AM · User-Ladsgroup, Wikimedia-Portals
Ladsgroup closed T279750: [accepted revision] is white in FlaggedRevs diffs as Resolved.
Mon, Apr 12, 11:29 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, Regression, MediaWiki-extensions-FlaggedRevs
Ladsgroup closed T279419: New MediaWiki logo is stretched on portals www.wiktionary.org, www.wikinews.org, www.wikiquote.org, www.wikibooks.org and www.wikiversity.org as Resolved.
Mon, Apr 12, 11:06 AM · User-Ladsgroup, Wikimedia-Portals
Ladsgroup closed T279419: New MediaWiki logo is stretched on portals www.wiktionary.org, www.wikinews.org, www.wikiquote.org, www.wikibooks.org and www.wikiversity.org, a subtask of T268230: Roll out the new logo of MediaWiki, as Resolved.
Mon, Apr 12, 11:05 AM · User-Ladsgroup, MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.31-release-notes, MW-1.35-notes, Patch-For-Review, Logos, MW-1.36-release, Design, MediaWiki-General
Ladsgroup closed T279398: Change logo of MediaWiki on www.wikipedia.org, a subtask of T268230: Roll out the new logo of MediaWiki, as Resolved.
Mon, Apr 12, 11:04 AM · User-Ladsgroup, MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.31-release-notes, MW-1.35-notes, Patch-For-Review, Logos, MW-1.36-release, Design, MediaWiki-General
Ladsgroup closed T279398: Change logo of MediaWiki on www.wikipedia.org as Resolved.
Mon, Apr 12, 11:04 AM · User-Ladsgroup, Wikimedia-Portals

Sun, Apr 11

Ladsgroup added a comment to T23272: Differentiate graphically deleted vs. suppressed revisions in history and log.

@Ladsgroup would you mind commenting on this, especially as to how developer-costly it would be to implement?

Sun, Apr 11, 8:49 PM · Patch-For-Review, MediaWiki-Revision-deletion
Ladsgroup updated the task description for T279870: Request creation of masz VPS project.
Sun, Apr 11, 8:45 PM · Anti-Harassment, Cloud-VPS (Project-requests)
Ladsgroup created T279870: Request creation of masz VPS project.
Sun, Apr 11, 8:44 PM · Anti-Harassment, Cloud-VPS (Project-requests)

Sat, Apr 10

Ladsgroup updated the task description for T72470: Remove legacy javascript globals.
Sat, Apr 10, 9:53 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.36-notes, MW-1.35-notes, Patch-For-Review, MW-1.35-release, User-notice, Technical-Debt (Deprecation process), Performance-Team-publish, Performance-Team, MediaWiki-ResourceLoader, JavaScript
Ladsgroup added a comment to T188679: Nuke should batch the deletions.

So not even deleteBatch.php batches the deletions. It basically doesn't exist in mediawiki. What should happen here is that Nuke should queue deletion jobs instead.

Sat, Apr 10, 8:50 PM · User-Ladsgroup, MediaWiki-extensions-Nuke
Ladsgroup added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

The traceback doesn't involve abusefilter but it's still possible. I'm also worried it might be flagged revs (in some weird combo config) but fawiki is really similar to enwiki so I think it's not that.

Sat, Apr 10, 5:59 PM · MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Ladsgroup added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

This is borderline UBN.

Sat, Apr 10, 5:41 PM · MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Ladsgroup created T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".
Sat, Apr 10, 5:39 PM · MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Ladsgroup added a comment to T278612: Install mailman3 and mailman2 at the same time on the cloud.

https://polymorphic.lists.wmcloud.org/mailman3/postorius/lists/ ^^

Sat, Apr 10, 7:13 AM · Patch-For-Review, SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T277116: fa_deleted_timestamp and fa_timestamp are binary(14) in code but varbinary(14) in production.

What is needed to move this out of Refine column?

Sat, Apr 10, 1:05 AM · DBA
Ladsgroup added a comment to T277118: iw_url in interwiki is varbinary(127) in production but blob in code.

What is needed to move this out of Refine column?

Sat, Apr 10, 1:05 AM · DBA
Ladsgroup added a comment to T279761: When reviewing pending changes, raw message ID "⧼revreview-hist-quality⧽" shown instead of human readable string.

Yes. I'm aware of that but I rather do it at end of the all the work to reduce the risk of issues.

Sat, Apr 10, 12:45 AM · Regression, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a comment to T279750: [accepted revision] is white in FlaggedRevs diffs.

Found the problem. This fixes it. If gets merged by Monday, I'll backport it. Sorry for the inconvenience. This codebase is beyond rotten. Any change on it is bound to break something it seems but it's necessary to make the code slightly more maintainable.

Sat, Apr 10, 12:00 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, Regression, MediaWiki-extensions-FlaggedRevs

Fri, Apr 9

Ladsgroup closed T278904: [Regression 1.36.0-wmf.36] On enwiki, new edits are being marked as quality instead of "accepted" after manual pending changes review as Resolved.
Fri, Apr 9, 11:38 PM · User-Ladsgroup, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a comment to T279761: When reviewing pending changes, raw message ID "⧼revreview-hist-quality⧽" shown instead of human readable string.

Yeah. I was worried this might happen. Basically we dropped the quality tier but there are edits that are marked as quality and the system doesn't know what to do with them. My suggestion would be to mark all of them as checked in the database. That's not hard to do but I rather not do it in a weekend (where our capacity is reduced and if things go wrong, can't ask for help)

Fri, Apr 9, 11:29 PM · Regression, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a comment to T278904: [Regression 1.36.0-wmf.36] On enwiki, new edits are being marked as quality instead of "accepted" after manual pending changes review.

Yes. It should be fixed now.

Fri, Apr 9, 9:32 PM · User-Ladsgroup, MediaWiki-extensions-FlaggedRevs
Ladsgroup claimed T279750: [accepted revision] is white in FlaggedRevs diffs.

I'll try to see what can be done to fix it.

Fri, Apr 9, 10:32 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, Regression, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a watcher for MediaWiki-extensions-FlaggedRevs: Ladsgroup.
Fri, Apr 9, 10:31 AM