Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Shah of BugsAdministrator

Projects (29)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (270 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata developer, open source enthusiast, mediawiki volunteer developer
Babel: fa-N, en-4, de-1, tr-1

Recent Activity

Today

Ladsgroup added a comment to T185664: Code stewardship review: FlaggedRevs.

The task specifies that there are no security bugs - T234736 is a security bug I filed in October

Mon, Dec 16, 1:04 AM · Release-Engineering-Team (Code Health), MediaWiki-extensions-FlaggedRevs, Code-Stewardship-Reviews

Yesterday

Krinkle awarded T240776: Codesearch "Everything" is missing MediaWiki core a Orange Medal token.
Sun, Dec 15, 1:35 AM · User-Ladsgroup, VPS-project-codesearch
Ladsgroup closed T240776: Codesearch "Everything" is missing MediaWiki core as Resolved.

Fixed now: https://codesearch.wmflabs.org/search/?q=MutableContext&i=nope&files=&repos=

Sun, Dec 15, 12:46 AM · User-Ladsgroup, VPS-project-codesearch
Ladsgroup added a comment to T240776: Codesearch "Everything" is missing MediaWiki core.

The config for everything has core:

"MediaWiki core": {
        "ms-between-poll": 3600000,
        "url": "https://gerrit-replica.wikimedia.org/r/mediawiki/core.git",
        "url-pattern": {
                "base-url": "https://gerrit.wikimedia.org/g/mediawiki/core/+/{rev}/{path}{anchor}",
                "anchor": "#{line}"
        }
},
Sun, Dec 15, 12:39 AM · User-Ladsgroup, VPS-project-codesearch
Ladsgroup added a comment to T240776: Codesearch "Everything" is missing MediaWiki core.

The code says that it should be there, the logs says hound couldn't index it:

ladsgroup@codesearch4:~$ sudo service hound-core status
● hound-core.service - hound-core
   Loaded: loaded (/etc/systemd/system/hound-core.service; enabled; vendor preset: enabled)
   Active: active (running) since Sat 2019-12-14 10:38:55 UTC; 13h ago
  Process: 18456 ExecStop=/usr/bin/docker stop hound-core (code=exited, status=0/SUCCESS)
  Process: 18529 ExecStartPre=/usr/bin/docker pull etsy/hound (code=exited, status=0/SUCCESS)
  Process: 18491 ExecStartPre=/usr/bin/docker rm -f hound-core (code=exited, status=0/SUCCESS)
  Process: 18484 ExecStartPre=/usr/bin/docker kill hound-core (code=exited, status=1/FAILURE)
 Main PID: 18536 (docker)
    Tasks: 6 (limit: 4915)
   Memory: 2.5M
      CPU: 377ms
   CGroup: /system.slice/hound-core.service
           └─18536 /usr/bin/docker run -p 6084:6080 --name hound-core -v /srv/hound/hound-core:/data -v /srv/puppet:/operations/puppet etsy/hound
Sun, Dec 15, 12:31 AM · User-Ladsgroup, VPS-project-codesearch

Sat, Dec 14

Ladsgroup added a comment to T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [].

As always I admire the courageous behavior but changing wikibase' default behavior (be it through removal of the config or inversion of its default value) is worth funneling the news through the appropriate channels.

Sat, Dec 14, 7:02 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-DataModel-Serialization, Wikidata, MediaWiki-extensions-WikibaseRepository

Fri, Dec 13

Ladsgroup added a comment to T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [].

It appears the installations configured by operations/mediawiki-config (wikidata et al) do the expected due to 499999, 507030 ff.
However, default wikibase installations still assume the old behavior ("empty array []").
Is that intentional? The name of the configuration variable (tmpSerializeEmptyListsAsObjects) suggests a step 2 should be had.

Fri, Dec 13, 12:29 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-DataModel-Serialization, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup placed T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master up for grabs.

It's caused by this patch and that $recordsToInsert doesn't necessary have all of the $idsToRestore cases because some might be already in the table. Fixing it is not easy because $recordsToInsert is an associative array of terms properly mapped and $idsToRestore is just list of term ids. I leave this for anyone else to pick up for now.

Fri, Dec 13, 11:44 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Alaa, Wikidata, Wikimedia-production-error
Ladsgroup moved T236895: ArticlePlaceholder dashboard stopped tracking page views from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Dec 13, 10:46 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, Analytics, wikidata-tech-focus, ArticlePlaceholder, Wikidata
Ladsgroup claimed T236895: ArticlePlaceholder dashboard stopped tracking page views.
Fri, Dec 13, 10:46 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, Analytics, wikidata-tech-focus, ArticlePlaceholder, Wikidata
Ladsgroup added a comment to T236895: ArticlePlaceholder dashboard stopped tracking page views.

Can I just use normalized_host field instead?

Fri, Dec 13, 10:24 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, Analytics, wikidata-tech-focus, ArticlePlaceholder, Wikidata
Ladsgroup moved T238539: Remove ControlledFallbackEntityIdFormatter and surrounding logic from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Dec 13, 10:16 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup claimed T238539: Remove ControlledFallbackEntityIdFormatter and surrounding logic.
Fri, Dec 13, 10:15 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup added a comment to T240342: Aliases should wrap nicely in editing mode.

I tried to do this but it's basically impossible or it's possible with horrible css hacks because it's an input element and not a textarea.
I suggest changing it to textarea. Some more info: https://stackoverflow.com/questions/5286663/wrapping-text-inside-input-type-text-element-html-css

Fri, Dec 13, 10:02 AM · Wikidata-Campsite, Wikidata
Ladsgroup added a project to T236772: Document Wikibase Usage Aspects: Wikidata-Campsite.
Fri, Dec 13, 9:43 AM · Wikidata-Campsite, Wikidata, User-Ladsgroup, User-GoranSMilovanovic, WMDE-Analytics-Engineering
Ladsgroup added a comment to T240624: Style desktop Minerva diff page to look like Special:MobileDiff .

I might be wrong here but the diff with mobile with #e07076 and #222 violates AAA WCAG contrast check, also the color of none of the diffs are from the color palette.

Fri, Dec 13, 9:16 AM · MinervaNeue, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)

Thu, Dec 12

Ladsgroup moved T235745: Add Wikidata support for mnwwiki from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Dec 12, 11:27 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T235745: Add Wikidata support for mnwwiki.

Added this one to ready to estimate, but we probably will not estimate it until the other 5 or so wikis pending creation are already ready to have the support turned on.

Thu, Dec 12, 11:27 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Wed, Dec 11

Ladsgroup claimed T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.

I licked this.

Wed, Dec 11, 11:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Alaa, Wikidata, Wikimedia-production-error
Ladsgroup moved T239761: Wikibase is not compatible with PHP7.4 from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11, 11:50 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, PHP 7.4 support
Ladsgroup placed T237984: Some property labels are not displayed on Item pages up for grabs.
Wed, Dec 11, 5:04 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup awarded T236225: [Epic] CheckUser 2.0 Improvements a Love token.
Wed, Dec 11, 3:59 PM · Epic, Anti-Harassment, CheckUser
Ladsgroup added a comment to T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis.

Some shiny graphs:

Wed, Dec 11, 2:52 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Ladsgroup, StructuredDataOnCommons, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Michael, Wikidata, Wikimedia-production-error
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11, 2:51 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T240235: Alter rebuildItemTerms.php to allow passing of a a list of int item ids to process from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11, 2:49 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MediaWiki-extensions-WikibaseRepository, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T240235: Alter rebuildItemTerms.php to allow passing of a a list of int item ids to process.
Wed, Dec 11, 1:05 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MediaWiki-extensions-WikibaseRepository, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T239761: Wikibase is not compatible with PHP7.4 from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11, 1:04 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, PHP 7.4 support
Ladsgroup closed T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis as Resolved.
Wed, Dec 11, 12:24 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Ladsgroup, StructuredDataOnCommons, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Michael, Wikidata, Wikimedia-production-error
Ladsgroup closed T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis, a subtask of T233858: 1.35.0-wmf.10 deployment blockers, as Resolved.
Wed, Dec 11, 12:24 PM · Release, Train Deployments
Ladsgroup added a project to T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]: Core Platform Team.

I highly doubt this is something Wikibase team would be able to fix. The usage of the LocalUserCreated hook in Wikibase code seems to be straightforward and simple, something in core or Translate extension needs to change. It might be caused by splitting Language object. I add Daniel and CPT to the ticket.

Wed, Dec 11, 12:17 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikimedia-production-error, Wikidata
Ladsgroup reassigned T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis from Ladsgroup to Michael.
Wed, Dec 11, 12:11 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Ladsgroup, StructuredDataOnCommons, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Michael, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis.

Doing it as we speak

Wed, Dec 11, 11:35 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Ladsgroup, StructuredDataOnCommons, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Michael, Wikidata, Wikimedia-production-error
Ladsgroup moved T240316: Issue with QuickStatements "you are blocked on Wikidata" from To Do to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11, 11:31 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T240316: Issue with QuickStatements "you are blocked on Wikidata".

Added all reserved IPs for private network to the whitelist to avoid cases like that in the future.

Wed, Dec 11, 11:31 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T240410: Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 11, 11:18 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Ladsgroup, StructuredDataOnCommons, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Michael, Wikidata, Wikimedia-production-error

Tue, Dec 10

Ladsgroup added a comment to T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5].

I might be very wrong here but can it be that it's caused by I7ca40f8eda?

Tue, Dec 10, 11:25 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikimedia-production-error, Wikidata
Ladsgroup moved T235468: Add monolingual language code mfa from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 10, 11:03 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T240097: Add Chukchi language (ckt) to monolingual codes from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 10, 11:03 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup moved T155424: Add monolingual language code abq-Latn (Abaza in Latin script) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 10, 11:03 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup moved T240098: Add Dagbani language (dag) to monolingual codes from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 10, 11:03 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup moved T239761: Wikibase is not compatible with PHP7.4 from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 10, 10:59 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, PHP 7.4 support
Ladsgroup added a comment to T239931: Reduce the impact of the sanitizer on wikidata.

Sounds like some kind of parse flag? I'm not too familiar with those interfaces. Separately, CirrusSearch tends to assume that the ParserCache has an anonymously rendered version of all current pages somewhere. Is Cirrus somehow getting a different cache key than anonymous page views?

Tue, Dec 10, 10:22 PM · Discovery-Search, CirrusSearch, Wikidata
Ladsgroup added a comment to T232240: New service to shorten wmflabs URLs.

I would be willing to take on this one, I just want to have a system of enforcing some whitelist/blacklist for users like an OAuth

Tue, Dec 10, 10:14 PM · Cloud-Services
Ladsgroup added a comment to T240316: Issue with QuickStatements "you are blocked on Wikidata".

Added. Does it fix the issue?

Tue, Dec 10, 4:19 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T239761: Wikibase is not compatible with PHP7.4.

With the patch applied the only errors and warnings left are:

10:48:30 7) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "by title" (array('query', 'pageterms', 'No11|No22|No3333'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Vienna'), array('Capitol city of Austria'))), array(array(array('Moscow'), array('Capitol city of Russia'))), array(array(array('Population'), array('number of inhabitants')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30 
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 8) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "descriptions only" (array('query', 'pageterms', 'No11|No22', 'description'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Capitol city of Austria'))), array(array(array('Capitol city of Russia')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30 
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 9) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "with uselang" (array('query', 'pageterms', 'No11|No22', 'de'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Wien'), array('Hauptstadt Österreichs'))), array(array(array('Moskau'), array('Hauptstadt Russlands')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache::isExpired(de): cache missing, need to make one []
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30 
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 10) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "title without entity" (array('query', 'pageterms', 'No11|SomeTitleWithoutEntity'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Vienna'), array('Capitol city of Austria')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30 
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 11) Wikibase\Client\Tests\Api\PageTermsTest::testPageTerms with data set "continue" (array('query', 'pageterms', 'No11|No22', '20'), array(array(array('Vienna', 'Wien'), array('Capitol city of Austria', 'Hauptstadt Österreichs')), array(array('Moscow', 'Moskau'), array('Capitol city of Russia', 'Hauptstadt Russlands')), array(array('Population', 'Einwohnerzahl'), array('number of inhabitants', 'Anzahl der Bewohner'))), array(array(array(array('Moscow'), array('Capitol city of Russia')))))
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:48:30 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 ===
10:48:30 Trying to access array offset on value of type null
10:48:30 
10:48:30 /workspace/src/includes/api/ApiPageSet.php:125
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:47
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:229
10:48:30 /workspace/src/extensions/Wikibase/client/tests/phpunit/includes/Api/PageTermsTest.php:391
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 --
10:48:30 
10:48:30 There were 7 warnings:
10:48:30 
10:48:30 1) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "full empty" (array(), 'full-dump', 'empty')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 2) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "full some entities" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'full-dump', 'entities')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 3) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "full redirect" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'full-dump', 'redirect')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 4) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "truthy empty" (array(), 'truthy-dump', 'empty')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 5) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "truthy some entities" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'truthy-dump', 'entities')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 6) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testGenerateDump with data set "truthy redirect" (array(Wikibase\DataModel\Entity\PropertyId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'truthy-dump', 'redirect')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
10:48:30 
10:48:30 7) Wikibase\Repo\Tests\Dumpers\RdfDumpGeneratorTest::testReferenceDedup with data set "references" (array(Wikibase\DataModel\Entity\ItemId Object (...), Wikibase\DataModel\Entity\ItemId Object (...)), 'refs')
10:48:30 === Logs generated by test case
10:48:30 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:48:30 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"}
10:48:30 ===
10:48:30 Trying to configure method "getTitleForId" which cannot be configured because it does not exist, has not been specified, is final, or is static
10:48:30 
10:48:30 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
10:48:30 /workspace/src/maintenance/doMaintenance.php:99
`
Tue, Dec 10, 3:04 PM · User-Ladsgroup, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, PHP 7.4 support
Ladsgroup placed T233490: wikibase-docker, switch wikibase images to use composer merge plugin up for grabs.
Tue, Dec 10, 2:57 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Containers
Ladsgroup moved T233490: wikibase-docker, switch wikibase images to use composer merge plugin from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 10, 2:57 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Containers
Ladsgroup added a comment to T237667: PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue) [8 story points].

Sorry, When I made the patch to gerrit it made sense to open the ticket so the bots can add the patch to this ticket, when the patch is in gerrit, this can be opened. right?

Tue, Dec 10, 2:53 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Security, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
Ladsgroup merged T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php] into T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Tue, Dec 10, 2:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Alaa, Wikidata, Wikimedia-production-error
Ladsgroup merged task T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php] into T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.
Tue, Dec 10, 2:50 PM · Wikidata-Campsite, Wikimedia-production-error, Wikidata
Ladsgroup updated the task description for T208425: [EPIC] Kill the wb_terms table.
Tue, Dec 10, 2:48 PM · User-Addshore, wikidata-tech-focus, Wikidata-Ugly-Cat-Trailblaze (wb_terms trail blazing), Wikidata
Ladsgroup claimed T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

Let's continue discussion in T239931: Reduce the impact of the sanitizer on wikidata. For the sense of the spikes, this is done.

Tue, Dec 10, 2:44 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

I got my answer, PC gets purged at 1:00 UTC every day only (using mediawiki::maintenance::parsercachepurging job) meaning I have to wait a full day to get the value.

Tue, Dec 10, 12:33 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a subtask for T233856: 1.35.0-wmf.8 deployment blockers: T240316: Issue with QuickStatements "you are blocked on Wikidata".
Tue, Dec 10, 11:53 AM · Release, Train Deployments
Ladsgroup added a subtask for T233858: 1.35.0-wmf.10 deployment blockers: T240316: Issue with QuickStatements "you are blocked on Wikidata".
Tue, Dec 10, 11:53 AM · Release, Train Deployments
Ladsgroup added parent tasks for T240316: Issue with QuickStatements "you are blocked on Wikidata": T233856: 1.35.0-wmf.8 deployment blockers, T233858: 1.35.0-wmf.10 deployment blockers.
Tue, Dec 10, 11:53 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T240316: Issue with QuickStatements "you are blocked on Wikidata".

Potentially a train blocker.

Tue, Dec 10, 11:35 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T240316: Issue with QuickStatements "you are blocked on Wikidata".

I can't check right now but for whoever is debugging, this is very likely regression from wmf.8 that got deployed yesterday. (List of patches that got deployed)

Tue, Dec 10, 11:34 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

Regarding size of ParserCache. I queries pc255 on the first PC node. it had 975,982 rows yesterday and today it had 975,580. Assuming perfect randomness in sharding, there should be a total of 308,736 rows drop (154,368 PC entries) since yesterday. Even though I don't see the drop in the graphs, maybe it needs more time.

Tue, Dec 10, 11:32 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction.

What @brennen reported isn’t a deadlock, isn’t it? It seems to be some race condition that we thought Should Never Happen™.

Tue, Dec 10, 11:15 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikimedia-database-error, Wikidata
Ladsgroup added a comment to T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction.

This is the right issue but given the size of migration still a little bit of deadlock is unavoidable. How big the number is?

Tue, Dec 10, 10:59 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Wikimedia-database-error, Wikidata
Ladsgroup changed the visibility for T237667: PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue) [8 story points].
Tue, Dec 10, 10:47 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Security, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

The spikes are gone now:


Tue, Dec 10, 10:35 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Dec 9

Ladsgroup added a comment to T239931: Reduce the impact of the sanitizer on wikidata.

Hey, Thanks for the comment. I'm planning to turn it back on ASAP, right now, we are at middle of the migration and it puts too much pressure on s8, once the migration of of wb_terms is over, we can turn this back on again. That's going to happen in two months (hopefully).

Mon, Dec 9, 11:57 PM · Discovery-Search, CirrusSearch, Wikidata
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.

What do we think about the pile of these in the log:

21:31:02 Wikibase\Repo\Store\Sql\SqlChangeDispatchCoordinator::selectClient: Could not lock any of the candidate client wikis for dispatching

Are they a problem?

Mon, Dec 9, 9:37 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup claimed T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
Mon, Dec 9, 8:55 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup moved T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186 from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 9, 8:54 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup edited projects for T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

Filled the follow up: T240263

Mon, Dec 9, 8:54 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup created T240263: Add memcached to mwmaint01 using puppet.
Mon, Dec 9, 8:54 PM · Puppet, Beta-Cluster-Infrastructure
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.
ladsgroup@deployment-mwmaint01:/var/log/wikidata$ tail dispatchChanges-wikidatawiki.log --lines 50
12887: Starting dispatcher
20:45:02 Starting loop for unlimited passes or 540 seconds
20:45:05 Posted 6 changes to enwiki, up to ID 1681591, timestamp 20191209130228. Lag is 27757 seconds. Next ID is 1681747.
20:45:08 Posted 2 changes to dewiki, up to ID 1680869, timestamp 20191204174336. Lag is 442892 seconds. Next ID is 1681747.
Mon, Dec 9, 8:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.

nope, memcached php extension wasn't installed there. Then it was lack of geoip and msgpack php extensions.

Mon, Dec 9, 8:46 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.

It's because the mwmaint01 is dirty...

Mon, Dec 9, 5:43 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup added a comment to T239894: Dispatching broken on beta - Fatal error: Class 'Memcached' not found in ObjectCache.php on line 186.

This is a big misconfiguration. ObjactCache in line 186 dynamically tries to load the cache class defined in "class" configuration (grrr). They all changed for the mcrouter stuff. I'm trying to see if I can fix it.

Mon, Dec 9, 5:34 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-Cache, Beta-Cluster-reproducible
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

@Ladsgroup I think we can move this from peer review now, great investigative work!
The question is, should it live in the waiting col on the iteration or on the campsite board? ;)

Mon, Dec 9, 2:34 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T239470: Check the success of the initial terms migration (does it have holes).

I ran some checks on your numbers. It seems in some ranges, things are clean, like only 30% have issues in some ranges more than > 95%. This is the numbers separated by millions. 1 means up to Q1Mio:

1 364510
2 415854
3 380372
4 302745
5 356028
6 326523
7 444421
8 404898
9 821285
10 590021
11 475503
12 218112
13 256970
14 384180
15 439502
16 639781
17 320441
18 409604
19 330605
20 201857
21 449418
22 426350
23 582121
24 321645
25 443846
26 462407
27 350897
28 446790
29 488908
30 322142
31 620204
32 364034
33 659610
34 815488
35 784804
36 642381
37 950938
38 912740
39 920671
40 950641
41 948308
42 807250
43 793387
44 849349
45 928451
46 644449
47 910284
48 534375
49 36997
50 397077
51 875785
52 923620
53 819251
54 607872
55 559604
56 751158
57 851437
58 915506
59 945442
60 905496
61 861103
62 841255
63 811589
64 700324
65 841526
66 831120
67 705046
68 658960
69 811256
70 620628
71 687696
72 885236
73 883354
74 878387
75 800494
76 986947
77 976292
78 236429
`
Mon, Dec 9, 1:13 PM · User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T171986: Diff summary doesn't work for foreign entities.

This is funny. Looking at commons, now linking works but the label is gone:
(For example)

Mon, Dec 9, 10:45 AM · User-Addshore, SDC General, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup added a comment to T231518: Add *.wmflabs.org to w.wiki shortener.

I can create a project in cloud vps and install url shortener there. Is there anyone who wants to help maintaining it for the future?

Mon, Dec 9, 10:24 AM · Wikimedia-Site-requests, Security-Team, MediaWiki-extensions-UrlShortener

Sun, Dec 8

Ladsgroup added a comment to T155425: Add monolingual language code phn (Phoenician).

@jhsoby What's the final decision here?

Sun, Dec 8, 4:22 PM · patch-welcome, good first task, Wikidata

Sat, Dec 7

Ladsgroup added a comment to T192134: Personal and site-wide CSS and JavaScript is loaded on Special:PasswordReset.

Maybe I should call that method in alterForm instead of construct. Can't say for sure tbh.

Most other specials seem to call it in execute() though SpecialPasswordReset.php doesn't call execute() right now. I'm not sure there's anything wrong with calling disallowUserJs() within the constructor, though I'm sure that could be modified to look more like what is done in SpecialChangeEmail for consistency's sake. Anyhow, whatever you want to do, I'd like to try to deploy this during the security deployment window this Monday, if possible.

Sat, Dec 7, 10:39 PM · MW-1.32-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.34-notes, MW-1.33-notes, MW-1.31-release-notes, User-Ladsgroup, Security-Team, MediaWiki-Special-pages, Security

Fri, Dec 6

Ladsgroup moved T237984: Some property labels are not displayed on Item pages from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Dec 6, 11:59 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Thu, Dec 5

Ladsgroup moved T229407: Spikes in DB traffic and rows/s reads when reading from new terms store from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Dec 5, 9:37 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T237984: Some property labels are not displayed on Item pages from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

I think I know what's causing it but given the nature of the problem (like the ones you mentioned, they all are fixed now), it's really hard to make sure that would fix it. I will make a patch and hopefully wait to see if that stops happening.

Thu, Dec 5, 9:37 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Dec 5, 9:18 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

So After lots of debugging it turned out that it's CirrusSearchChecker job that is causing this. The time matches perfectly:

Thu, Dec 5, 7:18 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Addshore awarded T229407: Spikes in DB traffic and rows/s reads when reading from new terms store a Baby Tequila token.
Thu, Dec 5, 1:02 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup updated subscribers of T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

Binlogs that @Marostegui gave me has things like this:

REPLACE /* SqlBagOStuff::updateTableKeys RunSingleJob.php@mw1335 */ INTO `pc156` (keyname,value,exptime) VALUES ('wikidatawiki:pcache:idoptions:55899217','<gibberish>...

In timespan of six minutes, there's 17k of praser cache insertion on wikidata from RunSingleJob.php in one of the three PC nodes. This is, to put it mildly, insane. One of the items that got a new PC is Q55864736 that hasn't visited in the last month, has no templates or entity usage. I think it's one of wikibase jobs. I dig deeper now.

Thu, Dec 5, 11:34 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T237984: Some property labels are not displayed on Item pages.

What is the item?

Thu, Dec 5, 11:20 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

Given the dbs (in s7) I highly doubt it's wikidata but I also want to mention that s7 has only frwiktionary and metawiki as their group1 wikis. Is there anything special about those?

Thu, Dec 5, 10:18 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Ladsgroup claimed T237551: beta wikidata trying to dispatch to wikis that don't exist.

:D

Thu, Dec 5, 10:14 AM · User-Ladsgroup, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Beta-Cluster-Infrastructure
Ladsgroup added a comment to T237013: Refactor the Wikidata Data Quality Report analytics procedures.

@Ladsgroup As of me, you don't need to keep the following ORES updates on stat1007 anymore:

  • run.out
  • run_20190901.out
  • run_201910.out
  • run_201911.out

From the filenames of your most recent updates: run_201910.out, run_201911.out, I infer that we will have run_201912.out, run_202001.out, then run_202002.out, etc. in the future. Please confirm.

Thu, Dec 5, 10:11 AM · User-GoranSMilovanovic, WMDE-Analytics-Engineering

Wed, Dec 4

Ladsgroup added a comment to T143870: Some mw snapshot hosts are accessing main db servers.

Can this be causing spikes desribed in T229407: Spikes in DB traffic and rows/s reads when reading from new terms store as well?
Some graphs to look at:

Wed, Dec 4, 7:42 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Dumps-Generation, DBA
Ladsgroup added a comment to T239594: Unexpected general module "jquery.ui.core.styles" in styles queue..

I deployed it in wmf.8, if everything goes well. This should be gone in a couple of hours.

Wed, Dec 4, 7:17 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Performance-Team, Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup moved T237551: beta wikidata trying to dispatch to wikis that don't exist from Ready to pick up to Ready to estimate on the Wikidata-Campsite board.
Wed, Dec 4, 5:01 PM · User-Ladsgroup, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Beta-Cluster-Infrastructure
Ladsgroup added a comment to T237551: beta wikidata trying to dispatch to wikis that don't exist.

This was fun. The client, the list, everything for that was fine, the problem was that somehow wb_changes_dispatch table got production data (could have happened when someone mistakenly changes to $wgWBRepoSettings['localClientDatabases'] to be as the same as production. You can quickly fix it but when it's messes up the table, it can't get fixed on its own.) I dropped everything from that table and dispatching is back to normal now.

Wed, Dec 4, 5:01 PM · User-Ladsgroup, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Beta-Cluster-Infrastructure
Ladsgroup moved T229407: Spikes in DB traffic and rows/s reads when reading from new terms store from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 4, 12:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

I have been working on this since yesterday. I have a hunch what's going on here. Will write more once I'm certain.

Wed, Dec 4, 12:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Tue, Dec 3

Ladsgroup added a comment to T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master.

Still happening: 240

Tue, Dec 3, 5:37 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Alaa, Wikimedia-production-error, Wikidata
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Dec 3, 2:57 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Dec 2

Ladsgroup moved T225057: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_NEW from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 2, 9:58 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
Ladsgroup moved T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 2, 9:52 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata