Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani (WMDE))
Master of introducing new bugsAdministrator

Projects (29)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (244 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Wikidata developer, open source enthusiast, mediawiki volunteer developer
Babel: fa-N, en-4, de-1, tr-1

Recent Activity

Today

Ladsgroup added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

This is rather lots of work, SpecialWikibasePage is not the right place to keep the list, Making it per special page also is complex, like Special:SetLabel can be used on property and item and if the person is blocked on item namespace, there's no way to make sure it's applied until the user actually tries it (in which EntityStore should handle it properly using PermissionManager), so maybe we should just drop it? I would prefer if the special page still checks for site-wide bans.

Mon, Jun 17, 2:57 PM · Patch-For-Review, Anti-Harassment, Wikidata-Campsite, MediaWiki-extensions-WikibaseRepository, Wikidata
Ladsgroup added a comment to T214884: linking Schemas in statements.

It would have been so much easier if EntitySchemas were entities, we just could have re-used the entity datatype boilerplate

Mon, Jun 17, 2:03 PM · Wikidata-Campsite, Wikidata, Shape Expressions
Ladsgroup moved T225073: Add baserevid to wblremovesense API module from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jun 17, 12:41 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup moved T225500: Decrease EntityUsageTable addUsage batch size to 100 from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Jun 17, 12:32 PM · User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, Wikidata
Ladsgroup added a comment to T223303: on production enable bugfix for wbeditentity setting aliases to empty array.

https://www.wikidata.org/w/index.php?title=Q4115189&diff=963952400&oldid=963896842

Mon, Jun 17, 11:51 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup updated Ladsgroup.
Mon, Jun 17, 9:13 AM

Yesterday

Ladsgroup added a comment to T225496: Improve caching in CI tests.

I just put this here:

Sun, Jun 16, 5:46 PM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup

Fri, Jun 14

Ladsgroup created T225787: LGBT mailing list moderator password reset.
Fri, Jun 14, 9:12 AM · Operations, Wikimedia-Mailing-lists

Thu, Jun 13

Ladsgroup added a comment to T225496: Improve caching in CI tests.

This seems to have had a ~20% speed improvement – picking two patches merged into MW-core either side of this change (but without any change in the number or nature of tests), the before durations are 135 and 156 seconds, and the after durations are 162 and 187. Of course, the durations bump around based on CI server load, but 30 seconds saved is 30 seconds saved.

Thu, Jun 13, 11:10 AM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup
Krinkle awarded T225496: Improve caching in CI tests a Orange Medal token.
Thu, Jun 13, 1:18 AM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup

Tue, Jun 11

Ladsgroup added a comment to T160690: Be able to request a custom icon pack on-the-fly without bloating RL module registry.

The first user is probably going to be this MobileFrontend patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/510067/10..11/extension.json

Tue, Jun 11, 11:26 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Front-end-Standards-Group, Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader, Epic, OOUI
Ladsgroup added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

Another note and observation: Running tests in HHVM is extremely slower than php7. phpunit excluding database takes 2 minutes in hhvm and 40 seconds in php7. Selenium takes 4 minutes on hhvm and 1 minute on php7. These jobs hopefully will be dropped soon.

Tue, Jun 11, 9:42 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
Ladsgroup added a comment to T225524: phan stopped respecting dependencies.

Yes, the fixes to make phan not slow down CI mean that it's now non-recursive in dependency fetching. See T225112.

I guess the real dependency tree for WikibaseLexeme needs to be updated.

Tue, Jun 11, 3:34 PM · Continuous-Integration-Config, phan
Ladsgroup created T225524: phan stopped respecting dependencies.
Tue, Jun 11, 3:11 PM · Continuous-Integration-Config, phan
Ladsgroup moved T225073: Add baserevid to wblremovesense API module from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Jun 11, 12:20 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T225496: Improve caching in CI tests.

Number of DBQueries drop by 1000:

amsa@amsa-Latitude-7480:~/Downloads$ grep DBQuery mw-debug-www.log | wc -l
24814
amsa@amsa-Latitude-7480:~/Downloads$ grep DBQuery mw-debug-www.log.1 | wc -l
23775
Tue, Jun 11, 12:06 PM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup
Ladsgroup added a comment to T225496: Improve caching in CI tests.

^ This patch reduces the time for selenium tests from 1:18 to 0:50 ([https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php70-docker/20462/consoleFull| 1]] 2). Number of calls to SqlBagOStuff reduces drastically:

amsa@amsa-Latitude-7480:~/Downloads$ grep SqlBag mw-debug-www.log | wc -l
1623
amsa@amsa-Latitude-7480:~/Downloads$ grep SqlBag mw-debug-www.log.1 | wc -l
113
Tue, Jun 11, 11:57 AM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup
Restricted Application added a project to T225496: Improve caching in CI tests: User-Ladsgroup.
Tue, Jun 11, 11:18 AM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup

Mon, Jun 10

Ladsgroup added a comment to T222626: Turn logout link into a POST API call with refresh.

It works in beta as expected:

Mon, Jun 10, 2:48 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikimedia-Hackathon-2019, User-Ladsgroup, MediaWiki-Authentication-and-authorization, Security
Ladsgroup added a comment to T225420: Let order in Special:Translate to be random.

I don't have any idea how to do deterministic random sorts (for paging) efficiently.

Mon, Jun 10, 11:49 AM · MediaWiki-extensions-Translate
Ladsgroup created T225420: Let order in Special:Translate to be random.
Mon, Jun 10, 11:33 AM · MediaWiki-extensions-Translate

Sun, Jun 9

Ladsgroup added a comment to T222224: Normalizing *links tables.

I started the patch, It's way far from being ready.

Sun, Jun 9, 7:49 PM · Patch-For-Review, MediaWiki-Database, TechCom-RFC
Ladsgroup added a comment to T223602: Define variant Wikimedia production config in compiled, static files.

2- indentation is tricky and problematic sometimes. You know, like this.

Let me drill down on this a bit. The most annoying part is when you make a mistake in json, it explodes, it gives you error "Unable to parse json" but when you make a mistake in yaml, it works but the output is changed in a sneaky way and it explodes when you deploy it :)

Sun, Jun 9, 2:27 PM · Release-Engineering-Team (Kanban), Epic, serviceops, Continuous-Integration-Config

Sat, Jun 8

Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

That's an argument against code commenting in general.
I strongly disagree with the suggestion that we should limit the amount of comments a developer is allowed to provide, either explicitly or implicitly (by choice of format). I can guarantee that any recommendation that developers should add their comments somewhere other than alongside the code they are writing will simply result in developers not writing comments at all.

Well, Developers should avoid writing comments as much as possible too. I know it seems counter-intuitive but there's a whole chapter of "Clean Code" by Uncle Bob dedicated to this. There are lots of reasons for that:

  • The code should be self-explanatory through variables/classes/methods names and structure (readability of the code is an important factor in maintainability of it) then comments become redundant and a cognitive load without giving out anything new.
  • When you have code and comments, they might get out of sync, they become misleading, they decay and now you need to main two things instead of one. (If you're maintaining documentation, like what we do for schema structures at mediawiki.org, you have three things to maintain, the DDL, the comments, the mediawiki.org documentation).
Sat, Jun 8, 9:54 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup closed T222626: Turn logout link into a POST API call with refresh as Resolved.

\o/

Sat, Jun 8, 7:03 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikimedia-Hackathon-2019, User-Ladsgroup, MediaWiki-Authentication-and-authorization, Security
Ladsgroup added a comment to T223602: Define variant Wikimedia production config in compiled, static files.

@Ladsgroup what sort of issues have you had with yaml in python? How complicated are the structures you needed to represent?

Sat, Jun 8, 6:47 PM · Release-Engineering-Team (Kanban), Epic, serviceops, Continuous-Integration-Config
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

Abstract schemas is an argument for keeping MSSQL, Oracle, and other lightly-supported DBMSes in Core, not splitting them out.

You are completely right but that's true when there's an existing abstraction in place. With current system and specially in case of oracle, it's not possible to use Doctrine DBAL to build the abstraction or requires a great amount of developer work to write a DBAL from scratch. (See this)

Sat, Jun 8, 6:23 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

(Warning. Long comment ahead)
This week, I have been so frustrated with slow jenkins that I spent the last two days trying to make it faster. I learned a lot about mediawiki's caching actually which is surprising to me. While I share the same concern, I think making browser tests non-voting defies the point of having them in the first place (we did a similar thing with Wikibase, we moved most of browser tests to a daily jenkins job. Guess what happened. The tests have been red for around two years now.
So what should we do?

  • Find and fix slow phpunit tests. We have report of tests run time which is pretty useful in finding weird cases.
  • Move browser tests to another parallel job.
  • Separate unit tests from integration tests (T87781: Split mediawiki tests into unit and integration tests) It doesn't just make the tests faster, it has another fun benefit too. quibble is really smart, at first it runs phpunit excluding database group (we should start honoring "database" tag in our codebase, I don't think we do). Then it runs the browser tests and then at last runs database phpunit tests. This is a smart way to stop early when the build is going to fail anyway, run fast ones first and abort when they fail. By separating unittests, we can put them in front of quibble queue, making it abort jobs that fail in unittests before running lots of other tests.
  • Improve caching in our tests. I thought phpunit uses the default caching for database but it actually sets all of caches to 'hash' (opcache) in all types of tests. If we do this for browser tests too, it makes them blazing fast. Number of database queries if you set caching to database is unbelievable (Try it). I set browsertests caching to APCu but it hasn't been merged yet: https://gerrit.wikimedia.org/r/515702 That will improve things drastically. But still we might want to consider using persistent cache in our unittests because for example making Language object is pretty expensive but they are cached.
  • Speaking of Language object, can this be more mockable or split? Most of slow phpunit tests are slow because they try to make the object. In my (rather slow) computer it takes around 50ms to just construct and do a basic use of Language object (you can see the difference by changing the language so it reuses the cache)
Sat, Jun 8, 4:32 PM · MediaWiki-Core-Testing, Patch-For-Review, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity
Ladsgroup triaged T225351: Regression in diffing unreviewed changes in edit mode in FlaggedRevs as High priority.
Sat, Jun 8, 1:20 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Regression, MediaWiki-extensions-FlaggedRevs
Ladsgroup closed T155878: Use OOUI icons for FlaggedRevs as Resolved.

I made T225351: Regression in diffing unreviewed changes in edit mode in FlaggedRevs for the regression. The point of the task is done (Renewing icons). It should be reopened if the regression causes it to be reverted which happened yet (it's more likely that this regression gets fixed instead)

Sat, Jun 8, 1:19 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization
Ladsgroup closed T155878: Use OOUI icons for FlaggedRevs, a subtask of T55733: Use the same icons to represent the same things (tracking), as Resolved.
Sat, Jun 8, 1:19 PM · UI-Standardization, OOUI, Tracking-Neverending, Design, MediaWiki-General-or-Unknown
Ladsgroup created T225351: Regression in diffing unreviewed changes in edit mode in FlaggedRevs.
Sat, Jun 8, 1:17 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Regression, MediaWiki-extensions-FlaggedRevs

Thu, Jun 6

Ladsgroup moved T225017: Flaky WikibaseLexeme test from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jun 6, 8:48 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error (Shared Build Failure), Lexicographical data, Wikidata
Ladsgroup added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

So this is the backtrace when you set $wgWBRepoSettings['useEntitySourceBasedFederation'] = true;:

/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php:106
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessor.php:88
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php:264
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php:186
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:125
/var/lib/mediawiki2/extensions/Wikibase/data-access/src/ByTypeDispatchingEntityRevisionLookup.php:54
/var/lib/mediawiki2/extensions/WikibaseLexeme/src/DataAccess/Store/SenseRevisionLookup.php:55
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityRevisionLookup.php:54
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:104
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:87
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:104
/var/lib/mediawiki2/extensions/Wikibase/lib/includes/Store/CachingEntityRevisionLookup.php:87
/var/lib/mediawiki2/extensions/Wikibase/repo/includes/Api/GetEntities.php:275
/var/lib/mediawiki2/extensions/Wikibase/repo/includes/Api/GetEntities.php:257
/var/lib/mediawiki2/extensions/Wikibase/repo/includes/Api/GetEntities.php:136
/var/lib/mediawiki2/includes/api/ApiMain.php:1595
/var/lib/mediawiki2/includes/api/ApiMain.php:500
/var/lib/mediawiki2/tests/phpunit/includes/api/ApiTestCase.php:106
/var/lib/mediawiki2/extensions/Wikibase/repo/tests/phpunit/includes/Api/WikibaseApiTestCase.php:156
/var/lib/mediawiki2/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Api/LexemeGetEntitiesTest.php:105
/var/lib/mediawiki2/tests/phpunit/MediaWikiTestCase.php:427
/var/lib/mediawiki2/maintenance/doMaintenance.php:99
Thu, Jun 6, 8:39 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
stjn awarded T155878: Use OOUI icons for FlaggedRevs a Like token.
Thu, Jun 6, 7:21 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization
Ladsgroup moved T224301: Clean up ruby test infrastructure from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Jun 6, 4:15 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Browser-Tests, Story, wikidata-tech-focus, Technical-Debt, Lexicographical data, Wikidata
Ladsgroup added a comment to T211014: Requesting access to deployment for Christoph Jauera (WMDE-Fisch).

I just added @WMDE-Fisch to wmf-deployment LDAP group which seems was not done with this

Thu, Jun 6, 2:07 PM · Release-Engineering-Team (Watching / External), User-jijiki, Patch-For-Review, SRE-Access-Requests, Operations
Ladsgroup added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

If you set $wgWBRepoSettings['useEntitySourceBasedFederation'] = true; in localhost, it works just fine:

{
    "entities": {
        "L16-F1": {
            "pageid": 513,
            "ns": 146,
            "title": "Lexeme:L16",
            "lastrevid": 515,
            "modified": "2019-05-22T15:06:48Z",
            "id": "L16-F1",
            "representations": {
                "en": {
                    "language": "en",
                    "value": "ff"
                }
            },
            "grammaticalFeatures": [],
            "claims": {}
        }
    },
    "success": 1
}
Thu, Jun 6, 10:31 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup awarded T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone a Like token.
Thu, Jun 6, 8:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch
Restricted Application added a project to T225183: $wgLexemeUseCirrus and $wgLexemeDisableCirrus both set to true for production: Discovery-Search.
Thu, Jun 6, 8:37 AM · Discovery-Search (Current work), Wikimedia-Site-requests

Wed, Jun 5

Ladsgroup added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

This is all of wikibase-related configs that differ between production and beta clsuter:

1 wgWBQualityConstraintsWikibaseFormId:"Q505134"
1 wgWBQualityConstraintsWikibaseFormId:"Q54285143"
1 wgWBQualityConstraintsWikibaseItemId:"Q29934200"
1 wgWBQualityConstraintsWikibaseItemId:"Q505131"
1 wgWBQualityConstraintsWikibaseLexemeId:"Q505133"
1 wgWBQualityConstraintsWikibaseLexemeId:"Q51885771"
1 wgWBQualityConstraintsWikibasePropertyId:"Q29934218"
1 wgWBQualityConstraintsWikibasePropertyId:"Q505132"
1 wgWBQualityConstraintsWikibaseSenseId:"Q505135"
1 wgWBQualityConstraintsWikibaseSenseId:"Q54285715"
1 wgWikibaseMultiRepositoryServiceWiringFiles:["\/srv\/mediawiki\/php-1.34.0-wmf.8\/extensions\/Wikibase\/client\/..\/data-access\/src\/MultiRepositoryServiceWiring.php"]
1 wgWikibaseMultiRepositoryServiceWiringFiles:["\/srv\/mediawiki-staging\/php-master\/extensions\/Wikibase\/client\/..\/data-access\/src\/MultiRepositoryServiceWiring.php"]
1 wgWikibasePerRepositoryServiceWiringFiles:["\/srv\/mediawiki\/php-1.34.0-wmf.8\/extensions\/Wikibase\/client\/..\/data-access\/src\/PerRepositoryServiceWiring.php"]
1 wgWikibasePerRepositoryServiceWiringFiles:["\/srv\/mediawiki-staging\/php-master\/extensions\/Wikibase\/client\/..\/data-access\/src\/PerRepositoryServiceWiring.php"]
1 wmgWikibaseClientBadgeClassNames:{"Q17437796":"badge-featuredarticle","Q17437798":"badge-goodarticle","Q17559452":"badge-recommendedarticle","Q17506997":"badge-featuredlist","Q17580674":"badge-featuredportal","Q20748091":"badge-notproofread","Q20748094":"badge-problematic","Q20748092":"badge-proofread","Q20748093":"badge-validated","Q28064618":"badge-digitaldocument","Q51759403":"badge-goodlist"}
1 wmgWikibaseClientBadgeClassNames:{"Q49444":"badge-goodarticle","Q49447":"badge-featuredarticle","Q49448":"badge-recommendedarticle","Q49449":"badge-featuredlist","Q49450":"badge-featuredportal","Q98649":"badge-notproofread","Q98650":"badge-problematic","Q98658":"badge-proofread","Q98651":"badge-validated"}
1 wmgWikibaseClientEchoIcon:{"path":"\/static\/images\/wikibase\/echoIcon.svg"}
1 wmgWikibaseClientEchoIcon:{"url":"\/static\/images\/wikibase\/echoIcon.svg"}
1 wmgWikibaseClientPropertyOrderUrl:"https:\/\/www.wikidata.org\/w\/index.php?title=MediaWiki:Wikibase-SortedProperties&action=raw&sp_ver=1"
1 wmgWikibaseClientRepoConceptBaseUri:"http:\/\/www.wikidata.beta.wmflabs.org\/entity\/"
1 wmgWikibaseClientRepoConceptBaseUri:"http:\/\/www.wikidata.org\/entity\/"
1 wmgWikibaseClientRepositories:{"":{"repoDatabase":"wikidatawiki","baseUri":"http:\/\/www.wikidata.org\/entity\/","entityNamespaces":{"item":0,"property":120,"lexeme":146},"prefixMapping":{"":""}}}
1 wmgWikibaseClientRepositories:{"":{"repoDatabase":"wikidatawiki","entityNamespaces":{"item":0,"property":120,"lexeme":146},"baseUri":"https:\/\/wikidata.beta.wmflabs.org\/entity\/","prefixMapping":{"":""}},"commons":{"repoDatabase":"commonswiki","entityNamespaces":{"mediainfo":"6\/mediainfo"},"baseUri":"https:\/\/commons.wikimedia.beta.wmflabs.org\/entity\/","prefixMapping":[]}}
1 wmgWikibaseClientRepoUrl:"https:\/\/wikidata.beta.wmflabs.org"
1 wmgWikibaseClientRepoUrl:"https:\/\/www.wikidata.org"
1 wmgWikibaseClientUseTermsTableSearchFields:false
1 wmgWikibaseClientUseTermsTableSearchFields:true
1 wmgWikibaseFeatureFlagWbeditentitySetEmptyAliases:false
1 wmgWikibaseFeatureFlagWbeditentitySetEmptyAliases:true
1 wmgWikibaseRepoBadgeItems:{"Q17437798":"wb-badge-goodarticle","Q17437796":"wb-badge-featuredarticle","Q17559452":"wb-badge-recommendedarticle","Q17506997":"wb-badge-featuredlist","Q17580674":"wb-badge-featuredportal","Q20748091":"wb-badge-notproofread","Q20748094":"wb-badge-problematic","Q20748092":"wb-badge-proofread","Q20748093":"wb-badge-validated","Q28064618":"wb-badge-digitaldocument","Q51759403":"wb-badge-goodlist"}
1 wmgWikibaseRepoBadgeItems:{"Q49444":"wb-badge-goodarticle","Q49447":"wb-badge-featuredarticle","Q49448":"wb-badge-recommendedarticle","Q49449":"wb-badge-featuredlist","Q49450":"wb-badge-featuredportal","Q98649":"wb-badge-notproofread","Q98650":"wb-badge-problematic","Q98658":"wb-badge-proofread","Q98651":"wb-badge-validated"}
1 wmgWikibaseSearchIndexProperties:[]
1 wmgWikibaseSearchIndexPropertiesExclude:[]
1 wmgWikibaseSearchIndexPropertiesExclude:["P304","P433","P478","P558","P3903","P3921","P4316","P1433","P2860"]
1 wmgWikibaseSearchIndexProperties:["P31","P279"]
1 wmgWikibaseSearchStatementBoosts:[]
1 wmgWikibaseSearchStatementBoosts:{"P31=Q4167410":-10,"P31=Q13442814":-5,"P31=Q18918145":-5}
1 wmgWikibaseSSRTermboxServerUrl:"https:\/\/ssr-termbox.wmflabs.org\/termbox"
1 wmgWikibaseUseSSRTermbox:true
Wed, Jun 5, 5:20 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

Beta cluster lexeme-related configs:

wgLexemePrefixRescoreProfile:"lexeme_prefix"
wgLexemeEnableRepo:true
wgLexemeNamespace:146
wgLexemePrefixSearchProfiles:[]
wgWBQualityConstraintsWikibaseSenseId:"Q505135"
wgLexemeRescoreFunctions:[]
wmgUseWikibaseLexemeCirrusSearch:true
wgLexemeEnableSenses:true
wgLexemeLanguageCodePropertyId:"P218"
wmgUseWikibaseLexeme:true
wgLexemeDisableCirrus:true
wgLexemeUseCirrus:true
wgLexemeTalkNamespace:147
wmgNewWikibaseLexemeCirrusSearch:true
wgLexemeFulltextRescoreProfile:"lexeme_fulltext"
wgLexemePrefixSearchProfile:"lexeme_prefix"
wgWBQualityConstraintsWikibaseLexemeId:"Q505133"
Wed, Jun 5, 5:00 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup merged T225120: wbgetentities calls fail for Forms/Senses into T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).
Wed, Jun 5, 4:49 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup merged task T225120: wbgetentities calls fail for Forms/Senses into T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).
Wed, Jun 5, 4:49 PM · Regression, Lexicographical data, Wikidata
Ladsgroup added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

It fails on test wikidata https://www.wikidata.org/w/api.php?action=wbgetentities&format=json&origin=*&ids=L1-S1

Wed, Jun 5, 4:28 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup claimed T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

Oops!... I licked It Again

Wed, Jun 5, 4:16 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup added a comment to T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).

Unbelievably, it works in beta cluster but not in production and my localhost: https://wikidata.beta.wmflabs.org/w/api.php?action=wbgetentities&ids=L53-S1

Wed, Jun 5, 4:15 PM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Ladsgroup updated subscribers of T223303: on production enable bugfix for wbeditentity setting aliases to empty array.

This can't be done at the given time since most SRE people will be at SRE summit and hence no deployment (no SWAT, no train, no service, literally nothing of course except when production is on fire)

Wed, Jun 5, 3:00 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup claimed T224301: Clean up ruby test infrastructure.
Wed, Jun 5, 2:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Browser-Tests, Story, wikidata-tech-focus, Technical-Debt, Lexicographical data, Wikidata
Ladsgroup moved T224593: WikibaseLanguageIndependentLuaBindings::getEntityId should normalize page titles if necessary from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jun 5, 2:10 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
Ladsgroup added a comment to T225092: Missing i18n in FlaggedRevs.
$wgMessagesDirs['FlaggedRevs'] = __DIR__ . '/i18n/flaggedrevs';
$wgMessagesDirs['RevisionReview'] = __DIR__ . '/i18n/revisionreview';
$wgMessagesDirs['Stabilization'] = __DIR__ . '/i18n/stabilization';
$wgMessagesDirs['ReviewedVersions'] = __DIR__ . '/i18n/reviewedversions';
$wgMessagesDirs['UnreviewedPages'] = __DIR__ . '/i18n/unreviewedpages';
$wgMessagesDirs['PendingChanges'] = __DIR__ . '/i18n/pendingchanges';
$wgMessagesDirs['ProblemChanges'] = __DIR__ . '/i18n/problemchanges';
$wgMessagesDirs['ReviewedPages'] = __DIR__ . '/i18n/reviewedpages';
$wgMessagesDirs['StablePages'] = __DIR__ . '/i18n/stablepages';
$wgMessagesDirs['ConfiguredPages'] = __DIR__ . '/i18n/configuredpages';
$wgMessagesDirs['QualityOversight'] = __DIR__ . '/i18n/qualityoversight';
$wgMessagesDirs['ValidationStatistics'] = __DIR__ . '/i18n/validationstatistics';
$wgMessagesDirs['FlaggedRevsApi'] = __DIR__ . '/i18n/api';
$wgExtensionMessagesFiles['FlaggedRevsMagic'] = "$langDir/FlaggedRevs.i18n.magic.php";
$wgExtensionMessagesFiles['FlaggedRevsAliases'] = "$langDir/FlaggedRevs.alias.php";
Wed, Jun 5, 1:57 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-extensions-FlaggedRevs, User-zeljkofilipin, Release-Engineering-Team (Kanban)
Ladsgroup added a comment to T225092: Missing i18n in FlaggedRevs.

@Ladsgroup will this be fixed by train window tomorrow?

Wed, Jun 5, 1:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-extensions-FlaggedRevs, User-zeljkofilipin, Release-Engineering-Team (Kanban)
Ladsgroup triaged T225092: Missing i18n in FlaggedRevs as Unbreak Now! priority.

Definitely a train blocker.

Wed, Jun 5, 1:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-extensions-FlaggedRevs, User-zeljkofilipin, Release-Engineering-Team (Kanban)
Ladsgroup created T225092: Missing i18n in FlaggedRevs.
Wed, Jun 5, 1:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-extensions-FlaggedRevs, User-zeljkofilipin, Release-Engineering-Team (Kanban)
Ladsgroup added a comment to T220733: 1.34.0-wmf.8 deployment blockers.
Wed, Jun 5, 1:35 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Release, Train Deployments
Ladsgroup moved T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jun 5, 12:51 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, User-zeljkofilipin, wikidata-tech-focus, ArticlePlaceholder, Wikimedia-production-error, Wikidata
Ladsgroup moved T224536: Add EntitySchema in the license footer from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jun 5, 12:51 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
Ladsgroup moved T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jun 5, 11:40 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, User-zeljkofilipin, wikidata-tech-focus, ArticlePlaceholder, Wikimedia-production-error, Wikidata
Ladsgroup edited projects for T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
Wed, Jun 5, 11:02 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, User-zeljkofilipin, wikidata-tech-focus, ArticlePlaceholder, Wikimedia-production-error, Wikidata
Ladsgroup moved T224536: Add EntitySchema in the license footer from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Jun 5, 10:35 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
Ladsgroup claimed T224536: Add EntitySchema in the license footer.
Wed, Jun 5, 10:32 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions
Ladsgroup added a member for acl*phabricator: WMDE-leszek.
Wed, Jun 5, 10:16 AM
Ladsgroup placed T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses) up for grabs.

Unlicking the cookie

Wed, Jun 5, 9:58 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
Restricted Application removed a project from T225073: Add baserevid to wblremovesense API module: Patch-For-Review.
Wed, Jun 5, 9:56 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup claimed T207235: PHP error "Undefined index: Q…" from ArticlePlaceholder hook on SpecialSearch.

I will do it ASAP.

Wed, Jun 5, 9:56 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, User-zeljkofilipin, wikidata-tech-focus, ArticlePlaceholder, Wikimedia-production-error, Wikidata
Ladsgroup created T225072: Add baserevid to wblremoveform API module.
Wed, Jun 5, 9:55 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup created T225071: Add baserevid to wbleditsenseelements API module.
Wed, Jun 5, 9:53 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup created T225070: Add baserevid to wbleditformelements API module.
Wed, Jun 5, 9:52 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Ladsgroup added a comment to T225040: Check if filtering is needed in labs for new term store data.

Given that wb_terms is also fully replicated I don't see any reason to change it now. We remove terms from the term store when the page gets deleted/suppressed etc.

Wed, Jun 5, 9:43 AM · Wikidata wb_terms Trailblazing
Ladsgroup added a comment to T220733: 1.34.0-wmf.8 deployment blockers.

Deployment blocker: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514446 this needs to backported to wmf.8 before going to group1

Wed, Jun 5, 9:41 AM · User-zeljkofilipin, Release-Engineering-Team (Kanban), Release, Train Deployments

Tue, Jun 4

Ladsgroup added a comment to T223602: Define variant Wikimedia production config in compiled, static files.

Here's my two cents:

  • I have done a similar thing with ores, in couple of months we made a huge Makefile that contains instructions for extracting and building the models for ores into per-wiki config files that turned into a generated Makefile at the end. I have some lessons learned from that action.
  • We need to have a migration path. There's always lots of edge cases that can't be migrated in one go. Migrating model instructions took us months to finish and it was way simpler than InitialiseSettings.php. The way that we did it was we introduced the generated Makefile as "Makefile.automated" and started to include that empty file into the main one and per-wiki we moved the manual instructions to the new one (we also did an audit of each wiki and we found one error per wiki on average, because automation helped us check for inconsistencies). And after we were almost done, we renamed the Makefile to Makefile.manual and Makefile.automated to Makefile. The Makefile.manual still exists for weird edge cases (like wikidata)
  • A similar course of action can be done here. Before getting things fully moved, we can define "InitialiseSettings-generated.php" and load it before InitialiseSettings.php (so values in InitialiseSettings.php override this one) and then in rather large batches move content and horrors of InitialiseSettings.php to per-wiki config files.
  • The "InitialiseSettings-generated.php" can be generated before each deployment, we can put to .gitignore but the script that generates the file needs to show the diff and asks the user if the changes made make sense.
  • Once everything is moved to InitialiseSettings-generated.php, then we can decide on how to properly do config management in mediawiki in production. The script can get all of those config files and put them somewhere else (even etcd directly) if needed. My idea basically narrows down the focus of this solution and make it very local to add space for breathing for future changes.
  • I'm personally in favor of using pretty json for two reasons: 1- There's no native/built-in support for yaml in python or php. I've been dealing with yaml and it's a big headache even with python. 2- json is sorta standard in mediawiki these days, we have extension.json (and similar things like composer.json), etc. 3- (It's not a real reason): We can add support for comments the way we added support for config variables in extension.json. We can ignore any key value that starts with _ or @ in generating the result. (Which also brings the question of should we output them as comment in the result or we should omit comments).
Tue, Jun 4, 10:31 PM · Release-Engineering-Team (Kanban), Epic, serviceops, Continuous-Integration-Config
Ladsgroup added a comment to T215178: Self-hosted SonarQube.

I think having one or several (HA) VPS nodes is way better than having them in toolforge. We have more control over the node. I might be able to setup something quickly. Is there a help on how to setup a standalone service?

Tue, Jun 4, 8:52 PM · Code-Health-Metrics

Mon, Jun 3

Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

a) It looks like colliding with https://phabricator.wikimedia.org/T113831

Mon, Jun 3, 3:20 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup updated the task description for T155878: Use OOUI icons for FlaggedRevs.
Mon, Jun 3, 10:56 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization
Ladsgroup moved T155878: Use OOUI icons for FlaggedRevs from Not ready to announce to To Triage on the User-notice board.
Mon, Jun 3, 9:43 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-extensions-FlaggedRevs, User-Ladsgroup, User-notice, UI-Standardization
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

Thanks for the comment :)

Mon, Jun 3, 9:31 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

To recap. I suggest these two:

  • Drop official support for Oracle and MSSQL
  • Use Doctorine DBAL to handle SQL generation of schema and schem changes (practically turning .sql files to .json files)
Mon, Jun 3, 1:30 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Ladsgroup added a comment to T218155: Create Wikisource Hindi.

@Ladsgroup Are thre any tickets describing what are the script problems that this task should depend on?

Mon, Jun 3, 1:22 AM · Operations, User-Ladsgroup, Patch-For-Review, User-Urbanecm, Wiki-Setup (Create)

Sat, Jun 1

Ladsgroup added a comment to T205045: Exception from LinksUpdate: Deadlock found in database query (from Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages).

and DBAs to babysit the deployment for a couple of days

I can do that if you tell me anyting specific -metrics- to check for (other than typical error count and general stability. Specially if initial deployment happens at the beginning of next week for example, near EU timezone.

Sat, Jun 1, 5:42 PM · wikidata-tech-focus, User-Addshore, Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Wikidata, Wikimedia-production-error

Fri, May 31

Ladsgroup updated subscribers of T224532: WD within WP watchlists: Allow hiding new language versions of articles.

I agreed to work on it but I would like to keep these tickets unassigned to me in order to avoid "licking the cookie". i.e. if someone beats me to do it, I don't want to block them. I might not be able to get to it any time soon.

Fri, May 31, 11:17 AM · MediaWiki-Watchlist, Growth-Team, Wikidata
Ladsgroup added a comment to T205045: Exception from LinksUpdate: Deadlock found in database query (from Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages).

@jcrespo thank you! That's useful information.

@Ladsgroup @Addshore What's needed to get this ready for pickup in camp?

Fri, May 31, 11:00 AM · wikidata-tech-focus, User-Addshore, Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Wikidata, Wikimedia-production-error
Ladsgroup added a comment to T224383: Tool Forge kills checkdictation-fa.

Reza is @Yamaha5 :)

Fri, May 31, 10:57 AM · Tools, Toolforge

Wed, May 29

Ladsgroup added a comment to T222224: Normalizing *links tables.

One quick update. I worked a little bit on this in the hackathon. A POC is almost ready, I'm trying to finish it soon.
Also, by checking the code, it seems "templatelinks" table is the best option to start for two reasons: 1- the target column is only referenced around 20 times in the code, making the migration at code level easier than other tables (categorylinks is referenced around 80 times) 2- it's the biggest links table. (It's basically lowest and heaviest hanging fruit.)

Wed, May 29, 4:29 PM · Patch-For-Review, MediaWiki-Database, TechCom-RFC
Ladsgroup added a comment to T191231: RFC: Abstract schemas and schema changes.

In the discussion with @daniel and @Anomie it become apparent that it's better to drop support for Oracle and MSSQL before trying to abstract it and moving support to extensions and if someone wants to maintain the support, they should do it in the extension.

Wed, May 29, 10:10 AM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic

Tue, May 28

Ladsgroup created P8570 Uneditable tasks.
Tue, May 28, 10:21 PM
Ladsgroup awarded T219342: Pageview performance timeline analysis (March 2019) a Doubloon token.
Tue, May 28, 8:15 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Performance-Team
Ladsgroup added a project to T170567: Support TLSv1.3: Performance.

Adding Performance because handshakes on TLS 1.3 are 100ms faster and also it caches handshakes (https://kinsta.com/blog/tls-1-3/). Hope that's fine for you.

Tue, May 28, 7:36 PM · Performance, Goal, Patch-For-Review, Traffic, Operations
Ladsgroup closed T224099: Request for conduit token of Phabricator_maintenance user as Resolved.

Okay, now the first batch is ran

Tue, May 28, 4:51 PM · User-Ladsgroup, Phabricator-Bot-Requests, Phabricator
Ladsgroup set Security to sensitive on T204664: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Eduardo Apodaka.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204663: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Ainara Miguel Sáez de Urabain.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204665: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Beatriz Zabalondo.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204670: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Imanol Murua.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204673: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Gorka Moreno.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204674: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Aingeru Genaut.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204675: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Andoni Iturbe.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204676: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Andere Ormazabal.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T211329: EHU - Bizkaiko campusa - Gizarte eta Komunikazio Zientzien fakultatea - Izaro Gorostidi.
Tue, May 28, 4:01 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204261: EHU - Gipuzkoako campusa - HEFA - Haur eta Gazte Literatura 2018/19.
Tue, May 28, 4:00 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204540: EHU - Arabako Campusa - Letren Fakultatea - Artearen Historiako Gradua.
Tue, May 28, 4:00 PM · Wikimedia-User-Group-Basque
Ladsgroup set Security to sensitive on T204546: EHU - Arabako Campusa - Letren Fakultatea - Artearen Historiako Gradua - Mikel Onandia.
Tue, May 28, 4:00 PM · Wikimedia-User-Group-Basque