Page MenuHomePhabricator

Legoktm (Legoktm)
UserAdministrator

Today

  • No visible events.

Tomorrow

  • No visible events.

Friday

  • No visible events.

User Details

User Since
Sep 19 2014, 7:30 PM (608 w, 4 d)
Roles
Administrator
Availability
Available
IRC Nick
legoktm
LDAP User
Legoktm
MediaWiki User
Unknown

Recent Activity

Tue, May 5

Legoktm claimed T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities.

Yep; PHP is now GPL-compatible so it's totally fine to distribute built binaries under the GPL. I'll put up a patch updating the repo shortly.

Tue, May 5, 5:00 PM · WMDE-TechWish-Maintenance, Software-Licensing, wikidiff2

Apr 12 2026

Legoktm added a watcher for Tool-prosesize: Legoktm.
Apr 12 2026, 3:28 AM

Apr 8 2026

Legoktm closed T383948: Echo notification expiration should be time-based, not hardcoded 2000 as Resolved.

Closing, this was deployed and there was no appetite (or maybe it would be fairer to say there was resistance) to delay it. Echo Chamber should be functional again for those who wish to use it.

Apr 8 2026, 4:00 PM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.20; 2026-03-17), Growth-Team, Notifications (Echo)
Legoktm closed T422318: Echo Chamber API error: You don't have permission as Resolved.

Thanks @bd808 for approving, the tool should be usable again.

Apr 8 2026, 3:53 PM · Tool-echo-chamber
Legoktm added a comment to T420154: CVE-2026-5266: Notifications (Echo) API can be used by any OAuth tool.

What is the visible consequence for users, before and after the merge?

Apr 8 2026, 1:52 AM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MW-1.45-release, MW-1.44-release, MW-1.43-release, Growth-Team (FY2025-26 Q3 Sprint 6), MediaWiki-Platform-Team (Radar), SecTeam-Processed, Notifications (Echo), Security, Security-Team
Legoktm claimed T422318: Echo Chamber API error: You don't have permission.

The new OAuth consumer is pending approval: https://meta.wikimedia.org/wiki/Special:OAuthListConsumers/view/56797921b0a88d17f8ea5d338f04b11d

Apr 8 2026, 12:58 AM · Tool-echo-chamber

Apr 2 2026

Legoktm added a comment to T420154: CVE-2026-5266: Notifications (Echo) API can be used by any OAuth tool.

I don't think it needs a tech news announcement personally, mediawiki-api-announce would be more appropriate.

Apr 2 2026, 2:37 PM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MW-1.45-release, MW-1.44-release, MW-1.43-release, Growth-Team (FY2025-26 Q3 Sprint 6), MediaWiki-Platform-Team (Radar), SecTeam-Processed, Notifications (Echo), Security, Security-Team

Mar 17 2026

Legoktm added a comment to T383948: Echo notification expiration should be time-based, not hardcoded 2000.

Sorry, I didn't realize that the plan was to roll it out this week. I personally don't care very strongly about this (when I worked on Notifications like a decade ago it seemed pretty clear that they were ephemeral!), I mostly created the tool because MatmaRex asked for it in T383948#11625527 and it seemed fun. Not sure if he qualifies for Amir's request for "one user on any wiki" :-)

Mar 17 2026, 2:45 PM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.20; 2026-03-17), Growth-Team, Notifications (Echo)
Legoktm added a comment to T383948: Echo notification expiration should be time-based, not hardcoded 2000.

https://meta.wikimedia.org/w/index.php?title=Tech/News/2026/13&diff=prev&oldid=30270406

Mar 17 2026, 3:36 AM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.20; 2026-03-17), Growth-Team, Notifications (Echo)

Mar 15 2026

Legoktm added a project to T420154: CVE-2026-5266: Notifications (Echo) API can be used by any OAuth tool: Notifications (Echo).
Mar 15 2026, 9:01 PM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MW-1.45-release, MW-1.44-release, MW-1.43-release, Growth-Team (FY2025-26 Q3 Sprint 6), MediaWiki-Platform-Team (Radar), SecTeam-Processed, Notifications (Echo), Security, Security-Team
Legoktm created T420154: CVE-2026-5266: Notifications (Echo) API can be used by any OAuth tool.
Mar 15 2026, 9:00 PM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MW-1.45-release, MW-1.44-release, MW-1.43-release, Growth-Team (FY2025-26 Q3 Sprint 6), MediaWiki-Platform-Team (Radar), SecTeam-Processed, Notifications (Echo), Security, Security-Team
Legoktm added a comment to T420151: Link to 'source code' on echo-chamber.toolforge.org doesn't work.

Heh, thanks for trying the tool so quickly :) Apparently a middle click went awry.

Mar 15 2026, 8:52 PM · Tool-echo-chamber
Legoktm added a comment to T383948: Echo notification expiration should be time-based, not hardcoded 2000.

Also, I wish we could document a way to export your notifications before they're gone. I think the action=query&meta=notifications API would be an acceptable way to do this, were it not for the fact that it is limited to 50 notifications – could we temporarily increase this limit to 2000? (perhaps with a rate limit to avoid issues) [I can write the patch for this]

I think it would be more useful to have a JavaScript snippet, possibly hosted as a Toolforge tool, which handles the continuation to fetch all notifications instead of temporarily raising the limit.

Mar 15 2026, 7:53 PM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.20; 2026-03-17), Growth-Team, Notifications (Echo)
Legoktm added a watcher for Tool-echo-chamber: Legoktm.
Mar 15 2026, 7:17 PM

Mar 3 2026

Legoktm added a comment to T383948: Echo notification expiration should be time-based, not hardcoded 2000.

Also, I wish we could document a way to export your notifications before they're gone. I think the action=query&meta=notifications API would be an acceptable way to do this, were it not for the fact that it is limited to 50 notifications – could we temporarily increase this limit to 2000? (perhaps with a rate limit to avoid issues) [I can write the patch for this]

Mar 3 2026, 2:21 AM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.20; 2026-03-17), Growth-Team, Notifications (Echo)

Mar 2 2026

Legoktm renamed T325503: fast-ec should cache username -> actor_id, user opt-in status from fast-ec should cache username -> actor_id, user opt-in status, and domain -> dbname to fast-ec should cache username -> actor_id, user opt-in status.
Mar 2 2026, 5:06 AM · tool-fast-ec
Legoktm closed T325511: fast-ec should use a connection pool as Resolved.

Fixed in https://gitlab.wikimedia.org/toolforge-repos/fast-ec/-/commit/6d825f760b96f9c6004d976aaf2e660d95561639.

Mar 2 2026, 5:02 AM · tool-fast-ec

Feb 28 2026

Legoktm created T418673: {{#parsoid included in output when using Parsoid read views.
Feb 28 2026, 6:10 PM · Parsoid

Feb 25 2026

Legoktm added a comment to T416536: hywiki: some doi links in refs render with https with legacy parser and http with Parsoid.

My main intent behind SecureLinkFixer was to avoid having bots constantly needing to edit basically every single page a bunch of times as websites gradually added support for HTTPS. So that's how I approach it, as much as reasonably possible it should be as if the actual wikitext URL was HTTPS. In practice the Linker hook already existed so that's what I used and ideally we'd be able to preserve that behavior (I'm a little out of date and don't know what OutputTransform applies to or doesn't apply to). I would expect that e.g. my bot that fetches Parsoid HTML would see URLs already modified to HTTPS.

Feb 25 2026, 11:54 PM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MediaWiki-extensions-SecureLinkFixer, Content-Transform-Team (Work In Progress)
Restricted Application added a project to T303495: Merge WebAuthn extension into OATHAuth: Product Safety and Integrity.
Feb 25 2026, 12:04 AM · Product Safety and Integrity, FY2025-26 WE 4.6 - Account Security (WE 4.6.9 (Passwordless login and passkey promotion)), MW-1.46-notes (1.46.0-wmf.14; 2026-02-03), translatewiki.net, Technical-Debt, MediaWiki-extensions-OATHAuth
Legoktm added a comment to T418288: Bots on Commons do not have bot flag in database.

@Legoktm You mean this would have to be solved by Commons admins? Or by who? And that was just an example, lots and lots of bot accounts do not have that flag. It does look like a technical issue. How to solve this?

Feb 25 2026, 12:00 AM

Feb 24 2026

Legoktm closed T418288: Bots on Commons do not have bot flag in database as Invalid.

This is an on-wiki issue, that account isn't flagged as a bot: https://commons.wikimedia.org/wiki/Special:UserRights/File_Upload_Bot_(Magnus_Manske)

Feb 24 2026, 6:42 PM
Legoktm added a comment to T253764: Undeploy the InterwikiSorting extension from Wikipedia production.

This feels like a dissatisfying ending to a feature that's been on Wikipedias in one form or another since 2004. I was surprised to see it gone so quickly but also I forgot that I turned off compact links years ago, so maybe sorting is irrelevant to most users. I get the tech debt rationale broadly, but T253764#11632202 doesn't feel convincing because it's just static data that seems like it should be straightforward to have auto-generated instead of manually maintained (then again, no one did that for 20+ years so...).

Feb 24 2026, 4:08 AM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.16; 2026-02-17), Patch-For-Review, Release-Engineering-Team (Doing), Technical-Debt, MediaWiki-extensions-InterwikiSorting

Feb 20 2026

Legoktm closed T412361: logo-test.toolforge.org is down as Resolved.

It's back up now, sorry about that.

Feb 20 2026, 5:02 AM · Tool-logo-test
Legoktm added a comment to T417839: Editing using OAuth 2 doesn’t work.

Was any integration or regression test added for this?

Feb 20 2026, 2:42 AM · MW-1.46-notes (1.46.0-wmf.16; 2026-02-17), SRE, MediaWiki-Platform-Team, MediaWiki-extensions-OAuth
Legoktm added a comment to T415233: Parsoid blindly uses srcTagName even if node name has changed.

It's fixed :) https://en.wikipedia.org/w/index.php?title=Wikipedia:Articles_for_deletion/Purananoorru&diff=prev&oldid=1338973451

Feb 20 2026, 12:40 AM · Essential-Work, Content-Transform-Team (Work In Progress), Parsoid

Feb 19 2026

Legoktm added a comment to T415477: Can't resolve duplicate-ids issues by editing Parsoid HTML.

One question regarding editing, if I want to change the ID on the duplicate element, should I modify data-x-id or id (which is Parsoid generated)? And if it's the latter, should I delete data-x-id?

Feb 19 2026, 3:48 PM · Content-Transform-Team (Work In Progress), MediaWiki-extensions-Linter, Parsoid

Feb 17 2026

Legoktm closed T350997: mwbot-rs: Implement better support for OAuth webapps as Resolved.

There's now https://gitlab.wikimedia.org/repos/mwbot-rs/rocket_mwoauth. It's being used in the masto-collab tool.

Feb 17 2026, 2:57 AM · mwbot-rs

Feb 13 2026

Legoktm created T417363: Special:LintTemplateErrors with no category selected should display an index.
Feb 13 2026, 4:30 AM · MW-1.46-notes (1.46.0-wmf.19; 2026-03-10), MediaWiki-extensions-Linter

Feb 11 2026

Legoktm added a comment to T413375: Create new {{#isbn}} parser function.

You could just edit properly and not use VisualEditor.

Feb 11 2026, 3:53 AM · User-notice, MediaWiki-Parser

Feb 10 2026

Legoktm added a comment to T413375: Create new {{#isbn}} parser function.

I guess T148274: Implement a convenient way to link to ISBNs without magic links should be duped into this issue now?

Feb 10 2026, 12:49 AM · User-notice, MediaWiki-Parser

Feb 5 2026

Legoktm closed T416416: SQL metadata files problem as Invalid.

Based on https://en.wikipedia.org/wiki/Wikipedia:Bots/Noticeboard#c-The_Anome-20260204155000-Legoktm-20260204003800 this seems like it was a misunderstanding on what was going away.

Feb 5 2026, 10:09 PM · Data-Engineering (Q3 FY25/26 January 1st - March 31th), Dumps-Generation
Legoktm added a project to T416536: hywiki: some doi links in refs render with https with legacy parser and http with Parsoid: MediaWiki-extensions-SecureLinkFixer.
Feb 5 2026, 9:18 PM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MediaWiki-extensions-SecureLinkFixer, Content-Transform-Team (Work In Progress)
Legoktm added a comment to T416536: hywiki: some doi links in refs render with https with legacy parser and http with Parsoid.

I don't have a strong opinion on how this is implemented (really I haven't thought about it), I do want to flag one potential area for improvement though. The signature for the hook is:

public static function onLinkerMakeExternalLink( &$url, &$text, &$link, &$attribs, $linktype ) { ... }
Feb 5 2026, 9:17 PM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MediaWiki-extensions-SecureLinkFixer, Content-Transform-Team (Work In Progress)

Feb 4 2026

Legoktm added a comment to T412630: Audit heavy linter categories to see if we really need them.

Personally, I have been running my bot on bnwikibooks to just add color declarations wherever Linter complains about them being missing,

Feb 4 2026, 12:25 AM · MediaWiki-extensions-Linter
Legoktm added a comment to T412630: Audit heavy linter categories to see if we really need them.

The template is perfectly readable in both dark mode and light mode, despite the lack of an explicit color declaration alongside the bgcolor declaration. Furthermore, when I inspect the problem element, I see that color:black is indeed being assigned to it, inherited from the .infobox parent element. So the element that is tagged as missing a color actually does have one, and it's working fine.

Feb 4 2026, 12:19 AM · MediaWiki-extensions-Linter

Jan 26 2026

Legoktm placed T371073: wikitext/to/lint API is returning an empty array for night-mode-unaware-background-color lint errors up for grabs.
Jan 26 2026, 11:00 PM · Essential-Work, MediaWiki-extensions-Linter, Parsoid
Legoktm added a comment to T412630: Audit heavy linter categories to see if we really need them.

Edited the description to use the category names instead of the numerical IDs.

Jan 26 2026, 6:15 AM · MediaWiki-extensions-Linter
Legoktm updated the task description for T412630: Audit heavy linter categories to see if we really need them.
Jan 26 2026, 6:05 AM · MediaWiki-extensions-Linter
Legoktm created T415477: Can't resolve duplicate-ids issues by editing Parsoid HTML.
Jan 26 2026, 2:50 AM · Content-Transform-Team (Work In Progress), MediaWiki-extensions-Linter, Parsoid

Jan 25 2026

Legoktm added a comment to T413944: sr:Модул:No globals/док has the wrong content model.

Trying to edit https://te.wikipedia.org/wiki/%E0%B0%AE%E0%B1%82%E0%B0%B8:Message_box gives "Scribunto module" content is not allowed on page మూస:Message box in slot "Main" which feels related but might be a distinct issue?

Jan 25 2026, 8:07 PM · Scribunto, MediaWiki-ContentHandler

Jan 22 2026

Legoktm created T415233: Parsoid blindly uses srcTagName even if node name has changed.
Jan 22 2026, 4:28 AM · Essential-Work, Content-Transform-Team (Work In Progress), Parsoid

Jan 21 2026

Legoktm added a comment to T413944: sr:Модул:No globals/док has the wrong content model.

I wonder why page_content_model was wrongly set though. Is this the same issue as T108663#1741046? :/ If so, might be worth resurrecting a modified version of https://phabricator.wikimedia.org/source/mediawiki/browse/REL1_43/maintenance/fixDefaultJsonContentPages.php;848a9f279f42ed0edb0c83bde65254585bc829cb but for Scribunto.

Jan 21 2026, 4:18 AM · Scribunto, MediaWiki-ContentHandler

Jan 7 2026

Legoktm created T413944: sr:Модул:No globals/док has the wrong content model.
Jan 7 2026, 4:38 AM · Scribunto, MediaWiki-ContentHandler

Jan 5 2026

Legoktm closed T319104: mwbot-rs: Support operation on multiple wikis as Resolved.

This is basically implemented now, I think there are still some rough edges, like the save page message not indicating what wiki the page was saved on, but I've been using it for the past few hours and it's pretty functional. Thanks to @XtexChooser for doing the first part in mwapi last year :)

Jan 5 2026, 7:08 AM · Patch-For-Review, mwbot-rs (mwbot)

Dec 30 2025

Legoktm created T413591: Signatures should not be allowed to contain an id attribute.
Dec 30 2025, 3:59 AM · MediaWiki-extensions-Linter

Dec 27 2025

Legoktm closed T382975: RecordLintJob should be enqueued lazily as Resolved.

Please re-open if that wasn't sufficient.

Dec 27 2025, 5:52 AM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), Performance Issue, MediaWiki-extensions-Linter

Dec 24 2025

Legoktm added a comment to T319097: mwbot-rs: Split up node.rs.

P.S. I added you to https://www.mediawiki.org/w/index.php?title=Mwbot-rs&diff=8101926&oldid=7828836, please feel free to update it if you'd like to be credited differently. I couldn't find a wiki account under your username so I linked to gitlab.

Dec 24 2025, 10:52 PM · good first task, mwbot-rs (parsoid)
Legoktm closed T319097: mwbot-rs: Split up node.rs as Resolved.

Sorry, I had missed your initial ping. Thanks for the patch, it's great!!

Dec 24 2025, 10:49 PM · good first task, mwbot-rs (parsoid)

Dec 21 2025

Legoktm added a comment to T398874: Potentially move mwseaql to the monorepo.

@GalStar no objection to moving it in the monorepo, I had kept it separate since it didn't have any intra-project dependencies whereas most of the monorepo depends on each other.

Dec 21 2025, 2:11 AM · mwbot-rs (mwseaql)

May 28 2025

Legoktm added a comment to T395387: "We are having a problem billing the wikimedia organization" on GitHub.

Thanks all!

May 28 2025, 9:48 PM · Release-Engineering-Team, Wikimedia-GitHub

May 27 2025

Legoktm created T395387: "We are having a problem billing the wikimedia organization" on GitHub.
May 27 2025, 10:49 PM · Release-Engineering-Team, Wikimedia-GitHub

Apr 29 2025

Legoktm added a comment to T392834: mwmaint1002 is out of disk space.
elukey@mwmaint1002:/home$ sudo du -hs /home/* | sort -h | tail
...
11G	/home/legoktm

The home dirs may be a quick one for a cleanup, we have a total of 62G used there, but there are few big ones.

@Legoktm

Apr 29 2025, 1:03 AM · serviceops-radar, SRE

Apr 18 2025

Legoktm added a comment to T382424: Scribunto fails with confusing error message for invalid #interlanguagelink langcode.

It's not limited to this particular parser function and the problem did exist before its introduction.

It seems the same reponse format from the parser is used for 'invalid input' and 'function not found' cases, and so Scribunto has no way of differentiating these.

Apr 18 2025, 7:34 PM · MediaWiki-Interwiki, MediaWiki-Parser, Scribunto
Legoktm added a project to T392279: CVE-2025-53502: HTML injection in FeaturedFeeds output from i18n message: MediaWiki-extensions-FeaturedFeeds.
Apr 18 2025, 3:38 AM · SecTeam-Processed, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Vuln-XSS, MediaWiki-extensions-FeaturedFeeds, Security, Security-Team
Legoktm created T392279: CVE-2025-53502: HTML injection in FeaturedFeeds output from i18n message.
Apr 18 2025, 3:38 AM · SecTeam-Processed, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Vuln-XSS, MediaWiki-extensions-FeaturedFeeds, Security, Security-Team
Legoktm added a project to T392276: CVE-2025-6591: HTML injection in API action=feedcontributions output from i18n message: Patch-For-Review.

Apr 18 2025, 2:34 AM · MW-Interfaces-Team, MW-1.44-release, MW-1.43-release, MW-1.42-release, MW-1.39-release, Vuln-XSS, MediaWiki-Action-API, Security, Security-Team
Legoktm added a project to T392276: CVE-2025-6591: HTML injection in API action=feedcontributions output from i18n message: MediaWiki-Action-API.
Apr 18 2025, 2:30 AM · MW-Interfaces-Team, MW-1.44-release, MW-1.43-release, MW-1.42-release, MW-1.39-release, Vuln-XSS, MediaWiki-Action-API, Security, Security-Team
Legoktm created T392276: CVE-2025-6591: HTML injection in API action=feedcontributions output from i18n message.
Apr 18 2025, 2:29 AM · MW-Interfaces-Team, MW-1.44-release, MW-1.43-release, MW-1.42-release, MW-1.39-release, Vuln-XSS, MediaWiki-Action-API, Security, Security-Team

Apr 17 2025

Legoktm added a comment to T178146: Add support for a newer Lua version than Lua 5.1 to luasandbox.

I've started https://www.mediawiki.org/wiki/Extension:Scribunto/New_Lua_version. Please add other new Lua features that would be useful there (I've already copied @Od1n's comment above).

Apr 17 2025, 12:55 AM · LuaSandbox, Scribunto

Apr 15 2025

Legoktm added a comment to T178146: Add support for a newer Lua version than Lua 5.1 to luasandbox.

@tstarling Got any updated opinions about this in 2025?

Apr 15 2025, 6:04 PM · LuaSandbox, Scribunto

Apr 5 2025

Legoktm closed T386650: Tag a new release of poolcounter service as Resolved.

I pushed a 1.2.0 tag. On the production side, there's nothing worth upgrading for.

Apr 5 2025, 11:42 PM · Release, MediaWiki-Debian, MediaWiki-Platform-Team, PoolCounter

Apr 2 2025

Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

Report for what incident? The missing ETags? The handling of the redirect parameter? Both were regrettable bugs, but not substantial operational issues or problems with broad impact on users.

Apr 2 2025, 5:49 AM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting
Legoktm added a comment to T389885: Display WMF cluster permissions granted to a Developer account.

Also, is "puppet groups" a good label for this? Is there a better term?

Apr 2 2025, 5:27 AM · Tool-ldap
Legoktm claimed T389885: Display WMF cluster permissions granted to a Developer account.

Let's do it. Here's what I rigged up locally (will push to GitLab in a bit).

Apr 2 2025, 5:26 AM · Tool-ldap
Legoktm added a comment to T389030: mwapi: allow changing api_url after construction.

See T319104: mwbot-rs: Support operation on multiple wikis. I had always imagined that mwbot would have the logic to support multi-wiki operation and mwapi would continue to stay single-wiki for simplicity. I'm not really fixed on that concept and would love to see some progress on this, so feel free to give it a shot.

Apr 2 2025, 2:39 AM · mwbot-rs (mwapi)

Feb 8 2025

Legoktm added a comment to T385156: Patch Demo can publicly reveal User-Agents via the CheckUser extension.

Also IANAL the privacy policy seems ambiguous here to me.

Feb 8 2025, 5:53 AM · Catalyst (kokosila), Privacy Engineering, SecTeam-Processed, Vuln-Infoleak, Security, Security-Team

Jan 31 2025

Legoktm added a comment to T357603: REST API: ETag missing from some responses from page HTML endpoint.

To expand on that, if we think it's older cached content, shouldn't there be a corresponding change that has fixed it for new entries? And given there's a max time limit on varnish content, said change would've needed to be deployed within that time window.

Jan 31 2025, 4:34 PM · MW-1.44-notes (1.44.0-wmf.16; 2025-02-11), MW-Interfaces-Team (MWI-Sprint-2 (2025-01-28 to 2025-02-11)), MediaWiki-REST-API
Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

@HCoplin-WMF is there a reason no incident report was ever written for this? (If it was, I couldn't find it when searching https://wikitech.wikimedia.org/wiki/Incident_status)

Jan 31 2025, 5:20 AM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting
Legoktm added a comment to T357603: REST API: ETag missing from some responses from page HTML endpoint.

I 'll take a closer look tomorrow but this is indeed possibly older cached content. See for example

Jan 31 2025, 5:19 AM · MW-1.44-notes (1.44.0-wmf.16; 2025-02-11), MW-Interfaces-Team (MWI-Sprint-2 (2025-01-28 to 2025-02-11)), MediaWiki-REST-API

Jan 26 2025

Legoktm added a comment to T384216: Reroute RESTBase /page/lint/ endpoints to MediaWiki REST endpoints.

The endpoints don't seem to always be equivalent. For example, a POST request to https://en.wikipedia.org/api/rest_v1/transform/wikitext/to/lint/User%20talk:Loganwasgood returns:

[{"type":"night-mode-unaware-background-color","dsr":[59,7185,47,2],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[241,2032,95,2],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[339,2029,213,6],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[2033,7182,47,2],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[2081,4771,111,0],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[2193,4771,83,2],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[4772,7179,114,0],"templateInfo":null,"params":[]},{"type":"night-mode-unaware-background-color","dsr":[4887,7179,83,2],"templateInfo":null,"params":[]}]
Jan 26 2025, 6:45 PM · MW-Interfaces-Team (MWI-Sprint-23 (2025-11-18 to 2025-12-02)), MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), serviceops-deprecated, DiscussionTools, Patch-For-Review, MediaWiki-REST-API, RESTBase Sunsetting
Legoktm merged T361694: Search box suggestions get only English description for Module namespace into T299279: Pages with Scribunto content model get English content language and short description.
Jan 26 2025, 3:23 AM · Wikidata, MediaWiki-extensions-Wikibase-Client, Scribunto
Legoktm merged task T361694: Search box suggestions get only English description for Module namespace into T299279: Pages with Scribunto content model get English content language and short description.
Jan 26 2025, 3:23 AM · Scribunto, MediaWiki-User-Interface (autocomplete search)
Legoktm claimed T356771: Allow canonical namespace names for module namespace redirects.
Jan 26 2025, 3:19 AM · Patch-For-Review, Scribunto, MediaWiki-Redirects
Legoktm created T384788: Toolforge webservice still accepts --canonical but complains about it in service.template.
Jan 26 2025, 2:58 AM · cloud-services-team, Toolforge
Legoktm claimed T319109: mwbot-rs: Option to error on new messages.
Jan 26 2025, 2:19 AM · Patch-For-Review, mwbot-rs (mwbot)
Legoktm closed T349520: Cannot pass Template as params to Template as Declined.

Closing as declined since I don't think we can support this until Parsoid supports editing parameters as HTML instead of wikitext. (Please re-open if I'm mistaken)

Jan 26 2025, 1:09 AM · mwbot-rs (parsoid)
Legoktm closed T354035: Switch mwbot-rs to use rest.php v1 instead of restbase as Resolved.

This is done in parsoid 0.10.0-rc.4; aiming to do a stable release soon. I was peeking at the git log and it was a team effort by myself, xtex, mirror-kt and CountCount :)

Jan 26 2025, 1:05 AM · mwbot-rs (parsoid)
Legoktm added a comment to T295648: Provide API that exposes DiscussionTools data structure.

(The code doing that can do it to Parsoid HTML too, and it will need to be introduced when we start trying to use Parsoid HTML for page views, but we didn't need it so far, so it's not there.)

Jan 26 2025, 12:59 AM · DiscussionTools
Legoktm closed T384568: Masto-Collab: Logging in results in 500 - etag is missing as Resolved.

@Peachey88 should be fixed now, I've worked around the MW bug.

Jan 26 2025, 12:49 AM · Tool-masto-collab

Jan 25 2025

Legoktm added a comment to T384568: Masto-Collab: Logging in results in 500 - etag is missing.

See T374683#10495069.

Jan 25 2025, 10:57 PM · Tool-masto-collab
Legoktm added a subtask for T384568: Masto-Collab: Logging in results in 500 - etag is missing: T357603: REST API: ETag missing from some responses from page HTML endpoint.
Jan 25 2025, 10:57 PM · Tool-masto-collab
Legoktm added a parent task for T357603: REST API: ETag missing from some responses from page HTML endpoint: T384568: Masto-Collab: Logging in results in 500 - etag is missing.
Jan 25 2025, 10:57 PM · MW-1.44-notes (1.44.0-wmf.16; 2025-02-11), MW-Interfaces-Team (MWI-Sprint-2 (2025-01-28 to 2025-02-11)), MediaWiki-REST-API
Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

For better or worse, all the requests I've tried on test.wikipedia.org are returning etags 🙃

Jan 25 2025, 10:55 PM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting
Legoktm added a comment to T357603: REST API: ETag missing from some responses from page HTML endpoint.

This has become a much bigger issue because RESTbase is now redirecting to the REST API.

Jan 25 2025, 10:52 PM · MW-1.44-notes (1.44.0-wmf.16; 2025-02-11), MW-Interfaces-Team (MWI-Sprint-2 (2025-01-28 to 2025-02-11)), MediaWiki-REST-API
Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

I found T357603: REST API: ETag missing from some responses from page HTML endpoint which seems to be the cause. In the prior example, when I remove ?redirect=false, an etag shows up:

$ curl -I 'https://en.wikipedia.org/w/rest.php/v1/page/Wikipedia%3ARequests_for_adminship%2Ftheleekycauldron_2/html'| grep etag
etag: W/"1170967427/fbb0a9e1-da83-11ef-9f0b-99a171ff8019/view/html"
Jan 25 2025, 10:42 PM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting
Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

I didn't see a linked patch for the etag stuff but I assume someone checked/addressed it? I can't reproduce the failure on test.wikipedia.org.

The page/html endpoint returns an etag. There's no patch because that didn't change - as far as I can tell, it has been returning etags for a long time. What failure were you trying to reproduce?

Jan 25 2025, 10:35 PM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting

Jan 15 2025

Legoktm closed T382728: GitHub: "the given path has multiple possibilities" whilst trying to download REL1_43.tar.gz as Resolved.
Jan 15 2025, 3:06 AM · MediaWiki-Releasing, Wikimedia-GitHub
Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

@Legoktm -- do you have any final concerns? If not, I think we should be good to go :)

Jan 15 2025, 3:03 AM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting
Legoktm added a comment to T354037: rest.php/v1/transform/html/to/wikitext with if-match fails with "No stashed content found for" and HTTP 412.

@Legoktm There may be no need for stashing or etags at all if you use the output of https://en.wikipedia.org/w/rest.php/v1/page/Earth/html?flavor=edit. flavor=edit makes it embed all the parsoid annotations in the HTML, which should allow the transform endpoint to turn HTML back into wikitext without the need for stashed state.

Jan 15 2025, 2:45 AM · Content-Transform-Team, MW-Interfaces-Team, RESTBase Sunsetting, MediaWiki-REST-API
Legoktm added a comment to T380015: Content API (proposal): Allow bots to opt for a lower stash ttl in exchange for a more permissive rate limit.

How do we move forward here @daniel?

Jan 15 2025, 2:44 AM · RESTBase Sunsetting, Content-Transform-Team, MediaWiki-REST-API, MW-Interfaces-Team
Legoktm added a comment to T382086: MediaWiki ships a copy of swagger-ui with license problems.

There are both security and legal issues here.

Jan 15 2025, 1:16 AM · MW-Interfaces-Team (MWI-Sprint-7 (2025-04-08 to 2025-04-22)), MW-1.44-release, SecTeam-Processed, Security-Team, WMF-Legal, Upstream, MW-1.43-release, MediaWiki-Debian, Software-Licensing, MediaWiki-REST-API
Legoktm added a comment to T383533: peerjs in VisualEditor has no unminified source.

Thanks @Legoktm! Hmm, this is technically tricky because the source is in typescript, which would require a whole extra compilation system in our build process. But I think we are ok because:

  1. PeerJS is MIT licensed
  2. VisualEditor is MIT licensed
Jan 15 2025, 12:45 AM · MW-1.43-release, MediaWiki-Debian, VisualEditor

Jan 13 2025

Legoktm created T383533: peerjs in VisualEditor has no unminified source.
Jan 13 2025, 5:44 AM · MW-1.43-release, MediaWiki-Debian, VisualEditor

Jan 5 2025

Legoktm created T383004: Parsoid read views: map with extension (cite, templatestyles) in caption results in raw UNIQ QINU marker.
Jan 5 2025, 6:42 AM · Parsoid-Read-Views (Large Wikipedias), OKR-Work, Content-Transform-Team (Work In Progress)

Dec 18 2024

Legoktm added a comment to T382044: Use static arrays for ExtensionRegistry::loadFromQueue caching.

Time is a flat circle, back to loading extension information from PHP it seems :) This was proposed as part of the original RfC even:

Reading and parsing a JSON file will be slower than loading a PHP file due to APC and other factors. However, we can mitigate that by providing a script to "compile" all the required JSON files into their PHP equivalents.

Dec 18 2024, 7:00 AM · MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Performance Issue, MediaWiki-Configuration

Nov 10 2024

Legoktm closed T378908: Simple upload doesn't upload as Resolved.

I released mwapi 0.6.1 by backporting just this fix. Thanks for reporting!

Nov 10 2024, 11:30 PM · affects-Miraheze, mwbot-rs (mwapi)
Legoktm claimed T378908: Simple upload doesn't upload.

For some reason multipart::Part::stream wasn't working, when I switch it to:

Nov 10 2024, 10:09 PM · affects-Miraheze, mwbot-rs (mwapi)

Nov 8 2024

Legoktm added a comment to T378908: Simple upload doesn't upload.

I spent a few minutes looking at this today, I started by getting:

Nov 8 2024, 11:35 PM · affects-Miraheze, mwbot-rs (mwapi)

Nov 6 2024

Legoktm added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

The responses were also not returning an etag header, as previously expected.

That shouldn't have been the case... you are seeing the etags now, right?

Nov 6 2024, 10:34 PM · User-notice-archive, MW-Interfaces-Team (MWI-Sprint-1 (2025-01-14 to 2025-01-28)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), serviceops-deprecated, RESTBase Sunsetting