Page MenuHomePhabricator

maryyang (Mary Yang)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2022, 9:51 PM (41 w, 4 d)
Availability
Available
LDAP User
Mary Yang
MediaWiki User
Unknown

Recent Activity

Sep 30 2022

maryyang committed rMSFS81cb108519b4: Add ZObject.js as a base class for other ZObject js classes. (authored by maryyang).
Add ZObject.js as a base class for other ZObject js classes.
Sep 30 2022, 1:25 AM

Sep 17 2022

maryyang committed rMSFO51addca292f9: Add initial benchmark suite for orchestate with mocks. (authored by maryyang).
Add initial benchmark suite for orchestate with mocks.
Sep 17 2022, 3:52 AM

Sep 16 2022

maryyang committed rMSFO87dbf5a63a36: Propagate the no-async validator changes to orchestrator. (authored by maryyang).
Propagate the no-async validator changes to orchestrator.
Sep 16 2022, 3:53 PM

Sep 9 2022

maryyang committed rMSFO0153297800c3: Create wrapper for logger to accomodate for different types of API. (authored by maryyang).
Create wrapper for logger to accomodate for different types of API.
Sep 9 2022, 6:40 AM

Sep 8 2022

maryyang committed rMSFS6bdb7c022206: A first example of creating JS classes for ZObjects. (authored by maryyang).
A first example of creating JS classes for ZObjects.
Sep 8 2022, 10:42 PM
maryyang committed rMSFSeda2afd5a289: Remove mutex locks and async references in function schemata. (authored by maryyang).
Remove mutex locks and async references in function schemata.
Sep 8 2022, 8:41 PM

Aug 17 2022

maryyang updated subscribers of T315477: Create benchmark suite for function-* services.

HI @cmassaro, we are thinking of having a benchmarking tool to monitor performance stats. Roughly speaking, do you know any key parts of the function-* services that could use monitoring?

Aug 17 2022, 7:05 PM · Patch-For-Review, Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship
maryyang created T315477: Create benchmark suite for function-* services.
Aug 17 2022, 7:02 PM · Patch-For-Review, Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship
maryyang closed T311457: Set up health checks for function-* services on Beta Cluster, a subtask of T261469: Launch demonstration system, as Resolved.
Aug 17 2022, 6:46 PM · Epic, Abstract Wikipedia team
maryyang closed T311457: Set up health checks for function-* services on Beta Cluster as Resolved.
Aug 17 2022, 6:46 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review, 2022 Wikimedia Google.org Fellowship, Abstract Wikipedia team (Phase θ – Throttling)
maryyang claimed T290700: Use a Proper Logging Module in Orchestrator.
Aug 17 2022, 5:56 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase θ – Throttling), function-orchestrator

Aug 15 2022

maryyang claimed T310728: Emit a log from the orchestrator and evaluator on request result.

Sure. I'll see where this fits in.

Aug 15 2022, 8:18 PM · Abstract Wikipedia team (Phase θ – Throttling), function-evaluator, function-orchestrator

Aug 11 2022

maryyang claimed T296841: Consider Locking Validators When `validateStatus` Is Called.
Aug 11 2022, 4:59 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Abstract Wikipedia team (Phase κ – Clean-up), function-schemata
maryyang reopened T296841: Consider Locking Validators When `validateStatus` Is Called as "Open".

After talking with @cmassaro we decided to re-open this task and undo the mutex+async. Reusing this task for the undo!

Aug 11 2022, 4:58 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Abstract Wikipedia team (Phase κ – Clean-up), function-schemata

Aug 10 2022

maryyang added a comment to T296841: Consider Locking Validators When `validateStatus` Is Called.

Sorry for commenting on such an old ticket, but I was reading on some AJV docs and they seem to indicate the race condition would not happen in our scenario: https://ajv.js.org/faq.html#would-errors-get-overwritten-in-case-of-concurrent-validations. As long as we read the errors in the same execution block as the validate call, which I believe we are/can, they won't be overwritten. Here is a discussion thread about this: https://github.com/ajv-validator/ajv/issues/242. Here is the part of the code where the mutex is used: https://github.com/wikimedia/mediawiki-services-function-schemata/blob/master/javascript/src/schema.js#L472-L473.

Aug 10 2022, 7:58 AM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Abstract Wikipedia team (Phase κ – Clean-up), function-schemata
maryyang added a comment to T311457: Set up health checks for function-* services on Beta Cluster.

@fgiunchedi thanks for the clarification! What would be our recommended course of action, e.g. perhaps to proxy the probes through another way?

Aug 10 2022, 7:00 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review, 2022 Wikimedia Google.org Fellowship, Abstract Wikipedia team (Phase θ – Throttling)

Aug 9 2022

maryyang added a comment to T290700: Use a Proper Logging Module in Orchestrator.

Perhaps I am lacking context, but why do we need to pass the logger object around? Could we use separate logger for each class/script?

Aug 9 2022, 9:30 PM · Patch-For-Review, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase θ – Throttling), function-orchestrator
maryyang added a comment to T311457: Set up health checks for function-* services on Beta Cluster.

Update: we are running into some issues with the prometheus blackbox checks where the probes are timing out (10 second). The request should take ~3 seconds to resolve.

Aug 9 2022, 6:00 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review, 2022 Wikimedia Google.org Fellowship, Abstract Wikipedia team (Phase θ – Throttling)

Aug 1 2022

maryyang created T314342: Create JS classes and builders for ZObjects in function-schemata.
Aug 1 2022, 10:30 PM · Abstract Wikipedia team, Patch-For-Review, function-schemata, 2022 Wikimedia Google.org Fellowship
maryyang committed rMSFSa70f4aa32d83: Update schema async function's jsdoc return type to indicate Promise. (authored by maryyang).
Update schema async function's jsdoc return type to indicate Promise.
Aug 1 2022, 10:09 PM

Jul 21 2022

maryyang committed rMSFEa117df1defe1: Change evaluate error type from generic parser error to specific (authored by maryyang).
Change evaluate error type from generic parser error to specific
Jul 21 2022, 1:36 PM

Jul 20 2022

maryyang claimed T310324: Create and use "Invalid Programming Language" Errors.
Jul 20 2022, 2:23 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
maryyang added a comment to T310324: Create and use "Invalid Programming Language" Errors.

I'll finish the last part of this task: Use in function-evaluator.

Jul 20 2022, 2:23 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Jul 10 2022

maryyang added a comment to T310324: Create and use "Invalid Programming Language" Errors.

Hi @Teleosteen, here is an example of where this error would be used: evaluate.js. If you search for this bug ID, you will find two scenarios where this error type is needed: when a function definition specifies a programming language that does not exist, or does not have an executor built-in. I hope this answers your questions. Cheers!

Jul 10 2022, 1:26 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Jul 6 2022

maryyang added a comment to T311457: Set up health checks for function-* services on Beta Cluster.

@taavi when you say "beta prometheus isn't hooked to any alerting system", does it mean it's impossible to set up alerting on a beta cluster host, or it just has not been done before?

Jul 6 2022, 8:36 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review, 2022 Wikimedia Google.org Fellowship, Abstract Wikipedia team (Phase θ – Throttling)
maryyang added a comment to T310184: Alerting for function-* services on Beta.

Oops I created a separate task: https://phabricator.wikimedia.org/T311457. Lemme know if I should merge the two.

Jul 6 2022, 5:34 PM · Beta-Cluster-Infrastructure, Abstract Wikipedia team

Jul 5 2022

maryyang updated subscribers of T311457: Set up health checks for function-* services on Beta Cluster.

Hi @fgiunchedi, thank you for the helpful input! The goal for health monitoring in prod should be similar to that in Beta: we want to make sure the services are up and returning correct responses for basic requests. Since the prod instance will be on kubernetes, the infrastructure we need to achieve the same goal will be different (or so we were told). This is why we are ready to make Beta monitoring a separate effort, since we likely cannot reuse the same setup. I hope that answers your questions!

Jul 5 2022, 10:38 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review, 2022 Wikimedia Google.org Fellowship, Abstract Wikipedia team (Phase θ – Throttling)

Jun 27 2022

maryyang created T311457: Set up health checks for function-* services on Beta Cluster.
Jun 27 2022, 8:18 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Patch-For-Review, 2022 Wikimedia Google.org Fellowship, Abstract Wikipedia team (Phase θ – Throttling)

Jun 13 2022

maryyang updated subscribers of T307700: Observability for function-* services.

We'd also like to invite @JMeybohm and @akosiaris to review the wikifunctions observability doc. We'd really appreciate your input and feedback:) Thanks!

Jun 13 2022, 6:34 PM · Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship, function-evaluator, function-orchestrator

Jun 10 2022

maryyang updated the task description for T307700: Observability for function-* services.
Jun 10 2022, 7:32 PM · Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship, function-evaluator, function-orchestrator
maryyang updated subscribers of T307700: Observability for function-* services.

As part of the observability goal, we are looking to implement periodic health checks to monitor the uptime of the function orchestrator and evaluator.

Jun 10 2022, 7:27 PM · Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship, function-evaluator, function-orchestrator
maryyang committed rMSFE6537fe0c7023: Return error when evaluator cannot find language in implementation. (authored by maryyang).
Return error when evaluator cannot find language in implementation.
Jun 10 2022, 1:15 PM
maryyang created T310332: Investigate possibility for stronger type checking for orchestrators.
Jun 10 2022, 7:06 AM · Abstract Wikipedia team, function-orchestrator
maryyang triaged T310324: Create and use "Invalid Programming Language" Errors as Low priority.
Jun 10 2022, 1:02 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
maryyang created T310324: Create and use "Invalid Programming Language" Errors.
Jun 10 2022, 1:01 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

May 17 2022

maryyang created T308599: Track user defined function and implementation counts.
May 17 2022, 7:02 PM · Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship, function-orchestrator, function-evaluator

May 5 2022

maryyang updated the task description for T307700: Observability for function-* services.
May 5 2022, 8:01 PM · Abstract Wikipedia team (Phase θ – Throttling), 2022 Wikimedia Google.org Fellowship, function-evaluator, function-orchestrator

May 2 2022

maryyang claimed T296857: Evaluator Should Return Z5 When Programming Language Is Invalid.
May 2 2022, 8:40 PM · WikiLambda, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), function-evaluator

Apr 20 2022

maryyang added a comment to T300810: Add Tests for isSomeZObjectType Functions in `src/utils.js`.

Not sure if I got the priority right (I guessed "low"). I just wanted to change the "needs triage" since I accepted the task. Feel free to correct the priority if you see differently.

Apr 20 2022, 8:40 AM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks, function-orchestrator
maryyang claimed T300810: Add Tests for isSomeZObjectType Functions in `src/utils.js`.
Apr 20 2022, 8:38 AM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks, function-orchestrator

Apr 15 2022

maryyang updated the task description for T306225: Grant Access to ldap/wmf for "Mary Yang".
Apr 15 2022, 4:42 PM · SRE Observability (FY2021/2022-Q4), SRE, LDAP-Access-Requests
maryyang added a comment to T306225: Grant Access to ldap/wmf for "Mary Yang".

Hi Andre,

Apr 15 2022, 4:42 PM · SRE Observability (FY2021/2022-Q4), SRE, LDAP-Access-Requests

Apr 14 2022

maryyang created T306225: Grant Access to ldap/wmf for "Mary Yang".
Apr 14 2022, 10:24 PM · SRE Observability (FY2021/2022-Q4), SRE, LDAP-Access-Requests