Admin at cswiki and Wikidata. Tech-Ambassadors, +2 on MediaWiki. Contribute to Pywikibot.
User Details
- User Since
- Oct 12 2014, 12:35 PM (402 w, 2 d)
- Availability
- Available
- IRC Nick
- matej_suchanek
- LDAP User
- Matěj Suchánek
- MediaWiki User
- Matěj Suchánek [ Global Accounts ]
Today
Yesterday
Fri, Jun 24
Tue, Jun 21
Mon, Jun 20
Sun, Jun 19
Thu, Jun 16
Obsolete behavior MAY be removed after it has been hard deprecated for three months in the development version (the master branch) as well as in one major release
Wed, Jun 15
Beware, -grep is already reserved for pagegenerators:
class HarvestRobot(ConfigParserBot, WikidataBot): update_options = { 'always': True, 'create': False, 'exists': '', 'islink': False, 'multi': False, }
The bot always runs as if -always was provided. The change would be trivial, but it could break e.g. bots via repeated jobs on Toolforge.
Mon, Jun 13
Sun, Jun 5
This task seems straightforward, but it involves both frontend and backend and also both modern and legacy interfaces. Also, things have changed a lot since T98941#3333468.
Fri, Jun 3
The test was created in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/773927.
Thu, Jun 2
Wed, Jun 1
This would probably help us solve several tasks around filter privacy (see the workboard on AbuseFilter). T174862: Special:AbuseLog should not show log entries of private filters is a similar proposal, but there were some concerns about transparency. I'm not sure myself, too.
Tue, May 31
Both SpecialChangeEmail and SpecialCreateAccount (via LoginSignupSpecialPage) use HTMLFrom with 'type' => 'email', but this is just an alias for HTMLTextField which does not validate the input in any way. Therefore, both pages do the validation themselves using Sanitizer::validateEmail which already has some technical debt (TODO). Maybe this all could now be unified and enhanced with length validation. Hope this helps.
I think you may need to use added_lines_pst instead of added_lines.
May 29 2022
May 25 2022
May 18 2022
See also T261744: Introduce ThrottleStore.
May 15 2022
May 11 2022
whether it's external (with getWikiId())
May 10 2022
This method is just the tip of the Linker iceberg: ::userToolLinks, ::userToolLinksRedContribs, ::userTalkLink, etc. have the same pattern, and some of them are wrappers (or wrappers of wrappers). So
May 7 2022
The chain of calls seems to be:
- SpecialCreateLocalAccount::onSubmit (CA)
- CentralAuthForcedLocalCreationService::attemptAutoCreateLocalUserFromName
- CentralAuthUtilityService::autoCreateUser
- AuthManager::autoCreateUser (core)
- AbuseFilterPreAuthenticationProvider::testUserForCreation/::testUser (AF)
- RunVariableGenerator::getAccountCreationVars
May 3 2022
May 1 2022
Looks like this could have the same root cause as T299896.
Apr 29 2022
Removed in 071f87bf12a60edda23a4490d42b26c374d48a6e.
Apr 28 2022
You are right, I must have once convinced myself about that.
For your convenience, variables related to users are set in VariableGenerator::generateUserVars and computed in LazyVariableComputer.
Apr 27 2022
It seems the only realistic immediate solution is to abandon the problematic logging query (that counts rows and is not fully indexed) and instead make a boolean query to archive using ArchivedRevisionLookup::hasArchivedRevisions. I left some comments on https://gerrit.wikimedia.org/r/c/530949 that can be used for guidance (or rebased).
Apr 22 2022
Apr 19 2022
The Authority interface gives us now multiple options to solve the "not making this user be a sysop" part:
Apr 17 2022
Apr 14 2022
UI.input_list_choice does not handle the default from self.input(...):
Apr 12 2022
SIMULATION: wbsetreference action blocked.
12:11:35 Creating echo_unread_wikis table...Wikimedia\Rdbms\DBQueryError from line 1638 of /workspace/src/includes/libs/rdbms/database/Database.php: Error 1: unrecognized token: "#" 12:11:35 Function: Wikimedia\Rdbms\Database::sourceFile( /workspace/src/extensions/Echo/db_patches/echo_unread_wikis.sql ) 12:11:35 Query: CREATE TABLE echo_unread_wikis ( 12:11:35 # Primary key 12:11:35 euw_id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT, 12:11:35 # Global user id 12:11:35 euw_user INTEGER NOT NULL, 12:11:35 # Name of wiki 12:11:35 euw_wiki TEXT NOT NULL, 12:11:35 # unread alerts count on that wiki 12:11:35 euw_alerts INTEGER NOT NULL, 12:11:35 # TEXT of the most recent unread alert 12:11:35 euw_alerts_ts BLOB NOT NULL, 12:11:35 # unread messages count on that wiki 12:11:35 euw_messages INTEGER NOT NULL, 12:11:35 # TEXT of the most recent unread message 12:11:35 euw_messages_ts BLOB NOT NULL 12:11:35 ) 12:11:35 12:11:35 #0 /workspace/src/includes/libs/rdbms/database/Database.php(1622): Wikimedia\Rdbms\Database->getQueryException('unrecognized to...', 1, 'CREATE TABLE ec...', 'Wikimedia\\Rdbms...') 12:11:35 #1 /workspace/src/includes/libs/rdbms/database/Database.php(1596): Wikimedia\Rdbms\Database->getQueryExceptionAndLog('unrecognized to...', 1, 'CREATE TABLE ec...', 'Wikimedia\\Rdbms...') 12:11:35 #2 /workspace/src/includes/libs/rdbms/database/Database.php(1178): Wikimedia\Rdbms\Database->reportQueryError('unrecognized to...', 1, 'CREATE TABLE ec...', 'Wikimedia\\Rdbms...', false) 12:11:35 #3 /workspace/src/includes/libs/rdbms/database/Database.php(4987): Wikimedia\Rdbms\Database->query('CREATE TABLE ec...', 'Wikimedia\\Rdbms...') 12:11:35 #4 /workspace/src/includes/libs/rdbms/database/Database.php(4926): Wikimedia\Rdbms\Database->sourceStream(Resource id #2059, NULL, NULL, 'Wikimedia\\Rdbms...', NULL) 12:11:35 #5 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->sourceFile('/workspace/src/...') 12:11:35 #6 /workspace/src/includes/libs/rdbms/database/MaintainableDBConnRef.php(35): Wikimedia\Rdbms\DBConnRef->__call('sourceFile', Array) 12:11:35 #7 /workspace/src/includes/installer/DatabaseUpdater.php(704): Wikimedia\Rdbms\MaintainableDBConnRef->sourceFile('/workspace/src/...') 12:11:35 #8 /workspace/src/includes/installer/DatabaseUpdater.php(749): DatabaseUpdater->applyPatch('/workspace/src/...', true, 'Creating echo_u...') 12:11:35 #9 /workspace/src/includes/installer/DatabaseUpdater.php(533): DatabaseUpdater->addTable('echo_unread_wik...', '/workspace/src/...', true) 12:11:35 #10 /workspace/src/includes/installer/DatabaseUpdater.php(501): DatabaseUpdater->runUpdates(Array, true) 12:11:35 #11 /workspace/src/maintenance/update.php(193): DatabaseUpdater->doUpdates(Array) 12:11:35 #12 /workspace/src/maintenance/doMaintenance.php(114): UpdateMediaWiki->execute() 12:11:35 #13 /workspace/src/maintenance/update.php(264): require_once('/workspace/src/...') 12:11:35 #14 {main}
Apr 10 2022
This is interesting because the unit/ directory in AbuseFilter has never been written in uppercase.
Apr 8 2022
Apr 5 2022
Apr 3 2022
Apr 2 2022
Not everything is done, some methods are stubs that just raise an error.
Mar 27 2022
This could have been fixed by T303060.
Mar 26 2022
For reference, I made the above patch after uncovering the "manual patrol status overwrite" bug in T302140.
Mar 25 2022
Mar 23 2022
Mar 22 2022
Mar 18 2022
Mar 17 2022
Mar 16 2022
Mar 14 2022
Mar 11 2022
So what's left?