matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (165 w, 1 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Yesterday

matmarex renamed T182907: Link inspector overlapped by toolbar and extends past the screen when it opens upwards (only when editing links in tables and references) from The link inspector can behave weirdly when editing links in tables and references to Link inspector overlapped by toolbar and extends past the screen when it opens upwards (only when editing links in tables and references).
Sat, Dec 16, 10:03 PM · VisualEditor
matmarex merged task T182999: Namespace selection dropdown opens in the wrong direction, Special page tab overlaps into T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.
Sat, Dec 16, 10:01 PM · OOjs-UI, MediaWiki-General-or-Unknown
matmarex merged T182999: Namespace selection dropdown opens in the wrong direction, Special page tab overlaps into T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.
Sat, Dec 16, 10:01 PM · Patch-For-Review, Vector
matmarex renamed T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards from "Move page" select namespace list sometime dysfunctional (overlapped by namespace tabs when it opens upwards) to Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.
Sat, Dec 16, 9:59 PM · Patch-For-Review, Vector
matmarex claimed T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.
Sat, Dec 16, 9:48 PM · Patch-For-Review, OOjs-UI
matmarex added a comment to T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.

The solution for this is to put the menus/popups inside an "overlay" (essentially, a separate "layer" shown on top of everything else on the page – https://www.mediawiki.org/wiki/OOjs_UI/Concepts#Overlays). But there are some caveats:

  • This is currently not be possible for PHP-generated widgets that become infused (https://www.mediawiki.org/wiki/OOjs_UI/Using_OOjs_UI_in_MediaWiki#Infusion). I'm working on a patch to make them always use an overlay (this will fix all PHP widgets everywhere at once).
  • Some things to consider for JS code:
    • The Vector skin has some really weird z-indices set on the personal menu (in top right). You need to set 'z-index: 101' (or higher) on your overlay to display your content above them.
    • Almost all of the skins also have weird font-sizes set on the <body> element, which are later overridden. This makes using overlays annoying :(
    • To resolve this, OOUI should make a default overlay available with all the necessary z-index and font-size overrides already applies, which all applications will be able to use.
Sat, Dec 16, 9:43 PM · Patch-For-Review, OOjs-UI
matmarex added parent tasks for T183069: Issues with OOUI menus/popups that open upwards being overlapped by things: T182711: Recent changes: Filter menu opens upwards, T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards, T182907: Link inspector overlapped by toolbar and extends past the screen when it opens upwards (only when editing links in tables and references), T182999: Namespace selection dropdown opens in the wrong direction, Special page tab overlaps.
Sat, Dec 16, 9:35 PM · Patch-For-Review, OOjs-UI
matmarex added a subtask for T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards: T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.
Sat, Dec 16, 9:35 PM · Patch-For-Review, Vector
matmarex added a subtask for T182711: Recent changes: Filter menu opens upwards: T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.
Sat, Dec 16, 9:35 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
matmarex added a subtask for T182907: Link inspector overlapped by toolbar and extends past the screen when it opens upwards (only when editing links in tables and references): T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.
Sat, Dec 16, 9:35 PM · VisualEditor
matmarex added a subtask for T182999: Namespace selection dropdown opens in the wrong direction, Special page tab overlaps: T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.
Sat, Dec 16, 9:35 PM · OOjs-UI, MediaWiki-General-or-Unknown
matmarex created T183069: Issues with OOUI menus/popups that open upwards being overlapped by things.
Sat, Dec 16, 9:34 PM · Patch-For-Review, OOjs-UI
matmarex added a comment to T182711: Recent changes: Filter menu opens upwards.

@jmatazzoni I'm already working on a systematic solution, my set of patches on T182602 (pending review since Wednesday) resolves all of the issues caused by menus/popups opening upwards that I know of, except for this issue with RCFilters (which is fixed by the two patches I submitted here; only one of them was backported though, the one for the main filter menu) and T182907 in VisualEditor (on which I'll have to work separately, I did not look into it yet).

Sat, Dec 16, 9:30 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Fri, Dec 15

matmarex added a comment to T181112: Sort skins by their ID and default position, not by their localised name.

I understand placing default skin first, but I don't understand what sense does it make to sort the rest by internal name, as opposed to regular sort order or sort by popularity.

Fri, Dec 15, 1:26 AM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), MediaWiki-Internationalization, MediaWiki-User-preferences
matmarex closed T181112: Sort skins by their ID and default position, not by their localised name as Resolved.
Fri, Dec 15, 1:26 AM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), MediaWiki-Internationalization, MediaWiki-User-preferences
matmarex closed T181112: Sort skins by their ID and default position, not by their localised name, a subtask of T180538: Improve Special:Preferences UI/UX, as Resolved.
Fri, Dec 15, 1:26 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, UI-Standardization, MediaWiki-User-preferences
matmarex closed T182359: [wmf.11] "Uncaught TypeError: Cannot read property 'css' of undefined" when topics are sorted on SD boards as Resolved.

Fixed and deployed.

Fri, Dec 15, 12:31 AM · OOjs-UI, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
matmarex closed T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working) as Resolved.

Fixed and deployed.

Fri, Dec 15, 12:31 AM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a comment to T182711: Recent changes: Filter menu opens upwards.

Also reported on plwiki: https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#Bugi_w_interfejsie

Fri, Dec 15, 12:09 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Thu, Dec 14

matmarex added a comment to T181045: Enable both "edit" and "edit code" tabs in Polish Wikipedia.

We don't have an option in site configuration to do that right now. The options are:

  • $wmgVisualEditorUseSingleEditTab = false: two tabs, "Edit" and "Edit source", are always displayed (except on pages that can't be edited with VE)
  • $wmgVisualEditorUseSingleEditTab = true: user has an option in preferences to choose whether to use the above behavior, use only VE, use only WT, or use whichever editor they used last (this is the default choice).
Thu, Dec 14, 11:54 PM · User-Ryasmeen, Patch-For-Review, Wikimedia-Site-requests, VisualEditor
matmarex raised the priority of T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working) from Low to High.
Thu, Dec 14, 11:00 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex triaged T182359: [wmf.11] "Uncaught TypeError: Cannot read property 'css' of undefined" when topics are sorted on SD boards as High priority.
Thu, Dec 14, 11:00 PM · OOjs-UI, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
matmarex added a comment to T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).

This is the same issue as T182359, which had a patch proposed and merged last night, so I'll abandon mine and backport that instead.

Thu, Dec 14, 10:51 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex updated the task description for T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).
Thu, Dec 14, 10:48 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a parent task for T182834: Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given: T180748: 1.31.0-wmf.15 deployment blockers.
Thu, Dec 14, 8:44 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Patch-For-Review, Wikimedia-log-errors, CheckUser, StructuredDiscussions, Collaboration-Team-Triage
matmarex added a subtask for T180748: 1.31.0-wmf.15 deployment blockers: T182834: Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given.
Thu, Dec 14, 8:44 PM · Release, Train Deployments
matmarex added a comment to T182834: Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given.

Note that a fix has been merged only in 1.31.0-wmf.12, but not in master.

Thu, Dec 14, 8:42 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Patch-For-Review, Wikimedia-log-errors, CheckUser, StructuredDiscussions, Collaboration-Team-Triage

Wed, Dec 13

matmarex updated subscribers of T182834: Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given.

Apparently CheckUser has been renamed to SpecialCheckUser in 6ab26d6e47f7526708c4a9da52f6ff79373be328 (https://gerrit.wikimedia.org/r/#/c/396599/).

Wed, Dec 13, 11:11 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Patch-For-Review, Wikimedia-log-errors, CheckUser, StructuredDiscussions, Collaboration-Team-Triage
matmarex added a comment to T181324: Edit font preview in preferences uses a small font size for monospace.

(For future reference, this refers to the feature from https://gerrit.wikimedia.org/r/#/c/389980/, which is currently reverted per https://gerrit.wikimedia.org/r/#/c/394804/)

Wed, Dec 13, 1:39 AM · VisualEditor, MediaWiki-Page-editing, Patch-For-Review, MediaWiki-User-preferences
matmarex claimed T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.
Wed, Dec 13, 12:33 AM · Patch-For-Review, Vector

Tue, Dec 12

matmarex added a comment to T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).

Right. Someone should probably merge and deploy that backport then ;)

Tue, Dec 12, 11:06 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a comment to T182711: Recent changes: Filter menu opens upwards.

Actually, it seems that you set $overlay correctly everywhere, and the ugly overlapping seen in the screenshots posted by Elena and myself above is because the overlay itself is below the personal menu in z-index.

Tue, Dec 12, 10:57 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
matmarex added a comment to T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.

I'm not sure if that would always make sense. (If there was no other way to resolve the current problem, I would support that, but if we can make the menu appear on top of everything else, I think that's better.)

Tue, Dec 12, 10:15 PM · Patch-For-Review, Vector
matmarex claimed T182711: Recent changes: Filter menu opens upwards.

For the big filters menu, we probably want to make it always open downwards, since some other things depend on this (and we scroll to make the menu usably large). This can be forced by overriding #getVerticalAnchorEdge.

Tue, Dec 12, 10:00 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
matmarex updated the task description for T182711: Recent changes: Filter menu opens upwards.
Tue, Dec 12, 9:55 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
matmarex added a comment to T182711: Recent changes: Filter menu opens upwards.

Can also happen with "Save current filter settings" (bookmark icon) and maybe more other things.

Tue, Dec 12, 9:54 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
matmarex added a comment to T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).

The fix is in OOUI, and it will be released no sooner than next Tuesday, and I suppose you might want this fixed faster. I'll prepare a manual backport to MediaWiki too (but I'm leaving it for Multimedia folks to review and deploy this).

Tue, Dec 12, 9:23 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a project to T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working): OOjs-UI.
Tue, Dec 12, 9:16 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a comment to T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).

As a side note, this interface should probably be using an IndexLayout (https://doc.wikimedia.org/oojs-ui/master/demos/#IndexLayout) to build the tabs, or at least use a TabSelectWidget instead of MenuSelectWidget with weird custom overrides. It would be more consistent and probably it'd take less code. (This probably didn't exist when this code was written though.)

Tue, Dec 12, 9:15 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex merged task T182658: MultimediaViewer: Share/Embed button not working into T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).
Tue, Dec 12, 8:58 PM · Patch-For-Review, Multimedia-Team-Working-Board, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex merged T182658: MultimediaViewer: Share/Embed button not working into T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).
Tue, Dec 12, 8:58 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex renamed T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working) from mwext-qunit-jessie Jenkins job fails for MultimediaViewer to mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).
Tue, Dec 12, 8:58 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a comment to T182658: MultimediaViewer: Share/Embed button not working.

Actually I'm going to merge this into T182395, since that's the same issue?

Tue, Dec 12, 8:57 PM · Patch-For-Review, Multimedia-Team-Working-Board, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex claimed T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).
Tue, Dec 12, 8:33 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex added a comment to T182395: mwext-qunit-jessie Jenkins job fails for MultimediaViewer (Share/Embed button not working).

Sorry for late reply. $floatableContainer is not supposed to be required.

Tue, Dec 12, 8:32 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), OOjs-UI, User-zeljkofilipin, Multimedia, MediaWiki-extensions-MultimediaViewer
matmarex removed a member for Multimedia: matmarex.
Tue, Dec 12, 7:15 PM
matmarex added a member for UploadWizard: matmarex.
Tue, Dec 12, 7:15 PM
matmarex added a comment to T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.

So, Vector is intentionally set up so that the page content can never overlap the interface elements, like the tabs, even when absolutely positioned (df10f03a7a28e1cefceb65bebf2e008870e39cb4). Unfortunately in this case the dropdown menu is part of the page content…

Tue, Dec 12, 8:00 AM · Patch-For-Review, Vector
matmarex claimed T182650: Dropdowns/popups/etc. always open downwards if the anchor is partially offscreen, even when they should open upwards.
Tue, Dec 12, 5:11 AM · Patch-For-Review, OOjs-UI
matmarex created T182650: Dropdowns/popups/etc. always open downwards if the anchor is partially offscreen, even when they should open upwards.
Tue, Dec 12, 4:24 AM · Patch-For-Review, OOjs-UI
matmarex added a comment to T182466: Implement ToggleSwitchInputWidget.

That isn't possible for non-JS, and you said that's a requirement.

Tue, Dec 12, 3:07 AM · OOjs-UI

Mon, Dec 11

matmarex edited projects for T182632: PAGENAMEE magic word does not work properly when used in target links of files and pagename contains a semicolon, added: MediaWiki-Parser; removed MediaWiki-General-or-Unknown.
Mon, Dec 11, 10:31 PM · MediaWiki-Parser
matmarex renamed T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards from "Move page" select namespace list sometime dysfunctional to "Move page" select namespace list sometime dysfunctional (overlapped by namespace tabs when it opens upwards).
Mon, Dec 11, 7:24 PM · Patch-For-Review, Vector
matmarex added a comment to T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.

That's silly and sounds annoying. I'll look into this.

Mon, Dec 11, 7:24 PM · Patch-For-Review, Vector
matmarex added a comment to T158934: Automatically change popup direction if there is no space.

That's a bug, I'll file another task and look into it.

Mon, Dec 11, 7:22 PM · OOjs-UI
matmarex updated the task description for T182602: Vector: Long dropdown menus (e.g. select namespace) overlapped by namespace tabs and personal menu when they open upwards.
Mon, Dec 11, 7:17 PM · Patch-For-Review, Vector

Sat, Dec 9

matmarex added a comment to T182466: Implement ToggleSwitchInputWidget.

The convention is that only widgets that are subclasses of InputWidget (and whose names end in 'InputWidget') are compatible with HTML <form>s.

Sat, Dec 9, 12:31 AM · OOjs-UI

Fri, Dec 8

matmarex updated the task description for T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook (Apex) but not in Vector (WikimediaUI theme).
Fri, Dec 8, 9:24 PM · OOjs-UI (OOjs-UI-0.25.0)
matmarex added a comment to T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook (Apex) but not in Vector (WikimediaUI theme).

To clarify, this is about read-only text fields, not disabled text fields; and it affects single-line fields too. In Apex theme (MonoBook skin), the text is greyed out slightly. In WikimediaUI theme (Vector skin), the background is grey instead. Screenshots from the demo (after running widget.setReadOnly(1) in the console for each field):

Fri, Dec 8, 9:23 PM · OOjs-UI (OOjs-UI-0.25.0)
matmarex closed T25238: Add tabindex to Special:Upload as Resolved.

I didn't sign up as a Google Code-in mentor this year, so I can't mark this as completed on the GCI site – probably @Aklapper can do it if @Prtksxna is not around.

Fri, Dec 8, 9:12 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Google-Code-in-2017, Accessibility, MediaWiki-Interface
matmarex closed T25238: Add tabindex to Special:Upload, a subtask of T45562: Special pages and other forms with initial focus of input nowhere or no tab order/tabindex set (tracking), as Resolved.
Fri, Dec 8, 9:12 PM · Accessibility, Tracking, MediaWiki-General-or-Unknown
matmarex closed T25238: Add tabindex to Special:Upload, a subtask of T2367: Markup accessibility issues (tracking), as Resolved.
Fri, Dec 8, 9:12 PM · Tracking, Accessibility, MediaWiki-Interface
matmarex merged T182429: OOUI drop downs do not change selection on an arrow keypress unlike native browser widget into T53229: OOjs UI: Tab character in dropdown boxes should pick the current selection (like Enter does).
Fri, Dec 8, 8:48 PM · OOjs-UI
matmarex merged task T182429: OOUI drop downs do not change selection on an arrow keypress unlike native browser widget into T53229: OOjs UI: Tab character in dropdown boxes should pick the current selection (like Enter does).
Fri, Dec 8, 8:48 PM · OOjs-UI
matmarex added a comment to T182429: OOUI drop downs do not change selection on an arrow keypress unlike native browser widget.

Depending on the browser, pressing Tab can either confirm or cancel the choice in a dropdown. I compared a bunch of Windows browsers' behaviors a few years ago: T53229#1026273. I don't own any Macs, but it seems that Chrome and Safari cancel the choice on pressing Tab: T53229#2928164.

Fri, Dec 8, 8:47 PM · OOjs-UI

Thu, Dec 7

matmarex added a comment to T181503: Add proper category collation for the Northern Sami Wikipedia.

To be honest I'm not sure what the rest of the syntax, other than <, << and <<<, means ;)

Thu, Dec 7, 10:51 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), WMNO-Northern-Sami, Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex added a comment to T181503: Add proper category collation for the Northern Sami Wikipedia.

Ü and Ű are also missing, although I have no idea if they're actually useful.

Thu, Dec 7, 10:16 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), WMNO-Northern-Sami, Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex closed T181947: Special:SpecialPages on skin Timeless has bad aligned two column layout as Resolved.
Thu, Dec 7, 10:06 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Timeless, MediaWiki-Special-pages
matmarex added a comment to T181503: Add proper category collation for the Northern Sami Wikipedia.

(Added 'Ǥ' after 'Ǧ' to the patch, per IRC conversation with Jon.)

Thu, Dec 7, 9:33 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), WMNO-Northern-Sami, Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex added a comment to T181947: Special:SpecialPages on skin Timeless has bad aligned two column layout.

This is also noticeable in Vector for me, although the misalignment is a lot smaller.

Thu, Dec 7, 9:22 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Timeless, MediaWiki-Special-pages
matmarex added a comment to T181503: Add proper category collation for the Northern Sami Wikipedia.

@jhsoby-WMNO Thanks for the patch! I tested locally by creating the pages with the same titles as the test category (https://se.wikipedia.org/wiki/Kategoriija:Sámegielaid_alfabehta) and changing the collation of my test wiki. It looks fine:

Thu, Dec 7, 8:56 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), WMNO-Northern-Sami, Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex added a comment to T182264: IE content analyzer is executed on non-first chunks during chunk uploading, preventing legitimate uploads.

This indeed looks like the same issue as T143610, except the offending function is UploadBase::verifyMimeType() rather than detectScript(). This should be very easy to fix, but a similar fix for T143610 was rejected because folks are not sufficiently certain that the partially uploaded files are only accessible to their uploader, rather than everyone.

Thu, Dec 7, 8:13 PM · MediaWiki-Uploading, Multimedia, Commons
matmarex added a comment to T182320: Fix textarea editor's edit font size.

I support this, but it will probably be super annoying for some users if the font rendering changes for them. (I know how annoyed I was when the upgrade from Sublime Text 2 to 3 changed the text rendering very slightly by switching from GDI to DirectWrite, and how relieved when I found you can change it back.)

Thu, Dec 7, 8:00 PM · Patch-For-Review, UI-Standardization
matmarex claimed T181112: Sort skins by their ID and default position, not by their localised name.
Thu, Dec 7, 7:00 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), MediaWiki-Internationalization, MediaWiki-User-preferences

Wed, Dec 6

matmarex added a comment to T76632: OOUI themes should be able to be moved out to another repo.

Well it's still just as impossible as before? IIRC James closed this after I did rGOJU09d210d61d8c: Implement `grunt add-theme` task to ease theme creation, but that doesn't resolve this task (it only helps you add themes if you fork OOUI).

Wed, Dec 6, 7:13 PM · Epic, OOjs-UI

Tue, Dec 5

matmarex edited projects for T182060: Code spacing of infobox is lost and code changed places , added: VisualEditor-MediaWiki; removed MediaWiki-General-or-Unknown.
Tue, Dec 5, 2:54 PM · VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T104541: Category pages causes articles to list in one row and the "letter" in another.

Only old Opera and IE/Edge support break-before: avoid / break-after: avoid, which we need to prevent the breaking between the header and the list. That page is quite generous in saying Chrome "supports" multicolumn. (This lack is actually described in the footnote 1 though.)

Tue, Dec 5, 2:52 PM · MediaWiki-Categories

Mon, Dec 4

matmarex closed T179359: Many translations for 'createacct-helpusername-url' are missing as Resolved.

Looks like some other missing messages were restored in 8830e6fe63fa4ee2ec71eddb195b5c32eb7ed6bd. Possibly Raymond made it work with 31705b897594f7dd37572a340814e5174a1553e6? Looks like the message is now present in the repository in all 58 languages, so this seems fixed.

Mon, Dec 4, 9:43 PM · Wikimedia-General-or-Unknown, translatewiki.net, WikimediaMessages
matmarex added a comment to T91707: L10n-bot should not force-merge / override Jenkins (breaks the build).

It probably wouldn't be hard, but it would be tedious, since you'd probably have to update the expected values in each test from English text to the message keys.

Mon, Dec 4, 9:11 PM · Continuous-Integration-Infrastructure, translatewiki.net
matmarex edited parent tasks for T181996: New Preferences headers may be unclickable when wrapped on Timeless skin, added: T180538: Improve Special:Preferences UI/UX; removed: T117781: Convert Special:Preferences to OOUI, T176034: Handle tabs of IndexLayout that don't fit on the screen horizontally (scrolling or wrapping).
Mon, Dec 4, 8:54 PM · Timeless, MediaWiki-User-preferences
matmarex removed a subtask for T117781: Convert Special:Preferences to OOUI: T181996: New Preferences headers may be unclickable when wrapped on Timeless skin.
Mon, Dec 4, 8:54 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Patch-For-Review, Front-end-Standards-Group, MediaWiki-Special-pages, Epic, UI-Standardization
matmarex removed a subtask for T176034: Handle tabs of IndexLayout that don't fit on the screen horizontally (scrolling or wrapping): T181996: New Preferences headers may be unclickable when wrapped on Timeless skin.
Mon, Dec 4, 8:54 PM · OOjs-UI
matmarex added a subtask for T180538: Improve Special:Preferences UI/UX: T181996: New Preferences headers may be unclickable when wrapped on Timeless skin.
Mon, Dec 4, 8:54 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, UI-Standardization, MediaWiki-User-preferences
matmarex added a comment to T181996: New Preferences headers may be unclickable when wrapped on Timeless skin.

This doesn't occur with other skins.

Mon, Dec 4, 8:54 PM · Timeless, MediaWiki-User-preferences
matmarex renamed T181996: New Preferences headers may be unclickable when wrapped on Timeless skin from New Preferences headers may be unclickable when wrapped to New Preferences headers may be unclickable when wrapped on Timeless skin.
Mon, Dec 4, 8:53 PM · Timeless, MediaWiki-User-preferences
matmarex added a comment to T104541: Category pages causes articles to list in one row and the "letter" in another.

I don't understand how that helps. Note that we're already using a very similar markup, namely:

Mon, Dec 4, 8:47 PM · MediaWiki-Categories
matmarex added a comment to T117781: Convert Special:Preferences to OOUI.

I reverted Special:Preferences back to the old interface, and the revert was deployed to all wikis today. For anyone who doesn't want to check Gerrit, here's a copy of the explanation from the commit message:

Mon, Dec 4, 4:28 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Patch-For-Review, Front-end-Standards-Group, MediaWiki-Special-pages, Epic, UI-Standardization
matmarex added a comment to T180538: Improve Special:Preferences UI/UX.

I reverted Special:Preferences back to the old interface, and the revert was deployed to all wikis today. For anyone who doesn't want to check Gerrit, here's a copy of the explanation from the commit message:

Mon, Dec 4, 4:28 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, UI-Standardization, MediaWiki-User-preferences

Sat, Dec 2

matmarex reopened T117781: Convert Special:Preferences to OOUI as "Open".
Sat, Dec 2, 10:13 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Patch-For-Review, Front-end-Standards-Group, MediaWiki-Special-pages, Epic, UI-Standardization
matmarex reopened T117781: Convert Special:Preferences to OOUI, a subtask of T101471: Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OOUI FormSpecialPage or explicit OOUI PHP, as Open.
Sat, Dec 2, 10:13 PM · UI-Standardization
matmarex reopened T117781: Convert Special:Preferences to OOUI, a subtask of T107037: Convert all MW core special pages to OOUI, as Open.
Sat, Dec 2, 10:13 PM · Front-end-Standards-Group, Tracking, Epic, UI-Standardization
matmarex reopened T117781: Convert Special:Preferences to OOUI, a subtask of T171238: Special:Preferences design broken - not using OOUI, as Open.
Sat, Dec 2, 10:13 PM · MinervaNeue, UI-Standardization
matmarex added a comment to T181770: Special:Preferences layout (with OOUI) has quite a bit of excess whitespace in Monobook.

(I am copying the screenshots to Phabricator because Commons admins like to delete stuff)

Sat, Dec 2, 9:45 PM · MonoBook, OOjs-UI, MediaWiki-User-preferences
matmarex updated the task description for T181770: Special:Preferences layout (with OOUI) has quite a bit of excess whitespace in Monobook.
Sat, Dec 2, 9:38 PM · MonoBook, OOjs-UI, MediaWiki-User-preferences
matmarex added a comment to T143923: "(help me choose)" link near the username field in the signup form looks out of place.

Here to report that in Mozilla Firefox 39.0 the text seems rendered somehow bigger than normal and so in it.wiki I see this text wrapped.

https://it.wikipedia.org/w/index.php?title=Speciale:CreaUtenza

I cannot reproduce this problem with other newer versions of Mozilla Firefox, or with Chromium 43.0, so it seems only a bug in Mozilla Firefox 39.

Sat, Dec 2, 4:13 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), MediaWiki-User-login-and-signup, Regression, MediaWiki-Interface
matmarex added a comment to T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.

No. I almost did it, but to upload them there, you'd have to find out the right license for every single one separately, and that was more effort than I was willing to put into it. The skins can each have different licenses, they're not all on GPL like MediaWiki.

Sat, Dec 2, 4:02 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface

Thu, Nov 30

matmarex edited projects for T181711: mw.Feedback could allow last-minute modifications of the message, added: MediaWiki-General-or-Unknown; removed OOjs-UI, Performance-Team, MediaWiki-ResourceLoader.
Thu, Nov 30, 8:40 PM · MediaWiki-General-or-Unknown, JavaScript
matmarex closed T181698: Headings of sections on "Gadgets" tab on Special:Preferences display escaped HTML after OOUI conversion as Resolved.

Fixed and deployed.

Thu, Nov 30, 7:21 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-HTMLForm, Regression, MediaWiki-User-preferences
matmarex closed T181698: Headings of sections on "Gadgets" tab on Special:Preferences display escaped HTML after OOUI conversion, a subtask of T180538: Improve Special:Preferences UI/UX, as Resolved.
Thu, Nov 30, 7:21 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, UI-Standardization, MediaWiki-User-preferences
matmarex closed T106095: Fixed-position headers/footers obscure last elements of OOUI dropdowns as Resolved.

We can have separate tasks for those, if any.

Thu, Nov 30, 5:13 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), OOjs-UI, MediaWiki-Debug-Logger