Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (20)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (235 w, 2 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Tue, Apr 16

matmarex moved T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML from QA to Product owner review on the VisualEditor (Current work) board.
Tue, Apr 16, 7:22 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML from Code review to QA on the VisualEditor (Current work) board.
Tue, Apr 16, 7:22 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex triaged T221128: Wikibase / CirrusSearch tests are blocking merges in Math extension as Unbreak Now! priority.
Tue, Apr 16, 6:22 PM · Discovery-Search, Math, CirrusSearch, Wikidata
matmarex added a comment to T220011: Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors.

Block notices are also covered by T209599

Tue, Apr 16, 5:29 PM · VisualEditor, VisualEditor-MediaWiki-Mobile
matmarex merged task T220922: Give a clearer message when a mobile edit fails because of spam blacklist into T167078: Spam links trigger unknown error on mobile.
Tue, Apr 16, 5:23 PM · MobileFrontend
matmarex merged T220922: Give a clearer message when a mobile edit fails because of spam blacklist into T167078: Spam links trigger unknown error on mobile.
Tue, Apr 16, 5:23 PM · VisualEditor, SpamBlacklist, MobileFrontend
matmarex merged T184978: Header bar overlaps save button in Visual Editor into T183284: Timeless and VE media insertion dialog conflict.
Tue, Apr 16, 3:41 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Verified, User-Ryasmeen, VisualEditor, Timeless
matmarex merged task T184978: Header bar overlaps save button in Visual Editor into T183284: Timeless and VE media insertion dialog conflict.
Tue, Apr 16, 3:41 PM · Timeless
matmarex added a comment to T184978: Header bar overlaps save button in Visual Editor.

This has been resolved by the same fix as T183284.

Tue, Apr 16, 3:41 PM · Timeless

Mon, Apr 15

matmarex edited projects for T221042: Got "TypeError" when searching with prefix: in the Spanish Wikipedia, added: CirrusSearch, Wikimedia-production-error; removed MediaWiki-General-or-Unknown.

Error backtrace:

Argument 1 passed to Elastica\Exception\ResponseException::__construct() must be an instance of Elastica\Request, null given, called in /srv/mediawiki/php-1.33.0-wmf.25/extensions/CirrusSearch/includes/ElasticsearchIntermediary.php on line 204
Mon, Apr 15, 10:53 PM · Wikimedia-production-error, CirrusSearch, Discovery-Search
matmarex added a comment to T220792: LookupElement has padding at the end if there is just one suggestion.

I think this might be a problem with all dropdown menus – for some reason MenuSelectWidget has a min-height in its styles.

Mon, Apr 15, 10:42 PM · OOUI
matmarex added a comment to T220984: Visualeditor/Parsoid in Internet Explorer scrambles Texts.

I can reproduce this on Windows 10 as well. The problem happens when typing with a "table selection" (blue overlay covering a table cell); it doesn't happen when typing with a "linear selection" (blinking cursor inside a table cell).

Mon, Apr 15, 10:40 PM · Browser-Support-Internet-Explorer, VisualEditor, Parsoid
matmarex closed T220916: ve is apparently writing cs1|2 templates with invalid parameters as Invalid.

VisualEditor uses parameters as defined in the template's TemplateData. This parameter is documented in https://en.wikipedia.org/w/index.php?title=Template:Citation/doc&action=edit and neither the JSON data nor the human-readable description mention any restrictions on its use. If you want Citoid to stop using it, you should delete this line from it: "issueDate": "issue-date",.

Mon, Apr 15, 10:36 PM · VisualEditor
matmarex added a comment to T220671: Replace `em` based sizing in favor of `px` based.

I think being able to resize everything by just increasing the font-size is valuable and convenient. Example use cases:

Mon, Apr 15, 9:23 PM · OOUI
matmarex moved T218635: Mobile visual editor scrolls to the top of the page after adding a link in iOS Safari from Stalled/Waiting to Product owner review on the VisualEditor (Current work) board.
Mon, Apr 15, 8:36 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work)
matmarex added a comment to T218635: Mobile visual editor scrolls to the top of the page after adding a link in iOS Safari.

I'm not familiar with that problem, and I don't recall any relevant tasks… I would prefer if we filed a separate task for it.

Mon, Apr 15, 8:35 PM · VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work)
matmarex added a parent task for T87190: Migrate JavaScript move of FancyCaptcha to PHP in ConfirmEdit: T72803: FOUC on signup page where CAPTCHA is in the wrong place before moving down.
Mon, Apr 15, 8:24 PM · WMF-deploy-2015-09-15_(1.26wmf23), MW-1.26-release, Patch-For-Review, MediaWiki-User-login-and-signup, ConfirmEdit (CAPTCHA extension)
matmarex added a subtask for T72803: FOUC on signup page where CAPTCHA is in the wrong place before moving down: T87190: Migrate JavaScript move of FancyCaptcha to PHP in ConfirmEdit.
Mon, Apr 15, 8:24 PM · MediaWiki-User-login-and-signup
matmarex closed T72803: FOUC on signup page where CAPTCHA is in the wrong place before moving down as Resolved.

Resolved by way of T87190: Migrate JavaScript move of FancyCaptcha to PHP in ConfirmEdit.

Mon, Apr 15, 8:24 PM · MediaWiki-User-login-and-signup
matmarex added a subtask for T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving: T221028: Parsoid incorrectly parses links to pages starting with a slash '/' in namespaces that can have subpages.
Mon, Apr 15, 7:33 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
matmarex added a parent task for T221028: Parsoid incorrectly parses links to pages starting with a slash '/' in namespaces that can have subpages: T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.
Mon, Apr 15, 7:32 PM · Parsoid-Read-Views
matmarex added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

Typing "/Sandbox" into the link inspector shouldn't create a link to the "Sandbox" subpage of the current page. It should create a link to the page "/Sandbox" in the main namespace. We do not support any other relative link syntaxes supported by MediaWiki (e.g. try "../Sandbox", it refuses to accept it, but [[../Sandbox]] is a valid link in wikitext).

Mon, Apr 15, 7:32 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
matmarex created T221028: Parsoid incorrectly parses links to pages starting with a slash '/' in namespaces that can have subpages.
Mon, Apr 15, 7:29 PM · Parsoid-Read-Views
matmarex closed T115089: Template/reference preview of links is relative to current page, not the correct base, until saved as Resolved.

This no longer seems to be a problem.

Mon, Apr 15, 7:18 PM · User-Ryasmeen, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki-References, VisualEditor
matmarex moved T154622: Hidden HTML comments are in very light grey and hard to read from Ready for Pick Up to Product owner review on the VisualEditor (Current work) board.
Mon, Apr 15, 5:22 PM · VisualEditor-EditingTools, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), Accessibility
matmarex moved T154622: Hidden HTML comments are in very light grey and hard to read from Unsorted to Colors on the Accessibility board.
Mon, Apr 15, 5:22 PM · VisualEditor-EditingTools, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), Accessibility
matmarex changed the status of T154622: Hidden HTML comments are in very light grey and hard to read from Stalled to Open.
Mon, Apr 15, 5:21 PM · VisualEditor-EditingTools, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), Accessibility
matmarex added a comment to T154622: Hidden HTML comments are in very light grey and hard to read.
BeforeAfter
Mon, Apr 15, 5:21 PM · VisualEditor-EditingTools, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), Accessibility

Fri, Apr 12

matmarex edited projects for T208102: Improve compatibility of desktop VisualEditor with desktop Minerva skin, added: MinervaNeue (Desktop); removed MinervaNeue.
Fri, Apr 12, 12:40 AM · MinervaNeue (Desktop), Verified, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex added a parent task for T220781: When filtering page history by date, the older/newer paging links don't work: T107069: Convert HistoryAction.php to use OOUI and MW's new DateInputWidget.
Fri, Apr 12, 12:12 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-Interface, Regression
matmarex claimed T220781: When filtering page history by date, the older/newer paging links don't work.
Fri, Apr 12, 12:12 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-Interface, Regression
matmarex added a subtask for T107069: Convert HistoryAction.php to use OOUI and MW's new DateInputWidget: T220781: When filtering page history by date, the older/newer paging links don't work.
Fri, Apr 12, 12:12 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), UI-Standardization-Kanban, User-Jdlrobson, Advanced Mobile Contributions, MediaWiki-History-and-Diffs, UI-Standardization
matmarex created T220781: When filtering page history by date, the older/newer paging links don't work.
Fri, Apr 12, 12:11 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-Interface, Regression

Thu, Apr 11

matmarex added a comment to T220555: Evaluate collapsible form on HistoryAction (collapsed by default?).

@Volker_E I'm not an expert and may be wrong/out of date, but aren't there either accessibility and mobile issues with collapsing? I vaguely recall DJ putting a lot of work in on that front.

Thu, Apr 11, 11:47 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, UI-Standardization-Kanban, User-Jdlrobson, Advanced Mobile Contributions, MediaWiki-History-and-Diffs, UI-Standardization
matmarex added a comment to T107069: Convert HistoryAction.php to use OOUI and MW's new DateInputWidget.

I really liked this change because of the ability to pick a concrete date, but the interface clearly wasn’t fledged out. Collapsing the form now seems not like a complete fix of the design, but like a quick and dirty change to appease people. This is especially visible on the screenshots provided here, where OOUI clearly doesn’t support collapsing forms like this and bottom margin is still visible in collapsed view.

Thu, Apr 11, 11:44 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), UI-Standardization-Kanban, User-Jdlrobson, Advanced Mobile Contributions, MediaWiki-History-and-Diffs, UI-Standardization
matmarex added a subtask for T190765: Refreshing a source page in the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled): T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state.
Thu, Apr 11, 10:25 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a parent task for T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state: T190765: Refreshing a source page in the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled).
Thu, Apr 11, 10:24 PM · VisualEditor (Current work)
matmarex added a comment to T190765: Refreshing a source page in the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled).

I think this might be caused by T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state. We should revisit this task after that is fixed.

Thu, Apr 11, 10:24 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added subtasks for T190989: On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors: T178976: When VE is disabled but NWE is enabled and wiki is in multi-tab mode, initialization code for the "Edit" tab doesn't run, T190765: Refreshing a source page in the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled).
Thu, Apr 11, 10:24 PM · MinervaNeue (Desktop), VisualEditor, MediaWiki-Page-editing
matmarex added a parent task for T178976: When VE is disabled but NWE is enabled and wiki is in multi-tab mode, initialization code for the "Edit" tab doesn't run: T190989: On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors.
Thu, Apr 11, 10:24 PM · VisualEditor-MediaWiki, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a parent task for T190765: Refreshing a source page in the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled): T190989: On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors.
Thu, Apr 11, 10:24 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a comment to T190989: On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors.

Nevertheless, here's the below screenshot of what I described while enabling the new wikitext editor when I clicked the "Edit" button (via local gadget), which then becomes "edit source":

Thu, Apr 11, 10:23 PM · MinervaNeue (Desktop), VisualEditor, MediaWiki-Page-editing
matmarex added a comment to T220042: Visual editor (source editing mode) should always present edit summary box before saving.

Also related: T148297: Provide simultaneous access to diff preview and edit summary (perhaps actually an exact duplicate)

Thu, Apr 11, 9:39 PM · VisualEditor
matmarex added a comment to T220042: Visual editor (source editing mode) should always present edit summary box before saving.

Related: T52961: VisualEditor: Provide simultaneous access to editor and edit summary

Thu, Apr 11, 9:38 PM · VisualEditor

Wed, Apr 10

matmarex added a comment to T217217: Visual editor and 2017 wikitext editor mishandle cascading protection.

Note that there is an error message:

Wed, Apr 10, 10:35 PM · Editing-team, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-Page-protection
matmarex added a comment to T219848: MobileFrontEnd detects wrong protection level, causing the edit workflow to dead end.

I'm guessing this is a bug for VisualEditor project but let me know if that's not the case.

Wed, Apr 10, 10:32 PM · Readers-Web-Backlog (Tracking), VisualEditor, MediaWiki-Page-protection, MobileFrontend
matmarex added a comment to T191823: No toolbar on mobile views using Firefox and Chromium.

These are the interfaces you should see (when using any edit link):

Wed, Apr 10, 10:12 PM · MobileFrontend, VisualEditor
matmarex added a comment to T190989: On the desktop site, editing the lead section of a page under MinervaNeue skin directs a user to one of desktop WikiEditors.

Nevertheless, after recently re-testing a page by using the MinervaNeue skin, the issue is already fixed (or nearly fixed). Well, if the 2017/Newer Wikitext beta editor is not enabled, the gadget (if enabled) and one of the pencil icons would result the same. Nevertheless, the word "edit" button would appear next to the article title.

Wed, Apr 10, 10:09 PM · MinervaNeue (Desktop), VisualEditor, MediaWiki-Page-editing
matmarex moved T219680: Diff view goes empty while switching back Visual diff to wikitext diff from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Wed, Apr 10, 8:56 PM · Verified, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex claimed T219680: Diff view goes empty while switching back Visual diff to wikitext diff.
Wed, Apr 10, 8:37 PM · Verified, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Wed, Apr 10, 7:52 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex claimed T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML.
Wed, Apr 10, 7:22 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T219627: Sometimes an ISBN turns up wrapped in nowiki-tags.

I argued for this to be put in "Needs Discussion/Analysis" rather than "Freezer", but on a closer look, I agree with Ed – I'm not sure if this case is worth investigating. I think what I really wanted to discuss was T162291 (nowiki around ISBN caused by copy-paste of large blocks, e.g. copying citations from read mode).

Wed, Apr 10, 6:21 PM · VisualEditor, Citoid
matmarex added a comment to T220481: Reenable l10update in production.

Note also T158360 which proposes that LocalisationUpdate should be undeployed.

Wed, Apr 10, 5:40 PM · Release-Engineering-Team, Security, MediaWiki-extensions-LocalisationUpdate
matmarex updated the task description for T220629: Right click to delete across paragraphs in Firefox results in no model transaction.
Wed, Apr 10, 4:32 PM · VisualEditor, VisualEditor-ContentEditable

Tue, Apr 9

matmarex added parent tasks for T145604: [RfC] Future of magic links: T162291: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text, T219627: Sometimes an ISBN turns up wrapped in nowiki-tags.
Tue, Apr 9, 8:21 PM · MediaWiki-Parser, TechCom-RFC
matmarex added a subtask for T162291: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text: T145604: [RfC] Future of magic links.
Tue, Apr 9, 8:20 PM · VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki
matmarex added a subtask for T219627: Sometimes an ISBN turns up wrapped in nowiki-tags: T145604: [RfC] Future of magic links.
Tue, Apr 9, 8:20 PM · VisualEditor, Citoid
matmarex merged T217187: VisualEditor adds nowiki-tags around ISBNs into T162291: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text.
Tue, Apr 9, 8:19 PM · VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki
matmarex merged task T217187: VisualEditor adds nowiki-tags around ISBNs into T162291: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text.
Tue, Apr 9, 8:19 PM · VisualEditor
matmarex added a comment to T192049: Tools column responsiveness with VE Context tools minimum width .

This should no longer be a problem after T188823, which allowed the context item labels to wrap.

Tue, Apr 9, 7:10 PM · Language-Team (Language-2019-April-June), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor, Design, ContentTranslation
matmarex added a comment to T104540: Reference list <div> can overlap a template <div> because that's how HTML works.

This task had recent discussion.

Tue, Apr 9, 7:03 PM · Wikimedia-Hackathon-2018, VisualEditor, VisualEditor-ContentEditable
matmarex renamed T214543: Recovery of edits after a crash not working in some cases from Feature: Recovery of edits after a crash to Recovery of edits after a crash not working in some cases.
Tue, Apr 9, 5:43 PM · VisualEditor
matmarex added a comment to T220154: Leading spaces can be hard to see.

I don't think there is anything we could do to improve this?

Tue, Apr 9, 5:40 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a comment to T220264: VisualEditor: RTL typing is not working in Urdu.

I can reproduce this issue even when typing Latin characters with input methods disabled!

Tue, Apr 9, 5:29 PM · VisualEditor-InterfaceLanguage, VisualEditor-ContentLanguage, VisualEditor
matmarex added a comment to T220152: Adding a new line causes the next to be struck out.

Per @Schnark I think this is the expected behavior.

Tue, Apr 9, 4:50 PM · VisualEditor, VisualEditor-VisualDiffs
matmarex added a comment to T220319: Do not let the visual mode break tables.

The problematic edit that started these problems is this one which introduced a HTML table row which eventually led to these series of issues. Not sure what caused HTML to be introduced there. My guess is that it was a copy-paste that caused it to serialize as HTML.

(…)

Tue, Apr 9, 4:32 PM · Parsoid-Edit-Support, VisualEditor-Tables, VisualEditor
matmarex merged task T52395: VisualEditor: Phantoms can be width:100% when the object they're meant to cover has a floated element alongside it into T104540: Reference list <div> can overlap a template <div> because that's how HTML works.
Tue, Apr 9, 4:22 PM · VisualEditor, VisualEditor-ContentEditable
matmarex merged T52395: VisualEditor: Phantoms can be width:100% when the object they're meant to cover has a floated element alongside it into T104540: Reference list <div> can overlap a template <div> because that's how HTML works.
Tue, Apr 9, 4:21 PM · Wikimedia-Hackathon-2018, VisualEditor, VisualEditor-ContentEditable
matmarex added a comment to T103635: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead.

(More context in the Parsoid subtask: T95850#5078918)

Tue, Apr 9, 3:38 PM · VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T218436: Differences between read mode and edit mode on mobile: inconsistent underlines under top-level heading.

No, the underlines come from Minerva (or MobileFrontend) styles related to your section collapsing feature.

Tue, Apr 9, 3:34 PM · Readers-Web-Backlog (Tracking), MinervaNeue, VisualEditor
matmarex moved T209162: [Regression] Blockquotes can't be edited, because they're alienated content from In progress to Code review on the VisualEditor (Current work) board.
Tue, Apr 9, 11:47 AM · VisualEditor (Current work)
matmarex moved T208826: Toolbar and toolbar dialogs (e.g. special characters tray) unexpectedly become disabled after clicking on page title from Code review to QA on the VisualEditor (Current work) board.
Tue, Apr 9, 11:46 AM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)
matmarex moved T219813: VE article editor should never have a NullSelection from Code review to Product owner review on the VisualEditor (Current work) board.
Tue, Apr 9, 11:46 AM · Patch-For-Review, VisualEditor (Current work)
matmarex moved T109508: Mobile VE: Consider providing a visible or larger area for CE when editing an empty page/creating a new page from Code review to QA on the VisualEditor (Current work) board.
Tue, Apr 9, 11:46 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
matmarex moved T219200: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE from Code review to QA on the VisualEditor (Current work) board.
Tue, Apr 9, 11:46 AM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a comment to T219200: [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE.

When can we have the fix for it on Beta cluster?

Tue, Apr 9, 11:45 AM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mon, Apr 8

matmarex moved T220158: Avoid wgVisualEditorToolbarScrollOffset data export on page views from Ready for Pick Up to Product owner review on the VisualEditor (Current work) board.
Mon, Apr 8, 8:45 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor-MediaWiki
matmarex edited projects for T220158: Avoid wgVisualEditorToolbarScrollOffset data export on page views, added: VisualEditor (Current work); removed VisualEditor.
Mon, Apr 8, 8:44 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor-MediaWiki
matmarex updated subscribers of T220239: Unable to interact with ButtonSelectWidget using keyboard.

At a glance, this might be caused by rGOJUcfaea5347d69: SelectWidget: Allow multiselect mode, add to MenuTagMultiselectWidget.

Mon, Apr 8, 8:41 PM · Regression, Accessibility, OOUI

Fri, Apr 5

Mill <mill@mail.com> committed rECOS584586d0658f: 33baaaaaaaaaaa (authored by matmarex).
33baaaaaaaaaaa
Fri, Apr 5, 10:42 PM

Thu, Apr 4

matmarex moved T219829: De-activated selections should be visually distinct from Code review to Product owner review on the VisualEditor (Current work) board.
Thu, Apr 4, 8:26 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work)
matmarex added a comment to T219813: VE article editor should never have a NullSelection.

I think https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/500757 is also necessary to complete this fix?

Thu, Apr 4, 8:26 PM · Patch-For-Review, VisualEditor (Current work)
matmarex moved T76426: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are from In progress to Code review on the VisualEditor (Current work) board.
Thu, Apr 4, 7:41 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools
matmarex added a comment to T76426: Blockquotes aren't ContentBranchNodes in reality, and our code shouldn't try to insist that they are.

The patches now only resolve the technical issue of multi-paragraph blockquotes not being editable. I'll file a separate task to consider the toolbar changes later.

Thu, Apr 4, 7:12 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools
matmarex moved T206357: Self-XSS in VisualEditor link context menu from Code review to Product owner review on the VisualEditor (Current work) board.
Thu, Apr 4, 4:31 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work), Security

Wed, Apr 3

matmarex moved T107745: Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities from Code review to QA on the VisualEditor (Current work) board.
Wed, Apr 3, 9:44 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work), VisualEditor-ContentEditable
matmarex renamed T219949: PopupButtonWidgets should have real popups in PHP, not only "title" tooltips from Popups stopped working in PHP to PopupButtonWidgets should have real popups in PHP, not only "title" tooltips.
Wed, Apr 3, 7:46 PM · OOUI
matmarex moved T206357: Self-XSS in VisualEditor link context menu from Engineering QA to Code review on the VisualEditor (Current work) board.

This is the followup/hardening change I proposed here earlier.

Wed, Apr 3, 7:41 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work), Security
matmarex awarded T193731: CheckboxMultiSelect- & RadioSelectWidget changes vertical spacing when infused a Party Time token.
Wed, Apr 3, 7:21 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), OOUI (OOUI-0.31.3)
matmarex moved T219916: Deactivated selection out of position when window resized from Code review to Product owner review on the VisualEditor (Current work) board.
Wed, Apr 3, 6:03 PM · VisualEditor-ContentEditable, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)
matmarex added a comment to T219949: PopupButtonWidgets should have real popups in PHP, not only "title" tooltips.

What popups?

Wed, Apr 3, 2:47 AM · OOUI

Tue, Apr 2

matmarex added a comment to T97891: setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector.

This has been effectively reverted in Vector in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/500805 as a result of T219864.

Tue, Apr 2, 7:35 PM · User-notice, Patch-For-Review, Vector, Wikidata, Readers-Web-Backlog
matmarex moved T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it (converting a re-used basic reference to template citation) from Code review to In progress on the VisualEditor (Current work) board.

The main patch for this change (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/483337) is not merged yet, so none of the UI changes described above have happened.

Tue, Apr 2, 7:25 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-References
matmarex moved T219562: VE doesn't let you enable it in namespaces whose labels happen to be ints from Code review to Product owner review on the VisualEditor (Current work) board.
Tue, Apr 2, 7:23 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex moved T219916: Deactivated selection out of position when window resized from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Tue, Apr 2, 7:22 PM · VisualEditor-ContentEditable, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)
matmarex moved T103635: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead from Freezer to To Triage on the VisualEditor board.
Tue, Apr 2, 7:17 PM · VisualEditor-MediaWiki, VisualEditor
matmarex added a parent task for T95850: Parsoid does not escape language prefixes in internal link hrefs, causing html2html round-trip failures: T103635: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead.
Tue, Apr 2, 7:16 PM · Parsoid, VisualEditor
matmarex added a subtask for T103635: Stop the user from adding a langlink when we think they wanted to insert an interwiki instead: T95850: Parsoid does not escape language prefixes in internal link hrefs, causing html2html round-trip failures.
Tue, Apr 2, 7:16 PM · VisualEditor-MediaWiki, VisualEditor
matmarex updated subscribers of T95850: Parsoid does not escape language prefixes in internal link hrefs, causing html2html round-trip failures.

I actually kept digging a bit more. I blamed these lines to find where they came from.

Tue, Apr 2, 7:15 PM · Parsoid, VisualEditor