matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (157 w, 2 h)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Today

matmarex added a comment to T178568: [Investigate] Should some OOUI-icons be different on ar-wiki?.

Perhaps we should entirely remove the "info" icon, since the current symbol is indeed quite language-specific? We already have the "help" and "alert" icons (represented by a question mark and an exclamation mark), which are a lot more language-neutral, and which could probably replace it in most cases. A "hint" icon represented by the lightbulb could maybe be added, or perhaps a "guide" represented by a book or something.

Fri, Oct 20, 3:16 PM · Design, TCB-Team, WMDE-Design, OOjs-UI, Advanced-Search
matmarex added a comment to T153315: Pasting annotated wikitext results in double encoding and therefore <nowiki>s.

I still think that the new wikitext editor should not try to handle formatted pastes at all. At least, "paste as plain text" should be the default, like in every code editor in existence ever.

Fri, Oct 20, 1:06 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Yesterday

matmarex added a comment to T178159: Enforce section name when editing a section.

This definitely needs to be taken into consideration. Perhaps your use cuse breaks my entire proposal.

Thu, Oct 19, 10:30 PM · MediaWiki-Page-editing
matmarex added a comment to T178437: Make icon/indicator visibility handling several widget nesting levels proof.

I tried doing the revert today and it seems that T161177 is actually still fixed if we revert those.

Thu, Oct 19, 7:28 PM · Patch-For-Review, Regression, OOjs-UI
matmarex reopened T178456: Small unclickable gap between checkbox and label as "Open".

Actually, the fix caused another issue: T178612: The label of FieldLayout aligned inline is misaligned when it has to be wrapped over multiple lines. For now I'm reverting it (https://gerrit.wikimedia.org/r/#/c/385226/); I'll look into this more carefully later.

Thu, Oct 19, 7:09 PM · OOjs-UI
matmarex created T178612: The label of FieldLayout aligned inline is misaligned when it has to be wrapped over multiple lines.
Thu, Oct 19, 7:07 PM · Patch-For-Review, Regression, OOjs-UI
matmarex closed T177529: Replace deprecated PHP `multiline` option by MultilineTextInputWidget and remove from codebase in JS & PHP as Resolved.
Thu, Oct 19, 6:34 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), OOjs-UI (OOjs-UI-0.24.1), ProofreadPage, MediaWiki-General-or-Unknown, Wikimedia-log-errors, Technical-Debt
matmarex closed T177529: Replace deprecated PHP `multiline` option by MultilineTextInputWidget and remove from codebase in JS & PHP, a subtask of T130434: Break up TextInputWidget, as Resolved.
Thu, Oct 19, 6:34 PM · Technical-Debt, OOjs-UI
matmarex added a comment to T178595: Rcfilters broke recent changes and watchlist grouping mode css.

Probably caused by rMW15adf03cba71: Fix changes list misaligned arrow. That was means to fix T176368: [minor-wmf.19] Watchlist 'Grouped by page' arrow should be aligned vertically though. Can you post screenshots of what exactly looks wrong?

Thu, Oct 19, 6:31 PM · Patch-For-Review, Regression, MediaWiki-Special-pages, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage, CSS
matmarex updated the task description for T178574: VE help popup broken when toolbar is in narrow mode (<~900px).
Thu, Oct 19, 6:28 PM · Patch-For-Review, Regression, OOjs-UI, VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T178574: VE help popup broken when toolbar is in narrow mode (<~900px).

This is difficult to work around in VE. Since this is fairly minor breakage, I suggest we just wait for the next OOjs UI release with the fix.

Thu, Oct 19, 6:25 PM · Patch-For-Review, Regression, OOjs-UI, VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T178574: VE help popup broken when toolbar is in narrow mode (<~900px).

The issue was actually introduced in https://gerrit.wikimedia.org/r/#/c/381800/ (rGOJU7d6258a7043e: WikimediaUI theme: Simplify action toolbar buttons selectors), not 380546. I think we can safely revert that one. (Honestly we should stop trying to "simplify" > selectors. We previously did the same thing with rGOJUed185afb9167: ButtonElement: Decrease selector specificity, which was reverted before causing issues.)

Thu, Oct 19, 5:56 PM · Patch-For-Review, Regression, OOjs-UI, VisualEditor-MediaWiki, VisualEditor
matmarex added a project to T177529: Replace deprecated PHP `multiline` option by MultilineTextInputWidget and remove from codebase in JS & PHP: Wikimedia-log-errors.

@demon was grumbling about log spam, coming probably from this.

Thu, Oct 19, 5:47 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), OOjs-UI (OOjs-UI-0.24.1), ProofreadPage, MediaWiki-General-or-Unknown, Wikimedia-log-errors, Technical-Debt
matmarex added a comment to T178568: [Investigate] Should some OOUI-icons be different on ar-wiki?.

A second issue raised was that the questions mark icon is sometimes turned around and sometimes isn't. Is that something mediawiki-related or do the developers need to manually set a direction for the icon? Since there are many inconsistencies on ar-wiki I assume the latter although I really hope I'm wrong and it's just some weird bug.

The "help" icon (see https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons for the whole list) is horizontally flipped in rtl languages except he and yi, yes.

Thu, Oct 19, 4:59 PM · Design, TCB-Team, WMDE-Design, OOjs-UI, Advanced-Search

Wed, Oct 18

matmarex added a comment to T178437: Make icon/indicator visibility handling several widget nesting levels proof.

The display handling is the only concern, and that's what's causing this issue. But I don't suppose we can just delete that block and be done with it? The other styles probably already assume that .oo-ui-iconElement-icon will be hidden if there is no icon.

Wed, Oct 18, 9:06 PM · Patch-For-Review, Regression, OOjs-UI
matmarex added a comment to T178437: Make icon/indicator visibility handling several widget nesting levels proof.

I've been thinking really hard about this and I'm convinced that the easiest course of action is to revert .oo-ui-iconElement/.oo-ui-indicatorElement styling to how it was in OOjs UI v0.23.3, that is, to revert commits 8e31b2f2, 6604d0f2 and e92c5f0f. This will fix this issue and return us to a known good (if imperfect) state.

Wed, Oct 18, 8:35 PM · Patch-For-Review, Regression, OOjs-UI
matmarex added a comment to T178424: Absolute positioned icons makes wide+centred buttons hard to make.

Absolute positioning for ButtonElement icons/indicators seems to have been added in rGOJU99361c772c65: MediaWiki theme: Unify `padding` on ButtonElement (2017-04-06), only for the WikimediaUI theme (not Apex).

Wed, Oct 18, 8:27 PM · OOjs-UI
matmarex claimed T178439: [1.31.0-wmf.4 regression] Special:Notification page misplaces icons.
Wed, Oct 18, 6:55 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Notifications, Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2017), Regression
matmarex added a project to T178439: [1.31.0-wmf.4 regression] Special:Notification page misplaces icons: Notifications.
Wed, Oct 18, 6:20 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Notifications, Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2017), Regression
matmarex renamed T160593: Streamline IconElement/IndicatorElement visibility (set 'display: none' on them in a generic way when they are not used) from Streamline IconElement/IndicatorElement handling to Streamline IconElement/IndicatorElement visibility (set 'display: none' on them in a generic way when they are not used).
Wed, Oct 18, 6:17 PM · Patch-For-Review, OOjs-UI (OOjs-UI-0.23.4), UI-Standardization-Kanban, UI-Standardization
matmarex added a comment to T178384: Remove 'hideWhenOutOfView' feature of FloatableElement.

See T129521 examples of the results that never hiding dropdowns produces. This specifically:

Wed, Oct 18, 4:57 PM · OOjs-UI
matmarex added a comment to T178384: Remove 'hideWhenOutOfView' feature of FloatableElement.

The linked commit actually implemented a way to disable this behavior. The behavior was implemented in c449fe11c99f5fdcc2f100b18f7f95787e5fd442 for T129521.

Wed, Oct 18, 4:56 PM · OOjs-UI
matmarex added a comment to T178456: Small unclickable gap between checkbox and label.

For context, the light green area previously was not clickable and will be clickable now:

Wed, Oct 18, 4:42 PM · OOjs-UI
matmarex claimed T178456: Small unclickable gap between checkbox and label.
Wed, Oct 18, 4:31 PM · OOjs-UI

Tue, Oct 17

matmarex added a parent task for T118413: Wikimedia wikis should use https:// in $wgServer: T178357: Don't use protocol relative links to Commons in MultimediaViewer.
Tue, Oct 17, 9:43 PM · Patch-For-Review, Wikimedia-Site-requests
matmarex added a subtask for T178357: Don't use protocol relative links to Commons in MultimediaViewer: T118413: Wikimedia wikis should use https:// in $wgServer.
Tue, Oct 17, 9:43 PM · Wikimedia-General-or-Unknown, Multimedia
matmarex renamed T178357: Don't use protocol relative links to Commons in MultimediaViewer from Don't use protocol relative links to Commons to Don't use protocol relative links to Commons in MultimediaViewer.
Tue, Oct 17, 9:43 PM · Wikimedia-General-or-Unknown, Multimedia
matmarex removed a project from T178437: Make icon/indicator visibility handling several widget nesting levels proof: Patch-For-Review.

After the rewrite of how icons and indicators are styled (between v0.23.3 and v0.24, changes 8e31b2f2, 6604d0f2, e92c5f0f) widgets that mix in IconElement or IndicatorElement render incorrectly when nested (in the resulting DOM) three or more levels deep.

Tue, Oct 17, 9:25 PM · Patch-For-Review, Regression, OOjs-UI
matmarex added a comment to T178357: Don't use protocol relative links to Commons in MultimediaViewer.

So, the root cause here is that $wgServer on Commons is set to "//commons.wikimedia.org" while arguably it should be "https://commons.wikimedia.org".

Tue, Oct 17, 9:10 PM · Wikimedia-General-or-Unknown, Multimedia
matmarex edited projects for T178357: Don't use protocol relative links to Commons in MultimediaViewer, added: CommonsMetadata; removed MediaWiki-extensions-MultimediaViewer.

Looks like MultimediaViewer simply gets this data from the API and displays it as-is:

Tue, Oct 17, 8:39 PM · Wikimedia-General-or-Unknown, Multimedia
matmarex added a project to T178320: Make it possible to choose and copy text inside notices on visual editor: OOjs-UI.
Tue, Oct 17, 8:12 PM · User-Ryasmeen, OOjs-UI (OOjs-UI-0.24.0), VisualEditor
matmarex claimed T178320: Make it possible to choose and copy text inside notices on visual editor.
Tue, Oct 17, 8:05 PM · User-Ryasmeen, OOjs-UI (OOjs-UI-0.24.0), VisualEditor
matmarex added a comment to T178415: [Regression pre-wmf.4] A solid black icon appearing over an image after selecting it inside the Media Settings dialog .

This will need to be backported to 1.31.0-wmf.4.

Tue, Oct 17, 6:00 PM · Verified-in-Phase0, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Verified, User-Ryasmeen, VisualEditor
matmarex added a comment to T178415: [Regression pre-wmf.4] A solid black icon appearing over an image after selecting it inside the Media Settings dialog .

The "solid black icon" is a result of overlaying all the grey icons normally shown in the dialog on top of each other:

Tue, Oct 17, 5:57 PM · Verified-in-Phase0, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Verified, User-Ryasmeen, VisualEditor
matmarex claimed T178415: [Regression pre-wmf.4] A solid black icon appearing over an image after selecting it inside the Media Settings dialog .
Tue, Oct 17, 5:52 PM · Verified-in-Phase0, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Verified, User-Ryasmeen, VisualEditor
matmarex closed T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly as Resolved.
Tue, Oct 17, 2:46 PM · Regression, OOjs-UI
matmarex closed T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly, a subtask of T178388: Settings popup broken in Apex, as Resolved.
Tue, Oct 17, 2:46 PM · Regression, Collaboration-Team-Triage, Notifications
matmarex closed T178251: Apex: Invisible indicator adding right padding as Resolved.
Tue, Oct 17, 2:45 PM · Regression, OOjs-UI
matmarex removed a project from T178388: Settings popup broken in Apex: OOjs-UI.
Tue, Oct 17, 2:10 PM · Regression, Collaboration-Team-Triage, Notifications
matmarex added a subtask for T178388: Settings popup broken in Apex: T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly.
Tue, Oct 17, 2:10 PM · Regression, Collaboration-Team-Triage, Notifications
matmarex added a parent task for T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly: T178388: Settings popup broken in Apex.
Tue, Oct 17, 2:10 PM · Regression, OOjs-UI
matmarex added a comment to T178388: Settings popup broken in Apex.

Same issue as T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly (except with indicators instead of icons). The patch in OOUI there should fix it. You could also do a workaround in Echo like we did in VE with https://gerrit.wikimedia.org/r/384607, but the issue here is less glaring.

Tue, Oct 17, 2:10 PM · Regression, Collaboration-Team-Triage, Notifications
TheDJ awarded T171389: <citation> elements treated as divs instead of inline elements a Like token.
Tue, Oct 17, 6:18 AM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Regression, MediaWiki-Parser, CiteThisPage

Mon, Oct 16

matmarex added a comment to T178324: VE's context menus are badly broken in beta.

Might be, although the description there doesn't mention this specific issue. The patch there might apply to it too though. I filed T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly.

Mon, Oct 16, 8:36 PM · Verified-in-Phase0, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Verified, User-Ryasmeen, VisualEditor-EditingTools, OOjs-UI, VisualEditor
matmarex created T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly.
Mon, Oct 16, 8:35 PM · Regression, OOjs-UI
matmarex added a comment to T178324: VE's context menus are badly broken in beta.

That actually looks like a distinct issue, and a bug in OOjs UI itself rather than an interaction with our CSS. I'll file a separate task.

Mon, Oct 16, 8:27 PM · Verified-in-Phase0, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Verified, User-Ryasmeen, VisualEditor-EditingTools, OOjs-UI, VisualEditor
matmarex claimed T178324: VE's context menus are badly broken in beta.
Mon, Oct 16, 7:01 PM · Verified-in-Phase0, MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Verified, User-Ryasmeen, VisualEditor-EditingTools, OOjs-UI, VisualEditor
matmarex removed a project from T178179: MediaWiki:Edittools is broken on the French Wikiversity: CharInsert.
Mon, Oct 16, 5:23 PM · Wikimedia-Site-requests
matmarex closed T178179: MediaWiki:Edittools is broken on the French Wikiversity as Resolved.

I made this edit: https://fr.wikiversity.org/w/index.php?title=MediaWiki:Common.js&diff=prev&oldid=692871

Mon, Oct 16, 5:23 PM · Wikimedia-Site-requests
matmarex added a comment to T178179: MediaWiki:Edittools is broken on the French Wikiversity.

I suspect that on-wiki code which generates the pretty dropdown ends up somehow removing event handlers belonging to the CharInsert extension from the links, making them do nothing. (It's surprisingly easy to do.) It might not occur in debug mode or in other browsers depending on the order in which the two are executed (if dropdown generation runs before CharInsert, it's okay, otherwise it's not).

Mon, Oct 16, 5:12 PM · Wikimedia-Site-requests

Fri, Oct 13

matmarex added a comment to T178193: Make NilsTycho maintainer of Extension:SoundManager2Button.

Wait a minute, I meant to post under this account. The phabricator/wikitech account is associated with a mediawiki account, but the gerrit account is separate, right?

Fri, Oct 13, 9:28 PM · Repository-Ownership-Requests
matmarex claimed T171389: <citation> elements treated as divs instead of inline elements.

Wow, the way CiteThisPage makes this tag work is actually insane.

Fri, Oct 13, 9:11 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Regression, MediaWiki-Parser, CiteThisPage
matmarex closed T176444: #jump-to-nav top margin is too big as Resolved.
Fri, Oct 13, 9:02 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), MediaWiki-Interface
matmarex closed T178120: RCFilters do not work on IE 11, Opera 12: "TypeError: Object doesn't support property or method 'endsWith'" as Resolved.
Fri, Oct 13, 7:13 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Browser-Support-Opera, Browser-Support-Internet-Explorer, Edit-Review-Improvements, Collaboration-Team-Triage, MediaWiki-Recent-changes
matmarex added a comment to T178159: Enforce section name when editing a section.

I often remove or edit the autogenerated section comment, e.g. when I am actually deleting the section, or inserting another section above it, or editing the last section in an article to tweak the navboxes.

Fri, Oct 13, 6:47 PM · MediaWiki-Page-editing
matmarex closed T177693: Don't store initialConfig on OO.ui.Element as Resolved.
Fri, Oct 13, 5:52 PM · OOjs-UI (OOjs-UI-0.23.4), Performance
matmarex added a comment to T178178: Can't get multiple lines in a Preformatted paragraph.

You can use Shift+Enter to insert a newline without splitting the preformatted section. This is definitely a poor behavior though.

Fri, Oct 13, 4:40 PM · VisualEditor
matmarex closed T169268: Limiting thanks for new users at pl.wikipedia as Resolved.
Fri, Oct 13, 12:05 AM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage
matmarex closed T169268: Limiting thanks for new users at pl.wikipedia, a subtask of T176174: Revert Thanks limit on pl.wp for new users, as Resolved.
Fri, Oct 13, 12:05 AM · Patch-For-Review, Anti-Harassment, Support-and-Safety, Wikimedia-Site-requests

Thu, Oct 12

matmarex claimed T178120: RCFilters do not work on IE 11, Opera 12: "TypeError: Object doesn't support property or method 'endsWith'".
Thu, Oct 12, 10:15 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Browser-Support-Opera, Browser-Support-Internet-Explorer, Edit-Review-Improvements, Collaboration-Team-Triage, MediaWiki-Recent-changes
matmarex created T178120: RCFilters do not work on IE 11, Opera 12: "TypeError: Object doesn't support property or method 'endsWith'".
Thu, Oct 12, 10:14 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Browser-Support-Opera, Browser-Support-Internet-Explorer, Edit-Review-Improvements, Collaboration-Team-Triage, MediaWiki-Recent-changes
matmarex added a comment to T178118: SkinFallback guess skin keys from skin name.

(And yes, this duplication sucks and it would be great to avoid it. It actually looks very doable to make the installer methods public and make the fallback skin use them, if you'd like to work on that.)

Thu, Oct 12, 10:03 PM · MediaWiki-General-or-Unknown, Patch-For-Review, MediaWiki-Installer
matmarex added a comment to T178118: SkinFallback guess skin keys from skin name.

This feature is apparently implemented in two places:

  • For the installer, it's in Installer::findExtensions() and LocalSettingsGenerator::getText().
  • For the fallback skin, it's in SkinFallbackTemplate::findInstalledSkins() and getSnippetForSkin().
Thu, Oct 12, 10:00 PM · MediaWiki-General-or-Unknown, Patch-For-Review, MediaWiki-Installer
matmarex added a comment to T177705: REGRESSION - Option to suppress user accounts on blocks (hideuser) disappeared after migrating to OOjs UI.

I think there has never been a bug here. I remember specifically testing this when working on the patch and it worked correctly. Now we've done exactly nothing to resolve this and it magically fixes itself?

Thu, Oct 12, 9:16 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Regression, Stewards-and-global-tools, MediaWiki-User-management
matmarex closed T22210: Typeahead search drop-down suggestions for special page parameters as Resolved.

Actually, this has already been implemented for many pages, by @Umherirrender and @PiRSquared17. For example, the change for Special:WhatLinksHere was rMW078ae9dbf5aa: Add autocomplete for WhatLinksHere subpages.

Thu, Oct 12, 8:48 PM · Discovery, MediaWiki-Search
matmarex closed T22210: Typeahead search drop-down suggestions for special page parameters, a subtask of T50240: Implement autocompletion / search suggestion / auto-complete / autocomplete / auto-suggest throughout MediaWiki (tracking), as Resolved.
Thu, Oct 12, 8:48 PM · Tracking, MediaWiki-General-or-Unknown
matmarex closed T22210: Typeahead search drop-down suggestions for special page parameters, a subtask of T29411: Search Suggest bugs (tracking), as Resolved.
Thu, Oct 12, 8:48 PM · Tracking, MediaWiki-Search
matmarex added a comment to T169268: Limiting thanks for new users at pl.wikipedia.

This was recently discussed on pl.wp at https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#Wikinger_znowu_wszystkich_dyma.3F, I'll leave a comment there too when the change is deployed.

Thu, Oct 12, 8:26 PM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage
matmarex added a comment to T169268: Limiting thanks for new users at pl.wikipedia.

I scheduled the change for deployment today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20171012T2300

Thu, Oct 12, 8:17 PM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage
matmarex added a comment to T178100: OOUI\TextInputWidget and OOUI\IconElement define the same property ($iconName) in the composition of OOUI\MultilineTextInputWidget.

The issue is also visible in our demos if you run them using PHP 5.5, which normally no one does:

Thu, Oct 12, 7:17 PM · OOjs-UI (OOjs-UI-0.23.5)
matmarex created T178100: OOUI\TextInputWidget and OOUI\IconElement define the same property ($iconName) in the composition of OOUI\MultilineTextInputWidget.
Thu, Oct 12, 7:03 PM · OOjs-UI (OOjs-UI-0.23.5)

Wed, Oct 11

matmarex added a comment to M229: Refined WikimediaUI icons proposal.

Hmm, it seems we actually never use it at all, but that was my guess.

Wed, Oct 11, 5:16 PM · UI-Standardization, OOjs-UI
matmarex added an inline comment to M229: Refined WikimediaUI icons proposal.
Wed, Oct 11, 3:43 PM · UI-Standardization, OOjs-UI
matmarex added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

I've read older comments on this task again and it seems you pointed this out multiple times, and we apparently misunderstood you and thought the problem was with the edit summary field only rather than also its label. Sorry. The fix will be deployed to all wikis per the usual schedule next week (17-19 October).

Wed, Oct 11, 3:17 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor

Tue, Oct 10

matmarex added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

Huh, indeed. The font my system ends up using is narrow enough for the issue not to be visible on cs.wp, but I can reproduce locally after making the text long enough. (Note that the edit summary field's width is not limited; only the label's width is.) It's weird if this changed now, I'm pretty sure we've not changed anything relevant to this. Should be easy to fix though.

Tue, Oct 10, 11:47 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor
matmarex added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

I don't see the issue either. Can you take and upload another screenshot of what you're seeing now? Perhaps there's some subtle difference that would make the issue obvious to us.

Tue, Oct 10, 10:18 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor
Volker_E awarded T177846: mw.language.convertNumber() behavior for four-digit numbers incorrect for Polish a Love token.
Tue, Oct 10, 9:39 PM · Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2017), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, Edit-Review-Improvements, MediaWiki-General-or-Unknown, I18n
matmarex edited projects for T95105: Change period to comma in parser function results in Latvian Wikipedia, added: I18n; removed MediaWiki-Internationalization.
Tue, Oct 10, 3:40 PM · I18n, MediaWiki-extensions-ParserFunctions
matmarex closed T95105: Change period to comma in parser function results in Latvian Wikipedia as Declined.

As mentioned above, you can already get the desired result using formatnum:

Tue, Oct 10, 3:39 PM · I18n, MediaWiki-extensions-ParserFunctions
matmarex claimed T177846: mw.language.convertNumber() behavior for four-digit numbers incorrect for Polish.

The PHP code's behavior is apparently implemented by custom code in LanguagePl::commafy(). We don't have any such system in the JS code yet. It seems that the same code block is copy-pasted to a dozen other languages too. Perhaps there is a sensible way to generalize this.

Tue, Oct 10, 3:26 PM · Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2017), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, Edit-Review-Improvements, MediaWiki-General-or-Unknown, I18n
matmarex created T177846: mw.language.convertNumber() behavior for four-digit numbers incorrect for Polish.
Tue, Oct 10, 3:07 PM · Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2017), MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, Edit-Review-Improvements, MediaWiki-General-or-Unknown, I18n
matmarex added a comment to T169268: Limiting thanks for new users at pl.wikipedia.

I am not actively following the situation, but I believe we did that several times and got this person blacklisted in all major ISPs by now (although in some cases it took globally blocking all of the ISPs IP address space for a couple days before there was a reaction). Currently it seems he's using prepaid SIM cards (which can be bought anonymously) and editing via open proxies. Note that this has been going on since 2011 or so.

Tue, Oct 10, 1:25 PM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage

Mon, Oct 9

matmarex added a comment to T169268: Limiting thanks for new users at pl.wikipedia.

(Below is the query I used to get the numbers in last comment. Uncomment the various bits to query per-recipient vs general thanks, and blocked users vs not-blocked users.)

Mon, Oct 9, 4:34 PM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage
matmarex added a comment to T169268: Limiting thanks for new users at pl.wikipedia.

@TBolliger I appreciate that you're working on this but I honestly think we'd be just fine here with the simple solution of lowering the rate limit. And we probably should do that anyway while we discuss other options.

Mon, Oct 9, 4:31 PM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage
matmarex added a comment to T177673: User creation log, possible account-auto-creation spam.

They are not weird only because they come from other wiki or are in other language but by psychological meaning achieved by combination of words. I really suspect it got out of control because Wikipedia guidelines don't allow e.g. using real persons names without stating on that account user page that it is not the real person in question, and other rules (this guideline and related ones).

Mon, Oct 9, 3:39 PM · Wikimedia-General-or-Unknown
matmarex closed T176647: Help English Wikivoyage restrict certain file type uploads to address illicit file uploads as Resolved.
Mon, Oct 9, 1:29 PM · Community-Liaisons (Oct-Dec 2017), Wikimedia-Site-requests
matmarex added a comment to T169268: Limiting thanks for new users at pl.wikipedia.

For reference, since the limitation was lifted on 3 October, I see two cases of thanks spam in the public logs (there might be more if they were oversighted)

I think it's safe to say that the issue has not disappeared.

Mon, Oct 9, 12:55 PM · Anti-Harassment (AHT Sprint 7), User-Urbanecm, Wikimedia-Site-requests, Support-and-Safety, Collaboration-Team-Triage
matmarex added a comment to T170748: After checking the preview, the NWE appears one more plus (+) icon after the categories.

(Fix was applied by @Perhelion in https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-HotCat.js&diff=next&oldid=260137498.

Mon, Oct 9, 12:36 PM · Commons, Wikimedia-General-or-Unknown, User-Ryasmeen
matmarex edited projects for T170748: After checking the preview, the NWE appears one more plus (+) icon after the categories, added: Wikimedia-General-or-Unknown, Commons; removed VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor.
Mon, Oct 9, 12:36 PM · Commons, Wikimedia-General-or-Unknown, User-Ryasmeen
matmarex closed T151056: HotCat gadget does not handle multipage files well as Resolved.

It seems to work fine now. This was probably fixed by @Perhelion in https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-HotCat.js&diff=0&oldid=260137498.

Mon, Oct 9, 12:33 PM · Wikimedia-General-or-Unknown, Commons
matmarex closed T147197: load.php TypeError: span.firstChild.getAttribute (due to HotCat code) when navigating through a PDF's pages as Resolved.

I don't see the error anymore. This was probably fixed by @Perhelion in https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-HotCat.js&diff=0&oldid=260137498.

Mon, Oct 9, 12:32 PM · Commons, Wikimedia-General-or-Unknown

Sun, Oct 8

RandomDSdevel awarded T107036: Convert Special:Block and Special:Unblock to OOUI a Doubloon token.
Sun, Oct 8, 12:22 AM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), User-notice, UI-Standardization

Sat, Oct 7

matmarex added a comment to T172165: Bump PHP requirement to 7.0 in 1.32.
Sat, Oct 7, 1:07 AM · RfC, TechCom-RfC, MediaWiki-General-or-Unknown

Fri, Oct 6

matmarex added a comment to T177673: User creation log, possible account-auto-creation spam.

A user account is "created automatically" when a user currently logged in on any Wikimedia wiki visits a specific Wikimedia wikis for the first time. For example, a user who has registered an account on de.wikipedia.org (and is logged in there) visits en.wikipedia.org for the first time (e.g. by clicking an interwiki link). This often explains the weird name (the names of accounts that are "created automatically" are probably in a different language than the wiki content).

Fri, Oct 6, 11:28 PM · Wikimedia-General-or-Unknown
matmarex claimed T158934: Automatically change popup direction if there is no space.

This should be done not only for PopupWidget, but also for other dropdowny/popuppy things, e.g. DropdownWidget. (See comments on T107036)

Fri, Oct 6, 7:46 PM · Patch-For-Review, OOjs-UI
CKoerner_WMF awarded T176647: Help English Wikivoyage restrict certain file type uploads to address illicit file uploads a Goat token.
Fri, Oct 6, 6:05 PM · Community-Liaisons (Oct-Dec 2017), Wikimedia-Site-requests
matmarex added a comment to T176647: Help English Wikivoyage restrict certain file type uploads to address illicit file uploads.

I scheduled this change for deployment on Monday: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20171009T1300

Fri, Oct 6, 5:56 PM · Community-Liaisons (Oct-Dec 2017), Wikimedia-Site-requests
matmarex added a comment to T176647: Help English Wikivoyage restrict certain file type uploads to address illicit file uploads.

Unanimous agreement for the English Wikivoyage is documented here: https://en.wikivoyage.org/wiki/Wikivoyage_talk:Image_policy#Proposal_to_change_Special:Upload_page

Fri, Oct 6, 5:51 PM · Community-Liaisons (Oct-Dec 2017), Wikimedia-Site-requests
matmarex added a comment to T176647: Help English Wikivoyage restrict certain file type uploads to address illicit file uploads.

Documented below is how the list of allowed file types is generated. Turns out that my "messy" and "a little annoying" were understatements and the configuration is in fact completely insane. This list may not be exhaustive, some of the entries listed below may be duplicated somewhere else (duplicates in the list of allowed extensions are ignored).

Fri, Oct 6, 5:32 PM · Community-Liaisons (Oct-Dec 2017), Wikimedia-Site-requests
matmarex claimed T176647: Help English Wikivoyage restrict certain file type uploads to address illicit file uploads.

I'll figure out how to do it properly and do this one, so that it's easier for future deployers to change this setting for other wikis.

Fri, Oct 6, 4:30 PM · Community-Liaisons (Oct-Dec 2017), Wikimedia-Site-requests