Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (23)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (260 w, 3 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Today

matmarex created T235454: Text cursor (caret) is placed incorrectly when clicking on form input fields with padding (Chrome 77).
Mon, Oct 14, 10:26 PM · Browser-Support-Google-Chrome, MediaWiki-Interface
matmarex added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

With that patch VE will detect receiving invalid etags when querying RESTBase directly, and attempt querying RESTBase via the MediaWiki API instead. The API returns the etag as part of the normal payload instead of HTTP headers, which should prevent it from being messed with.

Mon, Oct 14, 9:16 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase
matmarex moved T233320: VisualEditor <-> RESTBase communication and ETags from Investigating to Code review on the VisualEditor (Current work) board.
Mon, Oct 14, 9:11 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase
matmarex added a project to T222217: When creating a "New section", the text for the body is not properly aligned with the rest of the page: Editing QA.

@Whatamidoing-WMF Can you check if it works for you now? (Try on https://en.wikipedia.beta.wmflabs.org/, it's not live on production wikis yet.)

Mon, Oct 14, 7:00 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T193253: VisualEditor should not add local "|link=https://..." links to file description when copying images from another page from Incoming to QA on the VisualEditor (Current work) board.
Mon, Oct 14, 6:58 PM · Editing QA, VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Parsoid-Edit-Support, VisualEditor-MediaWiki, VisualEditor-CopyPaste
matmarex edited projects for T193253: VisualEditor should not add local "|link=https://..." links to file description when copying images from another page, added: VisualEditor (Current work), Editing QA; removed VisualEditor.
Mon, Oct 14, 6:58 PM · Editing QA, VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Parsoid-Edit-Support, VisualEditor-MediaWiki, VisualEditor-CopyPaste
matmarex added a comment to T235315: Remove magic module loading of "mediawiki.messagePoster".

A similar pattern is used for 'mediawiki.ForeignApi', you might want to have a look at it too.

Mon, Oct 14, 6:46 PM · Patch-For-Review, MediaWiki-General, StructuredDiscussions, Growth-Team
matmarex added a comment to T233127: HTTP 404 error in VE possibly when confronted with an edit conflict.

@mobrovac I think I have some more questions…

Mon, Oct 14, 6:40 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), VisualEditor (Current work), BetaFeatures, Two-Column-Edit-Conflict-Merge, TCB-Team
matmarex updated subscribers of T234489: Problems with deleting/cutting/moving references in VisualEditor.

@Waddie96 @SerialNumber54129 I don't see this problem any more right now. I just tested on https://en.wikipedia.org/wiki/The_Fighting_Temeraire?veaction=edit and I was able to cut, paste or delete references, paragraphs, or even the entire article, and the editor was still responsive and the "Review your changes" dialog showed the expected results.

Mon, Oct 14, 4:41 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T235226: List editing buggy in VE when using templates as list entries.

I don't really understand T55368, but this sounds similar to T185093: Template transclusion of a few list items extends to the entire list in VE, making it impossible to edit visually to me. Maybe they're all the same.

Mon, Oct 14, 2:53 PM · VisualEditor
matmarex added a comment to T235319: Gray background FOUC on search icon.

There are actually two buttons in the search form: the normal button you always thought was there, and a fallback button that leads to the full-text search, which is only active in no-JS mode (and it gets removed by JS code). The second button doesn't have background-color: transparent set.

Mon, Oct 14, 2:49 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-Interface, Regression, Vector
matmarex moved T235323: Make the FG dataset pages tables editable in VE from To Triage to External and Administrivia on the VisualEditor board.
Mon, Oct 14, 2:23 PM · VisualEditor, User-Alicia_Fagerving_WMSE, User-Mrjohncummings

Fri, Oct 11

matmarex added a project to T235068: Pasting from LibreOffice calc into VE temporarily changes the font size of the whole page by adding a <style> tag to the paste target: Editing QA.
Fri, Oct 11, 12:48 AM · Editing QA, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), VisualEditor (Current work), VisualEditor-CopyPaste
matmarex moved T235068: Pasting from LibreOffice calc into VE temporarily changes the font size of the whole page by adding a <style> tag to the paste target from Code review to QA on the VisualEditor (Current work) board.
Fri, Oct 11, 12:47 AM · Editing QA, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), VisualEditor (Current work), VisualEditor-CopyPaste
matmarex added a project to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving: Editing QA.
Fri, Oct 11, 12:33 AM · Editing QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor (Current work), VisualEditor-MediaWiki-Links
matmarex added a project to T233628: Wrong hyperlink in link dialog in VisualEditor: Editing QA.
Fri, Oct 11, 12:33 AM · Editing QA, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)
matmarex added a project to T234108: Can't add cells in tables: Editing QA.
Fri, Oct 11, 12:33 AM · Editing QA, VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor-Tables
matmarex added a project to T234489: Problems with deleting/cutting/moving references in VisualEditor: Editing QA.
Fri, Oct 11, 12:33 AM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a project to T234881: TreeModifier: remover does not skip over a deleted node immediately following a text node: Editing QA.
Fri, Oct 11, 12:33 AM · Editing QA, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-ContentEditable
matmarex added a comment to T234680: After manually editing $separatorTransformTable in English translation, decimal separators for numbers have not changed.

Sorry, I have no idea.

Fri, Oct 11, 12:27 AM · MediaWiki-General
matmarex renamed T233101: Wikilinking a label with a HTML entities in it freezes the Visual Editor from Wikilinking a label with a 'prime' symbol in it freezes the Visual Editor to Wikilinking a label with a HTML entities in it freezes the Visual Editor.
Fri, Oct 11, 12:07 AM · VisualEditor (Current work)

Thu, Oct 10

matmarex added a comment to T215567: Split TreeModifier into a tree diff generator and tree diff applier.

Also:

Thu, Oct 10, 11:56 PM · VisualEditor (Current work), VisualEditor-DataModel
matmarex updated subscribers of T233101: Wikilinking a label with a HTML entities in it freezes the Visual Editor.

Never mind, I can reproduce it again. The issue occurs only if the entity is in the middle of the selected text (it works fine now if it's at the beginning or end), for example try selecting and linking 5′- somewhere on that page.

Thu, Oct 10, 11:55 PM · VisualEditor (Current work)
matmarex added a comment to T233101: Wikilinking a label with a HTML entities in it freezes the Visual Editor.

I remember I could reproduce this when I tried it soon after you filed this task (and determining that it was caused by using HTML entities in general, rather than the prime symbol), but now the issue no longer occurs.

Thu, Oct 10, 11:36 PM · VisualEditor (Current work)
matmarex added a comment to T185542: Undo doesn't work, if you switch to the visual mode.

To fix the original problem described in this task (losing the changed wikitext), I think we only need to make the modified = … variable in init.activateVe() here: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/2c243647d3258bdf7df9e20a59e0361146c92b7f/modules/ve-mw/preinit/ve.init.mw.DesktopArticleTarget.init.js#L876 also consider the page to be modified if undo/undoafter parameters are provided, and therefore preserve the contents of the edit field when switching.

Thu, Oct 10, 11:33 PM · VisualEditor
matmarex moved T234489: Problems with deleting/cutting/moving references in VisualEditor from Stalled/Waiting to QA on the VisualEditor (Current work) board.
Thu, Oct 10, 9:50 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

The second issue should also be resolved now.

Thu, Oct 10, 9:50 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

@Trizek-WMF The original issue (which should be resolved now) was that if you deleted, cut or moved a reference, the editor would stop responding to user actions.

Thu, Oct 10, 4:54 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a project to T234420: Months missing leading 0 (e.g. "2018-7") from citoid: Citoid.
Thu, Oct 10, 4:03 PM · Citoid, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Wed, Oct 9

matmarex moved T234404: Write a comment parser for PHP HTML from Ready for Development to In progress on the VisualEditor (Current work) board.

I wrote it!

Wed, Oct 9, 8:01 AM · Patch-For-Review, VisualEditor (Current work), Editing-team, OWC2020
matmarex added a comment to T234404: Write a comment parser for PHP HTML.

I only vaguely recall what it does, and only skimmed it now, but DiscussionParser can only detect a signature of the current user and the preceding section headings. We want to detect any signature, parse the user and time from it, guess the extent of the associated comment, and then guess the thread structure of the comments.

Wed, Oct 9, 7:47 AM · Patch-For-Review, VisualEditor (Current work), Editing-team, OWC2020
matmarex updated the task description for T234404: Write a comment parser for PHP HTML.
Wed, Oct 9, 7:42 AM · Patch-For-Review, VisualEditor (Current work), Editing-team, OWC2020

Tue, Oct 8

matmarex added a comment to T234982: Varying approaches to section names in edit summaries (mobile vs desktop and visual vs wikitext).

One more related task, about the same kind of issue in "new" wikitext editor:

Tue, Oct 8, 10:33 PM · WikiEditor, Contributors-Team, Section Editing, MobileFrontend, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, Editing Design, Mobile
matmarex added a comment to T233127: HTTP 404 error in VE possibly when confronted with an edit conflict.

Oh, and I also found some legit 404 cases, where pages were deleted, presumably because someone deleted the page while the user was editing it. E.g., for request with ID XZbZkQpAIDwAAAwda-YAAAAS RB returned:

{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/not_found#page_revisions","title":"Not found.","method":"get","detail":"Page was deleted","uri":"/en.wikipedia.org/v1/page/html/Dev_filmography/919164943"}

However, there were only 2 such cases in the last 24h. For that, it might be good for VE to inspect the response and emit an appropriate message to the client, but that's OT here.

Tue, Oct 8, 8:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), VisualEditor (Current work), BetaFeatures, Two-Column-Edit-Conflict-Merge, TCB-Team
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

(That problem is now filed as T234881)

Tue, Oct 8, 8:07 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex moved T234868: Mobile VE no longer restores section hash fragment after section editing from Incoming to Code review on the VisualEditor (Current work) board.
Tue, Oct 8, 6:53 PM · VisualEditor (Current work), Patch-For-Review, MinervaNeue, VisualEditor-MediaWiki
matmarex edited projects for T234868: Mobile VE no longer restores section hash fragment after section editing, added: VisualEditor (Current work); removed VisualEditor.
Tue, Oct 8, 6:53 PM · VisualEditor (Current work), Patch-For-Review, MinervaNeue, VisualEditor-MediaWiki
matmarex added a comment to T234648: Sort out #Editing-Team vs #VisualEditor Phabricator project tags.

The VisualEditor (Current work) milestone should be archived and its open tasks transferred to the Editing-team workboard. Tasks that were under that milestone AND are about VisualEditor should get the VisualEditor tag re-added if needed. (Note to myself: Tasks on that workboard about the VisualEditor codebase seem to have one of the VisualEditor-$something project tags (for the list of project tags, see https://phabricator.wikimedia.org/project/query/2IC.z8Qoz9uo/#R except for Mobile listed there) and Herald via H10 automatically adds VisualEditor to such tasks).

Tue, Oct 8, 3:25 PM · Developer-Advocacy (Oct-Dec 2019), Project-Admins
matmarex merged T234864: Automatically prepended section titles in edit summaries should be stripped of formatting into T229270: 2017WTE mishandles wiki markup in the section heading.
Tue, Oct 8, 12:10 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
matmarex merged task T234864: Automatically prepended section titles in edit summaries should be stripped of formatting into T229270: 2017WTE mishandles wiki markup in the section heading.
Tue, Oct 8, 12:10 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
matmarex updated the task description for T234868: Mobile VE no longer restores section hash fragment after section editing.
Tue, Oct 8, 12:08 AM · VisualEditor (Current work), Patch-For-Review, MinervaNeue, VisualEditor-MediaWiki
matmarex added a project to T234868: Mobile VE no longer restores section hash fragment after section editing: MinervaNeue.

When we save the page, we get the new page HTML from the action=parse API, and we search that HTML for the section number we used for editing (e.g. "9" in https://en.m.wikipedia.org/wiki/Frederick_Law_Olmsted#/editor/9) to get the section id (e.g. "U.S._park_designer" in https://en.m.wikipedia.org/wiki/Frederick_Law_Olmsted#U.S._park_designer).

Tue, Oct 8, 12:07 AM · VisualEditor (Current work), Patch-For-Review, MinervaNeue, VisualEditor-MediaWiki

Mon, Oct 7

matmarex closed T213120: Restore section hash fragment after section editing in mobile VE, a subtask of T209987: [Engineering EPIC]: Isolate Section Editing, as Resolved.
Mon, Oct 7, 11:59 PM · VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor
matmarex closed T213120: Restore section hash fragment after section editing in mobile VE as Resolved.

I think this is a new problem. We fixed this back in April, and it has only regressed recently. It'll be more convenient to investigate in a new task, so I filed one: T234868

Mon, Oct 7, 11:59 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex created T234868: Mobile VE no longer restores section hash fragment after section editing.
Mon, Oct 7, 11:58 PM · VisualEditor (Current work), Patch-For-Review, MinervaNeue, VisualEditor-MediaWiki
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

@Ryasmeen Beta might not have updated itself yet when you tested; it seems to be working right now for me.

Mon, Oct 7, 9:06 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T234680: After manually editing $separatorTransformTable in English translation, decimal separators for numbers have not changed.

I don't know, sorry. It might depend on your configuration, on my wiki I didn't even have to purge any caches, the change took effect immediately.

Mon, Oct 7, 8:22 PM · MediaWiki-General
matmarex moved T233628: Wrong hyperlink in link dialog in VisualEditor from Code review to QA on the VisualEditor (Current work) board.
Mon, Oct 7, 8:13 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

Curses, I'll have gone to the pub by then :) any idea what caused the problem(s) originally?

Mon, Oct 7, 7:02 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T215567: Split TreeModifier into a tree diff generator and tree diff applier.

Also T234742: TreeModifier: ensureNotText can return the wrong position.

Mon, Oct 7, 6:49 PM · VisualEditor (Current work), VisualEditor-DataModel
matmarex added a comment to T234742: TreeModifier: ensureNotText can return the wrong position.

(The problem also affected VE-MW, with wikitext like abc[[File:Example.jpg|20x20px]]def).

Mon, Oct 7, 6:49 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-DataModel
matmarex moved T234742: TreeModifier: ensureNotText can return the wrong position from Code review to QA on the VisualEditor (Current work) board.

This problem is now fixed on all Wikimedia wikis.

Mon, Oct 7, 6:48 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-DataModel
matmarex moved T234817: Template context menu doesn't appear in some cases from Code review to QA on the VisualEditor (Current work) board.

This problem is now fixed on all Wikimedia wikis.

Mon, Oct 7, 6:44 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T234489: Problems with deleting/cutting/moving references in VisualEditor from Code review to QA on the VisualEditor (Current work) board.

This problem is now fixed on all Wikimedia wikis.

Mon, Oct 7, 6:43 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T215567: Split TreeModifier into a tree diff generator and tree diff applier.

One more issue was caused by this change: T234489: Problems with deleting/cutting/moving references in VisualEditor.

Mon, Oct 7, 4:49 PM · VisualEditor (Current work), VisualEditor-DataModel
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

These are the backports for 1.34.0-wmf.25 (Wikimedia wikis version) and REL1_34 (upcoming stable MediaWiki release).

Mon, Oct 7, 4:47 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a comment to T232780: Write a client-side parser for signatures (username & timestamp).

Outside of the two scenarios mentioned above, are there any other edge cases you are aware of?

Mon, Oct 7, 3:24 PM · Patch-For-Review, OWC2020, VisualEditor (Current work)
matmarex added a comment to T234489: Problems with deleting/cutting/moving references in VisualEditor.

We'll deploy the fixes 3-4 hours from now (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20191007T1800).

Mon, Oct 7, 3:07 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex moved T234817: Template context menu doesn't appear in some cases from Incoming to Code review on the VisualEditor (Current work) board.
Mon, Oct 7, 12:57 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex added a comment to T234817: Template context menu doesn't appear in some cases.

This is a very similar bug to T167613 (caused by newlines in the template transclusion wikitext).

Mon, Oct 7, 12:47 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex claimed T234817: Template context menu doesn't appear in some cases.
Mon, Oct 7, 12:39 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex created T234817: Template context menu doesn't appear in some cases.
Mon, Oct 7, 12:31 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T234489: Problems with deleting/cutting/moving references in VisualEditor from Incoming to Code review on the VisualEditor (Current work) board.
Mon, Oct 7, 12:25 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex moved T234742: TreeModifier: ensureNotText can return the wrong position from Incoming to Code review on the VisualEditor (Current work) board.
Mon, Oct 7, 12:25 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-DataModel
matmarex merged T234579: Editor breaks when removing certain tables (TreeModifier error) into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:25 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex merged task T234579: Editor breaks when removing certain tables (TreeModifier error) into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:24 PM · VisualEditor
matmarex added a comment to T234680: After manually editing $separatorTransformTable in English translation, decimal separators for numbers have not changed.

It works for me. The localisation data is cached (https://www.mediawiki.org/wiki/Localisation#Caching) – try running the update.php maintenance script to purge the caches.

Mon, Oct 7, 12:22 PM · MediaWiki-General
matmarex added a project to T234489: Problems with deleting/cutting/moving references in VisualEditor: VisualEditor-DataModel.
Mon, Oct 7, 12:14 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex edited projects for T234742: TreeModifier: ensureNotText can return the wrong position, added: VisualEditor (Current work); removed VisualEditor.
Mon, Oct 7, 12:14 PM · Verified, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-DataModel
matmarex moved T234489: Problems with deleting/cutting/moving references in VisualEditor from To Triage to In current Tech/News draft on the User-notice board.
Mon, Oct 7, 12:10 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex triaged T234489: Problems with deleting/cutting/moving references in VisualEditor as Unbreak Now! priority.
Mon, Oct 7, 12:10 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex merged task T234423: Can't drag-and-drop text that includes a <ref> to rearrange into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · User-notice, Patch-For-Review, VisualEditor
matmarex merged task T233994: References disappear when dragging and dropping them using VisualEditor into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · Patch-For-Review, User-notice, Wikimedia-production-error, VisualEditor
matmarex merged task T234586: Citations are removed when they are dragged in VisualEditor into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · VisualEditor
matmarex merged task T234097: Error when trying to delete references on articles into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · Patch-For-Review, VisualEditor-MediaWiki-References, VisualEditor
matmarex merged task T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · Patch-For-Review, User-notice, VisualEditor, VisualEditor-ContentEditable
matmarex merged task T234244: Deleting a reference leaves you with a floating reference edit box that you can't dismiss into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · Patch-For-Review, VisualEditor
matmarex merged tasks T234244: Deleting a reference leaves you with a floating reference edit box that you can't dismiss, T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways, T234097: Error when trying to delete references on articles, T233994: References disappear when dragging and dropping them using VisualEditor, T234423: Can't drag-and-drop text that includes a <ref> to rearrange, T234586: Citations are removed when they are dragged in VisualEditor into T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex removed a parent task for T233994: References disappear when dragging and dropping them using VisualEditor: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:08 PM · Patch-For-Review, User-notice, Wikimedia-production-error, VisualEditor
matmarex removed a parent task for T234097: Error when trying to delete references on articles: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:07 PM · Patch-For-Review, VisualEditor-MediaWiki-References, VisualEditor
matmarex removed a parent task for T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:07 PM · Patch-For-Review, User-notice, VisualEditor, VisualEditor-ContentEditable
matmarex removed a parent task for T234244: Deleting a reference leaves you with a floating reference edit box that you can't dismiss: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:07 PM · Patch-For-Review, VisualEditor
matmarex removed a parent task for T234423: Can't drag-and-drop text that includes a <ref> to rearrange: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:07 PM · User-notice, Patch-For-Review, VisualEditor
matmarex removed subtasks for T234489: Problems with deleting/cutting/moving references in VisualEditor: T234586: Citations are removed when they are dragged in VisualEditor, T234423: Can't drag-and-drop text that includes a <ref> to rearrange, T233994: References disappear when dragging and dropping them using VisualEditor, T234097: Error when trying to delete references on articles, T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways, T234244: Deleting a reference leaves you with a floating reference edit box that you can't dismiss.
Mon, Oct 7, 12:07 PM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex removed a parent task for T234586: Citations are removed when they are dragged in VisualEditor: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 12:07 PM · VisualEditor
matmarex added a subtask for T234489: Problems with deleting/cutting/moving references in VisualEditor: T234586: Citations are removed when they are dragged in VisualEditor.
Mon, Oct 7, 11:57 AM · Editing QA, VisualEditor-DataModel, VisualEditor-MediaWiki-References, User-notice, VisualEditor (Current work)
matmarex added a parent task for T234586: Citations are removed when they are dragged in VisualEditor: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Mon, Oct 7, 11:56 AM · VisualEditor

Fri, Oct 4

matmarex merged task T234609: Jade unit test fails after api changes in SpamBlacklist into T232684: Update Jade for changes in AbuseFilter and SpamBlacklist API error responses.
Fri, Oct 4, 1:29 PM · SpamBlacklist, Jade, Wikimedia-production-error (Shared Build Failure), ci-test-error
matmarex merged T234609: Jade unit test fails after api changes in SpamBlacklist into T232684: Update Jade for changes in AbuseFilter and SpamBlacklist API error responses.
Fri, Oct 4, 1:29 PM · Patch-For-Review, Wikimedia-production-error (Shared Build Failure), ci-test-error, Jade

Thu, Oct 3

matmarex added a comment to T233628: Wrong hyperlink in link dialog in VisualEditor.

I added a fix for this case too to my patch.

Thu, Oct 3, 9:55 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)
matmarex added a comment to T232237: VE mobile default test buckets are unbalanced.

Engineering. (Note that it's still not merged, Krinkle had some concerns on the patch, and I just updated it.)

Thu, Oct 3, 9:05 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki-Mobile
matmarex added a comment to T231024: Some save success events do not contain a new revision ID.

We don't enable the "Publish" button until you make changes, but nothing stops you from publishing after typing and then deleting a space somewhere. That will result in a null edit.

Thu, Oct 3, 8:15 PM · VisualEditor, Product-Analytics
matmarex added a comment to T233127: HTTP 404 error in VE possibly when confronted with an edit conflict.

@mobrovac If you have the time to take a look, there are ~700 instances of a HTTP 404 response from RESTBase logged now: https://logstash.wikimedia.org/goto/4817263807e9f036af940cf848effc24. I apologize for the messy format (couldn't get structured logging to cooperate, see T234564), but the logs contain the URL we requested, the If-Match header we sent, and the response body.

Thu, Oct 3, 7:55 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), VisualEditor (Current work), BetaFeatures, Two-Column-Edit-Conflict-Merge, TCB-Team
matmarex updated the task description for T234564: Logstash discards messages from MediaWiki if they contain uncommon keys in the $context array.
Thu, Oct 3, 7:40 PM · Patch-For-Review, Wikimedia-production-error, Release-Engineering-Team, Performance-Team (Radar), Deployments, Wikimedia-Logstash, VisualEditor
matmarex moved T234564: Logstash discards messages from MediaWiki if they contain uncommon keys in the $context array from To Triage to External and Administrivia on the VisualEditor board.
Thu, Oct 3, 7:39 PM · Patch-For-Review, Wikimedia-production-error, Release-Engineering-Team, Performance-Team (Radar), Deployments, Wikimedia-Logstash, VisualEditor
matmarex created T234564: Logstash discards messages from MediaWiki if they contain uncommon keys in the $context array.
Thu, Oct 3, 7:39 PM · Patch-For-Review, Wikimedia-production-error, Release-Engineering-Team, Performance-Team (Radar), Deployments, Wikimedia-Logstash, VisualEditor

Wed, Oct 2

matmarex added a parent task for T233994: References disappear when dragging and dropping them using VisualEditor: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Wed, Oct 2, 10:38 PM · Patch-For-Review, User-notice, Wikimedia-production-error, VisualEditor
matmarex added a parent task for T234097: Error when trying to delete references on articles: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Wed, Oct 2, 10:38 PM · Patch-For-Review, VisualEditor-MediaWiki-References, VisualEditor
matmarex added a parent task for T234142: VE: Selecting/copying/deleting text that includes citation footnotes is broken in various ways: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Wed, Oct 2, 10:38 PM · Patch-For-Review, User-notice, VisualEditor, VisualEditor-ContentEditable
matmarex added a parent task for T234244: Deleting a reference leaves you with a floating reference edit box that you can't dismiss: T234489: Problems with deleting/cutting/moving references in VisualEditor.
Wed, Oct 2, 10:38 PM · Patch-For-Review, VisualEditor