matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (200 w, 22 h)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Yesterday

matmarex moved T198912: Clicking on focusable inside table cell can jump cursor to start of document from Code review to QA on the VisualEditor (Current work) board.
Fri, Aug 17, 10:10 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-ContentEditable
matmarex moved T201329: Mobile: Hide keyboard while menus are open from Code review to QA on the VisualEditor (Current work) board.
Fri, Aug 17, 10:09 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex closed T181854: Better handling of 'instruction text' on Preferences tabs for Recent Changes and Watchlist, a subtask of T117781: Convert Special:Preferences to OOUI, as Resolved.
Fri, Aug 17, 9:49 PM · Tech-Ambassadors, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-User-preferences, Front-end-Standards-Group, MediaWiki-Special-pages, Epic, UI-Standardization
matmarex closed T181854: Better handling of 'instruction text' on Preferences tabs for Recent Changes and Watchlist as Resolved.

I think this can be considered resolved with Ed's patch (see screenshots above).

Fri, Aug 17, 9:49 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-User-preferences, UI-Standardization
matmarex closed T202151: Avoid jquery.accessKeyLabel computation in addPortletLink() when possible as Resolved.
Fri, Aug 17, 9:35 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MediaWiki-Interface, Performance-Team
matmarex closed T202151: Avoid jquery.accessKeyLabel computation in addPortletLink() when possible, a subtask of T127328: Optimise critical rendering path, as Resolved.
Fri, Aug 17, 9:35 PM · Epic, Performance-Team
matmarex added a comment to T197179: Deprecate OOUI HTMLFormField "notices" in favor of "inline help".

Changes to Special:GlobalRenameRequest:

BeforeAfter
Fri, Aug 17, 9:27 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-HTMLForm
matmarex moved T109529: Cursor appears over the drop down menu for text styling in Mobile VisualEditor from Code review to QA on the VisualEditor (Current work) board.
Fri, Aug 17, 3:19 PM · VisualEditor (Current work), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki-Mobile
matmarex moved T201329: Mobile: Hide keyboard while menus are open from Code review to In progress on the VisualEditor (Current work) board.

(Copying from code review comment so it doesn't get lost)

Fri, Aug 17, 3:18 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a comment to T195053: Reduce page jumps in table of contents.

@MattFitzpatrick We discussed it earlier on the task: Windows Narrator with IE 11 will unfortunately read the show/hide button only as "Off; button" / "On; button". I don't know if more advanced screen readers can handle it better. With Edge, it works better, being read as "'hide'; button" / "'show'; button".

Fri, Aug 17, 2:38 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
matmarex awarded T202047: CODE_OF_CONDUCT.md should link to the mediawiki.org page in user's preferred language a Like token.
Fri, Aug 17, 2:33 PM · VPS-project-libraryupgrader, MediaWiki-extensions-General, I18n

Thu, Aug 16

matmarex added a comment to T40800: Tidy should not create (additional) white space between elements.

This is still an issue, but not longer a blocker to T2260 since we changed Tidy not to generate HTML like this (T85794).

Thu, Aug 16, 10:34 PM · Tidy, MediaWiki-Parser
matmarex updated subscribers of T197179: Deprecate OOUI HTMLFormField "notices" in favor of "inline help".

instead implement a boolean 'help-inline' parameter corresponding to the new OOUI FieldLayout 'helpInline' config option

Thu, Aug 16, 10:30 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-HTMLForm
matmarex added a comment to T181854: Better handling of 'instruction text' on Preferences tabs for Recent Changes and Watchlist.

Side-by-side comparison for the proposed patch:

BeforeAfter
Thu, Aug 16, 8:57 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-User-preferences, UI-Standardization
matmarex closed T190945: FlaggedRevs is not compatible with TemplateStyles as Resolved.
Thu, Aug 16, 8:41 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MediaWiki-extensions-FlaggedRevs, TemplateStyles
matmarex added a comment to T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken, but the problem is rare and intermittent.

Could we just [copy-paste] all OOUI styles and make it more efficient in a follow-up?

Thu, Aug 16, 8:37 PM · Patch-For-Review, User-Ryasmeen, VisualEditor (Current work)
matmarex reassigned T201506: Fatal error when viewing some Wikisource pages: MWContentSerializationException: The serialization is an invalid JSON array. from matmarex to Tpt.
Thu, Aug 16, 8:32 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Patch-For-Review, Editing-team, Wikimedia-log-errors, ProofreadPage
matmarex closed T201506: Fatal error when viewing some Wikisource pages: MWContentSerializationException: The serialization is an invalid JSON array. as Resolved.

The change has been merged and will be deployed to production wikis next week, 21-23 August, per the usual schedule. Hopefully it fixes the issues.

Thu, Aug 16, 8:32 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Patch-For-Review, Editing-team, Wikimedia-log-errors, ProofreadPage
matmarex closed T202091: ProofreadPage PHPUnit tests failing on master (failure related to 'hadSignature') as Resolved.
Thu, Aug 16, 8:19 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Editing-team, ProofreadPage
matmarex added a comment to T202091: ProofreadPage PHPUnit tests failing on master (failure related to 'hadSignature').

Probably caused by rMWf2e3c4d09fdf: Give pages with ~~~~ a different cache TTL in core.

Thu, Aug 16, 7:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Editing-team, ProofreadPage
matmarex triaged T202091: ProofreadPage PHPUnit tests failing on master (failure related to 'hadSignature') as Unbreak Now! priority.
Thu, Aug 16, 7:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Editing-team, ProofreadPage
matmarex closed T194788: An introduction to working with OOUI (Wikimedia Hackathon 2018) as Resolved.

Probably…

Thu, Aug 16, 6:51 PM · User-Jayprakash12345, Wikimedia-Hackathon-2018
matmarex added a comment to T202044: Missing icons and a broken link in OOUI tutorials toolbar.

However, we're not sure why the missing links do load locally, while a link to this CSS file is missing.

Thu, Aug 16, 6:39 PM · OOUI (OOUI-0.28.0)
matmarex added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

@APerson Can you clarify what you mean? The new user group interface-admin already exists on the wikis and users can be added to it by bureaucrats.

Thu, Aug 16, 6:38 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

Wed, Aug 15

matmarex moved T201871: [regression] Layout issues in feedback dialog from Code review to QA on the VisualEditor (Current work) board.
Wed, Aug 15, 6:03 PM · OOUI (OOUI-0.28.0), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression

Tue, Aug 14

matmarex added a comment to T199252: Search engines continue to link to JS-redirect destination after Wikipedia copyright protest.

For reference, according to this thread, Polish Wikipedia was affected by a similar issue: https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#protest_w_sprawie_dyrektywy_UE_-_cache (last comment was on 20 July, I did not see the thread before)

Tue, Aug 14, 8:02 PM · Patch-For-Review, SEO, Performance-Team, Operations, Traffic, Wikimedia-General-or-Unknown
matmarex added projects to T201871: [regression] Layout issues in feedback dialog: VisualEditor-MediaWiki, OOUI.
Tue, Aug 14, 7:08 PM · OOUI (OOUI-0.28.0), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
matmarex reopened T178456: Small unclickable gap between checkbox and label as "Open".

Reverting again due to T201871: [regression] Layout issues in feedback dialog. It doesn't work right when the label contains a block element (e.g. if it's composed of several paragraphs <p>).

Tue, Aug 14, 7:08 PM · OOUI
matmarex added a comment to T201871: [regression] Layout issues in feedback dialog.

The checkbox alignment seems to be caused by T178456's patch (or, at least, disabling the padding-left rule it added fixes it; harder to test whether it predates that). @matmarex?

Tue, Aug 14, 6:59 PM · OOUI (OOUI-0.28.0), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression
matmarex moved T190596: Highlight does not cover the menu option entirely in the toolbar on Mobile VE from Code review to QA on the VisualEditor (Current work) board.
Tue, Aug 14, 6:05 PM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MinervaNeue, VisualEditor (Current work), Patch-For-Review, UI-Standardization-Kanban, UI-Standardization
matmarex edited projects for T190596: Highlight does not cover the menu option entirely in the toolbar on Mobile VE , added: VisualEditor (Current work), MinervaNeue; removed VisualEditor.
Tue, Aug 14, 5:26 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MinervaNeue, VisualEditor (Current work), Patch-For-Review, UI-Standardization-Kanban, UI-Standardization
matmarex added a comment to T190596: Highlight does not cover the menu option entirely in the toolbar on Mobile VE .

We're solving this by overriding the height of mobile editor's toolbar from 3.35em to 3em only when using VisualEditor. The existing VisualEditor styles are written to use a 3em toolbar (same on desktop and mobile) and overriding everything to use 3.35em would require a lot of fragile code (and where does 3.35em come from, anyway?).

Tue, Aug 14, 5:25 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MinervaNeue, VisualEditor (Current work), Patch-For-Review, UI-Standardization-Kanban, UI-Standardization
matmarex added a comment to T198845: OOUI tutorial migration.

There's an issue with the indicator in the dropdown widget that I want to get some insight on, I'm either missing something, or we might have an OOUI issue (?)

(…)

But the indicator isn't showing in the tutorials. I thought it might be that the icon isn't loaded, so I searched for any mention of indicator or 'down' in the less and css files, and all I found was src/themes/apex/widgets.less that redefines 'visibility:visible' and a margin.

Tue, Aug 14, 4:58 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), OOUI (OOUI-0.28.0), Collaboration-Team-Triage (Collab-Team-This-Quarter), Documentation

Fri, Aug 10

matmarex closed T192019: CodeMirror syntax highlighting shows overlapping text when word-wrap (hyphens, word-break) is overridden as Resolved.
Fri, Aug 10, 12:55 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Easy, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
matmarex added a comment to T192019: CodeMirror syntax highlighting shows overlapping text when word-wrap (hyphens, word-break) is overridden.

@Aschmidt reported that it is still not fixed for him.

Fri, Aug 10, 12:55 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Easy, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
matmarex added a comment to T200229: Support GlobalPreferences in VisualEditor when setting preferences.

To be exact, VE sets the following preferences via API: [I've just made this list by searching our source code]

Fri, Aug 10, 12:50 AM · MediaWiki-extensions-GlobalPreferences, VisualEditor
matmarex added a comment to T201329: Mobile: Hide keyboard while menus are open.

I think that sounds like a good idea. I can't think of any downsides (but that doesn't mean there are none…). Should I be reviewing the current patches, or do you want to rewrite with this approach?

Fri, Aug 10, 12:23 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Thu, Aug 9

matmarex added a comment to T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

I agree with Volker that the focus states in David's mockups look weird :/

Thu, Aug 9, 11:04 PM · UI-Standardization, VisualEditor
matmarex moved T199655: Switching between old WTE and visual editing doesn't preserve changes from Code review to QA on the VisualEditor (Current work) board.
Thu, Aug 9, 10:37 PM · Verified-in-Phase0, Verified, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Browser-Support-Firefox
matmarex added a comment to T199554: Switching between visual editor and source mode gives error message.

@Ryasmeen On a closer look, the "Remember that this is only a preview" should not appear after switching from VE to OWE, because we switch to the diff view (rather than the preview view).

Thu, Aug 9, 9:13 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken, but the problem is rare and intermittent.

Thanks for the hints @Esanders @Krinkle. I figured out what causes the issue.

Thu, Aug 9, 8:46 PM · Patch-For-Review, User-Ryasmeen, VisualEditor (Current work)
matmarex added a comment to T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

I think the current design is okay. I would suggest declining this task… @DLynch @Ryasmeen Do you feel strongly that it's a problem? :)

Thu, Aug 9, 8:04 PM · UI-Standardization, VisualEditor
matmarex added a comment to T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (?).

I can reproduce this, and I think @dchan's explanation is correct. So the problem is that with white-space: pre-wrap, sequences of multiple spaces at the end of a line are collapsed. I think we can proceed with this assumption.

Thu, Aug 9, 6:51 PM · VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki-2017WikitextEditor
matmarex merged T185987: Inserting a combining diacritic mark into a VE surface messes up cursoring and causes duplicate text into T85093: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters.
Thu, Aug 9, 6:22 PM · Patch-For-Review, Growth-Team, StructuredDiscussions, Collaboration-Team-Triage, Regression, I18n, VisualEditor
matmarex merged task T185987: Inserting a combining diacritic mark into a VE surface messes up cursoring and causes duplicate text into T85093: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters.
Thu, Aug 9, 6:22 PM · VisualEditor-ContentEditable, VisualEditor
matmarex edited subtasks for T138966: Make the VisualEditor/ProofreadPage integration good enough to enable by default, added: T196863: VisualEditor/ProofreadPage splitting of the page content into header/section/footer is incompatible with existing content (and more generally, with the layout of physical books); removed: T138604: Writing manual </div>s into header/footer using VisualEditor with ProofreadPage corrupts the page.
Thu, Aug 9, 6:11 PM · VisualEditor-MediaWiki, VisualEditor, ProofreadPage
matmarex removed a parent task for T138604: Writing manual </div>s into header/footer using VisualEditor with ProofreadPage corrupts the page: T138966: Make the VisualEditor/ProofreadPage integration good enough to enable by default.
Thu, Aug 9, 6:11 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor, Wikisource, ProofreadPage
matmarex added a parent task for T196863: VisualEditor/ProofreadPage splitting of the page content into header/section/footer is incompatible with existing content (and more generally, with the layout of physical books): T138966: Make the VisualEditor/ProofreadPage integration good enough to enable by default.
Thu, Aug 9, 6:11 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor, ProofreadPage
matmarex closed T138604: Writing manual </div>s into header/footer using VisualEditor with ProofreadPage corrupts the page as Resolved.

Per my previous comment. I think this exact problem can no longer occur, please follow T196863 instead for other header/footer issues.

Thu, Aug 9, 6:10 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor, Wikisource, ProofreadPage
matmarex closed T138604: Writing manual </div>s into header/footer using VisualEditor with ProofreadPage corrupts the page, a subtask of T138966: Make the VisualEditor/ProofreadPage integration good enough to enable by default, as Resolved.
Thu, Aug 9, 6:10 PM · VisualEditor-MediaWiki, VisualEditor, ProofreadPage
matmarex added parent tasks for T85093: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters: T182404: 2017 wikitext editor gets very confused while typing signature (combining diacritics and non-breaking spaces?), T198719: jquery.ime keyboard layouts that convert letters to combining characters works incorrectly.
Thu, Aug 9, 5:34 PM · Patch-For-Review, Growth-Team, StructuredDiscussions, Collaboration-Team-Triage, Regression, I18n, VisualEditor
matmarex added a subtask for T198719: jquery.ime keyboard layouts that convert letters to combining characters works incorrectly: T85093: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters.
Thu, Aug 9, 5:34 PM · UniversalLanguageSelector, VisualEditor
matmarex added a subtask for T182404: 2017 wikitext editor gets very confused while typing signature (combining diacritics and non-breaking spaces?): T85093: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters.
Thu, Aug 9, 5:34 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T85093: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters.

If you want to test this and can't easily insert combining characters from the keyboard, here is a U+0301 Combining Acute Accent for your copy-paste convenience:

Thu, Aug 9, 5:34 PM · Patch-For-Review, Growth-Team, StructuredDiscussions, Collaboration-Team-Triage, Regression, I18n, VisualEditor
matmarex claimed T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken, but the problem is rare and intermittent.

I have some ideas, I have yet to test them.

Thu, Aug 9, 4:24 PM · Patch-For-Review, User-Ryasmeen, VisualEditor (Current work)
matmarex added a parent task for T199554: Switching between visual editor and source mode gives error message: T201210: VisualEditor not switching to edit conflict interface.
Thu, Aug 9, 3:09 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a subtask for T201210: VisualEditor not switching to edit conflict interface: T199554: Switching between visual editor and source mode gives error message.
Thu, Aug 9, 3:09 AM · VisualEditor (Current work), MediaWiki-Page-editing
matmarex moved T201210: VisualEditor not switching to edit conflict interface from Up next to QA on the VisualEditor (Current work) board.

This works correctly for me now (testing on https://en.wikipedia.beta.wmflabs.org/wiki/T201210). After causing an edit conflict, then trying to save in VE, I was redirected directly to this screen:

Thu, Aug 9, 3:09 AM · VisualEditor (Current work), MediaWiki-Page-editing
matmarex moved T199484: Clicking on red link gives error "Uncaught TypeError: Cannot read property 'start' of null" from Up next to QA on the VisualEditor (Current work) board.
Thu, Aug 9, 3:03 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, Verified, Patch-For-Review, VisualEditor (Current work)
matmarex added a comment to T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it).

This probably should be low priority… but it was interesting, so I investigated it for a bit, and ended up with working patches… so might as well submit them.

Thu, Aug 9, 1:16 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
matmarex added a comment to T201472: List insertion by typing '#<space>', '*<space>' is broken.

(…) I think ultimately we should move the paragraph cleanup into the command or action code:

If I type abc<newline>{| I expect to get <p>abc</p><table>..., which your previous patch achieves.

However if I type abc<newline> then choose Insert>Table, I don't get the benefits of the newline cleanup, which I think you should.

In general, taking any action to insert a block level element into an empty paragraph should destroy that paragraph.

Thu, Aug 9, 12:48 AM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex created T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it).
Thu, Aug 9, 12:44 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
matmarex moved T201472: List insertion by typing '#<space>', '*<space>' is broken from Code review to QA on the VisualEditor (Current work) board.

Fixed and deployed to production wikis.

Thu, Aug 9, 12:29 AM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki

Wed, Aug 8

matmarex added a project to T130478: commonswiki.uploadstash table has unexpectedly old data: MediaWiki-Maintenance-scripts.

Having been recently reminded of this task over my foul language in the opening comment, I re-checked it and the old rows dating back to 2012 still exist in the database.

Wed, Aug 8, 11:28 PM · MediaWiki-Maintenance-scripts, Privacy, media-storage
matmarex added a comment to T201472: List insertion by typing '#<space>', '*<space>' is broken.

I think we should backport this fix to wmf.16. On a closer look, it seems we actually place a text cursor inside the slug in the invisible list item, and you can type into it… I am not sure how broken this really is (maybe it's dumb but harmless), but it looks super broken.

Wed, Aug 8, 11:04 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex added a comment to T199554: Switching between visual editor and source mode gives error message.

@Ryasmeen I can reproduce the issue on https://www.mediawiki.org/wiki/Project:Sandbox currently as an anonymous user. You have to switch from VE to old wikitext editor (so this depends on not having NWE enabled in preferences).

Wed, Aug 8, 10:54 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T201555: Determine if drag/droping a file onto a security task makes the file/image private.

It does. This is a public task though :)

Wed, Aug 8, 8:58 PM · User-greg, Security
matmarex moved T199655: Switching between old WTE and visual editing doesn't preserve changes from In progress to Code review on the VisualEditor (Current work) board.
Wed, Aug 8, 8:42 PM · Verified-in-Phase0, Verified, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Browser-Support-Firefox
matmarex moved T199554: Switching between visual editor and source mode gives error message from Code review to QA on the VisualEditor (Current work) board.
Wed, Aug 8, 8:36 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T127903: Projects should have an "Open Tasks" view by default.

I think this has been implemented? I see such a link on most projects now, but I'm not sure if all have it.

Wed, Aug 8, 5:44 PM · Release-Engineering-Team (Kanban), Phabricator (2017-04-26), Developer-Wishlist (2017)
Krinkle awarded T185049: Unable to open edit page, or view Special:Log, for certain pages ("MWException: Expected title, got null" from LogFormatter.php) a Orange Medal token.
Wed, Aug 8, 5:17 PM · MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Editing-team, Contributors-Team, MediaWiki-Page-editing, MediaWiki-Logging, Wikimedia-log-errors
matmarex added a comment to T200392: RfC: Release notes automation.

MatmaRex wrote a custom merge tool: https://github.com/MatmaRex/mediawikireleasenotes-driver If it works flawlessly, we should check it in to our .gitconfig and .gitattributes files in the repo. If we don't require that developers have Ruby installed, which I don't think we do (do we?), we should rewrite it in Python or PHP.

For the record, I tried out the linked merge tool and it ate a line on the first trial run. If we do this, we need a test suite.

Wed, Aug 8, 3:27 PM · MediaWiki-Documentation, TechCom-RFC
matmarex added a comment to T201514: Auto-resolve merge conflicts in RELEASE-NOTES.

It would be nice if we wrote our own merge driver for RELEASE-NOTES.

Wed, Aug 8, 1:47 PM · Core-Platform-Team
matmarex closed T157941: Inconsistent capitalisation for link labels in EditWatchlist due to message reuse as Resolved.
Wed, Aug 8, 4:38 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Easy, I18n, Growth-Team, MediaWiki-Watchlist
matmarex added a project to T201484: The notification for receiving thanks for the first revision of a page gives an incorrect diff URL: MediaWiki-General-or-Unknown.

That URL is not supposed to be invalid. In older MediaWiki versions, it showed only a diff header (with no diff), but not an error message.

Wed, Aug 8, 3:58 AM · MediaWiki-General-or-Unknown, Growth-Team, Notifications, Thanks
matmarex closed T191271: Set an associated revision id for imports as Resolved.
Wed, Aug 8, 12:05 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MediaWiki-Export-or-Import, MediaWiki-Logging

Tue, Aug 7

matmarex closed T200623: cl_sortkey_prefix crops unicode string mid character as Resolved.
Tue, Aug 7, 11:01 PM · MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), MediaWiki-Categories, Patch-For-Review
matmarex edited projects for T201472: List insertion by typing '#<space>', '*<space>' is broken, added: VisualEditor (Current work); removed VisualEditor.
Tue, Aug 7, 10:49 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex created T201472: List insertion by typing '#<space>', '*<space>' is broken.
Tue, Aug 7, 10:49 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex closed T185751: Support $overlay on DropdownInputWidget as Resolved.
Tue, Aug 7, 8:47 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Easy, OOUI
matmarex created P7434 (An Untitled Masterwork).
Tue, Aug 7, 8:14 PM
matmarex created P7433 (An Untitled Masterwork).
Tue, Aug 7, 8:09 PM
matmarex added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

IIRC these days ResourceLoader has a hidden option so the hack is not needed anymore.

Tue, Aug 7, 5:56 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
matmarex added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

To clarify, using rights=hidden on https://hr.wikipedia.org/wiki/MediaWiki:Gadgets-definition for this gadget means that you have to have the hidden right to enable it in your preferences. It does not affect the rights required to edit it.

Tue, Aug 7, 5:52 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
matmarex merged T189833: Viewing file page with certain 'filetimestamp' value causes fatal error into T155090: passing invalid timestamp in url for a file returns fatal.
Tue, Aug 7, 4:52 PM · Patch-For-Review, MediaWiki-File-management, Multimedia, MediaWiki-extensions-FlaggedRevs, Wikimedia-log-errors
matmarex merged task T189833: Viewing file page with certain 'filetimestamp' value causes fatal error into T155090: passing invalid timestamp in url for a file returns fatal.
Tue, Aug 7, 4:52 PM · Wikimedia-log-errors, MediaWiki-extensions-FlaggedRevs, Multimedia, Commons, MediaWiki-File-management

Sat, Aug 4

matmarex added a project to T199554: Switching between visual editor and source mode gives error message: VisualEditor-MediaWiki.

(Note that there is no data loss, for VE or other affected tools, just a misleading message.)

Sat, Aug 4, 12:16 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)

Thu, Aug 2

matmarex added a comment to T201072: [[?oldid=851713451]] is a valid link in the new preview, but not when the page is saved.

At the moment, I'm leaning towards having [[?oldid=851713451]] work as valid link syntax. Then we could get rid of {{oldid}}-type templates, and it would be easy to link to previous revisions everywhere. However, perhaps it would create problems that I haven't thought of yet.

Thu, Aug 2, 7:02 PM · VisualEditor, Parsoid, MediaWiki-Parser, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a subtask for T201072: [[?oldid=851713451]] is a valid link in the new preview, but not when the page is saved: T132629: Data passed to HHVM ($_SERVER variables) is a mixed bag of already-decoded and non-decoded nonsense.
Thu, Aug 2, 6:56 PM · VisualEditor, Parsoid, MediaWiki-Parser, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a parent task for T132629: Data passed to HHVM ($_SERVER variables) is a mixed bag of already-decoded and non-decoded nonsense: T201072: [[?oldid=851713451]] is a valid link in the new preview, but not when the page is saved.
Thu, Aug 2, 6:56 PM · Traffic, Operations, Wikimedia-Apache-configuration, Varnish
matmarex added a comment to T201072: [[?oldid=851713451]] is a valid link in the new preview, but not when the page is saved.

"?oldid=851713451" is a valid page title. For the wikitext [[?oldid=851713451]], Parsoid generates a correct link to https://en.wikipedia.org/wiki/%3Foldid=851713451. PHP Parser generates a link to https://en.wikipedia.org/w/index.php?title=%3Foldid%3D851713451&action=edit&redlink=1 – if you're logged out (and can't create pages), this redirects to https://en.wikipedia.org/wiki/%3Foldid%3D851713451. Note that the '?' character is URL-encoded.

Thu, Aug 2, 6:55 PM · VisualEditor, Parsoid, MediaWiki-Parser, VisualEditor-MediaWiki-2017WikitextEditor

Wed, Aug 1

matmarex updated subscribers of T200880: Editor should flag mobile editing warnings.

It sounds viable, other extensions implement similar mechanisms (e.g. AbuseFilter). I haven't made up my mind yet on whether it's a good idea.

Wed, Aug 1, 8:41 PM · TechCom-RFC, Page-Issue-Warnings, Readers-Web-Backlog (Design), Reading-Web-Local-Wiki-Issues, MobileFrontend
matmarex closed T199925: Be able to insert horizontal rules (<hr> or ----) as Resolved.
Wed, Aug 1, 8:30 PM · Verified, VisualEditor (Current work), User-Ryasmeen, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))
matmarex added a comment to T197901: npm warn deprecated.

In package.json. These problematic packages are probably dependencies of dependencies of dependencies of dependencies of dependencies of packages we actually use.

Wed, Aug 1, 7:29 PM · MediaWiki-Core-Tests
matmarex added a comment to T199925: Be able to insert horizontal rules (<hr> or ----).

Current version of the patches only implements inserting horizontal rules by typing ----. I think that's an uncontroversial improvement, and it is easy to support in the future (comparable to the {| sequence to insert a table that we already have), so I'm going to merge them.

Wed, Aug 1, 7:20 PM · Verified, VisualEditor (Current work), User-Ryasmeen, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))
matmarex closed T200893: Special:RevisionDelete: Part of the interface shows up in the content language as Declined.
Wed, Aug 1, 7:04 PM · I18n, MediaWiki-Internationalization, MediaWiki-Special-pages
matmarex merged T200628: Several deprecated npm packages being used on quibble tests into T197901: npm warn deprecated.
Wed, Aug 1, 6:48 PM · MediaWiki-Core-Tests
matmarex merged task T200628: Several deprecated npm packages being used on quibble tests into T197901: npm warn deprecated.
Wed, Aug 1, 6:48 PM · MediaWiki-Core-Tests
matmarex closed T158504: Special:NewPages should remember previous filters after changing them as Resolved.
Wed, Aug 1, 6:48 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MediaWiki-Special-pages
matmarex added a comment to T68898: PageCuration: Get rid of synchronous AJAX request on page load.

@MMiller_WMF Yes, but it's not urgent, this task is four years old and it will not hurt if it takes a few weeks to fix.

Wed, Aug 1, 6:02 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Growth-Team (Current Sprint), Patch-For-Review, Technical-Debt, Performance, MediaWiki-extensions-PageCuration