matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (208 w, 6 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Yesterday

matmarex closed T64071: Edit link inconsistencies on Foreign file pages - skins which use doEditSectionLink incompatible with FileRepo as Resolved.

Making FileRepo stuff depend on current skin would be horrible, also there's a problem with permissions/being logged in on foreign wiki which makes displaying edit links unreliable. However, I redid Bartosz's fix for bug 19415 (T21415) in https://gerrit.wikimedia.org/r/#/c/118135/

Thu, Oct 18, 9:10 PM · Commons, Multimedia, MediaWiki-File-management
matmarex closed T206546: Edit link is broken on file pages where magic commons is used, a subtask of T64071: Edit link inconsistencies on Foreign file pages - skins which use doEditSectionLink incompatible with FileRepo, as Resolved.
Thu, Oct 18, 9:05 PM · Commons, Multimedia, MediaWiki-File-management
matmarex closed T206546: Edit link is broken on file pages where magic commons is used as Resolved.
Thu, Oct 18, 9:05 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex added a comment to T206546: Edit link is broken on file pages where magic commons is used.

https://en.m.wikipedia.beta.wmflabs.org/wiki/File:Test_2018-10-18.png is now displaying the fetched file description, with no funky section edit links.

Thu, Oct 18, 8:54 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex updated the task description for T205382: Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;).
Thu, Oct 18, 8:06 PM · Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Need-volunteer, MinervaNeue, MobileFrontend
matmarex added a comment to T206546: Edit link is broken on file pages where magic commons is used.

I fixed the messages on beta English Wikipedia so that it's more obvious where it's fetching files from: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?user=Yatu&wpdate=2018-10-18&limit=7

Thu, Oct 18, 7:51 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex added a comment to T206546: Edit link is broken on file pages where magic commons is used.

I think I see the issue: the beta Commons URL is protocol-relative. When asked to fetch it, MWHttpRequest expands it to a http:// URL, but we no longer serve the site over HTTP. There is a 'Location:' redirect, but MWHttpRequest doesn't follow redirects by default.

Thu, Oct 18, 7:35 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex added a comment to T206546: Edit link is broken on file pages where magic commons is used.

I think I was wrong, it is pulling from the right repo, but failing to pull the description (I don't know why). I was confused because all of the on-wiki messages are customized to link to ommons.wikimedia.org even when the file is pulled from elsewhere :/ But with uselang=qqx, it is more clear:

Thu, Oct 18, 7:28 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex added a comment to T206546: Edit link is broken on file pages where magic commons is used.

That is pulling the file and description from the production Commons (https://commons.wikimedia.org/wiki/File:Banana.jpg?action=render), which is not running the new code yet.

Thu, Oct 18, 7:09 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex closed T207397: jqueryMsg error breaks Wikibase term editing as Resolved.

Sorry about that.

Thu, Oct 18, 6:03 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Wikidata-Campsite, MediaWiki-General-or-Unknown, Wikidata
matmarex closed T207397: jqueryMsg error breaks Wikibase term editing, a subtask of T206655: 1.33.0-wmf.1 deployment blockers, as Resolved.
Thu, Oct 18, 6:03 PM · Release, Train Deployments
matmarex added a commit to T21415: Suppress section edit links with action=render: rMW5f2cb872b587: ImagePage: Inherit parent's handling for action=render.
Thu, Oct 18, 3:38 PM · MediaWiki-Parser, MW-1.23.0-release
matmarex added a commit to T65891: URLs with action=render should not be indexed by search engines: rMW5f2cb872b587: ImagePage: Inherit parent's handling for action=render.
Thu, Oct 18, 3:38 PM · goodfirstbug, MediaWiki-General-or-Unknown
matmarex closed T204841: Fatal AFPUserVisibleException when evaluating certain arrays as Resolved.
Thu, Oct 18, 4:05 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), User-Daimona, Wikimedia-production-error, AbuseFilter
matmarex moved T205945: On mobile VE, text inside table header cell is overlapping with the sort icon from Code review to Product owner review on the VisualEditor (Current work) board.
Thu, Oct 18, 4:03 AM · Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor (Current work), MinervaNeue, MobileFrontend
matmarex closed T52365: VisualEditor: Template:Listen (and similar sound files) doesn't render the TMH aspects correctly as Resolved.

Looks perfect now.

Thu, Oct 18, 3:58 AM · User-Ryasmeen, VisualEditor, VisualEditor-ContentEditable
matmarex moved T198511: VisualEditor losing Media: links from In progress to QA on the VisualEditor (Current work) board.
Thu, Oct 18, 3:54 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
matmarex added a parent task for T21415: Suppress section edit links with action=render: T64071: Edit link inconsistencies on Foreign file pages - skins which use doEditSectionLink incompatible with FileRepo.
Thu, Oct 18, 3:13 AM · MediaWiki-Parser, MW-1.23.0-release
matmarex added subtasks for T64071: Edit link inconsistencies on Foreign file pages - skins which use doEditSectionLink incompatible with FileRepo: T21415: Suppress section edit links with action=render, T206546: Edit link is broken on file pages where magic commons is used.
Thu, Oct 18, 3:13 AM · Commons, Multimedia, MediaWiki-File-management
matmarex added a parent task for T206546: Edit link is broken on file pages where magic commons is used: T64071: Edit link inconsistencies on Foreign file pages - skins which use doEditSectionLink incompatible with FileRepo.
Thu, Oct 18, 3:13 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex claimed T206546: Edit link is broken on file pages where magic commons is used.
Thu, Oct 18, 3:03 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex added a comment to T206546: Edit link is broken on file pages where magic commons is used.

@Jdlrobson It happens in FileRepo::getDescriptionRenderUrl(), but I don't think it's feasible to add useskin= there. We'd have to pass it through a few levels of function calls, but more importantly, the foreign description is cached in File::getDescriptionText(), and that cache would have to be split by skin.

Thu, Oct 18, 3:01 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Readers-Web-Backlog, MinervaNeue
matmarex closed T207287: Separate *KeyDownHandler tests into separate files as Resolved.

Actually, I don't think product review is needed for this change, either :)

Thu, Oct 18, 2:41 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, VisualEditor (Current work)
matmarex closed T207287: Separate *KeyDownHandler tests into separate files, a subtask of T206138: [EPIC] Increase test coverage for VE.ce code, as Resolved.
Thu, Oct 18, 2:40 AM · VisualEditor (Current work)
matmarex moved T207287: Separate *KeyDownHandler tests into separate files from Code review to Product owner review on the VisualEditor (Current work) board.

(No QA needed)

Thu, Oct 18, 2:40 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, VisualEditor (Current work)
matmarex added a comment to T198511: VisualEditor losing Media: links.

(Better diff link, with fewer unrelated changes: https://en.wikipedia.org/w/index.php?title=Nightwish&diff=836341923&oldid=836326809)

Thu, Oct 18, 2:34 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
matmarex added a comment to T207065: CAPTCHA broken at English Wikipedia, when adding specific content in AFD (Articles for Deletion).

Also, I don't think this is a new issue. It seems that the bug has existed for years. The bug reporter must be the first person ever to use special page transclusion (fairly rare and unknown feature) while triggering a CAPTCHA (which mostly happens to newbie users). :)

Thu, Oct 18, 1:04 AM · MediaWiki-Parser, Patch-For-Review, ConfirmEdit (CAPTCHA extension)
matmarex added a project to T207065: CAPTCHA broken at English Wikipedia, when adding specific content in AFD (Articles for Deletion): MediaWiki-Parser.
Thu, Oct 18, 12:58 AM · MediaWiki-Parser, Patch-For-Review, ConfirmEdit (CAPTCHA extension)
matmarex claimed T207065: CAPTCHA broken at English Wikipedia, when adding specific content in AFD (Articles for Deletion).

Fascinating. So, a few things normally happen when a user tries to save the page (and gets rejected):

Thu, Oct 18, 12:57 AM · MediaWiki-Parser, Patch-For-Review, ConfirmEdit (CAPTCHA extension)
matmarex added a project to T165068: Parser::braceSubstitution() recreates new RequestContext and calls RequestContextCreateSkin twice: MediaWiki-Parser.
Thu, Oct 18, 12:37 AM · MediaWiki-Parser, Core Platform Team Backlog (Watching / External), Readers-Web-Backlog (Tracking), Performance, Parsing-Team
matmarex added a subtask for T183340: Special:RelatedChanges is shown as a template on the visual editor: T59886: Support special page transclusion.
Thu, Oct 18, 12:36 AM · MediaWiki-Special-pages, VisualEditor
matmarex added a parent task for T59886: Support special page transclusion: T183340: Special:RelatedChanges is shown as a template on the visual editor.
Thu, Oct 18, 12:36 AM · Parsoid-Read-Views
matmarex removed a project from T189416: Using Special:Recentchangeslinked more than once on a single page shows an error "Unstrip size limit exceeded (5 000 000)": Regression.
Thu, Oct 18, 12:34 AM · Growth-Team, MediaWiki-Parser, MediaWiki-Recent-changes
matmarex closed T189416: Using Special:Recentchangeslinked more than once on a single page shows an error "Unstrip size limit exceeded (5 000 000)" as Invalid.

There is a limit on the amount of content that can be generated by transclusions (the "unstrip post‐expand size"), and this limit is 5 000 000 bytes. If your transclusions are exceeding it, I can only recommend making them smaller (e.g. lowering the number of days for the list of recent changes) or splitting the pagae. While I'm not an authority on this matter, I am pretty sure that we're not going to raise the limit.

Thu, Oct 18, 12:34 AM · Growth-Team, MediaWiki-Parser, MediaWiki-Recent-changes
matmarex claimed T76972: "Strip prefix in list" checkbox at Special:PrefixIndex feels strange.

Certainly seems like we should keep the checkbox but change its label.

Thu, Oct 18, 12:23 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Design, MediaWiki-Special-pages

Wed, Oct 17

matmarex added a parent task for T52474: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text.: T198477: [he.wiki] Reference list is emptied when adding a new reference on a wiki that uses template generated references (not <ref> tags).
Wed, Oct 17, 8:48 PM · Epic, VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-DataModel
matmarex added a subtask for T198477: [he.wiki] Reference list is emptied when adding a new reference on a wiki that uses template generated references (not <ref> tags): T52474: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text..
Wed, Oct 17, 8:48 PM · VisualEditor
matmarex updated subscribers of T33260: Add support for rawParams to jqueryMsg.

This is ok for simple cases, but if you want to do something like attach some data or behavior to an element (something that IIRC Neil's message parser for UploadWizard explicitly does) you could end up losing it.

(Event handlers etc would need to be re-added after the string gets turned back into DOM elements in the document, which is potentially awkward.)

It may be useful to have an output mode that produces a DOM element rather than HTML source.

Wed, Oct 17, 8:21 PM · MediaWiki-Internationalization, JavaScript, I18n
matmarex closed T33260: Add support for rawParams to jqueryMsg as Declined.

Indeed, as @DanielFriesen says this is already possible (and @Catrope just fixed a bug that made it not work for some messages: rMW8d1844704ad6: jqueryMsg: Don't fall back to simple parser when jQuery params passed). I documented that you should pass jQuery/DOM objects to achieve this at https://www.mediawiki.org/wiki/Manual:Messages_API#Parameters_2.

Wed, Oct 17, 8:20 PM · MediaWiki-Internationalization, JavaScript, I18n
matmarex updated the task description for T33260: Add support for rawParams to jqueryMsg.
Wed, Oct 17, 7:51 PM · MediaWiki-Internationalization, JavaScript, I18n
matmarex closed T205991: "Select options below to be global" missing a checkbox as Resolved.
Wed, Oct 17, 7:46 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Discovery-Search (Current work), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), CirrusSearch, MediaWiki-extensions-GlobalPreferences, Community-Tech
matmarex closed T203988: On Special:Preferences>Search page, the descriptive text for each options should have the same font as other descriptive texts on other tabs as Resolved.
Wed, Oct 17, 7:45 PM · User-Ryasmeen, MediaWiki-User-preferences, Discovery-Search, CirrusSearch
matmarex closed T203988: On Special:Preferences>Search page, the descriptive text for each options should have the same font as other descriptive texts on other tabs, a subtask of T205991: "Select options below to be global" missing a checkbox, as Resolved.
Wed, Oct 17, 7:45 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Discovery-Search (Current work), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), CirrusSearch, MediaWiki-extensions-GlobalPreferences, Community-Tech
matmarex updated subscribers of T85470: Users are requesting a "Cancel and exit without saving" option.

We've talked about this task for about 30 seconds in the planning meeting today, and @Esanders reminded me of a different possible solution for the specific use case of discarding your autosaved edits: changing the notification popup about restored edit to have a button to discard it.

Wed, Oct 17, 5:39 PM · VisualEditor-MediaWiki, VisualEditor

Mon, Oct 15

matmarex closed T206795: Changes to TemplateData not applied when using the TemplateData GUI, unless in safe mode as Invalid.

I spent a few hours investigating this today. The problem with TemplateData editor and the exception are actually two separate issues, but both are caused by the wikEd gadget. @DePiep I am guessing you're using it since you have some configuration for it in your vector.js page.

Mon, Oct 15, 11:27 PM · TemplateData, VisualEditor
matmarex claimed T206925: HTMLInfoField with a default value of "0" in an OOUI HTMLForm shows an empty string instead.
Mon, Oct 15, 7:41 PM · OOUI (OOUI-0.29.3), Regression, MediaWiki-HTMLForm
matmarex merged task T206969: Hitting Shift+Enter within a bulleted or numbered list leads to incorrect wikitext into T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.
Mon, Oct 15, 5:42 PM · VisualEditor
matmarex merged tasks T180824: Parsoid should use <br/> to handle paragraph tags in single-line-mode wikitext constructs like list items, T206969: Hitting Shift+Enter within a bulleted or numbered list leads to incorrect wikitext into T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.
Mon, Oct 15, 5:42 PM · Parsoid
matmarex merged task T180824: Parsoid should use <br/> to handle paragraph tags in single-line-mode wikitext constructs like list items into T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.
Mon, Oct 15, 5:42 PM · Parsoid
matmarex added a comment to T206138: [EPIC] Increase test coverage for VE.ce code.

Current coverage report: https://doc.wikimedia.org/cover/visualeditor/src/ce/

Mon, Oct 15, 4:21 PM · VisualEditor (Current work)
matmarex closed T206977: ParserFunctions/includes/ExprParser.php triggers warnings in PHP 7.3 as Resolved.
Mon, Oct 15, 4:05 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, PHP 7.3 support, MediaWiki-extensions-ParserFunctions

Sat, Oct 13

matmarex updated the task description for T206795: Changes to TemplateData not applied when using the TemplateData GUI, unless in safe mode.
Sat, Oct 13, 1:56 AM · TemplateData, VisualEditor
matmarex moved T206892: Wrong localisation message used by VE for the Edit tab in single-edit-tab mode from Up next to Code review on the VisualEditor (Current work) board.
Sat, Oct 13, 1:18 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex claimed T206892: Wrong localisation message used by VE for the Edit tab in single-edit-tab mode.
Sat, Oct 13, 1:18 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex added a comment to T206892: Wrong localisation message used by VE for the Edit tab in single-edit-tab mode.

Additional related issue I found when debugging this issue: on file description pages for files from Wikimedia Commons (e.g. https://en.wikipedia.org/wiki/File:A5_Aarebruecke.jpg), the edit tab normally says "Add local description", and clicking it changes it to "Edit this page". It should remain unchanged.

Sat, Oct 13, 12:55 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex updated subscribers of T206554: Inconsistent "Edit" button label.
Sat, Oct 13, 12:52 AM · VisualEditor-MediaWiki, VisualEditor
matmarex added a project to T206554: Inconsistent "Edit" button label: VisualEditor-MediaWiki.
Sat, Oct 13, 12:52 AM · VisualEditor-MediaWiki, VisualEditor
matmarex updated the task description for T206554: Inconsistent "Edit" button label.
Sat, Oct 13, 12:52 AM · VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T206554: Inconsistent "Edit" button label.

@alexhollender Thank you, that's very helpful. I was able to find where we use the incorrect localisation message ( 'edit' instead of 'vector-view-edit'). I filed T206892 with some more details about this. Let's make this task just about the 'Edit' vs 'Edit source' distinction.

Sat, Oct 13, 12:51 AM · VisualEditor-MediaWiki, VisualEditor
matmarex created T206892: Wrong localisation message used by VE for the Edit tab in single-edit-tab mode.
Sat, Oct 13, 12:44 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki

Fri, Oct 12

matmarex closed T202465: [[MediaWiki:Visualeditor-debugbar-testsquasher/nb]]: "test the transaction squasher"? as Resolved.

I hope that helps. I added a link to this comment in https://translatewiki.net/wiki/MediaWiki:Visualeditor-debugbar-testsquasher/qqq.

Fri, Oct 12, 11:28 PM · User-Ryasmeen, VisualEditor, I18n
matmarex closed T171666: Implement HTMLFormFieldCloner in OOUIHTMLForm as Resolved.

Known issue with the patch:

Fri, Oct 12, 10:44 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), OOUI, MediaWiki-HTMLForm
matmarex added a comment to T205924: [Regression wmf.23] Drop down for menu options are overlapping with Toolbar when scrolling up.

Hm, yeah, please do.

Fri, Oct 12, 8:49 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor (Current work)
matmarex moved T206838: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode from Up next to QA on the VisualEditor (Current work) board.

I've looked at extensions using the EditFormPreloadText hook and it turns out this problem can be reproduced on Wikimedia projects as well, so asking for QA review.

Fri, Oct 12, 7:49 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
matmarex edited projects for T206838: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode, added: VisualEditor (Current work); removed VisualEditor.
Fri, Oct 12, 7:38 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
matmarex added a comment to T206838: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode.

There is no REL1_32 branch yet, as far as I can see. I don't think it has been cut yet, so the patch in master should be automatically included in it.

Fri, Oct 12, 7:23 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
matmarex added a parent task for T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused: T174485: UsersMultiselectWidget should throw error if unselected text is present onSubmit.
Fri, Oct 12, 7:12 PM · Patch-For-Review, Regression, OOUI
matmarex added a subtask for T174485: UsersMultiselectWidget should throw error if unselected text is present onSubmit: T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.
Fri, Oct 12, 7:12 PM · Growth-Team, MediaWiki-User-preferences, Collaboration-Team-Triage, Notifications
matmarex added parent tasks for T77826: Investigate if there is a low-effort way to recover entered details when the upload process has to be restarted: T113043: Accidental/automatical logout during upload process requires to start from scratch., T206831: Don't lose metadata if Upload Wizard "Describe" step is interrupted.
Fri, Oct 12, 7:07 PM · UploadWizard, Multimedia
matmarex added a subtask for T113043: Accidental/automatical logout during upload process requires to start from scratch.: T77826: Investigate if there is a low-effort way to recover entered details when the upload process has to be restarted.
Fri, Oct 12, 7:07 PM · MediaWiki-File-management, Multimedia, UploadWizard, Commons
matmarex added a subtask for T206831: Don't lose metadata if Upload Wizard "Describe" step is interrupted: T77826: Investigate if there is a low-effort way to recover entered details when the upload process has to be restarted.
Fri, Oct 12, 7:07 PM · Multimedia, UploadWizard
matmarex added a comment to T203988: On Special:Preferences>Search page, the descriptive text for each options should have the same font as other descriptive texts on other tabs.

The custom interface also caused issues with GlobalPreferences, thus the patch (see the parent task I added).

Fri, Oct 12, 6:49 PM · User-Ryasmeen, MediaWiki-User-preferences, Discovery-Search, CirrusSearch
matmarex added a subtask for T205991: "Select options below to be global" missing a checkbox: T203988: On Special:Preferences>Search page, the descriptive text for each options should have the same font as other descriptive texts on other tabs.
Fri, Oct 12, 6:45 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Discovery-Search (Current work), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), CirrusSearch, MediaWiki-extensions-GlobalPreferences, Community-Tech
matmarex added a parent task for T203988: On Special:Preferences>Search page, the descriptive text for each options should have the same font as other descriptive texts on other tabs: T205991: "Select options below to be global" missing a checkbox.
Fri, Oct 12, 6:45 PM · User-Ryasmeen, MediaWiki-User-preferences, Discovery-Search, CirrusSearch
matmarex added a comment to T205991: "Select options below to be global" missing a checkbox.

Looks like there is a separate task requesting that the preference be standardized (and Erik's patch seems to resolve it): T203988: On Special:Preferences>Search page, the descriptive text for each options should have the same font as other descriptive texts on other tabs

Fri, Oct 12, 6:45 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Discovery-Search (Current work), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), CirrusSearch, MediaWiki-extensions-GlobalPreferences, Community-Tech
matmarex added a comment to T206795: Changes to TemplateData not applied when using the TemplateData GUI, unless in safe mode.

Running with debug=true, webconsole message in Chrome: "Uncaught TypeError: Cannot read property 'accessKey' jquery.js[...]" (in Firefox: "jQuery.Deferred exception: element is undefined [...]"). Need more? -DePiep (talk) 16:17, 10 October 2018 (UTC)

Fri, Oct 12, 6:24 PM · TemplateData, VisualEditor
matmarex moved T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) from Code review to In progress on the VisualEditor (Current work) board.
Fri, Oct 12, 6:16 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, MobileFrontend, MinervaNeue
matmarex awarded T206813: Simplify anonymous editor CTA a Pterodactyl token.
Fri, Oct 12, 3:43 PM · MobileFrontend, Patch-For-Review, Readers-Web-Backlog (Design)
matmarex added a project to T206813: Simplify anonymous editor CTA: MobileFrontend.
Fri, Oct 12, 3:43 PM · MobileFrontend, Patch-For-Review, Readers-Web-Backlog (Design)
matmarex added a parent task for T205382: Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;): T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).
Fri, Oct 12, 3:37 PM · Audiences-QA, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Need-volunteer, MinervaNeue, MobileFrontend
matmarex added a subtask for T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop): T205382: Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;).
Fri, Oct 12, 3:37 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, MobileFrontend, MinervaNeue

Thu, Oct 11

matmarex closed T27086: Warning alternates between default and specified warning as Resolved.

Thank you for working on this, @Se4598 and @Daimona!

Thu, Oct 11, 6:38 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), User-notice, AbuseFilter
matmarex changed the status of T205924: [Regression wmf.23] Drop down for menu options are overlapping with Toolbar when scrolling up from Stalled to Open.
Thu, Oct 11, 1:20 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor (Current work)
matmarex closed T205956: HTMLInfoField.php: 'default' must be a FieldLayout or subclass when using 'rawrow' as Resolved.
Thu, Oct 11, 1:18 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MediaWiki-Special-pages, MediaWiki-HTMLForm
matmarex closed T205956: HTMLInfoField.php: 'default' must be a FieldLayout or subclass when using 'rawrow', a subtask of T41480: Issues affecting translatewiki.net, as Resolved.
Thu, Oct 11, 1:18 AM · Tracking, MediaWiki-General-or-Unknown
matmarex moved T205924: [Regression wmf.23] Drop down for menu options are overlapping with Toolbar when scrolling up from Stalled/Waiting to Code review on the VisualEditor (Current work) board.
Thu, Oct 11, 1:17 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor (Current work)
matmarex added a comment to T205924: [Regression wmf.23] Drop down for menu options are overlapping with Toolbar when scrolling up.

The issue occurs because two handlers for the Window 'scroll' event are executed in the wrong order:

  • A: ve.init.Target#onContainerScroll – Changes the toolbar between "floating" and normal mode
  • B: OO.ui.mixin.FloatableElement#position – Positions the dropdown relative to the toolbar
Thu, Oct 11, 1:00 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor (Current work)

Wed, Oct 10

matmarex claimed T205924: [Regression wmf.23] Drop down for menu options are overlapping with Toolbar when scrolling up.

Thanks, that helps. I can see some erratic behavior when scrolling now.


I'll investigate it.

Wed, Oct 10, 10:35 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor (Current work)
matmarex closed T206691: Rename html5shiv to html5shim as Declined.

The name may be incorrect, but it really is named shiv, so who are we to argue? https://github.com/aFarkas/html5shiv#why-is-it-called-a-shiv

Wed, Oct 10, 10:25 PM · MediaWiki-General-or-Unknown
matmarex added a comment to T206262: Remove client side code inside initEditLink in resources/skins.minerva.scripts/init.js.

Yeah, that sounds right.

Wed, Oct 10, 9:54 PM · Technical-Debt, Readers-Web-Backlog
matmarex added a comment to T184755: Consider not removing multiple blank lines/white space between paragraphs.

Also… when Parsoid parses a bunch of newlines in wikitext and outputs a bunch of <p><br></p> structures for them, it should mark the <br> node somehow so that we can ignore it in VisualEditor. Currently VisualEditor treats it as any other <br> tag and allows inserting content on either side of it (essentially, rendering it as two empty lines instead of one).

Wed, Oct 10, 8:43 PM · Patch-For-Review, Parsoid-Edit-Support, VisualEditor
matmarex added a comment to T184755: Consider not removing multiple blank lines/white space between paragraphs.

If we need to output <p><br></p> instead of <p></p> in the HTML we send to Parsoid, then I suppose we can do that.

Wed, Oct 10, 8:15 PM · Patch-For-Review, Parsoid-Edit-Support, VisualEditor
matmarex closed T196738: Inlined help needs to be part of widget's `<label>` element as Declined.

I think Prateek mostly solved the problem with rGOJUaa86508242c4: FieldLayout: Add 'for' attribute to inline help label.

Wed, Oct 10, 7:28 PM · Accessibility, OOUI
matmarex closed T196738: Inlined help needs to be part of widget's `<label>` element , a subtask of T185752: Support inline help labels as an alternative to popup help buttons (info icons), as Declined.
Wed, Oct 10, 7:28 PM · OOUI (OOUI-0.27.2), MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8))
matmarex closed T183700: References are misplaced when highlighted as Resolved.

Presumed fixed.

Wed, Oct 10, 7:18 PM · Timeless
matmarex renamed T191487: VisualEditor crashes with "Annotation with hash not found in store" when saving after pasting certain rich text content from The 2017 wikitext editor crashes with "Annotation with hash not found in store" when pasting certain rich text content to VisualEditor crashes with "Annotation with hash not found in store" when saving after pasting certain rich text content.
Wed, Oct 10, 6:52 PM · User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor-MediaWiki, VisualEditor
matmarex reopened T191487: VisualEditor crashes with "Annotation with hash not found in store" when saving after pasting certain rich text content as "Open".

I can still reproduce in visual mode.

Wed, Oct 10, 6:50 PM · User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T206262: Remove client side code inside initEditLink in resources/skins.minerva.scripts/init.js.

wgMinervaUserBlockInfo is not generated for anon users at all, exactly because of caching (anon users share one HTML cache, but each of them can be blocked separately). There was some bug about it that I can't find right now.

Wed, Oct 10, 3:35 PM · Technical-Debt, Readers-Web-Backlog
matmarex added a comment to T206262: Remove client side code inside initEditLink in resources/skins.minerva.scripts/init.js.

Here's the relevant code:

			isReadOnly = mw.config.get( 'wgMinervaReadOnly' ),
			isEditable = mw.config.get( 'wgIsProbablyEditable' ),
			blockInfo = user.isAnon() ? false : mw.config.get( 'wgMinervaUserBlockInfo', false ),
			canEdit = !isReadOnly && isEditable && !blockInfo;
Wed, Oct 10, 3:09 PM · Technical-Debt, Readers-Web-Backlog
matmarex removed a project from T205615: OOUI fieldset layouts sometimes contain widgets in visual editor components: Patch-For-Review.

I guess it's not broken…

Wed, Oct 10, 1:37 PM · Technical-Debt, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)