Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (43)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (353 w, 5 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Yesterday

matmarex closed T185284: Timeless WTE2017 preview has inconsistent styling as Resolved.

Thanks for the patch!

Wed, Jul 28, 7:38 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, Timeless, VisualEditor
matmarex moved T286608: Add unit tests for DiscussionTools topic subscription notification from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 28, 7:25 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a project to T286736: Notification not sent when a comment is added in a sub-section of the topic one subscribed to: Editing QA.
Wed, Jul 28, 7:25 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex updated the task description for T275698: Support MediaWiki:Anontalkpagetext by the New Discussion Tool.
Wed, Jul 28, 7:24 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex moved T237063: EventLogging validation errors for EditAttemptStep from Code Review to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.

We should check Logstash after this is deployed to confirm that the issue is fixed.

Wed, Jul 28, 7:22 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex added a project to T275698: Support MediaWiki:Anontalkpagetext by the New Discussion Tool: Editing QA.
Wed, Jul 28, 7:22 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T282204: Handle URLs for starting new sections.

(Apparently you can't post the new topics on the demo, or view the page while you have topic subscriptions enabled – you'll get a fat red error. This is an unrelated problem, now filed as T287611. Sorry, I didn't notice that earlier.)

Wed, Jul 28, 5:48 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex created T287611: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML() must be an instance of Wikimedia\Parsoid\DOM\Compat\Element, instance of DOMElement given.
Wed, Jul 28, 5:46 PM · Patch-For-Review, Editing-team (Tracking), DiscussionTools, Parsoid
matmarex moved T282205: Support links for starting a new topic on a page different from the one you are currently on from Doing to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.

(just waiting for T282204, no other development needed)

Wed, Jul 28, 3:30 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex moved T282204: Handle URLs for starting new sections from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 28, 3:29 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T282204: Handle URLs for starting new sections.

Demo page with more ways to add a new topic than you thought possible: https://patchdemo.wmflabs.org/wikis/014e812f6d/wiki/Talk:New_section

Wed, Jul 28, 3:27 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T282204: Handle URLs for starting new sections.

Some interesting interactions that came up when I started testing it:

Wed, Jul 28, 3:21 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a project to T259445: Unnecessary quotes in ref names in <references>...<references> sectiion: Parsoid.
Wed, Jul 28, 2:06 PM · Parsoid, VisualEditor-MediaWiki-References, VisualEditor
matmarex added a comment to T282204: Handle URLs for starting new sections.

And now, let me talk about how do we actually take over the action=edit&section=new URLs.

Wed, Jul 28, 1:48 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T282204: Handle URLs for starting new sections.

@Tacsipacsi Okay, you're correct again, I wrote my last comment quickly without thinking it through. So, right now I think that the new topic tool should only fall back to the normal wikitext editor if any of editintro, preload, preloadparams, preloadtitle is provided – and in a gadget like the warning.js one you linked, you could add &dtenable=0 to the query parameters to disable the new topic tool and fall back (this is what @DLynch proposed).

Wed, Jul 28, 1:41 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T282205: Support links for starting a new topic on a page different from the one you are currently on.

To clarify the relationship between this task and T282204: Handle URLs for starting new sections: the patch for T282204 will also resolve this task. Clicking a link to start a new topic on a different page will simply follow it, as it does now, and once the page loads, the new topic tool will open. If I understand correctly, we decided in the meeting yesterday that we are happy with that.

Wed, Jul 28, 1:26 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T277371: Take over gadgets/templates which create additional links to "Add a new topic".

To clarify the relationship between this task and T282204: Handle URLs for starting new sections: the patch for T282204 would have also resolved this task, even if none of the patches here were written. However, if we did that, then following a link added by gadget/template would require the whole page to be reloaded. The patches here allow us to do it without reloading the page, which is faster.

Wed, Jul 28, 1:26 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T287362: General site outage caused by ruwikinews usage of DPL: "upstream connect error or disconnect/reset before headers. reset reason: overflow".

@Krassotkin I think you would also benefit from re-reading the previous messages.

Wed, Jul 28, 10:57 AM · User-Ladsgroup, Wikimedia-Incident, SRE
matmarex added a comment to T287362: General site outage caused by ruwikinews usage of DPL: "upstream connect error or disconnect/reset before headers. reset reason: overflow".

@DonSimon Please re-read the previous message.

Wed, Jul 28, 7:49 AM · User-Ladsgroup, Wikimedia-Incident, SRE

Tue, Jul 27

matmarex moved T285997: Verify manual topic subscriptions supports muting from Ready to Be Worked On to QA on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 27, 9:24 PM · Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T285997: Verify manual topic subscriptions supports muting .

Also, according to https://www.mediawiki.org/wiki/Help:Notifications#mute: "You will still receive notifications if a muted user writes or participates on your user talk page".

Tue, Jul 27, 9:23 PM · Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T285997: Verify manual topic subscriptions supports muting .

I can't reproduce, I don't get the notification for the comment by muted user.

Tue, Jul 27, 9:22 PM · Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex moved T284836: [Implementation] Automatic topic subscriptions from Doing to Ready to Be Worked On on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 27, 9:09 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex claimed T282205: Support links for starting a new topic on a page different from the one you are currently on.
Tue, Jul 27, 9:09 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex claimed T282204: Handle URLs for starting new sections.
Tue, Jul 27, 9:09 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T263998: Support ordered lists with Arabic, Ol Chiki (Santali), Meetei (Manipuri), and N'Ko numerals in core.

You mentioned N'Ko language as well in the task, but the patch only implemented the other two. Does it also need a patch?

Tue, Jul 27, 9:00 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), I18n, MediaWiki-Internationalization
matmarex moved T237063: EventLogging validation errors for EditAttemptStep from Upcoming to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 27, 8:58 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex edited projects for T237063: EventLogging validation errors for EditAttemptStep, added: Editing-team (FY2021-22 Kanban Board); removed Editing-team.
Tue, Jul 27, 8:57 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex added a comment to T237063: EventLogging validation errors for EditAttemptStep.

I haven't really proved that the above is exactly what happens, but I think at this point it's a better use of time to just try it and see if that fixes the problem. I couldn't reproduce it locally, but there might be other scenarios that are just harder to reproduce.

Tue, Jul 27, 8:57 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex added a comment to T237063: EventLogging validation errors for EditAttemptStep.

I think this can occur because:

  • Tearing down and setting up the editor are both actually multi-step processes, with a few promises in the middle
  • Other code may run after a promise is resolved but before the promise success callback runs
  • We log the 'abort' event at the beginning of the teardown process; in contrast, we log 'ready' and 'loaded' at the end of the setup process.
Tue, Jul 27, 8:45 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex moved T287487: Uncaught TypeError: Cannot read property 'tools' of null from Code Review to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.

We should check the logs after this is deployed everywhere next week.

Tue, Jul 27, 7:33 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), VisualEditor, Wikimedia-production-error
matmarex added a comment to T282204: Handle URLs for starting new sections.

Maybe we should just fall back to the existing editor when any URL parameters other than ?title=...&action=edit&section=new are provided. Right now (in the limited solution implemented in T277371: Take over gadgets/templates which create additional links to "Add a new topic") we only fall back if any of editintro, preload, preloadparams, preloadtitle is provided, and other parameters are ignored.

Tue, Jul 27, 6:16 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T287315: Revise the editing toolbar's setting language.

(Also, it should say "editing toolbar" instead of "editing tools", for consistency.)

Tue, Jul 27, 5:13 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T237063: EventLogging validation errors for EditAttemptStep.

Updated logstash link in the description.

Tue, Jul 27, 3:46 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex updated the task description for T237063: EventLogging validation errors for EditAttemptStep.
Tue, Jul 27, 3:44 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
matmarex moved T287487: Uncaught TypeError: Cannot read property 'tools' of null from Needs Discussion / Investigation to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 27, 3:41 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), VisualEditor, Wikimedia-production-error
matmarex claimed T287487: Uncaught TypeError: Cannot read property 'tools' of null.
Tue, Jul 27, 3:35 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), VisualEditor, Wikimedia-production-error
matmarex created T287487: Uncaught TypeError: Cannot read property 'tools' of null.
Tue, Jul 27, 3:35 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), VisualEditor, Wikimedia-production-error
matmarex added a comment to T287315: Revise the editing toolbar's setting language.

@Tacsipacsi What if we added "…in these features" (or something similar) instead? I think that should make it clear enough, given the context of the preferences page.

Tue, Jul 27, 2:49 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T285973: Add functionality that allows language switching in editing mode.

The button could open visual editor's "Languages" dialog (currently accessible only from the hamburger menu). This would be similar to how clicking the categories at the bottom of the page opens the "Categories" dialog.

Tue, Jul 27, 1:42 PM · Readers-Web-Backlog (Tracking), Editing-team, Desktop Improvements
matmarex created T287463: Dirty diff related to link-in-link and a template.
Tue, Jul 27, 1:06 PM · DiscussionTools, Parsoid

Mon, Jul 26

matmarex moved T281044: Confusing reply tool dirty diff (caused by history merge) from Doing to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.

Fixed by this change: https://github.com/MatmaRex/dtcheck/commit/38e6a36b3f21bf70310582aca9ad2b72a6fd4149

Mon, Jul 26, 12:58 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex reopened T281044: Confusing reply tool dirty diff (caused by history merge) as "Open".

Actually this seems easy to fix, the recent changes data includes the ID of the previous revision at the time the edit was made, and we should be using that ID instead of the ID of the previous revision right now.

Mon, Jul 26, 11:17 AM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T281044: Confusing reply tool dirty diff (caused by history merge).

Also: https://en.wikipedia.org/?diff=1035102028

Mon, Jul 26, 11:03 AM · Editing-team (FY2021-22 Kanban Board), DiscussionTools

Sat, Jul 24

matmarex added a comment to T287318: TestingAccessWrapper can't be used with methods that pass arguments by reference.

We noticed the issue in code review of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/704835. I think it's an unavoidable limitation of __call (per PHP documentation: "None of the arguments of these magic methods can be passed by reference."), but @DannyS712 asked me to file a bug.

Sat, Jul 24, 4:28 AM · MediaWiki-Core-Tests
matmarex added a comment to T287318: TestingAccessWrapper can't be used with methods that pass arguments by reference.

Funnily enough, the following works in PHP 5.3, but it is a syntax error in all later versions where call-time pass-by-reference has been removed:

$a->func( &$b );

https://3v4l.org/EOJ07

Sat, Jul 24, 4:17 AM · MediaWiki-Core-Tests
matmarex created T287318: TestingAccessWrapper can't be used with methods that pass arguments by reference.
Sat, Jul 24, 4:11 AM · MediaWiki-Core-Tests
matmarex added a comment to T286094: Publicize availability of topic subscriptions via URL parameter.

It will be everyone who visits such a page (or almost everyone, depending on their user preferences), not just those who visited them before.

Sat, Jul 24, 3:36 AM · Editing-team (Tracking), Editing Design, DiscussionTools, OWC2020
matmarex added a comment to T285995: [SPIKE] Estimate growth in DiscussionTools' demand for ParserCache storage.

Technically there will be a small amount of extra storage used because we do add new html to the markup that’s being cached. I haven’t actually measured that, and the ratio will change per-page based on usage, but I’d be surprised if it was more than 2-3% or so. (This is the actual html for the reply links, and later the section headers.)

Sat, Jul 24, 3:15 AM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T286620: Bundled notifications get processed singly.

What happens:
Only the most recent comment gets highlighted in blue.
Only the most recent comment gets marked as read in the bundle.

Sat, Jul 24, 2:42 AM · Editing-team (FY2021-22 Kanban Board), DiscussionTools

Thu, Jul 22

matmarex moved T285796: Subscribe links appearing in main namespace unexpectedly from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Jul 22, 8:46 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
matmarex added a comment to T285796: Subscribe links appearing in main namespace unexpectedly.

Our [subscribe] and [reply] links are stored in the parser cache as part of the page contents, so if someone previously viewed the page and it has been cached, they will only disappear when either the page is manually purged (as @Quiddity described), or when the page is edited, or after a few weeks. Sorry, I probably should have thought about that and noted it.

Thu, Jul 22, 8:46 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
matmarex moved T277371: Take over gadgets/templates which create additional links to "Add a new topic" from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Jul 22, 8:25 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex moved T277371: Take over gadgets/templates which create additional links to "Add a new topic" from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (FY2021-22 Kanban Board) board.

But it seems like it's not working on the page you mentioned when I click on New Post: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)

Thu, Jul 22, 7:56 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex moved T262107: Create a hidden revision tag for talk page comments from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Jul 22, 7:41 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex added a comment to T262107: Create a hidden revision tag for talk page comments.

Defining qualifying edit:
Any edit that adds a talk page comment, according to our talk page parser, using the same algorithm as for generating notifications. It's somewhat complicated (and still changing as we make improvements to the notifications), but hopefully intuitively obvious? Latest version of the code for reference: EventDispatcher.php.

Thu, Jul 22, 7:39 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex updated the task description for T262107: Create a hidden revision tag for talk page comments.
Thu, Jul 22, 7:38 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex claimed T275698: Support MediaWiki:Anontalkpagetext by the New Discussion Tool.
Thu, Jul 22, 6:07 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex edited projects for T275698: Support MediaWiki:Anontalkpagetext by the New Discussion Tool, added: Editing-team (FY2021-22 Kanban Board); removed Editing-team.
Thu, Jul 22, 6:06 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Wed, Jul 21

matmarex added a comment to T287128: [Regression wmf.14] Reply link doesn't work on production after clicking on a notification from within Echo, shows error "Uncaught TypeError: Cannot read property 'id' of undefined".

It looks like you're viewing the page through Google Translate, that's probably the cause of the problem.

Wed, Jul 21, 11:51 PM · Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T277329: Implement empty state mockups for peoples' *own user* talk page.

Yes :)

Wed, Jul 21, 10:31 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Editing Design, OWC2020
matmarex moved T251348: Watchlist Expiry: Implement UI for VisualEditor [Large] from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 21, 6:29 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2021-22 Kanban Board), Community-Tech, Expiring-Watchlist-Items, VisualEditor
matmarex updated the task description for T251348: Watchlist Expiry: Implement UI for VisualEditor [Large].
Wed, Jul 21, 6:28 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2021-22 Kanban Board), Community-Tech, Expiring-Watchlist-Items, VisualEditor
matmarex moved T287035: `jQuery.Deferred exception: this.$addSectionLink is undefined` after posting a reply with DiscussionTools from Doing to QA on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 21, 6:23 PM · Verified, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Wikimedia-production-error
matmarex added a comment to T251348: Watchlist Expiry: Implement UI for VisualEditor [Large].

Everything looks good except the drop down for Watchlist time period stays enabled even when the "Watch this page" checkbox is un-checked.

Will be fixed by the patch above.

Wed, Jul 21, 6:05 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2021-22 Kanban Board), Community-Tech, Expiring-Watchlist-Items, VisualEditor
matmarex claimed T251348: Watchlist Expiry: Implement UI for VisualEditor [Large].
Wed, Jul 21, 6:02 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2021-22 Kanban Board), Community-Tech, Expiring-Watchlist-Items, VisualEditor
matmarex moved T251348: Watchlist Expiry: Implement UI for VisualEditor [Large] from Ready to Be Worked On to Doing on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 21, 6:02 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Editing-team (FY2021-22 Kanban Board), Community-Tech, Expiring-Watchlist-Items, VisualEditor
matmarex added a comment to T277329: Implement empty state mockups for peoples' *own user* talk page.

a potential scenario where people would need to create (read: start a conversation on) their own user talk page.

Wed, Jul 21, 5:43 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Editing Design, OWC2020
matmarex moved T287035: `jQuery.Deferred exception: this.$addSectionLink is undefined` after posting a reply with DiscussionTools from QA to Doing on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 21, 4:19 PM · Verified, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Wikimedia-production-error
matmarex added a comment to T287035: `jQuery.Deferred exception: this.$addSectionLink is undefined` after posting a reply with DiscussionTools.

Scheduled for later today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210721T1800

Wed, Jul 21, 4:18 PM · Verified, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Wikimedia-production-error

Tue, Jul 20

matmarex added a comment to T284836: [Implementation] Automatic topic subscriptions.

@Tacsipacsi Thanks, good points (particularly about user renames, I did not think about that).

Tue, Jul 20, 11:25 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex moved T287035: `jQuery.Deferred exception: this.$addSectionLink is undefined` after posting a reply with DiscussionTools from Needs Discussion / Investigation to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Jul 20, 8:34 PM · Verified, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Wikimedia-production-error
matmarex claimed T287035: `jQuery.Deferred exception: this.$addSectionLink is undefined` after posting a reply with DiscussionTools.
Tue, Jul 20, 8:32 PM · Verified, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Wikimedia-production-error
matmarex added a comment to T287035: `jQuery.Deferred exception: this.$addSectionLink is undefined` after posting a reply with DiscussionTools.

This is a bug in the patch for T277371: Take over gadgets/templates which create additional links to "Add a new topic".

Tue, Jul 20, 8:32 PM · Verified, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Wikimedia-production-error
matmarex created T287040: Reply tool does not work on talk pages with a background/frame created using a template.
Tue, Jul 20, 8:11 PM · DiscussionTools

Mon, Jul 19

matmarex claimed T262107: Create a hidden revision tag for talk page comments.
Mon, Jul 19, 8:06 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex added a comment to T284836: [Implementation] Automatic topic subscriptions.

Musing about implementation details:

Mon, Jul 19, 8:05 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex added a comment to T284836: [Implementation] Automatic topic subscriptions.

A few things are not completely clear to me:

Mon, Jul 19, 7:59 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
matmarex added a comment to T286954: Clarify the difference between "Talk page message" and "Talk page subscription" (on Special:Preferences → Notifications).

Here's one idea for how to rephrase it:

Mon, Jul 19, 7:45 PM · DiscussionTools, Notifications, Growth-Team
matmarex created T286954: Clarify the difference between "Talk page message" and "Talk page subscription" (on Special:Preferences → Notifications).
Mon, Jul 19, 7:43 PM · DiscussionTools, Notifications, Growth-Team
matmarex moved T285528: Improve delivery of notifications for comments posted in close succession from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Mon, Jul 19, 4:58 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T286829: When you redirect a page to another, should the page reload as ?redirect=no ?.

Currently it uses ?redirect=no, because otherwise using the page tabs (history, edit, etc.) would affect the redirect target page instead of the page you just saved.

Mon, Jul 19, 3:07 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Thu, Jul 15

matmarex claimed T286744: Dirty diffs on talk pages caused by incorrect markup in some templates on tr.wikipedia.

I searched for insource:/\<\/font size=3\>/ in the 'Template' namespace to find them: https://tr.wikipedia.org/w/index.php?search=insource%3A%2F%5C<%5C%2Ffont+size%3D3%5C>%2F&title=Özel:Ara&profile=advanced&fulltext=1&ns10=1

Thu, Jul 15, 9:01 PM · Editing-team (FY2021-22 Kanban Board)
matmarex created T286744: Dirty diffs on talk pages caused by incorrect markup in some templates on tr.wikipedia.
Thu, Jul 15, 8:33 PM · Editing-team (FY2021-22 Kanban Board)
matmarex added a comment to T281044: Confusing reply tool dirty diff (caused by history merge).

This diff found in dtcheck is caused by the same scenario: https://en.wikipedia.org/?diff=1029083485

Thu, Jul 15, 8:33 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex claimed T285528: Improve delivery of notifications for comments posted in close succession.
Thu, Jul 15, 7:16 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex moved T286736: Notification not sent when a comment is added in a sub-section of the topic one subscribed to from Needs Discussion / Investigation to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Jul 15, 6:59 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex claimed T286736: Notification not sent when a comment is added in a sub-section of the topic one subscribed to.
Thu, Jul 15, 6:41 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex updated the task description for T286736: Notification not sent when a comment is added in a sub-section of the topic one subscribed to.
Thu, Jul 15, 6:41 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex created T286736: Notification not sent when a comment is added in a sub-section of the topic one subscribed to.
Thu, Jul 15, 6:36 PM · Editing QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T286611: TypeError: Return value of JsonSchemaHooks::onEditFilterMergedContent() must be of the type boolean, none returned.

THanks for preparing these, scheduled: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210715T1800

Thu, Jul 15, 5:00 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), User-Zabe, Analytics, Analytics-EventLogging, Wikimedia-production-error
matmarex added a comment to T286611: TypeError: Return value of JsonSchemaHooks::onEditFilterMergedContent() must be of the type boolean, none returned.

I'll backport it today, this bug is causing some pages to be impossible to edit (e.g. the entire 'Schema' namespace on meta.wikimedia.org).

Thu, Jul 15, 4:21 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), User-Zabe, Analytics, Analytics-EventLogging, Wikimedia-production-error
matmarex moved T286608: Add unit tests for DiscussionTools topic subscription notification from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Jul 15, 4:09 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a comment to T260156: PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened.

I can't reproduce this.

Thu, Jul 15, 12:29 PM · Patch-For-Review, OOUI
matmarex placed T223844: Reserve space for the "Related articles" container up for grabs.
Thu, Jul 15, 11:42 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), RelatedArticles

Wed, Jul 14

matmarex moved T285796: Subscribe links appearing in main namespace unexpectedly from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jul 14, 6:44 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020

Tue, Jul 13

matmarex claimed T286608: Add unit tests for DiscussionTools topic subscription notification.
Tue, Jul 13, 8:16 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a parent task for T286608: Add unit tests for DiscussionTools topic subscription notification: T285528: Improve delivery of notifications for comments posted in close succession.
Tue, Jul 13, 8:16 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex added a subtask for T285528: Improve delivery of notifications for comments posted in close succession: T286608: Add unit tests for DiscussionTools topic subscription notification.
Tue, Jul 13, 8:16 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
matmarex created T286608: Add unit tests for DiscussionTools topic subscription notification.
Tue, Jul 13, 8:16 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), DiscussionTools