Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (47)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (491 w, 3 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Today

matmarex added a comment to T360316: Create patchdemo VM in the catalyst project for experimentation.

Thanks for the note, the setup script worked the last time I used it, but I can help debug if it doesn't work any more :)

Tue, Mar 19, 5:47 AM · Catalyst (MVP.VIP.1️⃣)

Fri, Mar 15

matmarex added a comment to T337286: Gadget API for adding buttons to section titles.

If you want to work on this, I think it needs to start with inventorying the existing gadgets to inform the design of the new API. Otherwise we risk spending time on something that doesn't actually serve the practical use cases. Until that happens, we need to continue supporting the de facto API of the .mw-editsection CSS class and associated markup.

Fri, Mar 15, 8:51 AM · Essential-Work, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), Web Team Essential Work 2024, Content-Transform-Team, MediaWiki-Core-Skin-Architecture

Thu, Mar 14

matmarex claimed T360153: Notification for user talk page edit did not link to the comment.

(I'll look into this in a week or two after I'm back home, but feel free to take it over from me if you're feeling bored)

Thu, Mar 14, 8:55 PM · DiscussionTools
matmarex created T360153: Notification for user talk page edit did not link to the comment.
Thu, Mar 14, 8:54 PM · DiscussionTools
matmarex added a project to T360131: Language selection in UploadWizard disrupts keyboard navigation: Accessibility.
Thu, Mar 14, 6:13 PM · Accessibility, Structured-Data-Backlog, Commons, UploadWizard
matmarex added a comment to T358784: Newly installed extensions don't pick up localization messages.

Oops, sorry about that. Thanks for fixing it for me.

Thu, Mar 14, 11:59 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker

Wed, Mar 13

Krinkle awarded T359939: PHP Warning: Illegal string offset 'page_len' a Love token.
Wed, Mar 13, 10:12 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-ResourceLoader, Wikimedia-production-error, MediaWiki-Platform-Team
matmarex added a comment to T359920: RadioSelectWidget in UploadWizard suppresses normal mouse use.

I think this is an old problem, previously reported in T177617. Your investigation has a lot more detail though, so maybe we should merge that task into this one.

Wed, Mar 13, 4:03 PM · UploadWizard, OOUI

Tue, Mar 12

matmarex awarded T359013: Refactor Codex HTMLForm fields to use a separate method instead of $isCodexForm a Like token.
Tue, Mar 12, 7:03 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
matmarex closed T167649: OOUI RadioSelectInputWidget does not create radiogroup element as Declined.

Per previous comment.

Tue, Mar 12, 2:57 PM · WMDE-TechWish, Accessibility, OOUI
matmarex added a comment to T359939: PHP Warning: Illegal string offset 'page_len'.

(I won't have the time today to backport this, I hope someone else can do it.)

Tue, Mar 12, 2:55 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-ResourceLoader, Wikimedia-production-error, MediaWiki-Platform-Team
matmarex claimed T359939: PHP Warning: Illegal string offset 'page_len'.

I spent a few minutes re-reading the code, and I think page_len is always set, but the titleInfo array we're building in that code is multi-dimensional, and we got confused about which level we're on.

Tue, Mar 12, 2:37 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-ResourceLoader, Wikimedia-production-error, MediaWiki-Platform-Team

Mon, Mar 11

matmarex closed T359522: Replace usage of wfGetDB() in ResourceLoader before the 1.42 cut so it can be hard-deprecated as Resolved.
Mon, Mar 11, 7:56 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Technical-Debt
matmarex closed T359522: Replace usage of wfGetDB() in ResourceLoader before the 1.42 cut so it can be hard-deprecated, a subtask of T273239: Stop using, deprecate, and then remove wfGetDB(), as Resolved.
Mon, Mar 11, 7:56 PM · MW-1.42-release, Technical-Debt, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MediaWiki-General
matmarex closed T359214: Non-Latin characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work as Resolved.
Mon, Mar 11, 7:55 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), I18n, SyntaxHighlight
matmarex created T359878: External link in commit message rendered incorrectly in Gerrit.
Mon, Mar 11, 7:36 PM · Gerrit
matmarex closed T357812: `DOMCompat::querySelector( $fragment, 'mw\\:editsection' )` throws "InvalidArgumentException: Unknown Selector: :editsection" as Resolved.
Mon, Mar 11, 6:54 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP, Parsoid
matmarex closed T358418: Make the value field required on Special:Redirect as Resolved.

Thanks!

Mon, Mar 11, 6:36 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Special-pages
matmarex added a comment to T359409: Need a soft dependency mechanism for QUnitTestModules?.

There's no built-in mechanism in ResourceLoader, but it's fairly easy to implement it for your own module, for example:

(This would work when defining the QUnitTestModule as well.)

Mon, Mar 11, 4:15 PM · WMDE-TechWish-Sprint-2024-03-13, MediaWiki-ResourceLoader, Browser-Tests, WMDE-TechWish-Sprint-2024-02-28, Page-Previews, MediaWiki-Platform-Team
matmarex closed T306206: Rendering the table of contents splits the parser cache by user language (even if the TOC is not shown) as Resolved.

This has been fixed somewhere in the recent ParserOutput refactoring, I don't feel like figuring out which patch exactly did it.

Mon, Mar 11, 3:06 PM · MediaWiki-Parser
matmarex closed T8411: Suppress section edit links and table of contents when rendering interface text, a subtask of T50719: Issues related to section editing (tracking), as Resolved.
Mon, Mar 11, 3:02 PM · Tracking-Neverending, MediaWiki-Page-editing
matmarex closed T8411: Suppress section edit links and table of contents when rendering interface text as Resolved.

Presumably fixed.

Mon, Mar 11, 3:02 PM · MediaWiki-Parser
matmarex added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Yes, it will. (Although you'll need to update it again when the other changes in this task land – see https://www.mediawiki.org/wiki/Heading_HTML_changes.)

Mon, Mar 11, 1:42 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Sun, Mar 10

matmarex merged T359780: In Wikifunctions, raw HTML is shown on Discussion Tools headers on empty talk pages into T344491: DiscussionTools empty talk page message double-escapes Wikifunctions ZID.
Sun, Mar 10, 11:51 PM · WikiLambda, Editing-team, Abstract Wikipedia team, DiscussionTools, Wikifunctions
matmarex added a project to T344491: DiscussionTools empty talk page message double-escapes Wikifunctions ZID: WikiLambda.
Sun, Mar 10, 11:50 PM · WikiLambda, Editing-team, Abstract Wikipedia team, DiscussionTools, Wikifunctions
matmarex merged task T359780: In Wikifunctions, raw HTML is shown on Discussion Tools headers on empty talk pages into T344491: DiscussionTools empty talk page message double-escapes Wikifunctions ZID.
Sun, Mar 10, 11:50 PM · Abstract Wikipedia team, DiscussionTools, WikiLambda, Wikifunctions
matmarex added a comment to T359758: DiscussionTools: subscribe button is hidden behind collapsed sections.

Wrapping the collapsed fragment in <div class="mw-notalk">...</div> or in <blockquote>...</blockquote> (as documented at https://www.mediawiki.org/wiki/Help:DiscussionTools/Magic_words_and_markup) would also make the subscribe button and discussion metadata work as intended.

Sun, Mar 10, 11:45 PM · DiscussionTools
matmarex added a comment to T359683: Remove ligatures from <pre>, <code>.

I'm not sure if this would be a good idea, there are some monospace fonts that include ligatures for some sequences like -> and != (see e.g. https://www.hanselman.com/blog/monospaced-programming-fonts-with-ligatures) and we probably shouldn't disable these if the user chose to use such a font.

Sun, Mar 10, 11:27 PM · MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface

Sat, Mar 9

matmarex added a comment to T358985: Admin account created by the installer isn't made global by CentralAuth.

Well, the good news is that it's a problem in the installer, so having it set up wouldn't really help ;) I would mostly rely on CI to test it for me, testing the installation process is annoying enough already.

Sat, Mar 9, 2:03 AM · Continuous-Integration-Config, MediaWiki-Installer, ci-test-error, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex awarded T359222: Improve indicator for optional parameters a Like token.
Sat, Mar 9, 1:47 AM · Patch-For-Review, JSDoc WMF theme

Fri, Mar 8

matmarex added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

@stjn I didn't know about that. Well, again, it's my bad.

Fri, Mar 8, 8:04 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
matmarex added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Sorry, I was busy recently and haven't looked at this task.

Fri, Mar 8, 4:34 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Thu, Mar 7

matmarex closed T114532: MWDebug toolbar log is empty when Monolog is enabled as Resolved.
Thu, Mar 7, 7:46 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Debug-Logger
matmarex removed a project from T68637: Make it possible to distinguish Wikitext headings and HTML headings: Patch-For-Review.
Thu, Mar 7, 7:23 PM · MediaWiki-Parser
matmarex added a project to T358932: Recent changes show temporary users when "Newcomers", "Learners" or "Experienced users" selected: MediaWiki-Recent-changes.
Thu, Mar 7, 5:31 PM · MediaWiki-Recent-changes, Growth-Team, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Temporary accounts
matmarex closed T358932: Recent changes show temporary users when "Newcomers", "Learners" or "Experienced users" selected as Resolved.
Thu, Mar 7, 5:31 PM · MediaWiki-Recent-changes, Growth-Team, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Temporary accounts
matmarex added a comment to T358940: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes.

More examples: T89947#9538996, T352308#9609776 (I swear I'm not going looking for them, these are just from tasks in my inbox, so this seems like a common problem)

Thu, Mar 7, 12:08 PM · Phabricator, GerritBot

Wed, Mar 6

matmarex added a comment to T338039: TextFormatter treats all messages as non-interface messages.

The interface flag should be set when parsing wiki interface, and unset when parsing wiki content. It's checked only to enable and disable some parser features in the interface and content: https://codesearch.wmcloud.org/search/?q=getInterfaceMessage (the reasons behind of them are more obvious than others… don't ask me why these features in particular).

Wed, Mar 6, 10:28 PM · MediaWiki-Parser, I18n, MediaWiki-Internationalization
matmarex added a comment to T359405: Create temporary account for edit attempts before pre-save hooks run in EditPage.

I don't really have time to dive into this, but if we're okay with the predicted increase in the number of temporary accounts, then this seems fine to me. In fact logging AbuseFilter hits this way seems like an improvement, and it probably makes a lot of things easier to implement (and design, and communicate to users).

Wed, Mar 6, 9:58 PM · Patch-For-Review, Temporary accounts
matmarex awarded T89947: Move special page alias translations to JSON a Love token.
Wed, Mar 6, 9:30 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Language-Team (Language-2024-January-March), Localization Infrastructure FY2023-24, Patch-For-Review, translatewiki.net, MediaWiki-Internationalization, I18n
matmarex closed T358946: Peast complains about backslash that is part of a regex in valid JS code as Resolved.

The fix will be deployed to Wikimedia wikis next week, between Tuesday and Thursday, per the usual schedule.

Wed, Mar 6, 9:11 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex closed T359014: XFDcloser gadget intermittently failing Peast validation as Resolved.

Yes. The fix will be deployed to Wikimedia wikis next week, between Tuesday and Thursday, per the usual schedule.

Wed, Mar 6, 9:11 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex created T359469: No visual diff inside <syntaxhighlight> block.
Wed, Mar 6, 8:55 PM · SyntaxHighlight, VisualEditor-VisualDiffs, VisualEditor
matmarex closed T357654: Replace usage of wfGetDB() in ORES before the 1.42 cut so it can be hard-deprecated, a subtask of T273239: Stop using, deprecate, and then remove wfGetDB(), as Resolved.
Wed, Mar 6, 5:34 PM · MW-1.42-release, Technical-Debt, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MediaWiki-General
matmarex closed T357654: Replace usage of wfGetDB() in ORES before the 1.42 cut so it can be hard-deprecated as Resolved.

Resolved in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/1003397, I don't know why the bot didn't tag it.

Wed, Mar 6, 5:34 PM · ORES, Machine-Learning-Team, Technical-Debt
matmarex closed T357633: Replace usage of wfGetDB() in AntiSpoof before the 1.42 cut so it can be hard-deprecated, a subtask of T273239: Stop using, deprecate, and then remove wfGetDB(), as Resolved.
Wed, Mar 6, 5:32 PM · MW-1.42-release, Technical-Debt, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MediaWiki-General
matmarex closed T357633: Replace usage of wfGetDB() in AntiSpoof before the 1.42 cut so it can be hard-deprecated as Resolved.
Wed, Mar 6, 5:32 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), AntiSpoof, Technical-Debt
matmarex closed T357653: Replace usage of wfGetDB() in OAuth before the 1.42 cut so it can be hard-deprecated, a subtask of T273239: Stop using, deprecate, and then remove wfGetDB(), as Resolved.
Wed, Mar 6, 5:31 PM · MW-1.42-release, Technical-Debt, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MediaWiki-General
matmarex closed T357653: Replace usage of wfGetDB() in OAuth before the 1.42 cut so it can be hard-deprecated as Resolved.
Wed, Mar 6, 5:31 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, MediaWiki-extensions-OAuth, Technical-Debt
matmarex updated the task description for T330641: Switch from LoadBalancer::getConnection() to ICP::getReplicaDatabase/getPrimaryDatabase.
Wed, Mar 6, 5:31 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-General, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Patch-For-Review, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Platform Engineering
matmarex closed T359290: ArgumentCountError: Too few arguments to function MediaWiki\Extension\Gadgets\GadgetRepo::titleWithoutPrefix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.21/extensions/Gadgets/includes/GadgetResourceLoaderModule.php on line 80 as Resolved.
Wed, Mar 6, 4:25 PM · Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-02-28, MediaWiki-Platform-Team (Radar), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-extensions-Gadgets, Wikimedia-production-error
matmarex closed T359290: ArgumentCountError: Too few arguments to function MediaWiki\Extension\Gadgets\GadgetRepo::titleWithoutPrefix(), 1 passed in /srv/mediawiki/php-1.42.0-wmf.21/extensions/Gadgets/includes/GadgetResourceLoaderModule.php on line 80 , a subtask of T354439: 1.42.0-wmf.21 deployment blockers, as Resolved.
Wed, Mar 6, 4:23 PM · Release-Engineering-Team (Now this 🫠), Release, Train Deployments
matmarex added a comment to T283461: Change datatype of cl_timestamp from timestamp to binary(14).

It looks like we already treat this field as a standard binary(14) timestamp in the code in some places, e.g.:

Wed, Mar 6, 2:59 PM · MediaWiki-Categories, Platform Team Workboards (Clinic Duty Team), Schema-change
matmarex awarded T355248: [M] Adopt the css gadget for responsive design on UploadWizard into the UW extension itself a Love token.
Wed, Mar 6, 10:41 AM · Structured-Data-Backlog (Current Work), UploadWizard
matmarex added a comment to T358985: Admin account created by the installer isn't made global by CentralAuth.

Could it be done in the LoadExtensionSchemaUpdates hook handler?

If you can reliably differentiate between install and update then yes. Otherwise, you'd have to be very careful not to violate any expectations as CentralAuth still supports various partially-unified modes.

I don't think it's officially supported. I do remember of a hacky way (possibly some config values being unset), but that's not reliable.

Wed, Mar 6, 1:58 AM · Continuous-Integration-Config, MediaWiki-Installer, ci-test-error, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth

Tue, Mar 5

matmarex added a comment to T354015: DBQueryDisconnectedError upon editing en:Template:COVID-19 pandemic data.

@matmarex I think we should:

  1. keep refreshing the rest of the hosts including codfw hosts (there is no harm in doing so)
  2. Prepare a patch to hint the use of the preferred index.
Tue, Mar 5, 10:50 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, DBA, Wikimedia-Slow-DB-Query, MediaWiki-Core-Revision-backend, Wikimedia-production-error
matmarex closed T358810: Having <> in headings leads to errors as Resolved.

Deployed to all wikis, looks fixed.

Tue, Mar 5, 9:46 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team, DiscussionTools
matmarex moved T358946: Peast complains about backslash that is part of a regex in valid JS code from Blocked/waiting to Current Sprint on the MediaWiki-Platform-Team board.
Tue, Mar 5, 9:12 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex moved T359014: XFDcloser gadget intermittently failing Peast validation from Blocked/waiting to Current Sprint on the MediaWiki-Platform-Team board.
Tue, Mar 5, 9:12 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex closed T359143: Signatures containing score are not recognized by DiscussionTools as Declined.

Sure.

Tue, Mar 5, 8:48 PM · DiscussionTools, MediaWiki-extensions-Score
matmarex added a project to T359214: Non-Latin characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work: I18n.
Tue, Mar 5, 8:44 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), I18n, SyntaxHighlight
matmarex created T359214: Non-Latin characters in <syntaxhighlight line linelinks=…> generate clickable links that don't work.
Tue, Mar 5, 8:44 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), I18n, SyntaxHighlight
matmarex added a comment to T358810: Having <> in headings leads to errors.

I'm sorry everyone, I wanted to backport this fix yesterday, but the deployment window has been cancelled due to problems with the platform (T359155), and the same thing happened when I tried again this afternoon. I'll try again when the problems are resolved.

Tue, Mar 5, 3:51 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team, DiscussionTools
matmarex added a comment to T358250: Full screen dialogs are truncated by scrollbar gutter.

scrollbar-gutter is supposed to be one of the things browser makers want to work in 2024: https://web.dev/blog/interop-2024 so I would say there's a chance.

Tue, Mar 5, 1:45 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
matmarex added a comment to T359143: Signatures containing score are not recognized by DiscussionTools.

Yeah, I agree with that. Score isn't recognized in signatures because it outputs a <div> tag. It doesn't work for the same reasons that <math display="block"> and <pre> don't work.

Tue, Mar 5, 11:56 AM · DiscussionTools, MediaWiki-extensions-Score

Mon, Mar 4

matmarex moved T322457: Only include one set of DiscussionTools buttons in the page HTML from Incoming to QA on the Editing-team (Kanban Board) board.
Mon, Mar 4, 7:41 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, DiscussionTools
matmarex added a project to T322457: Only include one set of DiscussionTools buttons in the page HTML: Editing-team (Kanban Board).
Mon, Mar 4, 7:40 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, DiscussionTools
matmarex added a comment to T358961: Clarify use of OrExpressionGroup / AndExpressionGroup as both are not stable and constructor is internal to rdbms.

I'm glad you reviewed that code, since these patches were all clear improvements, but I'm not a fan of the ones using factorConds(). I wasn't even aware that this method exists before, and although it's neat now that I know about it, it doesn't seem that obvious what it does. I think it's important that the query building code clearly says or/and, anyOf/allOf, or something like that, instead of having all of the operators be implied.

Mon, Mar 4, 7:38 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MediaWiki-libs-Rdbms
matmarex claimed T358946: Peast complains about backslash that is part of a regex in valid JS code.

Reported upstream: https://github.com/mck89/peast/issues/68

Mon, Mar 4, 7:15 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex claimed T359014: XFDcloser gadget intermittently failing Peast validation.

Reported upstream: https://github.com/mck89/peast/issues/68

Mon, Mar 4, 7:15 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex added a comment to T358946: Peast complains about backslash that is part of a regex in valid JS code.

The plwiki script has been reworked to avoid ResourceLoader minification, so this isn't urgent at this point. See:

Mon, Mar 4, 7:14 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex closed T357477: InvalidArgumentException: Script must be a string or array as Resolved.
Mon, Mar 4, 7:06 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
matmarex added a comment to T322457: Only include one set of DiscussionTools buttons in the page HTML.

(It's live on the beta cluster now, if you want to double-check: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page)

Mon, Mar 4, 6:44 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, DiscussionTools
matmarex added a comment to T358087: Create user preference to receive change notification emails for bot edits.

I understand that this is not the solution you're asking for, but just in case it helps, let me note that there's an Atom feed (like RSS) available for your watchlist – you can access it by clicking the "Atom" link in the sidebar (it will generate a URL with a secret token that allows accessing your watchlist without logging in).

Mon, Mar 4, 5:56 PM · Mail
matmarex claimed T358985: Admin account created by the installer isn't made global by CentralAuth.
Mon, Mar 4, 4:20 PM · Continuous-Integration-Config, MediaWiki-Installer, ci-test-error, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex added a comment to T359014: XFDcloser gadget intermittently failing Peast validation.

May be the same as T358946, there is a similar regexp in the source code here: /\n={3,}/. I'm confused why it would only fail intermittently though…

Mon, Mar 4, 4:15 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, MediaWiki-ResourceLoader

Sun, Mar 3

matmarex updated subscribers of T358961: Clarify use of OrExpressionGroup / AndExpressionGroup as both are not stable and constructor is internal to rdbms.
Sun, Mar 3, 10:02 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MediaWiki-libs-Rdbms
matmarex added a comment to T358981: Talk page discussion parsing is broken on mobile views with Parsoid read views enabled.

This doesn't seem specific to DiscussionTools. I see several problems on mobile when using Parsoid read views.

Sun, Mar 3, 7:35 PM · Parsoid (Tracking), DiscussionTools, MobileFrontend, Parsoid-Read-Views

Sat, Mar 2

matmarex added a comment to T358946: Peast complains about backslash that is part of a regex in valid JS code.

Minimal test case: Peast\Peast::ES2016( '/=\n/' )->parse();

Sat, Mar 2, 5:31 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex added a comment to T358946: Peast complains about backslash that is part of a regex in valid JS code.

I applied a temporary workaround in the gadget: https://pl.wikipedia.org/w/index.php?title=MediaWiki:Gadget-sk.js&diff=prev&oldid=73036090

Sat, Mar 2, 5:06 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex added a comment to T358946: Peast complains about backslash that is part of a regex in valid JS code.

I reproduced locally, it's caused by the mck89/peast upgrade from T357477 (which fixed a different bug like this). That was already deployed a week ago, but I guess we cache these for a while.

Sat, Mar 2, 5:00 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
matmarex added a comment to T358940: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes.

I guess that also works, but I really think this is a problem on the Phabricator side. Our repositories are big enough that 7-hexdigit hashes are too short to be unambiguous. Git itself uses adaptive length depending on the repo size, and I'm seeing 11-hexdigit short hashes in my clone of mediawiki/core (and if it knew about all the other repos, they'd probably be longer).

Sat, Mar 2, 2:35 PM · Phabricator, GerritBot
matmarex created T358940: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes.
Sat, Mar 2, 5:40 AM · Phabricator, GerritBot

Fri, Mar 1

matmarex claimed T358932: Recent changes show temporary users when "Newcomers", "Learners" or "Experienced users" selected.
Fri, Mar 1, 11:56 PM · MediaWiki-Recent-changes, Growth-Team, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Temporary accounts
matmarex created T358932: Recent changes show temporary users when "Newcomers", "Learners" or "Experienced users" selected.
Fri, Mar 1, 11:56 PM · MediaWiki-Recent-changes, Growth-Team, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Temporary accounts
matmarex added a comment to T358903: Vector search field disappears after focussing when using ResourceLoader debug mode 1.

Thanks!

Fri, Mar 1, 10:21 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Desktop Improvements (Vector 2022)
matmarex claimed T358810: Having <> in headings leads to errors.
Fri, Mar 1, 7:39 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team, DiscussionTools
matmarex created T358903: Vector search field disappears after focussing when using ResourceLoader debug mode 1.
Fri, Mar 1, 7:18 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Desktop Improvements (Vector 2022)
matmarex closed T358874: Parsoid EditSectionLink edge case on ruwiki as Resolved.

https://ru.wikipedia.org/w/index.php?title=MediaWiki:Gadget-edittop.js&diff=prev&oldid=136450234

Fri, Mar 1, 7:13 PM · Content-Transform-Team, Parsoid, Parsoid-Read-Views
matmarex updated subscribers of T322457: Only include one set of DiscussionTools buttons in the page HTML.

@AlexisJazz FYI too, looks like Factotum does some stuff to the links/buttons.

Fri, Mar 1, 6:16 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, DiscussionTools
matmarex added a comment to T322457: Only include one set of DiscussionTools buttons in the page HTML.

@Jack_who_built_the_house FYI, in case Convenient Discussions depends on the current markup. You can try the new one in the demo above.

Fri, Mar 1, 6:05 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, DiscussionTools
matmarex added a comment to T358372: TypeError: Cannot read properties of null (reading 'nodeName').

You can verify that by searching for the error messages generated by Firefox, which include more details.

Fri, Mar 1, 5:56 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), JavaScript, Web-Team-Backlog (FY2023-24 Q3 Sprint 4), Wikimedia-production-error
matmarex updated subscribers of T322457: Only include one set of DiscussionTools buttons in the page HTML.
Fri, Mar 1, 5:45 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Technical-Debt, DiscussionTools
matmarex moved T13555: .mw-editsection links should not be part of the <h#> element from Not ready to announce to In current Tech/News draft on the User-notice board.

Noted in https://meta.wikimedia.org/wiki/Tech/News/2024/10. Current draft:

The HTML markup of headings and section edit links will be changed later this year to improve accessibility. See Heading HTML changes for details. The new markup will be the same as in the new Parsoid wikitext parser. You can test your gadget or stylesheet with the new markup if you add ?useparsoid=1 to your URL (more info) or turn on Parsoid read views in your user options (more info).

Fri, Mar 1, 5:33 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
matmarex updated subscribers of T358874: Parsoid EditSectionLink edge case on ruwiki.

The link is added by a gadget (there are lots of gadgets that add an edit link to the top section, and they're all slightly different). I can have a look at why it's not adding it in the Parsoid version.

Fri, Mar 1, 4:00 PM · Content-Transform-Team, Parsoid, Parsoid-Read-Views
matmarex merged task T358875: Section titles with ">" in them result in exposed HTML into T358810: Having <> in headings leads to errors.
Fri, Mar 1, 3:59 PM · MediaWiki-Parser
matmarex merged T358875: Section titles with ">" in them result in exposed HTML into T358810: Having <> in headings leads to errors.
Fri, Mar 1, 3:59 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team, DiscussionTools
Mainframe98 awarded T358779: MessageValue and Message should share a common interface; MediaWiki\Message\Converter should be unnecessary a Mountain of Wealth token.
Fri, Mar 1, 8:40 AM · Patch-For-Review, MediaWiki-Internationalization

Thu, Feb 29

matmarex added a project to T358810: Having <> in headings leads to errors: Content-Transform-Team.

This happens because DiscussionTools's CommentFormatter, and MediaWiki core's HandleSectionLinks, expect different HTML serialization.

Thu, Feb 29, 10:01 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team, DiscussionTools
matmarex removed a project from T358810: Having <> in headings leads to errors: Parsoid.

Looks like the bug only affects pages with DiscussionTools (not main namespace). It's actually the > by itself which triggers the problem. It's probably somehow caused by rMW834ff25dc1ab: Move section heading formatting to post-cache transform (take 2).

Thu, Feb 29, 9:49 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team, DiscussionTools