The spacing with that patch is weird. The help labels almost look like headings for the field below them.
This is because when replying to transcluded comments, we update the page after saving using action=parse output, and it does not include our server-generated reply links. The exception occurs because we can't find the reply to highlight.
Tue, Oct 20
There have been no recent changes to CharInsert, it's a very dead project (or, you could say, very feature-complete).
I'll spare everyone else the notifications… In the future, you can probably just disturb @ppelberg and he'll disturb one of us ;)
What do you mean by "there's more"? There is certainly some root problem in jquery.makeCollapsible or jquery.tablesorter, which could presumably be debugged and resolved, but I did not have time to debug this further, and just making them run in this order seemed reliable enough (see T64878).
Patch will be deployed this week, 20-22 October, per the usual schedule.
Mon, Oct 19
I'd like to use this occasion to complain about the blockquote styling in Minerva (and the guide) :)
Thank you for the patch!
Deployed to Wikimedia wikis now.
I scheduled the backport for deployment later today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20201019T1800
Sat, Oct 17
Also, to be clear, this problem only affects the mobile site – you can switch to the desktop site temporarily to use your watchlist (although I understand this is an annoyance).
Potentially similar problem on pt.wp: https://pt.wikipedia.org/?diff=59606108
Fri, Oct 16
I think most of the above are caused by a single common pattern. For example, in Kartographer, this line causes it: padding-top: 4 / 14em;.
That makes core tests pass (and Vector – apparently it wasn't fine, no idea how I missed it).
This will be deployed next week, 20-22 October, per the usual schedule.
Apparently there is a LessFileCompilationTest, which will fail if the LESS compilation fails for any module, so you just need to run the MediaWiki unit tests for your skin/extension and check the results. This makes it much easier to find the problematic code.
And some HTML snippets from that. Several things look wrong here. I don't know enough about Parsoid to guess the issue, but it might offer some hints for you:
The affected transclusion is from https://pl.wikipedia.org/wiki/Wikipedia:Poczekalnia/biografie. I looked there, and a single section on that page is also not marked correctly as a transclusion:
Parsoid is incorrectly marking up the transclusions: https://pl.wikipedia.org/api/rest_v1/page/html/Wikipedia%3APoczekalnia%2FZgłoszenia?redirect=false&stash=true
Thu, Oct 15
Special:MobileDiff is just the worst :(
This probably is (or was) the same kind of issue as T265543.
The problem no longer occurs on this page because the template was substituted: https://cs.wikipedia.org/w/index.php?diff=19075859&oldid=19075730. But it's a real issue, I could reproduce it yesterday when talking with @Urbanecm about it.
Looks like a problem with the definition of mediawiki.messagePoster in core MediaWiki.
Also, some further details on why this happened.
Seems to work now on thwiki and newiki at a glance. I couldn't easily find a suitable discussion page to test on the others – it looks like their date formats or timezones changed recently, and timestamps generated before the change won't be recognized by DiscussionTools. The regular QA in T264693 should cover them, I guess.
Fixed and backported. The "Describe" step on https://commons.wikimedia.org/wiki/Special:UploadWizard looks normal to me again.
The patch definitely causes some issues. Most things I checked were fine (e.g. core, Vector, VisualEditor), but Minerva styles failed. I'm not planning to track this down right now, but maybe someone will.
(I previously did this for OOUI: https://gerrit.wikimedia.org/r/c/oojs/ui/+/535932)
We are backporting it today (right now, in fact).
Also affects UploadWizard: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/634290
And there are other places in UploadWizard that have a workaround for this problem, we just need to do the same here:
Yeah, they look like the same problem.
Backporting to wmf.11 and wmf.13:
- ✅ Sticky preference: if you customize the edit summary of the last comment you posted with the Reply Tool, the next time you open the tool the "Advanced" shelf should be shown.
- Special:Preference: create a new preference in Special:Preferences that enables people to explicit decide whether the "Advanced" shelf be always shown or not
Wed, Oct 14
The caller is initDesktop() in Echo, but the underlying problem is T265506.
This is T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash. The %E5 in the URL is the reason.
On maiwiki, mnwwiki, newiki, thwiki the reply links are not showing up – this is reported as T265500 and should be fixed tomorrow.
If we didn't add nowiki tags in visual mode, then it would no longer be visual.
It looks like DateTime::format( 'T' ) and DateTimeZone::listAbbreviations() produce different abbreviations for these timezones, which I didn't know was possible. E.g. on thwiki, the timezone is Asia/Bangkok, the former outputs "+07" and the latter "BMT", and that is the reason why we don't recognize the timestamps.
We've also already updated VisualEditor to use the latest version of the library in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/632981.