matmarex (Bartosz Dziewoński)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (131 w, 5 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Yesterday

matmarex edited the description of T155862: VisualEditor-MediaWiki: Don't be "smart" about only running jsduck on JS file changes.
Wed, Apr 26, 5:24 PM · VisualEditor, Continuous-Integration-Config
matmarex added a comment to T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.

(If we end up making a breaking change because of this, we might want to come up with an entirely different API for waiting for a dialog to open/close. Multiple people told me that the chained promises we have are extremely weird.)

Wed, Apr 26, 4:22 PM · OOjs-UI
matmarex added a comment to T99736: Special:Categories on wikisource.org -> "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException" error.

I guess this depends on T130067 now, then…

Wed, Apr 26, 3:58 PM · Patch-For-Review, MediaWiki-Categories, Wikimedia-log-errors, MediaWiki-Special-pages, Wikisource
matmarex added a subtask for T99736: Special:Categories on wikisource.org -> "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException" error: T130067: Add wl_id to watchlist tables on production dbs.
Wed, Apr 26, 3:58 PM · Patch-For-Review, MediaWiki-Categories, Wikimedia-log-errors, MediaWiki-Special-pages, Wikisource
matmarex added a parent task for T130067: Add wl_id to watchlist tables on production dbs: T99736: Special:Categories on wikisource.org -> "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException" error.
Wed, Apr 26, 3:58 PM · Epic, User-Addshore, Expiring-Watchlist-Items, MediaWiki-Watchlist, DBA, Blocked-on-schema-change, TCB-Team
matmarex added a comment to T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.

So, it shouldn't be possible to resolve a promise with another promise? Is there a way to work around this, other than wrapping the value in some object, which would be a breaking change for OOjs UI?

Wed, Apr 26, 3:47 PM · OOjs-UI
matmarex added a comment to T155769: Spurious completely empty `image` table row on commonswiki.

\o/

Wed, Apr 26, 3:41 PM · MW-1.29-release-notes, MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Patch-For-Review, Operations, DBA, Wikimedia-General-or-Unknown
matmarex added a comment to T163885: OOjs UI non-modal windows and dialogs miss default CSS.

Looking at the patch on T162147, it seems like you want a "normal" dialog that doesn't block interaction with other things on the page? Out of curiosity, can you upload a screenshot of how it looks?

Wed, Apr 26, 3:35 PM · WMDE-QWERTY-Team-Board, OOjs-UI
matmarex added a comment to T51969: OOjs UI: Dialogs should be repositionable/draggable.

I still think something like a split-screen mode would be a better solution for these cases than movable dialogs (see mockup above in T51969#821409).

Wed, Apr 26, 3:34 PM · Epic, OOjs-UI
matmarex added a comment to T163885: OOjs UI non-modal windows and dialogs miss default CSS.

Non-modal windows are a weird beast. I can't say if this was a good decision, but it is intentional, due to how non-modal windows were used in VisualEditor. For example, the "Special character" tool in VisualEditor is actually a non-modal window:

Wed, Apr 26, 3:24 PM · WMDE-QWERTY-Team-Board, OOjs-UI

Tue, Apr 25

matmarex removed a project from T163762: Random Article button may be breaking in Russian : MediaWiki-General-or-Unknown.
Tue, Apr 25, 1:06 PM · Wikipedia-iOS-App-Backlog

Mon, Apr 24

matmarex added a comment to T163715: Update appearance of TablePager nav component.

I'm not sure what I was thinking months ago, but right now I have no strong feelings about this, as long as we're talking about just these buttons/links shown on the screenshot (TablePager::getNavigationBar()). TablePager also includes code for generating the entire table show on these pages, and I feel that should not be an OOjs UI widget. It's just a table.

Mon, Apr 24, 5:56 PM · Patch-For-Review, UI-Standardization, MediaWiki-General-or-Unknown, OOjs-UI
matmarex added a comment to T163536: OO.ui.ComboBoxInputWidget should scroll back to the top if no exact match is found after filtering via filterFromInput: true.

It's not a vanilla ComboBoxInputWidget, ve.ui.MWSyntaxHighlightWindow passes filterFromInput: true to its menu, which apparently confuses it. filterFromInput: true means to hide options that do not partially match the text field contents; the normal behavior is to select an option that completely matches the input. And we're seeing a confusing mix of both.

Mon, Apr 24, 5:44 PM · Patch-For-Review, OOjs-UI, VisualEditor, SyntaxHighlight
matmarex added a comment to T163535: Upload verification-error possibly triggered by EXIF.

These weird checks exist because of an IE 5-7 misfeature where it would sometimes ignore the Content-Type indicated by the server, and instead treat things as HTML. In some cases that would lead to XSS vulnerabilities. Documentation of this is sparse because most sites stopped bothering to detect these cases ten years ago or so (thus leaving IE 5-7 users vulnerable to those attacks). Our code for it was introduced in 2004 by Brion Vibber: rSVN5580 (it changed several times afterwards, but this is the first version). We apparently later widened them to handle a similar misfeature in some version of Safari. (And there's apparently an additional, more precise check using the IEContentAnalyzer library developed back in the day by Tim Starling, which probably causes fewer false positives.)

Mon, Apr 24, 5:36 PM · MediaWiki-Uploading, Multimedia, Commons
matmarex closed T23249: Add configuration setting to disable script detection during upload as "Resolved".

Configuration variable $wgDisableUploadScriptChecks exists since 2011: d14f8c89a0fc8779da5370a4de6ae248c80e365a (rSVN103772).

Mon, Apr 24, 12:02 PM · Multimedia, MediaWiki-Uploading
matmarex closed T20411: The upload form only checks upload_max_filesize, not post_max_size as "Resolved".

This was fixed again in 05c27c3af122b57f896927e5092bd25a9d8808d3 (in 2012). And since ed6648427a86d6893deb219081a96e337a1141cb, the logic is centralized in UploadBase.

Mon, Apr 24, 11:51 AM · Multimedia, MediaWiki-Uploading
matmarex added a comment to T156907: OOjs UI documentation: Improve docs for $overlay config parameter.

Thanks for the reminder, done.

Mon, Apr 24, 8:47 AM · Patch-For-Review, Documentation, OOjs-UI
matmarex placed T88629: Document public properties up for grabs.
Mon, Apr 24, 8:46 AM · Documentation, OOjs-UI
matmarex added a comment to T163652: HorizontalLayout should provide widgets with label.

I don't understand what you mean here. HorizontalLayout by itself has no meaning; it's basically a hack so that people who are afraid of CSS don't have to write .foo { display: inline-block; } to display things on one line. Can you provide a code sample which results in poor accessibility and where we could magically make things better?

Mon, Apr 24, 8:33 AM · Accessibility, OOjs-UI

Sat, Apr 22

Prtksxna awarded T149654: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox a Cup of Joe token.
Sat, Apr 22, 11:43 AM · OOjs-UI (OOjs-UI-0.21.2), UI-Standardization, Accessibility, UI-Standardization-Kanban
matmarex added a comment to T163597: Timeout in WikiPage::insertRedirectEntry after move.

Error details:

[WPmtzArAEFEAAB9ovAMAAABX] /w/index.php?title=Spezial:Verschieben&action=submit   DBQueryError from line 1063 of /srv/mediawiki/php-1.29.0-wmf.20/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: INSERT INTO `redirect` (rd_from,rd_namespace,rd_title,rd_fragment,rd_interwiki) VALUES ('9871994','0','Tuukka_Salonen_(Fußballspieler)','','') ON DUPLICATE KEY UPDATE rd_namespace = '0',rd_title = 'Tuukka_Salonen_(Fußballspieler)',rd_fragment = '',rd_interwiki = ''
Function: WikiPage::insertRedirectEntry
Error: 1205 Lock wait timeout exceeded; try restarting transaction (10.192.16.11)
Sat, Apr 22, 2:04 AM · MediaWiki-General-or-Unknown, DBA

Fri, Apr 21

matmarex added a comment to T163532: Drop index rev_page_id (rev_page, rev_id).

The original use case for these functions were the prev/next links on the old revision page views. The user certainly expects a time-based ordering in that case.

Fri, Apr 21, 9:04 PM · Patch-For-Review, Schema-change, MediaWiki-Platform-Team
matmarex closed T163574: DropdownInputWidget doesn't have null as default value in PHP as "Declined".

It is not possible for a HTML <select> to have no value (unless it has no options), and for compatibility with that, DropdownInputWidget also doesn't allow it. DropdownInputWidget uses a <select> in the PHP version. You'll have to add a "fake" option at the beginning like [ 'data' => '', 'label' => 'Choose value:' ].

Fri, Apr 21, 7:36 PM · MediaWiki-HTMLForm, OOjs-UI
matmarex closed T159481: Rephrase enotif_lastdiff and enotif_lastvisited as "Resolved".
Fri, Apr 21, 7:32 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, MediaWiki-Email, I18n
matmarex closed T56888: Fresh install of MediaWiki lists "-1 recent contributors" in Special:UserLogin/signup as "Resolved".

Only took us a little under four years \o/

Fri, Apr 21, 6:21 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Ladies-That-FOSS-MediaWiki, MediaWiki-Installer, MediaWiki-User-login-and-signup
matmarex added a comment to T163359: 503 errors reported in VisualEditor on office.wiki during (at the start of?) read-only mode.

No, I got a pop-up dialog box (browser-style, not one of VE's own pop-ups) on top of the VE window, and it was much less verbose than the usual 503 landing page. I believe it said something like "Error: 503 [something something]" - 4 or 5 words total. Apologies for not having a screenshot or a better memory of it - at the time I assumed it was expected behavior during the planned outage, so I didn't think much of it until Whatamidoing told me otherwise afterward.

Fri, Apr 21, 5:12 PM · codfw-rollout
matmarex closed T158492: Special:Two-factor_authentication reloads identical after submit (step 4) as "Resolved".
Fri, Apr 21, 2:52 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, MediaWiki-HTMLForm, MediaWiki-extensions-OATHAuth
matmarex added a project to T158492: Special:Two-factor_authentication reloads identical after submit (step 4): MediaWiki-HTMLForm.
Fri, Apr 21, 2:37 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, MediaWiki-HTMLForm, MediaWiki-extensions-OATHAuth
matmarex added a comment to T156426: Issues with loading user common/minerva scripts in mobile site.

Resolved?

Fri, Apr 21, 11:00 AM · Reading-Web-Sprint-96, Unplanned-Sprint-Work, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Reading-Web-Backlog, MediaWiki-ResourceLoader, MediaWiki-Special-pages

Thu, Apr 20

matmarex added a subtask for T124742: Upgrade to jQuery 3: T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.
Thu, Apr 20, 11:35 PM · MW-1.29-release-notes, Performance-Team, JavaScript, MediaWiki-ResourceLoader
matmarex added a parent task for T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1: T124742: Upgrade to jQuery 3.
Thu, Apr 20, 11:35 PM · OOjs-UI
matmarex updated subscribers of T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.

I guess it doesn't like something about how we resolve promises with other promises. But I see nothing relevant in https://jquery.com/upgrade-guide/3.0/#deferred. I tried to debug this a bit, but I keep getting lost in jQuery's horrible Deferred code. Maybe @Krinkle wants to look into it.

Thu, Apr 20, 11:35 PM · OOjs-UI
matmarex added a comment to T162035: Some PNG thumbnails and JPEG originals delivered as [text/html] content-type and hence not rendered in browser.

@AlexRus Can you give an example of a file that is still broken?

Thu, Apr 20, 10:41 PM · Patch-For-Review, Traffic, Operations, media-storage, User-Urbanecm
matmarex added a comment to T163504: Action buttons in the footer of a ProcessDialog showing an error are still clickable.

Caused by rGOJUc8a4e49a31f9: MediaWiki theme: Fix focus states of ActionWidget's buttons.

Thu, Apr 20, 10:18 PM · User-Ryasmeen, OOjs-UI (OOjs-UI-0.21.2), Regression, VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.

After the patch:

Thu, Apr 20, 10:10 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex added a comment to T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.

(As a side note, the "Review your changes" button in the dialog footer shouldn't overlap the error message. That's T163504.)

Thu, Apr 20, 10:08 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex added a comment to T163492: With $wgReadOnly set and when $wgSessionCacheType = CACHE_DB, ApiQueryTokens will return invalid tokens.

It's not like the tokens are useful for much anyway if the site is readonly.

Logging in to be able to view pages with your own preferences, user scripts, and so on?

Thu, Apr 20, 9:48 PM · MediaWiki-Cache, MediaWiki-Authentication-and-authorization
matmarex added a comment to T163492: With $wgReadOnly set and when $wgSessionCacheType = CACHE_DB, ApiQueryTokens will return invalid tokens.

Could ApiQueryTokens::getToken() try to check the validity of the token it just generated, and if it's invalid, return an error? Or would that be checking against some cached data and always return that the token is valid?

Thu, Apr 20, 9:48 PM · MediaWiki-Cache, MediaWiki-Authentication-and-authorization
matmarex changed the status of T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one from "Stalled" to "Open".

Oh, that's neat, I didn't realize it's an option. In production I get this:

Thu, Apr 20, 9:05 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex claimed T163504: Action buttons in the footer of a ProcessDialog showing an error are still clickable.
Thu, Apr 20, 8:57 PM · User-Ryasmeen, OOjs-UI (OOjs-UI-0.21.2), Regression, VisualEditor-MediaWiki, VisualEditor
matmarex created T163504: Action buttons in the footer of a ProcessDialog showing an error are still clickable.
Thu, Apr 20, 8:55 PM · User-Ryasmeen, OOjs-UI (OOjs-UI-0.21.2), Regression, VisualEditor-MediaWiki, VisualEditor
matmarex changed the status of T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one from "Open" to "Stalled".
Thu, Apr 20, 8:44 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex added a comment to T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.

Yeah, it must be some difference between my local setup and our production setup, I'm just saying that I can't reproduce it myself and without any hint as to what the actual error/JSON displayed was, I can do nothing about it right now. I guess someone else could try? Best I can do is to be around during the production read-only time during the switchover in two weeks, and try to reproduce then.

Thu, Apr 20, 8:25 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex added a comment to T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.

My infinite loop issue is T163492/T163493. But I can't reproduce this problem if that is worked around. I get a pretty error message:

Thu, Apr 20, 7:48 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex created T163493: VisualEditor will retry saving a page forever if the API gives it an invalid token.
Thu, Apr 20, 7:47 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki
matmarex created T163492: With $wgReadOnly set and when $wgSessionCacheType = CACHE_DB, ApiQueryTokens will return invalid tokens.
Thu, Apr 20, 7:46 PM · MediaWiki-Cache, MediaWiki-Authentication-and-authorization
matmarex claimed T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.
Thu, Apr 20, 7:46 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex added a comment to T162838: Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface.

Yeah, the remaining patch on T162493 still needs to be merged though.

Thu, Apr 20, 6:12 PM · User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, VisualEditor, Timeless
matmarex added a subtask for T162838: Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface: T162493: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else.
Thu, Apr 20, 6:11 PM · User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, VisualEditor, Timeless
matmarex added a parent task for T162493: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else: T162838: Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface.
Thu, Apr 20, 6:11 PM · Patch-For-Review, VisualEditor
matmarex added a comment to T163359: 503 errors reported in VisualEditor on office.wiki during (at the start of?) read-only mode.

To be clear, you tried viewing a page like https://office.wikimedia.org/w/index.php?title=Does_not_exist&action=edit&redlink=1, and instead of a wiki interface, you got an error page like the below?

Thu, Apr 20, 5:28 PM · codfw-rollout
matmarex added a comment to T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.

It looks like that configuration change should be mostly equivalent to setting setting $wgReadOnly = 'foo bar'; locally.

Thu, Apr 20, 4:50 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Editing-Department, VisualEditor
matmarex closed T163193: Browser test fail due to OOUI change on EditPage button as "Resolved".
Thu, Apr 20, 3:26 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), WMDE-QWERTY-Team-Board, Editing-Department, Two-Column-Edit-Conflict-Merge, TCB-Team
matmarex edited the description of T154988: Promote a selection of Community Wishlist Survey 2016 projects well suited for volunteer developers.
Thu, Apr 20, 3:23 PM · Developer-Relations (Apr-Jun 2017)
matmarex created T163406: VisualEditor's "Page options" dialog throws an exception if the page has more categories than the API tells us about.
Thu, Apr 20, 12:30 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, VisualEditor
matmarex updated subscribers of T163404: [Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing.

This is probably a regression from rGOJU9d1612ace56f: DraggableElement: Only apply focus when widget is not disabled in OOjs UI (which fixed the 'padding' rule added in 09a82ed15/f6be5b2f that previously was ignored). I think @DLynch said he's looking into it, filing this just so that it's not forgotten.

Thu, Apr 20, 12:23 AM · Verified-in-Phase0, Verified, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
matmarex created T163404: [Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing.
Thu, Apr 20, 12:19 AM · Verified-in-Phase0, Verified, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T149654: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox.
  1. The combobox must be connected to the selected option using aria-activedescendant.

The third, I'm not convinced about – I'm having trouble making sense of the spec for aria-activedescendant, but it doesn't seem to mean the selected option? Are you sure about this?

Thu, Apr 20, 12:08 AM · OOjs-UI (OOjs-UI-0.21.2), UI-Standardization, Accessibility, UI-Standardization-Kanban

Wed, Apr 19

matmarex removed a project from T149654: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox: Patch-For-Review.
Wed, Apr 19, 8:52 PM · OOjs-UI (OOjs-UI-0.21.2), UI-Standardization, Accessibility, UI-Standardization-Kanban
matmarex claimed T149654: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox.

So, to recap, we want the following:

Wed, Apr 19, 7:40 PM · OOjs-UI (OOjs-UI-0.21.2), UI-Standardization, Accessibility, UI-Standardization-Kanban
matmarex merged task T163334: Italian Wikivoyage Sitenotice is shown at the bottom on IE11 browser into T125323: Sitenotice message sometimes shown at bottom of site for readers / logged-out users.
Wed, Apr 19, 3:22 PM · MediaWiki-General-or-Unknown, Browser-Support-Internet-Explorer
matmarex merged T163334: Italian Wikivoyage Sitenotice is shown at the bottom on IE11 browser into T125323: Sitenotice message sometimes shown at bottom of site for readers / logged-out users.
Wed, Apr 19, 3:22 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, DismissableSiteNotice, MediaWiki-General-or-Unknown

Tue, Apr 18

matmarex added a comment to T163266: [minor] White outline is displayed around some elements.

This is fixed in the next OOjs UI release, see T162848.

Tue, Apr 18, 9:34 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Notifications
matmarex added a parent task for T162848: Frameless buttons actually have a thin white frame: T163266: [minor] White outline is displayed around some elements.
Tue, Apr 18, 9:34 PM · OOjs-UI (OOjs-UI-0.21.1), Regression
matmarex added a subtask for T163266: [minor] White outline is displayed around some elements: T162848: Frameless buttons actually have a thin white frame.
Tue, Apr 18, 9:34 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Notifications
matmarex added a comment to T163055: FloatingMenuSelectWidget with an overlay jumps to the position of the overlay if an item is selected.

Yeah, this is a mess. I don't know what the best solution is either, but your proposed workaround seems okay.

Tue, Apr 18, 7:49 PM · Patch-For-Review, OOjs-UI
matmarex added a comment to T163226: Impossible to preview page (or changes) in old wikitext editor using IE 6 when VisualEditor is enabled.

This is caused by rEVED188ec0f5d23c: Send users whose browsers support JS but are unsupported by MW to the WTE…. Looks like the addScript() added there should be inside the if()…

Tue, Apr 18, 5:40 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor
matmarex created T163226: Impossible to preview page (or changes) in old wikitext editor using IE 6 when VisualEditor is enabled.
Tue, Apr 18, 5:33 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor
matmarex claimed T163219: [Regression pre-wmf.21] Impossible to edit pages using IE 6.
Tue, Apr 18, 4:29 PM · Browser-Support-Internet-Explorer, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, VisualEditor, Patch-For-Review, Editing-Department, MediaWiki-Page-editing
matmarex created T163219: [Regression pre-wmf.21] Impossible to edit pages using IE 6.
Tue, Apr 18, 4:29 PM · Browser-Support-Internet-Explorer, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), User-Ryasmeen, VisualEditor, Patch-For-Review, Editing-Department, MediaWiki-Page-editing
matmarex edited projects for T163099: lastmodifiedat shows the time of the last edit on the page itself, but it should be affected by templates or completely removed, added: MediaWiki-Interface; removed MediaWiki-General-or-Unknown, Vector.

Not Vector-specific – the same text is shown in every skin we have deployed. See Skin::lastModified().

Tue, Apr 18, 12:31 PM · MediaWiki-Interface, I18n
matmarex updated subscribers of T163154: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php.

This might be expected, if the file or the version of LightNCandy changes… I don't really know how this works.

Tue, Apr 18, 12:24 PM · MW-1.29-release, MediaWiki-Recent-changes

Mon, Apr 17

matmarex closed T137330: AbuseFilter variable deprecation notice: Typos as "Resolved".
Mon, Apr 17, 6:11 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), AbuseFilter
Volker_E awarded T162478: Reduce differences between PHP and JS code-comment documentation a Mountain of Wealth token.
Mon, Apr 17, 8:48 AM · Easy, OOjs-UI

Sat, Apr 15

matmarex closed T141686: On Special:MediaStatistics don't link Special:MIMESearch when it's disabled as "Invalid".
Sat, Apr 15, 12:15 AM · MediaWiki-Special-pages

Fri, Apr 14

matmarex added a comment to T162848: Frameless buttons actually have a thin white frame.

Also affects UploadWizard:

Fri, Apr 14, 2:48 PM · OOjs-UI (OOjs-UI-0.21.1), Regression
matmarex merged task T94301: Apex theme: various widgets have no focus state, including ButtonWidget into T162891: Nearly impossible to tell if a button is focused in the Apex theme (i.e. in MediaWiki's Monobook skin).
Fri, Apr 14, 1:19 PM · Accessibility, OOjs-UI
matmarex merged T94301: Apex theme: various widgets have no focus state, including ButtonWidget into T162891: Nearly impossible to tell if a button is focused in the Apex theme (i.e. in MediaWiki's Monobook skin).
Fri, Apr 14, 1:18 PM · OOjs-UI
matmarex reopened T162891: Nearly impossible to tell if a button is focused in the Apex theme (i.e. in MediaWiki's Monobook skin) as "Open".
Fri, Apr 14, 1:18 PM · OOjs-UI
matmarex added a comment to T146339: Text displayed inside Hovercards popups doesn't use subpixel rendering.

Same screenshot today (https://en.wikipedia.org/wiki/Huirangi), with Opera 45 (Chromium 58):

Fri, Apr 14, 1:11 PM · Design, Reading-Web-Backlog, Browser-Support-Google-Chrome, Page-Previews
matmarex added a subtask for T47443: Deploy language-specific "uca-xx" collations on Wikimedia wikis: T162823: Changing the alphabetical sorting (collation) @ ba.wikipedia.org.
Fri, Apr 14, 1:06 PM · Goal, Community-Tech, I18n, Wikimedia-Site-requests
matmarex added a parent task for T162823: Changing the alphabetical sorting (collation) @ ba.wikipedia.org: T47443: Deploy language-specific "uca-xx" collations on Wikimedia wikis.
Fri, Apr 14, 1:06 PM · MediaWiki-Internationalization, I18n
matmarex updated subscribers of T162823: Changing the alphabetical sorting (collation) @ ba.wikipedia.org.

I'm not really that familiar with how the process works. I only worked on implementing MediaWiki support for languages that were already supported by ICU.

Fri, Apr 14, 1:06 PM · MediaWiki-Internationalization, I18n
matmarex closed T153233: Diacritical letters (Çç, Êê, Îî, Şş, Ûû) on Kurdish pages do not become part of the internal link as "Resolved".

(Fixed a while ago.)

Fri, Apr 14, 12:58 PM · MW-1.27-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes, Patch-For-Review, MediaWiki-Internationalization
matmarex edited the description of T162981: Create edit confirmation checkbox gadget for VisualEditor.
Fri, Apr 14, 11:08 AM · User-Ryasmeen, MediaWiki-Page-editing, VisualEditor, Support-and-Safety
matmarex added a comment to T156426: Issues with loading user common/minerva scripts in mobile site.

I already explained what is happening in the task marked as duplicate: T155304#2953862. Unless this is actually a different issue, it's MobileFrontend not playing well with ResourceLoader, rather than a ResourceLoader bug.

Fri, Apr 14, 10:53 AM · Reading-Web-Sprint-96, Unplanned-Sprint-Work, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Reading-Web-Backlog, MediaWiki-ResourceLoader, MediaWiki-Special-pages
matmarex added a comment to T111088: Convert EditPage.php to use OOUI rather than MW UI.

That makes sense to me.

Fri, Apr 14, 10:51 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, User-Ladsgroup, Editing-Department, User-notice, UI-Standardization

Thu, Apr 13

matmarex merged task T162891: Nearly impossible to tell if a button is focused in the Apex theme (i.e. in MediaWiki's Monobook skin) into T94301: Apex theme: various widgets have no focus state, including ButtonWidget.
Thu, Apr 13, 6:50 PM · OOjs-UI
matmarex merged T162891: Nearly impossible to tell if a button is focused in the Apex theme (i.e. in MediaWiki's Monobook skin) into T94301: Apex theme: various widgets have no focus state, including ButtonWidget.
Thu, Apr 13, 6:50 PM · Accessibility, OOjs-UI
matmarex added a subtask for T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13: T161809: Update extensions not to use deprecated EditPageBeforeEditChecks hook.
Thu, Apr 13, 1:51 PM · Technical-Debt, Wikimedia-log-errors, MediaWiki-General-or-Unknown
matmarex added a parent task for T161809: Update extensions not to use deprecated EditPageBeforeEditChecks hook: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.
Thu, Apr 13, 1:51 PM · MediaWiki-extensions-WikibaseClient, Wikidata, MediaWiki-extensions-General-or-Unknown, Technical-Debt, VisualEditor
matmarex merged task T162880: Update deprecated hook usage EditPageBeforeEditChecks into T161809: Update extensions not to use deprecated EditPageBeforeEditChecks hook.
Thu, Apr 13, 1:50 PM · Wikimedia-log-errors, MediaWiki-extensions-WikibaseClient, Wikidata
matmarex merged T162880: Update deprecated hook usage EditPageBeforeEditChecks into T161809: Update extensions not to use deprecated EditPageBeforeEditChecks hook.
Thu, Apr 13, 1:50 PM · MediaWiki-extensions-WikibaseClient, Wikidata, MediaWiki-extensions-General-or-Unknown, Technical-Debt, VisualEditor
Volker_E awarded T160802: Resolve jQuery 3 migration errors in OOjs UI a Like token.
Thu, Apr 13, 6:13 AM · Patch-For-Review, OOjs-UI
matmarex claimed T161941: Echo continuous integration is broken with Selenium error.

After two hours of blind stumbling, I stumbled upon something that seems to work.

Thu, Apr 13, 12:49 AM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Notifications
matmarex closed T162667: Special:Move throws "TypeError: this.namespace is undefined" as "Resolved".

Fixed and deployed.

Thu, Apr 13, 12:00 AM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-Special-pages
matmarex closed T162374: Poor in-editor (WikiEditor & VE) upload disabled error message on wikitechwiki as "Resolved".
Thu, Apr 13, 12:00 AM · Patch-For-Review, Wikimedia-Site-requests

Wed, Apr 12

matmarex added a comment to T162848: Frameless buttons actually have a thin white frame.

(Regression from 99361c772c65baaf95de857d18e0dd8d00cc3e9c.)

Wed, Apr 12, 11:45 PM · OOjs-UI (OOjs-UI-0.21.1), Regression
matmarex added a comment to T111088: Convert EditPage.php to use OOUI rather than MW UI.

Looks like a new bug, I filed T162848.

Wed, Apr 12, 11:16 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, User-Ladsgroup, Editing-Department, User-notice, UI-Standardization
matmarex created T162848: Frameless buttons actually have a thin white frame.
Wed, Apr 12, 11:16 PM · OOjs-UI (OOjs-UI-0.21.1), Regression