Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (50)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (488 w, 4 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Today

stjn awarded T13555: .mw-editsection links should not be part of the <h#> element a Love token.
Wed, Feb 28, 10:01 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
matmarex added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

With only the "new" and the "bare" markups remaining, we can easily target all <h2>'s by simply using h2 selector. If ever we need to select only the bare <h2>'s, we can do :not(.mw-heading) > h2. And to target all headings at the topmost level, we could do .mw-heading2, :not(.mw-heading) > h2.

Wed, Feb 28, 9:33 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
matmarex added a comment to T354015: DBQueryDisconnectedError upon editing en:Template:COVID-19 pandemic data.

The query comes from MediaWiki\Revision\RevisionStore::findIdenticalRevision, it tries to find a recent identical revision in order to detect and tag manual reverts. This would explain why edits using the revert user interface or API work (they don't need to detect that).

Wed, Feb 28, 6:04 AM · DBA, Wikimedia-Slow-DB-Query, MediaWiki-Core-Revision-backend, Wikimedia-production-error
matmarex added a project to T354015: DBQueryDisconnectedError upon editing en:Template:COVID-19 pandemic data: DBA.

Same problem reported with the page https://en.wikipedia.org/wiki/Wikipedia:Requested_moves at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Issues_editing_Wikipedia:Requested_moves:

Wed, Feb 28, 5:51 AM · DBA, Wikimedia-Slow-DB-Query, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Yesterday

matmarex added a comment to T358304: Vector 2022 appears mysteriously on Thursday.

The fix has actually been deployed yesterday (T336504#9579650).

Tue, Feb 27, 11:19 PM · Desktop Improvements (Vector 2022)
matmarex closed T352592: Pages transcluding Special:WhatLinksHere are sometimes being rendered in the default skin as Resolved.

Seems fixed by that change. Until next time…

Tue, Feb 27, 11:16 PM · MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), MediaWiki-HTMLForm, MediaWiki-Special-pages
matmarex closed T357834: Viewing a page that transcludes Special:Impact sometimes overrides the default skin as Resolved.
Tue, Feb 27, 11:15 PM · Growth-Team, GrowthExperiments-ImpactModule
matmarex closed T336504: Transcluding Special:Prefixindex can force the default skin as Resolved.
Tue, Feb 27, 11:14 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Beta-Cluster-reproducible, GrowthExperiments, Growth-Team, Wikimedia-production-error, Regression
1234qwer1234qwer4 awarded T356008: mw.config 'wgGlobalGroups' should only include groups that are active on the current wiki a Party Time token.
Tue, Feb 27, 7:36 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex added a project to T356157: Unable to fetch Parsoid HTML: MediaWiki-REST-API.

The error code is 'rest-html-backend-error', emitted in several places in MediaWiki core: https://codesearch.wmcloud.org/search/?q=rest-html-backend-error&files=php|en\.json&excludeFiles=&repos=

Tue, Feb 27, 2:50 PM · Patch-For-Review, MediaWiki-REST-API, MediaWiki-Engineering, Content-Transform-Team-WIP, DiscussionTools, Parsoid, VisualEditor
matmarex merged T358548: Unable to fetch Parsoid HTML into T356157: Unable to fetch Parsoid HTML.
Tue, Feb 27, 2:39 PM · Patch-For-Review, MediaWiki-REST-API, MediaWiki-Engineering, Content-Transform-Team-WIP, DiscussionTools, Parsoid, VisualEditor
matmarex merged task T358548: Unable to fetch Parsoid HTML into T356157: Unable to fetch Parsoid HTML.
Tue, Feb 27, 2:38 PM · VisualEditor
matmarex added a comment to T358416: Support OO.Factory class keys (ES6) in OOUI WindowManager.

I couldn't see a way to automate it at glance. In exiting code, OO.inheritClass() will generally be called before the static properties are set, so a one-time forward-compat copy to native static is not feasible (too early from that point in time).

Tue, Feb 27, 1:49 AM · OOUI
matmarex added a comment to T357834: Viewing a page that transcludes Special:Impact sometimes overrides the default skin.

Someone should check whether https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1006601 resolves this as well.

Tue, Feb 27, 1:09 AM · Growth-Team, GrowthExperiments-ImpactModule
matmarex added a parent task for T290706: Parser code for special page transclusion replaces main context: T357834: Viewing a page that transcludes Special:Impact sometimes overrides the default skin.
Tue, Feb 27, 1:09 AM · Patch-For-Review, MediaWiki-General, Dependency injection
matmarex added a subtask for T357834: Viewing a page that transcludes Special:Impact sometimes overrides the default skin: T290706: Parser code for special page transclusion replaces main context.
Tue, Feb 27, 1:09 AM · Growth-Team, GrowthExperiments-ImpactModule
matmarex added a comment to T352592: Pages transcluding Special:WhatLinksHere are sometimes being rendered in the default skin.

Someone should check whether https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1006601 resolves this as well.

Tue, Feb 27, 1:09 AM · MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), MediaWiki-HTMLForm, MediaWiki-Special-pages
matmarex added a comment to T290706: Parser code for special page transclusion replaces main context.

If I understand correctly, after this change, if an includeable special page uses the global context for something instead of the passed context, then some parts of the rendering of the special page content will be done using the current user's context instead of the logged-out user context, and this rendering is cached and can be shown to other users later. Before this change, we have a different problem – some parts of the rendering other than the special page content were done using the logged-out user context instead of the current user's context.

Tue, Feb 27, 1:07 AM · Patch-For-Review, MediaWiki-General, Dependency injection

Mon, Feb 26

matmarex closed T323868: category sortkey generation of german letter ß changed as Resolved.

Well, that's one way to fix the problem. Thanks for letting us know @Formatierer, and sorry that we didn't do it from the MediaWiki side.

Mon, Feb 26, 11:15 PM · Wikimedia-Site-requests, I18n, MediaWiki-Categories
matmarex closed T356008: mw.config 'wgGlobalGroups' should only include groups that are active on the current wiki as Resolved.
Mon, Feb 26, 10:52 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex updated the task description for T356008: mw.config 'wgGlobalGroups' should only include groups that are active on the current wiki.
Mon, Feb 26, 10:52 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex added a comment to T356008: mw.config 'wgGlobalGroups' should only include groups that are active on the current wiki.

Thank you @WikiBayer and @UOzurumba for adding the Tech News entry, I've had a very busy couple of days and I didn't remember to do it. The entry looks good to me.

Mon, Feb 26, 10:51 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex added a comment to T352308: Port remaining files to jsdoc in MediaWiki core.

FYI, I added support to Patch demo to generate the JSDoc documentation as well, to make these patches easier to test and review: https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/603. There will be a link to the generated documentation on the main page of every new wiki. For example: https://patchdemo.wmflabs.org/wikis/147380bd91. (I hope it's better late than never :) )

Mon, Feb 26, 9:34 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), JSDoc WMF theme, Patch-For-Review, MediaWiki CodeJam Dec 2023, Tech-Docs-Team, Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
matmarex added a comment to T358416: Support OO.Factory class keys (ES6) in OOUI WindowManager.

@Krinkle The same issue affects other classes and static properties though, and most of them don't have an alternative like .key for .static.name. For example:

class MyWidget extends OO.ui.Widget {}
MyWidget.static.tagName = 'details'; // Oops, this affects *all* widgets
Mon, Feb 26, 8:29 PM · OOUI
matmarex closed T357723: MediaWiki\Extension\DiscussionTools\Tests\ApiParseDiscussionToolsTest::testApiParseSections failure as Resolved.
Mon, Feb 26, 4:29 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), ci-test-error (WMF-deployed Build Failure), DiscussionTools

Sat, Feb 24

matmarex added a comment to T358296: [UX] No obvious way to close notice dialog telling me that I'm using the Parsoid view experimental feature.

Let's just add a close icon to the notification when using autoHide: false. For some reason designers are allergic to this interface, so they won't stop you. ;)

Sat, Feb 24, 12:53 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-User-Interface (mw.notifications), Parsoid, Parsoid-Read-Views
matmarex added a comment to T358321: When using customized signature, the DiscussionTools do not work well.

@BugCatcher2019 Can you try applying these changes on your wiki, and see if that fixes it? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/1006097/1/includes/CommentUtils.php

Sat, Feb 24, 12:35 AM · Patch-For-Review, DiscussionTools
matmarex claimed T358321: When using customized signature, the DiscussionTools do not work well.
Sat, Feb 24, 12:21 AM · Patch-For-Review, DiscussionTools

Fri, Feb 23

matmarex added a comment to T358321: When using customized signature, the DiscussionTools do not work well.

Also, https://unitedearth.wiki/地球联合百科讨论:会议大厅?dtdebug=1 does seem to recognize comments – or does dtdebug=1 use the JavaScript comment parser, in contrast to Special:DiscussionToolsDebug and the actual reply links, which use the PHP comment parser?

Fri, Feb 23, 11:29 PM · Patch-For-Review, DiscussionTools
matmarex removed a project from T351487: Gutter doesn't disappear after disabling code editor: Patch-For-Review.
Fri, Feb 23, 8:24 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CodeEditor
matmarex closed T351487: Gutter doesn't disappear after disabling code editor as Resolved.
Fri, Feb 23, 8:24 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CodeEditor
matmarex added a project to T358327: Icon added to anonymous editing warning message (by accident?): Codex.
Fri, Feb 23, 2:44 PM · Design-System-Team, Codex, MediaWiki-Page-editing
matmarex updated the title for P57754 Repositories queried by https://gitlab.wikimedia.org/matmarex/gerrit-new-contributors from untitled to Repositories queried by https://gitlab.wikimedia.org/matmarex/gerrit-new-contributors.
Fri, Feb 23, 4:44 AM
matmarex claimed T358300: Difference in edit section links on enwikivoyage.

I updated it: https://en.wikivoyage.org/w/index.php?title=MediaWiki:Gadget-ListingEditor2023.js&diff=prev&oldid=4832346

Fri, Feb 23, 1:37 AM · Parsoid, Content-Transform-Team-WIP, Parsoid-Read-Views
matmarex renamed T358061: Global Search is down: 500: Internal Server Error / Could not resolve host: cloudelastic1004.wikimedia.org from 500: Internal Server Error on (Gadgets-definition|.*\.(js|css|json)) to Global Search is down: 500: Internal Server Error / Could not resolve host: cloudelastic1004.wikimedia.org.
Fri, Feb 23, 1:36 AM · Tool-global-search
matmarex moved T338920: Discussion tool saved answer not accessible on mobile when multiple pages are included from QA to Code Review on the Editing-team (Kanban Board) board.
Fri, Feb 23, 12:56 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Editing-team (Kanban Board), DiscussionTools
matmarex updated the task description for T358300: Difference in edit section links on enwikivoyage.
Fri, Feb 23, 12:56 AM · Parsoid, Content-Transform-Team-WIP, Parsoid-Read-Views
matmarex added a comment to T338920: Discussion tool saved answer not accessible on mobile when multiple pages are included.

This time it'll really work. I hope :) Sorry about that.

Fri, Feb 23, 12:54 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Editing-team (Kanban Board), DiscussionTools
matmarex added a comment to T338920: Discussion tool saved answer not accessible on mobile when multiple pages are included.

Hm, it works for me on desktop Chromium, so I thought it was fixed, but it doesn't work on desktop Firefox and on mobile Safari.

Fri, Feb 23, 12:05 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Editing-team (Kanban Board), DiscussionTools

Thu, Feb 22

matmarex closed T358149: InvalidArgumentException: Invalid username: Https//www.cocororo.net/ as Resolved.

This doesn't really affect users, so I'm not planning to backport, but if the log noise becomes too much, feel free to do it.

Thu, Feb 22, 11:40 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
matmarex closed T358103: mwext-phpunit-coverage-patch-docker has failing core test when running code coverage checks on CheckUser extension as Resolved.
Thu, Feb 22, 11:12 PM · Content-Transform-Team-WIP, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CheckUser, VisualEditor, MediaWiki-Core-Tests
matmarex added projects to T358250: Full screen dialogs are truncated by scrollbar gutter: Browser-Support-Google-Chrome, Upstream.

Looks like this is reported as https://issues.chromium.org/issues/40835364, which may also be the same as https://issues.chromium.org/issues/40792788.

Thu, Feb 22, 11:07 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
matmarex closed T358258: Can't set label for external link on mobile as Resolved.
Thu, Feb 22, 8:38 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex created P57754 Repositories queried by https://gitlab.wikimedia.org/matmarex/gerrit-new-contributors.
Thu, Feb 22, 6:19 PM
matmarex added a comment to T358198: Message-ID: <CACNAgmwRgLo4Uy0w9ZtAi07kB_rA9wxC5T3p+kr+ftWDUq7hWg@mail.gmail.com> delayed by 3 days.

(presumably reopened by accident because Phabricator doesn't detect edit conflicts)

Thu, Feb 22, 4:09 PM · SRE, Wikimedia-Mailing-lists
matmarex merged T358198: Message-ID: <CACNAgmwRgLo4Uy0w9ZtAi07kB_rA9wxC5T3p+kr+ftWDUq7hWg@mail.gmail.com> delayed by 3 days into T358020: Not receiving posts or moderation messages.
Thu, Feb 22, 4:09 PM · Wikimedia-Incident, SRE, Wikimedia-Mailing-lists
matmarex merged task T358198: Message-ID: <CACNAgmwRgLo4Uy0w9ZtAi07kB_rA9wxC5T3p+kr+ftWDUq7hWg@mail.gmail.com> delayed by 3 days into T358020: Not receiving posts or moderation messages.
Thu, Feb 22, 4:08 PM · SRE, Wikimedia-Mailing-lists

Wed, Feb 21

matmarex added projects to T358149: InvalidArgumentException: Invalid username: Https//www.cocororo.net/: MediaWiki-extensions-CentralAuth, MediaWiki-Platform-Team.
Wed, Feb 21, 9:26 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
matmarex closed T358112: Special:Contributions for IP ranges fails with InvalidArgumentException , due to CentralAuth as Resolved.
Wed, Feb 21, 9:16 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, Wikimedia-production-error, MediaWiki-extensions-CentralAuth
matmarex closed T358112: Special:Contributions for IP ranges fails with InvalidArgumentException , due to CentralAuth, a subtask of T354437: 1.42.0-wmf.19 deployment blockers, as Resolved.
Wed, Feb 21, 9:16 PM · Release-Engineering-Team (Now this 🫠), Release, Train Deployments
matmarex claimed T358149: InvalidArgumentException: Invalid username: Https//www.cocororo.net/.

@matmarex seems like spam but quite a few of these are popping up since deploying T358112

Wed, Feb 21, 9:15 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
matmarex added a project to T358103: mwext-phpunit-coverage-patch-docker has failing core test when running code coverage checks on CheckUser extension: Content-Transform-Team.
Wed, Feb 21, 7:48 PM · Content-Transform-Team-WIP, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CheckUser, VisualEditor, MediaWiki-Core-Tests
matmarex added a comment to T358103: mwext-phpunit-coverage-patch-docker has failing core test when running code coverage checks on CheckUser extension.

That test should probably disable hooks, it's not going to pass if an extension changes the output.

Wed, Feb 21, 7:47 PM · Content-Transform-Team-WIP, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CheckUser, VisualEditor, MediaWiki-Core-Tests
matmarex added a comment to T358112: Special:Contributions for IP ranges fails with InvalidArgumentException , due to CentralAuth.

The exception was added in T343963 / https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/988450.

Wed, Feb 21, 7:34 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, Wikimedia-production-error, MediaWiki-extensions-CentralAuth
matmarex added a project to T357758: VisualEditor runs into a timeout if wgAntivirusSetup is configured: MediaWiki-Uploading.
Wed, Feb 21, 5:20 PM · MediaWiki-Uploading, VisualEditor

Tue, Feb 20

matmarex closed T265308: Update extensions that extend core SpecialRandompage class as Resolved.
Tue, Feb 20, 4:56 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-extensions-RandomInCategory, MediaWiki-extensions-WikimediaIncubator
matmarex closed T265308: Update extensions that extend core SpecialRandompage class, a subtask of T259960: Inject services into API modules and special pages, as Resolved.
Tue, Feb 20, 4:55 PM · MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), User-DannyS712, Dependency injection, MediaWiki-Special-pages, MediaWiki-Action-API
matmarex closed T354292: Error thrown when clicking "Add topic" multiple times before widget loads as Resolved.

This went away after the patch: https://logstash.wikimedia.org/goto/368b9cf424917354a67373a3ef65d5d2

image.png (530×2 px, 84 KB)

Tue, Feb 20, 1:06 AM · MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Wikimedia-production-error, DiscussionTools

Mon, Feb 19

matmarex closed T297978: Switching from legacy new section editing in 2017WTE to New Discussion Tool via the "hint" opens a new tab as Invalid.

The hint has been removed in T322495.

Mon, Feb 19, 11:54 PM · VisualEditor, DiscussionTools, VisualEditor-MediaWiki-2017WikitextEditor
matmarex closed T299267: More clearly relate the link that appears within the hint to Special:Preferences as Invalid.

The hint has been removed in T322495.

Mon, Feb 19, 11:52 PM · DiscussionTools
matmarex merged T297760: Disable the New Discussion Tool Hint into T322495: Remove the new topic tool hint.
Mon, Feb 19, 11:51 PM · Skipped QA, MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Editing-team (Kanban Board), Technical-Debt, DiscussionTools
matmarex merged task T297760: Disable the New Discussion Tool Hint into T322495: Remove the new topic tool hint.
Mon, Feb 19, 11:51 PM · Editing-team, DiscussionTools
matmarex added a comment to T297760: Disable the New Discussion Tool Hint.

It has been removed in T322495.

Mon, Feb 19, 11:51 PM · Editing-team, DiscussionTools
matmarex added a comment to T357021: Permalinks are getting very long when non-latin characters are part of the link.

The non-encoded form of these URLs is equally valid, for example https://ar.wikipedia.org/wiki/ويكيبيديا:الميدان/منوعات#c-Mohanad-20240130214100-وصلة_دائمة_لتعليقات_المستخدمين_المُلحقة_بط. It should be possible to use this form when we're copying the link upon clicking a timestamp.

Mon, Feb 19, 11:44 PM · DiscussionTools
matmarex closed T325777: Make it so the mobile "Expand all sections" setting mobile controls talk pages' "Read as wiki page" view as Invalid.

After T280417 there is no longer a "Read as wiki page" view, so this task is moot.

Mon, Feb 19, 11:23 PM · MobileFrontend, DiscussionTools
matmarex added a comment to T357865: Read talk page as article now missing.

This functionality allows for you to edit a section. The edit section button without it is broken (nothing happens when you click it).

Mon, Feb 19, 11:20 PM · MobileFrontend
matmarex added a comment to T336122: LSP violations in OOUI.

BTW, it looks like OOjs's inheritance model (OO.inheritClass and the static field) is not compatible with both ES6 classes and TypeScript, thus it makes the effect of TS definitions quite limited. Are there any plans to change this in the future?

Mon, Feb 19, 11:14 PM · OOUI
matmarex added a comment to T354975: [carryover] ResourceLoaderSkinModule should load core styles before skin styles.

These changes caused incorrect rendering of headings on talk pages with DiscussionTools (T357929), and on all pages when using the Parsoid parser (T357831).

Mon, Feb 19, 8:14 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 4), MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, Desktop Improvements (Vector 2022), MediaWiki-Core-Skin-Architecture
matmarex closed T357929: <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project) as Resolved.
Mon, Feb 19, 8:10 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, DiscussionTools, MediaWiki-General, Regression
matmarex closed T357831: Headings are too large when Parsoid section edit links are added as Resolved.
Mon, Feb 19, 8:06 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
matmarex closed T357831: Headings are too large when Parsoid section edit links are added, a subtask of T269630: Parsoid should support section editing links, as Resolved.
Mon, Feb 19, 8:06 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
matmarex added a comment to T357929: <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project).

This revert also fixed T357831.

Mon, Feb 19, 8:03 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, DiscussionTools, MediaWiki-General, Regression
matmarex added a comment to T357831: Headings are too large when Parsoid section edit links are added.

It turns out that the same issue affected some pages with the legacy parser and DiscussionTools: T357929: <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project) and it was fixed by reverting a change in MediaWiki core: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1004712

Mon, Feb 19, 8:01 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
matmarex renamed T357929: <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project) from <h2> too large on talk pages (without DT visual enhancments), or other namespaces (e.g. Project) to <h2> too large on talk pages (without DT visual enhancements), or other namespaces (e.g. Project).
Mon, Feb 19, 8:00 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, DiscussionTools, MediaWiki-General, Regression
matmarex closed T266747: Watchlist Expiry: Special:Watchlist clock icon should be replaced by semicolon when removed as Resolved.
Mon, Feb 19, 5:04 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), good first task, Expiring-Watchlist-Items, Community-Tech
matmarex closed T357826: DiscussionTools Headings are wrapped twice when using Parsoid as Resolved.
Mon, Feb 19, 3:30 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid
matmarex closed T357826: DiscussionTools Headings are wrapped twice when using Parsoid, a subtask of T269630: Parsoid should support section editing links, as Resolved.
Mon, Feb 19, 3:29 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Parsoid

Sat, Feb 17

matmarex committed rECPA0e07661d64db: Use OutputPage::setPageTitleMsg() instead of ::setPageTitle() (authored by matmarex).
Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()
Sat, Feb 17, 2:43 AM
matmarex committed rETSAdda788458eb0: Use OutputPage::setPageTitleMsg() instead of ::setPageTitle() (authored by matmarex).
Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()
Sat, Feb 17, 2:39 AM
matmarex committed rESCC9cb8be025211: Use OutputPage::setPageTitleMsg() instead of ::setPageTitle() (authored by matmarex).
Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()
Sat, Feb 17, 2:27 AM

Fri, Feb 16

matmarex closed T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81 as Resolved.
Fri, Feb 16, 7:35 PM · MW-1.39-notes, MW-1.41-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Parser, Editing-team, ImageMap, Wikimedia-production-error
matmarex created T357812: `DOMCompat::querySelector( $fragment, 'mw\\:editsection' )` throws "InvalidArgumentException: Unknown Selector: :editsection".
Fri, Feb 16, 7:24 PM · Content-Transform-Team-WIP, Patch-For-Review, Parsoid
matmarex added a comment to T357723: MediaWiki\Extension\DiscussionTools\Tests\ApiParseDiscussionToolsTest::testApiParseSections failure.

The failure actually indicated a real problem – the comment metadata in the table of contents (the grey text like "3 comments") was missing.

Fri, Feb 16, 5:01 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), ci-test-error (WMF-deployed Build Failure), DiscussionTools
matmarex claimed T322457: Only include one set of DiscussionTools buttons in the page HTML.
Fri, Feb 16, 4:21 PM · Patch-For-Review, Technical-Debt, DiscussionTools
matmarex added a comment to T315510: Start maintenance script to backfill talk page comment database.

Mentioned in SAL (#wikimedia-operations) [2024-02-16T14:33:38Z] <Lucas_WMDE> STOP persistRevisionThreadItems.php on enwiki for T315510 again, I forgot to adjust the --start >.<

So why was it still updating some rows anyway? o_O

Fri, Feb 16, 2:54 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Goal, MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Editing-team (Kanban Board), TPP-Phase1, DiscussionTools
matmarex closed T357745: Cannot reuse VE citations as Resolved.

Fix deployed to Wikimedia wikis.

Fri, Feb 16, 1:56 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), VisualEditor-MediaWiki-References, VisualEditor
matmarex merged T357761: Re-using references on the VisualEditor does not seem to work into T357745: Cannot reuse VE citations.
Fri, Feb 16, 12:06 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), VisualEditor-MediaWiki-References, VisualEditor
matmarex merged task T357761: Re-using references on the VisualEditor does not seem to work into T357745: Cannot reuse VE citations.
Fri, Feb 16, 12:06 PM · VisualEditor, VisualEditor-MediaWiki-References
matmarex added a comment to T357734: Visual Editor unable to be used when submitting Wikipedia:Did you know applications.

I complained about this some time ago too: https://en.wikipedia.org/wiki/Wikipedia_talk:Did_you_know/Archive_185#Why_are_nominations_in_the_Template_namespace%3F but no one was willing to move the DYK discussions to a more suitable namespace and allow the discussion tools to work.

Fri, Feb 16, 12:42 AM · DiscussionTools

Thu, Feb 15

matmarex claimed T357723: MediaWiki\Extension\DiscussionTools\Tests\ApiParseDiscussionToolsTest::testApiParseSections failure.

Thanks for reverting, I'll take a look.

Thu, Feb 15, 9:59 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), ci-test-error (WMF-deployed Build Failure), DiscussionTools
matmarex removed a project from T352827: Directory traversal allows single-page whitelisting to override entire spam-blacklist entry: Patch-For-Review.
Thu, Feb 15, 8:31 PM · SecTeam-Processed, Vuln-Misconfiguration, SpamBlacklist, Security, Security-Team
matmarex closed T352827: Directory traversal allows single-page whitelisting to override entire spam-blacklist entry as Resolved.

(This was resolved by that patch, I just forgot to close it. @sbassett Could you please make it public?)

Thu, Feb 15, 8:29 PM · SecTeam-Processed, Vuln-Misconfiguration, SpamBlacklist, Security, Security-Team
matmarex added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Also, in the future (after migration), will we keep .mw-heading2, h2 and opposite .mw-heading2 h2 ? We may want to separate rules in two sets instead (one for .mw-heading2 block, another one for inline h2). But will that work on special pages, or with Parsoid?

Thu, Feb 15, 6:23 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
matmarex closed T356824: Unsuppressable DoubleEscaped warnings as Resolved.
Thu, Feb 15, 1:55 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), ci-test-error, phan-taint-check-plugin
matmarex closed T289226: Convert EasyTimeline extension to use Shellbox as Resolved.
Thu, Feb 15, 11:57 AM · EasyTimeline, Shellbox, MW-on-K8s
matmarex closed T289226: Convert EasyTimeline extension to use Shellbox, a subtask of T289225: Convert all Wikimedia-deployed extensions to shell out via Shellbox, as Resolved.
Thu, Feb 15, 11:56 AM · Patch-For-Review, Shellbox, MW-on-K8s
matmarex closed T357268: Image of timeline not found on upload.wikimedia.org as Resolved.
Thu, Feb 15, 11:32 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), EasyTimeline
matmarex added a comment to T357268: Image of timeline not found on upload.wikimedia.org.

It turns out that the HTTP 404 errors we were seeing were just cached for 10 minutes. You should be able to fix the broken timelines now by just purging the affected pages.

Thu, Feb 15, 11:28 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), EasyTimeline
matmarex updated subscribers of T357268: Image of timeline not found on upload.wikimedia.org.

Reverted with help from @Joe and @Lucas_Werkmeister_WMDE. Editing timelines works for me now. However, existing timelines that were previously affected by this bug still don't display; we're trying to figure out why.

Thu, Feb 15, 11:17 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), EasyTimeline
matmarex claimed T357268: Image of timeline not found on upload.wikimedia.org.

The only recent change to the extension is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/timeline/+/335038 "Include article name in Ploticus error messages". And I noticed that timelines only fail in articles with special characters in the title (either parentheses or non-ASCII text), which seems like it could be caused by incorrect escaping in that patch. We're reverting it now.

Thu, Feb 15, 10:50 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), EasyTimeline