Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (226 w, 6 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Today

matmarex merged T204239: Investigate ways to improve the copy-pasting workflow on mobile into T101113: Come up with a way to move/remove/duplicate focusable nodes in mobile.
Fri, Feb 22, 5:05 AM · VisualEditor, Design, VisualEditor-MediaWiki-Mobile
matmarex merged task T204239: Investigate ways to improve the copy-pasting workflow on mobile into T101113: Come up with a way to move/remove/duplicate focusable nodes in mobile.
Fri, Feb 22, 5:05 AM · VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor
matmarex added a comment to T216648: Can't cut, copy, or delete templates (probably all similar nodes) in mobile-visual editor from the keyboard.

In mobile VE, we render a fake selection for these nodes rather than a "native" selection, because a native selection causes the touch keyboard to pop up on mobile devices. The lack of native selection means that keyboard shortcuts that operate on text selection won't work (and this is a low priority issue for actual mobile devices, because they are not often used with a hardware keyboard, and the touch keyboard doesn't have these keys/shortcuts).

Fri, Feb 22, 5:05 AM · VisualEditor, VisualEditor-MediaWiki-Mobile
matmarex added a parent task for T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable: T216792: Ordered lists look broken in mobile VE.
Fri, Feb 22, 1:59 AM · Readers-Web-Backlog (Design), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
matmarex added a subtask for T216792: Ordered lists look broken in mobile VE: T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.
Fri, Feb 22, 1:59 AM · VisualEditor
matmarex added a subtask for T208102: Improve compatibility of desktop VisualEditor with desktop Minerva skin: T216792: Ordered lists look broken in mobile VE.
Fri, Feb 22, 1:59 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Editing QA, VisualEditor (Current work), MinervaNeue, VisualEditor-MediaWiki
matmarex added a parent task for T216792: Ordered lists look broken in mobile VE: T208102: Improve compatibility of desktop VisualEditor with desktop Minerva skin.
Fri, Feb 22, 1:59 AM · VisualEditor
matmarex created T216792: Ordered lists look broken in mobile VE.
Fri, Feb 22, 1:59 AM · VisualEditor
matmarex removed a project from T208102: Improve compatibility of desktop VisualEditor with desktop Minerva skin: Patch-For-Review.
Fri, Feb 22, 1:23 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Editing QA, VisualEditor (Current work), MinervaNeue, VisualEditor-MediaWiki
matmarex moved T208068: Can't open the visual editor on MinervaNeue on desktop from Stalled/Waiting to QA on the VisualEditor (Current work) board.

What do you mean by "test wiki"? It is not yet live on https://test.wikipedia.org/, it will go out with the train next week. It is live on Beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)/sandbox?useskin=minerva) and this functionality works as expected there for me (other than the "read-only mode" and not being able to save changes, which is apparently an unrelated ongoing issue).

Fri, Feb 22, 1:22 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, MinervaNeue

Wed, Feb 20

matmarex moved T216264: Rename or remove 'View.$' from Code review to Engineering QA on the VisualEditor (Current work) board.
Wed, Feb 20, 10:49 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Technical-Debt, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Patch-For-Review, MobileFrontend
matmarex added a comment to T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.

I see what you mean, but I don't think that's a problem. I've always seen ordered lists displayed (and printed) in this way (with the digits of the same magnitude aligned).

Wed, Feb 20, 10:49 PM · Readers-Web-Backlog (Design), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
matmarex added a comment to T150377: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable.

I think we still want to switch to outside list style for ordered lists (for scannability, for consistency with unordered lists, and to avoid the rendering bug inside styling causes in VE as seen on T208102).

Wed, Feb 20, 10:13 PM · Readers-Web-Backlog (Design), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Unplanned-Sprint-Work, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), User-Jdlrobson, MinervaNeue, Design, WMF-Design
matmarex closed T203158: uca-tr collation lists "I" as "ı" in category pages on trwiki as Resolved.

This will be fixed on Turkish Wikipedia next week, with the deployment of MW 1.33.0-wmf.19.

Wed, Feb 20, 9:23 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MediaWiki-Categories, Turkish-Sites, Wikimedia-Site-requests
matmarex closed T203158: uca-tr collation lists "I" as "ı" in category pages on trwiki, a subtask of T184943: Set $wgCategoryCollation = uca-tr on trwiki, as Resolved.
Wed, Feb 20, 9:23 PM · User-Urbanecm, Patch-For-Review, Turkish-Sites, Wikimedia-Site-requests
matmarex moved T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Wed, Feb 20, 8:24 PM · Editing QA, VisualEditor (Current work), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API
matmarex edited projects for T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses, added: VisualEditor (Current work); removed VisualEditor.
Wed, Feb 20, 8:24 PM · Editing QA, VisualEditor (Current work), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API
matmarex renamed T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses from VisualEditor does not auto-block IP addresses to VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses.
Wed, Feb 20, 8:24 PM · Editing QA, VisualEditor (Current work), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API
matmarex added a comment to T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses.

Thank you for fixing this!

Wed, Feb 20, 8:23 PM · Editing QA, VisualEditor (Current work), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API
matmarex added a hashtag to VisualEditor (Current work): #visualeditor-current.
Wed, Feb 20, 8:16 PM
matmarex added a comment to T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead.

When the patch was cherry-picked to change 488117 and deployed, it had no effect.

Wed, Feb 20, 1:56 AM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, MobileFrontend
matmarex moved T208068: Can't open the visual editor on MinervaNeue on desktop from Code review to QA on the VisualEditor (Current work) board.
Wed, Feb 20, 1:46 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, MinervaNeue
matmarex moved T216248: Citation logging splits events by citation type from Code review to Engineering QA on the VisualEditor (Current work) board.
Wed, Feb 20, 1:44 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, VisualEditor (Current work)
matmarex added a comment to T216582: demos: ButtonWidget (icon only) and without `invisibleLabel` results in oversized height on IE 10 & 11, Edge 15.

This only occurs for this single demo example, and nowhere else. It seems to be caused by the unicode-bidi: bidi-override; rule added in https://gerrit.wikimedia.org/r/c/oojs/ui/+/482703/5/demos/styles/demo.css#422 (it disappears when I remove it). That rule should only apply to elements with a label, but it also applies to these label-less buttons. I don't think we need the workaround in OOUI library code, only in demo code.

Wed, Feb 20, 1:18 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, OOUI (OOUI-0.30.3), Browser-Support-Internet-Explorer

Tue, Feb 19

matmarex closed T216449: MobileFrontend build does not fail when Webpack-generated files are not committed as Declined.
Tue, Feb 19, 11:34 PM · VisualEditor (Current work), Patch-For-Review, MobileFrontend
matmarex placed T212159: Scrolling a ProcessDialog scrolls the page behind on iphone 6S/iOS12.1.1/Safari up for grabs.

Lukewarm responses to my patch convince me that we all feel like the solutions are worse than the problem. I am not planning to work on this further. Please read my earlier comments for the drawbacks of each possible solution.

Tue, Feb 19, 11:17 PM · Browser-Support-Apple-Safari, OOUI
matmarex added a comment to T216413: Support accesskey (small k) in AccessKeyedElement trait.

I have no opinion, but if you make this change, you should also add similar aliases for any other analogical options/attributes – for example, tabIndex in TabIndexedElement and noFollow in ButtonWidget.

Tue, Feb 19, 8:03 PM · OOUI
matmarex added a comment to T210630: [Engineering EPIC]: Loading screen improvements.

No, it’s easy to use the indeterminate progress bar.

Tue, Feb 19, 5:01 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review

Mon, Feb 18

matmarex added a project to T216456: Visual editor fails to create reference from JSTOR: Citoid.
Mon, Feb 18, 11:55 PM · Citoid
matmarex added a comment to T216456: Visual editor fails to create reference from JSTOR.

The browser console output looks like a problem with some browser extension, or with the console (developer tools) itself, rather than VisualEditor.

Mon, Feb 18, 11:55 PM · Citoid
matmarex added a comment to T213767: HTMLSelectField doesn't use the `default` value when an invalid value is submitted.

I think it's a valid issue? The problem is slightly different than you described it originally, but there is a real problem here, as I hope I explained in the comments above.

Mon, Feb 18, 11:31 PM · MediaWiki-HTMLForm
matmarex moved T208068: Can't open the visual editor on MinervaNeue on desktop from In progress to Code review on the VisualEditor (Current work) board.
Mon, Feb 18, 11:12 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, MinervaNeue
matmarex updated the task description for T208102: Improve compatibility of desktop VisualEditor with desktop Minerva skin.
Mon, Feb 18, 10:59 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Editing QA, VisualEditor (Current work), MinervaNeue, VisualEditor-MediaWiki
matmarex moved T208068: Can't open the visual editor on MinervaNeue on desktop from Stalled/Waiting to In progress on the VisualEditor (Current work) board.

Looks like my fixes for this task have been very precisely unfixed, and the mobile editor loads on desktop again, bringing back the problems. I'm not sure which particular patch caused it, maybe rEMFR2309260e78b0: mobile.editor module merged into mobile.init? I will try to fix it again and hope it sticks.

Mon, Feb 18, 10:57 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), VisualEditor (Current work), Patch-For-Review, MinervaNeue
matmarex moved T216449: MobileFrontend build does not fail when Webpack-generated files are not committed from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Feb 18, 10:06 PM · VisualEditor (Current work), Patch-For-Review, MobileFrontend
matmarex added a project to T216449: MobileFrontend build does not fail when Webpack-generated files are not committed: VisualEditor (Current work).
Mon, Feb 18, 10:06 PM · VisualEditor (Current work), Patch-For-Review, MobileFrontend
matmarex added a comment to T216446: Page zooms slightly when focusing document on iPhone.

This does not happen for me using iPhone SE, which should be the same screen size. (In this recording, I zoom in with pinch-zoom.)

Mon, Feb 18, 10:05 PM · VisualEditor, VisualEditor-MediaWiki-Mobile
matmarex claimed T216449: MobileFrontend build does not fail when Webpack-generated files are not committed.
Mon, Feb 18, 9:38 PM · VisualEditor (Current work), Patch-For-Review, MobileFrontend
matmarex moved T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead from Stalled/Waiting to QA on the VisualEditor (Current work) board.

On en.wiki, it did not prompt for any CAPTCHA when I added an external link for the first time in a session but after that for subsequent sessions it did.

Mon, Feb 18, 9:29 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, MobileFrontend
matmarex created T216449: MobileFrontend build does not fail when Webpack-generated files are not committed.
Mon, Feb 18, 9:28 PM · VisualEditor (Current work), Patch-For-Review, MobileFrontend
matmarex reopened T214963: Database contention due to concurrent requests to ApiOptions as "Open".

(Eh, I guess we should go through the motions if I've put it on our workboard; for anyone else watching it, please consider it resolved)

Mon, Feb 18, 8:45 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), VisualEditor (Current work), MediaWiki-Database
matmarex reopened T214963: Database contention due to concurrent requests to ApiOptions, a subtask of T30499: 1205: Lock wait timeout exceeded; try restarting transaction (tracking), as Open.
Mon, Feb 18, 8:44 PM · MediaWiki-General-or-Unknown, Technical-Debt, Tracking
matmarex closed T214963: Database contention due to concurrent requests to ApiOptions as Resolved.
Mon, Feb 18, 8:43 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), VisualEditor (Current work), MediaWiki-Database
matmarex closed T214963: Database contention due to concurrent requests to ApiOptions, a subtask of T30499: 1205: Lock wait timeout exceeded; try restarting transaction (tracking), as Resolved.
Mon, Feb 18, 8:43 PM · MediaWiki-General-or-Unknown, Technical-Debt, Tracking
matmarex added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

Also, if you're sorting alphabetically, you have to sort according to the rules of the given language. For example, in Czech (cs), the namespace "Šablona" (Template) should be ordered after "Soubor" (File) and before "Uživatel" (User). The currently proposed patch will put it at the end of the list. In PHP you can use the Collator class for this (but you'll have to have a fallback in case the 'intl' extension is not available, since we don't actually require it right now).

Mon, Feb 18, 8:23 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
matmarex added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

I think one argument for keeping the current order (by namespace id) is that it is consistent across all languages. As someone who is occasionally asked to debug weird issues in various languages, I find it very convenient to navigate the interface without being able to speak the language it's written in. (Note that the namespace names are in the wiki content language even if you switch your interface language.) This is very much a minority use case though (probably only relevant to developers and stewards).

Mon, Feb 18, 8:16 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
matmarex added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

I thought that this can't possibly be the first time this is proposed, searched, and found the two duplicates. :) There was some discussion there (and also semi-relevant discussion on T176992, about the dropdown on Special:RecentChanges only).

Mon, Feb 18, 8:07 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
matmarex merged tasks T47771: Sort namespaces by name (not by internal numbers), T191138: Namespace drop-down should be sorted in human-friendly order into T146418: Special:Contributions lists namespaces by index number, which is not intuitive.
Mon, Feb 18, 8:06 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
matmarex merged task T47771: Sort namespaces by name (not by internal numbers) into T146418: Special:Contributions lists namespaces by index number, which is not intuitive.
Mon, Feb 18, 8:06 PM · MediaWiki-Special-pages
matmarex merged task T191138: Namespace drop-down should be sorted in human-friendly order into T146418: Special:Contributions lists namespaces by index number, which is not intuitive.
Mon, Feb 18, 8:06 PM · MediaWiki-Interface
matmarex added a comment to T214811: WTE2017 preview doesn't de-duplicate the categories.

Hm.. Just wondering why don't we use OWE JavaScript Preview for this? Issues like this has been already debugged in it over the years.

Mon, Feb 18, 6:02 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a parent task for T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader: T214450: Analyze impact of parallel loading of page content and mobile visual editor code.
Mon, Feb 18, 5:53 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
matmarex added a subtask for T214450: Analyze impact of parallel loading of page content and mobile visual editor code: T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.
Mon, Feb 18, 5:53 PM · VisualEditor, Product-Analytics, Performance, VisualEditor-MediaWiki-Mobile
matmarex removed a subtask for T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader: T214450: Analyze impact of parallel loading of page content and mobile visual editor code.
Mon, Feb 18, 5:53 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile
matmarex removed a parent task for T214450: Analyze impact of parallel loading of page content and mobile visual editor code: T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.
Mon, Feb 18, 5:53 PM · VisualEditor, Product-Analytics, Performance, VisualEditor-MediaWiki-Mobile
matmarex moved T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader from Engineering QA to Product owner review on the VisualEditor (Current work) board.

I wanted to compare the performance using the production data as part of QA:

Mon, Feb 18, 5:53 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-MediaWiki-Mobile

Fri, Feb 15

matmarex added a project to T216245: VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses: MediaWiki-API.

VisualEditor and MobileFrontend both use the action=edit API for saving changes.

Fri, Feb 15, 9:57 PM · Editing QA, VisualEditor (Current work), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-API
matmarex moved T213522: Reconsider URL changes done by Visual Diff from FY 18-19 to Up next on the VisualEditor board.
Fri, Feb 15, 9:43 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
matmarex moved T211898: Bits of WikiEditor UI being shown when following red link in WTE2017 from FY 18-19 to Up next on the VisualEditor board.
Fri, Feb 15, 9:42 PM · VisualEditor (Current work), Technical-Debt, VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T207325: Footnote weirdness after editing the title parameter from Code review to In progress on the VisualEditor (Current work) board.

With that patch, the issue is fixed for refs' context menus, but it is not fixed for reflists' CE renderings. We might need a similar patch in the Cite extension?

Fri, Feb 15, 9:03 PM · Patch-For-Review, Verified, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), VisualEditor (Current work), TemplateStyles
matmarex added a comment to T210630: [Engineering EPIC]: Loading screen improvements.

Right, I'll have to work on whatever we ultimately decide on in T214477 but in the interim we can use the most similar interaction. I think that is the indeterminate progress bar.

Fri, Feb 15, 5:03 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex added a project to T103883: CentralAuth wrongly reports successful auto-login on mirrors: ExternalGuidance.
Fri, Feb 15, 3:46 PM · ExternalGuidance, MediaWiki-extensions-CentralAuth
matmarex merged task T216124: Misleading login message is shown into T103883: CentralAuth wrongly reports successful auto-login on mirrors.
Fri, Feb 15, 3:46 PM · ExternalGuidance
matmarex merged T216124: Misleading login message is shown into T103883: CentralAuth wrongly reports successful auto-login on mirrors.
Fri, Feb 15, 3:46 PM · ExternalGuidance, MediaWiki-extensions-CentralAuth
matmarex added a comment to T216124: Misleading login message is shown.

I logged-out and the issue was not happening. When I logged-in again the issues was not happening. So there is some intermittent behaviour with this that makes it hard to reproduce, but the issue still happens in some cases.

Fri, Feb 15, 3:46 PM · ExternalGuidance
matmarex merged task T72487: Show no "central login" notification for framed pages into T103883: CentralAuth wrongly reports successful auto-login on mirrors.
Fri, Feb 15, 3:41 PM · MediaWiki-extensions-CentralAuth
matmarex merged T72487: Show no "central login" notification for framed pages into T103883: CentralAuth wrongly reports successful auto-login on mirrors.
Fri, Feb 15, 3:41 PM · ExternalGuidance, MediaWiki-extensions-CentralAuth
matmarex added a comment to T210630: [Engineering EPIC]: Loading screen improvements.

I've able to get the toolbar to show twice when loading/closing the editor repeatedly: (…)

Fri, Feb 15, 1:29 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex added a comment to T215741: Pasting in an link from Google-translated content throws an exception.

However, is there any expectation that the links will be preserved? Because that is not happening. Links within the copied text revert to plain text when pasted into VE-- and that's true whether or not the pasted text is Google-translated.

Fri, Feb 15, 1:18 AM · Verified, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), VisualEditor (Current work), Patch-For-Review, VisualEditor-CopyPaste

Thu, Feb 14

matmarex moved T214533: Mobile visual editor not logging EditAttemptStep abort actions from Code review to QA on the VisualEditor (Current work) board.
Thu, Feb 14, 10:47 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, VisualEditor (Current work), Contributors-Analysis, Product-Analytics
matmarex moved T211490: iPad Pro/iOS 12.1: scrolling is broken when editing mobile site in source mode from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Thu, Feb 14, 8:59 PM · Patch-For-Review, VisualEditor (Current work), Advanced Mobile Contributions, Readers-Web-Backlog (Tracking), MobileFrontend
matmarex claimed T211490: iPad Pro/iOS 12.1: scrolling is broken when editing mobile site in source mode.

This occurs because when iOS scrolls the cursor into view after opening the keyboard, it scrolls the browser viewport (and we otherwise go to great lenghts to avoid it from being scrolled, because on iOS we maintain our own viewport to work around lack of support for fixed elements). We work around this issue in mobile VE, but the mobile wikitext editor has no workaround for it.

Thu, Feb 14, 5:03 PM · Patch-For-Review, VisualEditor (Current work), Advanced Mobile Contributions, Readers-Web-Backlog (Tracking), MobileFrontend
matmarex added a comment to T210630: [Engineering EPIC]: Loading screen improvements.

Based on the research that @matmarex did on T216034#4952525 I'm wondering if the best solution here would be to go back to an indeterminate throbber. I did some research and found in A study on tolerable waiting time: how long are Web users willing to wait? that most users’ tolerable wait time is 4 seconds.

Thu, Feb 14, 4:26 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex added a comment to T210630: [Engineering EPIC]: Loading screen improvements.

(Krinkle talked to me yesterday after seeing the loading progress investigation. Apparently there exists a Navigator.connection API that can be used to get some data about the user's connection speed, which we could use to estimate load time. However, it seems sparsely supported by browsers.)

Thu, Feb 14, 4:19 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex added a comment to T208139: Georgian words are automatically (incorrectly) capitalized when entered.

This is definitely not caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/314725. That patch actually fixed a similar issue to this, but with characters from other alphabets (T147646). It does nothing about Georgian scripts though.

Thu, Feb 14, 2:42 AM · I18n, Wikidata, MediaWiki-extensions-WikibaseClient

Wed, Feb 13

matmarex closed T216034: Find out what it would take for VisualEditor loading progress bar to be correct as Resolved.
Wed, Feb 13, 9:25 PM · Patch-For-Review, VisualEditor (Current work)
matmarex closed T216034: Find out what it would take for VisualEditor loading progress bar to be correct, a subtask of T210630: [Engineering EPIC]: Loading screen improvements, as Resolved.
Wed, Feb 13, 9:25 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex added a comment to T216034: Find out what it would take for VisualEditor loading progress bar to be correct.

I spent a few hours finding out. The conclusion: it could be done, but it would take a lot of work, we would need support from folks in Performance and SRE, and from whoever owns RESTBase these days, and the end result would probably still feel worse to users than the current fake progress bar.

Wed, Feb 13, 9:22 PM · Patch-For-Review, VisualEditor (Current work)
matmarex removed a project from T215469: [Bug] Closing editor overlay shows loading spinner indefinitely: Editing QA.
Wed, Feb 13, 7:06 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, Patch-For-Review, Regression, MobileFrontend
matmarex removed a project from T209714: Switching from VisualEditor to SourceEditor on Mobile frontend causes funkyness when trying to edit different section: Editing QA.
Wed, Feb 13, 6:45 PM · Verified, Patch-For-Review, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
matmarex added a project to T101483: VisualEditor gives warning on Firefox for Android: Editing QA.
Wed, Feb 13, 6:44 PM · Editing QA, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, jQuery-Client, Browser-Support-Firefox, VisualEditor-MediaWiki-Mobile
matmarex added a project to T209714: Switching from VisualEditor to SourceEditor on Mobile frontend causes funkyness when trying to edit different section: Editing QA.
Wed, Feb 13, 6:44 PM · Verified, Patch-For-Review, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
matmarex added a project to T215694: VE mobile has extra padding on wide screens: Editing QA.
Wed, Feb 13, 6:44 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, VisualEditor (Current work), MobileFrontend, VisualEditor-MediaWiki-Mobile
matmarex added a project to T215741: Pasting in an link from Google-translated content throws an exception: Editing QA.
Wed, Feb 13, 6:44 PM · Verified, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), VisualEditor (Current work), Patch-For-Review, VisualEditor-CopyPaste
matmarex added a project to T215469: [Bug] Closing editor overlay shows loading spinner indefinitely: Editing QA.
Wed, Feb 13, 6:43 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, Patch-For-Review, Regression, MobileFrontend
matmarex added a project to T212554: Visual editor source editing preview does not link to changed reference footnotes: Editing QA.
Wed, Feb 13, 6:43 PM · Verified, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)
matmarex closed T215849: Clicking in textareas in iOS causes browser to zoom (e.g. in talk overlay) as Resolved.
Wed, Feb 13, 3:35 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, MobileFrontend, Readers-Web-Backlog
matmarex moved T216034: Find out what it would take for VisualEditor loading progress bar to be correct from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Wed, Feb 13, 3:33 PM · Patch-For-Review, VisualEditor (Current work)
matmarex added a subtask for T210630: [Engineering EPIC]: Loading screen improvements: T216034: Find out what it would take for VisualEditor loading progress bar to be correct.
Wed, Feb 13, 1:16 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex added a parent task for T216034: Find out what it would take for VisualEditor loading progress bar to be correct: T210630: [Engineering EPIC]: Loading screen improvements.
Wed, Feb 13, 1:16 PM · Patch-For-Review, VisualEditor (Current work)
matmarex claimed T216034: Find out what it would take for VisualEditor loading progress bar to be correct.
Wed, Feb 13, 1:16 PM · Patch-For-Review, VisualEditor (Current work)
matmarex created T216034: Find out what it would take for VisualEditor loading progress bar to be correct.
Wed, Feb 13, 1:16 PM · Patch-For-Review, VisualEditor (Current work)
matmarex claimed T208139: Georgian words are automatically (incorrectly) capitalized when entered.
Wed, Feb 13, 1:08 PM · I18n, Wikidata, MediaWiki-extensions-WikibaseClient
matmarex added a comment to T210630: [Engineering EPIC]: Loading screen improvements.

Here's what the scroll jump looks like to me. I tested this on Android and saw it there as well so I don't believe it's an i0S bug. This is shown in Safari and chrome.

Wed, Feb 13, 12:40 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing Design , VisualEditor (Current work), Patch-For-Review
matmarex moved T213214: Visual Editor gets stuck opening article (net::ERR_SPDY_PROTOCOL_ERROR 200/Loading failed for the <script> with source ...) from Freezer to External and Administrivia on the VisualEditor board.

https://stackoverflow.com/questions/33867014/what-does-err-spdy-protocol-error-mean-in-nginx indeed says that Chrome's net::ERR_SPDY_PROTOCOL_ERROR is equivalent to Firefox's "failure to load resource", and it has the suggestion:

If you are caching assets, then check the drive space on your nginx server.

which seems a very reasonable advice given that the error occurs on the probably largest resource that is used.
So, do the cache servers have enough space?

Wed, Feb 13, 11:25 AM · Traffic, Wikimedia-Apache-configuration, Operations, VisualEditor
matmarex merged T214534: VisualEditor sometimes fails to load (script load.php not loaded) into T213214: Visual Editor gets stuck opening article (net::ERR_SPDY_PROTOCOL_ERROR 200/Loading failed for the <script> with source ...).
Wed, Feb 13, 11:23 AM · Traffic, Wikimedia-Apache-configuration, Operations, VisualEditor
matmarex merged task T214534: VisualEditor sometimes fails to load (script load.php not loaded) into T213214: Visual Editor gets stuck opening article (net::ERR_SPDY_PROTOCOL_ERROR 200/Loading failed for the <script> with source ...).
Wed, Feb 13, 11:23 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a comment to T214534: VisualEditor sometimes fails to load (script load.php not loaded).

Oh, thanks for finding that! I was just guessing based on when both tasks were reported.

Wed, Feb 13, 11:23 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a comment to T215360: Allow video embeds in formats other than OGV (e.g. WEBM).

People are using GIFs instead, because no one wants to spend 15 minutes every time re-encoding an OGV until you get one that is <4 MB and not utterly messed up by the encoder, and it makes me sad :( T210630#4949865 T215361

Wed, Feb 13, 10:13 AM · Phabricator
matmarex moved T208631: Copy/Paste of images in Visual editor does not work browser page to browser page as expected from Code review to QA on the VisualEditor (Current work) board.
Wed, Feb 13, 10:07 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Editing QA, VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools