matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (148 w, 4 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Mon, Aug 21

matmarex added a comment to T173730: There is no search button in Revision history of pages.

Either I can't reproduce the issue you're describing or I don't understand your report. I see the "Show" button, and I see the pagination.

Mon, Aug 21, 6:53 PM · MediaWiki-History-or-Diffs
matmarex merged T173732: Can Phabricator be i18n? into T225: Use translatewiki.net to localize Phabricator.
Mon, Aug 21, 3:55 PM · Developer-Relations, Developer-Wishlist (2017), translatewiki.net, Upstream, Legalpad, Phabricator (Upstream)
matmarex merged task T173732: Can Phabricator be i18n? into T225: Use translatewiki.net to localize Phabricator.
Mon, Aug 21, 3:55 PM · Phabricator
matmarex added a comment to T173732: Can Phabricator be i18n?.

Currently it's not possible (other than by submitting patches upstream), but folks have been working on it.

Mon, Aug 21, 3:55 PM · Phabricator
matmarex edited projects for T173732: Can Phabricator be i18n?, added: Phabricator; removed I18n, MediaWiki-Internationalization.
Mon, Aug 21, 3:52 PM · Phabricator
matmarex added a project to T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions: Commons.

I've done the cleanup this morning. Ended up editing 486 pages. Many were already cleaned up by conscientious editors, some were false positives (broken syntax for coordinates etc. from old edits).

Mon, Aug 21, 3:36 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex edited projects for T173650: Inappropriate/broken redirecting of Japanese in search, added: MediaWiki-Search; removed MediaWiki-General-or-Unknown.
Mon, Aug 21, 12:32 PM · Discovery-Search, Discovery, CirrusSearch

Thu, Aug 17

matmarex added a comment to T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions.

There seem to be only three legitimate templates on Commons with potentially confusing names:

select page_title from page
where page_namespace=10
and page_title rlike '^[0-9]+$'
Thu, Aug 17, 10:14 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex added a comment to T26544: Watchlist tab empty (no alternative text) when loading images is off.

We could put a star emoji there (CSS-only, generated with :before/:after), normally hidden behind the image (using some positioning/z-index tricks)? ;)

Thu, Aug 17, 9:20 PM · Readers-Web-Backlog (Tracking), Vector, Accessibility
matmarex added a project to T63099: Vector: Remove use of raster graphics in the layout styles: Easy.

For the record, I think the gradients proposed by @Edokter in comment T63099#653216 above and https://test.wikipedia.org/wiki/MediaWiki:Gadget-ImagelessTabs.css look like a good starting point. Perhaps someone would want to turn that into a patch.

Thu, Aug 17, 9:16 PM · Easy, Readers-Web-Backlog (Tracking), Vector
matmarex merged T173367: Add some CSS (linear-gradient; separators) for the top panel into T63099: Vector: Remove use of raster graphics in the layout styles.
Thu, Aug 17, 9:15 PM · Easy, Readers-Web-Backlog (Tracking), Vector
matmarex merged task T173367: Add some CSS (linear-gradient; separators) for the top panel into T63099: Vector: Remove use of raster graphics in the layout styles.
Thu, Aug 17, 9:15 PM · CSS, Vector
matmarex added a project to T173360: PHP Notice: Undefined index: frameCount: Easy.

What is a LocalWikiDexFile, and why are GIFHandler and PNGHandler trying to handle it? :o Perhaps you have some extension that isn't cooperating with MediaWiki right.

Thu, Aug 17, 8:58 PM · Easy, Multimedia, Commons, MediaWiki-File-management
matmarex added a comment to T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).

Special:Upload is broken in this way on https://test.wikipedia.org/, https://test2.wikipedia.org/ and https://www.mediawiki.org/, but apparently not on he.wp (or other production wikis I checked). Perhaps this depends on some configuration too.

Thu, Aug 17, 8:55 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Special-pages, Regression, Notifications
matmarex renamed T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded) from Notifications icons are broken on Special:GadgetUsage to Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload) (module ext.echo.styles.badge not loaded).
Thu, Aug 17, 8:50 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Special-pages, Regression, Notifications
matmarex added a comment to T173392: Echo badge styles not applying on certain special pages.

This was apparently the first report of this, but the other one has gotten more comments.

Thu, Aug 17, 8:49 PM · MediaWiki-General-or-Unknown, Collaboration-Team-Triage, Notifications
matmarex merged T173392: Echo badge styles not applying on certain special pages into T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).
Thu, Aug 17, 8:49 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Special-pages, Regression, Notifications
matmarex merged task T173392: Echo badge styles not applying on certain special pages into T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).
Thu, Aug 17, 8:49 PM · MediaWiki-General-or-Unknown, Collaboration-Team-Triage, Notifications
matmarex closed T173279: Watch star on Timeless is not AJAX-ified as Resolved.

By the way, the two other features that the patch relies on also didn't exist when the original code was written:

Thu, Aug 17, 7:40 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface, Timeless
matmarex added a comment to T173279: Watch star on Timeless is not AJAX-ified.

Well, we could just move where the content wrapper encompasses, except
that all IS the page content, so perhaps not the best idea. If excluding
user-provided content is the idea, though, shouldn't there be a class
specifically for that? Or is that what mw-body-content is for? What if
you have multiple separated blocks of content?

Thu, Aug 17, 7:33 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface, Timeless
matmarex closed T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions as Resolved.

Yes, fixed and deployed.

Thu, Aug 17, 7:24 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex closed T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions, a subtask of T170632: 1.30.0-wmf.14 deployment blockers, as Resolved.
Thu, Aug 17, 7:24 PM · Train Deployments, Release-Engineering-Team (Kanban), Release
matmarex closed T86003: MediaWiki theme: Checkboxes and radios size (original design looks oversized on desktop) as Resolved.

With the fix for T148265, I think this is in fact resolved?

Thu, Aug 17, 7:20 PM · Patch-For-Review, UI-Standardization-Kanban, UI-Standardization, WMF-deploy-2015-02-04_(1.25wmf16), OOjs-UI
matmarex closed T86003: MediaWiki theme: Checkboxes and radios size (original design looks oversized on desktop), a subtask of T97631: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki's Vector skin, as Resolved.
Thu, Aug 17, 7:20 PM · Front-end-Standards-Group, OOjs-UI, VisualEditor-MediaWiki, VisualEditor
matmarex closed T86003: MediaWiki theme: Checkboxes and radios size (original design looks oversized on desktop), a subtask of T113560: Standardize MediaWiki components (tracking), as Resolved.
Thu, Aug 17, 7:20 PM · UI-Standardization-Kanban, Tracking, UI-Standardization
matmarex closed T86003: MediaWiki theme: Checkboxes and radios size (original design looks oversized on desktop), a subtask of T136371: Design shortcomings of current M101 widget overview (tracking), as Resolved.
Thu, Aug 17, 7:20 PM · WMF-Design, Tracking, UI-Standardization, UI-Standardization-Kanban, Design
matmarex added a comment to T148265: mediawiki.UI: Bring Checkboxes and Radios on par with M101 and OOjs UI implementation.

Notably, this changes the checkbox on Special:UserLogin (finally!):

Thu, Aug 17, 7:18 PM · MW-1.30-release-notes, Unplanned-Sprint-Work, Readers-Web-Kanban-Board, UI-Standardization, Design, UI-Standardization-Kanban
matmarex added a comment to T173531: New 'edit source' icon.

VE itself uses a pencil for the concept of editing, brackets for source editing and eye for visual editing. I think we settled on this unhappily after considering a few different things (T97451 and T116417 look relevant). If you invent a better metaphor, VE team might want to hear about it too

Thu, Aug 17, 6:51 PM · Timeless
matmarex added a comment to T173519: Please allow use of HeaderCount extension on eswiki.

This is not a formal review, but some quick thoughts about the HeaderCount extension:

  • It looks like the extension is not in our repositories on Gerrit, but only on GitHub. It would have to be imported first, so that we can do deployments without relying on external services.
  • Looking at the code, it looks like the extension does nothing to make sure it is reading the latest page content after a page has just been saved – we'd have to test it, but I think it would basically require purging a page every time after it is edited to get the correct results.
  • It also doesn't account for heading generates by embedded templates.
Thu, Aug 17, 6:24 PM · Wikimedia-Extension-setup
matmarex added a comment to T173525: Overflowing stuff in header causes header to overflow over colour border and anything on top of page (mismatched offset).

There's a (probably) core issue existing right now which causes this to break some pages (T173411), notably https://test2.wikipedia.org/wiki/Special:Upload.

Thu, Aug 17, 6:09 PM · Timeless
matmarex added a comment to T173411: Notifications icons are broken on some special pages (Special:GadgetUsage, Special:Upload, Special:Notifications) (module ext.echo.styles.badge not loaded).

A similar issue is reproducible on Special:Upload on test.wp (https://test2.wikipedia.org/wiki/Special:Upload?safemode=1), but no on any others pages I tested.

Thu, Aug 17, 6:06 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, MediaWiki-Special-pages, Regression, Notifications
matmarex added a comment to T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions.

I posted a quick notification about it: https://commons.wikimedia.org/wiki/Commons:Village_pump#.7B.7B83.7C.E2.80.A6.7D.7D_and_similar_broken_templates_in_UploadWizard_uploads

Thu, Aug 17, 5:46 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex added a comment to T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions.

After this is deployed, we'll need to find and fix the broken uploads. I will be doing that.

Thu, Aug 17, 5:45 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex added a parent task for T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions: T170632: 1.30.0-wmf.14 deployment blockers.
Thu, Aug 17, 5:37 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex added a subtask for T170632: 1.30.0-wmf.14 deployment blockers: T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions.
Thu, Aug 17, 5:37 PM · Train Deployments, Release-Engineering-Team (Kanban), Release
matmarex claimed T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions.

Caused by https://gerrit.wikimedia.org/r/#/c/371737/

Thu, Aug 17, 5:33 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex created T173522: UploadWizard generates wikitext like '{{83|...}}' (with different numbers) instead of '{{en|...}}' in file descriptions.
Thu, Aug 17, 5:32 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Commons, Patch-For-Review, Multimedia, UploadWizard
matmarex added a comment to T171581: Find a good name for new attribute in ref tag.

Also – given that these are still not translateable in the year 2017 (really…?), I think it would be valuable to choose a name more likely to be familiar to non-native English speakers. So I would vote againts "refine"/"refines" :(

Thu, Aug 17, 3:38 PM · TCB-Team, Cite
matmarex added a comment to T171581: Find a good name for new attribute in ref tag.

I don't know if you're looking for more ideas (I only saw this scrolling by on IRC), but there's a lot more words that could be used.

Thu, Aug 17, 3:36 PM · TCB-Team, Cite
matmarex added a comment to T129184: DraggableGroupWidget acts really silly when disabled.

I don't think they're related, This is about passing disabled: true or calling .setDisabled( true ).

Thu, Aug 17, 1:48 PM · OOjs-UI
matmarex added a comment to T154371: Review and deploy Timeless skin.

I have not seen what happens, but the worst case is that the interface gets so messed up that users have trouble reaching the Preferences page and changing their skin back. (The page Special:Preferences has all custom CSS turned off for this reason, but if you don't know how to get there other than typing the URL this can still be problematic.) Perhaps folks just erred on the side of caution here. This should not block other deployments, I think.

Thu, Aug 17, 1:40 PM · Patch-For-Review, User-notice, Wikimedia-Extension-setup, Community-consensus-needed, Timeless
matmarex added a comment to T154371: Review and deploy Timeless skin.

Per https://fr.wiktionary.org/wiki/Wiktionnaire:Wikidémie/août_2017#D.C3.A9ployement_de_Timeless it seems that existing on-wiki custom CSS conflicted with Timeless.

Thu, Aug 17, 1:32 PM · Patch-For-Review, User-notice, Wikimedia-Extension-setup, Community-consensus-needed, Timeless

Mon, Aug 14

matmarex closed T170586: Action `move` cannot be tested in AbuseFilter as Resolved.
Mon, Aug 14, 8:05 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), AbuseFilter
matmarex closed T170586: Action `move` cannot be tested in AbuseFilter, a subtask of T170574: Actions other than `edit` cannot be retrospectively tested in AbuseFilter, as Resolved.
Mon, Aug 14, 8:05 PM · Patch-For-Review, AbuseFilter
Ltrlg awarded T173279: Watch star on Timeless is not AJAX-ified a Piece of Eight token.
Mon, Aug 14, 8:27 AM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface, Timeless

Sun, Aug 13

matmarex added a comment to T173279: Watch star on Timeless is not AJAX-ified.

Hmm, yeah... that'll require some extra effort to make sure it works with all the skins, but it seems like a better long-term solution.

Sun, Aug 13, 9:58 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface, Timeless
matmarex added a project to T173279: Watch star on Timeless is not AJAX-ified: MediaWiki-Interface.

This is actually a core feature that doesn't for with Timeless - see resources/src/mediawiki/page/watch.js.

Sun, Aug 13, 9:41 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface, Timeless
matmarex created T173279: Watch star on Timeless is not AJAX-ified.
Sun, Aug 13, 9:38 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface, Timeless
matmarex added a comment to T173219: Timeless uses words instead of a heart for wikilove.

I kind of feel like however this is done for Vector, it'll need to be done differently for Timeless... probably should move that code to Vector and redo it in Timeless.

Sun, Aug 13, 9:34 PM · WikiLove, Collaboration-Team-Triage, Timeless
matmarex closed T171978: Language names in the dropdown menus are sorted in the wrong order (in most languages) as Resolved.
Sun, Aug 13, 7:08 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Multimedia, UploadWizard
matmarex closed T172220: Some languages in UploadWizard's dropdown list are displayed twice as Resolved.
Sun, Aug 13, 7:07 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Multimedia, UploadWizard
matmarex closed T126886: Tablesorter not sorting certain columns in Firefox & Safari as Resolved.
Sun, Aug 13, 6:47 PM · MW-1.30-release-notes, User-notice, Browser-Support-Apple-Safari, Browser-Support-Firefox, MediaWiki-jQuery-Tablesorter
matmarex added a comment to T2424: Add a direct unwatch link to entries on Special:Watchlist.

Thanks for the comments Pau.

Sun, Aug 13, 3:58 PM · MW-1.30-release-notes, User-notice, Community-Wishlist-Survey-2016, Design, MediaWiki-Watchlist
matmarex closed T2424: Add a direct unwatch link to entries on Special:Watchlist as Resolved.

I think we should mention this new feature in next Tech News - note that it's off by default for now (you have to turn it on in preferences). I wish we could turn it on for everyone, but let's see how well it's received first :)

Sun, Aug 13, 3:46 PM · MW-1.30-release-notes, User-notice, Community-Wishlist-Survey-2016, Design, MediaWiki-Watchlist

Sat, Aug 12

matmarex edited projects for T32553: UDP log message for AbuseFilter should be in content language, added: TestMe; removed Patch-For-Review.

This patch probably helps by standardizing how the log messages are generated, but I'm not really sure what this task is exactly about -- if anyone knows what it's about, please test it :D The patch should go live to Wikimedia wikis next week.

Sat, Aug 12, 11:25 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), TestMe, AbuseFilter
matmarex added a comment to T173220: The dropdown menu in flow (three dots on a thread) has weird borders in Timeless.

I blame the partial mw-ui styles D:

Sat, Aug 12, 9:15 PM · Collaboration-Team-Triage, Flow, Timeless
matmarex merged T173158: Timeless: Watchlist/RC legend looks weird into T173151: Watchlist legend alignment is weird.
Sat, Aug 12, 2:41 AM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Patch-For-Review, Timeless
matmarex merged task T173158: Timeless: Watchlist/RC legend looks weird into T173151: Watchlist legend alignment is weird.
Sat, Aug 12, 2:41 AM · Timeless

Fri, Aug 11

matmarex added a project to T173089: Watchlisting confirmation dialog interrupts editing: VisualEditor-MediaWiki-2017WikitextEditor.
Fri, Aug 11, 10:52 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-Page-editing, MediaWiki-Watchlist
matmarex added a comment to T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.

Also documented at https://www.mediawiki.org/wiki/Manual:Skinning_Part_2#Screenshots

Fri, Aug 11, 9:00 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex closed T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI as Resolved.
Fri, Aug 11, 8:50 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex closed T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI, a subtask of T161154: Include information on skins/extensions in installer when installing them, as Resolved.
Fri, Aug 11, 8:50 PM · MediaWiki-Installer
matmarex added a comment to T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.

With these patches merged, 24 skins out of 42 in our version control have screenshots.

Fri, Aug 11, 8:17 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex committed rSEXAMPLE84c65c899747: Add skin screenshot for the installer (authored by matmarex).
Add skin screenshot for the installer
Fri, Aug 11, 7:45 PM
matmarex closed T165816: jQuery Mobile compatibility with jQuery 3 as Resolved.
Fri, Aug 11, 6:45 PM · Timeless
matmarex closed T165816: jQuery Mobile compatibility with jQuery 3, a subtask of T154371: Review and deploy Timeless skin, as Resolved.
Fri, Aug 11, 6:45 PM · Patch-For-Review, User-notice, Wikimedia-Extension-setup, Community-consensus-needed, Timeless
matmarex renamed T165816: jQuery Mobile compatibility with jQuery 3 from Upgrade jQuery Mobile to 1.5 (jQuery 3 compatibility) to jQuery Mobile compatibility with jQuery 3.
Fri, Aug 11, 6:45 PM · Timeless
matmarex renamed T173057: Hide mw-revision-nav on old revisions in print mode from Hide mw-revision-nav on old revisions to Hide mw-revision-nav on old revisions in print mode.
Fri, Aug 11, 6:34 PM · MediaWiki-History-or-Diffs
matmarex claimed T165816: jQuery Mobile compatibility with jQuery 3.

http://blog.jquerymobile.com/2017/05/11/jquery-mobile-1-5-0-alpha-1-released/

Fri, Aug 11, 6:04 PM · Timeless
matmarex closed T161586: Compact language links' ULS panel shows itself on the right side of the "More" button, which is wrong in some skins as Resolved.

\o/

Fri, Aug 11, 6:02 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Design, ULS-CompactLinks, MediaWiki-extensions-UniversalLanguageSelector, Timeless
matmarex closed T161586: Compact language links' ULS panel shows itself on the right side of the "More" button, which is wrong in some skins, a subtask of T154371: Review and deploy Timeless skin, as Resolved.
Fri, Aug 11, 6:02 PM · Patch-For-Review, User-notice, Wikimedia-Extension-setup, Community-consensus-needed, Timeless
matmarex added a comment to T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.
MinervaNeue
Fri, Aug 11, 5:54 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex added a comment to T173116: Research fictional and non fictional goats.

The most famous one from Poland! https://en.wikipedia.org/wiki/Koziołek_Matołek

Fri, Aug 11, 5:29 PM · Wikimania-Hackathon-2017, Goatification
matmarex closed T134423: Deprecate nonstandard behavior of self-closed HTML tags in wikitext. as Resolved.

Yes, MediaWiki's parsing is different from normal HTML parsing, but the very point of this task was to bring them closer for consistency. This has been accomplished therefore this task is resolved. If you disagree with the premise then I'm afraid you're the only one.

Fri, Aug 11, 4:26 PM · Patch-For-Review, Chinese-Sites, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), User-notice, Parsoid, MediaWiki-Parser
matmarex closed T134423: Deprecate nonstandard behavior of self-closed HTML tags in wikitext., a subtask of T89331: Replace Tidy in MW parser with HTML 5 parse/reserialize, as Resolved.
Fri, Aug 11, 4:26 PM · Services (watching), User-notice, Tidy, RfC, Parsing-Team, TechCom-RfC, Parsoid
matmarex added a comment to T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.

I tried to include it, but it's shown me some error message so I skipped it. Maybe I'll look at it again later and try to actually read what the error says. I don't think it's a major problem if it's inconsistent; I won't be taking screenshots of all skins forever so they will soon enough become inconsistent anyway.

Fri, Aug 11, 3:45 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex added a comment to T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.

Here are 24 screenshots for all the skins in our version control that I could effortlessly get to work and that did not have obvious huge rendering issues. They're at 1280x800px.

Fri, Aug 11, 3:31 AM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex created P5878 (An Untitled Masterwork).
Fri, Aug 11, 3:24 AM

Thu, Aug 10

matmarex added a comment to T161586: Compact language links' ULS panel shows itself on the right side of the "More" button, which is wrong in some skins.

I've taken screenshots of hopefully every possible state of the popout in Timeless with the latest version of the patch. They look fine. (They look fine in RTL too but I've had enough of taking screenshots.)

Thu, Aug 10, 11:03 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Design, ULS-CompactLinks, MediaWiki-extensions-UniversalLanguageSelector, Timeless
matmarex added a comment to T134423: Deprecate nonstandard behavior of self-closed HTML tags in wikitext..

I am sorry but you're wrong. Here's a simple test file you can use to verify that <b/> is parsed as an opening tag. It is so in modern browsers, and it has always been (I tested with Firefox 3.6, I don't have older browsers readily available.)

Thu, Aug 10, 9:50 PM · Patch-For-Review, Chinese-Sites, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), User-notice, Parsoid, MediaWiki-Parser
matmarex added a comment to T134423: Deprecate nonstandard behavior of self-closed HTML tags in wikitext..

I am having trouble distilling meaning from this long comment, but I think you're wrong on at least one point. <elementname/> has only been equivalent to <elementname></elementname> in XHTML; in HTML, <elementname/> means the same as <elementname> (it's just an opening tag and the "stray" slash is ignored). As some tags like <br> do not require a closing tag, this is not a problem for them, but for tags that require contents it is.

Thu, Aug 10, 8:31 PM · Patch-For-Review, Chinese-Sites, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), User-notice, Parsoid, MediaWiki-Parser
matmarex removed projects from T70331: Make it possible to render the installer with any skin, or preview skins in the installer: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Patch-For-Review.

We actually have a separaete task T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI for screenshots, let's continue there.

Thu, Aug 10, 7:56 PM · MediaWiki-Installer
matmarex updated subscribers of T68295: Come up with a sane way of including screenshots with skins and displaying them in the UI.

Change https://gerrit.wikimedia.org/r/371080 (fd8d75c1fd26e9ca0976111f1b3861935a53f84b) makes this possible. I guess we should take a bunch of screenshots and include them now? :o

Thu, Aug 10, 7:55 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MediaWiki-Interface
matmarex added a comment to T143623: PHP code documentation comments inconsistently use int/number and bool/boolean for types of parameters and return values.

https://gerrit.wikimedia.org/r/#/c/371107/ changes some of those, but not all.

Thu, Aug 10, 6:56 PM · OOjs-UI
matmarex closed T96516: Add a field to Special:Diff as Resolved.

This has now been done as part of T47221.

Thu, Aug 10, 6:54 PM · MediaWiki-History-or-Diffs, MediaWiki-Special-pages
matmarex closed T47221: Document Special:PermanentLink and Special:Diff in the interface as Resolved.

https://gerrit.wikimedia.org/r/#/c/129095/ is merged! Better late than never.

Thu, Aug 10, 6:54 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Documentation, Patch-For-Review, Easy, MediaWiki-Special-pages
matmarex added a comment to T172643: "Editor won't start: 500 (Internal Server Error)" due to calling mime_content_type() without fallback to 'fileinfo'.

Documented here too: https://www.mediawiki.org/w/index.php?title=PHP_configuration&diff=2534528&oldid=2534527

Thu, Aug 10, 6:34 PM · MediaWiki-Installer, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14))
matmarex added a comment to T172643: "Editor won't start: 500 (Internal Server Error)" due to calling mime_content_type() without fallback to 'fileinfo'.

If this turns out to be a widespread issue, it is probably possible to implement a workaround, but for now yours is the only report of this problem.

Thu, Aug 10, 5:58 PM · MediaWiki-Installer, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14))
matmarex added a comment to T172643: "Editor won't start: 500 (Internal Server Error)" due to calling mime_content_type() without fallback to 'fileinfo'.

Yes, that's what that patch is supposed to do. This means you're missing the 'fileinfo' PHP extension – you somehow disabled it. MediaWiki requires it for correct operation. (Sorry, this was previously not properly documented – no one noticed, so apparently most normal installations include it.) Please get it enabled and see if that helps.

Thu, Aug 10, 5:54 PM · MediaWiki-Installer, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14))
matmarex added a comment to T47221: Document Special:PermanentLink and Special:Diff in the interface.

I rebased the patch. I had to rewrite it a little bit, since this code apparently changed a lot in the meantime.

Thu, Aug 10, 5:06 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Documentation, Patch-For-Review, Easy, MediaWiki-Special-pages

Wed, Aug 9

matmarex added a comment to T169112: Define requirements for incorporating OOUI with a reactive JS framework for the Wikipedia Mobile site.

Feel free to add me back to this task when my input is needed.

Wed, Aug 9, 11:01 PM · Readers-Web-Backlog (Tracking), Marvin, Front-end-Standards-Group, OOjs-UI, Reading Epics (Mobile Web SSR and Connection Management)
matmarex added a subtask for T172250: Reconsider the blue border for buttons themed like links on focus/click: T172578: Investigate and consider keyboard-only focus for OOUI widgets.
Wed, Aug 9, 10:52 PM · OOjs-UI
matmarex added a parent task for T172578: Investigate and consider keyboard-only focus for OOUI widgets: T172250: Reconsider the blue border for buttons themed like links on focus/click.
Wed, Aug 9, 10:52 PM · Design, OOjs-UI
matmarex renamed T172250: Reconsider the blue border for buttons themed like links on focus/click from Reconsider the blue border for buttons themed like links to Reconsider the blue border for buttons themed like links on focus/click.
Wed, Aug 9, 10:52 PM · OOjs-UI
matmarex created T172952: Link to existing page in Flow board description is shown as red.
Wed, Aug 9, 9:08 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Regression, Flow
matmarex closed T171156: Live preview does not show the preview of the summary anymore as Resolved.
Wed, Aug 9, 8:49 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Wikimania-Hackathon-2017, MediaWiki-Page-editing, Regression
matmarex closed T171156: Live preview does not show the preview of the summary anymore, a subtask of T162849: Support WMF communities in run-up to switching EditPage over to OOUI, as Resolved.
Wed, Aug 9, 8:49 PM · Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor
matmarex closed T171156: Live preview does not show the preview of the summary anymore, a subtask of T41272: Bugs in "Live preview" feature (tracking), as Resolved.
Wed, Aug 9, 8:49 PM · WikiEditor, JavaScript, MediaWiki-Page-editing, Tracking
matmarex added a parent task for T151269: Add English names for languages which don't yet have one: T172222: Many languages names in UploadWizard display in their native script (autonyms) rather than English.
Wed, Aug 9, 8:34 PM · Chinese-Sites, Language-Team, MediaWiki-extensions-CLDR, I18n, Wikidata
matmarex added a subtask for T172222: Many languages names in UploadWizard display in their native script (autonyms) rather than English: T151269: Add English names for languages which don't yet have one.
Wed, Aug 9, 8:34 PM · I18n, MediaWiki-extensions-CLDR, UploadWizard, Multimedia