matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (216 w, 5 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Today

matmarex moved T211156: Review EditAttemptStep validation failures in production from Ready for Pick Up to Engineering QA on the VisualEditor (Current work) board.

QA here would presumably involve waiting for the patch to be deployed, then verifying that the validation failures stopped.

Thu, Dec 13, 2:47 AM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Contributors-Analysis, Product-Analytics
matmarex edited projects for T211156: Review EditAttemptStep validation failures in production, added: VisualEditor (Current work); removed VisualEditor.
Thu, Dec 13, 2:46 AM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Contributors-Analysis, Product-Analytics
matmarex moved T210547: [Regression wmf.4] Old content shows up for a brief second after opening VE for an article from In progress to QA on the VisualEditor (Current work) board.

I believe this was caused by the same problem as T209542. I noticed this behavior when debugging that issue and described it:

Thu, Dec 13, 2:24 AM · VisualEditor (Current work)
matmarex added a comment to T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it.

@Der_Keks I'm not really sure what your suggestion is. You suggest a "Convert" button, but as we found out there already is one, which doesn't appear for this particular reference, because we can't detect that it is convertible. Can you clarify?

Thu, Dec 13, 2:15 AM · VisualEditor-MediaWiki-References, VisualEditor
matmarex moved T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it from To Triage to Up next on the VisualEditor board.
Thu, Dec 13, 2:13 AM · VisualEditor-MediaWiki-References, VisualEditor
matmarex renamed T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it from VE has problems with editing <ref name="XYZ" /> link to Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it.
Thu, Dec 13, 2:13 AM · VisualEditor-MediaWiki-References, VisualEditor
matmarex added a comment to T211518: Make removal of image in Visual Editor possible.

Actually, that was not a trivial task at all when the image doesn't exist and there's overlap with the new paragraph (and it's unclear where the cursor should go to put it after the image to backspace it).

Thu, Dec 13, 2:09 AM · VisualEditor
matmarex moved T211844: Block slugs can overlap floated templates/images/etc. from To Triage to Up next on the VisualEditor board.

At a glance, this could be fixed by setting overflow: hidden; on the slug (or another property that creates a block formatting context). But we probably need to think carefully whether this can cause any issues.

Thu, Dec 13, 2:08 AM · VisualEditor
matmarex created T211844: Block slugs can overlap floated templates/images/etc..
Thu, Dec 13, 2:02 AM · VisualEditor
matmarex added a comment to T209554: Cursor moves to the beginning/end of a table when clicking to the left/right of it.

@Kerry_Raymond Thanks for the report. I added a video of the bug to make it easier to understand.

Thu, Dec 13, 1:52 AM · VisualEditor
matmarex renamed T209554: Cursor moves to the beginning/end of a table when clicking to the left/right of it from Screen focus changes when working with a table to Cursor moves to the beginning/end of a table when clicking to the left/right of it.
Thu, Dec 13, 1:47 AM · VisualEditor
matmarex added a project to T211834: "Insert row" adding as a header row for certain tables: goodfirstbug.

Inserting a row always uses the same table cell style (data/header) as the first cell of the previous/next row (depending on whether you insert the row below or above). Probably it could look up the cell style for each cell individually.

Thu, Dec 13, 1:40 AM · Patch-For-Review, goodfirstbug, VisualEditor, VisualEditor-Tables
matmarex added a comment to T210798: BUG: VE freezing when editing table.

It should be fixed on Wikipedia tomorrow after the new version of MediaWiki is deployed.

Thu, Dec 13, 1:39 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor-Tables, VisualEditor (Current work)

Yesterday

matmarex closed T211767: Visual editor doesn't escape greater-than in template parameters as Invalid.

Thanks for the bug report!

Wed, Dec 12, 8:44 PM · VisualEditor
matmarex created T211816: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules).
Wed, Dec 12, 8:41 PM · Parsoid, MediaWiki-Parser
matmarex removed a project from T52355: VisualEditor: Add support for editing templates' parameters as DOM elements ("visually"), including supporting nested templates: Patch-For-Review.
Wed, Dec 12, 8:34 PM · VisualEditor, VisualEditor-EditingTools
matmarex added a parent task for T52355: VisualEditor: Add support for editing templates' parameters as DOM elements ("visually"), including supporting nested templates: T52182: VisualEditor: Add support for making some templates directly "visually editable" in the DOM, as if they were tables (e.g. infoboxes).
Wed, Dec 12, 8:32 PM · VisualEditor, VisualEditor-EditingTools
matmarex added a subtask for T52182: VisualEditor: Add support for making some templates directly "visually editable" in the DOM, as if they were tables (e.g. infoboxes): T52355: VisualEditor: Add support for editing templates' parameters as DOM elements ("visually"), including supporting nested templates.
Wed, Dec 12, 8:32 PM · VisualEditor, VisualEditor-EditingTools
matmarex closed T28441: quoted and unquoted attributes are not handled the same in Sanitizer.php as Resolved.

In the given example page (https://test.wikipedia.org/wiki/MW_ATTRIBS_REGEX), quoted and unquoted examples are now parsed identically.

Wed, Dec 12, 7:53 PM · MediaWiki-Parser
matmarex added a comment to T211379: Let me visit a red-linked page without opening the editor.

(We discussed this in the planning meeting today.)

Wed, Dec 12, 7:25 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
matmarex renamed T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome) from Backspace across paragraphs is broken on mobile VE to Backspace across paragraphs is broken on mobile VE (Android Chrome).
Wed, Dec 12, 5:43 PM · Browser-Support-Android-Google-Chrome, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex closed T94103: When a table needs to wrap up input text, typing white spaces entered in front of the text make a cursor go forward and back as Resolved.

I can't reproduce this today. I think this was caused by VE using &nbsp; when there were multiple spaces next to each other, and thus has been resolved by the patch for T55931: VisualEditor: Move to using white-space: pre-wrap instead of using nbsp's to fake spaces.

Wed, Dec 12, 3:41 PM · User-Ryasmeen, VisualEditor-Tables, VisualEditor
matmarex closed T89614: Template-generated table cells in the table at https://en.wikipedia.org/wiki/Skyfall#Accolades do not have the blue shields/highlights/whatever applied as Resolved.

This seems to work fine these days. Clicking that cell marks it with the striped background also used for alien nodes. It might have been fixed as part of T85648.

Wed, Dec 12, 3:35 PM · User-Ryasmeen, VisualEditor-Tables, VisualEditor, VisualEditor-MediaWiki
matmarex closed T89614: Template-generated table cells in the table at https://en.wikipedia.org/wiki/Skyfall#Accolades do not have the blue shields/highlights/whatever applied, a subtask of T85462: Support the editing of "tables" that are composed of templates, as Resolved.
Wed, Dec 12, 3:35 PM · VisualEditor-MediaWiki-Templates, VisualEditor, VisualEditor-Tables
marcella awarded T189148: "donut-container" <div> added in every <ref> a Cup of Joe token.
Wed, Dec 12, 2:33 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki
matmarex moved T211698: 'trackdebug' mode doesn't work unless debug mode is enabled from Code review to Engineering QA on the VisualEditor (Current work) board.
Wed, Dec 12, 1:04 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), Patch-For-Review, Technical-Debt

Tue, Dec 11

matmarex moved T205564: External text with CRLF line endings breaks text processing in NWE from QA to Engineering QA on the VisualEditor (Current work) board.
Tue, Dec 11, 11:48 PM · Editing QA, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T209619: Broken "HON" browser plug-in causes content corruption when editing from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Tue, Dec 11, 11:47 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T209619: Broken "HON" browser plug-in causes content corruption when editing from QA to Engineering QA on the VisualEditor (Current work) board.
Tue, Dec 11, 11:47 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T209648: Changing text in a TargetWidget does not enable dialog's "Apply" button (in media, gallery, reference dialog) until second keypress from Code review to QA on the VisualEditor (Current work) board.
Tue, Dec 11, 11:28 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), VisualEditor (Current work), Patch-For-Review, VisualEditor-EditingTools
matmarex added a comment to T210555: Inconsistent scrolling behavior observed for Gallery dialog on Mobile.

(If T208644 is fixed, it will likely affect this dialog)

Tue, Dec 11, 10:00 PM · VisualEditor-MediaWiki, VisualEditor
matmarex closed T189148: "donut-container" <div> added in every <ref> as Resolved.

The patch was deployed to all projects and the problem shouldn't occur for any new edits. You can find existing affected pages using the wiki search feature, for example: https://ru.wikipedia.org/w/index.php?search=insource%3Adonut-container&profile=all

Tue, Dec 11, 9:34 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki
matmarex closed T189148: "donut-container" <div> added in every <ref>, a subtask of T54327: Broken browser plugins cause cruft to be injected into the page (tracking), as Resolved.
Tue, Dec 11, 9:34 PM · Tracking, VisualEditor-DataModel, VisualEditor, VisualEditor-MediaWiki
matmarex moved T210559: Can't scroll the viewport while typing in the caption field in Gallery>Images on mobile from Code review to QA on the VisualEditor (Current work) board.
Tue, Dec 11, 8:24 PM · Verified, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex edited projects for T210559: Can't scroll the viewport while typing in the caption field in Gallery>Images on mobile, added: VisualEditor (Current work), VisualEditor-MediaWiki; removed VisualEditor.

I can reproduce this. I think it's actually more serious that it looked like – it seems what whenever the keyboard is used while any VE dialog is open, the viewport is continually scrolled to the top. This makes it nearly impossible to type in fields in the "bottom half" of dialogs, such as the gallery image caption field, but also affects e.g. fields in the options tab of gallery dialog, and other dialogs like the maps dialog.

Tue, Dec 11, 10:59 AM · Verified, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a project to T210555: Inconsistent scrolling behavior observed for Gallery dialog on Mobile: VisualEditor-MediaWiki.

I could reproduce it a few times, but every time I was able to make it fix itself by just waiting a few seconds (until the scrollbar disappeared) before trying to scroll again. So this seems low priority.

Tue, Dec 11, 10:59 AM · VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

Using any heuristic other than the one used by existing MediaWiki PHP code is incorrect. That heuristic is well-defined (using a specific encoding based on wiki content language) and I described on T106244 how it should be implemented in JavaScript. I feel weird having to link that task for the third time with no one acknowledging this.

Tue, Dec 11, 9:38 AM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search
matmarex closed T201723: List of permissions should not be shown for non-existent global groups as Resolved.
Tue, Dec 11, 7:28 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Stewards-and-global-tools, Patch-For-Review, MediaWiki-extensions-CentralAuth, goodfirstbug
matmarex added a comment to T189148: "donut-container" <div> added in every <ref>.

@MaxBioHazard Thank you for noticing. I found that this has been broken by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/473809.

Tue, Dec 11, 12:10 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), VisualEditor (Current work), VisualEditor-ContentEditable, VisualEditor-MediaWiki

Mon, Dec 10

matmarex closed T204411: Introduce HTMLGlobalUserTextField::class for global users as Resolved.

Thanks!

Mon, Dec 10, 11:53 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, MediaWiki-HTMLForm, User-Jayprakash12345, OOUI
matmarex closed T204411: Introduce HTMLGlobalUserTextField::class for global users, a subtask of T117884: Convert Special:UserRights to OOUI, as Resolved.
Mon, Dec 10, 11:53 PM · Patch-For-Review, MediaWiki-User-management, UI-Standardization
matmarex closed T204411: Introduce HTMLGlobalUserTextField::class for global users, a subtask of T122016: Convert Special:CentralAuth to use OOUI, as Resolved.
Mon, Dec 10, 11:52 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Stewards-and-global-tools, MediaWiki-extensions-CentralAuth, UI-Standardization
matmarex added a comment to T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

Short answer: It's impossible to "guess" the "right 8-but character encoding". It would be wrong to assume anything.

Mon, Dec 10, 9:28 PM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search
matmarex reopened T33780: WikiEditor dialogs kill the undo buffer as "Open".

Reverted in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/478734 due to concerns about compatibility with alternative editors that override the 'textSelection' API. This should be relatively easy to fix (see comments on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/474520), but somewhat time-consuming to verify that everything works correctly. Extensions to test: CodeEditor, CodeMirror, ProofreadPage, VisualEditor (NWE).

Mon, Dec 10, 6:40 PM · User-TheDJ, Patch-For-Review, User-Ryasmeen, Browser-Support-Internet-Explorer, Browser-Support-Google-Chrome, Upstream, WikiEditor

Fri, Dec 7

matmarex added a comment to T211157: Allow VE plugins to handle save errors generated by extensions.

QA notes: try to make an edit that will fail to save because of an error generated by ConfirmEdit (CAPTCHA) / SpamBlacklist / TitleBlacklist / AbuseFilter; make sure the error is shown correctly (as before).

Fri, Dec 7, 7:38 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T141676: Move ConfirmEdit-related code out of VisualEditor-MediaWiki and into the ConfirmEdit extension.

(Let's do Editing team QA/product review on T211157, these are all related.)

Fri, Dec 7, 7:36 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Technical-Debt, ConfirmEdit (CAPTCHA extension), VisualEditor-MediaWiki, VisualEditor
matmarex closed T141676: Move ConfirmEdit-related code out of VisualEditor-MediaWiki and into the ConfirmEdit extension as Resolved.
Fri, Dec 7, 7:36 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Technical-Debt, ConfirmEdit (CAPTCHA extension), VisualEditor-MediaWiki, VisualEditor
matmarex closed T136859: Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs as Resolved.

(Let's do Editing team QA/product review on T211157, these are all related.)

Fri, Dec 7, 7:36 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), ConfirmEdit (CAPTCHA extension), VisualEditor-MediaWiki, VisualEditor
matmarex closed T136859: Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs, a subtask of T141676: Move ConfirmEdit-related code out of VisualEditor-MediaWiki and into the ConfirmEdit extension, as Resolved.
Fri, Dec 7, 7:36 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Technical-Debt, ConfirmEdit (CAPTCHA extension), VisualEditor-MediaWiki, VisualEditor
matmarex closed T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist as Resolved.

(Let's do Editing team QA/product review on T211157, these are all related.)

Fri, Dec 7, 7:35 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-Ryasmeen, VisualEditor, TitleBlacklist, VisualEditor-MediaWiki
matmarex added a comment to T211426: The edited amount/content were not consistent with the revision history .

Looks like that edit was made using an old revision of the page as the base. Effectively, you undid all of the changes by other users made to that page in the past few weeks.

Fri, Dec 7, 7:33 PM · MediaWiki-Page-editing
matmarex moved T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Fri, Dec 7, 6:56 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-Ryasmeen, VisualEditor, TitleBlacklist, VisualEditor-MediaWiki
matmarex edited projects for T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist , added: VisualEditor (Current work); removed Patch-For-Review, VisualEditor.
Fri, Dec 7, 6:56 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-Ryasmeen, VisualEditor, TitleBlacklist, VisualEditor-MediaWiki
matmarex created T211443: Remove SpamBlacklist error handling from ApiVisualEditorEdit.php.
Fri, Dec 7, 6:53 PM · VisualEditor, Technical-Debt, VisualEditor-MediaWiki

Thu, Dec 6

matmarex moved T209911: Page options dialog (meta dialog) is unavailable in mobile VE from Design review to In progress on the VisualEditor (Current work) board.
Thu, Dec 6, 2:06 AM · VisualEditor, VisualEditor-MediaWiki

Wed, Dec 5

matmarex updated the task description for T211241: Distinguish AbuseFilter warnings and errors in VE.
Wed, Dec 5, 9:49 PM · VisualEditor, AbuseFilter, VisualEditor-MediaWiki
matmarex moved T211157: Allow VE plugins to handle save errors generated by extensions from Code review to QA on the VisualEditor (Current work) board.

I like it.

Wed, Dec 5, 9:39 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex triaged T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist as Low priority.
Wed, Dec 5, 9:39 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-Ryasmeen, VisualEditor, TitleBlacklist, VisualEditor-MediaWiki
matmarex triaged T211241: Distinguish AbuseFilter warnings and errors in VE as Low priority.
Wed, Dec 5, 9:38 PM · VisualEditor, AbuseFilter, VisualEditor-MediaWiki
matmarex created T211242: Move TitleBlacklist error handling code from VE to TitleBlacklist .
Wed, Dec 5, 9:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-Ryasmeen, VisualEditor, TitleBlacklist, VisualEditor-MediaWiki
matmarex created T211241: Distinguish AbuseFilter warnings and errors in VE.
Wed, Dec 5, 9:37 PM · VisualEditor, AbuseFilter, VisualEditor-MediaWiki
matmarex added a project to T210670: Regression: UI broken in search overlay, image, VE and language overlays: MobileFrontend.
Wed, Dec 5, 8:59 PM · MobileFrontend, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
matmarex added a comment to T194524: Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text.

The text feels very unexpected and unlike what placeholders should be like. I would expect the placeholder text to be something like "±HH:MM". I think the text you proposed would work better as a help label:

Wed, Dec 5, 6:30 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), UI-Standardization, MediaWiki-User-preferences
matmarex claimed T210798: BUG: VE freezing when editing table.
Wed, Dec 5, 5:12 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor-Tables, VisualEditor (Current work)

Tue, Dec 4

matmarex assigned T211157: Allow VE plugins to handle save errors generated by extensions to Esanders.
Tue, Dec 4, 11:21 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex moved T211157: Allow VE plugins to handle save errors generated by extensions from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Tue, Dec 4, 11:18 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T211157: Allow VE plugins to handle save errors generated by extensions.

Relevant patches, chronologically:
(patches in each row were dependent on each other and merged at the same time)

Tue, Dec 4, 11:14 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a project to T211157: Allow VE plugins to handle save errors generated by extensions: Technical-Debt.

I think the work on this was triggered by a third-party patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/474619 "Support recaptcha for visual editor" – while we were kind of unhappy about having code to handle the CAPTCHA used on Wikimedia wikis in VE, also adding the code to support Google's reCAPTCHA was completely out of the question (on Wikimedia wikis, we don't want to load code that calls out to other sites, even if we don't use it, since that would make it too easy to accidentally enable it and violate our privacy policy). So Ed worked on the framework to allow that code to be written in the extension rather than in VE.

Tue, Dec 4, 11:08 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a parent task for T211157: Allow VE plugins to handle save errors generated by extensions: T136859: Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs.
Tue, Dec 4, 11:05 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a subtask for T136859: Provide a system in VisualEditor-MediaWiki to properly integrate CAPTCHAs: T211157: Allow VE plugins to handle save errors generated by extensions.
Tue, Dec 4, 11:05 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), ConfirmEdit (CAPTCHA extension), VisualEditor-MediaWiki, VisualEditor
matmarex created T211157: Allow VE plugins to handle save errors generated by extensions.
Tue, Dec 4, 11:03 PM · Editing QA, Technical-Debt, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T153681: Autolinking to edited section does not work with certain chars.

OK, so to rephrase: when viewing https://no.wikipedia.org/w/index.php?title=Bruker:Jeblad/testing-dfgpiogj&action=edit&section=3 (editing a section titled "Baz <pogo>"), the pre-filled edit summary is /* Baz */ , but it should instead be /* Baz <pogo> */ .

Tue, Dec 4, 8:25 PM · MediaWiki-Page-editing
matmarex closed T211122: FOUC on Special:Preferences when MediaWiki:Preferences-summary is set as Resolved.
Tue, Dec 4, 5:55 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-User-preferences
matmarex merged T180955: Screenful occupied by email prevention textbox in Special:Preferences into T194525: Special:Preferences: Reduce the size of the <textarea>s shown for UsersMultiselectWidget when in non-JS mode.
Tue, Dec 4, 5:52 PM · MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), UI-Standardization, MediaWiki-User-preferences
matmarex merged task T180955: Screenful occupied by email prevention textbox in Special:Preferences into T194525: Special:Preferences: Reduce the size of the <textarea>s shown for UsersMultiselectWidget when in non-JS mode.
Tue, Dec 4, 5:52 PM · Anti-Harassment, MediaWiki-User-preferences
matmarex added a comment to T180955: Screenful occupied by email prevention textbox in Special:Preferences.

This has been fixed in rMWe9d7882e924d: UsersMultiselectWidget: Reduce default non-JS rows to 10.

Tue, Dec 4, 5:52 PM · Anti-Harassment, MediaWiki-User-preferences
matmarex closed T181864: Re-write the Beta Features preferences code to use OOUI, not re-implement bits of it with MWUI as Resolved.
Tue, Dec 4, 5:47 PM · UI-Standardization, MediaWiki-User-preferences, BetaFeatures
matmarex claimed T181864: Re-write the Beta Features preferences code to use OOUI, not re-implement bits of it with MWUI.

Not sure what this task is supposed to cover, but I think it has been mostly done with rEBET14379dd886f6: NewHTMLCheckField: Use pretty field for OOUIHTMLForm too as part of the work on T117781. There are some CSS classes that are prefixed with mw-ui-, but they are all custom and the prefix is harmless, we are not loading any of normal MW UI styles.

Tue, Dec 4, 5:46 PM · UI-Standardization, MediaWiki-User-preferences, BetaFeatures
matmarex moved T210889: VE/NWE is failing to load on Beta cluster from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Tue, Dec 4, 4:26 AM · Editing QA, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex edited projects for T210889: VE/NWE is failing to load on Beta cluster , added: VisualEditor (Current work), VisualEditor-MediaWiki; removed VisualEditor.
Tue, Dec 4, 4:26 AM · Editing QA, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T210914: Valid input in TagMultiselectWidget flagged as invalid on Special:ApiSandbox.

It's not just invalid, it's a weird semi-valid semi-invalid border. It should never be half red, half blue.

Tue, Dec 4, 4:24 AM · Patch-For-Review, OOUI
matmarex added a comment to T210684: Advanced search stuck showing three dots: "defaultUri is undefined" (Swedish wikis).

T106244 is the same issue from a different perspective.

Tue, Dec 4, 3:59 AM · WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, TCB-Team, Advanced-Search

Mon, Dec 3

matmarex added a comment to T210798: BUG: VE freezing when editing table.

So, precise steps to reproduce is:

  • Place a text cursor (or linear selection) inside a table cell (e.g. double-click it)
  • Click on another table cell while holding Shift
Mon, Dec 3, 5:48 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor-Tables, VisualEditor (Current work)

Sat, Dec 1

matmarex added a comment to T210889: VE/NWE is failing to load on Beta cluster .

May have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/476588, which was accidentally merged before its dependency (now fixed), or some related patch? Folks have been moving around a lot of code.

Sat, Dec 1, 7:08 PM · Editing QA, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T210889: VE/NWE is failing to load on Beta cluster .

Works for me right now… This error would usually indicate a missing dependency.

Sat, Dec 1, 7:05 PM · Editing QA, VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a comment to T210851: Spacing between diff and pipe separator is double what it should be in Special:Contributions.

An override for this message exists on these projects:

Sat, Dec 1, 6:37 PM · Accessibility, MediaWiki-Special-pages, MediaWiki-Watchlist, Growth-Team, MediaWiki-Recent-changes, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson
matmarex updated the task description for T210851: Spacing between diff and pipe separator is double what it should be in Special:Contributions.
Sat, Dec 1, 6:26 PM · Accessibility, MediaWiki-Special-pages, MediaWiki-Watchlist, Growth-Team, MediaWiki-Recent-changes, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson
matmarex moved T208914: Change recovery fails when the change inserted a reference from Code review to QA on the VisualEditor (Current work) board.
Sat, Dec 1, 6:20 PM · Editing QA, Cite, VisualEditor-MediaWiki-References, Patch-For-Review, VisualEditor (Current work)

Fri, Nov 30

matmarex added a comment to T210851: Spacing between diff and pipe separator is double what it should be in Special:Contributions.

Here we go: https://en.wikipedia.org/wiki/MediaWiki:Pipe-separator?action=edit

Fri, Nov 30, 4:19 PM · Accessibility, MediaWiki-Special-pages, MediaWiki-Watchlist, Growth-Team, MediaWiki-Recent-changes, Front-end-Standards-Group, UI-Standardization, User-Jdlrobson
matmarex closed T210734: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getParentRegion() must be an instance of ParserOutput, bool given as Resolved.
Fri, Nov 30, 12:34 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Editing-team, GeoCrumbs, Wikimedia-production-error
matmarex moved T210798: BUG: VE freezing when editing table from To Triage to Current work on the VisualEditor board.
Fri, Nov 30, 12:30 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor-Tables, VisualEditor (Current work)
matmarex added a comment to T210798: BUG: VE freezing when editing table.

Thanks, I can reproduce now!

Fri, Nov 30, 12:30 AM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor-Tables, VisualEditor (Current work)
matmarex closed T210811: OOUI being loaded unconditionally on mobile site resulting in 50kb more bytes shipped as Invalid.

And this issue is already known: T159738.

Fri, Nov 30, 12:20 AM · Performance-Team, MinervaNeue, Readers-Web-Backlog, Performance
matmarex edited projects for T210811: OOUI being loaded unconditionally on mobile site resulting in 50kb more bytes shipped, added: QuickSurveys; removed OOUI.

The module is not loaded on all pages – it is not loaded on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page, for example. (Check in browser console with mw.loader.getState('oojs-ui-core'), it return "registered" rather than "ready".)

Fri, Nov 30, 12:19 AM · Performance-Team, MinervaNeue, Readers-Web-Backlog, Performance

Thu, Nov 29

matmarex added a comment to T210675: Center aligned map does not really look center aligned on mobile VE.

After:

Thu, Nov 29, 11:57 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, Maps (Kartographer)
matmarex edited projects for T210675: Center aligned map does not really look center aligned on mobile VE, added: Maps (Kartographer), VisualEditor-MediaWiki, VisualEditor (Current work); removed VisualEditor.
Thu, Nov 29, 11:48 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, Maps (Kartographer)
matmarex claimed T210675: Center aligned map does not really look center aligned on mobile VE.

Hmm, it looks a bit broken on desktop too.

Thu, Nov 29, 11:48 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki, Maps (Kartographer)
matmarex moved T210796: The citation (with template) dialog's Apply changes action is always enabled from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Thu, Nov 29, 10:40 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-EditingTools, VisualEditor-MediaWiki-References, Cite
matmarex added a comment to T210798: BUG: VE freezing when editing table.

The issue doesn't occur for me, using Opera 57 / Chrome 70 on Windows 10 (Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 OPR/57.0.3098.53 (Edition beta)).

Thu, Nov 29, 10:38 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), VisualEditor-Tables, VisualEditor (Current work)
matmarex added a comment to T210686: [Regression pre-wmf.8] Typing in any fields for Cite>Web/Book etc. disables the "Insert" field.

ve.ui.MWCitationDialog has a bunch of weird code calling this.actions.setAbilities() (added in rEVEDda5398909e3b: Don't allow inserting blank citations), which seems to conflict with ve.ui.MWTemplateDialog's setApplicableStatus() calling the same method.

At a glance, I suspect we can remove all of that, and instead override setApplicableStatus() to not allow inserting blank citations.

Thu, Nov 29, 10:00 PM · VisualEditor-MediaWiki-References, Cite, VisualEditor (Current work), Verified, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11)