matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (188 w, 22 h)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Yesterday

matmarex updated subscribers of T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken on Beta.

Your screenshots look as if the styles for the 'oojs-ui-widgets' module were not loaded. All of the visually broken widgets belong to that module (TabSelectWidget, ButtonSelectWidget, OutlineSelectWidget).

Fri, May 25, 8:15 PM · VisualEditor (Current work)
matmarex added a comment to T193718: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php.

"Illegal string offset" means that $revArr (which should be an array) is actually a string, which means (at least) one of the values of $result['query']['pages'][$pid]['revisions'] is a string.

The API request is something like https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&prop=revisions&format=json&rvprop=timestamp|user|parsedcomment|ids&rvlimit=25&pageids=7776&format=jsonfm – and briefly looking at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/REL1_31/includes/api/ApiQueryRevisions.php I can't see how it would output a string there.

Fri, May 25, 6:45 PM · VisualEditor-MediaWiki, Patch-For-Review, VisualEditor
matmarex closed T66528: Allow manual insertion of soft hyphen in display title as Resolved.

This is done for MediaWiki. The patch should be deployed to all Wikimedia wikis on Monday (wmf.5 has been delayed due to unrelated problems).

Fri, May 25, 12:19 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), MediaWiki-Parser
matmarex closed T121979: U+00AD SOFT HYPHEN shouldn't be allowed in wiki article titles as Resolved.

This is done for MediaWiki. I filed T195546: Run the maintenance script cleanupTitles.php (in dry run mode first) on all wikis after wmf.5 deployment about running cleanupTitles.php on Wikimedia wikis.

Fri, May 25, 12:18 AM · User-notice, MediaWiki-General-or-Unknown
matmarex added a subtask for T191051: 1.32.0-wmf.5 deployment blockers: T195546: Run the maintenance script cleanupTitles.php (in dry run mode first) on all wikis after wmf.5 deployment.
Fri, May 25, 12:16 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
matmarex added a parent task for T195546: Run the maintenance script cleanupTitles.php (in dry run mode first) on all wikis after wmf.5 deployment: T191051: 1.32.0-wmf.5 deployment blockers.
Fri, May 25, 12:16 AM · Wikimedia-General-or-Unknown
matmarex created T195546: Run the maintenance script cleanupTitles.php (in dry run mode first) on all wikis after wmf.5 deployment.
Fri, May 25, 12:15 AM · Wikimedia-General-or-Unknown

Thu, May 24

matmarex added a comment to T195528: Issues with the mobile editor on Wikimedia Commons.

I was assuming classic desktop wikitext editor (and testing as a logged-out user).

Thu, May 24, 11:29 PM · MediaWiki-Page-editing, MobileFrontend
matmarex added projects to T195528: Issues with the mobile editor on Wikimedia Commons: MobileFrontend, MediaWiki-Page-editing.

So, to rephrase – viewing a URL like https://commons.m.wikimedia.org/wiki/User:Matma_Rex/sandbox?action=edit redirects to https://commons.m.wikimedia.org/wiki/User:Matma_Rex/sandbox#/editor/0 instead of loading the desktop wikitext editor.

Thu, May 24, 11:12 PM · MediaWiki-Page-editing, MobileFrontend
matmarex claimed T195517: Classic toolbar (2006 wikitext editor) buttons displayed twice.
Thu, May 24, 10:55 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), VisualEditor (Current work), Security-Team, Regression, MediaWiki-Page-editing
matmarex added a comment to T195520: Multiple projects reporting Cannot access the database: No working replica DB server.

There is a separate task about the broken text: T195525: MWExceptionRenderer.php doesn't always declare the encoding used.. It already has a patch pending, so in case another issue like this occurs, at least the error message will be displayed correctly ;)

Thu, May 24, 9:12 PM · Wikidata-Ministry-Of-Magic, Wikimedia-Incident, MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Wikidata, Patch-For-Review, Wikimedia-General-or-Unknown, Wikimedia-log-errors, Operations
matmarex updated subscribers of T195514: Can't copy and paste a list on office.wiki page in the visual editor.

Minimal test case:

A
* B 
** C
* D
Thu, May 24, 9:04 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), VisualEditor (Current work), Regression, VisualEditor-CopyPaste
matmarex merged task T195529: MWExceptionRenderer.php doesn't always declare the encoding used into T195525: MWExceptionRenderer.php doesn't always declare the encoding used..
Thu, May 24, 8:30 PM · MediaWiki-General-or-Unknown
matmarex merged T195529: MWExceptionRenderer.php doesn't always declare the encoding used into T195525: MWExceptionRenderer.php doesn't always declare the encoding used..
Thu, May 24, 8:30 PM · I18n, MediaWiki-Debug-Logger
matmarex edited projects for T195525: MWExceptionRenderer.php doesn't always declare the encoding used., added: MediaWiki-General-or-Unknown; removed Wikimedia-General-or-Unknown.

(For context, this is about the error message shown during recent database issues, T195520)

Thu, May 24, 8:10 PM · I18n, MediaWiki-Debug-Logger
matmarex closed T194193: "packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport as Resolved.
Thu, May 24, 7:34 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Multimedia, MediaWiki-Gallery
matmarex closed T194193: "packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport, a subtask of T88654: Performance review 2015: mediawiki.page.gallery module, as Resolved.
Thu, May 24, 7:34 PM · Performance-Team (Radar), MediaWiki-Gallery, JavaScript, Technical-Debt, Multimedia
matmarex updated the task description for T55662: gerrit won't accept patches where only commit metadata differ.
Thu, May 24, 5:23 PM · Upstream, Gerrit
matmarex changed the status of T55662: gerrit won't accept patches where only commit metadata differ from Declined to Resolved.

I am thrilled to report that Gerrit has fixed this at some point!

Thu, May 24, 5:23 PM · Upstream, Gerrit
matmarex removed projects from T195509: Notification letters contains ugly inflated links to pages with non-latin title: Notifications, Collaboration-Team-Triage.

These look like the watchlist notification emails, so removing Notifications (a.k.a. Echo extension).

Thu, May 24, 5:02 PM · MediaWiki-Email
matmarex edited projects for T164027: Consider removing icon-add element from Transclusion dialog's options, added: VisualEditor (Current work); removed VisualEditor.
Thu, May 24, 4:38 PM · OOUI (OOUI-0.27.1), VisualEditor (Current work), VisualEditor-MediaWiki-Templates
matmarex claimed T164027: Consider removing icon-add element from Transclusion dialog's options.
Thu, May 24, 4:37 PM · OOUI (OOUI-0.27.1), VisualEditor (Current work), VisualEditor-MediaWiki-Templates
matmarex added a comment to T194667: OOUI Checkboxes missing the checkmark in Safari since v0.27.0.

For future reference: we had issues with Safari not rendering the checkmarks in the past, but we worked around them: T89309: [Regression wmf17] Safari - cannot click in any check-box. Somehow the recent changes must have triggered a similar issue again (rGOJUec032ef96417: CheckboxInputWidget: Don't specify icon in CSS).

Thu, May 24, 12:56 PM · Browser-Support-Apple-Safari, OOUI
matmarex added a comment to T194863: Clarify and align TabSelectWidget focus .

Final implementation:

Thu, May 24, 12:20 PM · OOUI (OOUI-0.27.1), Design

Tue, May 22

matmarex closed T54098: Input box for page protection expiry time strange behaviour: key up and down (Safari/Chrome) as Resolved.

This was caused by us setting the value on all inputs when one of the inputs was changed, including re-setting it on the input being edited:

Tue, May 22, 5:55 PM · JavaScript, MediaWiki-Page-protection, Browser-Support-Google-Chrome
matmarex added a comment to T195249: Allow cascade semi-protection or different protection levels for root page and cascade transclusions.

Could you, please, reallow cascade semi-protection,

Tue, May 22, 4:50 PM · AbuseFilter, MediaWiki-Page-protection, MediaWiki-Page-editing
matmarex closed T29978: Pages sometimes appear as if they cannot be edited by anons (aka as if they were protected) even though they are not [Squid caching issue?] as Resolved.

This is probably no longer a problem?

Tue, May 22, 4:49 PM · Wikimedia-General-or-Unknown, Regression, MediaWiki-Page-protection

Mon, May 21

matmarex added a comment to T191756: Guess parameters for templates without TemplateData.

This is excellent \o/

Mon, May 21, 7:51 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
matmarex awarded T191756: Guess parameters for templates without TemplateData a Baby Tequila token.
Mon, May 21, 7:51 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Sun, May 20

matmarex added a project to T104540: Reference list <div> can overlap a template <div> because that's how HTML works: Wikimedia-Hackathon-2018.
Sun, May 20, 1:58 PM · Wikimedia-Hackathon-2018, VisualEditor, VisualEditor-ContentEditable
matmarex added a project to T190226: Allow "holes" inside focusable highlights, e.g. for images with editable captions: Wikimedia-Hackathon-2018.
Sun, May 20, 1:58 PM · Wikimedia-Hackathon-2018, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
matmarex updated the task description for T104540: Reference list <div> can overlap a template <div> because that's how HTML works.
Sun, May 20, 1:55 PM · Wikimedia-Hackathon-2018, VisualEditor, VisualEditor-ContentEditable
matmarex added a comment to T195188: Ability to sort output Special:UnusedImages .

The page is currently sorted by file upload date (img_timestamp).

Sun, May 20, 1:54 PM · MediaWiki-Special-pages
matmarex edited projects for T195172: Remove CologneBlue skin from appearance choice in Special:Preferences, added: Wikimedia-General-or-Unknown; removed CologneBlue.
Sun, May 20, 1:47 PM · Wikimedia-General-or-Unknown
matmarex added a comment to T53202: Draw VisualEditor's non-CE block highlights using SVG polygons.

We are now using getBoundingClientRect and getClientRects. The only part missing from this bug is to use SVG. We should investigate the performance benefits/losses of doing so.

Sun, May 20, 12:52 PM · Patch-For-Review, VisualEditor-Performance, VisualEditor, VisualEditor-ContentEditable

Sat, May 19

matmarex added a comment to T190226: Allow "holes" inside focusable highlights, e.g. for images with editable captions.

Screenshot (I've put no effort yet into tweaking the CSS):

Sat, May 19, 9:06 PM · Wikimedia-Hackathon-2018, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
matmarex added a comment to T190226: Allow "holes" inside focusable highlights, e.g. for images with editable captions.

Demo of highlights with holes using SVG clip-paths and masks:

Sat, May 19, 8:58 PM · Wikimedia-Hackathon-2018, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor-EditingTools, VisualEditor
matmarex closed T126546: Typing into text field in media search dialog hangs and then crashes browser tab when using Opera (Chromium-like) on Windows 7 as Resolved.

No longer happening… probably was a browser bug.

Sat, May 19, 8:36 PM · User-Ryasmeen, Performance, VisualEditor-MediaWiki, VisualEditor
Liuxinyu970226 awarded T194433: [wmf.3] Inspectors are cut off inside dialogs a Hungry Hippo token.
Sat, May 19, 3:37 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex added a comment to T195053: Reduce page jumps in table of contents.

There is a patch pending for this that uses similar approach to T42812: https://gerrit.wikimedia.org/r/#/c/372515/

Sat, May 19, 12:19 PM · Patch-For-Review, CSS, JavaScript, MediaWiki-Interface
matmarex added a comment to T194788: An introduction to working with OOUI (Wikimedia Hackathon 2018).

I think we might not have recording equipment in this room :(

Sat, May 19, 9:56 AM · Wikimedia-Hackathon-2018

Fri, May 18

matmarex updated the task description for T194532: Special:Preferences: What's '(disabled)' supposed to mean in "E-mail me when a page on my watchlist is changed (disabled)".
Fri, May 18, 7:34 PM · UI-Standardization, MediaWiki-User-preferences
matmarex renamed T194532: Special:Preferences: What's '(disabled)' supposed to mean in "E-mail me when a page on my watchlist is changed (disabled)" from Special:Preferences: Tacking on ' (disabled)' after preferences via DefaultPreferencesFactory setting "disabled" is bad UX to Special:Preferences: What's '(disabled)' supposed to mean in "E-mail me when a page on my watchlist is changed (disabled)".
Fri, May 18, 7:34 PM · UI-Standardization, MediaWiki-User-preferences
matmarex closed T194532: Special:Preferences: What's '(disabled)' supposed to mean in "E-mail me when a page on my watchlist is changed (disabled)", a subtask of T180538: Improve Special:Preferences UI/UX, as Invalid.
Fri, May 18, 7:34 PM · UI-Standardization, MediaWiki-User-preferences
matmarex added a comment to T194532: Special:Preferences: What's '(disabled)' supposed to mean in "E-mail me when a page on my watchlist is changed (disabled)".

This is not lego messages or in fact our code at all. It's an override from https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Tog-enotifwatchlistpages. I don't know why it was put there, I agree it is stupid.

Fri, May 18, 7:34 PM · UI-Standardization, MediaWiki-User-preferences
matmarex updated subscribers of T194523: DropdownInputWidget: In non-JS, focus state border is missing on the right side.

We last discussed it at T168703, @Volker_E and I consider this unfixable; @Esanders apparently had a workaround but he refused to show it to us ;)

Fri, May 18, 7:27 PM · OOUI
matmarex updated subscribers of T147117: [feature request] make property suggestor work for qualifiers and entities other than items.
Fri, May 18, 6:24 PM · MediaWiki-extensions-PropertySuggester, Wikidata
matmarex updated subscribers of T186716: enable fine grained usage tracking on Commons.
Fri, May 18, 6:22 PM · Commons, User-Ladsgroup, Wikidata
matmarex added a comment to T189366: OOUI styles aren't available separately for certain modules.

Meh, I guess this is getting merged anyway. Please never use this module though. You're just asking for an unintentional OOUI change to break your thing.

Fri, May 18, 6:21 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, OOUI
matmarex reopened T26655: Vector: Arrow+backspace key + mouse problem in SimpleSearch as "Open".
Fri, May 18, 6:18 PM · Readers-Web-Backlog (Tracking), Vector
matmarex closed T194433: [wmf.3] Inspectors are cut off inside dialogs as Resolved.
Fri, May 18, 5:43 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex removed a project from T194433: [wmf.3] Inspectors are cut off inside dialogs: Security.
Fri, May 18, 5:39 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
StjnVMF awarded T194433: [wmf.3] Inspectors are cut off inside dialogs a Hungry Hippo token.
Fri, May 18, 5:19 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex added a project to T189362: ipblock-exempt does not allow account creation when blocked: MediaWiki-Authentication-and-authorization.

It seems that AuthManager checks the user rights too stringently (when calling isBlockedFromCreateAccount()). In addition to checking whether the account creator can create the new account (AuthManager::checkAccountCreatePermissions()), it also checks whether the new account can create itself (CheckBlocksSecondaryAuthenticationProvider::testUserForCreation()). I think that is incorrect, but perhaps there is a reason for this (or perhaps it has always been this way, and you're in fact requesting a new feature).

Fri, May 18, 4:31 PM · MediaWiki-Authentication-and-authorization, MediaWiki-User-management
matmarex lowered the priority of T189362: ipblock-exempt does not allow account creation when blocked from Unbreak Now! to Needs Triage.
Fri, May 18, 4:25 PM · MediaWiki-Authentication-and-authorization, MediaWiki-User-management
matmarex updated the task description for T189362: ipblock-exempt does not allow account creation when blocked.
Fri, May 18, 3:54 PM · MediaWiki-Authentication-and-authorization, MediaWiki-User-management
matmarex added a comment to T189362: ipblock-exempt does not allow account creation when blocked.

Is this a regression? Why is it "unbreak now"?

Fri, May 18, 3:53 PM · MediaWiki-Authentication-and-authorization, MediaWiki-User-management
matmarex removed a project from T194956: corrupted files in the cache: Multimedia.
Fri, May 18, 2:41 PM · Cloud-Services, Structured-Data-Commons, Multimedia, Wikidata
matmarex added a comment to T194944: Error message doesn't explain much.

First, it doesn't seem like the page is taking that much.

Fri, May 18, 2:38 PM · VisualEditor, VisualEditor-VisualDiffs
matmarex added a comment to T194944: Error message doesn't explain much.

Can you clarify what would you like the error message to explain?

Fri, May 18, 1:48 PM · VisualEditor, VisualEditor-VisualDiffs
matmarex updated the task description for T194944: Error message doesn't explain much.
Fri, May 18, 1:48 PM · VisualEditor, VisualEditor-VisualDiffs
matmarex added a project to T194945: Infobox overlaps with text, prevents editing the latter.: Parsoid.

Looks like Parsoid is marking up the first paragraph as part of the transclusion. This might be a bug in Parsoid or broken syntax in the infobox template (e.g. unclosed HTML tags).

Fri, May 18, 1:33 PM · Parsoid, VisualEditor
matmarex triaged T194433: [wmf.3] Inspectors are cut off inside dialogs as Unbreak Now! priority.
Fri, May 18, 12:59 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex merged T194819: [Regression wmf.3] Opening link inspector inside the Reference dialog causes VE to crash into T194433: [wmf.3] Inspectors are cut off inside dialogs.
Fri, May 18, 12:56 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex merged task T194819: [Regression wmf.3] Opening link inspector inside the Reference dialog causes VE to crash into T194433: [wmf.3] Inspectors are cut off inside dialogs.
Fri, May 18, 12:56 PM · VisualEditor
matmarex added a comment to T194819: [Regression wmf.3] Opening link inspector inside the Reference dialog causes VE to crash.

If you try to insert a link anyway, it crashes VE. But does not show any error in the console.

Fri, May 18, 12:56 PM · VisualEditor
matmarex updated the task description for T194819: [Regression wmf.3] Opening link inspector inside the Reference dialog causes VE to crash.
Fri, May 18, 12:53 PM · VisualEditor
matmarex merged T194910: Link selector partly hidden behind the left part of the Insert media widget into T194433: [wmf.3] Inspectors are cut off inside dialogs.
Fri, May 18, 12:51 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), User-Ryasmeen, Verified, VisualEditor (Current work), VisualEditor-MediaWiki
matmarex merged task T194910: Link selector partly hidden behind the left part of the Insert media widget into T194433: [wmf.3] Inspectors are cut off inside dialogs.
Fri, May 18, 12:51 PM · VisualEditor
matmarex closed T193966: Form field should override subpage as Resolved.
Fri, May 18, 11:31 AM · Tracking
matmarex closed T193965: Form field should override subpage in Special:AllPages as Resolved.
Fri, May 18, 11:30 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Easy, MediaWiki-Special-pages
matmarex closed T193965: Form field should override subpage in Special:AllPages, a subtask of T193966: Form field should override subpage, as Resolved.
Fri, May 18, 11:30 AM · Tracking

Thu, May 17

matmarex claimed T194725: Collapsed tables broken in visual diff.
Thu, May 17, 11:11 AM · VisualEditor, VisualEditor-VisualDiffs
matmarex claimed T194833: VE Mobile editor switcher goes missing at certain widths.
Thu, May 17, 11:09 AM · VisualEditor (Current work), Patch-For-Review, OOUI, VisualEditor-MediaWiki-Mobile
matmarex added a comment to T194690: Incorrect encoding of id fields when runnign StructuredDiscussion on a Windows server.

MediaWiki uses the binary type for many text fields, but most of them contain UTF-8 text, so treating their contents as UTF-8 instead of binary data doesn't corrupt them. (Off the top of my head, the only columns that actually may contain binary data, depending on your configuration, are categorylinks.cl_sortkey and page_props.pp_value.)

Thu, May 17, 9:22 AM · Collaboration-Team-Triage, WMSE-Bug-Reporting-and-Translation-2018, StructuredDiscussions

Wed, May 16

matmarex closed T194832: Editor switcher in MobileFrontend visually broken as Resolved.
Wed, May 16, 6:01 PM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), MobileFrontend
matmarex added a comment to T194832: Editor switcher in MobileFrontend visually broken.

Caused by https://gerrit.wikimedia.org/r/#/c/428136/ in OOUI v0.26.5.

Wed, May 16, 3:08 PM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), MobileFrontend
matmarex reopened T185590: Invisible character at end of line through copy&paste as "Open".

Sounds related to T188837 or T162916.

Wed, May 16, 2:39 PM · User-Ryasmeen, VisualEditor
matmarex renamed T192247: Searchtext placeholder text misaligned with searchbox on Telugu Wiki projects in Firefox (version 59 only) from Searchtext placeholder text misaligned with searchbox on Telugu Wiki projects in Firefox to Searchtext placeholder text misaligned with searchbox on Telugu Wiki projects in Firefox (version 59 only).
Wed, May 16, 8:41 AM · MediaWiki-Interface, CirrusSearch, Discovery-Search, Discovery, I18n
matmarex added a comment to T192247: Searchtext placeholder text misaligned with searchbox on Telugu Wiki projects in Firefox (version 59 only).

So I think this was only a problem in Firefox 59. I'll close this task, but if you notice this again in another browser, please reopen. :)

Wed, May 16, 8:39 AM · MediaWiki-Interface, CirrusSearch, Discovery-Search, Discovery, I18n
matmarex added a comment to T194690: Incorrect encoding of id fields when runnign StructuredDiscussion on a Windows server.

I think this is a problem with your export method. The data in fields like ref_id is actually raw binary data, but it looks like your export tool tried to interpret is at UTF-8 (decode and re-encode it). It is not valid UTF-8 text, so some of the bytes were replaced with '�' (U+FFFD replacement character), which obviously corrupts the data. If you managed to import it, you'd probably find your Flow threads to be inaccessible.

Wed, May 16, 8:07 AM · Collaboration-Team-Triage, WMSE-Bug-Reporting-and-Translation-2018, StructuredDiscussions
matmarex closed T193927: Form field should override subpage in Special:PrefixIndex as Resolved.
Wed, May 16, 8:00 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Need-volunteer, Easy, MediaWiki-Special-pages
matmarex closed T193927: Form field should override subpage in Special:PrefixIndex, a subtask of T193966: Form field should override subpage, as Resolved.
Wed, May 16, 7:59 AM · Tracking
matmarex added a comment to T194756: Blocked user should be allowed to edit subpages of own user talk page.

I am not sure if this would be desirable.

Wed, May 16, 7:59 AM · MediaWiki-User-management, User-Zoranzoki21, MediaWiki-Page-editing
matmarex added a comment to T194789: Talk page of blocked user is not patrolled when user edit own talk page and he have autopatrol right.

Looks like this check happens in WikiPage:

				// Mark as patrolled if the user can do so
				$autopatrolled = $wgUseRCPatrol && !count(
						$this->mTitle->getUserPermissionsErrors( 'autopatrol', $user ) );

Title::getUserPermissionsErrors() calls Title::checkUserBlock(), which calls User::isBlockedFrom(), but only for $action == 'edit' || $action == 'create'. We should probably add 'autopatrol' to that list.

Wed, May 16, 7:54 AM · Patch-For-Review, User-Zoranzoki21, MediaWiki-Page-editing, MediaWiki-Patrolling
matmarex removed a project from T194765: Info popups possibly overlap with upper-right personal toolbar: OOUI.

Setting a z-index will not help, because the Vector skin is constructed so that elements inside the content (.mw-body-content) can not obscure the skin interface elements (like the menus), because it creates a stacking context (with position: relative; z-index: 0;).

Wed, May 16, 7:05 AM · Easy, TCB-Team, Advanced-Search

Tue, May 15

matmarex claimed T187645: Garbage characters in category first-letter heading for numbers 2 and 3 (due to collation handling?).
Tue, May 15, 3:37 PM · MW-1.31-release-notes, MW-1.31-release, MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Patch-For-Review, MediaWiki-Categories
matmarex added a comment to T187645: Garbage characters in category first-letter heading for numbers 2 and 3 (due to collation handling?).

The patch will be deployed to Wikimedia wikis this week per the usual
schedule (Tuesday-Thursday), but note that the first-letter data is
additionally cached for up to a week, so it might take a bit longer for the
issue to be fixed. I'll keep this task open until I can verify the fix.

Tue, May 15, 3:37 PM · MW-1.31-release-notes, MW-1.31-release, MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Patch-For-Review, MediaWiki-Categories

Mon, May 14

matmarex created P7126 Bad idea from https://gerrit.wikimedia.org/r/#/c/410038/.
Mon, May 14, 7:28 PM
matmarex added a project to T194667: OOUI Checkboxes missing the checkmark in Safari since v0.27.0: Browser-Support-Apple-Safari.
Mon, May 14, 5:55 PM · Browser-Support-Apple-Safari, OOUI
matmarex added a comment to T153011: Special:Notifications is too slow to open.

Well, running with "debug=true" makes the thing that loads slightly slowly
-- the filter thing on top of "related changes" -- load incredibly slowly;
without debug=true, it takes 4-5 seconds to load; with debug=true, it takes
more like 25 seconds.

Mon, May 14, 5:25 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Notifications
matmarex claimed T194676: Warnings in Firefox debugger when using debug=1 about broken source maps for OOUI modules.
Mon, May 14, 5:22 PM · OOUI (OOUI-0.27.1), MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, MediaWiki-General-or-Unknown
matmarex created T194676: Warnings in Firefox debugger when using debug=1 about broken source maps for OOUI modules.
Mon, May 14, 5:21 PM · OOUI (OOUI-0.27.1), MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, MediaWiki-General-or-Unknown
matmarex merged T194655: Special:PrefixIndex no longer put current prefix in the prefix input into T193927: Form field should override subpage in Special:PrefixIndex.
Mon, May 14, 4:43 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Need-volunteer, Easy, MediaWiki-Special-pages
matmarex merged task T194655: Special:PrefixIndex no longer put current prefix in the prefix input into T193927: Form field should override subpage in Special:PrefixIndex.
Mon, May 14, 4:43 PM · MediaWiki-Special-pages
matmarex added a comment to T194655: Special:PrefixIndex no longer put current prefix in the prefix input.

Yes, the patch there fixes this as well.

Mon, May 14, 4:42 PM · MediaWiki-Special-pages
matmarex claimed T194068: CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces.

I investigated today why this happens:

  • During VisualEditor's initialisation, <div id="mw-content-text"> is temporarily hidden while its contents are rearranged
  • On category pages, VisualEditor initialisation happens a bit differently so that the list of pages remains visible – in particular, the editing surface is inserted inside the <div id="mw-content-text"> rather than next to it (DesktopArticleTarget#getEditableContent)
  • When CodeEditor syntax-highlighting initializes (updateDisplayIfNeeded()), on category pages the editing surface is inside the hidden div, and so CodeEditor doesn't render it
  • Then the div is shown again and the incomplete syntax-highlighting editing surface appears (looks like invisible text)
Mon, May 14, 4:32 PM · VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, Community-Tech, MediaWiki-extensions-CodeMirror
matmarex awarded T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default a Yellow Medal token.
Mon, May 14, 7:49 AM · User-Tgr, Trust-and-Safety, TechCom, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

Thu, May 10

matmarex closed T53167: VisualEditor: Context menu should appear in floated element, not in float origin as Resolved.

This works correctly these days:

Thu, May 10, 9:49 PM · User-Ryasmeen, VisualEditor, VisualEditor-ContentEditable
matmarex closed T89615: Comment syntax shown in template's name in VisualEditor as Resolved.

VisualEditor should probably use the href field here in its context menu, not the wt field; this seems like a VE UI bug. Once you open the template for editing, perhaps you'd want to be able to edit the raw wikitext, but the href field is more appropriate in terms of showing the user which template is represented.

Thu, May 10, 9:45 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), User-Ryasmeen, MW-1.29-release-notes, Parsoid, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor