matmarex (Bartosz Dziewoński)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (135 w, 5 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Today

matmarex claimed T166256: HTMLForm multiselect field does not retain its values after submit, when action=GET.

This is a change in behavior caused by rMWb5237cfc1b47: HTMLForm: Allow distinguishing between form views and submission attempts to fix T29676.

Wed, May 24, 8:45 PM · MediaWiki-HTMLForm
matmarex renamed T166259: Adding a table column in a large table takes forever, loses all your work from "Adding a table column after the last one causes an infinite loop, loses all your work" to "Adding a table column in a large table takes forever, loses all your work".
Wed, May 24, 8:15 PM · VisualEditor-Tables, VisualEditor
matmarex added a comment to T166259: Adding a table column in a large table takes forever, loses all your work.

Actually, it seems that trying to add a column anywhere in that table causes this. Adding rows, or deleting rows/column, is fine.

Wed, May 24, 8:15 PM · VisualEditor-Tables, VisualEditor
matmarex created T166259: Adding a table column in a large table takes forever, loses all your work.
Wed, May 24, 8:09 PM · VisualEditor-Tables, VisualEditor
matmarex edited projects for T93290: ButtonElements with no label, icon and indicator should still have consistent height, added: OOjs-UI (OOjs-UI-0.12.9); removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)), Patch-For-Review, OOjs-UI.
Wed, May 24, 3:11 PM · OOjs-UI (OOjs-UI-0.12.9), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1))
matmarex closed T165930: Upload Wizard and Flickr don't seem to work for mass uploads on Commons as "Resolved".
Wed, May 24, 3:10 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), UploadWizard, Multimedia, Commons
matmarex added a comment to T165930: Upload Wizard and Flickr don't seem to work for mass uploads on Commons.

Looks like this will just be part of the regular release schedule. For Commons specifically, the change should be deployed today around 19:00-21:00 UTC, or 4-6 hours from now (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20170524T1900).

Wed, May 24, 3:09 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), UploadWizard, Multimedia, Commons
matmarex claimed T164750: Cannot set selected items in MenuTagMultiselectWidget when creating.

Thanks for the reminder, I'll do it.

Wed, May 24, 3:03 PM · OOjs-UI (OOjs-UI-0.22.0)
matmarex added a comment to T137269: Disable "cross-wiki" uploads (actually local ones) from Commons to Commons, or change the upload summary so that it does not say confusing "cross-wiki".

Okay, so skipping over the offtopic discussion, the current status of this task is the same as a year ago when I wrote this comment:

Wed, May 24, 2:55 PM · Wikimedia-Site-requests, Commons, Multimedia
matmarex added a comment to T164845: Request feature - make it easier to create navigation in custom skins.

Looks like https://www.mediawiki.org/wiki/Manual:Skinning_Part_2 got updated, thanks for doing it (and I made some minor tweaks too).

Wed, May 24, 2:36 PM · MediaWiki-General-or-Unknown
matmarex added a comment to T99736: Special:Categories on some wikis errors out with "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException".

Thank you both for working on this!

Wed, May 24, 2:29 PM · Patch-For-Review, MediaWiki-Categories, Wikimedia-log-errors, MediaWiki-Special-pages, Wikisource

Yesterday

matmarex added projects to T166183: Template-generated table row (multiple cells) is not entirely alienated: VisualEditor-Tables, VisualEditor-MediaWiki-Templates.
Tue, May 23, 10:10 PM · Parsoid, VisualEditor-MediaWiki-Templates, VisualEditor-Tables, VisualEditor-MediaWiki, VisualEditor
matmarex created T166183: Template-generated table row (multiple cells) is not entirely alienated.
Tue, May 23, 10:09 PM · Parsoid, VisualEditor-MediaWiki-Templates, VisualEditor-Tables, VisualEditor-MediaWiki, VisualEditor
matmarex updated subscribers of T165930: Upload Wizard and Flickr don't seem to work for mass uploads on Commons.

@HiW Matthias wrote the fix (and I just merged it), but it's not deployed on Wikimedia sites yet. It will be deployed per the usual schedule: https://www.mediawiki.org/wiki/MediaWiki_1.30/Roadmap on 23-25 May. (Although maybe we should deploy it sooner in a SWAT window – @Jdforrester-WMF?)

Tue, May 23, 3:16 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), UploadWizard, Multimedia, Commons
matmarex added a comment to T22307: Generate automatic summary /* blah */ when I manually add a section heading when editing.

I looked at this again during the 2017 hackathon and updated the patch. The feature is now implemented and seems to work fine, but I've ran into some CI troubles. But hopefully this will actually move forward soon!

Tue, May 23, 3:08 PM · Wikimedia-Hackathon-2017, Patch-For-Review, Community-Wishlist-Survey-2015, MediaWiki-Page-editing
matmarex removed a project from T22307: Generate automatic summary /* blah */ when I manually add a section heading when editing: Wikimania-Hackathon-2016.
Tue, May 23, 3:06 PM · Wikimedia-Hackathon-2017, Patch-For-Review, Community-Wishlist-Survey-2015, MediaWiki-Page-editing
matmarex added a comment to T165457: OOjs UI Demos: Show code used to generate widgets.

No, looks like a bug. That example definitely worked last time I checked that patch. Looks like it was broken by the last patchset.

Tue, May 23, 11:46 AM · Patch-For-Review, OOjs-UI (OOjs-UI-0.22.0), Documentation

Mon, May 22

matmarex awarded T166057: Sunset Extension:OOUIPlayground a Pirate Logo token.
Mon, May 22, 5:38 PM · MediaWiki-extensions-Other
matmarex awarded T166055: Sunset Skin:Blueprint a Pirate Logo token.
Mon, May 22, 5:37 PM · Blueprint

Sun, May 21

matmarex closed T160536: PHP Notice: A non well formed numeric value encountered as "Resolved".
Sun, May 21, 12:39 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Upstream, NewPHP, TimedMediaHandler
matmarex added a comment to T165892: [Regression pre-wmf.2] Context menu for table is appearing for template node.

Possibly fixed by https://gerrit.wikimedia.org/r/#/c/354558/ ?

Sun, May 21, 12:14 PM · VisualEditor-MediaWiki-Templates, VisualEditor-Tables, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), User-Ryasmeen, VisualEditor
matmarex added a comment to T93968: Mobile should not completely blank mediawiki.skinning.content.parsoid.

It was removed in rEMFRfc9576c02ccd: Hygiene: Kill no longer cached ResourceLoader modules, apparently.

Sun, May 21, 12:01 PM · Reading-Web-Backlog, MobileFrontend, Parsoid, Collaboration-Team-Triage
matmarex added a comment to T165959: LiquidThreads editor has toolbar displayed twice with different buttons.

All fixed?

Sun, May 21, 11:20 AM · User-Ryasmeen, VisualEditor, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), WikiEditor, JavaScript, MediaWiki-extensions-LiquidThreads
matmarex edited projects for T165959: LiquidThreads editor has toolbar displayed twice with different buttons, added: WikiEditor; removed MediaWiki-General-or-Unknown.

I blame @Esanders and https://gerrit.wikimedia.org/r/#/c/351681/.

Sun, May 21, 10:04 AM · User-Ryasmeen, VisualEditor, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), WikiEditor, JavaScript, MediaWiki-extensions-LiquidThreads
matmarex closed T155520: [[MediaWiki:Content-model-proofread-page]] is confusing as "Resolved".

Thanks!

Sun, May 21, 9:58 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), ProofreadPage, I18n

Sat, May 20

matmarex added a comment to T99736: Special:Categories on some wikis errors out with "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException".

Are we done fixing the large wikis too, or just checking them?

Sat, May 20, 7:53 PM · Patch-For-Review, MediaWiki-Categories, Wikimedia-log-errors, MediaWiki-Special-pages, Wikisource
matmarex added a comment to T139110: uca-fa collation shows pages starting with ا incorrectly under ء.

I suppose we need to run the updateCollation.php script on beta now to verify?

Sat, May 20, 7:41 PM · MW-1.30-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)), Patch-For-Review, MediaWiki-Categories, MediaWiki-Internationalization
matmarex added a comment to T133036: Field "hideuser" on Special:Block should be hidden when time field not indefinite.

For reference, there has been an older patch for this task at https://gerrit.wikimedia.org/r/#/c/318690/ (unfinished).

Sat, May 20, 7:28 PM · Patch-For-Review, Ladies-That-FOSS-MediaWiki, Easy, MediaWiki-User-management, JavaScript
matmarex added a comment to T153933: OOjs-ui TextInputWidget broken if a label is supplied with labelPosition=before.

This is fixed by the revert?

Sat, May 20, 1:30 PM · Patch-For-Review, Regression, OOjs-UI
matmarex added a comment to T96529: Misrendered infobox in hewiki article.

Perhaps the infobox has been changed not to trigger this problem. The underlying issue is still present:

Sat, May 20, 1:28 PM · Parsoid
matmarex added a comment to T163474: Table context off screen and causing(?) scrolling after OOUI update.

I don't see this problem anymore.

Sat, May 20, 1:24 PM · VisualEditor-Tables, OOjs-UI, VisualEditor
matmarex created T165865: Table row context menu appears too far below.
Sat, May 20, 12:00 PM · Patch-For-Review, VisualEditor
matmarex added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

I submitted a patch to change this (see T165854: Change OOUI EditPage inputs to keep the old 'id' attributes on the <input> elements). I hope you haven't updated too many gadgets that will need to be fixed again :( (The ones that used $( 'input#wpSummary, #wpSummary > input' ) etc. should work fine with the proposed HTML too, no further changes needed.)

Sat, May 20, 11:51 AM · Community-Liaisons (Apr-Jun 2017), Wikimedia-Site-requests, Patch-For-Review, User-notice, VisualEditor
matmarex added a comment to T165854: Change OOUI EditPage inputs to keep the old 'id' attributes on the <input> elements.

For most basic bits, it will mostly keep working – we still use a normal HTML <input> and it can still be interacted with using the usual DOM methods. Things might start behaving funny if we infuse the widget, but the things editors care about (like submitting the form with the edit summary) will work just fine.

Sat, May 20, 10:09 AM · VisualEditor, Patch-For-Review, Editing-Department, MediaWiki-Page-editing
matmarex created T165854: Change OOUI EditPage inputs to keep the old 'id' attributes on the <input> elements.
Sat, May 20, 10:04 AM · VisualEditor, Patch-For-Review, Editing-Department, MediaWiki-Page-editing
matmarex added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

Rather than changing countless uses, and also annoying downstream users and developers, why don't you let the input keep wpSummary id?
That seems a much nicer solution, instead of repurposing an id that has been used that way for nearly 12 years.

Sat, May 20, 9:57 AM · Community-Liaisons (Apr-Jun 2017), Wikimedia-Site-requests, Patch-For-Review, User-notice, VisualEditor

Fri, May 19

matmarex added a parent task for T165816: Upgrade jQuery Mobile to 1.5: T124742: Upgrade to jQuery 3.
Fri, May 19, 9:32 PM · Timeless
matmarex added a subtask for T124742: Upgrade to jQuery 3: T165816: Upgrade jQuery Mobile to 1.5.
Fri, May 19, 9:32 PM · MW-1.29-release-notes, Performance-Team, JavaScript, MediaWiki-ResourceLoader
matmarex created T165816: Upgrade jQuery Mobile to 1.5.
Fri, May 19, 9:31 PM · Timeless
matmarex added a project to T165552: OnlineStatus extension shows warning on deprecated hookEvent: MediaWiki-extensions-OnlineStatus.

The hookEvent call and the warning is coming from the OnlineStatus extension you have installed.

Fri, May 19, 8:35 PM · MediaWiki-extensions-OnlineStatus
matmarex edited the description of T47051: Phase out the Vector extension; merge the good parts into core (tracking).
Fri, May 19, 6:45 PM · Vector, Tracking, MediaWiki-Interface, MW-1.22.0-release
matmarex added a comment to T107745: Come up with an alternative to having multiple slugs (invitations to add a paragraph) next to each other that preserves editing capabilities.

It also prevents you from editing the images visually… please don't do that :) It helps for the specific case nl.wp had a problem with (T161408), but unless the content you wrap is already mostly made up of templates, it will result in worse interface in VE (and it's clutter in the page source).

Fri, May 19, 4:41 PM · VisualEditor-ContentEditable, VisualEditor
matmarex added a comment to T165718: OO.ui.ButtonInputWidget based on <input> differs in height from other buttons.

I bisected and this appears to have been caused by rGOJU1dcc221214b1: MediaWiki theme: Fix IE 7 oversized buttons.

Fri, May 19, 3:46 PM · OOjs-UI
matmarex added a comment to T165718: OO.ui.ButtonInputWidget based on <input> differs in height from other buttons.

This was broken once a long time ago, but we fixed it. Someone must have unfixed it recently. This is not an issue e.g. in this super-old version: https://doc.wikimedia.org/oojs-ui/v0.12.8/demos/

Fri, May 19, 3:35 PM · OOjs-UI
matmarex added a comment to T163990: Title::getArticleID (LinkCache::addLinkObj) should not fail with "Service disabled: DBLoadBalancer".

That doesn't really make sense for me. The database not being there is a pretty exceptional case. It deserves to throw exceptions. If your code is doing Title->getRestrictionTypes() while the wiki doesn't even have the concept of a Title yet, it's a bug in your code.

Fri, May 19, 1:15 PM · MediaWiki-General-or-Unknown
matmarex added a comment to T165552: OnlineStatus extension shows warning on deprecated hookEvent.

I wanted to check it out again but your wiki (http://www.hypoverse.com/) seems to be down…

Fri, May 19, 1:09 PM · MediaWiki-extensions-OnlineStatus
matmarex added a comment to T161408: Unneeded extra whitespace shown on some articles.

This is a specific case of T107745, it's possible we can solve this problem without doing the entire thing, maybe before 2020 ;) especially if it's okay to require minor wikitext changes to do so.

Fri, May 19, 12:57 PM · VisualEditor

Wed, May 17

matmarex added a comment to T165552: OnlineStatus extension shows warning on deprecated hookEvent.

I don't see any warnings when viewing the site.

Wed, May 17, 7:06 PM · MediaWiki-extensions-OnlineStatus
matmarex added a comment to T99736: Special:Categories on some wikis errors out with "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException".

I'll save you the grep, here are the non-zero entries:

Wed, May 17, 5:07 PM · Patch-For-Review, MediaWiki-Categories, Wikimedia-log-errors, MediaWiki-Special-pages, Wikisource
matmarex added a comment to T165552: OnlineStatus extension shows warning on deprecated hookEvent.

The URL in the error message is misleading. The error almost certainly comes from your site JavaScript (the pages 'MediaWiki:Common.js' and 'MediaWiki:Vector.js'), especially if you copied them from Wikipedia a long time ago. Vector doesn't use the hookEvent function.

Wed, May 17, 12:40 PM · MediaWiki-extensions-OnlineStatus
matmarex placed T165508: AbuseFilter supports a filter for cross-wiki uploads but the warning message not internationalized up for grabs.

Hmm. I think this probably ends up using the language you have set in preferences on Commons, which is English for new users. Possibly all we need is to pass a 'uselang' parameter to the API queries on target wiki, matching the language of the user on the source wiki… I'm not sure if that will be enough, I haven't worked with this code for a while.

Wed, May 17, 8:22 AM · MediaWiki-Uploading, I18n, AbuseFilter, Multimedia, Commons

Tue, May 16

Steinsplitter awarded T165508: AbuseFilter supports a filter for cross-wiki uploads but the warning message not internationalized a Love token.
Tue, May 16, 6:50 PM · MediaWiki-Uploading, I18n, AbuseFilter, Multimedia, Commons
matmarex added a project to T165455: Go from "E" to "A+" on Securityheaders.io: Wikimedia-General-or-Unknown.
Tue, May 16, 5:50 PM · Wikimedia-General-or-Unknown, Security
Framawiki awarded T165508: AbuseFilter supports a filter for cross-wiki uploads but the warning message not internationalized a Love token.
Tue, May 16, 5:02 PM · MediaWiki-Uploading, I18n, AbuseFilter, Multimedia, Commons
matmarex claimed T165146: veaction=editsource in the URL should load new wikitext editor.
Tue, May 16, 4:47 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex added a comment to T165146: veaction=editsource in the URL should load new wikitext editor.

This only happens on pages where visual mode is not available, and doesn't happen when you select "Always give me the visual editor if possible" in your preferences.

Tue, May 16, 4:32 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex merged task T165389: Direct navigation to ?veaction=editsource (e.g. opening in a new tab) fails to load the editor into T165146: veaction=editsource in the URL should load new wikitext editor.
Tue, May 16, 4:28 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex merged T165389: Direct navigation to ?veaction=editsource (e.g. opening in a new tab) fails to load the editor into T165146: veaction=editsource in the URL should load new wikitext editor.
Tue, May 16, 4:28 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
matmarex created P5451 (An Untitled Masterwork).
Tue, May 16, 1:48 PM
matmarex added a comment to T165455: Go from "E" to "A+" on Securityheaders.io.

We have the code to emit Referrer-Policy, and it's enabled on production wikis ('origin-when-cross-origin' by default, 'no-referrer' on private wikis), but it doesn't seem to actually be in the output headers… Maybe it's filtered out by Varnish or something?

Tue, May 16, 7:32 AM · Wikimedia-General-or-Unknown, Security
matmarex added a comment to T165455: Go from "E" to "A+" on Securityheaders.io.

We emit X-Frame-Options: DENY on all "sensitive" pages (pretty much everything that displays a form, e.g. action=edit or special pages). We probably can't do that on all pages (neither DENY nor SAMEORIGIN), since various community tools rely on including pages from Wikimedia wikis in frames (for example, Wikidata Game: https://tools.wmflabs.org/wikidata-game/#mode=commonscat).

Tue, May 16, 7:28 AM · Wikimedia-General-or-Unknown, Security
matmarex closed T165237: &ooui=1 is not preserved after Show preview is clicked as "Resolved".

There are no regular deployments this week (due to several teams having offsite meetings, and pre-hackathon travels), so this will probably go live next week.

Tue, May 16, 3:47 AM · MediaWiki-Page-editing, MW-1.30-release-notes

Mon, May 15

matmarex added a comment to T161798: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF.

Hiding and showing the '.oo-ui-outlineControlsWidget' element (applying 'display: none' in the inspector and then removing it) fixes the issue for me. Does that also work for you on Macs?

Mon, May 15, 8:32 PM · Browser-Support-Firefox, OOjs-UI, VisualEditor
matmarex added a comment to T161798: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF.

I see a different but similar issue on Windows, I suppose it's because of differences in scrollbar handling.

Mon, May 15, 8:24 PM · Browser-Support-Firefox, OOjs-UI, VisualEditor
Tbayer awarded T54510: Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled a Barnstar token.
Mon, May 15, 8:15 PM · Patch-For-Review, Collaboration-Team-Triage, MediaWiki-extensions-FlaggedRevs, Notifications
matmarex closed T162559: Page ID substitution ({{subst:PAGEID}}) does not work on creating a new page as "Declined".
Mon, May 15, 8:14 PM · MediaWiki-Page-editing
matmarex added a comment to T163990: Title::getArticleID (LinkCache::addLinkObj) should not fail with "Service disabled: DBLoadBalancer".

Under what circumstances are you getting this? This error seems to indicate that your code is not allowed to access the database at the time, for whatever reason (e.g. for code running in the MediaWiki installer, where the database does not exist yet).

Mon, May 15, 8:08 PM · MediaWiki-General-or-Unknown
matmarex changed the status of T164501: Upload wizard adds coordinates in opposite order from "Open" to "Stalled".
Mon, May 15, 8:03 PM · Multimedia, UploadWizard
matmarex renamed T164987: Trying to move a page to the actual title shows an inappropriate generic error from "Try to move a page to the actual title shows an unappropriate generic error" to "Trying to move a page to the actual title shows an inappropriate generic error".
Mon, May 15, 8:01 PM · Easy, MediaWiki-Special-pages
matmarex added a project to T164987: Trying to move a page to the actual title shows an inappropriate generic error: Easy.

This sounds like a fairly harmless issue and it should be easy to fix, so I'm leaving it for some new developer to look at :)

Mon, May 15, 7:46 PM · Easy, MediaWiki-Special-pages
matmarex added a comment to T165225: HTML attribute error with Timeless.

This sounds like T141894. Perhaps the patch there just needs backporting.

Mon, May 15, 6:25 PM · Timeless
matmarex reassigned T141894: Timeless + echo results in exception for logged in users from Isarra to Bawolff.

Looks like it has been fixed in rSTIM9613a9d4bc09: Fix MWException about passing an array named data to Html::element by @Bawolff.

Mon, May 15, 6:25 PM · Notifications, Collaboration-Team-Triage, Timeless
matmarex claimed T165237: &ooui=1 is not preserved after Show preview is clicked.

This would be indeed convenient. Hopefully it'll be a simple change.

Mon, May 15, 6:22 PM · MediaWiki-Page-editing, MW-1.30-release-notes

Sun, May 14

matmarex added a comment to T164339: Find alternative solution to connect OOjs UI documentation and implemented widgets.
  • For the font – OOjs UI widgets will use whatever font the page uses. Browsers usually use a serif font as the default, while in MediaWiki we use a sans-serif font. To include sane defaults for this and other options, you can just add the OOjs UI demo stylesheet to your page: https://github.com/wikimedia/oojs-ui/blob/master/demos/styles/demo.css (this is probably easier than extracting them from MediaWiki and the effect should be the same)
  • For the missing icon – you'll need to include the specific stylesheets, for example <link rel="stylesheet" href="dist/oojs-ui-mediawiki-icons-content.css">. Syntax like <link rel="stylesheet" src="oojs-ui-mediawiki-icons-*.css"> won't work. See the demo for the list of "icon packs": https://doc.wikimedia.org/oojs-ui/master/demos/#icons-mediawiki-ltr-desktop
Sun, May 14, 7:44 PM · Easy, Documentation, OOjs-UI

Fri, May 12

matmarex closed T162493: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else, a subtask of T162838: Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface, as "Declined".
Fri, May 12, 4:31 PM · User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki, Timeless, VisualEditor
matmarex closed T162493: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else as "Declined".
Fri, May 12, 4:31 PM · VisualEditor
matmarex edited projects for T124214: Allow filtering based on tag on Special:NewFiles, added: MediaWiki-Change-tagging; removed Patch-For-Review.
Fri, May 12, 4:21 PM · MediaWiki-Change-tagging, DBA, MediaWiki-Recent-changes, Multimedia, Commons, User-Josve05a

Thu, May 11

matmarex created T165098: unpackDOMFragments doesn't handle all mandatory content model constraints (those that are enforced by the HTML5 tree builder on a HTML5 parse).
Thu, May 11, 9:03 PM · Parsoid-DOM, Parsoid
matmarex added a comment to T164999: Cross-wiki media upload tool throws JavaScript error.

This is broken since OOjs UI v0.19.0, released on 2017-01-31, and deployed with 1.29.0-wmf.11 on 2017-02-07/09. (But again, it's only broken when the upload dialog is launched from WikiEditor, not from VisualEditor.)

Thu, May 11, 7:24 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), JavaScript, MediaWiki-Uploading, Multimedia
matmarex added a comment to T137269: Disable "cross-wiki" uploads (actually local ones) from Commons to Commons, or change the upload summary so that it does not say confusing "cross-wiki".

It's only totally broken when used from the wikitext editor, it works when used from the visual editor. Given that no one noticed a drop in the uploads when it broke, it seems most users use it from the visual editor.

Thu, May 11, 7:00 PM · Wikimedia-Site-requests, Commons, Multimedia
matmarex claimed T164999: Cross-wiki media upload tool throws JavaScript error.

This only affects the tool usage in WikiEditor, not in VisualEditor.

Thu, May 11, 6:07 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), JavaScript, MediaWiki-Uploading, Multimedia
matmarex added subtasks for T162954: MW-1.30.0-wmf.1 deployment blockers: T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets), T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is).
Thu, May 11, 4:58 PM · Deployment Blockers, MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Release
matmarex added a parent task for T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is): T162954: MW-1.30.0-wmf.1 deployment blockers.
Thu, May 11, 4:58 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Performance-Team, MediaWiki-ResourceLoader, Commons
matmarex added a parent task for T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets): T162954: MW-1.30.0-wmf.1 deployment blockers.
Thu, May 11, 4:58 PM · Patch-For-Review, MediaWiki-ResourceLoader
matmarex renamed T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets) from "MediaWiki:Common.css not applied on it.wikivoyage (works when using ?debug=true and when disabling all gadgets)" to "MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets)".
Thu, May 11, 4:57 PM · Patch-For-Review, MediaWiki-ResourceLoader
matmarex renamed T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is) from "Cat-a-Lot gadget on Commons fails to appear (JS file not loaded but CSS file is)" to "Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is)".
Thu, May 11, 4:56 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Performance-Team, MediaWiki-ResourceLoader, Commons
matmarex closed T163974: MediaWiki 1.29.0-wmf.21 breaks JavaScript collapsing ({{boîte déroulante}}) on fr.wikisource for some users, a subtask of T164242: Find and fix undeclared dependencies to mw.util, mw.notify etc of on-wiki scripts and gadgets, as "Resolved".
Thu, May 11, 4:55 PM · Wikimedia-Hackathon-2017, Reading-Web-Local-Wiki-Issues, Community-Tech-fixes, Wikimedia-General-or-Unknown
matmarex closed T163974: MediaWiki 1.29.0-wmf.21 breaks JavaScript collapsing ({{boîte déroulante}}) on fr.wikisource for some users as "Resolved".

This change should fix the problem: https://fr.wikisource.org/w/index.php?title=MediaWiki:Common.js&diff=6723802&oldid=6425474

Thu, May 11, 4:55 PM · JavaScript, Wikimedia-General-or-Unknown
matmarex added a comment to T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is).

I applied this change to fix those important scripts on Commons (Cat-a-lot and Navigation Popups): https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadgets-definition&diff=243659552&oldid=242815770

Thu, May 11, 4:54 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Performance-Team, MediaWiki-ResourceLoader, Commons
matmarex merged T165015: Some templates on en.wiktionary do not allow toggling between show/hide anymore into T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is).
Thu, May 11, 4:50 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Performance-Team, MediaWiki-ResourceLoader, Commons
matmarex merged task T165015: Some templates on en.wiktionary do not allow toggling between show/hide anymore into T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is).
Thu, May 11, 4:50 PM · Regression, Wiktionary
matmarex removed a subtask for T164242: Find and fix undeclared dependencies to mw.util, mw.notify etc of on-wiki scripts and gadgets: T165015: Some templates on en.wiktionary do not allow toggling between show/hide anymore.
Thu, May 11, 4:50 PM · Wikimedia-Hackathon-2017, Reading-Web-Local-Wiki-Issues, Community-Tech-fixes, Wikimedia-General-or-Unknown
matmarex removed a parent task for T165015: Some templates on en.wiktionary do not allow toggling between show/hide anymore: T164242: Find and fix undeclared dependencies to mw.util, mw.notify etc of on-wiki scripts and gadgets.
Thu, May 11, 4:50 PM · Regression, Wiktionary
matmarex added a comment to T163974: MediaWiki 1.29.0-wmf.21 breaks JavaScript collapsing ({{boîte déroulante}}) on fr.wikisource for some users.

Heh, funny thing, I refreshed the page and now it's broken. Here's how the broken version looks like, for comparison:

Thu, May 11, 4:46 PM · JavaScript, Wikimedia-General-or-Unknown
matmarex added a comment to T163974: MediaWiki 1.29.0-wmf.21 breaks JavaScript collapsing ({{boîte déroulante}}) on fr.wikisource for some users.

Please clarify what the issue is. I see the collapsible boxes on https://fr.wikisource.org/wiki/Utilisateur:Rical#Dates_d.27inscriptions_en_cat.C3.A9gorie and they can be expanded and collapsed for me. Can you upload a screenshot of what you're seeing?

Thu, May 11, 4:42 PM · JavaScript, Wikimedia-General-or-Unknown
matmarex added a comment to T165015: Some templates on en.wiktionary do not allow toggling between show/hide anymore.

This seems to have been resolved on-wiki with https://en.wiktionary.org/w/index.php?title=MediaWiki:Gadgets-definition&diff=42867887&oldid=42211374. I'm pretty sure the underlying issue is the same as T165031.

Thu, May 11, 4:39 PM · Regression, Wiktionary
matmarex added a comment to T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets).

Note that it's already loaded through ResourceLoader (as part of the 'site'/'site.styles' modules), but ResourceLoader doesn't know how to "follow" the @import rules, so they are not followed and loaded in separate requests.

Thu, May 11, 4:36 PM · Patch-For-Review, MediaWiki-ResourceLoader
matmarex edited projects for T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is), added: MediaWiki-ResourceLoader; removed Wikimedia-General-or-Unknown.

The page source includes the following call for me, which is normally used for style-only modules to indicate that their CSS is loaded and should not be loaded again. For some reason 'ext.gadget.Cat-a-lot' is among them, and so it is not being loaded. This obviously makes no sense, and I have no idea what could be causing this.

Thu, May 11, 4:31 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Performance-Team, MediaWiki-ResourceLoader, Commons
matmarex added a comment to T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets).

I don't think it's possible. Users could still technically disable this gadget. But you can advise them in its description that it's a really bad idea to do so.

Thu, May 11, 3:01 PM · Patch-For-Review, MediaWiki-ResourceLoader
matmarex added a comment to T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets).

@Andyrom75 Then I would recommend turning the entire MediaWiki:Common.css into a gadget that is enabled by default. This lets you use multiple CSS pages without annoying @import rules. We have the site styles on https://www.mediawiki.org/ set up that way, for example, as the "Site (styles)" gadget (https://www.mediawiki.org/wiki/Special:Gadgets). Compared to @import, this also lets the styles load faster, since they go through the ResourceLoader minification and they all load in a single request.

Thu, May 11, 2:46 PM · Patch-For-Review, MediaWiki-ResourceLoader