Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (22)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (252 w, 1 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Sat, Aug 10

matmarex moved T227354: Edit Cards v2: instrumentation post-deployment data checks from Ready for Pick Up to Engineering QA on the VisualEditor (Current work) board.
Sat, Aug 10, 10:50 AM · VisualEditor (Current work), VisualEditor-Edit Cards , Product-Analytics
matmarex edited projects for T227354: Edit Cards v2: instrumentation post-deployment data checks, added: VisualEditor (Current work); removed VisualEditor.
Sat, Aug 10, 10:50 AM · VisualEditor (Current work), VisualEditor-Edit Cards , Product-Analytics
matmarex added a project to T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE: OOUI.
Sat, Aug 10, 10:47 AM · Patch-For-Review, OOUI, VisualEditor (Current work)
matmarex closed T228225: Video embeds, even of OGV files, no longer work as Resolved.

Thank you, this indeed works!

Sat, Aug 10, 10:40 AM · serviceops-radar, Phabricator
matmarex moved T228159: Improve loading progress appearance when loading MF, or switching from MF to VE from In progress to Code review on the VisualEditor (Current work) board.

This is done now (although I will probably have to deal with neverending MobileFrontend build failures). There are a few other cleanup commits related to this work, I didn't tag them all to avoid spamming the task: https://gerrit.wikimedia.org/r/q/topic:switch-transition-T228159

Sat, Aug 10, 2:48 AM · Patch-For-Review, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile

Fri, Aug 9

matmarex moved T230237: Scroll animation when loading the visual editor no longer scrolls to the right place from Code review to QA on the VisualEditor (Current work) board.
Fri, Aug 9, 11:06 PM · VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T230237: Scroll animation when loading the visual editor no longer scrolls to the right place from Ready for Pick Up to Code review on the VisualEditor (Current work) board.

For comparison, expected behavior after the fix:

Fri, Aug 9, 8:12 PM · VisualEditor (Current work), VisualEditor-MediaWiki
matmarex claimed T230237: Scroll animation when loading the visual editor no longer scrolls to the right place.
Fri, Aug 9, 8:09 PM · VisualEditor (Current work), VisualEditor-MediaWiki
matmarex created T230237: Scroll animation when loading the visual editor no longer scrolls to the right place.
Fri, Aug 9, 8:08 PM · VisualEditor (Current work), VisualEditor-MediaWiki
matmarex moved T227933: Context items: verify logging events are firing properly from Inbox to High Priority on the Editing QA board.

Looks like we just want to re-check the issues Rummana identified previously, which should now be fixed by David's patches.

Fri, Aug 9, 6:17 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T229579: Use simplified mobilefrontend copyright messages on mobile VE from Inbox to Low Priority on the Editing QA board.
Fri, Aug 9, 6:16 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex removed a project from T223798: Error about manually adding translation tags does not fit the save dialog: Editing QA.

I can reproduce it on that page, although it looks like the error message has been made shorter, so it fits now:

Fri, Aug 9, 6:10 PM · VisualEditor
matmarex moved T223798: Error about manually adding translation tags does not fit the save dialog from Current work to Needs Discussion/Analysis on the VisualEditor board.
Fri, Aug 9, 6:08 PM · VisualEditor
matmarex added a comment to T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it (converting a re-used basic reference to template citation).

Jess, please have a look at the workflow I proposed: T208981#4868393

Fri, Aug 9, 5:20 PM · Editing Design, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-References
matmarex moved T185279: Linter isn't highlighting text in 2017 WTE anymore from QA to Product owner review on the VisualEditor (Current work) board.
Fri, Aug 9, 5:00 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-Linter
matmarex moved T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state from Inbox to Low Priority on the Editing QA board.
Fri, Aug 9, 4:57 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex moved T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:57 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, OOUI (OOUI-0.33.3), VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Browser-Support-Apple-Safari
matmarex moved T225936: Editing lede section with an infobox takes you to the infobox, not the first paragraph from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:56 PM · Editing QA, VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T226374: Impossible to copypaste a specific template across windows from Inbox to Low Priority on the Editing QA board.
Fri, Aug 9, 4:56 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), VisualEditor (Current work)
matmarex moved T227241: 'Change label' and label preview in link context don't work after clicking on 1 or 2 character links from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:56 PM · Editing QA, VisualEditor-DataModel, VisualEditor (Current work)
matmarex moved T227532: New edit cards obscure content at the bottom of the page from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:56 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T227630: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:55 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-Edit Cards
matmarex edited projects for T227852: Copying and pasting table cell is broken in VisualEditor, added: Skipped QA; removed Editing QA.
Fri, Aug 9, 4:55 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Regression, VisualEditor (Current work), VisualEditor-CopyPaste
matmarex moved T228165: Hide "options" bar under edit summary input when hidden from Inbox to Low Priority on the Editing QA board.
Fri, Aug 9, 4:53 PM · Editing Design, Editing QA, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T228227: Edit Cards: Edit link label: default to cursor vs. whole text highlight from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:53 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Editing Design, VisualEditor (Current work), VisualEditor-Edit Cards
matmarex moved T228229: Edit Cards: Fix transition from link search dialog back to document/Edit Card after changing the target of an existing link. from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:53 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), VisualEditor-Edit Cards , Editing Design, VisualEditor (Current work)
matmarex moved T229879: Keyboard and Edit Card show simultaneously when double-tapping link from Inbox to High Priority on the Editing QA board.
Fri, Aug 9, 4:53 PM · Editing QA, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex moved T228240: Visual Editor chops long external links (e.g. to TABernacle tool) from Inbox to Low Priority on the Editing QA board.
Fri, Aug 9, 4:53 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), VisualEditor (Current work), VisualEditor-CopyPaste, VisualEditor-MediaWiki-Links
matmarex edited projects for T229734: Convert button doesn't display since wmf.16, added: Skipped QA; removed Editing QA.

I checked myself that it works as expected again on https://cs.wikipedia.org/w/index.php?title=Za_%C4%BEud%C3%AD&oldid=17535284 (the fix is already live in production).

Fri, Aug 9, 4:53 PM · Skipped QA, VisualEditor (Current work), Citoid
matmarex added a project to T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state: Editing QA.
Fri, Aug 9, 4:48 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor-MediaWiki, VisualEditor (Current work)
matmarex added a project to T229734: Convert button doesn't display since wmf.16: Editing QA.
Fri, Aug 9, 4:48 PM · Skipped QA, VisualEditor (Current work), Citoid
matmarex added a project to T229879: Keyboard and Edit Card show simultaneously when double-tapping link: Editing QA.
Fri, Aug 9, 4:48 PM · Editing QA, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex added a project to T225936: Editing lede section with an infobox takes you to the infobox, not the first paragraph: Editing QA.
Fri, Aug 9, 4:48 PM · Editing QA, VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a project to T227630: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience : Editing QA.
Fri, Aug 9, 4:48 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-Edit Cards
matmarex added a project to T227933: Context items: verify logging events are firing properly: Editing QA.
Fri, Aug 9, 4:48 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a project to T228240: Visual Editor chops long external links (e.g. to TABernacle tool): Editing QA.
Fri, Aug 9, 4:48 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), VisualEditor (Current work), VisualEditor-CopyPaste, VisualEditor-MediaWiki-Links
matmarex added a project to T229579: Use simplified mobilefrontend copyright messages on mobile VE: Editing QA.
Fri, Aug 9, 4:47 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T230154: VE edit cards broken by Minerva change from QA to Product owner review on the VisualEditor (Current work) board.

Several people from both teams checked this, and I just verified once again that the patch definitely fixes it.

Fri, Aug 9, 4:42 PM · Skipped QA, VisualEditor (Current work), Regression, MinervaNeue
matmarex updated subscribers of T229794: Special:MyPage dies with action=edit&redlink=1.

@mobrovac Do you or anyone else from the team have any idea why this bug results in a blank page instead of redirecting?

Fri, Aug 9, 4:38 PM · Core Platform Team Workboards (Clinic Duty Team), VisualEditor (Current work), MediaWiki-Special-pages, MediaWiki-General
matmarex edited projects for T223116: Replace MFShowFirstParagraphBeforeInfobox DOM transformation with a CSS solution, added: VisualEditor; removed VisualEditor (Current work).

T225936 has been fixed with a different approach, I don't think we're planning to work on this soon.

Fri, Aug 9, 3:51 PM · VisualEditor, VisualEditor-MediaWiki-Mobile, MobileFrontend
matmarex moved T225936: Editing lede section with an infobox takes you to the infobox, not the first paragraph from Code review to QA on the VisualEditor (Current work) board.
Fri, Aug 9, 3:50 PM · Editing QA, VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex merged task T230186: Visualeditor cite reverses author order scientific papers of Nature family into T223115: Update Zotero (outdated Nature translator reverses author list).
Fri, Aug 9, 3:40 PM · Citoid, VisualEditor
matmarex merged task T230131: Cite listing authors in wrong order into T223115: Update Zotero (outdated Nature translator reverses author list).
Fri, Aug 9, 3:40 PM · Citoid
matmarex merged tasks T230131: Cite listing authors in wrong order, T230186: Visualeditor cite reverses author order scientific papers of Nature family into T223115: Update Zotero (outdated Nature translator reverses author list).
Fri, Aug 9, 3:40 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Citoid
matmarex added a comment to T223115: Update Zotero (outdated Nature translator reverses author list).

Another example from T230131:

Fri, Aug 9, 3:39 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Citoid

Thu, Aug 8

matmarex moved T230154: VE edit cards broken by Minerva change from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Thu, Aug 8, 11:27 PM · Skipped QA, VisualEditor (Current work), Regression, MinervaNeue
matmarex edited projects for T230154: VE edit cards broken by Minerva change, added: VisualEditor (Current work); removed VisualEditor.
Thu, Aug 8, 11:27 PM · Skipped QA, VisualEditor (Current work), Regression, MinervaNeue
matmarex added a comment to T230154: VE edit cards broken by Minerva change.

To clarify, the problem wasn't with a stacking context, it was with using transform: …; to create it. The fix is to instead use position: relative; z-index: …;.

Thu, Aug 8, 11:25 PM · Skipped QA, VisualEditor (Current work), Regression, MinervaNeue
matmarex merged T229840: Sticky horizontal bar in user preferences does not move correctly in Firefox on macOS into T224984: sticky Save button bar on Special:Preferences is jumping in Firefox.
Thu, Aug 8, 11:20 PM · Browser-Support-Firefox, Upstream, MediaWiki-User-preferences
matmarex merged task T229840: Sticky horizontal bar in user preferences does not move correctly in Firefox on macOS into T224984: sticky Save button bar on Special:Preferences is jumping in Firefox.
Thu, Aug 8, 11:20 PM · MediaWiki-User-preferences
matmarex added a project to T229794: Special:MyPage dies with action=edit&redlink=1: Core Platform Team.

Just for a simpler test case, the problem also occurs on https://www.wikidata.org/wiki/Special:MyPage?action=edit&redlink=1

Thu, Aug 8, 9:35 PM · Core Platform Team Workboards (Clinic Duty Team), VisualEditor (Current work), MediaWiki-Special-pages, MediaWiki-General
matmarex claimed T229532: VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones.
Thu, Aug 8, 8:23 PM · VisualEditor (Current work), Patch-For-Review
matmarex added a comment to T227325: VE does not support wikitext in system messages.

I am planning to work on this but can't promise when. If you're able to, feel free to send in a patch.

Thu, Aug 8, 8:19 PM · I18n, VisualEditor
matmarex added a comment to T228897: Unhelpful error message: "Error, edit not saved." (mobile-frontend-editor-error).

Somewhat related: in T229532 we're changing VE to also use the errors from the API (rather than our custom handling in some cases), which should help validate this approach.

Thu, Aug 8, 8:17 PM · Readers-Web-Backlog (Tracking), VisualEditor, Voice & Tone, MobileFrontend
matmarex added a comment to T229270: 2017WTE mishandles wiki markup in the section heading.

Previously discussed in T162017, where we fixed handling of wiki markup for links, but not italic/bold. The italic/bold markup is much harder to handle, and we did not want to spend the effort into reimplementing parts of the wikitext parser just to create edit summaries.

Thu, Aug 8, 8:14 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T228165: Hide "options" bar under edit summary input when hidden.
Before limit reachedAfter limit reached
Desktop
Mobile
Thu, Aug 8, 8:02 PM · Editing Design, Editing QA, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T206762: Remove table.wikitable border property. from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Thu, Aug 8, 7:56 PM · Skipped QA, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), patch-welcome, MinervaNeue
matmarex added a comment to T230149: "Add media" in source editor stopped working.

@Kipod is this not the same issue as T230078?

Thu, Aug 8, 6:59 PM · MediaWiki-Page-editing
matmarex added a comment to T229654: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled..

I asked to pull this into "Investigating" because I was very confused by the description. I think it was missing a "not", please check if that's right. Also, the issue is not reproducible at the given URL anymore, because Citoid was apparently enabled on the wiki. Is there another example?

Thu, Aug 8, 6:57 PM · VisualEditor (Current work), good first bug, Citoid
matmarex updated the task description for T229654: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled..
Thu, Aug 8, 6:56 PM · VisualEditor (Current work), good first bug, Citoid
matmarex moved T228159: Improve loading progress appearance when loading MF, or switching from MF to VE from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Thu, Aug 8, 6:52 PM · Patch-For-Review, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
matmarex edited projects for T228159: Improve loading progress appearance when loading MF, or switching from MF to VE, added: VisualEditor (Current work); removed VisualEditor.
Thu, Aug 8, 6:52 PM · Patch-For-Review, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
matmarex added a comment to T230118: I cant add new column to table.

This is apparently caused by the incorrect "rowspan" attributes on the last table row. I fixed them in this edit (https://cs.wikipedia.org/w/index.php?title=Speciální_čarodějnické_díly&diff=17549851&oldid=17549088&diffmode=source) and the table now works fine in VE. Of course it should have worked anyway, but I don't think we'll have time to debug this soon.

Thu, Aug 8, 6:51 PM · VisualEditor
matmarex merged T230130: Editor close button should not use history.back() into T201852: [Bug] impossible to navigate back to article if start from hash fragment link.
Thu, Aug 8, 6:17 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue, Readers-Web-Backlog
matmarex merged task T230130: Editor close button should not use history.back() into T201852: [Bug] impossible to navigate back to article if start from hash fragment link.
Thu, Aug 8, 6:17 PM · MobileFrontend
matmarex merged task T230149: "Add media" in source editor stopped working into T230078: WikiEditor insert file dialog broken.
Thu, Aug 8, 6:08 PM · MediaWiki-Page-editing
matmarex merged T230149: "Add media" in source editor stopped working into T230078: WikiEditor insert file dialog broken.
Thu, Aug 8, 6:08 PM · Regression, WikiEditor
matmarex moved T114454: [RFC] Visual Templates: Authoring templates with Visual Editor from To Triage to External and Administrivia on the VisualEditor board.
Thu, Aug 8, 4:57 PM · VisualEditor, Wikimedia-Developer-Summit (2017), Wikidata, MediaWiki-extensions-Scribunto, Research-and-Data-VisualEditor , Wikimedia-Developer-Summit-2016
matmarex updated the task description for T229018: RESTBase should be able to store Parsoid/PHP contents in Cassandra alongwith Parsoid/JS contents.
Thu, Aug 8, 4:50 PM · Core Platform Team Workboards (Green), CPT Initiatives (Parsoid PHP (CDP2)), RESTBase, Parsoid-PHP
matmarex moved T229532: VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Thu, Aug 8, 4:44 PM · VisualEditor (Current work), Patch-For-Review
matmarex added a project to T229115: When a user wants to create an article, offer to publish it as a draft : MediaWiki-Page-editing.
Thu, Aug 8, 4:39 PM · MediaWiki-Page-editing, Growth-Team, VisualEditor
matmarex added a comment to T229654: "convert" button doesn't correctly detect if Citoid is enabled; we shouldn't offer convert button and message if automatic tab also isn't enabled..

That's a different issue, T229734

Thu, Aug 8, 4:11 PM · VisualEditor (Current work), good first bug, Citoid
matmarex merged task T230123: "Convert" no longer available for plain links into T229734: Convert button doesn't display since wmf.16.
Thu, Aug 8, 3:50 PM · VisualEditor
matmarex merged T230123: "Convert" no longer available for plain links into T229734: Convert button doesn't display since wmf.16.
Thu, Aug 8, 3:50 PM · Skipped QA, VisualEditor (Current work), Citoid
matmarex edited projects for T230131: Cite listing authors in wrong order, added: Citoid; removed Cite, VisualEditor.

Authors are returned in the wrong order by the API: https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/https%3A%2F%2Fwww.nature.com%2Farticles%2Fs41558-019-0527-4

Thu, Aug 8, 3:49 PM · Citoid

Wed, Aug 7

matmarex closed T228930: Unit tests failing: "TypeError: Cannot read property 'debounce' of undefined" as Resolved.
Wed, Aug 7, 7:09 PM · Language-Team, ci-test-error, ContentTranslation, Wikimedia-production-error (Shared Build Failure)
matmarex claimed T228159: Improve loading progress appearance when loading MF, or switching from MF to VE.
Wed, Aug 7, 6:36 PM · Patch-For-Review, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
matmarex moved T229900: Add a Link makes the pop-up and background screen jerk up and down ... when adding a wikilink in Visual Editor from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Wed, Aug 7, 3:49 PM · VisualEditor (Current work), Patch-For-Review
matmarex edited projects for T229900: Add a Link makes the pop-up and background screen jerk up and down ... when adding a wikilink in Visual Editor, added: VisualEditor (Current work); removed VisualEditor.
Wed, Aug 7, 3:48 PM · VisualEditor (Current work), Patch-For-Review
matmarex merged T230021: Adding a link, the list of link proposals in the dialog changes the viewport, making the page scroll up and down into T229900: Add a Link makes the pop-up and background screen jerk up and down ... when adding a wikilink in Visual Editor.
Wed, Aug 7, 2:57 PM · VisualEditor (Current work), Patch-For-Review
matmarex merged task T230021: Adding a link, the list of link proposals in the dialog changes the viewport, making the page scroll up and down into T229900: Add a Link makes the pop-up and background screen jerk up and down ... when adding a wikilink in Visual Editor.
Wed, Aug 7, 2:57 PM · VisualEditor
matmarex added a comment to T230021: Adding a link, the list of link proposals in the dialog changes the viewport, making the page scroll up and down.

This was also reported in T229900. @Aklapper Every one, but you have to have a relatively small screen (or browser window), or zoom in.

Wed, Aug 7, 2:57 PM · VisualEditor

Tue, Aug 6

matmarex added a comment to T229900: Add a Link makes the pop-up and background screen jerk up and down ... when adding a wikilink in Visual Editor.

Thank you for the detailed descriptions. I can reproduce the problems, and I recorded videos of them:

Tue, Aug 6, 7:02 PM · VisualEditor (Current work), Patch-For-Review
matmarex added a comment to T221328: [Epic] Mobile VE usability improvements.

I updated the remaining "In progress" items to "Done" (almost all of them, although some are still waiting for QA/product approval) or "Not done" (T218545). Also changed the "Stalled" ones to "Not done" since I don't see us actually working on those.

Tue, Aug 6, 5:50 PM · VisualEditor-Mobile-UsabilityImprovements, Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex updated the task description for T221328: [Epic] Mobile VE usability improvements.
Tue, Aug 6, 5:48 PM · VisualEditor-Mobile-UsabilityImprovements, Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex moved T215717: When section editing, do not build whole CE tree from Ready for Pick Up to Product owner review on the VisualEditor (Current work) board.

Well, we did this, didn't we?

Tue, Aug 6, 5:12 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), VisualEditor-MediaWiki-Mobile, Section Editing, VisualEditor (Current work), VisualEditor-ContentEditable

Mon, Aug 5

matmarex moved T229734: Convert button doesn't display since wmf.16 from Code review to QA on the VisualEditor (Current work) board.
Mon, Aug 5, 9:09 PM · Skipped QA, VisualEditor (Current work), Citoid
matmarex moved T229879: Keyboard and Edit Card show simultaneously when double-tapping link from Code review to QA on the VisualEditor (Current work) board.
Mon, Aug 5, 9:09 PM · Editing QA, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex moved T227630: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience from Code review to QA on the VisualEditor (Current work) board.
Mon, Aug 5, 9:06 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-Edit Cards
matmarex added a comment to T39744: jquery.ui.button: Color classes only implemented in jquery.ui vector theme.

jQuery UI is still in use, for example in the Wikibase "Add links" inteface:

Mon, Aug 5, 9:01 PM · Readers-Web-Backlog (Tracking), Vector, MediaWiki-Interface

Sun, Aug 4

matmarex created T229744: HTML entities in section headings show on a separate line in mobile visual editor.
Sun, Aug 4, 6:33 AM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Thu, Aug 1

matmarex added a parent task for T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari: T227271: Dialog footers should be moved up on iOS when navigation menu isn't visible..
Thu, Aug 1, 8:51 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, OOUI (OOUI-0.33.3), VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Browser-Support-Apple-Safari
matmarex added a subtask for T227271: Dialog footers should be moved up on iOS when navigation menu isn't visible.: T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari.
Thu, Aug 1, 8:51 PM · OOUI (OOUI-0.33.3)
matmarex claimed T227271: Dialog footers should be moved up on iOS when navigation menu isn't visible..
Thu, Aug 1, 8:50 PM · OOUI (OOUI-0.33.3)
matmarex added a comment to T228159: Improve loading progress appearance when loading MF, or switching from MF to VE.

Ed suggested only changing the mobile wikitext header size to match mobile visual, and leaving everything else unchanged. I guess that's also an option.

Thu, Aug 1, 8:50 PM · Patch-For-Review, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
matmarex added a comment to T229548: How to make it obvious that one has to scroll down in special:preferences?.

The bug in Firefox causing that has apparently just been fixed: T224984: sticky Save button bar on Special:Preferences is jumping in Firefox

Thu, Aug 1, 8:30 PM · OOUI, MediaWiki-User-preferences
matmarex closed T45519: Userprefs for edit options should be set by radiobuttons not checkboxes as Invalid.

There is no longer a "Enable dialogs for inserting links, tables and more" preference, it has been merged into "Enable enhanced editing toolbar" (https://gerrit.wikimedia.org/r/351681).

Thu, Aug 1, 8:27 PM · WikiEditor
matmarex edited projects for T45519: Userprefs for edit options should be set by radiobuttons not checkboxes, added: WikiEditor; removed MediaWiki-User-preferences, Browser-Support-Firefox.
Thu, Aug 1, 8:24 PM · WikiEditor
matmarex added a comment to T228224: "Merge Duplicates"/"Edit Parent Tasks"/"Edit Subtasks" dialogs: Clicking on a task title closes the dialog instead of selecting the task.

Thanks. So the patch fixes this by making the links not be real clickable links. I must say I kind of liked them (for opening in a new tab when I wasn't sure if I found the right task), but losing them is definitely the lesser evil for me.

Thu, Aug 1, 8:19 PM · Regression, Upstream, Phabricator (Upstream)
matmarex added a comment to T208984: Slovene projects: Alphabetical order in categories (collation).

Sorry, but I don't understand if you're just documenting this behavior, or saying that it's wrong and should be changed?

Thu, Aug 1, 8:16 PM · Patch-For-Review, Wikimedia-Site-requests