Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (47)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (496 w, 1 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Yesterday

matmarex claimed T358452: Vector 2022 dynamic table of contents broken on Parsoid.

I realized that the same problem is affecting my work on T13555. I hope you won't mind if I write the patch.

Sat, Apr 20, 1:10 AM · Patch-For-Review, Parsoid-Read-Views (Phase 1 - DiscussionTools support), Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Web Team Essential Work 2024, Desktop Improvements (Vector 2022)

Fri, Apr 19

matmarex created T363031: Update DiscussionTools integration tests' input files to reflect current wikitext parser output.
Fri, Apr 19, 11:32 PM · Technical-Debt, DiscussionTools
matmarex created T363030: Remove the mostly unused Parser.js from DiscussionTools.
Fri, Apr 19, 11:31 PM · Technical-Debt, DiscussionTools
matmarex merged T341933: Red link to a comment on Special:FindComment into T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Fri, Apr 19, 10:48 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
matmarex merged task T341933: Red link to a comment on Special:FindComment into T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Fri, Apr 19, 10:48 PM · Editing-team, DiscussionTools
matmarex edited subtasks for T34620: Support for root /Foo style pretty urls, added: T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well; removed: T346735: Reply tool doesn't show when the wiki not run on subFolder like /wiki/.
Fri, Apr 19, 10:43 PM · MediaWiki-General
matmarex removed a parent task for T346735: Reply tool doesn't show when the wiki not run on subFolder like /wiki/: T34620: Support for root /Foo style pretty urls.
Fri, Apr 19, 10:43 PM · Editing-team (Tracking), MW-1.39-release, MW-1.40-release, Technical-Debt, DiscussionTools
matmarex added a parent task for T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well: T34620: Support for root /Foo style pretty urls.
Fri, Apr 19, 10:43 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), DiscussionTools
matmarex merged T346735: Reply tool doesn't show when the wiki not run on subFolder like /wiki/ into T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well.
Fri, Apr 19, 10:43 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), DiscussionTools
matmarex merged task T346735: Reply tool doesn't show when the wiki not run on subFolder like /wiki/ into T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well.
Fri, Apr 19, 10:43 PM · Editing-team (Tracking), MW-1.39-release, MW-1.40-release, Technical-Debt, DiscussionTools
matmarex added a comment to T346735: Reply tool doesn't show when the wiki not run on subFolder like /wiki/.

I think this was fixed in 1.42 when the same problem was reported again in T358321.

Fri, Apr 19, 10:43 PM · Editing-team (Tracking), MW-1.39-release, MW-1.40-release, Technical-Debt, DiscussionTools

Thu, Apr 18

matmarex added a comment to T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..

Alright, I did that, hope it works.

Thu, Apr 18, 8:13 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, WMF-General-or-Unknown, Wikimedia-production-error
matmarex added a comment to T362747: [regression] Minerva: Cached HTML are not getting the responsive infobox styles.

I'm not sure, probably.

Thu, Apr 18, 7:31 PM · Patch-For-Review, Regression, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
matmarex added a comment to T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..

@Nikerabbit Can you have a look at https://translatewiki.net/wiki/FAQ#!!FUZZY!! and at https://translatewiki.net/wiki/Quick_guide_to_editing_translatewiki.net and update them to describe what !!FUZZY!! actually does these days (if it does anything at all)?

Thu, Apr 18, 6:34 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, WMF-General-or-Unknown, Wikimedia-production-error
matmarex added a comment to T362747: [regression] Minerva: Cached HTML are not getting the responsive infobox styles.

Desktop and mobile have different parser caches.

Thu, Apr 18, 6:33 PM · Patch-For-Review, Regression, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
matmarex added a comment to T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..


I'll go through them, following the example that @Dreamy_Jazz set (marking the translations with !!FUZZY!!, which should cause them to be removed from the .json files and suggest them for re-translation, and documenting in qqq that they need to be translated differently).

Thu, Apr 18, 6:20 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, WMF-General-or-Unknown, Wikimedia-production-error
matmarex added a comment to T362747: [regression] Minerva: Cached HTML are not getting the responsive infobox styles.

This problem happens because the styles were moved to a new ResourceLoader module (ext.wikimediamessages.styles), which was not loaded on these pages before. Styles are loaded using <link> tags present in the generated page HTML, which is cached for logged-out users, and so it will be missing on some pages for up to 14 days (https://wikitech.wikimedia.org/wiki/CDN#Retention). The actual CSS that is served by /w/load.php?...&modules=ext.wikimediamessages.styles correctly includes them, but that file is not loaded on these pages.

Thu, Apr 18, 5:58 PM · Patch-For-Review, Regression, Web-Team-Backlog (FY2023-24 Q4 Sprint 1), FY2023-24-WE 2.1 Typography and palette customizations, MinervaNeue
ihurbain awarded T355535: Clicking "Add reviewer" button on Gerrit focuses the comment field, not the reviewers field a Party Time token.
Thu, Apr 18, 6:57 AM · Gerrit (Gerrit 3.8)

Wed, Apr 17

matmarex claimed T362139: [Regression] FlaggedRevs: When undoing unrevieved edit, user is asked whether to review the resulting revision.

I'll be honest, I'm not sure how it's supposed to work. But I think I managed to restore how it worked.

Wed, Apr 17, 10:38 PM · Patch-For-Review, MediaWiki-extensions-FlaggedRevs
matmarex added a comment to T343471: Gerrit does not send email when a new patchset is created using the web interface.

Just tried it, still not working – I edited https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/774399, I have my preferences set up to receive emails about my own actions, but I did not get an email about the new patchset.

Wed, Apr 17, 8:23 PM · Upstream, Gerrit
matmarex placed T362817: PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue] up for grabs.
Wed, Apr 17, 8:01 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Growth-Team, GrowthExperiments, MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a comment to T362814: RuntimeException: The revision #1218831252 belongs to a deleted page. .

The error is not new, and has been thrown in the past for different revisions on different pages, it's only a recent spike that's all about revision #1218831252:

Wed, Apr 17, 7:36 PM · Editing-team, DiscussionTools, Wikimedia-production-error
matmarex claimed T362817: PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue].
Wed, Apr 17, 7:16 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Growth-Team, GrowthExperiments, MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a project to T362817: PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue]: GrowthExperiments.

I'm not familiar with the code, but it looks like we just need to replace PARAM_SOURCE => 'post' with PARAM_SOURCE => 'body' in a few places? I'll prepare a patch to do that.

Wed, Apr 17, 7:13 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Growth-Team, GrowthExperiments, MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a project to T362817: PHP Deprecated: The "post" source is deprecated, use "body" instead [Called from MediaWiki\Rest\Validator\ParamValidatorCallbacks::getValue]: MediaWiki-extensions-OAuth.
Wed, Apr 17, 6:58 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Growth-Team, GrowthExperiments, MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex awarded T355535: Clicking "Add reviewer" button on Gerrit focuses the comment field, not the reviewers field a Pterodactyl token.
Wed, Apr 17, 5:21 PM · Gerrit (Gerrit 3.8)

Tue, Apr 16

matmarex closed T357933: Header column cell in template overlaps into next row, pushing the column cells one off as Resolved.

Just for fun, I decided to fix the broken articles.

Tue, Apr 16, 11:33 PM · Local-Wiki-Template-And-Gadget-Issues, Content-Transform-Team, Wikipedia-iOS-App-Backlog, iOS-app-feature-wikitext-editor
matmarex edited projects for T362507: Special:TopicSubscriptions raises an exception when there are no topics, added: Editing QA; removed Patch-For-Review.
Tue, Apr 16, 8:03 PM · Editing QA, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), DiscussionTools, affects-translatewiki.net, Wikimedia-production-error
matmarex added a project to T362507: Special:TopicSubscriptions raises an exception when there are no topics: Editing-team (Kanban Board).
Tue, Apr 16, 8:01 PM · Editing QA, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), DiscussionTools, affects-translatewiki.net, Wikimedia-production-error
matmarex closed T362561: jquery.makeCollapsible functions incorrectly when re-used in other scripts as Resolved.
Tue, Apr 16, 5:24 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Reference Previews, MediaWiki-User-Interface (active libraries)
matmarex added a comment to T185674: Add a 'mw-collapsible-header' class to 'mw-collapsible' scheme.

By the way, when I looked at that template, I noticed that the page content shifts a little bit when the toggle is added by the script:

Screen Shot 2024-04-16 at 18.57.06.png (800×1 px, 123 KB)
Screen Shot 2024-04-16 at 18.57.40.png (800×1 px, 123 KB)

We usually manage to avoid that for collapsible elements, and I think we can extend that solution to handle the new placeholder toggles as well. Patch pending review: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1020287

Tue, Apr 16, 5:02 PM · MediaWiki-User-Interface (collapsible elements), JavaScript
matmarex closed T185674: Add a 'mw-collapsible-header' class to 'mw-collapsible' scheme as Resolved.
Tue, Apr 16, 4:53 PM · MediaWiki-User-Interface (collapsible elements), JavaScript
matmarex added a comment to T185674: Add a 'mw-collapsible-header' class to 'mw-collapsible' scheme.

Thanks for checking.

Tue, Apr 16, 4:52 PM · MediaWiki-User-Interface (collapsible elements), JavaScript
matmarex closed T185674: Add a 'mw-collapsible-header' class to 'mw-collapsible' scheme, a subtask of T167654: [Request] Feature parity between new collapsible buttons and NavFrames, as Resolved.
Tue, Apr 16, 4:52 PM · MediaWiki-User-Interface, UI-Standardization

Mon, Apr 15

matmarex added a comment to T362496: ‘Start a discussion’ affordance should also be on existing talk pages that have no discussions.

Broken by rMW6d80f9e793ad: In OutputPage::addParserOutput, getText() before processing metadata :( (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/970901)

Mon, Apr 15, 10:29 PM · Regression, DiscussionTools
matmarex added a project to T362496: ‘Start a discussion’ affordance should also be on existing talk pages that have no discussions: Regression.

This used to work, I remember working on this feature… some years ago :) T312599: Show the new topic empty state experience on pages which have templates, but no discussions

Mon, Apr 15, 10:08 PM · Regression, DiscussionTools
matmarex updated subscribers of T185674: Add a 'mw-collapsible-header' class to 'mw-collapsible' scheme.

I found this task by accident when looking for something else, and I realized that a very similar feature has been implemented last year in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/897905 by Lucas. Rather than marking some element as a "header", you can mark exactly where you want the toggle to be placed using <div class="mw-collapsible-toggle-placeholder"></div>. I think that would work for all of the listed use cases.

Mon, Apr 15, 8:05 PM · MediaWiki-User-Interface (collapsible elements), JavaScript
matmarex added a comment to T361253: Unexpected section edit links appear on some pages with Parsoid.

(There's also a difference in rendering with the heading underline, since the TemplateStyles designed for old parser output don't apply, that will probably need to be fixed on-wiki.)

I'm not sure if anything was done on-wiki but the underline is no longer there. Could have been due to the wrong class being added before.

Mon, Apr 15, 7:17 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
matmarex removed a project from T361253: Unexpected section edit links appear on some pages with Parsoid: Patch-For-Review.
Mon, Apr 15, 7:16 PM · Parsoid-Read-Views (Phase 1 - DiscussionTools support), Content-Transform-Team-WIP, Parsoid
matmarex claimed T362507: Special:TopicSubscriptions raises an exception when there are no topics.

Thanks for reporting and investigating.

Mon, Apr 15, 7:00 PM · Editing QA, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), DiscussionTools, affects-translatewiki.net, Wikimedia-production-error
matmarex closed T251449: wfDeprecated default behaviour in tests is different from production as Declined.

Per @daniel's comment, this doesn't seem to be worth changing.

Mon, Apr 15, 6:55 PM · MediaWiki-Core-Tests
matmarex added a comment to T238885: AMC mobile history page layout messed up (FlaggedRevs).

As @Samwalton9-WMF noted in T238885#9658700, the rendering has significantly improved some time ago.

Mon, Apr 15, 4:57 PM · Moderator-Tools-Team, MediaWiki-extensions-FlaggedRevs, Advanced Mobile Contributions

Sun, Apr 14

matmarex added a comment to T356157: Unable to fetch Parsoid HTML.

There is a corresponding spike in error logs:

image.png (1×3 px, 168 KB)

Hopefully we will be able to investigate the problem properly now.

Sun, Apr 14, 6:00 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Content-Transform-Team, Essential-Work, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
matmarex closed T270215: Popup not necessarily positioned correctly when tabbing through links as Resolved.
Sun, Apr 14, 2:43 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 1), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Page-Previews

Fri, Apr 12

matmarex added a comment to T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..

I think I've done them all. (It got a bit tiresome near the end, and I didn't add qqq documentation to every message – it didn't seem worth it since they didn't look ambiguous to me, I think some translations were just copied without anyone reading them.)

Fri, Apr 12, 7:48 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, WMF-General-or-Unknown, Wikimedia-production-error
matmarex added a comment to T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..

I went through the groups, made some edits: https://translatewiki.net/wiki/Special:Contributions/Matma_Rex. Messages requiring action on-wiki:

Fri, Apr 12, 7:19 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, WMF-General-or-Unknown, Wikimedia-production-error
matmarex added a comment to T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log..

I don't think hunting down every single translation key problem makes sense…

Fri, Apr 12, 6:36 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, WMF-General-or-Unknown, Wikimedia-production-error
matmarex closed T331474: DiscussionTools is adding a class to h2 elements and that breaks custom css as Resolved.

Since T353489, the wrappers won't be added around <h2> and other heading tags that have any attributes, which actually fixes the original issue in this task as well. You can change the div to h2 now if you wish.

Fri, Apr 12, 4:48 PM · DiscussionTools
matmarex added a project to T362378: Lost work bug involving copy/pasting and ediitng an existing image gallery: Parsoid.
Fri, Apr 12, 2:51 PM · Parsoid, VisualEditor

Thu, Apr 11

matmarex added a project to T362359: Some visual diffs mark every template on the page with "Template parameters changed": Parsoid.

Maybe related to changes from T214241: data-mw info is clobbered by template annotations?

Thu, Apr 11, 8:38 PM · Parsoid, VisualEditor-MediaWiki, VisualEditor-VisualDiffs, VisualEditor
matmarex renamed T362359: Some visual diffs mark every template on the page with "Template parameters changed" from Specific visual diff shows every template on the page as changed to Some visual diffs mark every template on the page with "Template parameters changed".
Thu, Apr 11, 8:35 PM · Parsoid, VisualEditor-MediaWiki, VisualEditor-VisualDiffs, VisualEditor
matmarex added a comment to T362359: Some visual diffs mark every template on the page with "Template parameters changed".

I just saw a report that this also happens in visual diffs in the 2017 wikitext editor: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#"Template_parameters_changed"_appearing_on_every_template_on_page_when_"review_your_changes"_clicked

SPObQkL.png (1×908 px, 122 KB)

Thu, Apr 11, 8:35 PM · Parsoid, VisualEditor-MediaWiki, VisualEditor-VisualDiffs, VisualEditor
matmarex created T362359: Some visual diffs mark every template on the page with "Template parameters changed".
Thu, Apr 11, 8:30 PM · Parsoid, VisualEditor-MediaWiki, VisualEditor-VisualDiffs, VisualEditor
matmarex added a comment to T163492: With $wgReadOnly set and when $wgSessionCacheType = CACHE_DB, ApiQueryTokens will return invalid tokens.

I tried to reproduce (using this code in the browser console: await (new mw.Api()).edit('Scratch', (x) => x.content + 'test')) and I reproduced and got a badtoken error once, then I started debugging it to see why I'm getting different results than you, and from that point on I could no longer reproduce :)

Thu, Apr 11, 8:23 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff, MediaWiki-Core-AuthManager

Wed, Apr 10

matmarex added a comment to T356157: Unable to fetch Parsoid HTML.

Logging code is on all servers now, but I'm not seeing anything in the HtmlOutputRendererHelper channel so far.

Wed, Apr 10, 2:25 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Content-Transform-Team, Essential-Work, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
matmarex added a comment to T356157: Unable to fetch Parsoid HTML.

This might have happened again in T362210 (which also went away on its own), although the error message this time was "Unable to stash Parsoid HTML".

Wed, Apr 10, 2:23 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Content-Transform-Team, Essential-Work, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
matmarex added a comment to T362210: Error: Unable to stash Parsoid HTML when editing pages on MediaWiki.org.

This reminds me of T356157 – a very similar transient but reoccurring error.

Wed, Apr 10, 2:22 PM · MediaWiki-Platform-Team, Parsoid, VisualEditor

Tue, Apr 9

matmarex added a comment to T346984: Chaining abortable API promises is very unpleasant – introduce abort signals to mw.Api.

Since a few of you seem to be interested, an update: I've got it working, and I've updated some code in extensions to demonstrate the improvements: https://gerrit.wikimedia.org/r/q/topic:AbortController. However, I'm having trouble figuring out the browser compatibility (there's conflicting information on the internet about which Safari versions actually support this), and also running into a mysterious test failure I can't reproduce locally. See comments on the patch for details. If anyone would like to help, it'd be appreciated.

Tue, Apr 9, 11:53 PM · MediaWiki CodeJam Dec 2023, Patch-For-Review, MediaWiki-General
matmarex closed T67572: "Advertise" does not tell others that I'm reviewing that page; clicking "de-advertise" does not change display as Declined.

That feature was removed in rEFLRb7dba6952ee4: Remove "under review" advertisement functionality.

Tue, Apr 9, 3:59 PM · MediaWiki-extensions-FlaggedRevs
matmarex closed T90329: FlaggedRevs uses synchronous XMLHttpRequests as Resolved.

That feature was removed in rEFLRb7dba6952ee4: Remove "under review" advertisement functionality.

Tue, Apr 9, 3:58 PM · Technical-Debt, MediaWiki-extensions-FlaggedRevs, JavaScript
matmarex closed T90329: FlaggedRevs uses synchronous XMLHttpRequests, a subtask of T90327: Remove use of synchronous XMLHttpRequest (deprecated) , as Resolved.
Tue, Apr 9, 3:57 PM · Technical-Debt, Goal, JavaScript, WMF-General-or-Unknown
matmarex closed T358250: Full screen dialogs are truncated by scrollbar gutter as Resolved.
Tue, Apr 9, 3:52 PM · Upstream, Browser-Support-Google-Chrome, OOUI, Regression
matmarex closed T185396: Replace jsduck with JSDoc3 in OOUI as Resolved.
Tue, Apr 9, 3:49 PM · OOUI, Documentation
matmarex closed T185396: Replace jsduck with JSDoc3 in OOUI, a subtask of T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases, as Resolved.
Tue, Apr 9, 3:47 PM · MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Tech-Docs-Team, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, Editing-team (Tracking), Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
matmarex closed T185396: Replace jsduck with JSDoc3 in OOUI, a subtask of T250843: Replace jsduck with JSDoc3 in VisualEditor, as Resolved.
Tue, Apr 9, 3:47 PM · Patch-For-Review, Editing-team (Tracking), VisualEditor, Documentation
matmarex closed T330424: MenuTagMultiselectWidget unexpectedly removes card if invalid input is entered after the field loses focus as Resolved.

I assume that fixed it.

Tue, Apr 9, 3:46 PM · OOUI
matmarex removed a project from T294935: OOui DraggableGroupWidget doesn't work on touch devices: Patch-For-Review.
Tue, Apr 9, 3:46 PM · User-Michael, Mobile, OOUI
matmarex closed T294935: OOui DraggableGroupWidget doesn't work on touch devices as Resolved.

I assume that fixed it.

Tue, Apr 9, 3:46 PM · User-Michael, Mobile, OOUI
matmarex added a comment to T362139: [Regression] FlaggedRevs: When undoing unrevieved edit, user is asked whether to review the resulting revision.

@Wargo To clarify, you mean that getOldID() only checks whether we're viewing a page with the &oldid=… URL parameter, and we should also check for the &undoafter=…&undo=… parameters? That would make sense to me. (There's also a comment in that code that says "check not shown when editing old revisions, which [would be] confusing", and preparing a revert of the latest revision is a lot like editing the previous revision.)

Tue, Apr 9, 3:35 PM · Patch-For-Review, MediaWiki-extensions-FlaggedRevs

Mon, Apr 8

matmarex added a comment to T326060: Special:MediaStatistics doesn't have anchor tags for its headings.

@matmarex how can I populate my local database with existing data to test out if my fix is working or not?

Mon, Apr 8, 10:49 PM · Patch-For-Review, good first task, MediaWiki-Special-pages
matmarex closed T353859: Parsoid errors not fully propagated to VisualEditor errors as Resolved.

I think this is mostly resolved by rMW34e68c2ef1dc: REST: Log parsoid errors.

Mon, Apr 8, 10:00 PM · MediaWiki-REST-API, Parsoid (Tracking), VisualEditor
matmarex moved T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04 from Not ready to announce to In current Tech/News draft on the User-notice board.

Resolved now.

Mon, Apr 8, 8:45 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Growth-Team, Regression, MediaWiki-Recent-changes
matmarex moved T361940: Imports, moves and protections are not autoreviewed from Not ready to announce to In current Tech/News draft on the User-notice board.

Resolved now.

Mon, Apr 8, 8:45 PM · User-notice, Regression, MediaWiki-extensions-FlaggedRevs
hgzh awarded T361940: Imports, moves and protections are not autoreviewed a Like token.
Mon, Apr 8, 8:43 PM · User-notice, Regression, MediaWiki-extensions-FlaggedRevs
matmarex closed T361960: The page gets unreviewed when moved to a new address as Resolved.
Mon, Apr 8, 8:42 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-extensions-FlaggedRevs
matmarex closed T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04 as Resolved.
Mon, Apr 8, 8:41 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Growth-Team, Regression, MediaWiki-Recent-changes
matmarex merged T361960: The page gets unreviewed when moved to a new address into T361940: Imports, moves and protections are not autoreviewed.
Mon, Apr 8, 8:41 PM · User-notice, Regression, MediaWiki-extensions-FlaggedRevs
matmarex merged task T361960: The page gets unreviewed when moved to a new address into T361940: Imports, moves and protections are not autoreviewed.
Mon, Apr 8, 8:41 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-extensions-FlaggedRevs
matmarex closed T361940: Imports, moves and protections are not autoreviewed as Resolved.
Mon, Apr 8, 8:40 PM · User-notice, Regression, MediaWiki-extensions-FlaggedRevs
matmarex closed T359409: Need a soft dependency mechanism for QUnitTestModules? as Declined.

I assume that there's nothing else to do here, but feel free to reopen if you disagree. It seems to me that adding a helper mechanism for soft dependencies is not needed right now, given that it's easy enough to implement already, as discussed above.

Mon, Apr 8, 5:39 PM · WMDE-TechWish-Sprint-2024-03-13, MediaWiki-ResourceLoader, Browser-Tests, WMDE-TechWish-Sprint-2024-02-28, MediaWiki-Platform-Team, Page-Previews
matmarex closed T359409: Need a soft dependency mechanism for QUnitTestModules?, a subtask of T355194: Move the reference previews code to Cite extension, as Declined.
Mon, Apr 8, 5:39 PM · WMDE-TechWish-Sprint-2024-04-12, WMDE-TechWish-Sprint-2024-03-27, MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Epic, WMDE-TechWish-Sprint-2024-03-13, WMDE-TechWish-Sprint-2024-02-28, WMDE-TechWish-Sprint-2024-02-15, WMDE-TechWish-Sprint-2024-01-31, Reference Previews, WMDE-TechWish-Sprint-2024-01-17, Cite, Page-Previews
matmarex closed T361036: ?safemode=1 intentionally blocks JavaScript when it loads content from the wiki as Invalid.

Indeed, you're all correct, this is the expected behavior. And @Soda's explanation of the specific way it happens is right too.

Mon, Apr 8, 5:38 PM · PageTriage

Sun, Apr 7

matmarex closed T362013: Reverted and Manual Revert Tags malfunction as Invalid.

It also looks correct to me. The "manual revert" tag will always be added when an edit causes the page to have the same content as some older revision, even if you did not intend to make a revert, but just happened to make changes that cancel out previous edits. And when that tag is applied, the "reverted" tag will be applied to all intervening revisions, except for null revisions corresponding to log actions like page moves, because the page move itself is not being reverted (see T265312 for discussion about that behavior).

Sun, Apr 7, 8:09 PM · MediaWiki-General

Fri, Apr 5

matmarex added a project to T361940: Imports, moves and protections are not autoreviewed: User-notice.
Fri, Apr 5, 10:01 PM · User-notice, Regression, MediaWiki-extensions-FlaggedRevs
matmarex claimed T361960: The page gets unreviewed when moved to a new address.

Yes, probably my fault, that change broke a few other things :(

Fri, Apr 5, 9:53 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-extensions-FlaggedRevs
matmarex renamed T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04 from "Reverted" tag no longer applied in main namespace on German Wikipedia since 2024-04-04 to "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04.
Fri, Apr 5, 9:05 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Growth-Team, Regression, MediaWiki-Recent-changes
matmarex added a comment to T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04.

I'll backport the fix on Monday, I understand that it's a bit annoying for recent changes patrollers, but I don't think that this is critical enough to do right before the weekend.

Fri, Apr 5, 9:02 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Growth-Team, Regression, MediaWiki-Recent-changes
matmarex added a comment to T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04.

Indeed. FlaggedRevs prevents the mw-reverted from being applied to reverted edits if the revert is not autoreviewed, and later applies it manually if the revert gets reviewed (I didn't know about this, it's documented here: https://www.mediawiki.org/wiki/Manual:Reverts#FlaggedRevs). My commit https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1015175 changed the order in which things happen, so that when it checks if it should prevent the tag, the edit was not autoreviewed yet, so it always prevented it from applying. I'll submit a revert, and document the code better so that no one repeats my mistake.

Fri, Apr 5, 8:16 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Growth-Team, Regression, MediaWiki-Recent-changes
matmarex closed T356468: Convert LogFormatter to use dependency injection as Resolved.
Fri, Apr 5, 7:01 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MediaWiki-Platform-Team, MediaWiki-Logevents, Dependency injection
matmarex removed a project from T356468: Convert LogFormatter to use dependency injection: Patch-For-Review.
Fri, Apr 5, 7:00 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MediaWiki-Platform-Team, MediaWiki-Logevents, Dependency injection
matmarex renamed T361904: TypeError: messages.filter is not a function (problem with MediaWiki:Gadget-SousPages) from TypeError: messages.filter is not a function (possible incompatibility issue between MediaWiki:Gadget-SousPages and DiscussionTools)? to TypeError: messages.filter is not a function (problem with MediaWiki:Gadget-SousPages).
Fri, Apr 5, 6:03 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Local-Wiki-Template-And-Gadget-Issues, Wikimedia-production-error
matmarex removed a project from T361904: TypeError: messages.filter is not a function (problem with MediaWiki:Gadget-SousPages): DiscussionTools.
Fri, Apr 5, 6:03 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Local-Wiki-Template-And-Gadget-Issues, Wikimedia-production-error
matmarex claimed T361904: TypeError: messages.filter is not a function (problem with MediaWiki:Gadget-SousPages).

Yeah, that's a bit of a footgun. We should make loadMessagesIfMissing() accept that too.

Fri, Apr 5, 5:59 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Local-Wiki-Template-And-Gadget-Issues, Wikimedia-production-error
matmarex claimed T361940: Imports, moves and protections are not autoreviewed.

Could be caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1015175.

Fri, Apr 5, 5:29 PM · User-notice, Regression, MediaWiki-extensions-FlaggedRevs
matmarex claimed T361918: "Reverted" tag no longer applied in reviewable namespaces on wikis with FlaggedRevs since 2024-04-04.

Hmm, I don't see how the recent changes to FlaggedRevs could have affected how the mw-reverted tag is applied, since it's a core feature. I will try to reproduce and debug this, hopefully we can fix it on Monday.

Fri, Apr 5, 5:29 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Growth-Team, Regression, MediaWiki-Recent-changes
matmarex added a comment to T326365: Section titles containing a question mark should be URL encoded in table of contents links.

See also T50940 for the same problem, but with page titles.

Fri, Apr 5, 5:18 PM · good first task, MediaWiki-Parser, Parsoid
matmarex renamed T50940: Punctuation like ".", "?" and "!" at the end of page title in links not interpreted as part of the URL by various applications from Links in emails: Dot (.), "?" and "!" at end of username or title not interpreted as part of the URL by email clients to Punctuation like ".", "?" and "!" at the end of page title in links not interpreted as part of the URL by various applications.
Fri, Apr 5, 5:17 PM · MediaWiki-Email
matmarex merged tasks T257966: URL shall be terminated by %2E or _ if page name ends with dot, T276173: Unable to share link to article via Apple Message if title ends with exclamation mark into T50940: Punctuation like ".", "?" and "!" at the end of page title in links not interpreted as part of the URL by various applications.
Fri, Apr 5, 5:16 PM · MediaWiki-Email
matmarex merged task T276173: Unable to share link to article via Apple Message if title ends with exclamation mark into T50940: Punctuation like ".", "?" and "!" at the end of page title in links not interpreted as part of the URL by various applications.
Fri, Apr 5, 5:15 PM · Browser-Support-Apple-Safari, MediaWiki-General
matmarex merged task T257966: URL shall be terminated by %2E or _ if page name ends with dot into T50940: Punctuation like ".", "?" and "!" at the end of page title in links not interpreted as part of the URL by various applications.
Fri, Apr 5, 5:15 PM · MediaWiki-General