Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (313 w, 5 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Yesterday

matmarex added a comment to T130496: API sandbox's descriptions are positioned and styled poorly.

The spacing with that patch is weird. The help labels almost look like headings for the field below them.

Wed, Oct 21, 11:59 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MediaWiki-Interface, MediaWiki-API, Design
matmarex updated subscribers of T266195: Reply links disappear after replying, and reply is not highlighted, when replying to a transcluded comment.

This is because when replying to transcluded comments, we update the page after saving using action=parse output, and it does not include our server-generated reply links. The exception occurs because we can't find the reply to highlight.

Wed, Oct 21, 11:02 PM · DiscussionTools
matmarex updated the task description for T266195: Reply links disappear after replying, and reply is not highlighted, when replying to a transcluded comment.
Wed, Oct 21, 11:00 PM · DiscussionTools
matmarex created T266195: Reply links disappear after replying, and reply is not highlighted, when replying to a transcluded comment.
Wed, Oct 21, 10:57 PM · DiscussionTools
matmarex added a subtask for T262408: [TRACKING] Selser issues on talk pages: T266140: HTML entity replaced by the Unicode character in an edit.
Wed, Oct 21, 2:32 PM · Parsing-Active-Work, Patch-For-Review, Editing-team (Tracking), DiscussionTools, Parsoid
matmarex added a parent task for T266140: HTML entity replaced by the Unicode character in an edit: T262408: [TRACKING] Selser issues on talk pages.
Wed, Oct 21, 2:32 PM · Parsoid, DiscussionTools
matmarex created T266140: HTML entity replaced by the Unicode character in an edit.
Wed, Oct 21, 2:31 PM · Parsoid, DiscussionTools
matmarex added a comment to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.

Potentially similar problem on pt.wp: https://pt.wikipedia.org/?diff=59606108

Wed, Oct 21, 2:29 PM · Patch-For-Review, Parsoid, DiscussionTools

Tue, Oct 20

matmarex added a comment to T262835: After inserting wiki markup via Charinsert, cursor position always goes to beginning of line when syntax highlighting is enabled.

Is it possible for you to test a group of patches at the same time, instead of one by one? In the affirmative case, you can have a dichotomy approach to shorten the time to find the wrong patch.

Tue, Oct 20, 11:35 AM · Browser-Support-Google-Chrome, Community-Tech, WikiEditor
matmarex added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

which means that if I had defined these parameters (I didn't, because I don't want to actually delete any pages and I'm not sure if the API sandbox actually executes the requests) the unregistered user could proceed with the page deletion. Still there in no link for page deletion on the website, like it appears when I'm logged in, but it turns out the deletion could be completed through the API!

Tue, Oct 20, 10:00 AM · Editing-team (Tracking), Parsoid, MW-1.35-release, VisualEditor
matmarex added a comment to T262835: After inserting wiki markup via Charinsert, cursor position always goes to beginning of line when syntax highlighting is enabled.

There have been no recent changes to CharInsert, it's a very dead project (or, you could say, very feature-complete).

Tue, Oct 20, 5:56 AM · Browser-Support-Google-Chrome, Community-Tech, WikiEditor
matmarex updated subscribers of T262835: After inserting wiki markup via Charinsert, cursor position always goes to beginning of line when syntax highlighting is enabled.

I'll spare everyone else the notifications… In the future, you can probably just disturb @ppelberg and he'll disturb one of us ;)

Tue, Oct 20, 5:37 AM · Browser-Support-Google-Chrome, Community-Tech, WikiEditor
matmarex added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

Well, during MediaWiki's installation if the choice to allow only registered users to edit pages is made, then automatically the installer sets:

$wgGroupPermissions['*']['edit'] = false;

That's the only line of code used by the installer and it achieves the desired result, without using the second line you suggested. That raises the question to which groups ' * ' actually corresponds to.

Tue, Oct 20, 5:08 AM · Editing-team (Tracking), Parsoid, MW-1.35-release, VisualEditor
matmarex added a comment to T260642: Regression: Collapsible forms stopped working on Mobile special page.

What do you mean by "there's more"? There is certainly some root problem in jquery.makeCollapsible or jquery.tablesorter, which could presumably be debugged and resolved, but I did not have time to debug this further, and just making them run in this order seemed reliable enough (see T64878).

Tue, Oct 20, 4:55 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Readers-Web-Backlog (Kanbanana-FY-2020-21), Advanced Mobile Contributions, Regression, MinervaNeue
matmarex closed T265134: "wikitable sortable mw-collapsible mw-collapsed" is no longer displaying sortable headings when there are two tr lines with th elements as Resolved.

Patch will be deployed this week, 20-22 October, per the usual schedule.

Tue, Oct 20, 4:49 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Regression, MediaWiki-Interface (jQuery-Tablesorter)
matmarex created T265964: Handling for "fake headings" using ; syntax (<dt> tags).
Tue, Oct 20, 12:14 AM · Editing-team (FY2020-21 Kanban Board), DiscussionTools

Mon, Oct 19

matmarex added a comment to T265947: Unify blockquote treatment in DSG, MinervaNeue and Vector.

I'd like to use this occasion to complain about the blockquote styling in Minerva (and the guide) :)

Mon, Oct 19, 10:40 PM · Patch-For-Review, Design, Growth-Team, StructuredDiscussions, MinervaNeue (Desktop), Vector, Wikimedia Design Style Guide
matmarex added a comment to T265446: Make config change to enable Reply Tool as Beta Feature on fi.wiki.

When we do our next deploy, can we merge this no-op config cleanup left over from wmf7: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/620958

Mon, Oct 19, 10:30 PM · Editing-team (FY2020-21 Kanban Board), Beta-Feature, DiscussionTools, OWC2020
Volker_E awarded T265650: Enable strict units in LESS a Like token.
Mon, Oct 19, 10:13 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex moved T265499: Allow users to turn on DiscussionTools via some JavaScript hack from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Mon, Oct 19, 9:54 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T263255: Add option to hide (semi-)page protection editnotices in VisualEditor from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Mon, Oct 19, 8:18 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Skipped QA, Editing-team (FY2020-21 Kanban Board), UX-Debt, VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex moved T265798: Empty edit notices still shown if message is deliberately blanked from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Mon, Oct 19, 8:18 PM · Skipped QA, MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex added a project to T265798: Empty edit notices still shown if message is deliberately blanked: Editing-team (FY2020-21 Kanban Board).
Mon, Oct 19, 7:41 PM · Skipped QA, MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex edited projects for T263255: Add option to hide (semi-)page protection editnotices in VisualEditor, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team.
Mon, Oct 19, 7:40 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Skipped QA, Editing-team (FY2020-21 Kanban Board), UX-Debt, VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex added a comment to T263255: Add option to hide (semi-)page protection editnotices in VisualEditor.

Thank you for the patch!

Mon, Oct 19, 7:40 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Skipped QA, Editing-team (FY2020-21 Kanban Board), UX-Debt, VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex added a comment to T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset.

Deployed to Wikimedia wikis now.

Mon, Oct 19, 6:28 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MobileFrontend
matmarex added a project to T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset: User-notice.
Mon, Oct 19, 3:07 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MobileFrontend
matmarex added a comment to T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset.

I scheduled the backport for deployment later today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20201019T1800

Mon, Oct 19, 3:07 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MobileFrontend

Sat, Oct 17

matmarex added a comment to T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset.

Also, to be clear, this problem only affects the mobile site – you can switch to the desktop site temporarily to use your watchlist (although I understand this is an annoyance).

Sat, Oct 17, 5:59 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MobileFrontend
matmarex updated the task description for T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.
Sat, Oct 17, 5:19 PM · Patch-For-Review, Parsoid, DiscussionTools
matmarex added a comment to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.

Potentially similar problem on pt.wp: https://pt.wikipedia.org/?diff=59606108

Sat, Oct 17, 5:17 PM · Patch-For-Review, Parsoid, DiscussionTools
Aklapper awarded T265650: Enable strict units in LESS a Like token.
Sat, Oct 17, 12:30 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General

Fri, Oct 16

matmarex added a comment to T265650: Enable strict units in LESS.

I think most of the above are caused by a single common pattern. For example, in Kartographer, this line causes it: padding-top: 4 / 14em;.

Fri, Oct 16, 11:36 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex added a comment to T265650: Enable strict units in LESS.

That makes core tests pass (and Vector – apparently it wasn't fine, no idea how I missed it).

Fri, Oct 16, 11:25 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex added a comment to T264693: Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis.
  1. There are some comments which had Reply links missing. I am assuming that's because they don't have a signature that contains a link to a user or talk page or they are newsletters. Or is it because the timestamp is appearing on a new line? @matmarex: Can you confirm this behavior?

Here are some screenshots showing such cases:

Page: https://bh.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF%E0%A4%AA%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE:%E0%A4%9A%E0%A5%8C%E0%A4%AA%E0%A4%BE%E0%A4%B2

Fri, Oct 16, 10:55 PM · Verified, Turkish-Sites, Tamil-Sites, Hindi-Sites, Spanish-Sites, Editing-team (FY2020-21 Kanban Board), Beta-Feature, DiscussionTools, OWC2020
matmarex added a comment to T265332: Incorrect display of full-width punctuation on 2017 Wikitext Editor.

It should be using the same font as the old wikitext editor. You can set it in preferences: Preferences → Editing → Edit area font style on en.wp, 参数设置 → 编辑 → 编辑区字体样式 on zh.wp.

Fri, Oct 16, 10:10 PM · Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
matmarex closed T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset as Resolved.

This will be deployed next week, 20-22 October, per the usual schedule.

Fri, Oct 16, 10:01 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MobileFrontend
matmarex closed T265571: MediaWiki 1.36/wmf.13 needlessly HTML encodes ASCII characters in DjVu text layer as Resolved.
Fri, Oct 16, 8:44 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), ProofreadPage, Editing-team, MediaWiki-DjVu, Wikisource
matmarex added a comment to T265650: Enable strict units in LESS.

Apparently there is a LessFileCompilationTest, which will fail if the LESS compilation fails for any module, so you just need to run the MediaWiki unit tests for your skin/extension and check the results. This makes it much easier to find the problematic code.

Fri, Oct 16, 8:10 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
Jdforrester-WMF awarded T265650: Enable strict units in LESS a Like token.
Fri, Oct 16, 7:15 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex added a comment to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.

Try php bin/parse.php --domain pl.wikipedia.org --pageName 'Wikipedia:Poczekalnia/Zgłoszenia' --wrapSections < /dev/null and again without the --wrapSections option if you want to check this locally.

Fri, Oct 16, 6:11 PM · Patch-For-Review, Parsoid, DiscussionTools
matmarex added a comment to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.

And some HTML snippets from that. Several things look wrong here. I don't know enough about Parsoid to guess the issue, but it might offer some hints for you:

Fri, Oct 16, 5:40 PM · Patch-For-Review, Parsoid, DiscussionTools
matmarex added a comment to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.

The affected transclusion is from https://pl.wikipedia.org/wiki/Wikipedia:Poczekalnia/biografie. I looked there, and a single section on that page is also not marked correctly as a transclusion:

Fri, Oct 16, 5:37 PM · Patch-For-Review, Parsoid, DiscussionTools
matmarex added a comment to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.

I made edits on the subpages to fix the messed up heading structure on that page, but it did not affect this problem ( 1   2   3 ). Might make it easier to debug though.

Fri, Oct 16, 5:35 PM · Patch-For-Review, Parsoid, DiscussionTools
matmarex added a project to T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated: Parsoid.

Parsoid is incorrectly marking up the transclusions: https://pl.wikipedia.org/api/rest_v1/page/html/Wikipedia%3APoczekalnia%2FZgłoszenia?redirect=false&stash=true

Fri, Oct 16, 4:18 PM · Patch-For-Review, Parsoid, DiscussionTools
matmarex created T265737: Reply posted on wrong page on pl.wp, content from transcluded subpages duplicated.
Fri, Oct 16, 4:07 PM · Patch-For-Review, Parsoid, DiscussionTools

Thu, Oct 15

matmarex added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

You can use the 'user' group to assign permissions to logged in users.

I have already tried giving the appropriate permissions to the "user" group:

$wgRevokePermissions['*']['writeapi'] = true;
$wgGroupPermissions['user']['writeapi'] = true;

I also tried:

$wgRevokePermissions['*']['writeapi'] = true;
$wgGroupPermissions['*']['writeapi'] = true;

Both versions give a 403 error... I guess this approach does not work and it turns out that it's not the selected group of $wgGroupPermissions that doesn't solve the problem in the first version of the code.

Thu, Oct 15, 10:39 PM · Editing-team (Tracking), Parsoid, MW-1.35-release, VisualEditor
matmarex claimed T265654: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset.

Special:MobileDiff is just the worst :(

Thu, Oct 15, 10:02 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-notice, Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MobileFrontend
matmarex added a comment to T265657: Link text of the Wikipedia sidebar menu bigger than normal.

This probably is (or was) the same kind of issue as T265543.

Thu, Oct 15, 9:44 PM · Vector
matmarex added a comment to T265043: "Error contacting the Parsoid/RESTBase server (HTTP 403)" when trying to edit an existing page with VisualEditor.

OK. I found it.

I had set

$wgRevokePermissions['*']['writeapi'] = true;

for security reasons.

Is there a way to enable it only for registered users?

$wgGroupPermissions['*']['writeapi'] = true;

Is there a group I can use instead of " * "?

Thu, Oct 15, 9:40 PM · Editing-team (Tracking), Parsoid, MW-1.35-release, VisualEditor
matmarex added a comment to T265528: It's not possible to answer to a message generated by Template:Instrukce – patrolář a revertér at cswiki via the reply tool.

The problem no longer occurs on this page because the template was substituted: https://cs.wikipedia.org/w/index.php?diff=19075859&oldid=19075730. But it's a real issue, I could reproduce it yesterday when talking with @Urbanecm about it.

Thu, Oct 15, 9:35 PM · Editing-team, DiscussionTools
matmarex edited projects for T264965: RuntimeException when loading UploadWizard in MW1.35, added: MediaWiki-General, MW-1.35-release; removed UploadWizard.

Looks like a problem with the definition of mediawiki.messagePoster in core MediaWiki.

Thu, Oct 15, 8:24 PM · MW-1.35-release, MediaWiki-General
matmarex added a comment to T265500: Reply tool doesn't appear at some wikis, possibly due to timestamp formatting.

Also, some further details on why this happened.

Thu, Oct 15, 8:16 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T265500: Reply tool doesn't appear at some wikis, possibly due to timestamp formatting from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

Seems to work now on thwiki and newiki at a glance. I couldn't easily find a suitable discussion page to test on the others – it looks like their date formats or timezones changed recently, and timestamps generated before the change won't be recognized by DiscussionTools. The regular QA in T264693 should cover them, I guess.

Thu, Oct 15, 7:36 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex raised the priority of T265560: Text on UploadWizard's "Describe" page is too narrow (due to .mwe-upwiz-data defining "width: calc(-132.5%)") from High to Unbreak Now!.
Thu, Oct 15, 7:21 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Structured-Data-Backlog, Structured Data Engineering, Regression, UploadWizard
matmarex closed T265560: Text on UploadWizard's "Describe" page is too narrow (due to .mwe-upwiz-data defining "width: calc(-132.5%)") as Resolved.

Fixed and backported. The "Describe" step on https://commons.wikimedia.org/wiki/Special:UploadWizard looks normal to me again.

Thu, Oct 15, 7:12 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Structured-Data-Backlog, Structured Data Engineering, Regression, UploadWizard
matmarex added a comment to T265650: Enable strict units in LESS.

The patch definitely causes some issues. Most things I checked were fine (e.g. core, Vector, VisualEditor), but Minerva styles failed. I'm not planning to track this down right now, but maybe someone will.

Thu, Oct 15, 6:55 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex added a comment to T265650: Enable strict units in LESS.

(I previously did this for OOUI: https://gerrit.wikimedia.org/r/c/oojs/ui/+/535932)

Thu, Oct 15, 6:54 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex created T265650: Enable strict units in LESS.
Thu, Oct 15, 6:46 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, MediaWiki-General
matmarex added a comment to T265560: Text on UploadWizard's "Describe" page is too narrow (due to .mwe-upwiz-data defining "width: calc(-132.5%)").

We are backporting it today (right now, in fact).

Thu, Oct 15, 6:36 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Structured-Data-Backlog, Structured Data Engineering, Regression, UploadWizard
matmarex added a project to T265628: Identify which extensions' tests make HTTP requests and so are now broken post-T262443: UploadWizard.

Also affects UploadWizard: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/634290

Thu, Oct 15, 5:05 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, UploadWizard, User-zeljkofilipin, Math
matmarex claimed T265560: Text on UploadWizard's "Describe" page is too narrow (due to .mwe-upwiz-data defining "width: calc(-132.5%)").

And there are other places in UploadWizard that have a workaround for this problem, we just need to do the same here:

Thu, Oct 15, 4:38 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Structured-Data-Backlog, Structured Data Engineering, Regression, UploadWizard
matmarex added a comment to T265560: Text on UploadWizard's "Describe" page is too narrow (due to .mwe-upwiz-data defining "width: calc(-132.5%)").

https://phabricator.wikimedia.org/diffusion/EUWI/browse/master/resources/uploadWizard.less defines

#mwe-upwiz-stepdiv-details .mwe-upwiz-data {
		/* 230px + 2.5em is width of thumbnail on the left */
		width: calc( 100% - 230px - 2.5em );
	}

but code has not changed for two years.
Latest conversion from CSS to LESS in 104c59d76ba3931eabe595e5f6c661e3b87f86a5 didn't change anything either.

Thu, Oct 15, 4:35 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Structured-Data-Backlog, Structured Data Engineering, Regression, UploadWizard
matmarex added a comment to T264904: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak .

Yeah, they look like the same problem.

Thu, Oct 15, 4:32 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), Utilities-UnicodeJS, JavaScript, Wikimedia-production-error, VisualEditor
matmarex added a comment to T265500: Reply tool doesn't appear at some wikis, possibly due to timestamp formatting.

Backporting to wmf.11 and wmf.13:

  • wmf.11 is currently deployed on Wikipedias
  • wmf.12 was cancelled (T263178)
  • wmf.13 is due to roll out in a few hours, but there are still a few blockers, so it might not happen today (T263179)
Thu, Oct 15, 4:13 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T261539: Make it easy for editors to customize the edit summary of each comment they post from Ready for Development to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Oct 15, 3:55 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T261539: Make it easy for editors to customize the edit summary of each comment they post.
  • ✅ Sticky preference: if you customize the edit summary of the last comment you posted with the Reply Tool, the next time you open the tool the "Advanced" shelf should be shown.
  • Special:Preference: create a new preference in Special:Preferences that enables people to explicit decide whether the "Advanced" shelf be always shown or not
Thu, Oct 15, 3:54 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex closed T190120: Parse warnings not visible with live preview as Resolved.
Thu, Oct 15, 3:44 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-Page-editing
matmarex closed T190120: Parse warnings not visible with live preview, a subtask of T41272: Bugs in "Live preview" feature (tracking), as Resolved.
Thu, Oct 15, 3:43 PM · JavaScript, MediaWiki-Page-editing, Tracking-Neverending
matmarex closed T91167: LivePreview does not show Preview header nor preview warning as Resolved.
Thu, Oct 15, 3:43 PM · Patch-For-Review, MediaWiki-Page-editing, JavaScript
matmarex closed T91167: LivePreview does not show Preview header nor preview warning, a subtask of T41272: Bugs in "Live preview" feature (tracking), as Resolved.
Thu, Oct 15, 3:43 PM · JavaScript, MediaWiki-Page-editing, Tracking-Neverending
matmarex claimed T261539: Make it easy for editors to customize the edit summary of each comment they post.
Thu, Oct 15, 2:57 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex updated subscribers of T265571: MediaWiki 1.36/wmf.13 needlessly HTML encodes ASCII characters in DjVu text layer.

Probably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/628753 (rEPRPb9ab94b866e4: Fix escaping in PageContentBuilder::buildDefaultContentForPageTitle)

Thu, Oct 15, 11:17 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), ProofreadPage, Editing-team, MediaWiki-DjVu, Wikisource

Wed, Oct 14

matmarex added a comment to T66884: mediawiki.Uri does not support IPv6 URIs.

The caller is initDesktop() in Echo, but the underlying problem is T265506.

Wed, Oct 14, 8:29 PM · MediaWiki-General, JavaScript, IPv6
matmarex added a comment to T265506: mediawiki.Uri: Unable to get property 'protocol' of undefined or null reference.

This is T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash. The %E5 in the URL is the reason.

Wed, Oct 14, 8:28 PM · JavaScript, MediaWiki-Interface (jQuery-Tablesorter), Wikimedia-production-error
matmarex added a comment to T264693: Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis.

On maiwiki, mnwwiki, newiki, thwiki the reply links are not showing up – this is reported as T265500 and should be fixed tomorrow.

Wed, Oct 14, 8:23 PM · Verified, Turkish-Sites, Tamil-Sites, Hindi-Sites, Spanish-Sites, Editing-team (FY2020-21 Kanban Board), Beta-Feature, DiscussionTools, OWC2020
matmarex added a comment to T264520: Don't add nowiki tags in visual mode (or allow opting out).

If we didn't add nowiki tags in visual mode, then it would no longer be visual.

Wed, Oct 14, 8:20 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, User-DannyS712
matmarex moved T265500: Reply tool doesn't appear at some wikis, possibly due to timestamp formatting from Ready for Development to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Oct 14, 8:04 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex claimed T265500: Reply tool doesn't appear at some wikis, possibly due to timestamp formatting.

It looks like DateTime::format( 'T' ) and DateTimeZone::listAbbreviations() produce different abbreviations for these timezones, which I didn't know was possible. E.g. on thwiki, the timezone is Asia/Bangkok, the former outputs "+07" and the latter "BMT", and that is the reason why we don't recognize the timestamps.

Wed, Oct 14, 5:28 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex claimed T257581: Visual Editor adds link= parameter to image when only caption is edited.
Wed, Oct 14, 4:20 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex moved T258190: Production error: Cannot read property 'insertBefore' of null (VeCeDocumentNode.ve.ce.BranchNode.setupSlugs ) from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:15 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T265392: Uncaught Error: ve.dm.Document.getBranchNodeFromOffset(): offset * is out of bounds from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:14 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T265391: Uncaught Error: Invalid start or end offset in selectNodes from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:14 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T265389: Uncaught TypeError: selection.newFromAdjustment is not a function from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:14 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T134992: "TypeError: surface is null" on Flow page from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:14 PM · Growth-Team, StructuredDiscussions, Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T265156: Cannot read property 'focus' of undefined on mobile at VeCeSurface.ve.ce.Surface.focus from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:14 PM · Mobile, Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T264956: Uncaught Error: Remover past end at VeDmTreeModifier.ve.dm.TreeModifier.processRetain from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:13 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T255641: " TypeError: surface.getModel().getSelection().getRange is not a function" appearing in the console in a specific scenario from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:13 PM · OWC2020, DiscussionTools, Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T262060: Error: Cannot add a child to mwTransclusionBlock node from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:12 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261980: TypeError: this.model is null from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:11 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261969: TypeError: undefined is not an object (evaluating 'dialog.mediaUploadBooklet.setFile') from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:11 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261894: TypeError: titleAndFragment is null from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:11 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261888: Error: domNode has no ancestor with a .data( 'view' ) from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:10 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261884: TypeError: undefined is not an object (evaluating 'param.aliases.length') from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:10 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261785: Uncaught Error: Cannot add a child to text node from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:10 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T261782: Error: Unbalanced input passed to document from To Triage to Triaged on the VisualEditor board.
Wed, Oct 14, 4:10 PM · Growth-Team, StructuredDiscussions, Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T264904: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

We've also already updated VisualEditor to use the latest version of the library in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/632981.

Wed, Oct 14, 3:41 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), Utilities-UnicodeJS, JavaScript, Wikimedia-production-error, VisualEditor
matmarex edited projects for T264904: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak , added: Editing-team (FY2020-21 Kanban Board); removed Editing-team (Tracking).
Wed, Oct 14, 3:40 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), Utilities-UnicodeJS, JavaScript, Wikimedia-production-error, VisualEditor
matmarex edited projects for T191858: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly), added: Editing-team (FY2020-21 Kanban Board), Verified, VisualEditor-ContentEditable; removed Editing-team (Tracking).
Wed, Oct 14, 3:38 PM · User-Ryasmeen, VisualEditor-ContentEditable, Verified, Editing-team (FY2020-21 Kanban Board), JavaScript, Wikimedia-production-error, VisualEditor
matmarex added projects to T140871: Error thrown when deleting a heading next to a table (Unbalanced set of replace operations found): User-Ryasmeen, VisualEditor-DataModel.
Wed, Oct 14, 3:38 PM · VisualEditor-DataModel, User-Ryasmeen, Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor