QA here would presumably involve waiting for the patch to be deployed, then verifying that the validation failures stopped.
I believe this was caused by the same problem as T209542. I noticed this behavior when debugging that issue and described it:
@Der_Keks I'm not really sure what your suggestion is. You suggest a "Convert" button, but as we found out there already is one, which doesn't appear for this particular reference, because we can't detect that it is convertible. Can you clarify?
At a glance, this could be fixed by setting overflow: hidden; on the slug (or another property that creates a block formatting context). But we probably need to think carefully whether this can cause any issues.
@Kerry_Raymond Thanks for the report. I added a video of the bug to make it easier to understand.
Inserting a row always uses the same table cell style (data/header) as the first cell of the previous/next row (depending on whether you insert the row below or above). Probably it could look up the cell style for each cell individually.
It should be fixed on Wikipedia tomorrow after the new version of MediaWiki is deployed.
Thanks for the bug report!
In the given example page (https://test.wikipedia.org/wiki/MW_ATTRIBS_REGEX), quoted and unquoted examples are now parsed identically.
(We discussed this in the planning meeting today.)
I can't reproduce this today. I think this was caused by VE using when there were multiple spaces next to each other, and thus has been resolved by the patch for T55931: VisualEditor: Move to using white-space: pre-wrap instead of using nbsp's to fake spaces.
This seems to work fine these days. Clicking that cell marks it with the striped background also used for alien nodes. It might have been fixed as part of T85648.
Tue, Dec 11
(If T208644 is fixed, it will likely affect this dialog)
The patch was deployed to all projects and the problem shouldn't occur for any new edits. You can find existing affected pages using the wiki search feature, for example: https://ru.wikipedia.org/w/index.php?search=insource%3Adonut-container&profile=all
I can reproduce this. I think it's actually more serious that it looked like – it seems what whenever the keyboard is used while any VE dialog is open, the viewport is continually scrolled to the top. This makes it nearly impossible to type in fields in the "bottom half" of dialogs, such as the gallery image caption field, but also affects e.g. fields in the options tab of gallery dialog, and other dialogs like the maps dialog.
I could reproduce it a few times, but every time I was able to make it fix itself by just waiting a few seconds (until the scrollbar disappeared) before trying to scroll again. So this seems low priority.
@MaxBioHazard Thank you for noticing. I found that this has been broken by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/473809.
Mon, Dec 10
Short answer: It's impossible to "guess" the "right 8-but character encoding". It would be wrong to assume anything.
Reverted in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/478734 due to concerns about compatibility with alternative editors that override the 'textSelection' API. This should be relatively easy to fix (see comments on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/474520), but somewhat time-consuming to verify that everything works correctly. Extensions to test: CodeEditor, CodeMirror, ProofreadPage, VisualEditor (NWE).
Fri, Dec 7
QA notes: try to make an edit that will fail to save because of an error generated by ConfirmEdit (CAPTCHA) / SpamBlacklist / TitleBlacklist / AbuseFilter; make sure the error is shown correctly (as before).
Looks like that edit was made using an old revision of the page as the base. Effectively, you undid all of the changes by other users made to that page in the past few weeks.
Thu, Dec 6
Wed, Dec 5
I like it.
The text feels very unexpected and unlike what placeholders should be like. I would expect the placeholder text to be something like "±HH:MM". I think the text you proposed would work better as a help label:
Tue, Dec 4
Relevant patches, chronologically:
(patches in each row were dependent on each other and merged at the same time)
OK, so to rephrase: when viewing https://no.wikipedia.org/w/index.php?title=Bruker:Jeblad/testing-dfgpiogj&action=edit§ion=3 (editing a section titled "Baz <pogo>"), the pre-filled edit summary is /* Baz */ , but it should instead be /* Baz <pogo> */ .
This has been fixed in rMWe9d7882e924d: UsersMultiselectWidget: Reduce default non-JS rows to 10.
Not sure what this task is supposed to cover, but I think it has been mostly done with rEBET14379dd886f6: NewHTMLCheckField: Use pretty field for OOUIHTMLForm too as part of the work on T117781. There are some CSS classes that are prefixed with mw-ui-, but they are all custom and the prefix is harmless, we are not loading any of normal MW UI styles.
It's not just invalid, it's a weird semi-valid semi-invalid border. It should never be half red, half blue.
T106244 is the same issue from a different perspective.
Mon, Dec 3
So, precise steps to reproduce is:
- Place a text cursor (or linear selection) inside a table cell (e.g. double-click it)
- Click on another table cell while holding Shift
Sat, Dec 1
May have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/476588, which was accidentally merged before its dependency (now fixed), or some related patch? Folks have been moving around a lot of code.
Works for me right now… This error would usually indicate a missing dependency.
An override for this message exists on these projects:
Fri, Nov 30
Thanks, I can reproduce now!
And this issue is already known: T159738.
The module is not loaded on all pages – it is not loaded on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page, for example. (Check in browser console with mw.loader.getState('oojs-ui-core'), it return "registered" rather than "ready".)
Thu, Nov 29
Hmm, it looks a bit broken on desktop too.
The issue doesn't occur for me, using Opera 57 / Chrome 70 on Windows 10 (Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 OPR/57.0.3098.53 (Edition beta)).