matmarex (Bartosz Dziewoński)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (126 w, 5 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex

Recent Activity

Tue, Mar 21

matmarex committed rSEXAMPLEdc599bbfd79c: [DO NOT MERGE] Example of defining custom OOjs UI theme (authored by matmarex).
[DO NOT MERGE] Example of defining custom OOjs UI theme
Tue, Mar 21, 9:05 PM
matmarex added a comment to T124742: Upgrade to jQuery 3.

(Many of the modules you listed do depend on jQuery, some even actually have 'jquery' in their name :) . At a glance, probably around 50% of them currently use jQuery, either for DOM operations, for AJAX functions, or just to add things to $.fn. In many cases they could be rewritten without it, but someone would have to do all that work.)

Tue, Mar 21, 5:18 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Performance-Team, JavaScript, MediaWiki-ResourceLoader
matmarex added a comment to T124742: Upgrade to jQuery 3.

The 'user' module (that's user's common.js etc.) expects jQuery to be present (unless the user actually has no common.js etc.).

Tue, Mar 21, 5:06 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Performance-Team, JavaScript, MediaWiki-ResourceLoader
matmarex added a comment to T160690: Be able to request a custom icon pack on-the-fly without fragmenting RL cache.

Thanks for the notes, it explains a lot. I have an idea that might help: Let extensions define their own icon packs and icon styles using json. So extensions can have something like this https://github.com/wikimedia/mediawiki/blob/master/resources/lib/oojs-ui/themes/mediawiki/icons-content.json and mediawiki understands that. It can be really helpful since an extension might not want the variants and that can help in performance greatly.

Tue, Mar 21, 4:05 PM · MediaWiki-ResourceLoader, Epic, OOjs-UI
matmarex added a comment to T106999: Implement HTMLSelectAndOtherField and HTMLSelectOrOtherField in OOUIHTMLForm.

Yeah, HTMLSelectOrOtherField has low usage and two alternatives, so we could probably get away with skipping it. But I think most of the code will be reused from HTMLSelectAndOtherField.

Tue, Mar 21, 3:45 PM · MediaWiki-HTMLForm
matmarex closed T85742: RecentChanges has buggy function [numRows() with $wgAllowCategorizedRecentChanges] as "Resolved".
Tue, Mar 21, 10:35 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MediaWiki-Recent-changes
matmarex closed T160716: Wikibase unit tests assume inline <div>s don't get magically re-written as <span>s (holding up the OOUI release) as "Resolved".

Yes, thanks for reviews.

Tue, Mar 21, 10:29 AM · OOjs-UI, Wikidata

Mon, Mar 20

matmarex added a comment to T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself.

OK, so I guess this task is invalid. But instead, we should do these:

  • Add links to https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements from some more places related to VisualEditor and/or skinning
  • Replace the check for $wgVisualEditorSupportedSkins with a check for all the elements we expect a skin to provide
  • Move out skin-specific stylesheets for Vector, MonoBook, Apex and Minerva to their respective repositories (using $wgResourceModuleSkinStyles)
Mon, Mar 20, 9:15 PM · Developer-Wishlist (2017), VisualEditor
matmarex added a comment to T160802: Resolve jQuery 3 migration errors in OOjs UI.

So you're saying that we should be using .prop() for all attributes that have an associated property? Including e.g. type, title, href, id, but not e.g. role, aria-checked? We never had a written convention for this, but the rule of thumb I was using was .prop() for everything that changes in response to user actions (e.g. value, checked), and .attr() for everything else.

Mon, Mar 20, 9:04 PM · Patch-For-Review, OOjs-UI
matmarex added a comment to T160920: Throttling access to Special Pages that make potentially expensive queries.

Can we assume that the absolute final URL is , the title of the page (obtain from H1) , replace space character with _ and then URL encode it?

Mon, Mar 20, 6:37 PM · Performance, MediaWiki-Special-pages
matmarex added a comment to T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself.

Apparently, we actually have this documented: https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements :o

So that looks like it's actually all we need, at least for the basics. And I just didn't know it was there, or some such... be nice if we didn't have to add it to the array - if all the expected ids are there, just have it try, and if something goes horribly wrong, let it go horribly wrong. Obvious horrible-looking bugs are often much easier to fix than why is there no support at all.

Mon, Mar 20, 6:00 PM · Developer-Wishlist (2017), VisualEditor
matmarex added a comment to T160263: Special:MovePage full of arrows since last MW update.

Deployment of the fix got delayed further because of T160716, it will only go live next week :(

Mon, Mar 20, 5:39 PM · OOjs-UI (OOjs-UI-0.20.0), Regression, MediaWiki-Special-pages
matmarex added a comment to T155769: Spurious completely empty `image` table row on commonswiki.

I ran this query: P5085 to find out if any other wikis are affected – and yes, enwiki has the same problem. https://en.wikipedia.org/w/index.php?title=Special:ListFiles&dir=prev

Mon, Mar 20, 5:36 PM · Operations, DBA, Wikimedia-General-or-Unknown
matmarex created P5085 Query to find affected wikis for T155769.
Mon, Mar 20, 5:30 PM
matmarex added a comment to T160911: When editing a section of a translateable page in VE, "[edit]" is included in default edit summary.

Not a regression I guess.

Mon, Mar 20, 5:08 PM · Patch-For-Review, MediaWiki-extensions-Translate, VisualEditor-MediaWiki, VisualEditor
matmarex renamed T160911: When editing a section of a translateable page in VE, "[edit]" is included in default edit summary from "[Regression] When editing a section in VE, "[edit]" is included in default edit summary" to "When editing a section of a translateable page in VE, "[edit]" is included in default edit summary".
Mon, Mar 20, 5:08 PM · Patch-For-Review, MediaWiki-extensions-Translate, VisualEditor-MediaWiki, VisualEditor
matmarex renamed T160917: Error on "Wanted Pages" with MSSQL from "Error on "Wanted Pages"" to "Error on "Wanted Pages" with MSSQL".
Mon, Mar 20, 3:27 PM · MediaWiki-Database
matmarex added a comment to T85742: RecentChanges has buggy function [numRows() with $wgAllowCategorizedRecentChanges].

Solution:
if ( $rows->numRows() === 0 ) {
must read
if ( $rows === 0 ) {

Mon, Mar 20, 2:31 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MediaWiki-Recent-changes
matmarex created T160911: When editing a section of a translateable page in VE, "[edit]" is included in default edit summary.
Mon, Mar 20, 2:03 PM · Patch-For-Review, MediaWiki-extensions-Translate, VisualEditor-MediaWiki, VisualEditor

Sun, Mar 19

matmarex updated subscribers of T160852: Uncaught TypeError: Cannot read property 'defaultView' of null.
Sun, Mar 19, 3:45 PM · Patch-For-Review, OOjs-UI, MediaWiki-extensions-Translate
matmarex updated subscribers of T160852: Uncaught TypeError: Cannot read property 'defaultView' of null.
Sun, Mar 19, 3:43 PM · Patch-For-Review, OOjs-UI, MediaWiki-extensions-Translate
matmarex added a comment to T160852: Uncaught TypeError: Cannot read property 'defaultView' of null.

Side note… looks like the way you position the popup no longer works correctly, partially also due to that change, partially due to rGOJUa3caf97b7167: PopupWidget: Make popups able to actually pop *up*, as well as sideways. But I'm not really sure if this should be considered a regression in OOjs UI or a pre-existing bug in how you do positioning that was now exposed.

Sun, Mar 19, 3:43 PM · Patch-For-Review, OOjs-UI, MediaWiki-extensions-Translate
matmarex added a comment to T160852: Uncaught TypeError: Cannot read property 'defaultView' of null.

I'm actually not sure if getClosestScrollableContainer should return the root for the body, since arguably body doesn't have a scrollable container – it is the ultimate scrollable container. But that would probably be saner than retuning null or throwing exceptions, and even our own code expects that behavior.

Sun, Mar 19, 2:45 PM · Patch-For-Review, OOjs-UI, MediaWiki-extensions-Translate
matmarex added a comment to T160852: Uncaught TypeError: Cannot read property 'defaultView' of null.

Also, fun fact, the error occurs on Chrome but not on Firefox, due to inconsistencies in how they handle the root scrollable element.

Sun, Mar 19, 2:29 PM · Patch-For-Review, OOjs-UI, MediaWiki-extensions-Translate
matmarex claimed T160852: Uncaught TypeError: Cannot read property 'defaultView' of null.

The root cause is that OO.ui.Element.static.getClosestScrollableContainer( document.body ) throws an error, rather than returning the root scrollable element (OO.ui.Element.static.getRootScrollableElement()).

Sun, Mar 19, 2:22 PM · Patch-For-Review, OOjs-UI, MediaWiki-extensions-Translate

Sat, Mar 18

matmarex merged task T160214: `$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP exceptions) into T85742: RecentChanges has buggy function [numRows() with $wgAllowCategorizedRecentChanges].
Sat, Mar 18, 9:24 AM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), MediaWiki-Recent-changes
matmarex merged T160214: `$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP exceptions) into T85742: RecentChanges has buggy function [numRows() with $wgAllowCategorizedRecentChanges].
Sat, Mar 18, 9:24 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), MediaWiki-Recent-changes
matmarex added a comment to T160802: Resolve jQuery 3 migration errors in OOjs UI.

JQMIGRATE: jQuery.fn.removeAttr no longer sets boolean properties: required
https://jquery.com/upgrade-guide/3.0/#breaking-change-removeattr-no-longer-sets-properties-to-false

Stack: OO.ui.TextInputWidget.setRequired / .. / ve.ui.MWReferenceDialog.initialize
When: Opening Reference insert dialog.

Stack (2): OO.ui.TextInputWidget.setRequired / .. / ve.ui.MWSaveDialog.initialize
When: Saving changes.

Sat, Mar 18, 9:11 AM · Patch-For-Review, OOjs-UI
matmarex added a subtask for T160802: Resolve jQuery 3 migration errors in OOjs UI: T152778: ClippableElement not compatible with jQuery 3.0.
Sat, Mar 18, 8:50 AM · Patch-For-Review, OOjs-UI
matmarex added a parent task for T152778: ClippableElement not compatible with jQuery 3.0: T160802: Resolve jQuery 3 migration errors in OOjs UI.
Sat, Mar 18, 8:50 AM · OOjs-UI (OOjs-UI-0.18.2)

Fri, Mar 17

Krinkle awarded T124901: Ensure themes using `oo-ui-vertical-gradient` mixin have decent output on IE 8 & 9 a Orange Medal token.
Fri, Mar 17, 8:00 PM · OOjs-UI (OOjs-UI-0.15.2), MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)), UI-Standardization, Browser-Support-Internet-Explorer, OOjs-UI
matmarex closed T157619: Notice: Undefined index: X in /srv/mediawiki/php-1.29.0-wmf.11/skins/CologneBlue/SkinCologneBlue.php on line Y as "Resolved".

Looks like this was fixed with rSCBL2b629a8bb98a: Revert "Remove warning suppression".

Fri, Mar 17, 1:05 PM · MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Wikimedia-log-errors, CologneBlue
matmarex added a subtask for T158949: Fix forms to work with ooui: T100896: Allow skins to use different, custom OOUI themes.
Fri, Mar 17, 1:00 PM · Timeless
matmarex added a parent task for T100896: Allow skins to use different, custom OOUI themes: T158949: Fix forms to work with ooui.
Fri, Mar 17, 1:00 PM · Patch-For-Review, OOjs-UI, MediaWiki-Interface
matmarex added parent tasks for T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself: T134668: Refreshed should integrate native-support for VisualEditor, T132005: MediaWiki VisualEditor and PageAttachment compatibility.
Fri, Mar 17, 1:00 PM · Developer-Wishlist (2017), VisualEditor
matmarex added a subtask for T132005: MediaWiki VisualEditor and PageAttachment compatibility: T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself.
Fri, Mar 17, 1:00 PM · VisualEditor, Timeless
matmarex added a subtask for T134668: Refreshed should integrate native-support for VisualEditor: T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself.
Fri, Mar 17, 1:00 PM · Brickimedia, Refreshed
matmarex added a comment to T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself.

Apparently, we actually have this documented: https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements :o

Fri, Mar 17, 12:56 PM · Developer-Wishlist (2017), VisualEditor
matmarex added a comment to T132005: MediaWiki VisualEditor and PageAttachment compatibility.

I don't really know what PageAttachment is, but the VisualEditor compatibility fixes work. (You also need $wgVisualEditorSupportedSkins[] = 'timeless'; in LocalSettings for the VE "Edit" link to appear.)

Fri, Mar 17, 12:54 PM · VisualEditor, Timeless
matmarex added a comment to T155554: VE support for skins should be done by adding appropriate anchors/ids/styles to the skins, and not by editing VE itself.

Lack of documentation is another thing, but technically, I think this is possible. Essentially, your skin's HTML structure should be like Vector or MonoBook ;), then you can add yourself to $wgVisualEditorSupportedSkins. A few modules have custom styling for Vector or MonoBook or other, but you can achieve that with $wgResourceModuleSkinStyles.

Fri, Mar 17, 12:33 PM · Developer-Wishlist (2017), VisualEditor
matmarex merged task T160742: Show my edits in Special:Watchlist doesn't work into T160734: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist.
Fri, Mar 17, 11:14 AM · MediaWiki-User-preferences, MediaWiki-Watchlist
matmarex merged T160742: Show my edits in Special:Watchlist doesn't work into T160734: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist.
Fri, Mar 17, 11:14 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), Patch-For-Review, Regression, MediaWiki-Watchlist
matmarex closed T155886: <textarea> is too tall in some circumstances as "Resolved".
Fri, Mar 17, 9:40 AM · Editing-Department, MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), MW-1.29-release-notes, MediaWiki-Page-editing
matmarex added a comment to T160716: Wikibase unit tests assume inline <div>s don't get magically re-written as <span>s (holding up the OOUI release).

Thanks. I'll submit a patch for that too, then.

Fri, Mar 17, 8:00 AM · OOjs-UI, Wikidata
matmarex closed T160309: Add "log in" and "create account" links on Special:EmailUser if logged out as "Resolved".
Fri, Mar 17, 7:52 AM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MW-1.29-release-notes, MediaWiki-Special-pages, MediaWiki-Email
matmarex updated subscribers of T160716: Wikibase unit tests assume inline <div>s don't get magically re-written as <span>s (holding up the OOUI release).

As usual with Wikibase issues, my main problem is figuring out which repository the fix should go into. The last time this kind of thing happened, I learned that Jenkins uses mediawiki/extensions/Wikidata, so I submitted it there so that we can get the OOUI release merged. I'm hereby making upstreaming it into wherever it really should land a WMDE's problem :)

Fri, Mar 17, 7:45 AM · OOjs-UI, Wikidata
matmarex closed T160532: ResourceLoaderImageModule fails on big SVGs as "Resolved".
Fri, Mar 17, 6:39 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MediaWiki-ResourceLoader, WMDE-QWERTY-Team-Board
matmarex committed rSEXAMPLE9ed24bde1624: [DO NOT MERGE] Example of defining custom OOjs UI theme (authored by matmarex).
[DO NOT MERGE] Example of defining custom OOjs UI theme
Fri, Mar 17, 6:08 AM
matmarex claimed T100896: Allow skins to use different, custom OOUI themes.
Fri, Mar 17, 3:02 AM · Patch-For-Review, OOjs-UI, MediaWiki-Interface
matmarex added a comment to T100896: Allow skins to use different, custom OOUI themes.

I spent a few days working on this. With the patches above (and their dependencies, in MediaWiki and OOjs UI: https://gerrit.wikimedia.org/r/#/q/topic:custom-ooui-themes) it is actually feasible to create and use a custom OOjs UI theme. I wouldn't say it's easy (for that, we'd need T76632, pretty much rewriting all theme logic), but it's totally doable.

Fri, Mar 17, 3:02 AM · Patch-For-Review, OOjs-UI, MediaWiki-Interface
matmarex claimed T160190: [Regression wmf.16] Context menus for items below the screen appear broken (no vertical height).

To reproduce (other than on first try):

  1. Make a context menu appear.
  2. Scroll it offscreen.
  3. Make another context menu appear.
Fri, Mar 17, 12:03 AM · Verified-in-Phase2, Verified-in-Phase0, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Verified, VisualEditor-EditingTools, OOjs-UI, VisualEditor

Thu, Mar 16

matmarex added a project to T160400: Request for email address seniori@wikimedia.org: Operations.
Thu, Mar 16, 6:56 PM · Operations, Office-IT, User-Urbanecm
matmarex updated subscribers of T160595: Uncaught TypeError: $content.find(...).makeCollapsible is not a function.

I have a hunch this is caused by https://gerrit.wikimedia.org/r/#/c/341751/ in core. Can you see if reverting that fixes it locally?

Thu, Mar 16, 12:17 AM · Timeless

Wed, Mar 15

matmarex added a comment to T160532: ResourceLoaderImageModule fails on big SVGs.

Is anyone taking on this, or do you want me to do it? It shouldn't be difficult.

Wed, Mar 15, 8:00 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MediaWiki-ResourceLoader, WMDE-QWERTY-Team-Board
matmarex added a comment to T160532: ResourceLoaderImageModule fails on big SVGs.

We should probably do the same thing that CSSMin does when asked to process an /* @embed */ annotation for a file exceeding that size. Which seems to be not embedding.

Wed, Mar 15, 7:57 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MediaWiki-ResourceLoader, WMDE-QWERTY-Team-Board
matmarex added a comment to T117165: Sometimes user-inserted ISBNs don't get converted to magic links somehow, meaning Parsoid has to nowiki them….

To reproduce this behaviour of VisualEditor which always encloses ISBN numbers inside <nowiki> tags when you enter an ISBN number without followed by a space or line feed try the following steps:

  • edit a page with VisualEditor
  • add any ISBN number but don't c&p it and don't finish with a space or line feed (but also brackets, dots doesn't leads to the ISBN parsing)!
  • click "Save changes"
  • click "Review your changes" to verify your edit and save it
Wed, Mar 15, 5:48 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), VisualEditor-MediaWiki, VisualEditor
matmarex moved T160536: PHP Notice: A non well formed numeric value encountered from Unsorted to PHP 7 on the NewPHP board.

(PHP 7 and 7.1 are affected, but 7 fails silently instead of printing a warning.)

Wed, Mar 15, 4:06 PM · NewPHP, TimedMediaHandler
matmarex added a project to T160536: PHP Notice: A non well formed numeric value encountered: NewPHP.
Wed, Mar 15, 4:05 PM · NewPHP, TimedMediaHandler
matmarex added a comment to T160536: PHP Notice: A non well formed numeric value encountered.

Same problem in a couple other files:

Wed, Mar 15, 4:04 PM · NewPHP, TimedMediaHandler
matmarex updated subscribers of T160536: PHP Notice: A non well formed numeric value encountered.

Looks like this is upstream code, part of https://github.com/pear/File_Ogg / http://pear.php.net/package/File_Ogg.

Wed, Mar 15, 4:01 PM · NewPHP, TimedMediaHandler
matmarex added a comment to T160536: PHP Notice: A non well formed numeric value encountered.

I'm running PHP 7.1. It seems that PHP 7 and later no longer automatically casts strings containing hexadecimal numbers to actual numbers when trying to do math on them.

Wed, Mar 15, 3:50 PM · NewPHP, TimedMediaHandler
matmarex created T160536: PHP Notice: A non well formed numeric value encountered.
Wed, Mar 15, 3:48 PM · NewPHP, TimedMediaHandler
matmarex added a comment to T159976: Run namespaceDupes.php for wikis in Western Punjabi (pnb).

OK, I actually see the first one: there are two pages titled "سانچہ:جھنڈا_تصویر" (https://pnb.wikipedia.org/w/?curid=38571 and https://pnb.wikipedia.org/w/?curid=38447) and we need to somehow merge/delete one of them. Looks like this is actually an older problem, since "Template" was translated earlier.

Wed, Mar 15, 2:05 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex updated subscribers of T159976: Run namespaceDupes.php for wikis in Western Punjabi (pnb).

@Dereckson: Can you explain what the script output above actually means? I'm having trouble making sense of it. @75.Abbasdhothar provided the translations and requested the change, hopefully they can help here :)

Wed, Mar 15, 2:00 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex added a comment to T157871: Add translation of namespaces in Western Punjabi.

@75.Abbasdhothar Looks like there are a few pages on Western Punjabi Wikipedia whose names conflict with the new translations – please help us fix them at T159976 :)

Wed, Mar 15, 1:58 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), I18n, Collection, Flow, Collaboration-Team-Triage, MediaWiki-extensions-Scribunto, MediaWiki-General-or-Unknown, Gadgets
matmarex edited the description of T160513: Optimize oojs/ui Jenkins jobs.
Wed, Mar 15, 1:51 PM · Continuous-Integration-Config, OOjs-UI
matmarex added a comment to T160480: Selflinks should still be <a> tags with CSS styling via a class, not <strong> tags.

If that's a problem, we could make them literally <a>foo</a> (with no href), then they wouldn't be clickable and they wouldn't be styled as links.

Wed, Mar 15, 12:42 AM · Patch-For-Review, Technical-Debt, MediaWiki-Parser, MediaWiki-General-or-Unknown, Editing-Department, VisualEditor

Tue, Mar 14

matmarex added a comment to T148471: Break out search stuff in TextInputWidget into SearchInputWidget.

I'm not really sure why mw.widgets.SearchInputWidget inherits from mw.widgets.TitleInputWidget, most of its code seems to be workarounds for its behaviors… oh well, some other time.

Tue, Mar 14, 9:37 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Patch-For-Review, Technical-Debt, OOjs-UI
matmarex added a comment to T148471: Break out search stuff in TextInputWidget into SearchInputWidget.

Hm, I guess we need to implement OO.ui.SearchInputWidget functionality in mw.widgets.SearchInputWidget. That shouldn't be too difficult.

Tue, Mar 14, 9:05 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, Patch-For-Review, Technical-Debt, OOjs-UI
matmarex added a comment to T160423: set devnagri numeric system in hi.wikipedia.

Hmm, actually, I'm not sure if you're requesting the same thing here. Can you explain more precisely what behavior you want to be changed?

Tue, Mar 14, 4:41 PM · Wikimedia-Language-setup
matmarex added a comment to T160423: set devnagri numeric system in hi.wikipedia.

For reference, this was explicitly disabled back in 2011 per the request at T31279. It can be enabled back by removing the override for 'wgTranslateNumerals' from the configuration.

Tue, Mar 14, 4:36 PM · Wikimedia-Language-setup
matmarex closed T154575: Split MediaWiki:Userrights to sysops and non-sysops as "Resolved".
Tue, Mar 14, 3:16 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Easy, MediaWiki-Special-pages
matmarex closed T154575: Split MediaWiki:Userrights to sysops and non-sysops, a subtask of T27319: Make Special:UserRights available to everyone, as "Resolved".
Tue, Mar 14, 3:16 PM · MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), MW-1.29-release-notes, User-notice, Easy, MediaWiki-Special-pages
matmarex added a comment to Tea Lover.

:(

Tue, Mar 14, 2:26 PM

Mon, Mar 13

matmarex added a comment to T160309: Add "log in" and "create account" links on Special:EmailUser if logged out.

I was thinking of this check in OutputPage::showPermissionsErrorPage():

Mon, Mar 13, 5:00 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MW-1.29-release-notes, MediaWiki-Special-pages, MediaWiki-Email
matmarex added a comment to T160309: Add "log in" and "create account" links on Special:EmailUser if logged out.

I think there's already supposed to be such a special case…

Mon, Mar 13, 4:55 PM · MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MW-1.29-release-notes, MediaWiki-Special-pages, MediaWiki-Email

Sun, Mar 12

matmarex closed T160269: "edit" link for page lead shows in different font in Vector skin as "Resolved".

Thanks for filing the bug. The issue has been fixed, and the fix will be deployed to Wikimedia wikis next week, 14-16 March, per https://www.mediawiki.org/wiki/MediaWiki_1.29/Roadmap.

Sun, Mar 12, 9:43 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Regression, CSS, Vector

Sat, Mar 11

matmarex added a comment to T106924: Consider using the Badges application for a few special roles to highlight those users' comments.

It appears that the Badges application is enabled again now. I have the "Tea Lover" badge again, which I've created and given myself the last time it was enabled (and when it wasn't checking for permissions for such things).

Sat, Mar 11, 10:29 PM · Phabricator
matmarex added a project to T160263: Special:MovePage full of arrows since last MW update: OOjs-UI.

We messed up the styling for the no-JavaScript version of Apex theme OOjs UI dropdowns in the last release. This is already fixed (https://gerrit.wikimedia.org/r/#/c/342247/), but not released yet.

Sat, Mar 11, 10:24 PM · OOjs-UI (OOjs-UI-0.20.0), Regression, MediaWiki-Special-pages

Fri, Mar 10

matmarex created T160214: `$wgAllowCategorizedRecentChanges = true` and using the "Limit to categories" input on Special:RecentChanges no longer works (PHP exceptions).
Fri, Mar 10, 11:30 PM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), MediaWiki-Recent-changes
matmarex created T160207: Unnecessary <nowiki> when editing indent-pre with lines starting with '*'.
Fri, Mar 10, 9:33 PM · Parsoid, VisualEditor
matmarex closed T133003: $1 displayed for Thanks error (upon trying to thank self) as "Resolved".

It seems this was fixed by rETHAa9cbd9471ba9: Update for API error i18n. Special:Thanks calls the API internally, and prior to that patch it a) wasn't handling all of the possible errors and b) wasn't passing the $1 parameter in the fallback error message.

Fri, Mar 10, 8:53 PM · Collaboration-Team-Triage, Thanks
matmarex closed T159657: [[MediaWiki:Abusefilter-log-linkoncontribs-text/en]] i18n issue as "Resolved".
Fri, Mar 10, 8:39 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Easy, AbuseFilter, I18n
matmarex closed T159657: [[MediaWiki:Abusefilter-log-linkoncontribs-text/en]] i18n issue, a subtask of T32443: GENDER (tracking), as "Resolved".
Fri, Mar 10, 8:39 PM · Tracking, I18n, MediaWiki-Parser
matmarex added a comment to T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.

I updated the screenshots. The one on the left was from Apex, the right from MediaWiki (back when this was filed, they looked a lot more alike :) ).

Fri, Mar 10, 5:12 PM · Design, OOjs-UI
matmarex edited the description of T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.
Fri, Mar 10, 5:11 PM · Design, OOjs-UI

Thu, Mar 9

matmarex added a comment to T158360: RFC: Disabling LocalisationUpdate on WMF wikis.

If the problem is two different systems fighting… could we instead backport l10n updates from master to wmf branches daily, and deploy that with Scap? Even if that couldn't run unattended (could it?), doing it daily-on-weekdays, or even daily-on-train-days, would still be far better than weekly.

Thu, Mar 9, 5:40 PM · ArchCom-Has-shepherd, I18n, Wikimedia-General-or-Unknown, ArchCom-RfC
matmarex added a comment to T130496: API sandbox's descriptions are positioned and styled poorly.

I'm not really bothered by the rest, but we should definitely reduce the amount of width taken by the labels. We can ponder doing this in OOjs UI for all interfaces later, but for now we could just override it with CSS for ApiSandbox.

Thu, Mar 9, 5:21 PM · MediaWiki-Interface, MediaWiki-API, Design
matmarex added a comment to T160033: CapsuleMultiselectWidget emits resize event twice when it should not be sent at all.
MyCustomCapsuleWidget.prototype.updateIfHeightChanged = OO.ui.debounce( MyCustomCapsuleWidget.parent.prototype.updateIfHeightChanged );
Thu, Mar 9, 1:20 PM · OOjs-UI (OOjs-UI-0.20.0)

Wed, Mar 8

matmarex updated subscribers of T106641: '' is frequently used unnecessarily in VisualEditor and put in <nowiki>.

I just added a gadget on Polish Wikipedia (https://pl.wikipedia.org/wiki/MediaWiki:Gadget-veAutocorrect.js), currently opt-in, that implements autocorrection from '' to / (the right kind of curly quotes for Polish), based on @Schnark's work at https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veAutocorrect.js.

Wed, Mar 8, 8:12 PM · VisualEditor
matmarex closed T157871: Add translation of namespaces in Western Punjabi as "Resolved".

All done. The new translations should become available on Western Punjabi Wikipedia next week, on Thursday, 16 March.

Wed, Mar 8, 7:25 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), I18n, Collection, Flow, Collaboration-Team-Triage, MediaWiki-extensions-Scribunto, MediaWiki-General-or-Unknown, Gadgets
matmarex created T159976: Run namespaceDupes.php for wikis in Western Punjabi (pnb).
Wed, Mar 8, 7:23 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
matmarex added a comment to T153275: URL to pagenames with special characters fail.

Maybe? I guess it's a special case of that. Do whatever makes it easier for you folks to get it fixed :)

Wed, Mar 8, 7:20 PM · Operations, Wikimedia-Apache-configuration
matmarex added a comment to T153275: URL to pagenames with special characters fail.

MediaWiki already does it consistently and correctly, but it can't if it doesn't have access to the unmangled URL. Something in our server setup mangles the URLs irrecoverably, as described in parent task T132629.

Wed, Mar 8, 7:01 PM · Operations, Wikimedia-Apache-configuration
matmarex added a comment to T159505: OOjs should provide a convenience helper function extend to complement OO.inheritClass.

This sounds reasonable, and it's not much extra code to support.

Wed, Mar 8, 6:45 PM · OOjs, Front-end-Standards-Group, Reading-Web-Backlog, Technical-Debt, MobileFrontend
matmarex updated subscribers of T159906: Non-anchored popups don't align correctly.
Wed, Mar 8, 6:14 PM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), MW-1.29-release-notes, MediaWiki-Recent-changes, MediaWiki-General-or-Unknown, Patch-For-Review
matmarex added a comment to T159921: move CologneBlue messages from the core repo to the CologneBlue repo.

I grepped for them, and didn't find them anywhere in core PHP or JS code, but they do appear in some tests/parser/preprocess/All_system_messages* files, and I'm not sure what to do about those lines.

Wed, Mar 8, 11:48 AM · MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), Patch-For-Review, MediaWiki-Internationalization, I18n, CologneBlue
matmarex added a comment to T157871: Add translation of namespaces in Western Punjabi.

@75.Abbasdhothar Is it possible to use a different translation for "REDIRECT" that is only a single word (no spaces)? It seems spaces in it currently don't work :(

Wed, Mar 8, 11:00 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), I18n, Collection, Flow, Collaboration-Team-Triage, MediaWiki-extensions-Scribunto, MediaWiki-General-or-Unknown, Gadgets
matmarex added a comment to T156675: Allow editing <pre> inline, without a popup dialog/inspector.

I fixed this task, as originally reported. Your comments on February 14 completely changed what this task is about, I guess.

Wed, Mar 8, 10:22 AM · VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates, VisualEditor-DataModel, VisualEditor
matmarex edited projects for T159890: [[MediaWiki:Tsb-reject-confirmation/en]] i18n issue, added: MediaWiki-extensions-Translate; removed MediaWiki-General-or-Unknown.
Wed, Mar 8, 12:18 AM · Easy, MediaWiki-extensions-Translate, I18n