Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (21)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (244 w, 4 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Yesterday

matmarex added a comment to T225568: Translate Edit Card UI strings.

@Amire80 @ppelberg Regarding "recycling" messages, the new mobile interface is in fact going to use the same messages that are already used in two places, on desktop and in the old mobile interface. I think this is fine (the text represents the same concepts and the same actions in all of these interfaces), and even desirable (I think it's useful for mobile and desktop users to see the same language: to make it easier for a person to switch between the two interfaces, and to avoid miscommunications when discussing between people using different interfaces). We've had some issues in the past with translated messages not fitting, but we usually solved that with changes to the interface (e.g. allowing line-wrapping).

Mon, Jun 24, 6:35 PM · Editing Design, VisualEditor (Current work)
matmarex added a comment to T225725: Design Edit Cards "v2.0".

I would like us to change the "Unlink" label to "Remove link", because:

  • It feels like a jargon word, appropriate for us to use internally (e.g. in the name of the icon :) ), but not in the interface intended for people with varying degrees of experience
  • We do not use "link" as a verb elsewhere in the interface, only as a noun, e.g. "Add a link" not "Link"
  • I think it would encourage poor translations that feel even more jargony
  • We have more than enough space in the interface, so we do not need the brevity
  • I am not sure if "unlink" in this meaning is a real word in English. I checked a few dictionaries online and if they defined "unlink" at all, the definition is only about detaching physical things, not about hyperlinks (while the "link" verb has a separate definition for hyperlinks on the web)
Mon, Jun 24, 6:20 PM · Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Thu, Jun 20

Restricted Application added a project to T123522: Implement a server-side mw.MessagePoster equivalent: Growth-Team.

This would allow for posting messages cross-wiki from wikis that do not have Flow installed to those that do. Example use case is VisualEditor's "Leave feedback" dialog.

Thu, Jun 20, 10:55 PM · Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Patch-For-Review, MediaWiki-General-or-Unknown
matmarex added a comment to T224851: Please centralize enwiki's feedback for VisualEditor .

Sorry about the mess, I didn't realize that.

Thu, Jun 20, 10:55 PM · VisualEditor (Current work)
matmarex moved T221314: Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki from In progress to QA on the VisualEditor (Current work) board.
Thu, Jun 20, 10:11 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex updated subscribers of T221314: Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki.

And it's live! (with help from @Jdforrester-WMF)

Thu, Jun 20, 10:10 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex updated subscribers of T224851: Please centralize enwiki's feedback for VisualEditor .

This won't work, because the StructuredDiscussions code has been removed from enwiki (even though it's meant to be live on all prod wikis).

Instead of working, it errors with "Feedback report failed because MessagePoster could not be fetched". See the config for dewikivoyage etc.

Obviously we can re-enable the extension on enwiki, but I imagine that might confuse some people.

Thu, Jun 20, 7:34 PM · VisualEditor (Current work)
matmarex moved T217797: Selection can appear on top of toolbar from Ready for Pick Up to Stalled/Waiting on the VisualEditor (Current work) board.
Thu, Jun 20, 6:56 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T221314: Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Thu, Jun 20, 6:55 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T226073: Keyboard displays momentarily when tapping a link from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Thu, Jun 20, 6:55 PM · Verified, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex moved T225936: Editing lede section with an infobox takes you to the infobox, not the first paragraph from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Thu, Jun 20, 6:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex moved T225546: 2017WTE up/down cursoring skips multiple empty lines in Chrome from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Thu, Jun 20, 6:51 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Browser-Support-Google-Chrome, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T222957: Set VisualEditor as standard on all types of pages at pap.wikipedia.org (Papiamentu Wikipedia) from Ready for Pick Up to Stalled/Waiting on the VisualEditor (Current work) board.
Thu, Jun 20, 6:49 PM · VisualEditor (Current work), Wikimedia-Site-requests, Wiki-goes-Caribbean
matmarex moved T224851: Please centralize enwiki's feedback for VisualEditor from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Thu, Jun 20, 6:47 PM · VisualEditor (Current work)
matmarex added a comment to T221314: Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki.

We deployed the patch, but when testing, I realized that the production wikis are still running software version wmf.8 (from ~two weeks ago) rather than wmf.10 (from this week), and so the new code for mobile contexts is not deployed. Apparently there have been some issues with it, see T220735: 1.34.0-wmf.10 deployment blockers (not related to VisualEditor).

Thu, Jun 20, 6:38 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a comment to T226202: WARNING: "Failed to find visualeditor-toolbar-savedialog" in message cache.

So, we fixed one use of this message: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/516270 but apparently there are others…

Thu, Jun 20, 5:33 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team, Wikimedia-production-error, VisualEditor, MediaWiki-extensions-GettingStarted, Performance-Team (Radar)
matmarex added a comment to T226202: WARNING: "Failed to find visualeditor-toolbar-savedialog" in message cache.

We removed the message from VE in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/516266, it's supposed to be unused.

Thu, Jun 20, 5:30 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team, Wikimedia-production-error, VisualEditor, MediaWiki-extensions-GettingStarted, Performance-Team (Radar)
matmarex added a comment to T221314: Edit cards: deploy v1 to bn.wiki, he.wiki and fa.wiki.

Scheduled for deployment today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190620T1800

Thu, Jun 20, 5:28 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

@Ryasmeen Ed's fix for the Android issue should be available for testing on Beta soon (I'm not sure how long it takes to update itself).

Thu, Jun 20, 4:58 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Wed, Jun 19

matmarex added a comment to T224851: Please centralize enwiki's feedback for VisualEditor .

Scheduled for tomorrow: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190620T1800

Wed, Jun 19, 7:06 PM · VisualEditor (Current work)
matmarex claimed T224851: Please centralize enwiki's feedback for VisualEditor .
Wed, Jun 19, 7:04 PM · VisualEditor (Current work)
matmarex closed T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" as Resolved.

The patches for T189560 that were made so far have allowed the patch for VisualEditor to merge, but the one for MobileFrontend is still failing. (T225359)

Wed, Jun 19, 6:39 PM · VisualEditor, User-Ryasmeen, MW-1.33-release, VisualEditor-MediaWiki
matmarex renamed T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" from VisualEditor/MobileFrontend broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" to VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'".
Wed, Jun 19, 6:37 PM · VisualEditor, User-Ryasmeen, MW-1.33-release, VisualEditor-MediaWiki
matmarex reopened T225359: MobileFrontend throws ConfigException when loading JS as "Open".

I believe this should be tracked separately from T225354, because I was just able to get the patch for that issue to merge, while the patch here is still failing.

Wed, Jun 19, 6:37 PM · Anti-Harassment, Readers-Web-Backlog (Tracking), Patch-For-Review, MW-1.33-release, MobileFrontend
matmarex closed T226115: VisualEditor/Cite tests failing on REL1_33 as Resolved.
Wed, Jun 19, 6:31 PM · User-Ryasmeen, MW-1.33-release, Cite, VisualEditor
matmarex closed T226115: VisualEditor/Cite tests failing on REL1_33, a subtask of T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'", as Resolved.
Wed, Jun 19, 6:31 PM · VisualEditor, User-Ryasmeen, MW-1.33-release, VisualEditor-MediaWiki
matmarex added a parent task for T226115: VisualEditor/Cite tests failing on REL1_33: T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'".
Wed, Jun 19, 4:59 PM · User-Ryasmeen, MW-1.33-release, Cite, VisualEditor
matmarex added a subtask for T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'": T226115: VisualEditor/Cite tests failing on REL1_33.
Wed, Jun 19, 4:59 PM · VisualEditor, User-Ryasmeen, MW-1.33-release, VisualEditor-MediaWiki
matmarex created T226115: VisualEditor/Cite tests failing on REL1_33.
Wed, Jun 19, 4:59 PM · User-Ryasmeen, MW-1.33-release, Cite, VisualEditor

Tue, Jun 18

matmarex added a comment to T222957: Set VisualEditor as standard on all types of pages at pap.wikipedia.org (Papiamentu Wikipedia).

VisualEditor is already enabled on your wiki and it's the default editor. Can you clarify what exactly you're requesting?

Tue, Jun 18, 8:53 PM · VisualEditor (Current work), Wikimedia-Site-requests, Wiki-goes-Caribbean
matmarex renamed T225349: VE should respect/preserve original block formatting in block template (comments between template parameters) from VE should respect/preserve original block formatting in block template to VE should respect/preserve original block formatting in block template (comments between template parameters).
Tue, Jun 18, 8:35 PM · VisualEditor, Parsoid, VisualEditor-MediaWiki-Templates
matmarex edited projects for T225349: VE should respect/preserve original block formatting in block template (comments between template parameters), added: VisualEditor; removed VisualEditor (Current work).
Tue, Jun 18, 8:35 PM · VisualEditor, Parsoid, VisualEditor-MediaWiki-Templates
matmarex placed T225349: VE should respect/preserve original block formatting in block template (comments between template parameters) up for grabs.
Tue, Jun 18, 8:34 PM · VisualEditor, Parsoid, VisualEditor-MediaWiki-Templates
matmarex edited projects for T225349: VE should respect/preserve original block formatting in block template (comments between template parameters), added: Parsoid; removed TemplateData.

"format": "block" in templatedata instructs Parsoid to reformat the template, and that's why the initial spaces are removed. This is the expected behavior. To avoid this, you can define a custom format if the spaces are always desirable (https://www.mediawiki.org/wiki/Help:TemplateData#Custom_formats), or you can remove the "format": "block" so that existing formatting will be preserved.

Tue, Jun 18, 8:33 PM · VisualEditor, Parsoid, VisualEditor-MediaWiki-Templates
matmarex added a comment to T213995: Parsoid does not apply "format" from TemplateData if the template is transcluded via a redirect.

Yes, probably the same thing.

Tue, Jun 18, 8:18 PM · VisualEditor, TemplateData, Parsoid-Edit-Support
matmarex added a comment to T217797: Selection can appear on top of toolbar.

@JTannerWMF I think Ed actually had a try at it earlier, documented in the subtask at T220634#5214282:

Tue, Jun 18, 8:09 PM · VisualEditor-Mobile-UsabilityImprovements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
matmarex added a comment to T224322: Slight flicker in iOS Safari when cursor is placed past the first page of the document.

@ppelberg This happens very inconsistently for me, like 1 in 20 tries or even less often. I was able to capture it after trying for some time:

Tue, Jun 18, 7:53 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex added a comment to T224322: Slight flicker in iOS Safari when cursor is placed past the first page of the document.

@Ryasmeen I think that's separate, I filed T226047.

Tue, Jun 18, 7:47 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
matmarex added a comment to T226047: Keyboard covers cursor after closing a dialog on mobile iOS.

This looks very similar to T218650 or T218635. Maybe caused by c843549bc6526c545d0e69ff825033be05f8c0dc? Also, I couldn't reproduce it, but I didn't try that hard.

Tue, Jun 18, 7:46 PM · VisualEditor
matmarex created T226047: Keyboard covers cursor after closing a dialog on mobile iOS.
Tue, Jun 18, 7:45 PM · VisualEditor
matmarex updated subscribers of T225546: 2017WTE up/down cursoring skips multiple empty lines in Chrome.

Caused by rGVEDc0799b060844: Source mode performance optimizations.

Tue, Jun 18, 4:37 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Browser-Support-Google-Chrome, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T225546: 2017WTE up/down cursoring skips multiple empty lines in Chrome.

It also seems to be a recent regression in our code, I randomly picked a commit from February and this doesn't happen in that version. I'm bisecting now.

Tue, Jun 18, 4:30 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Browser-Support-Google-Chrome, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T225546: 2017WTE up/down cursoring skips multiple empty lines in Chrome.

This only happens in Chrome. It works correctly in Firefox and Edge.

Tue, Jun 18, 4:21 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Browser-Support-Google-Chrome, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T224175: Visual Editor doesn't scroll/float properly when searching for Arabic text while editing (Chrome/Safari).
  • Scroll all the way to the top of the page (exact location on the page seems to matter)
  • Click next result (">") lots of times....
    • #16 and #17 are barely on the screen (see screenshot)

Tue, Jun 18, 4:13 PM · VisualEditor-EditingTools, VisualEditor
matmarex added a comment to T225014: Getting two save dialogs when editing File pages on commons.

I can't reproduce.

Tue, Jun 18, 3:28 PM · VisualEditor
matmarex added a comment to T225979: Code-Review and Verified votes can be removed from changes after they are merged.

@Reedy Removing reviewers and reviews definitely has been possible for a while, but I am pretty sure it used to only be available on open changes.

Tue, Jun 18, 12:43 PM · Gerrit
matmarex created T225979: Code-Review and Verified votes can be removed from changes after they are merged.
Tue, Jun 18, 1:52 AM · Gerrit
matmarex reopened T225860: HTMLSelectAndOtherField has some issues with the default value and validation as "Open".

(oh sorry, I didn't notice the backport)

Tue, Jun 18, 1:32 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), MediaWiki-HTMLForm, Patch-For-Review, Anti-Harassment
matmarex closed T225860: HTMLSelectAndOtherField has some issues with the default value and validation as Resolved.
Tue, Jun 18, 1:31 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), MediaWiki-HTMLForm, Patch-For-Review, Anti-Harassment
matmarex added a comment to T225975: Dynamically update an OOUI element's config after construction.

I agree that this would be pretty cool.

Tue, Jun 18, 1:30 AM · OOUI
matmarex added a comment to T225854: Using append() loses focus of the active element..

Back to the main issue at hand – I am not sure if it would be good to do it.

Tue, Jun 18, 1:27 AM · OOUI
matmarex added a comment to T225854: Using append() loses focus of the active element..

Actually, make that a major correction. append(), as far as I can tell, does not call remove(), and therefore does not remove event handlers from the element being appended. You can see it in your demo, by noticing that the 'input' event handler continues working after being called for the first time and calling append() on the element.

Tue, Jun 18, 1:06 AM · OOUI
matmarex added a comment to T225854: Using append() loses focus of the active element..

Minor correction:

Tue, Jun 18, 12:59 AM · OOUI
matmarex added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

As I was testing the new patch, I noticed another issue on iOS. When VE scrolls the page to make space for the native context menu below the toolbar, the native context menu itself remains in place – it neither scrolls with the selection, as it ideally would, nor does it disappear, as it apparently used to do a few months ago (T202723#4983015).

Tue, Jun 18, 12:45 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex added a comment to T202723: Mobile native selection context menu can obscure the VE toolbar.

@Esanders The submodule update patch is failing due to some mysterious problems in ContentTranslation, can you have a look at it?

Tue, Jun 18, 12:45 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex added a comment to T213214: Visual Editor gets stuck opening article (net::ERR_SPDY_PROTOCOL_ERROR 200/Loading failed for the <script> with source ...).

The problem continues to happen for me intermittently as well.

Tue, Jun 18, 12:19 AM · User-Ryasmeen, Traffic, Wikimedia-Apache-configuration, Operations, VisualEditor

Mon, Jun 17

matmarex added a comment to T225882: "Sign In" dialog for piwik.wikimedia.org shown when accessing OOUI demos on doc.wikimedia.org.

I'm sorry if I came off as rude, it wasn't my intention.

Mon, Jun 17, 11:59 PM · Patch-For-Review, Analytics, Wikimedia-General-or-Unknown, OOUI, Security
matmarex moved T225645: Turn off section editing A/B test from Ready for Pick Up to Product owner review on the VisualEditor (Current work) board.
Mon, Jun 17, 9:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor-MediaWiki, Wikimedia-Site-requests, VisualEditor (Current work)
matmarex added a comment to T225882: "Sign In" dialog for piwik.wikimedia.org shown when accessing OOUI demos on doc.wikimedia.org.

For the record, I think this issue should have remained an "Unbreak Now". It's an extremely glaring issue that makes the demos nearly unusable. And the doc.wikimedia.org site is the closest thing to production for the OOUI tag. It is disappointing to me if we really consider issues on it so unimportant (and yet we go to great lenghts to add annoying analytics code…).

Mon, Jun 17, 9:19 PM · Patch-For-Review, Analytics, Wikimedia-General-or-Unknown, OOUI, Security
matmarex added a comment to T225882: "Sign In" dialog for piwik.wikimedia.org shown when accessing OOUI demos on doc.wikimedia.org.

@Milimetric @fdans If you used the same snippet on other sites, you might want to track them down and fix it, or fix the server configuration so that the two new URLs don't require authorizarion.

Mon, Jun 17, 9:17 PM · Patch-For-Review, Analytics, Wikimedia-General-or-Unknown, OOUI, Security
matmarex added a project to T225882: "Sign In" dialog for piwik.wikimedia.org shown when accessing OOUI demos on doc.wikimedia.org: Patch-For-Review.

@Milimetric That is incorrect. The original snippet was already wrong. See my patch https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/517548 for detailed explanation.

Mon, Jun 17, 9:14 PM · Patch-For-Review, Analytics, Wikimedia-General-or-Unknown, OOUI, Security
matmarex added a comment to T225882: "Sign In" dialog for piwik.wikimedia.org shown when accessing OOUI demos on doc.wikimedia.org.

This is extremely silly.

Mon, Jun 17, 8:58 PM · Patch-For-Review, Analytics, Wikimedia-General-or-Unknown, OOUI, Security
matmarex triaged T225882: "Sign In" dialog for piwik.wikimedia.org shown when accessing OOUI demos on doc.wikimedia.org as Unbreak Now! priority.
Mon, Jun 17, 8:58 PM · Patch-For-Review, Analytics, Wikimedia-General-or-Unknown, OOUI, Security
matmarex closed T225679: URL shortener does not update if used multiple times as Resolved.
Mon, Jun 17, 8:20 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup, Patch-For-Review, MediaWiki-extensions-UrlShortener
matmarex added a comment to T216446: Page zooms slightly when focusing document on iPhone Chrome.

If anyone wants to test the hack outside of VE, here's a simplified version I was initially testing with.

Mon, Jun 17, 7:07 PM · Patch-For-Review, VisualEditor (Current work), Browser-Support-Google-Chrome, VisualEditor-MediaWiki-Mobile
matmarex added a comment to T221311: Mobile edit cards: pre-deployment QA "adding/modifying links".

I can reproduce this on my iPhone SE as well. It only happens when tapping inside the editor for the first time after opening it, or after you dismissed the keyboard using the tick button on our toolbar (not the "Done" button on the keyboard). Although on my device it happens a lot faster (you can miss it if you're not looking for it).

Mon, Jun 17, 6:51 PM · Editing QA, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex added a comment to T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'".

Unfortunately the VisualEditor repo is unwisely configured in a very restrictive way so that no one other than Jenkins-bot can merge changes.

Mon, Jun 17, 6:09 PM · VisualEditor, User-Ryasmeen, MW-1.33-release, VisualEditor-MediaWiki

Fri, Jun 14

matmarex added a comment to T208984: Slovene projects: Alphabetical order in categories (collation).

@Janezdrilc No, only "Č", "Š", "Ž" get their own headings (this is defined here).

Fri, Jun 14, 10:24 PM · Wikimedia-Site-requests
matmarex moved T221311: Mobile edit cards: pre-deployment QA "adding/modifying links" from Inbox to High Priority on the Editing QA board.
Fri, Jun 14, 9:47 PM · Editing QA, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex moved T220633: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile from Inbox to High Priority on the Editing QA board.
Fri, Jun 14, 9:47 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex moved T225541: 'Change label' in link inspector broken when cursor is at end of link from Inbox to High Priority on the Editing QA board.
Fri, Jun 14, 9:47 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Editing QA, VisualEditor-DataModel, VisualEditor (Current work)
matmarex added a comment to T204733: Edit cards: re-think positioning of mobile contexts.

(QA is happening on T221311)

Fri, Jun 14, 9:46 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Design
matmarex reassigned T202723: Mobile native selection context menu can obscure the VE toolbar from Ryasmeen to Esanders.
Fri, Jun 14, 9:43 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex removed a project from T199617: Link to edit the label overlaps with the label: Editing QA.

(oops, was already marked as Verified)

Fri, Jun 14, 9:43 PM · Verified, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
matmarex added a project to T199617: Link to edit the label overlaps with the label: Editing QA.
Fri, Jun 14, 9:41 PM · Verified, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
matmarex added a project to T202723: Mobile native selection context menu can obscure the VE toolbar: Editing QA.
Fri, Jun 14, 9:41 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor-Mobile-UsabilityImprovements, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex added a project to T220633: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile: Editing QA.
Fri, Jun 14, 9:41 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex added a project to T221311: Mobile edit cards: pre-deployment QA "adding/modifying links": Editing QA.
Fri, Jun 14, 9:41 PM · Editing QA, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
matmarex added a project to T225541: 'Change label' in link inspector broken when cursor is at end of link: Editing QA.
Fri, Jun 14, 9:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Editing QA, VisualEditor-DataModel, VisualEditor (Current work)
matmarex moved T225541: 'Change label' in link inspector broken when cursor is at end of link from Code review to QA on the VisualEditor (Current work) board.
Fri, Jun 14, 9:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Editing QA, VisualEditor-DataModel, VisualEditor (Current work)
matmarex moved T204733: Edit cards: re-think positioning of mobile contexts from Code review to Product owner review on the VisualEditor (Current work) board.

You can now use the config variable $wgVisualEditorEnableNewMobileContext = true; to enable the new version of mobile contexts.

Fri, Jun 14, 9:38 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Design
matmarex removed a project from T220633: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile: Patch-For-Review.
Fri, Jun 14, 8:41 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex added a comment to T220633: Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile.

Actually I will split this change into a separate commit. It is not really related to the other context changes, and it seems to be the only functional change in that commit that affects both old and new contexts.

Fri, Jun 14, 8:30 PM · Editing QA, Patch-For-Review, VisualEditor (Current work), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable
matmarex edited parent tasks for T204733: Edit cards: re-think positioning of mobile contexts, added: T221307: [Engineering Epic] Mobile edit cards; removed: T221247: [Epic] Mobile context items.
Fri, Jun 14, 8:01 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Design
matmarex removed a subtask for T221247: [Epic] Mobile context items: T204733: Edit cards: re-think positioning of mobile contexts.
Fri, Jun 14, 8:01 PM · VisualEditor
matmarex added a subtask for T221307: [Engineering Epic] Mobile edit cards: T204733: Edit cards: re-think positioning of mobile contexts.
Fri, Jun 14, 8:01 PM · VisualEditor
matmarex reopened T204733: Edit cards: re-think positioning of mobile contexts as "Open".

(still has patches for review, I assume this was accidentally closed)

Fri, Jun 14, 8:00 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, Design
matmarex reopened T204733: Edit cards: re-think positioning of mobile contexts, a subtask of T211255: [EPIC] Mobile VE toolbar improvements, as Open.
Fri, Jun 14, 8:00 PM · VisualEditor-MediaWiki-Mobile, Editing Design, VisualEditor
matmarex reopened T204733: Edit cards: re-think positioning of mobile contexts, a subtask of T221247: [Epic] Mobile context items, as Open.
Fri, Jun 14, 8:00 PM · VisualEditor
matmarex moved T199617: Link to edit the label overlaps with the label from Code review to QA on the VisualEditor (Current work) board.
BeforeAfter
Fri, Jun 14, 7:55 PM · Verified, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
matmarex moved T199617: Link to edit the label overlaps with the label from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Fri, Jun 14, 7:52 PM · Verified, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
matmarex edited projects for T199617: Link to edit the label overlaps with the label, added: VisualEditor (Current work); removed VisualEditor.

@Esanders rediscovered this issue while working on changes to contexts on mobile:

Fri, Jun 14, 7:52 PM · Verified, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Thu, Jun 13

matmarex added a comment to T216446: Page zooms slightly when focusing document on iPhone Chrome.

The zoom controls can be changed dynamically, so if that's a problem, we could try doing something cheeky like re-enabling zoom after the cursor is placed, or maybe even keep it always enabled except when the user is placing the cursor to prevent this unintended zoom… We'd need to test that carefully to make sure nothing blows up, but depending on how the browser handles it, we may be able to do it.

Thu, Jun 13, 11:23 PM · Patch-For-Review, VisualEditor (Current work), Browser-Support-Google-Chrome, VisualEditor-MediaWiki-Mobile
matmarex added a comment to T225683: Error in Preferences in debug mode.

No need to backport anything.

Thu, Jun 13, 9:32 PM · Upstream, MW-1.32-release, MediaWiki-User-preferences
matmarex moved T217784: Toolbar in loading overlay should display sooner in sequencing from Code review to Product owner review on the VisualEditor (Current work) board.
Thu, Jun 13, 8:49 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor (Current work)
matmarex moved T1181: VisualEditor loading indicator should feel more integrated into the mobile interface from Design review to Product owner review on the VisualEditor (Current work) board.

Ed reviewed and merged the changaes, and the new loading indicator can now be seen on Beta, e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Digital_object_identifier. It will go live on production sites next week, 18-20 June, per the usual train deployment schedule.

Thu, Jun 13, 8:49 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, Design
matmarex renamed T186735: VisualEditor toolbar overlaps with desktop Minerva header from VisualEditor toolbar overlaps with Minerva header to VisualEditor toolbar overlaps with desktop Minerva header.
Thu, Jun 13, 8:19 PM · User-Ryasmeen, VisualEditor
matmarex closed T186735: VisualEditor toolbar overlaps with desktop Minerva header as Resolved.
Thu, Jun 13, 8:19 PM · User-Ryasmeen, VisualEditor
matmarex removed a project from T225683: Error in Preferences in debug mode: OOUI.

The warning is caused by SemanticMediaWiki, see here: T205956#4633005 T205956#4633514

Thu, Jun 13, 8:15 PM · Upstream, MW-1.32-release, MediaWiki-User-preferences
matmarex added a parent task for T217784: Toolbar in loading overlay should display sooner in sequencing: T1181: VisualEditor loading indicator should feel more integrated into the mobile interface.
Thu, Jun 13, 8:08 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), VisualEditor (Current work)