+1 for the sticky header option looking more feasible, and it looks pretty neat!

Seems to work.

Patch is ready & has been +1'ed.
Since we do not intend to merge the patch at this point, I've filed T410565 to follow up and get this merged later on.
I think we can close this out.

The quick fix seems to have resolved the issue on beta (see link in description - carousel is now up top)
TBC one it hits production.

Confirmed to have been fixed on prod, see: https://fr.wikipedia.org/wiki/Barcelone?imageBrowsing=1&useskin=minerva#/imagebrowsing/Fichier:Avinguda_de_la_Reina_Maria_Cristina_Barcelona_2013_modified.jpg

Some more cases that should have been fixed here:

Confirmed to be enabled on enwiki

Relevant patch already merged (being deployed this week): https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReaderExperiments/+/1197249

• Update the VTOC image layout to better use the space while accounting for extreme aspect ratios

Note: the patchdemo link in above comment still exhibits the old duplicate behavior, but it's resolved in more instances (e.g. https://97d2d44553.catalyst.wmcloud.org/wiki/London?imageBrowsing=1&useskin=minerva#/imagebrowsing/File:London_Skyline_(125508655).jpeg)

FYI: I would suggest [400, 960, 1280, 2560] - the lower 2 are already standard sizes (wgThumbLimits & wgThumbnailSteps) and, based on statcounter, would cover at least 20% (and those are likely the ones where the amount of bytes remain relatively important as well)

There were some issues where the code was assuming results coming in in releveance order, but that was not the case (and to make things worse, globalusage was coming in in yet another order)
It was not only causing duplicates (caused by the first problem), but also dropped perfectly valid results (caused by the 2nd)

In T405992#11234586, @JScherer-WMF wrote:

Image appears twice
https://24f17e0e4a.catalyst.wmcloud.org/wiki/ChatGPT?imageBrowsing=1&useskin=minerva#/imagebrowsing/File:Countries_where_ChatGPT_is_available.svg
https://24f17e0e4a.catalyst.wmcloud.org/wiki/ChatGPT?imageBrowsing=1&useskin=minerva#/imagebrowsing/File:ChatGPT_availability_by_country_or_region.svg

In T405992#11234574, @JScherer-WMF wrote:

Smart cropping doesn't work well with vertical positioning on desktop

In T404155#11234709, @lwatson wrote:

I prefer to restore focus to the original image (CarouselItem) that was selected to open the overlay. This makes the most sense to me because the focus picks up where you last were in the carousel, and it's also a simpler implementation.
Thoughts?

Catalyst: https://78a66ef974.catalyst.wmcloud.org/wiki/Barack_Obama?useskin=minerva&imageBrowsing=1
Patchdemo: https://patchdemo.wmcloud.org/wikis/4cc2ca7131/wiki/Barack_Obama?useskin=minerva&imageBrowsing=1

Both now have matching MRs:

@SDunlap Do we need anything else to move this along?

Approved; ready for CR

Note: above patch is technically ready, but is awaiting design input on the demo.
Discussion ongoing on Slack so I'll keep this in "doing" for now - I'll update/move this ticket based depending on the outcome.

Can we just make the fullscreen button toggle object-fit instead? It loads cropped (object-fit: cover) + caption, but toggles to uncropped (object-fit: contain) without caption? That’s essentially only adding a class to the container & 2 lines of CSS, and keeps controls simple and consistent (i.e. buttons remain and easy to go back to cropped mode)

Above is an example where we can already get all data we need through existing resources.
In this example:

• 10 (gsrlimit=10) images (gsrnamespace=6) for "cat" (gsrsearch=custommatch:depicts_or_linked_from=Q146
• with the French (wbetlanguage=fr) label (prop=entityterms & wbetterms=label)
• and the main-namespace articles (gunamespace=0) they're used in (prop=globalusage)

I filed this only 5 days ago, and so much potentially related code has already changed.
I just spun up a new patchdemo instance to check whether this issue was still present for me, and I could no longer reproduce: https://patchdemo.wmcloud.org/wikis/cf6e99b2fb/wiki/Cannes?useskin=minerva
Elena couldn't even reproduce in the original.

In T402872#11160449, @egardner wrote:

Do we need to file a follow-up task for anything here? @matthiasmullie if not feel free to move this to sign-off and I'll close it.

In T402872#11153884, @Etonkovidova wrote:

(1.1) on the page patchdemo Paris article Tab is clicked - the link 'Jump to content' is displayed as double-underlined with width >1600 px. The issue might be specific to Patchdemo quirks of vector skin. The production (wmf.17) starts displaying the issue with width >1620