Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (265 w, 2 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Today

matthiasmullie moved T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Dec 5, 1:33 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), Structured Data Engineering, UploadWizard, WikibaseMediaInfo
matthiasmullie moved T231994: Add support for url data type (top-level statements and qualifiers) from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Dec 5, 10:35 AM · Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard

Tue, Dec 3

matthiasmullie moved T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Tue, Dec 3, 3:34 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), Structured Data Engineering, UploadWizard, WikibaseMediaInfo
matthiasmullie edited projects for T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Tue, Dec 3, 3:34 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), Structured Data Engineering, UploadWizard, WikibaseMediaInfo
matthiasmullie claimed T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files.
Tue, Dec 3, 3:34 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), Structured Data Engineering, UploadWizard, WikibaseMediaInfo
matthiasmullie added a comment to T238878: Data about how many file pages on Commons contain at least one structured data element .

If you want to count pages, then you are only looking at the current revision, right? And the current revision of a page is by definition never deleted/suppressed. So no need to check rev_deleted.

Tue, Dec 3, 11:07 AM · Product-Analytics, SDC General, Analytics, Wikidata
matthiasmullie added a comment to T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".

Whoops. I hadn't realized this was blocked on me! Thanks for the ping, @Krinkle & @Ramsey-WMF.

Tue, Dec 3, 8:16 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
matthiasmullie added a comment to T238878: Data about how many file pages on Commons contain at least one structured data element .

@Milimetric it wasn't being used to omit deleted pages (see inline comments about archive table), but to also exclude those RevDel'ed revisions.
I was thinking it made sense to exclude rev-deleted revisions: if a page only has (SDC) revisions that are partly restricted for most people, that we might not want to count those.
But one could argue that we should include them, and I'm happy to exclude that condition from the query! (though the number is likely extremely low, too low to even matter)

Tue, Dec 3, 8:04 AM · Product-Analytics, SDC General, Analytics, Wikidata

Mon, Dec 2

matthiasmullie moved T239552: Add support for property-specific formatting of labels from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Mon, Dec 2, 2:44 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)

Fri, Nov 29

matthiasmullie moved T239475: Validate input and inform the user about violations from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 29, 4:05 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie added a comment to T231994: Add support for url data type (top-level statements and qualifiers).

Current status: wbsetclaim fail silently, and (silently) restore the UI to the state it loaded with, in read mode.
IMO, when a change fails to submit, the widget should probably remain in edit mode, with (invalid) input untouched, and an error message.

Fri, Nov 29, 2:35 PM · Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard
matthiasmullie moved T239475: Validate input and inform the user about violations from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 29, 2:16 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie edited projects for T239475: Validate input and inform the user about violations, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Fri, Nov 29, 2:16 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie added a comment to T231994: Add support for url data type (top-level statements and qualifiers).

Working on related: T239475: Validate input and inform the user about violations

Fri, Nov 29, 2:15 PM · Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard
matthiasmullie renamed T239475: Validate input and inform the user about violations from Validate values (and inform the user about violations) before attempting to submit them to Validate input and inform the user about violations.
Fri, Nov 29, 2:15 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie created T239475: Validate input and inform the user about violations.
Fri, Nov 29, 2:13 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie claimed T231981: Add support for top-level statements with quantity values.

I've split up this task. This ticket is not solely about enabling statement-level support for quantities.
I've split off the units-related work into T239474

Fri, Nov 29, 1:41 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie renamed T231981: Add support for top-level statements with quantity values from Add support for top-level statements with quantity values, and units for quantity data type to Add support for top-level statements with quantity values.
Fri, Nov 29, 1:39 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie updated the task description for T239474: Units support for quantity datatype.
Fri, Nov 29, 1:39 PM · Structured-Data-Backlog, Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie created T239474: Units support for quantity datatype.
Fri, Nov 29, 1:36 PM · Structured-Data-Backlog, Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie claimed T231994: Add support for url data type (top-level statements and qualifiers).
Fri, Nov 29, 1:31 PM · Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard
matthiasmullie updated the task description for T239154: Enable support for basic string types in top-level statements.
Fri, Nov 29, 1:28 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie claimed T239154: Enable support for basic string types in top-level statements.
Fri, Nov 29, 1:27 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)

Tue, Nov 26

matthiasmullie moved T236692: Implement MediaInfo-specific Lua library from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Nov 26, 3:14 PM · Structured-Data-Backlog (Current Work), Patch-For-Review
matthiasmullie edited projects for T236692: Implement MediaInfo-specific Lua library, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Tue, Nov 26, 3:14 PM · Structured-Data-Backlog (Current Work), Patch-For-Review
matthiasmullie renamed T236692: Implement MediaInfo-specific Lua library from [Spike] Implement MediaInfo-specific Lua library to Implement MediaInfo-specific Lua library.
Tue, Nov 26, 3:13 PM · Structured-Data-Backlog (Current Work), Patch-For-Review
matthiasmullie moved T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Nov 26, 3:13 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Wikidata, Structured Data Engineering, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie claimed T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities.
Tue, Nov 26, 3:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured Data Engineering, Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie moved T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Nov 26, 3:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured Data Engineering, Patch-For-Review, Structured-Data-Backlog (Current Work)

Mon, Nov 25

matthiasmullie added a comment to T238878: Data about how many file pages on Commons contain at least one structured data element .

I don't really know much about how mediawiki_history gets populated, but wbcreateclaim & wbeditentity (in addition to wbsetclaim) could also be used to create (or edit) statements IIRC, so this last set of results is likely incomplete.

Mon, Nov 25, 8:45 PM · Product-Analytics, SDC General, Analytics, Wikidata

Fri, Nov 22

matthiasmullie added a comment to T238878: Data about how many file pages on Commons contain at least one structured data element .

As far as I can tell:
@mpopov's queries (wbc_entity_usage based) include both MediaInfo items, along with Wikidata-items pulled in via Lua.
@Addshore's queries are stricktly the amount of MediaInfo items.

Fri, Nov 22, 3:49 PM · Product-Analytics, SDC General, Analytics, Wikidata
matthiasmullie added a comment to T181062: Adapt QuickStatements2 to be able to work with structured data on Commons as well.

Can my colleagues from the StructuredDataOnCommons team do anything to make it easier to include filename-to-Mid conversion in QuickStatements?

Fri, Nov 22, 1:59 PM · WMSE-Tools-for-Partnerships-2019-Blueprinting, GLAM-Tech, SDC General, Wikidata

Wed, Nov 13

matthiasmullie added a comment to T226093: Capacity planning for Commons Structured Data.

Matthias will look into discrepancies between number of files with mediainfo slots vs. what's indexed in Cirrus.

Wed, Nov 13, 10:24 AM · Structured-Data-Backlog (Current Work), Dumps-Generation, Operations, SDC General, Wikidata

Tue, Nov 12

matthiasmullie closed T236558: "wikidata-federation" Cloud VPS project jessie deprecation as Resolved.

federated-commons.wikidata-federation.eqiad.wmflabs & federated-wikidata.wikidata-federation.eqiad.wmflabs have been deleted

Tue, Nov 12, 11:05 AM · Cloud-VPS (Debian Jessie Deprecation)

Fri, Nov 8

matthiasmullie moved T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:11 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie moved T234756: Prevent users from entering short file caption on Commons from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:10 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog, Structured Data Engineering, Structured-Data-Backlog (Current Work), Commons
matthiasmullie moved T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed" from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:10 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
matthiasmullie moved T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:10 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie edited projects for T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Fri, Nov 8, 10:10 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error

Thu, Nov 7

matthiasmullie claimed T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch.
Thu, Nov 7, 9:12 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error

Nov 4 2019

matthiasmullie added a comment to T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

Patch has been updated:

Nov 4 2019, 1:34 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T236558: "wikidata-federation" Cloud VPS project jessie deprecation.

@Cparle also no longer needs them.
I suspect no-one else needs these anymore, but speak up if you do! I'll wait another week before removing them.

Nov 4 2019, 10:46 AM · Cloud-VPS (Debian Jessie Deprecation)
matthiasmullie moved T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed" from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Nov 4 2019, 10:20 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons

Oct 31 2019

Abit awarded T231463: Newly registered user cant save contributions a Love token.
Oct 31 2019, 3:24 PM · Structured-Data-Backlog (Current Work), ISA

Oct 30 2019

matthiasmullie added a comment to T236558: "wikidata-federation" Cloud VPS project jessie deprecation.

federated-commons and federated-wikidata can be probably removed.
There's one more instance on there that is still being used (not on Jessie, though): sdc-test-runner - this one should stay.

Oct 30 2019, 4:16 PM · Cloud-VPS (Debian Jessie Deprecation)
matthiasmullie merged T236911: InvalidArgumentException: Unsaved revision passed when undoing a 'depicts' statement into T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".
Oct 30 2019, 2:43 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
matthiasmullie merged task T236911: InvalidArgumentException: Unsaved revision passed when undoing a 'depicts' statement into T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".
Oct 30 2019, 2:43 PM · Structured-Data-Backlog, WikibaseMediaInfo
matthiasmullie closed T231463: Newly registered user cant save contributions as Resolved.

Rate limits have been increased for registered & confirmed users.

Oct 30 2019, 11:33 AM · Structured-Data-Backlog (Current Work), ISA

Oct 29 2019

matthiasmullie added a comment to T236558: "wikidata-federation" Cloud VPS project jessie deprecation.

We have been using it in the past - unsure if we plan to use it anymore - let me ask around

Oct 29 2019, 4:35 PM · Cloud-VPS (Debian Jessie Deprecation)

Oct 28 2019

matthiasmullie closed T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items as Resolved.

Currently being used in production: https://commons.wikimedia.org/w/index.php?title=File%3AJodrell_Bank_Mark_II_5.jpg&type=revision&diff=371864746&oldid=149735587
Closing this one - let's open other more specific tickets for additional work (T236691, T236692) or issues once they arise.

Oct 28 2019, 2:33 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, a subtask of T212144: Allow access to MediaInfo from wikitext on Commons, as Resolved.
Oct 28 2019, 2:33 PM · Structured-Data-Backlog, Wikidata, Structured Data Engineering
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Oct 28 2019, 2:31 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie created T236692: Implement MediaInfo-specific Lua library.
Oct 28 2019, 2:30 PM · Structured-Data-Backlog (Current Work), Patch-For-Review
matthiasmullie created T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities.
Oct 28 2019, 2:23 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured Data Engineering, Patch-For-Review, Structured-Data-Backlog (Current Work)

Oct 24 2019

matthiasmullie added a comment to T236370: Call to undefined method Wikibase\Lib\EntityTypeDefinitions::getPrefetchingTermLookupCallbacks().

Same as with T236372, these happened at the exact time these changes were being scapped, and stopped immediately after: https://logstash.wikimedia.org/goto/cfd3017e60a6be127c9673fd9ff53536

Oct 24 2019, 12:46 PM · Wikidata-Campsite, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
matthiasmullie added a comment to T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/WikibaseRepo.php on line 2470 and exactly 10 expected.

These all happened at 11:10 UTC, when the change was being deployed. This stopped immediately after: https://logstash.wikimedia.org/goto/39611d534c6b97d76c367f4e4878ab15

Oct 24 2019, 12:44 PM · Wikidata-Campsite, Wikibase-DataModel, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
matthiasmullie added a comment to T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/WikibaseRepo.php on line 2470 and exactly 10 expected.

I'll doublecheck, but I think these only happened the minute the patches were being scapped, and then stopped.

Oct 24 2019, 12:36 PM · Wikidata-Campsite, Wikibase-DataModel, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
matthiasmullie added a comment to T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

What other wikis have structured data enabled? 😃

Oct 24 2019, 6:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)

Oct 23 2019

matthiasmullie added a comment to T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

That copy change in the confirmation dialog is a great idea, I'll go make that change.

Oct 23 2019, 4:32 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

@matthiasmullie repeating myself from the IRC

Mmh - didn't see anything - what channel was that in? (or DM?)

Oct 23 2019, 1:54 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie updated subscribers of T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

So... @Ramsey-WMF/@PDrouin-WMF: here's a few screenshots of how I've implemented this thus far.
Let me know if we need to change things, or if this is ok as-is & we can move on with code review.

Oct 23 2019, 12:06 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 23 2019, 11:02 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 22 2019

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Commons is group 1. Let me know if you'd like me to deploy these patches once merged, or help in any way!

Oct 22 2019, 3:56 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

There is no magic involved.
Term lookups are performed differently for different entity types (because the data lives elsewhere), but in a non-hacky fashion (and it doesn't really matter where the data comes from or how it's retrieved anyway)

Oct 22 2019, 6:18 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 21 2019

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

AFAICT, most operations seem to be working fine.
The one that don't are either:

  • irrelevant (e.g. resolvePropertyId - MediaInfo's aren't properties; or getDescription - it works, but MediaInfo's don't tend to have descriptions...)
  • use SiteLinkLookup (getEntityIdForTitle and getSitelink) - I'm not even sure we'll need these for MediaInfo's - if we do, we can implement that later on!

Other lookups seem to work just fine!

Oct 21 2019, 7:16 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Apologies for being hard to reach recently @matthiasmullie.
I've submitted a change pair https://gerrit.wikimedia.org/r/544972 + https://gerrit.wikimedia.org/r/544973 with a simple proof-of-concept of what would be my idea how to solve this. I am not certain how to verify that all lookup operations are working as expected, so I would appreciate if you could have a look.

Oct 21 2019, 5:37 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 17 2019

matthiasmullie moved T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 17 2019, 1:03 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie created T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.
Oct 17 2019, 11:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

I should be able to help with it @matthiasmullie . Looking into it...

Oct 17 2019, 11:17 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 16 2019

matthiasmullie moved T235236: [Bug] File Page statement panels are not behaving properly in master branch and production from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 16 2019, 2:09 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering

Oct 11 2019

matthiasmullie moved T235236: [Bug] File Page statement panels are not behaving properly in master branch and production from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 11 2019, 7:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T235236: [Bug] File Page statement panels are not behaving properly in master branch and production.
Oct 11 2019, 7:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering

Oct 10 2019

matthiasmullie added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Heads-up - we're going to start addressing some of these issues soon, but there's a refactoring patch that has to go out first (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/528825/).

Oct 10 2019, 2:42 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, RTL, I18n, Structured-Data-Team-Current-Work
matthiasmullie closed T233734: WikibaseMediaInfo should not export unprefixed config/globals in JavaScript as Resolved.
Oct 10 2019, 2:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo
matthiasmullie moved T233734: WikibaseMediaInfo should not export unprefixed config/globals in JavaScript from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo
matthiasmullie moved T231463: Newly registered user cant save contributions from To Do to Blocked on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:40 PM · Structured-Data-Backlog (Current Work), ISA
matthiasmullie moved T235167: When there are no hideable caption languages on the File page, we still get a link saying "show 0 more languages" from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:39 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie moved T234756: Prevent users from entering short file caption on Commons from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:38 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog, Structured Data Engineering, Structured-Data-Backlog (Current Work), Commons
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Update: while above patches got merged, Lua still won't work by next week's deployment (at least not until some more issues are straightened out, but they may require some more work)

Oct 10 2019, 2:05 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:01 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 8 2019

matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 8 2019, 10:53 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T233267: Links to Wikidata Q-items don't open in a new tab from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 8 2019, 10:53 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering

Oct 7 2019

matthiasmullie moved T229011: Templatize CaptionsPanel.js from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 7 2019, 4:09 PM · Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work

Sep 27 2019

matthiasmullie moved T233267: Links to Wikidata Q-items don't open in a new tab from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Sep 27 2019, 7:14 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T233267: Links to Wikidata Q-items don't open in a new tab.
Sep 27 2019, 7:13 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 24 2019

matthiasmullie added a comment to T231463: Newly registered user cant save contributions.

@OlafJanssen It's not immediately clear to me exactly what's going on.
Did the new user start seeing this error message immediately, when the very first thing was being submitted? (in which case this is probably some yet unknown bug)
Or was it only after having already submitted a few things that it showed up? (in which case I suspect the user was rate limited - only a certain amount of edits are allowed in a short period of time for new users)

Sep 24 2019, 12:40 PM · Structured-Data-Backlog (Current Work), ISA
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Sep 24 2019, 12:10 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Sep 24 2019, 12:10 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 23 2019

matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from To Do to Doing on the Structured Data Engineering board.
Sep 23 2019, 4:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T232499: Provide mechanism for users to opt in to statement the copy functionality.
Sep 23 2019, 4:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 10 2019

matthiasmullie added a project to T232499: Provide mechanism for users to opt in to statement the copy functionality: UploadWizard.
Sep 10 2019, 4:40 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T232499: Provide mechanism for users to opt in to statement the copy functionality.
Sep 10 2019, 4:39 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 6 2019

matthiasmullie placed T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section up for grabs.

And unassigning myself - I don't want to claim this. Anyone can pick this up, work on any number of the acceptance criteria, and pass it on.

Sep 6 2019, 11:03 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie edited projects for T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

I've spun this off into multiple tickets - one per "category" - and I'm pulling this first one into "current work".

Sep 6 2019, 11:01 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T232208: Write selenium tests for QA checklist "Check Language support beyond English" section.
Sep 6 2019, 10:57 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232207: Write selenium tests for QA checklist "Check UI design integrity" section.
Sep 6 2019, 10:57 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232206: Write selenium tests for QA checklist "Check that general Commons functionality is still intact" section.
Sep 6 2019, 10:56 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232205: Write selenium tests for QA checklist "Check that Search works properly" section.
Sep 6 2019, 10:55 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232204: Write selenium tests for QA checklist "Check that diffs between past revisions/edits works" section.
Sep 6 2019, 10:54 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie updated the task description for T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section.
Sep 6 2019, 10:52 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering