Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (276 w, 5 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Thu, Feb 20

matthiasmullie added a comment to F31552245: set-units.png.

Would it help to disable the search box once something has been selected?
This should make it obvious that the only 2 options are to keep it or remove it, and that it can no longer be used for searching?

Thu, Feb 20, 11:28 AM
matthiasmullie added a comment to T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers.

Does this work?

Thu, Feb 20, 11:11 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie added a comment to T231996: [M] Add support for 'monolingual text' data type (top-level and qualifiers).

How does this look on mobile? (particularly the qualifiers) ❓

Thu, Feb 20, 10:44 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering

Tue, Feb 18

matthiasmullie added a comment to F31552245: set-units.png.

@Pginer-WMF does above look ok to you?

Tue, Feb 18, 5:16 PM
matthiasmullie moved T231996: [M] Add support for 'monolingual text' data type (top-level and qualifiers) from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Feb 18, 1:08 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie added a comment to T244953: 5 character limit is too restrictive for structured data on commons for character-based languages.

Changing this would be easy, except that there's probably no limit that makes sense for all languages, and compiling a list of limits that do make sense per language seems not feasible.
And even so, this limit was added to prevent spam to some extent - just because Chinese can have meaningful content in 1 character, doesn't make it any more immune from spam.
And there is an (even more strict - 9 characters) abuse filter that will prevent this kind of input, even if we were to lower the character count.

Tue, Feb 18, 8:59 AM · StructuredDataOnCommons, Structured-Data-Backlog

Thu, Feb 13

matthiasmullie added a comment to T231996: [M] Add support for 'monolingual text' data type (top-level and qualifiers).

Proposed implementation (with ULS):

Thu, Feb 13, 1:31 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie claimed T231996: [M] Add support for 'monolingual text' data type (top-level and qualifiers).
Thu, Feb 13, 1:22 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie added a comment to T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers.

Update after design feedback: checkboxes are gone & dropdowns always active. They'll automatically update with what's inferred from time input, until something else is manually selected.

Thu, Feb 13, 10:59 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie moved T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Feb 13, 10:58 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering

Tue, Feb 11

matthiasmullie added a comment to T244856: Prefer relevant unit suggestions over other entities.

Ah, I didn't notice above comment.
Above link was a list of items with a "unit symbol" property, but unit conversion (P2370 or P2442) makes just as much sense.

Tue, Feb 11, 2:18 PM · Wikidata, MediaWiki-extensions-PropertySuggester, Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T244856: Prefer relevant unit suggestions over other entities.

This looks like a decent list of unit entities: https://query.wikidata.org/#prefix%20wdt%3A%20%3Chttp%3A%2F%2Fwww.wikidata.org%2Fprop%2Fdirect%2F%3E%0ASELECT%20%3Fitem%20%3FitemLabel%20WHERE%20%7B%0A%20%20%3Fitem%20wdt%3AP5061%20%3Fdummy0%20.%0A%20%20SERVICE%20wikibase%3Alabel%20%7Bbd%3AserviceParam%20wikibase%3Alanguage%20%22en%22%20%7D%0A%7D

Tue, Feb 11, 2:14 PM · Wikidata, MediaWiki-extensions-PropertySuggester, Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T239474: [M] Units support for quantity datatype.

If we're building a new interface, can you make it a bit smarter so it actually suggests a relevant unit? If I'm adding things like height and width, I probably want something like cm (not Cameroon) and when I add heading I probably want degree. Now I just get everything .

Tue, Feb 11, 1:16 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie created T244856: Prefer relevant unit suggestions over other entities.
Tue, Feb 11, 1:16 PM · Wikidata, MediaWiki-extensions-PropertySuggester, Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T239474: [M] Units support for quantity datatype.

Design update: see F31552245

Tue, Feb 11, 1:09 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)

Mon, Feb 10

matthiasmullie claimed T227116: Enhanced support for geo-coordinate Wikibase datatype.
Mon, Feb 10, 2:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.
Mon, Feb 10, 2:36 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie moved T227116: Enhanced support for geo-coordinate Wikibase datatype from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.
Mon, Feb 10, 2:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T244752: Suggested tag submission starts failing after multiple submissions from To Do to Needs QA on the Structured-Data-Backlog (Current Work) board.
Mon, Feb 10, 2:36 PM · Structured-Data-Backlog (Current Work), MachineVision
matthiasmullie edited projects for T244752: Suggested tag submission starts failing after multiple submissions, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Mon, Feb 10, 2:36 PM · Structured-Data-Backlog (Current Work), MachineVision
matthiasmullie claimed T244752: Suggested tag submission starts failing after multiple submissions.

Patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MachineVision/+/571274

Mon, Feb 10, 2:35 PM · Structured-Data-Backlog (Current Work), MachineVision

Fri, Feb 7

matthiasmullie added a comment to F31552245: set-units.png.

I like option #2, but that's not natively part of OOUI and would require a massive amount of work.

Fri, Feb 7, 4:58 PM
matthiasmullie added a comment to F31552245: set-units.png.

So, that's going to look pretty much like this:

Fri, Feb 7, 11:40 AM

Thu, Feb 6

matthiasmullie closed T244350: Literal HTML <ul><li> shown in case of an error while saving (here: edit conflict) as Resolved.

This is fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/566887, which hit production yesterday!

Thu, Feb 6, 7:32 AM · Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo

Wed, Feb 5

matthiasmullie claimed T244207: Revision 386521405 belongs to M43864745 instead of expected M79277318.

This is similar to T231276.

Wed, Feb 5, 4:14 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Wikibase-SDC-Shared, Structured Data Engineering, Commons, Wikidata, Wikimedia-production-error

Mon, Feb 3

matthiasmullie added a comment to T239474: [M] Units support for quantity datatype.

Actual (backend) support for other entities has already been merged.
Patch to bring support to the frontend is in code review.

Mon, Feb 3, 4:14 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie claimed T239474: [M] Units support for quantity datatype.
Mon, Feb 3, 4:09 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie added a comment to T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers.

Patch is in code review.

Mon, Feb 3, 2:13 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie moved T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Mon, Feb 3, 2:06 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering

Jan 24 2020

matthiasmullie moved T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Jan 24 2020, 1:45 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie claimed T231979: [L] Add UI support for time (date) Wikibase datatype for top-level statements and qualifiers.
Jan 24 2020, 1:45 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), UploadWizard, WikibaseMediaInfo, Structured Data Engineering
matthiasmullie added a comment to T225672: [Spike] Explore Special Pages related to SDC, particularly EntityUsage.

True. Do you have any idea if/how a similar scenario is currently handled in Wikidata?

Jan 24 2020, 1:08 AM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, Structured Data Engineering
matthiasmullie closed T239939: [S] Deploy WikibaseQualityConstraints to beta commons, a subtask of T239163: Inform users about constraint violation, as Resolved.
Jan 24 2020, 12:58 AM · Patch-For-Review, Wikidata, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie closed T239939: [S] Deploy WikibaseQualityConstraints to beta commons as Resolved.

This is now on betacommons: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Version

Jan 24 2020, 12:58 AM · Wikibase-Quality-Constraints, Wikidata, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)

Jan 23 2020

matthiasmullie moved T239474: [M] Units support for quantity datatype from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 23 2020, 11:04 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Absolutely, but this is somewhat putting the cart before the horse. We have no idea if MediaWiki will ever have a build step. At the same time, I don't think it's necessarily wise to effectively shift that build step to ResourceLoader (which kinda feels like the solution that is being proposed?) In other words, the ideal migration may never happen, so are we content with not having a build step? (i.e. what happens when the temporary solution becomes permanent?)

Jan 23 2020, 6:58 PM · Security-Team, TechCom-RFC

Jan 22 2020

matthiasmullie moved T239939: [S] Deploy WikibaseQualityConstraints to beta commons from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Jan 22 2020, 3:36 PM · Wikibase-Quality-Constraints, Wikidata, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie added a comment to T239474: [M] Units support for quantity datatype.

@matthiasmullie what am I doing wrong at /w/api.php?action=wbeditentity&format=json&id=M51867633&token=123445678903dd2%2B%5C&data=%7B%22claims%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P7787%22%2C%22datavalue%22%3A%7B%22value%22%3A%20%7B%22amount%22%20%3A%20%22%2B67%22%2C%20%22unit%22%20%3A%20%22http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ28390%22%7D%2C%22type%22%3A%22quantity%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D ?

Jan 22 2020, 12:15 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)

Jan 20 2020

matthiasmullie added a comment to T243123: Login to at least en.wikipedia.beta.wmflabs.org and commons.wikimedia.beta.wmflabs.org sometimes fails with `There seems to be a problem with your login session`.

I'm not sure if it's related, but I just got The provided authentication token is either expired or invalid. error message after logging in.

Jan 20 2020, 4:22 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralAuth, Beta-Cluster-Infrastructure, MediaWiki-User-login-and-signup, MediaWiki-Core-Testing, User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE)

Jan 16 2020

matthiasmullie moved T239474: [M] Units support for quantity datatype from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Jan 16 2020, 12:03 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie claimed T239474: [M] Units support for quantity datatype.
Jan 16 2020, 12:03 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 16 2020, 8:28 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T242331: Input field not cleared after selecting an entry from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 16 2020, 8:28 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Structured-Data-Backlog (Current Work), SDC General, Regression, WikibaseMediaInfo, Wikidata
matthiasmullie closed T225672: [Spike] Explore Special Pages related to SDC, particularly EntityUsage as Resolved.

As I understand it (and that understanding could be wrong, please re-open the ticket if it is), EntityUsage does not record/show usage of an item within claims in other entities.
It does, however, record usage of entities via Lua. Since having rolled out Lua support for MediaInfo entities (completed last week), those usages should now also show up in EntityUsage.

Jan 16 2020, 8:24 AM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, Structured Data Engineering

Jan 15 2020

Krinkle awarded T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70 a Orange Medal token.
Jan 15 2020, 12:39 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Jan 14 2020

matthiasmullie moved T242331: Input field not cleared after selecting an entry from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 14 2020, 4:09 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Structured-Data-Backlog (Current Work), SDC General, Regression, WikibaseMediaInfo, Wikidata
matthiasmullie moved T242331: Input field not cleared after selecting an entry from To Do to Doing on the Structured-Data-Backlog (Current Work) board.
Jan 14 2020, 2:45 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Structured-Data-Backlog (Current Work), SDC General, Regression, WikibaseMediaInfo, Wikidata
matthiasmullie claimed T242331: Input field not cleared after selecting an entry.
Jan 14 2020, 2:45 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Structured-Data-Backlog (Current Work), SDC General, Regression, WikibaseMediaInfo, Wikidata
matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from Needs QA to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 14 2020, 8:19 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie added a comment to T232499: Provide mechanism for users to opt in to statement the copy functionality.

There are 2 parts to this ticket, and only the WikibaseMediaInfo patch has been merged thus far. There is still a patch for UploadWizard (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/559709) in code review.

Jan 14 2020, 8:18 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 13 2020

matthiasmullie closed T242219: MediaInfoIdLookup::getEntityIds should omit entities it can't find as Resolved.
Jan 13 2020, 6:57 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 9 2020

matthiasmullie moved T242322: Create developer documentation about MediaInfo's templating/rendering workflow from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 9 2020, 8:53 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Documentation, WikibaseMediaInfo, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T242322: Create developer documentation about MediaInfo's templating/rendering workflow.
Jan 9 2020, 8:53 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Documentation, WikibaseMediaInfo, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie closed T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items as Resolved.

As far as I can tell, all (relevant) methods where a MediaInfo implementation was missing now work.

Jan 9 2020, 7:56 AM · Structured-Data-Backlog (Current Work), Wikidata, Structured Data Engineering, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Jan 8 2020

matthiasmullie moved T242219: MediaInfoIdLookup::getEntityIds should omit entities it can't find from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 8 2020, 1:28 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T242219: MediaInfoIdLookup::getEntityIds should omit entities it can't find.
Jan 8 2020, 1:28 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 7 2020

matthiasmullie moved T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70 from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 7 2020, 9:11 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
matthiasmullie edited projects for T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Jan 7 2020, 9:11 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
matthiasmullie added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

@AronManning Ugh - I had not noticed that you had already been working on a fix, sorry!
I submitted another patch - it looks like switching around the order of DOM changes & browser history manipulation also fixes Firefox's automatic scroll restoration.
I'm not too familiar with this codebase, so if you feel like your fix is the better (it does seem to have some welcome cleanup, but might also have some new browser hacks?), I'm happy to abandon mine & review yours once it passes CI.

Jan 7 2020, 9:10 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
matthiasmullie claimed T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.
Jan 7 2020, 9:02 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
matthiasmullie added a comment to T227116: Enhanced support for geo-coordinate Wikibase datatype.

I think once the mobile tweaks are done, it'll be ready. I have some mild concerns about turning the map off by default, but let's give it a go.

Jan 7 2020, 7:36 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering

Jan 6 2020

matthiasmullie added a comment to T240773: Exposed HTML in WikibaseMediaInfo autocomplete suggestions (CVE-2020-6163).

Yes - not sure why gerritbot didn't pick it up, but here's the patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/558203

Jan 6 2020, 7:54 PM · Security, Vuln-XSS, Security-Team, Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie closed T240773: Exposed HTML in WikibaseMediaInfo autocomplete suggestions (CVE-2020-6163) as Resolved.

This is now fixed - confirmed with example mentioned in task description.

Jan 6 2020, 6:48 PM · Security, Vuln-XSS, Security-Team, Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie moved T241984: Remove dead/unused code from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 6 2020, 12:44 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie renamed T241984: Remove dead/unused code from Remove dead code to Remove dead/unused code.
Jan 6 2020, 12:20 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie created T241984: Remove dead/unused code.
Jan 6 2020, 12:19 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie moved T241983: Remove backward compatibility code that is no longer needed from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 6 2020, 12:18 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a project to T241983: Remove backward compatibility code that is no longer needed: Structured Data Engineering.
Jan 6 2020, 12:18 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a project to T241982: Address WikibaseMediaInfo todos: Structured Data Engineering.
Jan 6 2020, 12:17 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie moved T241982: Address WikibaseMediaInfo todos from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 6 2020, 12:16 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie created T241983: Remove backward compatibility code that is no longer needed.
Jan 6 2020, 12:14 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie created T241982: Address WikibaseMediaInfo todos.
Jan 6 2020, 12:14 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie merged task T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities into T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items.
Jan 6 2020, 12:09 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie merged T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities into T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items.
Jan 6 2020, 12:09 PM · Structured-Data-Backlog (Current Work), Wikidata, Structured Data Engineering, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Dec 20 2019

matthiasmullie added a comment to T232499: Provide mechanism for users to opt in to statement the copy functionality.

This has indeed broken! Patches are up, but will take some time to land with the holidays.

Dec 20 2019, 9:36 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Dec 19 2019

matthiasmullie closed T239475: Validate input and inform the user about violations, a subtask of T233036: Enable support for all WB data types in top-level Statements and Qualifiers, as Resolved.
Dec 19 2019, 9:17 AM · Structured-Data-Backlog, Structured Data Engineering, Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie closed T239475: Validate input and inform the user about violations as Resolved.

Submit errors are now being displayed

Dec 19 2019, 9:17 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)

Dec 17 2019

matthiasmullie moved T239475: Validate input and inform the user about violations from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Dec 17 2019, 5:43 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie updated the task description for T239475: Validate input and inform the user about violations.
Dec 17 2019, 5:42 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie updated the task description for T239475: Validate input and inform the user about violations.
Dec 17 2019, 5:42 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (other-input-types-on-a-dirigible)
matthiasmullie closed T239165: PHP Warning: count(): Parameter must be an array or an object that implements Countable in WikibaseMediaInfo as Resolved.

No longer present in recent error logs.

Dec 17 2019, 5:27 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), WikibaseMediaInfo, Wikidata, Wikibase-DataModel, CirrusSearch, Wikimedia-production-error
matthiasmullie closed T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch as Resolved.

No longer present in recent error logs.

Dec 17 2019, 5:27 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie moved T240773: Exposed HTML in WikibaseMediaInfo autocomplete suggestions (CVE-2020-6163) from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Dec 17 2019, 5:03 PM · Security, Vuln-XSS, Security-Team, Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo

Dec 16 2019

matthiasmullie closed T236692: Implement MediaInfo-specific Lua library as Resolved.

The getSitelink break was handled in T240563. The fix has been deployed, and my initial tests seem to indicate it works.
This also completes this ticket.

Dec 16 2019, 8:49 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work)
matthiasmullie moved T231994: Add support for url data type (top-level statements and qualifiers) from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Dec 16 2019, 8:40 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, SDC-Statements (other-input-types-on-a-dirigible), Structured-Data-Backlog (Current Work), Structured Data Engineering, UploadWizard
matthiasmullie moved T240773: Exposed HTML in WikibaseMediaInfo autocomplete suggestions (CVE-2020-6163) from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Dec 16 2019, 8:40 PM · Security, Vuln-XSS, Security-Team, Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie claimed T240773: Exposed HTML in WikibaseMediaInfo autocomplete suggestions (CVE-2020-6163).
Dec 16 2019, 8:10 PM · Security, Vuln-XSS, Security-Team, Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie closed T240563: broken Lua's mw.wikibase.entity:getSitelink function as Resolved.

Fix got deployed - I believe this is done, but please do re-open the ticket should you still discover issues!

Dec 16 2019, 7:30 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Regression, StructuredDataOnCommons, Wikidata
matthiasmullie added a comment to T240563: broken Lua's mw.wikibase.entity:getSitelink function.

Can we just keep getSitelink method, and make it return nil when applied to MediaInfo entities?

Dec 16 2019, 12:25 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Regression, StructuredDataOnCommons, Wikidata
matthiasmullie created T240839: Make DataAccessSnakFormatterOutputFormatTest more robust.
Dec 16 2019, 10:12 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Wikidata-Campsite, Wikidata

Dec 13 2019

matthiasmullie added a comment to T236692: Implement MediaInfo-specific Lua library.

We already had painful code break when ... somehow broke parsing of wikidata entities

The breaking of getSitelink for Wikidata entities was a bug - the new library should not have affected those!

Dec 13 2019, 2:55 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T240563: broken Lua's mw.wikibase.entity:getSitelink function.

I believe that whatever I ended up doing to remove the getSitelink method from MediaInfo entities, accidentally took it away from the parent class as well. Am looking into it!

Dec 13 2019, 7:56 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Regression, StructuredDataOnCommons, Wikidata

Dec 12 2019

matthiasmullie added a comment to T240563: broken Lua's mw.wikibase.entity:getSitelink function.

Yes, it looks like the removal of getSitelink for MediaInfo entities probably caused this.
There's already a discussion about this on the module's talk page: https://commons.wikimedia.org/wiki/Module_talk:Wikidata_label#Lua_error_in_Module:Wikidata_label_at_line_24:_attempt_to_call_method_'getSitelink'_(a_nil_value).

Dec 12 2019, 2:55 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Regression, StructuredDataOnCommons, Wikidata

Dec 11 2019

matthiasmullie moved T236692: Implement MediaInfo-specific Lua library from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Dec 11 2019, 10:47 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work)
matthiasmullie moved T231977: Add support for geo-coordinate Wikibase datatype for statements about commons files from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Dec 11 2019, 10:47 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Structured-Data-Backlog (Current Work), SDC-Statements (other-input-types-on-a-dirigible), Structured Data Engineering, UploadWizard, WikibaseMediaInfo

Dec 10 2019

matthiasmullie added a comment to T239565: Create reportupdater reports that execute SDC requests .

No it shouldn’t count pages more than once.
UNION omits duplicates (UNION ALL doesn’t), so no need to DISTINCT again.

Dec 10 2019, 6:11 PM · Analytics-Kanban, Product-Analytics, SDC General, Wikidata, Analytics
matthiasmullie added a comment to T239565: Create reportupdater reports that execute SDC requests .

I'm not really sure what number we want to go with, but I can probably help clarify what kind of data is in which db tables (and what numbers derived from those actually mean)

Dec 10 2019, 2:16 PM · Analytics-Kanban, Product-Analytics, SDC General, Wikidata, Analytics
matthiasmullie added a comment to T238878: Data about how many file pages on Commons contain at least one structured data element .

Ping @matthiasmullie to asses this info

That is correct; just want to clarify 1 little detail:

Dec 10 2019, 2:14 PM · Product-Analytics, SDC General, Analytics, Wikidata
matthiasmullie added a comment to T208517: Should Wikibase add a property to the page response object that indicates the embedded entities?.

Alternatively, this API endpoint already includes the entity id: https://commons.wikimedia.beta.wmflabs.org/w/api.php?action=wbgetentities&sites=commonswiki&titles=File:Redsq.png

Dec 10 2019, 1:04 PM · MediaWiki-API, SDC General, Wikidata, MediaWiki-extensions-WikibaseRepository

Dec 6 2019

matthiasmullie added a project to T238484: Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer: Structured-Data-Backlog (Current Work).
Dec 6 2019, 12:24 PM · Structured-Data-Backlog (Current Work), Wikibase-Lua, MediaWiki-extensions-WikibaseClient, SDC General, Wikidata