Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (258 w, 6 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Today

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

There is no magic involved.
Term lookups are performed differently for different entity types (because the data lives elsewhere), but in a non-hacky fashion (and it doesn't really matter where the data comes from or how it's retrieved anyway)

Tue, Oct 22, 6:18 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Yesterday

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

AFAICT, most operations seem to be working fine.
The one that don't are either:

  • irrelevant (e.g. resolvePropertyId - MediaInfo's aren't properties; or getDescription - it works, but MediaInfo's don't tend to have descriptions...)
  • use SiteLinkLookup (getEntityIdForTitle and getSitelink) - I'm not even sure we'll need these for MediaInfo's - if we do, we can implement that later on!

Other lookups seem to work just fine!

Mon, Oct 21, 7:16 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Apologies for being hard to reach recently @matthiasmullie.
I've submitted a change pair https://gerrit.wikimedia.org/r/544972 + https://gerrit.wikimedia.org/r/544973 with a simple proof-of-concept of what would be my idea how to solve this. I am not certain how to verify that all lookup operations are working as expected, so I would appreciate if you could have a look.

Mon, Oct 21, 5:37 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Thu, Oct 17

matthiasmullie moved T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Oct 17, 1:03 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie created T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.
Thu, Oct 17, 11:46 AM · Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

I should be able to help with it @matthiasmullie . Looking into it...

Thu, Oct 17, 11:17 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Wed, Oct 16

matthiasmullie moved T235236: [Bug] File Page statement panels are not behaving properly in master branch and production from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Oct 16, 2:09 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering

Fri, Oct 11

matthiasmullie moved T235236: [Bug] File Page statement panels are not behaving properly in master branch and production from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Oct 11, 7:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T235236: [Bug] File Page statement panels are not behaving properly in master branch and production.
Fri, Oct 11, 7:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering

Thu, Oct 10

matthiasmullie added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Heads-up - we're going to start addressing some of these issues soon, but there's a refactoring patch that has to go out first (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/528825/).

Thu, Oct 10, 2:42 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, RTL, I18n, Structured-Data-Team-Current-Work
matthiasmullie closed T233734: WikibaseMediaInfo should not export unprefixed config/globals in JavaScript as Resolved.
Thu, Oct 10, 2:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo
matthiasmullie moved T233734: WikibaseMediaInfo should not export unprefixed config/globals in JavaScript from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Oct 10, 2:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo
matthiasmullie moved T231463: Newly registered user cant save contributions from To Do to Blocked on the Structured-Data-Backlog (Current Work) board.
Thu, Oct 10, 2:40 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), ISA
matthiasmullie moved T235167: When there are no hideable caption languages on the File page, we still get a link saying "show 0 more languages" from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Oct 10, 2:39 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie moved T234756: Prevent users from entering short file caption on Commons from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Oct 10, 2:38 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, Android-app-feature-UX-Debt, Structured Data Engineering, Structured-Data-Backlog (Current Work), Commons
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Update: while above patches got merged, Lua still won't work by next week's deployment (at least not until some more issues are straightened out, but they may require some more work)

Thu, Oct 10, 2:05 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.
Thu, Oct 10, 2:01 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Tue, Oct 8

matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Tue, Oct 8, 10:53 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T233267: Links to Wikidata Q-items don't open in a new tab from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Tue, Oct 8, 10:53 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering

Mon, Oct 7

matthiasmullie moved T229011: Templatize CaptionsPanel.js from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Mon, Oct 7, 4:09 PM · Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work

Fri, Sep 27

matthiasmullie moved T233267: Links to Wikidata Q-items don't open in a new tab from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Sep 27, 7:14 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T233267: Links to Wikidata Q-items don't open in a new tab.
Fri, Sep 27, 7:13 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering

Tue, Sep 24

matthiasmullie added a comment to T231463: Newly registered user cant save contributions.

@OlafJanssen It's not immediately clear to me exactly what's going on.
Did the new user start seeing this error message immediately, when the very first thing was being submitted? (in which case this is probably some yet unknown bug)
Or was it only after having already submitted a few things that it showed up? (in which case I suspect the user was rate limited - only a certain amount of edits are allowed in a short period of time for new users)

Tue, Sep 24, 12:40 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), ISA
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Sep 24, 12:10 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Sep 24, 12:10 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Mon, Sep 23

matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from To Do to Doing on the Structured Data Engineering board.
Mon, Sep 23, 4:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T232499: Provide mechanism for users to opt in to statement the copy functionality.
Mon, Sep 23, 4:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 10 2019

matthiasmullie added a project to T232499: Provide mechanism for users to opt in to statement the copy functionality: UploadWizard.
Sep 10 2019, 4:40 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T232499: Provide mechanism for users to opt in to statement the copy functionality.
Sep 10 2019, 4:39 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 6 2019

matthiasmullie placed T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section up for grabs.

And unassigning myself - I don't want to claim this. Anyone can pick this up, work on any number of the acceptance criteria, and pass it on.

Sep 6 2019, 11:03 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie edited projects for T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

I've spun this off into multiple tickets - one per "category" - and I'm pulling this first one into "current work".

Sep 6 2019, 11:01 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T232208: Write selenium tests for QA checklist "Check Language support beyond English" section.
Sep 6 2019, 10:57 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232207: Write selenium tests for QA checklist "Check UI design integrity" section.
Sep 6 2019, 10:57 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232206: Write selenium tests for QA checklist "Check that general Commons functionality is still intact" section.
Sep 6 2019, 10:56 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232205: Write selenium tests for QA checklist "Check that Search works properly" section.
Sep 6 2019, 10:55 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232204: Write selenium tests for QA checklist "Check that diffs between past revisions/edits works" section.
Sep 6 2019, 10:54 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie updated the task description for T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section.
Sep 6 2019, 10:52 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie updated the task description for T232200: Write selenium tests for QA checklist "Add Structured data during file upload with Upload Wizard" section.
Sep 6 2019, 10:52 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie updated the task description for T232201: Write selenium tests for QA checklist "Check page/file history AND recent changes" section.
Sep 6 2019, 10:52 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232203: Write selenium tests for QA checklist "Check that watchlists work properly" section.
Sep 6 2019, 10:52 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232201: Write selenium tests for QA checklist "Check page/file history AND recent changes" section.
Sep 6 2019, 10:51 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232200: Write selenium tests for QA checklist "Add Structured data during file upload with Upload Wizard" section.
Sep 6 2019, 10:49 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie renamed T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section from Write selenium tests for QA checklist to Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section.
Sep 6 2019, 10:48 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 3 2019

matthiasmullie created T231855: Allow using relative paths in array config vars.
Sep 3 2019, 8:13 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Security, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Structured-Data-Backlog, MediaWiki-Configuration, Wikidata

Sep 2 2019

matthiasmullie created T231789: Many "Unable to store text to external storage" exception on beta (read-only).
Sep 2 2019, 9:27 AM · MediaWiki-Revision-backend, Beta-Cluster-reproducible, Beta-Cluster-Infrastructure

Aug 30 2019

matthiasmullie moved T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Aug 30 2019, 2:09 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Aug 29 2019

matthiasmullie added a comment to T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.

a) is nothing to worry about: already fixed in prod T231488

Aug 29 2019, 7:15 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Aug 28 2019

matthiasmullie added a comment to T225102: Refactor UW statements code.

I backported the patch that I believe should fix this - are you still able to get into this stuck state now?

Aug 28 2019, 3:21 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.

I believe all of those things have now been fixed - can you do another run on labs to verify? :)

Aug 28 2019, 3:19 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Aug 27 2019

matthiasmullie claimed T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.
Aug 27 2019, 12:35 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)
matthiasmullie added a comment to T225102: Refactor UW statements code.

Ok cool, thanks for the info!
I suspect the CORS (CSP) errors in console have nothing to do with it (see T135963), but the "abort is not a function" might.

Aug 27 2019, 7:41 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T225102: Refactor UW statements code.

That's on beta, I suspect?
What steps did you do to trigger this? Just added the new property, and that's how it then appeared? Or did you start typing an item? Or did it only appear once you added the other statements or edited anything else?

Aug 27 2019, 7:16 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 26 2019

matthiasmullie added a comment to T229679: Statements with unsupported properties are displayed weirdly on edit.

It's greyed out because that specific datatype has no proper support yet (e.g. can't edit the coordinate)
It's something we want to do soon, though: T224060

Aug 26 2019, 3:04 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC-Statements (Other-statements-running), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie moved T228327: Add option to skip structured data parts in upload wizard campaigns from Doing to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Aug 26 2019, 2:58 PM · Structured-Data-Team-Current-Work, UploadWizard, Structured-Data-Backlog (Current Work), Wiki-Loves-Monuments, SDC-Statements (Campaigns-jogging), Structured Data Engineering
matthiasmullie moved T227220: Large numbers not handled properly in quantity qualifier field from Doing to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Aug 26 2019, 2:57 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T227220: Large numbers not handled properly in quantity qualifier field.

@Ramsey-WMF Is this still broken for you? AFAICT, it works fine now.

Aug 26 2019, 2:57 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie closed T229679: Statements with unsupported properties are displayed weirdly on edit as Resolved.

Some of last week's refactors probably solved this.
Closing since I can no longer reproduce this, but if anyone else still sees this, please reopen!

Aug 26 2019, 2:54 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC-Statements (Other-statements-running), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie claimed T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.
Aug 26 2019, 2:51 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Aug 23 2019

matthiasmullie moved T225102: Refactor UW statements code from To Do to Needs QA on the Structured-Data-Team-Current-Work board.
Aug 23 2019, 8:42 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie moved T225102: Refactor UW statements code from Doing to Verify on Production on the Structured Data Engineering board.
Aug 23 2019, 8:36 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 15 2019

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

@LucasWerkmeister Yes - I'm in Stockholm. I'll take a look at your suggestion and then come find you!

Aug 15 2019, 7:29 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Aug 1 2019

matthiasmullie added a comment to T229473: Old "digital representation of" statement panels show as grayed out [due to cache].

Things >30d old will expire and get proper treatment, things < 8d should already have correct html in cache.
It's just the things in between, I believe. Basically the "active enough that it *is* in cache (most likely only when bot ran), but not really too active because it's not really recent".
I believe the bad caches size is small enough, the issue trivial enough, and the tempfix (?action=purge) easy enough, that we should not put more effort into it, and just let caches expire.

Aug 1 2019, 7:30 AM · Structured Data Engineering, SDC-Statements (Other-statements-running), Multimedia

Jul 26 2019

matthiasmullie added a project to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items: Structured-Data-Team-Current-Work.
Jul 26 2019, 12:08 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Declined.
Jul 26 2019, 12:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo as Declined.

It looks like we may not need wb_terms (or the redesigned store) at this time. Declining ticket for now.

Jul 26 2019, 12:07 PM · Multimedia, Wikidata, SDC General, Structured Data Engineering
matthiasmullie closed T227847: Backfill terms index, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Declined.
Jul 26 2019, 12:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227847: Backfill terms index as Declined.

I'll decline this task, since we probably won't end up wanting or needing wb_terms (not yet, at least).
This could be reopened if at some point later on we find that we do have a valid usecase for them.

Jul 26 2019, 12:07 PM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

I was thinking it'd make most sense to use the existing code & structure already used by Wikidata.
But I've since learned about the reasons for not using wb_terms (I figured it was just a case of not having implemented it because there had not been a need for it yet)

Jul 26 2019, 12:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

Confirmed fixed on test-commons.

Jul 26 2019, 9:21 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia

Jul 24 2019

matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

This may be something we'll want to cherry-pick (or postpone enabling other statement until new branch gets to commons, next Wed)

Jul 24 2019, 3:02 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie moved T228807: Existing qualifiers do not appear in read-mode on the file page from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Jul 24 2019, 3:01 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie claimed T228807: Existing qualifiers do not appear in read-mode on the file page.
Jul 24 2019, 2:40 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie added a comment to T228808: Hide structured data on file pages for remote repositories.

I *think* this is a testcommons-specific edge case.
The SDC content should have 'display: none' by default on all other wikis, but since this one also has MediaInfo, it's actually getting displayed (but since it's not inside the own wiki's content div, it's not being hooked up properly)

Jul 24 2019, 11:55 AM · Structured-Data-Backlog (Current Work), WikibaseMediaInfo, Structured-Data-Team-Current-Work
matthiasmullie claimed T228849: 'Discard changes?' confirm box does not appear for statements.
Jul 24 2019, 11:51 AM · SDC-Statements (Other-statements-running), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Structured-Data-Team-Current-Work, Structured Data Engineering, WikibaseMediaInfo, Multimedia
matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

Can you still reproduce this? Or anyone else?
I can see the qualifiers immediately, both logged in & out.

Jul 24 2019, 11:28 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia

Jul 18 2019

matthiasmullie closed T227282: Selenium test runner should notify SDC team when it detects failures as Resolved.

Closing - we're getting notifications in Slack!

Jul 18 2019, 6:46 AM · Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Jul 16 2019

Nicolas_Raoul awarded T227798: "Add a caption" is broken a Like token.
Jul 16 2019, 11:29 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 15 2019

matthiasmullie updated the task description for T227226: Only Depicts statement panels should have Learn More links (for now).
Jul 15 2019, 4:37 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie reassigned T227226: Only Depicts statement panels should have Learn More links (for now) from Cparle to Edtadros.
Jul 15 2019, 4:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie reassigned T227798: "Add a caption" is broken from matthiasmullie to Edtadros.
Jul 15 2019, 4:05 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 12 2019

matthiasmullie claimed T227798: "Add a caption" is broken.
Jul 12 2019, 12:10 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T227847: Backfill terms index.

Nope, you're not mixing it up with something else; it is indeed undergoing redesign.
I've created T227848 to look into that, and what it'd mean in this context.

Jul 12 2019, 8:54 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie closed T227056: [Spike 2 days] Plan to access SDC data from Lua, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Resolved.
Jul 12 2019, 8:00 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227056: [Spike 2 days] Plan to access SDC data from Lua as Resolved.

As mentioned in T223792: Current Wikibase Lua support seems able to deal with MediaInfo entities already - it just can't find them.
If we start writing MediaInfo entities to wb_terms, it all starts to work.
However:

  • we'll need to run a maintenance script to populate the index for older entities: T227847
  • IIRC, wb_terms is currently undergoing redesign/migration - we need to figure out what that means for us (wait until that is done? migrate? how?) T227848

I've create new tickets for those things, and am considering this one done.

Jul 12 2019, 8:00 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, Spike
matthiasmullie created T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo.
Jul 12 2019, 7:56 AM · Multimedia, Wikidata, SDC General, Structured Data Engineering
matthiasmullie edited projects for T227847: Backfill terms index, added: Structured Data Engineering; removed MediaWiki-extensions-WikibaseClient.
Jul 12 2019, 7:49 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie removed projects from T227847: Backfill terms index: Wikidata, Wikibase-Lua.
Jul 12 2019, 7:49 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie created T227847: Backfill terms index.
Jul 12 2019, 7:49 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie added a subtask for T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items: T227056: [Spike 2 days] Plan to access SDC data from Lua.
Jul 12 2019, 7:44 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a parent task for T227056: [Spike 2 days] Plan to access SDC data from Lua: T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.
Jul 12 2019, 7:44 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, Spike
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

It looks like the Wikibase Lua support can mostly deal with MediaInfo already, except that it can't look up the MediaInfo entities.
Unlike Wikibase properties & items, MediaInfo entities are not currently stored in wb_terms.
If MediaInfo starts writing to wb_terms, Lua's functions also start working.
wb_terms is in the process of being redesigned/migrated, though, and I have yet to look into that.

Jul 12 2019, 7:36 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Jul 11 2019

matthiasmullie created T227798: "Add a caption" is broken.
Jul 11 2019, 4:32 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 9 2019

matthiasmullie placed T227274: File page: qualifiers not displayed just after they've been added up for grabs.
Jul 9 2019, 9:21 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie updated the task description for T227274: File page: qualifiers not displayed just after they've been added.
Jul 9 2019, 9:20 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie placed T226181: Odd behaviour when editing qualifier property type but not value up for grabs.
Jul 9 2019, 9:19 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie placed T225102: Refactor UW statements code up for grabs.
Jul 9 2019, 9:11 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 8 2019

matthiasmullie claimed T227274: File page: qualifiers not displayed just after they've been added.
Jul 8 2019, 10:42 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Jul 4 2019

matthiasmullie moved T227282: Selenium test runner should notify SDC team when it detects failures from To Do to Blocked on the Structured-Data-Team-Current-Work board.
Jul 4 2019, 1:54 PM · Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie added a comment to T227282: Selenium test runner should notify SDC team when it detects failures.

Should be done (slack notification) - won't be able to test until patch for T219815 gets merged

Jul 4 2019, 1:54 PM · Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie created T227282: Selenium test runner should notify SDC team when it detects failures.
Jul 4 2019, 1:27 PM · Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia