Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (437 w, 6 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Thu, Mar 23

matthiasmullie renamed T330773: [L] Make refinements to and incorporate P18 based section-level image suggestions from Another round of manual evaluation for section-level image suggestions focused on P18 to Another round of manual evaluation for section-level image suggestions.
Thu, Mar 23, 1:30 PM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie added a comment to T330773: [L] Make refinements to and incorporate P18 based section-level image suggestions.

As I understand things, simplified:

Thu, Mar 23, 1:26 PM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions

Wed, Mar 22

matthiasmullie updated the task description for T322872: [L] Change how we send image-suggestions notifications to experienced users.
Wed, Mar 22, 4:38 PM · Structured-Data-Backlog (Current Work), Image-Suggestions

Tue, Mar 21

matthiasmullie committed rESVUb02517a45c1b: Quick view - Show the expanded search result snippet (authored by SimoneThisDot).
Quick view - Show the expanded search result snippet
Tue, Mar 21, 10:13 AM

Fri, Mar 17

matthiasmullie moved T326383: [wmf.17-minor] Special:Search preview overlapping elements on a page from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Mar 17, 12:29 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements

Wed, Mar 8

matthiasmullie closed T311730: [L] Exclude certain sections from having generated image suggestions as Resolved.

Already implemented in https://gitlab.wikimedia.org/repos/structured-data/image-suggestions/-/tree/T311289

Wed, Mar 8, 11:27 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie closed T311730: [L] Exclude certain sections from having generated image suggestions, a subtask of T311814: [EPIC] Section-level image suggestions data pipeline, as Resolved.
Wed, Mar 8, 11:27 AM · Structured-Data-Backlog (Current Work), Data Pipelines, Section-Level-Image-Suggestions, Research-Backlog, Epic
matthiasmullie closed T311730: [L] Exclude certain sections from having generated image suggestions, a subtask of T311829: [XL] Combine suggestions based on section topics with section alignment ones and convert notebook code into idiomatic data pipeline code, as Resolved.
Wed, Mar 8, 11:27 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie closed T322668: [S] Exclude certain articles from having section-level image suggestions as Resolved.

Already implemented in https://gitlab.wikimedia.org/repos/structured-data/image-suggestions/-/tree/T311289

Wed, Mar 8, 11:25 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie closed T322668: [S] Exclude certain articles from having section-level image suggestions, a subtask of T311814: [EPIC] Section-level image suggestions data pipeline, as Resolved.
Wed, Mar 8, 11:25 AM · Structured-Data-Backlog (Current Work), Data Pipelines, Section-Level-Image-Suggestions, Research-Backlog, Epic
matthiasmullie closed T322668: [S] Exclude certain articles from having section-level image suggestions, a subtask of T311829: [XL] Combine suggestions based on section topics with section alignment ones and convert notebook code into idiomatic data pipeline code, as Resolved.
Wed, Mar 8, 11:25 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions

Tue, Mar 7

matthiasmullie added a parent task for T322872: [L] Change how we send image-suggestions notifications to experienced users: T330945: [S] Schedule section-level image suggestions notifications.
Tue, Mar 7, 10:11 AM · Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie added a subtask for T330945: [S] Schedule section-level image suggestions notifications: T322872: [L] Change how we send image-suggestions notifications to experienced users.
Tue, Mar 7, 10:11 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie added a comment to T330903: ECs do not receive notifications for p18-based image suggestions.

I would suggest closing this ticket and incorporating it into T330934's acceptance criteria instead (to ensure we don't end up wasting work by first adding P18 suggestions, then taking them away)

Tue, Mar 7, 9:59 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie added a comment to T330905: Contributors can easily opt-out out of section image suggestion notifications.

Note: this will probably end up being completed as part of T330934, which is to be built first and already lists opt-out among the acceptance criteria.

Tue, Mar 7, 9:55 AM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions

Mon, Mar 6

matthiasmullie committed rESVU76ed95bb41a2: Enhance the way the QuickView links searchResult to QuickView article (authored by SimoneThisDot).
Enhance the way the QuickView links searchResult to QuickView article
Mon, Mar 6, 1:26 PM
matthiasmullie moved T317639: [L] Enhance the way the QuickView links searchResult to QuickView article from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Mon, Mar 6, 1:16 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 4: Additional QuickView features)
matthiasmullie moved T328138: Mobile quick view last card should not hug the edge of the screen from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Mon, Mar 6, 1:12 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie moved T327648: [M] Accessibility improvements for Search Preview from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Mon, Mar 6, 1:11 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), SDAW-Search-Improvements (Milestone 4: Additional QuickView features), Structured-Data-Backlog (Current Work), Accessibility
matthiasmullie moved T328716: [S] Mobile search Preview not shown for articles with existing desktop search preview from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Mon, Mar 6, 1:11 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)

Thu, Mar 2

mfossati awarded T330516: Sections with images still appearing in the section-level image suggestions pipeline a Burninate token.
Thu, Mar 2, 2:21 PM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie claimed T330516: Sections with images still appearing in the section-level image suggestions pipeline.

A discrepancy in page title format (spaces vs underscores) between 2 datasets caused all multi-word titles to not have suggestions for sections with existing images pruned.
Fixing this brings the total number of remaining suggestions for the datasets used from 237406321 down to 178212325, or a 25% decrease.

Thu, Mar 2, 2:11 PM · Structured-Data-Backlog (Current Work), Section-Level-Image-Suggestions
matthiasmullie added a comment to T330073: Reset Phabricator 2FA for matthiasmullie.

Thanks a lot!

Thu, Mar 2, 11:06 AM · Phabricator

Wed, Mar 1

matthiasmullie added a comment to T330073: Reset Phabricator 2FA for matthiasmullie.

@Aklapper I'm not sure who to reach out to - any chance you could help me, or point me to someone who can? Thanks!

Wed, Mar 1, 2:51 PM · Phabricator

Feb 22 2023

matthiasmullie placed T268236: Add support for "phrase prefi*" queries in MediaSearch profile up for grabs.
Feb 22 2023, 10:51 AM · SDAW-MediaSearch, Structured-Data-Backlog
matthiasmullie placed T268237: Add support for fuzzy~2 queries in MediaSearch profile up for grabs.
Feb 22 2023, 10:50 AM · SDAW-MediaSearch, Structured-Data-Backlog
matthiasmullie placed T268238: Add support for prefi* queries in MediaSearch profile up for grabs.
Feb 22 2023, 10:50 AM · SDAW-MediaSearch, Structured-Data-Backlog
matthiasmullie placed T268239: Add support for w*ldcard queries in MediaSearch profile up for grabs.
Feb 22 2023, 10:50 AM · SDAW-MediaSearch, Structured-Data-Backlog

Feb 21 2023

matthiasmullie closed T329221: Search-thumbnail-extra-namespaces-message i18n question as Resolved.

Thanks, @MarcoAurelio!

Feb 21 2023, 5:58 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), User-MarcoAurelio, Discovery-Search (Current work), Structured-Data-Backlog, SDAW-MediaSearch, MediaWiki-Search, I18n
matthiasmullie committed rESVUdb5afc2242c9: Create wiki project interwiki link widgets and add to the quick view panel (authored by matthiasmullie).
Create wiki project interwiki link widgets and add to the quick view panel
Feb 21 2023, 3:09 PM
matthiasmullie committed rESVU71c6de63482b: Trigger an event when interacting with Interwiki Link section (authored by SimoneThisDot).
Trigger an event when interacting with Interwiki Link section
Feb 21 2023, 3:09 PM

Feb 20 2023

matthiasmullie added a comment to T329221: Search-thumbnail-extra-namespaces-message i18n question.

@MarcoAurelio sure, sounds good, thanks!

Feb 20 2023, 3:35 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), User-MarcoAurelio, Discovery-Search (Current work), Structured-Data-Backlog, SDAW-MediaSearch, MediaWiki-Search, I18n
matthiasmullie added a reverting change for rESVUbd7a277da3f1: Create wiki project interwiki link widgets and add to the quick view panel: rESVU5804d3def9db: Revert "Create wiki project interwiki link widgets and add to the quick view….
Feb 20 2023, 2:48 PM
matthiasmullie committed rESVU5804d3def9db: Revert "Create wiki project interwiki link widgets and add to the quick view… (authored by matthiasmullie).
Revert "Create wiki project interwiki link widgets and add to the quick view…
Feb 20 2023, 2:48 PM
matthiasmullie created T330073: Reset Phabricator 2FA for matthiasmullie.
Feb 20 2023, 12:24 PM · Phabricator

Feb 17 2023

matthiasmullie closed T327209: [S] Send image suggestions notifications for Feb 11 WMPT event as Resolved.

2nd round of notifications sent (608 to 19 users).

Feb 17 2023, 9:58 AM · Structured-Data-Backlog (Current Work), Image-Suggestions

Feb 13 2023

matthiasmullie added a project to T329459: IP Masking Considerations: MachineVision: Structured-Data-Backlog.
Feb 13 2023, 11:02 AM · Structured-Data-Backlog, IP Masking

Feb 10 2023

matthiasmullie added a comment to T327209: [S] Send image suggestions notifications for Feb 11 WMPT event.

560 notifications (35 per user, 16 users) have just been sent.
That's roughly 2/3 of the pages-with-suggestions in this category.

Feb 10 2023, 2:54 PM · Structured-Data-Backlog (Current Work), Image-Suggestions

Feb 6 2023

matthiasmullie moved T323036: [L] Exclude media topics from section topics dataset from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Feb 6 2023, 2:08 PM · Structured-Data-Backlog (Current Work), Section-Topics

Feb 3 2023

mfossati awarded T323036: [L] Exclude media topics from section topics dataset a Cup of Joe token.
Feb 3 2023, 11:03 AM · Structured-Data-Backlog (Current Work), Section-Topics
matthiasmullie closed T306272: [M] Notify a list of users on demand about image suggestions in a specific category as Resolved.

@CBogen Looks great, thanks!

Feb 3 2023, 7:58 AM · MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie closed T328136: Switch mobile Search Preview config to on as Resolved.

Closing this, as it was surpassed by T326957.

Feb 3 2023, 7:36 AM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)

Feb 2 2023

matthiasmullie added a comment to T323036: [L] Exclude media topics from section topics dataset .

There isn't too much consistency in the statements of media outlets (see a selection below)
Most have one or more P31 (instance of) statements that are one of these: (or a subclass thereof)

Feb 2 2023, 3:52 PM · Structured-Data-Backlog (Current Work), Section-Topics
matthiasmullie added a comment to T328136: Switch mobile Search Preview config to on.

Correct.
Enabling it via config change would've had to happen separate from deployment train, which would've meant doing it before deployment (running on last week's code) or after (only 1 more deployment slot left, at a rather inconvenient time for any of us)
Removing all conditionals from our repo (T326957) was simpler in this case (and has been backported yesterday); that will deploy per train - alongside the rest of the new code - while accomplishing the same result: it's enabled.
(I'll leave this open until it's actually been deployed, at which point we can close both tickets)

Feb 2 2023, 3:00 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)

Feb 1 2023

matthiasmullie added a comment to T327209: [S] Send image suggestions notifications for Feb 11 WMPT event.

Dry-runs with multiple configurations worked fine. Images within categories are found, users are being iterated over, etc etc.
Actual run with 3 account (2 notifications per account) seems to also have delivered notifications (for me at least; @CBogen you should have received 2x2 notifications as well)

Feb 1 2023, 3:43 PM · Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie added a comment to T327209: [S] Send image suggestions notifications for Feb 11 WMPT event.

The script manages to find 866 pages with suggestions within these categories (only 3 of which have a confidence below 80)
491 will be excluded if we filter out Q5 instances (375 pages remain)

Feb 1 2023, 3:38 PM · Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie added a comment to T327209: [S] Send image suggestions notifications for Feb 11 WMPT event.

How many images do we want to send per user? 2, like the other script, or more?
Do other filters (minimum suggestion confidence score of 80 & excluding instances of Q5) also apply here?
(I would imagine Q5 exclusion not to apply here, given thatmany categories are explicitly about people)

Feb 1 2023, 2:57 PM · Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie committed rESVU231cd08f52d0: Squashed diff to catch up to master (authored by matthiasmullie).
Squashed diff to catch up to master
Feb 1 2023, 2:07 PM
matthiasmullie committed rESVU488bbde82fa1: Remove mobile conditionals (authored by matthiasmullie).
Remove mobile conditionals
Feb 1 2023, 11:28 AM

Jan 31 2023

matthiasmullie claimed T328095: Mobile quick view - issues with displaying article card .
Jan 31 2023, 11:38 AM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)
matthiasmullie claimed T326957: [M] Remove configuration setting that turns off/on mobile Search Preview.
Jan 31 2023, 11:26 AM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)

Jan 30 2023

matthiasmullie moved T320647: [M] Mobile: Show wiki data description of the article in quick view from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 30 2023, 3:22 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie moved T326580: [M] Desktop preview hover area does not include the arrow area from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 30 2023, 1:40 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), SDAW-Search-Improvements (Milestone 2: QuickView MVP), Structured-Data-Backlog (Current Work)
matthiasmullie moved T326861: [S] [betalabs] Mobile - Search Preview displays Console errors for articles with apostrophe in the title from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 30 2023, 1:38 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements

Jan 26 2023

matthiasmullie moved T321001: [L] Mobile: Show Commons widget in the quick view panel from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 26 2023, 3:37 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)
matthiasmullie moved T320647: [M] Mobile: Show wiki data description of the article in quick view from Verify on Production to Needs Design on the Structured-Data-Backlog (Current Work) board.

I only just noticed this:

Jan 26 2023, 3:34 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie committed rESVUde37392b6f0d: Add keyboard navigation to Search Preview (authored by SimoneThisDot).
Add keyboard navigation to Search Preview
Jan 26 2023, 2:39 PM
matthiasmullie moved T326641: [L] Add ability to access and interact with the Search Preview with the keyboard only from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 26 2023, 2:36 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Accessibility, SDAW-Search-Improvements (Milestone 2: QuickView MVP), Structured-Data-Backlog (Current Work)

Jan 25 2023

matthiasmullie moved T327873: Result without body breaks the SearchVue extension from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 25 2023, 4:33 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), SDAW-Search-Improvements, SDAW-SearchVue, Structured-Data-Backlog (Current Work)

Jan 24 2023

matthiasmullie updated the task description for T270396: Implement backward navigation when JS is not supported.
Jan 24 2023, 2:15 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
matthiasmullie claimed T323036: [L] Exclude media topics from section topics dataset .
Jan 24 2023, 2:15 PM · Structured-Data-Backlog (Current Work), Section-Topics

Jan 23 2023

matthiasmullie committed rESVU4cdc48fe3620: Replace searchSatisfaction in SearchPreview event implementation (authored by SimoneThisDot).
Replace searchSatisfaction in SearchPreview event implementation
Jan 23 2023, 9:32 PM
matthiasmullie moved T326641: [L] Add ability to access and interact with the Search Preview with the keyboard only from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 23 2023, 9:56 AM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Accessibility, SDAW-Search-Improvements (Milestone 2: QuickView MVP), Structured-Data-Backlog (Current Work)

Jan 20 2023

matthiasmullie placed T318820: Provide compatible elasticsearch-oss (7.x) and wmf-elasticsearch-search-plugins for buster on WMF APT repo up for grabs.
Jan 20 2023, 9:16 AM · Discovery-Search (Current work)
matthiasmullie closed T318820: Provide compatible elasticsearch-oss (7.x) and wmf-elasticsearch-search-plugins for buster on WMF APT repo as Resolved.

Bullseye

Jan 20 2023, 9:16 AM · Discovery-Search (Current work)
matthiasmullie moved T320743: [L] Mobile: Create a Quick View component from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 20 2023, 7:56 AM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)

Jan 19 2023

matthiasmullie added a comment to T326663: [L] Update instrumentation & schema to track things for which we're currently relying on searchSatisfaction.js.
  • Generate a new sessionId every 10 minutes of inactivity (if the user has the screen on but does not interact for 30 minutes 3 "new-session" event are sent

I am not sure my 3rd point is correct, as the AC did not specify to emit a new-session event, but I guess we need to have the new session if we have a new sessionId.

Jan 19 2023, 3:28 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T326663: [L] Update instrumentation & schema to track things for which we're currently relying on searchSatisfaction.js.
Jan 19 2023, 2:48 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie moved T326345: [M] Reduce jumping of content in mobile preview animation from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 19 2023, 10:24 AM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)

Jan 17 2023

matthiasmullie added a comment to T310284: [L] Quick View: Create commons widget and add to the quickview panel.

most people expect this to be a link.

I am just curious who are we referring to here? Is it community feedback?

Jan 17 2023, 8:04 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP)

Jan 12 2023

matthiasmullie committed rESVU64c381f9b46c: Mobile: Loading indicator for search preview (authored by SimoneThisDot).
Mobile: Loading indicator for search preview
Jan 12 2023, 8:04 AM

Jan 11 2023

matthiasmullie added a comment to T326383: [wmf.17-minor] Special:Search preview overlapping elements on a page.

So as I understand correctly if anything is part of search results container it would tend to follow the 50em width in that case we won't have to worry about overlap.

Jan 11 2023, 4:38 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T253280: Per-file control for some thumbnail generation parameters .

There is not currently a way for other wikis to retrieve structured data (statements/captions) from Commons other than calling the Wikibase action APIs on commons.wikimedia.org.

Jan 11 2023, 2:51 PM · Thumbor Migration, MediaWiki-File-management, Commons, SDC General, Wikidata, Thumbor

Jan 10 2023

matthiasmullie updated subscribers of T326663: [L] Update instrumentation & schema to track things for which we're currently relying on searchSatisfaction.js.
Jan 10 2023, 5:51 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie closed T325569: Determine how to fix instrumentation for Search Preview on mobile as Resolved.
Jan 10 2023, 5:50 PM · Discovery-Search (Current work), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)
matthiasmullie updated the task description for T325569: Determine how to fix instrumentation for Search Preview on mobile.
Jan 10 2023, 5:50 PM · Discovery-Search (Current work), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)
matthiasmullie created T326663: [L] Update instrumentation & schema to track things for which we're currently relying on searchSatisfaction.js.
Jan 10 2023, 5:49 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), SDAW-Search-Improvements (Milestone 3: QuickView mobile), Structured-Data-Backlog (Current Work)
matthiasmullie added a member for Trusted-Contributors: StephaneRebai.
Jan 10 2023, 5:27 PM
matthiasmullie added a comment to T326383: [wmf.17-minor] Special:Search preview overlapping elements on a page.

Those wikidata results (.wdsearch_container) are not part of the search results container (.searchresults, the one where the min-height is set), so in this specific case, it's fairly easy to change & also make sure we don't overlap with that one (see above patch)

Jan 10 2023, 3:38 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T323650: [L] Search preview - Open images in commons widget in Multimedia Viewer.

Note: MultimediaViewer is deployed on nearly all wikis, so we could use it. I don't think it picks up on dynamically added content, so we'd have to invoke it ourselves; and I wouldn't be surprised if we'd also have to make some changes to the MultimediaViewer extension itself, but I'm pretty sure it could work.

Jan 10 2023, 3:03 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 4: Additional QuickView features)
matthiasmullie moved T310284: [L] Quick View: Create commons widget and add to the quickview panel from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 10 2023, 10:47 AM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP)
matthiasmullie added a comment to T326156: Fix CreditsSource drifts.

A bit of context: WikiVoyage was running running a very old MW version on postgres with a couple of custom extensions. There were a couple of Postgres-specific things that needed some refactoring before bringing to MySQL. Some extensions also shared tables, IIRC. CreditsSource was one of those extensions that were adopted when WikiVoyage was migrated to WMF and needed some tweaking.

Jan 10 2023, 9:36 AM · DBA

Jan 6 2023

matthiasmullie moved T321001: [L] Mobile: Show Commons widget in the quick view panel from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.

Moving back to QA since we're going to leave it as is for now.

Jan 6 2023, 9:43 AM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)

Jan 5 2023

matthiasmullie committed rESVUeef854536eb1: Fix URL construction (authored by matthiasmullie).
Fix URL construction
Jan 5 2023, 3:33 PM
matthiasmullie committed rESVU215a9ffb9790: Also get central description (authored by matthiasmullie).
Also get central description
Jan 5 2023, 2:21 PM
matthiasmullie committed rESVUbdc13940e822: Also get central description (authored by matthiasmullie).
Also get central description
Jan 5 2023, 2:10 PM
matthiasmullie committed rESVU954e6c09f4cf: Fix URL construction (authored by matthiasmullie).
Fix URL construction
Jan 5 2023, 2:05 PM
matthiasmullie updated subscribers of T326286: [minor-betalabs] interwiki links shown when scrolling Special:Search page with open QuickView.

AIUI, this is intentional/expected.
cc @Sneha to confirm.

Jan 5 2023, 1:58 PM · Structured-Data-Backlog, SDAW-Search-Improvements
matthiasmullie added a comment to T325831: [QA task] Special:Search quick preview - local vs central description .

It comes from the {{Short description}} template, which uses the {{SHORTDESC}} magic word. It allows (English) Wikipedia to explicitly override Wikidata descriptions everywhere. See T184000: Magic word on English WP to override display of Wikidata short description for more context.

Thanks! So if I understand that ticket correctly, we're using the magic word override if it exists, and if not we're using the wikidata description. I'm guessing on many wikis, that will mostly mean we're using the wikidata description, is that right?

Jan 5 2023, 1:33 PM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP)
matthiasmullie committed rESVU666e27f4f985: Also get central description (authored by matthiasmullie).
Also get central description
Jan 5 2023, 1:29 PM
matthiasmullie moved T310367: [L] Deploy SearchVue from Blocked to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 5 2023, 9:39 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, Wikimedia-extension-review-queue, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP), Wikimedia-Extension-setup, SDAW-SearchVue
matthiasmullie updated the task description for T310367: [L] Deploy SearchVue.
Jan 5 2023, 9:39 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, Wikimedia-extension-review-queue, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP), Wikimedia-Extension-setup, SDAW-SearchVue
matthiasmullie updated the task description for T310367: [L] Deploy SearchVue.
Jan 5 2023, 9:35 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, Wikimedia-extension-review-queue, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP), Wikimedia-Extension-setup, SDAW-SearchVue
matthiasmullie updated the task description for T310367: [L] Deploy SearchVue.
Jan 5 2023, 9:34 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), Patch-For-Review, Wikimedia-extension-review-queue, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP), Wikimedia-Extension-setup, SDAW-SearchVue

Jan 4 2023

matthiasmullie added a comment to T325831: [QA task] Special:Search quick preview - local vs central description .

It comes from the {{Short description}} template, which uses the {{SHORTDESC}} magic word. It allows (English) Wikipedia to explicitly override Wikidata descriptions everywhere. See T184000: Magic word on English WP to override display of Wikidata short description for more context.

Jan 4 2023, 4:52 PM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP)
matthiasmullie added a comment to T310284: [L] Quick View: Create commons widget and add to the quickview panel.

Looks like we had a regression with "In Wikimedia Commons" - per @Etonkovidova's comment, the text used to be black & show the icon, but it looks like that is no longer the case and it looks just like the other links, which is indeed confusing. That should certainly be fixed.

Jan 4 2023, 1:59 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 2: QuickView MVP)
matthiasmullie added a comment to T321001: [L] Mobile: Show Commons widget in the quick view panel.

If we're decoupling the "view more images" link from the images displayed, we're going to have to rethink a few more things: "view more images" only shows when there are more images available than those shown & if both searches are different, we no longer know that.

Jan 4 2023, 1:59 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-Search-Improvements (Milestone 3: QuickView mobile)
matthiasmullie moved T325779: [betalabs] wikidata enabled search quick view produces error - Cannot read properties of undefined (reading 'thumbnail') from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.

That was merged. Should be fixed now.

Jan 4 2023, 1:07 PM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), SDAW-Search-Improvements (Milestone 2: QuickView MVP), Structured-Data-Backlog (Current Work)
matthiasmullie committed rESVU36f08d50e26e: Squashed diff to catch up to wmf/1.40.0-wmf.17 (authored by matthiasmullie).
Squashed diff to catch up to wmf/1.40.0-wmf.17
Jan 4 2023, 9:00 AM

Jan 3 2023

matthiasmullie claimed T324428: Cross-wiki search overlap with footer when local search results are few.
Jan 3 2023, 3:31 PM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Structured-Data-Backlog (Current Work), CirrusSearch, Discovery-Search