Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (249 w, 4 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Thu, Aug 15

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

@LucasWerkmeister Yes - I'm in Stockholm. I'll take a look at your suggestion and then come find you!

Thu, Aug 15, 7:29 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Thu, Aug 1

matthiasmullie added a comment to T229473: Old "digital representation of" statement panels show as grayed out [due to cache].

Things >30d old will expire and get proper treatment, things < 8d should already have correct html in cache.
It's just the things in between, I believe. Basically the "active enough that it *is* in cache (most likely only when bot ran), but not really too active because it's not really recent".
I believe the bad caches size is small enough, the issue trivial enough, and the tempfix (?action=purge) easy enough, that we should not put more effort into it, and just let caches expire.

Thu, Aug 1, 7:30 AM · Structured Data Engineering, SDC-Statements (Other-statements-running), Multimedia

Fri, Jul 26

matthiasmullie added a project to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items: Structured-Data-Team-Current-Work.
Fri, Jul 26, 12:08 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Declined.
Fri, Jul 26, 12:07 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo as Declined.

It looks like we may not need wb_terms (or the redesigned store) at this time. Declining ticket for now.

Fri, Jul 26, 12:07 PM · Multimedia, Wikidata, SDC General, Structured Data Engineering
matthiasmullie closed T227847: Backfill terms index, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Declined.
Fri, Jul 26, 12:07 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227847: Backfill terms index as Declined.

I'll decline this task, since we probably won't end up wanting or needing wb_terms (not yet, at least).
This could be reopened if at some point later on we find that we do have a valid usecase for them.

Fri, Jul 26, 12:07 PM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

I was thinking it'd make most sense to use the existing code & structure already used by Wikidata.
But I've since learned about the reasons for not using wb_terms (I figured it was just a case of not having implemented it because there had not been a need for it yet)

Fri, Jul 26, 12:07 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

Confirmed fixed on test-commons.

Fri, Jul 26, 9:21 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia

Wed, Jul 24

matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

This may be something we'll want to cherry-pick (or postpone enabling other statement until new branch gets to commons, next Wed)

Wed, Jul 24, 3:02 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie moved T228807: Existing qualifiers do not appear in read-mode on the file page from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Wed, Jul 24, 3:01 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie claimed T228807: Existing qualifiers do not appear in read-mode on the file page.
Wed, Jul 24, 2:40 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie added a comment to T228808: Hide structured data on file pages for remote repositories.

I *think* this is a testcommons-specific edge case.
The SDC content should have 'display: none' by default on all other wikis, but since this one also has MediaInfo, it's actually getting displayed (but since it's not inside the own wiki's content div, it's not being hooked up properly)

Wed, Jul 24, 11:55 AM · Structured-Data-Backlog (Current Work), WikibaseMediaInfo, Structured-Data-Team-Current-Work
matthiasmullie claimed T228849: 'Discard changes?' confirm box does not appear for statements.
Wed, Jul 24, 11:51 AM · SDC-Statements (Other-statements-running), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Structured-Data-Team-Current-Work, Structured Data Engineering, WikibaseMediaInfo, Multimedia
matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

Can you still reproduce this? Or anyone else?
I can see the qualifiers immediately, both logged in & out.

Wed, Jul 24, 11:28 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia

Jul 18 2019

matthiasmullie closed T227282: Selenium test runner should notify SDC team when it detects failures as Resolved.

Closing - we're getting notifications in Slack!

Jul 18 2019, 6:46 AM · Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work

Jul 16 2019

Nicolas_Raoul awarded T227798: "Add a caption" is broken a Like token.
Jul 16 2019, 11:29 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 15 2019

matthiasmullie updated the task description for T227226: Only Depicts statement panels should have Learn More links (for now).
Jul 15 2019, 4:37 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie reassigned T227226: Only Depicts statement panels should have Learn More links (for now) from Cparle to Edtadros.
Jul 15 2019, 4:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie reassigned T227798: "Add a caption" is broken from matthiasmullie to Edtadros.
Jul 15 2019, 4:05 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 12 2019

matthiasmullie claimed T227798: "Add a caption" is broken.
Jul 12 2019, 12:10 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T227847: Backfill terms index.

Nope, you're not mixing it up with something else; it is indeed undergoing redesign.
I've created T227848 to look into that, and what it'd mean in this context.

Jul 12 2019, 8:54 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie closed T227056: [Spike 2 days] Plan to access SDC data from Lua, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Resolved.
Jul 12 2019, 8:00 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227056: [Spike 2 days] Plan to access SDC data from Lua as Resolved.

As mentioned in T223792: Current Wikibase Lua support seems able to deal with MediaInfo entities already - it just can't find them.
If we start writing MediaInfo entities to wb_terms, it all starts to work.
However:

  • we'll need to run a maintenance script to populate the index for older entities: T227847
  • IIRC, wb_terms is currently undergoing redesign/migration - we need to figure out what that means for us (wait until that is done? migrate? how?) T227848

I've create new tickets for those things, and am considering this one done.

Jul 12 2019, 8:00 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Spike, Multimedia
matthiasmullie created T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo.
Jul 12 2019, 7:56 AM · Multimedia, Wikidata, SDC General, Structured Data Engineering
matthiasmullie edited projects for T227847: Backfill terms index, added: Structured Data Engineering; removed MediaWiki-extensions-WikibaseClient.
Jul 12 2019, 7:49 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie removed projects from T227847: Backfill terms index: Wikidata, Wikibase-Lua.
Jul 12 2019, 7:49 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie created T227847: Backfill terms index.
Jul 12 2019, 7:49 AM · Structured Data Engineering, Multimedia, SDC General
matthiasmullie added a subtask for T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items: T227056: [Spike 2 days] Plan to access SDC data from Lua.
Jul 12 2019, 7:44 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a parent task for T227056: [Spike 2 days] Plan to access SDC data from Lua: T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.
Jul 12 2019, 7:44 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Spike, Multimedia
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

It looks like the Wikibase Lua support can mostly deal with MediaInfo already, except that it can't look up the MediaInfo entities.
Unlike Wikibase properties & items, MediaInfo entities are not currently stored in wb_terms.
If MediaInfo starts writing to wb_terms, Lua's functions also start working.
wb_terms is in the process of being redesigned/migrated, though, and I have yet to look into that.

Jul 12 2019, 7:36 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Jul 11 2019

matthiasmullie created T227798: "Add a caption" is broken.
Jul 11 2019, 4:32 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Multimedia, Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 9 2019

matthiasmullie placed T227274: File page: qualifiers not displayed just after they've been added up for grabs.
Jul 9 2019, 9:21 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie updated the task description for T227274: File page: qualifiers not displayed just after they've been added.
Jul 9 2019, 9:20 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie placed T226181: Odd behaviour when editing qualifier property type but not value up for grabs.
Jul 9 2019, 9:19 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie placed T225102: Refactor UW statements code up for grabs.
Jul 9 2019, 9:11 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Jul 8 2019

matthiasmullie claimed T227274: File page: qualifiers not displayed just after they've been added.
Jul 8 2019, 10:42 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Jul 4 2019

matthiasmullie moved T227282: Selenium test runner should notify SDC team when it detects failures from To Do to Blocked on the Structured-Data-Team-Current-Work board.
Jul 4 2019, 1:54 PM · Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T227282: Selenium test runner should notify SDC team when it detects failures.

Should be done (slack notification) - won't be able to test until patch for T219815 gets merged

Jul 4 2019, 1:54 PM · Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
matthiasmullie created T227282: Selenium test runner should notify SDC team when it detects failures.
Jul 4 2019, 1:27 PM · Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T227278: Write selenium tests for QA checklist.

@Ramsey-WMF At the offsite, we've been playing with the idea of gradually converting the QA checklist to automated tests.
We can start picking them off one by one, but since you created the QA checklist originally, and have best insight in "the future", I thought you might want to prioritize things differently.
If you're ok with us just going through them in whatever order we feel like, that's fine too - just let me know here and I'll update the acceptance criteria.

Jul 4 2019, 1:14 PM · Structured-Data-Backlog, Structured Data Engineering
matthiasmullie created T227278: Write selenium tests for QA checklist.
Jul 4 2019, 1:11 PM · Structured-Data-Backlog, Structured Data Engineering

Jul 2 2019

matthiasmullie created T227116: Enhanced support for geo-coordinate Wikibase datatype.
Jul 2 2019, 4:56 PM · Structured-Data-Backlog, Structured Data Engineering
matthiasmullie updated the task description for T224060: Add support for geo-coordinate Wikibase datatype.
Jul 2 2019, 4:53 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, Structured Data Engineering
matthiasmullie updated the task description for T227112: Add UI support for time Wikibase datatype.
Jul 2 2019, 4:31 PM · Structured-Data-Backlog, SDC-Statements (Other-statements-running), Structured Data Engineering
matthiasmullie updated the task description for T224060: Add support for geo-coordinate Wikibase datatype.
Jul 2 2019, 4:30 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, Structured Data Engineering
Restricted Application changed the subtype of T227056: [Spike 2 days] Plan to access SDC data from Lua from "Deadline" to "Spike".
Jul 2 2019, 6:33 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Spike, Multimedia

Jun 21 2019

matthiasmullie merged T226234: [Placeholder] Support geographic coordinates datatype into T224060: Add support for geo-coordinate Wikibase datatype.
Jun 21 2019, 4:09 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, Structured Data Engineering
matthiasmullie merged task T226234: [Placeholder] Support geographic coordinates datatype into T224060: Add support for geo-coordinate Wikibase datatype.
Jun 21 2019, 4:09 PM · Structured Data Engineering, Multimedia
matthiasmullie moved T226181: Odd behaviour when editing qualifier property type but not value from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Jun 21 2019, 12:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie claimed T226181: Odd behaviour when editing qualifier property type but not value.
Jun 21 2019, 12:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie added a comment to T226234: [Placeholder] Support geographic coordinates datatype.

Above is minimal acceptance criteria.
This could be implemented in many different ways: (TBD)

  • do we want to display a map in addition to/instead of only coordinates (for viewing - like wikidata does)?
  • do we want 1 input field for input (in 27°59'17"N, 86°55'31"E format, like wikidata)? or multiple for latitude/longitude?
  • or a map where one can click a location
  • or geocode an address
  • any combination of above?
Jun 21 2019, 8:11 AM · Structured Data Engineering, Multimedia
Restricted Application added a project to T226234: [Placeholder] Support geographic coordinates datatype: Multimedia.
Jun 21 2019, 8:08 AM · Structured Data Engineering, Multimedia

Jun 20 2019

matthiasmullie closed T225148: "Add metadata" in Wikimedia Upload Wizard fails to save as Resolved.

Production Commons. We probably shouldn't throw test garbage at it - let's assume it's fine until we hear otherwise?

Jun 20 2019, 4:03 PM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie reassigned T226101: Switching properties with different datatype doesn't update input field if it's blank from matthiasmullie to Edtadros.
Jun 20 2019, 11:24 AM · SDC-Statements (Depicts-on-training-wheels), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Multimedia, Structured Data Engineering
matthiasmullie closed T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind as Resolved.

This fix was now backported to the currently deployed branch.
This works.

Jun 20 2019, 11:21 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie reassigned T225148: "Add metadata" in Wikimedia Upload Wizard fails to save from matthiasmullie to Edtadros.
Jun 20 2019, 11:19 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie moved T225148: "Add metadata" in Wikimedia Upload Wizard fails to save from Blocked to Needs QA on the Structured-Data-Team-Current-Work board.

The rate limit has been increased, up to 120 edits (every statement counts as 1) per 15 minutes for newbie users. This should allow for a reasonable batch of images/statements to be submitted.

Jun 20 2019, 11:18 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie added a comment to T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind.

Looks like testcommons also got rolled back, so the failure is ok - the fix isn't there anymore. Let's test again next week :)

Jun 20 2019, 7:08 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Jun 19 2019

matthiasmullie reassigned T226103: Qualifiers property autocomplete doesn't work on beta from matthiasmullie to Edtadros.
Jun 19 2019, 4:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie moved T226103: Qualifiers property autocomplete doesn't work on beta from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 4:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie reassigned T226096: Empty depicts statements display 'unsupported datatype' message from matthiasmullie to Edtadros.
Jun 19 2019, 2:26 PM · SDC-Statements (Other-statements-running), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie moved T226096: Empty depicts statements display 'unsupported datatype' message from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 2:26 PM · SDC-Statements (Other-statements-running), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie moved T225099: Use the real datatype for a selected property (in UW) instead of hardcoding wikibase-entityid from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 2:26 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
matthiasmullie moved T224040: Qualifier properties should chosen via autosuggest instead of a dropdown from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 1:44 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie moved T226103: Qualifiers property autocomplete doesn't work on beta from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 1:21 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie moved T226101: Switching properties with different datatype doesn't update input field if it's blank from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 1:21 PM · SDC-Statements (Depicts-on-training-wheels), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Multimedia, Structured Data Engineering
Restricted Application added a project to T226103: Qualifiers property autocomplete doesn't work on beta: Multimedia.
Jun 19 2019, 1:12 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Restricted Application added a project to T226101: Switching properties with different datatype doesn't update input field if it's blank: Multimedia.
Jun 19 2019, 1:09 PM · SDC-Statements (Depicts-on-training-wheels), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Multimedia, Structured Data Engineering
matthiasmullie added a comment to T208539: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php.

@Umherirrender Can you take a look at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/510893 to see whether you think this would also adequately solve this task?

Jun 19 2019, 12:10 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Multimedia, MediaWiki-Uploading, Wikimedia-production-error
matthiasmullie moved T224498: Add dedicated "remove" controls to the "Add Statement" input from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 11:59 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Multimedia, SDC-Statements (Other-statements-running), Structured-Data-Team-Current-Work
matthiasmullie moved T226096: Empty depicts statements display 'unsupported datatype' message from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Jun 19 2019, 11:56 AM · SDC-Statements (Other-statements-running), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Restricted Application added a project to T226096: Empty depicts statements display 'unsupported datatype' message: Multimedia.
Jun 19 2019, 11:56 AM · SDC-Statements (Other-statements-running), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Jun 18 2019

matthiasmullie reassigned T224703: Newly added depicted items don’t show Wikidata logo from matthiasmullie to Edtadros.
Jun 18 2019, 2:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements, Multimedia
matthiasmullie updated the task description for T224703: Newly added depicted items don’t show Wikidata logo.
Jun 18 2019, 2:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements, Multimedia

Jun 17 2019

matthiasmullie reassigned T215644: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) from Esanders to PDrouin-WMF.

This thread has become a little long and confusing.

Jun 17 2019, 9:40 AM · Structured-Data-Design, Structured-Data-Backlog, Structured Data Engineering, SDC-Statements (UI-consolidation-on-a-Ferris-wheel), OOUI (OOUI-0.32.0), SDC Design
matthiasmullie added a comment to T215644: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs).

Erm ... I think we're using the framed one, would be nice if it wasn't deleted

Jun 17 2019, 9:34 AM · Structured-Data-Design, Structured-Data-Backlog, Structured Data Engineering, SDC-Statements (UI-consolidation-on-a-Ferris-wheel), OOUI (OOUI-0.32.0), SDC Design
matthiasmullie merged task T225358: Upload Wizard need improvement for metadata into T224890: Depicts: uploading multiple images issue.
Jun 17 2019, 9:29 AM · Multimedia, Commons, UploadWizard
matthiasmullie merged T225358: Upload Wizard need improvement for metadata into T224890: Depicts: uploading multiple images issue.
Jun 17 2019, 9:29 AM · Structured-Data-Design, Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured-Data-Team-Current-Work, SDC Design
matthiasmullie reassigned T224625: On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element from matthiasmullie to Edtadros.
Jun 17 2019, 8:59 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Depicts-on-training-wheels), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Jun 14 2019

matthiasmullie claimed T224703: Newly added depicted items don’t show Wikidata logo.
Jun 14 2019, 12:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements, Multimedia
matthiasmullie moved T224703: Newly added depicted items don’t show Wikidata logo from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Jun 14 2019, 12:11 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements, Multimedia

Jun 12 2019

matthiasmullie closed T224817: Fatal error from action=wbgetentities API for certain batch requests as Resolved.
Jun 12 2019, 4:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie reassigned T222361: UploadWizard should indicate that statements are being submitted from egardner to Edtadros.
Jun 12 2019, 4:11 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Structured-Data-Team-Current-Work, Multimedia, Structured Data Engineering
matthiasmullie reassigned T224817: Fatal error from action=wbgetentities API for certain batch requests from matthiasmullie to Edtadros.
Jun 12 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie reassigned T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind from matthiasmullie to Edtadros.
Jun 12 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie reassigned T224624: Quantity qualifier value box is not visible on smartphones from matthiasmullie to Edtadros.
Jun 12 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie claimed T225148: "Add metadata" in Wikimedia Upload Wizard fails to save.
Jun 12 2019, 2:34 PM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie moved T225148: "Add metadata" in Wikimedia Upload Wizard fails to save from To Do to Blocked on the Structured-Data-Team-Current-Work board.
Jun 12 2019, 2:34 PM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie claimed T224625: On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element.

It's pretty easy to fix (patch up for review), but:

  • this is default Firefox behavior
  • and while OOUI adds its own in-/decrease controls, it doesn't override that behavior

I'm not sure whether or not there's a good reason that this is not already handled in OOUI, so pinging @Volker_E for input.

Jun 12 2019, 10:25 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Depicts-on-training-wheels), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Jun 11 2019

matthiasmullie added a comment to T225150: [Test Commons] Structured data edits either take long to show or cause edit conflicts.

Is there any consistency between devices/browsers? Has this been seen anywhere other than Opera? (I've never had it on Chrome and have not used other browsers extensively)
Since a hard refresh fixes things, I'd guess the browser caches too aggressively (or we instruct it to, with poor HTTP cache control headers)

Jun 11 2019, 8:59 AM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie added a comment to T223916: Adding qualifiers results in the wrong button being focused.

Oops! I messed up the order of add/focus operations, causing focus to stop working. Patch up, will be fixed shortly!

Jun 11 2019, 8:40 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Jun 6 2019

matthiasmullie moved T224817: Fatal error from action=wbgetentities API for certain batch requests from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 6 2019, 9:48 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured Data Engineering, Structured-Data-Team-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie moved T224624: Quantity qualifier value box is not visible on smartphones from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Jun 6 2019, 9:48 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie moved T219407: UI for adding statements in UploadWizard (Q-items only, no qualifiers) from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 6 2019, 9:47 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Other-statements-running), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
matthiasmullie moved T224461: Non-default statements greyed out from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Jun 6 2019, 9:47 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie added a project to T225099: Use the real datatype for a selected property (in UW) instead of hardcoding wikibase-entityid: SDC-Statements (Other-statements-running).
Jun 6 2019, 9:46 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), SDC-Statements (Other-statements-running), Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
matthiasmullie added a project to T225102: Refactor UW statements code: SDC-Statements (Other-statements-running).
Jun 6 2019, 9:46 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie merged T219787: Empty qualifiers should be removed when switching back to read mode into T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind.
Jun 6 2019, 9:44 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
matthiasmullie merged task T219787: Empty qualifiers should be removed when switching back to read mode into T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind.
Jun 6 2019, 9:44 AM · SDC-Statements (Depicts-on-training-wheels), Structured Data Engineering, Multimedia