Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (241 w, 10 h)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Yesterday

matthiasmullie reassigned T224703: Newly added depicted items don’t show Wikidata logo from matthiasmullie to Edtadros.
Tue, Jun 18, 2:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, SDC-Statements, Multimedia
matthiasmullie updated the task description for T224703: Newly added depicted items don’t show Wikidata logo.
Tue, Jun 18, 2:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, SDC-Statements, Multimedia

Mon, Jun 17

matthiasmullie reassigned T215644: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) from Esanders to PDrouin-WMF.

This thread has become a little long an confusing.

Mon, Jun 17, 9:40 AM · Multimedia-Current-Work, OOUI (OOUI-0.32.0), SDC Design, Multimedia
matthiasmullie added a comment to T215644: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs).

Erm ... I think we're using the framed one, would be nice if it wasn't deleted

Mon, Jun 17, 9:34 AM · Multimedia-Current-Work, OOUI (OOUI-0.32.0), SDC Design, Multimedia
matthiasmullie merged task T225358: Upload Wizard need improvement for metadata into T224890: Depicts: uploading multiple images issue.
Mon, Jun 17, 9:29 AM · Multimedia, Commons, UploadWizard
matthiasmullie merged T225358: Upload Wizard need improvement for metadata into T224890: Depicts: uploading multiple images issue.
Mon, Jun 17, 9:29 AM · SDC-Statements (Other-statements-running), Multimedia-Current-Work, Multimedia, SDC Design
matthiasmullie reassigned T224625: On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element from matthiasmullie to Edtadros.
Mon, Jun 17, 8:59 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia

Fri, Jun 14

matthiasmullie claimed T224703: Newly added depicted items don’t show Wikidata logo.
Fri, Jun 14, 12:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, SDC-Statements, Multimedia
matthiasmullie moved T224703: Newly added depicted items don’t show Wikidata logo from To Do to Code Review on the Multimedia-Current-Work board.
Fri, Jun 14, 12:11 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, SDC-Statements, Multimedia

Wed, Jun 12

matthiasmullie closed T224817: Fatal error from action=wbgetentities API for certain batch requests as Resolved.
Wed, Jun 12, 4:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie reassigned T222361: UploadWizard should indicate that statements are being submitted from egardner to Edtadros.
Wed, Jun 12, 4:11 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
matthiasmullie reassigned T224817: Fatal error from action=wbgetentities API for certain batch requests from matthiasmullie to Edtadros.
Wed, Jun 12, 4:10 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie reassigned T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind from matthiasmullie to Edtadros.
Wed, Jun 12, 4:10 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie reassigned T224624: Quantity qualifier value box is not visible on smartphones from matthiasmullie to Edtadros.
Wed, Jun 12, 4:10 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie claimed T225148: "Add metadata" in Wikimedia Upload Wizard fails to save.
Wed, Jun 12, 2:34 PM · Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie moved T225148: "Add metadata" in Wikimedia Upload Wizard fails to save from To Do to Blocked on the Multimedia-Current-Work board.
Wed, Jun 12, 2:34 PM · Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia, UploadWizard, Wikidata
matthiasmullie claimed T224625: On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element.

It's pretty easy to fix (patch up for review), but:

  • this is default Firefox behavior
  • and while OOUI adds its own in-/decrease controls, it doesn't override that behavior

I'm not sure whether or not there's a good reason that this is not already handled in OOUI, so pinging @Volker_E for input.

Wed, Jun 12, 10:25 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia

Tue, Jun 11

matthiasmullie added a comment to T225150: [Test Commons] Structured data edits either take long to show or cause edit conflicts.

Is there any consistency between devices/browsers? Has this been seen anywhere other than Opera? (I've never had it on Chrome and have not used other browsers extensively)
Since a hard refresh fixes things, I'd guess the browser caches too aggressively (or we instruct it to, with poor HTTP cache control headers)

Tue, Jun 11, 8:59 AM · Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T223916: Adding qualifiers results in the wrong button being focused.

Oops! I messed up the order of add/focus operations, causing focus to stop working. Patch up, will be fixed shortly!

Tue, Jun 11, 8:40 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia

Thu, Jun 6

matthiasmullie moved T224817: Fatal error from action=wbgetentities API for certain batch requests from Code Review to Needs QA on the Multimedia-Current-Work board.
Thu, Jun 6, 9:48 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie moved T224624: Quantity qualifier value box is not visible on smartphones from Doing to Code Review on the Multimedia-Current-Work board.
Thu, Jun 6, 9:48 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie moved T219407: UI for adding statements in UploadWizard (Q-items only, no qualifiers) from Code Review to Needs QA on the Multimedia-Current-Work board.
Thu, Jun 6, 9:47 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T224461: Non-default statements greyed out from Code Review to Needs QA on the Multimedia-Current-Work board.
Thu, Jun 6, 9:47 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie added a project to T225099: Use the real datatype for a selected property (in UW) instead of hardcoding wikibase-entityid: SDC-Statements (Other-statements-running).
Thu, Jun 6, 9:46 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie added a project to T225102: Refactor UW statements code: SDC-Statements (Other-statements-running).
Thu, Jun 6, 9:46 AM · SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie merged T219787: Empty qualifiers should be removed when switching back to read mode into T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind.
Thu, Jun 6, 9:44 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie merged task T219787: Empty qualifiers should be removed when switching back to read mode into T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind.
Thu, Jun 6, 9:44 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia
matthiasmullie added a comment to T224624: Quantity qualifier value box is not visible on smartphones.

@PDrouin-WMF: Are we also ok with the dropdown having the length of the input field + delete icon?
(because I'd otherwise have to subtract the icon's size from the dropdown's length, but that's defined in OOUI and could change beyond our control)

Thu, Jun 6, 8:51 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie added a comment to T225099: Use the real datatype for a selected property (in UW) instead of hardcoding wikibase-entityid.

It looks like mw.config.get( 'wbDataTypes' ) already holds this map!
wbDataTypes won't exist on Special:UploadWizard, but we should probably let WikibaseMediaInfo expose a similar (or the exact same) map, in the same way it already does wbmiProperties (and a few others) so that they're always available, even for UploadWizard.

Thu, Jun 6, 7:52 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Wed, Jun 5

Restricted Application added a project to T225102: Refactor UW statements code: Multimedia.
Wed, Jun 5, 2:33 PM · SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia
Restricted Application added a project to T225099: Use the real datatype for a selected property (in UW) instead of hardcoding wikibase-entityid: Multimedia.
Wed, Jun 5, 2:29 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia-Current-Work, Multimedia

Tue, Jun 4

matthiasmullie moved T224624: Quantity qualifier value box is not visible on smartphones from To Do to Doing on the Multimedia-Current-Work board.
Tue, Jun 4, 11:49 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie claimed T224624: Quantity qualifier value box is not visible on smartphones.
Tue, Jun 4, 11:48 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie moved T222361: UploadWizard should indicate that statements are being submitted from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, Jun 4, 11:48 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Design, SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Multimedia, SDC Engineering
matthiasmullie moved T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind from Doing to Code Review on the Multimedia-Current-Work board.
Tue, Jun 4, 11:22 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie moved T224817: Fatal error from action=wbgetentities API for certain batch requests from To Do to Code Review on the Multimedia-Current-Work board.
Tue, Jun 4, 10:58 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie claimed T224817: Fatal error from action=wbgetentities API for certain batch requests.
Tue, Jun 4, 10:57 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC Engineering, Multimedia-Current-Work, Wikidata, Wikidata-Campsite, Multimedia, WikibaseMediaInfo, Wikimedia-production-error

Mon, Jun 3

matthiasmullie claimed T224639: Attempting to add a qualifier and then cancelling leaves a "trace" behind.
Mon, Jun 3, 3:27 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work

Wed, May 29

matthiasmullie added a comment to T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.

So basically, the feature here is changing the qualifier property dropdown (with values 'color', 'wears', etc) to an autocomplete input field (that only autocompletes properties of a certain data type)
The filtering by supported data type is already implemented for 'add statement' as well (only statements of type wikibase-item can be selected there), so we should be able to lean on that work for the autocomplete.

Wed, May 29, 6:46 PM · Patch-For-Review, SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.

They shouldn't be able to search for datatypes, but for 'properties' (and we'll narrow it down to only properties of a certain datatype, but users don't need to be aware of datatypes)

Wed, May 29, 6:43 PM · Patch-For-Review, SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T224498: Add dedicated "remove" controls to the "Add Statement" input.

I think Eric is referring to the input field for selecting a new property, like this:

Wed, May 29, 9:25 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Multimedia, SDC-Statements (Other-statements-running), Multimedia-Current-Work

Tue, May 28

matthiasmullie moved T221861: Structured Data table overflows when wikidata label is too long from Needs QA to Verify on Production on the Multimedia-Current-Work board.

Actually, let's move this to "Verify on Production", since there's nothing new to test, and the example (and fix) are already in prod.

Tue, May 28, 2:49 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons
matthiasmullie updated the task description for T221861: Structured Data table overflows when wikidata label is too long.
Tue, May 28, 2:48 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons
matthiasmullie moved T221861: Structured Data table overflows when wikidata label is too long from Doing to Needs QA on the Multimedia-Current-Work board.

Yes, should be fixed already. Moving to Needs QA for verification.

Tue, May 28, 2:47 PM · SDC Engineering, Multimedia-Current-Work, Multimedia, I18n, StructuredDataOnCommons, Commons
matthiasmullie updated the task description for T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.
Tue, May 28, 11:38 AM · Patch-For-Review, SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T224040: Qualifier properties should chosen via autosuggest instead of a dropdown.

'string' is also (theoretically) already supported (though let's test it just to make sure)
So valid qualifier data types: wikibase-item, qualifier, string

Tue, May 28, 11:36 AM · Patch-For-Review, SDC-Statements (Other-statements-running), Multimedia-Current-Work, SDC Engineering, Multimedia

Fri, May 24

matthiasmullie added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Most of that code is somewhere in WikibaseMediaInfoHooks::doBeforePageDisplay (and the various methods called from there)
That method is run via a hook shortly before everything gets output.
Basically, the content is already there (from parser cache, or generated at that time) and the code in that method will extract it from that location, do some things with it (e.g. add tabs) and move some bits and pieces around.
All of that happens after the parser cache, so should probably be fine.

Fri, May 24, 3:48 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work
matthiasmullie added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

That's because the captions panel is inside <div id="mw-imagepage-content">, which has lang="en", dir="ltr" and class="mw-content-ltr".
It makes sense that that one has LTR, because it indicates the start of the "content" of the page (not the interface), which on that page, on Commons, is English.

Fri, May 24, 3:35 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), SDC Engineering, RTL, I18n, Multimedia, Multimedia-Current-Work

Tue, May 21

matthiasmullie placed T218435: Alignment of Search help text is off when switching between modes (Alpha/Labs) up for grabs.
Tue, May 21, 11:25 AM · SDC Engineering, Multimedia-Current-Work, SDC-Statements (Depicts-on-training-wheels), Multimedia
matthiasmullie updated the task description for T223321: [Beta Commons] Attempting to add qualifiers when logged out repeatedly triggers IP address log warning.
Tue, May 21, 11:18 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T223321: [Beta Commons] Attempting to add qualifiers when logged out repeatedly triggers IP address log warning from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, May 21, 11:17 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie reassigned T223321: [Beta Commons] Attempting to add qualifiers when logged out repeatedly triggers IP address log warning from matthiasmullie to Edtadros.
Tue, May 21, 11:17 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T223916: Adding qualifiers results in the wrong button being focused from To Do to Code Review on the Multimedia-Current-Work board.
Tue, May 21, 11:17 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T223324: [Beta Commons] Auto-suggest dropdown menu for qualifier values does not appear.

@WMDE-leszek that worked, thanks!

Tue, May 21, 10:59 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie moved T223655: Wikidata icon doesn't align with property link in statements widget when secondary statement label is present from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, May 21, 7:46 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie moved T223432: Captions mobile improvements from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, May 21, 7:46 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
matthiasmullie moved T223321: [Beta Commons] Attempting to add qualifiers when logged out repeatedly triggers IP address log warning from To Do to Code Review on the Multimedia-Current-Work board.
Tue, May 21, 7:46 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia

May 17 2019

matthiasmullie added a comment to T223448: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given.

As I understand it, when doing async uploads:

May 17 2019, 1:28 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia, UploadWizard, Wikimedia-production-error
matthiasmullie added a comment to T223432: Captions mobile improvements.

I suspect "cancel/publish" should be in the same row as "add a caption" if there's enough space, and drop down below it if the screen becomes too small to fit all
(that's how it's done for statements, with "remove statements/learn more" instead of "add a caption")

May 17 2019, 10:32 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
matthiasmullie added a comment to T218620: [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field.

https://federated-commons.wmflabs.org/wiki/Main_Page (also added to acceptance criteria)

May 17 2019, 10:28 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie updated the task description for T218620: [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field.
May 17 2019, 10:28 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia

May 16 2019

matthiasmullie added a comment to T223324: [Beta Commons] Auto-suggest dropdown menu for qualifier values does not appear.

Oh cool - didn't know you could list properties by value datatype - might already have a few I won't need to create!

May 16 2019, 4:30 PM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie added a comment to T221228: Depicts widget has a couple of visual quirks on mobile/small screens.

The first (wikidata logo) has a patch already: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/510721

May 16 2019, 3:44 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
matthiasmullie moved T218951: Make button placement for Captions consistent with Depicts/statements from Needs QA to Verify on Production on the Multimedia-Current-Work board.
May 16 2019, 10:16 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T218951: Make button placement for Captions consistent with Depicts/statements from Code Review to Needs QA on the Multimedia-Current-Work board.
May 16 2019, 10:15 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, SDC Design, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie reassigned T221228: Depicts widget has a couple of visual quirks on mobile/small screens from matthiasmullie to PDrouin-WMF.

Assigning to @PDrouin-WMF to verify this is fixed.

May 16 2019, 10:15 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
matthiasmullie reassigned T222107: Depicts panel heading/url/button text alignment is off from matthiasmullie to PDrouin-WMF.

Assigning to @PDrouin-WMF to verify this is fixed.

May 16 2019, 10:15 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T222107: Depicts panel heading/url/button text alignment is off from Code Review to Needs QA on the Multimedia-Current-Work board.
May 16 2019, 10:13 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T221228: Depicts widget has a couple of visual quirks on mobile/small screens from Code Review to Needs QA on the Multimedia-Current-Work board.
May 16 2019, 10:13 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
matthiasmullie updated the task description for T223432: Captions mobile improvements.
May 16 2019, 10:12 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
matthiasmullie closed T221658: Poor/non-functional experience on mobile [Epic] as Resolved.

This ticket is about both captions & statements.

May 16 2019, 10:12 AM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie updated the task description for T221228: Depicts widget has a couple of visual quirks on mobile/small screens.
May 16 2019, 10:09 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
matthiasmullie created T223432: Captions mobile improvements.
May 16 2019, 10:07 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Multimedia-Current-Work, Multimedia, SDC Engineering
matthiasmullie added a comment to T223321: [Beta Commons] Attempting to add qualifiers when logged out repeatedly triggers IP address log warning.

"first attempt to edit", is this:

  • every time one goes into edit mode, not for any other change after that
  • only when user goes into edit mode for the first time for this statement
  • only when user goes into edit mode for the first time for any statement (= if this was already displayed for another statement, we're not showing it again)
  • only ever once, for statements OR captions, for whichever is first (making changes to captions, statements, captions again, ... = still only one notification for the very first change, and none after)
May 16 2019, 7:25 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T223324: [Beta Commons] Auto-suggest dropdown menu for qualifier values does not appear from To Do to Blocked on the Multimedia-Current-Work board.
May 16 2019, 7:14 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie placed T223324: [Beta Commons] Auto-suggest dropdown menu for qualifier values does not appear up for grabs.
May 16 2019, 7:14 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie added a comment to T223324: [Beta Commons] Auto-suggest dropdown menu for qualifier values does not appear.

The properties have the wrong value datatype.
They're all 'string' (which is why it's just a plain input field), but it should be 'Item' for most, and 'Quantity' for quantity.

May 16 2019, 7:14 AM · SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie moved T221658: Poor/non-functional experience on mobile [Epic] from Doing to Code Review on the Multimedia-Current-Work board.
May 16 2019, 6:46 AM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work

May 13 2019

matthiasmullie updated subscribers of T222979: File reuse links for audio files overlap the audio player (when not being logged in).

I have no permissions to edit this gadget, so...

May 13 2019, 10:02 AM · Multimedia-Current-Work, Multimedia

May 10 2019

matthiasmullie moved T222107: Depicts panel heading/url/button text alignment is off from To Do to Code Review on the Multimedia-Current-Work board.
May 10 2019, 12:33 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie claimed T221228: Depicts widget has a couple of visual quirks on mobile/small screens.
May 10 2019, 12:33 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multimedia-Current-Work, SDC Design, Multimedia, SDC Engineering
matthiasmullie claimed T221658: Poor/non-functional experience on mobile [Epic].
May 10 2019, 12:33 PM · Patch-For-Review, Epic, SDC Design, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie claimed T222107: Depicts panel heading/url/button text alignment is off.
May 10 2019, 12:32 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie renamed T218803: [Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter from [Spike] investigate how much effort would be involved in wrapping wikibase.mediainfo.statements in an Adapter to [Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter.
May 10 2019, 6:10 AM · SDC Engineering, Multimedia

May 9 2019

matthiasmullie closed T222138: interwiki items are formatted as NonExistingEntityId in text/html when no label exists in requested language as Resolved.

It works! Thanks

May 9 2019, 11:46 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, SDC Engineering, Multimedia, Multimedia-Current-Work, Wikidata
matthiasmullie closed T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language as Resolved.
May 9 2019, 11:45 AM · Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie reassigned T220429: Update UploadWizard describe step with text explaining what "publish" actually does from PDrouin-WMF to Edtadros.
May 9 2019, 9:15 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multimedia-Current-Work, Patch-For-Review, SDC Design, UploadWizard, Multimedia
matthiasmullie reassigned T222485: Increase padding between statement blocks on UW from matthiasmullie to Edtadros.
May 9 2019, 9:15 AM · SDC-Statements (Depicts-Walking), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Multimedia-Current-Work, SDC Engineering, UploadWizard, SDC Design, Multimedia
matthiasmullie reassigned T222482: Publish data button should be disabled if nothing has been added yet from matthiasmullie to Edtadros.
May 9 2019, 9:15 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), SDC-Statements (Depicts-Walking), SDC Engineering, Multimedia-Current-Work, SDC Design, Multimedia
matthiasmullie moved T222485: Increase padding between statement blocks on UW from Code Review to Needs QA on the Multimedia-Current-Work board.
May 9 2019, 9:13 AM · SDC-Statements (Depicts-Walking), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Multimedia-Current-Work, SDC Engineering, UploadWizard, SDC Design, Multimedia
matthiasmullie moved T222482: Publish data button should be disabled if nothing has been added yet from Code Review to Needs QA on the Multimedia-Current-Work board.
May 9 2019, 9:13 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), SDC-Statements (Depicts-Walking), SDC Engineering, Multimedia-Current-Work, SDC Design, Multimedia
matthiasmullie moved T220429: Update UploadWizard describe step with text explaining what "publish" actually does from Code Review to Needs QA on the Multimedia-Current-Work board.
May 9 2019, 9:13 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multimedia-Current-Work, Patch-For-Review, SDC Design, UploadWizard, Multimedia
matthiasmullie moved T222481: There's no way to go forward to Add Data if there's an error/warning of any sort from To Do to Code Review on the Multimedia-Current-Work board.
May 9 2019, 9:12 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), SDC Engineering, Multimedia-Current-Work, SDC Design, Multimedia
matthiasmullie moved T222483: Captions on UW doesn't warn you more than once if your input is over 250 from To Do to Code Review on the Multimedia-Current-Work board.
May 9 2019, 9:12 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), SDC-Statements (Depicts-Walking), Multimedia-Current-Work, SDC Engineering, SDC Design, Multimedia
matthiasmullie claimed T222483: Captions on UW doesn't warn you more than once if your input is over 250.
May 9 2019, 9:12 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), SDC-Statements (Depicts-Walking), Multimedia-Current-Work, SDC Engineering, SDC Design, Multimedia
matthiasmullie added a comment to T222483: Captions on UW doesn't warn you more than once if your input is over 250.

The actual issue here is that UW was configured to allow 255 characters (and it shows and continues to show a warning when you exceed that number), but Wikibase doesn't allow labels longer than 250 (not 255).
So anything with 251-255 characters ran into this issue...

May 9 2019, 8:41 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), SDC-Statements (Depicts-Walking), Multimedia-Current-Work, SDC Engineering, SDC Design, Multimedia

May 7 2019

matthiasmullie updated the task description for T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language.
May 7 2019, 9:55 AM · Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie moved T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language from Blocked to Needs QA on the Multimedia-Current-Work board.
May 7 2019, 9:54 AM · Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie reassigned T222196: Left rail should not show on Add data step if there's just one file from matthiasmullie to Edtadros.
May 7 2019, 6:15 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Multimedia, Multimedia-Current-Work, SDC Design
matthiasmullie updated the task description for T222196: Left rail should not show on Add data step if there's just one file.
May 7 2019, 6:15 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Multimedia, Multimedia-Current-Work, SDC Design