Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (330 w, 2 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Yesterday

matthiasmullie moved T272537: [M] Select menu keyboard navigation isn't functional from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Mar 4, 11:30 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie moved T274494: [M] Make filter URL query param match the search keywords from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Mar 4, 11:24 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Structured-Data-Backlog (Current Work)

Wed, Mar 3

matthiasmullie added a comment to T273839: MediaSearch: invalid search queries never finish loading - no warning to users.

T271387 is when filters have an invalid value that we don't know how to handle in the UI (it's not one of the values that could be chosen in one of the dropdowns). It can only be achieved by manually mishandling the URI (or via software that messes up links) since we provide no controls to construct a search like that.
This is actual search input (can simply be entered in the search input field) that the search engine just happens to fail to process and make sense of. It's a rather extreme edge case, but it's plausible that it happens by accidental user input.
(FWIW, I think we can give both the same generic error msg treatment)

Wed, Mar 3, 4:50 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
matthiasmullie claimed T274494: [M] Make filter URL query param match the search keywords.
Wed, Mar 3, 12:17 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Structured-Data-Backlog (Current Work)

Tue, Mar 2

matthiasmullie added a comment to T275900: Indicate whether there are relevant results in the not-currently displayed MediaSearch tabs.

FYI: I would absolutely love to see numbers in the other tabs. But this will require a separate search query for each tab, which will mean a five-fold increase of search traffic (and it'll take longer to render the page, because it now has to wait for 5 results)
I think we'll need to look into other ways to draw attention to the other tabs.

Tue, Mar 2, 10:18 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Mon, Mar 1

matthiasmullie added a comment to T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons.

I suspect the correct solution within MediaInfoHandler::getTitleForId would probable be to throw an InvalidArgumentException in case there's no title for the given id (EntityHandler::getTitleForId is documented to throw that exception if $id refers to an entity of the wrong type.)

Mon, Mar 1, 10:01 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), wdwb-tech-focus, Commons, SDC General, Wikidata, Wikimedia-production-error

Fri, Feb 26

matthiasmullie claimed T272923: [M] [wmf.27] MediaSearch - duplicate files displayed in search results.
Fri, Feb 26, 9:51 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T272923: [M] [wmf.27] MediaSearch - duplicate files displayed in search results.

I think we have 2 separate problems here:

Fri, Feb 26, 9:31 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie moved T275844: Filter changes trigger multiple API calls from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Feb 26, 9:16 AM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Structured-Data-Backlog (Current Work)
matthiasmullie created T275844: Filter changes trigger multiple API calls.
Fri, Feb 26, 9:15 AM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Structured-Data-Backlog (Current Work)

Thu, Feb 25

matthiasmullie moved T271799: [L] Implement new search profile(s) based on image search signal results from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
Thu, Feb 25, 3:50 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ImageRecs), Structured-Data-Backlog (Current Work), Image-Recommendations, Structured Data Engineering, WikibaseMediaInfo
matthiasmullie claimed T271799: [L] Implement new search profile(s) based on image search signal results .
Thu, Feb 25, 3:43 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ImageRecs), Structured-Data-Backlog (Current Work), Image-Recommendations, Structured Data Engineering, WikibaseMediaInfo
matthiasmullie added a comment to T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.
  • Namespaces are kinda weird on Commons! Since Commons' content language is English, namespaces aren't translated, except for the default namespace (Gallery). Also, the main namespace appears in parentheses (see Special:Search) because of the way the message is configured (see https://commons.wikimedia.org/wiki/MediaWiki:Blanknamespace). Just prepping you for what you'll see when this is done...
Thu, Feb 25, 2:35 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons
matthiasmullie edited projects for T275744: Special:MediaSearch must respect search-match-redirect preference, added: Structured-Data-Backlog; removed Structured-Data-Backlog (Current Work).
Thu, Feb 25, 9:14 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie created T275744: Special:MediaSearch must respect search-match-redirect preference.
Thu, Feb 25, 9:13 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie added a comment to T270390: Don't submit authentication requests prior to autocomplete search requests.

Yeah, that's not the expected behavior.
This ticket required a change in 2 places.
The other part is T274252, in the wikibase/javascript-api repo, which follows a different rollout schedule.
I've inquired about when (if any) upcoming release is scheduled here: T274252#6859705

Thu, Feb 25, 7:47 AM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie reopened T274252: Let getLocationAgnosticMwApi accept API options as "Open".

Actually - is there a timeline for releasing the next version of this repo?
It looks like (except for this patch) nothing has happened in this repo for the past 8 months, so I'm worried it'll sit around for a long time.
If there's no plan to release this soon, that's ok - in that case MediaSearch can simply reimplement something like getLocationAgnosticMwApi.

Thu, Feb 25, 7:44 AM · Structured-Data-Backlog (Current Work), Wikidata-Campsite, Wikidata

Wed, Feb 24

matthiasmullie moved T275579: Extract ability to parse WBCS License Mappings into a share-able location from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Wed, Feb 24, 4:46 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Structured-Data-Backlog (Current Work), Discovery-Search, CirrusSearch
matthiasmullie claimed T275579: Extract ability to parse WBCS License Mappings into a share-able location.
Wed, Feb 24, 4:46 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Structured-Data-Backlog (Current Work), Discovery-Search, CirrusSearch
matthiasmullie updated subscribers of T274220: Populate MachineVision databases for images commonly returned by search.

I don't think running in parallel with different inputs would be a problem.
Ping @Mholloway in case he has thoughts.

Wed, Feb 24, 8:50 AM · Discovery-Search (Current work), Structured-Data-Backlog, MachineVision

Fri, Feb 19

matthiasmullie added a comment to T273166: [M] Change haslicense keywords.

Would it be appropriate to just add a use CirrusSearch\Util; line to SpecialMediaSearch.php in order to avoid duplicating this logic, or is introducing this kind of cross-extension dependency something we want to avoid?

Fri, Feb 19, 9:01 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T273166: [M] Change haslicense keywords.

I assume this is some kind of data object (PHP associative array?), where cc-by-sa, cc-by, etc. are the keys and the statements (P275=Q98755364, etc) are the values? What does the | mean? Also, why not just do this in JSON?

This is a totally arbitrary format that already exists for several of Cirrus' on-wiki configurable code (e.g. cirrussearch-boost-templates; see CirrusSearch\Util::parseSettingsInMessage)
The only deviation from the other existing messages is that the values can be split up over multiple lines, because the lists are expected to be long.

Fri, Feb 19, 9:00 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Thu, Feb 18

matthiasmullie added a comment to T260292: [M] Add "did you mean" feature to Media Search.

(1) There will never be results displayed with Did you mean.

Thu, Feb 18, 1:18 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Wed, Feb 17

matthiasmullie moved T263705: [wmf.10] MediaSearch Other tab - 429 error is present from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Feb 17, 1:45 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.

I think that looks great

Wed, Feb 17, 5:55 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons

Tue, Feb 16

matthiasmullie updated the task description for T274355: Make videos load smoother.
Tue, Feb 16, 9:34 AM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie updated the task description for T274355: Make videos load smoother.
Tue, Feb 16, 9:33 AM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie added a comment to T274355: Make videos load smoother.

Note: this bit of code has already been merged (even though it has not yet undergone backlog grooming). Because this has minimal impact and I suspect the behavior is desirable, I will let it go ahead & be deployed.
If backlog grooming comes around and find that this is undesirable, ping me & I will remove the relevant code. Otherwise, this can move straight to "Needs QA"

Tue, Feb 16, 9:32 AM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Mon, Feb 15

matthiasmullie updated the task description for T274749: Requesting access to stat boxes for mlitn.
Mon, Feb 15, 8:21 AM · SRE, SRE-Access-Requests
matthiasmullie created T274749: Requesting access to stat boxes for mlitn.
Mon, Feb 15, 8:19 AM · SRE, SRE-Access-Requests

Fri, Feb 12

matthiasmullie moved T263705: [wmf.10] MediaSearch Other tab - 429 error is present from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Feb 12, 12:48 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T263705: [wmf.10] MediaSearch Other tab - 429 error is present.

I've just tested the steps to reproduce, and even after a lot of scrolling, I didn't run into 429s. Yesterday was the same. Several hundreds of thumbnails (that obviously had to be generated on the fly, given their slow response time) loaded just fine.
I don't know whether it's still much of an issue.

Fri, Feb 12, 12:45 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T273882: [M] Estimate how many unillustrated articles on Cebuano and Arabic wikis would have matches in MediaSearch .

Hey @Miriam! I'm going to be working on this ticket—how can I get the list of unillustrated Cebuano and Arabic articles from you?

Fri, Feb 12, 10:11 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ImageRecs), Image-Recommendations
matthiasmullie added a comment to T274610: MediaSearch: "Categories and Pages" filter issues.

I don't think "categories and pages" doesn't infer anything about their priority/order; I simply read it a "both of those things" (not particularly in any order)
We *could* prioritize categories over other pages, but that would have the effect of categories that are a very poor match for the search term outranking other pages that are obviously much better matches, which I don't think is desirable.

Fri, Feb 12, 10:09 AM · Structured-Data-Backlog
matthiasmullie moved T260292: [M] Add "did you mean" feature to Media Search from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Feb 12, 8:08 AM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Thu, Feb 11

matthiasmullie added a comment to T260292: [M] Add "did you mean" feature to Media Search.

Is there a way for us to know that all the tabs returned 0 results and only do the rewrite then?

Thu, Feb 11, 3:29 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie claimed T263705: [wmf.10] MediaSearch Other tab - 429 error is present.
Thu, Feb 11, 3:19 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie updated subscribers of T263154: [M] Instrument audio and video playback in MediaSearch.

@egardner Can this be worked on now, or is the remaining work in T257637 (still open) expected to impact this?

Thu, Feb 11, 3:16 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)
matthiasmullie updated subscribers of T273062: [L] Create tool to manually test image recommendations POC results.

The tool will run the API to get 500 random unillustrated articles from each wiki and their image recommendations

@CBogen Is that 1 image recommendation per article, or however many the API returns by default?
(asking because it'll have a significant impact on the amount of images that will need to be evaluated)

Thu, Feb 11, 1:28 PM · SDAW-MediaSearch (MediaSearch-ImageRecs), Structured-Data-Backlog (Current Work), Image-Recommendations
matthiasmullie closed T274252: Let getLocationAgnosticMwApi accept API options as Resolved.
Thu, Feb 11, 1:16 PM · Structured-Data-Backlog (Current Work), Wikidata-Campsite, Wikidata
matthiasmullie claimed T264296: [M] WikibaseMediaInfo does not support editing monolingual text in languages not supported by MediaWiki.
Thu, Feb 11, 1:03 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Structured-Data-Backlog (Current Work), Wikidata, Language codes, SDC General
matthiasmullie added a project to T274494: [M] Make filter URL query param match the search keywords: Structured-Data-Backlog.
Thu, Feb 11, 9:56 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie created T274494: [M] Make filter URL query param match the search keywords.
Thu, Feb 11, 9:48 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Structured-Data-Backlog (Current Work)

Wed, Feb 10

matthiasmullie moved T266067: [L] Create edit tags to measure multimedia edits to Wikipedia articles from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.

I have a patch in code review that deviates slightly from the task description.
I figured it'd be confusing or misleading to categorize media replacements as "add media" (but we probably also wouldn't want to ignore those), so instead of a singular "add media" tag, I've added 3: one for additions (only), one for removals (only), and another for changes (both additions & removals).
New media (including replacements) thus includes both "add media" and "change media".
Does that work?

Wed, Feb 10, 4:30 PM · Patch-For-Review, Image-Recommendations, Structured-Data-Backlog (Current Work)
matthiasmullie moved T265939: Split MediaSearch out into its own extension from Code Review to Blocked on the Structured-Data-Backlog (Current Work) board.

Patch has been approved, but won't be testable until it's enabled on-wiki, which is blocked on security readiness review (T266513)
Moving to blocked until that is complete.

Wed, Feb 10, 2:58 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Release-Engineering-Team (Deployment services), Wikimedia-extension-review-queue, Structured-Data-Backlog (Current Work)
matthiasmullie claimed T266067: [L] Create edit tags to measure multimedia edits to Wikipedia articles.
Wed, Feb 10, 2:12 PM · Patch-For-Review, Image-Recommendations, Structured-Data-Backlog (Current Work)
matthiasmullie moved T271373: [S] [wmf.25] MediaSearch: Audio mid files do not have audio icons from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
Wed, Feb 10, 12:37 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T274355: Make videos load smoother.
Wed, Feb 10, 12:37 PM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie updated the task description for T274355: Make videos load smoother.
Wed, Feb 10, 12:36 PM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie created T274355: Make videos load smoother.
Wed, Feb 10, 12:35 PM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Tue, Feb 9

matthiasmullie claimed T271373: [S] [wmf.25] MediaSearch: Audio mid files do not have audio icons.
Tue, Feb 9, 3:56 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T259896: Integrate MediaSearch backend into Visual Editor.

Yes, that is in the patch that has been merged.

Tue, Feb 9, 3:47 PM · User-notice, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)
matthiasmullie closed T258052: [M] Use aliases of matching wikidata entities to expand the wikitext, title, caption & categories search terms as Declined.

Closing. For the most part, this is already part of T258053 as well (with the exception of non-english aliases for non-english searches, for which we don't have efficient means of fetching, and we likely have little relevant data anyway)

Tue, Feb 9, 1:42 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie moved T274252: Let getLocationAgnosticMwApi accept API options from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.

Above patch should suffice, but needs someone with wikibase/javascript-api repo knowledge/access to CR.

Tue, Feb 9, 1:38 PM · Structured-Data-Backlog (Current Work), Wikidata-Campsite, Wikidata
matthiasmullie created T274252: Let getLocationAgnosticMwApi accept API options.
Tue, Feb 9, 1:37 PM · Structured-Data-Backlog (Current Work), Wikidata-Campsite, Wikidata
matthiasmullie moved T274251: Ensure ES queries don't return negative score from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Feb 9, 1:33 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Structured-Data-Backlog (Current Work)
matthiasmullie created T274251: Ensure ES queries don't return negative score.
Tue, Feb 9, 1:32 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Structured-Data-Backlog (Current Work)
matthiasmullie closed T271801: Create mechanism for comparing search profiles using labelled data as Resolved.

Hmm. So if it finds the things in those fields, but the item it finds doesn't have any other info that *is* used in ranking, where would it show up in the search results? Automatically at the end or...?

Tue, Feb 9, 1:09 PM · SDAW-MediaSearch (MediaSearch-ImageRecs), Structured-Data-Backlog (Current Work), Image-Recommendations, Structured Data Engineering, WikibaseMediaInfo
matthiasmullie closed T271801: Create mechanism for comparing search profiles using labelled data, a subtask of T269852: [Epic] Interpret image search signal results, as Resolved.
Tue, Feb 9, 1:08 PM · SDAW-MediaSearch (MediaSearch-ImageRecs), Structured-Data-Backlog (Current Work), Image-Recommendations, Structured Data Engineering, WikibaseMediaInfo

Thu, Feb 4

matthiasmullie moved T262271: Activate mediasearch profile without requiring an explicit flag from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.

AIUI, this is no longer blocked. We can proceed to make mediasearch default (for searches within file namespace), right?

Thu, Feb 4, 1:28 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T273880: [S] Remove "files depicting..." from skin search widget autocomplete.
Thu, Feb 4, 1:20 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie created T273880: [S] Remove "files depicting..." from skin search widget autocomplete.
Thu, Feb 4, 1:19 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie renamed T273879: [L] Take over the skin search input widget to submit to Special:MediaSearch from Take over the skin search input widget to Take over the skin search input widget to submit to Special:MediaSearch.
Thu, Feb 4, 1:10 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
matthiasmullie created T273879: [L] Take over the skin search input widget to submit to Special:MediaSearch.
Thu, Feb 4, 1:09 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Wed, Feb 3

matthiasmullie moved T262271: Activate mediasearch profile without requiring an explicit flag from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
Wed, Feb 3, 2:29 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie moved T271532: [L] Remove WDQS layer in ApiRelatedConcepts from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Feb 3, 2:27 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie moved T259896: Integrate MediaSearch backend into Visual Editor from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
Wed, Feb 3, 2:26 PM · User-notice, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)

Feb 1 2021

matthiasmullie added a comment to T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.

@matthiasmullie are we able to add the last update timestamp and short description as in Special:Search now that we have the generator info?

Feb 1 2021, 11:06 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons

Jan 29 2021

matthiasmullie created T273299: [S] Change MediaSearch tabs.
Jan 29 2021, 4:13 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 28 2021

matthiasmullie added a comment to T273166: [M] Change haslicense keywords.

I think this is okay. Does it require a certain user permission to edit?

Jan 28 2021, 5:33 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T273166: [M] Change haslicense keywords.

I have updated the ticket. Please look over the changes (esp. the last acceptance criterium, which would grant community better control)

Jan 28 2021, 4:02 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T273166: [M] Change haslicense keywords.
Jan 28 2021, 4:02 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie renamed T273166: [M] Change haslicense keywords from [Spike] Investigate disconnect between search keyword license options and their UI descriptive names to Change haslicense keywords.
Jan 28 2021, 3:58 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T273166: [M] Change haslicense keywords.

@matthiasmullie any objections to repurposing this ticket from a spike to actually making the change?

Jan 28 2021, 3:48 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T273166: [M] Change haslicense keywords.

IMO to make things clearer the best thing to do would be to change the names of the haslicense keyword options to reflect the names in the UI. Would that have any negative impact/break anything?

Jan 28 2021, 3:09 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T271105: wbeditentity response does not contain lemma data.

@Keegan and @matthiasmullie, do you have a sense of what this would break on our end and/or for the community? and @Keegan do you know of any policies that this change would fall under?

Jan 28 2021, 10:47 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata Lexicographical data
matthiasmullie added a comment to T272000: MediaSearch - issues for Other License filter for Images.

The map of these license statements can be found at https://commons.wikimedia.org/w/index.php?title=MediaWiki:Wikibasecirrus-license-mapping

Jan 28 2021, 10:08 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T272000: MediaSearch - issues for Other License filter for Images.

(1)
These 2 were missing from the license map config:

	P275=Q98755364, # copyright licence = Commons Attribution-ShareAlike 3.0 Italy
	P275=Q98755344, # copyright licence = Commons Attribution-Share Alike 3.0 Serbia

I have added them, and the files in question now no longer appear in search results they don't belong.

Jan 28 2021, 10:06 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a project to T273167: [S] Quickview: if we show license information, always show a license icon: Structured-Data-Backlog (Current Work).
Jan 28 2021, 10:04 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie created T273167: [S] Quickview: if we show license information, always show a license icon.
Jan 28 2021, 10:00 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie updated subscribers of T273166: [M] Change haslicense keywords.

Adding @Keegan & @CBogen, who I suspect can best evaluate this. If the task description is not clear, LMK.

Jan 28 2021, 9:54 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie created T273166: [M] Change haslicense keywords.
Jan 28 2021, 9:53 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie created T273165: [S] Some files don't show license information in QuickView.
Jan 28 2021, 9:35 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie closed T273008: MediaSearch should not pick up redirects as Declined.

We've manually been assessing thousands of search results, and the data that we have indicates that redirects are a pretty good signal (worse than titles, but better than text)
Ergo: we probably should not remove redirects from the data used by the algorithm, just because there's false information in there: there's true for all other fields.
I think the right thing to do in this specific case would be to remove the redirect (given that it's essentially false - you also wouldn't want "dog" to redirect to "mona lisa")

Jan 28 2021, 8:36 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.
Jan 28 2021, 8:10 AM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader

Jan 27 2021

matthiasmullie added a comment to T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.

Special:Search allows selecting multiple namespaces at once.
None of our current filters support that IIRC - what would that look like (if at all possible)?

Jan 27 2021, 4:17 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.

Since I'm here, I figured it'd be worth pointing out a few caveats about the minifier, most of which probably won't really be a surprise:

  • This grew from a few very tiny regular expression. It is a lot more complex now, but it's essentially still just a bunch of regexes. They're usually faster than any PHP userland code could parse JS syntax, but they're limited in their ability to process code (e.g. finding matching closing brackets in nested structures is something regexes are not great at...)
  • Since it's just a bunch of regexes, it does not parse or validate the original or produced code, so it may silently produce invalid results.
  • One of the most common ways in which it could silently fail is when the PCRE limits (pcre.backtrack_limit & pcre.recursion_limit - see http://php.net/manual/en/pcre.configuration.php) are configured too low. I've optimized the regexes a bunch and have not recently seen bug reports that indicate it still happens frequently (if at all), but it is technically still possible, given low enough limits & code written in a specific way to trigger large pcre recursion/backtracking.
  • A JS-based minifier should be much superior than this (or any other) PHP-based minifier. While I started to build it for exactly the same reasons that apply to MediaWiki (be able to run with minimal fuss & additional infrastructure), it might makes sense to attempt to shell out to a JS compiler for WMF sites (if at all possible), and use a PHP-based solution as fallback, when that infrastructure is not available (for many 3rd party installs)

(I had no idea this was going on - feel free to ping me if there's anything I can help with)

Jan 27 2021, 9:51 AM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader
matthiasmullie added a comment to T272882: Upgrade ResourceLoader JS minifier to support ES6.

https://github.com/matthiasmullie/minify/commit/8538190f4ab21f77c938e51109547f0e943f7d44 would probably fix the slowness in that regex. Thanks for tracking that down!

Jan 27 2021, 8:54 AM · Wikimedia-Minify, Vue.js Migration, Patch-For-Review, Performance-Team (Radar), MediaWiki-ResourceLoader

Jan 26 2021

matthiasmullie added a comment to T269383: [M] Media Search: Surfacing the result count.

The mediasearch query param must remain until T262271 is resolved.
The api emits a warning that it's an unrecognized parameter (it's not an actively supported API param), but it is required to allow the mediasearch profile to be used until it becomes enabled by default.
Dropping the query param from the request would result in old (non-mediasearch) search profiles being used. That warning can simply be ignored until we can drop the query param from the request.

Jan 26 2021, 8:36 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie claimed T271532: [L] Remove WDQS layer in ApiRelatedConcepts.
Jan 26 2021, 1:41 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 25 2021

matthiasmullie moved T272425: Debounce the Resize Listener in SearchResults.vue from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 25 2021, 2:19 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Performance Issue, Structured-Data-Backlog (Current Work)
matthiasmullie claimed T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue.
Jan 25 2021, 1:20 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), wdwb-tech-focus, Structured-Data-Backlog (Current Work), Structured Data Engineering, User-brennen, WikibaseMediaInfo, Wikimedia-production-error, Wikidata
matthiasmullie moved T272548: Adding a filter then changing tabs yields no results from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Jan 25 2021, 1:19 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 22 2021

matthiasmullie added a comment to T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue.

Under normal conditions, it is not possible to submit invalid values like the one encountered here.
I suspect there must've been a federation configuration issue >1y ago where test-commons thought it was linked to production wikidata rather than testwikidata, thus allowing this invalid data.
Either way, I have a patch that should handle these kind of issues (that don't usually seem possible in the first place) in a more graceful way, and allows for fixing the invalid data.

Jan 22 2021, 4:59 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), wdwb-tech-focus, Structured-Data-Backlog (Current Work), Structured Data Engineering, User-brennen, WikibaseMediaInfo, Wikimedia-production-error, Wikidata
matthiasmullie moved T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Jan 22 2021, 4:56 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), wdwb-tech-focus, Structured-Data-Backlog (Current Work), Structured Data Engineering, User-brennen, WikibaseMediaInfo, Wikimedia-production-error, Wikidata
matthiasmullie edited projects for T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Jan 22 2021, 4:56 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), wdwb-tech-focus, Structured-Data-Backlog (Current Work), Structured Data Engineering, User-brennen, WikibaseMediaInfo, Wikimedia-production-error, Wikidata

Jan 21 2021

matthiasmullie moved T270336: SparqlClient: 504 Gateway Timeout from Blocked to Code Review on the Structured-Data-Backlog (Current Work) board.

The code still hasn't been removed, so we should probably keep this one open until the actual code is gone.
I had resolved T258055 because we have the answers that we need (but maybe I should've kept it open until all relevant code is also gone)

Jan 21 2021, 12:46 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch, Wikimedia-production-error
matthiasmullie moved T269383: [M] Media Search: Surfacing the result count from Blocked to Ready for Development on the Structured-Data-Backlog (Current Work) board.
Jan 21 2021, 12:26 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie moved T260292: [M] Add "did you mean" feature to Media Search from Blocked to Ready for Development on the Structured-Data-Backlog (Current Work) board.
Jan 21 2021, 12:26 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
matthiasmullie moved T262992: Add formatted page/file size from Blocked to Ready for Development on the Structured-Data-Backlog (Current Work) board.
Jan 21 2021, 12:25 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured Data Engineering