Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (307 w, 3 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Today

matthiasmullie added a comment to T258419: Survey users about mediasearch on commons.

@matthiasmullie, you mentioned there's a hack to avoid this - seems like we should go that route. What are the down sides?

Fri, Sep 25, 1:54 PM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie added a comment to T259619: [M] Create user-facing documentation for Media Search on Commons.

Below is an attempt at explaining what kind of data is used, how & why, without getting too technical.
If anything is too detailed or not detailed enough, or plain unclear, LMK and I'm happy to try to accommodate.
Feel free to edit in any way, and post wherever it may be relevant.

Fri, Sep 25, 1:35 PM · Documentation, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie created T263841: RFC: Allow generators to return data instead of just generating titles.
Fri, Sep 25, 12:01 PM · Structured-Data-Backlog (Current Work), TechCom-RFC

Yesterday

matthiasmullie claimed T259619: [M] Create user-facing documentation for Media Search on Commons.
Thu, Sep 24, 1:42 PM · Documentation, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T256431: [L] Implement superclass "concept chips" in the MediaSearch interface.

And one last thing to remember: we chose this heuristics implementation because it was the only viable one in a short amount of time.
It is flawed to some extent both in results (Wikidata ontology can be weird and inconsistent) and performance (we should be careful with these SPARQL queries)
This implementation is fine for limited usage on Special:MediaSearch and will allow us to evaluate the feature, but if we ever want to scale it up (to the point of it being served by default for most casual searches), we will have to consider alternative implementations.
In other words: let's instrument this, and if it's found to be used extensively, we should start working on more sustainable alternatives.

Thu, Sep 24, 7:39 AM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)

Wed, Sep 23

matthiasmullie added a comment to T260292: [M] Add "did you mean" feature to Media Search.

We're using the search API, which already exposes suggestions (&srinfo=suggestion.) E.g. https://commons.wikimedia.org/w/api.php?action=query&list=search&srsearch=einstn&srnamespace=6&srinfo=suggestion&mediasearch=1
Sadly, it's not exposing any such data when used as generator (which we do), and changing things to add that kind of data likely isn't happening (see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/394120/1#message-1e5569733143789c304edc5d8bc1c7fc17362e15)

Wed, Sep 23, 5:06 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T262857: [M] Adjust algorithm for the "popular" queue on CAT/SuggestedTags.
Wed, Sep 23, 4:30 PM · Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T256431: [L] Implement superclass "concept chips" in the MediaSearch interface.

Most heuristics in spreadsheet have been implemented (strikethroughed)

Wed, Sep 23, 4:17 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T260251: Review MediaSearch profile for integration into CirrusSearch.

The relevant tickets are already in the ticket description; I can't think of any others not already listed.

Wed, Sep 23, 3:51 PM · Discovery-Search (Current work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog

Mon, Sep 21

matthiasmullie added a comment to T259896: Integrate MediaSearch backend into Visual Editor.

@matthiasmullie will this affect file namespace searches on the wikipedias?

Mon, Sep 21, 12:34 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)
matthiasmullie added a comment to T258419: Survey users about mediasearch on commons.

QuickSurveys only allows 1 question, so we either run separate surveys, or so an external survey. (Since @Ramsey-WMF said we don't have to ask both at once, I assumed we'd do 2 separate?)

Mon, Sep 21, 12:15 PM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering

Fri, Sep 18

matthiasmullie added a comment to T259896: Integrate MediaSearch backend into Visual Editor.

Yes for VE.

Fri, Sep 18, 3:00 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)
matthiasmullie added a comment to T260251: Review MediaSearch profile for integration into CirrusSearch.

Another thing to consider would be T258055: [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail & feedback is very much welcome (scroll to last post for findings)

Fri, Sep 18, 11:05 AM · Discovery-Search (Current work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog
matthiasmullie added a comment to T258055: [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail.

Short summary:

Fri, Sep 18, 11:04 AM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T263238: Cache the relevant entities used in media search query.
Fri, Sep 18, 10:31 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie created T263238: Cache the relevant entities used in media search query.
Fri, Sep 18, 10:30 AM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T258419: Survey users about mediasearch on commons.

@CBogen @Ramsey-WMF Does T258419#6447736 (screenshot and caveats) look acceptable for us? (If not, we're likely in for a sizeable refactor of QuickSurveys, or consider alternative solution)

Fri, Sep 18, 10:27 AM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie closed T261815: MediaSearch: Search results depend on terms order as Resolved.

This was actually blocked by T258063. Both of the above links now have (almost) the exact set of results, so this is fixed.

Fri, Sep 18, 9:33 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-Beta)
matthiasmullie added a comment to T258063: [M] Remove ApiQueryMediaSearch.

Please inform translatewiki.net when adding or removing translation files. This way we can do changes beforehand before they show up in our error logs. You can tag translatewiki.net or ping @Raymond directly in Phabricator or Gerrit when it is about MediaWiki core or extensions.

Fri, Sep 18, 9:32 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Alpha), Structured-Data-Backlog (Current Work)
matthiasmullie moved T259896: Integrate MediaSearch backend into Visual Editor from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.
Fri, Sep 18, 9:30 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)
matthiasmullie added a comment to T259896: Integrate MediaSearch backend into Visual Editor.

AFAICT, VisualEditor already performs the perfect API call that will receive mediasearch results once the new profile is activated by default (so: blocked on T262271)
Work for this ticket will likely be a simple verification.

Fri, Sep 18, 9:30 AM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate)
matthiasmullie added a comment to T262522: Strike a decent balance between fulltext matches & statement matches.

Quick status update: we have 3 patches that will help the situation.

Fri, Sep 18, 9:19 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), SDAW-MediaSearch (MediaSearch-Beta), Patch-For-Review, Structured-Data-Backlog (Current Work)

Thu, Sep 17

matthiasmullie merged T259573: [M] Remove autocomplete suggestions with a space at the end into T263126: Autocomplete suggest variants where case or punctuation are the only difference.
Thu, Sep 17, 2:40 PM · SDAW-MediaSearch, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Structured-Data-Backlog (Current Work)
matthiasmullie merged task T259573: [M] Remove autocomplete suggestions with a space at the end into T263126: Autocomplete suggest variants where case or punctuation are the only difference.
Thu, Sep 17, 2:40 PM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie closed T259573: [M] Remove autocomplete suggestions with a space at the end as Resolved.

Do you have a specific example where this occurred?
I'll close this because I'm fairly certain that the fix for T263126 will also fix this, but please re-open if you do find examples where that patch didn't resolve this.

Thu, Sep 17, 2:39 PM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T262522: Strike a decent balance between fulltext matches & statement matches from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 17, 1:29 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), SDAW-MediaSearch (MediaSearch-Beta), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie moved T263126: Autocomplete suggest variants where case or punctuation are the only difference from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 17, 1:29 PM · SDAW-MediaSearch, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Structured-Data-Backlog (Current Work)
matthiasmullie created T263126: Autocomplete suggest variants where case or punctuation are the only difference.
Thu, Sep 17, 1:08 PM · SDAW-MediaSearch, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T263047: Uncaught TypeError: Cannot read property 'node' of undefined.

Once the lock is removed by whoever can (I don't have the right linux permissions, it seems), please deploy the backport:

Thu, Sep 17, 11:25 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), JavaScript, User-brennen, Regression, Wikimedia-production-error, Performance-Team, MediaWiki-extensions-NavigationTiming

Wed, Sep 16

matthiasmullie added a comment to T262522: Strike a decent balance between fulltext matches & statement matches.

Note: not number of words, as non-latin languages behave differently & certain words (stopwords) are omitted. We need the tokens from elastic.

Wed, Sep 16, 3:22 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), SDAW-MediaSearch (MediaSearch-Beta), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie closed T258054: [M] Include quality assessments to tweak rank of results as Declined.

Yeah, I guess we don't need this any longer then.

Wed, Sep 16, 2:51 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie closed T258172: Use MediaSearchBuilder for any search that contains the File namespace as Resolved.
Wed, Sep 16, 2:50 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie closed T252685: [XL] Create commons-specific elasticsearch query builder that emulates current MediaSearch behaviour as Resolved.
Wed, Sep 16, 2:50 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Discovery-Search, Structured-Data-Backlog (Current Work)
matthiasmullie created T263026: [S] command+click should open image in new tab, not quickview.
Wed, Sep 16, 1:46 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Mon, Sep 14

matthiasmullie added a comment to T246792: Performance review of Improved Commons Search.

Media search is essentially 2 separate parts:

  1. there as a new, media-focused, UI which uses the search API
  2. there is a multimedia-specific search profile to alter the actual elastic query

After of next week's deployment train hits Commons (Wed 16 Sept, if things go well), both will be wired together & can be tested at https://commons.wikimedia.org/wiki/Special:MediaSearch?quickview=1

Mon, Sep 14, 1:07 PM · Discovery-Search, Performance-Team

Thu, Sep 10

matthiasmullie added a comment to T262511: Balance default scores with rescore profiles.

I've only looked at some of the profiles briefly, but it looks like:

Thu, Sep 10, 12:39 PM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T260722: Sort by filter for Media Search.

@AnneT I'd suggest to use the popular_inclinks profile for now.
popular_inclinks_pv seems to add only a minor score, but popular_inclinks does have a massive impact.
That one's only based on incoming links, though, not incoming links + pageviews; but a good enough proxy for 'popularity' none the less.
We can then use T262511 to further investigate the impact of these rescore profiles.

Thu, Sep 10, 12:19 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T262522: Strike a decent balance between fulltext matches & statement matches.
Thu, Sep 10, 10:14 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), SDAW-MediaSearch (MediaSearch-Beta), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie moved T262511: Balance default scores with rescore profiles from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 10, 10:06 AM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)
matthiasmullie moved T262522: Strike a decent balance between fulltext matches & statement matches from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 10, 10:06 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), SDAW-MediaSearch (MediaSearch-Beta), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T262511: Balance default scores with rescore profiles.

This is probably blocked on (or at least influenced by) T262522

Thu, Sep 10, 10:05 AM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)
matthiasmullie created T262522: Strike a decent balance between fulltext matches & statement matches.
Thu, Sep 10, 9:58 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), SDAW-MediaSearch (MediaSearch-Beta), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".

IMO it's quite likely that these are simply (very late) resubmissions from Special:Upload after the original upload failed (in which case the file got stashed), but the resubmission took long enough that the stashed file got cleaned up in the meantime.
See T38587#6267136 (duplicate) for more details.

Thu, Sep 10, 7:58 AM · Structured-Data-Backlog, Structured Data Engineering, Multimedia, MediaWiki-Uploading, Wikimedia-production-error
matthiasmullie created T262511: Balance default scores with rescore profiles.
Thu, Sep 10, 7:11 AM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T260722: Sort by filter for Media Search.

1 thing is missing from your links: to be able to use the media search profile right now, you'll need to add ?mediasearch=1 to the url (and API sandbox keep stripping it, apparently)

Thu, Sep 10, 6:57 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)

Wed, Sep 9

matthiasmullie claimed T258419: Survey users about mediasearch on commons.
Wed, Sep 9, 4:52 PM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie added a comment to T258419: Survey users about mediasearch on commons.

Does this look ok?

Wed, Sep 9, 4:51 PM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering

Tue, Sep 8

matthiasmullie moved T260722: Sort by filter for Media Search from Blocked to Ready for Development on the Structured-Data-Backlog (Current Work) board.

This is no longer blocked now that T258063 has a working patch.

Tue, Sep 8, 1:17 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie closed T257295: Modify Special:MediaSearch to use the MediaQueryBuilder as Declined.

This has taken too long to land & we no longer need this intermediate step because the Vue work has already been merged.
I've worked around the blocker for T258063, which makes this ticket obsolete.

Tue, Sep 8, 1:13 PM · SDAW-MediaSearch (MediaSearch-Alpha), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T258063: [M] Remove ApiQueryMediaSearch.

This was blocked because the media search profile is not active unless explicitly requested (via mediasearch query param). This will not change until A/B test results confirm that we're not turning the search results into a total mess.
This ticket blocks a few others, though (e.g. ability to sort), so let's get this moving...

Tue, Sep 8, 1:09 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Alpha), Structured-Data-Backlog (Current Work)
matthiasmullie moved T262271: Activate mediasearch profile without requiring an explicit flag from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.
Tue, Sep 8, 1:00 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Patch-For-Review, Structured-Data-Backlog (Current Work)
matthiasmullie created T262271: Activate mediasearch profile without requiring an explicit flag.
Tue, Sep 8, 12:56 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Patch-For-Review, Structured-Data-Backlog (Current Work)

Mon, Sep 7

matthiasmullie added a comment to T258419: Survey users about mediasearch on commons.

And who do we want to survey (what are the criteria the audience)? Any random commons visitor? Anons? Or experienced with over X contributions? Only visitors of Special:MediaSearch? Or visitors of one of SDC's talk pages?

Mon, Sep 7, 12:53 PM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie added a comment to T258419: Survey users about mediasearch on commons.

What is/are the question(s) we'd like to ask?

Mon, Sep 7, 12:47 PM · Product-Analytics, Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), Surveys, Structured-Data-Backlog (Current Work), Structured Data Engineering

Thu, Sep 3

matthiasmullie moved T261817: Changing the filters in one tab should not discard results in other tabs from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 3, 2:04 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie moved T261818: Changing the filters within a tab should clear Quickview within that tab from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 3, 2:04 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie moved T261957: Opening quickview causes thumbnails to spread out when there were not enough to fill the available height from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Thu, Sep 3, 2:04 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Structured-Data-Backlog (Current Work)
matthiasmullie created T261957: Opening quickview causes thumbnails to spread out when there were not enough to fill the available height.
Thu, Sep 3, 2:03 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Structured-Data-Backlog (Current Work)
matthiasmullie closed T218803: [Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter as Declined.

The existing Wikibase datamodel objects continue to be supported upstream and there are no plans of removing them.
We are no longer actively working on this much, so there is no reason to pursue this any further & we'll stick with what we've got.

Thu, Sep 3, 1:42 PM · Structured-Data-Backlog, Structured Data Engineering
matthiasmullie closed T218803: [Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter, a subtask of T216527: [Spike] How to deal with WB replacing their JS data model?, as Declined.
Thu, Sep 3, 1:42 PM · Structured-Data-Backlog, User-Addshore, wdwb-tech-focus, Structured Data Engineering, Wikidata
matthiasmullie closed T221681: Clarify the MediaInfo data model in relation to Wikibase [Epic] as Declined.

The existing Wikibase datamodel objects continue to be supported upstream and there are no plans of removing them.
We are no longer actively working on this much, so there is no reason to pursue this any further & we'll stick with what we've got.

Thu, Sep 3, 1:41 PM · Structured-Data-Backlog, Structured Data Engineering

Tue, Sep 1

matthiasmullie closed T216527: [Spike] How to deal with WB replacing their JS data model?, a subtask of T204264: "Depicts crawling": Add displaying/editing statements to File page, as Declined.
Tue, Sep 1, 5:17 PM · Structured-Data-Backlog, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Crawling), Structured Data Engineering (Depicts-Crawling), Epic, Multimedia-Team-Working-Board, Multimedia, Wikidata
matthiasmullie closed T216527: [Spike] How to deal with WB replacing their JS data model? as Declined.

Not worth pursuing ATM. Let’s figure this out and reconsider options if/when this becomes an actual issue in the future.

Tue, Sep 1, 5:17 PM · Structured-Data-Backlog, User-Addshore, wdwb-tech-focus, Structured Data Engineering, Wikidata
matthiasmullie updated the task description for T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end.
Tue, Sep 1, 10:20 AM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie claimed T261727: JS must respect the order (index) of the initial batch of results.
Tue, Sep 1, 10:19 AM · Structured-Data-Backlog (Current Work)
matthiasmullie created T261727: JS must respect the order (index) of the initial batch of results.
Tue, Sep 1, 10:18 AM · Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end.

We can simply grab the contents of the input field (which also contains the existing search term) instead of grabbing it from the url. That also covers the case of users starting new input before JS has had a chance to load.
The main reason that people will be able to start inputting text is the latency of having to transfer the JS bundle, which is now covered.

Tue, Sep 1, 9:23 AM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie moved T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Tue, Sep 1, 9:08 AM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)

Mon, Aug 31

matthiasmullie created T261649: [S] Components must not add all (API) result keys as HTML element properties.
Mon, Aug 31, 2:46 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end.
Mon, Aug 31, 1:18 PM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie moved T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
Mon, Aug 31, 12:18 PM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie claimed T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end.
Mon, Aug 31, 12:17 PM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)

Thu, Aug 27

matthiasmullie added a comment to T258055: [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail.

Based on the simplistic example query pasted earlier, it looks like it takes somewhere in the 300-600ms range to find nested statements (capped at 3 levels deep, limited at 750)
This will vary slightly based on the exact query (and we're going to need to keep it as simply as possible), but this is the ballpark.
We should probably cache that result (entity tree) for a short time so that we won't have to do it again as users continue to load additional pages of results for the same search term.

Thu, Aug 27, 12:00 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Aug 25 2020

matthiasmullie added a comment to T258611: [L] Update PHP-renderd MediaSearch UI for better parity with new front-end.

The initial render (from PHP) & the JS takeover are getting way out of sync.
There's a significant FOUC (there already was, but it's getting worse now that the UI is drifting apart), changes in functionality that we need to think about (can we skip the filters in no-JS), tabs are about to change, and the actual initial results (that are passed along from backend to frontend) are already based on different calls (filetype=bitmap vs filetype=bitmap|drawing)
We probably need to prioritize this - we should keep the initial render in sync (to some extent) when we make changes in JS, but it is no longer in a state where that is feasible.

Aug 25 2020, 4:50 PM · SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)
matthiasmullie moved T258048: Test Commons has incorrectly configured depicts property from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.
Aug 25 2020, 4:16 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie closed T38587: Fatal error when uploading a file to Commons (UploadStashFileNotFoundException) as Resolved.

Closing per rationale in above comment.

Aug 25 2020, 2:44 PM · Wikimedia-production-error, Commons, Multimedia, MediaWiki-File-management
matthiasmullie closed T38587: Fatal error when uploading a file to Commons (UploadStashFileNotFoundException), a subtask of T61914: Chunked upload (tracking), as Resolved.
Aug 25 2020, 2:43 PM · Commons, Multimedia, Tracking-Neverending, MediaWiki-Uploading
matthiasmullie closed T38587: Fatal error when uploading a file to Commons (UploadStashFileNotFoundException), a subtask of T85568: Uploadstash errors (tracking), as Resolved.
Aug 25 2020, 2:43 PM · SRE-swift-storage, Multimedia, Commons, UploadWizard, Tracking-Neverending, MediaWiki-File-management
matthiasmullie added a comment to T258055: [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail.

After some quick tests, elastic seems to respond just as fast with (up to) 50 (current situation) or 750 statements. But there's an upper limit of 1024 clauses ATM (too_many_clauses: maxClauseCount is set to 1024)

Aug 25 2020, 2:09 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie moved T244061: UploadWizard shows afterActive message during a campaign instead of whileActive from Blocked to Code Review on the Structured-Data-Backlog (Current Work) board.
Aug 25 2020, 8:34 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), UploadWizard

Aug 24 2020

matthiasmullie added a comment to T260722: Sort by filter for Media Search.

"most recent" and "most viewed" imply things about the implementation.
We can rescore results, but that's no guarantee that they'd be in that exact order, because we don't necessarily want a super popular image that is a poor match for the search term to outrank a near perfect match that is a little less popular.
I propose we rephrase the options to "relevance", "recency" and "popularity" to be less suggestive about the exact implementation.
PS: if we're going with popular: there is a rescore profile that uses both pageviews and incoming links to rank things by - that would probably be an even better one to use.

Aug 24 2020, 7:55 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Beta), Structured-Data-Backlog (Current Work)

Aug 20 2020

matthiasmullie added a comment to T260706: Update/repair Search A/B Test autoreporter.

Note: the "quick & simple analysis of preference from interleaved A/B tests" as described at the end of this issue's description should be good enough for the test that we'd like to run next week.
Knowing the preferential set of results is good enough to drive our immediate work.

Aug 20 2020, 1:04 PM · Structured-Data-Backlog, Discovery-Search, Discovery-Analysis, Product-Analytics

Aug 18 2020

matthiasmullie added a comment to T260706: Update/repair Search A/B Test autoreporter.

We are working on improving search results on Commons by including structured data (captions, statements) etc.
It would be extremely useful (essential, actually) to be able to tell the impact of changes, to confirm that we're moving in a good direction.

Aug 18 2020, 4:13 PM · Structured-Data-Backlog, Discovery-Search, Discovery-Analysis, Product-Analytics
matthiasmullie awarded T260706: Update/repair Search A/B Test autoreporter a Like token.
Aug 18 2020, 4:11 PM · Structured-Data-Backlog, Discovery-Search, Discovery-Analysis, Product-Analytics

Aug 17 2020

matthiasmullie added a comment to T244061: UploadWizard shows afterActive message during a campaign instead of whileActive.

Oh, I somehow misread the order of actual & expected results, my apologies! I'll look into this!

Aug 17 2020, 5:58 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), UploadWizard
matthiasmullie moved T258048: Test Commons has incorrectly configured depicts property from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.
Aug 17 2020, 11:58 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T244061: UploadWizard shows afterActive message during a campaign instead of whileActive from Ready for Development to Blocked on the Structured-Data-Backlog (Current Work) board.
Aug 17 2020, 11:58 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), UploadWizard
matthiasmullie claimed T258048: Test Commons has incorrectly configured depicts property.
Aug 17 2020, 11:57 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T244061: UploadWizard shows afterActive message during a campaign instead of whileActive.
Aug 17 2020, 11:52 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), UploadWizard
matthiasmullie added a comment to T244061: UploadWizard shows afterActive message during a campaign instead of whileActive.

I'm not sure I completely understand this issue.
If - as described - a campaign has a start date in the past and end date in the future, it's currently active (has already started, but not yet ended), right?
In such case, I would expect the whileActive message to be displayed, and afterActive shouldn't be displayed until the end date has reached.
Can anyone explain why it has to be the other way around, or where my understanding is wrong?

Aug 17 2020, 11:50 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), UploadWizard

Jul 31 2020

matthiasmullie added a comment to T258054: [M] Include quality assessments to tweak rank of results.

Note: I believe (some of) this already exists via Cirrus boosting usage of certain templates/categories, in which case we might simply be able to use that.

Jul 31 2020, 2:36 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
matthiasmullie claimed T256617: Make link to entity/concept URI visible in left side menu for all Commons files.
Jul 31 2020, 12:32 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Structured-Data-Backlog (Current Work), Wikidata, GLAM-Tech, SDC General
matthiasmullie edited projects for T256617: Make link to entity/concept URI visible in left side menu for all Commons files, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Jul 31 2020, 12:32 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Structured-Data-Backlog (Current Work), Wikidata, GLAM-Tech, SDC General

Jul 30 2020

matthiasmullie added a comment to T258063: [M] Remove ApiQueryMediaSearch.

T257295 has to go first - that one replaces the existing MediaSearch API logic to make it use the default search API (with MediaSearch profile). That way we can start to use the new backend without having to make & synchronize changes to the frontend.

Jul 30 2020, 5:57 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), SDAW-MediaSearch (MediaSearch-Alpha), Structured-Data-Backlog (Current Work)

Jul 27 2020

matthiasmullie added a comment to T258453: [Spike] Comparison test cases - Commons Special:Search and Special:MediaSearch.

Captions, wikitext & filenames will indeed all be included when searching.
However, "paris" should not be matched when searching for "iris" or "irises". Do you have an example of where that was the case?
Most of the not too obvious matches I could find for "iris" were because the wikitext contained the photographer's name, "iris".

Jul 27 2020, 12:07 PM · SDAW-MediaSearch (MediaSearch-Alpha), Structured-Data-Backlog (Current Work)

Jul 24 2020

matthiasmullie added a comment to T258055: [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail.

Quick brain dump before the weekend.

Jul 24 2020, 2:31 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Jul 22 2020

matthiasmullie claimed T258055: [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail.
Jul 22 2020, 11:21 AM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Jul 21 2020

matthiasmullie added a comment to T245861: Add Structured data during file upload with Upload Wizard.

I don't think many oppose, only a few loud mouths.

Jul 21 2020, 7:38 PM · Structured-Data-Backlog, StructuredDataOnCommons, UploadWizard, Structured Data Engineering

Jul 16 2020

matthiasmullie added a comment to T257938: License type filter for media search.

Sadly, it’s not (consistently) in structured data (yet?)
It lives in wikitext & Extension:CommonsMetadata extracts it on-demand (but it’s not stored anywhere)
I suspect there’ll be hooks in both of those methods, where CommonsMetadata could then add those fields to?

Jul 16 2020, 4:29 PM · Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), SDC General, Wikidata, Commons, Structured-Data-Backlog (Current Work)

Jul 15 2020

matthiasmullie added a comment to T243787: libup run of repo WikibaseMediaInfo fails on npm ci with failing wikibase dependencies.

The latest is actually intentional in this case, because it's only used in tests and we want to ensure that those run against the latest code (that matches what is automatically going to be on production later on)
That said, if it's causing issues elsewhere, we can pin it to a specific version. That patch LGTM - do you want it merged?

Jul 15 2020, 5:58 PM · Patch-For-Review, WikibaseMediaInfo, LibUp