Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (233 w, 9 m)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Thu, Apr 18

matthiasmullie added a comment to T219382: Allow editing of non-depicts statement block on File page.

This ticket is just for the most basic "support": making sure other statements don't break things and can be deleted.
This will already be in production, so we can deal with vandalism from manually crafted API calls to submit other statements.

Thu, Apr 18, 1:57 PM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia

Wed, Apr 17

JeanFred awarded T219677: During UploadWizard process, issue with Captions blocked the process a Love token.
Wed, Apr 17, 5:54 PM · SDC-Statements (Depicts-Crawling), SDC Engineering, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, UploadWizard, Multimedia
matthiasmullie closed T219677: During UploadWizard process, issue with Captions blocked the process as Resolved.

Okay, this seems to have worked: FlickreviewR 2 got its edit in, and captions kept submitting.

Wed, Apr 17, 3:24 PM · SDC-Statements (Depicts-Crawling), SDC Engineering, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, UploadWizard, Multimedia
matthiasmullie added a comment to T219677: During UploadWizard process, issue with Captions blocked the process .

Actually, the more captions are added, the longer submitting all of them (sequentially) will take, and the better the odds of the bot making its edit.
We should try an upload with 10 or so captions, and we can validate whether the bot edited in time by examining the file's history.
Let's see... :)

Wed, Apr 17, 2:31 PM · SDC-Statements (Depicts-Crawling), SDC Engineering, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, UploadWizard, Multimedia
matthiasmullie added a comment to T219677: During UploadWizard process, issue with Captions blocked the process .

Yeah, it's pretty hard to test as it depends on the timing of a couple of things...
As we're unable to reproduce this now, I suggest we resolve this ticket. If the problem reappears, we can reopen or file a new ticket.
Sounds good?

Wed, Apr 17, 2:28 PM · SDC-Statements (Depicts-Crawling), SDC Engineering, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, UploadWizard, Multimedia
matthiasmullie edited projects for T216536: Use filetype:bitmap|audio to search in multiple filetypes at once, added: SDC-Statements (Depicts-on-training-wheels); removed SDC Engineering (Depicts and other statements on a bicycle).
Wed, Apr 17, 2:09 PM · SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Patch-For-Review, Wikidata, Epic, Multimedia, SDC General
matthiasmullie updated the task description for T221233: Unable to submit structured data on IE11.
Wed, Apr 17, 2:08 PM · Multimedia, SDC Engineering
matthiasmullie added a comment to T221233: Unable to submit structured data on IE11.

Actually, maybe even better than an error message (if we can't get it to work at all) would be to sniff out IE11 and just not load the JS widget. Things will then just be read-only.

Wed, Apr 17, 2:06 PM · Multimedia, SDC Engineering
matthiasmullie created T221233: Unable to submit structured data on IE11.
Wed, Apr 17, 2:05 PM · Multimedia, SDC Engineering
matthiasmullie moved T218922: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs from Needs QA to Verify on Production on the Multimedia-Current-Work board.

Works on beta!

Wed, Apr 17, 1:58 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia
matthiasmullie moved T219292: Top-to-bottom order of primary/prominent depicts values should change on publish from Needs QA to Verify on Production on the Multimedia-Current-Work board.

Works on beta & test-commons!

Wed, Apr 17, 1:31 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T221229: Statements submitted on mobile don't show up until refresh.
Wed, Apr 17, 1:10 PM · SDC-Statements (Depicts-Crawling), Multimedia, SDC Engineering
matthiasmullie updated subscribers of T221228: Depicts widget has a couple of visual quirks on mobile/small screens.

@PDrouin-WMF might have ideas on how to fix some of these things.

Wed, Apr 17, 1:08 PM · SDC Design, Multimedia, SDC Engineering
matthiasmullie created T221228: Depicts widget has a couple of visual quirks on mobile/small screens.
Wed, Apr 17, 1:07 PM · SDC Design, Multimedia, SDC Engineering
matthiasmullie moved T218922: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs from Code Review to Needs QA on the Multimedia-Current-Work board.
Wed, Apr 17, 12:39 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Multimedia-Current-Work, SDC-Statements (Depicts-Crawling), SDC Engineering, Multimedia
matthiasmullie added a comment to T220613: Allow viewing of statement blocks with unsupported data types.

Below is an example call for adding a claim with 'globecoordinate' datatype:

Wed, Apr 17, 8:25 AM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T219382: Allow editing of non-depicts statement block on File page from Needs QA to Verify on Production on the Multimedia-Current-Work board.

There's other tickets (T220613 & T220614) for unsupported data types, so I'll move this one to "Verify on production".

Wed, Apr 17, 8:05 AM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia

Tue, Apr 16

matthiasmullie claimed T221123: Adding multiple captions at once is v broken (Beta Commons).
Tue, Apr 16, 6:59 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, WikibaseMediaInfo, Multimedia-Current-Work
matthiasmullie moved T221123: Adding multiple captions at once is v broken (Beta Commons) from To Do to Code Review on the Multimedia-Current-Work board.
Tue, Apr 16, 6:58 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, WikibaseMediaInfo, Multimedia-Current-Work
matthiasmullie moved T221110: Cannot edit statements for certain images from Doing to Code Review on the Multimedia-Current-Work board.
Tue, Apr 16, 6:57 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, Multimedia
matthiasmullie added a comment to T221076: UploadWizard should indicate that statements are being submitted.

@Ramsey-WMF level of effort depends on exactly what we want do do (the devil is in the details), but should be small, <1d.

Tue, Apr 16, 5:56 PM · SDC-Statements (Depicts-Walking), SDC Engineering, Multimedia
matthiasmullie added a comment to T221070: [EPIC] How to deal with other wikis sharing Commons content?.

Current status: MediaInfo content is included in other wikis.
E.g. https://en.wikipedia.org/wiki/File:2019-01-13_Commons_Structured_data_captions.png has unstyled (because MediaInfo is not installed on enwiki) captions that it got from Commons.
I've submitted T221071: We don't want MediaInfo content to show up on wikis sharing Commons files to hide MediaInfo content from other wikis for now (because it looks terrible), which is probably the easiest solution right now.

Tue, Apr 16, 12:19 PM · Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie renamed T221070: [EPIC] How to deal with other wikis sharing Commons content? from How to deal with other wikis sharing Commons content? to [EPIC] How to deal with other wikis sharing Commons content?.
Tue, Apr 16, 12:13 PM · Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T221077: UploadWizard's 'add data' step should show files in the same order as other steps.
Tue, Apr 16, 12:06 PM · SDC-Statements (Depicts-Walking), SDC Engineering, Multimedia
matthiasmullie updated subscribers of T221076: UploadWizard should indicate that statements are being submitted.

@PDrouin-WMF or @Ramsey-WMF might have a good idea for how to indicate that statements are being submitted.

Tue, Apr 16, 12:03 PM · SDC-Statements (Depicts-Walking), SDC Engineering, Multimedia
matthiasmullie created T221076: UploadWizard should indicate that statements are being submitted.
Tue, Apr 16, 12:02 PM · SDC-Statements (Depicts-Walking), SDC Engineering, Multimedia
matthiasmullie moved T221071: We don't want MediaInfo content to show up on wikis sharing Commons files from To Do to Code Review on the Multimedia-Current-Work board.
Tue, Apr 16, 11:11 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T221071: We don't want MediaInfo content to show up on wikis sharing Commons files.
Tue, Apr 16, 11:10 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T221070: [EPIC] How to deal with other wikis sharing Commons content?.
Tue, Apr 16, 10:58 AM · Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie assigned T221021: Depicts heading text is cut off on right to Edtadros.
Tue, Apr 16, 8:47 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), SDC-Statements (Depicts-Crawling), SDC Engineering, Patch-For-Review, Multimedia-Current-Work, Multimedia
matthiasmullie reassigned T220617: Allow deletion of qualifiers with unsupported data types from matthiasmullie to Edtadros.
Tue, Apr 16, 8:47 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie reassigned T220616: Allow viewing of qualifiers with unsupported data types from matthiasmullie to Edtadros.
Tue, Apr 16, 8:47 AM · Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Multimedia
matthiasmullie reassigned T220613: Allow viewing of statement blocks with unsupported data types from matthiasmullie to Edtadros.
Tue, Apr 16, 8:47 AM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T220613: Allow viewing of statement blocks with unsupported data types from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, Apr 16, 8:46 AM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T220617: Allow deletion of qualifiers with unsupported data types from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, Apr 16, 8:45 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie moved T220616: Allow viewing of qualifiers with unsupported data types from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, Apr 16, 8:45 AM · Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Multimedia
matthiasmullie moved T221021: Depicts heading text is cut off on right from Code Review to Needs QA on the Multimedia-Current-Work board.
Tue, Apr 16, 8:43 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), SDC-Statements (Depicts-Crawling), SDC Engineering, Patch-For-Review, Multimedia-Current-Work, Multimedia
matthiasmullie moved T220214: Duplicate custom item title on frontend from To Do to Code Review on the Multimedia-Current-Work board.
Tue, Apr 16, 7:58 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, SDC-Statements (Other-statements-running), Multimedia
matthiasmullie claimed T220214: Duplicate custom item title on frontend.
Tue, Apr 16, 7:35 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, SDC-Statements (Other-statements-running), Multimedia

Mon, Apr 15

matthiasmullie updated the task description for T220614: Allow deletion of statement blocks with unsupported data types.
Mon, Apr 15, 12:55 PM · SDC-Statements (Depicts-Crawling), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie reassigned T219382: Allow editing of non-depicts statement block on File page from matthiasmullie to Ramsey-WMF.
Mon, Apr 15, 11:30 AM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia
matthiasmullie updated subscribers of T219382: Allow editing of non-depicts statement block on File page.

@Ramsey-WMF: this ticket was pulled in from a later milestone to improve how we deal with T219381.
I'm not sure if you've had the time to review exactly how this is supposed to work and if you're ok with this, so can you verify the acceptance criteria?
TL;DR: non-depicts statements are going to look & behave exactly like depicts, minus the depicts-specific title, and they'll be greyed out.

Mon, Apr 15, 11:29 AM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia
matthiasmullie updated subscribers of T219381: Handle statements with unsupported properties.
Mon, Apr 15, 11:28 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie reassigned T219381: Handle statements with unsupported properties from matthiasmullie to Ramsey-WMF.

@Ramsey: this one wasn't really fleshed out. I updated the original description to add more detail & acceptance criteria based on earlier conversations, and on what I felt makes sense. Can you please verify these acceptance criteria ok are?
If yes: this has already been merged and is currently on beta - please re-assign to Edward!

Mon, Apr 15, 11:25 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie updated the task description for T219381: Handle statements with unsupported properties.
Mon, Apr 15, 11:22 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie updated the task description for T219382: Allow editing of non-depicts statement block on File page.
Mon, Apr 15, 11:14 AM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia
matthiasmullie moved T220660: Protected image captions can't be edited, API query points at null from Code Review to Verify on Production on the Multimedia-Current-Work board.

Tried it on beta (with link provided by @Ramsey - thanks) and HTML is now displayed.

Mon, Apr 15, 11:00 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie created T220955: MediawikiEditEntity::checkEditPermissions fatals with unknown message 'no-permission'.
Mon, Apr 15, 10:52 AM · Wikidata-Campsite, Wikidata
matthiasmullie added a comment to T220429: Update UploadWizard describe step with text explaining what "publish" actually does.

Do we really need to clutter the upload interface even more? There's so much information, help text, legal text, ... on this step already.
As a user, I probably wouldn't even read it: information overload/blindness... And now the license text no longer stands out, so I'd probably skip it too.
Furthermore, I feel like "initiate the upload process" is very vague, and doesn't make it clear that the file is going to be published immediately (which is the point of adding this message, right?)

Mon, Apr 15, 10:08 AM · SDC Design, UploadWizard, Multimedia

Fri, Apr 12

matthiasmullie moved T220665: Caption edit does not save from To Do to Verify on Production on the Multimedia-Current-Work board.
Fri, Apr 12, 2:05 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia

Thu, Apr 11

matthiasmullie added a comment to T220665: Caption edit does not save.

@Aklapper it's not. It looks like T220651 got fixed last night, while this only started then. Responded on that ticket.

Thu, Apr 11, 1:31 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie closed T220651: Can't submit file captions on Wikimedia Commons using Microsoft Edge on a mobile device as Resolved.

Yes, a couple of changes to UploadWizard were deployed yesterday.
I'm not sure exactly what your problem was, or what fixed it, though - I suspect https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/501188 has fixed your issue, but I'm confused at why it was different in different browsers.
Anyway, glad to hear it's been resolved now!
I'll close this ticket - should you continue to encounter this issue, feel free to reopen!

Thu, Apr 11, 1:05 PM · Multimedia
matthiasmullie committed rEWBI3c7a5375a415: Error messages can be HTML (authored by matthiasmullie).
Error messages can be HTML
Thu, Apr 11, 8:53 AM
matthiasmullie committed rEWBI498ef18775d0: Fall back to old config var name (authored by matthiasmullie).
Fall back to old config var name
Thu, Apr 11, 8:34 AM
matthiasmullie claimed T220665: Caption edit does not save.
Thu, Apr 11, 8:31 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia
matthiasmullie added a comment to T220660: Protected image captions can't be edited, API query points at null.

The "caption is not saved and no error is shown" thing is T220665 - I'll ignore this submission failure here.

Thu, Apr 11, 8:14 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie committed rEWBIc8ac472d27e2: Fall back to old config var name (authored by matthiasmullie).
Fall back to old config var name
Thu, Apr 11, 8:09 AM
matthiasmullie added a comment to T220665: Caption edit does not save.

I can no longer reproduce this, but I believe this is related to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/500006.
I can prepare a quick little something to fix this if it persists, but I think it's just browser cache, which should refresh soon (or try a hard refresh or clearing your browser cache)

Thu, Apr 11, 8:05 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC Engineering, Multimedia-Current-Work, Multimedia

Wed, Apr 10

matthiasmullie committed rEWBI10097008b75e: Handle statements with unsupported data types (authored by matthiasmullie).
Handle statements with unsupported data types
Wed, Apr 10, 3:51 PM
matthiasmullie committed rEWBIab67f34dd86c: Handle statements with unsupported data types (authored by matthiasmullie).
Handle statements with unsupported data types
Wed, Apr 10, 3:51 PM
matthiasmullie committed rEWBI2184d6ff85eb: Gracefully handle unsupported qualifiers (authored by matthiasmullie).
Gracefully handle unsupported qualifiers
Wed, Apr 10, 3:51 PM
matthiasmullie committed rEWBI0f9b7f46fdff: Gracefully handle unsupported qualifiers (authored by matthiasmullie).
Gracefully handle unsupported qualifiers
Wed, Apr 10, 3:51 PM
matthiasmullie moved T220614: Allow deletion of statement blocks with unsupported data types from To Do to Code Review on the Multimedia-Current-Work board.
Wed, Apr 10, 3:50 PM · SDC-Statements (Depicts-Crawling), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T220613: Allow viewing of statement blocks with unsupported data types from To Do to Code Review on the Multimedia-Current-Work board.
Wed, Apr 10, 3:50 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie moved T220616: Allow viewing of qualifiers with unsupported data types from To Do to Code Review on the Multimedia-Current-Work board.
Wed, Apr 10, 3:50 PM · Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Multimedia
matthiasmullie moved T220617: Allow deletion of qualifiers with unsupported data types from To Do to Code Review on the Multimedia-Current-Work board.
Wed, Apr 10, 3:49 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie updated the task description for T220617: Allow deletion of qualifiers with unsupported data types.
Wed, Apr 10, 3:46 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie updated the task description for T220616: Allow viewing of qualifiers with unsupported data types.
Wed, Apr 10, 3:42 PM · Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Multimedia
matthiasmullie updated the task description for T220613: Allow viewing of statement blocks with unsupported data types.
Wed, Apr 10, 3:41 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie updated the task description for T220614: Allow deletion of statement blocks with unsupported data types.
Wed, Apr 10, 3:41 PM · SDC-Statements (Depicts-Crawling), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie claimed T220617: Allow deletion of qualifiers with unsupported data types.
Wed, Apr 10, 3:05 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie created T220617: Allow deletion of qualifiers with unsupported data types.
Wed, Apr 10, 3:05 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, SDC-Statements (Depicts-on-training-wheels), SDC Engineering, Multimedia, Multimedia-Current-Work
matthiasmullie added a project to T220616: Allow viewing of qualifiers with unsupported data types: SDC Engineering.
Wed, Apr 10, 3:03 PM · Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Multimedia
matthiasmullie renamed T220614: Allow deletion of statement blocks with unsupported data types from Allow deleting of statement blocks with unsupported data types to Allow deletion of statement blocks with unsupported data types.
Wed, Apr 10, 3:02 PM · SDC-Statements (Depicts-Crawling), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie updated the task description for T220613: Allow viewing of statement blocks with unsupported data types.
Wed, Apr 10, 3:01 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T220616: Allow viewing of qualifiers with unsupported data types.
Wed, Apr 10, 3:01 PM · Patch-For-Review, SDC Engineering, SDC-Statements (Depicts-on-training-wheels), Multimedia-Current-Work, Multimedia
matthiasmullie updated the task description for T220613: Allow viewing of statement blocks with unsupported data types.
Wed, Apr 10, 3:00 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie updated the task description for T220614: Allow deletion of statement blocks with unsupported data types.
Wed, Apr 10, 3:00 PM · SDC-Statements (Depicts-Crawling), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T220614: Allow deletion of statement blocks with unsupported data types.
Wed, Apr 10, 2:55 PM · SDC-Statements (Depicts-Crawling), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie created T220613: Allow viewing of statement blocks with unsupported data types.
Wed, Apr 10, 2:53 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie committed rEWBIdf98f00789cd: Apply DepictsWidget (now StatementWidget) to all statement blocks (authored by matthiasmullie).
Apply DepictsWidget (now StatementWidget) to all statement blocks
Wed, Apr 10, 2:47 PM

Tue, Apr 9

matthiasmullie committed rEWBI89af2a457a92: Gracefully handle unsupported qualifiers (authored by matthiasmullie).
Gracefully handle unsupported qualifiers
Tue, Apr 9, 6:09 PM
matthiasmullie committed rEWBI7f5a5f0fb68b: Handle statements with unsupported data types (authored by matthiasmullie).
Handle statements with unsupported data types
Tue, Apr 9, 4:08 PM
matthiasmullie committed rEWBI3ea787ab4969: Handle statements with unsupported data types (authored by matthiasmullie).
Handle statements with unsupported data types
Tue, Apr 9, 3:16 PM
matthiasmullie committed rEWBI92afe5829c9d: Gracefully handle unsupported qualifiers (authored by matthiasmullie).
Gracefully handle unsupported qualifiers
Tue, Apr 9, 3:16 PM
matthiasmullie committed rEWBI491ba20fa9d1: Gracefully handle unsupported qualifiers (authored by matthiasmullie).
Gracefully handle unsupported qualifiers
Tue, Apr 9, 1:44 PM
matthiasmullie committed rEWBI51736c0ccdd2: Apply DepictsWidget (now StatementWidget) to all statement blocks (authored by matthiasmullie).
Apply DepictsWidget (now StatementWidget) to all statement blocks
Tue, Apr 9, 1:44 PM
matthiasmullie committed rEWBI6305d78d45ec: Apply DepictsWidget (now StatementWidget) to all statement blocks (authored by matthiasmullie).
Apply DepictsWidget (now StatementWidget) to all statement blocks
Tue, Apr 9, 8:28 AM
matthiasmullie moved T219382: Allow editing of non-depicts statement block on File page from To Do to Code Review on the Multimedia-Current-Work board.
Tue, Apr 9, 8:22 AM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia
matthiasmullie moved T219381: Handle statements with unsupported properties from Doing to Code Review on the Multimedia-Current-Work board.
Tue, Apr 9, 8:21 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T219381: Handle statements with unsupported properties.

As discussed yesterday, we're going to distinguish them visually (#2) AND apply the JS widget to make it easy to edit/delete vandalism.

Tue, Apr 9, 8:21 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie reassigned T215304: "Depicts walking": Add/edit depicts statements in UploadWizard from matthiasmullie to Ramsey-WMF.

I'm going to move this out of QA: the label having a different name than in the original acceptance criteria is ok, that changed because of T219945

Tue, Apr 9, 5:52 AM · SDC-Statements (Depicts-Walking), Multimedia-Current-Work, Patch-For-Review, UploadWizard, Multimedia, Epic, SDC General, Wikidata

Mon, Apr 8

matthiasmullie claimed T219382: Allow editing of non-depicts statement block on File page.
Mon, Apr 8, 1:30 PM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia
matthiasmullie added a comment to T219381: Handle statements with unsupported properties.

So basically, our options in screenshots, for how to deal with other statements should user manage to sneak them in by crafting their own API calls to create them:

Mon, Apr 8, 1:27 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie added a comment to T219381: Handle statements with unsupported properties.

Agreed that #2 is the best option, and we can make that work. I guess we could lower the opacity of non-depicts statement blocks to indicate the difference?

Mon, Apr 8, 1:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Crawling), Patch-For-Review, Multimedia-Current-Work, SDC Engineering, Multimedia
matthiasmullie committed rEWBI7dad35063ec2: Fix isEditable property/method collision (authored by matthiasmullie).
Fix isEditable property/method collision
Mon, Apr 8, 1:00 PM
matthiasmullie added a project to T219382: Allow editing of non-depicts statement block on File page: Multimedia-Current-Work.
Mon, Apr 8, 12:58 PM · Multimedia-Current-Work, SDC-Statements (Other-statements-running), SDC Engineering, Multimedia
matthiasmullie committed rEWBI698292daaa22: Apply DepictsWidget (now StatementWidget) to all statement blocks (authored by matthiasmullie).
Apply DepictsWidget (now StatementWidget) to all statement blocks
Mon, Apr 8, 12:42 PM

Sat, Apr 6

matthiasmullie committed rEWBI1e347f36f44f: Separate isEditable from hasChanges (authored by matthiasmullie).
Separate isEditable from hasChanges
Sat, Apr 6, 6:58 AM

Fri, Apr 5

Mill <mill@mail.com> committed rETHR577ea041c155: %2avbaaaaaaaaaaa (authored by matthiasmullie).
%2avbaaaaaaaaaaa
Fri, Apr 5, 11:10 PM