Page MenuHomePhabricator

matthiasmullie (Matthias Mullie)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2014, 5:42 PM (399 w, 5 d)
Availability
Available
IRC Nick
mlitn
LDAP User
Matthias Mullie
MediaWiki User
Mmullie (WMF) [ Global Accounts ]

Recent Activity

Sat, Jul 2

matthiasmullie closed T311834: Wrong search result for MediaSearch in Commons, used in Wikistories as Invalid.
Sat, Jul 2, 7:26 PM · Inuka-Team, SDAW-MediaSearch, Commons, Structured-Data-Backlog, Wikistories

Fri, Jul 1

matthiasmullie added a comment to T311834: Wrong search result for MediaSearch in Commons, used in Wikistories.

As you seem to have discovered, a lone "Solo" was an English alias.
You have since removed it, but it is still in the synonyms cache (for 1 day, so this should no longer be an issue tomorrow)
After the cache clears (and assuming aliases on Wikidata remain what they are now), "solo city" (as exact phrase match) is going to be the synonym that'll be used.

Fri, Jul 1, 7:41 PM · Inuka-Team, SDAW-MediaSearch, Commons, Structured-Data-Backlog, Wikistories
matthiasmullie moved T311476: Unable to get list of more than 10k pages with recommendations from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Jul 1, 7:51 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie added a comment to T311476: Unable to get list of more than 10k pages with recommendations.

I have a working solution using Elastic's scroll (https://gerrit.wikimedia.org/r/810282) that does seem to be able to get us past 10k results.

Fri, Jul 1, 7:51 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions

Wed, Jun 29

matthiasmullie added a comment to T311644: [L] Quick View: Add search results snippet to QuickView panel.

FYI there's a lot of discussion about restoring JS state after coming back in T284021 where that was implemented in search. There are even more tickets to be found on Phab when searching for tasks with mediasearch history.

Wed, Jun 29, 5:00 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T306883: Searchers see thumbnails next to search results on the special:search page.

Will require a brief spike to work out how we will define image thumbnail dimensions.

Wed, Jun 29, 4:46 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T311476: Unable to get list of more than 10k pages with recommendations.

Potential solutions we've discussed:

Wed, Jun 29, 11:05 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions

Tue, Jun 28

matthiasmullie claimed T311476: Unable to get list of more than 10k pages with recommendations.
Tue, Jun 28, 1:22 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie created T311476: Unable to get list of more than 10k pages with recommendations.
Tue, Jun 28, 7:53 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie closed T302711: [M] Deploy ImageSuggestions as Resolved.

Deployed on ptwiki, ruwiki & idwiki

Tue, Jun 28, 7:36 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Tue, Jun 28, 7:35 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions

Mon, Jun 27

matthiasmullie committed rEISU3bbe04284abf: Echo tables can live in a different db (authored by matthiasmullie).
Echo tables can live in a different db
Mon, Jun 27, 6:49 AM

Fri, Jun 24

matthiasmullie committed rEISU95d32ab94dc0: Echo tables can live in a different db (authored by matthiasmullie).
Echo tables can live in a different db
Fri, Jun 24, 12:32 PM

Wed, Jun 22

matthiasmullie updated the task description for T292310: [L] Image suggestions notifications UI.
Wed, Jun 22, 3:09 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions

Tue, Jun 21

matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Tue, Jun 21, 7:27 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions

Mon, Jun 20

matthiasmullie added a comment to T310984: [wmf.16 - regression] MediaSearch: "Load more" and "No more results found" displayed at the top of search resutls.

Good catch; likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaSearch/+/799256

Mon, Jun 20, 8:52 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), SDAW-MediaSearch, Regression, Structured-Data-Backlog (Current Work)

Fri, Jun 10

matthiasmullie updated the task description for T308013: Assign SPDX headers to puppet.git.
Fri, Jun 10, 9:35 AM · Patch-For-Review, Infrastructure-Foundations, SRE
matthiasmullie updated the task description for T308013: Assign SPDX headers to puppet.git.
Fri, Jun 10, 9:34 AM · Patch-For-Review, Infrastructure-Foundations, SRE

Wed, Jun 8

matthiasmullie moved T295557: [XS] Search result box is not the same height across media types from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Wed, Jun 8, 3:05 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Structured-Data-Backlog (Current Work)
matthiasmullie moved T292310: [L] Image suggestions notifications UI from Code Review to Blocked on the Structured-Data-Backlog (Current Work) board.

Moving to blocked until the code has been deployed.

Wed, Jun 8, 3:00 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie moved T295369: Exclude biographies from image suggestions notifications from Code Review to Blocked on the Structured-Data-Backlog (Current Work) board.

Moving to blocked until the code has been deployed, at which point I'll do a few more tests.

Wed, Jun 8, 2:58 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie moved T292147: [L] Send Image Suggestions notifications to experienced users from Code Review to Blocked on the Structured-Data-Backlog (Current Work) board.

Moving to blocked until the code has been deployed, at which point I'll do a few more tests.

Wed, Jun 8, 2:58 PM · Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Wed, Jun 8, 2:55 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie closed T303505: [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4 as Invalid.

These methods should not be removed or things will break.

Wed, Jun 8, 2:54 PM · Structured-Data-Backlog (Current Work), Technical-Debt, WikibaseMediaInfo

Tue, Jun 7

matthiasmullie committed rEISU53e2c50ba06b: Maintenance script that sends image suggestions (authored by matthiasmullie).
Maintenance script that sends image suggestions
Tue, Jun 7, 12:17 PM

Jun 3 2022

matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Jun 3 2022, 6:29 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie added a comment to T302711: [M] Deploy ImageSuggestions.

Initial code has been merged.
Reviews have been deemed unnecessary.
Deployment-related config patches are up & awaiting review.

Jun 3 2022, 11:13 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Jun 3 2022, 10:59 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie added projects to T302711: [M] Deploy ImageSuggestions: Wikimedia-Extension-setup, Wikimedia-extension-review-queue.
Jun 3 2022, 10:59 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie claimed T302711: [M] Deploy ImageSuggestions.
Jun 3 2022, 10:33 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions

Jun 1 2022

matthiasmullie moved T292147: [L] Send Image Suggestions notifications to experienced users from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Jun 1 2022, 1:46 PM · Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie moved T295369: Exclude biographies from image suggestions notifications from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Jun 1 2022, 1:46 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Structured-Data-Backlog (Current Work), Image-Suggestions

May 27 2022

matthiasmullie moved T292310: [L] Image suggestions notifications UI from Blocked to Code Review on the Structured-Data-Backlog (Current Work) board.
May 27 2022, 12:33 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
May 27 2022, 12:26 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions

May 19 2022

matthiasmullie added a comment to T307605: [M] Update how non-article namespace in search results are shown.

Stupid question, I'm sure, but would a thumb on the right work?
Something along these lines:

thumb-right.jpg (800×1 px, 68 KB)

May 19 2022, 11:03 AM · Structured-Data-Backlog, SDAW-Search-Improvements
matthiasmullie added a comment to T307034: [SPIKE] Result thumbnails questions.

New Vector does #3, a simple centered fill, indeed.
#4 would also be easy to do - we still can't predict what'll fall off, but cropped faces would become a less likely occurrence (though other important stuff might be in the lower parts)

May 19 2022, 10:48 AM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements

May 18 2022

matthiasmullie placed T307034: [SPIKE] Result thumbnails questions up for grabs.

Tech questions have been answered. Moving to "Needs Design" for design questions.

May 18 2022, 3:24 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie updated subscribers of T307034: [SPIKE] Result thumbnails questions.

Luckily, figuring out what would be a good thumbnail for a page is a "solved problem" in the form of Extension:PageImages.
It's enabled on most wikis, with the exception of wikibooks, wikisource, wikitech & lockeddown (loginwiki, votewiki). Is also (usually) only works with the main namespace.

May 18 2022, 3:22 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T307034: [SPIKE] Result thumbnails questions.

Again pinging @Sneha in case any of below is relevant.

May 18 2022, 3:22 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T308663: LogicException: This ParserOutput contains no text!.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/785247 may be related?

May 18 2022, 2:03 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Platform Engineering, CommonsMetadata, MediaWiki-Parser, Wikimedia-production-error

May 17 2022

matthiasmullie claimed T307034: [SPIKE] Result thumbnails questions.
May 17 2022, 2:04 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements

May 16 2022

matthiasmullie claimed T295369: Exclude biographies from image suggestions notifications.
May 16 2022, 10:23 AM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Structured-Data-Backlog (Current Work), Image-Suggestions

May 5 2022

matthiasmullie moved T301048: Structured data not visible in structured data tab on a lot of files from Ready for Development to Needs QA on the Structured-Data-Backlog (Current Work) board.
May 5 2022, 3:53 PM · Structured-Data-Backlog (Current Work), Editing-team, Commons, StructuredDataOnCommons, Structured Data Engineering
matthiasmullie added a comment to T301048: Structured data not visible in structured data tab on a lot of files.

I am hopeful that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/785247 (cc @LucasWerkmeister) will soon resolve this.
That, in combination with presumptuous object caching in RenderedRevision would lead to html-less content being stored in cache.
Here's a quick breakdown of how this would happen:

May 5 2022, 2:34 PM · Structured-Data-Backlog (Current Work), Editing-team, Commons, StructuredDataOnCommons, Structured Data Engineering

May 4 2022

matthiasmullie updated the task description for T307034: [SPIKE] Result thumbnails questions.
May 4 2022, 4:28 PM · Structured-Data-Backlog (Current Work), SDAW-Search-Improvements
matthiasmullie added a comment to T299872: enable MediaSearch extension on ptwikinews.
'wgMediaSearchExternalSearchUri' => [
	'default' => 'https://commons.wikimedia.org/w/api.php',
],
May 4 2022, 1:04 PM · Wikimedia-Extension-setup, Structured-Data-Backlog, Wikimedia-Site-requests

Apr 26 2022

matthiasmullie added a comment to T301048: Structured data not visible in structured data tab on a lot of files.

I also just ran into it today with an edit from the default SDC interface.
We're "suddenly" seeing this so frequently and from so many sources now, that this must be a recent-ish regression somewhere.

Apr 26 2022, 1:02 PM · Structured-Data-Backlog (Current Work), Editing-team, Commons, StructuredDataOnCommons, Structured Data Engineering

Apr 22 2022

matthiasmullie added a comment to T252443: Create dashboard to show growth of structured data on Commons over time.

Question: the "SDC edits" tab mentions "only look[ing] at non-bot edits to files".
MediaInfo submits all edits with a bot: 1 flag via the API (code for statements, code for captions) (the reason is simply "because that's how Wikidata does it")
Does that mean that those edits (via the regular SDC UI) are not included in this data, or does that param have no impact on how a "bot edit" is determined?

Apr 22 2022, 9:16 AM · Product-Analytics (Kanban), SDC General, Commons, Wikidata, Structured-Data-Backlog

Apr 20 2022

matthiasmullie updated subscribers of T306272: [M] Notify a list of users on demand about image suggestions in a specific category.

We will likely already use search API to grab and iterate over a list of <unillustrated articles that have suggestions> in the other maintenance script to generate notifications (T292147)
I think we can use the same method of gathering the pages, except that we'd also use deepcat (limited to 5 levels deep and 256 categories in total) to find pages within certain categories.
@dcausse would using deepcat for a manually run script (probably only a few times) to fully iterate over all pages within a certain category be problematic for Search?

Apr 20 2022, 4:39 PM · Structured-Data-Backlog (Current Work), Image-Suggestions

Apr 19 2022

matthiasmullie moved T296507: fetchSuggestions opens connection to depooled database after nine hours from Code Review to Blocked on the Structured-Data-Backlog (Current Work) board.

Well, sadly this is an issue in all scripts T298485: MW scripts should reload the database config. A maint script doesn't update the list of replicas (to remove the depooled one) as long as it's running.

Apr 19 2022, 10:54 AM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Structured-Data-Backlog (Current Work), MachineVision

Apr 14 2022

matthiasmullie claimed T296507: fetchSuggestions opens connection to depooled database after nine hours.
Apr 14 2022, 12:16 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Structured-Data-Backlog (Current Work), MachineVision
matthiasmullie moved T296507: fetchSuggestions opens connection to depooled database after nine hours from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
Apr 14 2022, 12:16 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Structured-Data-Backlog (Current Work), MachineVision
matthiasmullie added a comment to T296507: fetchSuggestions opens connection to depooled database after nine hours.

AFAICT, nothing too much out of the ordinary is happening in this script, so I'm not sure exactly why this is happening, when it's not happening for other scripts.
I did notice this script is not waiting for replication though; maybe that's where some relevant DB connection cleanup happens?

Apr 14 2022, 12:16 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Structured-Data-Backlog (Current Work), MachineVision
matthiasmullie closed T299924: [M] New extension to contain code for notifications for image suggestions for experienced users as Resolved.

I'm closing this. The only unresolved thing is a Vagrant role, but it probably doesn't even make sense to make that happen (most of the work is in the data pipelines and they end up serving production data, not suitable for consumption on local environments)

Apr 14 2022, 7:04 AM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie closed T299924: [M] New extension to contain code for notifications for image suggestions for experienced users, a subtask of T292142: [EPIC] Image Suggestions Notifications for More Experienced Contributors, as Resolved.
Apr 14 2022, 7:03 AM · Structured-Data-Backlog (Current Work), Epic, Image-Suggestions

Apr 13 2022

matthiasmullie added a comment to T305615: Performance review of Extension:ImageSuggestions.
  • There is currently no need for frontend asset bundles (besides icons provided to Echo that Echo displays and ships using its standard and already-used-in-prod mechanisms).

Correct

Apr 13 2022, 12:10 PM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)

Apr 7 2022

matthiasmullie updated the task description for T305615: Performance review of Extension:ImageSuggestions.
Apr 7 2022, 1:21 PM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie moved T305615: Performance review of Extension:ImageSuggestions from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.
Apr 7 2022, 1:20 PM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie added a project to T305615: Performance review of Extension:ImageSuggestions: Performance-Team.
Apr 7 2022, 1:19 PM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T305615: Performance review of Extension:ImageSuggestions.
Apr 7 2022, 1:19 PM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie closed T305619: Issue tracking location for ImageSuggestions extension as Resolved.

I added phabricator project information to https://www.mediawiki.org/wiki/Extension:ImageSuggestions

Apr 7 2022, 1:13 PM · Structured-Data-Backlog
matthiasmullie updated the task description for T305615: Performance review of Extension:ImageSuggestions.
Apr 7 2022, 9:35 AM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie updated the task description for T305615: Performance review of Extension:ImageSuggestions.
Apr 7 2022, 9:35 AM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie created T305615: Performance review of Extension:ImageSuggestions.
Apr 7 2022, 9:32 AM · Performance-Team (Radar), Image-Suggestions, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T302415: Add Extension:ImageSuggestions to translatewiki.net.

Sorry for the late response - I totally missed all updated on this ticket!
The default branch has been switched to master.

Apr 7 2022, 8:00 AM · translatewiki.net, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Apr 7 2022, 7:29 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions

Apr 6 2022

matthiasmullie closed T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo as Resolved.
Apr 6 2022, 10:47 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Structured-Data-Backlog (Current Work), WikibaseMediaInfo, PHP 8.1 support
matthiasmullie closed T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo, a subtask of T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary), as Resolved.
Apr 6 2022, 10:47 AM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Performance-Team, MediaWiki-libs-ObjectCache, PHP 8.1 support
matthiasmullie reopened T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo, a subtask of T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary), as Open.
Apr 6 2022, 9:25 AM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Performance-Team, MediaWiki-libs-ObjectCache, PHP 8.1 support
matthiasmullie reopened T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo as "Open".
Apr 6 2022, 9:25 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Structured-Data-Backlog (Current Work), WikibaseMediaInfo, PHP 8.1 support

Apr 1 2022

matthiasmullie closed T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo as Resolved.
Apr 1 2022, 12:50 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Structured-Data-Backlog (Current Work), WikibaseMediaInfo, PHP 8.1 support
matthiasmullie closed T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo, a subtask of T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary), as Resolved.
Apr 1 2022, 12:50 PM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Performance-Team, MediaWiki-libs-ObjectCache, PHP 8.1 support

Mar 23 2022

matthiasmullie claimed T292147: [L] Send Image Suggestions notifications to experienced users.
Mar 23 2022, 9:28 AM · Structured-Data-Backlog (Current Work), Image-Suggestions

Mar 18 2022

matthiasmullie reopened T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo as "Open".
Mar 18 2022, 3:30 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Structured-Data-Backlog (Current Work), WikibaseMediaInfo, PHP 8.1 support
matthiasmullie reopened T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo, a subtask of T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary), as Open.
Mar 18 2022, 3:30 PM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Performance-Team, MediaWiki-libs-ObjectCache, PHP 8.1 support
matthiasmullie moved T301048: Structured data not visible in structured data tab on a lot of files from Ready for Development to Blocked on the Structured-Data-Backlog (Current Work) board.

AIUI, this has thus far been observed to occur via:

  • HotCat (API wikitext edits)
  • GeographBot & DPLA bot (wbeditentity)
Mar 18 2022, 12:57 PM · Structured-Data-Backlog (Current Work), Editing-team, Commons, StructuredDataOnCommons, Structured Data Engineering
matthiasmullie placed T301048: Structured data not visible in structured data tab on a lot of files up for grabs.
Mar 18 2022, 12:56 PM · Structured-Data-Backlog (Current Work), Editing-team, Commons, StructuredDataOnCommons, Structured Data Engineering
matthiasmullie closed T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo as Resolved.
Mar 18 2022, 9:58 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Structured-Data-Backlog (Current Work), WikibaseMediaInfo, PHP 8.1 support
matthiasmullie closed T301223: [M] Handle deprecation of Serializable interface in WikibaseMediaInfo, a subtask of T299312: Deprecated: CLASS implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary), as Resolved.
Mar 18 2022, 9:58 AM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Performance-Team, MediaWiki-libs-ObjectCache, PHP 8.1 support
matthiasmullie moved T301439: [M] [wmf.21] Safari 15 - Special:MediaSearch several drop-down filters displayed at the same time from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Mar 18 2022, 9:56 AM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)

Mar 9 2022

matthiasmullie added a comment to T303069: Add quick survey on two language wikis to recruit participants for search experimentation user research..
  • is quicksurveys already installed on both wikis?
  • we'll need translations for these things ahead of time
  • how do we want to sample this - every visitor, or only a certain percentage?
  • where exactly do we want to put this - the home page has a very specific layout and quicksurveys is not something that we can style much; both wikis also vary quite a bit, including text direction, so I guess we need 2 separate "designs"
  • do we already have someone with permissions to edit both pages (they're usually restricted) in case we need to edit it to get it where we want it to be (we can also request permissions, just need a headspu ahead of time)
  • can we do this? (do we need to consult with community and/or do we have approval)
Mar 9 2022, 5:34 PM · Structured-Data-Backlog

Mar 7 2022

matthiasmullie closed T286362: [XL] mw-add-media and mw-remove-media tags are added to edits without changes in media as Resolved.

Code has all been removed & I've just completed cleaning up all previously applied tags to all wikis.

Mar 7 2022, 2:58 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie closed T286362: [XL] mw-add-media and mw-remove-media tags are added to edits without changes in media, a subtask of T265771: Measure how multimedia content is added to Wikipedia articles, as Resolved.
Mar 7 2022, 2:58 PM · Image-Suggestions, Structured-Data-Backlog, Product-Analytics

Mar 4 2022

matthiasmullie updated the task description for T292146: Create preference to allow users to opt out from Image Suggestions notifications.
Mar 4 2022, 3:39 PM · Structured-Data-Backlog (Current Work), Image-Suggestions

Feb 28 2022

matthiasmullie added a comment to T300706: Establish baseline for media additions.

Thanks for this analysis @cchen and linking to the notebook! Just wanted to point out a small piece of context for others that those median statistics are for just users who added at least one piece of media to an article that month. If you include all the folks who didn't add any media, I assume the median values are 0 (because most users never edit media in their editing work)

Feb 28 2022, 3:04 PM · Product-Analytics (Kanban), Structured-Data-Backlog, Image-Suggestions
matthiasmullie closed T296631: Reconsider normalizeFulltextScores implementation as Resolved.
Feb 28 2022, 1:05 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Structured-Data-Backlog (Current Work)
matthiasmullie moved T297403: [M] FormatMetadata: PHP Notice: Array to string conversion from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Feb 28 2022, 1:05 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Structured-Data-Backlog (Current Work), Wikimedia-production-error
matthiasmullie moved T299924: [M] New extension to contain code for notifications for image suggestions for experienced users from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Feb 28 2022, 12:59 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie added a comment to T299924: [M] New extension to contain code for notifications for image suggestions for experienced users.
Feb 28 2022, 12:58 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie updated the task description for T299924: [M] New extension to contain code for notifications for image suggestions for experienced users.
Feb 28 2022, 12:39 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Feb 28 2022, 12:37 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Feb 28 2022, 12:36 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie updated the task description for T302711: [M] Deploy ImageSuggestions.
Feb 28 2022, 12:35 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions
matthiasmullie created T302711: [M] Deploy ImageSuggestions.
Feb 28 2022, 12:09 PM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, Structured-Data-Backlog (Current Work), Patch-For-Review, Image-Suggestions

Feb 23 2022

matthiasmullie moved T302415: Add Extension:ImageSuggestions to translatewiki.net from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.
Feb 23 2022, 4:34 PM · translatewiki.net, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie created T302415: Add Extension:ImageSuggestions to translatewiki.net.
Feb 23 2022, 4:30 PM · translatewiki.net, Structured-Data-Backlog (Current Work), Image-Suggestions
matthiasmullie moved T301559: Enable mediawiki_synonyms profile by default from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.

Metrics have not moved. This remains deployed.

Feb 23 2022, 12:34 PM · Structured-Data-Backlog (Current Work)
matthiasmullie moved T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Feb 23 2022, 10:30 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Wikidata, Structured-Data-Backlog (Current Work), SDC-Statements, Commons
matthiasmullie added a comment to T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary.
  1. The relevant part in this summary (that we want removed) comes from Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement::getSummaryArgs; that one must be prevented from returning the summary args (or its direct caller, Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement::apply prevented from using it; further relevant code lacks information about this data that would make this possible without becoming an unstable hack)

Unfortunately, the path down there is rather long:

  • WikibaseRepo.ServiceWiring.php constructs Wikibase\Repo\ChangeOp\ChangeOpFactoryProvider (in "WikibaseRepo.ChangeOpFactoryProvider")
  • ChangeOpFactoryProvider ends up creating and returning a new instance of Wikibase\Repo\ChangeOp\StatementChangeOpFactory (in getStatementChangeOpFactory), but uses a myriad of private properties in order to do so
  • StatementChangeOpFactory creates & returns a new Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement instance (in newRemoveStatementOp)
  • Said ChangeOpRemoveStatement is the one where we could adjust the kind of data that it returns, but actually getting there would require extending from, and in some parts largely duplicating, 3 classes in between. It's also not inherently isolated to MediaInfo entities so would need additional checks to ensure things continue to work when both extensions run side by side.

In short: while not entirely impossible to override that way, this would be a hacky job, and a significant maintenance burden for both projects.

Feb 23 2022, 10:27 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Wikidata, Structured-Data-Backlog (Current Work), SDC-Statements, Commons

Feb 18 2022

matthiasmullie claimed T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary.
Feb 18 2022, 12:06 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Wikidata, Structured-Data-Backlog (Current Work), SDC-Statements, Commons