Page MenuHomePhabricator

mewoph (Mew Ophaswongse)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2021, 8:52 PM (15 w, 5 h)
Availability
Available
LDAP User
MewOphaswongse
MediaWiki User
MOphaswongse (WMF) [ Global Accounts ]

Recent Activity

Yesterday

mewoph added a comment to T281771: Prevent contenteditabe like experiences (cursor placement; menu selection for cutting text) in AddLinkArticleTarget.

It looks like setting inputMode='none' interferes somehow with OOUI's window opening/closing logic...perhaps it changes the focused element or scroll position? I did a quick test without the link inspector & with VE loaded in standard mode. It looks like this weird behavior only occurs when opening the dialog and tapping on a surface w/inputMode='none'.

Mon, May 10, 11:09 PM · Patch-For-Review, Add-Link, Growth-Team (Current Sprint)

Fri, May 7

mewoph added a comment to T281771: Prevent contenteditabe like experiences (cursor placement; menu selection for cutting text) in AddLinkArticleTarget.

Posted a WIP patch with some improvements:

Fri, May 7, 12:00 AM · Patch-For-Review, Add-Link, Growth-Team (Current Sprint)

Thu, May 6

mewoph added a comment to T282194: [mobile] Add link: clicking on article elements triggers "Unrecognized symbolic name: alien".

Hi @Etonkovidova which environment is this from? With changes for T281434: Add link: VE shortcut opens a regular link inspector overlapping add link context item context items for elements other than link recommendations should not be invoked.

Thu, May 6, 11:28 PM · Growth-Team, Add-Link

Wed, May 5

mewoph added a comment to T281771: Prevent contenteditabe like experiences (cursor placement; menu selection for cutting text) in AddLinkArticleTarget.

@kostajh I wanted to clarify to behavior you're referring to. Do you mean this effect when the link inspector shifts up as the article is scrolled when tapping anywhere on the surface?

Wed, May 5, 10:12 PM · Patch-For-Review, Add-Link, Growth-Team (Current Sprint)
mewoph added a subtask for T252822: [EPIC] Growth: "add a link" structured task 1.0: T281967: Infinite loop between edit / edit source for linkrecommendation tasks.
Wed, May 5, 8:00 PM · Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks, Epic
mewoph added a parent task for T281967: Infinite loop between edit / edit source for linkrecommendation tasks: T252822: [EPIC] Growth: "add a link" structured task 1.0.
Wed, May 5, 8:00 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T281967: Infinite loop between edit / edit source for linkrecommendation tasks from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Wed, May 5, 7:59 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281967: Infinite loop between edit / edit source for linkrecommendation tasks.

I tried to reproduce the issue in https://ar.wikipedia.beta.wmflabs.org/ and locally with "Remember my last editor" editing preference enabled but am getting VisualEditor when clicked on a link recommendation task even though my last editor was the source editor. Maybe other settings are needed to reproduce this issue?

Wed, May 5, 6:40 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T278488: Add a link: guidance content: update help panel content from Design Review to Code Review on the Growth-Team (Current Sprint) board.

Hi @RHo, I just posted a patch to show the suggested-edits screen for link-recommendation.

Wed, May 5, 5:58 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T281960: TypeError: can't access property "setNotices", actionTools.notices is undefined from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, May 5, 5:42 PM · Add-Link, Growth-Team (Current Sprint), Wikimedia-production-error
mewoph moved T282030: Add a link: Yes button flickers when toggling states from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, May 5, 5:41 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T282030: Add a link: Yes button flickers when toggling states.

With latest changes:

Wed, May 5, 5:40 PM · Growth-Team (Current Sprint), Add-Link
mewoph claimed T282030: Add a link: Yes button flickers when toggling states.
Wed, May 5, 5:32 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T282030: Add a link: Yes button flickers when toggling states from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Wed, May 5, 5:32 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T282030: Add a link: Yes button flickers when toggling states from Backlog to May 3 - May 7 on the Add-Link board.
Wed, May 5, 5:32 PM · Growth-Team (Current Sprint), Add-Link
mewoph created T282030: Add a link: Yes button flickers when toggling states.
Wed, May 5, 5:31 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T281961: AddLinkArticleTarget toolbar does not display properly from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Wed, May 5, 5:20 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281961: AddLinkArticleTarget toolbar does not display properly.

Same article w/latest changes:

Wed, May 5, 5:19 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281961: AddLinkArticleTarget toolbar does not display properly.

The floating state of the toolbar should only be applied when the page is scrolled.

Wed, May 5, 5:04 PM · Growth-Team (Current Sprint), Add-Link

Tue, May 4

mewoph moved T281288: Add a link: beta wiki, issue with width display on mobile of Growth feature: Add a link from QA to Code Review on the Growth-Team (Current Sprint) board.

Firefox Android w/latest changes:

Tue, May 4, 10:06 PM · Growth-Team (Current Sprint), Mobile, Add-Link, GrowthExperiments-Homepage
mewoph added a comment to T281288: Add a link: beta wiki, issue with width display on mobile of Growth feature: Add a link.

In Firefox, the scrollWidth of the topics overlay is incorrect, it should be the same as window.innerWidth

Tue, May 4, 6:49 PM · Growth-Team (Current Sprint), Mobile, Add-Link, GrowthExperiments-Homepage

Mon, May 3

mewoph moved T281788: Add a link in VE: Include "below" and "inline" position values for ve.ui.ToolbarDialog upstream from Backlog to May 3 - May 7 on the Add-Link board.
Mon, May 3, 11:41 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph moved T281788: Add a link in VE: Include "below" and "inline" position values for ve.ui.ToolbarDialog upstream from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Mon, May 3, 11:41 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph renamed T281788: Add a link in VE: Include "below" and "inline" position values for ve.ui.ToolbarDialog upstream from Add a link in VE: Include new position values upstream to Add a link in VE: Include "below" and "inline" position values for ve.ui.ToolbarDialog upstream.
Mon, May 3, 11:40 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph created T281788: Add a link in VE: Include "below" and "inline" position values for ve.ui.ToolbarDialog upstream.
Mon, May 3, 11:40 PM · Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph moved T281463: Set background color to recommended link context item from May 3 - May 7 to QA on the Add-Link board.
Mon, May 3, 11:29 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T281463: Set background color to recommended link context item from Ready for Development to QA on the Growth-Team (Current Sprint) board.
Mon, May 3, 11:29 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281463: Set background color to recommended link context item.

With changes for T280129: Disable interactions with all context items except for RecommendedLinkContextItem, this issue is not reproducible.

Mon, May 3, 11:28 PM · Growth-Team (Current Sprint), Add-Link
mewoph merged task T280129: Disable interactions with all context items except for RecommendedLinkContextItem into T281463: Set background color to recommended link context item.
Mon, May 3, 11:28 PM · Growth-Team (Current Sprint), Add-Link
mewoph merged T280129: Disable interactions with all context items except for RecommendedLinkContextItem into T281463: Set background color to recommended link context item.
Mon, May 3, 11:28 PM · Growth-Team (Current Sprint), Add-Link
mewoph created T281786: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface MediaWiki\User\UserIdentity, null given, called in /srv/mediawiki/php-1.37.0-wmf.3/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php on line 170.
Mon, May 3, 11:09 PM · GrowthExperiments, Growth-Team, Wikimedia-production-error
mewoph created T281785: Flow\Exception\NoParserException: Request to parsoid for "wikitext" to "html" conversion of content connected to title "User_talk:Afrain" failed: 500.
Mon, May 3, 11:06 PM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
mewoph created T281784: Flow\Exception\InvalidDataException: Revisions for w3m0hl06e77t05d6 could not be found.
Mon, May 3, 11:02 PM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
mewoph created T281783: Flow\Exception\FailCommitException: Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value. This indicates the blocks are not able to commit, so Flow\SubmissionHandler::commit should not be called..
Mon, May 3, 11:01 PM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
mewoph created T281782: Flow: ContributionsFormatter times out for a certain user.
Mon, May 3, 10:58 PM · Parsoid (Tracking), StructuredDiscussions, Growth-Team, Wikimedia-production-error
mewoph moved T281774: Ensure link suggestion stays highlighted from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Mon, May 3, 10:51 PM · Growth-Team (Current Sprint), Add-Link
mewoph claimed T281774: Ensure link suggestion stays highlighted.
Mon, May 3, 10:47 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T281616: Add link: context item should always be visible from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Mon, May 3, 10:13 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281616: Add link: context item should always be visible .

Updated scroll behavior on desktop:

Mon, May 3, 10:11 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281616: Add link: context item should always be visible .

The bottom offset was added along with the changes for T281496: Add a link: virtual keyboard covers the link inspector on mobile. I'll update the top offset so that when navigating back, the annotation appears a bit lower on the page.

Mon, May 3, 6:18 PM · Growth-Team (Current Sprint), Add-Link
mewoph updated the task description for T281616: Add link: context item should always be visible .
Mon, May 3, 6:13 PM · Growth-Team (Current Sprint), Add-Link

Fri, Apr 30

mewoph added a comment to T278298: Replace all references to "AI" and "artificial intelligence" for labeling link recommendation suggestions.

Hi @Etonkovidova, the learn more like is only shown if learnmore field is set for the task type in the wiki's MediaWiki:NewcomerTasks.json page. For en betalabs https://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:NewcomerTasks.json, it looks like this field is not present.

Fri, Apr 30, 9:32 PM · Research, Growth-Team (Current Sprint), Add-Link
mewoph moved T281452: annotation not found for offset from April 26 - April 30 to QA on the Add-Link board.
Fri, Apr 30, 8:07 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph moved T281452: annotation not found for offset from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Apr 30, 8:07 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link

Thu, Apr 29

mewoph moved T281496: Add a link: virtual keyboard covers the link inspector on mobile from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Apr 29, 10:17 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281496: Add a link: virtual keyboard covers the link inspector on mobile.

Another issue w/keyboard: when tapping on anywhere in the surface (outside of the recommended link annotations), the keyboard shows up and the link inspector is pushed towards the top of the screen (whereas with the default context item, tapping outside the link inspector should dismiss it)

Thu, Apr 29, 9:37 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T281496: Add a link: virtual keyboard covers the link inspector on mobile.

The patch addresses the issue where the keyboard shows up when navigating between recommendations using buttons in the link inspector.

Thu, Apr 29, 9:11 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph claimed T281496: Add a link: virtual keyboard covers the link inspector on mobile.
Thu, Apr 29, 3:43 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph moved T281496: Add a link: virtual keyboard covers the link inspector on mobile from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Thu, Apr 29, 3:43 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph moved T281496: Add a link: virtual keyboard covers the link inspector on mobile from Backlog to April 26 - April 30 on the Add-Link board.
Thu, Apr 29, 3:43 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph created T281496: Add a link: virtual keyboard covers the link inspector on mobile.
Thu, Apr 29, 3:42 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link

Wed, Apr 28

mewoph moved T269658: Add a link: skipped all suggestions dialog from April 26 - April 30 to QA on the Add-Link board.
Wed, Apr 28, 11:21 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T267690: Add a link in VE: don't write to or read from restored edits from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Apr 28, 11:15 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph moved T267690: Add a link in VE: don't write to or read from restored edits from April 26 - April 30 to QA on the Add-Link board.
Wed, Apr 28, 11:15 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph claimed T267690: Add a link in VE: don't write to or read from restored edits.
Wed, Apr 28, 11:15 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph moved T280616: [betalabs] Add link: switching to source editor results in persistent page re-loading from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Apr 28, 11:14 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Growth-Structured-Tasks, Add-Link, GrowthExperiments
mewoph moved T280616: [betalabs] Add link: switching to source editor results in persistent page re-loading from April 26 - April 30 to QA on the Add-Link board.
Wed, Apr 28, 11:14 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Growth-Structured-Tasks, Add-Link, GrowthExperiments
mewoph added a comment to T280991: Add a link: open the article in edit mode right away.

From @kostajh's comment in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/683410/1/includes/HomepageModules/SuggestedEdits.php

Wed, Apr 28, 9:48 PM · Growth-Team, Add-Link
mewoph moved T267690: Add a link in VE: don't write to or read from restored edits from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Apr 28, 6:30 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph moved T267690: Add a link in VE: don't write to or read from restored edits from QA to In Progress on the Growth-Team (Current Sprint) board.
Wed, Apr 28, 6:27 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph reopened T267690: Add a link in VE: don't write to or read from restored edits, a subtask of T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach, as Open.
Wed, Apr 28, 6:27 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph reopened T267690: Add a link in VE: don't write to or read from restored edits as "Open".

Reopening this since I was still able to reproduce this issue

Wed, Apr 28, 6:27 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Add-Link, Growth-Team (Current Sprint), Growth-Structured-Tasks
mewoph moved T269658: Add a link: skipped all suggestions dialog from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Apr 28, 5:55 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T280616: [betalabs] Add link: switching to source editor results in persistent page re-loading from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Apr 28, 5:52 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Growth-Structured-Tasks, Add-Link, GrowthExperiments

Tue, Apr 27

mewoph added a comment to T281319: Add a link: triangle on link inspector has incorrect background color.

Updated color:

Tue, Apr 27, 10:28 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph moved T281319: Add a link: triangle on link inspector has incorrect background color from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Tue, Apr 27, 10:28 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph moved T281319: Add a link: triangle on link inspector has incorrect background color from Backlog to April 26 - April 30 on the Add-Link board.
Tue, Apr 27, 10:28 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph updated the task description for T281319: Add a link: triangle on link inspector has incorrect background color.
Tue, Apr 27, 9:55 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph updated the task description for T281319: Add a link: triangle on link inspector has incorrect background color.
Tue, Apr 27, 9:54 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph created T281319: Add a link: triangle on link inspector has incorrect background color.
Tue, Apr 27, 9:39 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T279684: [Design review] Visual design tweaks for the suggested link tags in Suggestions mode.

Updated background color:

Tue, Apr 27, 9:34 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T279684: [Design review] Visual design tweaks for the suggested link tags in Suggestions mode from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Apr 27, 9:33 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T279684: [Design review] Visual design tweaks for the suggested link tags in Suggestions mode from QA to April 26 - April 30 on the Add-Link board.
Tue, Apr 27, 9:27 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph added a comment to T279684: [Design review] Visual design tweaks for the suggested link tags in Suggestions mode.

Hi @RHo, that should address it. I'll update the background color to #F4F9FF

Tue, Apr 27, 9:27 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T267706: Add a link in VE: Use a permanent context instead of VE's built-in context from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Apr 27, 7:46 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph added a comment to T267706: Add a link in VE: Use a permanent context instead of VE's built-in context.

@kostajh I'll do that as part of this work. Will also include the follow up changes from your comments

Tue, Apr 27, 6:31 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph claimed T280616: [betalabs] Add link: switching to source editor results in persistent page re-loading.
Tue, Apr 27, 4:51 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Growth-Structured-Tasks, Add-Link, GrowthExperiments
mewoph added a comment to T280616: [betalabs] Add link: switching to source editor results in persistent page re-loading.

This seems to be caused by my changes to open edit mode via JS

Tue, Apr 27, 4:51 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Growth-Structured-Tasks, Add-Link, GrowthExperiments
mewoph added a comment to T267706: Add a link in VE: Use a permanent context instead of VE's built-in context.

The positioning has been implemented in my latest patchset. For desktop, one difference from the original context item is that the link inspector is now aligned with the annotation rather than positioned based on the position of the cursor. I was unable to re-use existing positioning logic from ve.ui.DesktopContext and this was a simpler implementation. The positioning behavior is as follows:

Tue, Apr 27, 4:21 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph created T281206: '.event.abort_timing' should be integer.
Tue, Apr 27, 12:04 AM · Editing-team, Wikimedia-production-error
mewoph added a project to T281205: PHP Warning: array_combine() expects parameter 1 to be array, null given: Growth-Team.
Tue, Apr 27, 12:03 AM · GrowthExperiments, Growth-Team, Wikimedia-production-error

Mon, Apr 26

mewoph created T281205: PHP Warning: array_combine() expects parameter 1 to be array, null given.
Mon, Apr 26, 11:58 PM · GrowthExperiments, Growth-Team, Wikimedia-production-error

Fri, Apr 23

mewoph added a comment to T267706: Add a link in VE: Use a permanent context instead of VE's built-in context.

I posted a WIP patch with RecommendedLinkToolbarDialog (extending ve.ui.ToolbarDialog) with the following existing functionalities:

  • accepting/rejecting recommendations
  • auto advancing upon acceptance/rejection
  • updating the UI based on current selection
  • showing link preview
  • navigating through recommendations
Fri, Apr 23, 11:21 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
mewoph added a comment to T280129: Disable interactions with all context items except for RecommendedLinkContextItem.

Hi @MMiller_WMF I think this should be kept separate even though they are related. Once a permanent context is used for the link inspector, nothing is stopping the user from clicking outside the link inspector (and on elements other than the link recommendations) so it's possible that existing context items would still show up.

Fri, Apr 23, 11:07 PM · Growth-Team (Current Sprint), Add-Link
mewoph added a comment to T280089: Add a link: delay the intro pop-up animating on until after VisualEditor loads.

Hi @RHo — loading the article right away should be possible. I think there will be some additional work to ensure that on mobile, when the user closes Suggestions mode, they are taken to the article's read mode rather than back to the homepage. I went ahead and created T280991: Add a link: open the article in edit mode right away — feel free to add/edit. Thanks!

Fri, Apr 23, 5:23 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), Add-Link
mewoph created T280991: Add a link: open the article in edit mode right away.
Fri, Apr 23, 5:22 PM · Growth-Team, Add-Link

Wed, Apr 21

mewoph closed T280819: Add a link: accept & reject buttons are on a separate line in RTL language as Invalid.

This issue was found with un-merged changes for T280277: [Design] Link inspector layout issues. Will address this issue with T280277 instead.

Wed, Apr 21, 4:59 PM · Growth-Team (Current Sprint), Add-Link
mewoph claimed T280819: Add a link: accept & reject buttons are on a separate line in RTL language.
Wed, Apr 21, 4:42 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T280819: Add a link: accept & reject buttons are on a separate line in RTL language from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Wed, Apr 21, 4:40 PM · Growth-Team (Current Sprint), Add-Link
mewoph moved T280819: Add a link: accept & reject buttons are on a separate line in RTL language from Backlog to April 19 - April 23 on the Add-Link board.
Wed, Apr 21, 4:39 PM · Growth-Team (Current Sprint), Add-Link
mewoph created T280819: Add a link: accept & reject buttons are on a separate line in RTL language.
Wed, Apr 21, 4:39 PM · Growth-Team (Current Sprint), Add-Link

Mon, Apr 19

mewoph moved T280277: [Design] Link inspector layout issues from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Mon, Apr 19, 9:53 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph added a comment to T280277: [Design] Link inspector layout issues.

I've added Please keep to as succinct text strings as possible in the translation. to the QQQs for growthexperiments-addlink-context-button-accept and growthexperiments-addlink-context-button-reject

Mon, Apr 19, 9:53 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mewoph moved T280564: Add a link: help panel button shows up when reloading (mobile) from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Mon, Apr 19, 4:31 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), Add-Link
mewoph moved T280564: Add a link: help panel button shows up when reloading (mobile) from Backlog to April 19 - April 23 on the Add-Link board.
Mon, Apr 19, 4:19 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), Add-Link
mewoph claimed T280564: Add a link: help panel button shows up when reloading (mobile).
Mon, Apr 19, 4:19 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), Add-Link
mewoph created T280564: Add a link: help panel button shows up when reloading (mobile).
Mon, Apr 19, 4:17 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), Add-Link
mewoph updated subscribers of T280277: [Design] Link inspector layout issues.

I do see your point about how having a long 'Yes' and or 'No' could also cause further wrapping, so would we be able to provide one further flex in that case so that the buttons then left align and fit across the whole width, but any further we would clip so that the Yes No (and "..." if shown ) buttons always stay on one 1-line.

Mon, Apr 19, 4:11 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Fri, Apr 16

mewoph moved T280276: [Design] Link inspector button style fixes from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Apr 16, 7:37 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team-Filtering, Add-Link, Growth-Team (Current Sprint), GrowthExperiments, Growth-Structured-Tasks
mewoph added a comment to T280276: [Design] Link inspector button style fixes.

Fri, Apr 16, 7:37 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team-Filtering, Add-Link, Growth-Team (Current Sprint), GrowthExperiments, Growth-Structured-Tasks