Page MenuHomePhabricator

mmodell (Mukunda Modell)
Release Engineer, Phabricator AdminAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 9:45 AM (370 w, 22 h)
Roles
Administrator
Availability
Available
IRC Nick
twentyafterfour
LDAP User
20after4
MediaWiki User
MModell (WMF) [ Global Accounts ]

I am a Software Engineer on the Wikimedia Release-Engineering-Team.

What I do

Deployments

A big part of my work involves release automation and tooling. This includes Scap, Deployments, MediaWiki-Release-Tools and Train Deployments.

Phabricator

I am also responsible for Phabricator maintenance, improvements and occasional software deployments. I'm constantly working to improve phabricator through my contributions to Wikimedia-Phabricator-Extensions (rPHEX phabricator-extensions) and Phabricator (Upstream).

Elsewhere on the web:

github/20after4
Stack Overflow/20after4

Disclaimer: I work for the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.`

Recent Activity

Wed, Oct 20

mmodell moved T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from Backlog to In progress on the Release-Engineering-Team (Done by Thu 04 Nov) board.
Wed, Oct 20, 7:10 PM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator
mmodell added a comment to T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.

This is a straightforward and simple bugfix.

Wed, Oct 20, 5:41 PM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator
mmodell claimed T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.
Wed, Oct 20, 5:39 PM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator

Tue, Oct 19

mmodell moved T291978: Limit GitLab shared runners to images from Wikimedia Docker registry from Done by Wed 06 Oct to Priority Backlog 🔥 on the Release-Engineering-Team board.
Tue, Oct 19, 7:18 PM · Release-Engineering-Team (Priority Backlog 🔥), Security-Team, Patch-For-Review, User-brennen, GitLab (CI & Job Runners), Security
mmodell awarded T293604: Puppet failure on phabricator-prod-1001.devtools.eqiad1.wikimedia.cloud a Mountain of Wealth token.
Tue, Oct 19, 11:43 AM · Patch-For-Review, Phabricator
mmodell closed T293604: Puppet failure on phabricator-prod-1001.devtools.eqiad1.wikimedia.cloud as Resolved.

Thanks for the fix!

Tue, Oct 19, 11:43 AM · Patch-For-Review, Phabricator
mmodell added a comment to T191865: Deploy "Due Dates" / Deadlines feature.

More than a year too late but...

Tue, Oct 19, 11:37 AM · Release-Engineering-Team (Kanban), Phabricator
mmodell added a project to T293734: Make assignees or setters of a past Due Date on a non-closed task more aware of that task: Release-Engineering-Team (Next).
Tue, Oct 19, 11:34 AM · Release-Engineering-Team (Next), Phabricator
mmodell archived Phabricator (2021-03-24).
Tue, Oct 19, 11:32 AM
mmodell added a comment to T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters.

the link is missing the project phid.. Example the 5 weeks link should look like:

Tue, Oct 19, 11:13 AM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator
mmodell triaged T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters as High priority.
Tue, Oct 19, 11:08 AM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator
mmodell changed the subtype of T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from "Task" to "Bug Report".
Tue, Oct 19, 11:08 AM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator
mmodell moved T291710: "Project report" Age Distribution query links to individual weeks lack project tag and task status parameters from INBOX to Priority Backlog 🔥 on the Release-Engineering-Team board.
Tue, Oct 19, 11:07 AM · Release-Engineering-Team (Done by Thu 04 Nov), Phabricator
mmodell edited projects for T265617: Experiment with GitLab-Phabricator integration, added: Release-Engineering-Team (Next); removed Release-Engineering-Team (Done by Wed 06 Oct).
Tue, Oct 19, 11:04 AM · Release-Engineering-Team (Next), GitLab (Integrations), Phabricator, User-brennen, GitLab-Test
mmodell edited projects for T288381: Connect WikiBugs IRC bot to Wikimedia GitLab, added: Release-Engineering-Team (Next); removed Release-Engineering-Team (Done by Wed 06 Oct).
Tue, Oct 19, 11:04 AM · Release-Engineering-Team (Next), GitLab (Integrations), Patch-For-Review, Wikibugs
mmodell placed T288381: Connect WikiBugs IRC bot to Wikimedia GitLab up for grabs.
Tue, Oct 19, 11:02 AM · Release-Engineering-Team (Next), GitLab (Integrations), Patch-For-Review, Wikibugs

Thu, Oct 14

mmodell updated the task description for T89945: Merge to deployed branches instead of cutting a new deployment branch every week..
Thu, Oct 14, 11:36 PM · RelEng-Archive-FY201718-Q2, Release-Engineering-Team (Long-Lived-Branches), releng-201617-q1, Deployments, Epic

Wed, Oct 13

mmodell added a project to T148805: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards: Release-Engineering-Team (Priority Backlog 🔥).
Wed, Oct 13, 4:57 PM · Release-Engineering-Team (Priority Backlog 🔥), Data³, Phabricator

Fri, Oct 8

mmodell added a comment to T265617: Experiment with GitLab-Phabricator integration.

So one thing I think that we need is the equivalent to the "gerrit patches" table that shows up in phabricator for any gerrit patches tagged with Bug: Tnnn I suppose we could use the exact same convention, we just need a way to query gitlab for matching MRs...

Fri, Oct 8, 6:21 PM · Release-Engineering-Team (Next), GitLab (Integrations), Phabricator, User-brennen, GitLab-Test
mmodell added a comment to T291978: Limit GitLab shared runners to images from Wikimedia Docker registry.

So the containers will be running in a VM environment, no? And we can ensure that they restore to a snapshot or known-good baseline before testing a new patch? If we limit the absolute resource usage of the virtual machine and ensure a clean wipe/reset after each run then I think that root escape would have minimal real impact? Am I missing something?

Fri, Oct 8, 6:15 PM · Release-Engineering-Team (Priority Backlog 🔥), Security-Team, Patch-For-Review, User-brennen, GitLab (CI & Job Runners), Security

Wed, Oct 6

mmodell moved T211904: Set up data storage to collect loosely structured data from CI from Next to Priority Backlog 🔥 on the Release-Engineering-Team board.
Wed, Oct 6, 4:32 PM · Release-Engineering-Team (Priority Backlog 🔥), Elasticsearch, Continuous-Integration-Infrastructure

Tue, Oct 5

mmodell awarded Blog Post: Blog Post Writing Club a Love token.
Tue, Oct 5, 6:06 PM

Wed, Sep 29

mmodell added a comment to T292094: Limit GitLab shared runners to trusted contributors.

If there’s an error or the request times out, the pipeline is accepted.

Wed, Sep 29, 11:34 PM · Release-Engineering-Team (Doing), Security-Team, User-brennen, GitLab (CI & Job Runners)
mmodell added a comment to T263166: Convert static mediawiki configuration to form more suitable for containers.

I plan to submit a more detailed proposal to the Tech Decision Forum shortly.

Wed, Sep 29, 10:49 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s
mmodell added a comment to T292094: Limit GitLab shared runners to trusted contributors.

Mark all new users as "External" and have a process for unchecking the box. In some ways this may be simplest, but don't really like it - it's just a bad user experience, as you can't create new projects even under your own user when marked external, and last I tried this it wasn't at all obvious why.

Wed, Sep 29, 10:37 PM · Release-Engineering-Team (Doing), Security-Team, User-brennen, GitLab (CI & Job Runners)
mmodell added a comment to T212016: Create a repository for sharing ad-hoc local development tools.

This might be a good candidate for early adoption / migration to gitlab?

Wed, Sep 29, 6:26 PM · Developer Productivity
mmodell removed a watcher for Toolhub: mmodell.
Wed, Sep 29, 6:17 PM
mmodell added a comment to T291978: Limit GitLab shared runners to images from Wikimedia Docker registry.

I think that many of the upstream docker images should be fine, for instance, images maintained by trustworthy organizations / open source projects. I don't know if there is a way to allow a list of blessed images / orgs with some kind of allow-list but that would also require extra maintenance work.

Wed, Sep 29, 6:09 PM · Release-Engineering-Team (Priority Backlog 🔥), Security-Team, Patch-For-Review, User-brennen, GitLab (CI & Job Runners), Security
mmodell added a comment to T263166: Convert static mediawiki configuration to form more suitable for containers.

Broadly:

  • SRE-level stuff, like server hostnames should be in etcd for ease of automation
  • releng-level stuff, like which wiki is in which group or which wiki is on which release, which extensions are loaded: probably Git, so it goes through CI and can be diffed and blamed
  • basic wiki configuration tasks, currently by sysadmins or trusted users but really should and can be managed through on-wiki interfaces and stored in MySQL.

I think we should also try to move away from loading all configuration during initialization, and defer stuff that's needed only for specific features or endpoints until it's actually needed.

Wed, Sep 29, 5:55 PM · User-Daniel, Platform Engineering Roadmap, Release-Engineering-Team (Seen), MW-on-K8s

Tue, Sep 28

mmodell awarded Blog Post: How we deploy code a Love token.
Tue, Sep 28, 9:25 AM
mmodell added a comment to T291593: give visibility for "in progress" tasks on a work board.

Will there be a pop-up what these symbols mean when hovering with a mouse? (I'd like to reduce the amount of potential confusion / support questions.)

Tue, Sep 28, 8:18 AM · Phabricator
mmodell closed T291881: Get CI working on ddd repo in gitlab as Resolved.

build is now green: https://gitlab.wikimedia.org/releng/ddd/-/pipelines

Tue, Sep 28, 6:11 AM · Data³

Mon, Sep 27

mmodell added a comment to T291593: give visibility for "in progress" tasks on a work board.

@Jpita: It's not deployed yet.

Mon, Sep 27, 10:52 PM · Phabricator
mmodell updated the task description for T291881: Get CI working on ddd repo in gitlab.
Mon, Sep 27, 7:48 PM · Data³
mmodell moved T291881: Get CI working on ddd repo in gitlab from MVP to Extra credit on the Data³ board.
Mon, Sep 27, 7:45 PM · Data³
mmodell created T291881: Get CI working on ddd repo in gitlab.
Mon, Sep 27, 7:43 PM · Data³

Sat, Sep 25

mmodell placed T258803: Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?) up for grabs.
Sat, Sep 25, 6:24 AM · Phabricator
mmodell lowered the priority of T258803: Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?) from Medium to Low.
Sat, Sep 25, 6:24 AM · Phabricator
mmodell added a comment to T291593: give visibility for "in progress" tasks on a work board.

Screenshot from 2021-09-25 01-13-45.png (552×800 px, 88 KB)

Sat, Sep 25, 6:18 AM · Phabricator
mmodell triaged T291593: give visibility for "in progress" tasks on a work board as Medium priority.
Sat, Sep 25, 6:16 AM · Phabricator

Fri, Sep 24

mmodell changed the status of T148805: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards from Open to In Progress.
Fri, Sep 24, 7:03 PM · Release-Engineering-Team (Priority Backlog 🔥), Data³, Phabricator
mmodell awarded T208257: stop using mod_php anywhere a 100 token.
Fri, Sep 24, 7:02 PM · Patch-For-Review, SRE
mmodell changed the status of T291593: give visibility for "in progress" tasks on a work board, a subtask of T288956: Evaluate adding "In progress" status to Phabricator., from Open to In Progress.
Fri, Sep 24, 6:59 PM · Phabricator
mmodell changed the status of T291593: give visibility for "in progress" tasks on a work board from Open to In Progress.
Fri, Sep 24, 6:59 PM · Phabricator

Thu, Sep 23

mmodell added a subtask for T288956: Evaluate adding "In progress" status to Phabricator.: T291593: give visibility for "in progress" tasks on a work board.
Thu, Sep 23, 9:37 PM · Phabricator
mmodell added a parent task for T291593: give visibility for "in progress" tasks on a work board: T288956: Evaluate adding "In progress" status to Phabricator..
Thu, Sep 23, 9:37 PM · Phabricator
mmodell claimed T291593: give visibility for "in progress" tasks on a work board.
Thu, Sep 23, 9:37 PM · Phabricator

Sep 20 2021

mmodell added a comment to D1196: ReleaseDetailsCustomField: prefill "Unbreak now" train blocker priority.

code change unnecessary: I changed the form configuration, this is now the default: https://phabricator.wikimedia.org/maniphest/task/edit/form/46/

Sep 20 2021, 8:42 PM
mmodell changed the Default Edit Policy policy for application Projects from All Users to Trusted-Contributors (Project).
Sep 20 2021, 8:37 PM
mmodell moved T274228: Phabricator should cache tasks for a few minutes for logged-out users from To Triage to Needs code (in Phab or bot) on the Phabricator board.
Sep 20 2021, 8:30 PM · SRE, Traffic, Phabricator
mmodell added a comment to T266328: Some task notifications include a @mention entry in the X-Phabricator-Stamps mail header for no obvious reason.

I can't make much sense of what that specific event would trigger an @mention but there are other @mentions in the thread, perhaps it's just an off-by-one error?

Sep 20 2021, 8:29 PM · Upstream, Phabricator

Sep 16 2021

mmodell added a comment to T290959: Phabricator failed to generate thumbnails for some 800-900KB files.

Hmm, perhaps it's hitting a memory limit or something? The limit shouldn't be a problem with such a small file though (unless it's doing something incredibly inefficient.)

Sep 16 2021, 2:12 PM · Phabricator

Sep 15 2021

mmodell added a comment to T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.

Deployed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/721312

Sep 15 2021, 7:50 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell closed T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107, a subtask of T281164: 1.37.0-wmf.23 deployment blockers, as Resolved.
Sep 15 2021, 7:50 PM · Release-Engineering-Team (Doing), Release, Train Deployments
mmodell closed T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107 as Resolved.
Sep 15 2021, 7:50 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a comment to T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.

I can attest to seeing a huge spike in errors.

Sep 15 2021, 7:24 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a subtask for T281164: 1.37.0-wmf.23 deployment blockers: T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:13 PM · Release-Engineering-Team (Doing), Release, Train Deployments
mmodell removed a subtask for T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki: T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:13 PM · Structured-Data-Backlog, SDAW-MediaSearch
mmodell edited parent tasks for T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107, added: T281164: 1.37.0-wmf.23 deployment blockers; removed: T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki.
Sep 15 2021, 7:13 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a parent task for T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107: T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki.
Sep 15 2021, 7:13 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell added a subtask for T291097: [testwiki-wmf.23] Disable MediaSearch on testwiki: T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:13 PM · Structured-Data-Backlog, SDAW-MediaSearch
mmodell created T291123: TypeError: Argument 5 passed to MediaWiki\Extension\AbuseFilter\Parser\ParserStatus::__construct() must be of the type integer, null given, called in /srv/mediawiki/php-1.37.0-wmf.23/extensions/AbuseFilter/includes/Parser/ParserStatus.php on line 107.
Sep 15 2021, 7:11 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), AbuseFilter, Wikimedia-production-error
mmodell created T291108: PHP Deprecated: Use of Title::getBacklinkCache was deprecated in MediaWiki 1.37. [Called from DeleteAction::tempConfirmDelete].
Sep 15 2021, 6:17 PM · MW-1.37-release, Platform Engineering, Wikimedia-production-error
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

Maybe we should notify wikitech-l about this? I would tag as user-notice but this isn't for tech news

Sep 15 2021, 5:05 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

I've disabled the herald rule.

Sep 15 2021, 5:05 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

hmmm, well needs triage is the highest possible priority besides unbreak now. Medium is the same as "no prioritization" in my mind, but maybe others think of it differently.

Sep 15 2021, 4:51 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

@DannyS712: sure, I'll write a quick notice to the list.

Sep 15 2021, 4:49 PM · Phabricator
mmodell added a comment to T285232: The restricted/mediawiki-webserver image should include skins and resources.

at the end of the day it seems to me that we only have these symlinks for historical reasons and we don't really want people to use them anymore.

Sep 15 2021, 4:47 PM · Performance-Team (Radar), Patch-For-Review, SRE, serviceops, Release-Engineering-Team (Radar), MW-on-K8s
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

I don't think it makes sense that in-progress tasks would "need triage." therefore I added the above herald rule: If setting a task to in progress without setting the priority, it'll get set to medium priority automatically. Should that be high priority or is that a bad idea to have the herald rule prioritize it?

Sep 15 2021, 4:45 PM · Phabricator
mmodell changed the status of T288956: Evaluate adding "In progress" status to Phabricator. from Open to In Progress.
Sep 15 2021, 4:43 PM · Phabricator
mmodell changed the status of T288956: Evaluate adding "In progress" status to Phabricator. from In Progress to Open.
Sep 15 2021, 4:42 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

Ok ^ you can see what it looks like above.

Sep 15 2021, 4:39 PM · Phabricator
mmodell changed the status of T288956: Evaluate adding "In progress" status to Phabricator. from Open to In Progress.
Sep 15 2021, 4:39 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

Apparently there are no strong opinions about the icon, I'm going to go with step-forward , we can change it if there are objections.

Sep 15 2021, 4:32 PM · Phabricator
mmodell added a comment to T290960: Make it easier to track tasks which are stalled pending a MediaWiki release.

Wouldn't a project 'tag' be appropriate for this?

Sep 15 2021, 4:28 PM · MediaWiki-Releasing (Workflow Improvements), Developer Productivity, Phabricator
mmodell added a comment to T290959: Phabricator failed to generate thumbnails for some 800-900KB files.

Unfortunately I didn't find any useful clues in the logs.

Sep 15 2021, 4:24 PM · Phabricator

Sep 14 2021

mmodell awarded T273020: Security Readiness Review For Toolhub a Love token.
Sep 14 2021, 7:16 PM · user-sbassett, Toolhub, Security, Security Readiness Reviews, secscrum
mmodell added a comment to T281164: 1.37.0-wmf.23 deployment blockers.

@hashar I guess I can take over from here since I'm assigned. Looks like it's clear for deployment...

Sep 14 2021, 7:04 PM · Release-Engineering-Team (Doing), Release, Train Deployments
mmodell claimed T290959: Phabricator failed to generate thumbnails for some 800-900KB files.
Sep 14 2021, 2:56 PM · Phabricator
mmodell added a comment to T290959: Phabricator failed to generate thumbnails for some 800-900KB files.

I've seen a few alerts for the phabricator phd process. It always recovers immediately but there might be something going on with the queue processing. I'll look into it.

Sep 14 2021, 2:55 PM · Phabricator
mmodell raised the priority of T279718: Branch script doesn't respect `branchpoint` when creating submodules, resulting in "implicit merges" error from gerrit from Low to Medium.

That's a good question: @mmodell may have a better memory of ^ than me?

Sep 14 2021, 5:09 AM · Release-Engineering-Team (Seen), MediaWiki-Release-Tools
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

Should we delete it from Puppet then?

Sep 14 2021, 5:04 AM · Phabricator

Sep 13 2021

mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

Oh I hadn't noticed https://gerrit.wikimedia.org/r/720811... That is unfortunately out of date / obsolete. Phabricator gets that setting from the database:

Sep 13 2021, 10:22 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

What icon should we use?

Sep 13 2021, 10:21 PM · Phabricator
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

I imagine we'd want @gerritbot to also state-change tasks into "In Progress" when a Patch-To-Review tag gets added?

Sep 13 2021, 9:48 PM · Phabricator

Sep 3 2021

mmodell closed T281162: 1.37.0-wmf.21 deployment blockers as Resolved.
Sep 3 2021, 3:31 AM · Patch-For-Review, Release-Engineering-Team (Done by Fri 03 Sep), Release, Train Deployments

Sep 2 2021

mmodell added a comment to P17190 reload script for datasette.

For maximum efficiency, replace the xdotool stuff with some applescript to refresh your firefox tab. Or just remove the xdotool commands, but make sure that the refresh function still does exit 0 because that's how it avoids falling into the loop when you run it from the run-on-save plugin.

Sep 2 2021, 9:51 PM
mmodell added a comment to P17190 reload script for datasette.

vs.code settings for use with https://marketplace.visualstudio.com/items?itemName=pucelle.run-on-save

Sep 2 2021, 9:49 PM
mmodell created P17190 reload script for datasette.
Sep 2 2021, 9:46 PM
mmodell created P17189 jsonnet.
Sep 2 2021, 8:08 PM

Sep 1 2021

mmodell removed a subtask for T281162: 1.37.0-wmf.21 deployment blockers: T289697: PHP Notice: Undefined index: tp:tag.
Sep 1 2021, 8:28 PM · Patch-For-Review, Release-Engineering-Team (Done by Fri 03 Sep), Release, Train Deployments
mmodell removed a parent task for T289697: PHP Notice: Undefined index: tp:tag: T281162: 1.37.0-wmf.21 deployment blockers.
Sep 1 2021, 8:28 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Language-Team (Language-2021-July-September), MediaWiki-extensions-Translate, Wikimedia-production-error
mmodell edited Train Status on T281162: 1.37.0-wmf.21 deployment blockers.
Sep 1 2021, 8:27 PM · Patch-For-Review, Release-Engineering-Team (Done by Fri 03 Sep), Release, Train Deployments
mmodell edited Train Status on T281162: 1.37.0-wmf.21 deployment blockers.
Sep 1 2021, 8:27 PM · Patch-For-Review, Release-Engineering-Team (Done by Fri 03 Sep), Release, Train Deployments
mmodell added a comment to T281162: 1.37.0-wmf.21 deployment blockers.

oops, previous updates were accidentally posted to wmf.20's blocker task

Sep 1 2021, 7:58 PM · Patch-For-Review, Release-Engineering-Team (Done by Fri 03 Sep), Release, Train Deployments
mmodell added a comment to T281161: 1.37.0-wmf.20 deployment blockers.

sorry for spamming this task with wmf.21 updates, I had the wrong task id somehow

Sep 1 2021, 7:58 PM · Patch-For-Review, User-brennen, Release-Engineering-Team (Doing), Release, Train Deployments
mmodell added a comment to T288956: Evaluate adding "In progress" status to Phabricator..

There are some benefits to having this as a status, from my perspective.

Sep 1 2021, 7:45 PM · Phabricator
mmodell added a comment to T289697: PHP Notice: Undefined index: tp:tag.

It looks like the fix is merged prior to the branch cut, so if I'm not mistaken, it's in wmf.21 and this isn't a blocker anymore.

Sep 1 2021, 7:39 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Language-Team (Language-2021-July-September), MediaWiki-extensions-Translate, Wikimedia-production-error
mmodell added a comment to T289697: PHP Notice: Undefined index: tp:tag.

Should I be concerned about this causing further problems after rolling out wmf.21?

Sep 1 2021, 7:37 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Language-Team (Language-2021-July-September), MediaWiki-extensions-Translate, Wikimedia-production-error
mmodell removed a subtask for T281162: 1.37.0-wmf.21 deployment blockers: T289806: PHP Notice: Undefined offset: 5.
Sep 1 2021, 7:36 PM · Patch-For-Review, Release-Engineering-Team (Done by Fri 03 Sep), Release, Train Deployments