Page MenuHomePhabricator

mmodell (Mukunda Modell)
Release Engineer, Phabricator AdminAdministrator

Projects (35)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 9:45 AM (318 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
twentyafterfour
LDAP User
20after4
MediaWiki User
MModell (WMF) [ Global Accounts ]

I am a Software Engineer on the Wikimedia Release-Engineering-Team.

What I do

Deployments

A big part of my work involves release automation and tooling. This includes Scap, Deployments, MediaWiki-Release-Tools and Train Deployments.

Phabricator

I am also responsible for Phabricator maintenance, improvements and occasional software deployments. I'm constantly working to improve phabricator through my contributions to Wikimedia-Phabricator-Extensions (rPHEX phabricator-extensions) and Phabricator (Upstream).

Elsewhere on the web:

github/20after4
Stack Overflow/20after4

Disclaimer: I work for the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.`

Recent Activity

Wed, Oct 21

mmodell added a comment to T253673: Avoid php-opcache corruption in WMF production.

My idea is to tag shared memory with a pkey. Then when entering or exiting a section of the code that writes to shared memory, only a single instruction (WRPKRU) needs to be executed to change the permissions on all of shared memory.

The goal is to convert shared memory corruption into segfaults, which are less damaging in production. Segfaults can produce core dumps, potentially giving a lead as to the root cause of the memory corruption.

Wed, Oct 21, 4:55 PM · User-jijiki, Patch-For-Review, Sustainability (Incident Followup), Performance-Team, serviceops

Fri, Oct 16

mmodell created P13014 addTicketToColumn.
Fri, Oct 16, 8:12 PM

Thu, Oct 15

mmodell closed T255703: Enhance phabricator project metrics and reporting as Resolved.

This is now deployed.

Thu, Oct 15, 9:30 AM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Phabricator, Developer Productivity
mmodell committed rPHDEP7dea3f4884e4: Update submodules (authored by mmodell).
Update submodules
Thu, Oct 15, 12:15 AM

Wed, Oct 14

mmodell added a comment to T265490: rate limited etherpad.

Phabricator's websockets have also recently stopped working. May be related?

Wed, Oct 14, 5:57 PM · Patch-For-Review, Operations, Wikimedia-Etherpad
mmodell moved T260079: train-dev: Include sample security patches in deploy VM from INBOX to New Work on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 14, 5:34 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), MediaWiki Train Development Environment
mmodell moved T211904: Set up data storage to collect loosely structured data from CI from INBOX to New Work on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 14, 5:34 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release-Engineering-Team (CI & Testing services), Elasticsearch, Continuous-Integration-Infrastructure
mmodell moved T244544: Add a quick rollback command to scap that skips all unnecessary steps from INBOX to Maintenance on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.
Wed, Oct 14, 5:34 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Sustainability (Incident Followup), User-brennen, Scap
mmodell edited projects for T211904: Set up data storage to collect loosely structured data from CI, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Wed, Oct 14, 5:21 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release-Engineering-Team (CI & Testing services), Elasticsearch, Continuous-Integration-Infrastructure
mmodell edited projects for T244544: Add a quick rollback command to scap that skips all unnecessary steps, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO.
Wed, Oct 14, 5:08 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Sustainability (Incident Followup), User-brennen, Scap

Tue, Oct 13

mmodell added a comment to T264667: Define distributed RPC/Request TRACING strategy and tooling recommendation.

This looks interesting, though it's geared towards a microservice architecture. It might be worth looking at anyway: https://www.jaegertracing.io/

Tue, Oct 13, 6:46 PM · observability
mmodell awarded T253673: Avoid php-opcache corruption in WMF production a Love token.
Tue, Oct 13, 3:59 PM · User-jijiki, Patch-For-Review, Sustainability (Incident Followup), Performance-Team, serviceops
mmodell awarded T248490: Move scap plugins from mediawiki-config repo to scap repo a Love token.
Tue, Oct 13, 3:56 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap
mmodell added a comment to T237706: Deploying "Phatality" plugin for Kibana invokes oom-killer on logstash::collector nodes.

@fgiunchedi it's unlikely that it will work in kibana 7 without significant changes. Kibana's been in the process of totally refactoring their code and switching from angularJS to react. I think I can port the phatality code to kibana 7 fairly easily but I haven't started working on that yet.

Tue, Oct 13, 3:55 PM · Developer Productivity, Phatality, Operations, observability
mmodell awarded T264667: Define distributed RPC/Request TRACING strategy and tooling recommendation a Love token.
Tue, Oct 13, 3:46 PM · observability

Thu, Oct 1

mmodell added a comment to T264363: Instances of User are not serializable!.

yeah I don't know what's going on. it must be the parser output that has a user in it somehow?

Thu, Oct 1, 9:03 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
mmodell added a comment to T264363: Instances of User are not serializable!.

https://gerrit.wikimedia.org/g/mediawiki/core/+/e7ff3cbb6b4db6f4db55746422d64d4205720f79/includes/Storage/PageEditStash.php#160

Thu, Oct 1, 9:00 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
mmodell added a comment to T264363: Instances of User are not serializable!.

There doesn't appear to be a user object being serialized though?

// Store what is actually needed and split the output into another key (T204742)
$stashInfo = (object)[
	'pstContent' => $pstContent,
	'output'     => $parserOutput,
	'timestamp'  => $timestamp,
	'edits'      => $user->getEditCount()
];
$ok = $this->cache->set( $key, $stashInfo, $ttl, BagOStuff::WRITE_ALLOW_SEGMENTS );
Thu, Oct 1, 8:57 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
mmodell added a comment to T264363: Instances of User are not serializable!.

Apparently caused by rMWdc436c3cff5f: Introduce and apply NonSerializableTrait

Thu, Oct 1, 8:56 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
mmodell added a project to T264363: Instances of User are not serializable!: MediaWiki-Cache.
Thu, Oct 1, 8:50 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
mmodell created T264363: Instances of User are not serializable!.
Thu, Oct 1, 8:50 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
mmodell added a comment to T264257: Fix ParserOutput corruption wmf.10 -> wmf.11.

@Pchelolo: Should we close this or leave it open? (not sure if there is remaining work besides merging the aforementioned patches?)

Thu, Oct 1, 7:29 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Wikimedia-Incident, MediaWiki-Parser, Platform Engineering, Wikimedia-production-error
mmodell removed a subtask for T263177: 1.36.0-wmf.11 deployment blockers: Unknown Object (Task).
Thu, Oct 1, 7:26 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell closed T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given, a subtask of T263177: 1.36.0-wmf.11 deployment blockers, as Invalid.
Thu, Oct 1, 7:00 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell closed T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given as Invalid.
Thu, Oct 1, 7:00 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error, Wikidata
mmodell added a comment to T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given.

IT was showing up a bunch but I think it was probably opcache corruption.

Thu, Oct 1, 7:00 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error, Wikidata
mmodell added a comment to T264257: Fix ParserOutput corruption wmf.10 -> wmf.11.

I too am pretty uncertain about wmf.11, there were actually multiple issues that cropped up yesterday and it was hard to tell which ones were real because we had a lot of nonsensical / seemingly impossible errors that were caused by opcode cache corruption. The corruption errors were obscuring the other issues for a while.

Thu, Oct 1, 3:18 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Wikimedia-Incident, MediaWiki-Parser, Platform Engineering, Wikimedia-production-error
mmodell updated subscribers of T264257: Fix ParserOutput corruption wmf.10 -> wmf.11.

wmf.11 is completely rolled back, hopefully it can roll out tomorrow but I'm not too confident. If @hashar wants to try it during EU window that's up to him ;)

Thu, Oct 1, 4:06 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Patch-For-Review, Wikimedia-Incident, MediaWiki-Parser, Platform Engineering, Wikimedia-production-error

Wed, Sep 30

mmodell created P12864 servers with possible opcache corruption.
Wed, Sep 30, 10:04 PM
mmodell added a comment to T264241: Class 'LathMathML' not found.

It does seem like something was massively wrong because the number of crazy and unrelated errors were off the chart, and the error rate didn't return to normal until I rolled back even group0 to wmf.10

Wed, Sep 30, 9:29 PM · serviceops, Math, Wikimedia-production-error
mmodell added a comment to T263177: 1.36.0-wmf.11 deployment blockers.

Train rolled all the way back and completely undeployed wmf.11 because of the massive number of errors that were occurring even after rolling back group1.

Wed, Sep 30, 9:25 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell triaged T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given as Unbreak Now! priority.
Wed, Sep 30, 9:10 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error, Wikidata
mmodell triaged T264241: Class 'LathMathML' not found as Unbreak Now! priority.
Wed, Sep 30, 9:09 PM · serviceops, Math, Wikimedia-production-error
mmodell added a subtask for T263177: 1.36.0-wmf.11 deployment blockers: T264241: Class 'LathMathML' not found.
Wed, Sep 30, 9:09 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell added a parent task for T264241: Class 'LathMathML' not found: T263177: 1.36.0-wmf.11 deployment blockers.
Wed, Sep 30, 9:09 PM · serviceops, Math, Wikimedia-production-error
mmodell added a subtask for T263177: 1.36.0-wmf.11 deployment blockers: T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given.
Wed, Sep 30, 9:09 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell added a parent task for T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given: T263177: 1.36.0-wmf.11 deployment blockers.
Wed, Sep 30, 9:09 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error, Wikidata
mmodell created T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, instance of Wikibase\Repo\Content\EntityContentFactory given.
Wed, Sep 30, 9:08 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error, Wikidata
mmodell created T264241: Class 'LathMathML' not found.
Wed, Sep 30, 9:02 PM · serviceops, Math, Wikimedia-production-error
mmodell added a comment to T248490: Move scap plugins from mediawiki-config repo to scap repo.

missing on deploy1001 .. did the new version actually get rolled out to all of production?

Wed, Sep 30, 7:28 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap
mmodell added a comment to T248490: Move scap plugins from mediawiki-config repo to scap repo.

rOMWC658f28991a78 broke deployments. scap update-wikiversions was removed and apparently it's not in scap core.

Wed, Sep 30, 7:12 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Wikimedia-Site-requests, Scap
mmodell set Source Repo to https://phabricator.wikimedia.org/source/mediawiki-config/ on MediaWiki-Configuration.
Wed, Sep 30, 7:06 PM
mmodell edited projects for T260079: train-dev: Include sample security patches in deploy VM, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Wed, Sep 30, 5:11 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), MediaWiki Train Development Environment
mmodell removed a project from T258803: Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?): Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).
Wed, Sep 30, 5:10 PM · Phabricator
mmodell added a comment to T263177: 1.36.0-wmf.11 deployment blockers.

@Lucas_Werkmeister_WMDE interesting. I was kinda confused about that as well but I didn't want to take any risks. I'll go ahead and roll forward to group0 and we'll see where things stand then.

Wed, Sep 30, 4:19 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell added a comment to T255703: Enhance phabricator project metrics and reporting.

Uh, nice. Thanks!

Under Age of open tasks, if that blue bar with the number was turned into link, then the link could have the format https://phabricator.wikimedia.org/maniphest/?ids=1,2,3,4#R as the number of tickets could be more than one.

Wed, Sep 30, 4:13 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Phabricator, Developer Productivity

Tue, Sep 29

mmodell added a subtask for T263177: 1.36.0-wmf.11 deployment blockers: Unknown Object (Task).
Tue, Sep 29, 9:49 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell added a comment to T263177: 1.36.0-wmf.11 deployment blockers.

The train is now blocked but there is no task for https://gerrit.wikimedia.org/r/630797 so I can't add anything as a blocker.... :-/

Tue, Sep 29, 9:45 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell added a comment to T263177: 1.36.0-wmf.11 deployment blockers.

@Lucas_Werkmeister_WMDE: I'm rolling back because the revert has a merge conflict. I'm not sure what to do about it so I'll leave it to you to resolve.

Tue, Sep 29, 9:43 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell added a comment to T263177: 1.36.0-wmf.11 deployment blockers.

@Lucas_Werkmeister_WMDE it seems that after this change, this url[1] indeed becomes uncacheable.

Tue, Sep 29, 9:19 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
mmodell committed rPHEX17d69519febb: Fix init script so that rollback cli works (authored by mmodell).
Fix init script so that rollback cli works
Tue, Sep 29, 12:34 AM

Mon, Sep 28

mmodell closed T261493: Introduce new task statuses in Phabricator., a subtask of T148805: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards, as Declined.
Mon, Sep 28, 5:05 PM · Phabricator
mmodell closed T261493: Introduce new task statuses in Phabricator. as Declined.
Mon, Sep 28, 5:05 PM · Developer Productivity, Phabricator
mmodell added a comment to T255703: Enhance phabricator project metrics and reporting.

I've added a list of overdue tasks to the metrics on the report. Here is a screenshot of the latest:

  • Mon, Sep 28, 3:21 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Phabricator, Developer Productivity
    mmodell updated images of M308: Phabricator Project Metrics.
    Mon, Sep 28, 3:18 PM · Release-Engineering-Team-TODO, Phabricator

    Sep 25 2020

    mmodell claimed T260079: train-dev: Include sample security patches in deploy VM.
    Sep 25 2020, 2:21 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), MediaWiki Train Development Environment
    mmodell added a comment to T263177: 1.36.0-wmf.11 deployment blockers.

    Thank you @Lucas_Werkmeister_WMDE for the risky patch details! This will be very helpful and it is very much appreciated!

    Sep 25 2020, 1:07 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments

    Sep 24 2020

    mmodell added a member for Trusted-Contributors: lmata.
    Sep 24 2020, 5:05 PM
    mmodell added a comment to T706: Requests for addition to the #acl*Project-Admins group (in comments).

    I guess I should be repeating @Aklapper's disclaimer: Please follow guidelines (naming, project description, project type), and if unsure please ask - thanks!

    Sep 24 2020, 5:05 PM · Project-Admins

    Sep 23 2020

    mmodell added a comment to T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds.

    So the code in question appears to be ok, I think something changed in the code it's calling so the assumption that pageId would be valid is no longer valid.

    Sep 23 2020, 3:32 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), GlobalUsage, Release-Engineering-Team (Logspam), Wikimedia-production-error
    mmodell added a comment to T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds.

    and yet the code in question hasn't been touched since 2009:

    Sep 23 2020, 1:00 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), GlobalUsage, Release-Engineering-Team (Logspam), Wikimedia-production-error
    mmodell added a comment to T263463: Update the DBA task tracking workflow.

    @mmodell : "The field will show on any task that has a value for the field." - so it only applies if the field value was set at creation time (presumably via a form)?

    Sep 23 2020, 12:59 PM · Data-Persistence-Admin, Data-Persistence, PM
    mmodell changed Source Repo from /diffusion/EGUS/ to https://phabricator.wikimedia.org/diffusion/EGUS/ on GlobalUsage.
    Sep 23 2020, 12:42 PM
    mmodell set Source Repo to /diffusion/EGUS/ on GlobalUsage.
    Sep 23 2020, 12:42 PM
    mmodell added a comment to T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds.

    added as blocker even though this isn't new. It's currently the highest frequency logspam in kibana.

    Sep 23 2020, 12:38 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), GlobalUsage, Release-Engineering-Team (Logspam), Wikimedia-production-error
    mmodell added a subtask for T257978: 1.36.0-wmf.10 deployment blockers: T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds.
    Sep 23 2020, 12:37 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
    mmodell added a parent task for T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds: T257978: 1.36.0-wmf.10 deployment blockers.
    Sep 23 2020, 12:37 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), GlobalUsage, Release-Engineering-Team (Logspam), Wikimedia-production-error
    mmodell added a comment to T237467: Invariant failed: Bad UTF-8 (full string verification).

    @Urbanecm I apologize, I meant to deploy that last night.

    Sep 23 2020, 12:30 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-notice, Parsing-Active-Work, WMDE-QWERTY-Sprint-2020-08-26, Patch-For-Review, Wikimedia-production-error, User-brennen, Parsoid

    Sep 22 2020

    mmodell added a subtask for T257978: 1.36.0-wmf.10 deployment blockers: T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].
    Sep 22 2020, 9:02 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release, Train Deployments
    mmodell added a parent task for T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum]: T257978: 1.36.0-wmf.10 deployment blockers.
    Sep 22 2020, 9:02 PM · MW-1.35-notes, MW-1.31-release-notes, MediaWiki-extensions-PdfHandler, Commons, MediaWiki-File-management, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MediaWiki-extensions-Scribunto, MediaWiki-Parser, MediaWiki-General, Patch-For-Review
    mmodell created T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].
    Sep 22 2020, 8:59 PM · MW-1.35-notes, MW-1.31-release-notes, MediaWiki-extensions-PdfHandler, Commons, MediaWiki-File-management, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MediaWiki-extensions-Scribunto, MediaWiki-Parser, MediaWiki-General, Patch-For-Review
    mmodell added a comment to T263463: Update the DBA task tracking workflow.

    @mmodell: Any thoughts (as my knowledge about Forms is rather limited)?

    Sep 22 2020, 6:49 PM · Data-Persistence-Admin, Data-Persistence, PM
    Aklapper awarded T255703: Enhance phabricator project metrics and reporting a Like token.
    Sep 22 2020, 5:29 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Phabricator, Developer Productivity

    Sep 21 2020

    mmodell added a comment to T255703: Enhance phabricator project metrics and reporting.

    @EBjune @Naike @thcipriani
    I've deployed a preview version of this code to phab.wmflabs.org

    Sep 21 2020, 9:16 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Phabricator, Developer Productivity
    mmodell added a comment to M308: Phabricator Project Metrics.

    This is now deployed to https://phab.wmflabs.org/project/reports/5/

    Sep 21 2020, 9:16 PM · Release-Engineering-Team-TODO, Phabricator

    Sep 18 2020

    mmodell updated subscribers of T263063: Phabricator global search: "Cannot use object of type PhutilSafeHTML as array" error for certain strings.

    @brennen see above for wtf php lol

    Sep 18 2020, 3:58 PM · Phabricator (Search)
    mmodell awarded T263166: Convert static mediawiki configuration to form more suitable for containers a Like token.
    Sep 18 2020, 3:58 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), MW-on-K8s, Release-Engineering-Team (Pipeline)
    mmodell added a comment to T261619: Unhandled Exception trying to access Phabricator's "Sprint" application.

    It's obsolete afaik. I think it can be removed without much consequence.

    Sep 18 2020, 3:55 PM · Phabricator
    mmodell added a comment to T263063: Phabricator global search: "Cannot use object of type PhutilSafeHTML as array" error for certain strings.

    Ok this one has got to be one of the biggest WATPHP bugs I've ever had to deal with.

    Sep 18 2020, 9:38 AM · Phabricator (Search)

    Sep 17 2020

    mmodell added a comment to T263063: Phabricator global search: "Cannot use object of type PhutilSafeHTML as array" error for certain strings.

    I think it must be some procurement task that you all can see but I can't.

    Sep 17 2020, 10:25 PM · Phabricator (Search)
    mmodell added a comment to T263063: Phabricator global search: "Cannot use object of type PhutilSafeHTML as array" error for certain strings.

    They all work for me.

    Sep 17 2020, 10:16 PM · Phabricator (Search)

    Sep 16 2020

    mmodell moved T211904: Set up data storage to collect loosely structured data from CI from INBOX to New Work on the Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)) board.
    Sep 16 2020, 5:48 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release-Engineering-Team (CI & Testing services), Elasticsearch, Continuous-Integration-Infrastructure
    mmodell claimed T211904: Set up data storage to collect loosely structured data from CI.
    Sep 16 2020, 5:47 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release-Engineering-Team (CI & Testing services), Elasticsearch, Continuous-Integration-Infrastructure

    Sep 14 2020

    mmodell added a member for Trusted-Contributors: Akuckartz.
    Sep 14 2020, 8:07 PM
    mmodell added a member for Trusted-Contributors: Nadzik.
    Sep 14 2020, 8:04 PM
    mmodell added a member for Trusted-Contributors: CptViraj.
    Sep 14 2020, 7:58 PM
    mmodell added a member for Trusted-Contributors: Risker.
    Sep 14 2020, 7:57 PM

    Sep 10 2020

    mmodell added a comment to T261029: Decide on UI framework(s) to start the project with.

    +1, I agree with @Mooeypoo regarding the advantages of sticking with the same thing that other foundation projects will be using.

    Sep 10 2020, 1:47 PM · Toolhub
    mmodell edited projects for T245089: Restore highlighting of target comment in Phabricator, added: Phabricator (2020-09-10); removed Phabricator (Upstream).
    Sep 10 2020, 1:40 PM · Phabricator (2020-09-10), Upstream
    mmodell awarded T245089: Restore highlighting of target comment in Phabricator a Orange Medal token.
    Sep 10 2020, 1:40 PM · Phabricator (2020-09-10), Upstream
    mmodell committed rPHDEP6f105e1d1e7f: Updated submodules (authored by mmodell).
    Updated submodules
    Sep 10 2020, 12:12 AM
    mmodell created Phabricator (next).
    Sep 10 2020, 12:08 AM
    mmodell renamed Phabricator (2020-09-10) from next to 2020-09-10.
    Sep 10 2020, 12:07 AM
    mmodell committed rPHTR2bffb231adff: updated translations (authored by mmodell).
    updated translations
    Sep 10 2020, 12:00 AM
    mmodell committed rPHTR6f905a0de8f8: libphutil is no more. (authored by mmodell).
    libphutil is no more.
    Sep 10 2020, 12:00 AM

    Sep 5 2020

    mmodell closed T261442: Editing a Project description shows "No Edit Forms: You do not have access to any forms which are enabled and marked as edit forms" as Resolved.

    I've also added @Iniquity to Trusted-Contributors

    Sep 5 2020, 6:13 AM · Phabricator
    mmodell added a member for Trusted-Contributors: Iniquity.
    Sep 5 2020, 6:10 AM
    mmodell added a comment to T261442: Editing a Project description shows "No Edit Forms: You do not have access to any forms which are enabled and marked as edit forms".

    @Jack_who_built_the_house yes, I have added you to Trusted-Contributors

    Sep 5 2020, 6:09 AM · Phabricator
    mmodell added a member for Trusted-Contributors: Jack_who_built_the_house.
    Sep 5 2020, 6:09 AM

    Sep 3 2020

    mmodell added a comment to T256995: Production Error task subtype symbol appearing on tasks, indicating something urgent, but is non-interactive.

    @Krinkle: Apparently there isn't a way to turn it off with config, I'll have to patch the code. I think it could be useful with some subtypes but it sucks that it shows on every subtype. I think I agree that it's not useful for this particular case.

    Sep 3 2020, 5:24 PM · Accessibility, Phabricator