Page MenuHomePhabricator

mmodell (Mukunda Modell)
Release Engineer, Phabricator AdminAdministrator

Projects (33)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 9:45 AM (251 w, 6 d)
Roles
Administrator
Availability
Available
IRC Nick
twentyafterfour
LDAP User
20after4
MediaWiki User
MModell (WMF) [ Global Accounts ]

I am a Software Engineer on the Wikimedia Release-Engineering-Team.


Current projects: Wikimedia-Phabricator-Extensions, Developer Productivity, Release Pipeline

Besides working on Deployments, I am responsible for Phabricator maintenance & operations. I also help out with other phabricator-related tasks as a member of Project-Admins and Repository-Admins.

Disclaimer: I work for the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.`

Recent Activity

Today

mmodell added a comment to T227132: issues with artifact cache in an-coord1001.

Does this scap config take effect in the source as well as the target of the deploy?

Thu, Jul 18, 4:30 PM · Release-Engineering-Team (Deployment services), Analytics-Kanban, Analytics
mmodell added a comment to T227132: issues with artifact cache in an-coord1001.

Can the release engineering chime as to whether scap config settings should also delete artifacts from the target of the deploy?

Thu, Jul 18, 4:24 PM · Release-Engineering-Team (Deployment services), Analytics-Kanban, Analytics

Yesterday

mmodell added a project to T220670: Set "auth.lock-config" to true: Patch-For-Review.

https://gerrit.wikimedia.org/r/c/operations/puppet/+/524026

Wed, Jul 17, 9:02 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Phabricator

Tue, Jul 16

mmodell moved T171940: Create an easier way to manage SWAT deploys on (Deployments calendar) from Later / Need volunteer to Soon-ish on the Release-Engineering-Team-TODO board.
Tue, Jul 16, 2:59 PM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO, wikitech.wikimedia.org, Deployments, User-MModell
mmodell created T228169: Index gerrit hashtags.
Tue, Jul 16, 2:20 PM · wikimedia.biterg.io

Mon, Jul 15

mmodell awarded T140921: Static asset time on disk a Love token.
Mon, Jul 15, 10:41 PM · Performance-Team (Radar), Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Deployment services), Deployments
mmodell moved T185155: Improve error reporting / integration between Kibana and Phabricator from INBOX to Doing on the Release-Engineering-Team-TODO (201907) board.
Mon, Jul 15, 4:13 PM · Release-Engineering-Team-TODO (201907), Wikimedia-Logstash, Phabricator
mmodell added a project to T185155: Improve error reporting / integration between Kibana and Phabricator: Release-Engineering-Team-TODO (201907).
Mon, Jul 15, 4:13 PM · Release-Engineering-Team-TODO (201907), Wikimedia-Logstash, Phabricator
mmodell updated subscribers of T227267: Permission to edit Forms No. 31, 32 and 33 for MarcoAurelio.

So it seems that it's not possible to override the policy on form editing. @epriestley: shouldn't this use the application "can edit / can configure application" policy for the transactions application? It doesn't seem to actually work that way although it looks like it should from reading the code.

Mon, Jul 15, 3:51 PM · Phabricator

Thu, Jul 11

mmodell added a comment to T227267: Permission to edit Forms No. 31, 32 and 33 for MarcoAurelio.

@MarcoAurelio Can you edit those forms now?

Thu, Jul 11, 7:58 PM · Phabricator
mmodell added a member for acl*phabricator: MarcoAurelio.
Thu, Jul 11, 7:58 PM
mmodell added a comment to T227267: Permission to edit Forms No. 31, 32 and 33 for MarcoAurelio.

@MarcoAurelio I'll see what I can do to make this work.

Thu, Jul 11, 7:54 PM · Phabricator
mmodell added a comment to T218450: Exception when accessing to a Phabricator mock: "Attempting to add more metadata after metadata has been locked.".
25phabricatorinfrastructure/javelin/markup.php : 22CelerityStaticResourceResponse::addMetadata()
24phabricatorview/AphrontTagView.php : 161javelin_tag()
23phabricatorinfrastructure/markup/rule/PhabricatorObjectRemarkupRule.php : 177AphrontTagView::render()
22phabricatorinfrastructure/markup/rule/PhabricatorObjectRemarkupRule.php : 108PhabricatorObjectRemarkupRule::renderHovertag()
21phabricatorinfrastructure/markup/rule/PhabricatorObjectRemarkupRule.php : 84PhabricatorObjectRemarkupRule::renderObjectRef()
20phabricatorinfrastructure/markup/rule/PhabricatorObjectRemarkupRule.php : 389PhabricatorObjectRemarkupRule::renderObjectRefForAnyMedia()
19phutilmarkup/engine/PhutilRemarkupEngine.php : 293PhabricatorObjectRemarkupRule::didMarkupText()
18phabricatorinfrastructure/markup/PhabricatorMarkupEngine.php : 144PhutilRemarkupEngine::postprocessText()
17phabricatorinfrastructure/markup/PhabricatorMarkupEngine.php : 73PhabricatorMarkupEngine::process()
16phabricatorinfrastructure/markup/view/PHUIRemarkupView.php : 90PhabricatorMarkupEngine::renderOneObject()
15phabricatorview/AphrontView.php : 222PHUIRemarkupView::render()
14phutilmarkup/render.php : 111AphrontView::producePhutilSafeHTML()
13(Internal)phutil_escape_html()
12phutilmarkup/render.php : 181array_map()
11phabricatoraphront/response/AphrontResponse.php : 317hsprintf()
10(Internal)AphrontResponse::processValueForJSONEncoding()
9phabricatoraphront/response/AphrontResponse.php : 333array_walk_recursive()
8phabricatorapplications/celerity/CelerityStaticResourceResponse.php : 279AphrontResponse::encodeJSONForHTTPResponse()
7phabricatorview/page/PhabricatorStandardPageView.php : 583CelerityStaticResourceResponse::renderHTMLFooter()
6phabricatorview/page/AphrontPageView.php : 51PhabricatorStandardPageView::getTail()
5phabricatorview/page/PhabricatorStandardPageView.php : 889AphrontPageView::render()
4phabricatoraphront/configuration/AphrontApplicationConfiguration.php : 715PhabricatorStandardPageView::produceAphrontResponse()
3phabricatoraphront/configuration/AphrontApplicationConfiguration.php : 301AphrontApplicationConfiguration::produceResponse()
2phabricatoraphront/configuration/AphrontApplicationConfiguration.php : 209AphrontApplicationConfiguration::processRequest()
1/srv/deployment/phabricator/deployment-cache/revs/61f10999d8837a8c9dbeea12f67b2554daf057ab/phabricator/webroot/index.php : 35AphrontApplicationConfiguration::runHTTPRequest()
Thu, Jul 11, 6:56 PM · Phabricator (Upstream), Upstream

Wed, Jul 10

mmodell closed T227519: "Unhandled Exception: Call to undefined method PhutilDOMNode::setRawContent() when trying to access several tasks as Resolved.

The upstream fix has been applied to production.

Wed, Jul 10, 5:58 PM · Regression, Upstream, Phabricator (Upstream)
mmodell committed rPHUTIL1ce011bc6568: Merge remote-tracking branch 'upstream/stable' into wmf/stable (authored by mmodell).
Merge remote-tracking branch 'upstream/stable' into wmf/stable
Wed, Jul 10, 5:52 PM

Tue, Jul 9

mmodell closed T227247: All Burnup Rate charts (burndown) are 404 (due to uninstalled "Facts" application) as Resolved.

The charts are now based on the 'facts' application and the application was uninstalled on our phabricator. I "installed" the facts application and now this works as it should. Note it's still a very early prototype so it may be buggy.

Tue, Jul 9, 9:13 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Regression, Phabricator

Mon, Jul 8

mmodell closed T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003) as Resolved.
Mon, Jul 8, 4:33 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell added a hashtag to MediaWiki-API: #mediawiki-api.
Mon, Jul 8, 4:31 PM
mmodell closed T222870: Specific existing project tag not found by Phabricator's project search as Resolved.

fixed by editing the project hashtags

Mon, Jul 8, 4:29 PM · Phabricator
mmodell added hashtags to Community-Wishlist-Survey-2016: #community-wishlist-survey-2016, #2016_community_wishlist_survey.
Mon, Jul 8, 4:28 PM
mmodell closed T158434: Phabricator: Make sure phabricator works properly including our puppet roles on jessie as Resolved.
Mon, Jul 8, 4:22 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, Operations, Phabricator
mmodell added a comment to T78196: In Phabricator forms, text fields made visible by an option should become focused when they appear.

This is something we can consider implementing in our fork and maintaining downstream if there is enough interest. I am of the opinion that it'd be helpful. Another option might be to do it with a browser extension or userscript.

Mon, Jul 8, 3:09 PM · Upstream, Phabricator (Upstream)

Thu, Jul 4

mmodell triaged T227251: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts as High priority.
Thu, Jul 4, 2:59 PM · Operations, Phabricator
mmodell added a comment to T227251: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts.

Now the graphs look better. Unfortunately, puppet will set the config back to 10 taskmasters unless we make a commit to rOPUP Wikimedia Puppet

Thu, Jul 4, 2:54 PM · Operations, Phabricator
mmodell added a comment to T227251: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts.

@Marostegui ok I found a way to slow down the queue: I lowered phd.taskmasters to 1

Thu, Jul 4, 2:53 PM · Operations, Phabricator
mmodell added a comment to T227251: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts.

I could cancel the rest of the search jobs, I think that would still produce quite a bit of database activity but maybe less than all the queue status updates needed to execute the jobs. This would result in the search index missing some data though.

Thu, Jul 4, 2:49 PM · Operations, Phabricator
mmodell awarded T201480: Toggle buttons in Phabricator don't work on mobile (affects: Login, Search) a Love token.
Thu, Jul 4, 2:43 PM · Phabricator (2019-07-03), Upstream, Mobile
mmodell added a comment to T227251: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts.

@Marostegui: The phabricator work queue is almost empty now, see https://phabricator.wikimedia.org/daemon/ (There were well over 1 million jobs, now down to just over 300,000 and those are search jobs which should not have significant insert / update load on mysql. Rather, those jobs will be doing a lot of mysql read queries and inserting a lot of documents into elasticsearch.

Thu, Jul 4, 2:36 PM · Operations, Phabricator
mmodell added a comment to T227251: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts.

I'm cleaning up the worker queue to lighten the load. It should subside soon.

Thu, Jul 4, 5:53 AM · Operations, Phabricator
mmodell added a subtask for T70820: Automatically log fatals/exceptions into Phabricator with stack traces: T185155: Improve error reporting / integration between Kibana and Phabricator.
Thu, Jul 4, 12:15 AM · Wikimedia-Logstash
mmodell added a parent task for T185155: Improve error reporting / integration between Kibana and Phabricator: T70820: Automatically log fatals/exceptions into Phabricator with stack traces.
Thu, Jul 4, 12:15 AM · Release-Engineering-Team-TODO (201907), Wikimedia-Logstash, Phabricator

Wed, Jul 3

mmodell committed rPHDEP0f57ac5ec71a: Updated submodules (authored by mmodell).
Updated submodules
Wed, Jul 3, 11:35 PM
mmodell committed rPHDEPf8785d64c6cd: submodule updates (authored by mmodell).
submodule updates
Wed, Jul 3, 11:35 PM
mmodell committed rPHEXfa50d1a5eaa7: Don't call setType - removed upstream. (authored by mmodell).
Don't call setType - removed upstream.
Wed, Jul 3, 11:35 PM
mmodell committed rPHTRa039e115598f: Generated translation classes (authored by mmodell).
Generated translation classes
Wed, Jul 3, 11:34 PM
mmodell created Phabricator (2019-07-03).
Wed, Jul 3, 11:33 PM
mmodell committed rPHUTILc2d604923187: Merge remote-tracking branch 'upstream/stable' into wmf/stable (authored by mmodell).
Merge remote-tracking branch 'upstream/stable' into wmf/stable
Wed, Jul 3, 11:28 PM
mmodell committed rPHUTIL44cf12ab116f: Merge remote-tracking branch 'upstream/stable' into wmf/stable (authored by mmodell).
Merge remote-tracking branch 'upstream/stable' into wmf/stable
Wed, Jul 3, 11:28 PM
mmodell committed rPHUTIL9bf413d023e8: Merge remote-tracking branch 'upstream/stable' into wmf/stable (authored by mmodell).
Merge remote-tracking branch 'upstream/stable' into wmf/stable
Wed, Jul 3, 11:28 PM
mmodell added a member for WMF-NDA: WDoranWMF.
Wed, Jul 3, 7:14 PM
mmodell added a member for Trusted-Contributors: WDoranWMF.
Wed, Jul 3, 7:14 PM

Mon, Jul 1

mmodell updated the task description for T185155: Improve error reporting / integration between Kibana and Phabricator.
Mon, Jul 1, 4:03 PM · Release-Engineering-Team-TODO (201907), Wikimedia-Logstash, Phabricator
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

@MoritzMuehlenhoff: cool! FWIW the new package seems to have fixed the problem and I haven't noticed any other bugs with it.

Mon, Jul 1, 3:04 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell removed a member for acl*research_collaborations_policy_admins: bmansurov.
Mon, Jul 1, 7:19 AM
mmodell changed the edit policy for acl*procurement-review.
Mon, Jul 1, 7:19 AM
mmodell changed the edit policy for acl*research_collaborations_policy_admins.
Mon, Jul 1, 7:18 AM

Fri, Jun 28

Aklapper awarded T220736: 1.34.0-wmf.11 deployment blockers a Like token.
Fri, Jun 28, 7:57 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell added a comment to T213976: Workflow to be able to move data files computed in jobs from analytics cluster to production .

Yes, you're right. Maybe turning mwmaint1002 to a minikube and applying jobs there (not just ores jobs but also mediawiki manual maintenance jobs as well when mediawiki moved to kubernetes). Just an idea.

Fri, Jun 28, 4:01 PM · Patch-For-Review, Research-Backlog, Operations, Discovery, Analytics
mmodell updated subscribers of T213976: Workflow to be able to move data files computed in jobs from analytics cluster to production .

@mmodell This is kind of a 'deployment' process thing, is this something we can work with RelEng to figure out? @fgiunchedi should we work with you to get the Swift parts available/working? If not, let us know who to ping.

Fri, Jun 28, 4:01 PM · Patch-For-Review, Research-Backlog, Operations, Discovery, Analytics
mmodell claimed T185155: Improve error reporting / integration between Kibana and Phabricator.
Fri, Jun 28, 5:15 AM · Release-Engineering-Team-TODO (201907), Wikimedia-Logstash, Phabricator

Thu, Jun 27

mmodell committed rPHEXcf1484edaddf: Updated Profile Menu Items for compatibility with upstream/stable (authored by mmodell).
Updated Profile Menu Items for compatibility with upstream/stable
Thu, Jun 27, 9:38 PM
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

Thanks @MoritzMuehlenhoff ! I really appreciate it! I'll install that now.

Thu, Jun 27, 9:09 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion

Wed, Jun 26

mmodell triaged T226682: Automating the swat deployment workflow as Normal priority.
Wed, Jun 26, 11:37 PM · Scap
mmodell created T226682: Automating the swat deployment workflow.
Wed, Jun 26, 11:37 PM · Scap
mmodell lowered the priority of T226662: Database query error in en.wikisource.org Special:Preferences Gadgets on save from Unbreak Now! to Normal.

I have successfully disabled and enabled Easy LST (and a few other gadgets) a few times with no issues. Probably just a temporary glitch during deployment caused by overloaded servers?

Wed, Jun 26, 8:04 PM · Wikimedia-production-error, MediaWiki-User-management
mmodell added a comment to T226662: Database query error in en.wikisource.org Special:Preferences Gadgets on save.

lock wait timeout? That seems a bit strange based on the query

Wed, Jun 26, 7:50 PM · Wikimedia-production-error, MediaWiki-User-management
mmodell awarded Train Conductor to recipient: jeena.
Wed, Jun 26, 7:07 PM
mmodell added a comment to T224857: Enhance MediaWiki deployments for support of php7.x.

Note: we should think about how this affects canary tests in scap.

Wed, Jun 26, 4:11 PM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO, Patch-For-Review, User-jijiki, PHP 7.2 support, Scap, serviceops
mmodell added a comment to T224857: Enhance MediaWiki deployments for support of php7.x.

We could kick off a rolling restart also at the end of each SWAT window, just for good measure. Of course, that goes against @Krinkle's desire for keeping app servers running for > 3 days. Still waiting to hear more from him about the performance implications of restarting ~daily.

Wed, Jun 26, 11:31 AM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO, Patch-For-Review, User-jijiki, PHP 7.2 support, Scap, serviceops
mmodell updated the task description for T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".
Wed, Jun 26, 10:44 AM · MediaWiki-Uploading, Multimedia, Wikimedia-production-error
mmodell added a comment to T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".

It seems that @Seb35 uncovered the steps to reproduce:

Wed, Jun 26, 10:42 AM · MediaWiki-Uploading, Multimedia, Wikimedia-production-error
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

Thanks @MoritzMuehlenhoff!

Wed, Jun 26, 10:34 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell updated the task description for T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).
Wed, Jun 26, 10:34 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion

Tue, Jun 25

mmodell added a comment to T220735: 1.34.0-wmf.10 deployment blockers.

deploying MediaWiki 1.34.0-wmf.10 to all wikis

Tue, Jun 25, 7:08 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell assigned T220736: 1.34.0-wmf.11 deployment blockers to jeena.
Tue, Jun 25, 6:41 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell added a comment to T226545: Loop trying to create an account in Wikimedia Space in certain cases.

Works fine for me with Firefox 67.0.3 (64-bit) (Linux)

Tue, Jun 25, 5:50 PM · Space (Jul-Sep-2019), Discourse
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

This is causing significant inconvenience as we have some repositories which are hosted on phabricator and cannot be pushed over ssh. I'm kind of grasping at straws here but I'll ask anyway:
Is there any temporary solution that we could use to get the self-built binary on phab1003 (and then configure sshd-phabricator service to use it)? I'm not even sure what sort of solution would be acceptable to SRE and I'm not very keen on it given the ad-hoc nature of installing binaries outside of the dpkg system. I only ask because debian isn't exactly known for moving quickly and the upstream bug has been open for quite a while without any movement since August of last year.

Tue, Jun 25, 8:16 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell moved T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003) from Backlog to Blocked (externally) on the Release-Engineering-Team (Kanban) board.
Tue, Jun 25, 2:14 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell placed T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003) up for grabs.
Tue, Jun 25, 2:13 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

So I finally got a chance to test this, I can confirm that my patched sshd binary fixes the issue.

Tue, Jun 25, 2:11 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion

Mon, Jun 24

mmodell added a comment to T220735: 1.34.0-wmf.10 deployment blockers.

Given the above, the current plan is as follows:

Mon, Jun 24, 5:30 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell removed a member for acl*procurement-review: cwdent.
Mon, Jun 24, 5:19 PM
mmodell added a comment to T220735: 1.34.0-wmf.10 deployment blockers.

This is now unblocked! 🎉

Mon, Jun 24, 5:13 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell removed parent tasks for T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content: T220736: 1.34.0-wmf.11 deployment blockers, T220735: 1.34.0-wmf.10 deployment blockers.
Mon, Jun 24, 5:12 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
mmodell removed a subtask for T220735: 1.34.0-wmf.10 deployment blockers: T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.
Mon, Jun 24, 5:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell removed a subtask for T220736: 1.34.0-wmf.11 deployment blockers: T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.
Mon, Jun 24, 5:12 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
mmodell added a comment to T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.

Thanks @kostajh, indeed that sounds like it's not a blocker.

Mon, Jun 24, 5:12 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
mmodell added a comment to T226197: Fatal from ApiHelpPanelPostQuestion: Argument to QuestionPoster::runEditFilterMergedContentHook must implement Content.

If this is really not a blocker then lets remove the parent tasks. @kostajh: can you explain? Also, what remains to be done with https://gerrit.wikimedia.org/r/518739 before it can merge? I'd like to deploy wmf.10 today but I would prefer to fix the fatals before doing so.

Mon, Jun 24, 5:09 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error
mmodell claimed T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).
Mon, Jun 24, 2:31 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

@ArielGlenn I built the whole package successfully and uploaded the sshd binary to my home directory on phab1003. I think I can test it without swapping out the normal sshd binary by simply stopping the git-sshd service and then running the patched binary in debug mode with sudo ./sshd -d

Mon, Jun 24, 2:31 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion

Fri, Jun 21

mmodell edited P8641 TOP.
Fri, Jun 21, 5:13 PM
mmodell created P8641 TOP.
Fri, Jun 21, 5:11 PM
mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

@LucasWerkmeister that could work, though if the fix is as simple as it appears to be then I'd like to just patch sshd. @ArielGlenn what do you think? If I attempt to build sshd with a patch, where should I build it and how should I deploy the patched binary?

Fri, Jun 21, 12:47 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion
mmodell closed T196411: Document scap swat command as Declined.

I no longer believe that scap swat is the right solution to the problem that it originally attempted to address. In the near future we will be working on other tooling to streamline swat deployments. I think this task can be laid to rest.

Fri, Jun 21, 12:41 PM · Scap, Release-Engineering-Team (Kanban), User-MModell
mmodell closed T196411: Document scap swat command, a subtask of T193311: Track scap syncs that are part of a given SWAT window , as Declined.
Fri, Jun 21, 12:41 PM · Scap
mmodell added a comment to T226044: Prepare Phame to support heavy traffic for a Tech Department blog.

This seems like a good idea, however, the upstream documentation has a warning that there are some issues with an external blog / dedicated subdomain: https://secure.phabricator.com/book/phabricator/article/phame/#external-blogs

Fri, Jun 21, 12:37 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, Operations, Traffic, Phabricator
mmodell added a comment to T226240: Create mirror of Gerrit repositories for consumption by various tools.

@hashar: we already have a read-only replica of most repositories on phabricator. Is that not satisfactory? It's kept up to date, with a lag of just a few minutes in the worst case.

Fri, Jun 21, 12:30 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, Gerrit

Thu, Jun 20

mmodell added a comment to T226109: Jobs not being executed on 1.34.0-wmf.10.

edit: I didn't see @Krinkle's message, this was replying to @RhinosF1:

Thu, Jun 20, 4:25 PM · Analytics, EventBus, Services (done), Core Platform Team Workboards (Done with CPT), Operations, WMF-JobQueue, MassMessage

Jun 18 2019

mmodell awarded T220735: 1.34.0-wmf.10 deployment blockers a Cup of Joe token.
Jun 18 2019, 7:17 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Release-Engineering-Team (Kanban), Release, Train Deployments

Jun 16 2019

mmodell awarded T220897: "Choose subtype" box does not disappear after choosing an option when creating new subtask with "Persistent Chat" option in Conpherence enabled a Cookie token.
Jun 16 2019, 12:45 PM · Phabricator (2019-07-03), Upstream
mmodell updated subscribers of T225875: GSoD Proposal: Improvements in Release Notes Documentation of MediaWiki Releases.
Jun 16 2019, 12:42 PM · Google Season of Docs 2019

Jun 13 2019

mmodell added a comment to T224939: Create an interface for the local-charts ecosystem.

@thcipriani: at least on a mac with homebrew, it's as simple as brew install python

Jun 13 2019, 9:59 PM · Release-Engineering-Team (Local Dev), Release-Engineering-Team-TODO, Developer Productivity, local-charts
mmodell added a comment to T224939: Create an interface for the local-charts ecosystem.

My two cents, I wanted to suggest consideration of PHP and JavaScript as languages to be used for creation of the CLI.

Jun 13 2019, 6:03 PM · Release-Engineering-Team (Local Dev), Release-Engineering-Team-TODO, Developer Productivity, local-charts

Jun 12 2019

mmodell added a comment to T216605: Cannot assign user name "XXX" to account ####; name already in use..

If so, we can apply the generated patch, reindex user accounts and resolve this ticket -- trying to think of any other implications of this that I missed here.

Jun 12 2019, 10:27 PM · Security, Gerrit
mmodell lowered the priority of T181393: Make sure elasticsearch 6 is supported in phabricator from High to Normal.
Jun 12 2019, 9:44 PM · Release-Engineering-Team-TODO, Phabricator, User-MModell
mmodell added a comment to T181393: Make sure elasticsearch 6 is supported in phabricator.

es6 patch was rolled back because at the time I think we were still on es5 and my code wasn't as forward/backward compatible as I thought it was. Still need to re-apply the patch for fully es6 index.

Jun 12 2019, 9:44 PM · Release-Engineering-Team-TODO, Phabricator, User-MModell
mmodell added a comment to T224939: Create an interface for the local-charts ecosystem.

pywebview is a lightweight cross-platform wrapper around a webview component that allows to display HTML content in its own native GUI window. It gives you power of web technologies in your desktop application, hiding the fact that GUI is browser based. You can use pywebview either with a lightweight web framework like Flask or Bottle or on its own with a two way bridge between Python and DOM.
pywebview uses native GUI for creating a web component window: WinForms on Windows, Cocoa on macOS and QT or GTK on Linux. If you choose to freeze your application, pywebview does not bundle a heavy GUI toolkit or web renderer with it keeping the executable size small. pywebview is compatible with both Python 2 and 3.

Jun 12 2019, 4:58 PM · Release-Engineering-Team (Local Dev), Release-Engineering-Team-TODO, Developer Productivity, local-charts

Jun 11 2019

mmodell awarded T221177: REST route handler extension interface RFC a Like token.
Jun 11 2019, 3:31 PM · Core Platform Team Workboards (Team 1), TechCom-RFC (TechCom-Approved), Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2))
mmodell added projects to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003): Packaging, Upstream.

So it appears that there is a fix upstream in sshd but it hasn't made it's way into a stable debian package. What's the next step here? Move phabricator back to an older debian version? Build a custom sshd package with the fix applied? Something else? What do you thank @ArielGlenn?

Jun 11 2019, 2:49 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion

Jun 10 2019

mmodell added a comment to T224677: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003).

openssh-server: SSH AuthorizedKeysCommand hangs when output is too large

Jun 10 2019, 5:25 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Upstream, Packaging, User-zeljkofilipin, Operations, Diffusion