Page MenuHomePhabricator

mwilliams (Matthew)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2020, 6:07 PM (69 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MWilliams (WMF) [ Global Accounts ]

Recent Activity

Tue, Jun 8

mwilliams added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

@Etonkovidova Good question! I had incorrectly assumed that these assessments would be for images and video only but if there are other file types receiving these assessments, it can't hurt to show the filter on all of the tabs. I don't think it's a blocker but something to consider when we have the time to update.

Tue, Jun 8, 9:16 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Wed, Jun 2

mwilliams moved T281748: [S] More details link in MediaSearch on mobile goes to desktop site from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.
Wed, Jun 2, 4:25 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
mwilliams renamed T281748: [S] More details link in MediaSearch on mobile goes to desktop site from More details link in MediaSearch on mobile goes to desktop site to [S] More details link in MediaSearch on mobile goes to desktop site.
Wed, Jun 2, 4:21 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch

May 12 2021

mwilliams updated subscribers of T280055: [S] MediaSearch: Special pages not present in search results.

Chatted with a few of you about this...some ideas:

May 12 2021, 7:25 PM · Structured-Data-Backlog (Current Work)

May 11 2021

mwilliams claimed T280055: [S] MediaSearch: Special pages not present in search results.
May 11 2021, 2:05 PM · Structured-Data-Backlog (Current Work)

Apr 5 2021

mwilliams updated the task description for T276257: [M] Create "assessment" filter in MediaSearch.
Apr 5 2021, 6:01 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch
mwilliams moved T276257: [M] Create "assessment" filter in MediaSearch from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Apr 5 2021, 5:54 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch
mwilliams updated the task description for T276257: [M] Create "assessment" filter in MediaSearch.
Apr 5 2021, 5:53 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch
mwilliams added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

After chatting with the team, we decided on starting with the least complex solution to implement as we currently have limited time resources to dedicate to this. We hope to gain more insight on how this filter is being used before investing more time.

Apr 5 2021, 5:52 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Mar 31 2021

mwilliams added a comment to T274927: [M] Add messaging to the MediaSearch page linking back to Special:Search and indicating that there is a preference.

Thanks Elena!

Mar 31 2021, 9:43 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Mar 30 2021

mwilliams added a comment to T278844: [S] MediaSearch:"Categories and Pages" filter UI discrepancies.

@AnneT Having the namespace filter use the same hover state (gray background) makes sense to me!

Mar 30 2021, 4:47 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)

Mar 25 2021

mwilliams added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

@ChristianFerrer All good points, thanks. Going to bring this ticket up in an upcoming team meeting and see what parts of this we can accomplish and when. Here are some mockups of your ideas:

Mar 25 2021, 7:07 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Mar 24 2021

mwilliams added a comment to T274927: [M] Add messaging to the MediaSearch page linking back to Special:Search and indicating that there is a preference.

@Jseddon brought to my attention that now that we have the "Help" link in the top right, that this design doesn't quite work. A few points I mentioned from our Slack thread

Mar 24 2021, 9:59 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T276261: [L] Build namespace filter feature in JS UI.

That all makes sense to me. So let's just keep option 1 for now and we can think on any improvements to the filter language and the visible cue issue once we can use it in for production for awhile!

Mar 24 2021, 9:17 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T276261: [L] Build namespace filter feature in JS UI.

One other thing that I overlooked when we switched this to a dialog is how to represent the text of this action next to the other filters. A few thoughts there:

Mar 24 2021, 7:49 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T276261: [L] Build namespace filter feature in JS UI.

I've mostly been thinking that the X in dialogs equals a "Cancel" button but after thinking about it "Cancel" does feel like it more explicitly implies that we will not be saving any choices.

Mar 24 2021, 7:42 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Mar 17 2021

mwilliams added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

@ChristianFerrer Thanks for your input, that could work, still figuring out how they would work together and to not make the "Advanced" link appear to be part of the select options while having an expected interaction once clicked on.

Mar 17 2021, 8:36 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Mar 16 2021

mwilliams added a comment to T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.

Thanks for your detailed work on this @Etonkovidova!

Mar 16 2021, 9:06 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons

Mar 15 2021

mwilliams added a comment to T276729: Components – Dialogs: “Alerts” not yet represented.

Hello @Volker_E! Not sure I'm totally following what we need here.

Mar 15 2021, 11:20 PM · Wikimedia Design Style Guide
mwilliams moved T271440: [XS] Media Search: Decrease padding below filters from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Mar 15 2021, 6:37 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T271440: [XS] Media Search: Decrease padding below filters.

This works for me! Thanks everyone

Mar 15 2021, 6:36 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Mar 12 2021

mwilliams added a comment to T276257: [M] Create "assessment" filter in MediaSearch.

Really like this idea and could see it be especially useful while searching for image to place in an article.

Mar 12 2021, 8:19 PM · Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch

Mar 10 2021

mwilliams added a comment to T271565: [S] Media Search: Adjustment of filter selects / dropdowns.

@Jseddon This looks great!

Mar 10 2021, 3:45 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Mar 8 2021

mwilliams moved T274927: [M] Add messaging to the MediaSearch page linking back to Special:Search and indicating that there is a preference from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Mar 8 2021, 5:18 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Mar 3 2021

mwilliams updated the task description for T274927: [M] Add messaging to the MediaSearch page linking back to Special:Search and indicating that there is a preference.
Mar 3 2021, 9:04 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T273839: [M] MediaSearch: invalid search queries never finish loading - no warning to users.

Thanks @matthiasmullie, that makes sense.

Mar 3 2021, 8:48 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
mwilliams added a comment to T273839: [M] MediaSearch: invalid search queries never finish loading - no warning to users.

@Etonkovidova Can you help me understand how this ticket differs from https://phabricator.wikimedia.org/T271387?

Mar 3 2021, 3:57 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch
mwilliams updated subscribers of T275671: Add Matthew Williams to analytics-privatedata-users.

Thanks for getting this started @nettrom_WMF!

Mar 3 2021, 3:56 PM · Structured-Data-Backlog (Current Work), SRE, Product-Analytics, SRE-Access-Requests
mwilliams updated the task description for T275671: Add Matthew Williams to analytics-privatedata-users.
Mar 3 2021, 3:54 PM · Structured-Data-Backlog (Current Work), SRE, Product-Analytics, SRE-Access-Requests
mwilliams updated the task description for T275671: Add Matthew Williams to analytics-privatedata-users.
Mar 3 2021, 3:54 PM · Structured-Data-Backlog (Current Work), SRE, Product-Analytics, SRE-Access-Requests
mwilliams added a comment to T271387: [M] Handle case of erroneous search filter values in URL.

@egardner That seems reasonable to me, thanks!

Mar 3 2021, 3:47 AM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 25 2021

mwilliams added a comment to T272417: [S] MediaSearch: the search icon not visible when page loads.

@Jseddon Sounds good to me, thanks for the suggestion!

Feb 25 2021, 9:24 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.

Thanks for the heads up @AnneT!

Feb 25 2021, 6:27 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons
mwilliams added a comment to T272502: [XS] Media Search: End of results messaging update.

@Jseddon Yup, not bold anymore. Good catch!

Feb 25 2021, 2:52 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 24 2021

mwilliams updated subscribers of T275662: Create a Vue.js-based Dialog component for use in Structured Data projects.
Feb 24 2021, 6:55 PM · SDAW-MediaSearch, Structured-Data-Backlog
mwilliams updated the task description for T275662: Create a Vue.js-based Dialog component for use in Structured Data projects.
Feb 24 2021, 6:55 PM · SDAW-MediaSearch, Structured-Data-Backlog
mwilliams added a comment to T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.

The design team just released a very rough v1 dialog component: https://design.wikimedia.org/style-guide/components/dialogs.html

Feb 24 2021, 5:26 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 23 2021

mwilliams added a comment to T271440: [XS] Media Search: Decrease padding below filters.

I think its fine to have it on all the tabs to make this consistent

Feb 23 2021, 6:29 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T271440: [XS] Media Search: Decrease padding below filters.

Yeah, I wondered that when I took a look at this @AnneT, thanks for bringing that up.

Feb 23 2021, 5:07 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Feb 22 2021

mwilliams added a comment to T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.

So the de-facto default is "All"?

Yup! Default is all the namespaces that apply to the Pages & Categories tab

Feb 22 2021, 11:31 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T274927: [M] Add messaging to the MediaSearch page linking back to Special:Search and indicating that there is a preference.

Good points @Keegan, thanks for the input!

Feb 22 2021, 8:01 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams updated the task description for T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.
Feb 22 2021, 5:35 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams updated the task description for T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.
Feb 22 2021, 5:32 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams updated the task description for T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.
Feb 22 2021, 5:30 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T272502: [XS] Media Search: End of results messaging update.

@Jseddon For now we just want to adjust "EndofResults"

Feb 22 2021, 4:21 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T271440: [XS] Media Search: Decrease padding below filters.

@Jseddon Tested out removing the 16px from the search results and that seems like it does the job nicely!

Feb 22 2021, 4:21 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Feb 19 2021

mwilliams moved T260292: [M] Add "did you mean" feature to Media Search from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Feb 19 2021, 3:48 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T260292: [M] Add "did you mean" feature to Media Search.

This seems fine to me!

Feb 19 2021, 3:48 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 17 2021

mwilliams added a comment to T274927: [M] Add messaging to the MediaSearch page linking back to Special:Search and indicating that there is a preference.

Two ideas for this ticket so far:

Feb 17 2021, 7:33 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.

Per our meeting yesterday, I updated the namespace selector filter dialogs to map a little closer to the special:search experience. Two questions: Do you think that we need that "Default" selection choice? I'm not sure I have enough context to know what to do there. And should we support the "Remember selection for future searches" checkbox, is that a lot of work?

Feb 17 2021, 6:04 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 16 2021

mwilliams updated subscribers of T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.

Dropped the above screenshot into Slack and got some good feedback

Feb 16 2021, 10:49 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons
mwilliams added a comment to T260263: [S] Remove focus from search input after searching in Media Search.

4 months later I respond...

Feb 16 2021, 9:00 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T274355: Make videos load smoother.

Works for me!

Feb 16 2021, 6:06 PM · Structured-Data-Backlog (Current Work), MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Feb 12 2021

mwilliams moved T270735: [M] Media Search: Image sizing and quick view from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Feb 12 2021, 4:42 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T270735: [M] Media Search: Image sizing and quick view.

Seems to be a good improvement!

Feb 12 2021, 4:41 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 11 2021

mwilliams added a comment to T260292: [M] Add "did you mean" feature to Media Search.

Thanks for the explanation @matthiasmullie, sounds like we should avoid attempting to add in the rewrite feature at the moment.

Feb 11 2021, 4:39 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T260292: [M] Add "did you mean" feature to Media Search.

@egardner This makes sense, getting rewrites 100% right would obviously be a good thing but that sounds very tricky as you've explained. I also don't think rewrites are a blocker for us making Media Search the default, more of a "really nice to have".

Feb 11 2021, 3:19 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Feb 8 2021

mwilliams moved T272536: SVG `currentColor` isn't sufficient with skinning variants in mind from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Feb 8 2021, 7:04 PM · Structured-Data-Backlog, SDAW-MediaSearch, Wikidata
mwilliams added a comment to T273979: [S] Add preference to allow users to keep Special:Search as the default target for the skin search input widget.

Added a screenshot to the description, the one thing I think we could also update is adding a "header" to the top section of preferences since everything else has one and it felt a bit odd. I put "General" in there but I imagine we could think of something more specific.

Feb 8 2021, 6:31 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams updated the task description for T273979: [S] Add preference to allow users to keep Special:Search as the default target for the skin search input widget.
Feb 8 2021, 6:30 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Feb 5 2021

mwilliams added a comment to T271174: [M] MediaSearch: display namespaces and snippets for search results on "Categories and Pages" tab.

Starting to try out some options here for where the namespace goes. I think the text snippet having some space in between the title and the metadata should work fine but we should limit how long that line can be so it's still legible. Adding any additional metadata, like a date can fit in the current metadata line as well.

Feb 5 2021, 5:41 PM · Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), StructuredDataOnCommons

Feb 3 2021

mwilliams added a comment to T271565: [S] Media Search: Adjustment of filter selects / dropdowns.

Option 1 works for me! If adding the hover state starts to get annoying, just adjusting the spacing resolves the majority of issue with this.

Feb 3 2021, 9:31 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Feb 1 2021

mwilliams closed T263171: Media Search: Ability to clear selected filters as Resolved.
Feb 1 2021, 5:32 PM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)
mwilliams added a comment to T263171: Media Search: Ability to clear selected filters.

I don't think we need this feature at this time. We have a small amount of filters and the use case of someone using enough of them at one time to really need this is limited. We revisit this in the future.

Feb 1 2021, 5:32 PM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)
mwilliams closed T261703: Media Search: Updated Filter Experience as Declined.
Feb 1 2021, 5:30 PM · SDAW-MediaSearch, Structured-Data-Backlog (Current Work)

Jan 29 2021

mwilliams added a comment to T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.

Thanks for the feedback Anne! Also chatted with Eric who brought up some similar concerns.

Jan 29 2021, 5:40 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 27 2021

mwilliams added a comment to T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.

One idea for this is to create two top level radio buttons and allow users to switch to custom and select any checkboxes they want.

Jan 27 2021, 4:52 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams moved T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab from Ready for Estimation to Needs Design on the Structured-Data-Backlog (Current Work) board.
Jan 27 2021, 4:29 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams moved T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jan 27 2021, 4:09 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams created T273073: [Epic] Media Search: Ability to filter by namespaces in the Categories and Pages tab.
Jan 27 2021, 4:08 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T269383: [M] Media Search: Surfacing the result count.

Chatted with @AnneT about this and we are going to leave the result count at the end of filters to keep it more similar to desktop, even if it's well hidden and seen infrequently.

Jan 27 2021, 12:24 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 26 2021

mwilliams added a comment to T269383: [M] Media Search: Surfacing the result count.

@egardner On mobile web, I don't think it's worth creating a whole new line and pushing the results even farther down just to add this feature, the top section is already getting pretty tall. Any other strategy would include fixed elements / major rearrangements which also doesn't seem worth it.

Jan 26 2021, 9:07 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 23 2021

Ckoerner awarded T269383: [M] Media Search: Surfacing the result count a Love token.
Jan 23 2021, 3:14 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 20 2021

mwilliams updated the task description for T272502: [XS] Media Search: End of results messaging update.
Jan 20 2021, 3:53 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams moved T272502: [XS] Media Search: End of results messaging update from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jan 20 2021, 3:52 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams created T272502: [XS] Media Search: End of results messaging update.
Jan 20 2021, 3:52 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T261166: [S] Media Search: Messaging that you've reached the end of results.

Good points Matthias, thanks for your input! We chatted about this in our team Slack group, where I showed a couple different designs and copy options and we decided that moving forward with a simpler and more subtle design is the right path forward for now.

Jan 20 2021, 3:48 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)

Jan 19 2021

mwilliams added a comment to T271387: [M] Handle case of erroneous search filter values in URL.

Simple solution

Message saying this is an invalid search with a link to media search

Jan 19 2021, 5:29 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 15 2021

mwilliams moved T271387: [M] Handle case of erroneous search filter values in URL from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jan 15 2021, 6:48 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T271387: [M] Handle case of erroneous search filter values in URL.

Works for me.

Jan 15 2021, 6:48 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 14 2021

mwilliams added a comment to T271387: [M] Handle case of erroneous search filter values in URL.

That makes sense. I don't think I'd usually use that phrase with most users but with anyone adjusting filters in their URL I imagine they will understand what is going on?

Jan 14 2021, 10:20 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T271387: [M] Handle case of erroneous search filter values in URL.
  • Is there a way for us to not remove/eliminate the filters with this error state? That makes this experience feel much more broken and like our mistake/bug rather than a user error.
  • In general our goal with error states in search is to: Clearly state there are no results and offer a path forward.
  • After chatting with @egardner he mentioned we will know specifically that this is broken due to an invalid value and not just a normal no results state. One easy way forward could be to replicate the current no results state with some updated copy to address all errors related to bad values for media type, filters, etc.
Jan 14 2021, 10:03 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 13 2021

mwilliams moved T266150: Support search filters in no-JS search results page from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Jan 13 2021, 4:07 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams moved T257938: License type filter for media search from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Jan 13 2021, 4:07 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Patch-For-Review, SDAW-MediaSearch (MediaSearch-Beta), SDC General, Commons, Wikidata, Structured-Data-Backlog (Current Work)
mwilliams moved T264034: [L] Media Search: Grid updates from Design QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Jan 13 2021, 4:02 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)

Jan 8 2021

mwilliams added a comment to T261166: [S] Media Search: Messaging that you've reached the end of results.

Sounds good. I wondered about putting filter in there but like with spelling it could also be confusing if they don't have any filters applied.

Jan 8 2021, 9:06 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T261166: [S] Media Search: Messaging that you've reached the end of results.

Good point @AnneT. Ideally we would know if there was a more common spelling, if too many filters were applied, etc. in order to give good recommendations on what to do next. Since this is very static, maybe we just say something like....

Jan 8 2021, 8:41 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams moved T271565: [S] Media Search: Adjustment of filter selects / dropdowns from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jan 8 2021, 5:32 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams updated the task description for T271565: [S] Media Search: Adjustment of filter selects / dropdowns.
Jan 8 2021, 5:32 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams created T271565: [S] Media Search: Adjustment of filter selects / dropdowns.
Jan 8 2021, 5:29 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)

Jan 7 2021

mwilliams moved T271440: [XS] Media Search: Decrease padding below filters from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jan 7 2021, 6:46 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T261166: [S] Media Search: Messaging that you've reached the end of results.

Seems reasonable to me! Thanks @egardner

Jan 7 2021, 5:43 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T261166: [S] Media Search: Messaging that you've reached the end of results.

Text only is fine for now. The main goal of this was to make it clear that no more results were going to load/appear.

Jan 7 2021, 5:27 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a comment to T261166: [S] Media Search: Messaging that you've reached the end of results.

@egardner Good points! The lozenge shape decision was made after this ticket, so we are bit outdated. Lets map to the current concept chips design, lozenge shaped.

Jan 7 2021, 5:17 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2)
mwilliams added a project to T271440: [XS] Media Search: Decrease padding below filters: SDAW-MediaSearch (MediaSearch-ReleaseCandidate).
Jan 7 2021, 5:10 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams created T271440: [XS] Media Search: Decrease padding below filters.
Jan 7 2021, 5:10 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Structured-Data-Backlog (Current Work)
mwilliams moved T270735: [M] Media Search: Image sizing and quick view from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
Jan 7 2021, 5:04 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams added a comment to T266029: Add Dialogs to DSG.

Here is a very rough draft of the Dialog documentation, feel free to comment as I continue to work on it: https://docs.google.com/document/d/1UmldL2DWjFAERFpeEu6oSe2nq-vJqY3K3NUIc7_iolM/edit?usp=sharing

Jan 7 2021, 4:57 PM · Wikimedia Design Style Guide

Dec 22 2020

mwilliams updated the task description for T270735: [M] Media Search: Image sizing and quick view.
Dec 22 2020, 7:57 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)
mwilliams updated the task description for T270735: [M] Media Search: Image sizing and quick view.
Dec 22 2020, 7:55 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), Structured-Data-Backlog (Current Work)