Tue, Jun 8
@Etonkovidova Good question! I had incorrectly assumed that these assessments would be for images and video only but if there are other file types receiving these assessments, it can't hurt to show the filter on all of the tabs. I don't think it's a blocker but something to consider when we have the time to update.
Wed, Jun 2
May 12 2021
Chatted with a few of you about this...some ideas:
May 11 2021
Apr 5 2021
After chatting with the team, we decided on starting with the least complex solution to implement as we currently have limited time resources to dedicate to this. We hope to gain more insight on how this filter is being used before investing more time.
Mar 31 2021
Mar 30 2021
@AnneT Having the namespace filter use the same hover state (gray background) makes sense to me!
Mar 25 2021
@ChristianFerrer All good points, thanks. Going to bring this ticket up in an upcoming team meeting and see what parts of this we can accomplish and when. Here are some mockups of your ideas:
Mar 24 2021
@Jseddon brought to my attention that now that we have the "Help" link in the top right, that this design doesn't quite work. A few points I mentioned from our Slack thread
That all makes sense to me. So let's just keep option 1 for now and we can think on any improvements to the filter language and the visible cue issue once we can use it in for production for awhile!
One other thing that I overlooked when we switched this to a dialog is how to represent the text of this action next to the other filters. A few thoughts there:
I've mostly been thinking that the X in dialogs equals a "Cancel" button but after thinking about it "Cancel" does feel like it more explicitly implies that we will not be saving any choices.
Mar 17 2021
@ChristianFerrer Thanks for your input, that could work, still figuring out how they would work together and to not make the "Advanced" link appear to be part of the select options while having an expected interaction once clicked on.
Mar 16 2021
Thanks for your detailed work on this @Etonkovidova!
Mar 15 2021
Hello @Volker_E! Not sure I'm totally following what we need here.
This works for me! Thanks everyone
Mar 12 2021
Really like this idea and could see it be especially useful while searching for image to place in an article.
Mar 10 2021
@Jseddon This looks great!
Mar 8 2021
Mar 3 2021
Thanks @matthiasmullie, that makes sense.
Thanks for getting this started @nettrom_WMF!
@egardner That seems reasonable to me, thanks!
Feb 25 2021
@Jseddon Sounds good to me, thanks for the suggestion!
Thanks for the heads up @AnneT!
@Jseddon Yup, not bold anymore. Good catch!
Feb 24 2021
The design team just released a very rough v1 dialog component: https://design.wikimedia.org/style-guide/components/dialogs.html
Feb 23 2021
I think its fine to have it on all the tabs to make this consistent
Yeah, I wondered that when I took a look at this @AnneT, thanks for bringing that up.
Feb 22 2021
So the de-facto default is "All"?
Yup! Default is all the namespaces that apply to the Pages & Categories tab
Good points @Keegan, thanks for the input!
@Jseddon For now we just want to adjust "EndofResults"
@Jseddon Tested out removing the 16px from the search results and that seems like it does the job nicely!
Feb 19 2021
This seems fine to me!
Feb 17 2021
Two ideas for this ticket so far:
Per our meeting yesterday, I updated the namespace selector filter dialogs to map a little closer to the special:search experience. Two questions: Do you think that we need that "Default" selection choice? I'm not sure I have enough context to know what to do there. And should we support the "Remember selection for future searches" checkbox, is that a lot of work?
Feb 16 2021
Dropped the above screenshot into Slack and got some good feedback
4 months later I respond...
Works for me!
Feb 12 2021
Seems to be a good improvement!
Feb 11 2021
Thanks for the explanation @matthiasmullie, sounds like we should avoid attempting to add in the rewrite feature at the moment.
@egardner This makes sense, getting rewrites 100% right would obviously be a good thing but that sounds very tricky as you've explained. I also don't think rewrites are a blocker for us making Media Search the default, more of a "really nice to have".
Feb 8 2021
Added a screenshot to the description, the one thing I think we could also update is adding a "header" to the top section of preferences since everything else has one and it felt a bit odd. I put "General" in there but I imagine we could think of something more specific.
Feb 5 2021
Starting to try out some options here for where the namespace goes. I think the text snippet having some space in between the title and the metadata should work fine but we should limit how long that line can be so it's still legible. Adding any additional metadata, like a date can fit in the current metadata line as well.
Feb 3 2021
Option 1 works for me! If adding the hover state starts to get annoying, just adjusting the spacing resolves the majority of issue with this.
Feb 1 2021
I don't think we need this feature at this time. We have a small amount of filters and the use case of someone using enough of them at one time to really need this is limited. We revisit this in the future.
Jan 29 2021
Thanks for the feedback Anne! Also chatted with Eric who brought up some similar concerns.
Jan 27 2021
One idea for this is to create two top level radio buttons and allow users to switch to custom and select any checkboxes they want.
Chatted with @AnneT about this and we are going to leave the result count at the end of filters to keep it more similar to desktop, even if it's well hidden and seen infrequently.
Jan 26 2021
@egardner On mobile web, I don't think it's worth creating a whole new line and pushing the results even farther down just to add this feature, the top section is already getting pretty tall. Any other strategy would include fixed elements / major rearrangements which also doesn't seem worth it.
Jan 23 2021
Jan 20 2021
Good points Matthias, thanks for your input! We chatted about this in our team Slack group, where I showed a couple different designs and copy options and we decided that moving forward with a simpler and more subtle design is the right path forward for now.
Jan 19 2021
Jan 15 2021
Works for me.
Jan 14 2021
That makes sense. I don't think I'd usually use that phrase with most users but with anyone adjusting filters in their URL I imagine they will understand what is going on?
- Is there a way for us to not remove/eliminate the filters with this error state? That makes this experience feel much more broken and like our mistake/bug rather than a user error.
- In general our goal with error states in search is to: Clearly state there are no results and offer a path forward.
- After chatting with @egardner he mentioned we will know specifically that this is broken due to an invalid value and not just a normal no results state. One easy way forward could be to replicate the current no results state with some updated copy to address all errors related to bad values for media type, filters, etc.
Jan 13 2021
Jan 8 2021
Sounds good. I wondered about putting filter in there but like with spelling it could also be confusing if they don't have any filters applied.
Good point @AnneT. Ideally we would know if there was a more common spelling, if too many filters were applied, etc. in order to give good recommendations on what to do next. Since this is very static, maybe we just say something like....
Jan 7 2021
Seems reasonable to me! Thanks @egardner
Text only is fine for now. The main goal of this was to make it clear that no more results were going to load/appear.
@egardner Good points! The lozenge shape decision was made after this ticket, so we are bit outdated. Lets map to the current concept chips design, lozenge shaped.
Here is a very rough draft of the Dialog documentation, feel free to comment as I continue to work on it: https://docs.google.com/document/d/1UmldL2DWjFAERFpeEu6oSe2nq-vJqY3K3NUIc7_iolM/edit?usp=sharing