Wed, Jan 20
Good points Matthias, thanks for your input! We chatted about this in our team Slack group, where I showed a couple different designs and copy options and we decided that moving forward with a simpler and more subtle design is the right path forward for now.
Tue, Jan 19
Fri, Jan 15
Works for me.
Thu, Jan 14
That makes sense. I don't think I'd usually use that phrase with most users but with anyone adjusting filters in their URL I imagine they will understand what is going on?
- Is there a way for us to not remove/eliminate the filters with this error state? That makes this experience feel much more broken and like our mistake/bug rather than a user error.
- In general our goal with error states in search is to: Clearly state there are no results and offer a path forward.
- After chatting with @egardner he mentioned we will know specifically that this is broken due to an invalid value and not just a normal no results state. One easy way forward could be to replicate the current no results state with some updated copy to address all errors related to bad values for media type, filters, etc.
Wed, Jan 13
Fri, Jan 8
Sounds good. I wondered about putting filter in there but like spelling, it also could be confusing if they don't have any filters applied?
Good point @AnneT. Ideally we would know if there was a more common spelling, if too many filters were applied, etc. in order to give good recommendations on what to do next. Since this is very static, maybe we just say something like....
Thu, Jan 7
Seems reasonable to me! Thanks @egardner
Text only is fine for now. The main goal of this was to make it clear that no more results were going to load/appear.
@egardner Good points! The lozenge shape decision was made after this ticket, so we are bit outdated. Lets map to the current concept chips design, lozenge shaped.
Here is a very rough draft of the Dialog documentation, feel free to comment as I continue to work on it: https://docs.google.com/document/d/1UmldL2DWjFAERFpeEu6oSe2nq-vJqY3K3NUIc7_iolM/edit?usp=sharing
Dec 22 2020
Chatted with @AnneT about this, going to move this to verify production and create a new ticket for the images changing sizes weirdly when the quick view opens!
Looks good to me!
@Volker_E Good questions, here is an attempt to answer them :)
Dec 21 2020
Looks good and agree with Elena's answers here!
This looks good to me! I'll double check the contrast ratio and create a ticket if needed since that is separate from the icon issue.
Dec 18 2020
Dec 16 2020
After meetings with designers, engineers, product managers, and anyone else I could track down and bother, I believe I have enough information to form an opinion and propose a direction forward for this component.
Dec 14 2020
Dec 10 2020
This is looking good!
Dec 4 2020
I've created a handful of slides comparing the pro's and con's of the different action placement options in the slide deck, slides 15-22. Not going to attempt to replicate here in phab :)
Dec 3 2020
Dec 1 2020
Thanks for all the feedback everyone, keep it coming! I'll try and organize this by subject instead of quotes.
Nov 30 2020
Thanks for the feedback @RHo! Here is an attempt to address your questions:
Nov 25 2020
Small mobile update:
Nov 18 2020
Nov 16 2020
@egardner mentioned this as the potential culprit
Nov 10 2020
Nov 5 2020
To attempt to gain more context and clarity around this task, I've created a slide deck with definitions, current examples, and potential directions we might be able to take this work. So far we've gotten good feedback from the working group and the larger design team during a design review.
Nov 4 2020
@AnneT Agreed, if it's a hassle, lose it!
Oct 23 2020
This is super helpful, thanks @Volker_E!
Oct 21 2020
Hmmm, I'm seeing the desired action on production, I think I'm confused now :)
Oct 8 2020
Oct 6 2020
This is on hold for now...feels like our current implementation is working just fine.
Oct 5 2020
Ticket updated to include actual arrow buttons as well to navigate between images quickly
Squashed and updated my last couple comments here into the task description
Sep 29 2020
This ticket belongs around here too: https://phabricator.wikimedia.org/T263060
Sep 28 2020
@AnneT Good idea, having different icons depending on the media type sounds ideal.
- Improving resolution of images while in grid to avoid blurriness
- Finding optimal height for images (Seems like we need to increase the height by a bit?)
- How to handle panorama / very wide landscape photos, cropping strategy
- Should the images be slightly smaller when the quick view is open. Feels awkward when only 2 or even 1 image is shown per row when quick view is open.
- Related to previous point, but what seems to be the optimal width for the quick view? Should it be a reduced a bit to accommodate browsing the grid better?
This is looking really good to me! Plenty good enough to head to production and I'll spend more time with it once it is out and easier to test.
Sep 25 2020
Thanks for your help @Isaac, it is super helpful!
Sep 24 2020
@Etonkovidova This is a big enough improvement that I wouldn't block this from being released but yeah, seems like we have a bit more work to do on this.
Quick view images are looking good, but I agree that the images in the grid still seem low resolution . @egardner is this expected?
Sep 23 2020
Sep 21 2020
Starting to piece together ideas here on the placement (Slides 21-26) https://docs.google.com/presentation/d/1EGiLili2aYjhucLApxtTf9zhtXPxjs9MRs6F1gcYjQM/edit?usp=sharing
Sep 18 2020
I'm a bit worried how the grid and quick view will work/feel with losing that much width to the survey. I would certainly respond negatively to a survey that made the functionality of the thing we are asking about worse. @matthiasmullie It sounds like there isn't much flexibility on the layout or design with this? Is it worth my while to consider a few other ways this could work?
Sep 17 2020
Sep 16 2020
@TJones Thanks for the context! That is super helpful.