Page MenuHomePhabricator

mwjames (mwjames)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 25 2014, 9:38 PM (255 w, 3 d)
Availability
Available
LDAP User
Mwjames
MediaWiki User
Unknown

Recent Activity

Sep 22 2018

mwjames added a comment to T66721: mw.loader.store should not occupy all of localStorage.

As for the issue reported in this task, it's been resolved. In theory, it will always be

Sep 22 2018, 2:10 PM · MW-1.27-release-notes, Performance-Team, JavaScript, MediaWiki-ResourceLoader
mwjames closed T203862: MW 1.32+ "--with-phpunitclass" is gone as Resolved.

Use register_shutdown_function?

Sep 22 2018, 5:50 AM · MediaWiki-Core-Testing

Sep 15 2018

mwjames created T204423: MW 1.31 install reports "InvalidArgumentException ... DatabaseDomain.php: Domain has too few or too many parts ".
Sep 15 2018, 10:57 PM · MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, Performance-Team, MW-1.31-release, Wikimedia-Rdbms, MediaWiki-Installer
mwjames created T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()".
Sep 15 2018, 9:46 PM · PHP 7.3 support, MediaWiki-Core-Testing
mwjames added a comment to T203862: MW 1.32+ "--with-phpunitclass" is gone .

teardown (theoretically at least). But in any case, maybe you could use a test listener (https://phpunit.de/manual/6.5/en/extending-phpunit.html#extending-phpunit.PHPUnit_Framework_TestListener) and implement endTestSuite() ? It's not exactly identical since there are generally multiple suites being executed at once, but I think it might meet your needs.

Sep 15 2018, 9:43 PM · MediaWiki-Core-Testing

Sep 8 2018

mwjames closed T203724: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def', as Resolved.

... and by that you mean "MediaWikiServices::getInstance()->resetServiceForTesting( 'NameTableStoreFactory' );" ?

Sep 8 2018, 5:18 AM · MediaWiki-Change-tagging
mwjames added a comment to T203724: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def',.

tests but the table (change_tag) got emptied. Do you do something similar in the tests?

Sep 8 2018, 2:57 AM · MediaWiki-Change-tagging
mwjames created T203862: MW 1.32+ "--with-phpunitclass" is gone .
Sep 8 2018, 2:48 AM · MediaWiki-Core-Testing

Sep 6 2018

mwjames updated the task description for T203724: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def',.
Sep 6 2018, 11:19 PM · MediaWiki-Change-tagging
mwjames updated subscribers of T203724: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def',.

@Ladsgroup I believe this is caused by one of your changes.

Sep 6 2018, 11:18 PM · MediaWiki-Change-tagging
mwjames created T203724: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def',.
Sep 6 2018, 11:17 PM · MediaWiki-Change-tagging

Mar 30 2018

mwjames added a comment to T188840: 1.31 / TypeError from line 35 of ...\includes\jobqueue\utils\PurgeJobUtils.php: Argument 3 passed to PurgeJobUtils::invalidatePages() must be of the type array, null given, called in ...\includes\deferred\LinksUpdate.php on line 405.

The issue is still pending with 1.31 but somehow I get the feeling no one really cares since it has been open for one month without any feedback.

Mar 30 2018, 11:39 PM · MediaWiki-JobQueue

Mar 3 2018

mwjames created T188840: 1.31 / TypeError from line 35 of ...\includes\jobqueue\utils\PurgeJobUtils.php: Argument 3 passed to PurgeJobUtils::invalidatePages() must be of the type array, null given, called in ...\includes\deferred\LinksUpdate.php on line 405.
Mar 3 2018, 9:29 PM · MediaWiki-JobQueue

Feb 3 2018

mwjames added a comment to T186372: Add extension enabling/disabling support to ExtensionRegistry.

They shouldn't do that.

Feb 3 2018, 1:56 PM · Composer, MediaWiki-Configuration

Jan 8 2018

mwjames added a comment to T178453: CheckComposerLockUpToDate / version check is incorrect and causes "Error: your composer.lock file is not up to date. ...".

I'm not sure what you mean, as extensions aren't supposed to be adding things to core's composer.json.

Jan 8 2018, 4:23 AM · MediaWiki-General, Composer
mwjames added a comment to T178453: CheckComposerLockUpToDate / version check is incorrect and causes "Error: your composer.lock file is not up to date. ...".

From my POV the script is working as it is expected to

Jan 8 2018, 3:43 AM · MediaWiki-General, Composer
mwjames added a comment to T152261: nuke.php and nukeNS.php delete content without updating links tables or running hooks.

We don't close bugs just because they are inactive.

Jan 8 2018, 3:16 AM · MediaWiki-Maintenance-scripts, MediaWiki-Page-deletion
mwjames closed T152261: nuke.php and nukeNS.php delete content without updating links tables or running hooks as Invalid.

Closing due to inactivity (1y+) since it cannot be expected that anything will be done within a reasonable amount of time.

Jan 8 2018, 1:34 AM · MediaWiki-Maintenance-scripts, MediaWiki-Page-deletion
mwjames added a comment to T181926: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats.

I would please ask that you don't try and put words in my mouth.

Jan 8 2018, 12:52 AM · Patch-For-Review, GraphViz
mwjames added a comment to T181926: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats.

please let me know instead of ranting on random tickets (it's mostly coincidence that I saw this on IRC).

Jan 8 2018, 12:08 AM · Patch-For-Review, GraphViz

Jan 3 2018

mwjames added a comment to T174028: Finalize database schema for MCR content meta-data .

[mediawiki/core@master] MCR database schema
https://gerrit.wikimedia.org/r/378724

Jan 3 2018, 1:23 AM · Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1), MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), SDC General, Wikidata

Dec 24 2017

mwjames added a comment to T181926: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats.

GraphViz no longer working ...

Dec 24 2017, 6:55 PM · Patch-For-Review, GraphViz
mwjames added a comment to T181926: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats.

The SRF devs seem dead against supporting extension registration

Dec 24 2017, 6:51 PM · Patch-For-Review, GraphViz
mwjames updated subscribers of T152261: nuke.php and nukeNS.php delete content without updating links tables or running hooks.

@cicalese @MarkAHershberger FYI

Dec 24 2017, 4:09 PM · MediaWiki-Maintenance-scripts, MediaWiki-Page-deletion

Dec 22 2017

mwjames added a comment to T183505: RevisionStore.php Could not determine title for page ID X and revision ID Y in EventBus::createRevisionAttrs.

[mediawiki/core@master] [MCR] Add optional $title param to Revision byId methods
https://gerrit.wikimedia.org/r/399795

Dec 22 2017, 4:47 PM · Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), User-Daniel, Analytics, MediaWiki-General, Event-Platform, Beta-Cluster-reproducible, User-Addshore

Nov 29 2017

mwjames created T181683: SqlBagOStuff::set() fails with "duplicate key value violates unique constraint objectcache_keyname_key" on PostgreSQL.
Nov 29 2017, 9:50 PM · MW-1.31-release, MediaWiki-Cache, PostgreSQL
mwjames created T181682: 1.31.0-alpha / update.php causes Error: 42P07 ERROR: relation "ip_changes_ipc_rev_id_seq" already exists.
Nov 29 2017, 9:15 PM · PostgreSQL
mwjames renamed T181674: 1.31.0-alpha / action=edit causes Error: 42601 ERROR: syntax error at or near ")" LINE 1: ...ent_model FROM "templatelinks" LEFT JOIN ("page" ) from / action=edit causes Error: 42601 ERROR: syntax error at or near ")" LINE 1: ...ent_model FROM "templatelinks" LEFT JOIN ("page" ) to 1.31.0-alpha / action=edit causes Error: 42601 ERROR: syntax error at or near ")" LINE 1: ...ent_model FROM "templatelinks" LEFT JOIN ("page" ).
Nov 29 2017, 8:09 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Patch-For-Review, Wikimedia-Rdbms, PostgreSQL
mwjames created T181674: 1.31.0-alpha / action=edit causes Error: 42601 ERROR: syntax error at or near ")" LINE 1: ...ent_model FROM "templatelinks" LEFT JOIN ("page" ).
Nov 29 2017, 8:09 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Patch-For-Review, Wikimedia-Rdbms, PostgreSQL
mwjames created T181672: 1.31.0-alpha / update.php causes Error: 22007 ERROR: invalid input syntax for type timestamp with time zone: "".
Nov 29 2017, 8:06 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), MediaWiki-General, PostgreSQL
mwjames created T181671: 1.31.0-alpha / Declaration of SpecialRecentChangesLinked::getPageTitle() should be compatible with SpecialPage::getPageTitle.
Nov 29 2017, 8:02 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage, MediaWiki-General

Nov 11 2017

mwjames added a comment to T180143: Composer dependencies of MW 1.29.1 tarball broken.

No. You could check this for yourself very easily

Nov 11 2017, 12:26 PM · MW-1.29-release-notes, MediaWiki-Releasing, MW-1.29-release
mwjames added a comment to T180143: Composer dependencies of MW 1.29.1 tarball broken.

@Reedy Do you think your response in tone is appropriate? I don't think so!

Nov 11 2017, 12:04 PM · MW-1.29-release-notes, MediaWiki-Releasing, MW-1.29-release
mwjames added a comment to T78018: ShortUrl and Semantic Mediawiki conflict.

T104954: ExtensionRegistry / wgExtensionFunctions not treated as array?, SemanticMediaWiki needs to stop registering its hooks in a $wgExtensionFunctions, which is too late. +cc @mwjames.

Nov 11 2017, 9:08 AM · User-Nikerabbit, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), MediaWiki-extensions-ShortUrl
mwjames updated subscribers of T180143: Composer dependencies of MW 1.29.1 tarball broken.

@Kghbln FYI

Nov 11 2017, 8:58 AM · MW-1.29-release-notes, MediaWiki-Releasing, MW-1.29-release

Nov 4 2017

mwjames added a comment to T178453: CheckComposerLockUpToDate / version check is incorrect and causes "Error: your composer.lock file is not up to date. ...".

From my POV the script is working as it is expected to - we only used fixed versions in MediaWiki core's composer.json

Nov 4 2017, 7:03 PM · MediaWiki-General, Composer
mwjames added a comment to T87572: PHP Notice: Undefined offset: 0 in /.../includes/media/FormatMetadata.php on line 1045 .

@Tgr Please can you acknowledge the https://phabricator.wikimedia.org/T87572#3306652 comment from 1 Jul? I do hate it when I waste my time while being on phab and people do not respond!

Nov 4 2017, 7:58 AM · MW-1.29-release-notes, MW-1.27-release-notes, MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Wikimedia-production-error, Commons, MediaWiki-File-management, Multimedia
mwjames added a comment to T178453: CheckComposerLockUpToDate / version check is incorrect and causes "Error: your composer.lock file is not up to date. ...".

Do we need to advertise composer.local.json more prominently in documentation? e.g. in

Nov 4 2017, 7:55 AM · MediaWiki-General, Composer
mwjames added a comment to T179754: Removal of EOL release branches broke SemanticMediaWiki CI.

that was @demon in T92503: Remove EOL MediaWiki release branches i believe.

Nov 4 2017, 7:46 AM · Release-Engineering-Team (Other / Uncategorized), Release-Engineering-Team-TODO, MediaWiki-Releasing
mwjames created T179754: Removal of EOL release branches broke SemanticMediaWiki CI.
Nov 4 2017, 7:33 AM · Release-Engineering-Team (Other / Uncategorized), Release-Engineering-Team-TODO, MediaWiki-Releasing

Oct 18 2017

mwjames updated subscribers of T178453: CheckComposerLockUpToDate / version check is incorrect and causes "Error: your composer.lock file is not up to date. ...".

@Legoktm If time permits please comment on the outlined issue.

Oct 18 2017, 6:45 AM · MediaWiki-General, Composer
mwjames created T178453: CheckComposerLockUpToDate / version check is incorrect and causes "Error: your composer.lock file is not up to date. ...".
Oct 18 2017, 6:44 AM · MediaWiki-General, Composer

Oct 13 2017

mwjames closed T176540: CategoryPage to show additional information at the top? as Resolved.

I'm no longer expecting any response or help from a MW developer on the stated issue but for those who face a similar problem, I added a suggestion that may work for them and is what I understand as community support.

Oct 13 2017, 1:06 AM · MediaWiki-Categories
mwjames added a comment to T177496: Support content delivery from static sources (files) into MediaWiki content for extensions.

An idea, discussed at SMWCon Fall 2017, is to have a mechanism to directly serve the content of static sources (i.e. files) bundled with an extension.

Oct 13 2017, 12:37 AM · MediaWiki-Stakeholders-Group, MediaWiki-extension-requests
mwjames added a comment to T61872: Add mechanism to prevent autoloading of Composer installed extensions via LocalSettings.php.

My understanding is that once MediaWiki complies with (not sure that is the correct terminology) PSR-4, that community will be willing/able to adapt to extension registration.

Oct 13 2017, 12:26 AM · WorkType-NewFunctionality, Composer, MediaWiki-General

Oct 11 2017

mwjames added a comment to T176540: CategoryPage to show additional information at the top?.

No reply. Hence assuming yes.

Oct 11 2017, 2:10 AM · MediaWiki-Categories

Oct 3 2017

mwjames added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

The confusing part here is that Database is logging the internally caught non-error into the debug channel for debugging purposes.

Oct 3 2017, 11:21 PM · MW-1.32-release, PostgreSQL, Wikimedia-Rdbms

Sep 30 2017

mwjames added a comment to T177132: Run MediaWiki tests with PHPUnit 6.

This is more of a status report on running PHPUnit 6.x/PHP 7.1 with MediaWiki since I needed to modify core in order for our tests to pass. Whether the provided information are of interest or value to developers I don't know, I just wanted to disseminate our experience on the related matter.

Sep 30 2017, 8:03 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), PHP 7.1 support, MediaWiki-Core-Testing
mwjames created T177132: Run MediaWiki tests with PHPUnit 6.
Sep 30 2017, 12:24 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), PHP 7.1 support, MediaWiki-Core-Testing

Sep 29 2017

mwjames created T177128: Librarization of HTML and Sanitizer class.
Sep 29 2017, 11:17 PM · Librarization
mwjames added a comment to T177074: Database::upsert: weird behaviour after upgrading to 1.29.x or installing a fresh 1.29.x.

the log file writes are introducing a slight performance hit (not to mention it makes it harder to find actual errors in them)

Sep 29 2017, 4:13 PM · Wikimedia-Rdbms
mwjames updated subscribers of T177074: Database::upsert: weird behaviour after upgrading to 1.29.x or installing a fresh 1.29.x.

ERROR: duplicate key value violates unique constraint "md_module_skin"

Sep 29 2017, 2:41 PM · Wikimedia-Rdbms

Sep 25 2017

mwjames added a comment to T174017: Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".

A quick checkout of the PR confirms that the system no longer produces above listed exceptions.

Sep 25 2017, 1:32 PM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release, Patch-For-Review, MediaWiki-JobQueue, Wikimedia-Rdbms

Sep 23 2017

mwjames created T176540: CategoryPage to show additional information at the top?.
Sep 23 2017, 8:25 AM · MediaWiki-Categories
mwjames added a comment to T174017: Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".

You know how to mark bugs as release blockers, so if there's a regression you've found and want to see it fixed, mark it as a release blocker. :)

Sep 23 2017, 5:59 AM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release, Patch-For-Review, MediaWiki-JobQueue, Wikimedia-Rdbms
mwjames added a comment to T174017: Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".

Do we think that this is going to be fixed in 1.30, given that it has a valid exception stack trace?

Sep 23 2017, 4:44 AM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release, Patch-For-Review, MediaWiki-JobQueue, Wikimedia-Rdbms

Sep 19 2017

mwjames updated the task description for T176209: Future of HHVM, PHP7, and what it means for the MediaWiki software?.
Sep 19 2017, 12:10 PM · MediaWiki-General
mwjames updated the task description for T176209: Future of HHVM, PHP7, and what it means for the MediaWiki software?.
Sep 19 2017, 12:03 PM · MediaWiki-General
mwjames created T176209: Future of HHVM, PHP7, and what it means for the MediaWiki software?.
Sep 19 2017, 11:52 AM · MediaWiki-General

Sep 9 2017

mwjames updated subscribers of T174017: Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".

I was patiently awaiting (two weeks+) this issue to be triaged since this is clearly a regression since 1.29!

Sep 9 2017, 1:39 PM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release, Patch-For-Review, MediaWiki-JobQueue, Wikimedia-Rdbms

Aug 24 2017

mwjames added a comment to T174017: Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".

I reckoned there was a similar issue [0] in the past and I would have expected that a unit test is in place that would prevent such a regression.

Aug 24 2017, 1:04 PM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release, Patch-For-Review, MediaWiki-JobQueue, Wikimedia-Rdbms
mwjames created T174017: Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".
Aug 24 2017, 12:59 PM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release, Patch-For-Review, MediaWiki-JobQueue, Wikimedia-Rdbms

Aug 19 2017

mwjames added a comment to T43720: DISPLAYTITLE of a page not applied on the page itself for page title and category headers.

So, what is the status of this patch, issue?

Aug 19 2017, 1:26 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Categories

Aug 12 2017

mwjames added a comment to T172845: What makes a high quality MediaWiki extension? - Hackathon session.

I don't think there is an established convention and most extensions actually just use <extensionname> but IMO using MediaWiki\Extensions\... follows from the PSR-4 recommendation that namespaces

Aug 12 2017, 8:53 AM · MediaWiki-extensions-General, Wikimania-Hackathon-2017

Aug 5 2017

mwjames added a comment to T109652: Ex:SMW Special:SMWAdmin vulnerable to csrf.

do you want some time to do an announcement/anything of that nature first?

Aug 5 2017, 7:37 AM · Vuln-CSRF, Security-Extensions, Security
mwjames added a comment to T109652: Ex:SMW Special:SMWAdmin vulnerable to csrf.

since that page disables the OutputPage for some commands and does not set a cache-control header, if this is used in an environment where autocreation can happen, an attacker might be able to cause an admin's session id to be cached

Aug 5 2017, 1:41 AM · Vuln-CSRF, Security-Extensions, Security
mwjames added a comment to T172146: Remove unchecked calls to Title::getTalkPage from extensions.

See https://github.com/search?q=org%3ASemanticMediaWiki+getTalkPage+&type=Code

Aug 5 2017, 1:25 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Google-Code-in-2018, Technical-Debt, MediaWiki-extensions-General, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, MediaWiki-General

Jul 29 2017

mwjames updated the task description for T172028: Visibility change to CategoryPage::mCategoryViewerClass breaks extension.
Jul 29 2017, 6:01 AM · MW-1.30-release-notes, MediaWiki-Categories, MW-1.30-release, MediaWiki-extensions-General
mwjames updated the task description for T172028: Visibility change to CategoryPage::mCategoryViewerClass breaks extension.
Jul 29 2017, 5:47 AM · MW-1.30-release-notes, MediaWiki-Categories, MW-1.30-release, MediaWiki-extensions-General
mwjames updated subscribers of T172028: Visibility change to CategoryPage::mCategoryViewerClass breaks extension.

@Legoktm It would be marvellous if could take a peek at this.

Jul 29 2017, 12:42 AM · MW-1.30-release-notes, MediaWiki-Categories, MW-1.30-release, MediaWiki-extensions-General
mwjames created T172028: Visibility change to CategoryPage::mCategoryViewerClass breaks extension.
Jul 29 2017, 12:41 AM · MW-1.30-release-notes, MediaWiki-Categories, MW-1.30-release, MediaWiki-extensions-General

Jul 13 2017

mwjames added a comment to T166856: Title::invalidateCache() called on GET request (TransactionProfiler warns about writes).

On what url did this happen?

Jul 13 2017, 4:29 AM · MediaWiki-Cache
mwjames created T170512: InvalidArgumentException from line 1060 of WikiPage.php: "The supplied ParserOptions are not safe to ...".
Jul 13 2017, 4:17 AM · MediaWiki-Parser

Jul 8 2017

mwjames created T170030: Bring back Database::setTransactionProfiler.
Jul 8 2017, 12:39 AM · Wikimedia-Rdbms
mwjames added a comment to T167942: Database::upsert() for Postgres triggers an (ignored) error, by design.

Did that not work?

Jul 8 2017, 12:19 AM · MW-1.32-release, PostgreSQL, Wikimedia-Rdbms
mwjames added a comment to T153271: Release MediaWiki 1.29.

... rc.1 has been released like 10 minutes ago, but it'll make it into the final release.

Jul 8 2017, 12:05 AM · RelEng-Archive-FY201718-Q1, releng-201617-q4, MW-1.29-release, MediaWiki-General, Release
mwjames added a comment to T167946: SqlBagOStuff for PostgreSQL should not re-use main connection.

In which case, I suggest those driving the patch press the cherry-pick button and get a patch up for review on the target branch.

Jul 8 2017, 12:03 AM · MW-1.29-release-notes, MW-1.29-release, Performance-Team, PostgreSQL, MediaWiki-Cache, Wikimedia-Rdbms

Jul 7 2017

mwjames added a comment to T153271: Release MediaWiki 1.29.

All blockers are now resolved.

Jul 7 2017, 11:58 PM · RelEng-Archive-FY201718-Q1, releng-201617-q4, MW-1.29-release, MediaWiki-General, Release

Jul 6 2017

mwjames added a comment to T154424: TransactionProfiler should not apply to SqlBagOStuff.

With reference to https://gerrit.wikimedia.org/r/363727 and the comment "... should fix warnings about TransactionProfiler in objectcache...", it does NOT as it can be seen from the log output:

Jul 6 2017, 11:30 PM · Patch-For-Review, MW-1.29-release-notes, MediaWiki-Cache, Wikimedia-Rdbms
mwjames updated subscribers of T167946: SqlBagOStuff for PostgreSQL should not re-use main connection.

This was adopted in fda4d46fc4f810, ...
https://gerrit.wikimedia.org/r/363727

Jul 6 2017, 11:20 PM · MW-1.29-release-notes, MW-1.29-release, Performance-Team, PostgreSQL, MediaWiki-Cache, Wikimedia-Rdbms
mwjames added a comment to T154424: TransactionProfiler should not apply to SqlBagOStuff.

This isn't just PostgreSQL, it applies to MySQL too.

Jul 6 2017, 11:14 PM · Patch-For-Review, MW-1.29-release-notes, MediaWiki-Cache, Wikimedia-Rdbms
mwjames added a comment to T167946: SqlBagOStuff for PostgreSQL should not re-use main connection.

... specific to PostgreSQL, but after failing to reproduce the premise, Aaron pointed out "pg" in the wiki name.

Jul 6 2017, 11:03 PM · MW-1.29-release-notes, MW-1.29-release, Performance-Team, PostgreSQL, MediaWiki-Cache, Wikimedia-Rdbms
Krinkle awarded T167946: SqlBagOStuff for PostgreSQL should not re-use main connection a Orange Medal token.
Jul 6 2017, 10:50 PM · MW-1.29-release-notes, MW-1.29-release, Performance-Team, PostgreSQL, MediaWiki-Cache, Wikimedia-Rdbms

Jun 29 2017

mwjames added a comment to T168207: MysqlDatabaseBase::tableExists returns wrong results because method tableName returns the table name prefixed with the database if the table is a shared table.

Which tests specifically fail for you?

Jun 29 2017, 12:40 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Wikimedia-Rdbms

Jun 26 2017

mwjames added a comment to T168207: MysqlDatabaseBase::tableExists returns wrong results because method tableName returns the table name prefixed with the database if the table is a shared table.

Doing a quick var_dump on $encLike = $this->escapeLikeInternal( $table, '\\' ); reveals that before the PR it would return "unittest\_archive" and now after the change it contains "unittest\_unittest\_archive".

Jun 26 2017, 3:58 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Wikimedia-Rdbms
mwjames added a comment to T168207: MysqlDatabaseBase::tableExists returns wrong results because method tableName returns the table name prefixed with the database if the table is a shared table.

This change just broke all of our integration tests with:

Jun 26 2017, 1:50 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Wikimedia-Rdbms

Jun 20 2017

mwjames updated subscribers of T168347: DeferredUpdates hides exceptions.

@Seb35 Maybe something you want to have look at a convenient time?

Jun 20 2017, 9:35 PM · MW-1.30-release-notes, MW-1.29-release-notes, MediaWiki-Debug-Logger, Patch-For-Review, MW-1.29-release, Wikimedia-Rdbms
mwjames added a comment to T168398: Semantic Glossary and SMW 2.5.x.

So this is probably some incompatibliity with Semantic Glossary and SMW 2.5?

Jun 20 2017, 1:22 PM · MediaWiki-extensions-Semantic-Glossary

Jun 19 2017

mwjames created T168347: DeferredUpdates hides exceptions.
Jun 19 2017, 10:55 PM · MW-1.30-release-notes, MW-1.29-release-notes, MediaWiki-Debug-Logger, Patch-For-Review, MW-1.29-release, Wikimedia-Rdbms
mwjames updated subscribers of T168337: PHP Fatal error: Uncaught Error: Call to a member function canExist() on null.

@demon FYI

Jun 19 2017, 8:31 PM · RelEng-Archive-FY201718-Q1, MW-1.28-release-notes, MW-1.30-release-notes, MW-1.29-release-notes, Patch-For-Review, MediaWiki-General, MW-1.29-release
mwjames created T168337: PHP Fatal error: Uncaught Error: Call to a member function canExist() on null.
Jun 19 2017, 8:30 PM · RelEng-Archive-FY201718-Q1, MW-1.28-release-notes, MW-1.30-release-notes, MW-1.29-release-notes, Patch-For-Review, MediaWiki-General, MW-1.29-release

Jun 15 2017

mwjames added a comment to T154424: TransactionProfiler should not apply to SqlBagOStuff.

I think the method of injecting TransactionProfilers needs refactoring to make this more flexible, and given that this warning is mainly intended for developers I don't think it should be a release blocker (since it's not trivial to fix).

Jun 15 2017, 2:56 PM · Patch-For-Review, MW-1.29-release-notes, MediaWiki-Cache, Wikimedia-Rdbms
mwjames added a comment to T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti.

Normally, I would use redis but this time around for testing I just used the vanilla setup that comes with SqlBagOStuff out of the box hence the increased log output.

Jun 15 2017, 2:48 PM · MediaWiki-Cache, Wikimedia-Rdbms
mwjames added a comment to T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti.

or the cost of writing to a file on the server-side?

Jun 15 2017, 2:43 PM · MediaWiki-Cache, Wikimedia-Rdbms
mwjames added a comment to T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti.

Also nothing is thrown here, there is no PHP "exception". Rather it's a debug log message (severity=INFO) that is hidden by default and (for easier debugging) includes a manually created stack trace.

Jun 15 2017, 2:37 PM · MediaWiki-Cache, Wikimedia-Rdbms
mwjames created T167946: SqlBagOStuff for PostgreSQL should not re-use main connection.
Jun 15 2017, 9:15 AM · MW-1.29-release-notes, MW-1.29-release, Performance-Team, PostgreSQL, MediaWiki-Cache, Wikimedia-Rdbms
mwjames added a comment to T149454: 1.28-alpha / Error: 42P01 ERROR: table "unittest_user_groups" does not exist.

@mwjames can you confirm that everything here works now please?

Jun 15 2017, 9:06 AM · RelEng-Archive-FY201718-Q1, MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Patch-For-Review, MW-1.29-release, PostgreSQL, Regression, MediaWiki-Core-Testing, Wikimedia-Rdbms
mwjames updated subscribers of T167927: 1.30.0-alpha / DatabasePostgres throws "Expected mass rollback of all peer databases (DBO_TRX set)".

I was able to confirm that this fixes the reported issue and I'm able to run our integration tests without major interruptions.

Jun 15 2017, 9:03 AM · Performance-Team, MW-1.30-release-notes, MW-1.29-release-notes, PostgreSQL, Wikimedia-Rdbms
mwjames updated subscribers of T167941: TransactionProfiler throws a "Expectation ..." on SqlBagOStuff::setMulti.

@Krinkle As for the last stack trace, it happens on each edit and causes a significant lag during a save action.

Jun 15 2017, 8:48 AM · MediaWiki-Cache, Wikimedia-Rdbms
mwjames created T167943: 1.30.0-alpha / Postgres causes "PHP Notice: A non well formed numeric value encountered" on Title::getTouched.
Jun 15 2017, 8:41 AM · MediaWiki-General, PostgreSQL