Page MenuHomePhabricator

nnikkhoui (Nikki Nikkhoui)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2019, 8:40 PM (120 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
NNikkhoui (WMF) [ Global Accounts ]

Recent Activity

Thu, Jan 20

nnikkhoui moved T296671: MediaWiki REST API Search results should resolve redirects from Work In Progress to QA/Review on the API Platform board.
Thu, Jan 20, 4:01 PM · Patch-For-Review, MediaWiki-REST-API, API Platform, Desktop Improvements, WVUI
nnikkhoui moved T293361: Pre-Mortem from Work In Progress to Done on the API Platform board.
Thu, Jan 20, 3:35 PM · API Platform

Tue, Jan 18

nnikkhoui moved T296671: MediaWiki REST API Search results should resolve redirects from Ready/Groomed to Work In Progress on the API Platform board.
Tue, Jan 18, 5:16 PM · Patch-For-Review, MediaWiki-REST-API, API Platform, Desktop Improvements, WVUI

Thu, Jan 13

nnikkhoui claimed T296671: MediaWiki REST API Search results should resolve redirects.
Thu, Jan 13, 5:25 PM · Patch-For-Review, MediaWiki-REST-API, API Platform, Desktop Improvements, WVUI

Tue, Jan 11

nnikkhoui added a comment to T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL.

I just checked again and looks like the checkbox was hidden after this ticket was created in this patch by @Tgr this past August.

Tue, Jan 11, 10:02 PM · API Platform, Platform Team Workboards (Clinic Duty Team), Documentation, MediaWiki-extensions-OAuth
nnikkhoui added a comment to T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL.

@bd808 i tinkered with this a little, and I think the actual issue might be actually related to T297888. When I create an OAuth 2.0 client, the grant types are not being saved to the database (as is described in T297888) and I receive the same error you noted. However, when I hack around the UI to get the grant types to actually save to the database and then I supply a redirect uri that does not match that which i initially registered with, I do in fact get a specific error message with the attribute: hint: Invalid redirect URI.

Tue, Jan 11, 9:21 PM · API Platform, Platform Team Workboards (Clinic Duty Team), Documentation, MediaWiki-extensions-OAuth

Mon, Jan 10

nnikkhoui added a comment to T293361: Pre-Mortem.

Link to the Pre-Mortem post-survey results

Mon, Jan 10, 6:42 PM · API Platform
nnikkhoui claimed T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL.
Mon, Jan 10, 1:51 PM · API Platform, Platform Team Workboards (Clinic Duty Team), Documentation, MediaWiki-extensions-OAuth
nnikkhoui moved T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL from Ready/Groomed to Work In Progress on the API Platform board.
Mon, Jan 10, 1:50 PM · API Platform, Platform Team Workboards (Clinic Duty Team), Documentation, MediaWiki-extensions-OAuth

Fri, Jan 7

nnikkhoui added a comment to T292195: Unable to create user in Trove postgres DB.

@Andrew Ok cool - yes I was able to go through the psql command line to create the user instead! However I ran into another problem when doing so. When I tried to connect via cli, I realized I needed to actually specify the database name, but I'm unable to create a database in the horizon UI (I get a similar error as the one when trying to create a User). It took me longer than I would have liked haha to realized the default database is postgres and eventually was able to connect to create a database and a new user.

Fri, Jan 7, 4:58 PM · cloud-services-team (Kanban), Cloud-VPS
nnikkhoui added a comment to T298628: Account recovery help needed for Developer account Nikki Nikkhoui.

thanks @bd808 !

Fri, Jan 7, 1:43 PM · User-bd808, wikitech.wikimedia.org, Trust-and-Safety, cloud-services-team (Kanban)

Wed, Jan 5

nnikkhoui added a comment to T298628: Account recovery help needed for Developer account Nikki Nikkhoui.

@bd808 apologies - forgot to finish that last part.
bastion-eqiad1-01.bastion.eqiad.wmflabs:/home/nikkin/2fa-reset-request.txt

Wed, Jan 5, 5:00 PM · User-bd808, wikitech.wikimedia.org, Trust-and-Safety, cloud-services-team (Kanban)
nnikkhoui created T298628: Account recovery help needed for Developer account Nikki Nikkhoui.
Wed, Jan 5, 4:34 PM · User-bd808, wikitech.wikimedia.org, Trust-and-Safety, cloud-services-team (Kanban)

Dec 21 2021

nnikkhoui created T298123: Ensure "Try it Out" button works .
Dec 21 2021, 7:12 PM · API Platform

Dec 18 2021

nnikkhoui closed T297955: Upgrade php image to stretch/php74-fpm as Resolved.

oh wow i completely missed that section of the documentation! thank you! closing :)

Dec 18 2021, 1:52 AM · mwcli

Dec 17 2021

nnikkhoui created T297955: Upgrade php image to stretch/php74-fpm.
Dec 17 2021, 3:37 PM · mwcli

Dec 16 2021

nnikkhoui moved T293821: Create local command to generate API description from Work In Progress to Done on the API Platform board.
Dec 16 2021, 6:16 PM · API Platform
nnikkhoui updated the task description for T293821: Create local command to generate API description.
Dec 16 2021, 6:16 PM · API Platform
nnikkhoui moved T293821: Create local command to generate API description from Done to Work In Progress on the API Platform board.
Dec 16 2021, 4:57 PM · API Platform
nnikkhoui updated the task description for T293821: Create local command to generate API description.
Dec 16 2021, 4:57 PM · API Platform
nnikkhoui moved T293821: Create local command to generate API description from Work In Progress to Done on the API Platform board.
Dec 16 2021, 4:57 PM · API Platform
nnikkhoui committed rMSENb99a82159f2f: Use servicelib-node/spec to generate OpenAPI spec (authored by nnikkhoui).
Use servicelib-node/spec to generate OpenAPI spec
Dec 16 2021, 4:39 PM

Dec 14 2021

nnikkhoui moved T293361: Pre-Mortem from Ready/Groomed to Work In Progress on the API Platform board.
Dec 14 2021, 4:21 PM · API Platform

Dec 13 2021

nnikkhoui committed rMSLN18e6bc74f054: Patch version 1.0.1 (authored by nnikkhoui).
Patch version 1.0.1
Dec 13 2021, 6:09 PM

Dec 11 2021

nnikkhoui committed rMSLN69857d99e710: Reformat JSON for spec.json file (authored by nnikkhoui).
Reformat JSON for spec.json file
Dec 11 2021, 6:38 PM

Dec 10 2021

nnikkhoui closed T295994: setup servicelib-node/spec in CI and NPM as Resolved.
Dec 10 2021, 7:16 PM · Patch-For-Review, API Platform
nnikkhoui closed T295994: setup servicelib-node/spec in CI and NPM, a subtask of T293821: Create local command to generate API description, as Resolved.
Dec 10 2021, 7:16 PM · API Platform
nnikkhoui committed rMSLN659dbac80aac: Cleanup servicelib-node package.json(s) (authored by nnikkhoui).
Cleanup servicelib-node package.json(s)
Dec 10 2021, 4:21 PM

Dec 7 2021

nnikkhoui committed rMSLNe4b574f22590: Add Changelog (authored by nnikkhoui).
Add Changelog
Dec 7 2021, 3:49 AM

Dec 6 2021

nnikkhoui updated subscribers of T293358: Ask, “Who are we leaving out?”.

[Copied from slack thread on this topic]

Dec 6 2021, 6:43 PM · API Platform

Dec 3 2021

nnikkhoui committed rMSLNce90509bea09: Prep servicelib-node/spec for npm publish (authored by nnikkhoui).
Prep servicelib-node/spec for npm publish
Dec 3 2021, 4:40 PM
nnikkhoui committed rMSLN7c52b0f3f56c: New servicelib-node "spec" package (authored by nnikkhoui).
New servicelib-node "spec" package
Dec 3 2021, 3:49 PM

Nov 29 2021

nnikkhoui updated subscribers of T296088: Create JSDoc yaml linter in servicelib-node/spec.

@BPirkle and I discussed where in the development process it would make sense to do the linting/formatting. Ideally we would do the linting as early on in the process as possible.

Nov 29 2021, 9:33 PM · API Platform
nnikkhoui moved T296088: Create JSDoc yaml linter in servicelib-node/spec from Backlog to Investigate on the API Platform board.
Nov 29 2021, 7:50 PM · API Platform

Nov 28 2021

nnikkhoui committed rMSISb725f23e2d93: Add data refresh/deploy instructions (authored by nnikkhoui).
Add data refresh/deploy instructions
Nov 28 2021, 9:03 PM

Nov 23 2021

nnikkhoui updated the task description for T295994: setup servicelib-node/spec in CI and NPM.
Nov 23 2021, 7:14 PM · Patch-For-Review, API Platform
nnikkhoui moved T295994: setup servicelib-node/spec in CI and NPM from Backlog to Work In Progress on the API Platform board.
Nov 23 2021, 7:14 PM · Patch-For-Review, API Platform
nnikkhoui closed T295326: Add an image: Refresh API data, a subtask of T295316: Add an image: pre-deployment model refresh, as Resolved.
Nov 23 2021, 6:02 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Discovery-Search (Current work), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
nnikkhoui closed T295326: Add an image: Refresh API data as Resolved.
Nov 23 2021, 6:02 PM · Image-Suggestion-API, Discovery, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
nnikkhoui updated the task description for T295326: Add an image: Refresh API data.
Nov 23 2021, 5:40 PM · Image-Suggestion-API, Discovery, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Nov 22 2021

nnikkhoui committed rMSLNe4b176ddbb75: Add config.yaml for CI (authored by nnikkhoui).
Add config.yaml for CI
Nov 22 2021, 11:10 PM

Nov 19 2021

nnikkhoui created T296088: Create JSDoc yaml linter in servicelib-node/spec.
Nov 19 2021, 2:42 PM · API Platform

Nov 18 2021

nnikkhoui committed rMSLNb7614f99709a: Add spec blubber.yaml (authored by nnikkhoui).
Add spec blubber.yaml
Nov 18 2021, 8:08 PM
nnikkhoui created T295994: setup servicelib-node/spec in CI and NPM.
Nov 18 2021, 4:13 PM · Patch-For-Review, API Platform

Nov 17 2021

nnikkhoui committed rMSIS68f16994ade1: Convert modules to class syntax (authored by nnikkhoui).
Convert modules to class syntax
Nov 17 2021, 8:44 PM

Nov 10 2021

nnikkhoui added a comment to T293823: [SPIKE] Investigate Backstage's ability to apply transformations .

@dduvall ok so, had a little "feel a little dumb" moment becaue your initial thoughts to push back on this were on point:

Nov 10 2021, 4:37 PM · API Platform

Nov 9 2021

nnikkhoui claimed T293361: Pre-Mortem.
Nov 9 2021, 8:36 PM · API Platform
nnikkhoui updated subscribers of T293361: Pre-Mortem.

@sdkim @BPirkle @codebug according to the toolkit,

Nov 9 2021, 2:23 PM · API Platform

Nov 3 2021

nnikkhoui committed rMSISe6711be575a2: Add index to row_num_ima (authored by nnikkhoui).
Add index to row_num_ima
Nov 3 2021, 9:04 PM
nnikkhoui closed T294667: [SPIKE] Experiment with Backstage custom integration with integration.wikimedia.org as Resolved.

@dduvall awesome I think this will work great, thank you Dan!

Nov 3 2021, 1:54 PM · API Platform
nnikkhoui closed T294667: [SPIKE] Experiment with Backstage custom integration with integration.wikimedia.org, a subtask of T293823: [SPIKE] Investigate Backstage's ability to apply transformations , as Resolved.
Nov 3 2021, 1:54 PM · API Platform
nnikkhoui added a comment to T273236: For a given page, list the image suggestions.

@Tgr After i posted that comment i did end up indexing all the language tables, so those 4 should also be just as fast as well, so no need to omit the source filter!

Nov 3 2021, 1:42 PM · Image-Suggestion-API, Image-Suggestions, Platform Team Workboards (Image Suggestion API)

Nov 2 2021

nnikkhoui added a comment to T273236: For a given page, list the image suggestions.

@Tgr Can you confirm its more performant now? I think it should be! (for enwiki queries)

Nov 2 2021, 2:21 PM · Image-Suggestion-API, Image-Suggestions, Platform Team Workboards (Image Suggestion API)
nnikkhoui added a comment to T273236: For a given page, list the image suggestions.

@Tgr Re: metrics, in my conversations with the cloud team I deduced that there was no way to publish metrics as of now because the API is hosted in a non-prod environment (cloud vps) and not under the deployment-prep project (which I believe is the only non-prod project able to publish metrics).

Nov 2 2021, 1:56 PM · Image-Suggestion-API, Image-Suggestions, Platform Team Workboards (Image Suggestion API)
nnikkhoui updated the task description for T293361: Pre-Mortem.
Nov 2 2021, 12:43 AM · API Platform

Nov 1 2021

nnikkhoui added a comment to T294667: [SPIKE] Experiment with Backstage custom integration with integration.wikimedia.org.

@dduvall Since we need to authenticate with Jenkins for read access to the build artifacts (https://integration.wikimedia.org/ci/job/mathoid-pipeline-test/lastSuccessfulBuild/execution/node/3/ws/openapi.spec.yaml/*view*/) im looking into how best to do authentication with an external app (our instance of Backstage). would it be something like this? https://www.jenkins.io/doc/book/system-administration/authenticating-scripted-clients/ using a service account + token ?

Nov 1 2021, 3:32 PM · API Platform
nnikkhoui moved T294667: [SPIKE] Experiment with Backstage custom integration with integration.wikimedia.org from Backlog to Work In Progress on the API Platform board.
Nov 1 2021, 1:37 PM · API Platform

Oct 29 2021

nnikkhoui created T294667: [SPIKE] Experiment with Backstage custom integration with integration.wikimedia.org.
Oct 29 2021, 8:50 PM · API Platform
nnikkhoui added a comment to T293823: [SPIKE] Investigate Backstage's ability to apply transformations .

@dduvall awesome thanks for putting the example together! A couple clarifications:

Oct 29 2021, 8:04 PM · API Platform
nnikkhoui added a comment to T293823: [SPIKE] Investigate Backstage's ability to apply transformations .

@dduvall

By "a script to re-generate the openapi spec" do you mean for each service repo, or is this a central repo somewhere? Can you link me to an example?

Oct 29 2021, 1:50 PM · API Platform

Oct 27 2021

nnikkhoui added a comment to T293823: [SPIKE] Investigate Backstage's ability to apply transformations .

@dduvall I appreciate the ask for background info! We want what seems most similar to the first "pre-merge generation" bullet, with a slight difference. We want a script to re-generate the openapi spec before the patch is merged (just as the bullet states). The script would take JSDoc function annotations > bundle and transform those into a single open api spec file.

Oct 27 2021, 8:13 PM · API Platform

Oct 26 2021

nnikkhoui added a comment to T294300: "promote" step failure with multiple users per email.

that was so quick, thank you @dduvall !

Oct 26 2021, 6:25 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Release Pipeline
nnikkhoui committed rMSISf9af41019b5e: Update README deployment (authored by nnikkhoui).
Update README deployment
Oct 26 2021, 12:30 AM

Oct 25 2021

nnikkhoui created T294300: "promote" step failure with multiple users per email.
Oct 25 2021, 7:33 PM · Release-Engineering-Team (Done by Thu 04 Nov 🧟), Release Pipeline
nnikkhoui added a comment to T292154: Image Suggestions API: Support querying by title.

@Tgr deployed!

Oct 25 2021, 6:33 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, Growth-Team (Current Sprint), Platform Engineering, Image-Suggestion-API
nnikkhoui moved T293821: Create local command to generate API description from Ready/Groomed to Work In Progress on the API Platform board.
Oct 25 2021, 2:56 PM · API Platform
nnikkhoui claimed T293821: Create local command to generate API description.
Oct 25 2021, 2:56 PM · API Platform

Oct 22 2021

nnikkhoui added a comment to T293823: [SPIKE] Investigate Backstage's ability to apply transformations .

oh ok! In that case I'm wondering if we could create another job that would publish these ephemeral artifacts to a repository, instead of leaving them there to get garbage collected. Is that possible at all, or do you think thats even a good idea...haha

Oct 22 2021, 5:52 PM · API Platform
nnikkhoui updated the task description for T293823: [SPIKE] Investigate Backstage's ability to apply transformations .
Oct 22 2021, 5:19 PM · API Platform
nnikkhoui updated subscribers of T293823: [SPIKE] Investigate Backstage's ability to apply transformations .

@thcipriani as part of this work, we were hoping to have CI generate an OpenAPI spec as a .yaml file, and publish that artifact to some repository (gitlab or github perhaps). You mentioned to @sdkim that CI doesn't publish artifacts other than docker images, but i was wondering the workflow for things like these, and the difference between these and generating something like a new .yaml file?

Oct 22 2021, 5:07 PM · API Platform

Oct 21 2021

nnikkhoui created T294047: Ensure mocha tests fail on timeout.
Oct 21 2021, 5:38 PM · Image-Suggestion-API
nnikkhoui added a comment to T284329: [SPIKE] Investigate potential solutions for canonical service catalog.

3 ways to add components to Backstage:

Oct 21 2021, 4:40 PM · API Platform
nnikkhoui updated subscribers of T292763: CVE-2021-44854: Rest API incorrectly publicly caches results from private wikis.
Oct 21 2021, 12:23 PM · MW-1.37-notes, MW-1.36-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), SecTeam-Processed, Vuln-Infoleak, API Platform, SRE, Platform Engineering, MediaWiki-REST-API, Desktop Improvements, Vector, Security, Security-Team
nnikkhoui added a comment to T292763: CVE-2021-44854: Rest API incorrectly publicly caches results from private wikis.

@Legoktm oh yikes, it wasn't handled as a security bug for the sole reason that this was my first one and had not realized there was a specific way to handle those in Gerrit (I actually do recall @Pchelolo mentioned something but it slipped my mind before i uploaded -_-) will educate myself on how for future security bugs.
I think you are right, basically anything that uses that search endpoint (which i think(?) is just new Vector with the vue.js search widget)

Oct 21 2021, 12:21 PM · MW-1.37-notes, MW-1.36-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), SecTeam-Processed, Vuln-Infoleak, API Platform, SRE, Platform Engineering, MediaWiki-REST-API, Desktop Improvements, Vector, Security, Security-Team

Oct 20 2021

nnikkhoui moved T292763: CVE-2021-44854: Rest API incorrectly publicly caches results from private wikis from QA/Review to Done on the API Platform board.
Oct 20 2021, 7:55 PM · MW-1.37-notes, MW-1.36-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), SecTeam-Processed, Vuln-Infoleak, API Platform, SRE, Platform Engineering, MediaWiki-REST-API, Desktop Improvements, Vector, Security, Security-Team

Oct 19 2021

nnikkhoui updated the task description for T293825: API description generated in CI.
Oct 19 2021, 8:30 PM · API Platform
nnikkhoui created T293825: API description generated in CI.
Oct 19 2021, 8:29 PM · API Platform
nnikkhoui updated the task description for T284329: [SPIKE] Investigate potential solutions for canonical service catalog.
Oct 19 2021, 8:18 PM · API Platform
nnikkhoui moved T293823: [SPIKE] Investigate Backstage's ability to apply transformations from Backlog to Investigate on the API Platform board.
Oct 19 2021, 8:18 PM · API Platform
nnikkhoui created T293823: [SPIKE] Investigate Backstage's ability to apply transformations .
Oct 19 2021, 8:17 PM · API Platform
nnikkhoui moved T292763: CVE-2021-44854: Rest API incorrectly publicly caches results from private wikis from Work In Progress to QA/Review on the API Platform board.
Oct 19 2021, 5:45 PM · MW-1.37-notes, MW-1.36-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), SecTeam-Processed, Vuln-Infoleak, API Platform, SRE, Platform Engineering, MediaWiki-REST-API, Desktop Improvements, Vector, Security, Security-Team
nnikkhoui added a comment to T293799: Backstage does not load on Safari.

Seems like the issue was raised in a dependent package that is the one causing the issue: https://github.com/IonicaBizau/parse-url/issues/32

Oct 19 2021, 5:39 PM · Browser-Support-Apple-Safari, API Platform
nnikkhoui moved T293799: Backstage does not load on Safari from Backlog to Investigate on the API Platform board.
Oct 19 2021, 3:24 PM · Browser-Support-Apple-Safari, API Platform
nnikkhoui created T293799: Backstage does not load on Safari.
Oct 19 2021, 3:24 PM · Browser-Support-Apple-Safari, API Platform

Oct 18 2021

nnikkhoui updated subscribers of T265927: Refactor package.json.

@Jdlrobson makes sense to me, thank you for cleaning this up. Anything 1 year old isn't show stopping :)

Oct 18 2021, 9:16 PM · Vector (Vector (Tracking))

Oct 14 2021

nnikkhoui created T293413: Translate Example Node API JSDoc to OpenAPI spec.
Oct 14 2021, 7:25 PM · API Platform
nnikkhoui updated the task description for T293412: Add JSdoc to Example Node API.
Oct 14 2021, 7:21 PM · API Platform
nnikkhoui created T293412: Add JSdoc to Example Node API.
Oct 14 2021, 7:21 PM · API Platform
nnikkhoui added a comment to T284329: [SPIKE] Investigate potential solutions for canonical service catalog.

One idea of workflow of how to go from Node API Development > pubblished docs on Backstage:

Oct 14 2021, 4:35 PM · API Platform
nnikkhoui closed T293364: Identify partners, a subtask of T293353: DEI in API Platform, as Declined.
Oct 14 2021, 1:20 PM · API Platform (Product Roadmap), Epic
nnikkhoui closed T293364: Identify partners as Declined.
Oct 14 2021, 1:20 PM · API Platform
nnikkhoui created T293364: Identify partners.
Oct 14 2021, 1:19 PM · API Platform
nnikkhoui created T293362: Iterate on plan based on risks identified in Pre-mortem .
Oct 14 2021, 1:06 PM · API Platform
nnikkhoui updated the task description for T293361: Pre-Mortem.
Oct 14 2021, 1:03 PM · API Platform
nnikkhoui created T293361: Pre-Mortem.
Oct 14 2021, 1:02 PM · API Platform
nnikkhoui created T293360: Set explicit DEI OKRs.
Oct 14 2021, 1:02 PM · API Platform
nnikkhoui created T293358: Ask, “Who are we leaving out?”.
Oct 14 2021, 1:01 PM · API Platform
nnikkhoui created T293357: Set explicit accessibility goals.
Oct 14 2021, 12:55 PM · API Platform
nnikkhoui removed a project from T293355: Welcoming Diverse Opinions: Epic.
Oct 14 2021, 12:54 PM · API Platform
nnikkhoui created T293356: Explicitly discuss DEI as part of the plan .
Oct 14 2021, 12:53 PM · API Platform