Page MenuHomePhabricator

nnikkhoui (Nikki Nikkhoui)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2019, 8:40 PM (43 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
NNikkhoui (WMF) [ Global Accounts ]

Recent Activity

Today

nnikkhoui created T259720: Allow IP Ranges in User Contributions REST endpoint.
Wed, Aug 5, 4:03 PM · MediaWiki-REST-API, Platform Team Workboards (Green)
nnikkhoui created T259680: User Contributions endpoints: rename "name" parameter to "user" .
Wed, Aug 5, 3:19 AM · Patch-For-Review, Platform Team Workboards (Green)

Thu, Jul 30

nnikkhoui added a comment to T235073: Moderator gets user contributions.

@eprodromou Do you have any objection to me renaming the 'name' path param to 'user'? It makes more sense with how the backend is refactored now, but from an end user perspective I think it also makes more sense for the case of passing in an ip address, as thats more of a 'user' than a name.

Thu, Jul 30, 8:22 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Wed, Jul 29

nnikkhoui added a project to T259145: UserDef DI: Dependency injection.
Wed, Jul 29, 4:11 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, Dependency injection, Platform Team Workboards (Green)
nnikkhoui triaged T259145: UserDef DI as Medium priority.
Wed, Jul 29, 4:11 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, Dependency injection, Platform Team Workboards (Green)
nnikkhoui moved T259145: UserDef DI from Backlog to Doing on the Platform Team Workboards (Green) board.
Wed, Jul 29, 4:10 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, Dependency injection, Platform Team Workboards (Green)
nnikkhoui created T259145: UserDef DI.
Wed, Jul 29, 4:10 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, Dependency injection, Platform Team Workboards (Green)
nnikkhoui moved T251805: Contributor gets own contribution count from Doing to User Story Review on the Platform Team Workboards (Green) board.
Wed, Jul 29, 3:14 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Fri, Jul 24

nnikkhoui created T258830: Security Issue Access Request for nnikkhoui.
Fri, Jul 24, 7:55 PM · Security-Team, Security

Wed, Jul 22

nnikkhoui created T258665: Add NAME constant to hook interfaces.
Wed, Jul 22, 11:52 PM · MediaWiki-Core-Hooks, Platform Team Initiatives (New Hook System)
nnikkhoui added a comment to T251805: Contributor gets own contribution count.

wow ok your due diligence has uncovered that yes I think we just forgot to implement that one....theres no route for it and the user in UserContributionsCount defaults to "me". @daniel I can work on that one now. It shouldn't take too long.

Wed, Jul 22, 7:47 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui added a comment to T251803: Contributor gets own contributions by tag.

@apaskulin Users (i think only admins) can create custom tags. I believe a fresh install of mediawiki comes with no predefined tags, but there might be some jobs or something that create standard tags (because i see a few that pop up when I run the integration tests and look at what tags are stored in the database)

Wed, Jul 22, 7:41 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Platform Team Workboards (Green), Story, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui created T258555: Remove usage of explicitly setting $wgHooks in tests.
Wed, Jul 22, 5:54 AM · Platform Team Initiatives (New Hook System)

Tue, Jul 21

nnikkhoui moved T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks from Next to Doing on the Platform Team Workboards (Clinic Duty Team) board.
Tue, Jul 21, 4:26 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)

Mon, Jul 20

nnikkhoui moved T257838: Model contributions as distinct from revisions from Doing to Waiting for Review on the Platform Team Workboards (Green) board.
Mon, Jul 20, 5:31 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Fri, Jul 17

nnikkhoui updated the task description for T258296: setTemporaryHook() to accept both new and old hook names .
Fri, Jul 17, 8:59 PM · Patch-For-Review, Platform Team Initiatives (New Hook System)
nnikkhoui created T258296: setTemporaryHook() to accept both new and old hook names .
Fri, Jul 17, 8:42 PM · Patch-For-Review, Platform Team Initiatives (New Hook System)
nnikkhoui added a comment to T257838: Model contributions as distinct from revisions.

@daniel I think I need to go through and rename more things to 'contribution' e.g. ContributionSegment->getRevisions() to ContributionsSegment->getContributions () yea?

Fri, Jul 17, 8:01 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui moved T257838: Model contributions as distinct from revisions from Ready to Doing on the Platform Team Workboards (Green) board.
Fri, Jul 17, 6:17 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui moved T257839: Only include page revisions in the contributions endpoints from Ready to Waiting for Review on the Platform Team Workboards (Green) board.
Fri, Jul 17, 6:17 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Wed, Jul 15

nnikkhoui claimed T257838: Model contributions as distinct from revisions.
Wed, Jul 15, 3:32 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui claimed T257839: Only include page revisions in the contributions endpoints.
Wed, Jul 15, 3:32 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui closed T256826: Create E2E test for api-testing action=tag as Resolved.
Wed, Jul 15, 2:45 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)
nnikkhoui moved T257839: Only include page revisions in the contributions endpoints from Backlog to Ready on the Platform Team Workboards (Green) board.
Wed, Jul 15, 2:37 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui moved T257838: Model contributions as distinct from revisions from Backlog to Ready on the Platform Team Workboards (Green) board.
Wed, Jul 15, 2:36 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Sprints Board (Sprint 0), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Tue, Jul 14

nnikkhoui moved T257464: UserFactory should have a method for constructing an anonymous User from Backlog to Doing on the Platform Team Workboards (Green) board.
Tue, Jul 14, 11:04 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (Green), Platform Engineering
nnikkhoui claimed T257464: UserFactory should have a method for constructing an anonymous User .
Tue, Jul 14, 10:19 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (Green), Platform Engineering
nnikkhoui moved T256826: Create E2E test for api-testing action=tag from Doing to Waiting for Review on the Platform Team Workboards (Green) board.
Tue, Jul 14, 4:40 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)

Mon, Jul 13

nnikkhoui moved T256826: Create E2E test for api-testing action=tag from Ready to Doing on the Platform Team Workboards (Green) board.
Mon, Jul 13, 10:14 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)
nnikkhoui moved T256826: Create E2E test for api-testing action=tag from Backlog to Ready on the Platform Team Workboards (Green) board.
Mon, Jul 13, 10:14 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)
nnikkhoui renamed T256826: Create E2E test for api-testing action=tag from Create E2E test for api-testing action=managetags to Create E2E test for api-testing action=tag.
Mon, Jul 13, 9:29 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)
nnikkhoui renamed T256826: Create E2E test for api-testing action=tag from Create E2E test for api-testing action=tag to Create E2E test for api-testing action=managetags.
Mon, Jul 13, 8:49 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)

Jul 1 2020

nnikkhoui added a subtask for T254381: Update Example and BoilerPlate extensions for new hooks system: T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks .
Jul 1 2020, 6:57 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui added a parent task for T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks : T254381: Update Example and BoilerPlate extensions for new hooks system.
Jul 1 2020, 6:57 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)

Jun 30 2020

nnikkhoui created T256826: Create E2E test for api-testing action=tag.
Jun 30 2020, 11:31 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Green), Platform Team Initiatives (API Integration Tests)

Jun 24 2020

nnikkhoui closed T255582: Router::getRouteUrl make consistent with HandlerTestTrait::getRouteUrl as Resolved.
Jun 24 2020, 4:38 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)

Jun 18 2020

nnikkhoui updated the task description for T200259: ContribsPager should use a unique criterion for paging.
Jun 18 2020, 7:52 PM · Platform Team Workboards (External Code Reviews), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), WMDE-QWERTY-X-Mas-Sprint-2018-12-18, MediaWiki-Special-pages, WMDE-QWERTY-Sprint-2018-12-04

Jun 16 2020

nnikkhoui moved T255582: Router::getRouteUrl make consistent with HandlerTestTrait::getRouteUrl from Waiting for Review to Done on the Platform Team Workboards (Green) board.
Jun 16 2020, 9:14 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui updated the task description for T252202: Contributor gets their own contributions.
Jun 16 2020, 7:01 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui moved T255582: Router::getRouteUrl make consistent with HandlerTestTrait::getRouteUrl from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.
Jun 16 2020, 4:33 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui added a project to T255582: Router::getRouteUrl make consistent with HandlerTestTrait::getRouteUrl: Platform Team Initiatives (API Integration Tests).
Jun 16 2020, 4:32 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui created T255582: Router::getRouteUrl make consistent with HandlerTestTrait::getRouteUrl.
Jun 16 2020, 4:32 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui added a comment to T254175: 1.35.0-wmf.38 deployment blockers.

Just adding a quick note, that cpt has moved some mediawiki REST endpoints from /v0 namespace into /v1 (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/604441). This shouldn't be a problem but just making a note of it.

Jun 16 2020, 4:28 PM · Patch-For-Review, User-brennen, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Release, Train Deployments

Jun 12 2020

nnikkhoui updated the task description for T252202: Contributor gets their own contributions.
Jun 12 2020, 5:56 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Jun 11 2020

nnikkhoui moved T254381: Update Example and BoilerPlate extensions for new hooks system from Doing to Blocked on the Platform Team Workboards (Green) board.
Jun 11 2020, 10:08 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui updated the task description for T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks .
Jun 11 2020, 5:11 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)

Jun 10 2020

nnikkhoui updated the task description for T252202: Contributor gets their own contributions.
Jun 10 2020, 8:03 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui renamed T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks from MediaWikiIntegrationTestCase::setTemporaryHook not working for new style hooks to MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks .
Jun 10 2020, 6:23 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)
nnikkhoui created T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks .
Jun 10 2020, 6:23 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)
nnikkhoui moved T254381: Update Example and BoilerPlate extensions for new hooks system from Ready to Doing on the Platform Team Workboards (Green) board.
Jun 10 2020, 4:31 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui closed T254400: Remove ActionAPI and REST tests from api-testing node module, a subtask of T236680: Enable API integration tests in CI for MediaWiki core, as Resolved.
Jun 10 2020, 4:30 PM · Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Platform Team Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
nnikkhoui closed T254400: Remove ActionAPI and REST tests from api-testing node module as Resolved.
Jun 10 2020, 4:30 PM · Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui moved T254400: Remove ActionAPI and REST tests from api-testing node module from Doing to Done on the Platform Team Workboards (Green) board.
Jun 10 2020, 4:30 PM · Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui added a parent task for T254381: Update Example and BoilerPlate extensions for new hooks system: T254670: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system.
Jun 10 2020, 3:30 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui added a subtask for T254670: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system: T254381: Update Example and BoilerPlate extensions for new hooks system.
Jun 10 2020, 3:30 PM · Epic, Platform Engineering, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General, User-DannyS712

Jun 8 2020

nnikkhoui assigned T248684: Add support for logged in clients to REST testing framework to daniel.
Jun 8 2020, 8:37 PM · Patch-For-Review, Platform Team Workboards (Green), Testing-Roadblocks, Platform Team Initiatives (API Integration Tests)
nnikkhoui added a comment to T248684: Add support for logged in clients to REST testing framework.

@Naike This is being worked on by Daniel and I, I have added an assignee :)

Jun 8 2020, 8:37 PM · Patch-For-Review, Platform Team Workboards (Green), Testing-Roadblocks, Platform Team Initiatives (API Integration Tests)

Jun 5 2020

nnikkhoui renamed T254381: Update Example and BoilerPlate extensions for new hooks system from Update Extension and BoilerPlate extensions for new hooks system to Update Example and BoilerPlate extensions for new hooks system.
Jun 5 2020, 7:00 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui added a comment to T254381: Update Example and BoilerPlate extensions for new hooks system.

@Pppery absolutely :)

Jun 5 2020, 7:00 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui moved T254381: Update Example and BoilerPlate extensions for new hooks system from Backlog to Ready on the Platform Team Workboards (Green) board.
Jun 5 2020, 6:59 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui added a comment to T252202: Contributor gets their own contributions.

@Naike Woops - added assignee. Daniel and I are working on this at the moment (But it only lets me add one user)

Jun 5 2020, 6:52 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui assigned T252202: Contributor gets their own contributions to daniel.
Jun 5 2020, 6:51 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

Jun 3 2020

nnikkhoui created T254403: Tests for api-testing node module.
Jun 3 2020, 8:59 PM · Platform Team Initiatives (API Integration Tests)
nnikkhoui moved T254400: Remove ActionAPI and REST tests from api-testing node module from Backlog to Doing on the Platform Team Workboards (Green) board.
Jun 3 2020, 8:52 PM · Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui moved T252202: Contributor gets their own contributions from Ready to Doing on the Platform Team Workboards (Green) board.
Jun 3 2020, 8:52 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui added a subtask for T236680: Enable API integration tests in CI for MediaWiki core: T254400: Remove ActionAPI and REST tests from api-testing node module.
Jun 3 2020, 8:51 PM · Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Platform Team Initiatives (API Integration Tests), Code-Health, Continuous-Integration-Config
nnikkhoui added a parent task for T254400: Remove ActionAPI and REST tests from api-testing node module: T236680: Enable API integration tests in CI for MediaWiki core.
Jun 3 2020, 8:51 PM · Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui created T254400: Remove ActionAPI and REST tests from api-testing node module.
Jun 3 2020, 8:51 PM · Platform Team Initiatives (API Integration Tests), Platform Team Workboards (Green)
nnikkhoui updated the task description for T252202: Contributor gets their own contributions.
Jun 3 2020, 7:58 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui updated the task description for T252202: Contributor gets their own contributions.
Jun 3 2020, 7:23 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui created T254381: Update Example and BoilerPlate extensions for new hooks system.
Jun 3 2020, 5:24 PM · Platform Team Sprints Board (Sprint 0), Patch-For-Review, MediaWiki-extensions-Examples, Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui closed T251444: HookContainer Integration Tests as Resolved.
Jun 3 2020, 12:43 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)

May 27 2020

nnikkhoui claimed T250757: Update individual hook manuals on MediaWiki.
May 27 2020, 11:55 PM · Documentation, Platform Team Initiatives (New Hook System)

May 26 2020

nnikkhoui claimed T250754: Update Hooks Manual on MediaWiki.
May 26 2020, 11:13 PM · Documentation, Platform Team Initiatives (New Hook System)
nnikkhoui added a comment to T250757: Update individual hook manuals on MediaWiki.

Looking at my previous comment, instead of just services we instead would want to note that it is the ObjectFactory spec, not just services.

May 26 2020, 9:43 PM · Documentation, Platform Team Initiatives (New Hook System)

May 19 2020

nnikkhoui added a comment to T252566: Core REST API page history endpoint returns invalid links.

@daniel I may be completely missing something. but doesn't a handler have access to its full path via Handler::$request? Could we use something like $this->getRequest()->getUri()->getPath(); in the PageHistoryHandler?

May 19 2020, 11:50 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), MediaWiki-REST-API, Platform Team Workboards (Green), Platform Team Initiatives (MW REST API in PHP)

May 18 2020

nnikkhoui added a comment to T252202: Contributor gets their own contributions.

@eprodromou question: I'm still a little confused by the "segment" param, the syntax is unclear to me by how it is written in the description. (Using timestamp below as an example)

May 18 2020, 11:50 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
nnikkhoui created T253066: Page fixtures for MediaWiki REST integration tests .
May 18 2020, 8:28 PM · MediaWiki-REST-API, Testing-Roadblocks
nnikkhoui updated the task description for T252202: Contributor gets their own contributions.
May 18 2020, 6:12 PM · Platform Team Sprints Board (Sprint 0), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (Green), Story, MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)

May 15 2020

nnikkhoui awarded T252811: Requesting +2 rights for Mediawiki Group for DannyS712 a 100 token.
May 15 2020, 4:35 PM · User-DannyS712, MediaWiki-Gerrit-Group-Requests

May 13 2020

nnikkhoui added a comment to T252686: extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties.

Actually! Just remembered @tstarling has this change in patch already out (but not yet merged).

May 13 2020, 8:27 PM · MediaWiki-Core-Hooks, Dependency injection, Platform Team Workboards (Clinic Duty Team)
nnikkhoui added a comment to T252686: extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties.

Unsure if this was intentionally omitted to prevent people from using it until the new Hooks system is fully released, but I think we need to just add HookHandlers to extension.schema.v2.json.

May 13 2020, 8:25 PM · MediaWiki-Core-Hooks, Dependency injection, Platform Team Workboards (Clinic Duty Team)

May 11 2020

nnikkhoui closed T250300: Update setTemporaryHook() to use scopedRegister as Resolved.
May 11 2020, 3:25 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui moved T251444: HookContainer Integration Tests from Ready to Doing on the Platform Team Workboards (Green) board.
May 11 2020, 3:09 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui moved T250300: Update setTemporaryHook() to use scopedRegister from Doing to Done on the Platform Team Workboards (Green) board.
May 11 2020, 3:09 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)

May 6 2020

nnikkhoui added a comment to T250757: Update individual hook manuals on MediaWiki.

It looks really good to me!! Couple of ideas:

May 6 2020, 11:08 PM · Documentation, Platform Team Initiatives (New Hook System)

May 4 2020

nnikkhoui added a comment to T249528: Warn if MediaWiki::getInstance() called prior to bootstrap completing .

@Aklapper Appreciate it !

May 4 2020, 3:36 PM · MediaWiki-ServiceContainer, Platform Engineering

Apr 29 2020

nnikkhoui moved T251444: HookContainer Integration Tests from Backlog to Ready on the Platform Team Workboards (Green) board.
Apr 29 2020, 5:48 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui added a project to T251444: HookContainer Integration Tests: Platform Team Workboards (Green).
Apr 29 2020, 5:48 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui updated the task description for T251444: HookContainer Integration Tests.
Apr 29 2020, 5:47 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)
nnikkhoui created T251444: HookContainer Integration Tests.
Apr 29 2020, 5:47 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)

Apr 28 2020

nnikkhoui updated subscribers of T250859: Rename BeforeParserrenderImageGalleryHook to BeforeParserRenderImageGalleryHook.

Renaming this would break some of the logic that generates the hook function names. A proposed alternative by @tstarling was to introduce hook aliases instead of actually renaming the hook itself. This would also allow us to alias some of the hooks that have double colons in the name (e.g. ApiMain::moduleManager) which as of now is converting the colons into underscores (e.g. ApiMain__moduleManager) which looks slightly awkward.

Apr 28 2020, 10:26 PM · MediaWiki-Parser, Platform Team Initiatives (New Hook System), MediaWiki-Core-Hooks

Apr 20 2020

nnikkhoui updated subscribers of T250754: Update Hooks Manual on MediaWiki.
Apr 20 2020, 9:39 PM · Documentation, Platform Team Initiatives (New Hook System)
nnikkhoui updated subscribers of T250757: Update individual hook manuals on MediaWiki.
Apr 20 2020, 9:39 PM · Documentation, Platform Team Initiatives (New Hook System)
nnikkhoui created T250757: Update individual hook manuals on MediaWiki.
Apr 20 2020, 9:38 PM · Documentation, Platform Team Initiatives (New Hook System)
nnikkhoui created T250754: Update Hooks Manual on MediaWiki.
Apr 20 2020, 9:19 PM · Documentation, Platform Team Initiatives (New Hook System)
nnikkhoui closed T250102: Fix failing tests that rely on Hooks.php as Resolved.
Apr 20 2020, 8:12 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Platform Team Workboards (Green), MediaWiki-Core-Hooks, Platform Team Initiatives (New Hook System)
nnikkhoui closed T247089: Create HookContainer.php, a subtask of T247086: Create New Hook Infrastructure, as Resolved.
Apr 20 2020, 8:12 PM · Platform Team Workboards (Epics), Epic, Platform Team Initiatives (New Hook System)
nnikkhoui closed T247089: Create HookContainer.php as Resolved.
Apr 20 2020, 8:12 PM · Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)

Apr 17 2020

nnikkhoui moved T247089: Create HookContainer.php from Doing to Done on the Platform Team Workboards (Green) board.
Apr 17 2020, 9:34 PM · Platform Team Workboards (Green), Platform Team Initiatives (New Hook System)