Thu, Apr 8
Wed, Apr 7
Tue, Apr 6
Wed, Mar 31
Tue, Mar 30
Thu, Mar 25
Thu, Mar 18
@thcipriani I think the idea is to still use PipelineLib, but going to be honest this one completely slipped my memory since I'm no longer working with the web team!
Removed it from your board for now since I'm not sure where priority is/if this should be done anymore considering the build step has drastically changed since this was written. Will leave it to web team to see if its a priority to do!
Tue, Mar 16
My first guess as to what may be the cause is that in the SearchHandler class, SearchHandler:: createSearchEngine() is using defaultNamespaces() to set the searchable namespaces. I see another method that exists called searchableNamespaces() that might be the correct set of namespaces to use.
Mon, Mar 15
@Volker_E Yes, will resolve :)
@Volker_E I think this was just intended as just a representational task to show that someone (me) was matrixed out to another team.
Mar 12 2021
Mar 11 2021
Mar 10 2021
@BPirkle were you able to do any look into performance of the actual request to MS itself vs. how long the API takes to process?
@sdkim yes yes
Mar 9 2021
Mar 8 2021
Mar 7 2021
Mar 4 2021
Feb 25 2021
Feb 17 2021
Feb 16 2021
I think we can consider the _info endpoint the "hello world" health check endpoint.
Feb 11 2021
Feb 10 2021
Feb 9 2021
Feb 8 2021
Feb 4 2021
Feb 3 2021
Feb 2 2021
Feb 1 2021
Cool ok! The only difference will be that our docs will be part of the api itself on toolforge, as the ?doc endpoint is part of the service-template scaffolding already, and is the thing that will deliver the swagger docs just like that example you have above, so it will all just be in one place. But I agree with Bill that it should be a separate task :)
@sdkim By API spec do you mean the Swagger docs or something else?
Jan 29 2021
I can request a new gerrit repository for us, i think it belongs in /mediawiki/services directory, any objection to just /mediawiki/services/image-recommendation-api?
Jan 28 2021
Jan 27 2021
AH yes okay yep that makes sense, this task is just to capture the first version then. Got it.
Is the distinction between this task and T272734 so that we can compare results of both, and see how it affects users interaction with applying images? And if so, we would need some indicator in either the request params/header/some ruleset built in the API for knowing when to give which result. Maybe we're not there yet, just noting for future.
Jan 14 2021
Jan 13 2021
Closing, as discussion on T269957 has moved back to using buster backports instead.
Thanks @MoritzMuehlenhoff and @jbond for your explanations, will use buster backports on my own local Docker images. @jeena or @hashar would it be possible for releng is able install via backports on the blubber-generated images?
Jan 12 2021
@jbond Gotcha! So just to make sure I understand, no matter the approach we'll have to manage the security of the package and its dependencies. With using backports, we get support from Debian until 2022. But by adding npm to our own debian package repo, we just have to manage dependencies ourselves starting now. Is that a correct understanding?
Thanks @jbond for the reasoning and explanation! Just because I'm not very familiar with package management, wouldn't this be an issue for anytime we wanted to upgrade versions of npm, or really any big package? And wouldn't this need to be upgraded eventually? Or do we not do usually major updates of big packages (like npm) unless absolutely necessary.
Jan 11 2021
Cool thanks @BPirkle! I gathered a lot of the same conclusions from watching the meeting recording back. Couple more things I was wondering about:
Jan 6 2021
Given we've decided to not have unique endpoints per task-type (e.g. /tasks/add_image or /tasks/add_link) I am wondering how might we provide this cascade of filtering that is intuitive to the user?
Jan 5 2021
@phuedx It's not necessarily blocked on releng, but I had some open questions on the original patch that would help me confidently fix this patch and its parent. (I think it got lost when i abandoned it when we removed the feat/search branch and so thats my bad!
Jan 4 2021
Dec 23 2020
I believe so, all 3 patches were merged and we did a short knowledge transfer.
Dec 22 2020
@thcipriani okay so this was definitely a case of PEBCAK haha I was trying to reference those anchors elsewhere on the page and didn't see that working, but i was doing so incorrectly. I just uploaded a new patch aaaand i see it working now :) thanks for clearing that up
@Dzahn I'm not seeing the changes BUT I realized this is likely my fault, I think markdown.safehtml also needs to be enabled for named anchors to be true.... -_-
Apologies, I will submit another patch to add that!
Dec 21 2020
@Dzahn do the changes take time to take affect or should it be immediate?
Dec 19 2020
Thanks @Dzahn !
Dec 18 2020
Dec 17 2020
Dec 16 2020
AHHHHH. Got it. Thanks!!
On Debian that is two separate packages and they are not kept in sync. I was actually really curious about that, I was originally confused why npm and nodejs were installed separately, but didn't realize that it was a debian-specific thing. Also didn't know https://debmonitor.wikimedia.org/packages/npm existed, thats a cool tool for tracking!
Dec 14 2020
Closing, as there have been no new errors since train rolled out this change on December 8th.
I don't know much about backports to understand how they will be phased out! The article on backports says: