nray (Nick Ray)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2018, 4:57 PM (32 w, 6 d)
Availability
Available
LDAP User
Nray
MediaWiki User
NRay (WMF) [ Global Accounts ]

Recent Activity

Yesterday

nray claimed T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.
Mon, Feb 18, 6:05 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Thu, Feb 14

nray added a comment to T208980: [Bug] The statsv client should send a request when the page unloads.

@nray: See @Krinkle's detailed explanation here: T208980#4792762

Thu, Feb 14, 5:16 PM · Performance-Team, Readers-Web-Backlog, MediaWiki-extensions-WikimediaEvents

Wed, Feb 13

nray closed T208915: MobileFrontend modules: Cleanup some deprecation calls as Resolved.
Wed, Feb 13, 8:59 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T208915: MobileFrontend modules: Cleanup some deprecation calls.
Wed, Feb 13, 6:05 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Tue, Feb 12

nray added a comment to T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.

Following up from yesterdays discussion, one thing we talked about is when it's appropriate to use and event bus and when it's not.

In general, an event bus is best used to create loose coupling between components that have distinct responsibilities (best example is event-logging, where one component is mainly responsible for analytics, while the other is responsible for UI, but we want them to talk to each other, sometimes).

In MF and Minerva however, we sometimes use events to call methods within the same class or subclass (i.e. within the same inheritance chain).

An example of this is how Panel.js emits a show/hide event self.emit( 'show' ); but this event is actually only bound in it's child class of Drawer.js. This pattern makes it difficult to understand where a method is actually executed, because not only do you have to understand the whole inheritance chain, you also need to identify where the method is bound and where in the chain the events are being triggering as well.

I think this kind of behaviour could be replaced with calling class methods directly instead of through an event bus.

Tue, Feb 12, 9:07 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T215657: MFA: LanguageOverlay should be an Overlay with a LanguageSearcher component.
Tue, Feb 12, 6:47 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
nray moved T215657: MFA: LanguageOverlay should be an Overlay with a LanguageSearcher component from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Feb 12, 6:47 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
nray claimed T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.
Tue, Feb 12, 6:05 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T208980: [Bug] The statsv client should send a request when the page unloads.

IIRC, in some mobile browsers, the unload event doesn't fire before the JavaScript VM is torn down after a tab is closed. However, we're more confident that the visibilitychange event does fire

Tue, Feb 12, 2:21 AM · Performance-Team, Readers-Web-Backlog, MediaWiki-extensions-WikimediaEvents

Thu, Feb 7

nray placed T202746: Enable babel transpiling in MobileFrontend up for grabs.
Thu, Feb 7, 12:40 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Wed, Feb 6

nray moved T202746: Enable babel transpiling in MobileFrontend from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Feb 6, 11:47 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Tue, Feb 5

nray closed T213340: Editor code is built via webpack as Resolved.
Tue, Feb 5, 9:35 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T213340: Editor code is built via webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Tue, Feb 5, 9:35 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T214180: Add informational links to AMC opt-in toggle.

@Niedzielski can you answer a few questions please:

  1. Which environment does this need to be tested in?
Tue, Feb 5, 9:28 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
nray claimed T202746: Enable babel transpiling in MobileFrontend.
Tue, Feb 5, 6:22 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
nray moved T202746: Enable babel transpiling in MobileFrontend from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Feb 5, 6:21 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Mon, Feb 4

nray placed T213340: Editor code is built via webpack up for grabs.
Mon, Feb 4, 10:41 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T213340: Editor code is built via webpack from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 4, 10:40 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T213340: Editor code is built via webpack.
Mon, Feb 4, 10:40 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T213340: Editor code is built via webpack.

Before signing off on this I would also like this small patch to be reviewed :)

Mon, Feb 4, 10:39 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T213340: Editor code is built via webpack.

critical js size (mobile.startup.js + mobile.common.js) has not increased. Beware of any modules that are shared among the lazy loaded chunks and are not in mobile.startup.js. Webpack will excise these into mobile.common.js and increase our critical js size

Mon, Feb 4, 9:05 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T213340: Editor code is built via webpack.
Mon, Feb 4, 6:05 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Fri, Jan 25

nray placed T214180: Add informational links to AMC opt-in toggle up for grabs.
Fri, Jan 25, 1:56 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
nray moved T214180: Add informational links to AMC opt-in toggle from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Jan 25, 1:54 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Wed, Jan 23

nray moved T214200: Editor code is packaged in 2 modules from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 10:09 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review

Tue, Jan 22

nray placed T213298: Special:Uploads is built via webpack up for grabs.
Tue, Jan 22, 9:31 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T213298: Special:Uploads is built via webpack as Resolved.
Tue, Jan 22, 9:31 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T213298: Special:Uploads is built via webpack, a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Tue, Jan 22, 9:31 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T213298: Special:Uploads is built via webpack.
Tue, Jan 22, 9:31 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T213298: Special:Uploads is built via webpack.

git checkout e1c212dbe1d583952b2de1eb7ee347108ba68d06 (this patch's commit)
curl -i 'http://localhost:8181/w/load.php?debug=false&lang=en&modules=mobile.startup&skin=minerva' | wc -c
90376

Tue, Jan 22, 9:26 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T213298: Special:Uploads is built via webpack.
Tue, Jan 22, 8:07 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T214180: Add informational links to AMC opt-in toggle.
Tue, Jan 22, 7:28 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
nray moved T214180: Add informational links to AMC opt-in toggle from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 22, 7:28 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
nray claimed T213298: Special:Uploads is built via webpack.
Tue, Jan 22, 6:06 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 19 2019

Jdlrobson awarded T214220: [betalabs] MinervaNeue: "TypeError: j.bind is not a function" - the page becomes non-responsive a Yellow Medal token.
Jan 19 2019, 5:27 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Mobile

Jan 18 2019

nray placed T213472: Port categories code to webpack up for grabs.
Jan 18 2019, 7:56 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T213472: Port categories code to webpack from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 18 2019, 6:09 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray placed T213474: Port talk code to webpack up for grabs.
Jan 18 2019, 4:56 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T213472: Port categories code to webpack.
Jan 18 2019, 12:20 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T213472: Port categories code to webpack from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 18 2019, 12:20 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T213474: Port talk code to webpack from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 18 2019, 12:08 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 17 2019

nray moved T213298: Special:Uploads is built via webpack from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 17 2019, 10:06 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T213474: Port talk code to webpack.
Jan 17 2019, 8:13 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T213474: Port talk code to webpack from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 17 2019, 8:13 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray placed T213299: Special:Nearby is built in webpack up for grabs.
Jan 17 2019, 4:41 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 15 2019

nray moved T213112: Entry points for mobileoptions, mobile.init, mobilediff and userlogin are generated via webpack from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 15 2019, 11:50 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T213299: Special:Nearby is built in webpack.
Jan 15 2019, 4:25 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T213299: Special:Nearby is built in webpack from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 15 2019, 4:24 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 14 2019

nray placed T212944: Update page issues folder structure up for grabs.
Jan 14 2019, 11:58 PM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog
nray updated the task description for T212944: Update page issues folder structure.
Jan 14 2019, 11:37 PM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog
nray updated the task description for T212944: Update page issues folder structure.
Jan 14 2019, 11:18 PM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog
nray updated the task description for T212944: Update page issues folder structure.
Jan 14 2019, 11:17 PM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog
nray added a project to T212944: Update page issues folder structure: MinervaNeue.
Jan 14 2019, 11:06 PM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog
nray updated the task description for T212944: Update page issues folder structure.
Jan 14 2019, 11:03 PM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog
nray added a project to T213696: Sample by title in QuickSurvey: Readers-Web-Backlog.
Jan 14 2019, 10:30 PM · Readers-Web-Backlog, QuickSurveys, Research
nray added a comment to T213336: Regression: Mobile gallery loading spinner appears on left instead of centered.

When I briefly looked into this, I thought it was https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/472368/ that introduced the regression. I couldn't reproduce before that commit

Jan 14 2019, 10:28 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend

Jan 12 2019

nray added a comment to T212944: Update page issues folder structure.

I plan to carve out time to look at this on Monday, Jan. 14

Jan 12 2019, 12:05 AM · MinervaNeue, Page-Issue-Warnings, Technical-Debt, Readers-Web-Backlog

Jan 11 2019

nray placed T212823: MFA: mobile.special.watchlist.scripts is built via Webpack up for grabs.
Jan 11 2019, 10:23 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
nray updated the task description for T210209: MFA: mobile.mediaViewer is built with webpack (code splitting).
Jan 11 2019, 10:23 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T210209: MFA: mobile.mediaViewer is built with webpack (code splitting).
Jan 11 2019, 10:22 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T210209: MFA: mobile.mediaViewer is built with webpack (code splitting) as Resolved.
Jan 11 2019, 10:22 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T210209: MFA: mobile.mediaViewer is built with webpack (code splitting), a subtask of T207787: [EPIC] Reduce the amount of modules in MobileFrontend, as Resolved.
Jan 11 2019, 10:22 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T210209: MFA: mobile.mediaViewer is built with webpack (code splitting).

Commit: f4387e9dfa5a55f3af681f0aabd3b17ead464693 (this card's commit)
curl -i -H 'Accept-Encoding: gzip' 'http://localhost:8181/w/load.php?debug=false&lang=en&modules=mobile.startup&skin=minerva' | wc -c
22436

Jan 11 2019, 10:16 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 10 2019

nray claimed T210209: MFA: mobile.mediaViewer is built with webpack (code splitting).
Jan 10 2019, 6:05 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 9 2019

nray added a comment to T209129: MFA: Drawers and Overlays should not auto-append it self to the body element.

@Jdrewniak Am noticing that after commit 12f24ee7abe0f18af33f2729b0308193e467cbc0, clicking the languages icon no longer shows the white screen loader. Please let me know if you have trouble reproducing

Jan 9 2019, 5:00 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 8 2019

D3r1ck01 awarded F27824647: code-coverage.png a Love token.
Jan 8 2019, 8:57 PM
nray closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.
Jan 8 2019, 8:54 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
nray closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Jan 8 2019, 8:54 PM · Readers-Web-Backlog, Epic, MobileFrontend
nray added a comment to T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.

100% code coverage now. Good job all!

Jan 8 2019, 8:43 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
nray claimed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.
Jan 8 2019, 6:02 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
nray closed T205592: Composition experiment: DownloadIcon and ShareIcon should not extend Icon as Resolved.
Jan 8 2019, 1:04 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T205592: Composition experiment: DownloadIcon and ShareIcon should not extend Icon, a subtask of T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance, as Resolved.
Jan 8 2019, 1:04 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MinervaNeue
nray added a comment to T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!).

git checkout c5a8dfd769ede9b3484a168a57058583ce1d092f
curl -i -H 'Accept-Encoding: gzip' 'http://localhost:8181/w/load.php?debug=false&lang=en&modules=mobile.languages.structured&skin=minerva&version=0hym8m0' | wc -c
2785 bytes

Jan 8 2019, 12:43 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 7 2019

nray updated the task description for T205592: Composition experiment: DownloadIcon and ShareIcon should not extend Icon.
Jan 7 2019, 11:44 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T210209: MFA: mobile.mediaViewer is built with webpack (code splitting).
Jan 7 2019, 7:55 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T210209: MFA: mobile.mediaViewer is built with webpack (code splitting).
Jan 7 2019, 7:51 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T212823: MFA: mobile.special.watchlist.scripts is built via Webpack.
Jan 7 2019, 7:09 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
nray moved T212823: MFA: mobile.special.watchlist.scripts is built via Webpack from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 7 2019, 7:09 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)

Jan 3 2019

nray moved T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!) from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 3 2019, 11:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray created T212913: [Spike, 8hrs] MFA: Investigate Webpack Lazy Loading Hurdles and approach to code splitting.
Jan 3 2019, 11:40 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Spike, Readers-Web-Backlog
nray moved T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!) from Needs Code Review to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 3 2019, 4:33 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Dec 21 2018

nray moved T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!) from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Dec 21 2018, 10:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray awarded T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance a 100 token.
Dec 21 2018, 1:39 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, MinervaNeue

Dec 19 2018

nray added a comment to T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.

@alexhollender thanks for looking into the text size stuff! Looks like this might not be an issue then

Dec 19 2018, 6:23 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Dec 18 2018

nray awarded T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views a Like token.
Dec 18 2018, 9:13 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.
Dec 18 2018, 8:54 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.
Dec 18 2018, 8:37 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.

Width - the width of each tab name must fit within the screen for all common screen sizes

Dec 18 2018, 6:32 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
nray closed T211963: View.test.js should call JSDom before initializing jQuery as Resolved.
Dec 18 2018, 6:08 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
nray closed T211963: View.test.js should call JSDom before initializing jQuery, a subtask of T210517: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown(), as Resolved.
Dec 18 2018, 6:08 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!).

We talked about this today:

  • Webpack runtime bundle doesn't seem to be for splitting sharing code
  • Webpack does seem to support de-duplicating JS via SplitChunksPlugin
  • Many ways to do this seem to exist:
    • could bypass RL and access JS directly
    • We could use webpack async loader
    • ... but beware referencing urls because cache problems (and that will get the attention of the performance team)

      We're all lacking in experience in this area so we will probably need to talk again about this when better informed, but the minimum we need to do is make sure that we don't ship code e.g. Overlay twice (inside mobile.startup and mobile.languages) and maintain the same level of bytes. Have added a bullet point to capture that.
Dec 18 2018, 1:14 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Dec 17 2018

nray placed T210517: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown() up for grabs.
Dec 17 2018, 11:40 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray closed T210517: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown() as Resolved.

Looks like we are done here. Reviewed the rest of our node qunit tests to ensure that the files that are using jquery also call its teardown method in the afterEach hook.

Dec 17 2018, 11:34 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated the task description for T210517: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown().
Dec 17 2018, 11:32 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T210517: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown().

This is second time I've attached a task to a spike, bad me! (but I didn't want this failing View.test.js to block other patches like T210208).

The patch adds the teadown in Skin.test.js and fixed View.test.js by adding the JSDom setup to that test. JQuery was failing because of no global window object. More specifically, the lack of a window object causes jQuery to export a factory function in Node instead of the proper jQuery class.

Dec 17 2018, 11:18 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!).
Dec 17 2018, 7:01 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T210210: MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!) from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Dec 17 2018, 7:01 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray reassigned T210553: Deploy page issues to all wikipedias (except enwiki) from nray to Jdlrobson.
Dec 17 2018, 6:11 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
nray claimed T210553: Deploy page issues to all wikipedias (except enwiki).
Dec 17 2018, 4:47 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
nray moved T210553: Deploy page issues to all wikipedias (except enwiki) from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Dec 17 2018, 4:47 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings