@MNeisler I'm still fuzzy on what is desired with this ticket and was hoping you could shed some light on the following questions I have:
@Mholloway From my understanding, I think at least part of the problem is that the default setting for the property we are interested in, VectorSkinVersion, is dependent on context and is not static like most other user properties. That is, its default value is dependent on whether the user is a newly created user or an existing user and the values of two related config variables in Vector - VectorDefaultSkinVersionForExistingAccounts and VectorDefaultSkinVersionForNewAccounts .
Wed, Mar 3
Tue, Mar 2
^^ New patch points tests to frwiki since it is a production wiki with wvui search enabled and because beta has (oddly) stopped showing search suggestions unless an exact match has been typed
To recap the work that was done in this ticket which might aid in sign off:
- Chores are updated to include the new dashboards
Mon, Mar 1
Wed, Feb 24
Tue, Feb 23
Today I met with @Peter to talk about the steps remaining for this ticket. Peter was very helpful and now we have a really a cool dashboard thanks to him!
Mon, Feb 22
@ovasileva Thank you. I agree that it should not be a blocker for deployment
Fri, Feb 19
Okay, I've looked into this more and made a POC. The POC was worthwhile as it exposed several gotchas that make this ticket not so trivial:
Thu, Feb 18
Sorry for the delay on this. I'm planning on looking into this more today
Tue, Feb 16
Thu, Feb 11
@phuedx Thank you. The rest of your posts made sense to me and were well articulated. Please consider this a "+2" from me 😀
Wed, Feb 10
Thank you @phuedx for the great detailed notes!
Tue, Feb 9
Sorry, I ran out of time to look at this today. Will plan on reviewing tomorrow
Mon, Feb 8
Fri, Feb 5
Feb 3 2021
Feb 2 2021
Feb 1 2021
thanks @Jdlrobson !
Jan 28 2021
@alexhollender You might also be interested in looking at the search with thumbnails disabled as well: https://patchdemo.wmflabs.org/wikis/9ed1c233860587aa138e8a652fbf5e63/w/index.php/Main_Page
Jan 27 2021
I will write QA steps soon
Patches for review:
Jan 26 2021
Jan 25 2021
Jan 22 2021
Patches for review:
Thank you @alexhollender and no problem 😃 I just wanted to make sure the code to support A was deliberate and preferred.
How will we create the button? mw-ui-button ? wvui styles ? other?
Jan 21 2021
Jan 20 2021
Assuming thumbnails are enabled, how important is it to you to have the input expand immediately on first focus before WVUI loads vs. having the input expand after WVUI loads? As an example, please compare these two patchdemos:
Patch for review is at https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/656504 which makes the input NOT expand (and before WVUI loads) if the search configuration has thumbnails disabled