In T209314#4824157, @Jdlrobson wrote:

A run of npm outdated tells me:
Package Current Wanted Latest Location
wdio-mocha-framework 0.6.3 0.6.3 0.6.4

Should we bump wdio-mocha-framework the extra step?

Per npm audit, there are 4 "high" vulnerabilities (with 44 "moderate" and 11 "low").

Thanks for that @Shreyasminocha! Annoyingly in production we are using node 6 so we can't benefit from these audits (have to do them manually every now and again). You are right though that these are dev dependencies.

I'm seeing just one issue now that could be resolved with

Run  npm install --save-dev grunt-contrib-watch@1.1.0  to resolve 2 vulnerabilities

Tested anon / logged in users, previews with images / no images using https://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor. All appears to be working as intended.

@Jdlrobson I really like the more granular pattern you've suggested which, as you said, is similar to how react does it and think it could work really well. We should talk about it at the next super-happy-dev-time. The thing that I didn't like about my approach is that it made each component responsible for knowing about an event bus and how to use it. Your suggestion would resolve that by moving that layer out of components (which I think is a good thing). By doing this, it seems like it would make our components more like presentational components and less like container + presentational components.

The following patches need review:

Am now seeing warnings in the output (as intended)

The page issues tests pass for me locally as shown below. Unfortunately, the tests run on the beta cluster are still flakey (and probably will be for the foreseeable future).

The doc looks good to me so far. I'm sure there will be revisions down the road as we continue to port and learn new things

Good news: I haven't noticed any test failures from pages issues in the last several builds.
Bad news: Other tests are failing and the beta cluster read only errors are making this hard sign off on. I *think* it's working, but there is a lot of noise right now.

Tested on https://en.m.wikipedia.org and we are still sending events at what seems like 50% of page views

1 big patch merged! Still more AC to do so I'm moving to Needs More Work column

Moving this to Needs More work. One patch has been reviewed and merge relating to class name but there is still AC to be met including passing isBorderBox

100% test coverage for icons.js and context.js!

Lgtm! Tested on chrome desktop and mobile (android), was able to see the spinner, download button worked, and html is valid.

Moving this to ready for sign off as it was a simple config change

Deployed and am noticing a drop in page issues events

In T208605#4717017, @Jdlrobson wrote:

Mmm interesting.. I wonder if https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/469153/ will take care of this when it gets deployed...

Per sign off instructions, created new task T208514 for merging feature branch to master