Fri, Dec 14
Thu, Dec 13
Wed, Dec 12
Tested anon / logged in users, previews with images / no images using https://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor. All appears to be working as intended.
@Jdlrobson I really like the more granular pattern you've suggested which, as you said, is similar to how react does it and think it could work really well. We should talk about it at the next super-happy-dev-time. The thing that I didn't like about my approach is that it made each component responsible for knowing about an event bus and how to use it. Your suggestion would resolve that by moving that layer out of components (which I think is a good thing). By doing this, it seems like it would make our components more like presentational components and less like container + presentational components.
Tue, Dec 11
Mon, Dec 10
Fri, Dec 7
Thu, Dec 6
Wed, Dec 5
Tue, Dec 4
The following patches need review:
Mon, Dec 3
Fri, Nov 30
Am now seeing warnings in the output (as intended)
Thu, Nov 29
Wed, Nov 28
The page issues tests pass for me locally as shown below. Unfortunately, the tests run on the beta cluster are still flakey (and probably will be for the foreseeable future).
The doc looks good to me so far. I'm sure there will be revisions down the road as we continue to port and learn new things
Tue, Nov 27
Good news: I haven't noticed any test failures from pages issues in the last several builds.
Bad news: Other tests are failing and the beta cluster read only errors are making this hard sign off on. I *think* it's working, but there is a lot of noise right now.
Tested on https://en.m.wikipedia.org and we are still sending events at what seems like 50% of page views
Mon, Nov 26
Sat, Nov 17
Nov 16 2018
Nov 15 2018
1 big patch merged! Still more AC to do so I'm moving to Needs More Work column
Nov 14 2018
Moving this to Needs More work. One patch has been reviewed and merge relating to class name but there is still AC to be met including passing isBorderBox
Nov 13 2018
100% test coverage for icons.js and context.js!
Nov 9 2018
Nov 8 2018
Lgtm! Tested on chrome desktop and mobile (android), was able to see the spinner, download button worked, and html is valid.
Nov 5 2018
Moving this to ready for sign off as it was a simple config change
Deployed and am noticing a drop in page issues events
Nov 2 2018
Nov 1 2018
Per sign off instructions, created new task T208514 for merging feature branch to master