Page MenuHomePhabricator

nray (Nick Ray)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2018, 4:57 PM (117 w, 1 d)
Availability
Available
LDAP User
Nray
MediaWiki User
NRay (WMF) [ Global Accounts ]

Recent Activity

Mon, Sep 28

nray closed T254695: Build a pre-library loading indicator for Vue.js search as Resolved.

Latest patch from @Jdrewniak fixes the tab overlapping the loading box. I did notice a somewhat interesting state when the viewport is resized to the point that the personal tools drops to the next line. When that happens, the loading indicator overlap the personal tools but that might be the expected/desired behavior (see below)? /cc @alexhollender

Mon, Sep 28, 10:51 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray reassigned T254695: Build a pre-library loading indicator for Vue.js search from nray to Jdrewniak.
Mon, Sep 28, 10:51 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray closed T254695: Build a pre-library loading indicator for Vue.js search, a subtask of T249299: [Epic] Build the new Vue.js search experience, as Resolved.
Mon, Sep 28, 10:50 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Epic, Desktop Improvements
nray claimed T254695: Build a pre-library loading indicator for Vue.js search.
Mon, Sep 28, 7:55 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray moved T254695: Build a pre-library loading indicator for Vue.js search from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 28, 7:55 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)

Fri, Sep 25

nray added a comment to T263834: Test new header-first DOM with screenreader users.

Also, I'm not sure what effect this would have on the test, but wanted to note that the implementation of T262872 (currently in ready for dev) might play a role in how users perceive the new DOM order (bringing back the ability to jump from the sidebar button directly into the sidebar)

Fri, Sep 25, 4:49 PM · Vector, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Accessibility, Desktop Improvements
nray added a comment to T263834: Test new header-first DOM with screenreader users.

lgtm, just had one thought below:

Fri, Sep 25, 4:24 PM · Vector, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Accessibility, Desktop Improvements

Wed, Sep 23

nray reassigned T254695: Build a pre-library loading indicator for Vue.js search from nray to Jdrewniak.
Wed, Sep 23, 3:48 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray moved T254695: Build a pre-library loading indicator for Vue.js search from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Wed, Sep 23, 3:47 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray reassigned T251544: Add user journey performance tests for Vector's Legacy and Vue.js search from nray to Peter.
Wed, Sep 23, 3:46 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Tue, Sep 22

nray claimed T254695: Build a pre-library loading indicator for Vue.js search.
Tue, Sep 22, 5:09 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)

Mon, Sep 21

nray added a project to T263382: Remove ULS extension hacks from Vector and MobileFrontend: Readers-Web-Backlog.
Mon, Sep 21, 10:44 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
nray updated the task description for T263032: Deploy the new location of the search bar to new vector and begin A/B test on test wikis.
Mon, Sep 21, 5:55 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Wed, Sep 16

nray reassigned T254695: Build a pre-library loading indicator for Vue.js search from nray to Jdrewniak.
Wed, Sep 16, 5:06 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray moved T254695: Build a pre-library loading indicator for Vue.js search from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Wed, Sep 16, 5:06 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray moved T251544: Add user journey performance tests for Vector's Legacy and Vue.js search from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Wed, Sep 16, 1:13 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Tue, Sep 15

nray added a comment to T254695: Build a pre-library loading indicator for Vue.js search.

@Jdrewniak Looks good, but I noticed that part of the loading element is being hidden by the tabs on my local instance:

Tue, Sep 15, 12:58 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray reassigned T261378: Remove IE8 CSS hacks and fallbacks in Vector from nray to Volker_E.
Tue, Sep 15, 12:45 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Vector, good first task, Technical-Debt, Browser-Support-Internet-Explorer, CSS
nray closed T261378: Remove IE8 CSS hacks and fallbacks in Vector as Resolved.

LGTM! 👍

Tue, Sep 15, 12:45 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Vector, good first task, Technical-Debt, Browser-Support-Internet-Explorer, CSS
nray closed T261378: Remove IE8 CSS hacks and fallbacks in Vector, a subtask of T258766: Remove IE8 CSS hacks and workarounds in core, extensions and skins, as Resolved.
Tue, Sep 15, 12:45 AM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), MediaWiki-General, MediaWiki-extensions-General, good first task, Technical-Debt, Browser-Support-Internet-Explorer, CSS

Mon, Sep 14

nray updated the task description for T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .
Mon, Sep 14, 11:44 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Spike
nray added a comment to T261802: Switch to header-first DOM.

@Niedzielski the removal of mw-page-base was intentional. It used to push down the content with its height, but now that the absolute positioning is removed from most of the elements, it serves no logical function. If we kept it in the DOM it would be an empty div without any styles.

Mon, Sep 14, 10:47 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray updated the task description for T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .
Mon, Sep 14, 10:39 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Spike
nray created T262872: [Spike] Determine best approach for focusing from the sidebar button into the sidebar .
Mon, Sep 14, 10:38 PM · Vector, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Spike
nray claimed T254695: Build a pre-library loading indicator for Vue.js search.
Mon, Sep 14, 5:07 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray placed T261802: Switch to header-first DOM up for grabs.
Mon, Sep 14, 4:55 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray moved T251544: Add user journey performance tests for Vector's Legacy and Vue.js search from Needs Code Review to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 14, 3:50 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Wed, Sep 9

nray updated subscribers of T261802: Switch to header-first DOM.

Update on this task as I'm leaving on vacation tomorrow (and come back next Monday the 14th):

Wed, Sep 9, 1:41 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray moved T261802: Switch to header-first DOM from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Wed, Sep 9, 1:32 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector

Tue, Sep 8

nray moved T262213: XSS on Pages viewed on Mobile (CVE-2020-26120) from Needs triage to MobileFrontend specific on the Mobile board.
Tue, Sep 8, 7:03 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team

Mon, Sep 7

nray added a comment to T262213: XSS on Pages viewed on Mobile (CVE-2020-26120).

Below add patch on top of the origin/wmf/1.36.0-wmf.6 branch per @Reedy 's request

Mon, Sep 7, 11:13 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
nray added a comment to T262213: XSS on Pages viewed on Mobile (CVE-2020-26120).

@Reedy yes, I'm on (nray is my nick)

Mon, Sep 7, 10:42 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
nray added a comment to T262213: XSS on Pages viewed on Mobile (CVE-2020-26120).

@Platonides it's important to note that the code in question doesn't seem to affect the rendering of the section headings in the DOM regardless if the regex is there or not - that's server rendered. If you checkout master, the header with links still exists with your example. As far as I know, that's considered a feature (although it might be good to review that later on).

Mon, Sep 7, 10:34 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
nray added a comment to T262213: XSS on Pages viewed on Mobile (CVE-2020-26120).

Thank you @Platonides for the patches! I think those patches fix the immediate issue, however after discussing this with @phuedx today, we'd both like to try removing the lines relating to the regex altogether as their continued usage is questionable at best. The small patch below applies this removal

Mon, Sep 7, 10:07 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
nray added a comment to T262213: XSS on Pages viewed on Mobile (CVE-2020-26120).

It looks like this line 56 from PageGateway.js [1] is at least somewhat implicated in this:

Mon, Sep 7, 6:47 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Mobile, MobileFrontend, Vuln-XSS, Security, Security-Team
nray moved T261802: Switch to header-first DOM from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Mon, Sep 7, 4:33 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray claimed T261802: Switch to header-first DOM.
Mon, Sep 7, 4:32 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector

Fri, Sep 4

nray moved T251544: Add user journey performance tests for Vector's Legacy and Vue.js search from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Fri, Sep 4, 8:31 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)
nray added a comment to T251544: Add user journey performance tests for Vector's Legacy and Vue.js search.

Update: I have two more metrics to add when the TypeadheadSearch component is complete, but I think those should be pretty easy and the above patches can be reviewed now.

Fri, Sep 4, 8:30 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Thu, Sep 3

nray updated the task description for T261802: Switch to header-first DOM.
Thu, Sep 3, 8:22 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray updated the task description for T261802: Switch to header-first DOM.
Thu, Sep 3, 6:45 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray updated the task description for T261802: Switch to header-first DOM.
Thu, Sep 3, 6:44 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector
nray updated the task description for T261802: Switch to header-first DOM.
Thu, Sep 3, 6:44 PM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements, Vector

Wed, Sep 2

nray placed T249308: [Spike] How should i18n work for Vue.js search? up for grabs.
Wed, Sep 2, 3:57 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), I18n, Vue.js (Vue.js-Search), Spike, Desktop Improvements
nray closed T249308: [Spike] How should i18n work for Vue.js search? as Resolved.

message passing looks good to me 👍 @Niedzielski I noticed part of the acceptance criteria is to create a task for the implementation. Not sure if this is still needed, but lmk if it is and I'm happy to create one. Signing off for now

Wed, Sep 2, 3:56 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), I18n, Vue.js (Vue.js-Search), Spike, Desktop Improvements
nray closed T249308: [Spike] How should i18n work for Vue.js search?, a subtask of T249298: [Epic] Establish initial project scaffolding for Vue.js search iterations, as Resolved.
Wed, Sep 2, 3:56 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Epic, Desktop Improvements

Tue, Sep 1

nray added a comment to T240489: [SPIKE 8hrs] Determine the optimum Vector DOM structure for a11y and performance.

Thank you for the feedback @Gilles !

Tue, Sep 1, 3:53 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Performance-Team (Radar), Accessibility, Desktop Improvements

Aug 31 2020

nray added a comment to T254399: Sidebar: Add ability to take `prefers-reduced-motion` user setting into account.

Today we discussed this ticket at the end of standup and concluded that it was a bit too nebulous in its current form so we moved it back to needs analysis. Questions that came up during the discussion:

Aug 31 2020, 6:02 PM · Readers-Web-Backlog, CSS, MediaWiki-General, Accessibility

Aug 28 2020

nray moved T260412: [Spike 10hrs] Determine steps necessary for switch to header-first DOM from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 28 2020, 6:39 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
nray updated subscribers of T260412: [Spike 10hrs] Determine steps necessary for switch to header-first DOM.

I've spent some time investigating what it would take to de-absolutely position/establish a navigation-first DOM order. While there is considerable risk involved in doing this in large part due to potential caching issues, it is definitely possible.

Aug 28 2020, 6:38 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Aug 27 2020

nray added a comment to T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width.

@Mhurd you can try using the useskinversion=2 query param e.g. https://en.wikipedia.org/wiki/Barack_Obama?useskinversion=2 🙂

Aug 27 2020, 9:51 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Aug 26 2020

nray claimed T249308: [Spike] How should i18n work for Vue.js search?.
Aug 26 2020, 5:09 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), I18n, Vue.js (Vue.js-Search), Spike, Desktop Improvements

Aug 21 2020

nray moved T260412: [Spike 10hrs] Determine steps necessary for switch to header-first DOM from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 21 2020, 7:20 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Aug 13 2020

nray added a comment to T251544: Add user journey performance tests for Vector's Legacy and Vue.js search.

@Peter First, great work with Sitespeed.io! I found it incredibly powerful.

Aug 13 2020, 4:27 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Aug 11 2020

nray moved T251544: Add user journey performance tests for Vector's Legacy and Vue.js search from Ready to On Web Board on the Vue.js (Vue.js-Search) board.
Aug 11 2020, 11:54 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Aug 10 2020

nray moved T251544: Add user journey performance tests for Vector's Legacy and Vue.js search from Needs Analysis to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 10 2020, 9:26 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)
nray added a project to T251544: Add user journey performance tests for Vector's Legacy and Vue.js search: Readers-Web-Backlog (Kanbanana-2020-21-Q1).
Aug 10 2020, 9:25 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)
nray claimed T251544: Add user journey performance tests for Vector's Legacy and Vue.js search.
Aug 10 2020, 9:25 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Performance-Team (Radar)

Aug 6 2020

nray updated the task description for T259761: Reduce space between sidebar and content.
Aug 6 2020, 4:33 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
nray updated the task description for T259761: Reduce space between sidebar and content.
Aug 6 2020, 4:23 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements

Aug 5 2020

nray reassigned T257015: Redeploy quicksurvey on enwiki (for a Growth study) from nray to Edtadros.
Aug 5 2020, 6:20 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), QuickSurveys, Wikimedia-Site-requests
nray added a comment to T257015: Redeploy quicksurvey on enwiki (for a Growth study).

This has been deployed now. I verified on https://en.wikipedia.org/wiki/Barack_Obama?quicksurvey=external-survey-growth-study-screener-survey that it shows. Not sure if this needs to go through QA again, but I'll move it there just in case. @ovasileva feel free to move to sign off if you think it can skip QA

Aug 5 2020, 6:20 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), QuickSurveys, Wikimedia-Site-requests
nray updated the task description for T257015: Redeploy quicksurvey on enwiki (for a Growth study).
Aug 5 2020, 6:17 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), QuickSurveys, Wikimedia-Site-requests

Aug 4 2020

nray added a comment to T257015: Redeploy quicksurvey on enwiki (for a Growth study).

I've signed up to turn this on during the 18:00–19:00 UTC backport window tomorrow Wednesday, August 05.

Aug 4 2020, 6:33 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), QuickSurveys, Wikimedia-Site-requests
nray claimed T257015: Redeploy quicksurvey on enwiki (for a Growth study).
Aug 4 2020, 3:58 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), QuickSurveys, Wikimedia-Site-requests
nray moved T257015: Redeploy quicksurvey on enwiki (for a Growth study) from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Aug 4 2020, 3:57 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), QuickSurveys, Wikimedia-Site-requests

Jul 31 2020

nray closed T256038: Build the wvui-button component for Vue.js search, a subtask of T255902: [Epic] Build the component primitives for Vue.js search, as Resolved.
Jul 31 2020, 8:56 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search), Epic
nray closed T256038: Build the wvui-button component for Vue.js search, a subtask of T256041: Build the wvui-search-form component for Vue.js search, as Resolved.
Jul 31 2020, 8:56 PM · WVUI, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray closed T256038: Build the wvui-button component for Vue.js search as Resolved.

👍👍 Looks great! Great job!

Jul 31 2020, 8:56 PM · WVUI, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray closed T256038: Build the wvui-button component for Vue.js search, a subtask of T256043: Build the wvui-typeahead-search component for Vue.js search, as Resolved.
Jul 31 2020, 8:56 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray reassigned T256038: Build the wvui-button component for Vue.js search from nray to Niedzielski.
Jul 31 2020, 8:56 PM · WVUI, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)
nray added a comment to T258544: Technical: Reconsider logo implementation.

@Jdlrobson sorry for the delay on this. I had the following concerns with the status quo:

Jul 31 2020, 8:39 PM · Vector, Desktop Improvements
nray updated the task description for T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width.
Jul 31 2020, 8:04 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)
nray updated the task description for T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width.
Jul 31 2020, 8:03 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)
nray moved T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Jul 31 2020, 8:00 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)
nray added a comment to T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width.

Updated title/description because I don't think VE is required for this bug to surface - AFAICT it happens on any page where the viewport is small enough to wrap the personal menu

Jul 31 2020, 7:59 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)
nray renamed T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width from [Bug] Sidebar Expand/Collapse button impacted by Narrow Width and VE to [Bug] Sidebar Expand/Collapse button impacted by Narrow Width.
Jul 31 2020, 7:57 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)
nray updated the task description for T258465: [Bug] Sidebar Expand/Collapse button impacted by Narrow Width.
Jul 31 2020, 7:48 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Jul 29 2020

nray added a comment to T231168: Fit above-the-fold layout and first paragraph HTML in 14 KB.

However, for desktop (Vector) this currently does not include the skin layout., because in Vector that is currently at the end of the HTML payload.

Jul 29 2020, 4:42 AM · Desktop Improvements, MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Readers-Web-Backlog (Tracking), MediaWiki-Interface, Performance-Team
nray added a comment to T240489: [SPIKE 8hrs] Determine the optimum Vector DOM structure for a11y and performance.

Thanks @Volker_E and @Niedzielski . I dug into the performance aspects of a content-first vs header-first (plus sidebar, article toolbar, personal tools) DOM order more since that was identified by @Volker_E as potentially having the biggest impact:

Jul 29 2020, 4:37 AM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Performance-Team (Radar), Accessibility, Desktop Improvements

Jul 23 2020

nray claimed T256038: Build the wvui-button component for Vue.js search.
Jul 23 2020, 5:07 PM · WVUI, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Vue.js (Vue.js-Search)

Jul 21 2020

nray moved T240489: [SPIKE 8hrs] Determine the optimum Vector DOM structure for a11y and performance from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Jul 21 2020, 10:10 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Performance-Team (Radar), Accessibility, Desktop Improvements
nray added a comment to T240489: [SPIKE 8hrs] Determine the optimum Vector DOM structure for a11y and performance.

@ovasileva I think this ticket is pretty important for future DIP work (it certainly played a large role in T246420) and IMO should be prioritized. I'm moving to the upcoming column as I did some analysis of it today.

Jul 21 2020, 10:10 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Performance-Team (Radar), Accessibility, Desktop Improvements
nray added a comment to T240489: [SPIKE 8hrs] Determine the optimum Vector DOM structure for a11y and performance.

Now that the max-width ticket has been resolved (T246420, T257518), I think we should make this ticket a very high priority and do a thorough cost-benefit analysis of Vector's "content-first" DOM order status quo as there were many challenges I encountered during this work (e.g. T257518) that made me question its value, and I think the pitfalls associated with this DOM order will continue to pop up as we progress with the Desktop Improvements Project. Additionally, the further we progress through Desktop Improvements and the more hoops we have to jump through to make this DOM order work, the more costly it will be to change later.

Jul 21 2020, 10:07 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), Performance-Team (Radar), Accessibility, Desktop Improvements

Jul 16 2020

nray reassigned T254230: Sidebar should allow for different states for logged-in and anonymous users from nray to Peter.ovchyn.
Jul 16 2020, 11:21 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Desktop Improvements
nray closed T254230: Sidebar should allow for different states for logged-in and anonymous users, a subtask of T246419: Build collapsible sidebar and sidebar button , as Resolved.
Jul 16 2020, 11:21 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Readers-Web-Backlog (Kanbanana-2019-20-Q4), Patch-For-Review, Desktop Improvements
nray closed T254230: Sidebar should allow for different states for logged-in and anonymous users as Resolved.
Jul 16 2020, 11:21 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Desktop Improvements
nray updated the task description for T254230: Sidebar should allow for different states for logged-in and anonymous users.
Jul 16 2020, 11:19 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Desktop Improvements
nray added a comment to T254230: Sidebar should allow for different states for logged-in and anonymous users.

Tested VectorDefaultSidebarVisibleForAuthorisedUser flag (true/false) and VectorDefaultSidebarVisibleForAnonymousUserflag (true/false). Both seem to be working as they should!

Jul 16 2020, 11:19 PM · Readers-Web-Backlog (Kanbanana-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Desktop Improvements
nray added a comment to T246420: Limit content width, and refine alignment & styling of relevant elements.

@Edtadros That's kind of weird that IE11 does that (although it is IE), but I don't think it's very concerning.

Jul 16 2020, 4:34 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements

Jul 15 2020

nray updated the task description for T258116: Post deploy: Move search styles into layout.less (and other places) and remove temporary feature flags.
Jul 15 2020, 10:16 PM · Readers-Web-Backlog, Desktop Improvements
nray created T258116: Post deploy: Move search styles into layout.less (and other places) and remove temporary feature flags.
Jul 15 2020, 10:13 PM · Readers-Web-Backlog, Desktop Improvements

Jul 14 2020

nray updated the task description for T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 14 2020, 11:51 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements
nray updated the task description for T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 14 2020, 11:47 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements
nray updated the task description for T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 14 2020, 11:45 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements
nray updated the task description for T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 14 2020, 11:44 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements
nray updated the task description for T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 14 2020, 11:38 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements
nray created T257999: MobileFormatter lead paragraph transform alert rate has doubled since July 2.
Jul 14 2020, 11:03 PM · MobileFrontend, Readers-Web-Backlog (Kanbanana-2020-21-Q1)

Jul 13 2020

nray moved T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Jul 13 2020, 8:08 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements
nray moved T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board.
Jul 13 2020, 5:47 PM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-2020-21-Q1), Patch-For-Review, Desktop Improvements