Fri, Oct 18
Looks like @Jdlrobson is fixing this at https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/544221/
Tue, Oct 15
Mon, Oct 14
looks like the config needed here is $wgMFUseDesktopSpecialWatchlistPage. I think this is ready to be estimated?
@ovasileva I've made the copy read like Alex's wording in https://phabricator.wikimedia.org/T230016#5561195 but want to double check with you before merging. Is "Advanced mode provides easy access to talk pages, history pages, user tools, and other editing tools" okay?
Sat, Oct 12
Here are my findings from this investigation. Feel free to leave comments on the doc or on this ticket!
Thu, Oct 10
@Jdlrobson Should this go into design review or qa next?
Wed, Oct 9
Tue, Oct 8
@Amire80 I just sent you an invite on google calendar. Would love to chat with you a bit on the the language selector!
Mon, Oct 7
fwiw, I've been able to replicate a missing hamburger icon (although it can be very inconsistent) using the following html/css:
Fri, Oct 4
Update: I've messed around with this some more and I'm pretty convinced now that the background-size: contain in mediawiki.ui.icon.less is somehow implicated in at least the icons that I've see disappear (hamburger, language selector, search).
Thu, Oct 3
So I've been able to replicate both the hamburger and search icon missing on my iphone test device (iOS 12.0). Although all the following screenshots are from my local dev instance, I've also seen it on en wiki. Here is a screenshot locally and comparisons between the .mw-ui-icon element, the :before element, and the network request for when the hamburger icon shows and doesn't show:
Wed, Oct 2
I'm waiting for this to be on beta and then will add qa steps
Tue, Oct 1
thanks @alexhollender . I'll just focus on the mobile alignment for now
Mon, Sep 30
Fri, Sep 27
Thu, Sep 26
Wed, Sep 25
I'm pulling this into needs design review because I'm not really sure how to proceed with this ticket until ^^ has been answered
@alexhollender Can you clarify what the ideal alignment for the user icon is on tablet size? I'm confused because part of the QA instructions for this ticket says:
thanks for the heads up @TheSandDoctor! I've made the necessary changes to those patches and everything looks good now
for more info: https://phabricator.wikimedia.org/T185233
Tue, Sep 24
@pmiazga Would it be wise to add another user mode under includes/features in MF to account for logged in users?
Sep 19 2019
Sep 16 2019
I don't notice this anymore on beta. Has this been resolved already?
Sep 13 2019
Sep 12 2019
Looks like Jon and I made a ticket for this at the same time:
Sep 11 2019
Ticket created at https://phabricator.wikimedia.org/T232690
Last 7 days:
- LazyImageTransform Timeouts: 7
- MobileFormatter Timeouts: 10
Sep 10 2019
thanks @ovasileva . Also, sorry if this was already answered in grooming (I think Jon asked it in the chat), but I'm wondering what should happen if the user loads the talk modal from the url (e.g. user goes to https://en.m.wikipedia.org/wiki/Barack_Obama#/talk). Should we show the drawer or not?
@ovasileva Can you also clarify what should happen when the user taps the black part of the overlay (area outside the drawer)? I'm assuming/hoping (in terms of work involved) that it should be the same behavior as when the user selects the "No thanks" button?
@pmiazga I moved this to QA, but I'm not sure if this is more design QA. Either way, can you add the appropriate QA steps and ensure this is in the right column?
Sep 9 2019
Sep 5 2019
@alexhollender I'm not sure if you'd be interested in reviewing this or not, but if you are, you can see the changes on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&limit=50&days=7&enhanced=1&damaging__likelygood_color=c2&urlversion=2
Sep 4 2019
^^ I can reproduce that on iPhone 6 Plus and Pixel 2 XL