Page MenuHomePhabricator

nray (Nick Ray)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2018, 4:57 PM (85 w, 5 d)
Availability
Available
LDAP User
Nray
MediaWiki User
NRay (WMF) [ Global Accounts ]

Recent Activity

Fri, Feb 21

nray added a comment to T245456: [Dev] Adopt template partials in Vector and revise sidebar component.

If my description sounds entirely vague or nonsensical to you, it's probably because it is! I'm having trouble articulating the approach I'm proposing, but I'm spending some time today to work out a POC patch that will hopefully explain it much better!

Fri, Feb 21, 3:58 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Thu, Feb 20

nray added a comment to T243281: Build opt-out button for logged-in users with new vector on.

Please see https://phabricator.wikimedia.org/T245456#5901923 for the latest on this task. I think figuring out the correct approach for that ticket is actually a prerequisite for this ticket and is what I'm focusing on right now

Thu, Feb 20, 7:29 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
nray added a comment to T245456: [Dev] Adopt template partials in Vector and revise sidebar component.

I've been looking at @Jdlrobson's POC patches related to template partials in trying to determine how to do T243281 (Note the note at the top of the task!). So far they look good to me, but I'm trying to work out if the following AC is the right approach:

Thu, Feb 20, 7:26 PM · Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Wed, Feb 19

nray added a comment to T243281: Build opt-out button for logged-in users with new vector on.

@Volker_E Regarding users who mistakenly click the button, my understanding of the AC is that the button is simply a link to the user preferences page appearance tab and that clicking on it will not actually perform the toggle (users will still have to opt-out after clicking the button)

Wed, Feb 19, 10:27 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Tue, Feb 18

nray updated the task description for T243650: Regression: Mobile talk page shows links in overlay header.
Tue, Feb 18, 11:47 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MinervaNeue
nray added a comment to T243650: Regression: Mobile talk page shows links in overlay header.

Path has been +2'd, I just need to add QA steps which I'm doing now...

Tue, Feb 18, 11:35 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MinervaNeue
nray assigned T243650: Regression: Mobile talk page shows links in overlay header to Edtadros.
Tue, Feb 18, 11:33 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MinervaNeue
nray claimed T243281: Build opt-out button for logged-in users with new vector on.
Tue, Feb 18, 10:03 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
nray moved T243281: Build opt-out button for logged-in users with new vector on from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 18, 10:03 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Fri, Feb 14

nray added a comment to T244481: Provide basic FeatureManagement in Vector codebase.

a composite - for example only 100 edits that visits a specific namespace $set = new CompositeSet( [ new VisitingNamespace ( NS_TALK ), new ContributorEditsCheck( 100 ) )

Fri, Feb 14, 9:48 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
nray placed T239258: Migrate JavaScript API documentation from jsduck to JSDoc up for grabs.
Fri, Feb 14, 7:44 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
nray updated the task description for T244481: Provide basic FeatureManagement in Vector codebase.
Fri, Feb 14, 6:22 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements

Thu, Feb 13

nray moved T239258: Migrate JavaScript API documentation from jsduck to JSDoc from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Thu, Feb 13, 5:07 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
nray added a comment to T239258: Migrate JavaScript API documentation from jsduck to JSDoc.

https://gerrit.wikimedia.org/r/571841 is ready for review which replaces the duck with the doc.

Thu, Feb 13, 12:45 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
nray moved T239258: Migrate JavaScript API documentation from jsduck to JSDoc from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Thu, Feb 13, 12:43 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt

Tue, Feb 11

nray added a comment to T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector.

Okay, this is probably a bit of scope creep now but there actually is one more patch I'd like to get merged before this task is resolved:

Tue, Feb 11, 11:07 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt
nray updated subscribers of T244369: Deploy WikidataPageBanner extension on trwiki.

Just a check with Web that you're OK with this change and it doesn't go against any plans. If you're OK, I deploy it later today.

Tue, Feb 11, 9:44 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Wikimedia-Site-requests, Wikidata, Wikidata-Page-Banner
nray added a comment to T244369: Deploy WikidataPageBanner extension on trwiki.

I will look at this today

Tue, Feb 11, 6:15 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Wikimedia-Site-requests, Wikidata, Wikidata-Page-Banner
nray claimed T239258: Migrate JavaScript API documentation from jsduck to JSDoc.
Tue, Feb 11, 5:56 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
nray moved T239258: Migrate JavaScript API documentation from jsduck to JSDoc from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 11, 5:56 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
nray placed T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector up for grabs.
Tue, Feb 11, 5:47 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt
nray moved T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 11, 5:47 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt
nray added a comment to T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector.

@phuedx Not anymore, I think this is ready for sign off now, There are still some topics I'd like to discuss in our next shdt whenever that may be, but I don't think that should block the resolution of this task.

Tue, Feb 11, 5:47 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt

Sat, Feb 8

nray created T244629: Popups on beta server display "There was an issue displaying this preview" message.
Sat, Feb 8, 1:28 AM · RESTBase-API, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray awarded T243925: Grant +2 gerrit rights for @polishdeveloper a Like token.
Sat, Feb 8, 1:13 AM · MediaWiki-Gerrit-Group-Requests, Gerrit-Privilege-Requests

Thu, Feb 6

nray added a comment to T237635: [SPIKE] What should feature management look like in desktop improvements?.

Remove the notion of groups from the system. AFAICT Feature#getGroup is only ever invoked in a unit test. Therefore, it only serves to increase entropy

Thu, Feb 6, 4:53 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Wed, Feb 5

nray moved T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Wed, Feb 5, 5:36 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt

Jan 21 2020

nray updated subscribers of T243071: Update PrefUpdate schema to include edit count .

We (@Jdrewniak, @phuedx, and I) voted this as a medium today in part because there is chance to unify client side edit count bucket related code with the code that lives in onUserSaveOptions. @phuedx could you remind me again where the client side code lives that we would want to unify?

Jan 21 2020, 6:48 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray claimed T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector.
Jan 21 2020, 3:56 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt
nray moved T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 21 2020, 3:56 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt

Jan 16 2020

nray reassigned T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either from nray to Edtadros.
Jan 16 2020, 11:08 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue
nray updated the task description for T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either.
Jan 16 2020, 10:41 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue
nray updated the task description for T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either.
Jan 16 2020, 10:39 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue
nray added a comment to T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.

Good point. How about "Advanced mode provides expanded functionality of History pages, Watchlist pages, Recent changes, and other editor tools on mobile". Still not perfect, so open to suggestions

Jan 16 2020, 8:11 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray updated subscribers of T236722: [Spike, 10hrs] Investigate automated visual regression tools.

I think removing it as a quarterly goal makes sense for now as I think we have more important things we can focus on first (e.g. I certainly wouldn't prioritize it over adding unit tests in vector and some of the other foundational work that we've discussed for desktop improvements). However, I do plan to invest more time in this in my 10% time as I still think it has potential to help.

Jan 16 2020, 1:12 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Spike
nray moved T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 16 2020, 12:40 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue

Jan 14 2020

nray updated subscribers of T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.

@ovasileva What would you like the updated copy on the amc outreach drawer to be? It is currently:

Jan 14 2020, 7:30 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray assigned T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible to Edtadros.
Jan 14 2020, 7:27 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray moved T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible from Needs More Work to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 14 2020, 7:17 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray updated the task description for T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.
Jan 14 2020, 7:12 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray updated the task description for T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.
Jan 14 2020, 7:12 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray added a comment to T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.

Found a regression on talk page that needs a fix:

Jan 14 2020, 6:03 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray moved T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible from Needs QA to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 14 2020, 6:02 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray claimed T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either.
Jan 14 2020, 4:49 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue
nray moved T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 14 2020, 4:49 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue

Jan 13 2020

nray updated the task description for T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.
Jan 13 2020, 7:50 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray placed T236722: [Spike, 10hrs] Investigate automated visual regression tools up for grabs.
Jan 13 2020, 7:48 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Spike
nray moved T236722: [Spike, 10hrs] Investigate automated visual regression tools from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 13 2020, 7:48 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Spike
nray updated the task description for T236722: [Spike, 10hrs] Investigate automated visual regression tools.
Jan 13 2020, 7:48 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Spike
nray added a comment to T236722: [Spike, 10hrs] Investigate automated visual regression tools.

Here are the main points I have surrounding visual regression testing:

Jan 13 2020, 7:47 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Spike

Jan 11 2020

nray updated the task description for T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.
Jan 11 2020, 1:03 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray updated the task description for T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.
Jan 11 2020, 12:55 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)
nray created T242491: Regression: AMC Outreach Drawer doesn't open when user is eligible.
Jan 11 2020, 12:53 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, Patch-For-Review, Advanced Mobile Contributions, MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Jan 9 2020

nray placed T198265: Special:MobileOptions is empty for third parties and when beta is disabled and this is confusing up for grabs.
Jan 9 2020, 5:40 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Reading-Web-Third-Party-Support, MobileFrontend, Mobile-Web-Settings

Jan 8 2020

nray added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

Patches to review:

Jan 8 2020, 6:13 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 7 2020

nray moved T234570: Tech debt: Drop Browser.supportsAnimations method from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 7 2020, 11:53 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

@Jdrewniak That's a great idea, and I took a shot at doing this in:

Jan 7 2020, 11:24 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T234570: Tech debt: Drop Browser.supportsAnimations method from Needs Code Review to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 7 2020, 6:00 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray placed T239295: Placeholder: Run display locking origin trial up for grabs.
Jan 7 2020, 4:50 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Jan 6 2020

nray added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

I made a minimal test case of the bug at https://quizzical-bhabha-d9a97e.netlify.com/. Notice the red box moving down when the page loads in chrome - that shouldn't happen as the only css is the following:

Jan 6 2020, 10:41 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray updated subscribers of T234570: Tech debt: Drop Browser.supportsAnimations method.

The video attached is what I'm seeing.

Jan 6 2020, 9:42 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

@Jdlrobson I've been able to replicate it on the latest Chrome version 79.0.3945.88 (Mac) so I don't think the bug has been resolved yet. The bug ticket is still open too.

Jan 6 2020, 8:21 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.

I think this is because of the .animations class which is added via JS for historical reasons. I think we have a bug somewhere to remove (and if we haven't got a bug we should create a bug to do that!)

Jan 6 2020, 4:57 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
nray moved T236722: [Spike, 10hrs] Investigate automated visual regression tools from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Jan 6 2020, 4:35 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Spike

Jan 2 2020

nray added a comment to T234570: Tech debt: Drop Browser.supportsAnimations method.

So I have two patches ready that should knock out the .animations class and the supportsAnimations method, but the only problem is I think this makes the chrome animation flash bug (https://bugs.chromium.org/p/chromium/issues/detail?id=332189) rear its ugly head again.

Jan 2 2020, 11:01 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T234570: Tech debt: Drop Browser.supportsAnimations method from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Jan 2 2020, 10:54 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T234570: Tech debt: Drop Browser.supportsAnimations method from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Jan 2 2020, 10:40 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray claimed T234570: Tech debt: Drop Browser.supportsAnimations method.
Jan 2 2020, 8:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
nray moved T234570: Tech debt: Drop Browser.supportsAnimations method from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Jan 2 2020, 8:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Dec 20 2019

nray added a comment to T230695: Render talk page as a tab (rather than a modal).

I recommend opening a new ticket if this is still a problem as I don't think the fix will be trivial

It looks better currently than it did when I took that video. Regarding further fixes does this task describe the work we'd need to do? T219388

Dec 20 2019, 6:49 PM · User-notice, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Thanks so much to all the people involved in making this happen (FAWG, @Niedzielski, others)! The points outlined in the RFC are articulated very well, and I am excited for the future ahead

Dec 20 2019, 6:32 PM · Security-Team, TechCom-RFC
nray awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Dec 20 2019, 6:24 PM · Security-Team, TechCom-RFC
nray moved T240502: Raw HTML in MobileFrontend from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 20 2019, 12:59 AM · Security, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend
nray placed T240502: Raw HTML in MobileFrontend up for grabs.
Dec 20 2019, 12:59 AM · Security, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend

Dec 19 2019

nray added a comment to T240502: Raw HTML in MobileFrontend.

@sbassett gerrit patch has now been updated at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/559557/ and ready to be deployed. Thank you!

Dec 19 2019, 9:37 PM · Security, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend
nray added a comment to T240502: Raw HTML in MobileFrontend.

Attached is the patch to add all of the listed messages + 1 other one in the RawHtmlMessages array. I'm not sure if putting the patch here matters since I already screwed up (I think) and pushed the patch to gerrit (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/559557/) before realizing this task was set to hidden. I'll try to be much more careful about this in the future.

Dec 19 2019, 7:31 PM · Security, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend

Dec 18 2019

nray claimed T240502: Raw HTML in MobileFrontend.
Dec 18 2019, 7:41 PM · Security, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend
nray moved T240502: Raw HTML in MobileFrontend from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 18 2019, 7:41 PM · Security, Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend
nray added a project to T240910: Link for PageTriage in tool menu looks broken in MinervaNeue: Readers-Web-Backlog.
Dec 18 2019, 12:40 AM · MinervaNeue (Tracking), Readers-Web-Backlog, Growth-Team, PageCuration
nray added a project to T240976: Mobile "new messages" notification should be more intrusive by default: Readers-Web-Backlog.
Dec 18 2019, 12:39 AM · Readers-Web-Backlog, MobileFrontend
nray added a project to T240531: Dashiki diffs fail on mobile: "The slot diff renderer for text content should be a TextSlotDiffRenderer subclass": Readers-Web-Backlog.
Dec 18 2019, 12:38 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend, MediaWiki-extensions-Dashiki, Wikimedia-production-error

Dec 17 2019

nray added a comment to T232653: Updates to user pages for all users.

@ovasileva @Edtadros This is now ready to test on mediawiki.org. QA steps have been updated with new urls as well as more explicit info. @ovasileva feel free to double check the qa steps I updated, I think think they reflect what the AC should be but it probably wouldn't hurt to have another pair of eyes on it

Dec 17 2019, 8:26 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray updated the task description for T232653: Updates to user pages for all users.
Dec 17 2019, 8:23 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Dec 16 2019

nray updated subscribers of T235681: [AMC] Toolbar on User talk page should match toolbar on User page.
Dec 16 2019, 6:20 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray reassigned T232653: Updates to user pages for all users from nray to Edtadros.
Dec 16 2019, 6:03 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray added a comment to T235681: [AMC] Toolbar on User talk page should match toolbar on User page.

Given that the AC listed in this ticket is part of T232653 (which also has the necessary QA steps), I propose we close out this ticket

Dec 16 2019, 5:57 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray updated the task description for T232653: Updates to user pages for all users.
Dec 16 2019, 5:55 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray updated the task description for T232653: Updates to user pages for all users.
Dec 16 2019, 5:41 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Dec 14 2019

nray added a comment to T238364: [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either.

Looking into this some more, I think the URIs that are not impacted by the table of contents bug can be fixed with a simple encodeURIComponent. That's what my patch does. AS for the other characters - that should be handled in the parser.

Dec 14 2019, 12:57 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-TheDJ, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue
nray moved T240728: [Bug] Latin Wikipedia has a stretched logo (was `Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site`) from Needs triage to Triaged on the Mobile board.
Dec 14 2019, 12:25 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Wikimedia-Site-requests
nray added a project to T240728: [Bug] Latin Wikipedia has a stretched logo (was `Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site`): Readers-Web-Backlog.
Dec 14 2019, 12:24 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Wikimedia-Site-requests

Dec 13 2019

nray added a comment to T240487: XSS in MinervaNeue skin (CVE-2019-19910).

thanks @sbassett . Yes, I think that's more of a bug than related to the xss vector. I'll open a separate ticket for that. I appreciate all of your help along with @suffusion_of_yellow !

Dec 13 2019, 8:50 PM · Security, user-sbassett, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Vuln-XSS
nray added a comment to T240487: XSS in MinervaNeue skin (CVE-2019-19910).
<h2><span class="section-heading"><span class="mw-headline"><img src="blah.jpg" onmouseover="alert('XSS')"></span></span><span class="mf-section-1">blah</span></h2>

In regards to the above example where the overlay opens automatically on page load, I think the is due to that .section-heading element which the code interprets as a valid section and since its child .mw-headline element doesn't have a id on it, the router opens the overlay thinking it matches a route without a hash.

Dec 13 2019, 8:27 PM · Security, user-sbassett, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Vuln-XSS
nray updated subscribers of T240487: XSS in MinervaNeue skin (CVE-2019-19910).

@Reedy @sbassett I think this does unfortunately have an impact on production. I think it occurs because of the following line which unescapes escaped html:

Dec 13 2019, 6:33 PM · Security, user-sbassett, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Vuln-XSS
nray added a comment to T240487: XSS in MinervaNeue skin (CVE-2019-19910).

I spoke too soon. I think this could impact production on certain browsers where the overlay is able to open. There is currently a bug T238364 that prevents the overlay from opening in certain browsers with certain characters. Given that the characters > and < are relevant here, that ticket shows that safari 13.0.3 and iOS Safari 12.0 (probably others) are able to open the overlay and could be impacted.

Dec 13 2019, 1:49 AM · Security, user-sbassett, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Vuln-XSS
nray added a comment to T240487: XSS in MinervaNeue skin (CVE-2019-19910).

Thanks for brining this up. I believe this has impacted 3rd party wikis only as our wmf-config has the following config:

Dec 13 2019, 1:18 AM · Security, user-sbassett, MinervaNeue, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Vuln-XSS

Dec 12 2019

nray added a comment to T232653: Updates to user pages for all users.
Anon user pageAnon user talk pageLogged in user pageLogged in user talk pageAMC user pageAMC user talk page
Dec 12 2019, 11:21 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
nray moved T235681: [AMC] Toolbar on User talk page should match toolbar on User page from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 12 2019, 12:35 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Dec 11 2019

nray moved T232653: Updates to user pages for all users from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 11 2019, 8:12 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Dec 10 2019

nray added a comment to T235681: [AMC] Toolbar on User talk page should match toolbar on User page.

I've moved this ticket to doing as the work for T232653 is closely related to this work considering the contributions icon should be part of the toolbar on both user pages and user talk pages for logged in users (https://phabricator.wikimedia.org/T232653#5730229)

Dec 10 2019, 11:57 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions