Page MenuHomePhabricator

osorio-juan-microsoft (Juan Osorio (Microsoft))
Software Development Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 16 2018, 11:34 PM (48 w, 1 d)
Availability
Available
LDAP User
Juan Osorio (Microsoft)
MediaWiki User
Unknown

I like open source.

Recent Activity

Yesterday

osorio-juan-microsoft updated the task description for T18691: RFC: Section header "share" link.
Wed, Sep 18, 11:52 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Thu, Sep 12

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.
  1. We don't know if this is proposed purely as a third party feature, or for deployment on WMF systems. If it's just for 3rd parties, it may not even need an RFC, and could perhaps be done as an extension as well. If it's for WMF production, we will have to look very closely on the implications for caching and overall performance.
Thu, Sep 12, 8:25 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Mon, Sep 9

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

I'm going to move this into CPT's clinic duty for review but we'll need the merge conflict resolved first if that's ok.

Mon, Sep 9, 6:51 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jul 25 2019

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

@Esanders @alexhollender I have removed some of the extra styles so that the copy field looks the same as the other CopyTextLayouts.

Jul 25 2019, 11:37 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jun 14 2019

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

There is now an mw.widgets.CopyTextLayout in core, as used on the URL shortener (https://meta.wikimedia.org/wiki/Special:UrlShortener):

Jun 14 2019, 4:17 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jun 12 2019

osorio-juan-microsoft moved T18691: RFC: Section header "share" link from Backlog to General requests on the MediaWiki-Interface board.
Jun 12 2019, 11:01 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
osorio-juan-microsoft moved T18691: RFC: Section header "share" link from Stalled/More Info Needed to For Review on the Design board.
Jun 12 2019, 11:00 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
osorio-juan-microsoft moved T18691: RFC: Section header "share" link from Blocked to Designing/discussing right now on the Readers-Web-Backlog (Design) board.
Jun 12 2019, 11:00 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jun 3 2019

osorio-juan-microsoft updated osorio-juan-microsoft.
Jun 3 2019, 5:51 PM

May 31 2019

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

I think I mean the former? I'm not entirely clear on what the technical distinction would imply. :-) The main thing I want to avoid, is having to manually replace the underscores with spaces, which I currently have to do whenever I copy part of the URL from the browser-address-bar. (I/we remove the underscores because otherwise they lead to linewrap issues, as well as being not an actual part of the title).

I have to think about this one because it should still be valid Wikitext for subsections with special characters like ] (closing square bracket)

May 31 2019, 10:08 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.
  1. Would it be possible to strip the underscore _ character out of the Heading_text in the Wikitext version?

By this, do you mean we should place the subsection title as-is after the # on the Wikitext version? Or just replace underscores with spaces?

May 31 2019, 8:42 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

May 30 2019

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

This is the current implementation I have pushed:

May 30 2019, 4:41 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

May 19 2019

osorio-juan-microsoft added a comment to T215391: Graphs are constantly being regenerated, no matter what.

I ran into an issue where graphs were being regenerated because of a bug in LocalFile. I have since pushed a fix for it, and now our graphs are not being regenerated unless their source changes.

May 19 2019, 8:27 PM · Patch-For-Review, GraphViz

Apr 9 2019

osorio-juan-microsoft added a comment to T129546: Support preserving external links in pasted HTML content.

It seems like things may not be as "plaintext" under the hood as I thought.

Apr 9 2019, 8:16 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor, VisualEditor-CopyPaste
osorio-juan-microsoft added a comment to T129546: Support preserving external links in pasted HTML content.

@DLynch hmm, am I going crazy or missing something?
Also, I'm pasting from sources within the browser outside of the Mediawiki instance. Either from the URL bar, or copy/pasting from plain text on a page. Both seem to be converted to external links on test2.

Apr 9 2019, 6:14 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor, VisualEditor-CopyPaste

Apr 5 2019

osorio-juan-microsoft edited projects for T220055: Internal links surrounded by square brackets should be parsed correctly, added: Parsoid; removed MediaWiki-Parser.
Apr 5 2019, 9:52 PM · Parsoid
osorio-juan-microsoft created T220244: LocalFile isMissing always returns true regardless of file stat.
Apr 5 2019, 9:33 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multimedia, Commons, MediaWiki-File-management

Apr 4 2019

osorio-juan-microsoft added a comment to T220055: Internal links surrounded by square brackets should be parsed correctly.

So that's pretty much "how it's supposed to work". Changing this would be wikitext 2.0-scope work.

Apr 4 2019, 8:55 PM · Parsoid

Apr 3 2019

osorio-juan-microsoft created T220055: Internal links surrounded by square brackets should be parsed correctly.
Apr 3 2019, 11:13 PM · Parsoid

Mar 5 2019

osorio-juan-microsoft closed T217701: Allow wikitext on upload-form-label-own-work as Resolved.

Looks like the commit dcf408fc8e7816715a0a203b1c4ed1f873579750 has already fixed this.

Mar 5 2019, 9:39 PM · Multimedia, MediaWiki-Uploading
osorio-juan-microsoft created T217701: Allow wikitext on upload-form-label-own-work.
Mar 5 2019, 7:59 PM · Multimedia, MediaWiki-Uploading

Mar 1 2019

osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

I like the idea of the share button, even though it adds an extra click to a relatively simple action. However, what are we doing to address the earlier concern of placing more actions next to the Edit action, when Edit is the most important action on a wiki? Also, do we need to consider the mobile case as well (i.e. creating a solution for mobile browsing parallel to a desktop version)?

Mar 1 2019, 7:37 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Feb 5 2019

osorio-juan-microsoft added a comment to T208631: Copy/Paste of images in Visual editor does not work browser page to browser page as expected.

Pinging stakeholders: It seems to me that a good potential solution would be to use the image (rather than the HTML) if and only if the HTML content only contains metadata node, empty text nodes, and the image(s) themselves. In other words, if the HTML contains any actual content (text or otherwise) other than the image(s), it should be used instead of the image. I have some working fix that I validated by pasting a single image from multiple popular sources, such as Chrome, One Note, and Word. If nobody has objections to the implementation, I'll go ahead and submit a patch.

Feb 5 2019, 12:39 AM · Verified, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), VisualEditor (Current work), VisualEditor-EditingTools

Feb 1 2019

osorio-juan-microsoft added a comment to T93081: VE should translate <span style="font-weight: bold">...</span> into <b>...</b>.

No worries, I'll take a look to see if this is an easy bug to fix, and if so I'll submit a patch

Feb 1 2019, 9:03 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), VisualEditor (Current work), Patch-For-Review, VisualEditor-DataModel, Epic, VisualEditor-CopyPaste

Jan 28 2019

osorio-juan-microsoft added a comment to T93081: VE should translate <span style="font-weight: bold">...</span> into <b>...</b>.

@MarkAHershberger The output from MS Word Online is the following:

Jan 28 2019, 11:12 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), VisualEditor (Current work), Patch-For-Review, VisualEditor-DataModel, Epic, VisualEditor-CopyPaste

Jan 24 2019

osorio-juan-microsoft added a comment to T93081: VE should translate <span style="font-weight: bold">...</span> into <b>...</b>.

@MarkAHershberger Hi! Any update on this?

Jan 24 2019, 10:19 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), VisualEditor (Current work), Patch-For-Review, VisualEditor-DataModel, Epic, VisualEditor-CopyPaste
osorio-juan-microsoft awarded T93081: VE should translate <span style="font-weight: bold">...</span> into <b>...</b> a 100 token.
Jan 24 2019, 10:18 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), VisualEditor (Current work), Patch-For-Review, VisualEditor-DataModel, Epic, VisualEditor-CopyPaste

Jan 23 2019

osorio-juan-microsoft updated subscribers of T211914: WinCache increment loses TTL information.

@Krinkle Do you think you could help me take a look at this one?

Jan 23 2019, 7:27 PM · Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-Cache
osorio-juan-microsoft added a comment to T18691: RFC: Section header "share" link.

I'm guessing this is something one of the WMF teams wants to own, but in terms of community contributions, is there anything we can do to help move this along?

Jan 23 2019, 7:14 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface
osorio-juan-microsoft awarded T18691: RFC: Section header "share" link a Burninate token.
Jan 23 2019, 7:12 PM · Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog, Patch-For-Review, TechCom-RFC, Design, MediaWiki-Interface

Jan 22 2019

osorio-juan-microsoft triaged T211914: WinCache increment loses TTL information as Normal priority.
Jan 22 2019, 5:58 PM · Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-Cache

Jan 16 2019

osorio-juan-microsoft created T213950: Links: External links with special characters, and surrounded by square brakets, are not rendered properly.
Jan 16 2019, 6:00 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor-MediaWiki-Links, VisualEditor

Jan 14 2019

osorio-juan-microsoft awarded T208631: Copy/Paste of images in Visual editor does not work browser page to browser page as expected a Burninate token.
Jan 14 2019, 7:02 PM · Verified, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), VisualEditor (Current work), VisualEditor-EditingTools

Jan 11 2019

osorio-juan-microsoft moved T211914: WinCache increment loses TTL information from Backlog to libs/objectcache on the MediaWiki-Cache board.
Jan 11 2019, 11:31 PM · Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-Cache

Jan 9 2019

osorio-juan-microsoft closed T213115: VisualEditor: Pasting multi-level lists is broken as Resolved.

I see, that makes sense, thanks matmarex! This specific issue seems to have been fixed on VisualEditor (master, 9e2b9c6). Thanks!

Jan 9 2019, 1:02 AM · User-Ryasmeen, VisualEditor

Jan 7 2019

osorio-juan-microsoft created T213115: VisualEditor: Pasting multi-level lists is broken.
Jan 7 2019, 9:13 PM · User-Ryasmeen, VisualEditor

Dec 14 2018

osorio-juan-microsoft added a comment to T129546: Support preserving external links in pasted HTML content.

Bumping this thread. Maybe making this configurable would be the best option (i.e. via LocalSettings.php or such)? With external links being blocked by default?

Dec 14 2018, 11:57 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor, VisualEditor-CopyPaste

Dec 13 2018

osorio-juan-microsoft created T211914: WinCache increment loses TTL information.
Dec 13 2018, 7:12 PM · Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-Cache

Nov 29 2018

osorio-juan-microsoft created T210794: WinCache Bug - Keys (e.g. Headings) with more than 150 characters.
Nov 29 2018, 9:49 PM · Performance-Team, MediaWiki-Cache

Nov 14 2018

osorio-juan-microsoft closed T207680: Make GraphViz 3.x Configurable Again as Resolved.
Nov 14 2018, 12:53 AM · Patch-For-Review, GraphViz

Nov 13 2018

osorio-juan-microsoft added a comment to T207680: Make GraphViz 3.x Configurable Again.

@Samwilson I've submitted a new patch for single setting items. Let me know if this is better!

Nov 13 2018, 7:11 PM · Patch-For-Review, GraphViz

Nov 8 2018

osorio-juan-microsoft added a comment to T207680: Make GraphViz 3.x Configurable Again.

@Samwilson You're right! Sorry I missed this.

Nov 8 2018, 5:19 PM · Patch-For-Review, GraphViz

Nov 6 2018

osorio-juan-microsoft added a comment to T208841: git-changed-in-head breaks with paths with spaces in.

For the bug linked, there is an added benefit of having the test scripts on a path with spaces (running shell commands with executables/arguments located in a path that has spaces is a common issue in Windows). Although the linter may complain in this setup, some MediaWiki developers may want to run shell commands with spaces in them, and the tests must validate that such shell commands work as expected. Is there a way to mark files as not linted?

Nov 6 2018, 5:25 PM · Patch-For-Review, Continuous-Integration-Infrastructure

Oct 25 2018

osorio-juan-microsoft added a comment to T207248: Dot Quoted String regex is broken.

@Samwilson Thanks for all the help! I've added a test alongside the fix. Is anything missing for getting it merged?

Oct 25 2018, 6:41 PM · Patch-For-Review, GraphViz
Samwilson awarded T207680: Make GraphViz 3.x Configurable Again a Like token.
Oct 25 2018, 9:31 AM · Patch-For-Review, GraphViz

Oct 24 2018

osorio-juan-microsoft added a comment to T183759: MediaWiki::shell with parameter fails on Windows.

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

Oct 24 2018, 4:29 PM · Patch-For-Review, SyntaxHighlight, MediaWiki-Shell, MediaWiki-extensions-Score
osorio-juan-microsoft claimed T183759: MediaWiki::shell with parameter fails on Windows.
Oct 24 2018, 4:21 PM · Patch-For-Review, SyntaxHighlight, MediaWiki-Shell, MediaWiki-extensions-Score

Oct 22 2018

osorio-juan-microsoft created T207680: Make GraphViz 3.x Configurable Again.
Oct 22 2018, 6:07 PM · Patch-For-Review, GraphViz

Oct 17 2018

osorio-juan-microsoft updated the task description for T207248: Dot Quoted String regex is broken.
Oct 17 2018, 12:52 AM · Patch-For-Review, GraphViz
osorio-juan-microsoft created T207248: Dot Quoted String regex is broken.
Oct 17 2018, 12:51 AM · Patch-For-Review, GraphViz