Sun, May 19
I ran into an issue where graphs were being regenerated because of a bug in LocalFile. I have since pushed a fix for it, and now our graphs are not being regenerated unless their source changes.
Apr 9 2019
Apr 5 2019
Apr 4 2019
Apr 3 2019
Mar 5 2019
Looks like the commit dcf408fc8e7816715a0a203b1c4ed1f873579750 has already fixed this.
Mar 1 2019
I like the idea of the share button, even though it adds an extra click to a relatively simple action. However, what are we doing to address the earlier concern of placing more actions next to the Edit action, when Edit is the most important action on a wiki? Also, do we need to consider the mobile case as well (i.e. creating a solution for mobile browsing parallel to a desktop version)?
Feb 5 2019
Pinging stakeholders: It seems to me that a good potential solution would be to use the image (rather than the HTML) if and only if the HTML content only contains metadata node, empty text nodes, and the image(s) themselves. In other words, if the HTML contains any actual content (text or otherwise) other than the image(s), it should be used instead of the image. I have some working fix that I validated by pasting a single image from multiple popular sources, such as Chrome, One Note, and Word. If nobody has objections to the implementation, I'll go ahead and submit a patch.
Feb 1 2019
No worries, I'll take a look to see if this is an easy bug to fix, and if so I'll submit a patch
Jan 28 2019
@MarkAHershberger The output from MS Word Online is the following:
Jan 24 2019
@MarkAHershberger Hi! Any update on this?
Jan 23 2019
@Krinkle Do you think you could help me take a look at this one?
I'm guessing this is something one of the WMF teams wants to own, but in terms of community contributions, is there anything we can do to help move this along?
Jan 22 2019
Jan 16 2019
Jan 14 2019
Jan 11 2019
Jan 9 2019
I see, that makes sense, thanks matmarex! This specific issue seems to have been fixed on VisualEditor (master, 9e2b9c6). Thanks!
Jan 7 2019
Dec 14 2018
Bumping this thread. Maybe making this configurable would be the best option (i.e. via LocalSettings.php or such)? With external links being blocked by default?
Dec 13 2018
Nov 29 2018
Nov 14 2018
Nov 13 2018
@Samwilson I've submitted a new patch for single setting items. Let me know if this is better!
Nov 8 2018
@Samwilson You're right! Sorry I missed this.
Nov 6 2018
For the bug linked, there is an added benefit of having the test scripts on a path with spaces (running shell commands with executables/arguments located in a path that has spaces is a common issue in Windows). Although the linter may complain in this setup, some MediaWiki developers may want to run shell commands with spaces in them, and the tests must validate that such shell commands work as expected. Is there a way to mark files as not linted?
Oct 25 2018
@Samwilson Thanks for all the help! I've added a test alongside the fix. Is anything missing for getting it merged?
Oct 24 2018
I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?