pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (67 w, 1 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF)

Recent Activity

Yesterday

pmiazga added a comment to T180626: [Spike 8hr] How should we limit resources used by chromium render service?.

@phuedx I'm not convinced this is our (reading-web-team) area of expertise to provide such information for Ops. Once it goes live we will not manage the service. We can come up with some ideas but IMHO the Services/Ops/team is going to manage that service should pick this task as they have the experience in running such kind of software on production servers and also they have the "last word".

Wed, Jan 17, 10:04 PM · Readers-Web-Kanban-Board, Spike, Services (next), Proton, Electron-PDFs, Readers-Web-Backlog
pmiazga removed a project from T185040: Regression: Lead intro "Found infobox wrapped with container on" warnings are logged on pages with infoboxes inside navboxes: Patch-For-Review.
Wed, Jan 17, 9:56 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MobileFrontend
pmiazga moved T185040: Regression: Lead intro "Found infobox wrapped with container on" warnings are logged on pages with infoboxes inside navboxes from Needs Code Review to Needs QA on the Readers-Web-Kanban-Board board.
Wed, Jan 17, 9:56 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MobileFrontend
pmiazga moved T185106: Cannot access property on non-object in MoveLeadParagraphTransform from Needs Code Review to Needs QA on the Readers-Web-Kanban-Board board.
Wed, Jan 17, 8:43 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MobileFrontend
pmiazga removed a project from T185106: Cannot access property on non-object in MoveLeadParagraphTransform: Patch-For-Review.
Wed, Jan 17, 8:43 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MobileFrontend
pmiazga claimed T181680: Allow rendering PDFs for mobile.
Wed, Jan 17, 4:33 PM · Services, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton
pmiazga moved T181680: Allow rendering PDFs for mobile from To Do to Doing on the Readers-Web-Kanban-Board board.
Wed, Jan 17, 4:33 PM · Services, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton
pmiazga moved T182162: Prefix all icons with `mf-` and fix the download icon glyph change glitch from Needs Code Review to Needs More Work on the Readers-Web-Kanban-Board board.
Wed, Jan 17, 4:33 PM · Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Proton, UI-Standardization-Kanban, UI-Standardization, Readers-Web-Backlog

Tue, Jan 16

pmiazga moved T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. from Doing to Needs Code Review on the Readers-Web-Kanban-Board board.
Tue, Jan 16, 9:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog
pmiazga moved T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. from To Do to Doing on the Readers-Web-Kanban-Board board.
Tue, Jan 16, 3:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog
pmiazga moved T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. from Doing to To Do on the Readers-Web-Kanban-Board board.
Tue, Jan 16, 3:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog

Mon, Jan 15

pmiazga moved T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. from Needs More Work to Doing on the Readers-Web-Kanban-Board board.
Mon, Jan 15, 4:05 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog

Fri, Jan 12

pmiazga added a comment to T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser..

Tested on Samsung S1, Samsung S2, Samsung S7, Samsung Note 10.1 and Samsung A5 on both Samsung Browser and Chrome, works as intended.

Fri, Jan 12, 6:11 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog
pmiazga removed a project from T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser.: Patch-For-Review.
Fri, Jan 12, 5:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog
pmiazga moved T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. from Doing to Needs Code Review on the Readers-Web-Kanban-Board board.
Fri, Jan 12, 5:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog

Thu, Jan 11

pmiazga moved T181297: Instrument print to PDF button from Doing to Needs Code Review on the Readers-Web-Kanban-Board board.
Thu, Jan 11, 4:56 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog
pmiazga added a comment to T181297: Instrument print to PDF button.

@Jdlrobson fixed

Thu, Jan 11, 4:56 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog
pmiazga moved T181297: Instrument print to PDF button from Needs More Work to Doing on the Readers-Web-Kanban-Board board.
Thu, Jan 11, 4:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog

Wed, Jan 10

pmiazga claimed T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser..
Wed, Jan 10, 8:33 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog
pmiazga moved T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser. from To Do to Doing on the Readers-Web-Kanban-Board board.
Wed, Jan 10, 8:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, User-notice, Proton, Readers-Web-Backlog

Tue, Jan 9

pmiazga moved T181297: Instrument print to PDF button from Doing to Needs Code Review on the Readers-Web-Kanban-Board board.
Tue, Jan 9, 6:08 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog
pmiazga added a comment to T181297: Instrument print to PDF button.

Currently, this shouldn't be possible right? The spinner appears as soon as the button is clicked while we're loading the images

Tue, Jan 9, 4:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog
pmiazga added a comment to T181297: Instrument print to PDF button.

@ovasileva @Tbayer do we also want to track:

  • ignore button clicks - happens when we user spams download button but the system is still processing the previous click ( eg it's still downloading images)
  • the time it took from button click to window.print() system call (time system spend on pre-loading images, max 3s)
Tue, Jan 9, 3:50 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog

Fri, Jan 5

pmiazga moved T170006: MobileFormatter#moveFirstParagraphBeforeInfobox should also move infoboxes wrapped in mw-stack element from Needs Code Review to Needs QA on the Readers-Web-Kanban-Board board.
Fri, Jan 5, 3:19 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Readers-Web-Backlog, MobileFrontend

Thu, Jan 4

pmiazga added a comment to T147722: Display namespace in mobile view of the page history.

@Nirzar can you sign it off? Change is on beta

Thu, Jan 4, 6:03 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga reassigned T147722: Display namespace in mobile view of the page history from ABorbaWMF to Nirzar.
Thu, Jan 4, 6:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend

Wed, Jan 3

pmiazga claimed T181297: Instrument print to PDF button.
Wed, Jan 3, 5:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog
pmiazga moved T181297: Instrument print to PDF button from To Do to Doing on the Readers-Web-Kanban-Board board.
Wed, Jan 3, 5:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Proton, Readers-Web-Backlog

Tue, Jan 2

pmiazga reassigned T147722: Display namespace in mobile view of the page history from pmiazga to ABorbaWMF.
Tue, Jan 2, 9:58 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga updated the task description for T147722: Display namespace in mobile view of the page history.
Tue, Jan 2, 9:58 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga added a comment to T183985: Chromium-PDF cannot render articles from File namespace properly.

File page renders are 0.9% ~ 0.5% of all renders.

Tue, Jan 2, 8:27 PM · Proton, Readers-Web-Backlog
pmiazga created T183985: Chromium-PDF cannot render articles from File namespace properly.
Tue, Jan 2, 8:06 PM · Proton, Readers-Web-Backlog
pmiazga added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

Still no response from puppeteer.

Tue, Jan 2, 3:42 PM · Readers-Web-Backlog (Tracking), Proton, Unplanned-Sprint-Work
pmiazga added a comment to T178278: Performance test the service.

Additionally, I ran a production traffic against the chromium-pdf renderer service. I retrieved all web requests to the chromium service done on 11/04/2017.

Tue, Jan 2, 3:01 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs

Fri, Dec 22

pmiazga removed a project from T147722: Display namespace in mobile view of the page history: Patch-For-Review.
Fri, Dec 22, 4:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga moved T147722: Display namespace in mobile view of the page history from Needs Code Review to Needs QA on the Readers-Web-Kanban-Board board.
Fri, Dec 22, 4:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend

Thu, Dec 21

pmiazga added a comment to T178278: Performance test the service.

Thu, Dec 21, 9:26 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga added a comment to T178278: Performance test the service.

@phuedx - yes, around 50GB. I'll attach some

Thu, Dec 21, 9:10 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga added a comment to T169257: Promote expand all sections feature from beta (in feature branch).

I'll be bold, we have an UI glitch, we cannot promote to stable something that is broken. Moving to blocked, as it's blocked on T183493.

Thu, Dec 21, 9:06 PM · Readers-Web-Kanban-Board, Patch-For-Review, Mobile-Web-Settings, Readers-Web-Backlog
pmiazga moved T169257: Promote expand all sections feature from beta (in feature branch) from Ready for Signoff to Blocked on the Readers-Web-Kanban-Board board.
Thu, Dec 21, 9:04 PM · Readers-Web-Kanban-Board, Patch-For-Review, Mobile-Web-Settings, Readers-Web-Backlog
pmiazga removed a project from T169807: Replace settings checkboxes to ToggleSwitches: Patch-For-Review.
Thu, Dec 21, 9:03 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Needs Code Review to Ready for Signoff on the Readers-Web-Kanban-Board board.
Thu, Dec 21, 9:03 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

This is a "nice-to-have" and it doesn't block the chromium release. This problem happens when user decides not to wait for PDF to get rendered and closes the browser. In that scenario we should stop rendering the PDF and free-up resources so chromium-service can start rendering different job.

Thu, Dec 21, 6:20 PM · Readers-Web-Backlog (Tracking), Proton, Unplanned-Sprint-Work
pmiazga placed T147722: Display namespace in mobile view of the page history up for grabs.
Thu, Dec 21, 5:38 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga moved T147722: Display namespace in mobile view of the page history from Doing to Needs Code Review on the Readers-Web-Kanban-Board board.
Thu, Dec 21, 5:38 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga added a comment to T147722: Display namespace in mobile view of the page history.

Per T147722#3389019 I submitted the patch to include the namespace. Changing the header and adding styles is too much work and It makes bigger more than a 3 pointer.

Thu, Dec 21, 5:29 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Needs More Work to Needs Code Review on the Readers-Web-Kanban-Board board.
Thu, Dec 21, 3:55 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog

Wed, Dec 20

pmiazga claimed T147722: Display namespace in mobile view of the page history.
Wed, Dec 20, 10:22 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga moved T147722: Display namespace in mobile view of the page history from To Do to Doing on the Readers-Web-Kanban-Board board.
Wed, Dec 20, 10:22 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Readers-Web-Kanban-Board, Readers-Web-Backlog, Mobile-Web-Settings, MinervaNeue, Design, Mobile, MobileFrontend
pmiazga added a comment to T169807: Replace settings checkboxes to ToggleSwitches.

I decided to quickly patch

Beta settings toggle should not get stuck on refresh page, figuring out other way to enable beta mode

by adding 250ms delay between toggle change and form submit.

Wed, Dec 20, 8:37 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Ready for Signoff to Needs Code Review on the Readers-Web-Kanban-Board board.
Wed, Dec 20, 8:31 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga placed T178278: Performance test the service up for grabs.
Wed, Dec 20, 7:30 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga moved T178278: Performance test the service from Doing to Ready for Signoff on the Readers-Web-Kanban-Board board.
Wed, Dec 20, 7:25 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga added a comment to T178278: Performance test the service.

TL;DR;

Service is performant and stable enough to be put on production. The most performant settings are to set up a number of concurrent renders to {CPU_CORES_COUNT} * 2 which
offers best rendering-to-waiting time. In comparison, when in idle state the service can generate short PDF in ~2secs and under high load same requests would take 50% more time.
I tested service for ~2 weeks, transferred over ~200GB of data. Before releasing to production (first days after release) some tuning is required. Setting render_concurrency
too high will end up with lower performance and rejected tasks.

Wed, Dec 20, 7:25 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga assigned T109364: Promote fontchanger to stable (in feature branch) to Nirzar.
Wed, Dec 20, 6:09 PM · Readers-Web-Kanban-Board, Patch-For-Review, Mobile-Web-Settings, Readers-Web-Backlog
pmiazga assigned T169257: Promote expand all sections feature from beta (in feature branch) to Nirzar.
Wed, Dec 20, 6:09 PM · Readers-Web-Kanban-Board, Patch-For-Review, Mobile-Web-Settings, Readers-Web-Backlog
pmiazga reassigned T169807: Replace settings checkboxes to ToggleSwitches from pmiazga to Nirzar.
Wed, Dec 20, 6:04 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog

Tue, Dec 19

pmiazga added a comment to T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?.

so we talked about Chrome/Chromium itself. Now the question about different browsers which are based on Chromium.

Tue, Dec 19, 8:26 PM · Readers-Web-Kanban-Board, Proton, Spike, Readers-Web-Backlog
pmiazga added a comment to T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?.

@bmansurov Google Chrome 53.0.2785.124, official build. Android v 4.1.2

Tue, Dec 19, 8:17 PM · Readers-Web-Kanban-Board, Proton, Spike, Readers-Web-Backlog
pmiazga added a comment to T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?.

@Kaartic, quoting: bmansurov:

We'll measure the system time right after the user taps on the print button. And we'll measure the time again after we call window.print(). We'll then find the difference in measured times. If it's in the milliseconds, we'll assume printing didn't work."

Tue, Dec 19, 8:01 PM · Readers-Web-Kanban-Board, Proton, Spike, Readers-Web-Backlog
pmiazga added a comment to T181680: Allow rendering PDFs for mobile.

Also, do we want to be strict about legal size, different mobile devices have different width to height ratio. Legal might be not good for all.

Tue, Dec 19, 5:18 PM · Services, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton
pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Needs More Work to Needs Code Review on the Readers-Web-Kanban-Board board.
Tue, Dec 19, 3:19 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog

Dec 18 2017

pmiazga added a comment to T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?.

@bmansurov your workaround will not work, as an example on Samsung S2 calling window.print() tries to create a print preview. The print function doesn't exit immediately. for long articles it takes 10-20 seconds to process, then it fires media query event which doesn't match print, and then focus gets back to the browser window.

Dec 18 2017, 11:46 PM · Readers-Web-Kanban-Board, Proton, Spike, Readers-Web-Backlog
pmiazga assigned T169807: Replace settings checkboxes to ToggleSwitches to bmansurov.
Dec 18 2017, 6:11 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Doing to Needs Code Review on the Readers-Web-Kanban-Board board.
Dec 18 2017, 6:11 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog

Dec 15 2017

pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Ready for Signoff to Doing on the Readers-Web-Kanban-Board board.
Dec 15 2017, 9:12 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga added a comment to T169807: Replace settings checkboxes to ToggleSwitches.
  • Beta settings toggle should not get stuck on refresh page, figuring out other way to enable beta mode

We might do it properly with async save, not the page reload. I'm not touching it right now.

  • Look into delay before the toast message, it's localstorage and there shouldn't be any delay for toast to show when a setting is saved

There is 1s delay between action and showing the toast message. I'll remove that delay

  • tapping on <label> doesn't trigger the input element on some androids

I'll look at it, so far I see that "Expand all sections" label is missing for attribute.

Dec 15 2017, 7:42 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga added a comment to T169807: Replace settings checkboxes to ToggleSwitches.

@Nirzar ready to test

Dec 15 2017, 5:13 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga moved T169807: Replace settings checkboxes to ToggleSwitches from Doing to Ready for Signoff on the Readers-Web-Kanban-Board board.
Dec 15 2017, 3:29 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga placed T169807: Replace settings checkboxes to ToggleSwitches up for grabs.
Dec 15 2017, 3:28 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga removed a project from T169369: Change font size controls to use small, regular, large and extra large buckets: Patch-For-Review.
Dec 15 2017, 3:28 PM · Mobile-Web-Settings, MobileFrontend, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga closed T182607: [Spike 8hrs] Why is Chromium rendering PDFs with missing pages? as Declined.
Dec 15 2017, 2:05 PM · Readers-Web-Kanban-Board, Spike, Readers-Web-Backlog, Proton
pmiazga added a comment to T182607: [Spike 8hrs] Why is Chromium rendering PDFs with missing pages?.

Ok, this task is invalid. The task is a result of first batch testing which were run on puppeteer v.0.11.0. In version v.0.13.0 they[[ https://github.com/GoogleChrome/puppeteer/commit/ce8a952044ef318baf3d9ff25157e41571293de5 | refactor: migrate NavigatorWatcher to lifecycle events ]] which solved this issue.

Dec 15 2017, 2:04 PM · Readers-Web-Kanban-Board, Spike, Readers-Web-Backlog, Proton
pmiazga added a comment to T182607: [Spike 8hrs] Why is Chromium rendering PDFs with missing pages?.

@bmansurov thank you for your checks, let me check one more thing.

Dec 15 2017, 1:01 PM · Readers-Web-Kanban-Board, Spike, Readers-Web-Backlog, Proton

Dec 14 2017

pmiazga added a comment to T169807: Replace settings checkboxes to ToggleSwitches.

I'm still investigating the issue

Dec 14 2017, 12:22 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga moved T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing) from Needs Code Review to Needs QA on the Readers-Web-Kanban-Board board.
Dec 14 2017, 12:21 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga removed a project from T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing): Patch-For-Review.
Dec 14 2017, 12:21 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga updated the task description for T182607: [Spike 8hrs] Why is Chromium rendering PDFs with missing pages?.
Dec 14 2017, 12:08 PM · Readers-Web-Kanban-Board, Spike, Readers-Web-Backlog, Proton

Dec 13 2017

pmiazga added a comment to T182235: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions.

I think our event logging is broken anyway as on SpecialMobileOptions:244 we log the event, when there is an error. Later on lines 253/259 we change the beta to [on|off] - but we do not send the event.

Dec 13 2017, 7:40 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Readers-Web-Kanban-Board, Patch-For-Review, Mobile-Web-Settings, Readers-Web-Backlog, MobileFrontend
pmiazga moved T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing) from Needs Code Review to Needs More Work on the Readers-Web-Kanban-Board board.
Dec 13 2017, 6:43 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga added a comment to T181680: Allow rendering PDFs for mobile.

Do we want to apply the mobile html tansformations (move infobox, etc)?

Dec 13 2017, 6:30 PM · Services, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton
pmiazga added a comment to T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing).

@bmansurov can you also add logic to handle 5xx errors and show the generic preview

Dec 13 2017, 6:12 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga reassigned T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing) from pmiazga to bmansurov.
Dec 13 2017, 6:11 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga claimed T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing).
Dec 13 2017, 6:03 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga claimed T169807: Replace settings checkboxes to ToggleSwitches.
Dec 13 2017, 1:41 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga added a comment to T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing).

@phuedx: as @Jdlrobson is OOO I'll follow-up on his patch.

Dec 13 2017, 1:40 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog

Dec 12 2017

pmiazga added a comment to T169807: Replace settings checkboxes to ToggleSwitches.

https://gerrit.wikimedia.org/r/#/c/396082/6 is merged. I have some strange issues while testing https://gerrit.wikimedia.org/r/394634 - save behavior is wonky, sometimes it saves the value, sometimes it doesn't. @Jdlrobson cannot reproduce it locally. I want to make sure that this behavior is specific only to my machine

Dec 12 2017, 11:07 PM · MobileFrontend, Mobile-Web-Settings, Readers-Web-Kanban-Board, Readers-Web-Backlog
pmiazga added a comment to T182639: Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing).

IMHO there is a change required in Page Previews codebase to not throw browser exception when the API response is incorrect.

Dec 12 2017, 6:22 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Readers-Web-Kanban-Board, Page-Previews, Readers-Web-Backlog
pmiazga added a comment to T178278: Performance test the service.

For next 3-5 days I'll keep sending 5-10 concurrent requests all the time plus from time to time I'll generate PDF to verify everything is still correct. I also need to prepare couple different testing scenarios (like generate set of "only non-latic languages").

Dec 12 2017, 6:18 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs

Dec 11 2017

pmiazga added a comment to T146312: [Spike 4hrs] phpcs should complain when we use the global keyword without explicitly saying its okay.

@Legoktm you're correct. Lots of MediaWiki codebase depends on globals, because of that it's a common practice to use it. We should not only maintain the highest standards but promote the best practices. Currently, we have MediaWikiServices - which uses Service Locator patter, we should encourage people to use it instead of sticking to old things are currently considered as a bad practice. If something is missing (ex: $wgMemc) we should implement those missing bits in the MediaWikiServices.

Dec 11 2017, 6:52 PM · Google-Code-in-2017, Spike, Technical-Debt (RW-Tech-Debt), Readers-Web-Backlog, MobileFrontend
pmiazga added a comment to T170006: MobileFormatter#moveFirstParagraphBeforeInfobox should also move infoboxes wrapped in mw-stack element.

I found out that the move first paragraph logic will move leading paragraph with unordered/unordered lists but the definition list would stay not attached to the paragraph. I pushed a small patch to fix this behavior and move any type of list (ordered/unordered/definition) with the first paragraph.

Dec 11 2017, 6:24 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Readers-Web-Kanban-Board, Readers-Web-Backlog, MobileFrontend
pmiazga updated the task description for T182607: [Spike 8hrs] Why is Chromium rendering PDFs with missing pages?.
Dec 11 2017, 5:32 PM · Readers-Web-Kanban-Board, Spike, Readers-Web-Backlog, Proton
pmiazga created T182608: Chromium renders article with broken fonts.
Dec 11 2017, 5:21 PM · Proton, Readers-Web-Backlog
pmiazga created T182607: [Spike 8hrs] Why is Chromium rendering PDFs with missing pages?.
Dec 11 2017, 5:13 PM · Readers-Web-Kanban-Board, Spike, Readers-Web-Backlog, Proton

Dec 8 2017

pmiazga updated subscribers of T178278: Performance test the service.

@bd808 -FYI, we're testing the newly created chromium service (http://chromium-pdf.wmflabs.org), don't get alarmed when this service gets flooded with requests or constantly uses all resources (cpu&mem).

Dec 8 2017, 4:50 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga added a comment to T178278: Performance test the service.

@mobrovac I stored files as I want to verify that files are rendered correctly. Transfer rate is less than 1MB/s and my SSD drive can write up 250MB/s, ~29GB over 12hours is not that much, it should not slow down the load testing overall. I'll definitely have couple rounds where I do not store data (typical performance/benchmark test), but for the regular load IMHO it doesn't hurt.
I like the idea of having couple long-running tasks in the background. I'll definitely do that.

Dec 8 2017, 4:45 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs
pmiazga added a comment to T178278: Performance test the service.

Testing round one.

Dec 8 2017, 2:27 PM · Performance, Readers-Web-Kanban-Board, Readers-Web-Backlog, Proton, Electron-PDFs

Dec 6 2017

pmiazga edited projects for T182253: OOJS replaces the article download button, added: Readers-Web-Backlog; removed Readers-Web-Kanban-Board.
Dec 6 2017, 9:25 PM · Readers-Web-Backlog, Proton, MobileFrontend
pmiazga created T182253: OOJS replaces the article download button.
Dec 6 2017, 9:25 PM · Readers-Web-Backlog, Proton, MobileFrontend
pmiazga updated the task description for T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?.
Dec 6 2017, 5:16 PM · Readers-Web-Kanban-Board, Proton, Spike, Readers-Web-Backlog