Page MenuHomePhabricator

pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (132 w, 5 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Fri, Apr 19

pmiazga added a comment to T216418: AMC Navigation - overflow menu.

The feature is available to test on https://reading-web-staging.wmflabs.org/

Fri, Apr 19, 10:29 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
pmiazga added a comment to T216418: AMC Navigation - overflow menu.

When testing I noticed couple things:

Fri, Apr 19, 10:26 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

Moving back to doing to address T216152#5125450

Fri, Apr 19, 5:01 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga claimed T216152: AMC Navigation - add new links to main menu with click tracking.
Fri, Apr 19, 5:00 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from Needs QA to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Fri, Apr 19, 5:00 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

@Krinkle thanks for your input. When building Definitions::insertCommunityPortal I found the code that was doing almost the same what I needed. That's how the insertCommunityPortal() was made. I'll check it with Skin::buildSidebar() and update the code.

Fri, Apr 19, 4:59 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs QA to Needs Design Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Fri, Apr 19, 4:45 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
pmiazga added a comment to T200969: No way to reach the editable version of a page when viewing the most recent mobile diff.

This task didn't have design review yet, moving it to "Needs design review".

Fri, Apr 19, 4:44 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
pmiazga reassigned T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Edtadros to alexhollender.
Fri, Apr 19, 4:44 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
pmiazga added a comment to T200969: No way to reach the editable version of a page when viewing the most recent mobile diff.

@alexhollender you can verify it here: https://reading-web-staging.wmflabs.org/

Fri, Apr 19, 4:44 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend

Thu, Apr 18

pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Apr 18, 9:23 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga removed a project from T216152: AMC Navigation - add new links to main menu with click tracking: Patch-For-Review.
Thu, Apr 18, 9:23 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

@Krinkle we load the MediaWiki:Portal-url, and then verify if title exists -> if the page doesn't exist we do not show the link - https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/menu/Definitions.php#L323

Thu, Apr 18, 6:43 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Apr 18, 6:34 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

https://gerrit.wikimedia.org/r/504938 removes The recent changes link from Advanced menu. If we decide to put Recent changes link once again, please revert this patch.

Thu, Apr 18, 6:34 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Apr 18, 6:27 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Thu, Apr 18, 6:27 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
pmiazga reassigned T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Jdrewniak to Edtadros.
Thu, Apr 18, 6:27 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
pmiazga removed a project from T200969: No way to reach the editable version of a page when viewing the most recent mobile diff: Patch-For-Review.
Thu, Apr 18, 6:27 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend

Wed, Apr 17

pmiazga updated the task description for T216152: AMC Navigation - add new links to main menu with click tracking.
Wed, Apr 17, 10:55 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Tue, Apr 16

pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 16, 9:34 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga removed a project from T216152: AMC Navigation - add new links to main menu with click tracking: Patch-For-Review.
Tue, Apr 16, 9:34 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga updated the task description for T221137: Skin should reset SkinOptions on UserLogout action..
Tue, Apr 16, 7:56 PM · Advanced Mobile Contributions, Readers-Web-Backlog, MinervaNeue, Technical-Debt
pmiazga renamed T221137: Skin should reset SkinOptions on UserLogout action. from SkinOptions are initialized too early to Skin should reset SkinOptions on UserLogout action..
Tue, Apr 16, 7:51 PM · Advanced Mobile Contributions, Readers-Web-Backlog, MinervaNeue, Technical-Debt
pmiazga created T221137: Skin should reset SkinOptions on UserLogout action..
Tue, Apr 16, 7:51 PM · Advanced Mobile Contributions, Readers-Web-Backlog, MinervaNeue, Technical-Debt
pmiazga placed T214715: [Spike] How should menus work in Minerva? up for grabs.
Tue, Apr 16, 5:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
pmiazga moved T214715: [Spike] How should menus work in Minerva? from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 16, 5:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
pmiazga added a comment to T214715: [Spike] How should menus work in Minerva?.

Use the same structure to build all menus in the system. We have pretty good Menus implementation and a Hook for registering new Menu elements. Instead of rewriting the system we could tweak a bit existing implementation, and write a reliable system for building menus. There are two reasons for that choice:

  • BlueSpiceMultiUpload and GrowthExperiments already use MobileMenu hook to create MenuEntry objects
  • we don't have enough time to refactor existing Menu system, the existing system allows us to play with it a little and make it much easier to extend.
Tue, Apr 16, 5:20 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Spike, Advanced Mobile Contributions
pmiazga moved T200969: No way to reach the editable version of a page when viewing the most recent mobile diff from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 16, 4:09 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions, MobileFrontend
pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

@TheDJ the new MainMenu implementation still sticks to old way of having MainMenu entries defined/hardcoded in the MinervaNeue. But now, it will be much easier to change it/override it. Menu building is finally fully configurable, and the only required thing is a new class, sth like WikiSourcedMainMenu that implements Menu/Main/IBuilder. That class would have to fetch the WikiPage, parse it, and return Groups[] set based on the wiki page. Previously such change wasn't available, now, finally, it should be possible to do. The only thing is how to tackle user-related entries (like login/log out buttons),

Tue, Apr 16, 9:22 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Mon, Apr 15

pmiazga created T221012: Extract $skinOptions from SkinMinerva class.
Mon, Apr 15, 4:02 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga created T221007: Extract Echo handling from SkinMinerva class.
Mon, Apr 15, 3:52 PM · Growth-Team, Notifications, Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga added projects to T221004: Simplify MainMenu building in Minerva skin: MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue, Readers-Web-Backlog.
Mon, Apr 15, 3:46 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend (MobileFrontend and MinervaNeue architecture)
pmiazga created T221004: Simplify MainMenu building in Minerva skin.
Mon, Apr 15, 3:46 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend (MobileFrontend and MinervaNeue architecture)

Thu, Apr 11

pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.
  • Ignore it if this is an URL to external site. The menu entry "Community Portal" will not be visible

@pmiazga - to confirm, it would be visible when it's an internal link? If so, let's go for this option.

Thu, Apr 11, 2:51 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T212482: Evolve hook system to support "filters" and "actions" only.

I like the idea of separation of concerns and having a codebase that is explicit and easy to use. From my understanding,

  • the action hooks can be used to modify state (expensive calls like update user in DB, log stuff, add tags, etc.)
  • the filter hooks can be used to build/filter things (like building UserDefaultOptions array, adding JS modules).
Thu, Apr 11, 1:49 PM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom

Wed, Apr 10

pmiazga added a comment to T216152: AMC Navigation - add new links to main menu with click tracking.

@ovasileva I have a question regarding the Community portal menu entry. Link for that menu entry comes from MediaWiki:Portal-url page. Usually, it has a Title (something like Wikipedia:Community portal), but it is possible, that this page will have an absolute link: (something like https://test.com/link). Therefore (when it's a link), we cannot get the menu entry label. By default, the label is the page name (which is also localized -- translated to user language). For absolute links, we can add a fallback translation, but most probably it will not be used as most probably all wikis definte Portal-url as a Title.

Wed, Apr 10, 10:50 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga placed T216152: AMC Navigation - add new links to main menu with click tracking up for grabs.
Wed, Apr 10, 5:07 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T212800: AMC feature flag can be superseded by a development query parameter.

I think it's valuable to do this thing, but IMHO we shouldn't allow users to enable things, that are disabled via config. I see the point of having ?amc=true to force AMC mode to be on, but only when AMC mode is available. But then it makes it
bit useless when it comes to testing because the automated browser test can just go and enable the AMC mode by itself.

Wed, Apr 10, 3:18 PM · Readers-Web-Backlog, Advanced Mobile Contributions

Tue, Apr 9

pmiazga added a comment to T219423: Use different share icon for Android and iOS.

@alexhollender I have everything. Thank you.

Tue, Apr 9, 6:23 PM · Readers-Web-Backlog (Design)
pmiazga added a member for MobileFrontend: pmiazga.
Tue, Apr 9, 6:22 PM
pmiazga added a watcher for MobileFrontend (MobileFrontend and MinervaNeue architecture): pmiazga.
Tue, Apr 9, 6:21 PM
pmiazga added a comment to T216418: AMC Navigation - overflow menu.

@Niedzielski the Minerva print button is handled uniquely. First, after injecting button, it logs shownPrintButton (printing is not always available, there is no need to inject the button if you cannot print). Then when clicked - it doesn't add printable=yes to the URL, what it does, after it's clicked first it logs the click, then tries to load images on the page (the one that is lazyloaded), then calls window.print().

Tue, Apr 9, 5:53 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 9, 5:03 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Mon, Apr 8

pmiazga added a comment to T206728: AutoLoaderStructureTest works incorrectly on extensions using PSR-4 autoloading and class_alias.

I encountered the same issue while working on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/502278. After renaming MenuBuilder to Group and registering it via PSR-4 the AutoLoaderStructureTest started to fail. After adding MediaWiki\Minerva\Menu\Group also to AutoloadClasses it works again.

Mon, Apr 8, 11:22 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Core-Testing, MediaWiki-Configuration

Wed, Apr 3

pmiazga claimed T207280: Track share button usage.
Wed, Apr 3, 5:06 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), User-Jdlrobson, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MinervaNeue
pmiazga removed a project from T207280: Track share button usage: Patch-For-Review.
Wed, Apr 3, 5:05 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), User-Jdlrobson, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MinervaNeue
pmiazga closed T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish as Resolved.
Wed, Apr 3, 1:46 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

@Daimona the original error message is solved (now we log this error as a warning, not an exception), and looks like the AbuseFilter is the only extension that causes the ManualLogEntry::publish() to log a warning.
I created a separate ticket to fix the AbuseFilter behavior T219951: AbuseFilter shouldn't publish `udp` LogEntries with $newId=0 and I'd like to resolve this task.

Wed, Apr 3, 1:46 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga created T219951: AbuseFilter shouldn't publish `udp` LogEntries with $newId=0.
Wed, Apr 3, 1:41 AM · Wikimedia-production-error, AbuseFilter

Tue, Apr 2

pmiazga moved T218304: Allow quicksurveys to target based on registration date from Needs More Work to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 2, 9:37 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga added a comment to T218304: Allow quicksurveys to target based on registration date.

@Edtadros AC1 and AC2 -> this is our env misconfiguration (CentralAuth plugin), it's not related to the QuikcSurveys extension. When you log in, please go back to testing urls manually. Sadly once you login, it cannot properly redirect you back to the site.

Tue, Apr 2, 9:37 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga added a comment to T218154: Provide a focus state to search box.

What about autofocus=true? https://www.w3schools.com/tags/att_input_autofocus.asp

Tue, Apr 2, 7:05 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog, UI-Standardization, UI-Standardization-Kanban, Accessibility, MinervaNeue
pmiazga added a comment to T218154: Provide a focus state to search box.

The flash is pretty visible on my machine:

Tue, Apr 2, 7:03 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog, UI-Standardization, UI-Standardization-Kanban, Accessibility, MinervaNeue
pmiazga updated the task description for T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file.
Tue, Apr 2, 4:44 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), QuickSurveys
pmiazga added a comment to T218154: Provide a focus state to search box.

When I'm testing this feature on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page I see a small blue outline flash. When I click search bar first it gets the blue outline, then (when overlay gets visible) it loses the blue outline and then after less than half of second it gets the blue outline again. In short -> it gets outline, loses the outline and gets the blue outline again. Then after it gets the outline second time it stays while I input search query.
The browser is Chrome 72 on Linux (Debian testing).

Tue, Apr 2, 4:37 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog, UI-Standardization, UI-Standardization-Kanban, Accessibility, MinervaNeue
pmiazga updated the task description for T219838: Inline Hogan templates in mobile.startup.
Tue, Apr 2, 4:20 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Fri, Mar 29

pmiazga committed rEQSc218f0f97ac2: Introduce registrationStart and registrationEnd audience checks (authored by pmiazga).
Introduce registrationStart and registrationEnd audience checks
Fri, Mar 29, 9:35 PM
pmiazga committed rEQS89087cde9b94: Introduce registrationStart and registrationEnd audience checks (authored by pmiazga).
Introduce registrationStart and registrationEnd audience checks
Fri, Mar 29, 9:20 PM
pmiazga committed rEQSfa03db6fc540: Introduce registrationStart and registrationEnd audience checks (authored by pmiazga).
Introduce registrationStart and registrationEnd audience checks
Fri, Mar 29, 8:23 PM
pmiazga placed T218304: Allow quicksurveys to target based on registration date up for grabs.
Fri, Mar 29, 7:45 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga moved T218304: Allow quicksurveys to target based on registration date from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Mar 29, 7:45 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga added a comment to T218304: Allow quicksurveys to target based on registration date.

@Isaac thank you for quick reply. Everything is clear now. Thanks. Also, registrationStart and registrationEnds sounds like much better names. I'll use those instead of registrationBefore and registrationAfter.

Fri, Mar 29, 7:02 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga added a comment to T218304: Allow quicksurveys to target based on registration date.

@ovasileva @Isaac couple questions regarding this task (mostly just to clarify things):

Fri, Mar 29, 6:41 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga added a comment to T218304: Allow quicksurveys to target based on registration date.

there is a function mw.user.getRegistration() that returns user registration as Date object.

Fri, Mar 29, 6:28 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga claimed T218304: Allow quicksurveys to target based on registration date.
Fri, Mar 29, 4:30 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga moved T218304: Allow quicksurveys to target based on registration date from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Mar 29, 4:30 PM · QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga closed T218625: Developer: Allow easier access to AMC user modes as Resolved.
Fri, Mar 29, 1:20 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog
pmiazga added a comment to T218625: Developer: Allow easier access to AMC user modes.

This task is merged, I think we can resolve it. If you have any questions please re-open the task @Jdlrobson

Fri, Mar 29, 1:20 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog

Thu, Mar 28

pmiazga added a comment to T215675: Provide mechanism to allow dynamically tag log entries.

I have to agree with you. It's not an epic, the task was relatively simple, the hardest part was finding people who can provide feedback on the changes to core repository. Also, the work is already done, and the tagging system works on production. There was a problem with some log entries (see T218940) but it's also tackled.

Thu, Mar 28, 5:49 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Logging, Advanced Mobile Contributions, MobileFrontend

Wed, Mar 27

pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

@Daimona definitely there is a configuration problem with AbuseFilter. If you have the RCID, then $wgAbuseFilterNotifications has to be set to rc or rcandudp. If it's set to udp, then tags are not applied to the RecentChange.

Wed, Mar 27, 8:58 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

Looks like it's fixed, I don't see errors from wmf.23 branch, but let's keep it open for a couple more days to make sure the issue is fixed.

Wed, Mar 27, 6:39 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga added a comment to T207280: Track share button usage.

I'll add QA steps

Wed, Mar 27, 5:50 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), User-Jdlrobson, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MinervaNeue
pmiazga added a comment to T218349: Update translation for "mobile web edit" change tag to "mobile web action".

It's not clear to me how to proceed with this task, this looks like a long task as we need to:

  • create a new tag and start tagging everything with a new tag, then deploy to wikis
  • during that time we will show both tags on Special:Tag page (the old one and the new one)
  • create a maintenance script (I don't see anything like that), that will update the change_tag.ct_tag_id = NEW_ID where change_tag_ct.tag_id = OLD_ID. It also needs to update the change_tag_dev.ctd_count properly (don't miss edits that happened during maintenance script execution)
  • run the maintenance script, and I'm afraid it can take ages for all wikis.

This whole maintenance process can take up like a week, plus most probably there are some edge cases are we ok with having two tags at the same time? Also, we need to do the same for both advanced mobile edit and mobile edit.

Wed, Mar 27, 5:13 PM · MobileFrontend, Readers-Web-Backlog

Tue, Mar 26

pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

@dduvall it just got +2

Tue, Mar 26, 5:19 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga added a comment to T215477: Tag Thanks actions with AMC tag.

This task is blocked by https://phabricator.wikimedia.org/T218940 - we need to solve logspam with Logging system, otherwise, our tagging system will be reverted, therefore tagging thanks action will stop working.

Tue, Mar 26, 5:10 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Product-Analytics, Advanced Mobile Contributions, Growth-Team, Thanks
pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

@dduvall we're very close to merge

Tue, Mar 26, 5:07 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error

Mon, Mar 25

pmiazga added a comment to T219242: deployment-mediawiki-09 PHP7 has broken cache of codebase?.

Maybe it's a opcache issue?

Mon, Mar 25, 11:36 PM · Patch-For-Review, Beta-Cluster-Infrastructure
pmiazga added a comment to T219242: deployment-mediawiki-09 PHP7 has broken cache of codebase?.

I checked the https://en.wikipedia.beta.wmflabs.org/w/api.php and it works for me bot as logged in and logged out user.

Mon, Mar 25, 11:30 PM · Patch-For-Review, Beta-Cluster-Infrastructure
pmiazga added a comment to T219242: deployment-mediawiki-09 PHP7 has broken cache of codebase?.

The MobileFrontend.Context is available for 12 days in the codebase (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/ServiceWiring.php#L52), it was added in rEMFR95629c2ef014: Move creation of MobileContext to MediaWikiServices.

Mon, Mar 25, 11:26 PM · Patch-For-Review, Beta-Cluster-Infrastructure
pmiazga moved T219028: [Bug] AMC toggle takes two taps to turn off/on from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Mar 25, 5:10 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
pmiazga added projects to T219028: [Bug] AMC toggle takes two taps to turn off/on: MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).
Mon, Mar 25, 5:10 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions
pmiazga moved T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Mar 25, 11:44 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga edited projects for T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog.
Mon, Mar 25, 11:44 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

Explanation what's going on here:

Mon, Mar 25, 11:22 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
pmiazga added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

I'm on it

Mon, Mar 25, 10:03 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error

Mar 22 2019

pmiazga moved T217296: Use the Overlay.make pattern for notification feature from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 22 2019, 9:54 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga added a comment to T219028: [Bug] AMC toggle takes two taps to turn off/on.

I'll look into that, user preferences update happens as a deferred update (it's executed as a last thing during page request). Same happens with the Beta switch. I think that can happen when prod is bit overloaded, and server renders you a new page, but the properties update didn't finish yet. Thats why it renders as "off" state (because switching to ON is still in progress).

Mar 22 2019, 8:01 PM · Audiences-QA (RW-Test-Cases), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MobileFrontend, Patch-For-Review, Advanced Mobile Contributions

Mar 21 2019

pmiazga moved T217102: MFA: TalkSectionAddOverlay should use Overlay.make pattern from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 21 2019, 5:02 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga added a comment to T217724: Investigate 2019-03-01 Proton incident.

@akosiaris - yes, there is some logic that tries to kill the browser instances if browser.close() promise doesn't succeed[1]. Looks like this code requires some tuning, and most probably it should try to kill the browser instance after some time without waiting for promise resolution/failure.

Mar 21 2019, 4:18 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team (Security, stability, performance and scalability (TEC1)), Proton

Mar 20 2019

pmiazga added a comment to T215477: Tag Thanks actions with AMC tag.

@Edtadros - The failed test is ok, the texts are bit different. If you want I can update the QA steps and fix the expected messages.
The second step "tagged correctly at" => it means that it has all three tags (Advanced mobile edit, mobile edit, mobile web edit), and those tags are applied.

Mar 20 2019, 9:44 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Product-Analytics, Advanced Mobile Contributions, Growth-Team, Thanks

Mar 19 2019

pmiazga claimed T216152: AMC Navigation - add new links to main menu with click tracking.
Mar 19 2019, 5:15 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T216152: AMC Navigation - add new links to main menu with click tracking from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mar 19 2019, 5:15 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga closed T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone as Resolved.
Mar 19 2019, 4:43 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, QuickSurveys, RelatedArticles, MinervaNeue
pmiazga closed T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone, a subtask of T127268: Dismantle ResourceLoader's "targets" system, as Resolved.
Mar 19 2019, 4:43 PM · Performance-Team, Readers-Web-Backlog (Tracking), Developer-Wishlist (2017), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MediaWiki-ResourceLoader
pmiazga updated the task description for T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone.
Mar 19 2019, 4:43 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, QuickSurveys, RelatedArticles, MinervaNeue
pmiazga created T218701: Bump QuickSurveys version to 1.3.0 and remove HISTORY file.
Mar 19 2019, 4:28 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), QuickSurveys
pmiazga added a project to T218454: Mobile form for forced password change (due to new password requirements) has no label for the "Retype password" field: Readers-Web-Backlog.
Mar 19 2019, 3:32 PM · Readers-Web-Backlog (Design), MobileFrontend
pmiazga claimed T208605: Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone.
Mar 19 2019, 12:50 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, QuickSurveys, RelatedArticles, MinervaNeue

Mar 18 2019

pmiazga added a comment to T210106: Provide a reusable getEditCountBucket function for analytics purposes.

@Krinkle I agree with you that there is no good place for that. Currently we do same buckets for:

I think that we had similar bucketing code somewhere else, but most probably it's already removed because I cannot find it. With AMC most probably we will use the same code once again (creating same 9 lines of code in another extension).

Mar 18 2019, 4:07 PM · Patch-For-Review, Analytics, Front-end-Standards-Group, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog