Page MenuHomePhabricator

pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (363 w, 4 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Wed, Sep 20

pmiazga updated Other Assignee for T327046: Improve (or identify) monitoring for CentralAuth autologins on Wikimedia wikis, removed: pmiazga.
Wed, Sep 20, 2:42 PM · IP-Masking-Growth-Team, MediaWiki-Platform-Team, Growth-Team (Current Sprint), IP Masking, MediaWiki-extensions-CentralAuth
pmiazga closed T346209: Send tracing headers from Shellbox client as Resolved.
Wed, Sep 20, 10:07 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Shellbox, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga closed T346209: Send tracing headers from Shellbox client, a subtask of T320556: Micro-specification for how service owners should propagate tracing headers, as Resolved.
Wed, Sep 20, 10:07 AM · Observability-Tracing

Mon, Sep 18

pmiazga closed T344149: Proof of Concept: OpenTelemetry in MediaWiki as Resolved.
Mon, Sep 18, 12:38 PM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga closed T344149: Proof of Concept: OpenTelemetry in MediaWiki, a subtask of T340552: MediaWiki imports OpenTelemetry client instrumentation library for enhanced trace metadata, as Resolved.
Mon, Sep 18, 12:38 PM · MediaWiki-Platform-Team (Radar), MediaWiki-libs-HTTP, Observability-Tracing

Thu, Sep 14

pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.

I pushed the proposed change marked as DNM - @Dreamy_Jazz please let me know if this is what we're looking for. I haven't tested it yet, other than just running tests locally.

Thu, Sep 14, 6:30 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.

In c) I meant to skip adding this row entirely, and not add anything other. Yes, sorry, I messed up when copying/pasting. I didn't know is it safe to insert data to other table in such case as I don't know the big picture of what CheckUser is doing.

Thu, Sep 14, 4:08 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.

I see four possible solutions here:

Thu, Sep 14, 11:00 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.

So after investigating the code - We have a RecentChange entry, that contains information about the change in our system. RecentChange has an attribute rc_logid -> which is the log entry associated with given change. It can be 0 -> no log entry set, or a integer -> then it's a foreign_key to logging table.

Thu, Sep 14, 10:21 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error

Wed, Sep 13

pmiazga added a comment to T340573: Add support for request tracing to WikimediaDebug browser extension.

@CDanis could you elaborate a little bit on this one? What do you mean "force a distributed tracing" ?

Wed, Sep 13, 1:32 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Platform-Team, WikimediaDebug, Observability-Tracing
pmiazga triaged T346211: Deprecate WebRequest::getRequestId() as Low priority.
Wed, Sep 13, 8:58 AM · MW-1.42-release, good first task, MediaWiki-Platform-Team, MediaWiki-libs-HTTP
pmiazga created T346211: Deprecate WebRequest::getRequestId().
Wed, Sep 13, 8:58 AM · MW-1.42-release, good first task, MediaWiki-Platform-Team, MediaWiki-libs-HTTP
pmiazga created T346209: Send tracing headers from Shellbox client.
Wed, Sep 13, 8:34 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Shellbox, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga closed T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore), a subtask of T320559: Trace header propagation for MediaWiki, as Resolved.
Wed, Sep 13, 8:23 AM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing
pmiazga closed T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore) as Resolved.
Wed, Sep 13, 8:23 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.
Wed, Sep 13, 7:40 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error

Tue, Sep 12

DAlangi_WMF awarded T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore) a Party Time token.
Tue, Sep 12, 9:31 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga updated subscribers of T343983: Error: Call to a member function getTimestamp() on null.

I found another log statement exactly from the same line. The previous error comes from fixStuckGlobalRename but the one I found comes from SpamBlacklist: https://logstash.wikimedia.org/app/dashboards#/view/c7013c90-a487-11ec-be91-b3435f0c0c49?_g=h@53fc073&_a=h@8974712 and was triggered on EditPage.

Tue, Sep 12, 5:25 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga triaged T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore) as Medium priority.
Tue, Sep 12, 5:19 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga added a comment to T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore).

We went through a set of reviews and I'm expecting this work to be merged and this ticket to be closed this week.

Tue, Sep 12, 5:19 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team

Mon, Sep 11

pmiazga moved T105626: AntiSpoof extension gives incorrect results when a requested username contains some special characters from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Sep 11, 1:55 PM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), MediaWiki-Platform-Team, GlobalRename, MediaWiki-extensions-CentralAuth, AntiSpoof
pmiazga moved T345632: AbuseFilter "global_user_editcount" field is null during (auto)createaccount action from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Sep 11, 1:55 PM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, AbuseFilter
pmiazga moved T345777: Consider making RevisionArchiveRecord::userCan() also check the page deletion permissions from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Sep 11, 1:54 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MediaWiki-Platform-Team, Security, MediaWiki-General
pmiazga moved T343499: Invalid minification for some gadgets with requiresES6 from Sprint +2 to Sprint +1 on the MediaWiki-Platform-Team board.
Mon, Sep 11, 1:52 PM · Patch-For-Review, Wikimedia-Minify, MediaWiki-Platform-Team, MediaWiki-ResourceLoader
pmiazga moved T345190: Update RL alerts from performance-team-alerts@ to mediawiki-platform-team@ from Sprint +2 to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Sep 11, 1:51 PM · Patch-For-Review, MediaWiki-Services-Group-onboarding, MediaWiki-Platform-Team, MediaWiki-ResourceLoader
pmiazga moved T341244: ParserOptions and Title::getPageViewLanguage may disagree on the lang/dir from Current Sprint to Sprint +1 on the MediaWiki-Platform-Team board.
Mon, Sep 11, 1:50 PM · Content-Transform-Team, MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ContentHandler
pmiazga reassigned T335851: Investigate the Federated Credential Management browser API from Tgr to DAlangi_WMF.
Mon, Sep 11, 1:30 PM · MediaWiki-Platform-Team, affects-Miraheze, User-Tgr, MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager

Fri, Sep 8

pmiazga closed T345295: MultiHttpClient should handle headers from __construct, a subtask of T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore), as Resolved.
Fri, Sep 8, 10:54 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga closed T345295: MultiHttpClient should handle headers from __construct as Resolved.
Fri, Sep 8, 10:54 AM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), Patch-For-Review, MediaWiki-libs-HTTP, MediaWiki-Platform-Team

Thu, Sep 7

pmiazga added a comment to T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore).

Today on codemob we decided to move Telemetry class to includes/libs folder and make it generic. But when doing that, I found that the Telemetry cannot be global singleton, as it uses the MediaWiki config: https://github.com/wikimedia/mediawiki/blob/5405fdccfcb7fec8c0fd9b9c9c2a73ee18d98127/includes/http/Telemetry.php#L60

Thu, Sep 7, 3:49 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team

Fri, Sep 1

pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.

I cannot reproduce it anymore nor I don't see any similar logs. This error happened twice on on 2023-08-10 after each command:

Fri, Sep 1, 4:41 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error

Thu, Aug 31

pmiazga added a comment to T344149: Proof of Concept: OpenTelemetry in MediaWiki.

Sorry for a bit of silence in this ticket, Recently I focused a little bit more on the T344926 issue which caused us lots of trouble due to layering issues (RESTBagOStuff and MultiHttpClient are part of general libs but Telemetry is MediaWiki specific).

Thu, Aug 31, 5:56 PM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga changed the status of T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore) from Open to In Progress.
Thu, Aug 31, 5:16 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga changed the status of T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore), a subtask of T320559: Trace header propagation for MediaWiki, from Open to In Progress.
Thu, Aug 31, 5:16 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing
pmiazga added a comment to T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore).

We spoke about those changes today on Codemob and we agreed on:

Thu, Aug 31, 5:16 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team

Wed, Aug 30

pmiazga added a comment to T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore).

Unless CDanis says there's urgency, I vote for skipping the temporary fix, as I'm not convinced the temporary fix is as simple as we'd hoped.

It's pretty straightforward: https://gerrit.wikimedia.org/r/953689 but I agree - I don't like it as it introduces the layering issue - the RESTBagOStuff shouldn't know anything about Telemetry/Tracing - it's the HTTPClient (whatever client we use) responsibility, not the RESTBagOStuff.

Wed, Aug 30, 8:32 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga renamed T345295: MultiHttpClient should handle headers from __construct from MultiHttpClient should handle headers from __constructor to MultiHttpClient should handle headers from __construct.
Wed, Aug 30, 8:01 PM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), Patch-For-Review, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga created T345295: MultiHttpClient should handle headers from __construct.
Wed, Aug 30, 8:01 PM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), Patch-For-Review, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga added a comment to T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore).

After a pairing session with @DAlangi_WMF we decided that the best way to tackle this :

Wed, Aug 30, 12:07 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team

Tue, Aug 29

pmiazga updated subscribers of T344926: Propagate x-request-id header from MultiHttpClient in MediaWiki (e.g. SessionStore).

This is caused by MultiHttpClient using raw curl_*() calls instead HttpRequestFactory to get the HTTP client. On Prod env sessions use kask-session object cache, which uses RESTBagOStuff. The RESTBagOStuff could use a specific HTTP client - but we do not specify one via config (https://github.com/wikimedia/operations-mediawiki-config/blob/811b3dad11ea1cb629e06f71d94ab4e7208ccdfd/wmf-config/CommonSettings.php#L596C18-L596C3), therefore it fallback to default MultiHttpClient library to send requests (https://github.com/wikimedia/mediawiki/blob/f071c22a9a3e7e399dcf3256c96a952f15291a69/includes/libs/objectcache/RESTBagOStuff.php#L149). I also noticed it can support only MultiHttpClient and we cannot pass anything that extends MWHttpRequest which supports telemetry headers.

Tue, Aug 29, 5:54 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-libs-ObjectCache, MediaWiki-libs-HTTP, MediaWiki-Platform-Team
pmiazga created T345181: No branch cut label applied to phab ticket after +2 on CheckUser extension.
Tue, Aug 29, 4:17 PM · ReleaseTaggerBot

Mon, Aug 28

pmiazga added a comment to T320559: Trace header propagation for MediaWiki.

T344926 is a standalone ticket as it's an existing issue. From a quick check, sessions can use RESTBagOStuff to store/retrieve session data. When setting up a RESTBagOStuff we can specify a custom HTTP client, or it will use MultiHttpClient by default.

Mon, Aug 28, 1:02 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing

Aug 22 2023

pmiazga changed the status of T344149: Proof of Concept: OpenTelemetry in MediaWiki from Open to In Progress.
Aug 22 2023, 3:49 PM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga changed the status of T344149: Proof of Concept: OpenTelemetry in MediaWiki, a subtask of T340552: MediaWiki imports OpenTelemetry client instrumentation library for enhanced trace metadata, from Open to In Progress.
Aug 22 2023, 3:49 PM · MediaWiki-Platform-Team (Radar), MediaWiki-libs-HTTP, Observability-Tracing
pmiazga added a comment to T344149: Proof of Concept: OpenTelemetry in MediaWiki.

For quick hacking I'm going to use the OpenTelemetry monorepo - https://github.com/open-telemetry/opentelemetry-php as the one from mszabo (https://github.com/mszabo-wikia/opentelemetry-php) seems a bit outdated.

Aug 22 2023, 10:57 AM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing

Aug 21 2023

pmiazga added a comment to T343983: Error: Call to a member function getTimestamp() on null.

@Dreamy_Jazz - I quickly checked this code and I found that this is caused by this line

Aug 21 2023, 3:47 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga reopened T344149: Proof of Concept: OpenTelemetry in MediaWiki, a subtask of T320549: distributed tracing v0 [minimum viable], as Open.
Aug 21 2023, 1:53 PM · Epic, Observability-Tracing
pmiazga reopened T344149: Proof of Concept: OpenTelemetry in MediaWiki as "Open".
Aug 21 2023, 1:53 PM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga added a project to T344149: Proof of Concept: OpenTelemetry in MediaWiki: MediaWiki-Platform-Team.
Aug 21 2023, 1:49 PM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga assigned T335515: Error: Call to a member function getId() on bool to matmarex.
Aug 21 2023, 1:48 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager, Wikimedia-production-error
pmiazga moved T328699: Consider including a JS runtime as part of MediaWiki from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Aug 21 2023, 1:41 PM · MediaWiki-Platform-Team (Radar), Design-Systems-Team, Front-end Modernization, MediaWiki-ResourceLoader
pmiazga moved T321394: Investigate possible sticky module cache poisoning bug from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Aug 21 2023, 1:38 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-ResourceLoader
pmiazga moved T340263: Deprecate mediawiki.ui.button. Use Codex markup instead. from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Aug 21 2023, 1:35 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Platform-Team (Radar), Web-Team-Backlog (Needs Prioritization (Tech)), MediaWiki-extensions-OAuth, MediaWiki-extensions-GuidedTour, MediaWiki-extensions-CentralAuth, Design-Systems-Team, Growth-Team
pmiazga moved T214215: MinimumPasswordLengthToLogin error message is unhelpful from Inbox, needs triage to Sprint +1 on the MediaWiki-Platform-Team board.
Aug 21 2023, 1:34 PM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), Patch-For-Review, MediaWiki-Platform-Team, I18n, Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-AuthManager
pmiazga claimed T343983: Error: Call to a member function getTimestamp() on null.
Aug 21 2023, 1:29 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga moved T343983: Error: Call to a member function getTimestamp() on null from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Aug 21 2023, 1:28 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Anti-Harassment (AHaT Sprint 32 - Baseball Cap), Patch-For-Review, MediaWiki-User-rename, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, CheckUser, Wikimedia-production-error
pmiazga triaged T335515: Error: Call to a member function getId() on bool as Medium priority.
Aug 21 2023, 1:23 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager, Wikimedia-production-error
pmiazga added a comment to T344148: Trace header propagation for Proton service.

Adding Content-Transform-Team as they are the owners of Proton service. If there are any questions regarding this change I'm happy to help.

Aug 21 2023, 12:25 PM · Proton, service-runner, Observability-Tracing
pmiazga added a project to T344148: Trace header propagation for Proton service: Content-Transform-Team.
Aug 21 2023, 12:24 PM · Proton, service-runner, Observability-Tracing
pmiazga placed T344148: Trace header propagation for Proton service up for grabs.
Aug 21 2023, 12:23 PM · Proton, service-runner, Observability-Tracing
pmiazga claimed T340573: Add support for request tracing to WikimediaDebug browser extension.
Aug 21 2023, 12:20 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Platform-Team, WikimediaDebug, Observability-Tracing
pmiazga added a comment to T340573: Add support for request tracing to WikimediaDebug browser extension.

I see two tickets here, one to add tracing headers to the response (same as X-Request-ID), and second ticket to modify the extension to show additional fields.

Aug 21 2023, 12:19 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Platform-Team, WikimediaDebug, Observability-Tracing
pmiazga added a comment to T320559: Trace header propagation for MediaWiki.

@CDanis Can you confirm that you see traces on prod ?

Aug 21 2023, 12:17 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing
pmiazga triaged T320559: Trace header propagation for MediaWiki as High priority.
Aug 21 2023, 12:13 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing
pmiazga changed the status of T320559: Trace header propagation for MediaWiki, a subtask of T320556: Micro-specification for how service owners should propagate tracing headers, from Open to In Progress.
Aug 21 2023, 12:13 PM · Observability-Tracing
pmiazga changed the status of T320559: Trace header propagation for MediaWiki from Open to In Progress.
Aug 21 2023, 12:13 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing

Aug 17 2023

pmiazga edited P50598 A quick benchmark for checking existence of Value node..
Aug 17 2023, 7:29 PM
pmiazga updated subscribers of T327082: Fix tech debt around Less_Tree->value property checks .

Recently @daniel raised a very good point about the performance of each solution, and whether it is faster to do instanceof (as it may have to traverse the inheritance tree) instead of calling property_exists() or even maybe trying to switch to $node->value ?? checks. I developed a super simple benchmark to verify which option would be the best pick.

Aug 17 2023, 7:08 PM · MediaWiki-Platform-Team, MediaWiki-Services-Group-onboarding, Less.php, Technical-Debt
pmiazga created P50598 A quick benchmark for checking existence of Value node..
Aug 17 2023, 6:51 PM

Aug 16 2023

pmiazga added a comment to T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.

I'll abandon those.

Aug 16 2023, 5:26 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga added a comment to T327082: Fix tech debt around Less_Tree->value property checks .

I wouldn't worry about the function call overhead, as it's only a couple extra ops - and IMHO it's more a micro-optimization that we wouldn't be able to notice in the runtime. And I hope that in such cases compiler could optimize the code by just fetching the variable instead of doing a function call. Some languages already do that.

Aug 16 2023, 12:55 PM · MediaWiki-Platform-Team, MediaWiki-Services-Group-onboarding, Less.php, Technical-Debt

Aug 14 2023

pmiazga added a comment to T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.

It has to be something related to the CI configs, I'll look for someone who could help me reproduce this problem locally. I followed @Jdforrester-WMF advice and I loaded a specific set of extensions

wfLoadExtension('EventBus');
wfLoadExtension('EventLogging');
wfLoadExtension('EventStreamConfig');
wfLoadExtension( 'WikimediaMessages' );
wfLoadExtension( 'WikiLambda' );
Aug 14 2023, 5:05 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga added a comment to T327082: Fix tech debt around Less_Tree->value property checks .

After a bit of research and thinking about this. There are couple of possible ways of getting rid of the tech debt:

Aug 14 2023, 1:32 PM · MediaWiki-Platform-Team, MediaWiki-Services-Group-onboarding, Less.php, Technical-Debt
pmiazga created T344149: Proof of Concept: OpenTelemetry in MediaWiki.
Aug 14 2023, 12:09 PM · Patch-For-Review, Spike, MediaWiki-Platform-Team, MediaWiki-libs-HTTP, Observability-Tracing
pmiazga created T344148: Trace header propagation for Proton service.
Aug 14 2023, 12:00 PM · Proton, service-runner, Observability-Tracing

Aug 10 2023

pmiazga added a comment to T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.

@Jdforrester-WMF - can you link me to the tests that fail?

Aug 10 2023, 10:47 AM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga added a comment to T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.

Could be, I didn't have the EventBus extension locally and didn't test it. But yesterday I started working on EventBus patch too, I'll have it ready today

Aug 10 2023, 10:45 AM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net

Aug 9 2023

pmiazga changed the status of T327082: Fix tech debt around Less_Tree->value property checks from Open to In Progress.
Aug 9 2023, 3:31 PM · MediaWiki-Platform-Team, MediaWiki-Services-Group-onboarding, Less.php, Technical-Debt
pmiazga added a comment to T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.

My understanding is that JobRunner uses overrideRequestId() with a null to reset the RequestId - but then after the reset - getting the id will try to get the ID from headers again, and if not present it will regenerate it.

Aug 9 2023, 3:02 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga claimed T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.
Aug 9 2023, 2:57 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga moved T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Aug 9 2023, 2:57 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga changed the status of T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given from Open to In Progress.
Aug 9 2023, 2:57 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga added a comment to T343893: TypeError: Argument 1 passed to MediaWiki\Http\Telemetry::overrideRequestId() must be of the type string, null given.

I'll look into it

Aug 9 2023, 2:50 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), Wikimedia-production-error, MediaWiki-Platform-Team, Observability-Tracing, affects-translatewiki.net
pmiazga added a comment to T330747: Provide link to the page's contributors (e.g. page history) in "Download as PDF" result.

Hmm.. is it possible to use the technology from ws-export.wmcloud.org that are able to compile the contributors (down to the contributors of templates and images that are being used). The alternative is to provide a link to the history page, as an acknowledgement. If it can provide a link "Retrieved from ...so-and-so...", then it shouldn't be hard to add "Click here to see all the contributors of this page"

Aug 9 2023, 1:08 PM · Proton
pmiazga added a comment to T330745: Cache not deleted on Special:DownloadAsPdf (current version of page not generated after generating old version of page).

Thank you for your cooperation in this matter. Ticket closed.

Aug 9 2023, 1:05 PM · Proton
pmiazga closed T330745: Cache not deleted on Special:DownloadAsPdf (current version of page not generated after generating old version of page) as Declined.
Aug 9 2023, 1:04 PM · Proton

Aug 7 2023

pmiazga added a comment to T98698: PDF rendering does not include graph image, as the Graph extension does not support Graphoid anymore.

as @TheDJ says - Proton - our PDF renderer disables the Javascript when rendering the page: https://github.com/wikimedia/mediawiki-services-chromium-render/blob/76161ba764e28e0f4f494d903d41d875a64481e6/lib/renderer.js#L157

Aug 7 2023, 4:12 PM · Proton, MediaWiki-extensions-Graph
pmiazga added a comment to T25370: Wikipedia PDF Article Print Option - Need Option to Change Printed Font Size.

The current PDF renderer (Proton) provides a way to render Desktop and Mobile versions of PDF article. This is doable by asking Proton to render mobile version of article - which will make fonts much bigger (if we render a full a4 page with the regular font on a mobile device - the text is not readable). IMHO it would partially solve the problem as we would have a way to render a PDF with much bigger fonts for people who are visually impaired.

Aug 7 2023, 4:05 PM · Accessibility, Collection
pmiazga added a comment to T86494: Allow setting different font size for PDF text.

The current PDF renderer provides two types of output it can render a regular PDF and a Mobile Version of PDF which is much easier to read on mobile devices.

Aug 7 2023, 4:00 PM · Proton, Product-Infrastructure-Team-Backlog-Deprecated, OCG-PDFRenderer, Accessibility
pmiazga added a comment to T330745: Cache not deleted on Special:DownloadAsPdf (current version of page not generated after generating old version of page).

The output of the PDF renderer is cached only for 10 minutes to prevent mass rendering of the same article/regenerating the same content. PDFs are generated by a standalone service called Proton, and the implementation from the beginning didn't listen to purge events.

Aug 7 2023, 3:46 PM · Proton
pmiazga closed T46186: Rendered output should be cached. as Declined.
Aug 7 2023, 3:32 PM · Collection
pmiazga added a comment to T46186: Rendered output should be cached..

Currently, the rendered output of "Download as PDF" is cached on Varnish for 10 minutes. I don't think we have a place to store PDF files. Probably, this ticket refers to an old combination of Collection + electron-renderer which is not supported any more.

Aug 7 2023, 3:32 PM · Collection
pmiazga closed T64592: Predictable URL for "Download as PDF" as Declined.
Aug 7 2023, 3:23 PM · Collection
pmiazga added a comment to T64592: Predictable URL for "Download as PDF".

I'll close this ticket as it refers to a combination of old Collection extension and most likely the electron-render renderer. Right now we use https://www.mediawiki.org/wiki/Proton to generate PDFs and links.

Aug 7 2023, 3:22 PM · Collection
pmiazga added a comment to T330747: Provide link to the page's contributors (e.g. page history) in "Download as PDF" result.

"Download as PDF" uses a Chromium headless browser to save the generated MediaWiki page as PDF. The result is identical to going to the wiki page and hitting print, and then "Destination: Save as PDF". Because the Wiki page does not contain a list of contributors, it's not present in the PDF file.

Aug 7 2023, 3:00 PM · Proton
pmiazga updated subscribers of T320559: Trace header propagation for MediaWiki.

@Krinkle had a pretty good question regarding the wgAllowExternalReqID guard.

Aug 7 2023, 1:04 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MediaWiki-Platform-Team, Observability-Tracing

Jul 28 2023

pmiazga changed the status of T342514: Indicate on Special:Version when no skins or no extension are installed from Open to In Progress.
Jul 28 2023, 3:22 PM · MW-1.41-notes (1.41.0-wmf.22; 2023-08-15), MW-1.40-release, MW-1.39-release, MediaWiki-Services-Group-onboarding, MediaWiki-Platform-Team, MediaWiki-General

Jul 21 2023

pmiazga renamed T341610: Add LastModified header support to Proton codebase from Add ETag support to Proton codebase to Add LastModified header support to Proton codebase.
Jul 21 2023, 3:31 PM · Proton, WMF-Architecture-Team, RESTBase Sunsetting
pmiazga updated subscribers of T341610: Add LastModified header support to Proton codebase.

Yesterday I confirmed with @Vgutierrez and @daniel that instead of building/creating the etag, we can just passthrough the LastModified - which btw is a better way. I'm going to update this phab ticket to reflect the current state.

Jul 21 2023, 3:27 PM · Proton, WMF-Architecture-Team, RESTBase Sunsetting

Jul 19 2023

pmiazga added a watcher for Observability-Tracing: pmiazga.
Jul 19 2023, 2:07 PM