pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (102 w, 3 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Today

pmiazga added a comment to T181195: Add a share button to the mobile site.

I made a proof of concept so we can see how this looks like in real life. The share feature is disabled, by default, will be visible only to beta users on mobile site. Also, there is a config variable that allows us to enable/disable the feature.

Fri, Sep 21, 6:41 PM · Patch-For-Review, Readers-Web-Backlog (Design)

Yesterday

pmiazga committed rMSCR7cfe93fb6ab5: Bump Puppeteer to latest 1.8.0 version (authored by pmiazga).
Bump Puppeteer to latest 1.8.0 version
Thu, Sep 20, 7:03 PM
pmiazga committed rMSCR0c5989d7cd14: Handle undefined response (authored by pmiazga).
Handle undefined response
Thu, Sep 20, 4:56 PM
pmiazga moved T201158: [4hrs] Have a Grafana dashboard for Proton from Needs Code Review to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Thu, Sep 20, 2:35 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, monitoring, Proton, Services (watching)

Wed, Sep 19

pmiazga committed rMSCRf764787550b2: Handle undefined response (authored by pmiazga).
Handle undefined response
Wed, Sep 19, 6:34 PM
pmiazga added a comment to T204606: Some requests takes over 60 seconds to be processed: what to do?.

I'd like to add one more Acceptance Criteria -> parse only first 1000 images, then skip the rest. Anyone against?

Wed, Sep 19, 5:41 PM · Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog
pmiazga added a comment to T204746: It should be possible to opt into new page issues treatment via query string parameter.

To get the user group we always call

Wed, Sep 19, 5:27 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Audiences-QA, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MinervaNeue
pmiazga committed rMSCR42b5c2694578: Handle undefined response (authored by pmiazga).
Handle undefined response
Wed, Sep 19, 12:44 PM
pmiazga committed rMSCR738cf9710270: Bump Puppeteer to latest 1.8.0 version (authored by pmiazga).
Bump Puppeteer to latest 1.8.0 version
Wed, Sep 19, 11:23 AM
pmiazga added a comment to T186748: New service request: chromium-render/deploy.

@mobrovac we're on 1.7.0, Puppeteer 1.8.0 got released like a week ago. Today I'll create a patch to update puppeteer to the latest version (we will be able to drop the CHROME_BIN variable)

Wed, Sep 19, 9:25 AM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations

Tue, Sep 18

pmiazga added a comment to T204606: Some requests takes over 60 seconds to be processed: what to do?.

yes, we're skipping small images but somehow it doesn't work, we can add a simple check that only first X images will be transformed, that should be pretty easy.
I checked the code and it's pretty simple but most probably performance is pretty bad (we're doing many DOM operations on pretty big DOMDocument), I'll do some small research and try to do things differently (like clone elements instead of creating new one every time) and do some performance testing using https://en.wikipedia.org/wiki/User:West.andrew.g/2013_popular_pages)

Tue, Sep 18, 7:21 PM · Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog
pmiazga added a comment to T204606: Some requests takes over 60 seconds to be processed: what to do?.

Maybe there is a faster/less resource heavy images transformation -> that the first thing to check. Second -> maybe we can just parse first X images, and then skip the rest, I agree, a page with 11k images is huge, and most probably we should skip transformation for such pages.
Do we know what is the average image count?

Tue, Sep 18, 3:54 PM · Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog

Mon, Sep 17

pmiazga created T204606: Some requests takes over 60 seconds to be processed: what to do?.
Mon, Sep 17, 8:55 PM · Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog
pmiazga added a project to T202978: Move MobileFrontend's VisualEditor styles back to MobileFrontend: Readers-Web-Backlog (Tracking).
Mon, Sep 17, 8:29 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Readers-Web-Backlog (Tracking), VisualEditor (Current work), Technical-Debt, MinervaNeue, MobileFrontend
pmiazga added a comment to T201158: [4hrs] Have a Grafana dashboard for Proton.

Moved to workboard as I'm actively working on it

Mon, Sep 17, 4:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, monitoring, Proton, Services (watching)
pmiazga added a project to T201158: [4hrs] Have a Grafana dashboard for Proton: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1).
Mon, Sep 17, 4:15 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, monitoring, Proton, Services (watching)
pmiazga moved T181623: Chromium-render doesn't handle browser connection abort well from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Mon, Sep 17, 4:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

I'm thinking loud here: -> There is only one case when we jump out of puppeteer scope, in renderer.closeBrowser()) we ask the browser to close and then we listen to the native ChildProcess exit event - if it didn't happen we kill the browser.
The scenario @Jdrewniak talks about - happens only when something other than our code (something other than puppetter&chromium-render) tries to manage the chromium process. If we start listening to exit event all the time (not only when we ask the browser to close), we could log&prevent such situations in a nice manner.

Mon, Sep 17, 3:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

@mobrovac that's a good point. I was going to add the check anyway because that error kills the worker which IMHO is pretty bad. The chromium-render process shouldn't die, all errors have to be handled properly. Also, if that error (callback called twice) is triggered during tests -> that's more than sure it will happen on production. I'll analyze the flow and I'll try to prevent similar cases.

Mon, Sep 17, 2:32 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Wed, Sep 12

pmiazga committed rMSCR4f2eaaf45586: Hygiene: remove redundant .count (authored by pmiazga).
Hygiene: remove redundant .count
Wed, Sep 12, 10:28 PM
pmiazga updated the task description for T203480: Move advanced contributions prototype to labs .
Wed, Sep 12, 6:42 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga removed a project from T181623: Chromium-render doesn't handle browser connection abort well: Patch-For-Review.
Wed, Sep 12, 6:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga updated subscribers of T181623: Chromium-render doesn't handle browser connection abort well.

Looks like this task requires a technical QA - @Jdlrobson, @Niedzielski @Jdrewniak @nray - can one of you pick it up?

Wed, Sep 12, 4:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga updated the task description for T181623: Chromium-render doesn't handle browser connection abort well.
Wed, Sep 12, 12:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga placed T203480: Move advanced contributions prototype to labs up for grabs.
Wed, Sep 12, 12:34 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga moved T203480: Move advanced contributions prototype to labs from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Wed, Sep 12, 12:34 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga added a comment to T203480: Move advanced contributions prototype to labs .

/cc @ovasileva @alexhollender - this task is ready, prototype is live

Wed, Sep 12, 12:33 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga added a comment to T203480: Move advanced contributions prototype to labs .

The documentation is available on https://www.mediawiki.org/wiki/Reading/Web/Team/Hosting_Prototypes

Wed, Sep 12, 12:33 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga updated the task description for T203480: Move advanced contributions prototype to labs .
Wed, Sep 12, 12:33 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)

Tue, Sep 11

pmiazga added a comment to T203480: Move advanced contributions prototype to labs .

Prototype is available on https://people.wikimedia.org/~pmiazga/mobile_contributions

Tue, Sep 11, 8:02 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga updated the task description for T203480: Move advanced contributions prototype to labs .
Tue, Sep 11, 8:01 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga moved T203480: Move advanced contributions prototype to labs from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Sep 11, 5:10 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga set the point value for T203817: Continue webpack + test transition of mobile.startup to 5.
Tue, Sep 11, 4:47 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Technical-Debt, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
pmiazga added a comment to T203814: Turn on MinervaErrorLogSamplingRate (Schema:WebClientError).

IMHO we should enable this only to users without gadgets (maybe anons only?). I'm afraid that we might get lots of errors and spend way too much time on finding what's causing the issue.

Tue, Sep 11, 4:26 PM · Patch-For-Review, Wikimedia-Site-requests, Analytics, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog

Fri, Sep 7

pmiazga added a comment to T186748: New service request: chromium-render/deploy.

The task is nearly ready, the remaining bits and pieces:

  • we need to merge the last patch for T181623 - the new flow for closing the chromium browser - blocked on Services
  • security review - blocked on the review
  • fix the Icinga issues - that is most probably the configuration issue - blocked on services
  • review the Grafana dashboard - @pmiazga will do it

Then we can stream the traffic to the service to verify that it can withstand the live traffic. Service will get all requests to the old Electron service, but the PDF output will be discarded. We want to verify how the service performs in the live environment.

Fri, Sep 7, 7:14 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations
pmiazga added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

blocked, we're waiting for @mobrovac to come back from vacation.,

Fri, Sep 7, 7:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga added a comment to T203812: Allow stackTraces inside MobileFrontend error reporting.

I'm wondering what is the best way to store as much as possible without crossing the hard 1k limit for the URL. Adding some hard limit is a good way to go, but there are two pitfalls:

  • those strings will be encodeURIComponent(), which means that most probably the output will be longer, for example, the userUrl can have non-latin characters. if that happens the encoded string will be much longer than the not encoded one
  • some fields like errorUrl might be empty, we can use that space for longer stack traces
  • error messages can be super short (like Type error.) or pretty long (over 200 characters)
  • stacktrace might contain repetitive data (like most of the files share a similar path)
Fri, Sep 7, 6:20 PM · Readers-Web-Backlog
pmiazga moved T203480: Move advanced contributions prototype to labs from Doing to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Fri, Sep 7, 1:39 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)

Thu, Sep 6

pmiazga added a comment to T203480: Move advanced contributions prototype to labs .

ok, I'll do a quick research where to put it and comment in the task.

Thu, Sep 6, 5:15 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga claimed T203480: Move advanced contributions prototype to labs .
Thu, Sep 6, 5:02 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga moved T203480: Move advanced contributions prototype to labs from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Thu, Sep 6, 5:02 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)

Wed, Sep 5

pmiazga claimed T203522: Popups php unit tests mysteriously failing and blocking merges.
Wed, Sep 5, 6:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)
pmiazga moved T203522: Popups php unit tests mysteriously failing and blocking merges from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Wed, Sep 5, 6:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1)

Mon, Sep 3

pmiazga created T203408: Why did lastVisualChange and SpeedIndexes3G went up for mobile/desktop..
Mon, Sep 3, 5:46 PM · Performance-Team, Readers-Web-Backlog (Tracking)
pmiazga placed T202701: Bug: Thumbnails are incorrectly given the view-border-box class causing a minor on-load reflow (FOUC) up for grabs.
Mon, Sep 3, 4:28 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Need-volunteer, Easy, MinervaNeue, MobileFrontend
pmiazga moved T202701: Bug: Thumbnails are incorrectly given the view-border-box class causing a minor on-load reflow (FOUC) from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Mon, Sep 3, 4:28 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Need-volunteer, Easy, MinervaNeue, MobileFrontend
pmiazga claimed T202701: Bug: Thumbnails are incorrectly given the view-border-box class causing a minor on-load reflow (FOUC).
Mon, Sep 3, 3:26 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Need-volunteer, Easy, MinervaNeue, MobileFrontend
pmiazga moved T202701: Bug: Thumbnails are incorrectly given the view-border-box class causing a minor on-load reflow (FOUC) from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Mon, Sep 3, 3:26 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Need-volunteer, Easy, MinervaNeue, MobileFrontend

Fri, Aug 31

pmiazga added a comment to T186748: New service request: chromium-render/deploy.

I think (I didn't verify it yet) that it fails because of introduced restbase checks:

Fri, Aug 31, 9:11 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations
pmiazga removed a project from T202026: Report client-side JavaScript errors in MobileFrontend practically: Patch-For-Review.
Fri, Aug 31, 4:29 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MobileFrontend (MobileFrontend.js)

Thu, Aug 30

pmiazga closed T202742: [subtask] Add bundlesize tests as Resolved.
Thu, Aug 30, 4:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
pmiazga closed T202742: [subtask] Add bundlesize tests, a subtask of T195475: [EPIC] Automate asset bundling in MobileFrontend/Minerva, as Resolved.
Thu, Aug 30, 4:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Readers-Web-Kanbanana-Board-Old, User-Jdlrobson, Epic, MobileFrontend, MinervaNeue
pmiazga closed T202742: [subtask] Add bundlesize tests, a subtask of T199452: Introduce webpack config/node-qunit and port ModuleLoader, as Resolved.
Thu, Aug 30, 4:18 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Readers-Web-Kanbanana-Board-Old, MobileFrontend (MobileFrontend.js)
pmiazga added a comment to T202742: [subtask] Add bundlesize tests.

Tested locally, works as expected. After a couple changes to the mobile.startup.js script started to fail that file size exceed the max size.

Thu, Aug 30, 4:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue
pmiazga claimed T202742: [subtask] Add bundlesize tests.
Thu, Aug 30, 1:35 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, MobileFrontend (MobileFrontend.js), User-Jdlrobson, MinervaNeue

Wed, Aug 29

pmiazga committed rMSCR4606f7e13e5b: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Wed, Aug 29, 8:32 PM
pmiazga committed rMSCR9bbf27a15dcf: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Wed, Aug 29, 2:07 PM

Tue, Aug 28

pmiazga committed rMSCR0f4074ac4430: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Tue, Aug 28, 7:36 PM
pmiazga moved T186748: New service request: chromium-render/deploy from Needs More Work to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
Tue, Aug 28, 5:06 PM · User-notice, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Services (blocked), Service-deployment-requests, Proton, Electron-PDFs, Operations
pmiazga committed rMSCRaa7ad32d9886: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Tue, Aug 28, 3:06 PM
pmiazga committed rMSCRb6c8d3d1b326: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Tue, Aug 28, 11:34 AM
pmiazga committed rMSCR643c454d06e5: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Tue, Aug 28, 11:08 AM
pmiazga committed rMSCR9fbc5516599f: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Tue, Aug 28, 11:08 AM
pmiazga committed rMSCR0adf69b3cbf7: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Tue, Aug 28, 10:55 AM
pmiazga committed rMSCR26db7e36de10: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Tue, Aug 28, 10:55 AM
pmiazga committed rMSCR8a8caad32a65: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Tue, Aug 28, 10:55 AM

Mon, Aug 27

pmiazga committed rMSCR2f3f51cf2eb4: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Mon, Aug 27, 6:44 PM
pmiazga committed rMSCR7bcecd5e4d62: Update Puppeteer to v1.7.0 (authored by pmiazga).
Update Puppeteer to v1.7.0
Mon, Aug 27, 5:14 PM
pmiazga committed rMSCR3f4662b19f05: Handle the stopping chromium rendering correctly (authored by pmiazga).
Handle the stopping chromium rendering correctly
Mon, Aug 27, 5:14 PM

Aug 13 2018

pmiazga updated subscribers of T194731: Show diffs for all slots [MCR].

I also did couple of tests before and I found that:

  • MobileFrontend uses different DiffEngine (it's hardcoded), this is something you have to talk to Reading Web
  • I also remember there is a work on a different engine that nicely shows when stuff is moved around (instead of just showing added/removed) it shows "moved" with an arrow that points to the new location (@Jdlrobson will know more)
  • at least on my machine populateContentTablesthrows strange mysql errors:
Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback') in /vagrant/mediawiki/includes/libs/rdbms/lbfactory/LBFactory.php on line 707
Wikimedia\Rdbms\DBTransactionStateError from line 1298 of /vagrant/mediawiki/includes/libs/rdbms/database/Database.php: Cannot execute query from Wikimedia\Rdbms\Database::ping while transaction status is ERROR.
Aug 13 2018, 8:23 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Wikidata, Structured-Data-Commons

Aug 10 2018

pmiazga committed rMSCRcbd9395d5ca8: Update Puppeteer to v1.7.0 (authored by pmiazga).
Update Puppeteer to v1.7.0
Aug 10 2018, 8:03 PM
pmiazga committed rMSCRbbe01cded533: Handle the stopping chromium rendering correclty (authored by pmiazga).
Handle the stopping chromium rendering correclty
Aug 10 2018, 1:19 AM
pmiazga committed rMSCR44d772b27bca: Handle the stopping chromium rendering correclty (authored by pmiazga).
Handle the stopping chromium rendering correclty
Aug 10 2018, 1:14 AM
pmiazga moved T181623: Chromium-render doesn't handle browser connection abort well from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
Aug 10 2018, 1:12 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga committed rMSCR130e32ee19dd: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Aug 10 2018, 12:21 AM
pmiazga committed rMSCRa4e41ac3e99d: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Aug 10 2018, 12:18 AM
pmiazga committed rMSCR82f711bb0f94: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Aug 10 2018, 12:18 AM

Aug 9 2018

pmiazga committed rMSCR28e1215594d0: To prevent resource starvation, try to kill chromium after 3s (authored by pmiazga).
To prevent resource starvation, try to kill chromium after 3s
Aug 9 2018, 10:18 PM
pmiazga added a comment to T201565: Phan error inside ThanksLogFormatter.

Very similar construct has also the NewsletterExtension

Aug 9 2018, 6:54 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Growth-Team, phan-taint-check-plugin, Thanks
pmiazga moved T181623: Chromium-render doesn't handle browser connection abort well from Blocked on Others to Doing on the Readers-Web-Kanbanana-Board-Old board.
Aug 9 2018, 5:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work
pmiazga added a project to T181623: Chromium-render doesn't handle browser connection abort well: Readers-Web-Kanbanana-Board-Old.
Aug 9 2018, 5:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work

Aug 8 2018

pmiazga added a comment to T201158: [4hrs] Have a Grafana dashboard for Proton.

By simply exporting one from beta cluster grafana and importing it into production grafana I've created this https://grafana.wikimedia.org/dashboard/db/proton?orgId=1

However, a couple of questions for @pmiazga who was the one creating the dashboard in the beginning:

  1. What's queue management vs jobs management? Could you either clarify the names or add a legend? Why is abandoned metric has .count.count in it?

Queue -> it's the time when the task waits before it gets picked to render
Job -> the task got picked and started rendering,
The main difference is that we can have a pretty long queue and render only a couple of pages at once, we specify the different timeout/max size for the queue (as the task in this state do not require any resources) and different timeout for the jobs (as the task is processing and it requires the chromium instance)
about the count.count -> I'm not sure, I need to check the code. Most probably I named the bucket as something.count and then I take count of that.

  1. I believe that you wanted to use rates vs counts - counts are kinda meaningless cause they get nullified only on every flush, which is kinda arbitrary if I understand that correctly.

Thanks for the info, I'll check it

  1. Please add axis measurement units legend to all the graphs and also select appropriate units for the axis (for example latency graph uses short now while it should use ms

Will do, thanks for the tip

  1. All the services dashboards expose heap and GC graphs - please add them, you can find the examples on MCS dashboard https://grafana.wikimedia.org/dashboard/db/mobileapps?orgId=1

Will do, thanks for the tip

  1. I do not believe all the metrics are correct. The request rate from the last graph is 0.30 but the sum of request rates by type and by format are both 0.20 - where did 0.10 requests/s go?

Thos could be rejected request (because of timeouts/failed jobs etc). I'll check the graphs once again.

Aug 8 2018, 1:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, monitoring, Proton, Services (watching)

Aug 7 2018

pmiazga closed T201406: CI failing on Minerva as Resolved.
Aug 7 2018, 8:55 PM · MinervaNeue
pmiazga added a comment to T201406: CI failing on Minerva.

This task was solved by the https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/451045/ (reverting T173527)

Aug 7 2018, 8:55 PM · MinervaNeue
pmiazga added a comment to T173527: Allow people to explicitly choose skins for stationary and mobile.

@Esanders, the problem was with the Skin initialization system. MobileFrontend changes broke Minerva tests because the MobileFrontend stopped executing RequestContextCreateSkinMobile and the Minerva skin wasn't initialized properly.
By "wasn't initialized properly" I mean that the skinOptionsweren't set properly, all values were set to default false instead of proper values.

Aug 7 2018, 8:48 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Reading-Web-Third-Party-Support, Readers-Web-Backlog (Tracking), MediaWiki-User-preferences, MobileFrontend
pmiazga added a comment to T173527: Allow people to explicitly choose skins for stationary and mobile.

After digging into the code I found whats wrong:

Aug 7 2018, 6:00 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Reading-Web-Third-Party-Support, Readers-Web-Backlog (Tracking), MediaWiki-User-preferences, MobileFrontend
pmiazga moved T193172: [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.
Aug 7 2018, 5:08 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend
pmiazga added a comment to T201124: Provide standard/reproducible way to access a PageToken.

When refactoring, please keep in mind, that in Page previews repo, when we create a pageInteractionToken -> this token has to be unique for each preview. We cannot use the same token if the user dwells over the same link twice.

Aug 7 2018, 4:41 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board-Old, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings

Aug 6 2018

pmiazga moved T201233: Long math output unreadable on small screens due to scrolling off the side of screen from Needs triage to Triaged on the Mobile board.
Aug 6 2018, 8:42 PM · Readers-Web-Backlog (Design), MobileFrontend, Mobile, Math
pmiazga added projects to T201233: Long math output unreadable on small screens due to scrolling off the side of screen: MobileFrontend, Readers-Web-Backlog.
Aug 6 2018, 8:42 PM · Readers-Web-Backlog (Design), MobileFrontend, Mobile, Math
pmiazga added a project to T201228: Make it possible to reach the page history from mobile diff: Readers-Web-Backlog.
Aug 6 2018, 8:27 PM · Readers-Web-Backlog (Design), MobileFrontend
pmiazga moved T198579: Popups triggers "deprecated ResourceLoader module jquery.hidpi" on several pages from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.
Aug 6 2018, 5:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Easy, Page-Previews
pmiazga claimed T180050: [Russian] [Chinese] PHP Warning: Recursion detected in RequestContext.
Aug 6 2018, 2:34 PM · Readers-Web-Backlog, TextExtracts, Russian-Sites, Technical-Debt, Chinese-Sites, Wikimedia-production-error
pmiazga moved T201131: Bug: Order of some paragraphs is flipped on mobile from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
Aug 6 2018, 10:14 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend
pmiazga moved T201131: Bug: Order of some paragraphs is flipped on mobile from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.
Aug 6 2018, 10:04 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend
pmiazga claimed T201131: Bug: Order of some paragraphs is flipped on mobile.
Aug 6 2018, 9:36 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend

Aug 3 2018

pmiazga moved T197110: [Bug] Changing gallery images causes an abrupt and jarring white flash from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.
Aug 3 2018, 8:36 PM · User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MinervaNeue
This is a test notification, sent at Fri, Aug 3, 21:58.
Aug 3 2018, 7:58 PM
pmiazga added a comment to T201131: Bug: Order of some paragraphs is flipped on mobile.

That's a bug, most probably introduced in T199282, I'm on it

Aug 3 2018, 7:51 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Ryasmeen, Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, MobileFrontend
pmiazga added a comment to T181623: Chromium-render doesn't handle browser connection abort well.

@mobrovac as a easy/hacky fix for now, we can use Browser.process() (kudos to @phuedx for finding that) to get the Chromium child process and kill it.

Aug 3 2018, 11:10 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), User-Jdlrobson, Readers-Web-Kanbanana-Board-Old, Proton, Unplanned-Sprint-Work