Page MenuHomePhabricator

pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (176 w, 5 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Mon, Feb 10

pmiazga added a comment to T243925: Grant +2 gerrit rights for @polishdeveloper.

Using old phab account for last time, just to confirm that it is me.

Mon, Feb 10, 11:44 AM · MediaWiki-Gerrit-Group-Requests, Gerrit-Privilege-Requests

Jan 6 2020

Jdlrobson awarded T225213: Main Menu should work without JavaScript to be more accessible and a better user experience a Like token.
Jan 6 2020, 6:16 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Jan 2 2020

pmiazga added a comment to T241161: Download link and watchstar briefly exchange position in menu toolbar.

Marking as "declined" - the icon is added on the client side, before adding "download" icon system has to verify the print feature availability, thus it's is not possible to do that during page render

Jan 2 2020, 3:11 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
pmiazga closed T241161: Download link and watchstar briefly exchange position in menu toolbar as Declined.
Jan 2 2020, 3:08 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend
pmiazga added a comment to T241161: Download link and watchstar briefly exchange position in menu toolbar.

I'm tempted to mark this as "won't fix" and resolve it. Another approach would be always adding the "Download" icon on the backend, and then hide when a device does not support printing. But this again would cause the "flicker" for all devices that we think do not support printing - eg all other than Android plus older Android/Chrome versions.

Jan 2 2020, 1:16 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend

Dec 30 2019

pmiazga added a comment to T241161: Download link and watchstar briefly exchange position in menu toolbar.

I'm not sure if there is anything we could do about it. The Download icon is injected on the client-side (via Javascript) as we need to test browser capabilities for printing the page down.
Older browsers (Android >= 5 and/or Chrome >= 41) do not support print, therefore we cannot show the download icon (downloading on mobile is handled by "print to pdf' functionality). The download button is not present
in the HTML until Javascript fully kicks, then we check print support[1] and if that returns true, we add the "download" icon to the menu.

Dec 30 2019, 7:55 AM · Readers-Web-Backlog, MinervaNeue, MobileFrontend

Dec 24 2019

pmiazga added a comment to T234907: RFC: Where to implement Desktop Improvements project.

In fact, i believe at one point this sort of subclassing was explicitly recommended in the docs somewhere

Dec 24 2019, 3:08 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Dec 23 2019

pmiazga added a comment to T234907: RFC: Where to implement Desktop Improvements project.

I just wanted to highlight that we need to take precautions while working on the Vector skin. Some popular 3rd party skins/extensions depend heavily on Vector. For example Hydra developed/used by Gamepedia has HydraSkin, and the SkinHydra class extends SkinVector ( source code: https://gitlab.com/hydrawiki/skins/hydra/blob/master/SkinHydra.php ), therefore any bigger changes to SkinVector might break their sites.

Dec 23 2019, 12:26 PM · TechCom-RFC (TechCom-RFC-Closed), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Dec 19 2019

Volker_E awarded T225213: Main Menu should work without JavaScript to be more accessible and a better user experience a Grey Medal token.
Dec 19 2019, 10:11 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Jdlrobson, Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Dec 17 2019

pmiazga updated subscribers of T240868: [Regression] AMC - spacing wrong in article toolbar icons .

@alexhollender why do we need two different views, equally spaced and aligned to left/right?. Can we just have a one style for all possible cases?

Dec 17 2019, 6:23 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Dec 16 2019

pmiazga reassigned T232594: Add article and discussion tabs to all logged-in users on mobile from pmiazga to Edtadros.
Dec 16 2019, 7:53 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga reassigned T232652: Add History to article toolbar for all logged-in users from pmiazga to Edtadros.
Dec 16 2019, 7:52 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga moved T237635: [SPIKE] What should feature management look like in desktop improvements? from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 16 2019, 6:23 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Dec 9 2019

pmiazga claimed T232594: Add article and discussion tabs to all logged-in users on mobile.
Dec 9 2019, 6:23 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga placed T232734: Mobile logout should not involve an interstitial up for grabs.
Dec 9 2019, 6:15 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend
pmiazga added a comment to T232734: Mobile logout should not involve an interstitial.

Tested on Beta cluster - works as expected

Dec 9 2019, 6:15 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend
pmiazga moved T232734: Mobile logout should not involve an interstitial from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 9 2019, 6:14 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend

Dec 4 2019

pmiazga added a comment to T232594: Add article and discussion tabs to all logged-in users on mobile.

To confirm - the latter would still mean that only logged-in users would view the changes? If so, that's fine - we don't plan on having separate configurations per wiki

Dec 4 2019, 6:22 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga added a comment to T237635: [SPIKE] What should feature management look like in desktop improvements?.

Blocked on SuperHappyDevTime meeting

Dec 4 2019, 6:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
pmiazga moved T237635: [SPIKE] What should feature management look like in desktop improvements? from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 4 2019, 6:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Dec 3 2019

pmiazga updated subscribers of T232594: Add article and discussion tabs to all logged-in users on mobile.

@ovasileva just to confirm, we want to enable both this task and T232652: Add History to article toolbar for all logged-in users on all wikis/projects. We're trying to decide on the best direction and we're considering two options:

  • adding a loggedin mode, then these feature will be available to all logged_in users
  • remove the feature flags, and make those two features an integral part of the MobileFrontend/Minerva.
Dec 3 2019, 6:50 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga claimed T237635: [SPIKE] What should feature management look like in desktop improvements?.
Dec 3 2019, 6:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
pmiazga moved T237635: [SPIKE] What should feature management look like in desktop improvements? from Upcoming to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Dec 3 2019, 6:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Nov 7 2019

pmiazga moved T232734: Mobile logout should not involve an interstitial from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 7 2019, 10:03 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend

Nov 6 2019

pmiazga moved T232734: Mobile logout should not involve an interstitial from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 6 2019, 6:04 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend

Nov 4 2019

pmiazga moved T232734: Mobile logout should not involve an interstitial from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Nov 4 2019, 6:04 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend
pmiazga updated subscribers of T173023: Define and limit colors in new print styles.

/cc @ovasileva @alexhollender is it something we should worry? It's marked high and it's not in progress for 2 years.

Nov 4 2019, 10:42 AM · Design, Readers-Web-Backlog (Tracking), UI-Standardization, UI-Standardization-Kanban, Vector

Oct 24 2019

pmiazga closed T221007: Extract Echo handling from SkinMinerva class as Resolved.
Oct 24 2019, 2:24 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-Jdlrobson, good first task, Growth-Team, Notifications, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga closed T221007: Extract Echo handling from SkinMinerva class, a subtask of T221022: [EPIC] Divide MobileFrontend component concerns, as Resolved.
Oct 24 2019, 2:24 PM · Readers-Web-Backlog, Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
pmiazga updated the task description for T221007: Extract Echo handling from SkinMinerva class.
Oct 24 2019, 2:24 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-Jdlrobson, good first task, Growth-Team, Notifications, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Oct 23 2019

pmiazga placed T232734: Mobile logout should not involve an interstitial up for grabs.
Oct 23 2019, 5:06 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend
pmiazga moved T232734: Mobile logout should not involve an interstitial from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 23 2019, 5:06 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend

Oct 22 2019

pmiazga placed T221007: Extract Echo handling from SkinMinerva class up for grabs.
Oct 22 2019, 3:31 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-Jdlrobson, good first task, Growth-Team, Notifications, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga moved T221007: Extract Echo handling from SkinMinerva class from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 22 2019, 3:31 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-Jdlrobson, good first task, Growth-Team, Notifications, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga added a comment to T221007: Extract Echo handling from SkinMinerva class.

The patches above tackled moving the Echo stuff out of Minerva skin (moved related notifications code to Echo extension). There is no defined contract between Minerva and Echo, only a not documented hook SkinMinervaReplaceNotificationsBadge. This approach is also valid but before I can signoff this task we need to:

  • document the SkinMinervaReplaceNotificationsBadge hook
  • remove Echo from .phan directory_list config as it's not required any more.
  • removed unused EchoNotifUser class from SkinMinervaTest
  • the mobile-frontend-user-newmessages in qqq.json says Tooltip for new messages on the users talk page (if no Extension:Echo installed).", now it can be anything other than Echo, would be nice to update this message
  • resources/skins.minerva.scripts/menu.js still has some Echo handling. Do we want to move it? It uses hooks, so most probably can stay, I just wanted to highlight this.
Oct 22 2019, 3:31 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-Jdlrobson, good first task, Growth-Team, Notifications, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga claimed T232734: Mobile logout should not involve an interstitial.
Oct 22 2019, 3:14 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend
pmiazga moved T232734: Mobile logout should not involve an interstitial from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 22 2019, 3:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend

Oct 17 2019

pmiazga updated the task description for T232734: Mobile logout should not involve an interstitial.
Oct 17 2019, 5:34 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MediaWiki-Authentication-and-authorization, MediaWiki-User-login-and-signup, MobileFrontend
pmiazga placed T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users? up for grabs.
Oct 17 2019, 5:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga moved T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users? from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 17 2019, 5:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga added a comment to T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users?.

Logged-in users

A/B testing logged-in users is straightforward. We can easily do that on the server-side, and there is no need for any caching layer changes as all logged-in users requests skip cache.
The only required work is the backend (PHP) work.

Oct 17 2019, 5:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga claimed T221007: Extract Echo handling from SkinMinerva class.
Oct 17 2019, 4:26 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-Jdlrobson, good first task, Growth-Team, Notifications, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
pmiazga closed T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load), a subtask of T127268: Dismantle ResourceLoader's "targets" system, as Resolved.
Oct 17 2019, 4:26 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Patch-For-Review, User-Jdlrobson, Performance-Team, Readers-Web-Backlog (Tracking), Developer-Wishlist (2017), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MediaWiki-ResourceLoader
pmiazga closed T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load), a subtask of T173283: Extra 100KB of JS loaded by mobilemaps gadget on pageview, as Resolved.
Oct 17 2019, 4:26 PM · Readers-Web-Backlog (Tracking), Performance-Team (Radar), Maps-Sprint, Maps (Kartographer)
pmiazga closed T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load) as Resolved.
Oct 17 2019, 4:26 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Performance-Team (Radar), MediaWiki-extensions-Gadgets

Oct 15 2019

pmiazga added a comment to T233802: Add an option in the global preferences to enable Advanced Contributions mode globally.

The Special:MobileOptions has different UI and serves different purposes. But the preferences are still stored in the user preferences table, therefore it's possible to store those without deprecating MobileOptions page. Now it requires some research on how GlobalPreferences extension picks up which options to store as "global" and then decide on which part of code we need to update.

Oct 15 2019, 8:01 PM · Readers-Web-Backlog (Tracking), MediaWiki-extensions-GlobalPreferences, Advanced Mobile Contributions
pmiazga added a comment to T211006: Add redlink experience to empty search results on Mobile (JS version).

The link to search pages created on mobile device for English Wikipedia: https://en.wikipedia.org/w/index.php?hidebots=1&hidepageedits=1&hidecategorization=1&hideWikibase=1&namespace=0&tagfilter=mobile+edit&limit=50&days=7&title=Special:RecentChanges&urlversion=2

Oct 15 2019, 4:44 PM · Readers-Web-Backlog (Design), Desktop Improvements, Advanced Mobile Contributions, Discovery, Editing-team, MobileFrontend
pmiazga added a comment to T226071: Having trouble setting up MobileFrontend for development.

@Milimetric do you still see this issue?

Oct 15 2019, 4:28 PM · Readers-Web-Backlog, MobileFrontend
pmiazga added a comment to T233802: Add an option in the global preferences to enable Advanced Contributions mode globally.

There is small issue with this task. The AMC switch is a part of Mobile Preferences, it's not visible on the Special:Preferences page, thus most probably it's not stored as a global preference

Oct 15 2019, 4:18 PM · Readers-Web-Backlog (Tracking), MediaWiki-extensions-GlobalPreferences, Advanced Mobile Contributions
pmiazga placed T230016: Update description under AMC setting up for grabs.
Oct 15 2019, 4:01 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
pmiazga moved T230016: Update description under AMC setting from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 15 2019, 4:01 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
pmiazga added a comment to T234344: MinervaClientError sends malformed events.

The problem is that in some scenarios we get an event with malformed URL. The statsv client looks like it's correct, the code that triggers MinervaClientError event also has no trace of anything that would cause malformed event. The issue can be related or to the browser itself or to some code in maps feature. From @Jdrewniak description it looks like this happens only after Maps widget causes the CORS error.

Oct 15 2019, 3:53 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
pmiazga updated subscribers of T235424: Convert action=protect to OOUI (protect form is unusable on mobile).

/cc @alexhollender @ovasileva this is most probably something we can do under the AMC work, not sure if we have time for it.

Oct 15 2019, 3:41 PM · Readers-Web-Backlog, UI-Standardization, MediaWiki-Page-protection, MobileFrontend, Advanced Mobile Contributions
pmiazga added a comment to T235346: Edits which has been reverted and revision deleted over 40 hours ago were visible on page previews.

@mobrovac can you take this task and push it forward?

Oct 15 2019, 11:53 AM · Readers-Web-Backlog (Tracking), RESTBase-API, User-Josve05a, Page-Previews
pmiazga added a comment to T235424: Convert action=protect to OOUI (protect form is unusable on mobile).

@Zoranzoki21 could you specify what exactly is missing? Do you mean that some content is missing, or just a border around some controls.

Oct 15 2019, 11:51 AM · Readers-Web-Backlog, UI-Standardization, MediaWiki-Page-protection, MobileFrontend, Advanced Mobile Contributions
pmiazga added a project to T235346: Edits which has been reverted and revision deleted over 40 hours ago were visible on page previews: Readers-Web-Backlog (Tracking).
Oct 15 2019, 11:23 AM · Readers-Web-Backlog (Tracking), RESTBase-API, User-Josve05a, Page-Previews
pmiazga updated subscribers of T235346: Edits which has been reverted and revision deleted over 40 hours ago were visible on page previews.

@mobrovac @Pchelolo Is it possible that the Restbase endpoint is serving an outdated extract" If I remember right it has some caching built-in.

Oct 15 2019, 11:23 AM · Readers-Web-Backlog (Tracking), RESTBase-API, User-Josve05a, Page-Previews
pmiazga updated subscribers of T234344: MinervaClientError sends malformed events.

@JoeWalsh is it something Product Infrastructure could look at ?

Oct 15 2019, 11:20 AM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue

Oct 14 2019

pmiazga added a project to T235416: Bullet points are not centered in horizontal lists: Readers-Web-Backlog.
Oct 14 2019, 5:16 PM · Accessibility, Reading-Web-Local-Wiki-Issues, Readers-Web-Backlog (Kanbanana-2019-20-Q2), CSS, good first task, MinervaNeue
pmiazga added a project to T235436: Vagrant installation fails: Readers-Web-Backlog (Tracking).
Oct 14 2019, 5:06 PM · Readers-Web-Backlog (Tracking), MediaWiki-Vagrant, WMSE-Bug-Reporting-and-Translation-2019, MobileFrontend

Oct 11 2019

pmiazga added a comment to T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load).

Looks good, on Monday I'll check couple things and then I'll resolve it.

Oct 11 2019, 9:03 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Performance-Team (Radar), MediaWiki-extensions-Gadgets
Jdlrobson awarded T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users? a Like token.
Oct 11 2019, 5:21 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Oct 10 2019

pmiazga added a comment to T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users?.

@ovasileva

  • do we want to A/B test it per page or per the whole wiki?
  • do we know what is going to be our population size/which wikis do we want to A/B test? (like do we want to test on 100 users, or do we want to test on multiple wikis on 100 thousand anon users/sessions).
Oct 10 2019, 6:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga edited projects for T233037: [Regression] Not possible for logged in users to disable page previews, added: Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog (Kanbanana-2019-20-Q2).
Oct 10 2019, 2:35 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews
pmiazga added a comment to T233037: [Regression] Not possible for logged in users to disable page previews.

@awight - I can see popups as a logged-in user who disabled Page Previews on the Preferences page. It happens when I hover a regular page link.

Oct 10 2019, 1:24 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews

Oct 9 2019

pmiazga moved T234344: MinervaClientError sends malformed events from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 9 2019, 5:05 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
pmiazga claimed T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load).
Oct 9 2019, 5:04 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Performance-Team (Radar), MediaWiki-extensions-Gadgets
pmiazga updated subscribers of T233037: [Regression] Not possible for logged in users to disable page previews.

Moved to "Blocked on others" as it would be more valuable for the team who created Reference Previews to look at it (as it may be related).

Oct 9 2019, 4:33 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews
pmiazga updated the task description for T233612: Deploy Advanced mode to all Wikimedia projects.
Oct 9 2019, 4:10 PM · User-notice, Wikimedia-Site-requests, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Oct 8 2019

pmiazga claimed T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users?.
Oct 8 2019, 7:47 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga moved T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users? from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 8 2019, 7:47 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga updated subscribers of T230016: Update description under AMC setting.

@ovasileva, @alexhollender
Is the Advanced mode provides improved access to talk pages, history pages, user tools, and other editing tool. message final?

Oct 8 2019, 7:46 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
pmiazga updated the task description for T230695: Render talk page as a tab (rather than a modal).
Oct 8 2019, 5:24 PM · User-notice, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Oct 4 2019

pmiazga added a comment to T233982: Feature MinervaTalkAtTop is not defined during logout.

The problem is not Minerva, the problem is how/when MobileFrontend initializes FeatureManager. Just changing hook from RequestContextCreateSkinMobile to RequestContextCreateSkin won't help. The problem will be the same - The FeatureManager won't be initialized (won't send the hook).

Oct 4 2019, 5:36 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue, Wikimedia-production-error
pmiazga moved T233982: Feature MinervaTalkAtTop is not defined during logout from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 4 2019, 10:50 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue, Wikimedia-production-error
pmiazga added a comment to T233982: Feature MinervaTalkAtTop is not defined during logout.

So the problem is:

  • The FeatureManager is a part of MobileFrontend.
  • Feature registration happens when MobileFrontend kicks in (via RequestContextCreateSkin
  • During RequestContextCreateSkin we trigger MobileFrontendFeaturesRegistration hook that allows Minerva to register it's own features
  • because we use Minerva as desktop skin, the mobile mode doesn't kick in, thus code from RequestContextCreateSkin is not called, therefore Minerva doesn't register it's features
Oct 4 2019, 10:42 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue, Wikimedia-production-error

Oct 3 2019

pmiazga moved T234344: MinervaClientError sends malformed events from Needs Analysis to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 3 2019, 5:08 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
pmiazga moved T233663: Remove Minerva's EventLogging error tracking from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 3 2019, 3:01 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review
pmiazga claimed T234344: MinervaClientError sends malformed events.
Oct 3 2019, 8:58 AM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue

Oct 2 2019

pmiazga updated subscribers of T234258: Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs?.
Oct 2 2019, 6:11 PM · Readers-Web-Backlog (Tracking)
pmiazga added a comment to T234258: Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs?.

From my knowledge, readers-web-stephen is used and cannot be deleted. @Niedzielski is on sabbatical so he cannot confirm.

Oct 2 2019, 6:11 PM · Readers-Web-Backlog (Tracking)
pmiazga closed T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct() as Declined.
Oct 2 2019, 5:14 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga added a comment to T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct().

This issue happened twice and it's related to the deployment process. It happened exactly when a new branch was pushed to production and because of some reason PHP cached old AMCManager definition but used new ServiceWirings file, thus there was an inconsistency with the argument count. This did not happen again.

Oct 2 2019, 5:14 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga placed T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts up for grabs.
Oct 2 2019, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Performance-Team (Radar), MobileFrontend
pmiazga moved T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 2 2019, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Performance-Team (Radar), MobileFrontend
pmiazga placed T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias up for grabs.
Oct 2 2019, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga moved T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Oct 2 2019, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga added a comment to T232652: Add History to article toolbar for all logged-in users.

@nray yup, that's what I did.

Oct 2 2019, 11:35 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Sep 30 2019

pmiazga moved T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Sep 30 2019, 6:52 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Performance-Team (Radar), MobileFrontend
pmiazga claimed T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias.
Sep 30 2019, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga moved T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 30 2019, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga added a watcher for Desktop Improvements: pmiazga.
Sep 30 2019, 12:03 PM

Sep 20 2019

pmiazga added a comment to T233037: [Regression] Not possible for logged in users to disable page previews.

I can confirm this is an issue on Beta Cluster - I cannot reproduce that on production Reference Previews are enabled on German Wikipedia, but everything works there.

Sep 20 2019, 7:47 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews

Sep 18 2019

pmiazga moved T231613: Replace 24x24px SVGs in MF/Minerva from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 18 2019, 9:55 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
pmiazga assigned T232723: [Bug] [AMC] Multiple MobileWebUIActionsTracking instrumentation errors to Edtadros.
Sep 18 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Mobile, MediaWiki-extensions-WikimediaEvents

Sep 17 2019

pmiazga added a comment to T232652: Add History to article toolbar for all logged-in users.

@alexhollender everything is possible, but that's probably a new task. Also, please note, that the DownloadIcon is injected via JS, thus it may cause FOUC when we decide to change styling based on the number of icons in the toolbar.

Sep 17 2019, 7:54 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga updated subscribers of T232652: Add History to article toolbar for all logged-in users.

@Alex I just want to confirm - those mocks are not in sync, right? We do not show a different toolbar for Android and iOS.

Sep 17 2019, 5:55 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga updated the task description for T230034: [AMC] Menu handle has no active state.
Sep 17 2019, 9:51 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga updated the task description for T230034: [AMC] Menu handle has no active state.
Sep 17 2019, 9:50 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions

Sep 16 2019

pmiazga reassigned T230034: [AMC] Menu handle has no active state from alexhollender to Edtadros.
Sep 16 2019, 7:30 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions