Page MenuHomePhabricator

pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (142 w, 2 h)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Today

pmiazga moved T220016: Extend and rename MobileWebMainMenuClickTracking schema from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Jun 25, 5:11 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T226490: Minerva Discussion tab do not respect MinervaPageActions config flag from Needs Analysis to Upcoming on the Readers-Web-Backlog board.
Tue, Jun 25, 4:09 PM · Advanced Mobile Contributions, MinervaNeue, Readers-Web-Backlog
pmiazga added a comment to T226106: Three clicks required to exit talk overlay.

I can reproduce that

Tue, Jun 25, 4:08 PM · Readers-Web-Backlog, MobileFrontend, MinervaNeue, Mobile
pmiazga added a comment to T226143: Minerva: Add support for SkinAfterContent hook.

Is minerva missing fieldset styles?

Tue, Jun 25, 3:58 PM · Readers-Web-Backlog, Patch-For-Review, MinervaNeue
pmiazga added a project to T226492: FlaggedRevs "Review this revision" form styles broken on Minerva skin: Readers-Web-Backlog.
Tue, Jun 25, 11:57 AM · Readers-Web-Backlog (Design), MinervaNeue, MediaWiki-extensions-FlaggedRevs
pmiazga awarded T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors a Love token.
Tue, Jun 25, 11:51 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, User-herron, Reading-Infrastructure-Team-Backlog, Wikimedia-Logstash
pmiazga added a comment to T226143: Minerva: Add support for SkinAfterContent hook.

This change is correct, but most probably we should fix how the FlaggedRevs looks like on Mobile first (it's the only extension on production that uses SkinAfterContent hook to inject something to the page).

Tue, Jun 25, 11:36 AM · Readers-Web-Backlog, Patch-For-Review, MinervaNeue
pmiazga renamed T226492: FlaggedRevs "Review this revision" form styles broken on Minerva skin from FlaggedRevs UI broken on Mobile to FlaggedRevs "Review this revision" form styles broken on Minerva skin.
Tue, Jun 25, 11:35 AM · Readers-Web-Backlog (Design), MinervaNeue, MediaWiki-extensions-FlaggedRevs
pmiazga created T226492: FlaggedRevs "Review this revision" form styles broken on Minerva skin.
Tue, Jun 25, 11:34 AM · Readers-Web-Backlog (Design), MinervaNeue, MediaWiki-extensions-FlaggedRevs
pmiazga created T226490: Minerva Discussion tab do not respect MinervaPageActions config flag.
Tue, Jun 25, 11:16 AM · Advanced Mobile Contributions, MinervaNeue, Readers-Web-Backlog

Yesterday

pmiazga added a comment to T226071: Having trouble setting up MobileFrontend for development.

@Milimetric thanks for the log. Looks like parallel-lint is missing. Usually I work from vagrant environment, and vagrant has all required dependencies installed.
I'll analyze whats wrong.

Mon, Jun 24, 9:26 PM · Readers-Web-Backlog, MobileFrontend, Analytics
pmiazga added a project to T226009: add link to Wikidata on Wikipedia mobile view: Readers-Web-Backlog.
Mon, Jun 24, 9:23 PM · Readers-Web-Backlog, MobileFrontend, Mobile, Wikidata
pmiazga added a project to T226285: Mobileview cache not cleared after wikidata edits : Readers-Web-Backlog (Tracking).
Mon, Jun 24, 9:22 PM · Readers-Web-Backlog (Tracking), Wikidata, MobileFrontend
pmiazga updated the task description for T226442: CI jobs failing for MinervaNeue (because of old pinned fibers version?).
Mon, Jun 24, 9:21 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue
pmiazga moved T221792: PageActions Menu should use Builder pattern and reuse existing Menu elements from Doing to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Mon, Jun 24, 9:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
pmiazga reassigned T221792: PageActions Menu should use Builder pattern and reuse existing Menu elements from pmiazga to Edtadros.
Mon, Jun 24, 9:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
pmiazga updated the task description for T221792: PageActions Menu should use Builder pattern and reuse existing Menu elements.
Mon, Jun 24, 9:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
pmiazga placed T224735: [AMC] Updates to user pages up for grabs.
Mon, Jun 24, 6:02 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T224735: [AMC] Updates to user pages from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Mon, Jun 24, 6:02 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Thu, Jun 20

pmiazga claimed T226143: Minerva: Add support for SkinAfterContent hook.
Thu, Jun 20, 7:02 PM · Readers-Web-Backlog, Patch-For-Review, MinervaNeue
pmiazga added a comment to T224735: [AMC] Updates to user pages.

The task description looks clear, I'm just not sure if the User subpages (example /wiki/User:Pmiazga/MyArticle) should get same treatment as user pages (eg: /wiki/User:Pmiazga).

Thu, Jun 20, 4:46 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T224735: [AMC] Updates to user pages.

@alexhollender @ovasileva just to confirm - couple questions:

Thu, Jun 20, 4:03 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T225124: Allow AMC to load user contributions page from core.

@alexhollender @ovasileva the Contributions page loaded on Mobile looks bit broken on small devices:

Thu, Jun 20, 1:40 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a project to T226143: Minerva: Add support for SkinAfterContent hook: Readers-Web-Backlog.
Thu, Jun 20, 11:42 AM · Readers-Web-Backlog, Patch-For-Review, MinervaNeue

Wed, Jun 19

pmiazga added a comment to T226071: Having trouble setting up MobileFrontend for development.

@Milimetric could you explain whats wrong? are you getting any errors?

Wed, Jun 19, 7:00 PM · Readers-Web-Backlog, MobileFrontend, Analytics
pmiazga added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

Could we also consider moving the Wikimedia-specific instrumentation for the main menu into the WikimediaEvents extension?

Wed, Jun 19, 6:20 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
pmiazga claimed T224735: [AMC] Updates to user pages.
Wed, Jun 19, 5:04 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga claimed T221792: PageActions Menu should use Builder pattern and reuse existing Menu elements.
Wed, Jun 19, 5:03 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
pmiazga moved T224735: [AMC] Updates to user pages from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Jun 19, 5:03 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T220467: Reevaluate util.parseHTML semantics in MobileFrontend.

Looks like in most places we use util.parseHTML() just to create a single element:

Wed, Jun 19, 5:02 PM · Technical-Debt, MobileFrontend, Readers-Web-Backlog

Tue, Jun 18

pmiazga committed rEEPS05704c7fc970: Revert "Add warning message to Special:ElectronPdf" (authored by pmiazga).
Revert "Add warning message to Special:ElectronPdf"
Tue, Jun 18, 7:18 PM
pmiazga added a reverting change for rEEPSef9603b7b8ad: Add warning message to Special:ElectronPdf: rEEPS05704c7fc970: Revert "Add warning message to Special:ElectronPdf".
Tue, Jun 18, 7:17 PM
pmiazga committed rEEPS1f0494a6a8d6: Revert "Add warning message to Special:ElectronPdf" (authored by pmiazga).
Revert "Add warning message to Special:ElectronPdf"
Tue, Jun 18, 7:17 PM
pmiazga added a reverting change for rEEPSef9603b7b8ad: Add warning message to Special:ElectronPdf: rEEPS1f0494a6a8d6: Revert "Add warning message to Special:ElectronPdf".
Tue, Jun 18, 7:17 PM
pmiazga placed T211002: Remove PDF banner on Special:ElectronPdf up for grabs.
Tue, Jun 18, 7:17 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), PDF Rendering
pmiazga moved T211002: Remove PDF banner on Special:ElectronPdf from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Jun 18, 7:17 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), PDF Rendering
pmiazga added a comment to T219392: AMC: add "In other projects" action to page actions overflow menu.

@Niedzielski yes, it's possible, and I thought about that use case when I was working on the Menu system. It's not available right now (because of YAGNI) but we can implement the support for submenus. On the backend we have sth like that:

Tue, Jun 18, 6:05 PM · Readers-Web-Backlog (Design), User-Jdlrobson, Advanced Mobile Contributions
pmiazga moved T211002: Remove PDF banner on Special:ElectronPdf from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Jun 18, 5:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), PDF Rendering
pmiazga claimed T211002: Remove PDF banner on Special:ElectronPdf.
Tue, Jun 18, 5:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), PDF Rendering
pmiazga moved T221792: PageActions Menu should use Builder pattern and reuse existing Menu elements from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Jun 18, 5:03 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue
pmiazga updated the task description for T224735: [AMC] Updates to user pages.
Tue, Jun 18, 4:36 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
phuedx awarded T225213: [SPIKE 8hr] Main Menu should work without javascript a Like token.
Tue, Jun 18, 4:35 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
pmiazga updated the task description for T225124: Allow AMC to load user contributions page from core.
Tue, Jun 18, 4:08 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga renamed T225879: The logout link on Special::UserLogout doesn't respect mobile domain from It is not possible to logout from wiki if mobile view is enabled and mobile wiki has separate domain to The logout link on Special::UserLogout doesn't respect mobile domain.
Tue, Jun 18, 3:46 PM · Readers-Web-Backlog (Tracking), MediaWiki-User-login-and-signup, MobileFrontend
pmiazga added a project to T225879: The logout link on Special::UserLogout doesn't respect mobile domain: Readers-Web-Backlog (Tracking).
Tue, Jun 18, 3:44 PM · Readers-Web-Backlog (Tracking), MediaWiki-User-login-and-signup, MobileFrontend
pmiazga changed the status of T225879: The logout link on Special::UserLogout doesn't respect mobile domain from Stalled to Open.
Tue, Jun 18, 3:44 PM · Readers-Web-Backlog (Tracking), MediaWiki-User-login-and-signup, MobileFrontend
pmiazga added a comment to T225879: The logout link on Special::UserLogout doesn't respect mobile domain.

I'll edit description, and leave reproduction steps

Tue, Jun 18, 3:38 PM · Readers-Web-Backlog (Tracking), MediaWiki-User-login-and-signup, MobileFrontend
pmiazga added a comment to T225879: The logout link on Special::UserLogout doesn't respect mobile domain.

@Aklapper I think I know what's the issue, the Special:LogoutPage doesn't respect the mobile domain, it creates the logout link that points to the desktop wikipedia site.

Tue, Jun 18, 3:36 PM · Readers-Web-Backlog (Tracking), MediaWiki-User-login-and-signup, MobileFrontend
pmiazga added a comment to T225879: The logout link on Special::UserLogout doesn't respect mobile domain.

@DIKW_Pyramid - the logout link on the MainMenu doesn't specify the domain, it shows only relative link to the Special:UserLogout page.

Tue, Jun 18, 3:32 PM · Readers-Web-Backlog (Tracking), MediaWiki-User-login-and-signup, MobileFrontend
pmiazga added a comment to T226009: add link to Wikidata on Wikipedia mobile view.

The T222630: Add wikidata item link to AMC overflow menu does exactly what this this ticket says - it adds a link to Wikidata item to new menu. The Advanced Mobile Contributions project is a feature set that will add more contributor features/capabilities to the mobile web experience. It's an opt-in feature, that will slightly modify the mobile web UI, and allow access to many tools (like adding Wikidata links).

Tue, Jun 18, 3:28 PM · Readers-Web-Backlog, MobileFrontend, Mobile, Wikidata
pmiazga moved T226025: Expensive viewport size access in Reference Drawers from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Tue, Jun 18, 3:15 PM · Performance-Team (Radar), Readers-Web-Backlog, MobileFrontend
pmiazga added a project to T226025: Expensive viewport size access in Reference Drawers: Readers-Web-Backlog.
Tue, Jun 18, 3:15 PM · Performance-Team (Radar), Readers-Web-Backlog, MobileFrontend
pmiazga updated subscribers of T226025: Expensive viewport size access in Reference Drawers.

@nray could you analyze this one?

Tue, Jun 18, 3:15 PM · Performance-Team (Radar), Readers-Web-Backlog, MobileFrontend
pmiazga claimed T225877: Two link rel="canonical" if $wgEnableCanonicalServerLink and $mfNoIndexPages is true.
Tue, Jun 18, 3:12 PM · Readers-Web-Backlog, MobileFrontend
pmiazga merged T226009: add link to Wikidata on Wikipedia mobile view into T222630: Add wikidata item link to AMC overflow menu.
Tue, Jun 18, 3:07 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga merged task T226009: add link to Wikidata on Wikipedia mobile view into T222630: Add wikidata item link to AMC overflow menu.
Tue, Jun 18, 3:07 PM · Readers-Web-Backlog, MobileFrontend, Mobile, Wikidata
pmiazga added a comment to T226009: add link to Wikidata on Wikipedia mobile view.

This feature is available in "Advanced Mobile Contributions" mode, we're currently working on it. It's released only to couple wikis, not available on English Wikipedia yet. For more info please refer to T222630: Add wikidata item link to AMC overflow menu.

Tue, Jun 18, 3:05 PM · Readers-Web-Backlog, MobileFrontend, Mobile, Wikidata
pmiazga claimed T225876: MobileFrontend configuration directive $mfNoIndexPages - wrong description and wrong name.
Tue, Jun 18, 3:02 PM · Readers-Web-Backlog, MobileFrontend

Mon, Jun 17

pmiazga updated the task description for T225123: Deploy AMC to fawiki, jawiki, thwiki, itwiki.
Mon, Jun 17, 12:15 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga updated the task description for T225123: Deploy AMC to fawiki, jawiki, thwiki, itwiki.
Mon, Jun 17, 12:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T225123: Deploy AMC to fawiki, jawiki, thwiki, itwiki from Doing to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Mon, Jun 17, 12:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T225123: Deploy AMC to fawiki, jawiki, thwiki, itwiki from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Mon, Jun 17, 10:07 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Fri, Jun 14

pmiazga added a comment to T222630: Add wikidata item link to AMC overflow menu.

QA is blocked on availability of testable Wikidata item on beta cluster.
Once deployed to test prod, could be tested on testwiki: https://test.m.wikipedia.org/wiki/Wikidata

Fri, Jun 14, 7:02 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga placed T222630: Add wikidata item link to AMC overflow menu up for grabs.
Fri, Jun 14, 6:55 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T222630: Add wikidata item link to AMC overflow menu from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Fri, Jun 14, 6:55 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga updated the task description for T225785: Unhelpful error when trying to view contributions of an IP range.
Fri, Jun 14, 6:45 PM · Readers-Web-Backlog, MobileFrontend
pmiazga assigned T225785: Unhelpful error when trying to view contributions of an IP range to ovasileva.
Fri, Jun 14, 6:42 PM · Readers-Web-Backlog, MobileFrontend
pmiazga added a comment to T225785: Unhelpful error when trying to view contributions of an IP range.

^ sorry, I edited the task and reverted changes by mistake

Fri, Jun 14, 6:42 PM · Readers-Web-Backlog, MobileFrontend
pmiazga placed T225785: Unhelpful error when trying to view contributions of an IP range up for grabs.
Fri, Jun 14, 6:38 PM · Readers-Web-Backlog, MobileFrontend
pmiazga updated subscribers of T225785: Unhelpful error when trying to view contributions of an IP range.

@Daimona it's 1 -> the MobileSite requires a valid user name or an IP. Showing contributions from an IP range is not supported.

Fri, Jun 14, 6:29 PM · Readers-Web-Backlog, MobileFrontend
pmiazga added a project to T225785: Unhelpful error when trying to view contributions of an IP range: Readers-Web-Backlog.
Fri, Jun 14, 6:09 PM · Readers-Web-Backlog, MobileFrontend
pmiazga added a comment to T222630: Add wikidata item link to AMC overflow menu.

@alexhollender @nray I don't think we should show wikidata link on the usernamespace - if required we can add it later. As @nray pointed, it's one line change.

Fri, Jun 14, 6:08 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Fri, Jun 14, 6:05 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions

Thu, Jun 13

pmiazga claimed T222630: Add wikidata item link to AMC overflow menu.
Thu, Jun 13, 6:04 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T225663: Homepage: add sub-header text about user longevity to mobile homepage.

Currently there is no nice and clean way to do it. Adding isSpecialHomePage() is not best approach, Minerva shouldn't be aware of any special pages from different extensions. Passing an option sounds like a small hack (as it won't be used anywhere else, only in that one specific scenario).

Thu, Jun 13, 6:03 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
pmiazga updated the task description for T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.
Thu, Jun 13, 5:43 PM · Technical-Debt, Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, MobileFrontend, Wikidata
pmiazga added a comment to T220016: Extend and rename MobileWebMainMenuClickTracking schema.

@MNeisler can we add the required = false to Destination? We want to track clicks on menu elements, some elements will not have destination, for example:

  • clicking the Main Menu hamburger icon opens MainMenu, there is a Special:MobileMenu page that we could point to, but in near future we want to get rid of this page
  • clicking the "more' icon on the Overflow menu, or clicking user icon to show User menu will not have "destination". Those are triggers for modals, when clicked browser will present a modal, not redirect user to a different page (even when no JS)
Thu, Jun 13, 2:56 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga added a comment to T218304: Allow quicksurveys to target based on registration date.

@Isaac yes, you're correct. Looks like I mixed up the documentation, pushing a fix shortly. Thanks for spotting this!

Thu, Jun 13, 12:56 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys

Wed, Jun 12

pmiazga claimed T218304: Allow quicksurveys to target based on registration date.
Wed, Jun 12, 5:07 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), QuickSurveys, Audiences-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, Surveys
pmiazga added a comment to T219434: No popup is shown when quickly hovering the same link twice.

Hey @Lea_WMDE, sorry, I should be more transparent on the phab ticket. I kept the task in doing for some time as I wanted to work on the issue. Proposed solution caused some problems (If I remember right, system was sending an API request everytime link was hovered). Sadly I couldn't find time for it so I moved it back to "to do", to mark it that I'm not working on it.

Wed, Jun 12, 3:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
pmiazga added a comment to T220212: Wikimedia Technical Conference 2019: Discussion .

Frontend architecture evolution

Wed, Jun 12, 2:54 PM · International-Developer-Events

Tue, Jun 11

pmiazga added a comment to T220114: Updates to user page treatment (apply for IP address and always show toolbar).

reflecting reality,looks like the QA steps are out of sync with AC.

Tue, Jun 11, 5:15 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
pmiazga placed T220114: Updates to user page treatment (apply for IP address and always show toolbar) up for grabs.
Tue, Jun 11, 5:12 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
pmiazga moved T220114: Updates to user page treatment (apply for IP address and always show toolbar) from Needs More Work to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Jun 11, 5:12 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
pmiazga placed T218206: AMC Navigation - make main menu scrollable up for grabs.
Tue, Jun 11, 3:51 PM · Advanced Mobile Contributions, Readers-Web-Backlog
pmiazga moved T218206: AMC Navigation - make main menu scrollable from Needs Analysis to Upcoming on the Readers-Web-Backlog board.
Tue, Jun 11, 3:51 PM · Advanced Mobile Contributions, Readers-Web-Backlog
pmiazga changed the status of T218206: AMC Navigation - make main menu scrollable, a subtask of T214537: [EPIC] AMC Navigation - changes to main menu, from Stalled to Open.
Tue, Jun 11, 3:50 PM · Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4)
pmiazga changed the status of T218206: AMC Navigation - make main menu scrollable from Stalled to Open.
Tue, Jun 11, 3:50 PM · Advanced Mobile Contributions, Readers-Web-Backlog
pmiazga added a comment to T218206: AMC Navigation - make main menu scrollable.

It's ready to work on

Tue, Jun 11, 3:49 PM · Advanced Mobile Contributions, Readers-Web-Backlog
pmiazga added a comment to T222630: Add wikidata item link to AMC overflow menu.

Instead of adding new Hook handler to the Wikibase Client we will use the link injected into the Sidebar. Wikibase client already uses the BaseTemplateToolbox hook to inject Wikidata link. There is no need to implement another hook, to add the same thing just in different option.

Tue, Jun 11, 3:49 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
Restricted Application added a project to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase: Wikidata.
Tue, Jun 11, 3:41 PM · Technical-Debt, Readers-Web-Backlog, MediaWiki-extensions-WikibaseClient, MobileFrontend, Wikidata
pmiazga updated the task description for T222630: Add wikidata item link to AMC overflow menu.
Tue, Jun 11, 3:16 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Advanced Mobile Contributions
pmiazga moved T225365: MF tests seemingly broken in REL1_33 from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Tue, Jun 11, 1:51 PM · Readers-Web-Backlog, MobileFrontend
pmiazga added a project to T225365: MF tests seemingly broken in REL1_33: Readers-Web-Backlog.
Tue, Jun 11, 1:51 PM · Readers-Web-Backlog, MobileFrontend
D3r1ck01 awarded T225220: Don't show intermediate step during log out action on the MinervaNeue skin a Party Time token.
Tue, Jun 11, 12:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-D3r1ck01, good first bug, MinervaNeue
pmiazga removed a project from T225220: Don't show intermediate step during log out action on the MinervaNeue skin: Patch-For-Review.
Tue, Jun 11, 12:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-D3r1ck01, good first bug, MinervaNeue
pmiazga moved T225220: Don't show intermediate step during log out action on the MinervaNeue skin from To Do to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Jun 11, 12:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-D3r1ck01, good first bug, MinervaNeue
pmiazga placed T225220: Don't show intermediate step during log out action on the MinervaNeue skin up for grabs.
Tue, Jun 11, 12:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-D3r1ck01, good first bug, MinervaNeue
pmiazga added a comment to T225220: Don't show intermediate step during log out action on the MinervaNeue skin.

The issue was fixed by @D3r1ck01 - thanks for your contribution.
I reviewed the patch and did QA - moving to Ready for Sign off on kanbanana board.

Tue, Jun 11, 12:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), User-D3r1ck01, good first bug, MinervaNeue

Mon, Jun 10

pmiazga added a comment to T223204: History page filter revisions cannot be expanded on Minerva skin.

@pmiazga good catch. This is an issue on mobile and desktop. Also, if you expand the filter, add some criteria, then click "Show results" the filter closes when the results are shown. Ideally the filter would remain expanded in that case.

Mon, Jun 10, 7:43 PM · Audiences-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MinervaNeue