Page MenuHomePhabricator

pmiazga (Piotr Miazga)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (388 w, 6 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Fri, Mar 15

pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

@Tgr In ExternalStoreDB::initializeTable() we were passing QUERY_IGNORE_DBO_TRX only, which anyway was incorrect - the schema initialization code should pass QUERY_CHANGE_SCHEMA which is also a flag that isWriteQuery() would consider.

Fri, Mar 15, 3:09 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

@Tgr Now, if flag doesn't match one of SQLPlatform::QUERY_CHANGE_NONE, SQLPlatform::QUERY_CHANGE_TRX, SQLPlatform::QUERY_CHANGE_LOCKS. SQLPlatform::QUERY_CHANGE_ROWS , SQLPlatform::QUERY_CHANGE_SCHEMA, SQLPlatform::QUERY_PSEUDO_PERMANENT - we throw exception,

Fri, Mar 15, 1:45 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure

Thu, Mar 14

pmiazga updated subscribers of T358236: Cannot create a new wiki on beta cluster.

@aaron @Ladsgroup could you advise on what to do here? The ExternalStoreDBcalls $dbw->query() with QUERY_IGNORE_DBO_TRX -

Thu, Mar 14, 3:15 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

Recreating a new wiki from scratch fails with:

Thu, Mar 14, 3:02 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure

Tue, Mar 12

pmiazga claimed T359948: Test cross-domain cookie access with Storage Access API.
Tue, Mar 12, 4:04 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth

Mon, Mar 11

pmiazga moved T359105: Add Less.js v3.13 spec to less.php test suite from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Mar 11, 4:26 PM · MediaWiki-Platform-Team, Less.php
pmiazga assigned T359105: Add Less.js v3.13 spec to less.php test suite to Hokwelum.
Mon, Mar 11, 4:26 PM · MediaWiki-Platform-Team, Less.php
pmiazga moved T358784: Newly installed extensions don't pick up localization messages from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Mar 11, 4:25 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
pmiazga assigned T358784: Newly installed extensions don't pick up localization messages to DAlangi_WMF.
Mon, Mar 11, 4:25 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
pmiazga assigned T359409: Need a soft dependency mechanism for QUnitTestModules? to matmarex.
Mon, Mar 11, 4:20 PM · WMDE-TechWish-Sprint-2024-03-13, MediaWiki-ResourceLoader, Browser-Tests, WMDE-TechWish-Sprint-2024-02-28, Page-Previews, MediaWiki-Platform-Team
pmiazga moved T359522: Replace usage of wfGetDB() in ResourceLoader before the 1.42 cut so it can be hard-deprecated from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Mar 11, 4:17 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Technical-Debt
pmiazga updated subscribers of T359116: Split up CentralAuth into smaller extensions.

@Bmueller please check if we could fit that into next fiscal year.

Mon, Mar 11, 4:13 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
pmiazga moved T359116: Split up CentralAuth into smaller extensions from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.
Mon, Mar 11, 4:12 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
pmiazga moved T158365: Session "{session}": Metadata merge failed: {exception} from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.
Mon, Mar 11, 4:10 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager
pmiazga moved T204459: Session "{session}": CentralAuth saved source {saved} != expected source {expected} from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.
Mon, Mar 11, 4:10 PM · MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
pmiazga added a comment to T359522: Replace usage of wfGetDB() in ResourceLoader before the 1.42 cut so it can be hard-deprecated.

Note: [Wikitech-l] MediaWiki 1.42-alpha will be branched as a beta on 9 April 2024

Mon, Mar 11, 3:41 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Technical-Debt

Wed, Mar 6

pmiazga updated the task description for T330641: Switch from LoadBalancer::getConnection() to ICP::getReplicaDatabase/getPrimaryDatabase.
Wed, Mar 6, 5:19 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-General, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Patch-For-Review, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Platform Engineering
pmiazga changed the status of T357653: Replace usage of wfGetDB() in OAuth before the 1.42 cut so it can be hard-deprecated, a subtask of T273239: Stop using, deprecate, and then remove wfGetDB(), from Open to In Progress.
Wed, Mar 6, 3:28 PM · MW-1.42-release, Technical-Debt, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MediaWiki-General
pmiazga changed the status of T357653: Replace usage of wfGetDB() in OAuth before the 1.42 cut so it can be hard-deprecated from Open to In Progress.
Wed, Mar 6, 3:27 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, MediaWiki-extensions-OAuth, Technical-Debt

Tue, Feb 27

pmiazga created T358586: Improve redirection logic when system expects a named user.
Tue, Feb 27, 1:55 PM · Anti-Harassment, Temporary accounts

Mon, Feb 26

pmiazga added a comment to T336504: Transcluding Special:Prefixindex can force the default skin.

@RoySmith - the Thursday issue we're trying to fix is not related to this issue. We encountered a DB replication issues that affect only Beta Cluster wikis - not production one.

Mon, Feb 26, 3:22 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Beta-Cluster-reproducible, GrowthExperiments, Growth-Team, Wikimedia-production-error, Regression
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

@kostajh nope, we didn't do --skip-clusters. On first run it failed with missing migration, we fixed the script and we executed it again - but on the second execution it couldn't go through - so we dropped the test2wiki on beta cluster db (db11).

Mon, Feb 26, 1:59 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358329: beta-update-databases-eqiad job times out / beta databases are having issues.

@hashar yes, I dropped the database as addWiki.php script created a partially created schema (script failed in the middle of run), re-running script caused it to fail again as some tables were already created.

Mon, Feb 26, 11:13 AM · Patch-For-Review, Beta-Cluster-Infrastructure

Fri, Feb 23

pmiazga added a comment to T358329: beta-update-databases-eqiad job times out / beta databases are having issues.

I left the script working for 15 minutes and looks like it's slowly progressing:

Fri, Feb 23, 5:16 PM · Patch-For-Review, Beta-Cluster-Infrastructure
pmiazga added a comment to T358329: beta-update-databases-eqiad job times out / beta databases are having issues.

So I executed the script by hand and it looks like it gets stuck.

Fri, Feb 23, 4:28 PM · Patch-For-Review, Beta-Cluster-Infrastructure
pmiazga added a comment to T358329: beta-update-databases-eqiad job times out / beta databases are having issues.

This job runs the`wmf-beta-update-databases.py` script - I wonder if I can run it manually and see the output. I compared the last sucessfull run and first failed runs:

Fri, Feb 23, 4:24 PM · Patch-For-Review, Beta-Cluster-Infrastructure
pmiazga added a comment to T358329: beta-update-databases-eqiad job times out / beta databases are having issues.

T358236 could cause this issue as the addWiki.php script failed in the middle of the process and I had to drop the test2wiki multiple times manually (as the script was failing due to multiple reasons, I fixed those one by one). Those things happened around similar time.

Fri, Feb 23, 3:52 PM · Patch-For-Review, Beta-Cluster-Infrastructure

Thu, Feb 22

pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

After all fixes now script still fails, but this time on something new - which I think may be a result of running and dropping addWiki.php script multiple times.

Thu, Feb 22, 6:18 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T204787: Session Warning: "User ID mismatch, {uid_a} !== {uid_b}".

I just checked logs, still happening - 177 instances in last 6 hours.

Thu, Feb 22, 5:55 PM · MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
pmiazga moved T358236: Cannot create a new wiki on beta cluster from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Thu, Feb 22, 5:52 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

@Urbanecm_WMF thanks for the point - that's helpful. I checked the addWiki script for all remaining SQL files and looks like they are on the right place. I'm going to submit another PR to fix the Linter SQL file location and then hopefully it's gonna work.

Thu, Feb 22, 5:50 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

@bd808 in Linter script was moved to sql/mysql folder to match how we have it in other extensions

Thu, Feb 22, 5:49 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

For tracking purposes - the Linter extension had the SQL files moved recently (see https://phabricator.wikimedia.org/T353922, change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/985070).

Thu, Feb 22, 5:43 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

After updating the Add Wiki script - I was able to run the script - but it kept failing due to partially created DB. Previous run already created some tables so I had to manually drop the database.

Thu, Feb 22, 5:34 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

@Physikerwelt thanks for joining the conversation. I quickly created the ticket so I don't forget and started investigating this issue. We found out that those changes were intentional and we should update the add wiki script.

Thu, Feb 22, 4:13 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga changed the status of T358236: Cannot create a new wiki on beta cluster from Open to In Progress.
Thu, Feb 22, 4:08 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga updated subscribers of T358236: Cannot create a new wiki on beta cluster.

Another suggestion from @matmarex is to update the AddWiki script - after reading T349442 looks like those SQL files were removed intentionally.

Thu, Feb 22, 4:07 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T358236: Cannot create a new wiki on beta cluster.

As a quick solution, I think we could bring the SQL files that were removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/975432

Thu, Feb 22, 3:57 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T355281: Set up some beta cluster wikis with different registrable domain.

Cannot move forward due to Mathoid/BetaCluster problem - https://phabricator.wikimedia.org/T358236 - the AddWiki script fails with missing SQL files for Mathoid extension. I'm looking into that.

Thu, Feb 22, 3:53 PM · MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga created T358236: Cannot create a new wiki on beta cluster.
Thu, Feb 22, 3:52 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, MediaWiki-Platform-Team, Beta-Cluster-Infrastructure

Wed, Feb 21

pmiazga updated subscribers of T355281: Set up some beta cluster wikis with different registrable domain.

I spoke with @Urbanecm_WMF about creating new wikis and I learned that we want to keep the beta cluster wikis similar to production wikis. In other words, if we want to create a wiki then it should be something that is not available on the beta cluster yet but has a production equivalent. It is not desirable to have beta-wikis that do not have a production equivalent.

Wed, Feb 21, 6:02 PM · MediaWiki-Platform-Team, Beta-Cluster-Infrastructure

Mon, Feb 19

pmiazga updated subscribers of T326816: Update features for IP Masking.

MediaWiki Core Special Pages provide two helper methods requireLogin and requireNamedUser. Those methods check user type and redirect to UserLogin in case we have a user with the wrong type.

Mon, Feb 19, 12:41 PM · Patch-For-Review, Anti-Harassment, Temporary accounts

Feb 13 2024

pmiazga updated subscribers of T355281: Set up some beta cluster wikis with different registrable domain.

I would stick to beta.wmcloud.org as it nicely sticks follows {LANG}.{PROJECT}.org schema. Now I wonder, do we need an additional domain too?

Feb 13 2024, 3:24 PM · MediaWiki-Platform-Team, Beta-Cluster-Infrastructure

Feb 12 2024

pmiazga moved T343963: CentralAuthUser::getInstanceByName (and similar) should normalize the user name from Blocked/waiting to Current Sprint on the MediaWiki-Platform-Team board.
Feb 12 2024, 4:11 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
pmiazga moved T355916: One-click email unsubscribe service in MediaWiki core from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Feb 12 2024, 3:55 PM · MediaWiki-Platform-Team, MediaWiki-Email
pmiazga assigned T350947: Performance review of Extension:WikimediaCampaignEvents to Krinkle.
Feb 12 2024, 3:53 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Campaign-Tools, WikimediaCampaignEvents, MediaWiki-Platform-Team
pmiazga added a comment to T355378: Prepare OAuth extension for IP Masking.

Looks like we already have a pretty similar error message

Feb 12 2024, 3:25 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, Temporary accounts, MediaWiki-extensions-OAuth
pmiazga updated the task description for T355281: Set up some beta cluster wikis with different registrable domain.
Feb 12 2024, 3:18 PM · MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga added a comment to T355281: Set up some beta cluster wikis with different registrable domain.

I'm going to start adding items that needs to be done. @taavi you mentioned that beta.wmcloud.org is already designated for this. But do you meant that we can create a wiki with beta.wmcloud.org URL, or are we talking about creating a subdomain under beta.wmcloud.org ?

Feb 12 2024, 3:16 PM · MediaWiki-Platform-Team, Beta-Cluster-Infrastructure
pmiazga moved T350947: Performance review of Extension:WikimediaCampaignEvents from Backlog: non-prioritized to Current Sprint on the MediaWiki-Platform-Team board.
Feb 12 2024, 12:39 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Campaign-Tools, WikimediaCampaignEvents, MediaWiki-Platform-Team

Feb 8 2024

pmiazga closed T351831: Optimize how many times `SkinTemplate::getPortletsTemplateData` is called as Resolved.
Feb 8 2024, 5:11 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Core-Skin-Architecture (Menus 2.0), Wikimedia-Performance-recommendation
pmiazga closed T351831: Optimize how many times `SkinTemplate::getPortletsTemplateData` is called, a subtask of T331360: Allow skins to optimize the data the template receives., as Resolved.
Feb 8 2024, 5:11 PM · Web-Team-Backlog (Needs Prioritization (Tech)), MediaWiki-Core-Skin-Architecture
pmiazga closed T351831: Optimize how many times `SkinTemplate::getPortletsTemplateData` is called, a subtask of T350593: Analyze flamegraphs and identify which parts of MediaWiki execution could be improved, as Resolved.
Feb 8 2024, 5:11 PM · Wikimedia-Performance-recommendation, MediaWiki-Platform-Team
pmiazga updated subscribers of T355378: Prepare OAuth extension for IP Masking.

After checking https://www.mediawiki.org/wiki/User_account_types - Temporary Users feature set is more aligned with Anon user, not registered. The only difference between IP and Temp is that Temp can receive notifications -> which if I'm right was already happening for edits coming from IP - therefore it's not anything new.

Feb 8 2024, 5:11 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, Temporary accounts, MediaWiki-extensions-OAuth

Feb 5 2024

pmiazga moved T355280: Try to connect to central session before temp user creation from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Feb 5 2024, 4:12 PM · MediaWiki-Platform-Team, Temporary accounts, MediaWiki-extensions-CentralAuth
pmiazga moved T355286: [Epic] Globally blocking a temporary account should prevent further account creations from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Feb 5 2024, 4:11 PM · Stewards-and-global-tools, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Temporary accounts
pmiazga moved T356008: mw.config 'wgGlobalGroups' should only include groups that are active on the current wiki from Inbox, needs triage to Blocked/waiting on the MediaWiki-Platform-Team board.
Feb 5 2024, 4:10 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
pmiazga moved T356249: Consider adding $creator to postAuthentication hook from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Feb 5 2024, 4:09 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Growth-Team (Sprint 9 (Growth Team)), MediaWiki-Platform-Team (Radar), MediaWiki-Core-AuthManager
pmiazga moved T356348: Allow subscribing to the loading of a ResourceLoader module from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Feb 5 2024, 4:07 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
pmiazga moved T356614: Do not do central login after security reauthentication from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Feb 5 2024, 4:05 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, MediaWiki-Core-AuthManager
pmiazga closed T330332: PHP Warning: Invalid argument supplied for foreach() as Resolved.
Feb 5 2024, 3:49 PM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error

Jan 29 2024

pmiazga added a comment to T355916: One-click email unsubscribe service in MediaWiki core.

Looks like this feature is already partially implemented. If you check the UserMailer class we already send the List-Unsubscribe header:

Jan 29 2024, 4:10 PM · MediaWiki-Platform-Team, MediaWiki-Email
pmiazga updated subscribers of T355281: Set up some beta cluster wikis with different registrable domain.

@taavi @Tgr do we have any domains that we could use or do we need to purchase those first?

Jan 29 2024, 3:41 PM · MediaWiki-Platform-Team, Beta-Cluster-Infrastructure

Jan 26 2024

pmiazga added a comment to T355378: Prepare OAuth extension for IP Masking.

The only thing I would consider at this stage is to see if we want to show identical error messages to temporary users and anons.

Jan 26 2024, 4:58 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, Temporary accounts, MediaWiki-extensions-OAuth

Jan 24 2024

pmiazga updated subscribers of T355378: Prepare OAuth extension for IP Masking.

Existing OAuth logic already expects users to at least have email defined. Some parts of the system go a little bit further and require a confirmed email. Temporary accounts cannot log in as those do not have passwords - further more - they cannot update their email which already prevents them from using OAuth.

Jan 24 2024, 3:29 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, Temporary accounts, MediaWiki-extensions-OAuth
pmiazga added a comment to T287234: Move Skin::normalizeKey() to SkinFactory.

I tried to make a stab at this work some time ago (patches that Krinkle mentioned ) but then I abandoned the idea. Now I want to get this thing done and noticed you made a ticket for it and pushed a PR. Nice. Thanks.

Jan 24 2024, 12:54 PM · Patch-For-Review, Dependency injection, User-DannyS712, MediaWiki-Core-Skin-Architecture

Jan 23 2024

pmiazga added a comment to T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking.

In OATHAuth, the current permission configuration (in extension.json) adds oathauth-enable to user, that should probably be named.

I can find nothing else with a quick grep. disableOATHAuthForUser.php could maybe complain if the user parameter is a temp user, but then it's pretty unlikely that anyone would invoke it with a temp user.

Jan 23 2024, 1:08 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team, MediaWiki-extensions-OATHAuth, Anti-Harassment, Temporary accounts

Jan 17 2024

pmiazga added a comment to T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking.

In the OATHAuth extension we are required to change two places:

Jan 17 2024, 6:13 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team, MediaWiki-extensions-OATHAuth, Anti-Harassment, Temporary accounts
pmiazga added a comment to T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking.

The WebAuthn extension requires one change to fully support IPMasking. The only place that required investigation is checkPermissions method - https://gerrit.wikimedia.org/g/mediawiki/extensions/WebAuthn/+/122deaa8a99b868c08f9fa1e5e5d4ab0a4387bf3/src/Api/WebAuthn.php#112

Jan 17 2024, 1:26 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team, MediaWiki-extensions-OATHAuth, Anti-Harassment, Temporary accounts

Jan 15 2024

pmiazga moved T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Jan 15 2024, 3:55 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team, MediaWiki-extensions-OATHAuth, Anti-Harassment, Temporary accounts
pmiazga changed the status of T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking, a subtask of T326816: Update features for IP Masking, from Open to In Progress.
Jan 15 2024, 3:55 PM · Patch-For-Review, Anti-Harassment, Temporary accounts
pmiazga changed the status of T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking from Open to In Progress.
Jan 15 2024, 3:55 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team, MediaWiki-extensions-OATHAuth, Anti-Harassment, Temporary accounts
pmiazga claimed T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking.
Jan 15 2024, 3:55 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team, MediaWiki-extensions-OATHAuth, Anti-Harassment, Temporary accounts

Jan 8 2024

pmiazga changed the status of T353696: global accounts link should be singular from Open to In Progress.
Jan 8 2024, 4:26 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, I18n, MediaWiki-extensions-CentralAuth

Jan 5 2024

Osps7 awarded T346211: Deprecate WebRequest::getRequestId() a Like token.
Jan 5 2024, 10:21 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MW-1.42-release, good first task, MediaWiki-Platform-Team, MediaWiki-libs-HTTP

Dec 15 2023

pmiazga added a comment to T353529: Add namespace to ObjectCache (BagOStuff and friends) library.

@Krinkle do you have any thoughts on this? Do you know where the Wikimedia/LightweightObjectStore comes from?

Dec 15 2023, 2:52 PM · MediaWiki-libs-BagOStuff, MediaWiki-Platform-Team
pmiazga created T353529: Add namespace to ObjectCache (BagOStuff and friends) library.
Dec 15 2023, 2:49 PM · MediaWiki-libs-BagOStuff, MediaWiki-Platform-Team
pmiazga closed T350861: MW returns uncacheable responses for en.wikipedia.org when specific XFF values are sent as Resolved.
Dec 15 2023, 2:06 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MediaWiki-General, MediaWiki-Platform-Team, Vuln-DoS, SecTeam-Processed, Security, serviceops, Traffic
pmiazga moved T242031: Allow multiple different 2FA devices from Blocked/waiting to Current Sprint on the MediaWiki-Platform-Team board.
Dec 15 2023, 2:04 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Platform-Team, Patch-For-Review, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Wikimania-Hackathon-2023, Community-Wishlist-Survey-2023, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-OATHAuth

Dec 13 2023

pmiazga removed a project from T353367: Deprecate IP handling in `User::mailPasswordInternal` hook: MediaWiki CodeJam Dec 2023.
Dec 13 2023, 7:25 PM · Patch-For-Review, MediaWiki-User-login-and-signup, MediaWiki-Core-Hooks
pmiazga updated subscribers of T353367: Deprecate IP handling in `User::mailPasswordInternal` hook.

@daniel @Tgr @Krinkle - do you have any thoughts on this?

Dec 13 2023, 7:24 PM · Patch-For-Review, MediaWiki-User-login-and-signup, MediaWiki-Core-Hooks
pmiazga created T353367: Deprecate IP handling in `User::mailPasswordInternal` hook.
Dec 13 2023, 7:24 PM · Patch-For-Review, MediaWiki-User-login-and-signup, MediaWiki-Core-Hooks
pmiazga edited projects for T353339: Add support for dynamic placeholder replacement in logger., added: MediaWiki-Platform-Team, MediaWiki-Debug-Logger; removed MediaWiki CodeJam Dec 2023, MediaWiki-General.
Dec 13 2023, 4:21 PM · Patch-For-Review, MediaWiki-Debug-Logger, MediaWiki-Platform-Team
pmiazga created T353339: Add support for dynamic placeholder replacement in logger..
Dec 13 2023, 4:14 PM · Patch-For-Review, MediaWiki-Debug-Logger, MediaWiki-Platform-Team

Dec 12 2023

Krinkle awarded T353245: Methods within User class that deprecate on `::getRequest()` should expect WebRequest as argument a Love token.
Dec 12 2023, 6:21 PM · Patch-For-Review, MediaWiki CodeJam Dec 2023, MediaWiki-General
pmiazga moved T350094: Enable verbose logging without installing the WikimediaDebug extension from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:15 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Platform-Team, MediaWiki-Debug-Logger, observability
pmiazga moved T352548: The login intersite mechanism is broken from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:11 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Regression, MediaWiki-User-login-and-signup
pmiazga moved T352438: Unable to log in to SUL account from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:10 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
pmiazga moved T37063: Provide a way to "sticky" enable ResourceLoader's debug mode from Radar to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:10 PM · MediaWiki-Platform-Team, MediaWiki CodeJam Dec 2023, MediaWiki-ResourceLoader, JavaScript
pmiazga moved T37063: Provide a way to "sticky" enable ResourceLoader's debug mode from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:09 PM · MediaWiki-Platform-Team, MediaWiki CodeJam Dec 2023, MediaWiki-ResourceLoader, JavaScript
pmiazga moved T352798: Desktop view link on private wiki login required pages is broken from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:07 PM · Web-Team-Backlog, patch-welcome, MediaWiki-Platform-Team (Radar), MobileFrontend
pmiazga moved T352913: session_write_close failure in PHPSessionHandlerTest under php8.3 from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:06 PM · MediaWiki-Platform-Team, PHP 8.3 support, MediaWiki-Core-AuthManager
pmiazga moved T298334: Validations for gadget definitions from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:05 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets
pmiazga moved T326386: Use of "self" in callables is deprecated in php8.2 from liuggio/statsd-php-client package from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:04 PM · MediaWiki-Platform-Team, MediaWiki-libs-Stats, PHP 8.2 support, Upstream, MediaWiki-Vendor
pmiazga moved T353117: CSSJanus should support rotate() function from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.
Dec 12 2023, 4:00 PM · MediaWiki-Platform-Team, CSSJanus
pmiazga moved T353180: Flaky test WANObjectCacheTest::testPreemptiveRefresh (at least under php8.2 and php8.3) from Inbox, needs triage to Within 2 Qs on the MediaWiki-Platform-Team board.
Dec 12 2023, 3:52 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), PHP 8.3 support, PHP 8.2 support, MediaWiki-Platform-Team, ci-test-error, MediaWiki-libs-BagOStuff
pmiazga moved T353198: Improve error charts on authentication-metrics dashboard from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Dec 12 2023, 3:51 PM · MediaWiki-Core-AuthManager, MediaWiki-extensions-CentralAuth, MediaWiki-Platform-Team
pmiazga moved T353247: Fix tests misusing $wgCommandLineMode to delay DeferredUpdates execution from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Dec 12 2023, 3:50 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MediaWiki-Platform-Team, MediaWiki-extensions-General, MediaWiki-General
pmiazga moved T353249: De-duplicate Less_Tree_Color::fromKeyword method from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Dec 12 2023, 3:50 PM · Technical-Debt, MediaWiki-Platform-Team, Less.php
pmiazga moved T353262: Remove writing to $wgCommandLineMode from RunSingleJob.php from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Dec 12 2023, 3:49 PM · WMF-General-or-Unknown, MediaWiki-Platform-Team