pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (123 w, 6 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Sat, Feb 9

pmiazga moved T214715: [Spike] How should menus work in Minerva? from Doing to To Do on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Sat, Feb 9, 1:08 AM · Readers-Web-Backlog, Advanced Mobile Contributions

Fri, Feb 8

pmiazga renamed T215675: [EPIC] Provide mechanism to allow dynamically tag log entries from Provide mechanism to allow dynamicly tagging log entries to Provide mechanism to allow dynamically tag log entries.
Fri, Feb 8, 11:07 PM · Epic, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog, MediaWiki-Logging
pmiazga added a comment to T215477: Tag Thanks actions with AMC tag.

T215675 is a blocker, we need to decide on how to dynamically tag log entries before we can do this task.

Fri, Feb 8, 11:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team
pmiazga created T215675: [EPIC] Provide mechanism to allow dynamically tag log entries.
Fri, Feb 8, 11:05 PM · Epic, MobileFrontend, Advanced Mobile Contributions, Readers-Web-Backlog, MediaWiki-Logging
pmiazga updated the task description for T211197: Build AMC opt-in toggle.
Fri, Feb 8, 10:36 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Thu, Feb 7

pmiazga added a comment to T211197: Build AMC opt-in toggle.

FeaturesManager::isFeatureAvailableInContext will go away, there were no changes to the isFeatureAvailableInContext, only deprecation. It's deprecated because Minerva is still using it, after we're done with Minerva changes we should be able to remove isFeatureAvailableInContext method.

Thu, Feb 7, 8:55 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga reassigned T210652: Handoff Proton service to Reading Infrastructure from pmiazga to phuedx.
Thu, Feb 7, 8:50 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
pmiazga moved T210652: Handoff Proton service to Reading Infrastructure from Blocked on Others to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Feb 7, 8:50 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
pmiazga awarded T213367: Add MediaWiki-Vagrant role for Proton a Orange Medal token.
Thu, Feb 7, 4:53 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-Vagrant, Proton
pmiazga added a comment to T214180: Add informational links to AMC opt-in toggle.

@nray - yes, that is correct, and for now lets keep it that way. I know that there are some ideas to remove the mobile domain (I have no idea if this is going to happen)
@alexhollender - we can add some param to the the URL, like https://www.mediawiki.org/wiki/Special:MyLanguage/Talk:Reading/Web/Advanced_mobile_contributions?amc_source=optin (I wouldn't worry about caching as this is served to logged-in users only). Then with we would have to query hive to get the number of page views with that GET amc_source param. Difficulty - easy to medium. /cc @Tbayer

Thu, Feb 7, 1:56 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated subscribers of T214180: Add informational links to AMC opt-in toggle.
Thu, Feb 7, 1:54 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated subscribers of T215477: Tag Thanks actions with AMC tag.

@ovasileva @Tbayer clarification question so we are all on the same page. When should we tag "thanks" action with advanced mobile edit? I see two possibilities - when user who performs the action has amc mode enabled (when performing action), or do we want to tag thanks action when the revision thank is sent for was made with amc mode enabled?.

Thu, Feb 7, 12:12 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team
pmiazga added a comment to T212959: Create AMC edit tag.

As Tbayer mentioned, I created separate task to tackle the tagging actions done via Thanks extension - T215477. I did a quick check and it should be possible but definitely it doesn't look trivial.

Thu, Feb 7, 12:09 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga added a parent task for T215477: Tag Thanks actions with AMC tag: T210660: [EPIC] AMC Metrics .
Thu, Feb 7, 12:06 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team
pmiazga added a subtask for T210660: [EPIC] AMC Metrics : T215477: Tag Thanks actions with AMC tag.
Thu, Feb 7, 12:06 AM · Chinese-Sites, Epic, Advanced Mobile Contributions, Readers-Web-Backlog
pmiazga created T215477: Tag Thanks actions with AMC tag.
Thu, Feb 7, 12:04 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team

Wed, Feb 6

pmiazga moved T214715: [Spike] How should menus work in Minerva? from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Feb 6, 9:15 PM · Readers-Web-Backlog, Advanced Mobile Contributions
pmiazga edited projects for T214715: [Spike] How should menus work in Minerva?, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog.
Wed, Feb 6, 9:15 PM · Readers-Web-Backlog, Advanced Mobile Contributions
pmiazga added a project to T214715: [Spike] How should menus work in Minerva?: Readers-Web-Backlog.
Wed, Feb 6, 9:14 PM · Readers-Web-Backlog, Advanced Mobile Contributions
pmiazga added a comment to T213371: Document and possibly fine-tune how Proton interacts with Varnish.

@Tgr I assume you're still waiting for answers from @ema? Is there anything I can help you with?

Wed, Feb 6, 9:03 PM · Readers-Web-Backlog (Tracking), Services (watching), serviceops, Traffic, Reading-Infrastructure-Team-Backlog, Proton, Operations
pmiazga added a comment to T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.

I'll ping @mobrovac once again, as he decided to use internal domain names (previously we were using the public domains).

Wed, Feb 6, 9:01 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga added a comment to T213366: [2 hrs] Decide on handling system updates for Proton.

@Tgr so far we were bumping Puppeteer version and usually everything works. There was one problem with headers (chromium wasn't sending the headers we're asking for) but most probably that was the puppeteer lib issue in given version, not the conclict between two different versions. After we bumped to the newer release problem went away. We started chromium-render development from Puppeteer 0.11.0 (https://github.com/wikimedia/mediawiki-services-chromium-render/commit/d02e5a57ec1e986f0992edaf6b8c8169d13b5203#diff-b9cfc7f2cdf78a7f4b91a753d10865a2) and so far update process didn't cause any troubles (currently we're on 1.9.0)

Wed, Feb 6, 8:59 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
pmiazga added a comment to T214180: Add informational links to AMC opt-in toggle.

Quick question - do we want to track clicks on those links (how many people visit Learn More and Send feedback) ?

Wed, Feb 6, 6:13 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga added a project to T204606: Some requests time out after 60 seconds in MobileFrontend transforms. What to do?: Performance-Team.
Wed, Feb 6, 2:48 PM · Performance-Team, Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog
pmiazga added a comment to T204606: Some requests time out after 60 seconds in MobileFrontend transforms. What to do?.

I'd love to find out, what takes the most of the time during web request. The error message is not that processing that single part of code took more that 60 seconds. Timer starts when server receives the request, and when it runs out of time it just stops the execution and prints the current stacktrace, The MobileFrontend can be definitely an offender here (parsing huge DOM structures) but definitely there are other parts of code that just take time to process. For example there can be something that took over 50 seconds of the request time before MobileFormatter came into the play. If that happens most of the time, I wouldn't worry about the MobileFrontend transforms. But if the MobileFrontend transforms takes most of the request time - then it's definitely something we should look at.

Wed, Feb 6, 2:47 PM · Performance-Team, Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog
pmiazga placed T214658: Separate Lazy loading code from Skin.js up for grabs.
Wed, Feb 6, 1:49 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga moved T214658: Separate Lazy loading code from Skin.js from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Feb 6, 1:49 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga updated the task description for T214658: Separate Lazy loading code from Skin.js.
Wed, Feb 6, 1:48 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga added a comment to T214658: Separate Lazy loading code from Skin.js.

Last acceptance criteria says that we will remove usage of the jQuery lib, but the jQuery is still required for Deferreds and declaring types for function params, and attaching eventListeners.
Do we want to drop that last acceptance criteria?

Wed, Feb 6, 1:48 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga added a comment to T214658: Separate Lazy loading code from Skin.js.

The acceptance criteria says We will add test coverage for the Skin class but Skin.js has no coverage.

Wed, Feb 6, 1:41 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga moved T214658: Separate Lazy loading code from Skin.js from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Feb 6, 1:16 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga removed a project from T214658: Separate Lazy loading code from Skin.js: Patch-For-Review.
Wed, Feb 6, 1:15 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)

Tue, Feb 5

pmiazga claimed T214658: Separate Lazy loading code from Skin.js.
Tue, Feb 5, 6:08 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
pmiazga added a project to T215028: Unexpected extracts greek API response: Readers-Web-Backlog (Tracking).
Tue, Feb 5, 3:10 PM · Readers-Web-Backlog (Tracking), TextExtracts, MediaWiki-API
pmiazga added a project to T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL: Readers-Web-Backlog (Tracking).
Tue, Feb 5, 3:09 PM · Readers-Web-Backlog (Tracking), Traffic, MobileFrontend, Operations
pmiazga added a project to T214971: Popups: Raise test coverage for the new reference preview type: Readers-Web-Backlog (Tracking).
Tue, Feb 5, 2:52 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Test-Coverage, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Page-Previews, Reference Previews
pmiazga added a project to T212371: Separate page issue parsing from pageIssues.js: Readers-Web-Backlog.
Tue, Feb 5, 2:50 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog, Technical-Debt, MinervaNeue, Page-Issue-Warnings
pmiazga added a project to T214970: Popups: Code and documentation refactorings and clean-ups: Readers-Web-Backlog (Tracking).
Tue, Feb 5, 2:50 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Technical-Debt, TCB-Team, Page-Previews, Reference Previews
pmiazga placed T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead up for grabs.
Tue, Feb 5, 3:15 AM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing QA, Patch-For-Review, Editing-team, MobileFrontend
pmiazga added a comment to T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead.

Confirmed, and I see two issues here:
A) Captcha is filled in, but not visible in Wikitext editor, in visual editor it works properly.

Tue, Feb 5, 3:13 AM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing QA, Patch-For-Review, Editing-team, MobileFrontend

Mon, Feb 4

pmiazga claimed T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead.
Mon, Feb 4, 6:12 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing QA, Patch-For-Review, Editing-team, MobileFrontend
pmiazga moved T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 4, 6:12 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing QA, Patch-For-Review, Editing-team, MobileFrontend
pmiazga added a project to T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).
Mon, Feb 4, 6:06 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing QA, Patch-For-Review, Editing-team, MobileFrontend

Fri, Feb 1

pmiazga moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Feb 1, 6:53 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
pmiazga updated the task description for T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.
Fri, Feb 1, 6:53 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Thu, Jan 31

pmiazga placed T214180: Add informational links to AMC opt-in toggle up for grabs.
Thu, Jan 31, 9:39 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga moved T214180: Add informational links to AMC opt-in toggle from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Jan 31, 9:39 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga removed a project from T214180: Add informational links to AMC opt-in toggle: Patch-For-Review.
Thu, Jan 31, 9:38 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga added a comment to T213371: Document and possibly fine-tune how Proton interacts with Varnish.

@Jhernandez I'll update documentation once all Tgr questions are answered.

Thu, Jan 31, 7:46 PM · Readers-Web-Backlog (Tracking), Services (watching), serviceops, Traffic, Reading-Infrastructure-Team-Backlog, Proton, Operations
pmiazga updated the task description for T215037: Fix Piotr (and other's) npm install.
Thu, Jan 31, 7:33 PM · Readers-Web-Backlog, MobileFrontend
pmiazga renamed T215037: Fix Piotr (and other's) npm install from Upgrade deprectated npm modules to Fix broken npm modules.
Thu, Jan 31, 6:56 PM · Readers-Web-Backlog, MobileFrontend
pmiazga created T215037: Fix Piotr (and other's) npm install.
Thu, Jan 31, 6:45 PM · Readers-Web-Backlog, MobileFrontend

Fri, Jan 25

pmiazga closed T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class as Resolved.
Fri, Jan 25, 8:21 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
pmiazga closed T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Fri, Jan 25, 8:20 PM · Readers-Web-Backlog, Epic, MobileFrontend
pmiazga added a comment to T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class.

getPluralLicenseInfo() is fully covered. Resolving task.

Fri, Jan 25, 8:20 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
pmiazga claimed T209765: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class.
Fri, Jan 25, 8:16 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
pmiazga claimed T212802: [Spike] How do we extract beta / stable mode code from MobileContext to new file?.
Fri, Jan 25, 6:34 PM · Readers-Web-Backlog, Technical-Debt, Advanced Mobile Contributions
pmiazga claimed T214715: [Spike] How should menus work in Minerva?.
Fri, Jan 25, 6:28 PM · Readers-Web-Backlog, Advanced Mobile Contributions
pmiazga claimed T214180: Add informational links to AMC opt-in toggle.
Fri, Jan 25, 5:24 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga closed T212666: PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests as Resolved.
Fri, Jan 25, 4:47 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
pmiazga closed T212666: PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Fri, Jan 25, 4:47 PM · Readers-Web-Backlog, Epic, MobileFrontend
pmiazga added a comment to T212666: PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests.

Looks good.

Fri, Jan 25, 4:47 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend

Wed, Jan 23

pmiazga moved T211197: Build AMC opt-in toggle from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 6:46 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga moved T211197: Build AMC opt-in toggle from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 6:33 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga moved T211197: Build AMC opt-in toggle from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 6:25 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated subscribers of T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.

@Tgr - Public Wikimedia sites and Beta certs are set for public domains. Proton render used to access Wikipedia servers using internal network names (as it was inside internal network). The internal servers use the CA generated by Puppet.
Switching between HTTP/HTTPS modes is available via config (the config file has the URL template used to build the article URL).

Wed, Jan 23, 5:31 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga moved T213366: [2 hrs] Decide on handling system updates for Proton from Ready for Signoff to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 5:22 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
pmiazga moved T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings from Ready for Signoff to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 5:22 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Wed, Jan 23, 4:42 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Reading-Infrastructure-Team-Backlog, Proton
pmiazga added a comment to T213371: Document and possibly fine-tune how Proton interacts with Varnish.

What IMO we need to know to understand how the service will deal with spikes:

There is a queue mechanism. Each proton instance can only render X of jobs at one time, and Y jobs can be queued. If the spike is higher than X+Y every new job will be rejected with HTTP_503 error including the Retry-After header. Then the pool manager will de-pool that instance (allow it to peacefully render all jobs).

Wed, Jan 23, 3:57 PM · Readers-Web-Backlog (Tracking), Services (watching), serviceops, Traffic, Reading-Infrastructure-Team-Backlog, Proton, Operations
pmiazga assigned T213366: [2 hrs] Decide on handling system updates for Proton to Jhernandez.
Wed, Jan 23, 3:20 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
pmiazga moved T213366: [2 hrs] Decide on handling system updates for Proton from To Do to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 3:20 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
pmiazga added a comment to T213366: [2 hrs] Decide on handling system updates for Proton.

Done : documented how to perform updates and wrote down why we do it this way: https://wikitech.wikimedia.org/wiki/Proton#Updating_Puppeteer_&_Chromium

Wed, Jan 23, 3:20 PM · Reading-Infrastructure-Team-Backlog (Kanban), Security-Team, Operations, Proton
pmiazga reassigned T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings from pmiazga to Jhernandez.
Wed, Jan 23, 2:19 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga moved T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 23, 2:19 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga added a comment to T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.

Done: https://wikitech.wikimedia.org/wiki/Proton#Puppeteer_configuration

Wed, Jan 23, 2:17 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga added a comment to T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.

We cannot remove the --ignoreHTTPSErrors flag. It was added to the config https://github.com/wikimedia/mediawiki-services-chromium-render-deploy/commit/17fc7bb4cda2e1b408d6289c27685624d35e8714 because:

We use a self-signed certificate for our domains (since the CA is our Puppet). However, that results in Chromium HTTPS errors. Given that Proton cannot communicate with the outside world, it is safe to use the ignoreHTTPSErrors configuration flag since requesting HTML from our appservers is all the service does.

Wed, Jan 23, 1:57 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga updated the task description for T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.
Wed, Jan 23, 1:55 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga updated the task description for T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.
Wed, Jan 23, 1:55 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton

Tue, Jan 22

pmiazga updated the task description for T214180: Add informational links to AMC opt-in toggle.
Tue, Jan 22, 5:38 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga added a comment to T212800: AMC feature flag can be superseded by a development query parameter.

If I understand this task right (the AMC mode has to be disabled on production for now - not visible on Special:MobileOptions page), this development query parameter has to supersede the MFAdvancedMobileContributions config flag (enable the AMC mode and enable AMC for currently logged-in user). It looks bit scary, as the beta mode is available on production, and the mobileaction only temporarily enables the beta mode for the current user.

Tue, Jan 22, 5:05 PM · Readers-Web-Backlog, Advanced Mobile Contributions
pmiazga placed T211197: Build AMC opt-in toggle up for grabs.
Tue, Jan 22, 4:31 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga moved T211197: Build AMC opt-in toggle from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 22, 4:31 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated the task description for T212959: Create AMC edit tag.
Tue, Jan 22, 3:50 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga added a comment to T210554: Deploy page issues to enwiki and all remaining projects.

Deployed to English Wikipedia.

Tue, Jan 22, 1:55 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Wikimedia-Site-requests, Page-Issue-Warnings
pmiazga moved T210554: Deploy page issues to enwiki and all remaining projects from To Do to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 22, 1:54 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Wikimedia-Site-requests, Page-Issue-Warnings
pmiazga added a comment to T212959: Create AMC edit tag.

@ovasileva FYI: current implementation of AMC revision tag is identical to the mobile web edit tag. If the AMC tag doesn't appear on some moderation actions - the mobile web edit tag will not be present.

Tue, Jan 22, 11:14 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 18 2019

pmiazga edited projects for T213938: When watching specific kinds of history on mobile devices, it returns a fatal error. , added: Multi-Content-Revisions; removed Advanced Mobile Contributions.
Jan 18 2019, 9:40 PM · Wikimedia-production-error, MediaWiki-History-and-Diffs
pmiazga updated subscribers of T213938: When watching specific kinds of history on mobile devices, it returns a fatal error. .

@daniel @Tgr - could check whats causing this issue?

Jan 18 2019, 9:38 PM · Wikimedia-production-error, MediaWiki-History-and-Diffs
pmiazga added a project to T213938: When watching specific kinds of history on mobile devices, it returns a fatal error. : Advanced Mobile Contributions.
Jan 18 2019, 9:36 PM · Wikimedia-production-error, MediaWiki-History-and-Diffs

Jan 17 2019

pmiazga moved T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 17 2019, 8:04 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
pmiazga moved T212959: Create AMC edit tag from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 17 2019, 8:01 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga added a comment to T213362: Limit what URLs Proton can access.

As an interim solution - which most probably will provide enough of security - let's provide:

  • a config variable, where we can store a regex to whitelist URL [or possible an array of regexes]
  • if the config option is set, use the Page Request Interception, if it doesn't match the regex abort the request?
Jan 17 2019, 6:13 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Security, Core Platform Team Backlog (Watching / External), Services (watching), Proton
pmiazga added a comment to T212959: Create AMC edit tag.

@ovasileva @Tbayer - just out of curiosity - both advanced mobile edit and mobile web edit are redundant. Do we want to keep both (keeping both is much easier, showing only one - mobile web edit or advanced mobile edit is bit more complex). I'm just thinking aloud. The current implementation will add advanced mobile edit tag everytime AMC mode is on. That edit will be marked both with advanced mobiled edit and mobile web edit. Is it ok?

Jan 17 2019, 11:54 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated the task description for T212959: Create AMC edit tag.
Jan 17 2019, 11:46 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated the task description for T212959: Create AMC edit tag.
Jan 17 2019, 11:45 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated the task description for T212959: Create AMC edit tag.
Jan 17 2019, 11:44 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
pmiazga updated the task description for T212959: Create AMC edit tag.
Jan 17 2019, 11:34 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 15 2019

pmiazga placed T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions up for grabs.
Jan 15 2019, 6:02 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
pmiazga updated the task description for T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.
Jan 15 2019, 5:42 PM · Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton