Thu, Dec 13
@Jdlrobson this also might be related to the browser, did you call GC after doing tests? what is your chrome/os version? Sure, I'll try to reproduce that locally once again.
@Jdlrobson sounds good to me. The only thing I see is that point
4: Don't build anon mode at all
We will have to support: anon, anon beta, logged in, logged-in + beta, logged-in + amc, logged-in + beta + amc. This approach reduces cost a bit (but not having to support anon amc, anon amc + beta).
yes, the problem happens only on the beta cluster and it's not easy to reproduce that locally.
There is no difference between js and non-js users as Special:MobileOptions page works for non-js users. Storing AMC preference can be done on the server side. The system can track analytics events on the server side (see Important notes section). The Advanced Mobile Contributions mode can be handled the same way as MobileBeta Mode. but there are some concerns (please see concerns section at the end of comment).
Tue, Dec 11
PagePreviews use the Restbase endpoint api/rest_v1/page/summary/ to fetch the HTML. This has to be implemented on the services side.
just FYI - those tests were executed on the staging server (chromium-pdf.wmflabs.org), which is configured the same as production. We had to proceed this way because the production doesn't return PDFs from new service. The production instance can return PDFs when we provide ?new_pdf=true but we cannot modify PDF render settings (size/mode). And the beta cluster PDF prints articles only from Beta cluster.
Blocked on meeting (scheduled on Thursday, Dec 13th)
Mon, Dec 10
I'm an admin now. Thanks
@Krenair sorry for tagging it with Horizon, I didn't know it's used only for administration of Horizon itself. I used this tag to indicate that this is related to Horizon.
Fri, Dec 7
Thu, Dec 6
Also, as there are two icons, we can implement both, and instrument the tapping of the button to send which version of the icon is visible to the user.
can we instrument it in a way so that we can find out if they followed-through with sharing a the link?
yes, that's possible, we need to add some argument to the shared url, something like ....?share_btn, then we will be able to verify how many users are visiting Wikipedia via share links.
Created ticket to grant access rights to the service: T211382
Documentation is available on MediaWiki: https://www.mediawiki.org/wiki/Proton
Wed, Dec 5
This can be achieved by rolling back https://github.com/wikimedia/mediawiki-extensions-ElectronPdfService/commit/ef9603b7b8ad260af38f593398f542f68c5ba1d1
Unit tests coverage can be checked by using npm run coverage
=============================== Coverage summary =============================== Statements : 74.02% ( 436/589 ) Branches : 44.83% ( 104/232 ) Functions : 90% ( 54/60 ) Lines : 74.61% ( 432/579 ) ================================================================================
I can replicate memory leak, and honestly, it leaks a lot. Good part is that we do not leak HTML DOM nodes, most of the allocated (and not freed up) memory is code/closures/variables/arrays/objects. I was testing most of the stuff using local vagrant environment with only Popups and EventLogging extensions. Popups were configured to use restbaseHTML gateway - pointing to the production wiki.
@JFG for now, I tried to isolate issues that only refer to Popups - I'm trying to learn how to properly use the memory profiling tools. I'll keep hunting for memory leaks in whole WMF code.
Tue, Dec 4
Mon, Dec 3
Works as expected
I'm still thinking about it. Honestly, I'm not a fan of this solution (the switch that disables failing test). I'll give it another shot, if I cannot get it working - then I'll resolve this task.
Fri, Nov 30
I'm still digging into the code. It looks like there is a memory leak (I don't want to confirm it yet. First I need to understand what's going on.). Most probably the leak is caused by hover events when Popups and EventLogging are enabled.
I also noticed that after removing PagePreviews MediaWiki is still leaking (not that much but still).-
Ready to test
Thu, Nov 29
Temporarily assigned to me, I need to verify that both the testing tool is up to date (can handle production service) and the Beta Cluster has the latest proton service.
All tasks are solved - this task is ready to sign off.
The service is ready, the remaining thing is to increase the CPU count (T197862). I'll talk with services today about this task.
Wed, Nov 28
@Jhernandez are there any points you would like to add to the Acceptance Criteria?