All three surveys (en, no, ar) are undeployed.

Per slack conversation with @MNeisler

Marking high as AMC is available to all users and pulling into sprint board.

Re-opening this task as not all menu entries are tracked. Some UserMenu/Overflow menu elements do not have data-event-name attribute, thus interactions with those elements are not tracked.

Tested, looks good, signing it off.

@ovasileva @alexhollender the Advanced mobile edit tag description says

@stjn the proposed solution works, but on pages like Barack Obama it makes thumbnails bit too big, thumbnails get cropped, thus sometimes people faces do not fit into the thumbnail div.

Could we also consider moving the Wikimedia-specific instrumentation for the main menu into the WikimediaEvents extension

@Isaac could you sign off this task, please?

Will SWAT it during EU SWAT window.

To play it safe, I think that config change should be deployed after rSMIN8d703b7758d4: Remove all main_menu tracking related code."" gets deployed to all wikis. We had couple problems with this task, also, the old schema has some magic that tracks all AMC users, but only wgMinervaSchemaMainMenuClickTrackingSampleRate of non-amc users.

Reverted because we were missing Norwegian translations.

Note: removed requirement of sampling rate 100% for all AMC users. We're enabling AMC for all users shortly, there is no need for special handling AMC users any more.

@MNeisler do we want to enable the schema on production with sampling rate 50% ?

@Isaac I made a patch, but because I did not enable the surveys previously I'm not super familiar with the config.

I removed the TODO: GrowthExperiments instructions here. Growth team fixed the issue in rEGRE74537902fa59: Support new AMC user menu and from my knowledge they properly QAed the change. /cc @Catrope

@ovasileva I reassigned this task to me as :
a) it needs QA steps
b) it needs this patch and proper configs on staging environment

/cc @Jdlrobson

@MNeisler just to be sure. We pass mode as a comma separated string, for example: beta,amc. Does the order matter for you? is there any difference if we pass amc,beta because of some reason?
It's not a problem for now - now it will be strictly defined set of possible values and order - just a question for future once we might start adding new modes.

Approach with hook might not work on translate.wiki. The translate wiki is using https://www.mediawiki.org/wiki/Extension:CleanChanges extension, which listens to the same hook, and overrides the $list with NCL, EnhancedChangesList or OldChangesList. Most probably code has to accommodate how CleanChanges extension works.

LGTM, resolving

LGTM

@MNeisler one more question. Do we want to send exact user edits count - eg: userEditCount. I noticed that lately we decided to use editCountBucket and send values:

"0 edits"
"1-4 edits"
"5-99 edits"
"100-999 edits"
"1000+ edits"

instead of sending exact number. I don't remember what was the reasoning behind that choice. (less identifying I guess).