Page MenuHomePhabricator

pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (157 w, 6 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Today

pmiazga added a project to T235416: Bullet points are not centered in horizontal lists: Readers-Web-Backlog.
Mon, Oct 14, 5:16 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), CSS, good first bug, MinervaNeue
pmiazga added a project to T235436: Vagrant installation fails: Readers-Web-Backlog (Tracking).
Mon, Oct 14, 5:06 PM · Readers-Web-Backlog (Tracking), MediaWiki-Vagrant, WMSE-Bug-Reporting-and-Translation-2019, MobileFrontend

Fri, Oct 11

pmiazga added a comment to T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load).

Looks good, on Monday I'll check couple things and then I'll resolve it.

Fri, Oct 11, 9:03 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Performance-Team (Radar), mediawiki-extensions-gadgets
Jdlrobson awarded T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users? a Like token.
Fri, Oct 11, 5:21 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Thu, Oct 10

pmiazga added a comment to T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users?.

@ovasileva

  • do we want to A/B test it per page or per the whole wiki?
  • do we know what is going to be our population size/which wikis do we want to A/B test? (like do we want to test on 100 users, or do we want to test on multiple wikis on 100 thousand anon users/sessions).
Thu, Oct 10, 6:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga edited projects for T233037: [Regression] Not possible for logged in users to disable page previews, added: Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog (Kanbanana-2019-20-Q2).
Thu, Oct 10, 2:35 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews
pmiazga added a comment to T233037: [Regression] Not possible for logged in users to disable page previews.

@awight - I can see popups as a logged-in user who disabled Page Previews on the Preferences page. It happens when I hover a regular page link.

Thu, Oct 10, 1:24 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews

Wed, Oct 9

pmiazga moved T234344: MinervaClientError sends malformed events from Doing to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Oct 9, 5:05 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
pmiazga claimed T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load).
Wed, Oct 9, 5:04 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Performance-Team (Radar), mediawiki-extensions-gadgets
pmiazga updated subscribers of T233037: [Regression] Not possible for logged in users to disable page previews.

Moved to "Blocked on others" as it would be more valuable for the team who created Reference Previews to look at it (as it may be related).

Wed, Oct 9, 4:33 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews
pmiazga updated the task description for T233612: Deploy Advanced mode to all Wikimedia projects.
Wed, Oct 9, 4:10 PM · User-notice, Wikimedia-Site-requests, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Tue, Oct 8

pmiazga claimed T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users?.
Tue, Oct 8, 7:47 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga moved T233609: [SPIKE 4hrs] What is technically feasible in terms of logged-in/logged-out users? from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Oct 8, 7:47 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
pmiazga updated subscribers of T230016: Update description under AMC setting.

@ovasileva, @alexhollender
Is the Advanced mode provides improved access to talk pages, history pages, user tools, and other editing tool. message final?

Tue, Oct 8, 7:46 PM · Patch-For-Review, Advanced Mobile Contributions, Readers-Web-Backlog (Kanbanana-2019-20-Q2)
pmiazga updated the task description for T230695: Render talk page as a tab (rather than a modal).
Tue, Oct 8, 5:24 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Fri, Oct 4

pmiazga added a comment to T233982: Feature MinervaTalkAtTop is not defined during logout.

The problem is not Minerva, the problem is how/when MobileFrontend initializes FeatureManager. Just changing hook from RequestContextCreateSkinMobile to RequestContextCreateSkin won't help. The problem will be the same - The FeatureManager won't be initialized (won't send the hook).

Fri, Oct 4, 5:36 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue, Wikimedia-production-error
pmiazga moved T233982: Feature MinervaTalkAtTop is not defined during logout from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Fri, Oct 4, 10:50 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue, Wikimedia-production-error
pmiazga added a comment to T233982: Feature MinervaTalkAtTop is not defined during logout.

So the problem is:

  • The FeatureManager is a part of MobileFrontend.
  • Feature registration happens when MobileFrontend kicks in (via RequestContextCreateSkin
  • During RequestContextCreateSkin we trigger MobileFrontendFeaturesRegistration hook that allows Minerva to register it's own features
  • because we use Minerva as desktop skin, the mobile mode doesn't kick in, thus code from RequestContextCreateSkin is not called, therefore Minerva doesn't register it's features
Fri, Oct 4, 10:42 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MinervaNeue, Wikimedia-production-error

Thu, Oct 3

pmiazga moved T234344: MinervaClientError sends malformed events from Needs Analysis to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Oct 3, 5:08 PM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue
pmiazga moved T233663: Remove Minerva's EventLogging error tracking from Needs Code Review to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Thu, Oct 3, 3:01 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review
pmiazga claimed T234344: MinervaClientError sends malformed events.
Thu, Oct 3, 8:58 AM · Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Analytics, MinervaNeue

Wed, Oct 2

pmiazga updated subscribers of T234258: Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs?.
Wed, Oct 2, 6:11 PM · Readers-Web-Backlog (Tracking)
pmiazga added a comment to T234258: Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs?.

From my knowledge, readers-web-stephen is used and cannot be deleted. @Niedzielski is on sabbatical so he cannot confirm.

Wed, Oct 2, 6:11 PM · Readers-Web-Backlog (Tracking)
pmiazga closed T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct() as Declined.
Wed, Oct 2, 5:14 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga added a comment to T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct().

This issue happened twice and it's related to the deployment process. It happened exactly when a new branch was pushed to production and because of some reason PHP cached old AMCManager definition but used new ServiceWirings file, thus there was an inconsistency with the argument count. This did not happen again.

Wed, Oct 2, 5:14 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga placed T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts up for grabs.
Wed, Oct 2, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Performance-Team (Radar), MobileFrontend
pmiazga moved T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Oct 2, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Performance-Team (Radar), MobileFrontend
pmiazga placed T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias up for grabs.
Wed, Oct 2, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga moved T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias from Doing to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Wed, Oct 2, 1:02 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga added a comment to T232652: Add History to article toolbar for all logged-in users.

@nray yup, that's what I did.

Wed, Oct 2, 11:35 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Mon, Sep 30

pmiazga moved T232690: Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Mon, Sep 30, 6:52 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Performance-Team (Radar), MobileFrontend
pmiazga claimed T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias.
Mon, Sep 30, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga moved T206497: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Sep 30, 5:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), Wikimedia-Site-requests, Hindi-Sites, Chinese-Sites, SEO
pmiazga added a watcher for Desktop Improvements: pmiazga.
Mon, Sep 30, 12:03 PM

Fri, Sep 20

pmiazga added a comment to T233037: [Regression] Not possible for logged in users to disable page previews.

I can confirm this is an issue on Beta Cluster - I cannot reproduce that on production Reference Previews are enabled on German Wikipedia, but everything works there.

Fri, Sep 20, 7:47 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews

Wed, Sep 18

pmiazga moved T231613: Replace 24x24px SVGs in MF/Minerva from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Sep 18, 9:55 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
pmiazga assigned T232723: [Bug] [AMC] Multiple MobileWebUIActionsTracking instrumentation errors to Edtadros.
Wed, Sep 18, 5:17 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Mobile, MediaWiki-extensions-WikimediaEvents

Tue, Sep 17

pmiazga added a comment to T232652: Add History to article toolbar for all logged-in users.

@alexhollender everything is possible, but that's probably a new task. Also, please note, that the DownloadIcon is injected via JS, thus it may cause FOUC when we decide to change styling based on the number of icons in the toolbar.

Tue, Sep 17, 7:54 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga updated subscribers of T232652: Add History to article toolbar for all logged-in users.

@Alex I just want to confirm - those mocks are not in sync, right? We do not show a different toolbar for Android and iOS.

Tue, Sep 17, 5:55 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga updated the task description for T230034: [AMC] Menu handle has no active state.
Tue, Sep 17, 9:51 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga updated the task description for T230034: [AMC] Menu handle has no active state.
Tue, Sep 17, 9:50 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions

Mon, Sep 16

pmiazga reassigned T230034: [AMC] Menu handle has no active state from alexhollender to Edtadros.
Mon, Sep 16, 7:30 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga added a comment to T230034: [AMC] Menu handle has no active state.

The highlight color can be modified by -webkit-tap-highlight-color,

  • we can disable the highlight color for menu handles, but it will bring inconsistency between user menu and notifications menu, same it will bring inconsistency between icons on toolbar and the overflow menu
  • set the highlight to given color - we will need two CSS rules, one for user menu (it's on dark background), and a second one for overflow menu (it's on white background). The ToggleList supposed to be a generic component,

but if we want to make it look nice we need specific styles based on where the menu trigger is located.

Mon, Sep 16, 7:30 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga added a comment to T232723: [Bug] [AMC] Multiple MobileWebUIActionsTracking instrumentation errors .

This task looks good to me and we can start working on it.

Mon, Sep 16, 11:34 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions, Mobile, MediaWiki-extensions-WikimediaEvents

Sep 13 2019

pmiazga added a comment to T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

After Fix thanks extension works as expected

Sep 13 2019, 7:23 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
pmiazga added a comment to T232792: [Regression] ICONS: Not compatible with truncated text (last modified and logout button).

The logout icon on Firefox is misaligned:

Sep 13 2019, 2:55 PM · Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga added a comment to T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

I found a weird issue on Firefox (on production) - The logout icon is misaligned -

Sep 13 2019, 2:32 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Sep 12 2019

pmiazga added a comment to T230694: [AMC] Updates to "User rights" menu item.

Ready to review.

Sep 12 2019, 2:02 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga placed T230694: [AMC] Updates to "User rights" menu item up for grabs.
Sep 12 2019, 2:00 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T230694: [AMC] Updates to "User rights" menu item from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 12 2019, 2:00 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Sep 11 2019

pmiazga claimed T230694: [AMC] Updates to "User rights" menu item.
Sep 11 2019, 3:00 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T230694: [AMC] Updates to "User rights" menu item from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 11 2019, 3:00 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga assigned T231436: Turn off AMC outreach modal to ovasileva.
Sep 11 2019, 2:59 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga updated the task description for T231436: Turn off AMC outreach modal.
Sep 11 2019, 2:58 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga moved T231436: Turn off AMC outreach modal from Ready for Development to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 11 2019, 2:58 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Sep 10 2019

pmiazga added a comment to T230034: [AMC] Menu handle has no active state.

thx @nray, @alexhollender this thing will be available to verify on beta cluster/staging env

Sep 10 2019, 6:27 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga placed T230034: [AMC] Menu handle has no active state up for grabs.
Sep 10 2019, 12:11 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga moved T230034: [AMC] Menu handle has no active state from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 10 2019, 12:11 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga moved T230034: [AMC] Menu handle has no active state from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 10 2019, 11:15 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga placed T220016: Create, and deploy working MobileWebUIActionsTracking schema up for grabs.
Sep 10 2019, 11:15 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T220016: Create, and deploy working MobileWebUIActionsTracking schema from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 10 2019, 11:14 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga added a comment to T220016: Create, and deploy working MobileWebUIActionsTracking schema.

Bumping sampling rate to 10%

Sep 10 2019, 9:57 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T220016: Create, and deploy working MobileWebUIActionsTracking schema from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 10 2019, 9:56 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Sep 9 2019

pmiazga added a comment to T206265: Bug: Section edit links should be hidden for blocked users.

@Edtadros can beta cluster, can be staging. Let's proceed with staging, please share the user name that has to be blocked,

Sep 9 2019, 8:22 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug

Sep 5 2019

pmiazga placed T230034: [AMC] Menu handle has no active state up for grabs.
Sep 5 2019, 2:23 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga moved T230034: [AMC] Menu handle has no active state from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 5 2019, 2:23 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga placed T230694: [AMC] Updates to "User rights" menu item up for grabs.
Sep 5 2019, 1:47 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T230694: [AMC] Updates to "User rights" menu item from Doing to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 5 2019, 10:16 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga added a comment to T230694: [AMC] Updates to "User rights" menu item.

text change is done in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/534596/ but the icon change is blocked on T230694#5466578. All overflow menu icons come from WikimediaUI. If we want to change the SVG to userGroups, first we have to add it to WikimediaUI.

Sep 5 2019, 10:16 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga claimed T230694: [AMC] Updates to "User rights" menu item.
Sep 5 2019, 10:01 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T230694: [AMC] Updates to "User rights" menu item from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 5 2019, 10:01 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Sep 4 2019

pmiazga claimed T230034: [AMC] Menu handle has no active state.
Sep 4 2019, 8:40 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga moved T230034: [AMC] Menu handle has no active state from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sep 4 2019, 8:40 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
pmiazga reassigned T206265: Bug: Section edit links should be hidden for blocked users from pmiazga to Edtadros.
Sep 4 2019, 8:40 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug

Sep 3 2019

pmiazga added a comment to T220016: Create, and deploy working MobileWebUIActionsTracking schema.

/cc @Nuria @MNeisler

Sep 3 2019, 5:20 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga added a comment to T220016: Create, and deploy working MobileWebUIActionsTracking schema.

We're receiving ~15 events per minute (previously we were receiving ~100 events), I think that we can still safely bump the sampling rate to ~10%, but first, we need to understand why do we get an events spike from time to time.

Sep 3 2019, 5:16 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Sep 2 2019

pmiazga added a comment to T220016: Create, and deploy working MobileWebUIActionsTracking schema.

Now we're tracking all clicks on menu elements (Main Menu, Toolbar, Overflow, User) with 0.01% sampling rate.
Previously, for the MainMenu only, we were getting ~80-100 events per 10 minutes, now we're getting less than 1 even per 10 minutes (see https://grafana.wikimedia.org/d/000000018/eventlogging-schema?orgId=1&var-schema=MobileWebUIActionsTracking&from=now-7d&to=now ). I'll bump the sampling rate by 100 (to 1%).

Sep 2 2019, 12:11 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Aug 29 2019

pmiazga claimed T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct().
Aug 29 2019, 4:33 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
pmiazga updated subscribers of T229295: Cleanup AMC feature flagging.

The only missing thing are translations (only if we want to promote those things into beta mode) - but I'm not sure if this is something we might do.

Aug 29 2019, 3:48 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
pmiazga placed T229295: Cleanup AMC feature flagging up for grabs.
Aug 29 2019, 3:35 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
pmiazga added a comment to T229295: Cleanup AMC feature flagging.

QA all possible configs, everything looks good, each config works well both standalone, and with other configs.

Aug 29 2019, 3:35 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
pmiazga moved T229295: Cleanup AMC feature flagging from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:35 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions

Aug 28 2019

pmiazga added a comment to T231206: Turn on AMC outreach modal.

@Jdforrester-WMF sorry for the trouble. Thanks for the fix. Do you need any help with that?

Aug 28 2019, 5:11 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga moved T231206: Turn on AMC outreach modal from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 28 2019, 5:10 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga added a comment to T206265: Bug: Section edit links should be hidden for blocked users.

sure, I'll check it

Aug 28 2019, 2:35 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug
pmiazga updated the task description for T231206: Turn on AMC outreach modal.
Aug 28 2019, 12:10 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga added a comment to T231206: Turn on AMC outreach modal.

Task to disable this feature in two weeks is tracked in T231436: Turn off AMC outreach modal

Aug 28 2019, 12:10 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga placed T231436: Turn off AMC outreach modal up for grabs.
Aug 28 2019, 12:09 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga created T231436: Turn off AMC outreach modal.
Aug 28 2019, 12:08 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
pmiazga moved T231206: Turn on AMC outreach modal from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 28 2019, 9:59 AM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Aug 27 2019

pmiazga added a comment to T220016: Create, and deploy working MobileWebUIActionsTracking schema.

Blocked on 1.34-wmf.20 release.

Aug 27 2019, 5:07 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga moved T220016: Create, and deploy working MobileWebUIActionsTracking schema from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 27 2019, 5:06 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
pmiazga added a comment to T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.

Also, please thing about different languages. English looks really nice, but I'm afraid that in other languages those labels can be pretty long. For example in Polish language "unwatch" would become "przestań obserwować" or "usuń z obserwowanych".

Aug 27 2019, 4:32 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
pmiazga added a comment to T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.

The Language icon title definition in i18n:

Aug 27 2019, 4:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
pmiazga closed T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode", a subtask of T220745: 1.34.0-wmf.20 deployment blockers, as Resolved.
Aug 27 2019, 10:00 AM · User-zeljkofilipin, Release-Engineering-Team-TODO (201908), Release-Engineering-Team (Deployment services), Release, Train Deployments
pmiazga closed T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" as Resolved.
Aug 27 2019, 10:00 AM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
pmiazga moved T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 27 2019, 10:00 AM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
pmiazga added a comment to T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".

ok, thx for info

Aug 27 2019, 9:59 AM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
pmiazga added a comment to T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".

@zeljkofilipin this should be fixed now, can we resolve task once this goes to production? We're unable to reproduce it locally.

Aug 27 2019, 8:40 AM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error

Aug 26 2019

pmiazga added a comment to T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".

@zeljkofilipin yes, the fix got merged like 2 hours ago, but the CI is still processing it ;/

Aug 26 2019, 6:12 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error