pmiazga (Piotr Miazga)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2016, 5:18 PM (114 w, 4 d)
Availability
Available
LDAP User
Pmiazga
MediaWiki User
PMiazga (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Jdlrobson awarded T211375: Rename chromium-render gerrit project to Proton a Heartbreak token.
Fri, Dec 14, 6:29 PM · Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team Backlog (Attic), Services (attic), Gerrit, Readers-Web-Backlog, Proton

Thu, Dec 13

pmiazga added a comment to T208634: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions.

@Jdlrobson this also might be related to the browser, did you call GC after doing tests? what is your chrome/os version? Sure, I'll try to reproduce that locally once again.

Thu, Dec 13, 11:29 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Performance-Team (Radar), Page-Previews
pmiazga added a comment to T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation.

@Jdlrobson sounds good to me. The only thing I see is that point

4: Don't build anon mode at all

We will have to support: anon, anon beta, logged in, logged-in + beta, logged-in + amc, logged-in + beta + amc. This approach reduces cost a bit (but not having to support anon amc, anon amc + beta).

Thu, Dec 13, 11:14 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions
pmiazga moved T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Dec 13, 11:08 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-D3r1ck01, MobileFrontend
pmiazga awarded T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium a Burninate token.
Thu, Dec 13, 5:58 PM · Readers-Web-Backlog, Epic, MobileFrontend
pmiazga added a comment to T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation.

Does this mean there is no JavaScript executed on Special:MobileOptions? If there is JavaScript, it would seem to me that we have different options available to us on the server and client.

There is Javascript on Special:MobileOptions (to make toggles look nice and to autosubmit the form when you toggle the beta mode). What I want to say, there is no Javascript required to opt-in to beta, also there is no JS tracking, everything (opt-in/opt-out) and AnalyticsEvents tracking are done on the server side.

Thu, Dec 13, 5:41 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions
pmiazga closed T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster as Resolved.
Thu, Dec 13, 2:20 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue
pmiazga added a comment to T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster.

yes, the problem happens only on the beta cluster and it's not easy to reproduce that locally.

Thu, Dec 13, 2:20 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue
pmiazga moved T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Dec 13, 2:19 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions
pmiazga added a comment to T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation.

Summary

There is no difference between js and non-js users as Special:MobileOptions page works for non-js users. Storing AMC preference can be done on the server side. The system can track analytics events on the server side (see Important notes section). The Advanced Mobile Contributions mode can be handled the same way as MobileBeta Mode. but there are some concerns (please see concerns section at the end of comment).

Thu, Dec 13, 2:17 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions

Tue, Dec 11

pmiazga moved T211078: [Bug] Arrow in the "Jump to Top" circle is not centered on RTL wikis (βeta) from Needs triage to Triaged on the Mobile board.
Tue, Dec 11, 10:41 PM · goodfirstbug, Readers-Web-Backlog, Mobile, MinervaNeue, RTL, I18n
pmiazga moved T211439: Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target) from Needs triage to Triaged on the Mobile board.
Tue, Dec 11, 10:41 PM · Readers-Web-Backlog (Design), MinervaNeue, MediaWiki-User-login-and-signup, Mobile
pmiazga added projects to T211501: Page Previews should take FlaggedRevs' stabilization setting into account: Readers-Web-Backlog (Tracking), Services.
Tue, Dec 11, 10:36 PM · Services (later), Readers-Web-Backlog (Tracking), Page-Previews, MediaWiki-extensions-FlaggedRevs
pmiazga added a comment to T211501: Page Previews should take FlaggedRevs' stabilization setting into account.

PagePreviews use the Restbase endpoint api/rest_v1/page/summary/ to fetch the HTML. This has to be implemented on the services side.

Tue, Dec 11, 10:36 PM · Services (later), Readers-Web-Backlog (Tracking), Page-Previews, MediaWiki-extensions-FlaggedRevs
pmiazga added a project to T211439: Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target): Readers-Web-Backlog.
Tue, Dec 11, 10:30 PM · Readers-Web-Backlog (Design), MinervaNeue, MediaWiki-User-login-and-signup, Mobile
pmiazga updated subscribers of T211305: Preference for page-previews default incorrect when resetting preferences.
Tue, Dec 11, 10:28 PM · User-TheDJ, Readers-Web-Backlog, MediaWiki-User-preferences, Page-Previews
pmiazga added a project to T211305: Preference for page-previews default incorrect when resetting preferences: Readers-Web-Backlog.
Tue, Dec 11, 10:27 PM · User-TheDJ, Readers-Web-Backlog, MediaWiki-User-preferences, Page-Previews
pmiazga added a comment to T211305: Preference for page-previews default incorrect when resetting preferences.

@TheDJ - @Jdforrester-WMF nailed the answer. It's exactly

Tue, Dec 11, 10:26 PM · User-TheDJ, Readers-Web-Backlog, MediaWiki-User-preferences, Page-Previews
pmiazga added a project to T211212: Page Previews not working in SRF Datatables: Readers-Web-Backlog.
Tue, Dec 11, 10:06 PM · Page-Previews (Tracking), mediawiki-extensions-Semantic-Result-Formats, Readers-Web-Backlog (Tracking)
pmiazga added a project to T211078: [Bug] Arrow in the "Jump to Top" circle is not centered on RTL wikis (βeta): Readers-Web-Backlog.
Tue, Dec 11, 10:03 PM · goodfirstbug, Readers-Web-Backlog, Mobile, MinervaNeue, RTL, I18n
pmiazga updated subscribers of T211078: [Bug] Arrow in the "Jump to Top" circle is not centered on RTL wikis (βeta).

ping @alexhollender

Tue, Dec 11, 10:03 PM · goodfirstbug, Readers-Web-Backlog, Mobile, MinervaNeue, RTL, I18n
pmiazga added a project to T211063: It should be possible to turn lead paragraph on in other namespaces: Readers-Web-Backlog.
Tue, Dec 11, 10:02 PM · Need-volunteer, Readers-Web-Backlog, MobileFrontend
pmiazga added a comment to T210793: Verify that PDFs generated by Proton service are correct.

just FYI - those tests were executed on the staging server (chromium-pdf.wmflabs.org), which is configured the same as production. We had to proceed this way because the production doesn't return PDFs from new service. The production instance can return PDFs when we provide ?new_pdf=true but we cannot modify PDF render settings (size/mode). And the beta cluster PDF prints articles only from Beta cluster.

Tue, Dec 11, 5:11 PM · Readers-Web-Backlog, Proton
pmiazga added a comment to T210652: Handoff Proton service to Reading Infrastructure.

Blocked on meeting (scheduled on Thursday, Dec 13th)

Tue, Dec 11, 5:07 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga moved T210652: Handoff Proton service to Reading Infrastructure from Doing to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Dec 11, 5:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton

Mon, Dec 10

pmiazga closed T211610: Add @pmiazga to the reading-web-staging admin group in horizon as Resolved.
Mon, Dec 10, 6:15 PM · Readers-Web-Backlog
pmiazga added a comment to T211610: Add @pmiazga to the reading-web-staging admin group in horizon.

I'm an admin now. Thanks

Mon, Dec 10, 6:15 PM · Readers-Web-Backlog
pmiazga added a comment to T211610: Add @pmiazga to the reading-web-staging admin group in horizon.

@Krenair sorry for tagging it with Horizon, I didn't know it's used only for administration of Horizon itself. I used this tag to indicate that this is related to Horizon.

Mon, Dec 10, 5:28 PM · Readers-Web-Backlog
pmiazga updated subscribers of T211610: Add @pmiazga to the reading-web-staging admin group in horizon.

@phuedx can you approve my request?
@Jhernandez looks like you know how to do it (T172911), can you add me to the admin group?

Mon, Dec 10, 5:19 PM · Readers-Web-Backlog
pmiazga created T211610: Add @pmiazga to the reading-web-staging admin group in horizon.
Mon, Dec 10, 5:17 PM · Readers-Web-Backlog

Fri, Dec 7

pmiazga added a comment to T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.

@bearND - per https://phabricator.wikimedia.org/T210652#4787383 looks like no, James is working on multimedia.

Fri, Dec 7, 4:01 PM · Patch-For-Review, Proton, SRE-Access-Requests, Operations
pmiazga updated subscribers of T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.

@phuedx could you approve my request? @Jhernandez can you approve the request for @bearND @Mholloway @MSantos and @Tgr?

Fri, Dec 7, 3:44 PM · Patch-For-Review, Proton, SRE-Access-Requests, Operations

Thu, Dec 6

pmiazga claimed T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation.
Thu, Dec 6, 10:07 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions
pmiazga moved T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Dec 6, 10:07 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions
pmiazga added a parent task for T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr: T210652: Handoff Proton service to Reading Infrastructure.
Thu, Dec 6, 10:04 PM · Patch-For-Review, Proton, SRE-Access-Requests, Operations
pmiazga added a subtask for T210652: Handoff Proton service to Reading Infrastructure: T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.
Thu, Dec 6, 10:04 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga added a comment to T181195: Add a share button to the mobile site (starting by enabling in beta).

Also, as there are two icons, we can implement both, and instrument the tapping of the button to send which version of the icon is visible to the user.

Thu, Dec 6, 10:02 PM · Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26))
pmiazga added a comment to T181195: Add a share button to the mobile site (starting by enabling in beta).

can we instrument it in a way so that we can find out if they followed-through with sharing a the link?

yes, that's possible, we need to add some argument to the shared url, something like ....?share_btn, then we will be able to verify how many users are visiting Wikipedia via share links.

Thu, Dec 6, 9:59 PM · Readers-Web-Backlog (Design), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26))
pmiazga added a comment to T210652: Handoff Proton service to Reading Infrastructure.

Created ticket to grant access rights to the service: T211382

Thu, Dec 6, 9:46 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga updated subscribers of T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.

@bearND @Mholloway @MSantos @Tgr could you edit the task and put your shell usernames here please?

Thu, Dec 6, 9:45 PM · Patch-For-Review, Proton, SRE-Access-Requests, Operations
pmiazga updated the task description for T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.
Thu, Dec 6, 9:43 PM · Patch-For-Review, Proton, SRE-Access-Requests, Operations
pmiazga created T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.
Thu, Dec 6, 9:41 PM · Patch-For-Review, Proton, SRE-Access-Requests, Operations
pmiazga added a comment to T210652: Handoff Proton service to Reading Infrastructure.

Documentation is available on MediaWiki: https://www.mediawiki.org/wiki/Proton

Thu, Dec 6, 8:58 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Thu, Dec 6, 8:58 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga added a parent task for T211375: Rename chromium-render gerrit project to Proton: T210652: Handoff Proton service to Reading Infrastructure.
Thu, Dec 6, 8:57 PM · Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team Backlog (Attic), Services (attic), Gerrit, Readers-Web-Backlog, Proton
pmiazga added a subtask for T210652: Handoff Proton service to Reading Infrastructure: T211375: Rename chromium-render gerrit project to Proton.
Thu, Dec 6, 8:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga created T211375: Rename chromium-render gerrit project to Proton.
Thu, Dec 6, 8:56 PM · Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team Backlog (Attic), Services (attic), Gerrit, Readers-Web-Backlog, Proton

Wed, Dec 5

D3r1ck01 awarded T209768: Fix $this->file hard dependency on PageImages extension a Party Time token.
Wed, Dec 5, 9:38 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-D3r1ck01, MobileFrontend
pmiazga closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.
Wed, Dec 5, 9:29 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-D3r1ck01, MobileFrontend
pmiazga closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Wed, Dec 5, 9:29 PM · Readers-Web-Backlog, Epic, MobileFrontend
pmiazga added a comment to T211002: Remove PDF banner.

This can be achieved by rolling back https://github.com/wikimedia/mediawiki-extensions-ElectronPdfService/commit/ef9603b7b8ad260af38f593398f542f68c5ba1d1

Wed, Dec 5, 5:35 PM · Readers-Web-Backlog, Proton
pmiazga updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Wed, Dec 5, 1:11 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga added a comment to T210652: Handoff Proton service to Reading Infrastructure.

Unit tests coverage can be checked by using npm run coverage

=============================== Coverage summary ===============================
Statements   : 74.02% ( 436/589 )
Branches     : 44.83% ( 104/232 )
Functions    : 90% ( 54/60 )
Lines        : 74.61% ( 432/579 )
================================================================================
Wed, Dec 5, 1:10 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga claimed T210652: Handoff Proton service to Reading Infrastructure.
Wed, Dec 5, 1:00 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga moved T210652: Handoff Proton service to Reading Infrastructure from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Dec 5, 1:00 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga placed T208634: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions up for grabs.
Wed, Dec 5, 1:00 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Performance-Team (Radar), Page-Previews
pmiazga moved T208634: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions from Doing to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Dec 5, 1:00 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Performance-Team (Radar), Page-Previews
pmiazga added a comment to T208634: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions.

I can replicate memory leak, and honestly, it leaks a lot. Good part is that we do not leak HTML DOM nodes, most of the allocated (and not freed up) memory is code/closures/variables/arrays/objects. I was testing most of the stuff using local vagrant environment with only Popups and EventLogging extensions. Popups were configured to use restbaseHTML gateway - pointing to the production wiki.

Wed, Dec 5, 12:59 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Performance-Team (Radar), Page-Previews
pmiazga added a comment to T205127: Memory leak on Wikipedia pages (including Popups).

@JFG for now, I tried to isolate issues that only refer to Popups - I'm trying to learn how to properly use the memory profiling tools. I'll keep hunting for memory leaks in whole WMF code.

Wed, Dec 5, 12:48 AM · Readers-Web-Backlog, Performance-Team (Radar), Page-Previews, Growth-Team
pmiazga created T211168: Prevent memory leaks from the nextState() function.
Wed, Dec 5, 12:45 AM · Performance-Team (Radar), Page-Previews, Readers-Web-Backlog

Tue, Dec 4

pmiazga moved T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Dec 4, 4:20 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-D3r1ck01, MobileFrontend
pmiazga moved T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Dec 4, 2:14 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-D3r1ck01, MobileFrontend
pmiazga moved T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Dec 4, 2:14 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-D3r1ck01, MobileFrontend
pmiazga moved T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Tue, Dec 4, 2:14 PM · Readers-Web-Backlog, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), User-D3r1ck01, MobileFrontend

Mon, Dec 3

pmiazga closed T204876: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi as Resolved.
Mon, Dec 3, 10:52 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018, Need-volunteer, goodfirstbug, MobileFrontend
pmiazga added a comment to T204876: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi.

Works as expected

Mon, Dec 3, 10:52 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018, Need-volunteer, goodfirstbug, MobileFrontend
pmiazga moved T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Mon, Dec 3, 10:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue
pmiazga added a comment to T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster.

I'm still thinking about it. Honestly, I'm not a fan of this solution (the switch that disables failing test). I'll give it another shot, if I cannot get it working - then I'll resolve this task.

Mon, Dec 3, 10:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue
pmiazga claimed T208808: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster.
Mon, Dec 3, 6:04 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, Spike, MinervaNeue
pmiazga claimed T204876: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi.
Mon, Dec 3, 6:03 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018, Need-volunteer, goodfirstbug, MobileFrontend

Fri, Nov 30

pmiazga added a comment to T208634: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions.

I'm still digging into the code. It looks like there is a memory leak (I don't want to confirm it yet. First I need to understand what's going on.). Most probably the leak is caused by hover events when Popups and EventLogging are enabled.
I also noticed that after removing PagePreviews MediaWiki is still leaking (not that much but still).-

Fri, Nov 30, 10:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Performance-Team (Radar), Page-Previews
pmiazga added a comment to T210793: Verify that PDFs generated by Proton service are correct.

Ready to test

Fri, Nov 30, 7:54 PM · Readers-Web-Backlog, Proton
pmiazga placed T210793: Verify that PDFs generated by Proton service are correct up for grabs.
Fri, Nov 30, 7:54 PM · Readers-Web-Backlog, Proton

Thu, Nov 29

pmiazga added a comment to T210793: Verify that PDFs generated by Proton service are correct.

Temporarily assigned to me, I need to verify that both the testing tool is up to date (can handle production service) and the Beta Cluster has the latest proton service.

Thu, Nov 29, 9:49 PM · Readers-Web-Backlog, Proton
pmiazga created T210793: Verify that PDFs generated by Proton service are correct.
Thu, Nov 29, 9:48 PM · Readers-Web-Backlog, Proton
pmiazga updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Thu, Nov 29, 9:43 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga added a comment to T210652: Handoff Proton service to Reading Infrastructure.

@Jhernandez could you provide me with a list of people who requires access to deploy/manage Proton service? just @Mholloway and @bearND?

Thu, Nov 29, 9:42 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Thu, Nov 29, 9:41 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton
pmiazga moved T210737: Various User.php: PHP Notice: Object of class User could not be converted to int from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Nov 29, 6:10 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga placed T210737: Various User.php: PHP Notice: Object of class User could not be converted to int up for grabs.
Thu, Nov 29, 6:10 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga moved T210737: Various User.php: PHP Notice: Object of class User could not be converted to int from Needs Code Review to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Nov 29, 6:09 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga placed T193505: AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid errors up for grabs.
Thu, Nov 29, 6:06 PM · Advanced Mobile Contributions, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Need-volunteer, MinervaNeue (Desktop)
pmiazga added a comment to T181084: [EPIC] Deploy the mediawiki-services-chromium-render service (Proton).

All tasks are solved - this task is ready to sign off.

Thu, Nov 29, 5:48 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, Proton, Epic
pmiazga removed a subtask for T186748: [EPIC] New service request: chromium-render/deploy: T197862: Increase the CPU count for proton[12]00[12].
Thu, Nov 29, 5:48 PM · Epic, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-notice, Services (blocked), Service-deployment-requests, Proton, Operations, Electron-PDFs
pmiazga edited parent tasks for T197862: Increase the CPU count for proton[12]00[12], added: T181084: [EPIC] Deploy the mediawiki-services-chromium-render service (Proton); removed: T186748: [EPIC] New service request: chromium-render/deploy.
Thu, Nov 29, 5:48 PM · Operations, Services (doing), Proton
pmiazga added a subtask for T181084: [EPIC] Deploy the mediawiki-services-chromium-render service (Proton): T197862: Increase the CPU count for proton[12]00[12].
Thu, Nov 29, 5:48 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, Proton, Epic
pmiazga moved T210737: Various User.php: PHP Notice: Object of class User could not be converted to int from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Nov 29, 4:46 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga added a comment to T210737: Various User.php: PHP Notice: Object of class User could not be converted to int.

It's caused by https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/d85ddc207836e61515d8679951d660b3c5671425#diff-bb2b21ef7774df8687ff02b0284505c6

Thu, Nov 29, 3:42 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga claimed T210737: Various User.php: PHP Notice: Object of class User could not be converted to int.
Thu, Nov 29, 3:32 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga moved T210737: Various User.php: PHP Notice: Object of class User could not be converted to int from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Thu, Nov 29, 3:32 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend, Wikimedia-production-error
pmiazga added a comment to T186748: [EPIC] New service request: chromium-render/deploy.

The service is ready, the remaining thing is to increase the CPU count (T197862). I'll talk with services today about this task.

Thu, Nov 29, 2:09 PM · Epic, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-notice, Services (blocked), Service-deployment-requests, Proton, Operations, Electron-PDFs

Wed, Nov 28

pmiazga closed T204866: MFA: Remove mobile.startup/user as Resolved.
Wed, Nov 28, 11:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Performance-Team (Radar), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
pmiazga closed T204866: MFA: Remove mobile.startup/user, a subtask of T195478: [EPIC] Speed up unit test execution and increase code coverage, as Resolved.
Wed, Nov 28, 11:13 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Readers-Web-Kanbanana-Board-Old, User-Jdlrobson, Epic, MobileFrontend, MinervaNeue
pmiazga added a comment to T204866: MFA: Remove mobile.startup/user.

LGTM

Wed, Nov 28, 11:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Performance-Team (Radar), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture)
pmiazga closed T210333: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests as Resolved.
Wed, Nov 28, 9:19 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-D3r1ck01, MobileFrontend
pmiazga closed T210333: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Wed, Nov 28, 9:19 PM · Readers-Web-Backlog, Epic, MobileFrontend
pmiazga added a comment to T210333: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests.

LGTM

Wed, Nov 28, 9:19 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), User-D3r1ck01, MobileFrontend
pmiazga moved T86210: MobileFrontend throws away warnings and other data from action=parse from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Wed, Nov 28, 9:18 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018, Need-volunteer, MobileFrontend
pmiazga removed a project from T86210: MobileFrontend throws away warnings and other data from action=parse: Patch-For-Review.
Wed, Nov 28, 9:18 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Google-Code-in-2018, Need-volunteer, MobileFrontend
pmiazga added a comment to T210652: Handoff Proton service to Reading Infrastructure.

@Jhernandez are there any points you would like to add to the Acceptance Criteria?

Wed, Nov 28, 8:07 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Reading-Infrastructure-Team-Backlog, Proton