Page MenuHomePhabricator

sarhan.alaa (Alaa Sarhan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 9 2019, 8:29 PM (88 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Sarhan.alaa [ Global Accounts ]

Recent Activity

Jan 8 2020

sarhan.alaa claimed T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection.
Jan 8 2020, 10:10 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Ladsgroup, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
sarhan.alaa moved T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

I drafted a patch for this, but won't have enough time to clean it up .. it works fine now, but the code is not the prettiest. Specifically, it might require some clean-up around where TermCollisionDetector instances come from, as for these two special pages we are getting them directly from WikibaseRepo (where it is determined whether we are using new store or not) but inside TermsValidatorFactory it is done using another layer of indirection (with ByIdFingerprintUniquenessValidator) and so on.. but probably it is better to do such clean up when migration is done and temporary stuff are removed.

Jan 8 2020, 10:08 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Ladsgroup, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
sarhan.alaa moved T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Jan 8 2020, 9:48 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Ladsgroup, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
sarhan.alaa created T242204: Update SpecialNewProperty and SpecialNewItem to use new store conflict detection.
Jan 8 2020, 9:48 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Ladsgroup, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Jan 6 2020

sarhan.alaa updated the task description for T232040: Add label and description collision detectors for new terms store.
Jan 6 2020, 8:17 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

Oh, apparently SpecialNewEntity creates entities without even creating change ops. That would explain it, as then it will by-pass the whole validation of fignreprint uniqueness that is only executed inside ChangeOpFingerprintResult::validate(). Guess that needs to change too.

Jan 6 2020, 8:16 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa updated the task description for T232040: Add label and description collision detectors for new terms store.
Jan 6 2020, 6:35 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

Same goes for items. API calls fail manually as expected, but I can create conflicting items through special pages. I also confirm that SingleEntitySourceServices::getTermSearchInteractorFactory and SingleEntitySourceServices::getPrefetchingTermLookup need fixing. Will be working on that this evening.

Jan 6 2020, 11:07 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

I added two test cases to the integration test editentity fingerprint uniqueness. They pass for API calls, which I could also confirm sending API requests manually.

Jan 6 2020, 10:33 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Jan 5 2020

sarhan.alaa moved T232040: Add label and description collision detectors for new terms store from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

While reviewing https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/553524/ I noticed that both at least 2 more things need fixing:

  • SingleEntitySourceServices::getTermSearchInteractorFactory
  • SingleEntitySourceServices::getPrefetchingTermLookup

Until that happens its hard to really verify the final patch etc.

Jan 5 2020, 2:30 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Dec 30 2019

sarhan.alaa updated sarhan.alaa.
Dec 30 2019, 12:46 PM
sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

If reviewing the patch in the current state is too much effort or difficult (it can be very much the case), also let me know I can try to split it up further into couple of smaller patches

Dec 30 2019, 12:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

@Addshore @Ladsgroup
Are we waiting on this until we start reading a range (first 1000 items iirc) from new store? Is there more code review to be done?

Dec 30 2019, 12:37 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Dec 19 2019

sarhan.alaa moved T232040: Add label and description collision detectors for new terms store from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 19 2019, 10:46 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

Not sure @Ladsgroup your comments in the review do make sense.. can you please double check them and read through the code again? I may of course have misunderstood them, maybe little more elaboration will help

Dec 19 2019, 10:46 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Dec 12 2019

sarhan.alaa added a comment to T232040: Add label and description collision detectors for new terms store.

Last patch turning on validation of uniqueness in new store is ready for review now
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/553524
It has 3 little fixes below it too

Dec 12 2019, 9:49 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa updated the task description for T232040: Add label and description collision detectors for new terms store.
Dec 12 2019, 9:48 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Dec 10 2019

Addshore awarded T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors a Like token.
Dec 10 2019, 10:53 AM · Gerrit-Privilege-Requests
sarhan.alaa claimed T232040: Add label and description collision detectors for new terms store.
Dec 10 2019, 9:52 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
sarhan.alaa added a comment to T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors.

Added. It is not really difficult :). I believe you can even do so with your employee account if you wanted to.

Dec 10 2019, 9:43 AM · Gerrit-Privilege-Requests
sarhan.alaa updated subscribers of T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors.
Dec 10 2019, 9:19 AM · Gerrit-Privilege-Requests
sarhan.alaa updated the task description for T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors.
Dec 10 2019, 9:18 AM · Gerrit-Privilege-Requests
sarhan.alaa updated the task description for T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors.
Dec 10 2019, 9:18 AM · Gerrit-Privilege-Requests
sarhan.alaa updated the task description for T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors.
Dec 10 2019, 9:17 AM · Gerrit-Privilege-Requests
sarhan.alaa created T240321: Add Alaa Sarhan (gerrit `sarhan`) to Trusted-Contributors.
Dec 10 2019, 9:16 AM · Gerrit-Privilege-Requests
sarhan.alaa archived User-Alaa.
Dec 10 2019, 9:03 AM

Nov 8 2019

sarhan.alaa closed T228668: Draft definition of "Ready to Estimate" for Wikibase board as Invalid.
Nov 8 2019, 9:10 PM · User-Alaa
sarhan.alaa closed T228624: Go over tasks in wikidata boards and assign BUG sub-type appropriately as Invalid.
Nov 8 2019, 9:09 PM · User-Alaa
sarhan.alaa closed T228667: Write up some guidelines for iteration board task flow as Invalid.
Nov 8 2019, 9:07 PM · User-Alaa
sarhan.alaa closed T228494: Go over and clean up tasks in campsite iteration To Do column as Resolved.
Nov 8 2019, 9:06 PM · User-Alaa
sarhan.alaa closed T228493: Add ToDo definition to Wikidata Campsite iteration board description as Resolved.
Nov 8 2019, 9:06 PM · User-Alaa
sarhan.alaa closed T228665: Review tasks before story time as Resolved.
Nov 8 2019, 9:06 PM · User-Alaa
sarhan.alaa closed T228599: Apply for US visa as Resolved.
Nov 8 2019, 9:06 PM · User-Alaa
sarhan.alaa closed T230630: Prepare case for RL/Webpack trailblazing as Resolved.
Nov 8 2019, 9:05 PM · User-Alaa
sarhan.alaa closed T231081: Take notes from Moving Data Item link as Resolved.
Nov 8 2019, 9:05 PM · User-Alaa
sarhan.alaa closed T228495: Check Phabricator API for setting up some team lead-time and throughput metrics as Resolved.
Nov 8 2019, 9:05 PM · User-Alaa
sarhan.alaa closed T233757: Remove inheritance of private Test class from external library in Wikibase as Invalid.
Nov 8 2019, 9:02 PM · User-Alaa
sarhan.alaa moved T228495: Check Phabricator API for setting up some team lead-time and throughput metrics from Doing to Done on the User-Alaa board.
Nov 8 2019, 9:01 PM · User-Alaa
sarhan.alaa moved T232595: Make it possible to collapse the "All entered languages" section when at the end of the section from Test (Verification) to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

I guess this is still just in beta?

Nov 8 2019, 9:01 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata

Sep 24 2019

sarhan.alaa created T233757: Remove inheritance of private Test class from external library in Wikibase.
Sep 24 2019, 8:43 PM · User-Alaa

Aug 22 2019

sarhan.alaa added a comment to T230630: Prepare case for RL/Webpack trailblazing.

what kind of impact the solving of the issue will generate and why?

Aug 22 2019, 7:37 AM · User-Alaa
sarhan.alaa added a comment to T230630: Prepare case for RL/Webpack trailblazing.

who/what is suffering from it ?

problem one

  • developers productivity not catching up with modern javascript, making it become slower with time as the projects expands.
  • on boarding young developers increase in cost too as they need to get to learn and work with semi-outdated and limitef APIs and standardbof JS.
Aug 22 2019, 7:17 AM · User-Alaa
sarhan.alaa added a comment to T230630: Prepare case for RL/Webpack trailblazing.

what the current problem(s) are ?

problem one
we cannot use es5/6 features that are not supported by browsers yet and cannot be polyfilled in runtime (like URI api. ref: T117651: Align mediawiki.Uri more with the native URL constructor and <the one with browser.URI>)

Aug 22 2019, 7:04 AM · User-Alaa
sarhan.alaa updated the task description for T230630: Prepare case for RL/Webpack trailblazing.
Aug 22 2019, 6:50 AM · User-Alaa

Aug 21 2019

sarhan.alaa added a comment to T230926: Moved Wikidata Item link to Other Projects might break gadgets.

@WMDE-leszek that's great! I remember seeing it differently locally when I tested adding the id back a while back, or maybe I just assumed it will land on the a tag from the code (that seems to do some magic there). Either way, I should've waited and checked on beta :)

Aug 21 2019, 6:51 PM · Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
sarhan.alaa added a comment to T230926: Moved Wikidata Item link to Other Projects might break gadgets.

@Ladsgroup yeah probably.. There might still some that might break because the id now is on the a tag and not a wrapper element like it used to be.

Aug 21 2019, 5:26 PM · Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Jun 28 2019

sarhan.alaa added a comment to T215405: Extract Wikibase IdGenerator(s) into a library and use it in WikibaseSchema.

yeah we need some column for such cases.

Jun 28 2019, 9:14 PM · Wikidata-Trailblazing-Exploration, Librarization, User-Michael, Wikidata, Technical-Debt, Shape Expressions

Jun 6 2019

sarhan.alaa moved T224678: Feature request: ability to include labels for related entities in wbgetentities responses from incoming to needs discussion or investigation on the Wikidata board.
Jun 6 2019, 4:43 PM · User-Alaa, Wikipedia-Android-App-Backlog, Product-Infrastructure-Team-Backlog, Wikidata, MediaWiki-extensions-WikibaseRepository

May 25 2019

sarhan.alaa closed T223856: Improve documentation for WMDE's Wikibase Docker images repository as Resolved.

Thanks @waldyrious very much for your contribution on the spot!

May 25 2019, 6:06 PM · Wikidata, Documentation, Wikibase-Containers, Wikimedia-Hackathon-2019

Apr 13 2019

sarhan.alaa removed a project from T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
Apr 13 2019, 7:09 AM · Wikidata-Campsite, Wikidata
sarhan.alaa placed T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text up for grabs.
Apr 13 2019, 7:08 AM · Wikidata-Campsite, Wikidata
sarhan.alaa moved T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text from incoming to ready to go on the Wikidata board.

Moved back to be briefly discussed, estimated and broken down.

Apr 13 2019, 7:08 AM · Wikidata-Campsite, Wikidata
sarhan.alaa updated the task description for T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.
Apr 13 2019, 7:05 AM · Wikidata-Campsite, Wikidata
sarhan.alaa updated the task description for T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.
Apr 13 2019, 7:03 AM · Wikidata-Campsite, Wikidata
sarhan.alaa added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

Wow in minutes .. it took a query on wb_terms >5 minutes to get 50 results only. Same on Query Service. How did you find those?

Apr 13 2019, 6:45 AM · Wikidata-Campsite, Wikidata

Apr 11 2019

sarhan.alaa added a comment to T220150: [Story] Clean up unused records.

oh yeah sure that won't be running in production like that .. I just was wondering if there are any extra optimization here that I could've missed re using indexes or using the sub-queries.

Apr 11 2019, 7:30 PM · Wikidata, Wikidata wb_terms Trailblazing

Mar 26 2019

sarhan.alaa awarded T219134: `text.trim is not a function` in node selenium tests blocking Wikibase CI; blocking test/merge in WB/WBL/WBMI/etc. a Cookie token.
Mar 26 2019, 9:24 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Wikidata Lexicographical data, WikibaseMediaInfo, Wikimedia-production-error (ARCHIVED -- Shared Build Failure), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Feb 20 2019

sarhan.alaa added a comment to T214471: wdio browser tests fail locally due to session not being persisted before 2nd stage of login starts.

yes I did. I should add that the only teats failing for me now are WikibaseLexeme ones, specifically mwbot logins. There is an invalid edit token (+\\ feels truncated or smth) being stored and reused by the test sometimes, causing Invalid CSRF Token error.

Feb 20 2019, 7:16 AM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Wikimedia-production-error (ARCHIVED -- Shared Build Failure), User-Addshore, MediaWiki-Authentication-and-authorization, Release-Engineering-Team (Kanban), MediaWiki-Core-Testing, User-zeljkofilipin

Jan 22 2019

sarhan.alaa added a watcher for Wikimedia-Hackathon-2019: sarhan.alaa.
Jan 22 2019, 2:39 PM