@Amire80, how about the comment below? Thx.
Fri, Feb 21
Some explorations for Android below:
Thanks @Dbrant for your hard work on this. The updated tags/colors for all themes are perfectly implemented!
Thu, Feb 20
All the screenshots are currently in translation review by various WMF employees. Updates soon.
Wed, Feb 19
@Dbrant, here’s the promised update in regards to:
Mon, Feb 17
Ok thx Amir, the bulk of your feedback has been distributed to newly created or ongoing Phab tasks:
Hey @Dbrant, currently design reviewing two possible solutions for the tags:
Wed, Feb 12
Moving it to QA signoff! 🎉
You nailed it @Dbrant! Damn, it feels so clean now 😍Moving it to QA signoff...
This is in fact the default styling of the system component that we're using. I don't see a clear way of customizing it to have the exact padding that we want.
Adding cryptic notes from my conversation with @Amire80 this morning. Will process them soon. Also, feel free to just drop screenshots here @Amire80. Thanks so much for your time, looking forward to our next session!
Bringing this to your attention in case your checking in with product infrastructure soon @Charlotte.
Tue, Feb 11
I’m positively surprised by the 14.84% that come from the Explore feed. I think we should continue to create cards for the feed, as people are using it and it doesn’t hurt. Do you agree @Charlotte? Will create designs for it today/tomorrow in T244866.
For the sake of completion: Scheduled a session with @Amire80 for this! Updates will follow soon...
The trick is to add the width of the checkmark to the inital (loading) size of the tag so it won’t change its size when it’s enabled.
A big plus would be a subtle animation (text animates to the right when tick is added, as seen on the video above)
I'm afraid this is not how the Material Chip component works. We could potentially show a different icon when it's unchecked versus when it's checked, but not this kind of manipulation.
Ok, thanks @Dbrant! Checked it out. Two things:
Mon, Feb 10
Great work, thanks! Moving this to QA signoff...
Current status of the back functionality is discussed in T240196#5865593.
can we make the whole list item a tap target to make tapping an item more accessible?
I'm afraid it's not possible to make the whole item clickable, while also making the links within the text clickable.
I wasn’t able to check out the snackbar. Tried it with three different accounts but it wasn’t showing up.
Thanks @Dbrant, looks good in all 4 themes! Only one thing: Currently, tapping the back button in the onboarding screen leads users to the image tag experience. It should take users back to Suggested edits home! If that is fixed, it’s good to go...
Everything in regards to animation has been mentioned in T240196#5865593:
Wow, it’s already an experience @Dbrant 👏Spotted a few things yet to optimize! 👇
Looks good so far! Two things:
Thanks @Dbrant. The issues mentioned in T230047#5822758 are fixed, but tapping an element currently does not scroll to the corresponding element (tested in 2.7.50309-alpha-2020-02-06). It closes the references bottom sheet and stays at the same position. Plus: can we make the whole list item a tap target to make tapping an item more accessible? Of course, the links in an item should still be tappable too.
Fri, Feb 7
Related comment on OTRS about the Russian Play Store listing that mentions Wikipedia Zero: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11290811
Jan 22 2020
Thanks for working on this @Dbrant. A few comments below:
Jan 16 2020
Hey @Charlotte, no blocker to go forward with this on Android from the design team. We might have to think about more educational UI elements or be more clear if we continue to have issues with it.
Jan 15 2020
Thanks @cooltey. Your proposed solution for article descriptions is perfectly fine, since the article text is the center of the task, not the image.
Thanks for taking this on @Charlotte.
Jan 14 2020
Thanks @cooltey, looks clean already... 😳 In regards to:
Jan 13 2020
Updated the task’s description @Charlotte 👍