Page MenuHomePhabricator

sguebo_WMF (Samuel Guebo)
Sr. Privacy Engineer (Security Team)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 10 2018, 4:17 PM (289 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Samuel (WMF) [ Global Accounts ]

Recent Activity

Thu, Feb 1

sguebo_WMF closed T312819: right-* messages contain wikitext but User::getRightDescription() returns them as plaintext as Resolved.
Thu, Feb 1, 5:19 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, MediaWiki-Platform-Team, good first task, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth, I18n
sguebo_WMF closed T217211: Rename jobs should log error details as Resolved.
Thu, Feb 1, 5:17 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), MediaWiki-extensions-CentralAuth, GlobalRename
sguebo_WMF closed T217211: Rename jobs should log error details, a subtask of T157850: Interacting with Wikimedia logs should be a pleasant experience, as Resolved.
Thu, Feb 1, 5:17 AM · Observability-Logging, Epic, WMF-General-or-Unknown

Jan 25 2024

sguebo_WMF claimed T217211: Rename jobs should log error details.
Jan 25 2024, 4:06 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), MediaWiki-extensions-CentralAuth, GlobalRename

Jan 21 2024

sguebo_WMF updated Other Assignee for T217211: Rename jobs should log error details, added: sguebo_WMF.
Jan 21 2024, 3:12 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), MediaWiki-extensions-CentralAuth, GlobalRename

Dec 16 2023

sguebo_WMF closed T312323: Migrate usage of Database::select to SelectQueryBuilder in BetaFeatures, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Resolved.
Dec 16 2023, 2:24 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
sguebo_WMF closed T312323: Migrate usage of Database::select to SelectQueryBuilder in BetaFeatures as Resolved.
Dec 16 2023, 2:24 AM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), BetaFeatures, Technical-Debt

Dec 14 2023

sguebo_WMF claimed T312323: Migrate usage of Database::select to SelectQueryBuilder in BetaFeatures.
Dec 14 2023, 7:42 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), BetaFeatures, Technical-Debt

Dec 8 2023

sguebo_WMF added a comment to T352563: Add some type of percentage indicator for new, high-level categories within risk assessment matrix.

I was able to include the high-level category and presented the relevant data in a heatmap-like fashion. Although I did not include any percentage to avoid visual cluttering, I think the heatmap colors convey a sense of where exactly the most concerning areas. Kindly take a look at the WIP_Matrix sheet and let me know what your thoughts are.

Dec 8 2023, 6:13 AM · SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment

Dec 7 2023

sguebo_WMF added a comment to T312819: right-* messages contain wikitext but User::getRightDescription() returns them as plaintext.

Perhaps it makes sense to use Message::parse() in directly in User::getRightDescription(). It could be redundant for Special:ListGrants et al. since there is also some parsing happening there but at least it would prevent wikitext from being displayed as raw text. I'll submit a patch in line with this.

Dec 7 2023, 8:15 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, MediaWiki-Platform-Team, good first task, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth, I18n
sguebo_WMF claimed T312819: right-* messages contain wikitext but User::getRightDescription() returns them as plaintext.
Dec 7 2023, 8:14 AM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, MediaWiki-Platform-Team, good first task, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth, I18n

Dec 1 2023

sguebo_WMF changed the status of T352563: Add some type of percentage indicator for new, high-level categories within risk assessment matrix from Open to In Progress.
Dec 1 2023, 7:34 PM · SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment
sguebo_WMF changed the status of T352563: Add some type of percentage indicator for new, high-level categories within risk assessment matrix, a subtask of T343366: [EPIC] Production Risk Assessment Work - Phase 2, from Open to In Progress.
Dec 1 2023, 7:34 PM · Epic, user-sbassett, SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment
sguebo_WMF added a comment to T352563: Add some type of percentage indicator for new, high-level categories within risk assessment matrix.

The color-coding approach using Gsheet formulas seems reasonable and fairly straightforward to implement. The current table format is suited for color-coding each individual health check metric row based on its score. However, if we need to include the high-level headings to the table, I'd need to think of a good way to feature both the individual row color-code and the high-level heading color-code while avoiding visual confusion or cluttering. I'll give it some thought and try something.

Dec 1 2023, 7:34 PM · SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment
sguebo_WMF awarded T348781: Add higher-level organizational header names to the risk matrix Google sheets a Like token.
Dec 1 2023, 7:23 PM · Security-Team, SecTeam-Processed, Code-Health, Security, Security Team AppSec, production-risk-assessment

Nov 15 2023

sguebo_WMF moved T335892: Get stats on Gadgets and Users scripts loading third-party resources from Incoming to Backlog on the Privacy Engineering board.
Nov 15 2023, 5:10 PM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum

Nov 14 2023

sguebo_WMF awarded T349910: Enable the TagManager plugin for Matomo a Like token.
Nov 14 2023, 6:51 PM · Data-Engineering, SecTeam-Processed, Privacy Engineering, Data-Platform-SRE

Nov 13 2023

sguebo_WMF added a comment to T349910: Enable the TagManager plugin for Matomo.

Hi, all — I’ll share here a joint privacy review of the two proposed changes: enabling the TagManager and the Marketing Campaign Reporting plugins, as well as a succinct privacy risk assessment of the self-hosted Matomo instance, although it wasn’t specifically requested.

Nov 13 2023, 2:18 AM · Data-Engineering, SecTeam-Processed, Privacy Engineering, Data-Platform-SRE

Nov 12 2023

sguebo_WMF changed the status of T348782: Re-evaluate the weighting of the various risk factors from Open to In Progress.
Nov 12 2023, 3:01 AM · SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment
sguebo_WMF changed the status of T348782: Re-evaluate the weighting of the various risk factors, a subtask of T343366: [EPIC] Production Risk Assessment Work - Phase 2, from Open to In Progress.
Nov 12 2023, 3:00 AM · Epic, user-sbassett, SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment
sguebo_WMF added a comment to T348782: Re-evaluate the weighting of the various risk factors.

@sbassett I proposed some changes in a new PR. I've seen some linting issues but I'll look into it a bit later. For now, I'd be curious to know whether I am going in the right direction. So let me know when you get the chance to look at the code.

Nov 12 2023, 3:00 AM · SecTeam-Processed, Code-Health, Security, Security Team AppSec, Security-Team, production-risk-assessment

Oct 30 2023

sguebo_WMF moved T142275: Owner-only consumers should not expose the user's email address from Incoming to Watching on the Privacy Engineering board.
Oct 30 2023, 2:44 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, Privacy Engineering, MediaWiki-Platform-Team, MediaWiki-extensions-OAuth

Oct 13 2023

sguebo_WMF added a comment to T348781: Add higher-level organizational header names to the risk matrix Google sheets.

I've given it a try in the sheet COPY_High-level indicators and grouped the factors under 4 high-level indicators: security, testability, activity, and stewardship. These indicators are mainly inspired by our Mediawiki documentation on Codehealth[1][2] and some external resources[3].

Oct 13 2023, 10:40 PM · Security-Team, SecTeam-Processed, Code-Health, Security, Security Team AppSec, production-risk-assessment
sguebo_WMF added a comment to T348781: Add higher-level organizational header names to the risk matrix Google sheets.

I had another thought about this requirement. Besides the higher level organizational header names, it would be helpful if the risk of those columns could be collectively expressed by a single value.

Oct 13 2023, 8:56 PM · Security-Team, SecTeam-Processed, Code-Health, Security, Security Team AppSec, production-risk-assessment

Oct 12 2023

sguebo_WMF added a comment to T348781: Add higher-level organizational header names to the risk matrix Google sheets.

@acooper I think I need edit privileges to modify the sheet. I'd like to make a copy of the 'Matrix' sheet and tweak it.

I think you should have access to both of the linked Google sheets now.

Oct 12 2023, 9:24 PM · Security-Team, SecTeam-Processed, Code-Health, Security, Security Team AppSec, production-risk-assessment
sguebo_WMF added a comment to T348781: Add higher-level organizational header names to the risk matrix Google sheets.

@acooper I think I need edit privileges to modify the sheet. I'd like to make a copy of the 'Matrix' sheet and tweak it.

Oct 12 2023, 8:48 PM · Security-Team, SecTeam-Processed, Code-Health, Security, Security Team AppSec, production-risk-assessment
sguebo_WMF claimed T348781: Add higher-level organizational header names to the risk matrix Google sheets.
Oct 12 2023, 8:28 PM · Security-Team, SecTeam-Processed, Code-Health, Security, Security Team AppSec, production-risk-assessment

Sep 18 2023

sguebo_WMF placed T275754: Fix (non-default) gadgets loading executable JavaScript from third-party URLs up for grabs.
Sep 18 2023, 5:12 PM · WMF-General-or-Unknown, Privacy, Privacy Engineering
sguebo_WMF placed T65598: Privacy issues with Gadget-GoogleTrans.js (calls out to google APIs) up for grabs.
Sep 18 2023, 5:11 PM · Security, Privacy Engineering, WMF-General-or-Unknown, Privacy

Aug 30 2023

sguebo_WMF updated subscribers of T264814: Add a column for the blocks in WikiStats.

Hey @RhinosF1, I don't fully recall the use case that T&S had in mind back then. I'll defer to @jrbs to clarify whether this work is something that's still needed.

Aug 30 2023, 5:36 PM · VPS-project-Wikistats, Trust-and-Safety

Jul 18 2023

sguebo_WMF closed T337863: Gather feedback on TPR policy through meta-wiki consultation as Resolved.
Jul 18 2023, 12:33 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF closed T337863: Gather feedback on TPR policy through meta-wiki consultation, a subtask of T296847: Third-party resources policy, as Resolved.
Jul 18 2023, 12:33 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Jun 29 2023

SD_hehua awarded T335892: Get stats on Gadgets and Users scripts loading third-party resources a Dislike token.
Jun 29 2023, 1:50 PM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum

Jun 5 2023

sguebo_WMF updated the task description for T337863: Gather feedback on TPR policy through meta-wiki consultation.
Jun 5 2023, 11:29 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T296847: Third-party resources policy.

The policy draft is now publicly available for feedback on meta-wiki. Hope to hear your thoughts there!

Jun 5 2023, 10:18 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T335892: Get stats on Gadgets and Users scripts loading third-party resources.

my main point is that since we now have the stats above, and they point out fonts as among the main third-party resources people load, we should make sure we try to address that in some way (find a reasonable way to enable that use case without unreasonably raising the risk). It's currently bright-line prohibited, but the fontcdn solution has properties that reduce that risk to what I assert is an acceptable level. It's just not zero, which is what the current bright-line policy requires.

Jun 5 2023, 9:55 AM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum

Jun 3 2023

sguebo_WMF updated the task description for T337863: Gather feedback on TPR policy through meta-wiki consultation.
Jun 3 2023, 1:23 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

May 31 2023

sguebo_WMF updated the task description for T337863: Gather feedback on TPR policy through meta-wiki consultation.
May 31 2023, 3:06 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF updated the task description for T337863: Gather feedback on TPR policy through meta-wiki consultation.
May 31 2023, 2:58 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF updated the task description for T337863: Gather feedback on TPR policy through meta-wiki consultation.
May 31 2023, 2:57 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T296847: Third-party resources policy.

Hello — just a heads up that the policy draft will be released publicly for discussion next week, on June 5th, as part of the official consultation. When the policy discussion opens, there will be an announcement through the usual channels: wikimedia-l, IRC, etc. You can find more details about the upcoming steps and dates of the consultation in the subtask T337863.

May 31 2023, 2:40 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF changed the status of T337863: Gather feedback on TPR policy through meta-wiki consultation, a subtask of T296847: Third-party resources policy, from Open to In Progress.
May 31 2023, 2:37 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF changed the status of T337863: Gather feedback on TPR policy through meta-wiki consultation from Open to In Progress.
May 31 2023, 2:37 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF updated the task description for T337863: Gather feedback on TPR policy through meta-wiki consultation.
May 31 2023, 2:36 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF created T337863: Gather feedback on TPR policy through meta-wiki consultation.
May 31 2023, 2:36 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF claimed T296847: Third-party resources policy.
May 31 2023, 1:15 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

May 30 2023

sguebo_WMF added a comment to T334761: Clickwrap Agreement.

Hey @ldelench_wmf, the Security team's review is complete. You'll find below our feedback:

May 30 2023, 12:56 PM · User-Iflorez, Campaign-Tools (Campaign-Tools-Current-Sprint), CampaignEvents, Campaign-Registration

May 17 2023

sguebo_WMF changed the status of T296847: Third-party resources policy from Open to In Progress.
May 17 2023, 5:37 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

May 8 2023

sguebo_WMF moved T325663: Audit use of cookies #2 from Incoming to In Progress on the Privacy Engineering board.
May 8 2023, 11:37 AM · Privacy Engineering, WMF-General-or-Unknown

May 4 2023

Aklapper awarded T335892: Get stats on Gadgets and Users scripts loading third-party resources a Love token.
May 4 2023, 12:22 PM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T335892: Get stats on Gadgets and Users scripts loading third-party resources.

Either a separate column, or a separate table is fine; I think there may be some exceptions to add as well, for example the page https://meta.wikimedia.org/wiki/MediaWiki:Gadget-common-special-search.js is on the list above, pointing to a yandex.ru link, however it isn't actually importing that, that is inside a comment - not sure how much effort would be needed or what the expected benefit of excluding comments would be

May 4 2023, 10:44 AM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF changed the status of T335892: Get stats on Gadgets and Users scripts loading third-party resources, a subtask of T296847: Third-party resources policy, from Open to In Progress.
May 4 2023, 10:31 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF changed the status of T335892: Get stats on Gadgets and Users scripts loading third-party resources from Open to In Progress.
May 4 2023, 10:31 AM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum

May 3 2023

sguebo_WMF added a comment to T335892: Get stats on Gadgets and Users scripts loading third-party resources.

Can the stats table be split by userscripts and gadgets? The later certainly have far more exposure, esp when counting userscripts of defunct users in the user table.

May 3 2023, 6:01 PM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T296847: Third-party resources policy.

Hey there -- just a heads-up that I have started compiling some data on Gadgets and User scripts loading third-party resources across Wikimedia projects in T335892. This may help get a sense of the impact of the policy. The initial data is probably off/incomplete. So any ideas to get more accurate data is warmly welcome :)

May 3 2023, 5:21 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF created T335892: Get stats on Gadgets and Users scripts loading third-party resources.
May 3 2023, 5:15 PM · WMF-General-or-Unknown, affects-Miraheze, SecTeam-Processed, Privacy Engineering, tech-decision-forum

Mar 30 2023

sguebo_WMF added a comment to T322751: Design: Design how to present all PII information collected from participants to organizers (on desktop and mobile).

My recommendation from a data privacy perspective is to show aggregated data only and keep the PII in the back end for 90 days, during which time participants can update their answers, after which time we anonymize the PII data and keep only the aggregated data.
As far as aggregated data, I recommend reporting out when we have more than x persons in a [sub]category; below that we could either not report out or report, for example a compilation "other <x"

Mar 30 2023, 7:15 PM · Campaign-Tools, CampaignEvents, Campaign-Registration

Mar 28 2023

sguebo_WMF added a comment to T322751: Design: Design how to present all PII information collected from participants to organizers (on desktop and mobile).

Usually, with PII data on persons we set a minimum for calculating averages so the data cannot be disambiguated and persons identified.
Essentially, such data should not be disaggregated at small numbers. There may be a standard at 10, that is usually 20 though for power to detect differences. So, for example, if you have <10 persons in a [sub] category then you don't report out on that [sub] category.
Security and GDI teams may be able to provide additional insights and feedback.

Hey @Iflorez, how will that work if event organizers are able to view data at an individual level anyway (F35861130)? Will the detailed view of the Participants tab be unavailable once data is aggregated, after the 90-day window?

Mar 28 2023, 12:33 PM · Campaign-Tools, CampaignEvents, Campaign-Registration

Mar 7 2023

sguebo_WMF added a comment to T296847: Third-party resources policy.

@sguebo_WMF given that the TPR policy is being proposed to be incorporated by reference into the terms of use, i think there is a desire for there to at least be a public draft, if not the final policy, prior to the comment period for the terms of use ammendments closing.

Mar 7 2023, 12:23 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T273220: Deploy StopForumSpam extension to production.

Thanks for the ping @sbassett. We could borrow some ideas from the generic message currently displayed when logged in users visit external links, and a privacy notice(T65598#6914486) which was provided by WMF-Legal. Privacy best practices encourage both brevity and clarity of notices. So, a more privacy-conscious message could be something along these lines:

Mar 7 2023, 10:44 AM · Privacy Engineering, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Security-Team, user-sbassett, User-notice, Wikimedia-Extension-setup, MediaWiki-extensions-StopForumSpam
sguebo_WMF moved T273220: Deploy StopForumSpam extension to production from Incoming to Completed on the Privacy Engineering board.
Mar 7 2023, 10:44 AM · Privacy Engineering, MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Security-Team, user-sbassett, User-notice, Wikimedia-Extension-setup, MediaWiki-extensions-StopForumSpam

Mar 6 2023

sguebo_WMF added a comment to T296847: Third-party resources policy.

Hey everyone, I agree that having the Security-Team review every single Gadgets and User script would not be scalable or even realistic.

Mar 6 2023, 11:43 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF moved T324989: Application Security Review Request : OurWorldInData from Incoming to In Progress on the Privacy Engineering board.
Mar 6 2023, 10:01 AM · Wikimedia-Medicine, Privacy Engineering, Application Security Reviews
sguebo_WMF added a comment to T324989: Application Security Review Request : OurWorldInData.

Tagging Privacy Engineering for an opinion/risk rating about the following. I'm not certain there's precedent for this on Wikimedia production or that wmcs would completely satisfy any privacy concerns for proposed, embedded content like this.

Mar 6 2023, 9:45 AM · Wikimedia-Medicine, Privacy Engineering, Application Security Reviews

Mar 3 2023

sguebo_WMF added a comment to T324989: Application Security Review Request : OurWorldInData.

Hello @Skizzerz, is there a publicly accessible repository for the source code of https://owidm.wmcloud.org?

Mar 3 2023, 1:22 PM · Wikimedia-Medicine, Privacy Engineering, Application Security Reviews

Feb 10 2023

sguebo_WMF updated sguebo_WMF.
Feb 10 2023, 12:07 PM

Nov 28 2022

sguebo_WMF added a comment to T312898: NDA tool should treat `~` as a symbol, not a non-Latin character.

@jrbs was added as a maintainer to the NDA bot, see (https://toolsadmin.wikimedia.org/tools/id/tsbot). Also, the code was moved the Wikimedia's Gitlab instance: https://gitlab.wikimedia.org/repos/security/tsbot-nda

Nov 28 2022, 12:30 PM · Trust-and-Safety
sguebo_WMF closed T312903: Move github.com/samuelguebo/tsbot-nda to Wikimedia code hosting as Resolved.
Nov 28 2022, 12:27 PM · Trust and Safety Tools Team Backlog
sguebo_WMF added a comment to T312903: Move github.com/samuelguebo/tsbot-nda to Wikimedia code hosting.

The repository was imported to Wikimedia's Gitlab instance: https://gitlab.wikimedia.org/repos/security/tsbot-nda

Nov 28 2022, 12:26 PM · Trust and Safety Tools Team Backlog

Nov 24 2022

sguebo_WMF moved T65598: Privacy issues with Gadget-GoogleTrans.js (calls out to google APIs) from Waiting to Watching on the Privacy Engineering board.
Nov 24 2022, 8:47 AM · Security, Privacy Engineering, WMF-General-or-Unknown, Privacy
sguebo_WMF moved T259421: WordPress blogs load (unused) Twemoji.js which uses third-party service from Waiting to Watching on the Privacy Engineering board.
Nov 24 2022, 8:47 AM · Privacy, Privacy Engineering, Technical Blog, wikimediafoundation.org
sguebo_WMF moved T65598: Privacy issues with Gadget-GoogleTrans.js (calls out to google APIs) from In Progress to Waiting on the Privacy Engineering board.
Nov 24 2022, 8:46 AM · Security, Privacy Engineering, WMF-General-or-Unknown, Privacy
sguebo_WMF moved T318838: netbox.wikimedia.org/metrics and netbox-next.wikimedia.org/metrics publicly expose prometheus and python metrics from Backlog to Completed on the Privacy Engineering board.
Nov 24 2022, 8:39 AM · Infrastructure-Foundations, Vuln-MissingAuthz, SecTeam-Processed, Privacy Engineering, SRE, Security, Security-Team
sguebo_WMF moved T322218: Create API to allow retrieving detailed information about Thanks log items for my own user account from Incoming to Completed on the Privacy Engineering board.
Nov 24 2022, 6:52 AM · Growth-Team, Privacy Engineering, Thanks, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule
sguebo_WMF added a comment to T322218: Create API to allow retrieving detailed information about Thanks log items for my own user account.

I examined the proposed API through common privacy risk categories:

Nov 24 2022, 6:48 AM · Growth-Team, Privacy Engineering, Thanks, Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule

Nov 8 2022

sguebo_WMF added a comment to T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System.

Hey @ldelench_wmf, I have no objections to closing this one, thanks.

Nov 8 2022, 4:49 PM · Campaign-Tools, Campaign-Registration, Privacy Engineering

Nov 1 2022

sguebo_WMF added a comment to T296847: Third-party resources policy.

Hello, some quick updates.

Nov 1 2022, 1:29 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Oct 25 2022

sguebo_WMF added a comment to T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System.

@ifried, the Security-Team hasn't gotten the chance to discuss the mitigating options surfaced in the Google Docs conversation. Meanwhile, I would like to keep the ticket open and update it once we've made some progress.

Oct 25 2022, 6:49 PM · Campaign-Tools, Campaign-Registration, Privacy Engineering

Oct 20 2022

sguebo_WMF moved T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System from Backlog to Waiting on the Privacy Engineering board.
Oct 20 2022, 4:35 PM · Campaign-Tools, Campaign-Registration, Privacy Engineering
sguebo_WMF added a comment to T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System.

Hey @ifried, the Privacy Engineering review is complete. Could you take a look at our conclusions and address any potential misunderstanding there? https://docs.google.com/document/d/1lFeq7jtUCmXdwoKwIfqgO-74ccTU0kBtX7zkJkeMByw/edit#?

Oct 20 2022, 4:07 PM · Campaign-Tools, Campaign-Registration, Privacy Engineering

Oct 14 2022

sguebo_WMF added a comment to T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System.

Hello @ifried, Privacy Engineering will start looking into this as part of our current sprint. On a side note, I am aware that the previous features have been looked at by WMF-Legal. For this additional feature, are you having any conversation with Legal in parallel?

Oct 14 2022, 7:54 PM · Campaign-Tools, Campaign-Registration, Privacy Engineering

Oct 12 2022

sguebo_WMF moved T320641: Security/Privacy Review For P&E Dashboard Integration with Campaign Registration System from Incoming to Backlog on the Privacy Engineering board.
Oct 12 2022, 4:00 PM · Campaign-Tools, Campaign-Registration, Privacy Engineering

Oct 4 2022

sguebo_WMF added a comment to T318838: netbox.wikimedia.org/metrics and netbox-next.wikimedia.org/metrics publicly expose prometheus and python metrics.

From a privacy angle, I see no concerns here. The output of https://netbox.wikimedia.org/metrics and https://toolhub.wikimedia.org/metrics does not appear to contain any identifying information.
@sbassett , let me know if I should leave a separate comment on T318839 or the parent ticket as well.

Oct 4 2022, 2:25 PM · Infrastructure-Foundations, Vuln-MissingAuthz, SecTeam-Processed, Privacy Engineering, SRE, Security, Security-Team

Aug 22 2022

sguebo_WMF awarded Blog Post: Creating a pentesting process a Like token.
Aug 22 2022, 12:42 PM · Security Team AppSec, Security

Jul 12 2022

sguebo_WMF added a comment to T312903: Move github.com/samuelguebo/tsbot-nda to Wikimedia code hosting.

@Aklapper, sure thing. It used to be a private repo which I was the sole maintainer when I was still in Trust-and-Safety. Moving it to GitLab makes sense but I am not sure which project would be suited for it. I don't currently see anything related to Trust & Safety. Any suggestion?

Jul 12 2022, 11:47 PM · Trust and Safety Tools Team Backlog
sguebo_WMF updated subscribers of T312903: Move github.com/samuelguebo/tsbot-nda to Wikimedia code hosting.
Jul 12 2022, 11:33 PM · Trust and Safety Tools Team Backlog
sguebo_WMF added a comment to T312898: NDA tool should treat `~` as a symbol, not a non-Latin character.

Merged and deployed lemme know if that fixed it - sorry didn't get the chance to test it live as I no longer have a TS account. Let me know if you have a tool account and I add you as a deployer. Once the PR is merged deploying is usually just ssh'ing and running a shell script that does all the git and kubernetes steps.

Jul 12 2022, 11:27 PM · Trust-and-Safety
sguebo_WMF added a comment to T312896: NDA tool does not respect the new "formerly" parameter.

Hey @jrbs, I think the issue might linger somewhere between these lines: https://github.com/samuelguebo/tsbot-nda/blob/6c05f844039d9713f3328d1e59c34aa29c80fa3b/routes/nda.py#L233-L284

Jul 12 2022, 9:09 PM · Trust-and-Safety

Mar 8 2022

sguebo_WMF changed the visibility for T65598: Privacy issues with Gadget-GoogleTrans.js (calls out to google APIs).
Mar 8 2022, 2:28 PM · Security, Privacy Engineering, WMF-General-or-Unknown, Privacy
sguebo_WMF added a comment to T65598: Privacy issues with Gadget-GoogleTrans.js (calls out to google APIs).

Thank you both.

Mar 8 2022, 2:27 PM · Security, Privacy Engineering, WMF-General-or-Unknown, Privacy

Mar 7 2022

sguebo_WMF added a project to T296847: Third-party resources policy: Security-Team.
Mar 7 2022, 12:54 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T65598: Privacy issues with Gadget-GoogleTrans.js (calls out to google APIs).

Hey @sbassett and @JFishback_WMF , do you have any strong objections to making this task public? Its content may inform the ongoing discussion around third-party resources in T296847.

Mar 7 2022, 12:01 PM · Security, Privacy Engineering, WMF-General-or-Unknown, Privacy

Mar 4 2022

sguebo_WMF added a comment to T296847: Third-party resources policy.

I'm confused by this problem statement. The Privacy Policy already forbids anything on Wikimedia projects that causes the UA to contact any third-party website, including Toolforge and WMCS, for any purpose (any HTTP header and the client IP are covered by the definition of "Personal information"). So regardless of whether it's executable code, an image, a webfont, JSON/JSONP data, etc. it is currently bright-line forbidden. What, then, would this "clear Wikimedia policy on the use of third-party resources" cover?

Mar 4 2022, 6:50 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T296847: Third-party resources policy.

We had an RFC open about this for a couple of years, which has some analysis and discussion of legitimate use cases and UX for opt-in: T208188: RFC: Partial opt-out method for Content security policy

Mar 4 2022, 6:08 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF added a comment to T296847: Third-party resources policy.

My current plan for rollout is as follows:

  • Informal feedback round (in progress)
  • Update policy based on feedback.
  • New more formal feedback round from WMF staff e.g. please respond by X date
  • Update policy based on feedback.
  • A formal round of feedback from the community.
  • We'll update the interface to provide a notice on pages where JS can be added that links to the policy:
<div class="mw-message-box mw-message-box-notice">All code written here is expected to <a href="#">adhere to the gadget policy</a>.</div>

Screen Shot 2022-02-16 at 11.07.18 AM.png (1×2 px, 461 KB)

Mar 4 2022, 6:03 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Feb 16 2022

sguebo_WMF added a comment to T296847: Third-party resources policy.

Following T262493#7584789 I've begun drafting a policy and collating feedback on the talk page:
https://www.mediawiki.org/wiki/User:Jdlrobson/Extension:Gadget/Policy

Perhaps we could combine efforts here?

Feb 16 2022, 3:19 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF triaged T296847: Third-party resources policy as Medium priority.
Feb 16 2022, 1:05 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum
sguebo_WMF moved T296847: Third-party resources policy from Backlog to In Progress on the Privacy Engineering board.
Feb 16 2022, 1:05 PM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Feb 15 2022

sguebo_WMF moved T290493: Cross Origin Resource Sharing Misconfiguration | Lead to sensitive information. in "diff.wikimedia.org" from Waiting to Completed on the Privacy Engineering board.
Feb 15 2022, 6:32 PM · Privacy Engineering, Privacy, Diff-blog, SecTeam-Processed, Security
sguebo_WMF added a comment to T290493: Cross Origin Resource Sharing Misconfiguration | Lead to sensitive information. in "diff.wikimedia.org".

As noted above, WordPress-powered websites such as Diff are used by the Foundation for public-facing initiatives. For instance, blog posts published on Diff feature names of their authors, and in most cases their titles within the organization. Although, the REST API allows people to retrieve the list of user accounts of the website, it generates list of already-public users, in JSON format that'll need to be parsed/processed. Therefore, the API is not disclosing any information that was not already private, nor is it increasing the visibility of information that was already public by making it easier to retrieve.

Feb 15 2022, 6:32 PM · Privacy Engineering, Privacy, Diff-blog, SecTeam-Processed, Security